[PATCH v3 net] r8169: work around RTL8125 UDP hw bug

2021-01-27 Thread Heiner Kallweit
It was reported that on RTL8125 network breaks under heavy UDP load, e.g. torrent traffic ([0], from comment 27). Realtek confirmed a hw bug and provided me with a test version of the r8125 driver including a workaround. Tests confirmed that the workaround fixes the issue. I modified the original v

Re: [PATCH net] r8169: work around RTL8125 UDP hw bug

2021-01-27 Thread Heiner Kallweit
On 27.01.2021 23:48, Willem de Bruijn wrote: > On Wed, Jan 27, 2021 at 4:34 PM Heiner Kallweit wrote: >> >> On 27.01.2021 21:35, Willem de Bruijn wrote: >>> On Wed, Jan 27, 2021 at 3:32 PM Heiner Kallweit >>> wrote: On 27.01.2021 20:54, Willem de Bruijn wrote: > On Wed, Jan 27, 202

[PATCH net 1/1] netfilter: conntrack: Check offload bit on table dump

2021-01-27 Thread Roi Dayan
Currently, offloaded flows might be deleted when executing conntrack -L or cat /proc/net/nf_conntrack while rules being offloaded. Ct timeout is not maintained for offloaded flows as aging of offloaded flows are managed by the flow table offload infrastructure. Don't do garbage collection for offl

Re: [PATCH] ath9k: Add separate entry for LED triggers to fix module builds

2021-01-27 Thread Kalle Valo
Krzysztof Kozlowski wrote: > After commit 72cdab808714 ("ath9k: Do not select MAC80211_LEDS by > default") a configuration like: > - MAC80211_LEDS=y > - LEDS_CLASS=m > - NEW_LEDS=y > - ATH9K=y > leads to a build failure: > > /usr/bin/ld: drivers/net/wireless/ath/ath9k/gpio.o: in function

Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m

2021-01-27 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_ATH9K is built-in but LED support is in a loadable > module, both ath9k drivers fails to link: > > x86_64-linux-ld: drivers/net/wireless/ath/ath9k/gpio.o: in function > `ath_deinit_leds': > gpio.c:(.text+0x36): undefined reference to

Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-01-27 Thread Dmitry Vyukov
On Thu, Jan 28, 2021 at 3:43 AM Hillf Danton wrote: > > Init the u64 stats in order to avoid the lockdep prints on the 32bit > hardware like FTR this is not just to avoid lockdep prints, but also to prevent very real stalls in production. u64_stats_init initializes seqlock, if the uninitialized s

[PATCH mlx5-next v1] RDMA/mlx5: Cleanup the synchronize_srcu() from the ODP flow

2021-01-27 Thread Leon Romanovsky
From: Yishai Hadas Cleanup the synchronize_srcu() from the ODP flow as it was found to be a very heavy time consumer as part of dereg_mr. For example de-registration of 1 ODP MRs each with size of 2M hugepage took 19.6 sec comparing de-registration of same number of non ODP MRs that took 172

Re: Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-27 Thread Yongji Xie
On Thu, Jan 28, 2021 at 2:14 PM Jason Wang wrote: > > > On 2021/1/28 下午2:03, Yongji Xie wrote: > > + > > +static const struct file_operations vduse_domain_fops = { > > + .mmap = vduse_domain_mmap, > > + .release = vduse_domain_release, > > +}; > It's better to expl

Re: [PATCH net] net: hdlc_x25: Use qdisc to queue outgoing LAPB frames

2021-01-27 Thread Martin Schiller
On 2021-01-27 21:29, Xie He wrote: On Wed, Jan 27, 2021 at 2:14 AM David Laight wrote: If I read this correctly it adds a (potentially big) queue between the LAPB code that adds the sequence numbers to the frames and the hardware that actually sends them. Yes. The actual number of outgoing

Re: [Patch bpf-next v5 1/3] bpf: introduce timeout hash map

2021-01-27 Thread Cong Wang
On Wed, Jan 27, 2021 at 10:00 AM Alexei Starovoitov wrote: > > On Tue, Jan 26, 2021 at 11:00 PM Cong Wang wrote: > > > > ret = PTR_ERR(l_new); > > > > + if (ret == -EAGAIN) { > > > > + htab_unlock_bucket(htab, b, hash, flags); > > > > +

Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-27 Thread Jason Wang
On 2021/1/28 下午2:03, Yongji Xie wrote: + +static const struct file_operations vduse_domain_fops = { + .mmap = vduse_domain_mmap, + .release = vduse_domain_release, +}; It's better to explain the reason for introducing a dedicated file for mmap() here. To make the implementation of io

[PATCH net-next 2/2] net: ipv6: don't generate link local address on PUREIP device

2021-01-27 Thread Rocco Yue
PUREIP device such as ccmni does not need kernel to generate link-local address in any addr_gen_mode, generally, it shall use the IPv6 Interface Identifier, as provided by the GGSN, to create its IPv6 link-ocal Unicast Address. Signed-off-by: Rocco Yue --- net/ipv6/addrconf.c | 9 - 1 fi

[PATCH net-next 1/2] net: if_arp: add ARPHRD_PUREIP type

2021-01-27 Thread Rocco Yue
This patch add the definition of ARPHRD_PUREIP which can for example be used by mobile ccmni device as device type. ARPHRD_PUREIP means that this device doesn't need kernel to generate the link-local address in any addr_gen_mode. Signed-off-by: Rocco Yue --- include/uapi/linux/if_arp.h | 1 + 1

Re: Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Yongji Xie
On Thu, Jan 28, 2021 at 12:31 PM Jason Wang wrote: > > > On 2021/1/28 上午11:52, Yongji Xie wrote: > > On Thu, Jan 28, 2021 at 11:05 AM Jason Wang wrote: > >> > >> On 2021/1/27 下午5:11, Yongji Xie wrote: > >>> On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: > On 2021/1/20 下午2:52, Yongji Xie

Re: Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-27 Thread Yongji Xie
On Thu, Jan 28, 2021 at 12:27 PM Jason Wang wrote: > > > On 2021/1/27 下午4:50, Yongji Xie wrote: > > On Tue, Jan 26, 2021 at 4:09 PM Jason Wang wrote: > >> > >> On 2021/1/19 下午1:07, Xie Yongji wrote: > >>> This VDUSE driver enables implementing vDPA devices in userspace. > >>> Both control path

Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

2021-01-27 Thread Leon Romanovsky
On Wed, Jan 27, 2021 at 07:16:41PM -0400, Jason Gunthorpe wrote: > On Wed, Jan 27, 2021 at 10:17:56PM +, Saleem, Shiraz wrote: > > > Even with another core PCI driver, there still needs to be private > > communication channel between the aux rdma driver and this PCI > > driver to pass things li

Re: Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Yongji Xie
On Thu, Jan 28, 2021 at 11:08 AM Jens Axboe wrote: > > On 1/27/21 8:04 PM, Jason Wang wrote: > > > > On 2021/1/27 下午5:11, Yongji Xie wrote: > >> On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: > >>> > >>> On 2021/1/20 下午2:52, Yongji Xie wrote: > On Wed, Jan 20, 2021 at 12:24 PM Jason Wang

[PATCH v2] lan743x: fix endianness when accessing descriptors

2021-01-27 Thread Alexey Denisov
TX/RX descriptor ring fields are always little-endian, but conversion wasn't performed for big-endian CPUs, so the driver failed to work. This patch makes the driver work on big-endian CPUs. It was tested and confirmed to work on NXP P1010 processor (PowerPC). Signed-off-by: Alexey Denisov ---

[PATCH net 1/1] [PATCH net]bonding: check port and aggregator when select

2021-01-27 Thread Aichun Li
When the network service is repeatedly restarted in 802.3ad, there is a low probability that oops occurs. Test commands:systemctl restart network 1.crash: __enable_port():port->slave is NULL crash> bt PID: 2508692 TASK: 803e72a7ec80 CPU: 29 COMMAND: "kworker/u192:0" #0 [b13cb5c0]

Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Jason Wang
On 2021/1/28 上午11:52, Yongji Xie wrote: On Thu, Jan 28, 2021 at 11:05 AM Jason Wang wrote: On 2021/1/27 下午5:11, Yongji Xie wrote: On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: On 2021/1/20 下午2:52, Yongji Xie wrote: On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: On 2021/1/19 下午

Re: [PATCH V2 0/1] net: dsa: rtl8366rb: change type of jam tables

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 27 Jan 2021 02:06:31 +0100 you wrote: > I was trying to see if there were some Intel 8051 instructions in the > jam tables with Linus Walleij, when I noticed some oddities. > This patch's aim is to make the code mor

Re: [RFC v3 08/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-01-27 Thread Jason Wang
On 2021/1/27 下午4:50, Yongji Xie wrote: On Tue, Jan 26, 2021 at 4:09 PM Jason Wang wrote: On 2021/1/19 下午1:07, Xie Yongji wrote: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In th

Re: [PATCH iproute2-next v2 1/2] iplink: print warning for missing VF data

2021-01-27 Thread David Ahern
On 1/26/21 10:40 AM, Edwin Peer wrote: > The kernel might truncate VF info in IFLA_VFINFO_LIST. Compare the > expected number of VFs in IFLA_NUM_VF to how many were found in the > list and warn accordingly. > > Signed-off-by: Edwin Peer > --- > ip/ipaddress.c | 9 - > 1 file changed, 8 i

Re: [PATCH net-next v2 1/1] rtnetlink: extend RTEXT_FILTER_SKIP_STATS to IFLA_VF_INFO

2021-01-27 Thread David Ahern
On 1/26/21 10:40 AM, Edwin Peer wrote: > This filter already exists for excluding IPv6 SNMP stats. Extend its > definition to also exclude IFLA_VF_INFO stats in RTM_GETLINK. > > This patch constitutes a partial fix for a netlink attribute nesting > overflow bug in IFLA_VFINFO_LIST. By excluding th

[net] net: ip_tunnel: fix mtu calculation

2021-01-27 Thread Vadim Fedorenko
dev->hard_header_len for tunnel interface is set only when header_ops are set too and already contains full overhead of any tunnel encapsulation. That's why there is not need to use this overhead twice in mtu calc. Fixes: fdafed459998 ("ip_gre: set dev->hard_header_len and dev->needed_headroom pr

Re: [PATCH net-next 01/10] netdevsim: fib: Convert the current occupancy to an atomic variable

2021-01-27 Thread David Ahern
On 1/27/21 3:51 AM, Amit Cohen wrote: > > >> -Original Message- >> From: David Ahern >> Sent: Wednesday, January 27, 2021 6:33 >> To: Ido Schimmel ; netdev@vger.kernel.org >> Cc: da...@davemloft.net; k...@kernel.org; Amit Cohen ; >> Roopa Prabhu ; Donald >> Sharp ; Benjamin Poirier ; ml

Re: Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Yongji Xie
On Thu, Jan 28, 2021 at 11:05 AM Jason Wang wrote: > > > On 2021/1/27 下午5:11, Yongji Xie wrote: > > On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: > >> > >> On 2021/1/20 下午2:52, Yongji Xie wrote: > >>> On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: > On 2021/1/19 下午12:59, Xie Yongji

Re: [net-next 01/14] devlink: Add DMAC filter generic packet trap

2021-01-27 Thread Jakub Kicinski
On Tue, 26 Jan 2021 15:24:06 -0800 Saeed Mahameed wrote: > From: Aya Levin > > Add packet trap that can report packets that were dropped due to > destination MAC filtering. > > Signed-off-by: Aya Levin > Reviewed-by: Ido Schimmel > Reviewed-by: Moshe Shemesh > Reviewed-by: Tariq Toukan > Sig

Re: [PATCH net-next 10/10] selftests: netdevsim: Add fib_notifications test

2021-01-27 Thread David Ahern
On 1/26/21 6:23 AM, Ido Schimmel wrote: > From: Amit Cohen > > Add test to check fib notifications behavior. > > The test checks route addition, route deletion and route replacement for > both IPv4 and IPv6. > > When fib_notify_on_flag_change=0, expect single notification for route > addition/d

Re: [PATCHv17 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL

2021-01-27 Thread Hangbin Liu
On Wed, Jan 27, 2021 at 02:24:47PM -0800, John Fastabend wrote: > [...] > > > +{ > > + "ARG_CONST_MAP_PTR_OR_NULL: null pointer for ex_map", > > + .insns = { > > + BPF_MOV64_IMM(BPF_REG_1, 0), > > + /* bpf_redirect_map_multi arg1 (in_map) */ > > + BPF_LD_MAP_FD(BP

Re: [PATCH net-next 08/10] net: ipv6: Emit notification when fib hardware flags are changed

2021-01-27 Thread David Ahern
On 1/26/21 6:23 AM, Ido Schimmel wrote: > From: Amit Cohen > > After installing a route to the kernel, user space receives an > acknowledgment, which means the route was installed in the kernel, > but not necessarily in hardware. > > The asynchronous nature of route installation in hardware can

Re: [PATCH net-next 05/10] net: ipv4: Emit notification when fib hardware flags are changed

2021-01-27 Thread David Ahern
On 1/26/21 6:23 AM, Ido Schimmel wrote: > From: Amit Cohen > > After installing a route to the kernel, user space receives an > acknowledgment, which means the route was installed in the kernel, > but not necessarily in hardware. > > The asynchronous nature of route installation in hardware can

Re: [net 01/12] net/mlx5: Fix memory leak on flow table creation error flow

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Tue, 26 Jan 2021 15:43:34 -0800 you wrote: > From: Roi Dayan > > When we create the ft object we also init rhltable in ft->fgs_hash. > So in error flow before kfree of ft we need to destroy that rhltable. > > Fixes: 693c6

Re: [patch net-next v2] net: dsa: mv88e6xxx: Make global2 support mandatory

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 27 Jan 2021 01:32:10 +0100 you wrote: > Early generations of the mv88e6xxx did not have the global 2 > registers. In order to keep the driver slim, it was decided to make > the code for these registers optional. Ove

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-27 Thread Hangbin Liu
On Wed, Jan 27, 2021 at 11:43:30AM +0200, Nikolay Aleksandrov wrote: > > For IGMP, although you said they are different. In my understanding, when > > bridge mac changed, we need to re-join multicast group, while a gratuitous > > ARP is also needed. I couldn't find a reason why IGMP message is OK b

Re: [PATCH net v3] ibmvnic: Ensure that CRQ entry read are correctly ordered

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 27 Jan 2021 19:34:42 -0600 you wrote: > Ensure that received Command-Response Queue (CRQ) entries are > properly read in order by the driver. dma_rmb barrier has > been added before accessing the CRQ descriptor to ensure

Re: pull-request: mac80211-next 2021-01-27

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Wed, 27 Jan 2021 22:09:14 +0100 you wrote: > Hi Jakub, > > Alright ... let's try again, with two more fixes on top, one > for the virt_wifi deadlock and one for a minstrel regression > in the earlier patches. >

Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices

2021-01-27 Thread Jason Wang
On 2021/1/27 下午4:57, Stefano Garzarella wrote: On Wed, Jan 27, 2021 at 11:33:03AM +0800, Jason Wang wrote: On 2021/1/20 下午7:08, Stefano Garzarella wrote: On Wed, Jan 20, 2021 at 11:46:38AM +0800, Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: With VDUSE, we should be able to su

Re: UDP implementation and the MSG_MORE flag

2021-01-27 Thread Willem de Bruijn
On Wed, Jan 27, 2021 at 9:53 PM Willem de Bruijn wrote: > > On Tue, Jan 26, 2021 at 10:25 PM Willem de Bruijn > wrote: > > > > On Tue, Jan 26, 2021 at 5:00 PM Willem de Bruijn > > wrote: > > > > > > On Tue, Jan 26, 2021 at 4:54 PM Willem de Bruijn > > > wrote: > > > > > > > > On Tue, Jan 26, 20

Re: [net-next 01/12] can: gw: fix typo

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 27 Jan 2021 10:22:16 +0100 you wrote: > This patch fixes a typo found by codespell. > > Fixes: 94c23097f991 ("can: gw: support modification of Classical CAN DLCs") > Link: https://lore.kernel.org/r/20210127085529.

Re: pull-request: can-next 2021-01-27

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Wed, 27 Jan 2021 10:22:15 +0100 you wrote: > Hello Jakub, hello David, > > this is a pull request of 12 patches for net-next/master. > > The first two patches are by me and fix typos on the CAN gw protocol and t

Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Jens Axboe
On 1/27/21 8:04 PM, Jason Wang wrote: > > On 2021/1/27 下午5:11, Yongji Xie wrote: >> On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: >>> >>> On 2021/1/20 下午2:52, Yongji Xie wrote: On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: > On 2021/1/19 下午12:59, Xie Yongji wrote: >> Now w

Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-27 Thread Jason Wang
On 2021/1/27 下午5:11, Yongji Xie wrote: On Wed, Jan 27, 2021 at 11:38 AM Jason Wang wrote: On 2021/1/20 下午2:52, Yongji Xie wrote: On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: Now we have a global percpu counter to limit the recursion depth of

Re: [net-next] tipc: remove duplicated code in tipc_msg_create

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 27 Jan 2021 09:51:23 +0700 you wrote: > Remove a duplicate code checking for header size in tipc_msg_create() as > it's already being done in tipc_msg_init(). > > Acked-by: Jon Maloy > Signed-off-by: Hoang Huu Le

Re: UDP implementation and the MSG_MORE flag

2021-01-27 Thread Willem de Bruijn
On Tue, Jan 26, 2021 at 10:25 PM Willem de Bruijn wrote: > > On Tue, Jan 26, 2021 at 5:00 PM Willem de Bruijn > wrote: > > > > On Tue, Jan 26, 2021 at 4:54 PM Willem de Bruijn > > wrote: > > > > > > On Tue, Jan 26, 2021 at 9:58 AM Oliver Graute > > > wrote: > > > > > > > > Hello, > > > > > > >

Re: [PATCH net-next v2 0/2] net: bridge: multicast: per-port EHT hosts limit

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 26 Jan 2021 11:35:31 +0200 you wrote: > From: Nikolay Aleksandrov > > Hi, > This set adds a simple configurable per-port EHT tracked hosts limit. > Patch 01 adds a default limit of 512 tracked hosts per-port, sin

Re: [Patch bpf-next v5 1/3] bpf: introduce timeout hash map

2021-01-27 Thread Alexei Starovoitov
On Wed, Jan 27, 2021 at 2:48 PM Daniel Borkmann wrote: > > On 1/27/21 7:00 PM, Alexei Starovoitov wrote: > > On Tue, Jan 26, 2021 at 11:00 PM Cong Wang wrote: > ret = PTR_ERR(l_new); > + if (ret == -EAGAIN) { > + htab_unlock_bucket(hta

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-27 Thread Chris Mi
On 1/28/2021 7:03 AM, Saeed Mahameed wrote: On Wed, 2021-01-27 at 11:42 +0800, Chris Mi wrote: Could you please tell me what's sparse warnings you hit? https://patchwork.kernel.org/project/netdevbpf/patch/20210127101648.513562-1-...@nvidia.com/ build allmodconfig and build32 OK, I see. Thank

Re: [PATCH] neighbour: Prevent a dead entry from updating gc_list

2021-01-27 Thread Cong Wang
On Wed, Jan 27, 2021 at 8:55 AM Chinmay Agarwal wrote: > > Following race condition was detected: > - neigh_flush_dev() is under execution and calls > neigh_mark_dead(n) marking the neighbour entry 'n' as dead. > > - Executing: __netif_receive_skb() -> > __netif_receive_skb_core() -> arp_rcv() -

Re: [PATCH bpf-next v5 1/2] bpf: allow rewriting to ports under ip_unprivileged_port_start

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 27 Jan 2021 11:31:39 -0800 you wrote: > At the moment, BPF_CGROUP_INET{4,6}_BIND hooks can rewrite user_port > to the privileged ones (< ip_unprivileged_port_start), but it will > be rejected later on in the __inet_bi

Re: [PATCH v5 net-next] From: Petr Vandrovec

2021-01-27 Thread Andrew Lunn
On Wed, Jan 27, 2021 at 06:08:16PM -0800, Ronak Doshi wrote: > buf_info structures in RX & TX queues are private driver data that > do not need to be visible to the device. Although there is physical > address and length in the queue descriptor that points to these > structures, their layout is no

[PATCH v3 net-next] net: Remove redundant calls of sk_tx_queue_clear().

2021-01-27 Thread Kuniyuki Iwashima
The commit 41b14fb8724d ("net: Do not clear the sock TX queue in sk_set_socket()") removes sk_tx_queue_clear() from sk_set_socket() and adds it instead in sk_alloc() and sk_clone_lock() to fix an issue introduced in the commit e022f0b4a03f ("net: Introduce sk_tx_queue_mapping"). On the other hand,

Re: BUG: Incorrect MTU on GRE device if remote is unspecified

2021-01-27 Thread Vadim Fedorenko
On 28.01.2021 01:38, Cong Wang wrote: On Wed, Jan 27, 2021 at 4:56 PM Jakub Kicinski wrote: On Mon, 25 Jan 2021 22:10:10 +0200 Slava Bacherikov wrote: Hi, I'd like to report a regression. Currently, if you create GRE interface on the latest stable or LTS kernel (5.4 branch) with unspecified r

[PATCH v5 net-next] From: Petr Vandrovec

2021-01-27 Thread Ronak Doshi
buf_info structures in RX & TX queues are private driver data that do not need to be visible to the device. Although there is physical address and length in the queue descriptor that points to these structures, their layout is not standardized, and device never looks at them. So lets allocate the

Re: pull-request: can 2021-01-27

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Wed, 27 Jan 2021 10:40:27 +0100 you wrote: > Hello Jakub, hello David, > > this is a pull request of 1 patch for net/master. > > The patch is by Dan Carpenter and fixes a potential information leak in > can_fill_info

Re: [PATCH net 1/3] netfilter: nft_dynset: honor stateful expressions in set definition

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Wed, 27 Jan 2021 14:25:10 +0100 you wrote: > If the set definition contains stateful expressions, allocate them for > the newly added entries from the packet path. > > Fixes: 65038428b2c6 ("netfilter: nf_tables: allow to sp

Re: [net] can: dev: prevent potential information leak in can_fill_info()

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 27 Jan 2021 10:40:28 +0100 you wrote: > From: Dan Carpenter > > The "bec" struct isn't necessarily always initialized. For example, the > mcp251xfd_get_berr_counter() function doesn't initialize anything if the > inter

Re: [PATCH net] MAINTAINERS: add missing header for bonding

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 26 Jan 2021 18:18:44 -0800 you wrote: > include/net/bonding.h is missing from bonding entry. > > Signed-off-by: Jakub Kicinski > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) Here is the summary with link

Re: [PATCH bpf-next v5 1/2] bpf: allow rewriting to ports under ip_unprivileged_port_start

2021-01-27 Thread Andrey Ignatov
Stanislav Fomichev [Wed, 2021-01-27 11:32 -0800]: > At the moment, BPF_CGROUP_INET{4,6}_BIND hooks can rewrite user_port > to the privileged ones (< ip_unprivileged_port_start), but it will > be rejected later on in the __inet_bind or __inet6_bind. > > Let's add another return value to indicate t

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-27 Thread Andrew Lunn
On Tue, Jan 26, 2021 at 08:33:37AM +0100, Mike Looijmans wrote: > The mdio_bus reset code first de-asserted the reset by allocating with > GPIOD_OUT_LOW, then asserted and de-asserted again. In other words, if > the reset signal defaulted to asserted, there'd be a short "spike" > before the reset.

Re: [PATCH net-next 0/4] Automatically manage DSA master interface state

2021-01-27 Thread Florian Fainelli
On 1/27/2021 5:30 PM, Vladimir Oltean wrote: > On Wed, Jan 27, 2021 at 05:03:23PM -0800, Florian Fainelli wrote: >> I really like all patches but number #2, though I don't believe there >> are existing use cases besides you one you described where it makes >> sense to keep a switch in an unmanag

Re: [PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Sedat Dilek
On Thu, Jan 28, 2021 at 2:41 AM Andrii Nakryiko wrote: > > On Wed, Jan 27, 2021 at 5:30 PM Sedat Dilek wrote: > > > > On Thu, Jan 28, 2021 at 2:27 AM Andrii Nakryiko > > wrote: > > > > > > On Thu, Jan 21, 2021 at 4:32 PM Sedat Dilek wrote: > > > > > > > > When dealing with BPF/BTF/pahole and DW

[PATCH bpf-next] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Sedat Dilek
When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. While looking into the source code I found duplicate assignments in misc tools for the LLVM eco system, e.g. clang and llvm-objcopy. Move the Clang, LLC and/or LLVM utils definitions to tools/scripts/Makefile.include file an

Re: [PATCH v7 net-next 08/11] net: dsa: allow changing the tag protocol via the "tagging" device attribute

2021-01-27 Thread Florian Fainelli
On 1/27/2021 5:30 PM, Jakub Kicinski wrote: > On Tue, 26 Jan 2021 00:03:30 +0200 Vladimir Oltean wrote: >> From: Vladimir Oltean >> >> Currently DSA exposes the following sysfs: >> $ cat /sys/class/net/eno2/dsa/tagging >> ocelot >> >> which is a read-only device attribute, introduced in the ker

Re: [PATCH net v2 0/7][pull request] Intel Wired LAN Driver Updates 2021-01-26

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Tue, 26 Jan 2021 14:10:28 -0800 you wrote: > This series contains updates to the ice, i40e, and igc driver. > > Henry corrects setting an unspecified protocol to IPPROTO_NONE instead of > 0 for IPv6 flexbytes filters for ic

Re: [PATCH net-next v3] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-27 Thread Chris Mi
On 1/28/2021 7:49 AM, Jakub Kicinski wrote: On Wed, 27 Jan 2021 18:16:48 +0800 Chris Mi wrote: @@ -35,4 +45,21 @@ static inline void psample_sample_packet(struct psample_group *group, #endif +static void static inline Done. +psample_nic_sample_packet(struct psample_group *group, +

[PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-27 Thread Chris Mi
In order to send sampled packets to userspace, NIC driver calls psample api directly. But it creates a hard dependency on module psample. Introduce psample_ops to remove the hard dependency. It is initialized when psample module is loaded and set to NULL when the module is unloaded. Reported-by: k

Re: [PATCH net-next 4/4] Revert "net: ipv4: handle DSA enabled master network devices"

2021-01-27 Thread Florian Fainelli
On 1/26/2021 5:00 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This reverts commit 728c02089a0e3eefb02e9927bfae50490f40e72e. > > Since 2015 DSA has gained more integration with the network stack, we > can now have the same functionality without explicitly open-coding for > it: > - I

Re: [PATCH net-next 2/4] net: dsa: automatically bring user ports down when master goes down

2021-01-27 Thread Florian Fainelli
On 1/27/2021 4:52 PM, Andrew Lunn wrote: > On Thu, Jan 28, 2021 at 02:50:14AM +0200, Vladimir Oltean wrote: >> On Thu, Jan 28, 2021 at 01:46:30AM +0100, Andrew Lunn wrote: + case NETDEV_GOING_DOWN: { + struct dsa_port *dp, *cpu_dp; + struct dsa_switch_tree *dst;

Re: [PATCH net-next 3/4] Revert "net: Have netpoll bring-up DSA management interface"

2021-01-27 Thread Florian Fainelli
On 1/26/2021 5:00 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This reverts commit 1532b9778478577152201adbafa7738b1e844868. > > The above commit is good and it works, however it was meant as a bugfix > for stable kernels and now we have more self-contained ways in DSA to > handle t

Re: [Patch net] net: fix dev_ifsioc_locked() race condition

2021-01-27 Thread Cong Wang
On Mon, Jan 25, 2021 at 11:43 AM Gong, Sishuai wrote: > > Hi, > > We also found another pair of writer and reader that may suffer the same > problem. > > A data race may also happen on the variable netdev->dev_addr when functions > e1000_set_mac() and packet_getname() run in parallel, eventually

Re: [PATCH net-next v2 0/2] net: bridge: multicast: per-port EHT hosts limit

2021-01-27 Thread Jakub Kicinski
On Tue, 26 Jan 2021 11:35:31 +0200 Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Hi, > This set adds a simple configurable per-port EHT tracked hosts limit. > Patch 01 adds a default limit of 512 tracked hosts per-port, since the EHT > changes are still only in net-next that shouldn'

Re: [PATCH net-next 1/4] net: dsa: automatically bring up DSA master when opening user port

2021-01-27 Thread Florian Fainelli
On 1/26/2021 5:00 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > DSA wants the master interface to be open before the user port is due to > historical reasons. The promiscuity of interfaces that are down used to > have issues, as referenced Lennert Buytenhek in commit df02c6ff2e39 > ("

Re: [PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Andrii Nakryiko
On Wed, Jan 27, 2021 at 5:30 PM Sedat Dilek wrote: > > On Thu, Jan 28, 2021 at 2:27 AM Andrii Nakryiko > wrote: > > > > On Thu, Jan 21, 2021 at 4:32 PM Sedat Dilek wrote: > > > > > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > > > > > > While looking into the sourc

Re: [PATCH] rocker: Simplify the calculation of variables

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 26 Jan 2021 16:13:03 +0800 you wrote: > Fix the following coccicheck warnings: > > ./drivers/net/ethernet/rocker/rocker_ofdpa.c:926:34-36: WARNING !A || A > && B is equivalent to !A || B. > > Reported-by: Abaci Ro

Re: [net] net: decnet: fix netdev refcount leaking on error path

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 26 Jan 2021 03:02:14 +0300 you wrote: > On building the route there is an assumption that the destination > could be local. In this case loopback_dev is used to get the address. > If the address is still cannot be retrie

Re: BUG: Incorrect MTU on GRE device if remote is unspecified

2021-01-27 Thread Cong Wang
On Wed, Jan 27, 2021 at 4:56 PM Jakub Kicinski wrote: > > On Mon, 25 Jan 2021 22:10:10 +0200 Slava Bacherikov wrote: > > Hi, I'd like to report a regression. Currently, if you create GRE > > interface on the latest stable or LTS kernel (5.4 branch) with > > unspecified remote destination it's MTU

Re: [PATCH net v2] ibmvnic: Ensure that CRQ entry read are correctly ordered

2021-01-27 Thread Lijun Pan
On Wed, Jan 27, 2021 at 7:31 PM Jakub Kicinski wrote: > > On Wed, 27 Jan 2021 19:22:25 -0600 Lijun Pan wrote: > > On Wed, Jan 27, 2021 at 7:06 PM Jakub Kicinski wrote: > > > > > > On Mon, 25 Jan 2021 17:20:23 -0600 Lijun Pan wrote: > > > > Ensure that received Command-Response Queue (CRQ) entries

[PATCH net v3] ibmvnic: Ensure that CRQ entry read are correctly ordered

2021-01-27 Thread Lijun Pan
Ensure that received Command-Response Queue (CRQ) entries are properly read in order by the driver. dma_rmb barrier has been added before accessing the CRQ descriptor to ensure the entire descriptor is read before processing. Fixes: 032c5e82847a ("Driver for IBM System i/p VNIC protocol") Signed-o

Re: [PATCH v7 net-next 08/11] net: dsa: allow changing the tag protocol via the "tagging" device attribute

2021-01-27 Thread Jakub Kicinski
On Tue, 26 Jan 2021 00:03:30 +0200 Vladimir Oltean wrote: > From: Vladimir Oltean > > Currently DSA exposes the following sysfs: > $ cat /sys/class/net/eno2/dsa/tagging > ocelot > > which is a read-only device attribute, introduced in the kernel as > commit 98cdb4807123 ("net: dsa: Expose taggin

Re: [PATCH net v2] ibmvnic: Ensure that CRQ entry read are correctly ordered

2021-01-27 Thread Jakub Kicinski
On Wed, 27 Jan 2021 19:22:25 -0600 Lijun Pan wrote: > On Wed, Jan 27, 2021 at 7:06 PM Jakub Kicinski wrote: > > > > On Mon, 25 Jan 2021 17:20:23 -0600 Lijun Pan wrote: > > > Ensure that received Command-Response Queue (CRQ) entries are > > > properly read in order by the driver. dma_rmb barrier

Re: [PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Sedat Dilek
On Thu, Jan 28, 2021 at 2:27 AM Andrii Nakryiko wrote: > > On Thu, Jan 21, 2021 at 4:32 PM Sedat Dilek wrote: > > > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > > > > While looking into the source code I found duplicate assignments > > in misc tools for the LLVM ec

Re: [PATCH net-next 0/4] Automatically manage DSA master interface state

2021-01-27 Thread Vladimir Oltean
On Wed, Jan 27, 2021 at 05:03:23PM -0800, Florian Fainelli wrote: > I really like all patches but number #2, though I don't believe there > are existing use cases besides you one you described where it makes > sense to keep a switch in an unmanaged mode being "headless" with its > CPU port down, wh

Re: [PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Andrii Nakryiko
On Thu, Jan 21, 2021 at 4:32 PM Sedat Dilek wrote: > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > > While looking into the source code I found duplicate assignments > in misc tools for the LLVM eco system, e.g. clang and llvm-objcopy. > > Move the Clang, LLC and/or

Re: [PATCH net v2] ibmvnic: Ensure that CRQ entry read are correctly ordered

2021-01-27 Thread Lijun Pan
On Wed, Jan 27, 2021 at 7:06 PM Jakub Kicinski wrote: > > On Mon, 25 Jan 2021 17:20:23 -0600 Lijun Pan wrote: > > Ensure that received Command-Response Queue (CRQ) entries are > > properly read in order by the driver. dma_rmb barrier has > > been added before accessing the CRQ descriptor to ensure

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-27 Thread Andrew Lunn
On Thu, Jan 28, 2021 at 12:25:55AM +, Russell King - ARM Linux admin wrote: > On Thu, Jan 28, 2021 at 01:00:57AM +0100, Andrew Lunn wrote: > > On Tue, Jan 26, 2021 at 01:49:38PM +, Russell King - ARM Linux admin > > wrote: > > > On Tue, Jan 26, 2021 at 02:14:40PM +0100, Andrew Lunn wrote:

Re: [PATCH] net: sysctl: remove redundant #ifdef CONFIG_NET

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 26 Jan 2021 08:14:21 +0900 you wrote: > CONFIG_NET is a bool option, and this file is compiled only when > CONFIG_NET=y. > > Remove #ifdef CONFIG_NET, which we know it is always met. > > Signed-off-by: Masahiro Ya

Re: [PATCH 1/4] net: move CONFIG_NET guard to top Makefile

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 26 Jan 2021 08:16:55 +0900 you wrote: > When CONFIG_NET is disabled, nothing under the net/ directory is > compiled. Move the CONFIG_NET guard to the top Makefile so the net/ > directory is entirely skipped. > > W

Re: [PATCH] net: remove redundant 'depends on NET'

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 26 Jan 2021 08:20:26 +0900 you wrote: > These Kconfig files are included from net/Kconfig, inside the > if NET ... endif. > > Remove 'depends on NET', which we know it is already met. > > Signed-off-by: Masahiro Y

Re: [PATCH net-next 0/4] Automatically manage DSA master interface state

2021-01-27 Thread Florian Fainelli
On 1/26/2021 5:00 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This patch series adds code that makes DSA open the master interface > automatically whenever one user interface gets opened, either by the > user, or by various networking subsystems: netconsole, nfsroot. > With that in

Re: [PATCH net-next] r8169: remove not needed call to rtl_wol_enable_rx from rtl_shutdown

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 25 Jan 2021 17:55:12 +0100 you wrote: > rtl_wol_enable_rx() is called via the following call chain if WoL > is enabled: > rtl8169_down() > -> rtl_prepare_power_down() >-> rtl_wol_enable_rx() > Therefore we don't

Re: [PATCH net-next 0/5] MPTCP: IPv4-mapped IPv6 addressing for subflows

2021-01-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 25 Jan 2021 10:58:59 -0800 you wrote: > This patch series from the MPTCP tree adds support for IPv4-mapped IPv6 > addressing that was missing when multiple subflows were first > implemented. > > Patches 1 and 2 ha

Re: [PATCH net v2] ibmvnic: Ensure that CRQ entry read are correctly ordered

2021-01-27 Thread Jakub Kicinski
On Mon, 25 Jan 2021 17:20:23 -0600 Lijun Pan wrote: > Ensure that received Command-Response Queue (CRQ) entries are > properly read in order by the driver. dma_rmb barrier has > been added before accessing the CRQ descriptor to ensure > the entire descriptor is read before processing. > > Fixes: 0

Re: BUG: Incorrect MTU on GRE device if remote is unspecified

2021-01-27 Thread Jakub Kicinski
On Mon, 25 Jan 2021 22:10:10 +0200 Slava Bacherikov wrote: > Hi, I'd like to report a regression. Currently, if you create GRE > interface on the latest stable or LTS kernel (5.4 branch) with > unspecified remote destination it's MTU will be adjusted for header size > twice. For example: > > $ ip

[PATCH net-next v2 4/4] bridge: mrp: Update br_mrp to use new return values of br_mrp_switchdev

2021-01-27 Thread Horatiu Vultur
Check the return values of the br_mrp_switchdev function. In case of: - BR_MRP_NONE, return the error to userspace, - BR_MRP_SW, continue with SW implementation, - BR_MRP_HW, continue without SW implementation, Signed-off-by: Horatiu Vultur --- net/bridge/br_mrp.c | 43 ++

Re: [PATCH net-next 4/4] Revert "net: ipv4: handle DSA enabled master network devices"

2021-01-27 Thread Andrew Lunn
On Wed, Jan 27, 2021 at 03:00:28AM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > This reverts commit 728c02089a0e3eefb02e9927bfae50490f40e72e. > > Since 2015 DSA has gained more integration with the network stack, we > can now have the same functionality without explicitly open-codin

[PATCH net-next v2 3/4] bridge: mrp: Extend br_mrp_switchdev to detect better the errors

2021-01-27 Thread Horatiu Vultur
This patch extends the br_mrp_switchdev functions to be able to have a better understanding what cause the issue and if the SW needs to be used as a backup. There are the following cases: - when the code is compiled without CONFIG_NET_SWITCHDEV. In this case return success so the SW can continue

[PATCH net-next v2 1/4] switchdev: mrp: Extend ring_role_mrp and in_role_mrp

2021-01-27 Thread Horatiu Vultur
Add the member sw_backup to the structures switchdev_obj_ring_role_mrp and switchdev_obj_in_role_mrp. In this way the SW can call the driver in 2 ways, once when sw_backup is set to false, meaning that the driver should implement this completely in HW. And if that is not supported the SW will call

[PATCH net-next v2 2/4] bridge: mrp: Add 'enum br_mrp_hw_support'

2021-01-27 Thread Horatiu Vultur
Add the enum br_mrp_hw_support that is used by the br_mrp_switchdev functions to allow the SW to detect the cases where HW can't implement the functionality or when SW is used as a backup. Signed-off-by: Horatiu Vultur --- net/bridge/br_private_mrp.h | 14 ++ 1 file changed, 14 inser

[PATCH net-next v2 0/4] bridge: mrp: Extend br_mrp_switchdev_*

2021-01-27 Thread Horatiu Vultur
This patch series extends MRP switchdev to allow the SW to have a better understanding if the HW can implement the MRP functionality or it needs to help the HW to run it. There are 3 cases: - when HW can't implement at all the functionality. - when HW can implement a part of the functionality but n

  1   2   3   4   >