[PATCH net-next v2] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-26 Thread Chris Mi
In order to send sampled packets to userspace, NIC driver calls psample api directly. But it creates a hard dependency on module psample. Introduce psample_ops to remove the hard dependency. It is initialized when psample module is loaded and set to NULL when the module is unloaded. Reported-by: k

[Patch v2 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-01-26 Thread Hariprasad Kelam
From: Christina Jacob Register set_link_ksetting callback with driver such that link configurations parameters like advertised mode,speed, duplex and autoneg can be configured. below command ethtool -s eth0 advertise 0x1 speed 10 duplex full autoneg on Signed-off-by: Christina Jacob Signed-off

[Patch v2 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-01-26 Thread Hariprasad Kelam
From: Christina Jacob Add ethtool support to configure fec modes baser/rs and support to fecth FEC stats from CGX as well PHY. Configure fec mode - ethtool --set-fec eth0 encoding rs/baser/off/auto Query fec mode - ethtool --show-fec eth0 Signed-off-by: Christina Jacob Signed-o

[Patch v2 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-01-26 Thread Hariprasad Kelam
From: Felix Manlunas This patch adds support to fetch fec stats from PHY. The stats are put in the shared data struct fwdata. A PHY driver indicates that it has FEC stats by setting the flag fwdata.phy.misc.has_fec_stats Besides CGX_CMD_GET_PHY_FEC_STATS, also add CGX_CMD_PRBS and CGX_CMD_DISPL

[Patch v2 net-next 5/7] octeontx2-af: advertised link modes support on cgx

2021-01-26 Thread Hariprasad Kelam
From: Christina Jacob CGX supports setting advertised link modes on physical link. This patch adds support to derive cgx mode from ethtool link mode and pass it to firmware to configure the same. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam ---

[Patch v2 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-01-26 Thread Hariprasad Kelam
From: Christina Jacob Register get_link_ksettings callback to get link status information from the driver. As virtual function (vf) shares same physical link same API is used for both the drivers and for loop back drivers simply returns the fixed values as its does not have physical link. ethtoo

[Patch v2 net-next 4/7] octeontx2-af: Physical link configuration support

2021-01-26 Thread Hariprasad Kelam
From: Christina Jacob CGX LMAC, the physical interface support link configuration parameters like speed, auto negotiation, duplex etc. Firmware saves these into memory region shared between firmware and this driver. This patch adds mailbox handler set_link_mode, fw_data_get to configure and rea

[Patch v2 net-next 0/7] ethtool support for fec and link configuration

2021-01-26 Thread Hariprasad Kelam
This series of patches add support for forward error correction(fec) and physical link configuration. Patches 1&2 adds necessary mbox handlers for fec mode configuration request and to fetch stats. Patch 3 registers driver callbacks for fec mode configuration and display. Patch 4&5 adds support of

RE: [PATCHv17 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-01-26 Thread John Fastabend
Hangbin Liu wrote: > From: Jesper Dangaard Brouer > > This changes the devmap XDP program support to run the program when the > bulk queue is flushed instead of before the frame is enqueued. This has > a couple of benefits: > > - It "sorts" the packets by destination devmap entry, and then runs

[net 11/12] net/mlx5e: Revert parameters on errors when changing MTU and LRO state without reset

2021-01-26 Thread Saeed Mahameed
From: Maxim Mikityanskiy Sometimes, channel params are changed without recreating the channels. It happens in two basic cases: when the channels are closed, and when the parameter being changed doesn't affect how channels are configured. Such changes invoke a hardware command that might fail. The

[net 08/12] net/mlx5e: Fix CT rule + encap slow path offload and deletion

2021-01-26 Thread Saeed Mahameed
From: Paul Blakey Currently, if a neighbour isn't valid when offloading tunnel encap rules, we offload the original match and replace the original action with "goto slow path" action. For this we use a temporary flow attribute based on the original flow attribute and then change the action. Flow

[net 09/12] net/mlx5e: Correctly handle changing the number of queues when the interface is down

2021-01-26 Thread Saeed Mahameed
From: Maxim Mikityanskiy This commit addresses two issues related to changing the number of queues when the channels are closed: 1. Missing call to mlx5e_num_channels_changed to update real_num_tx_queues when the number of TCs is changed. 2. When mlx5e_num_channels_changed returns an error, the

[net 12/12] net/mlx5: CT: Fix incorrect removal of tuple_nat_node from nat rhashtable

2021-01-26 Thread Saeed Mahameed
From: Paul Blakey If a non nat tuple entry is inserted just to the regular tuples rhashtable (ct_tuples_ht) and not to natted tuples rhashtable (ct_nat_tuples_ht). Commit bc562be9674b ("net/mlx5e: CT: Save ct entries tuples in hashtables") mixed up the return labels and names sot that on cleanup

[patch net-next v2] net: dsa: mv88e6xxx: Make global2 support mandatory

2021-01-26 Thread Andrew Lunn
Early generations of the mv88e6xxx did not have the global 2 registers. In order to keep the driver slim, it was decided to make the code for these registers optional. Over time, more generations of switches have been added, always supporting global 2 and adding more and more registers. No effort h

Re: [PATCH net-next 1/2] net: usb: qmi_wwan: add qmap id sysfs file for qmimux interfaces

2021-01-26 Thread Bjørn Mork
Jakub Kicinski writes: > On Mon, 25 Jan 2021 17:14:28 +0100 Bjørn Mork wrote: >> Daniele Palmas writes: >> >> > Add qmimux interface sysfs file qmap/mux_id to show qmap id set >> > during the interface creation, in order to provide a method for >> > userspace to associate QMI control channels to

Re: [patch net-next v2] net: dsa: mv88e6xxx: Make global2 support mandatory

2021-01-26 Thread Florian Fainelli
On 1/26/2021 4:32 PM, Andrew Lunn wrote: > Early generations of the mv88e6xxx did not have the global 2 > registers. In order to keep the driver slim, it was decided to make > the code for these registers optional. Over time, more generations of > switches have been added, always supporting glob

Re: [PATCH net-next] net: bridge: multicast: fix br_multicast_eht_set_entry_lookup indentation

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 25 Jan 2021 10:20:40 +0200 you wrote: > From: Nikolay Aleksandrov > > Fix the messed up indentation in br_multicast_eht_set_entry_lookup(). > > Fixes: baa74d39ca39 ("net: bridge: multicast: add EHT source set han

Re: pull-request: wireless-drivers-2021-01-26

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Tue, 26 Jan 2021 09:22:02 + (UTC) you wrote: > Hi, > > here's a pull request to net tree, more info below. Please let me know if > there > are any problems. > > Kalle > > [...] Here is the summary with links:

Re: [PATCH] staging: rtl8723bs: fix wireless regulatory API misuse

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 26 Jan 2021 11:54:09 +0100 you wrote: > From: Johannes Berg > > This code ends up calling wiphy_apply_custom_regulatory(), for which > we document that it should be called before wiphy_register(). This > driver doesn't

Re: pull-request: mac80211 2021-01-26

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Tue, 26 Jan 2021 14:05:28 +0100 you wrote: > Hi Jakub, > > We have a few fixes - note one is for a staging driver, but acked by > Greg and fixing the driver for a change that came through my tree. > > Please pull and

RE: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

2021-01-26 Thread Saleem, Shiraz
> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and > implement private channel OPs > > On Tue, Jan 26, 2021 at 12:42:16AM +, Saleem, Shiraz wrote: > > > I think this essentially means doing away with .open/.close piece. > > Yes, that too, and probably the FSM as well.

RE: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

2021-01-26 Thread Saleem, Shiraz
> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and > implement private channel OPs > > On Mon, Jan 25, 2021 at 05:01:40PM -0800, Jacob Keller wrote: > > > > > > On 1/25/2021 4:39 PM, Saleem, Shiraz wrote: > > >> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary dr

RE: [PATCH 09/22] RDMA/irdma: Implement HW Admin Queue OPs

2021-01-26 Thread Saleem, Shiraz
> Subject: Re: [PATCH 09/22] RDMA/irdma: Implement HW Admin Queue OPs > > On Fri, Jan 22, 2021 at 05:48:14PM -0600, Shiraz Saleem wrote: > > +#define LS_64_1(val, bits) ((u64)(uintptr_t)(val) << (bits)) > > +#define RS_64_1(val, bits) ((u64)(uintptr_t)(val) >> (bits)) > > +#define LS_32_1(val, bit

Re: [PATCH] net: mdiobus: Prevent spike on MDIO bus reset signal

2021-01-26 Thread Mike Looijmans
See below. Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijm...@topicproducts.com W: www.topicproducts.com Please consider the environment before printing this

Re: [PATCH v2] tracepoint: Do not fail unregistering a probe due to memory allocation

2021-01-26 Thread Alexey Kardashevskiy
On 18/11/2020 23:46, Steven Rostedt wrote: On Tue, 17 Nov 2020 20:54:24 -0800 Alexei Starovoitov wrote: extern int @@ -310,7 +312,12 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p) do {\

Delays

2021-01-26 Thread Jakub Kicinski
Hi folks! vger seems to be randomly inserting many-hour delays on forwarding emails which also renders patchwork pretty hard to use. Sorry if there are delays or mistakes in applying patches, the issue has been known (and repeatedly reported) for the last two weeks, and it's getting increasingly

Re: Preemptible idr_alloc() in QRTR code

2021-01-26 Thread Matthew Wilcox
On Tue, Jan 26, 2021 at 06:36:02PM +, Mark Rutland wrote: > On Tue, Jan 26, 2021 at 11:00:05AM -0600, Bjorn Andersson wrote: > > On Tue 26 Jan 10:21 CST 2021, Mark Rutland wrote: > > > > > On Tue, Jan 26, 2021 at 02:58:33PM +, Matthew Wilcox wrote: > > > > On Tue, Jan 26, 2021 at 10:47:34A

Re: [PATCH net v2 7/7] igc: fix link speed advertising

2021-01-26 Thread Heiner Kallweit
On 26.01.2021 23:10, Tony Nguyen wrote: > From: Corinna Vinschen > > Link speed advertising in igc has two problems: > > - When setting the advertisement via ethtool, the link speed is converted > to the legacy 32 bit representation for the intel PHY code. > This inadvertently drops ETHTOOL_

Re: [Patch bpf-next v5 1/3] bpf: introduce timeout hash map

2021-01-26 Thread Cong Wang
On Tue, Jan 26, 2021 at 2:04 PM Daniel Borkmann wrote: > > On 1/22/21 9:54 PM, Cong Wang wrote: > > From: Cong Wang > > > > This borrows the idea from conntrack and will be used for conntrack in > > ebpf too. Each element in a timeout map has a user-specified timeout > > in msecs, after it expire

[PATCH net-next 2/4] net: dsa: automatically bring user ports down when master goes down

2021-01-26 Thread Vladimir Oltean
From: Vladimir Oltean This is not fixing any actual bug that I know of, but having a DSA interface that is up even when its lower (master) interface is down is one of those things that just do not sound right. Yes, DSA checks if the master is up before actually bringing the user interface up, bu

[PATCH net-next 1/4] net: dsa: automatically bring up DSA master when opening user port

2021-01-26 Thread Vladimir Oltean
From: Vladimir Oltean DSA wants the master interface to be open before the user port is due to historical reasons. The promiscuity of interfaces that are down used to have issues, as referenced Lennert Buytenhek in commit df02c6ff2e39 ("dsa: fix master interface allmulti/promisc handling"). The

[PATCH net-next 4/4] Revert "net: ipv4: handle DSA enabled master network devices"

2021-01-26 Thread Vladimir Oltean
From: Vladimir Oltean This reverts commit 728c02089a0e3eefb02e9927bfae50490f40e72e. Since 2015 DSA has gained more integration with the network stack, we can now have the same functionality without explicitly open-coding for it: - It now opens the DSA master netdevice automatically whenever a us

[PATCH net-next 0/4] Automatically manage DSA master interface state

2021-01-26 Thread Vladimir Oltean
From: Vladimir Oltean This patch series adds code that makes DSA open the master interface automatically whenever one user interface gets opened, either by the user, or by various networking subsystems: netconsole, nfsroot. With that in place, we can remove some of the places in the network stack

[PATCH net-next 3/4] Revert "net: Have netpoll bring-up DSA management interface"

2021-01-26 Thread Vladimir Oltean
From: Vladimir Oltean This reverts commit 1532b9778478577152201adbafa7738b1e844868. The above commit is good and it works, however it was meant as a bugfix for stable kernels and now we have more self-contained ways in DSA to handle the situation where the DSA master must be brought up. Signed-

RE: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

2021-01-26 Thread Saleem, Shiraz
> Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and > implement private channel OPs > > > > On 1/25/2021 9:29 PM, Leon Romanovsky wrote: > > On Mon, Jan 25, 2021 at 05:01:40PM -0800, Jacob Keller wrote: > >> > >> > >> On 1/25/2021 4:39 PM, Saleem, Shiraz wrote: > Subje

RE: [PATCH 15/22] RDMA/irdma: Implement device supported verb APIs

2021-01-26 Thread Saleem, Shiraz
> Subject: Re: [PATCH 15/22] RDMA/irdma: Implement device supported verb APIs > > On Fri, Jan 22, 2021 at 05:48:20PM -0600, Shiraz Saleem wrote: > > From: Mustafa Ismail > > > > Implement device supported verb APIs. The supported APIs vary based on > > the underlying transport the ibdev is regist

[PATCH v2 net] r8169: work around RTL8125 UDP hw bug

2021-01-26 Thread Heiner Kallweit
It was reported that on RTL8125 network breaks under heavy UDP load, e.g. torrent traffic ([0], from comment 27). Realtek confirmed a hw bug and provided me with a test version of the r8125 driver including a workaround. Tests confirmed that the workaround fixes the issue. I modified the original v

Re: [PATCH net-next] cxgb4: remove redundant NULL check

2021-01-26 Thread Raju Rangoju
On Tuesday, January 01/26/21, 2021 at 10:50:13 +0800, Yang Li wrote: > Fix below warnings reported by coccicheck: > ./drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c:323:3-9: WARNING: > NULL check before some freeing functions is not needed. > ./drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:3554:2-8

[PATCH] bpf: Check for integer overflow when using roundup_pow_of_two()

2021-01-26 Thread Bui Quang Minh
On 32-bit architecture, roundup_pow_of_two() can return 0 when the argument has upper most bit set due to resulting 1UL << 32. Add a check for this case. Fixes: d5a3b1f ("bpf: introduce BPF_MAP_TYPE_STACK_TRACE") Signed-off-by: Bui Quang Minh --- kernel/bpf/stackmap.c | 2 ++ 1 file changed, 2 i

[PATCH v3] net/bluetooth/hci_debugfs.c: fix coccicheck warnings

2021-01-26 Thread Jiapeng Zhong
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- Changes in v2: -Modifying row alignment. net/bluetooth/hci_debugfs.c | 80 ++--- 1 file changed, 40 insertions(

Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

2021-01-26 Thread Jason Gunthorpe
On Wed, Jan 27, 2021 at 12:42:09AM +, Saleem, Shiraz wrote: > > It does, the PCI driver is not supposed to spawn any aux devices for RDMA > > at all > > if RDMA is disabled. > > > > For an iWarp driver I would consider ENABLE_ROCE to really be a general > > ENABLE_RDMA. > > Well the driver

[net-next] tipc: remove duplicated code in tipc_msg_create

2021-01-26 Thread Hoang Huu Le
Remove a duplicate code checking for header size in tipc_msg_create() as it's already being done in tipc_msg_init(). Acked-by: Jon Maloy Signed-off-by: Hoang Huu Le --- net/tipc/msg.c | 4 1 file changed, 4 deletions(-) diff --git a/net/tipc/msg.c b/net/tipc/msg.c index 2aca86021df5..e926

Re: [PATCH net] iwlwifi: provide gso_type to GSO packets

2021-01-26 Thread Coelho, Luciano
On Tue, 2021-01-26 at 21:55 +0100, Johannes Berg wrote: > On Tue, 2021-01-26 at 12:32 -0800, Jakub Kicinski wrote: > > On Mon, 25 Jan 2021 07:09:49 -0800 Eric Dumazet wrote: > > > From: Eric Dumazet > > > > > > net/core/tso.c got recent support for USO, and this broke iwlfifi > > > because the dr

Re: [PATCH net-next 1/2] net: usb: qmi_wwan: add qmap id sysfs file for qmimux interfaces

2021-01-26 Thread Jakub Kicinski
On Mon, 25 Jan 2021 17:14:28 +0100 Bjørn Mork wrote: > Daniele Palmas writes: > > > Add qmimux interface sysfs file qmap/mux_id to show qmap id set > > during the interface creation, in order to provide a method for > > userspace to associate QMI control channels to network interfaces. > > > > Si

Re: [PATCH net v6] net: lapb: Add locking to the lapb module

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 25 Jan 2021 20:09:39 -0800 you wrote: > In the lapb module, the timers may run concurrently with other code in > this module, and there is currently no locking to prevent the code from > racing on "struct lapb_cb". This

Re: [PATCH net-next v2 0/2] net: dsa: mv88e6xxx: remove some 6250-specific methods

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 25 Jan 2021 16:04:47 +0100 you wrote: > v2: > > - resend now that the bug-fix patch (87fe04367d84, "net: dsa: > mv88e6xxx: also read STU state in mv88e6250_g1_vtu_getnext") is in > net and also merged to net-n

Re: [PATCH 0/2] net: usbnet: convert to new tasklet API

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 23 Jan 2021 18:32:19 +0100 you wrote: > From: Emil Renner Berthing > > This converts the usbnet driver to use the new tasklet API introduced in > commit 12cc923f1ccc ("tasklet: Introduce new initialization API")

Re: [RFC v3 06/11] vhost-vdpa: Add an opaque pointer for vhost IOTLB

2021-01-26 Thread Jason Wang
On 2021/1/20 下午3:52, Yongji Xie wrote: On Wed, Jan 20, 2021 at 2:24 PM Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: Add an opaque pointer for vhost IOTLB to store the corresponding vma->vm_file and offset on the DMA mapping. Let's split the patch into two. 1) opaque pointer

Re: [RFC v3 05/11] vdpa: shared virtual addressing support

2021-01-26 Thread Jason Wang
On 2021/1/20 下午3:10, Yongji Xie wrote: On Wed, Jan 20, 2021 at 1:55 PM Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: This patches introduces SVA (Shared Virtual Addressing) support for vDPA device. During vDPA device allocation, vDPA device driver needs to indicate whether SVA i

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-26 Thread kernel test robot
/kernel/git/davem/net-next.git 02c26940908fd31bb112e9742adedfb06eca19e1 config: s390-randconfig-s031-20210126 (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x

Re: [PATCH net-next 08/10] net: ipv6: Emit notification when fib hardware flags are changed

2021-01-26 Thread David Ahern
On 1/26/21 6:23 AM, Ido Schimmel wrote: > From: Amit Cohen > > After installing a route to the kernel, user space receives an > acknowledgment, which means the route was installed in the kernel, > but not necessarily in hardware. > > The asynchronous nature of route installation in hardware can

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-26 Thread Chris Mi
Hi Jakub, On 1/27/2021 10:49 AM, Jakub Kicinski wrote: On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote: In order to send sampled packets to userspace, NIC driver calls psample api directly. But it creates a hard dependency on module psample. Introduce psample_ops to remove the hard dependency

Re: UDP implementation and the MSG_MORE flag

2021-01-26 Thread Willem de Bruijn
On Tue, Jan 26, 2021 at 5:00 PM Willem de Bruijn wrote: > > On Tue, Jan 26, 2021 at 4:54 PM Willem de Bruijn > wrote: > > > > On Tue, Jan 26, 2021 at 9:58 AM Oliver Graute > > wrote: > > > > > > Hello, > > > > > > we observe some unexpected behavior in the UDP implementation of the > > > linux

Re: [PATCH net-next v3] selftests: add IPv4 unicast extensions tests

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 25 Jan 2021 20:08:34 -0800 you wrote: > Add selftests for kernel behavior with regard to various classes of > unallocated/reserved IPv4 addresses, checking whether or not these > addresses can be assigned as unicast

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-26 Thread Saeed Mahameed
On Tue, 2021-01-26 at 18:49 -0800, Jakub Kicinski wrote: > On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote: > > In order to send sampled packets to userspace, NIC driver calls > > psample api directly. But it creates a hard dependency on module > > psample. Introduce psample_ops to remove the har

Re: [PATCH net-next 04/10] net: ipv4: Publish fib_nlmsg_size()

2021-01-26 Thread David Ahern
On 1/26/21 6:23 AM, Ido Schimmel wrote: > From: Amit Cohen > > Publish fib_nlmsg_size() to allow it to be used later on from > fib_alias_hw_flags_set(). > > Remove the inline keyword since it shouldn't be used inside C files. > > Signed-off-by: Amit Cohen > Signed-off-by: Ido Schimmel > --- >

Re: [PATCH net-next 03/10] net: ipv4: Pass fib_rt_info as const to fib_dump_info()

2021-01-26 Thread David Ahern
On 1/26/21 6:23 AM, Ido Schimmel wrote: > From: Amit Cohen > > fib_dump_info() does not change 'fri', so pass it as 'const'. > It will later allow us to invoke fib_dump_info() from > fib_alias_hw_flags_set(). > > Signed-off-by: Amit Cohen > Signed-off-by: Ido Schimmel > --- > net/ipv4/fib_loo

Re: [PATCH net-next 02/10] netdevsim: fib: Perform the route programming in a non-atomic context

2021-01-26 Thread David Ahern
On 1/26/21 6:23 AM, Ido Schimmel wrote: > From: Amit Cohen > > Currently, netdevsim implements dummy FIB offload and marks notified > routes with RTM_F_TRAP flag. netdevsim does not defer route notifications > to a work queue because it does not need to program any hardware. > > Given that netde

Re: [PATCH] bpf: Fix integer overflow in argument calculation for bpf_map_area_alloc

2021-01-26 Thread Bui Quang Minh
On Wed, Jan 27, 2021 at 11:23:41AM +0700, Bui Quang Minh wrote: > > * Seems like there are quite a few similar calls scattered around > > (cpumap, etc.). Did you audit these as well? > > I spotted another bug after re-auditting. In hashtab, there ares 2 places > using > the same calls > >

Re: [PATCH net] bonding: fix send_peer_notif data truncation

2021-01-26 Thread kernel test robot
Hi liaichun, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/liaichun/bonding-fix-send_peer_notif-data-truncation/20210127-081947 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 07d4

Re: [PATCH net-next 06/10] net: Pass 'net' struct as first argument to fib6_info_hw_flags_set()

2021-01-26 Thread David Ahern
On 1/26/21 6:23 AM, Ido Schimmel wrote: > From: Amit Cohen > > The next patch will emit notification when hardware flags are changed, > in case that fib_notify_on_flag_change sysctl is set to 1. > > To know sysctl values, net struct is needed. > This change is consistent with the IPv4 version, w

Re: [PATCH net-next 05/10] net: ipv4: Emit notification when fib hardware flags are changed

2021-01-26 Thread David Ahern
On 1/26/21 6:23 AM, Ido Schimmel wrote: > From: Amit Cohen > > After installing a route to the kernel, user space receives an > acknowledgment, which means the route was installed in the kernel, > but not necessarily in hardware. > > The asynchronous nature of route installation in hardware can

Re: [PATCH net-next 01/10] netdevsim: fib: Convert the current occupancy to an atomic variable

2021-01-26 Thread David Ahern
On 1/26/21 6:23 AM, Ido Schimmel wrote: > @@ -889,22 +882,29 @@ static void nsim_nexthop_destroy(struct nsim_nexthop > *nexthop) > static int nsim_nexthop_account(struct nsim_fib_data *data, u64 occ, > bool add, struct netlink_ext_ack *extack) > { > - int err =

Re: [PATCH] bpf: Fix integer overflow in argument calculation for bpf_map_area_alloc

2021-01-26 Thread Bui Quang Minh
On Tue, Jan 26, 2021 at 09:36:57AM +, Lorenz Bauer wrote: > On Tue, 26 Jan 2021 at 08:26, Bui Quang Minh wrote: > > > > In 32-bit architecture, the result of sizeof() is a 32-bit integer so > > the expression becomes the multiplication between 2 32-bit integer which > > can potentially leads t

Re: [PATCH 4/4] cxgb4: remove redundant NULL check

2021-01-26 Thread Raju Rangoju
On Monday, January 01/25/21, 2021 at 17:47:25 +0800, Yang Li wrote: > Fix below warnings reported by coccicheck: > ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:533:2-8: WARNING: > NULL check before some freeing functions is not needed. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li

[net-next 02/14] net/mlx5: Add support for devlink traps in mlx5 core driver

2021-01-26 Thread Saeed Mahameed
From: Aya Levin Add devlink traps infra-structure to mlx5 core driver. Add traps list to mlx5_priv and corresponding API: - mlx5_devlink_trap_report() to wrap trap reports to devlink - mlx5_devlink_trap_get_num_active() to decide whether to open/close trap resources. Signed-off-by: Aya Levi

[pull request][net-next 00/14] mlx5 devlink trap support

2021-01-26 Thread Saeed Mahameed
Hi Jakub, Dave, This series adds devlink trap support to mlx5 driver. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit 02c26940908fd31bb112e9742adedfb06eca19e1: nfc: fix typo (2021-01-25

[net-next 03/14] net/mlx5: Register to devlink ingress VLAN filter trap

2021-01-26 Thread Saeed Mahameed
From: Aya Levin Add traps registration to mlx5_core devlink register/unregister flow. This patch registers INGRESS_VLAN_FILTER trap. Signed-off-by: Aya Levin Reviewed-by: Tariq Toukan Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/devlink.c

[net-next 13/14] net/mlx5e: Add listener to DMAC filter trap event

2021-01-26 Thread Saeed Mahameed
From: Aya Levin Add support for trapping packets which didn't match any DMAC in the MAC table. Add a listener which adds/removes MAC trap rule in the flow steering according to the trap's action trap/drop. Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Reviewed-by: Tariq Toukan Signed-of

[net 07/12] net/mlx5e: Disable hw-tc-offload when MLX5_CLS_ACT config is disabled

2021-01-26 Thread Saeed Mahameed
From: Maor Dickman The cited commit introduce new CONFIG_MLX5_CLS_ACT kconfig variable to control compilation of TC hardware offloads implementation. When this configuration is disabled the driver is still wrongly reports in ethtool that hw-tc-offload is supported. Fixed by reporting hw-tc-offlo

[net-next 10/14] net/mlx5e: Expose RX dma info helpers

2021-01-26 Thread Saeed Mahameed
From: Aya Levin In order to support RQs outside of channel context, change mlx5e_init_di_list() signature to accept NUMA node instead of cpu. In addition, expose dma info helpers as API. This API will be used for RQ's creation in other files in downstream patches. Signed-off-by: Aya Levin Revie

[pull request][net 00/12] mlx5 fixes 2021-01-26

2021-01-26 Thread Saeed Mahameed
Hi Jakub, Dave This series introduces some fixes to mlx5 driver. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit c5e9e8d48acdf3b863282af7f6f6931d39526245: Merge tag 'mac80211-for-net-2021-01-26' of git://git.kernel.org/pub/scm/linux/

[net 06/12] net/mlx5: Maintain separate page trees for ECPF and PF functions

2021-01-26 Thread Saeed Mahameed
From: Daniel Jurgens Pages for the host PF and ECPF were stored in the same tree, so the ECPF pages were being freed along with the host PF's when the host driver unloaded. Combine the function ID and ECPF flag to use as an index into the x-array containing the trees to get a different tree for

Re: [pull request][net-next V10 00/14] Add mlx5 subfunction support

2021-01-26 Thread Jakub Kicinski
On Fri, 22 Jan 2021 11:36:44 -0800 Saeed Mahameed wrote: > This series form Parav was the theme of this mlx5 release cycle, > we've been waiting anxiously for the auxbus infrastructure to make it into > the kernel, and now as the auxbus is in and all the stars are aligned, I > can finally submit th

Re: [PATCH] lan743x: fix endianness when accessing descriptors

2021-01-26 Thread Jakub Kicinski
On Mon, 25 Jan 2021 14:03:20 +0500 Alexey Denisov wrote: > TX/RX descriptor ring fields are always little-endian, but conversion > wasn't performed for big-endian CPUs, so the driver failed to work. > > This patch makes the driver work on big-endian CPUs. It was tested and > confirmed to work on N

Re: [PATCH v4 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-26 Thread Jakub Kicinski
On Mon, 25 Jan 2021 20:34:56 -0700 David Ahern wrote: > On 1/25/21 2:44 PM, Praveen Chaudhary wrote: > > For IPv4, default route is learned via DHCPv4 and user is allowed to change > > metric using config etc/network/interfaces. But for IPv6, default route can > > be learned via RA, for which, curr

[PATCH v2] net/bluetooth/hci_debugfs.c: fix coccicheck warnings

2021-01-26 Thread Jiapeng Zhong
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong --- Changes in v2: -Modifying row alignment. net/bluetooth/hci_debugfs.c | 80 ++--- 1 file changed, 40 insertions(

Re: [PATCH net] bonding: fix send_peer_notif data truncation

2021-01-26 Thread Jakub Kicinski
On Tue, 26 Jan 2021 11:52:01 + liaichun wrote: > send_peer_notif is u8, the value of this parameter is obtained from u8*int, > the data may be truncated. > And in practice, more than u8(256) characters are used. New line before Fixes > Fixes: 07a4ddec3ce9 ("bonding: add an option to specif

[PATCH bpf-next] bpf: change 'BPF_ADD' to 'BPF_AND' in print_bpf_insn()

2021-01-26 Thread menglong8 . dong
From: Menglong Dong This 'BPF_ADD' is duplicated, and I belive it should be 'BPF_AND'. Fixes: 981f94c3e921 ("bpf: Add bitwise atomic instructions") Signed-off-by: Menglong Dong --- kernel/bpf/disasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/disasm.c b/ker

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-26 Thread Hangbin Liu
On Tue, Jan 26, 2021 at 04:55:22PM +0200, Nikolay Aleksandrov wrote: > >> Thanks for the reply. There are a few reasons I think the bridge should > >> handle NETDEV_NOTIFY_PEERS: > >> > >> 1. Only a few devices will call NETDEV_NOTIFY_PEERS notifier: bond, team, > >>virtio, xen, 6lowpan. There

Re: [PATCH 3/4] cxgb4: remove redundant NULL check

2021-01-26 Thread Raju Rangoju
On Monday, January 01/25/21, 2021 at 17:47:24 +0800, Yang Li wrote: > Fix below warnings reported by coccicheck: > ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c:161:2-7: WARNING: > NULL check before some freeing functions is not needed. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li

[PATCH net v2]bonding: fix send_peer_notif data truncation

2021-01-26 Thread liaichun
send_peer_notif is u8, the value of this parameter is obtained from u8*int, it's easy to be truncated. And in practice, more than u8(256) characters are used. Fixes: 07a4ddec3ce9 ("bonding: add an option to specify a delay between peer notifications") Signed-off-by: Aichun Li --- include/net

Re: [RFC v3 01/11] eventfd: track eventfd_signal() recursion depth separately in different cases

2021-01-26 Thread Jason Wang
On 2021/1/20 下午2:52, Yongji Xie wrote: On Wed, Jan 20, 2021 at 12:24 PM Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: Now we have a global percpu counter to limit the recursion depth of eventfd_signal(). This can avoid deadlock or stack overflow. But in stack overflow case, it s

Re: [PATCH v2 net 1/1] net: fec: Fix temporary RMII clock reset on link up

2021-01-26 Thread Jakub Kicinski
On Mon, 25 Jan 2021 11:07:45 +0100 Laurent Badel wrote: > fec_restart() does a hard reset of the MAC module when the link status > changes to up. This temporarily resets the R_CNTRL register which controls > the MII mode of the ENET_OUT clock. In the case of RMII, the clock > frequency momentarily

Re: [RFC v3 03/11] vdpa: Remove the restriction that only supports virtio-net devices

2021-01-26 Thread Jason Wang
On 2021/1/20 下午7:08, Stefano Garzarella wrote: On Wed, Jan 20, 2021 at 11:46:38AM +0800, Jason Wang wrote: On 2021/1/19 下午12:59, Xie Yongji wrote: With VDUSE, we should be able to support all kinds of virtio devices. Signed-off-by: Xie Yongji ---  drivers/vhost/vdpa.c | 29 +++-

Re: [PATCH 09/22] RDMA/irdma: Implement HW Admin Queue OPs

2021-01-26 Thread Jason Gunthorpe
On Wed, Jan 27, 2021 at 12:41:59AM +, Saleem, Shiraz wrote: > > Subject: Re: [PATCH 09/22] RDMA/irdma: Implement HW Admin Queue OPs > > > > On Fri, Jan 22, 2021 at 05:48:14PM -0600, Shiraz Saleem wrote: > > > +#define LS_64_1(val, bits) ((u64)(uintptr_t)(val) << (bits)) > > > +#define RS

[PATCH net] MAINTAINERS: add missing header for bonding

2021-01-26 Thread Jakub Kicinski
include/net/bonding.h is missing from bonding entry. Signed-off-by: Jakub Kicinski --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8f68b591be57..4deef5791101 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3239,6 +3239,7 @@ L:netdev@vger

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-26 Thread Jakub Kicinski
On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote: > In order to send sampled packets to userspace, NIC driver calls > psample api directly. But it creates a hard dependency on module > psample. Introduce psample_ops to remove the hard dependency. > It is initialized when psample module is loaded a

Re: [PATCH V3 2/6] net: stmmac: stop each tx channel independently

2021-01-26 Thread Willem de Bruijn
On Tue, Jan 26, 2021 at 8:44 PM Joakim Zhang wrote: > > > > -Original Message- > > From: Willem de Bruijn > > Sent: 2021年1月27日 7:10 > > To: Joakim Zhang > > Cc: Giuseppe Cavallaro ; Alexandre Torgue > > ; Jose Abreu ; David > > Miller ; Jakub Kicinski ; Network > > Development ; dl-linux

Re: [PATCH] [net-next] bonding: add TLS dependency

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 25 Jan 2021 12:31:59 +0100 you wrote: > From: Arnd Bergmann > > When TLS is a module, the built-in bonding driver may cause a > link error: > > x86_64-linux-ld: drivers/net/bonding/bond_main.o: in function > `bo

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-01-26 Thread Jakub Kicinski
On Mon, 25 Jan 2021 16:18:19 +0100 Simon Horman wrote: > From: Baowen Zheng > > Allow a policer action to enforce a rate-limit based on packets-per-second, > configurable using a packet-per-second rate and burst parameters. This may > be used in conjunction with existing byte-per-second rate limi

RE: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp clock

2021-01-26 Thread Joakim Zhang
> -Original Message- > From: Florian Fainelli > Sent: 2021年1月27日 9:33 > To: Joakim Zhang ; Willem de Bruijn > > Cc: Giuseppe Cavallaro ; Alexandre Torgue > ; Jose Abreu ; David > Miller ; Jakub Kicinski ; Network > Development ; dl-linux-imx ; > Andrew Lunn > Subject: Re: [PATCH V3 1/6]

Re: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp clock

2021-01-26 Thread Florian Fainelli
On 1/26/2021 5:30 PM, Joakim Zhang wrote: > >> -Original Message- >> From: Willem de Bruijn >> Sent: 2021年1月27日 6:46 >> To: Joakim Zhang >> Cc: Giuseppe Cavallaro ; Alexandre Torgue >> ; Jose Abreu ; David >> Miller ; Jakub Kicinski ; Network >> Development ; dl-linux-imx ; >> Andrew

RE: [PATCH V3 2/6] net: stmmac: stop each tx channel independently

2021-01-26 Thread Joakim Zhang
> -Original Message- > From: Willem de Bruijn > Sent: 2021年1月27日 7:10 > To: Joakim Zhang > Cc: Giuseppe Cavallaro ; Alexandre Torgue > ; Jose Abreu ; David > Miller ; Jakub Kicinski ; Network > Development ; dl-linux-imx ; > Andrew Lunn ; Florian Fainelli > Subject: Re: [PATCH V3 2/6] n

Re: [PATCH net-next v3 1/2] nfc: Add a virtual nci device driver

2021-01-26 Thread Jakub Kicinski
On Sat, 23 Jan 2021 18:24:24 +0900 Bongsu Jeon wrote: > From: Bongsu Jeon > > NCI virtual device simulates a NCI device to the user. It can be used to > validate the NCI module and applications. This driver supports > communication between the virtual NCI device and NCI module. > > Signed-off-by

Re: [PATCH bpf-next] samples/bpf: Add include dir for MIPS Loongson64 to fix build errors

2021-01-26 Thread Tiezhu Yang
On 01/27/2021 12:01 AM, Daniel Borkmann wrote: On 1/26/21 3:05 PM, Tiezhu Yang wrote: There exists many build errors when make M=samples/bpf on the Loongson platform, this issue is MIPS related, x86 compiles just fine. Here are some errors: [...] So we can do the similar things in samples/bp

RE: [PATCH V3 1/6] net: stmmac: remove redundant null check for ptp clock

2021-01-26 Thread Joakim Zhang
> -Original Message- > From: Willem de Bruijn > Sent: 2021年1月27日 6:46 > To: Joakim Zhang > Cc: Giuseppe Cavallaro ; Alexandre Torgue > ; Jose Abreu ; David > Miller ; Jakub Kicinski ; Network > Development ; dl-linux-imx ; > Andrew Lunn ; Florian Fainelli > Subject: Re: [PATCH V3 1/6] n

Re: [PATCH net-next] bnxt_en: Convert to use netif_level() helpers.

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 26 Jan 2021 01:20:24 -0500 you wrote: > Use the various netif_level() helpers to simplify the C code. This was > suggested by Joe Perches. > > Cc: Joe Perches > Signed-off-by: Michael Chan > --- > drivers/net/e

Re: [PATCH] usbnet: fix the indentation of one code snippet

2021-01-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 23 Jan 2021 13:11:02 +0800 you wrote: > Every line of code should start with tab (8 characters) > > Signed-off-by: Dongliang Mu > --- > drivers/net/usb/usbnet.c | 12 ++-- > 1 file changed, 6 insertions(+

Re: [PATCH net-next 0/4] Automatically manage DSA master interface state

2021-01-26 Thread Vladimir Oltean
On Wed, Jan 27, 2021 at 03:00:24AM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > This patch series adds code that makes DSA open the master interface > automatically whenever one user interface gets opened, either by the > user, or by various networking subsystems: netconsole, nfsroot

  1   2   3   4   >