[PATCHv16 bpf-next 2/6] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL

2021-01-21 Thread Hangbin Liu
Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be used when we want to allow NULL pointer for map parameter. The bpf helper need to take care and check if the map is NULL when use this type. Signed-off-by: Hangbin Liu --- v13-v15: no update v11-v12: rebase the patch to latest

[PATCHv16 bpf-next 3/6] xdp: add a new helper for dev map multicast support

2021-01-21 Thread Hangbin Liu
This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv16 bpf-next 6/6] selftests/bpf: add xdp_redirect_multi test

2021-01-21 Thread Hangbin Liu
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this test we have 3 forward groups and 1 exclude group. The test will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. We will also test both DEVMAP and DEVMAP_HASH

[PATCHv16 bpf-next 4/6] sample/bpf: add xdp_redirect_map_multicast test

2021-01-21 Thread Hangbin Liu
This is a sample for xdp multicast. In the sample we could forward all packets between given interfaces. There is also an option -X that could enable 2nd xdp_prog on egress interface. Signed-off-by: Hangbin Liu --- v15: use bpf_object__find_program_by_name() instead of bpf_object__find_prog

[PATCHv16 bpf-next 5/6] selftests/bpf: Add verifier tests for bpf arg ARG_CONST_MAP_PTR_OR_NULL

2021-01-21 Thread Hangbin Liu
Use helper bpf_redirect_map() and bpf_redirect_map_multi() to test bpf arg ARG_CONST_MAP_PTR and ARG_CONST_MAP_PTR_OR_NULL. Make sure the map arg could be verified correctly when it is NULL or valid map pointer. Add devmap and devmap_hash in struct bpf_test due to bpf_redirect_{map, map_multi} lim

[PATCHv16 bpf-next 0/6] xdp: add a new helper for dev map multicast support

2021-01-21 Thread Hangbin Liu
This patch is for xdp multicast support. which has been discussed before[0], The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces to forward a

[PATCHv16 bpf-next 1/6] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-01-21 Thread Hangbin Liu
From: Jesper Dangaard Brouer This changes the devmap XDP program support to run the program when the bulk queue is flushed instead of before the frame is enqueued. This has a couple of benefits: - It "sorts" the packets by destination devmap entry, and then runs the same BPF program on all the

Re: [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void

2021-01-21 Thread Marc Kleine-Budde
On Thu, Jan 21, 2021 at 09:48:12PM +0100, Uwe Kleine-König wrote: > The driver core ignores the return value of the remove callback, so > don't give isa drivers the chance to provide a value. > > Adapt all isa_drivers with a remove callbacks accordingly; they all > return 0 unconditionally anyhow.

Re: [PATCH v3] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

2021-01-21 Thread Marc Kleine-Budde
On 1/22/21 4:01 AM, Su Yanjun wrote: > The sizeof(u32) is hardcoded. It's better to use the config value in > regmap. > > It increases the size of target object, but it's flexible when new mcp chip > need other val_bytes. > > Signed-off-by: Su Yanjun > --- > drivers/net/can/spi/mcp251xfd/mcp251

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-21 Thread Jiri Pirko
Thu, Jan 21, 2021 at 05:38:40PM CET, dsah...@gmail.com wrote: >On 1/21/21 8:32 AM, Jiri Pirko wrote: >> Thu, Jan 21, 2021 at 12:41:58AM CET, k...@kernel.org wrote: >>> On Wed, 20 Jan 2021 14:56:46 +0100 Andrew Lunn wrote: > No, the FW does not know. The ASIC is not physically able to get the >>

Re: [PATCH v1] can: mcp251xfd: use regmap_bulk_write for compatibility

2021-01-21 Thread Marc Kleine-Budde
On 1/22/21 4:02 AM, Su Yanjun wrote: > Recently i use mcp2518fd on 4.x kernel which multiple write is not > backported, regmap_raw_write will cause old kernel crash because the > tx buffer in driver is smaller then 2K. Use regmap_bulk_write instead > for compatibility. Hmmm, this patch will never

Re: [PATCH v2 net-next] ibmvnic: workaround QT Creator/libCPlusPlus segfault

2021-01-21 Thread Alexey Dobriyan
On Thu, Jan 21, 2021 at 06:44:54PM -0800, Jakub Kicinski wrote: > On Fri, 22 Jan 2021 01:07:39 +0300 Alexey Dobriyan wrote: > > My name is Alexey and I've tried to use IDE for kernel development. > > > > QT Creator segfaults while parsing ibmvnic.c which is annoying as it > > will start parsing af

Re: [PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w

2021-01-21 Thread Marc Kleine-Budde
On 1/22/21 7:22 AM, Su Yanjun wrote: > When i debug mcp2518fd, some method to track registers is > needed. This easy debug interface will be ok. NACK As the driver uses regmap, everything should be there already. To read use: | cat /sys/kernel/debug/regmap/spi0.0-crc/registers Register write s

[PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w

2021-01-21 Thread Su Yanjun
When i debug mcp2518fd, some method to track registers is needed. This easy debug interface will be ok. For example, read a register at 0xe00: echo 0xe00 > can_get_reg cat can_get_reg write a register at 0xe00: echo 0xe00,0x60 > can_set_reg Signed-off-by: Su Yanjun --- .../net/can/spi/mcp251xf

[PATCH iproute2-next RESEND] devlink: Extend man page for port function set command

2021-01-21 Thread Parav Pandit
Extended devlink-port man page for synopsis, description and example for setting devlink port function attribute. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- man/man8/devlink-port.8 | 21 + 1 file changed, 21 insertions(+) diff --git a/man/man8/devlink-port.8 b/

Re: [Race] data race between dev_ifsioc_locked() and eth_commit_mac_addr_change()

2021-01-21 Thread Gong, Sishuai
Hi, We found this data race can corrupt the variable ifr->ifr_hwaddr.sa_data as only partially updated, so it should be harmful. Under the following interleaving, the writer and reader from these 2 memcpy() can interleave with each other on the variable dev->dev_addr. Thus, ifr->ifr_hwaddr.sa_

Re: [PATCH] net: macb: ignore tx_clk if MII is used

2021-01-21 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 20 Jan 2021 20:43:03 +0100 you wrote: > If the MII interface is used, the PHY is the clock master, thus don't > set the clock rate. On Zynq-7000, this will prevent the following > warning: > macb e000b000.ethernet

Re: [PATCH net-next] net: remove aurora nb8800 driver

2021-01-21 Thread Jakub Kicinski
On Thu, 21 Jan 2021 13:58:42 + Måns Rullgård wrote: > > From: Arnd Bergmann > > > > The tango4 platform is getting removed, and this driver has no > > other known users, so it can be removed. > > > > Cc: Marc Gonzalez > > Cc: Mans Rullgard > > Signed-off-by: Arnd Bergmann > > Acked-by: M

Re: [PATCH net-next v3 1/7] ethtool: Extend link modes settings uAPI with lanes

2021-01-21 Thread Jakub Kicinski
On Wed, 20 Jan 2021 11:37:07 +0200 Danielle Ratson wrote: > Currently, when auto negotiation is on, the user can advertise all the > linkmodes which correspond to a specific speed, but does not have a > similar selector for the number of lanes. This is significant when a > specific speed can be ach

RE: [net-next V9 04/14] devlink: Support get and set state of port function

2021-01-21 Thread Parav Pandit
> From: Samudrala, Sridhar > Sent: Friday, January 22, 2021 2:23 AM > > On 1/21/2021 12:52 AM, Saeed Mahameed wrote: > > From: Parav Pandit > > > > devlink port function can be in active or inactive state. > > Allow users to get and set port function's state. > > > > When the port function it a

RE: [net-next V9 03/14] devlink: Support add and delete devlink port

2021-01-21 Thread Parav Pandit
> From: Samudrala, Sridhar > Sent: Friday, January 22, 2021 2:21 AM > > > $ devlink port show > > pci/:06:00.0/65535: type eth netdev ens2f0np0 flavour physical > > port 0 splittable false > > > > $ devlink port add pci/:06:00.0 flavour pcisf pfnum 0 sfnum 88 > > Do we need to specify

Re: [PATCH net-next 2/3] net: add CSUM_T_IP_GENERIC csum_type

2021-01-21 Thread Xin Long
On Fri, Jan 22, 2021 at 2:13 AM Alexander Duyck wrote: > > On Thu, Jan 21, 2021 at 12:46 AM Xin Long wrote: > > > > This patch is to extend csum_type field to 2 bits, and introduce > > CSUM_T_IP_GENERIC csum type, and add the support for this in > > skb_csum_hwoffload_help(), just like CSUM_T_SCT

Re: [PATCH net-next 1/3] net: rename csum_not_inet to csum_type

2021-01-21 Thread Xin Long
On Fri, Jan 22, 2021 at 10:50 AM Jakub Kicinski wrote: > > On Thu, 21 Jan 2021 16:45:36 +0800 Xin Long wrote: > > This patch is to rename csum_not_inet to csum_type, as later > > more csum type would be introduced in the next patch. > > > > Signed-off-by: Xin Long > > drivers/net/ethernet/hisilic

Re: [PATCHv2 3/3] CDC-NCM: record speed in status method

2021-01-21 Thread Grant Grundler
On Thu, Jan 21, 2021 at 12:57 PM Oliver Neukum wrote: > > The driver has a status method for receiving speed updates. > The framework, however, had support functions only for devices > that reported their speed upon an explicit query over a MDIO > interface. > CDC_NCM however gets direct notificat

[PATCH v3] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

2021-01-21 Thread Su Yanjun
The sizeof(u32) is hardcoded. It's better to use the config value in regmap. It increases the size of target object, but it's flexible when new mcp chip need other val_bytes. Signed-off-by: Su Yanjun --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 9 ++--- 1 file changed, 6 insertions(

[PATCH v1] can: mcp251xfd: use regmap_bulk_write for compatibility

2021-01-21 Thread Su Yanjun
Recently i use mcp2518fd on 4.x kernel which multiple write is not backported, regmap_raw_write will cause old kernel crash because the tx buffer in driver is smaller then 2K. Use regmap_bulk_write instead for compatibility. Signed-off-by: Su Yanjun --- drivers/net/can/spi/mcp251xfd/mcp251xfd-co

Re: [PATCHv2 2/3] usbnet: add method for reporting speed without MDIO

2021-01-21 Thread Grant Grundler
On Thu, Jan 21, 2021 at 12:57 PM Oliver Neukum wrote: > > The old method for reporting network speed upwards > assumed that a device uses MDIO and uses the generic phy > functions based on that. > Add a a primitive internal version not making the assumption > reporting back directly what the statu

Re: [PATCH net-next 1/3] net: rename csum_not_inet to csum_type

2021-01-21 Thread Jakub Kicinski
On Thu, 21 Jan 2021 16:45:36 +0800 Xin Long wrote: > This patch is to rename csum_not_inet to csum_type, as later > more csum type would be introduced in the next patch. > > Signed-off-by: Xin Long drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:1073:11: error: ‘struct sk_buff’ has no member na

[PATCHv10 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2021-01-21 Thread Hangbin Liu
This patch add a xdp program on egress to show that we can modify the packet on egress. In this sample we will set the pkt's src mac to egress's mac address. The xdp_prog will be attached when -X option supplied. Signed-off-by: Hangbin Liu --- v10: make xdp_redirect_map() always inline. v9: roll

Re: [PATCH net-next 2/2] udp: allow forwarding of plain (non-fraglisted) UDP GRO packets

2021-01-21 Thread Willem de Bruijn
On Mon, Jan 18, 2021 at 2:33 PM Alexander Lobakin wrote: > > Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") actually > not only added a support for fraglisted UDP GRO, but also tweaked > some logics the way that non-fraglisted UDP GRO started to work for > forwarding too. > Commit 2e4e

Re: [PATCH v2 net-next] ibmvnic: workaround QT Creator/libCPlusPlus segfault

2021-01-21 Thread Jakub Kicinski
On Fri, 22 Jan 2021 01:07:39 +0300 Alexey Dobriyan wrote: > My name is Alexey and I've tried to use IDE for kernel development. > > QT Creator segfaults while parsing ibmvnic.c which is annoying as it > will start parsing after restart only to crash again. > > The workaround is to either exclude

[PATCH v2 2/3] drivers: thermal: Remove thermal_notify_framework

2021-01-21 Thread Thara Gopinath
thermal_notify_framework just updates for a single trip point where as thermal_zone_device_update does other bookkeeping like updating the temperature of the thermal zone and setting the next trip point. The only driver that was using thermal_notify_framework was updated in the previous patch to us

[PATCH v2 3/3] Documentation: driver-api: thermal: Remove thermal_notify_framework from documentation

2021-01-21 Thread Thara Gopinath
Since thermal_notify_framework is no longer supported/implemented remove the entry from sysfs-api.rst. --- Documentation/driver-api/thermal/sysfs-api.rst | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/Documentation/driver-api/thermal/sysfs-api.rst b/Documentation

Re: [PATCH net] team: postpone features update to avoid deadlock

2021-01-21 Thread Jakub Kicinski
On Thu, 21 Jan 2021 11:29:37 +0100 Ivan Vecera wrote: > On Wed, 20 Jan 2021 15:18:20 -0800 > Cong Wang wrote: > > On Wed, Jan 20, 2021 at 4:56 AM Ivan Vecera wrote: > > > Team driver protects port list traversal by its team->lock mutex > > > in functions like team_change_mtu(), team_set_rx_mode

[PATCH v2 0/3] thermal: Replace thermal_notify_framework with thermal_zone_device_update

2021-01-21 Thread Thara Gopinath
thermal_notify_framework just updates for a single trip point where as thermal_zone_device_update does other bookkeeping like updating the temperature of the thermal zone, running through the list of trip points and setting the next trip point etc. Since the later is a more thorough version of for

[PATCH v2 1/3] iwlwifi: mvm: tt: Replace thermal_notify_framework

2021-01-21 Thread Thara Gopinath
thermal_notify_framework just updates for a single trip point where as thermal_zone_device_update does other bookkeeping like updating the temperature of the thermal zone and setting the next trip point etc. Replace thermal_notify_framework with thermal_zone_device_update as the later is more thoro

Re: [net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-21 Thread Marcelo Ricardo Leitner
On Fri, Jan 22, 2021 at 02:18:34AM +0100, Pablo Neira Ayuso wrote: > Hi Oz, > > On Wed, Jan 20, 2021 at 06:09:48PM +0200, Oz Shlomo wrote: > > On 1/14/2021 11:50 PM, Marcelo Ricardo Leitner wrote: > > > > > > Thoughts? > > > > > > > I wonder if we should develop a generic mechanism to optimize

Re: [PATCHv2 0/3] usbnet: speed reporting for devices without MDIO

2021-01-21 Thread Grant Grundler
On Fri, Jan 22, 2021 at 1:29 AM Andrew Lunn wrote: > > On Thu, Jan 21, 2021 at 01:57:28PM +0100, Oliver Neukum wrote: > > This series introduces support for USB network devices that report > > speed as a part of their protocol, not emulating an MII to be accessed > > over MDIO. > > > > v2: adjuste

[PATCH bpf-next v4] samples/bpf: Update build procedure for manually compiling LLVM and Clang

2021-01-21 Thread Tiezhu Yang
The current LLVM and Clang build procedure in samples/bpf/README.rst is out of date. See below that the links are not accessible any more. $ git clone http://llvm.org/git/llvm.git Cloning into 'llvm'... fatal: unable to access 'http://llvm.org/git/llvm.git/': Maximum (20) redirects followed $ git

Re: [PATCHv2 2/3] usbnet: add method for reporting speed without MDIO

2021-01-21 Thread Grant Grundler
On Thu, Jan 21, 2021 at 12:57 PM Oliver Neukum wrote: > > The old method for reporting network speed upwards > assumed that a device uses MDIO and uses the generic phy > functions based on that. > Add a a primitive internal version not making the assumption > reporting back directly what the statu

Re: [PATCH v2 net-next 5/5] mptcp: implement delegated actions

2021-01-21 Thread Jakub Kicinski
On Wed, 20 Jan 2021 15:39:14 +0100 Paolo Abeni wrote: > On MPTCP-level ack reception, the packet scheduler > may select a subflow other then the current one. > > Prior to this commit we rely on the workqueue to trigger > action on such subflow. > > This changeset introduces an infrastructure that

Re: [PATCHv2 0/3] usbnet: speed reporting for devices without MDIO

2021-01-21 Thread Andrew Lunn
On Thu, Jan 21, 2021 at 01:57:28PM +0100, Oliver Neukum wrote: > This series introduces support for USB network devices that report > speed as a part of their protocol, not emulating an MII to be accessed > over MDIO. > > v2: adjusted to recent changes Hi Oliver Please give more details what act

Re: [PATCH bpf-next 2/2] selftests/bpf: verify that rebinding to port < 1024 from BPF works

2021-01-21 Thread Martin KaFai Lau
On Thu, Jan 21, 2021 at 04:30:08PM -0800, s...@google.com wrote: > On 01/21, Martin KaFai Lau wrote: > > On Thu, Jan 21, 2021 at 02:57:44PM -0800, s...@google.com wrote: > > > On 01/21, Martin KaFai Lau wrote: > > > > On Wed, Jan 20, 2021 at 05:22:41PM -0800, Stanislav Fomichev wrote: > > > > > BPF

Re: [PATCH net v2 1/2] net: mrp: fix definitions of MRP test packets

2021-01-21 Thread Horatiu Vultur
The 01/21/2021 21:40, Rasmus Villemoes wrote: It seems that is missing a Fixes tag, other than that it looks fine. Reviewed-by: Horatiu Vultur > > Wireshark says that the MRP test packets cannot be decoded - and the > reason for that is that there's a two-byte hole filled with garbage > betwee

Re: [PATCH] cxgb4: Assign boolean values to a bool variable

2021-01-21 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 20 Jan 2021 15:01:51 +0800 you wrote: > Fix the following coccicheck warnings: > > ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:5142:2-33: > WARNING: Assignment of 0/1 to bool variable. > > Reported-by: Abaci

[PATCH v2 iproute2] man: tc-taprio.8: document the full offload feature

2021-01-21 Thread Vladimir Oltean
From: Vladimir Oltean Since this feature's introduction in commit 9c66d1564676 ("taprio: Add support for hardware offloading") from kernel v5.4, it never got documented in the man pages. Due to this reason, we see customer reports of seemingly contradictory information: the community manpages cla

Re: [PATCH v2 net-next] cxgb4: remove bogus CHELSIO_VPD_UNIQUE_ID constant

2021-01-21 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 20 Jan 2021 08:27:14 +0100 you wrote: > The comment is quite weird, there is no such thing as a vendor-specific > VPD id. 0x82 is the value of PCI_VPD_LRDT_ID_STRING. So what we are > doing here is simply checking w

Re: [net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-21 Thread Pablo Neira Ayuso
Hi Oz, On Wed, Jan 20, 2021 at 06:09:48PM +0200, Oz Shlomo wrote: > On 1/14/2021 11:50 PM, Marcelo Ricardo Leitner wrote: > > > > Thoughts? > > > > I wonder if we should develop a generic mechanism to optimize CT software > for a use case that is faulty by design. > This has limited value for s

Re: [PATCH iproute2] man: tc-taprio.8: document the full offload feature

2021-01-21 Thread David Ahern
On 1/21/21 5:37 PM, Vladimir Oltean wrote: > On Thu, Jan 21, 2021 at 04:10:06PM -0700, David Ahern wrote: >> On 1/21/21 2:57 PM, Vladimir Oltean wrote: >>> On Thu, Jan 21, 2021 at 11:47:08PM +0200, Vladimir Oltean wrote: +Enables the full-offload feature. In this mode, taprio will pass the gat

Re: [PATCHv2 1/3] usbnet: specify naming of usbnet_set/get_link_ksettings

2021-01-21 Thread Andrew Lunn
On Thu, Jan 21, 2021 at 01:57:29PM +0100, Oliver Neukum wrote: > The old generic functions assume that the devices includes > an MDIO interface. This is true only for genuine ethernet. > Devices with a higher level of abstraction or based on different > technologies do not have it. So in preparatio

Re: [PATCH v2] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

2021-01-21 Thread Jakub Kicinski
Bjorn, I think this was posted before you pointed out the missing CCs and Giacinto didn't repost. Looks good? On Wed, 20 Jan 2021 05:56:50 +0100 Giacinto Cifelli wrote: > Bus 003 Device 009: ID 1e2d:006f > Device Descriptor: > bLength18 > bDescriptorType 1 > bcdUSB

Re: [PATCH net-next] vmxnet3: Remove buf_info from device accessible structures

2021-01-21 Thread Jakub Kicinski
On Tue, 19 Jan 2021 18:19:40 -0800 Ronak Doshi wrote: > From: Petr Vandrovec > > vmxnet3: Remove buf_info from device accessible structures Something happened to the posting, looks like the subject is listed twice? > buf_info structures in RX & TX queues are private driver data that > do not ne

Re: [PATCH v1 0/2] isa: Make the remove callback for isa drivers return void

2021-01-21 Thread William Breathitt Gray
On Thu, Jan 21, 2021 at 09:48:10PM +0100, Uwe Kleine-König wrote: > Hello, > > as described in the commit log of the 2nd patch returning an error code > from a bus' remove callback doesn't make any difference as the driver > core ignores it and still considers the device removed. > > So change th

[PATCH v3] Bluetooth: Keep MSFT ext info throughout ahci_dev's life cycle

2021-01-21 Thread Miao-chen Chou
This moves msft_do_close() from hci_dev_do_close() to hci_unregister_dev() to avoid clearing MSFT extension info. This also avoids retrieving MSFT info upon every msft_do_open() if MSFT extension has been initialized. The following test steps were performed. (1) boot the test device and verify the

Re: [PATCH iproute2] man: tc-taprio.8: document the full offload feature

2021-01-21 Thread Vladimir Oltean
On Thu, Jan 21, 2021 at 04:10:06PM -0700, David Ahern wrote: > On 1/21/21 2:57 PM, Vladimir Oltean wrote: > > On Thu, Jan 21, 2021 at 11:47:08PM +0200, Vladimir Oltean wrote: > >> +Enables the full-offload feature. In this mode, taprio will pass the gate > >> +control list to the NIC which will exe

[PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. While looking into the source code I found duplicate assignments in misc tools for the LLVM eco system, e.g. clang and llvm-objcopy. Move the Clang, LLC and/or LLVM utils definitions to tools/scripts/Makefile.include file an

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:21 AM Sedat Dilek wrote: > > On Fri, Jan 22, 2021 at 1:12 AM Sedat Dilek wrote: > > > > On Fri, Jan 22, 2021 at 1:04 AM Andrii Nakryiko > > wrote: > > > > > > On Wed, Jan 20, 2021 at 2:36 PM Jiri Olsa wrote: > > > > > > > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sed

Re: [PATCH bpf-next 2/2] selftests/bpf: verify that rebinding to port < 1024 from BPF works

2021-01-21 Thread Andrii Nakryiko
On Thu, Jan 21, 2021 at 4:09 PM wrote: > > On 01/21, Andrii Nakryiko wrote: > > On Wed, Jan 20, 2021 at 7:16 PM Stanislav Fomichev wrote: > > > > > > BPF rewrites from 111 to 111, but it still should mark the port as > > > "changed". > > > We also verify that if port isn't touched by BPF, it's st

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:12 AM Sedat Dilek wrote: > > On Fri, Jan 22, 2021 at 1:04 AM Andrii Nakryiko > wrote: > > > > On Wed, Jan 20, 2021 at 2:36 PM Jiri Olsa wrote: > > > > > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote: > > > > When dealing with BPF/BTF/pahole and DWARF v5

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:04 AM Andrii Nakryiko wrote: > > On Wed, Jan 20, 2021 at 2:36 PM Jiri Olsa wrote: > > > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote: > > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > > > > > > While looking into the source

Re: [net-next V9 14/14] net/mlx5: Add devlink subfunction port documentation

2021-01-21 Thread Jason Gunthorpe
On Thu, Jan 21, 2021 at 12:59:55PM -0800, Samudrala, Sridhar wrote: > > + mlx5_core.sf.4 > > + (subfunction auxiliary device) > > + /\ > > + / \ > > + /\ > > +/ \ > > +

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Andrii Nakryiko
On Wed, Jan 20, 2021 at 2:36 PM Jiri Olsa wrote: > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote: > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > > > > While looking into the source code I found duplicate assignments > > in misc tools for the LLVM eco

Re: [PATCH bpf-next 2/2] selftests/bpf: verify that rebinding to port < 1024 from BPF works

2021-01-21 Thread Andrii Nakryiko
On Wed, Jan 20, 2021 at 7:16 PM Stanislav Fomichev wrote: > > BPF rewrites from 111 to 111, but it still should mark the port as > "changed". > We also verify that if port isn't touched by BPF, it's still prohibited. > > Signed-off-by: Stanislav Fomichev > --- > .../selftests/bpf/prog_tests/bind

Re: [PATCH bpf-next 2/2] selftests/bpf: verify that rebinding to port < 1024 from BPF works

2021-01-21 Thread Martin KaFai Lau
On Thu, Jan 21, 2021 at 02:57:44PM -0800, s...@google.com wrote: > On 01/21, Martin KaFai Lau wrote: > > On Wed, Jan 20, 2021 at 05:22:41PM -0800, Stanislav Fomichev wrote: > > > BPF rewrites from 111 to 111, but it still should mark the port as > > > "changed". > > > We also verify that if port is

Re: [PATCH bpf-next 3/3] libbpf: Use string table index from index table if needed

2021-01-21 Thread Andrii Nakryiko
On Thu, Jan 21, 2021 at 12:26 PM Jiri Olsa wrote: > > For very large ELF objects (with many sections), we could > get special value SHN_XINDEX (65535) for elf object's string > table index - e_shstrndx. > > Call elf_getshdrstrndx to get the proper string table index, > instead of reading it direct

[PATCH resend net] net: switchdev: don't set port_obj_info->handled true when -EOPNOTSUPP

2021-01-21 Thread Rasmus Villemoes
It's not true that switchdev_port_obj_notify() only inspects the ->handled field of "struct switchdev_notifier_port_obj_info" if call_switchdev_blocking_notifiers() returns 0 - there's a WARN_ON() triggering for a non-zero return combined with ->handled not being true. But the real problem here is

Re: [PATCH 1/3] elf_symtab: Add support for SHN_XINDEX index to elf_section_by_name

2021-01-21 Thread Jiri Olsa
On Thu, Jan 21, 2021 at 03:10:25PM -0800, Andrii Nakryiko wrote: > On Thu, Jan 21, 2021 at 12:24 PM Jiri Olsa wrote: > > > > In case the elf's header e_shstrndx contains SHN_XINDEX, > > we need to call elf_getshdrstrndx to get the proper > > string table index. > > > > Signed-off-by: Jiri Olsa >

Re: [PATCH 2/3] bpf_encoder: Translate SHN_XINDEX in symbol's st_shndx values

2021-01-21 Thread Andrii Nakryiko
On Thu, Jan 21, 2021 at 12:25 PM Jiri Olsa wrote: > > For very large ELF objects (with many sections), we could > get special value SHN_XINDEX (65535) for symbol's st_shndx. > > This patch is adding code to detect the optional extended > section index table and use it to resolve symbol's section >

Re: [PATCH net-next v2 6/8] igc: Add support for tuning frame preemption via ethtool

2021-01-21 Thread Vinicius Costa Gomes
Jakub Kicinski writes: > On Mon, 18 Jan 2021 16:40:26 -0800 Vinicius Costa Gomes wrote: >> +NL_SET_ERR_MSG(extack, "Invalid value for add-frag-size"); > > NL_SET_ERR_MSG_MOD Will fix. Thanks. Cheers, -- Vinicius

Re: [PATCH net-next v2 1/8] ethtool: Add support for configuring frame preemption

2021-01-21 Thread Vinicius Costa Gomes
Jakub Kicinski writes: > On Mon, 18 Jan 2021 16:40:21 -0800 Vinicius Costa Gomes wrote: >> + == == >> + ``ETHTOOL_A_CHANNELS_HEADER`` nested request header > > ETHTOOL_A_PREEMPT_HEADER > >> + ==

Re: [PATCH net-next v2 2/8] taprio: Add support for frame preemption offload

2021-01-21 Thread Vinicius Costa Gomes
Jakub Kicinski writes: > On Mon, 18 Jan 2021 16:40:22 -0800 Vinicius Costa Gomes wrote: >> Adds a way to configure which traffic classes are marked as >> preemptible and which are marked as express. >> >> Even if frame preemption is not a "real" offload, because it can't be >> executed purely in

Re: [PATCH iproute2] man: tc-taprio.8: document the full offload feature

2021-01-21 Thread David Ahern
On 1/21/21 2:57 PM, Vladimir Oltean wrote: > On Thu, Jan 21, 2021 at 11:47:08PM +0200, Vladimir Oltean wrote: >> +Enables the full-offload feature. In this mode, taprio will pass the gate >> +control list to the NIC which will execute cyclically it in hardware. > > Ugh, I meant "execute it cyclica

Re: [PATCH 1/3] elf_symtab: Add support for SHN_XINDEX index to elf_section_by_name

2021-01-21 Thread Andrii Nakryiko
On Thu, Jan 21, 2021 at 12:24 PM Jiri Olsa wrote: > > In case the elf's header e_shstrndx contains SHN_XINDEX, > we need to call elf_getshdrstrndx to get the proper > string table index. > > Signed-off-by: Jiri Olsa > --- > dutil.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-)

Re: [PATCH net-next] net: ethtool: allow MAC drivers to override ethtool get_ts_info

2021-01-21 Thread Russell King - ARM Linux admin
On Thu, Jan 21, 2021 at 07:55:34PM +0100, Andrew Lunn wrote: > On Thu, Jan 21, 2021 at 09:03:47AM -0800, Richard Cochran wrote: > > On Thu, Jan 21, 2021 at 05:22:37PM +0100, Andrew Lunn wrote: > > > > > There is a growing interesting in PTP, the number of drivers keeps > > > going up. The likeliho

Re: [PATCH] dsa: vsc73xx: add support for vlan filtering

2021-01-21 Thread Vladimir Oltean
Hi Pawel, On Wed, Jan 20, 2021 at 07:30:18AM +0100, Pawel Dembicki wrote: > This patch adds support for vlan filtering in vsc73xx driver. > > After vlan filtering enable, CPU_PORT is configured as trunk, without > non-tagged frames. This allows to avoid problems with transmit untagged > frames be

Re: [PATCH net] ibmvnic: device remove has higher precedence over reset

2021-01-21 Thread Sukadev Bhattiprolu
Lijun Pan [lijunp...@gmail.com] wrote: > > > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c > > > b/drivers/net/ethernet/ibm/ibmvnic.c > > > index aed985e08e8a..11f28fd03057 100644 > > > --- a/drivers/net/ethernet/ibm/ibmvnic.c > > > +++ b/drivers/net/ethernet/ibm/ibmvnic.c > > > @@ -2235,8 +2235,

Re: [PATCH bpf-next 2/2] selftests/bpf: verify that rebinding to port < 1024 from BPF works

2021-01-21 Thread Martin KaFai Lau
On Wed, Jan 20, 2021 at 05:22:41PM -0800, Stanislav Fomichev wrote: > BPF rewrites from 111 to 111, but it still should mark the port as > "changed". > We also verify that if port isn't touched by BPF, it's still prohibited. > > Signed-off-by: Stanislav Fomichev > --- > .../selftests/bpf/prog_te

Re: [PATCH net-next] ibmvnic: workaround QT Creator/libCPlusPlus segfault

2021-01-21 Thread Andrew Lunn
On Fri, Jan 22, 2021 at 01:01:50AM +0300, Alexey Dobriyan wrote: > My name is Alexey and I've tried to use IDE for kernel development. > > QT Creator segfaults while parsing ibmvnic.c which is annoying as it > will start parsing after restart only to crash again. > > The workaround is to either e

[PATCH net 0/1] Fix big endian definition of ipv6_rpl_sr_hdr

2021-01-21 Thread Justin Iurman
Following RFC 6554 [1], the current order of fields is wrong for big endian definition. Indeed, here is how the header looks like: +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Next Header | Hdr Ext Len | Routing Type | Segments Left | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

[PATCH net 1/1] uapi: fix big endian definition of ipv6_rpl_sr_hdr

2021-01-21 Thread Justin Iurman
Following RFC 6554 [1], the current order of fields is wrong for big endian definition. Indeed, here is how the header looks like: +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Next Header | Hdr Ext Len | Routing Type | Segments Left | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

[PATCH v2 net-next] ibmvnic: workaround QT Creator/libCPlusPlus segfault

2021-01-21 Thread Alexey Dobriyan
My name is Alexey and I've tried to use IDE for kernel development. QT Creator segfaults while parsing ibmvnic.c which is annoying as it will start parsing after restart only to crash again. The workaround is to either exclude ibmvnic.c from list of project files or to apply dummy ifdef to hide t

Re: More flexible BPF socket inet_lookup hooking after listening sockets are dispatched

2021-01-21 Thread Martin KaFai Lau
On Thu, Jan 21, 2021 at 09:40:19PM +0100, Shanti Lombard wrote: > Le 2021-01-21 12:14, Jakub Sitnicki a écrit : > > On Wed, Jan 20, 2021 at 10:06 PM CET, Alexei Starovoitov wrote: > > > > There is also documentation in the kernel: > > > > https://www.kernel.org/doc/html/latest/bpf/prog_sk_lookup.

[PATCH net-next] ibmvnic: workaround QT Creator/libCPlusPlus segfault

2021-01-21 Thread Alexey Dobriyan
My name is Alexey and I've tried to use IDE for kernel development. QT Creator segfaults while parsing ibmvnic.c which is annoying as it will start parsing after restart only to crash again. The workaround is to either exclude ibmvnic.c from list of project files or to apply dummy ifdef to hide t

Re: [PATCH iproute2] man: tc-taprio.8: document the full offload feature

2021-01-21 Thread Vladimir Oltean
On Thu, Jan 21, 2021 at 11:47:08PM +0200, Vladimir Oltean wrote: > +Enables the full-offload feature. In this mode, taprio will pass the gate > +control list to the NIC which will execute cyclically it in hardware. Ugh, I meant "execute it cyclically" not "execute cyclically it". David, could you

[PATCH iproute2] man: tc-taprio.8: document the full offload feature

2021-01-21 Thread Vladimir Oltean
From: Vladimir Oltean Since this feature's introduction in commit 9c66d1564676 ("taprio: Add support for hardware offloading") from kernel v5.4, it never got documented in the man pages. Due to this reason, we see customer reports of seemingly contradictory information: the community manpages cla

Re: [PATCH] rdma.8: Add basic description for users unfamiliar with rdma

2021-01-21 Thread Alan Perry
On 12/23/20 12:19 AM, Leon Romanovsky wrote: On Tue, Dec 22, 2020 at 08:47:51PM -0800, Alan Perry wrote: Add a description section with basic info about the rdma command for users unfamiliar with it. Signed-off-by: Alan Perry --- man/man8/rdma.8 | 6 +- 1 file changed, 5 insertion(+)

Re: [PATCH net v2 1/2] net: mrp: fix definitions of MRP test packets

2021-01-21 Thread Rasmus Villemoes
On 21/01/2021 22.23, Horatiu Vultur wrote: > The 01/21/2021 21:40, Rasmus Villemoes wrote: > > It seems that is missing a Fixes tag, other than that it looks fine. That would be these two I guess: Fixes: 2801758391ba ("bridge: uapi: mrp: Extend MRP attributes for MRP interconnect") Fixes: 4714d1

[PATCH v1 2/2] isa: Make the remove callback for isa drivers return void

2021-01-21 Thread Uwe Kleine-König
The driver core ignores the return value of the remove callback, so don't give isa drivers the chance to provide a value. Adapt all isa_drivers with a remove callbacks accordingly; they all return 0 unconditionally anyhow. Signed-off-by: Uwe Kleine-König --- drivers/base/isa.c

[PATCH v1 0/2] isa: Make the remove callback for isa drivers return void

2021-01-21 Thread Uwe Kleine-König
Hello, as described in the commit log of the 2nd patch returning an error code from a bus' remove callback doesn't make any difference as the driver core ignores it and still considers the device removed. So change the remove callback to return void to not give driver authors an incentive to beli

Re: [PATCH] MAINTAINERS: add entry for Arrow SpeedChips XRS7000 driver

2021-01-21 Thread Jakub Kicinski
On Wed, 20 Jan 2021 07:53:23 -0600 George McCollister wrote: > Add myself as maintainer of the Arrow SpeedChips XRS7000 series Ethernet > switch driver. > > Suggested-by: Jakub Kicinski > Signed-off-by: George McCollister Applied, thank you!

Re: [net-next V9 14/14] net/mlx5: Add devlink subfunction port documentation

2021-01-21 Thread Samudrala, Sridhar
On 1/21/2021 12:52 AM, Saeed Mahameed wrote: From: Parav Pandit Add documentation for subfunction management using devlink port. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../device_drivers/ethernet/mellanox/mlx5.rst | 210 ++ 1 file changed, 210 insert

Re: [net-next V9 04/14] devlink: Support get and set state of port function

2021-01-21 Thread Samudrala, Sridhar
On 1/21/2021 12:52 AM, Saeed Mahameed wrote: From: Parav Pandit devlink port function can be in active or inactive state. Allow users to get and set port function's state. When the port function it activated, its operational state may change after a while when the device is created and driver

Re: [net-next V9 03/14] devlink: Support add and delete devlink port

2021-01-21 Thread Samudrala, Sridhar
On 1/21/2021 12:52 AM, Saeed Mahameed wrote: From: Parav Pandit Extended devlink interface for the user to add and delete a port. Extend devlink to connect user requests to driver to add/delete a port in the device. Driver routines are invoked without holding devlink instance lock. This enable

Re: More flexible BPF socket inet_lookup hooking after listening sockets are dispatched

2021-01-21 Thread Shanti Lombard
Le 2021-01-21 12:14, Jakub Sitnicki a écrit : On Wed, Jan 20, 2021 at 10:06 PM CET, Alexei Starovoitov wrote: There is also documentation in the kernel: https://www.kernel.org/doc/html/latest/bpf/prog_sk_lookup.html Thank you, I saw it, it's well written and very much explains it all. Exi

[PATCH net v2 0/2] fix and move definitions of MRP data structures

2021-01-21 Thread Rasmus Villemoes
v2: update commit log of the patch to include comments on 32 bit alignment; include second patch moving the structs out of uapi. Rasmus Villemoes (2): net: mrp: fix definitions of MRP test packets net: mrp: move struct definitions out of uapi include/uapi/linux/mrp_bridge.h | 86

[PATCH net v2 2/2] net: mrp: move struct definitions out of uapi

2021-01-21 Thread Rasmus Villemoes
None of these are actually used in the kernel/userspace interface - there's a userspace component of implementing MRP, and userspace will need to construct certain frames to put on the wire, but there's no reason the kernel should provide the relevant definitions in a UAPI header. In fact, most of

[PATCH net v2 1/2] net: mrp: fix definitions of MRP test packets

2021-01-21 Thread Rasmus Villemoes
Wireshark says that the MRP test packets cannot be decoded - and the reason for that is that there's a two-byte hole filled with garbage between the "transitions" and "timestamp" members. So Wireshark decodes the two garbage bytes and the top two bytes of the timestamp written by the kernel as the

Re: [PATCH v6 net-next 07/10] net: dsa: allow changing the tag protocol via the "tagging" device attribute

2021-01-21 Thread Florian Fainelli
On 1/21/2021 8:01 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Currently DSA exposes the following sysfs: > $ cat /sys/class/net/eno2/dsa/tagging > ocelot > > which is a read-only device attribute, introduced in the kernel as > commit 98cdb4807123 ("net: dsa: Expose tagging protocol

Re: [PATCH net-next v2 00/17] ucc_geth improvements

2021-01-21 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 19 Jan 2021 16:07:45 +0100 you wrote: > This is a resend of some improvements to the ucc_geth driver that was > previously sent together with bug fixes, which have by now been > applied. > > Li Yang, if you don't

[PATCH bpf-next 3/3] libbpf: Use string table index from index table if needed

2021-01-21 Thread Jiri Olsa
For very large ELF objects (with many sections), we could get special value SHN_XINDEX (65535) for elf object's string table index - e_shstrndx. Call elf_getshdrstrndx to get the proper string table index, instead of reading it directly from ELF header. Signed-off-by: Jiri Olsa --- tools/lib/bp

  1   2   3   >