[PATCH v3 bpf-next 7/7] selftests/bpf: test kernel module ksym externs

2021-01-11 Thread Andrii Nakryiko
Add per-CPU variable to bpf_testmod.ko and use those from new selftest to validate it works end-to-end. Acked-by: Yonghong Song Acked-by: Hao Luo Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/bpf_testmod/bpf_testmod.c | 3 ++ .../selftests/bpf/prog_tests/ksyms_module.c | 31 +++

[PATCH v3 bpf-next 5/7] bpf: support BPF ksym variables in kernel modules

2021-01-11 Thread Andrii Nakryiko
Add support for directly accessing kernel module variables from BPF programs using special ldimm64 instructions. This functionality builds upon vmlinux ksym support, but extends ldimm64 with src_reg=BPF_PSEUDO_BTF_ID to allow specifying kernel module BTF's FD in insn[1].imm field. During BPF progr

[PATCH v3 bpf-next 3/7] bpf: declare __bpf_free_used_maps() unconditionally

2021-01-11 Thread Andrii Nakryiko
__bpf_free_used_maps() is always defined in kernel/bpf/core.c, while include/linux/bpf.h is guarding it behind CONFIG_BPF_SYSCALL. Move it out of that guard region and fix compiler warning. Reported-by: kernel test robot Fixes: a2ea07465c8d ("bpf: Fix missing prog untrack in release_maps") Acked-

[PATCH v3 bpf-next 6/7] libbpf: support kernel module ksym externs

2021-01-11 Thread Andrii Nakryiko
Add support for searching for ksym externs not just in vmlinux BTF, but across all module BTFs, similarly to how it's done for CO-RE relocations. Kernels that expose module BTFs through sysfs are assumed to support new ldimm64 instruction extension with BTF FD provided in insn[1].imm field, so no e

[PATCH v3 bpf-next 4/7] selftests/bpf: sync RCU before unloading bpf_testmod

2021-01-11 Thread Andrii Nakryiko
If some of the subtests use module BTFs through ksyms, they will cause bpf_prog to take a refcount on bpf_testmod module, which will prevent it from successfully unloading. Module's refcnt is decremented when bpf_prog is freed, which generally happens in RCU callback. So we need to trigger syncroni

[PATCH v3 bpf-next 0/7] Support kernel module ksym variables

2021-01-11 Thread Andrii Nakryiko
Add support for using kernel module global variables (__ksym externs in BPF program). BPF verifier will now support ldimm64 with src_reg=BPF_PSEUDO_BTF_ID and non-zero insn[1].imm field, specifying module BTF's FD. In such case, module BTF object, similarly to BPF maps referenced from ldimm64 with

[PATCH v3 bpf-next 2/7] bpf: avoid warning when re-casting __bpf_call_base into __bpf_call_base_args

2021-01-11 Thread Andrii Nakryiko
BPF interpreter uses extra input argument, so re-casts __bpf_call_base into __bpf_call_base_args. Avoid compiler warning about incompatible function prototypes by casting to void * first. Reported-by: kernel test robot Fixes: 1ea47e01ad6e ("bpf: add support for bpf_call to interpreter") Acked-by:

[PATCH v3 bpf-next 1/7] bpf: add bpf_patch_call_args prototype to include/linux/bpf.h

2021-01-11 Thread Andrii Nakryiko
Add bpf_patch_call_args() prototype. This function is called from BPF verifier and only if CONFIG_BPF_JIT_ALWAYS_ON is not defined. This fixes compiler warning about missing prototype in some kernel configurations. Reported-by: kernel test robot Fixes: 1ea47e01ad6e ("bpf: add support for bpf_call

Re: [PATCH net-next 1/2] udp: call udp_encap_enable for v6 sockets when enabling encap

2021-01-11 Thread Xin Long
ing-v4-packets-with-UDP-GRO/20210111-205115 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > 73b7a6047971aa6ce4a70fc4901964d14f077171 > config: m68k-defconfig (attached as .config) > compiler: m68k-linux-gcc (GCC) 9.3.0 > reproduce (thi

Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Greg KH
On Tue, Jan 12, 2021 at 01:36:29PM +0800, Cindy Lu wrote: > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > this cb.private will finally use in vhost_vdpa_config_cb as > vhost_vdpa. Fix this issue. > > Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") > Ac

Re: [PATCH v2] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Greg KH
On Tue, Jan 12, 2021 at 01:32:27PM +0800, Cindy Lu wrote: > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > this cb.private will finally use in vhost_vdpa_config_cb as > vhost_vdpa. Fix this issue. > > Signed-off-by: Cindy Lu > --- > drivers/vhost/vdpa.c | 2 +- > 1 file ch

Re: [RFC PATCH bpf-next 1/2] bpf: share BTF "show" implementation between kernel and libbpf

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 9:34 AM Alan Maguire wrote: > > libbpf already supports a "dumper" API for dumping type information, > but there is currently no support for dumping typed _data_ via libbpf. > However this functionality does exist in the kernel, in part to > facilitate the bpf_snprintf_btf(

Re: [PATCH bpf-next 4/4] bpf: runqslower: use task local storage

2021-01-11 Thread Yonghong Song
On 1/11/21 11:14 PM, Andrii Nakryiko wrote: On Mon, Jan 11, 2021 at 7:24 PM Yonghong Song wrote: On 1/11/21 2:54 PM, Song Liu wrote: On Jan 11, 2021, at 9:49 AM, Yonghong Song wrote: On 1/8/21 3:19 PM, Song Liu wrote: Replace hashtab with task local storage in runqslower. This im

Re: [PATCH bpf-next 2/2] selftests: bpf: Add a new test for bare tracepoints

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 10:20 AM Qais Yousef wrote: > > Reuse module_attach infrastructure to add a new bare tracepoint to check > we can attach to it as a raw tracepoint. > > Signed-off-by: Qais Yousef > --- > > Andrii > > I was getting the error below when I was trying to run the test. > I had

Re: [PATCH net-next 1/2] net: move the hsize check to the else block in skb_segment

2021-01-11 Thread Xin Long
On Tue, Jan 12, 2021 at 12:26 AM Alexander Duyck wrote: > > On Mon, Jan 11, 2021 at 4:45 AM Xin Long wrote: > > > > After commit 89319d3801d1 ("net: Add frag_list support to skb_segment"), > > it goes to process frag_list when !hsize in skb_segment(). However, when > > using skb frag_list, sg nor

Re: [PATCH bpf-next 4/4] bpf: runqslower: use task local storage

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 7:24 PM Yonghong Song wrote: > > > > On 1/11/21 2:54 PM, Song Liu wrote: > > > > > >> On Jan 11, 2021, at 9:49 AM, Yonghong Song wrote: > >> > >> > >> > >> On 1/8/21 3:19 PM, Song Liu wrote: > >>> Replace hashtab with task local storage in runqslower. This improves the > >

[net-next V2 07/11] net/mlx5e: CT: Remove redundant usage of zone mask

2021-01-11 Thread Saeed Mahameed
From: Roi Dayan The zone member is of type u16 so there is no reason to apply the zone mask on it. This is also matching the call to set a match in other places which don't need and don't apply the mask. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- driv

[net-next V2 06/11] net/mlx5e: Remove redundant initialization to null

2021-01-11 Thread Saeed Mahameed
From: Roi Dayan miss_rule and prio_s args are not being referenced before assigned so there is no need to init them. Signed-off-by: Roi Dayan Reviewed-by: Oz Shlomo Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c | 4 ++-- 1

[net-next V2 10/11] net/mlx5e: IPsec, Inline feature_check fast-path function

2021-01-11 Thread Saeed Mahameed
From: Tariq Toukan Feature check functions are in the TX fast-path of all SKBs, not only IPsec traffic. Move the IPsec feature check function into a header and turn it inline. Use a stub and clean the config flag condition in Eth main driver file. Signed-off-by: Tariq Toukan Reviewed-by: Raed S

[net-next V2 09/11] net/mlx5e: IPsec, Avoid unreachable return

2021-01-11 Thread Saeed Mahameed
From: Tariq Toukan Simple code improvement, move default return operation under the #else block. Signed-off-by: Tariq Toukan Reviewed-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/en_accel.h | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[net-next V2 11/11] net/mlx5e: IPsec, Remove unnecessary config flag usage

2021-01-11 Thread Saeed Mahameed
From: Tariq Toukan MLX5_IPSEC_DEV() is always defined, no need to protect it under config flag CONFIG_MLX5_EN_IPSEC, especially in slow path. Signed-off-by: Tariq Toukan Reviewed-by: Raed Salem Reviewed-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core

[net-next V2 08/11] net/mlx5e: IPsec, Enclose csum logic under ipsec config

2021-01-11 Thread Saeed Mahameed
From: Tariq Toukan All IPsec logic should be wrapped under the compile flag, including its checksum logic. Introduce an inline function in ipsec datapath header, with a corresponding stub. Signed-off-by: Tariq Toukan Reviewed-by: Raed Salem Reviewed-by: Huy Nguyen Signed-off-by: Saeed Mahamee

[net-next V2 01/11] net/mlx5: Add HW definition of reg_c_preserve

2021-01-11 Thread Saeed Mahameed
From: Paul Blakey Add capability bit to test whether reg_c value is preserved on recirculation. Signed-off-by: Paul Blakey Signed-off-by: Maor Dickman Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- include/linux/mlx5/mlx5_ifc.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[net-next V2 04/11] net/mlx5e: E-Switch, Offload all chain 0 priorities when modify header and forward action is not supported

2021-01-11 Thread Saeed Mahameed
From: Jianbo Liu Miss path handling of tc multi chain filters (i.e. filters that are defined on chain > 0) requires the hardware to communicate to the driver the last chain that was processed. This is possible only when the hardware is capable of performing the combination of modify header and fo

[net-next V2 03/11] net/mlx5: E-Switch, use new cap as condition for mpls over udp

2021-01-11 Thread Saeed Mahameed
From: Eli Cohen Use tunnel_stateless_mpls_over_udp instead of MLX5_FLEX_PROTO_CW_MPLS_UDP since new devices have native support for mpls over udp and do not rely on flex parser. Signed-off-by: Eli Cohen Reviewed-by: Roi Dayan Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- drivers

[net-next V2 02/11] net/mlx5e: Simplify condition on esw_vport_enable_qos()

2021-01-11 Thread Saeed Mahameed
From: Eli Cohen esw->qos.enabled will only be true if both MLX5_CAP_GEN(dev, qos) and MLX5_CAP_QOS(dev, esw_scheduling) are true. Therefore, remove them from the condition in and rely only on esw->qos.enabled. Fixes: 1bd27b11c1df ("net/mlx5: Introduce E-switch QoS management") Signed-off-by: Eli

[net-next V2 05/11] net/mlx5e: CT: Pass null instead of zero spec

2021-01-11 Thread Saeed Mahameed
From: Roi Dayan No need to pass zero spec to mlx5_add_flow_rules() as the function can handle null spec. Signed-off-by: Roi Dayan Reviewed-by: Oz Shlomo Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 3 +-- 1 file changed, 1 i

[pull request][net-next V2 00/11] mlx5 updates 2021-01-07

2021-01-11 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub This series provides misc updates for mlx5 driver. v1->v2: - Drop the +trk+new TC feature for now until we handle the module dependency issue. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks,

Re: [PATCH bpf-next 2/4] selftests/bpf: add non-BPF_LSM test for task local storage

2021-01-11 Thread Andrii Nakryiko
On Fri, Jan 8, 2021 at 3:30 PM Song Liu wrote: > > Task local storage is enabled for tracing programs. Add a test for it > without CONFIG_BPF_LSM. > > Signed-off-by: Song Liu > --- > .../bpf/prog_tests/test_task_local_storage.c | 34 + > .../selftests/bpf/progs/task_local_storag

Re: [PATCH mlx5-next v1 2/5] PCI: Add SR-IOV sysfs entry to read number of MSI-X vectors

2021-01-11 Thread Leon Romanovsky
On Mon, Jan 11, 2021 at 11:30:39AM -0800, Alexander Duyck wrote: > On Sun, Jan 10, 2021 at 7:10 AM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > Some SR-IOV capable devices provide an ability to configure specific > > number of MSI-X vectors on their VF prior driver is probed on th

Re: [PATCH v2 bpf-next 6/7] libbpf: support kernel module ksym externs

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 5:34 PM Yonghong Song wrote: > > > > On 1/11/21 1:37 PM, Andrii Nakryiko wrote: > > On Sun, Jan 10, 2021 at 8:15 PM Yonghong Song wrote: > >> > >> > >> > >> On 1/8/21 2:09 PM, Andrii Nakryiko wrote: > >>> Add support for searching for ksym externs not just in vmlinux BTF,

[PATCH net-next 7/7] ibmvnic: remove unused spinlock_t stats_lock definition

2021-01-11 Thread Lijun Pan
stats_lock is no longer used. So remove it. Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 2 -- drivers/net/ethernet/ibm/ibmvnic.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index f9db139f652b.

[PATCH net-next 5/7] ibmvnic: fix miscellaneous checks

2021-01-11 Thread Lijun Pan
Fix the following checkpatch checks: CHECK: Macro argument 'off' may be better as '(off)' to avoid precedence issues CHECK: Alignment should match open parenthesis CHECK: multiple assignments should be avoided CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Please use a blank li

[PATCH net-next 6/7] ibmvnic: add comments for spinlock_t definitions

2021-01-11 Thread Lijun Pan
There are several spinlock_t definitions without comments. Add them. Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b/drivers/net/ethernet/ibm/ibmvnic.h index c09c3

[PATCH net-next 1/7] ibmvnic: prefer 'unsigned long' over 'unsigned long int'

2021-01-11 Thread Lijun Pan
Fix the following checkpatch warnings: WARNING: Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary WARNING: Prefer 'long' over 'long int' as the int is unnecessary Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 16 1 file changed, 8 ins

[PATCH net-next 4/7] ibmvnic: avoid multiple line dereference

2021-01-11 Thread Lijun Pan
Fix the following checkpatch warning: WARNING: Avoid multiple line dereference Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmv

[PATCH net-next 2/7] ibmvnic: fix block comments

2021-01-11 Thread Lijun Pan
Fix the following checkpatch warning: WARNING: networking block comments don't use an empty /* line, use /* Comment... Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic

[PATCH net-next 0/7] a set of fixes of coding style

2021-01-11 Thread Lijun Pan
This series address several coding style problems. Lijun Pan (7): ibmvnic: prefer 'unsigned long' over 'unsigned long int' ibmvnic: fix block comments ibmvnic: fix braces ibmvnic: avoid multiple line dereference ibmvnic: fix miscellaneous checks ibmvnic: add comments for spinlock_t def

[PATCH net-next 3/7] ibmvnic: fix braces

2021-01-11 Thread Lijun Pan
Fix the following checkpatch warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/

Re: [PATCH bpf 2/2] libbpf: allow loading empty BTFs

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 5:16 PM Yonghong Song wrote: > > > > On 1/11/21 12:51 PM, Andrii Nakryiko wrote: > > On Mon, Jan 11, 2021 at 10:13 AM Yonghong Song wrote: > >> > >> > >> > >> On 1/9/21 11:03 PM, Andrii Nakryiko wrote: > >>> Empty BTFs do come up (e.g., simple kernel modules with no new ty

Re: [PATCH mlx5-next v1 1/5] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-01-11 Thread Leon Romanovsky
On Mon, Jan 11, 2021 at 11:30:33AM -0800, Alexander Duyck wrote: > On Sun, Jan 10, 2021 at 7:12 AM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > Extend PCI sysfs interface with a new callback that allows configure > > the number of MSI-X vectors for specific SR-IO VF. This is neede

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-11 Thread Vincent MAILHOL
On Tue. 12 Jan 2021 at 11:14, Richard Cochran wrote: > > On Tue, Jan 12, 2021 at 09:00:33AM +0900, Vincent MAILHOL wrote: > > Out of curiosity, which programs do you use? I guess wireshark > > but please let me know if you use any other programs (I just use > > to write a small C program to do the

Re: [PATCH mlx5-next v1 1/5] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-01-11 Thread Leon Romanovsky
On Mon, Jan 11, 2021 at 10:25:42PM -0500, Don Dutile wrote: > On 1/11/21 2:30 PM, Alexander Duyck wrote: > > On Sun, Jan 10, 2021 at 7:12 AM Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Extend PCI sysfs interface with a new callback that allows configure > > > the number of MSI-

[PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Cindy Lu
In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. this cb.private will finally use in vhost_vdpa_config_cb as vhost_vdpa. Fix this issue. Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") Acked-by: Jason Wang Signed-off-by: Cindy Lu --- drivers/vhost/vdpa.c

[PATCH net V3] cxgb4/chtls: Fix tid stuck due to wrong update of qid

2021-01-11 Thread Ayush Sawal
TID stuck is seen when there is a race in CPL_PASS_ACCEPT_RPL/CPL_ABORT_REQ and abort is arriving before the accept reply, which sets the queue number. In this case HW ends up sending CPL_ABORT_RPL_RSS to an incorrect ingress queue. V1->V2: - Removed the unused variable len in chtls_set_quiesce_ct

[PATCH v2] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Cindy Lu
In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. this cb.private will finally use in vhost_vdpa_config_cb as vhost_vdpa. Fix this issue. Signed-off-by: Cindy Lu --- drivers/vhost/vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/

RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-11 Thread ashid...@fujitsu.com
> For T1, it seems like Master is pretty important. Do you have > information to be able to return the current Master/slave > configuration, or allow it to be configured? See the nxp-tja11xx.c > for an example. I think it's possible to return a Master/Slave configuration. By the way, do you need

Re: [PATCHv2 net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2021-01-11 Thread Xin Long
On Tue, Jan 12, 2021 at 12:48 AM Alexander Duyck wrote: > > On Mon, Jan 11, 2021 at 5:22 AM Xin Long wrote: > > > > This patch is to let it always do CRC checksum in sctp_gso_segment() > > by removing CRC flag from the dev features in gre_gso_segment() for > > SCTP over GRE, just as it does in Co

[PATCH V2] drivers: net: marvell: Fix two spellings, controling to controlling and oen to one

2021-01-11 Thread Bhaskar Chowdhury
s/controling/controlling/ s/oen/one/ Signed-off-by: Bhaskar Chowdhury --- As Gustavo mentioned in reply, so included that missed one before drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvp

[PATCH] kernel: trace: uprobe: Fix word to the correct spelling

2021-01-11 Thread Bhaskar Chowdhury
s/controling/controlling/p Signed-off-by: Bhaskar Chowdhury --- kernel/trace/trace_uprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 3cf7128e1ad3..55c6afd8cb27 100644 --- a/kernel/trace/trace_uprobe.c +++

[PATCH] drivers: net: ehternet: marvell: Change controling to controlling

2021-01-11 Thread Bhaskar Chowdhury
s/controling/controlling/p Signed-off-by: Bhaskar Chowdhury --- drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h index 8867f25afab4..

Re: "general protection fault in sctp_ulpevent_notify_peer_addr_change" and "general protection fault in sctp_ulpevent_nofity_peer_addr_change" should share the same root cause

2021-01-11 Thread 慕冬亮
On Tue, Jan 12, 2021 at 11:27 AM Marcelo Ricardo Leitner wrote: > > On Tue, Jan 12, 2021 at 10:18:00AM +0800, 慕冬亮 wrote: > > Dear developers, > > > > I find that "general protection fault in l2cap_sock_getsockopt" and > > "general protection fault in sco_sock_getsockopt" may be duplicated > > bugs

Re: [PATCH net-next 0/2] Introduce XDP_FLAGS_NO_TX flag

2021-01-11 Thread Charlie Somerville
On Tue, Jan 12, 2021, at 14:03, Jason Wang wrote: > > On 2021/1/9 上午10:49, Charlie Somerville wrote: > > This patch series introduces a new flag XDP_FLAGS_NO_TX which prevents > > the allocation of additional send queues for XDP programs. > > > This part I don't understand. Is such flag a must?

Re: [PATCv4 net-next] octeontx2-pf: Add RSS multi group support

2021-01-11 Thread Geethasowjanya Akula
Hi All, Any feedback on this patch. Thank you, Geetha. From: Geetha sowjanya Sent: Monday, January 4, 2021 12:50 PM To: netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Sunil Kovvuri Goutham; da...@davemloft.net; k...@kernel.org; Geethasowjanya

RE: [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices

2021-01-11 Thread Parav Pandit
Hi Michael, > From: Virtualization On > Behalf Of Parav Pandit > > > > > > When we add mac address attribute in add command, at that point also > > remove the module parameter macaddr. > > > > Will that be mandatory? I'm not to happy with a UAPI we intend to > > break straight away ... > No. Spec

RE: [PATCH] igb: avoid premature Rx buffer reuse

2021-01-11 Thread Li,Rongqing
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Tuesday, January 12, 2021 4:54 AM > To: Li,Rongqing > Cc: Netdev ; intel-wired-lan > ; Björn Töpel > Subject: Re: [PATCH] igb: avoid premature Rx buffer reuse > > On Wed, Jan 6, 2021 at 7:53 PM Li R

Re: [PATCH net 1/9] MAINTAINERS: altx: move Jay Cliburn to CREDITS

2021-01-11 Thread Chris Snook
On Mon, Jan 11, 2021 at 6:39 PM Jakub Kicinski wrote: > > On Sun, 10 Jan 2021 21:36:24 -0800 Chris Snook wrote: > > On Sun, Jan 10, 2021 at 9:28 PM Jakub Kicinski wrote: > > > Jay was not active in recent years and does not have plans > > > to return to work on ATLX drivers. > > > > > > Subsystem

Re: [PATCH mlx5-next v1 1/5] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-01-11 Thread Don Dutile
On 1/11/21 2:30 PM, Alexander Duyck wrote: On Sun, Jan 10, 2021 at 7:12 AM Leon Romanovsky wrote: From: Leon Romanovsky Extend PCI sysfs interface with a new callback that allows configure the number of MSI-X vectors for specific SR-IO VF. This is needed to optimize the performance of newly b

Re: "general protection fault in sctp_ulpevent_notify_peer_addr_change" and "general protection fault in sctp_ulpevent_nofity_peer_addr_change" should share the same root cause

2021-01-11 Thread Marcelo Ricardo Leitner
On Tue, Jan 12, 2021 at 10:18:00AM +0800, 慕冬亮 wrote: > Dear developers, > > I find that "general protection fault in l2cap_sock_getsockopt" and > "general protection fault in sco_sock_getsockopt" may be duplicated > bugs from the same root cause. > > First, by comparing the PoC similarity after o

Re: [PATCH bpf-next 4/4] bpf: runqslower: use task local storage

2021-01-11 Thread Yonghong Song
On 1/11/21 2:54 PM, Song Liu wrote: On Jan 11, 2021, at 9:49 AM, Yonghong Song wrote: On 1/8/21 3:19 PM, Song Liu wrote: Replace hashtab with task local storage in runqslower. This improves the performance of these BPF programs. The following table summarizes average runtime of these p

Re: [PATCH v1] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Jason Wang
On 2021/1/12 上午10:46, Cindy Lu wrote: in vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. Should be "In" this cb.private will finally use in vhost_vdpa_config_cb as vhost_vdpa.Fix this issue An whitespace is needed before Fix and a full stop after "issue" Fixes: 776f39

Re: [PATCH 21/21] vdpasim: control virtqueue support

2021-01-11 Thread Jason Wang
On 2021/1/11 下午8:26, Eli Cohen wrote: On Wed, Dec 16, 2020 at 02:48:18PM +0800, Jason Wang wrote: This patch introduces the control virtqueue support for vDPA simulator. This is a requirement for supporting advanced features like multiqueue. A requirement for control virtqueue is to isolate i

Re: [PATCH net-next 0/2] Introduce XDP_FLAGS_NO_TX flag

2021-01-11 Thread Jason Wang
On 2021/1/9 上午10:49, Charlie Somerville wrote: This patch series introduces a new flag XDP_FLAGS_NO_TX which prevents the allocation of additional send queues for XDP programs. This part I don't understand. Is such flag a must? I think the answer is probably not. Why not simply do: 1) if

[Patch net] cls_flower: call nla_ok() before nla_next()

2021-01-11 Thread Cong Wang
From: Cong Wang fl_set_enc_opt() simply checks if there are still bytes left to parse, but this is not sufficent as syzbot seems to be able to generate malformatted netlink messages. nla_ok() is more strict so should be used to validate the next nlattr here. And nla_validate_nested_deprecated()

Re: [PATCH net-next 0/2] dsa: add MT7530 GPIO support

2021-01-11 Thread DENG Qingfang
Hi Marek, On Mon, Jan 11, 2021 at 11:46 PM Marek Behún wrote: > > what modes does the LED support? Does it support blinking on rx/tx? > What about link status? Yes. But unfortunately they cannot be controlled individually, unless on GPIO mode. > I'd like to know because I am still working on pa

[PATCH v1] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Cindy Lu
in vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. this cb.private will finally use in vhost_vdpa_config_cb as vhost_vdpa.Fix this issue Signed-off-by: Cindy Lu --- drivers/vhost/vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/dr

Re: [RFC PATCH bpf-next 0/2] bpf, libbpf: share BTF data show functionality

2021-01-11 Thread Alexei Starovoitov
On Mon, Jan 11, 2021 at 05:32:51PM +, Alan Maguire wrote: > The BPF Type Format (BTF) can be used in conjunction with the helper > bpf_snprintf_btf() to display kernel data with type information. > > This series generalizes that support and shares it with libbpf so > that libbpf can display ty

Re: [PATCH net 1/9] MAINTAINERS: altx: move Jay Cliburn to CREDITS

2021-01-11 Thread Jakub Kicinski
On Sun, 10 Jan 2021 21:36:24 -0800 Chris Snook wrote: > On Sun, Jan 10, 2021 at 9:28 PM Jakub Kicinski wrote: > > Jay was not active in recent years and does not have plans > > to return to work on ATLX drivers. > > > > Subsystem ATLX ETHERNET DRIVERS > > Changes 20 / 116 (17%) > > Last activi

Re: [PATCH net v2 0/3] skb frag: kmap_atomic fixes

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Sat, 9 Jan 2021 17:18:31 -0500 you wrote: > From: Willem de Bruijn > > skb frags may be backed by highmem and/or compound pages. Various > code calls kmap_atomic to safely access highmem pages. But this > needs additional

Re: [PATCH] rtw88: debug: style: Simplify bool comparison

2021-01-11 Thread Pkshih
On Mon, 2021-01-11 at 09:22 +, YANG LI wrote: > Fix the following coccicheck warning: >  ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING: > Comparison of 0/1 to bool variable > > Signed-off-by: YANG LI > Reported-by: Abaci Robot--- >  drivers/net/wireless/realtek/rtw88/debug.c

"general protection fault in sctp_ulpevent_notify_peer_addr_change" and "general protection fault in sctp_ulpevent_nofity_peer_addr_change" should share the same root cause

2021-01-11 Thread 慕冬亮
Dear developers, I find that "general protection fault in l2cap_sock_getsockopt" and "general protection fault in sco_sock_getsockopt" may be duplicated bugs from the same root cause. First, by comparing the PoC similarity after own minimization, we find they share the same PoC. Second, the stack

Re: [PATCH net V2] cxgb4/chtls: Fix tid stuck due to wrong update of qid

2021-01-11 Thread Jakub Kicinski
On Sat, 9 Jan 2021 08:21:06 +0530 Ayush Sawal wrote: > + if (skb) > + kfree_skb(skb); kfree_skb() handles NULL just fine

Re: [PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-11 Thread Richard Cochran
On Tue, Jan 12, 2021 at 09:00:33AM +0900, Vincent MAILHOL wrote: > Out of curiosity, which programs do you use? I guess wireshark > but please let me know if you use any other programs (I just use > to write a small C program to do the stuff). I was thinking of PTP over DeviceNET (which, in turn,

Re: [PATCH v2 0/3] hv_netvsc: Prevent packet loss during VF add/remove

2021-01-11 Thread Jakub Kicinski
On Fri, 8 Jan 2021 16:53:40 -0800 Long Li wrote: > From: Long Li > > This patch set fixes issues with packet loss on VF add/remove. These patches are for net-next? They just optimize the amount of packet loss on switch, not fix bugs, right?

Re: [PATCH] rndis_host: set proper input size for OID_GEN_PHYSICAL_MEDIUM request

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 8 Jan 2021 09:58:39 + you wrote: > MSFT ActiveSync implementation requires that the size of the response for > incoming query is to be provided in the request input length. Failure to > set the input size proper res

Re: [PATCH net-next] net: mvpp2: prs: improve ipv4 parse flow

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 10 Jan 2021 16:30:59 +0200 you wrote: > From: Stefan Chulski > > Patch didn't fix any issue, just improve parse flow > and align ipv4 parse flow with ipv6 parse flow. > > Currently ipv4 kenguru parser first check

Office.Dr

2021-01-11 Thread wwwheadoffic...@gmail.com

Re: [PATCH] net: macb: Add default usrio config to default gem config

2021-01-11 Thread Atish Patra
On Mon, 2021-01-11 at 15:13 -0800, Jakub Kicinski wrote: > On Mon, 11 Jan 2021 11:55:53 -0800 Atish Patra wrote: > > There is no usrio config defined for default gem config leading to > > a kernel panic devices that don't define a data. This issue can be > > reprdouced with microchip polar fire soc

[PATCH net v2] net: macb: Add default usrio config to default gem config

2021-01-11 Thread Atish Patra
There is no usrio config defined for default gem config leading to a kernel panic devices that don't define a data. This issue can be reprdouced with microchip polar fire soc where compatible string is defined as "cdns,macb". Fixes: edac63861db7 ("net: macb: Add default usrio config to default gem

RE: [PATCH 4/6] ethernet: stmmac: fix dma physical address of descriptor when display ring

2021-01-11 Thread Joakim Zhang
> -Original Message- > From: Florian Fainelli > Sent: 2021年1月12日 1:30 > To: Joakim Zhang ; peppe.cavall...@st.com; > alexandre.tor...@st.com; joab...@synopsys.com; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH 4/6] ethernet: stmma

Re: [PATCH v2 bpf-next 6/7] libbpf: support kernel module ksym externs

2021-01-11 Thread Yonghong Song
On 1/11/21 1:37 PM, Andrii Nakryiko wrote: On Sun, Jan 10, 2021 at 8:15 PM Yonghong Song wrote: On 1/8/21 2:09 PM, Andrii Nakryiko wrote: Add support for searching for ksym externs not just in vmlinux BTF, but across all module BTFs, similarly to how it's done for CO-RE relocations. Kern

Re: [PATCH] Fix whitespace in uapi/linux/tcp.h.

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 22:21:04 + you wrote: > From: Danilo Carvalho > > List of things fixed: > - Two of the socket options were idented with spaces instead of tabs. > - Trailing whitespace in some lines. > - Impr

Re: [PATCH v2 bpf-next 5/7] bpf: support BPF ksym variables in kernel modules

2021-01-11 Thread Yonghong Song
On 1/11/21 1:29 PM, Andrii Nakryiko wrote: On Sun, Jan 10, 2021 at 8:13 PM Yonghong Song wrote: On 1/8/21 2:09 PM, Andrii Nakryiko wrote: Add support for directly accessing kernel module variables from BPF programs using special ldimm64 instructions. This functionality builds upon vmlinu

[no subject]

2021-01-11 Thread Mrs.Isabella .Helmreich
-- Não sei se você vê minha mensagem?

Re: [PATCH net-next 0/3] r8169: improve PLL power-down handling

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 10 Jan 2021 20:46:58 +0100 you wrote: > This series includes improvements to handling of PLL power-down. > > Heiner Kallweit (3): > r8169: enable PLL power-down for chip versions 34, 35, 36, 42 > r8169: improv

Re: [PATCH net-next] net: bareudp: simplify error paths calling dellink

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 10 Jan 2021 21:29:22 -0800 you wrote: > bareudp_dellink() only needs the device list to hand it to > unregister_netdevice_queue(). We can pass NULL in, and > unregister_netdevice_queue() will do the unregistering. >

Re: [PATCH bpf 2/2] libbpf: allow loading empty BTFs

2021-01-11 Thread Yonghong Song
On 1/11/21 12:51 PM, Andrii Nakryiko wrote: On Mon, Jan 11, 2021 at 10:13 AM Yonghong Song wrote: On 1/9/21 11:03 PM, Andrii Nakryiko wrote: Empty BTFs do come up (e.g., simple kernel modules with no new types and strings, compared to the vmlinux BTF) and there is nothing technically wro

Re: [PATCH net-next] r8169: make use of the unaligned access helpers

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 9 Jan 2021 23:53:26 +0100 you wrote: > Instead of open-coding unaligned access let's use the predefined > unaligned access helpers. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet/realtek/r8169_ma

Re: [PATCH net-next 0/2] r8169: improve jumbo configuration

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 9 Jan 2021 22:59:08 +0100 you wrote: > Small improvements to jumbo configuration. > > Heiner Kallweit (2): > r8169: align RTL8168e jumbo pcie read request size with vendor driver > r8169: tweak max read reques

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Jakub Kicinski
On Tue, 12 Jan 2021 01:47:27 +0100 Andrew Lunn wrote: > On Mon, Jan 11, 2021 at 04:36:53PM -0800, Jakub Kicinski wrote: > > On Sun, 10 Jan 2021 21:23:02 +0200 stef...@marvell.com wrote: > > > From: Stefan Chulski > > > > > > Packet Processor hardware not connected to MAC flow control unit and >

Re: [PATCH net-next] net: marvell: prestera: Correct typo

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 8 Jan 2021 21:06:22 -0800 you wrote: > The function was incorrectly named with a trailing 'r' at the end of > prestera. > > Signed-off-by: Florian Fainelli > --- > Jakub, David, > > [...] Here is the summary wi

[PATCH net] net: dsa: clear devlink port type before unregistering slave netdevs

2021-01-11 Thread Vladimir Oltean
From: Vladimir Oltean Florian reported a use-after-free bug in devlink_nl_port_fill found with KASAN: (devlink_nl_port_fill) (devlink_port_notify) (devlink_port_unregister) (dsa_switch_teardown.part.3) (dsa_tree_teardown_switches) (dsa_unregister_switch) (bcm_sf2_sw_remove) (platform_remove) (de

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Andrew Lunn
On Mon, Jan 11, 2021 at 04:36:53PM -0800, Jakub Kicinski wrote: > On Sun, 10 Jan 2021 21:23:02 +0200 stef...@marvell.com wrote: > > From: Stefan Chulski > > > > Packet Processor hardware not connected to MAC flow control unit and > > cannot support TX flow control. > > This patch disable flow con

Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

2021-01-11 Thread Jakub Kicinski
On Sun, 10 Jan 2021 21:23:02 +0200 stef...@marvell.com wrote: > From: Stefan Chulski > > Packet Processor hardware not connected to MAC flow control unit and > cannot support TX flow control. > This patch disable flow control support. > > Fixes: 3f518509dedc ("ethernet: Add new driver for Marvel

Re: [PATCH v6 net-next 08/15] net: allow ndo_get_stats64 to return an int error code

2021-01-11 Thread Saeed Mahameed
On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > Some drivers need to do special tricks to comply with the new policy > of > ndo_get_stats64 being sleepable. For example, the bonding driver, > which > derives its stats from its lower interfaces, must recurse w

[PATCH net-next 3/4] tcp: consistently account for overhead in rcv_wscale calculation

2021-01-11 Thread Heath Caldwell
When calculating the window scale to use for the advertised window for a TCP connection, adjust the size values used to extend the maximum possible window value so that overhead is properly accounted. In other words: convert the maximum value candidates from buffer size space into advertised windo

Re: [PATCH bpf-next 2/4] selftests/bpf: add non-BPF_LSM test for task local storage

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 9:30 AM, Yonghong Song wrote: > > > > On 1/8/21 3:19 PM, Song Liu wrote: >> Task local storage is enabled for tracing programs. Add a test for it >> without CONFIG_BPF_LSM. >> Signed-off-by: Song Liu >> --- >> .../bpf/prog_tests/test_task_local_storage.c | 34 +++

Re: [PATCH v6 net-next 11/15] net: catch errors from dev_get_stats

2021-01-11 Thread Saeed Mahameed
On Sat, 2021-01-09 at 19:26 +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > dev_get_stats can now return error codes. Convert all remaining call > sites to look at that error code and stop processing. > > The effects of simulating a kernel error (returning -ENOMEM) upon > existing prog

Re: [PATCH bpf-next 2/4] selftests/bpf: add non-BPF_LSM test for task local storage

2021-01-11 Thread Song Liu
> On Jan 11, 2021, at 9:44 AM, KP Singh wrote: > > On Mon, Jan 11, 2021 at 6:31 PM Yonghong Song wrote: >> >> >> >> On 1/8/21 3:19 PM, Song Liu wrote: >>> Task local storage is enabled for tracing programs. Add a test for it >>> without CONFIG_BPF_LSM. > > Can you also explain what the te

[PATCH net-next 4/4] tcp: remove limit on initial receive window

2021-01-11 Thread Heath Caldwell
Remove the 64KB limit imposed on the initial receive window. The limit was added by commit a337531b942b ("tcp: up initial rmem to 128KB and SYN rwin to around 64KB"). This change removes that limit so that the initial receive window can be arbitrarily large (within existing limits and depending o

  1   2   3   4   >