Re: [PATCH] net: remove disc_data_lock in ppp line discipline

2020-12-31 Thread Xie He
> In tty layer, it use tty->ldisc_sem to proect tty_ldisc_ops. > So I think tty->ldisc_sem can also protect tty->disc_data; It might help by CC'ing TTY people, so that we could get this reviewed by people who are familiar with TTY code. Greg Kroah-Hartman (supporter:TTY LAYER) Jiri Slaby (suppo

What's the difference between inet_rcv_saddr and inet_saddr?

2020-12-31 Thread Theodore Dubois
(Resending since my first attempt appears to have gone to /dev/null) What's the difference between inet_rcv_saddr and inet_saddr? Or inet_num and inet_sport. It seems that the first of each pair is in the struct sock instead of the struct inet_sock, but that doesn't explain why there would be a

What's the difference between inet_rcv_saddr and inet_saddr?

2020-12-31 Thread Theodore Dubois
What's the difference between inet_rcv_saddr and inet_saddr? Or inet_num and inet_sport. It seems that the first of each pair is in the struct sock instead of the struct inet_sock, but that doesn't explain why there would be apparent duplicates of each in the inet_sock. Thanks, ~Theodore

WARNING: suspicious RCU usage in xt_obj_to_user

2020-12-31 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:f838f8d2 mfd: ab8500-debugfs: Remove extraneous seq_putc git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17074c4750 kernel config: https://syzkaller.appspot.com/x/.config?x=7a43a64bad3fdb39 dashboa

Account Details for Passives Einkommen Meine Erfolgsgeschichte in 1 Monat. Der Leitfaden fur passives Einkommen in Hohe von 10000 USD pro Monat >>>>>>>>>>>>>> https://www.google.com/url?q=https%3A%2

2020-12-31 Thread Acadaware
Hello Passives Einkommen Meine Erfolgsgeschichte in 1 Monat. Der Leitfaden fur passives Einkommen in Hohe von 1 USD pro Monat >> https://www.google.com/url?q=https%3A%2F%2Fvk.cc%2FbW9Ahb%3Fq%3Da&sa=D&pro=qto&usg=AFQjCNFmdcUrwh_NlvClKeEaVPTKYlFtoA , Thank you for registering

UBSAN: shift-out-of-bounds in gred_change

2020-12-31 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:3db1a3fa Merge tag 'staging-5.11-rc1' of git://git.kernel... git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=155708db50 kernel config: https://syzkaller.appspot.com/x/.config?x=2ae878fbf640b72b das

Re: Race Condition Observed in ARP Processing.

2020-12-31 Thread Cong Wang
On Tue, Dec 29, 2020 at 8:06 AM Chinmay Agarwal wrote: > > Hi All, > > We found a crash while performing some automated stress tests on a 5.4 kernel > based device. > > We found out that it there is a freed neighbour address which was still part > of the gc_list and was leading to crash. > Upon

Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-31 Thread Roland Dreier
I haven't tried these patches yet but they don't look quite right to me. inlining the first 0001 patch: > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index 1447da1d5729..bcd17f6d6de6 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -944,7 +

[PATCH net] net: lapb: Decrease the refcount of "struct lapb_cb" in lapb_device_event

2020-12-31 Thread Xie He
In lapb_device_event, lapb_devtostruct is called to get a reference to an object of "struct lapb_cb". lapb_devtostruct increases the refcount of the object and returns a pointer to it. However, we didn't decrease the refcount after we finished using the pointer. This patch fixes this problem. Fixe

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Andrew Lunn
> > Looking at sfp_module_info(), adding a check for i2c_block_size < 2 > > when determining what length to return. ethtool should do the right > > thing, know that the second page has not been returned to user space. > > But if we limit length of eeprom then userspace would not be able to > acces

Re: [PATCH iproute2-next 7/9] dcb: Support -n to suppress translation to nice names

2020-12-31 Thread David Ahern
On 12/23/20 11:25 AM, Petr Machata wrote: > diff --git a/dcb/dcb.c b/dcb/dcb.c > index a59b63ac9159..e6cda7337924 100644 > --- a/dcb/dcb.c > +++ b/dcb/dcb.c > @@ -467,7 +467,8 @@ static void dcb_help(void) > " dcb [ -f | --force ] { -b | --batch } filename [ -N | > --Netns ] ne

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Pali Rohár
On Thursday 31 December 2020 16:30:33 Andrew Lunn wrote: > On Thu, Dec 31, 2020 at 01:14:10PM +0100, Pali Rohár wrote: > > On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > > > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > > > On Wednesday 30 December

RE: [PATCH bpf-next] xsk: build skb by page

2020-12-31 Thread John Fastabend
Xuan Zhuo wrote: > This patch is used to construct skb based on page to save memory copy > overhead. > > Taking into account the problem of addr unaligned, and the > possibility of frame size greater than page in the future. > > Signed-off-by: Xuan Zhuo > --- > net/xdp/xsk.c | 68 > +++

Re: [PATCH iproute2-next] rdma: Add support for the netlink extack

2020-12-31 Thread David Ahern
On 12/30/20 10:42 PM, Leon Romanovsky wrote: > diff --git a/rdma/utils.c b/rdma/utils.c > index 2a201aa4..927e2107 100644 > --- a/rdma/utils.c > +++ b/rdma/utils.c > @@ -664,7 +664,7 @@ void rd_prepare_msg(struct rd *rd, uint32_t cmd, uint32_t > *seq, uint16_t flags) > > int rd_send_msg(struct r

[PATCH] can: rcar: Update help description for CAN_RCAR_CANFD config

2020-12-31 Thread Lad Prabhakar
The rcar_canfd driver supports R-Car Gen3 and RZ/G2 SoC's, update the description to reflect this. Signed-off-by: Lad Prabhakar --- drivers/net/can/rcar/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/rcar/Kconfig b/drivers/net/can/rcar/Kconfig

[PATCH] can: rcar: Update help description for CAN_RCAR config

2020-12-31 Thread Lad Prabhakar
The rcar_can driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update the description to reflect this. Signed-off-by: Lad Prabhakar --- drivers/net/can/rcar/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/rcar/Kconfig b/drivers/net/can/rcar/Kco

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Pali Rohár
On Thursday 31 December 2020 16:09:25 Andrew Lunn wrote: > On Thu, Dec 31, 2020 at 01:14:10PM +0100, Pali Rohár wrote: > > On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > > > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > > > On Wednesday 30 December

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Andrew Lunn
On Thu, Dec 31, 2020 at 01:14:10PM +0100, Pali Rohár wrote: > On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > > On Wednesday 30 December 2020 18:13:15 Andrew Lunn wrote: > > > > Hi Pali > > > > > > > >

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Andrew Lunn
On Thu, Dec 31, 2020 at 01:14:10PM +0100, Pali Rohár wrote: > On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > > On Wednesday 30 December 2020 18:13:15 Andrew Lunn wrote: > > > > Hi Pali > > > > > > > >

Re: [PATCH net] net: ipv6: Validate GSO SKB before finish IPv6 processing

2020-12-31 Thread Daniel Axtens
Hi Aya, > Daniel Axtens, does this solve the issue referred in your commit? > 8914a595110a bnx2x: disable GSO where gso_size is too big for hardware No, because: > Note: These cases are handled in the same manner in IPv4 output finish. > This patch aligns the behavior of IPv6 and IPv4. and the is

Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

2020-12-31 Thread Pali Rohár
On Wednesday 30 December 2020 19:12:40 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 06:27:07PM +0100, Marek Behún wrote: > > On Wed, 30 Dec 2020 18:06:52 +0100 > > Pali Rohár wrote: > > > > > if (!sfp->type->module_supported(&id) && > > > (memcmp(id.base.vendor_name, "U

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Pali Rohár
On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > On Wednesday 30 December 2020 18:13:15 Andrew Lunn wrote: > > > Hi Pali > > > > > > I have to agree with Russell here. I would rather have no diagnostics >

Re: [PATCH] mt76: Fix queue ID variable types after mcu queue split

2020-12-31 Thread Lorenzo Bianconi
> Clang warns in both mt7615 and mt7915: > > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:271:9: warning: implicit > conversion from enumeration type 'enum mt76_mcuq_id' to different > enumeration type 'enum mt76_txq_id' [-Wenum-conversion] > txq = MT_MCUQ_FWDL; >

答复: [PATCH] net: remove disc_data_lock in ppp line discipline

2020-12-31 Thread Gaoyan
Dear all: Could I get your comments for the updates? If I can get a reply, it will help me a lot . Thanks https://lkml.org/lkml/2020/12/28/19 *** Original mail - 发件人: gaoyan (RD) 发送时间: 2020年12月28日 15:16 收件人: pau...@samba.org; da...@davemloft.net; k...@k

[PATCH RFC net-next] net: hns3: debugfs add dump tm info of nodes, priority and qset

2020-12-31 Thread Guangbin Huang
To increase methods to dump more tm info, adds three debugfs commands to dump tm info of nodes, priority and qset. And a new tm file of debugfs is created for only dumping tm info. Unlike previous debugfs commands, to dump each tm information, user needs to enter two commands now. The first comman

Re: Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-31 Thread Yongji Xie
On Thu, Dec 31, 2020 at 3:12 PM Jason Wang wrote: > > > On 2020/12/31 下午2:52, Yongji Xie wrote: > > On Thu, Dec 31, 2020 at 1:50 PM Jason Wang wrote: > >> > >> On 2020/12/31 下午1:15, Yongji Xie wrote: > >>> On Thu, Dec 31, 2020 at 10:49 AM Jason Wang wrote: > On 2020/12/30 下午6:12, Yongji Xie