Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-28 Thread Roland Dreier
> Applied to net and queued for LTS, thanks! Thanks - is Oliver's series of 3 patches that get rid of the other half of the log spam also on the way upstream? - R.

Re: [PATCH 07/21] vdpa: multiple address spaces support

2020-12-28 Thread Eli Cohen
On Wed, Dec 16, 2020 at 02:48:04PM +0800, Jason Wang wrote: > This patches introduces the multiple address spaces support for vDPA > device. This idea is to identify a specific address space via an > dedicated identifier - ASID. > > During vDPA device allocation, vDPA device driver needs to report

RE: [PATCH v5 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-28 Thread John Fastabend
Lorenzo Bianconi wrote: > Introduce xdp_prepare_buff utility routine to initialize per-descriptor > xdp_buff fields (e.g. xdp_buff pointers). Rely on xdp_prepare_buff() in > all XDP capable drivers. > > Signed-off-by: Lorenzo Bianconi > --- Same as 1, looks like a reasonable cleanup and spot che

RE: [PATCH v5 bpf-next 1/2] net: xdp: introduce xdp_init_buff utility routine

2020-12-28 Thread John Fastabend
Lorenzo Bianconi wrote: > Introduce xdp_init_buff utility routine to initialize xdp_buff fields > const over NAPI iterations (e.g. frame_sz or rxq pointer). Rely on > xdp_init_buff in all XDP capable drivers. > > Signed-off-by: Lorenzo Bianconi > --- Seems like a nice bit of cleanup. I spot chec

Re: [PATCH net-next v2 5/6] bcm63xx_enet: convert to build_skb

2020-12-28 Thread Florian Fainelli
On 12/24/2020 6:24 AM, Sieng Piaw Liew wrote: > We can increase the efficiency of rx path by using buffers to receive > packets then build SKBs around them just before passing into the network > stack. In contrast, preallocating SKBs too early reduces CPU cache > efficiency. > > Check if we're

Re: [PATCH net-next v2 6/6] bcm63xx_enet: improve rx loop

2020-12-28 Thread Florian Fainelli
On 12/24/2020 6:24 AM, Sieng Piaw Liew wrote: > Use existing rx processed count to track against budget, thereby making > budget decrement operation redundant. > > rx_desc_count can be calculated outside the rx loop, making the loop a > bit smaller. > > Signed-off-by: Sieng Piaw Liew Acked-b

Re: [PATCH net-next v2 3/6] bcm63xx_enet: add xmit_more support

2020-12-28 Thread Florian Fainelli
On 12/24/2020 6:24 AM, Sieng Piaw Liew wrote: > Support bulking hardware TX queue by using netdev_xmit_more(). > > Signed-off-by: Sieng Piaw Liew Acked-by: Florian Fainelli -- Florian

Re: [PATCH net-next v2 4/6] bcm63xx_enet: alloc rx skb with NET_IP_ALIGN

2020-12-28 Thread Florian Fainelli
On 12/24/2020 6:24 AM, Sieng Piaw Liew wrote: > Use netdev_alloc_skb_ip_align on newer SoCs with integrated switch > (enetsw) when refilling RX. Increases packet processing performance > by 30% (with netif_receive_skb_list). > > Non-enetsw SoCs cannot function with the extra pad so continue to

Re: [PATCH net-next v2 2/6] bcm63xx_enet: add BQL support

2020-12-28 Thread Florian Fainelli
On 12/24/2020 6:24 AM, Sieng Piaw Liew wrote: > Add Byte Queue Limits support to reduce/remove bufferbloat in > bcm63xx_enet. > > Signed-off-by: Sieng Piaw Liew Acked-by: Florian Fainelli -- Florian

Re: [PATCH net-next v2 1/6] bcm63xx_enet: batch process rx path

2020-12-28 Thread Florian Fainelli
On 12/24/2020 6:24 AM, Sieng Piaw Liew wrote: > Use netif_receive_skb_list to batch process rx skb. > Tested on BCM6328 320 MHz using iperf3 -M 512, increasing performance > by 12.5%. > > Before: > [ ID] Interval Transfer Bandwidth Retr > [ 4] 0.00-30.00 sec 120 MBytes

[PATCH net v6] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

2020-12-28 Thread wangyunjian
From: Yunjian Wang Currently the vhost_zerocopy_callback() maybe be called to decrease the refcount when sendmsg fails in tun. The error handling in vhost handle_tx_zerocopy() will try to decrease the same refcount again. This is wrong. To fix this issue, we only call vhost_net_ubuf_put() when vq

Re: [PATCH rfc 1/3] virtio-net: support transmit hash report

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 4:36 PM Michael S. Tsirkin wrote: > > On Mon, Dec 28, 2020 at 11:22:31AM -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Virtio-net supports sharing the flow hash from host to guest on rx. > > Do the same on transmit, to allow the host to infer connection

Re: [PATCH rfc 1/3] virtio-net: support transmit hash report

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 12:28 PM Michael S. Tsirkin wrote: > > On Mon, Dec 28, 2020 at 11:47:45AM -0500, Willem de Bruijn wrote: > > On Mon, Dec 28, 2020 at 11:28 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Dec 28, 2020 at 11:22:31AM -0500, Willem de Bruijn wrote: > > > > From: Willem de Bru

Re: [PATCH rfc 0/3] virtio-net: add tx-hash, rx-tstamp and tx-tstamp

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 7:47 PM Michael S. Tsirkin wrote: > > On Mon, Dec 28, 2020 at 02:51:09PM -0500, Willem de Bruijn wrote: > > On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Dec 28, 2020 at 11:22:30AM -0500, Willem de Bruijn wrote: > > > > From: Willem de Brui

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 7:55 PM Michael S. Tsirkin wrote: > > On Mon, Dec 28, 2020 at 02:30:31PM -0500, Willem de Bruijn wrote: > > On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > > > > From: Willem de Brui

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 5:59 PM Jakub Kicinski wrote: > > On Mon, 28 Dec 2020 11:22:32 -0500 Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Add optional PTP hardware timestamp offload for virtio-net. > > > > Accurate RTT measurement requires timestamps close to the wire. > > Introduce

Re: pull-request: bpf 2020-12-28

2020-12-28 Thread David Miller
From: Daniel Borkmann Date: Mon, 28 Dec 2020 22:28:30 +0100 > Hi David, hi Jakub, > > The following pull-request contains BPF updates for your *net* tree. > > There is a small merge conflict between bpf tree commit 69ca310f3416 > ("bpf: Save correct stopping point in file seq iteration") and ne

Re: [PATCH v3 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay

2020-12-28 Thread Florian Fainelli
On 12/23/2020 3:29 PM, Martin Blumenstingl wrote: > Amlogic Meson G12A, G12B and SM1 SoCs have a more advanced RGMII RX > delay register which allows picoseconds precision. Deprecate the old > "amlogic,rx-delay-ns" in favour of the generic "rx-internal-delay-ps" > property. > > For older SoCs t

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-28 Thread Konstantin Ryabitsev
On Mon, Dec 28, 2020 at 01:05:26PM -0800, Florian Fainelli wrote: > On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote: > > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: > Konstantin, would you be willing to mod the kernel.org instance of > patchwork to populate Fixes

Re: [PATCH net-next] nfc: Add a virtual nci device driver

2020-12-28 Thread Jakub Kicinski
On Mon, 28 Dec 2020 18:45:07 +0900 Bongsu Jeon wrote: > From: Bongsu Jeon > > A NCI virtual device can be made to simulate a NCI device in user space. > Using the virtual NCI device, The NCI module and application can be > validated. This driver supports to communicate between the virtual NCI > d

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin wrote: > > On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Add optional PTP hardware timestamp offload for virtio-net. > > > > Accurate RTT measurement requires timestamps close to the wire. >

Re: [PATCH rfc 0/3] virtio-net: add tx-hash, rx-tstamp and tx-tstamp

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin wrote: > > On Mon, Dec 28, 2020 at 11:22:30AM -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > RFC for three new features to the virtio network device: > > > > 1. pass tx flow hash and state to host, for routing + telemetry > >

Re: [PATCH v3 0/5] dwmac-meson8b: picosecond precision RX delay support

2020-12-28 Thread Jakub Kicinski
On Thu, 24 Dec 2020 00:29:00 +0100 Martin Blumenstingl wrote: > Hello, > > with the help of Jianxin Pan (many thanks!) the meaning of the "new" > PRG_ETH1[19:16] register bits on Amlogic Meson G12A, G12B and SM1 SoCs > are finally known. These SoCs allow fine-tuning the RGMII RX delay in > 200ps s

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-28 Thread Konstantin Ryabitsev
On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: > >> Konstantin, would you be willing to mod the kernel.org instance of > >> patchwork to populate Fixes tags in the generated mboxes? > > > > I'd really rather not -- we try not to diverge from project upstream if at > > all > > p

Re: [PATCH net-next v2 0/6] bcm63xx_enet: major makeover of driver

2020-12-28 Thread Jakub Kicinski
On Thu, 24 Dec 2020 22:24:15 +0800 Sieng Piaw Liew wrote: > This patch series aim to improve the bcm63xx_enet driver by integrating the > latest networking features, i.e. batched rx processing, BQL, build_skb, etc. > > The newer enetsw SoCs are found to be able to do unaligned rx DMA by adding > N

Re: [PATCH net-next v2 3/6] bcm63xx_enet: add xmit_more support

2020-12-28 Thread Jakub Kicinski
On Thu, 24 Dec 2020 22:24:18 +0800 Sieng Piaw Liew wrote: > Support bulking hardware TX queue by using netdev_xmit_more(). > > Signed-off-by: Sieng Piaw Liew > --- > drivers/net/ethernet/broadcom/bcm63xx_enet.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a

Re: [PATCH] fsl/fman: Add MII mode support.

2020-12-28 Thread Jakub Kicinski
On Sat, 26 Dec 2020 13:59:56 +0300 Maxim Kochetkov wrote: > Set proper value to IF_MODE register for MII mode. > > Signed-off-by: Maxim Kochetkov Please repost in a few days - the net-next is still closed: http://vger.kernel.org/~davem/net-next.html Please tag the patch with [PATCH net-next].

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-28 Thread Florian Fainelli
On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote: > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: Konstantin, would you be willing to mod the kernel.org instance of patchwork to populate Fixes tags in the generated mboxes? >>> >>> I'd really rather not -- we try n

Re: [PATCH net-next] net: nfc: nci: Change the NCI close sequence

2020-12-28 Thread Jakub Kicinski
On Mon, 28 Dec 2020 10:46:31 +0900 Bongsu Jeon wrote: > From: Bongsu Jeon > > Change the NCI close sequence because the NCI Command timer should be > deleted after flushing the NCI command work queue. The commit message should describe the reason - why new order is better than the old one. The e

pull-request: bpf 2020-12-28

2020-12-28 Thread Daniel Borkmann
Hi David, hi Jakub, The following pull-request contains BPF updates for your *net* tree. There is a small merge conflict between bpf tree commit 69ca310f3416 ("bpf: Save correct stopping point in file seq iteration") and net tree commit 66ed594409a1 ("bpf/task_iter: In task_file_seq_get_next use

Re: [PATCH v4] net: neighbor: fix a crash caused by mod zero

2020-12-28 Thread David Miller
From: weichenchen Date: Fri, 25 Dec 2020 13:44:45 +0800 > pneigh_enqueue() tries to obtain a random delay by mod > NEIGH_VAR(p, PROXY_DELAY). However, NEIGH_VAR(p, PROXY_DELAY) > migth be zero at that point because someone could write zero > to /proc/sys/net/ipv4/neigh/[device]/proxy_delay after

Re: [PATCH net] net: mvpp2: fix pkt coalescing int-threshold configuration

2020-12-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 23 Dec 2020 20:35:21 +0200 you wrote: > From: Stefan Chulski > > The packet coalescing interrupt threshold has separated registers > for different aggregated/cpu (sw-thread). The required value should > be loaded for e

Re: [PATCH net] ipv4: Ignore ECN bits for fib lookups in fib_compute_spec_dst()

2020-12-28 Thread David Miller
From: Guillaume Nault Date: Thu, 24 Dec 2020 20:01:09 +0100 > RT_TOS() only clears one of the ECN bits. Therefore, when > fib_compute_spec_dst() resorts to a fib lookup, it can return > different results depending on the value of the second ECN bit. > > For example, ECT(0) and ECT(1) packets cou

Re: [PATCH net 1/2] net: mrp: fix definitions of MRP test packets

2020-12-28 Thread Jakub Kicinski
On Wed, 23 Dec 2020 15:45:32 +0100 Rasmus Villemoes wrote: > Wireshark says that the MRP test packets cannot be decoded - and the > reason for that is that there's a two-byte hole filled with garbage > between the "transitions" and "timestamp" members. > > So Wireshark decodes the two garbage byte

Re: [PATCH net 2/2] net: switchdev: don't set port_obj_info->handled true when -EOPNOTSUPP

2020-12-28 Thread Jakub Kicinski
On Wed, 23 Dec 2020 15:45:33 +0100 Rasmus Villemoes wrote: > It's not true that switchdev_port_obj_notify() only inspects the > ->handled field of "struct switchdev_notifier_port_obj_info" if > call_switchdev_blocking_notifiers() returns 0 - there's a WARN_ON() > triggering for a non-zero return

Re: [PATCH net 0/2] bnxt_en: Bug fixes.

2020-12-28 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Sun, 27 Dec 2020 14:18:16 -0500 you wrote: > The first patch fixes recovery of fatal AER errors. The second one > fixes a potential array out of bounds issue. > > Please queue for -stable. Thanks. > > Michael Chan (1): >

Re: [PATCH net 0/2] net: ipa: fix some new build warnings

2020-12-28 Thread Alex Elder
On 12/28/20 4:14 PM, Jakub Kicinski wrote: If only it could have been caught with COMPILE_TEST.. ;) I know, I know!!! I've had a branch that's half done for a long time. It has other dependencies that are not set up for COMPILE_TEST so it's harder than I'd like. Let me see if I can make some

Re: [Aspeed, v2 2/2] net: ftgmac100: Change the order of getting MAC address

2020-12-28 Thread Jakub Kicinski
On Tue, 22 Dec 2020 22:00:34 +0100 Andrew Lunn wrote: > On Tue, Dec 22, 2020 at 09:46:52PM +0100, Heiner Kallweit wrote: > > On 22.12.2020 21:14, Hongwei Zhang wrote: > > > Dear Reviewer, > > > > > > Use native MAC address is preferred over other choices, thus change the > > > order > > > of re

Re: [PATCH net 0/2] net: ipa: fix some new build warnings

2020-12-28 Thread Jakub Kicinski
On Sat, 26 Dec 2020 15:37:35 -0600 Alex Elder wrote: > I got a super friendly message from the Intel kernel test robot that > pointed out that two patches I posted last week caused new build > warnings. I already had these problems fixed in my own tree but > the fix was not included in what I sent

Re: [net 0/4][pull request] Intel Wired LAN Driver Updates 2020-12-23

2020-12-28 Thread Jakub Kicinski
On Wed, 23 Dec 2020 15:36:21 -0800 Tony Nguyen wrote: > Commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > systems") disabled S0ix flows for systems that have various incarnations of > the i219-LM ethernet controller. This was done because of some regressions > caused by an e

Re: [PATCH net v2] tun: fix return value when the number of iovs exceeds MAX_SKB_FRAGS

2020-12-28 Thread Jakub Kicinski
On Fri, 25 Dec 2020 10:52:16 +0800 wangyunjian wrote: > From: Yunjian Wang > > Currently the tun_napi_alloc_frags() function returns -ENOMEM when the > number of iovs exceeds MAX_SKB_FRAGS + 1. However this is inappropriate, > we should use -EMSGSIZE instead of -ENOMEM. > > The following distinc

Re: [PATCH net] net: mptcp: cap forward allocation to 1M

2020-12-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 21 Dec 2020 22:07:25 +0100 you wrote: > the following syzkaller reproducer: > > r0 = socket$inet_mptcp(0x2, 0x1, 0x106) > bind$inet(r0, &(0x7f80)={0x2, 0x4e24, @multicast2}, 0x10) > connect$inet(r0, &(0x7f000

Re: [PATCH rfc 1/3] virtio-net: support transmit hash report

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 11:22:31AM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Virtio-net supports sharing the flow hash from host to guest on rx. > Do the same on transmit, to allow the host to infer connection state > for more robust routing and telemetry. > > Linux derives ipv

Re: [PATCH rfc 0/3] virtio-net: add tx-hash, rx-tstamp and tx-tstamp

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 02:51:09PM -0500, Willem de Bruijn wrote: > On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin wrote: > > > > On Mon, Dec 28, 2020 at 11:22:30AM -0500, Willem de Bruijn wrote: > > > From: Willem de Bruijn > > > > > > RFC for three new features to the virtio network device

Re: [PATCH net] net: ethernet: ti: cpts: fix ethtool output when no ptp_clock registered

2020-12-28 Thread Jakub Kicinski
On Thu, 24 Dec 2020 13:21:36 -0800 Richard Cochran wrote: > On Thu, Dec 24, 2020 at 06:24:05PM +0200, Grygorii Strashko wrote: > > The CPTS driver registers PTP PHC clock when first netif is going up and > > unregister it when all netif are down. Now ethtool will show: > > - PTP PHC clock index 0

[PATCH 4/4] net: ethernet: ravb: Name the AVB functional clock fck

2020-12-28 Thread Adam Ford
The bindings have been updated to support two clocks, but the original clock now requires the name fck to distinguish it from the other. Signed-off-by: Adam Ford --- drivers/net/ethernet/renesas/ravb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 02:30:31PM -0500, Willem de Bruijn wrote: > On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin wrote: > > > > On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > > > From: Willem de Bruijn > > > > > > Add optional PTP hardware timestamp offload for virtio-

[PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks

2020-12-28 Thread Adam Ford
The AVB driver assumes there is an external clock, but it could be driven by an external clock. In order to enable a programmable clock, it needs to be added to the clocks list and enabled in the driver. Since there currently only one clock, there is no clock-names list either. Update bindings t

[PATCH 2/4] ARM: dts: renesas: Add fck to etheravb-rcar-gen2 clock-names list

2020-12-28 Thread Adam Ford
The bindings have been updated to support two clocks, but the original clock now requires the name fck. Add a clock-names list in the device tree with fck in it. Signed-off-by: Adam Ford --- arch/arm/boot/dts/r8a7742.dtsi | 1 + arch/arm/boot/dts/r8a7743.dtsi | 1 + arch/arm/boot/dts/r8a7744.

[PATCH 3/4] arm64: dts: renesas: Add fck to etheravb-rcar-gen3 clock-names list

2020-12-28 Thread Adam Ford
The bindings have been updated to support two clocks, but the original clock now requires the name fck. Add a clock-names list in the device tree with fck in it. Signed-off-by: Adam Ford --- arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 1 + arch/a

Re: [PATCH net v3 0/4] net-sysfs: fix race conditions in the xps code

2020-12-28 Thread Jakub Kicinski
On Wed, 23 Dec 2020 15:26:08 -0800 Alexander Duyck wrote: > On Wed, Dec 23, 2020 at 1:23 PM Antoine Tenart wrote: > > > > Hello all, > > > > This series fixes race conditions in the xps code, where out of bound > > accesses can occur when dev->num_tc is updated, triggering oops. The > > root cause

Re: [PATCH] CDC-NCM: remove "connected" log message

2020-12-28 Thread Jakub Kicinski
On Thu, 24 Dec 2020 08:53:52 +0100 Greg KH wrote: > On Wed, Dec 23, 2020 at 07:21:16PM -0800, Roland Dreier wrote: > > The cdc_ncm driver passes network connection notifications up to > > usbnet_link_change(), which is the right place for any logging. > > Remove the netdev_info() duplicating this f

Re: [PATCH net v2] net: hdlc_ppp: Fix issues when mod_timer is called while timer is running

2020-12-28 Thread David Miller
From: Xie He Date: Sun, 27 Dec 2020 18:53:39 -0800 > ppp_cp_event is called directly or indirectly by ppp_rx with "ppp->lock" > held. It may call mod_timer to add a new timer. However, at the same time > ppp_timer may be already running and waiting for "ppp->lock". In this > case, there's no need

Re: [PATCH v2] atlantic: remove architecture depends

2020-12-28 Thread David Miller
From: dftxb...@free.fr Date: Sun, 27 Dec 2020 17:11:36 +0100 > From: Léo Le Bouter > > This was tested on a RaptorCS Talos II with IBM POWER9 DD2.2 CPUs and an > ASUS XG-C100F PCI-e card without any issue. Speeds of ~8Gbps could be > attained with not-very-scientific (wget HTTP) both-ways measur

Re: [PATCH] ipv6: Prevent overrun when parsing v6 header options

2020-12-28 Thread David Miller
From: Defang Bo Date: Sun, 27 Dec 2020 22:11:35 +0800 > Similar to commit<2423496af35>, the fragmentation code tries to parse the > header options in order > to figure out where to insert the fragment option. Since nexthdr points > to an invalid option, the calculation of the size of the networ

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Jakub Kicinski
On Mon, 28 Dec 2020 11:22:32 -0500 Willem de Bruijn wrote: > From: Willem de Bruijn > > Add optional PTP hardware timestamp offload for virtio-net. > > Accurate RTT measurement requires timestamps close to the wire. > Introduce virtio feature VIRTIO_NET_F_RX_TSTAMP. If negotiated, the > virtio-n

Re: [Patch net] erspan: fix version 1 check in gre_parse_header()

2020-12-28 Thread David Miller
From: Cong Wang Date: Sat, 26 Dec 2020 15:44:53 -0800 > From: Cong Wang > > Both version 0 and version 1 use ETH_P_ERSPAN, but version 0 does not > have an erspan header. So the check in gre_parse_header() is wrong, > we have to distinguish version 1 from version 0. > > We can just check the g

Re: [PATCH -net] net: sched: prevent invalid Scell_log shift count

2020-12-28 Thread David Miller
From: Randy Dunlap Date: Thu, 24 Dec 2020 22:23:44 -0800 > Check Scell_log shift size in red_check_params() and modify all callers > of red_check_params() to pass Scell_log. > > This prevents a shift out-of-bounds as detected by UBSAN: > UBSAN: shift-out-of-bounds in ./include/net/red.h:252:22

Re: [PATCH net v2] net: hns: fix return value check in __lb_other_process()

2020-12-28 Thread David Miller
From: wangyunjian Date: Sat, 26 Dec 2020 16:10:05 +0800 > From: Yunjian Wang > > The function skb_copy() could return NULL, the return value > need to be checked. > > Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet > support") > Signed-off-by: Yunjian Wang Applied

Re: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets

2020-12-28 Thread Jakub Kicinski
On Thu, 24 Dec 2020 10:46:47 + Manish Chopra wrote: > > -Original Message- > > From: Manish Chopra > > Sent: Monday, December 21, 2020 8:26 PM > > To: da...@davemloft.net > > Cc: netdev@vger.kernel.org; Ariel Elior ; Igor Russkikh > > ; Sudarsana Reddy Kalluru > > Subject: [PATCH net

Re: [PATCH rfc 0/3] virtio-net: add tx-hash, rx-tstamp and tx-tstamp

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 11:22:30AM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > RFC for three new features to the virtio network device: > > 1. pass tx flow hash and state to host, for routing + telemetry > 2. pass rx tstamp to guest, for better RTT estimation > 3. pass tx tstamp

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Add optional PTP hardware timestamp offload for virtio-net. > > Accurate RTT measurement requires timestamps close to the wire. > Introduce virtio feature VIRTIO_NET_F_RX_TSTAMP. If negotiated, the > v

Re: [PATCH rfc 1/3] virtio-net: support transmit hash report

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 11:47:45AM -0500, Willem de Bruijn wrote: > On Mon, Dec 28, 2020 at 11:28 AM Michael S. Tsirkin wrote: > > > > On Mon, Dec 28, 2020 at 11:22:31AM -0500, Willem de Bruijn wrote: > > > From: Willem de Bruijn > > > > > > Virtio-net supports sharing the flow hash from host to

Re: [PATCH rfc 1/3] virtio-net: support transmit hash report

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 11:28 AM Michael S. Tsirkin wrote: > > On Mon, Dec 28, 2020 at 11:22:31AM -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Virtio-net supports sharing the flow hash from host to guest on rx. > > Do the same on transmit, to allow the host to infer connectio

[PATCH RESEND net-next 3/4] enetc: drop MDIO_DATA() macro

2020-12-28 Thread Michael Walle
value is u16, masking with 0x is a nop. Drop it. Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean --- drivers/net/ethernet/freescale/enetc/enetc_mdio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driver

[PATCH RESEND net-next 0/4] enetc: code cleanups

2020-12-28 Thread Michael Walle
This are some code cleanups in the MDIO part of the enetc. They are intended to make the code more readable. Michael Walle (4): enetc: drop unneeded indirection enetc: don't use macro magic for the readx_poll_timeout() callback enetc: drop MDIO_DATA() macro enetc: reorder macros and functi

[PATCH RESEND net-next 1/4] enetc: drop unneeded indirection

2020-12-28 Thread Michael Walle
Before commit 6517798dd343 ("enetc: Make MDIO accessors more generic and export to include/linux/fsl") these macros actually had some benefits. But after the commit it just makes the code hard to read. Drop the macro indirections. Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Reviewed-by

[PATCH RESEND net-next 4/4] enetc: reorder macros and functions

2020-12-28 Thread Michael Walle
Now that there aren't any more macros with parameters, move the macros above any functions. Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Reviewed-by: Vladimir Oltean --- .../net/ethernet/freescale/enetc/enetc_mdio.c | 22 +-- 1 file changed, 11 insertions(+), 11 deleti

[PATCH RESEND net-next 2/4] enetc: don't use macro magic for the readx_poll_timeout() callback

2020-12-28 Thread Michael Walle
The macro enetc_mdio_rd_reg() is just used in that particular case and has a hardcoded parameter name "mdio_priv". Define a specific function to use for readx_poll_timeout() instead. Also drop the TIMEOUT macro since it is used just once. Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Rev

Re: [PATCH rfc 1/3] virtio-net: support transmit hash report

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 11:22:31AM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Virtio-net supports sharing the flow hash from host to guest on rx. > Do the same on transmit, to allow the host to infer connection state > for more robust routing and telemetry. > > Linux derives ipv

[PATCH rfc 0/3] virtio-net: add tx-hash, rx-tstamp and tx-tstamp

2020-12-28 Thread Willem de Bruijn
From: Willem de Bruijn RFC for three new features to the virtio network device: 1. pass tx flow hash and state to host, for routing + telemetry 2. pass rx tstamp to guest, for better RTT estimation 3. pass tx tstamp to host, for accurate pacing All three would introduce an extension to the virt

[PATCH rfc 1/3] virtio-net: support transmit hash report

2020-12-28 Thread Willem de Bruijn
From: Willem de Bruijn Virtio-net supports sharing the flow hash from host to guest on rx. Do the same on transmit, to allow the host to infer connection state for more robust routing and telemetry. Linux derives ipv6 flowlabel and ECMP multipath from sk->sk_txhash, and updates these fields on e

[PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Willem de Bruijn
From: Willem de Bruijn Add optional PTP hardware timestamp offload for virtio-net. Accurate RTT measurement requires timestamps close to the wire. Introduce virtio feature VIRTIO_NET_F_RX_TSTAMP. If negotiated, the virtio-net header is expanded with room for a timestamp. A host may pass receive

[PATCH rfc 3/3] virtio-net: support transmit timestamp

2020-12-28 Thread Willem de Bruijn
From: Willem de Bruijn Add optional delivery time (SO_TXTIME) offload for virtio-net. The Linux TCP/IP stack tries to avoid bursty transmission and network congestion through pacing: computing an skb delivery time based on congestion information. Userspace protocol implementations can achieve th

Re: [RFC] ravb: Add support for optional txc_refclk

2020-12-28 Thread Geert Uytterhoeven
Hi Adam, CC devicetree On Mon, Dec 28, 2020 at 2:49 PM Adam Ford wrote: > On Mon, Dec 14, 2020 at 4:05 AM Geert Uytterhoeven > wrote: > > On Sun, Dec 13, 2020 at 5:18 PM Adam Ford wrote: > > > The SoC expects the txv_refclk is provided, but if it is provided > > > by a programmable clock, the

Re: [PATCH net v5 2/2] vhost_net: fix tx queue stuck when sendmsg fails

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 01:27:42PM +, wangyunjian wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Sunday, December 27, 2020 7:21 PM > > To: wangyunjian > > Cc: netdev@vger.kernel.org; jasow...@redhat.com; > > willemdebruijn.ker...@gmail.com

RE: [PATCH net v5 2/2] vhost_net: fix tx queue stuck when sendmsg fails

2020-12-28 Thread wangyunjian
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Sunday, December 27, 2020 7:21 PM > To: wangyunjian > Cc: netdev@vger.kernel.org; jasow...@redhat.com; > willemdebruijn.ker...@gmail.com; virtualizat...@lists.linux-foundation.org; > Lilijun (Jerry) ; chenchan

[PATCH v11 bpf-next] bpf/selftests: fold test_current_pid_tgid_new_ns into test_progs.

2020-12-28 Thread Carlos Neira
Currently tests for bpf_get_ns_current_pid_tgid() are outside test_progs. This change folds test cases into test_progs. Changes from v10: - Code style fixes. - Remove redundant code. Signed-off-by: Carlos Neira --- tools/testing/selftests/bpf/.gitignore| 1 - tools/testing/selftest

Re: [RFC] ravb: Add support for optional txc_refclk

2020-12-28 Thread Adam Ford
On Mon, Dec 14, 2020 at 4:05 AM Geert Uytterhoeven wrote: > > Hi Adam, > > On Sun, Dec 13, 2020 at 5:18 PM Adam Ford wrote: > > The SoC expects the txv_refclk is provided, but if it is provided > > by a programmable clock, there needs to be a way to get and enable > > this clock to operate. It n

[PATCH net v2 1/2] bareudp: set NETIF_F_LLTX flag

2020-12-28 Thread Taehee Yoo
Like other tunneling interfaces, the bareudp doesn't need TXLOCK. So, It is good to set the NETIF_F_LLTX flag to improve performance and to avoid lockdep's false-positive warning. Test commands: ip netns add A ip netns add B ip link add veth0 netns A type veth peer name veth1 netns B

[PATCH net v2 0/2] bareudp: fix several issues

2020-12-28 Thread Taehee Yoo
This patchset is to fix problems when bareudp is used nestedly. 1. If the NETIF_F_LLTX flag is not set, the lockdep warns about a possible deadlock scenario when bareudp interfaces are used nestedly. But, like other tunneling interfaces, bareudp doesn't need xmit lock. So, it sets NETIF_F_LLTTX. L

[PATCH net v2 2/2] bareudp: Fix use of incorrect min_headroom size

2020-12-28 Thread Taehee Yoo
In the bareudp6_xmit_skb(), it calculates min_headroom. At that point, it uses struct iphdr, but it's not correct. So panic could occur. The struct ipv6hdr should be used. Test commands: ip netns add A ip netns add B ip link add veth0 netns A type veth peer name veth1 netns B ip ne

Re: [PATCH] staging: qlge: Removed duplicate word in comment.

2020-12-28 Thread Greg KH
On Fri, Dec 18, 2020 at 05:48:29PM -0800, Daniel West wrote: > This patch fixes the checkpatch warning: > > WARNING: Possible repeated word: 'and' > > Signed-off-by: Daniel West signed-off-by does not match From: line, so I can't take this :( Please fix up and resend. thanks, greg k-h

Re: "ethtool" missing "master-slave" args in "do_sset" function.[TEXT/PLAIN]

2020-12-28 Thread Rudy Lei (shlei)
Hi Michal, Merry Christmas and thanks a lot for the prompt reply. After upgraded the kernel to 5.10 and we did see the expected logs: [root@shlei-dev-machine ~]# ethtool -s ens32 master-slave preferred-master netlink error: master/slave configuration not supported by device (offset 36) netlink

Re: [PATCH net v5 2/2] vhost_net: fix tx queue stuck when sendmsg fails

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 11:55:36AM +, wangyunjian wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Sunday, December 27, 2020 7:21 PM > > To: wangyunjian > > Cc: netdev@vger.kernel.org; jasow...@redhat.com; > > willemdebruijn.ker...@gmail.com

regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

2020-12-28 Thread Michal Kubecek
FYI, there is a regression in iwlwifi driver caused by commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") reported at https://bugzilla.kernel.org/show_bug.cgi?id=210733 https://bugzilla.suse.com/show_bug.cgi?id=1180344 The problem seems to be an attempt to write terminati

RE: [PATCH net v5 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

2020-12-28 Thread wangyunjian
> -Original Message- > From: Willem de Bruijn [mailto:willemdebruijn.ker...@gmail.com] > Sent: Monday, December 28, 2020 12:15 AM > To: Michael S. Tsirkin > Cc: wangyunjian ; Network Development > ; Jason Wang ; Willem de > Bruijn ; > virtualizat...@lists.linux-foundation.org; Lilijun (Jer

RE: [PATCH net v5 2/2] vhost_net: fix tx queue stuck when sendmsg fails

2020-12-28 Thread wangyunjian
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Sunday, December 27, 2020 7:21 PM > To: wangyunjian > Cc: netdev@vger.kernel.org; jasow...@redhat.com; > willemdebruijn.ker...@gmail.com; virtualizat...@lists.linux-foundation.org; > Lilijun (Jerry) ; chenchan

Re: [PATCH] [v2] net/mlx5e: Fix two double free cases

2020-12-28 Thread Leon Romanovsky
On Mon, Dec 28, 2020 at 04:48:40PM +0800, Dinghao Liu wrote: > mlx5e_create_ttc_table_groups() frees ft->g on failure of > kvzalloc(), but such failure will be caught by its caller > in mlx5e_create_ttc_table() and ft->g will be freed again > in mlx5e_destroy_flow_table(). The same issue also occur

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2020-12-28 Thread Jiri Pirko
Fri, Dec 18, 2020 at 08:30:33PM CET, ja...@redhat.com wrote: >This comes from an end-user request, where they're running multiple VMs on >hosts with bonded interfaces connected to some interest switch topologies, >where 802.3ad isn't an option. They're currently running a proprietary >solution that

Re: [RFC PATCH net-next 0/9] Get rid of the switchdev transactional model

2020-12-28 Thread Jiri Pirko
Thu, Dec 17, 2020 at 02:58:13AM CET, vladimir.olt...@nxp.com wrote: >This series comes after the late realization that the prepare/commit >separation imposed by switchdev does not help literally anybody: >https://patchwork.kernel.org/project/netdevbpf/patch/20201212203901.351331-1-vladimir.olt...@n

[PATCH net-next] nfc: Add a virtual nci device driver

2020-12-28 Thread Bongsu Jeon
From: Bongsu Jeon A NCI virtual device can be made to simulate a NCI device in user space. Using the virtual NCI device, The NCI module and application can be validated. This driver supports to communicate between the virtual NCI device and NCI module. Signed-off-by: Bongsu Jeon --- MAINTAINER

Re: Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-28 Thread Yongji Xie
On Mon, Dec 28, 2020 at 4:43 PM Jason Wang wrote: > > > On 2020/12/28 下午4:14, Yongji Xie wrote: > >> I see. So all the above two questions are because VHOST_IOTLB_INVALIDATE > >> is expected to be synchronous. This need to be solved by tweaking the > >> current VDUSE API or we can re-visit to go w

[PATCH] [v2] net/mlx5e: Fix two double free cases

2020-12-28 Thread Dinghao Liu
mlx5e_create_ttc_table_groups() frees ft->g on failure of kvzalloc(), but such failure will be caught by its caller in mlx5e_create_ttc_table() and ft->g will be freed again in mlx5e_destroy_flow_table(). The same issue also occurs in mlx5e_create_ttc_table_groups(). Set ft->g to NULL after kfree()

Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-28 Thread Jason Wang
On 2020/12/28 下午4:14, Yongji Xie wrote: I see. So all the above two questions are because VHOST_IOTLB_INVALIDATE is expected to be synchronous. This need to be solved by tweaking the current VDUSE API or we can re-visit to go with descriptors relaying first. Actually all vdpa related operatio

Re: Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-28 Thread Yongji Xie
On Mon, Dec 28, 2020 at 3:43 PM Jason Wang wrote: > > > On 2020/12/25 下午6:31, Yongji Xie wrote: > > On Fri, Dec 25, 2020 at 2:58 PM Jason Wang wrote: > >> > >> On 2020/12/24 下午3:37, Yongji Xie wrote: > >>> On Thu, Dec 24, 2020 at 10:41 AM Jason Wang wrote: > On 2020/12/23 下午8:14, Yongji Xie