syzbot has found a reproducer for the following issue on:
HEAD commit:a409ed15 Merge tag 'gpio-v5.11-1' of git://git.kernel.org/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=174778a750
kernel config: https://syzkaller.appspot.com/x/.config?x=20efebc
> From: Jakub Kicinski
> Sent: Saturday, December 19, 2020 1:21 AM
>
> On Thu, 17 Dec 2020 05:46:45 + Parav Pandit wrote:
> > > From: Jakub Kicinski
> > > Sent: Thursday, December 17, 2020 5:39 AM
> > >
> > > On Wed, 16 Dec 2020 05:15:04 + Parav Pandit wrote:
> > > > > From: Jakub Kici
> From: Jakub Kicinski
> Sent: Saturday, December 19, 2020 1:29 AM
>
> On Thu, 17 Dec 2020 05:23:10 + Parav Pandit wrote:
> > > From: Jakub Kicinski
> > > Sent: Thursday, December 17, 2020 5:42 AM
> > >
> > > On Wed, 16 Dec 2020 05:19:15 + Parav Pandit wrote:
> > > > > From: Jakub Kic
> From: Jakub Kicinski
> Sent: Saturday, December 19, 2020 1:18 AM
> So the SF is always created from the eswitch controller side?
> How does the host side look?
>
Host side creates the auxiliary device for the SF.
$ ls -l /sys/bus/auxiliary/devices/
mlx5_core.sf.4 ->
../../../devices/pci
On 12/18/2020 2:38 PM, Vladimir Oltean wrote:
> The SYSTEMPORT driver maps each port of the embedded Broadcom DSA switch
> port to a certain queue of the master Ethernet controller. For that it
> currently uses a dedicated notifier infrastructure which was added in
> commit 60724d4bae14 ("net: d
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Fri, 18 Dec 2020 13:04:06 +0100 you wrote:
> From: Colin Ian King
>
> The intention of the err_expr cleanup path is to iterate over the
> allocated expr_array objects and free them, starting from i - 1 and
> working down t
It'd be great if someone more familiar with our IPv6 code could take a
look. Adding some folks to the CC.
On Wed, 16 Dec 2020 23:01:29 +0100 Dmytro Shytyi wrote:
> Variable SLAAC [Can be activated via sysctl]:
> SLAAC with prefixes of arbitrary length in PIO (randomly
> generated hostID or stable
This patch fixes the checkpatch warning:
WARNING: Possible repeated word: 'and'
Signed-off-by: Daniel West
---
drivers/staging/qlge/qlge_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index e6b7baa12
On Fri, Dec 18, 2020 at 4:30 PM Jakub Kicinski wrote:
>
> On Thu, 17 Dec 2020 17:25:18 +0100 Antoine Tenart wrote:
> > Callers to netif_set_xps_queue should take the rtnl lock. Failing to do
> > so can lead to race conditions between netdev_set_num_tc and
> > netif_set_xps_queue, triggering variou
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 17 Dec 2020 22:29:46 +0100 you wrote:
> taprio_graft() can insert a NULL element in the array of child qdiscs. As
> a consquence, taprio_reset() might not reset child qdiscs completely, and
> taprio_destroy() might leak
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Thu, 17 Dec 2020 14:34:16 -0800 you wrote:
> This series contains updates to i40e and iavf drivers.
>
> Sylwester fixes an issue where PF was not properly being rebuilt
> following VF removal for i40e.
>
> Jakub Kicinski f
On Fri, 18 Dec 2020 14:11:16 +0800 lyl wrote:
> Remove tcp_low_latency, since it is not functional After commit
> e7942d0633c4 (tcp: remove prequeue support)
>
> Signed-off-by: lyl
I don't think we can remove sysctls, even if they no longer control
the behavior of the kernel. The existence of t
On Thu, 17 Dec 2020 17:25:18 +0100 Antoine Tenart wrote:
> Callers to netif_set_xps_queue should take the rtnl lock. Failing to do
> so can lead to race conditions between netdev_set_num_tc and
> netif_set_xps_queue, triggering various oops:
>
> - netif_set_xps_queue uses dev->tc_num as one of the
On 12/18/2020 2:38 PM, Vladimir Oltean wrote:
> The SYSTEMPORT driver maps each port of the embedded Broadcom DSA switch
> port to a certain queue of the master Ethernet controller. For that it
> currently uses a dedicated notifier infrastructure which was added in
> commit 60724d4bae14 ("net: d
On 12/18/2020 2:38 PM, Vladimir Oltean wrote:
> This effectively reverts commit 60724d4bae14 ("net: dsa: Add support for
> DSA specific notifiers"). The reason is that since commit 2f1e8ea726e9
> ("net: dsa: link interfaces with the DSA master to get rid of lockdep
> warnings"), it appears that
On 18/12/2020 19:36:08-0400, Jason Gunthorpe wrote:
> On Fri, Dec 18, 2020 at 10:16:58PM +0100, Alexandre Belloni wrote:
>
> > But then again, what about non-enumerable devices on the PCI device? I
> > feel this would exactly fit MFD. This is a collection of IPs that exist
> > as standalone but in
On 12/18/2020 2:38 PM, Vladimir Oltean wrote:
> It is a bit strange to see something as specific as Broadcom SYSTEMPORT
> bits in the main DSA include file. Move these away into a separate
> header, and have the tagger and the SYSTEMPORT driver include them.
>
> Signed-off-by: Vladimir Oltean
Jarod Wilson wrote:
>This comes from an end-user request, where they're running multiple VMs on
>hosts with bonded interfaces connected to some interest switch topologies,
>where 802.3ad isn't an option. They're currently running a proprietary
>solution that effectively achieves load-balancing of
On 12/18/2020 2:38 PM, Vladimir Oltean wrote:
> Using the NETDEV_CHANGEUPPER notifications, drivers can be aware when
> they are enslaved to e.g. a bridge by calling netif_is_bridge_master().
>
> Export this helper from DSA to get the equivalent functionality of
> determining whether the upper
On Fri, Dec 18, 2020 at 12:18 PM Jason Gunthorpe wrote:
>
> On Fri, Dec 18, 2020 at 11:22:12AM -0800, Alexander Duyck wrote:
>
> > Also as far as the patch count complaints I have seen in a few threads
> > I would be fine with splitting things up so that the devlink and aux
> > device creation get
Add BPF_CORE_READ_USER(), BPF_CORE_READ_USER_STR() and their _INTO()
variations to allow reading CO-RE-relocatable kernel data structures from the
user-space. One of such cases is reading input arguments of syscalls, while
reaping the benefits of CO-RE relocations w.r.t. handling 32/64 bit
conversi
BPF_CORE_READ(), in addition to handling CO-RE relocations, also allows much
nicer way to read data structures with nested pointers. Instead of writing
a sequence of bpf_probe_read() calls to follow links, one can just write
BPF_CORE_READ(a, b, c, d) to effectively do a->b->c->d read. This is a wel
Add selftests validating that newly added variations of BPF_CORE_READ(), for
use with user-space addresses and for non-CO-RE reads, work as expected.
Signed-off-by: Andrii Nakryiko
---
.../bpf/prog_tests/core_read_macros.c | 64 +++
.../bpf/progs/test_core_read_macros.c
Add two sets of BPF_CORE_READ()-like macros. One is for reading kernel data
from user address space (e.g., UAPI data structs for syscalls). Another one is
non-CO-RE variants, which don't emit CO-RE relocations and thus won't fail on
kernels without BTF. The latter one still provides much shorter wa
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote:
>
> Jarod Wilson wrote:
...
> >The addition of a case BOND_LINK_BACK in bond_miimon_commit() is somewhat
> >separate from the fix for the actual hang, but it eliminates a constant
> >"invalid new link 3 on slave" message seen related to this issu
On Fri, Dec 18, 2020 at 10:16:58PM +0100, Alexandre Belloni wrote:
> But then again, what about non-enumerable devices on the PCI device? I
> feel this would exactly fit MFD. This is a collection of IPs that exist
> as standalone but in this case are grouped in a single device.
So, if mfd had a m
On Sat, Dec 19, 2020 at 12:08 AM Phil Sutter wrote:
>
> On Fri, Dec 18, 2020 at 08:09:23PM +0100, Andrea Claudi wrote:
> > Functions get_cgroup2_id() and get_cgroup2_path() uncorrectly performs
> > cleanup on the single return point. Both of them may get to use close()
> > with a negative argument
On Fri, Dec 18, 2020 at 08:09:23PM +0100, Andrea Claudi wrote:
> Functions get_cgroup2_id() and get_cgroup2_path() uncorrectly performs
> cleanup on the single return point. Both of them may get to use close()
> with a negative argument, if open() fails.
>
> Fix this adding proper labels and gotos
Hi Andrea,
On Fri, Dec 18, 2020 at 08:09:22PM +0100, Andrea Claudi wrote:
> make_path() function calls mkdir two times in a row. The first one it
> stores mkdir return code, and then it calls it again to check for errno.
To me it rather seems like I rebased the original commit into a mess. Or
I g
Using the NETDEV_CHANGEUPPER notifications, drivers can be aware when
they are enslaved to e.g. a bridge by calling netif_is_bridge_master().
Export this helper from DSA to get the equivalent functionality of
determining whether the upper interface of a CHANGEUPPER notifier is a
DSA switch interfa
This effectively reverts commit 60724d4bae14 ("net: dsa: Add support for
DSA specific notifiers"). The reason is that since commit 2f1e8ea726e9
("net: dsa: link interfaces with the DSA master to get rid of lockdep
warnings"), it appears that there is a generic way to achieve the same
purpose. The o
The SYSTEMPORT driver maps each port of the embedded Broadcom DSA switch
port to a certain queue of the master Ethernet controller. For that it
currently uses a dedicated notifier infrastructure which was added in
commit 60724d4bae14 ("net: dsa: Add support for DSA specific notifiers").
However, s
It is a bit strange to see something as specific as Broadcom SYSTEMPORT
bits in the main DSA include file. Move these away into a separate
header, and have the tagger and the SYSTEMPORT driver include them.
Signed-off-by: Vladimir Oltean
---
MAINTAINERS| 1 +
dri
Upon a quick inspection, it seems that there is some code in the generic
DSA layer that is somehow specific to the Broadcom SYSTEMPORT driver.
The challenge there is that the hardware integration is very tight between
the switch and the DSA master interface. However this does not mean that
the driv
On Fri, Dec 18, 2020 at 1:17 PM Alexandre Belloni
wrote:
>
> On 18/12/2020 16:58:56-0400, Jason Gunthorpe wrote:
> > On Fri, Dec 18, 2020 at 08:32:11PM +, Mark Brown wrote:
> >
> > > > So, I strongly suspect, MFD should create mfd devices on a MFD bus
> > > > type.
> > >
> > > Historically peo
The json output of the TCA_FLOWER_KEY_MPLS_OPTS attribute was invalid.
Example:
$ tc filter add dev eth0 ingress protocol mpls_uc flower mpls \
lse depth 1 label 100 \
lse depth 2 label 200
$ tc -json filter show dev eth0 ingress
...{"eth_t
Let the FW know we have enough receive buffer space for the
vlan tag if it isn't stripped.
Fixes: 0f3154e6bcb3 ("ionic: Add Tx and Rx handling")
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
Hi Miao-chen,
> This moves msft_do_close() from hci_dev_do_close() to
> hci_unregister_dev() to avoid clearing MSFT extension info. This also
> avoids retrieving MSFT info upon every msft_do_open() if MSFT extension
> has been initialized.
what is the actual benefit of this?
It is fundamentally
Hi Abhishek,
> Just like MGMT_OP_START_DISCOVERY, we should reject
> MGMT_OP_START_SERVICE_DISCOVERY with MGMT_STATUS_BUSY when we are paused
> for suspend.
>
> Signed-off-by: Abhishek Pandit-Subedi
> ---
> On ChromeOS, we started getting reports of scanning failing after
> resuming from suspend
Hi Abhishek,
> Add a missing SUSPEND_SCAN_ENABLE in passive scan, remove the separate
> function for configuring le scan during suspend and update the request
> complete function to clear both enable and disable tasks.
>
> Fixes: dce0a4be8054 ("Bluetooth: Set missing suspend task bits")
> Reviewe
On 12/18/20 1:14 PM, Vladimir Oltean wrote:
> On Fri, Dec 18, 2020 at 01:08:58PM -0800, Florian Fainelli wrote:
>> On 12/18/20 1:02 PM, Vladimir Oltean wrote:
>>> On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote:
On 12/18/20 12:52 PM, Vladimir Oltean wrote:
> On Fri, Dec 18
On 18/12/2020 16:58:56-0400, Jason Gunthorpe wrote:
> On Fri, Dec 18, 2020 at 08:32:11PM +, Mark Brown wrote:
>
> > > So, I strongly suspect, MFD should create mfd devices on a MFD bus
> > > type.
> >
> > Historically people did try to create custom bus types, as I have
> > pointed out before
On Fri, Dec 18, 2020 at 03:49:44PM -0500, Willem de Bruijn wrote:
> On Fri, Dec 18, 2020 at 3:23 PM Jonathan Lemon
> wrote:
> >
> > From: Jonathan Lemon
> >
> > This is set of cleanup patches for zerocopy which are intended
> > to allow a introduction of a different zerocopy implementation.
>
>
On Fri, Dec 18, 2020 at 01:08:58PM -0800, Florian Fainelli wrote:
> On 12/18/20 1:02 PM, Vladimir Oltean wrote:
> > On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote:
> >> On 12/18/20 12:52 PM, Vladimir Oltean wrote:
> >>> On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wr
On 12/18/20 1:02 PM, Vladimir Oltean wrote:
> On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote:
>> On 12/18/20 12:52 PM, Vladimir Oltean wrote:
>>> On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wrote:
On 12/18/20 12:24 PM, Vladimir Oltean wrote:
> Hi Florian,
>
On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote:
> On 12/18/20 12:52 PM, Vladimir Oltean wrote:
> > On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wrote:
> >> On 12/18/20 12:24 PM, Vladimir Oltean wrote:
> >>> Hi Florian,
> >>>
> >>> On Fri, Dec 18, 2020 at 09:38:43AM -
On Fri, Dec 18, 2020 at 12:47 PM Jonathan Lemon
wrote:
>
> From: Jonathan Lemon
>
> Only obtain the task reference count at the end of the RCU section
> instead of repeatedly obtaining/releasing it when iterating though
> a thread group.
>
> Jump to the correct branch when it is known that the ta
On Fri, Dec 18, 2020 at 12:47 PM Jonathan Lemon
wrote:
>
> From: Jonathan Lemon
>
> Instead of directly comparing task->tgid and task->pid, use the
> thread_group_leader() helper. This helps with readability, and
> there should be no functional change.
>
> Signed-off-by: Jonathan Lemon
> ---
A
On Fri, Dec 18, 2020 at 12:47 PM Jonathan Lemon
wrote:
>
> From: Jonathan Lemon
>
> On some systems, some variant of the following splat is
> repeatedly seen. The common factor in all traces seems
> to be the entry point to task_file_seq_next(). With the
> patch, all warnings go away.
>
> r
On Fri, Dec 18, 2020 at 08:32:11PM +, Mark Brown wrote:
> > So, I strongly suspect, MFD should create mfd devices on a MFD bus
> > type.
>
> Historically people did try to create custom bus types, as I have
> pointed out before there was then pushback that these were duplicating
> the platfor
On 12/18/20 12:52 PM, Vladimir Oltean wrote:
> On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wrote:
>> On 12/18/20 12:24 PM, Vladimir Oltean wrote:
>>> Hi Florian,
>>>
>>> On Fri, Dec 18, 2020 at 09:38:43AM -0800, Florian Fainelli wrote:
The driver is already allocating receive bu
On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wrote:
> On 12/18/20 12:24 PM, Vladimir Oltean wrote:
> > Hi Florian,
> >
> > On Fri, Dec 18, 2020 at 09:38:43AM -0800, Florian Fainelli wrote:
> >> The driver is already allocating receive buffers of 2KiB and the
> >> Ethernet MAC is conf
On Fri, Dec 18, 2020 at 3:23 PM Jonathan Lemon wrote:
>
> From: Jonathan Lemon
>
> This is set of cleanup patches for zerocopy which are intended
> to allow a introduction of a different zerocopy implementation.
Can you describe in more detail what exactly is lacking in the current
zerocopy inte
On Fri, Dec 18, 2020 at 02:41:50PM -0400, Jason Gunthorpe wrote:
> On Fri, Dec 18, 2020 at 06:03:10PM +, Mark Brown wrote:
> > If it's not supposed to use platform devices so I'm assuming that the
> > intention is that it should use aux devices, otherwise presumably it'd
> > be making some new
On 12/18/20 12:24 PM, Vladimir Oltean wrote:
> Hi Florian,
>
> On Fri, Dec 18, 2020 at 09:38:43AM -0800, Florian Fainelli wrote:
>> The driver is already allocating receive buffers of 2KiB and the
>> Ethernet MAC is configured to accept frames up to UMAC_MAX_MTU_SIZE.
>>
>> Fixes: bfcb813203e6 ("n
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 16 Dec 2020 09:28:04 +0200 you wrote:
> On 64-bit systems the packet procfs header field names following 'sk'
> are not aligned correctly:
>
> sk RefCnt Type Proto Iface R Rmem User Inode
> 605d2c64 3
Hi Florian,
On Fri, Dec 18, 2020 at 09:38:43AM -0800, Florian Fainelli wrote:
> The driver is already allocating receive buffers of 2KiB and the
> Ethernet MAC is configured to accept frames up to UMAC_MAX_MTU_SIZE.
>
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Signed
On Thu, 17 Dec 2020 16:34:29 -0600 Rob Herring wrote:
> The correct syntax for JSON pointers begins with a '/' after the '#'.
> Without a '/', the string should be interpretted as a subschema
> identifier. The jsonschema module currently doesn't handle subschema
> identifiers and incorrectly allows
On Fri, Dec 18, 2020 at 11:22:12AM -0800, Alexander Duyck wrote:
> Also as far as the patch count complaints I have seen in a few threads
> I would be fine with splitting things up so that the devlink and aux
> device creation get handled in one set, and then we work out the
> details of mlx5 atta
From: Jonathan Lemon
Replace direct assignments with skb_zcopy_set() for clarity.
Signed-off-by: Jonathan Lemon
---
drivers/net/tap.c | 3 +--
drivers/net/tun.c | 3 +--
drivers/vhost/net.c | 1 +
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tap.c b/drivers/ne
From: Jonathan Lemon
The sock_zerocopy_put_abort function contains logic which is
specific to the current zerocopy implementation. Add a wrapper
which checks the callback and dispatches apppropriately.
Signed-off-by: Jonathan Lemon
---
include/linux/skbuff.h | 10 ++
net/core/skbuff.c
From: Jonathan Lemon
In preparation for expanded zerocopy (TX and RX), move
the ZC related bits out of tx_flags into their own flag
word.
Signed-off-by: Jonathan Lemon
---
drivers/net/tap.c | 3 +--
drivers/net/tun.c | 3 +--
drivers/net/xen-netback/interf
From: Jonathan Lemon
Add an optional skb parameter to the zerocopy callback parameter,
which is passed down from skb_zcopy_clear(). This gives access
to the original skb, which is needed for upcoming RX zero-copy
error handling.
Signed-off-by: Jonathan Lemon
---
drivers/net/tap.c
From: Jonathan Lemon
Rename the get routines for consistency.
Signed-off-by: Jonathan Lemon
---
include/linux/skbuff.h | 4 ++--
net/core/skbuff.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index df98d61e8c51..638
From: Jonathan Lemon
RX zerocopy fragment pages which are not allocated from the
system page pool require special handling. Give the callback
in skb_zcopy_clear() a chance to process them first.
Signed-off-by: Jonathan Lemon
---
net/core/skbuff.c | 3 ++-
1 file changed, 2 insertions(+), 1 de
From: Jonathan Lemon
This is set of cleanup patches for zerocopy which are intended
to allow a introduction of a different zerocopy implementation.
The top level api will use the skb_zcopy_*() functions, while
the current TCP specific zerocopy would use the sock_zerocopy_*()
calls.
There should
From: Jonathan Lemon
skb_zcopy_abort() has no in-tree consumers, remove it.
Signed-off-by: Jonathan Lemon
---
include/linux/skbuff.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 69588b304f83..fb6dd6af0f82 100644
--- a/inc
From: Jonathan Lemon
In preparation for further work, the zcopy* routines will
become basic building blocks, while the zerocopy* ones will
be specific for the existing zerocopy implementation.
All uargs should have a callback function, (unless nouarg
is set), so push all special case logic handl
From: Jonathan Lemon
Currently, an ubuf is attached to a new skb, the skb zc_flags
is initialized to a fixed value. Instead of doing this, set
the default zc_flags in the ubuf, and have new skb's inherit
from this default.
This is needed when setting up different zerocopy types.
Signed-off-by:
On Thu, 17 Dec 2020 12:40:26 -0800 Ben Greear wrote:
> On 12/17/20 10:20 AM, Eric Dumazet wrote:
> > On Thu, Dec 17, 2020 at 7:13 PM Ben Greear wrote:
> >
> >> It is the iwlwifi/mvm logic that supports ax200.
> >
> > Let me ask again :
> >
> > I see two different potential call points :
> >
On Fri, Dec 18, 2020 at 07:09:11PM +, Lee Jones wrote:
> ACPI, DT and MFD are not busses.
And yet ACPI and PNP have a bus:
extern struct bus_type acpi_bus_type;
extern struct bus_type pnp_bus_type;
Why? Because in the driver core if you subclass struct device and want
to bind drivers,
On Thu, Dec 17, 2020 at 9:30 AM Jesper Dangaard Brouer
wrote:
>
> Adding selftest for BPF-helper bpf_check_mtu(). Making sure
> it can be used from both XDP and TC.
>
> Signed-off-by: Jesper Dangaard Brouer
> ---
> tools/testing/selftests/bpf/prog_tests/check_mtu.c | 204
>
On Thu, 17 Dec 2020 05:23:10 + Parav Pandit wrote:
> > From: Jakub Kicinski
> > Sent: Thursday, December 17, 2020 5:42 AM
> >
> > On Wed, 16 Dec 2020 05:19:15 + Parav Pandit wrote:
> > > > From: Jakub Kicinski
> > > > Sent: Wednesday, December 16, 2020 6:14 AM
> > > >
> > > > On Tue, 1
On Thu, 17 Dec 2020 05:46:45 + Parav Pandit wrote:
> > From: Jakub Kicinski
> > Sent: Thursday, December 17, 2020 5:39 AM
> >
> > On Wed, 16 Dec 2020 05:15:04 + Parav Pandit wrote:
> > > > From: Jakub Kicinski
> > > > Sent: Wednesday, December 16, 2020 6:08 AM
> > > >
> > > > On Tue, 1
On Wed, 16 Dec 2020 20:44:21 -0800 Saeed Mahameed wrote:
> On Wed, 2020-12-16 at 15:59 -0800, Jakub Kicinski wrote:
> > On Wed, 16 Dec 2020 03:42:51 + Parav Pandit wrote:
> > > > From: Jakub Kicinski
> > > > So subfunctions don't have a VF id but they may have a
> > > > controller?
> > > >
This comes from an end-user request, where they're running multiple VMs on
hosts with bonded interfaces connected to some interest switch topologies,
where 802.3ad isn't an option. They're currently running a proprietary
solution that effectively achieves load-balancing of VMs and bandwidth
utiliza
On Thu, Dec 17, 2020 at 1:54 AM Christophe Leroy
wrote:
>
>
>
> Le 17/12/2020 à 07:11, Alexei Starovoitov a écrit :
> > On Wed, Dec 16, 2020 at 10:07:37AM +, Christophe Leroy wrote:
> >> Implement Extended Berkeley Packet Filter on Powerpc 32
> >>
> >> Test result with test_bpf module:
> >>
>
On Fri, Dec 18, 2020 at 10:08 AM Jonathan Lemon
wrote:
>
> On Fri, Dec 18, 2020 at 08:53:22AM -0800, Yonghong Song wrote:
> >
> >
> > On 12/11/20 9:11 AM, Jonathan Lemon wrote:
> > > From: Jonathan Lemon
> > >
> > > On some systems, some variant of the following splat is
> > > repeatedly seen. T
On Fri, Dec 18, 2020 at 10:01 AM Parav Pandit wrote:
>
>
> > From: Alexander Duyck
> > Sent: Friday, December 18, 2020 9:31 PM
> >
> > On Thu, Dec 17, 2020 at 9:20 PM Parav Pandit wrote:
> > >
> > >
> > > > From: Alexander Duyck
> > > > Sent: Friday, December 18, 2020 8:41 AM
> > > >
> > > > On
make_path() function calls mkdir two times in a row. The first one it
stores mkdir return code, and then it calls it again to check for errno.
This seems unnecessary, as we can use the return code from the first
call and check for errno if not 0.
Signed-off-by: Andrea Claudi
---
lib/fs.c | 2 +-
This series contains a couple of fixes and improvements on lib/fs.c
- in functions get_cgroup2_id() and get_cgroup2_path(), fixes cleanup on
single return point;
- in function make_path(), avoid to call mkdir() two times in a row.
Andrea Claudi (2):
lib/fs: avoid double call to mkdir on make_p
Functions get_cgroup2_id() and get_cgroup2_path() uncorrectly performs
cleanup on the single return point. Both of them may get to use close()
with a negative argument, if open() fails.
Fix this adding proper labels and gotos to make sure we clean up only
resources we are effectively used before.
On Thu, Dec 17, 2020 at 1:14 PM Cong Wang wrote:
>
> On Wed, Dec 16, 2020 at 10:29 PM Cong Wang wrote:
> >
> > On Wed, Dec 16, 2020 at 10:35 AM Andrii Nakryiko
> > wrote:
> > > Minimize duplication of the code, no one said copy/paste all the code.
> > > But memory bloat is a real problem and sho
On Wed, Dec 16, 2020 at 10:29 PM Cong Wang wrote:
>
> On Wed, Dec 16, 2020 at 10:35 AM Andrii Nakryiko
> wrote:
> >
> > On Tue, Dec 15, 2020 at 4:15 PM Cong Wang wrote:
> > >
> > > On Tue, Dec 15, 2020 at 2:08 PM Andrii Nakryiko
> > > wrote:
> > > >
> > > > On Tue, Dec 15, 2020 at 12:06 PM Cong
On Fri, 18 Dec 2020, Jason Gunthorpe wrote:
> On Fri, Dec 18, 2020 at 06:03:10PM +, Mark Brown wrote:
> > On Fri, Dec 18, 2020 at 12:28:17PM -0400, Jason Gunthorpe wrote:
> > > On Fri, Dec 18, 2020 at 03:52:04PM +, Mark Brown wrote:
> > > > On Fri, Dec 18, 2020 at 10:08:54AM -0400, Jason G
From: Jonathan Lemon
Instead of directly comparing task->tgid and task->pid, use the
thread_group_leader() helper. This helps with readability, and
there should be no functional change.
Signed-off-by: Jonathan Lemon
---
kernel/bpf/task_iter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Jonathan Lemon
Only obtain the task reference count at the end of the RCU section
instead of repeatedly obtaining/releasing it when iterating though
a thread group.
Jump to the correct branch when it is known that the task is NULL.
Signed-off-by: Jonathan Lemon
---
kernel/bpf/task_iter.
From: Jonathan Lemon
On some systems, some variant of the following splat is
repeatedly seen. The common factor in all traces seems
to be the entry point to task_file_seq_next(). With the
patch, all warnings go away.
rcu: INFO: rcu_sched self-detected stall on CPU
rcu: \x0926-: (20
From: Jonathan Lemon
v3->v4:
Split commit into separate patches.
v2->v3:
Add splat to commitlog descriptions
v1->v2
Use Fixes: shas from correct tree
Jonathan Lemon (3):
bpf: save correct stopping point in file seq iteration.
bpf: Use thread_group_leader()
bpf: optimize task iteratio
On Fri, Dec 18, 2020 at 06:03:10PM +, Mark Brown wrote:
> On Fri, Dec 18, 2020 at 12:28:17PM -0400, Jason Gunthorpe wrote:
> > On Fri, Dec 18, 2020 at 03:52:04PM +, Mark Brown wrote:
> > > On Fri, Dec 18, 2020 at 10:08:54AM -0400, Jason Gunthorpe wrote:
>
> > > > I thought the recent LWN a
On 12/18/20 10:06 AM, Jonathan Lemon wrote:
On Fri, Dec 18, 2020 at 08:53:22AM -0800, Yonghong Song wrote:
On 12/11/20 9:11 AM, Jonathan Lemon wrote:
From: Jonathan Lemon
On some systems, some variant of the following splat is
repeatedly seen. The common factor in all traces seems
to be
On Fri, Dec 18, 2020 at 08:53:22AM -0800, Yonghong Song wrote:
>
>
> On 12/11/20 9:11 AM, Jonathan Lemon wrote:
> > From: Jonathan Lemon
> >
> > On some systems, some variant of the following splat is
> > repeatedly seen. The common factor in all traces seems
> > to be the entry point to task_
On Thu, Dec 17, 2020 at 04:34:29PM -0600, Rob Herring wrote:
> The correct syntax for JSON pointers begins with a '/' after the '#'.
> Without a '/', the string should be interpretted as a subschema
> identifier. The jsonschema module currently doesn't handle subschema
> identifiers and incorrectly
On Thu, 17 Dec 2020 14:03:07 -0800 Tom Rix wrote:
> On 12/17/20 9:28 AM, Jakub Kicinski wrote:
> > On Thu, 17 Dec 2020 05:17:24 -0800 Tom Rix wrote:
> >> On 12/16/20 4:45 PM, Jakub Kicinski wrote:
> >>> On Tue, 15 Dec 2020 06:22:28 -0800 t...@redhat.com wrote:
> From: Tom Rix
>
>
On Fri, Dec 18, 2020 at 12:28:17PM -0400, Jason Gunthorpe wrote:
> On Fri, Dec 18, 2020 at 03:52:04PM +, Mark Brown wrote:
> > On Fri, Dec 18, 2020 at 10:08:54AM -0400, Jason Gunthorpe wrote:
> > > I thought the recent LWN article summed it up nicely, auxillary bus is
> > > for gluing to subsy
> From: Alexander Duyck
> Sent: Friday, December 18, 2020 9:31 PM
>
> On Thu, Dec 17, 2020 at 9:20 PM Parav Pandit wrote:
> >
> >
> > > From: Alexander Duyck
> > > Sent: Friday, December 18, 2020 8:41 AM
> > >
> > > On Thu, Dec 17, 2020 at 5:30 PM David Ahern
> wrote:
> > > >
> > > > On 12/16
The driver is already allocating receive buffers of 2KiB and the
Ethernet MAC is configured to accept frames up to UMAC_MAX_MTU_SIZE.
Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
Signed-off-by: Florian Fainelli
---
drivers/net/ethernet/broadcom/bcmsysport.c | 1 +
1 file
> On Dec 18, 2020, at 8:38 AM, Yonghong Song wrote:
>
>
>
> On 12/17/20 9:23 PM, Alexei Starovoitov wrote:
>> On Thu, Dec 17, 2020 at 8:33 PM Song Liu wrote:
ahh. I missed that. Makes sense.
vm_file needs to be accurate, but vm_area_struct should be accessed as
ptr_to_
On 18/12/2020 12:28:17-0400, Jason Gunthorpe wrote:
> On Fri, Dec 18, 2020 at 03:52:04PM +, Mark Brown wrote:
> > On Fri, Dec 18, 2020 at 10:08:54AM -0400, Jason Gunthorpe wrote:
> > > On Fri, Dec 18, 2020 at 01:17:09PM +, Mark Brown wrote:
> >
> > > > As previously discussed this will nee
On 12/17/20 2:34 PM, Rob Herring wrote:
> The correct syntax for JSON pointers begins with a '/' after the '#'.
> Without a '/', the string should be interpretted as a subschema
> identifier. The jsonschema module currently doesn't handle subschema
> identifiers and incorrectly allows JSON pointers
1 - 100 of 141 matches
Mail list logo
