> -Original Message-
> From: Willem de Bruijn [mailto:willemdebruijn.ker...@gmail.com]
> Sent: Wednesday, December 9, 2020 10:43 PM
> To: wangyunjian
> Cc: Michael S. Tsirkin ; Jason Wang
> ; virtualizat...@lists.linux-foundation.org; Network
> Development ; Lilijun (Jerry)
> ; chenchanghu
From: Parav Pandit
To handle SF port management outside of the eswitch as independent
software layer, introduce eswitch notifier APIs so that upper layer who
wish to support sf port management in switchdev mode can perform its
task whenever eswitch mode is set to switchdev or before eswitch is
di
From: Parav Pandit
Support changing the state of the SF port's function through devlink.
When activating the SF port's function, enable the hca in the device
followed by adding its auxiliary device.
When deactivating the SF port's function, delete its auxiliary device
followed by disabling the vH
From: Parav Pandit
Added documentation for devlink port and port function related commands.
Signed-off-by: Parav Pandit
Reviewed-by: Jiri Pirko
Reviewed-by: Jacob Keller
Signed-off-by: Saeed Mahameed
---
.../networking/devlink/devlink-port.rst | 118 ++
Documentation/n
From: Vu Pham
Prepare eswitch to handle SF vport during
(a) querying eswitch functions
(b) egress ACL creation
(c) account for SF vports in total vports calculation
Assign a dedicated placeholder for SFs vports and their representors.
They are placed after VFs vports and before ECPF vports as be
From: Parav Pandit
Add auxiliary device driver for mlx5 subfunction auxiliary device.
A mlx5 subfunction is similar to PCI PF and VF. For a subfunction
an auxiliary device is created.
As a result, when mlx5 SF auxiliary device binds to the driver,
its netdev and rdma device are created, they ap
From: Parav Pandit
Add devlink port documentation for subfunction management.
Signed-off-by: Parav Pandit
Signed-off-by: Saeed Mahameed
---
Documentation/driver-api/auxiliary_bus.rst| 2 +
.../networking/devlink/devlink-port.rst | 89 ++-
2 files changed, 87 inserti
From: Parav Pandit
Add documentation for subfunction management using devlink
port.
Signed-off-by: Parav Pandit
Signed-off-by: Saeed Mahameed
---
.../device_drivers/ethernet/mellanox/mlx5.rst | 204 ++
1 file changed, 204 insertions(+)
diff --git a/Documentation/networking/de
From: Parav Pandit
Introduce API to add and delete an auxiliary device for an SF.
Each SF has its own dedicated window in the PCI BAR 2.
SF device is similar to PCI PF and VF that supports multiple class of
devices such as net, rdma and vdpa.
SF device will be added or removed in subsequent pat
From: Parav Pandit
Add helpers to enable/disable eswitch port, register its devlink port and
load its representor.
Signed-off-by: Vu Pham
Signed-off-by: Parav Pandit
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
.../mellanox/mlx5/core/esw/devlink_port.c | 41 +
From: Parav Pandit
devlink port function can be in active or inactive state.
Allow users to get and set port function's state.
When the port function it activated, its operational state may change
after a while when the device is created and driver binds to it.
Similarly on deactivation flow.
T
From: Parav Pandit
vhca state events indicates change in the state of the vhca that may
occur due to a SF allocation, deallocation or enabling/disabling the
SF HCA.
Introduce vhca state event handler which will be used by SF devlink
port manager and SF hardware id allocator in subsequent patches
Hi Dave, Jakub, Jason,
This series form Parav was the theme of this mlx5 release cycle,
we've been waiting anxiously for the auxbus infrastructure to make it into
the kernel, and now as the auxbus is in and all the stars are aligned, I
can finally submit this V2 of the devlink and mlx5 subfunction
From: Parav Pandit
Extended devlink interface for the user to add and delete port.
Extend devlink to connect user requests to driver to add/delete
such port in the device.
When driver routines are invoked, devlink instance lock is not held.
This enables driver to perform several devlink objects
From: Parav Pandit
Prepare code to fill zero or more port function optional attributes.
Subsequent patch makes use of this to fill more port function
attributes.
Signed-off-by: Parav Pandit
Reviewed-by: Jiri Pirko
Reviewed-by: Vu Pham
Signed-off-by: Saeed Mahameed
---
net/core/devlink.c | 6
From: Parav Pandit
A PCI sub-function (SF) represents a portion of the device similar
to PCI VF.
In an eswitch, PCI SF may have port which is normally represented
using a representor netdevice.
To have better visibility of eswitch port, its association with SF,
and its representor netdevice, int
On Fri, Dec 11, 2020 at 08:08:16PM -0800, Jakub Kicinski wrote:
> On Fri, 11 Dec 2020 11:37:34 -0600 Dan Williams wrote:
> > Just to re-iterate: QMI ~= AT commands ~= MBIM (not quite, but same
> > level)
> >
> > We already do QMI-over-USB, or AT-over-CDC-ACM. This is QMI-over-MHI.
>
> Why do we n
On Fri, Dec 11, 2020 at 4:29 AM Jonas Bonn wrote:
>
> This patch adds support for handling IPv6. Both the GTP tunnel and the
> tunneled packets may be IPv6; as they constitute independent streams,
> both v4-over-v6 and v6-over-v4 are supported, as well.
>
> This patch includes only the driver fun
On Fri, Dec 11, 2020 at 11:53 PM Daniel Borkmann wrote:
>
> On 12/11/20 5:26 AM, Zhu Yanjun wrote:
> > In the function xdp_umem_pin_pages, if npgs != umem->npgs and
> > npgs >= 0, the function xdp_umem_unpin_pages is called. In this
> > function, kfree is called to handle umem->pgs, and then in th
On Fri, Dec 11, 2020 at 4:29 AM Jonas Bonn wrote:
>
> All GTP traffic is currently sent from the same source port. This makes
> everything look like one big flow which is difficult to balance across
> network resources.
>
> From 3GPP TS 29.281:
> "...the UDP Source Port or the Flow Label field...
On Fri, Dec 11, 2020 at 4:28 AM Jonas Bonn wrote:
>
> Signed-off-by: Jonas Bonn
> ---
> drivers/net/gtp.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
> index 236ebbcb37bf..7bbeec173113 100644
> --- a/drivers/net/gtp.c
> ++
On Fri, 2020-12-11 at 11:05 +0100, Vasyl Gomonovych wrote:
> Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable
> Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable
[]
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c
> b/drivers/net/ethernet/mellanox/mlx4/main
On Fri, Dec 11, 2020 at 5:52 PM Alexei Starovoitov
wrote:
>
> On Fri, Dec 11, 2020 at 02:15:28PM -0800, Andrii Nakryiko wrote:
> > On Fri, Dec 11, 2020 at 1:27 PM Alexei Starovoitov
> > wrote:
> > >
> > > On Thu, Dec 10, 2020 at 08:27:32PM -0800, Andrii Nakryiko wrote:
> > > > During BPF program
Hi,
here's a pull request to net-next tree, more info below. Please let me know if
there are any problems.
Kalle
The following changes since commit af3f4a85d90218bb59315d591bd2bffa5e646466:
Merge branch 'mlxsw-Misc-updates' Ido Schimmel says: (2020-12-06 19:22:15
-0800)
are available in the
Following patch add support for flow based tunneling API
to send and recv GTP tunnel packet over tunnel metadata API.
This would allow this device integration with OVS or eBPF using
flow based tunneling APIs.
Signed-off-by: Pravin B Shelar
---
Fixed according to comments from Jonas Bonn
---
driv
On Fri, Dec 11, 2020 at 6:15 AM Jonas Bonn wrote:
>
> Hi Pravin,
>
> On 11/12/2020 07:56, Pravin B Shelar wrote:
> > Following patch add support for flow based tunneling API
> > to send and recv GTP tunnel packet over tunnel metadata API.
> > This would allow this device integration with OVS or eB
Abhishek Kumar wrote:
> In some devices difference in chip-id should be enough to pick
> the right BDF. Add another support for chip-id based BDF selection.
> With this new option, ath10k supports 2 fallback options.
>
> The board name with chip-id as option looks as follows
> board name 'bus=sn
On Fri, 11 Dec 2020 19:04:11 +0200 Ido Schimmel wrote:
> From: Jiri Pirko
>
> Upon route insertion and removal, it is needed to flush possibly cached
> entries from the XM cache. Extend XM op context to carry information
> needed for the flush. Implement the flush in delayed work since for HW
> d
On Fri, 11 Dec 2020 17:49:53 +0100 Maciej Fijalkowski wrote:
> @@ -864,14 +865,12 @@ ice_reuse_rx_page(struct ice_ring *rx_ring, struct
> ice_rx_buf *old_buf)
> * for use by the CPU.
> */
> static struct ice_rx_buf *
> -ice_get_rx_buf(struct ice_ring *rx_ring, struct sk_buff **skb,
> -
On Fri, 11 Dec 2020 16:37:06 +0800 Zheng Yongjun wrote:
> Simplify the return expression at diffrent gve_adminq.c file, simplify this
> all.
>
> Signed-off-by: Zheng Yongjun
Does not apply, please rebase.
On Fri, 11 Dec 2020 11:37:34 -0600 Dan Williams wrote:
> Just to re-iterate: QMI ~= AT commands ~= MBIM (not quite, but same
> level)
>
> We already do QMI-over-USB, or AT-over-CDC-ACM. This is QMI-over-MHI.
Why do we need a different QMI-over-X for every X? If you say there
are already chardev
On Thu, 10 Dec 2020 16:18:53 -0800 Ivan Babrou wrote:
> Queue sharing behaviour already exists in the out-of-tree sfc driver,
> available under xdp_alloc_tx_resources module parameter.
>
> This avoids the following issue on machines with many cpus:
>
> Insufficient resources for 12 XDP event queu
Sleepable iterator program have access to helper functions like bpf_d_path.
Signed-off-by: Song Liu
---
tools/lib/bpf/libbpf.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 9be88a90a4aad..9204d12d04bf8 100644
--- a/tools/lib/bpf/li
The test dumps information similar to /proc/pid/maps. The first line of
the output is compared against the /proc file to make sure they match.
Signed-off-by: Song Liu
---
.../selftests/bpf/prog_tests/bpf_iter.c | 106 --
tools/testing/selftests/bpf/progs/bpf_iter.h | 9 +
Introduce task_vma bpf_iter to print memory information of a process. It
can be used to print customized information similar to /proc//maps.
task_vma iterator releases mmap_lock before calling the BPF program.
Therefore, we cannot pass vm_area_struct directly to the BPF program. A
new __vm_area_st
task_file and task_vma iter programs have access to file->f_path. Enable
bpf_d_path to print paths of these file.
bpf_iter programs are generally called in sleepable context. However, it
is still necessary to diffientiate sleepable and non-sleepable bpf_iter
programs: sleepable programs have acces
This set introduces bpf_iter for task_vma, which can be used to generate
information similar to /proc/pid/maps or /proc/pid/smaps. Patch 4/4 adds
an example that mimics /proc/pid/maps.
Song Liu (4):
bpf: introduce task_vma bpf_iter
bpf: allow bpf_d_path in sleepable bpf_iter program
libbpf:
On 11/12/2020 21:27, Thomas Gleixner wrote:
> On Fri, Dec 11 2020 at 09:29, boris ostrovsky wrote:
>
>> On 12/11/20 7:37 AM, Thomas Gleixner wrote:
>>> On Fri, Dec 11 2020 at 13:10, Jürgen Groß wrote:
On 11.12.20 00:20, boris.ostrov...@oracle.com wrote:
> On 12/10/20 2:26 PM, Thomas Gleixn
On Fri, Dec 11, 2020 at 1:13 PM Daniel Borkmann wrote:
> >> + }
> >> emit_jmp:
> >> if (is_imm8(jmp_offset)) {
> >> + if (jmp_padding)
> >> + cnt += emit_nops(&prog,
> >> INSN_SZ_D
On Fri, Dec 11, 2020 at 02:15:28PM -0800, Andrii Nakryiko wrote:
> On Fri, Dec 11, 2020 at 1:27 PM Alexei Starovoitov
> wrote:
> >
> > On Thu, Dec 10, 2020 at 08:27:32PM -0800, Andrii Nakryiko wrote:
> > > During BPF program load time, verifier will resolve FD to BTF object and
> > > will
> > > t
From: Alexander Duyck
There are cases where a fastopen SYN may trigger either a ICMP_TOOBIG
message in the case of IPv6 or a fragmentation request in the case of
IPv4. This results in the socket stalling for a second or more as it does
not respond to the message by retransmitting the SYN frame.
The set of required attributes for a given SRv6 behavior is identified
using a bitmap stored in an unsigned long, since the initial design of
SRv6 networking in Linux. Recently the same approach has been used for
identifying the optional attributes.
We realized that choosing an unsigned long to st
On Fri, 2020-12-11 at 20:28 +0100, Lorenzo Bianconi wrote:
> Introduce xdp_prepare_buff utility routine to initialize per-
> descriptor
> xdp_buff fields (e.g. xdp_buff pointers). Rely on xdp_prepare_buff()
> in
> all XDP capable drivers.
>
> Signed-off-by: Lorenzo Bianconi
>
...
> +static inlin
On Thu, Dec 10, 2020 at 8:42 PM Thomas Gleixner wrote:
> Let the core code do the fiddling with irq_desc.
>
> Signed-off-by: Thomas Gleixner
> Cc: Linus Walleij
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-g...@vger.kernel.org
Reviewed-by: Linus Walleij
I suppose you will funnel th
On Fri, Dec 11, 2020 at 3:01 PM Jonathan Lemon wrote:
>
> On Fri, Dec 11, 2020 at 12:23:34PM -0800, Andrii Nakryiko wrote:
> > > @@ -164,7 +164,7 @@ task_file_seq_get_next(struct
> > > bpf_iter_seq_task_file_info *info)
> > > curr_files = get_files_struct(curr_task);
> > >
On Fri, Dec 11, 2020 at 12:59:52PM -0700, David Ahern wrote:
> On 12/11/20 11:45 AM, Jakub Kicinski wrote:
> > Ack, these patches are not exciting (to me), so I'm wondering if there
> > is a better way. The only reason NIC would have to understand a ULP for
> > ZC is to parse out header/message len
On Fri, Dec 11, 2020 at 12:23:34PM -0800, Andrii Nakryiko wrote:
> > @@ -164,7 +164,7 @@ task_file_seq_get_next(struct
> > bpf_iter_seq_task_file_info *info)
> > curr_files = get_files_struct(curr_task);
> > if (!curr_files) {
> > put_task_st
Andrew,
On Fri, Dec 11 2020 at 22:21, Andrew Cooper wrote:
> On 11/12/2020 21:27, Thomas Gleixner wrote:
>> It's not any different from the hardware example at least not as far as
>> I understood the code.
>
> Xen's event channels do have a couple of quirks.
Why am I not surprised?
> Binding an
On Fri, Dec 11, 2020 at 1:27 PM Alexei Starovoitov
wrote:
>
> On Thu, Dec 10, 2020 at 08:27:32PM -0800, Andrii Nakryiko wrote:
> > During BPF program load time, verifier will resolve FD to BTF object and
> > will
> > take reference on BTF object itself and, for module BTFs, corresponding
> > mod
On Fri, Dec 11 2020 at 22:08, Thomas Gleixner wrote:
> On Fri, Dec 11 2020 at 19:53, Andy Shevchenko wrote:
>
>> On Thu, Dec 10, 2020 at 10:14 PM Thomas Gleixner wrote:
>>>
>>> irq_set_lockdep_class() is used from modules and requires irq_to_desc() to
>>> be exported. Move it into the core code w
From: Thomas Gleixner
> Sent: 11 December 2020 21:11
>
> On Fri, Dec 11 2020 at 14:19, David Laight wrote:
> > From: Thomas Gleixner
> >> You can't catch that. If this really becomes an issue you need a
> >> sequence counter around it.
> >
> > Or just two copies of the high word.
> > Provided the
Add support for finding BTF-based kernel attach targets (fentry/fexit
functions, tp_btf tracepoints, etc) with programmatic
bpf_program__set_attach_target() API. It is now as capable as libbpf's
SEC()-based logic.
Andrii Nakryiko (2):
libbpf: support modules in bpf_program__set_attach_target() A
Support finding kernel targets in kernel modules when using
bpf_program__set_attach_target() API. This brings it up to par with what
libbpf supports when doing declarative SEC()-based target determination.
Some minor internal refactoring was needed to make sure vmlinux BTF can be
loaded before bpf
Add test for bpf_program__set_attach_target() API, validating it can find
kernel module fentry target.
Signed-off-by: Andrii Nakryiko
---
.../testing/selftests/bpf/prog_tests/module_attach.c | 11 ++-
.../testing/selftests/bpf/progs/test_module_attach.c | 11 +++
2 files change
On Fri, Dec 11, 2020 at 11:18 AM Eric Dumazet wrote:
>
> On Fri, Dec 11, 2020 at 6:15 PM Alexander Duyck
> wrote:
> >
> > On Fri, Dec 11, 2020 at 8:22 AM Eric Dumazet wrote:
> > >
> > > On Fri, Dec 11, 2020 at 5:03 PM Alexander Duyck
> > > wrote:
> > >
> > > > That's fine. I can target this for
My name is Cahil Frank an advertising agent with Eurocredit & loan services,
the company pays me commission as per each client introduced to them. The
Company specializes in providing equity funding for projects and corporate also
Personal loan funding at 3% Interest Rate for duration of 10 to 1
On Thu, Dec 10, 2020 at 08:27:32PM -0800, Andrii Nakryiko wrote:
> During BPF program load time, verifier will resolve FD to BTF object and will
> take reference on BTF object itself and, for module BTFs, corresponding module
> as well, to make sure it won't be unloaded from under running BPF progr
On Fri, Dec 11 2020 at 09:29, boris ostrovsky wrote:
> On 12/11/20 7:37 AM, Thomas Gleixner wrote:
>> On Fri, Dec 11 2020 at 13:10, Jürgen Groß wrote:
>>> On 11.12.20 00:20, boris.ostrov...@oracle.com wrote:
On 12/10/20 2:26 PM, Thomas Gleixner wrote:
> Change the implementation so that t
On 12/11/20 9:58 PM, Andrii Nakryiko wrote:
On Fri, Dec 11, 2020 at 8:51 AM Gary Lin wrote:
[...]
+static int emit_nops(u8 **pprog, int len)
+{
+ u8 *prog = *pprog;
+ int i, noplen, cnt = 0;
+
+ while (len > 0) {
+ noplen = len;
+
+ if (noplen >
On Fri, Dec 11 2020 at 14:19, David Laight wrote:
> From: Thomas Gleixner
>> You can't catch that. If this really becomes an issue you need a
>> sequence counter around it.
>
> Or just two copies of the high word.
> Provided the accesses are sequenced:
> writer:
> load high:low
> add sm
On Fri, Dec 11 2020 at 19:53, Andy Shevchenko wrote:
> On Thu, Dec 10, 2020 at 10:14 PM Thomas Gleixner wrote:
>>
>> irq_set_lockdep_class() is used from modules and requires irq_to_desc() to
>> be exported. Move it into the core code which lifts another requirement for
>> the export.
>
> ...
>
>
On Fri, Dec 11, 2020 at 5:37 PM Yonatan Linik wrote:
> index 2b33e977a905..031f2b593720 100644
> --- a/net/packet/af_packet.c
> +++ b/net/packet/af_packet.c
> @@ -4612,9 +4612,11 @@ static int __net_init packet_net_init(struct net *net)
> mutex_init(&net->packet.sklist_lock);
> IN
On Fri, Dec 11, 2020 at 8:51 AM Gary Lin wrote:
>
> The x64 bpf jit expects bpf images converge within the given passes, but
> it could fail to do so with some corner cases. For example:
>
> l0: ldh [4]
> l1: jeq #0x537d, l2, l40
> l2: ld [0]
> l3: jeq #0xfa
On Tue, Dec 08, 2020 at 13:23, Vladimir Oltean wrote:
> Sorry it took so long. I wanted to understand:
> (a) where are the challenged for drivers to uniformly support software
> bridging when they already have code for bridge offloading. I found
> the following issues:
> - We have tagg
On Fri, Dec 11, 2020 at 10:56 AM Jonathan Lemon
wrote:
>
> From: Jonathan Lemon
>
> On some systems, some variant of the following splat is
> repeatedly seen. The common factor in all traces seems
> to be the entry point to task_file_seq_next(). With the
> patch, all warnings go away.
>
> r
Hello,
syzbot found the following issue on:
HEAD commit:3db4c21c usb: typec: tcpm: Update vbus_vsafe0v on init
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=179809f350
kernel config: h
On 12/11/20 11:45 AM, Jakub Kicinski wrote:
> Ack, these patches are not exciting (to me), so I'm wondering if there
> is a better way. The only reason NIC would have to understand a ULP for
> ZC is to parse out header/message lengths. There's gotta be a way to
> pass those in header options or suc
On 12/11/20 9:19 AM, Gary Lin wrote:
The x64 bpf jit expects bpf images converge within the given passes, but
it could fail to do so with some corner cases. For example:
l0: ldh [4]
l1: jeq #0x537d, l2, l40
l2: ld [0]
l3: jeq #0xfa163e0d, l4, l40
Hi Maxim,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/HTB-offload/20201211-233216
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
On Fri, Dec 11, 2020 at 2:28 AM Cong Wang wrote:
>
> From: Cong Wang
>
> This patchset introduces a new bpf hash map which has timeout.
> Patch 1 is a preparation, patch 2 is the implementation of timeout
> map, patch 3 contains a test case for timeout map. Please check each
> patch description f
Currently this macro is defined in internal MHI header as
a TRE length mask. Moving it to external header allows MHI
client drivers to set this upper bound for the transmit
buffer size.
Signed-off-by: Hemant Kumar
Reviewed-by: Jeffrey Hugo
Reviewed-by: Manivannan Sadhasivam
---
drivers/bus/mhi
MHI userspace client driver is creating device file node
for user application to perform file operations. File
operations are handled by MHI core driver. Currently
QMI MHI channel is supported by this driver.
Signed-off-by: Hemant Kumar
Reviewed-by: Jeffrey Hugo
---
Documentation/mhi/index.rst
This patch series adds support for UCI driver. UCI driver enables userspace
clients to communicate to external MHI devices like modem. UCI driver probe
creates standard character device file nodes for userspace clients to
perform open, read, write, poll and release file operations. These file
opera
This MHI client driver allows userspace clients to transfer
raw data between MHI device and host using standard file operations.
Driver instantiates UCI device object which is associated to device
file node. UCI device object instantiates UCI channel object when device
file node is opened. UCI chan
Introduce xdp_init_buff and xdp_prepare_buff utility routines to initialize
xdp_buff data structure and remove duplicated code in all XDP capable
drivers.
Changes since v1:
- introduce xdp_prepare_buff utility routine
Lorenzo Bianconi (2):
net: xdp: introduce xdp_init_buff utility routine
net
Introduce xdp_init_buff utility routine to initialize xdp_buff fields
const over NAPI iterations (e.g. frame_sz or rxq pointer). Rely on
xdp_init_buff in all XDP capable drivers.
Signed-off-by: Lorenzo Bianconi
---
drivers/net/ethernet/amazon/ena/ena_netdev.c| 3 +--
drivers/net/ethernet
Introduce xdp_prepare_buff utility routine to initialize per-descriptor
xdp_buff fields (e.g. xdp_buff pointers). Rely on xdp_prepare_buff() in
all XDP capable drivers.
Signed-off-by: Lorenzo Bianconi
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
drivers/net/ethernet/broadcom
On Fri, Dec 11, 2020 at 7:26 AM Maxim Mikityanskiy wrote:
>
> HTB doesn't scale well because of contention on a single lock, and it
> also consumes CPU. This patch adds support for offloading HTB to
> hardware that supports hierarchical rate limiting.
>
> This solution addresses two main problems
On Fri, Dec 11, 2020 at 01:03:22AM +0800, DENG Qingfang wrote:
> MT7530 has a global RX length register, so we are actually changing its
> MRU.
> Enable MTU normalization for this reason.
>
> Signed-off-by: DENG Qingfang
> ---
Makes sense. Since it's global and not per port, this also helps the
s
keys_ex is dinamically allocated with calloc on line 770, but
is not freed in case of error at line 823.
Fixes: 081d6c310d3a ("tc: pedit: Support JSON dumping")
Signed-off-by: Andrea Claudi
---
tc/m_pedit.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tc/m_pedit.c b/tc/
This series fixes two memory leaks in iproute2,
in tc and devlink code.
Andrea Claudi (2):
devlink: fix memory leak in cmd_dev_flash()
tc: pedit: fix memory leak in print_pedit
devlink/devlink.c | 13 -
tc/m_pedit.c | 4 +++-
2 files changed, 11 insertions(+), 6 deletions(-
nlg_ntf is dinamically allocated in mnlg_socket_open(), and is freed on
the out: return path. However, some error paths do not free it,
resulting in memory leak.
This commit fix this using mnlg_socket_close(), and reporting the
correct error number when required.
Fixes: 9b13cddfe268 ("devlink: im
On Thu, 10 Dec 2020 19:43:57 -0700 David Ahern wrote:
> On 12/10/20 7:01 PM, Jakub Kicinski wrote:
> > On Wed, 9 Dec 2020 21:26:05 -0700 David Ahern wrote:
> >> Yes, TCP is a byte stream, so the packets could very well show up like
> >> this:
> >>
> >> +--+-+---+
From: Arjun Roy
At present, tcp_recvmsg() uses flags to track if any CMSGs are pending
and what those CMSGs are. These flags are currently magic numbers,
used only within tcp_recvmsg().
To prepare for receive timestamp support in tcp receive zerocopy,
gently refactor these magic numbers into enu
On 10/12/2020 5:39, David Ahern wrote:
> On 12/9/20 12:41 AM, Boris Pismenny wrote:
>
>> is applied there is relevant here. More generally, this offload is
>> very similar in concept to TLS offload (tls_device).
>>
>
> I disagree with the TLS comparison. As an example, AIUI the TLS offload
> wo
From: Arjun Roy
This patch series provides CMSG and receive timestamp support to TCP
receive zerocopy. Patch 1 refactors CMSG pending state for
tcp_recvmsg() to avoid the use of magic numbers; patch 2 implements
receive timestamp via CMSG support for receive zerocopy, and uses the
constants added
From: Arjun Roy
tcp_recvmsg() uses the CMSG mechanism to receive control information
like packet receive timestamps. This patch adds CMSG fields to
struct tcp_zerocopy_receive, and provides receive timestamps
if available to the user.
Signed-off-by: Arjun Roy
Signed-off-by: Eric Dumazet
Signed
Commit 924c43778a84 ("man: tc-ct.8: Add manual page for ct tc action")
add man page for tc-ct, but it brings with it a bogus block of text
in the benning of tc-flower man page.
This commit simply removes it.
Fixes: 924c43778a84 ("man: tc-ct.8: Add manual page for ct tc action")
Reported-by: Paolo
Souptick Joarder wrote:
> Kernel test robot reported warning:
>
>drivers/net/wireless/mediatek/mt76/tx.c: In function
> 'mt76_txq_schedule':
> >> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q'
> >> set but not used [-Wunused-but-set-variable]
> 499 | struct mt76_
Lee Jones wrote:
> Also add documentation for 'mvm'.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/intel/iwlwifi/mvm/rs.c:400: warning: cannot understand
> function prototype: 'const u16 expected_tpt_legacy[IWL_RATE_COUNT] = '
> drivers/net/wireless/intel/iwlw
"Gustavo A. R. Silva" wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> warning by replacing a /* fall through */ comment with the new
> pseudo-keyword macro fallthrough; instead of letting the code fall
> through to the next case.
>
> Notice that Clang doesn't recogniz
"Gustavo A. R. Silva" wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly using the fallthrough pseudo-keyword as a
> replacement for a number of "fall through" markings.
>
> Notice that Clang doesn't recognize "fall through" comments as
> im
"Gustavo A. R. Silva" wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly using the fallthrough pseudo-keyword as a
> replacement for a number of "fall through" markings.
>
> Notice that Clang doesn't recognize "fall through" comments as
> im
On Thu, Dec 10, 2020 at 9:57 PM Thomas Gleixner wrote:
>
> First of all drivers have absolutely no business to dig into the internals
> of an irq descriptor. That's core code and subject to change. All of this
> information is readily available to /proc/interrupts in a safe and race
> free way.
>
On Sun, Dec 06, 2020 at 12:25:45AM +0100, Thomas Gleixner wrote:
> Pavel,
>
> On Sat, Dec 05 2020 at 21:40, Pavel Machek wrote:
> > So... what kind of guarantees does this aim to provide / what tasks it
> > is useful for?
> >
> > For real time response, we have other approaches.
>
> Depends on yo
On Thu, 10 Dec 2020 19:25:46 +,
Thomas Gleixner wrote:
>
> The irq descriptor is already there, no need to look it up again.
>
> Signed-off-by: Thomas Gleixner
> Cc: Mark Rutland
> Cc: Catalin Marinas
> Cc: Will Deacon
> Cc: Marc Zyngier
> Cc: linux-arm-ker...@lists.infradead.org
> ---
On Thu, 10 Dec 2020 19:25:45 +,
Thomas Gleixner wrote:
>
> The irq descriptor is already there, no need to look it up again.
>
> Signed-off-by: Thomas Gleixner
> Cc: Marc Zyngier
> Cc: Russell King
> Cc: linux-arm-ker...@lists.infradead.org
> ---
> arch/arm/kernel/smp.c |2 +-
> 1 fi
On Fri, 11 Dec 2020 15:36:53 +0100 Eric Dumazet wrote:
> On Fri, Dec 11, 2020 at 12:24 PM SeongJae Park wrote:
> >
> > From: SeongJae Park
> >
> > On a few of our systems, I found frequent 'unshare(CLONE_NEWNET)' calls
> > make the number of active slab objects including 'sock_inode_cache' type
On Thu, Dec 10, 2020 at 10:14 PM Thomas Gleixner wrote:
>
> irq_set_lockdep_class() is used from modules and requires irq_to_desc() to
> be exported. Move it into the core code which lifts another requirement for
> the export.
...
> + if (IS_ENABLED(CONFIG_LOCKDEP))
> + __irq
Hello,
syzbot found the following issue on:
HEAD commit:0477e928 Linux 5.10-rc7
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16dacc1350
kernel config: https://syzkaller.appspot.com/x/.config?x=4305fa9ea70c7a9f
dashboard link: https://syzkaller.appspo
1 - 100 of 257 matches
Mail list logo