Re: [PATCH bpf] xsk: fix race in SKB mode transmit with shared cq

2020-12-10 Thread Magnus Karlsson
On Thu, Dec 10, 2020 at 10:53 PM Alexei Starovoitov wrote: > > On Thu, Dec 10, 2020 at 7:36 AM Magnus Karlsson > wrote: > > > > From: Magnus Karlsson > > > > Fix a race when multiple sockets are simultaneously calling sendto() > > when the completion ring is shared in the SKB case. This is the c

Re: [PATCH v17 3/3] bus: mhi: Add userspace client interface driver

2020-12-10 Thread Greg KH
On Thu, Dec 10, 2020 at 11:04:11PM -0800, Hemant Kumar wrote: > This MHI client driver allows userspace clients to transfer > raw data between MHI device and host using standard file operations. > Driver instantiates UCI device object which is associated to device > file node. UCI device object ins

RE: [PATCH net] vhost_net: fix high cpu load when sendmsg fails

2020-12-10 Thread wangyunjian
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Friday, December 11, 2020 10:53 AM > To: wangyunjian ; Michael S. Tsirkin > > Cc: virtualizat...@lists.linux-foundation.org; netdev@vger.kernel.org; Lilijun > (Jerry) ; chenchanghu ; > xudingke > Subject: Re: [PA

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-10 Thread Jon Nettleton
On Thu, Dec 10, 2020 at 7:08 PM Ioana Ciornei wrote: > > [Added also the netdev mailing list, I haven't heard of linux-netdev > before but kept it] > > On Thu, Dec 10, 2020 at 05:31:56PM +, Daniel Thompson wrote: > > Hi Ioana > > Hi Daniel, > > > > > On Mon, Jun 29, 2020 at 06:47:11PM +, I

Re: [PATCH net-next 3/7] net: hns3: add support for forwarding packet to queues of specified TC when flow director rule hit

2020-12-10 Thread tanhuazhong
On 2020/12/11 4:46, Saeed Mahameed wrote: On Thu, 2020-12-10 at 20:24 +0800, tanhuazhong wrote: On 2020/12/10 13:40, Saeed Mahameed wrote: On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: From: Jian Shen For some new device, it supports forwarding packet to queues of specified TC w

[PATCH v17 0/3] userspace MHI client interface driver

2020-12-10 Thread Hemant Kumar
This patch series adds support for UCI driver. UCI driver enables userspace clients to communicate to external MHI devices like modem. UCI driver probe creates standard character device file nodes for userspace clients to perform open, read, write, poll and release file operations. These file opera

[PATCH v17 2/3] docs: Add documentation for userspace client interface

2020-12-10 Thread Hemant Kumar
MHI userspace client driver is creating device file node for user application to perform file operations. File operations are handled by MHI core driver. Currently QMI MHI channel is supported by this driver. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo --- Documentation/mhi/index.rst

[PATCH v17 3/3] bus: mhi: Add userspace client interface driver

2020-12-10 Thread Hemant Kumar
This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device file node. UCI device object instantiates UCI channel object when device file node is opened. UCI chan

[PATCH v17 1/3] bus: mhi: core: Move MHI_MAX_MTU to external header file

2020-12-10 Thread Hemant Kumar
Currently this macro is defined in internal MHI header as a TRE length mask. Moving it to external header allows MHI client drivers to set this upper bound for the transmit buffer size. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi

[PATCH net-next] GTP: add support for flow based tunneling API

2020-12-10 Thread Pravin B Shelar
Following patch add support for flow based tunneling API to send and recv GTP tunnel packet over tunnel metadata API. This would allow this device integration with OVS or eBPF using flow based tunneling APIs. Signed-off-by: Pravin B Shelar --- drivers/net/gtp.c | 541 +++

Re: [PATCH net-next 2/7] net: hns3: add support for tc mqprio offload

2020-12-10 Thread tanhuazhong
On 2020/12/11 4:24, Saeed Mahameed wrote: On Thu, 2020-12-10 at 20:27 +0800, tanhuazhong wrote: On 2020/12/10 12:50, Saeed Mahameed wrote: On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: From: Jian Shen Currently, the HNS3 driver only supports offload for tc number and prio_tc. Th

Re: [PATCH] mt76: Fixed kernel test robot warning

2020-12-10 Thread Souptick Joarder
On Thu, Dec 10, 2020 at 12:46 PM Kalle Valo wrote: > > Souptick Joarder writes: > > > Kernel test robot throws below warning -> > > > >drivers/net/wireless/mediatek/mt76/tx.c: In function > > 'mt76_txq_schedule': > >>> drivers/net/wireless/mediatek/mt76/tx.c:499:21: warning: variable 'q' > >>

[PATCHv6 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-12-10 Thread George Cherian
Add devlink support to AF driver. Basic devlink support is added. Currently info_get is the only supported devlink ops. devlink ouptput looks like this # devlink dev pci/0002:01:00.0 # devlink dev info pci/0002:01:00.0: driver octeontx2-af # Signed-off-by: Sunil Kovvuri Goutham Signed-off

[PATCH 3/3] docs: octeontx2: Add Documentation for NPA health reporters

2020-12-10 Thread George Cherian
Add Documentation for devlink health reporters for NPA block. Signed-off-by: George Cherian --- .../ethernet/marvell/octeontx2.rst| 50 +++ 1 file changed, 50 insertions(+) diff --git a/Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rst b/Docume

[PATCHv6 net-next 0/3] Add devlink and devlink health reporters to

2020-12-10 Thread George Cherian
Add basic devlink and devlink health reporters. Devlink health reporters are added for NPA block. Address Jakub's comment to add devlink support for error reporting. https://www.spinics.net/lists/netdev/msg670712.html For now, I have dropped the NIX block health reporters. This series attempts t

[PATCH 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-12-10 Thread George Cherian
Add health reporters for RVU NPA block. NPA Health reporters handle following HW event groups - GENERAL events - ERROR events - RAS events - RVU event Output: #devlink health pci/0002:01:00.0: reporter hw_npa_intr state healthy error 0 recover 0 grace_period 0 auto_recover true auto

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-10 Thread Jürgen Groß
On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interrupts and overwrite the affinity mask with the corresponding cpumask. That does not make sense. The XEN impleme

Re: [PATCH bpf-next] selftests/bpf: fix bpf_testmod.ko recompilation logic

2020-12-10 Thread Alexei Starovoitov
On Thu, Dec 10, 2020 at 5:59 PM Andrii Nakryiko wrote: > > bpf_testmod.ko build rule declared dependency on VMLINUX_BTF, but the variable > itself was initialized after the rule was declared, which often caused > bpf_testmod.ko to not be re-compiled. Fix by moving VMLINUX_BTF determination > soone

Re: [PATCH v2 2/3] net: mhi: Get RX queue size from MHI core

2020-12-10 Thread Manivannan Sadhasivam
On Thu, Dec 10, 2020 at 12:15:50PM +0100, Loic Poulain wrote: > The RX queue size can be determined at runtime by retrieving the > number of available transfer descriptors. > > Signed-off-by: Loic Poulain > --- > v2: Fixed commit message typo > > drivers/net/mhi_net.c | 6 +++--- > 1 file chan

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Jon Nettleton
On Thu, Dec 10, 2020 at 9:27 PM Andrew Lunn wrote: > > > +1. As soon as the MDIO+ACPI lands, I plan to do the rework. > > Don't hold you breath. It has gone very quiet about ACPI in net > devices. NXP resources were re-allocated for their next internal BSP release. I have been working with Calvin

[PATCH RFC bpf-next 4/4] selftests/bpf: test kernel module ksym externs

2020-12-10 Thread Andrii Nakryiko
Add per-CPU variable to bpf_testmod.ko and use those from new selftest to validate it works end-to-end. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/bpf_testmod/bpf_testmod.c | 3 ++ .../selftests/bpf/prog_tests/ksyms_module.c | 33 +++ .../selftests/bpf/progs/test_k

[PATCH RFC bpf-next 0/4] Support kernel module ksym variables

2020-12-10 Thread Andrii Nakryiko
This RFC is sent to show how ksym variable access in BPF program can be supported for kernel modules and gather some feedback while necessary fixes for pahole ([0]) are reviewed and hopefully will make it into 1.20 version. This work builds on all the previous kernel and libbpf changes to support

[PATCH RFC bpf-next 3/4] libbpf: support kernel module ksym externs

2020-12-10 Thread Andrii Nakryiko
Add support for searching for ksym externs not just in vmlinux BTF, but across all module BTFs, similarly to how it's done for CO-RE relocations. Kernels that expose module BTFs through sysfs are assumed to support new ldimm64 instruction extension with BTF FD provided in insn[1].imm field, so no e

[PATCH RFC bpf-next 1/4] selftests/bpf: sync RCU before unloading bpf_testmod

2020-12-10 Thread Andrii Nakryiko
If some of the subtests use module BTFs through ksyms, they will cause bpf_prog to take a refcount on bpf_testmod module, which will prevent it from successfully unloading. Module's refcnt is decremented when bpf_prog is freed, which generally happens in RCU callback. So reuse kernel_sync_rcu(), so

[PATCH RFC bpf-next 2/4] bpf: support BPF ksym variables in kernel modules

2020-12-10 Thread Andrii Nakryiko
Add support for directly accessing kernel module variables from BPF programs using special ldimm64 instructions. This functionality builds upon vmlinux ksym support, but extends ldimm64 with src_reg=BPF_PSEUDO_BTF_ID to allow specifying kernel module BTF's FD in insn[1].imm field. During BPF progr

[PATCHv2] selftests: test_vxlan_under_vrf: mute unnecessary error message

2020-12-10 Thread Po-Hsu Lin
The cleanup function in this script that tries to delete hv-1 / hv-2 vm-1 / vm-2 netns will generate some uncessary error messages: Cannot remove namespace file "/run/netns/hv-2": No such file or directory Cannot remove namespace file "/run/netns/vm-1": No such file or directory Cannot remove name

Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

2020-12-10 Thread kernel test robot
Hi Michael, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on next-20201210] [cannot apply to net/master ipvs/master linus/master v5.10-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH] selftests: test_vxlan_under_vrf: mute uncessary error message

2020-12-10 Thread Po-Hsu Lin
The cleanup function in this script that tries to delete hv-1 / hv-2 vm-1 / vm-2 netns will generate some uncessary error messages: Cannot remove namespace file "/run/netns/hv-2": No such file or directory Cannot remove namespace file "/run/netns/vm-1": No such file or directory Cannot remove name

Re: [PATCH net-next v2 00/14] Add mlx5 subfunction support

2020-12-10 Thread Samudrala, Sridhar
On 12/8/2020 11:29 PM, sa...@kernel.org wrote: From: Parav Pandit Hi Dave, Jakub, Jason, This series form Parav was the theme of this mlx5 release cycle, we've been waiting anxiously for the auxbus infrastructure to make it into the kernel, and now as the auxbus is in and all the stars are ali

Re: [PATCH net] vhost_net: fix high cpu load when sendmsg fails

2020-12-10 Thread Jason Wang
On 2020/12/9 下午9:27, wangyunjian wrote: -Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Wednesday, December 9, 2020 8:50 PM To: wangyunjian Cc: jasow...@redhat.com; virtualizat...@lists.linux-foundation.org; netdev@vger.kernel.org; Lilijun (Jerry) ; chenchang

Re: [PATCH] net: core: fix msleep() is not accurate

2020-12-10 Thread Yejune Deng
Does anyone else have a different opinion? If not,I will adopt it and resubmit. On Thu, Dec 10, 2020 at 6:19 PM Eric Dumazet wrote: > > On Thu, Dec 10, 2020 at 10:35 AM Yejune Deng wrote: > > > > See Documentation/timers/timers-howto.rst, msleep() is not > > for (1ms - 20ms), There is a more adv

Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-10 Thread David Ahern
On 12/10/20 7:01 PM, Jakub Kicinski wrote: > On Wed, 9 Dec 2020 21:26:05 -0700 David Ahern wrote: >> Yes, TCP is a byte stream, so the packets could very well show up like this: >> >> +--+-+---+-++-+ >> | data - seg 1 | PDU hdr | prev data | TCP hdr

[PATCHv5 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2020-12-10 Thread Hangbin Liu
This patch add a xdp program on egress to show that we can modify the packet on egress. In this sample we will set the pkt's src mac to egress's mac address. The xdp_prog will be attached when -X option supplied. Signed-off-by: Hangbin Liu --- v5: a) close fd when err out in get_mac_addr() b) exi

Re: [PATCH v7] lib: optimize cpumask_local_spread()

2020-12-10 Thread Shaokun Zhang
Hi Dave, Apologies for the late reply. 在 2020/12/1 1:08, Dave Hansen 写道: { - int cpu, hk_flags; + static DEFINE_SPINLOCK(spread_lock); + static bool used[MAX_NUMNODES]; >>> >>> I thought I mentioned this last time. How large is this array? How >>> large would it be if it

Re: INFO: task hung in linkwatch_event (2)

2020-12-10 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:a7105e34 Merge branch 'hns3-next' git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=155af80f50 kernel config: https://syzkaller.appspot.com/x/.config?x=2ac2dabe250b3a58 dashboard link: h

Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-10 Thread Jakub Kicinski
On Wed, 9 Dec 2020 21:26:05 -0700 David Ahern wrote: > Yes, TCP is a byte stream, so the packets could very well show up like this: > > +--+-+---+-++-+ > | data - seg 1 | PDU hdr | prev data | TCP hdr | IP hdr | eth | > +--+-+-

Re: [PATCH net-next v2] inet_ecn: Use csum16_add() helper for IP_ECN_set_* helpers

2020-12-10 Thread kernel test robot
Hi "Toke, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/inet_ecn-Use-csum16_add-helper-for-IP_ECN_set_-helpers/20201211-071305 base: https://git.kernel.org/pub/scm/linux/ker

[PATCH bpf-next] selftests/bpf: fix bpf_testmod.ko recompilation logic

2020-12-10 Thread Andrii Nakryiko
bpf_testmod.ko build rule declared dependency on VMLINUX_BTF, but the variable itself was initialized after the rule was declared, which often caused bpf_testmod.ko to not be re-compiled. Fix by moving VMLINUX_BTF determination sooner. Also enforce bpf_testmod.ko recompilation when we detect that

[net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-10 Thread Alexander Duyck
From: Alexander Duyck In the case of a fastopen SYN there are cases where it may trigger either a ICMP_TOOBIG message in the case of IPv6 or a fragmentation request in the case of IPv4. This results in the socket stalling for a second or more as it does not respond to the message by retransmittin

[PATCH bpf] bpf: fix enum names for bpf_this_cpu_ptr() and bpf_per_cpu_ptr() helpers

2020-12-10 Thread Andrii Nakryiko
Remove bpf_ prefix, which causes these helpers to be reported in verifier dump as bpf_bpf_this_cpu_ptr() and bpf_bpf_per_cpu_ptr(), respectively. Fixes: eaa6bcb71ef6 ("bpf: Introduce bpf_per_cpu_ptr()") Signed-off-by: Andrii Nakryiko --- include/uapi/linux/bpf.h | 4 ++-- kernel/bpf/helper

[PATCH v2 13/21] net: stmmac: dwmac-sun8i: Prepare for second EMAC clock register

2020-12-10 Thread Andre Przywara
The Allwinner H616 SoC has two EMAC controllers, with the second one being tied to the internal PHY, but also using a separate EMAC clock register. To tell the driver about which clock register to use, we add a parameter to our syscon phandle. The driver will use this value as an index into the re

Re: Refcount mismatch when unregistering netdevice from kernel

2020-12-10 Thread stranche
BTW, have you tried your previous proposed patch and confirmed it would fix the issue? Yes, we shared this with the customer and the refcount mismatch still occurred, so this doesn't seem sufficient either. Could we further distinguish between dst added to the uncached list by icmp6_dst_all

Re: [PATCH iproute2-next v1] iplink macvlan: Added bcqueuelen parameter

2020-12-10 Thread Jakub Kicinski
On Thu, 10 Dec 2020 17:07:51 +0100 Thomas Karlsson wrote: > On 2020-11-30 15:23, Thomas Karlsson wrote: > > This is a follow up patch to iproute2 that allows the user > > to set and retrieve the added IFLA_MACVLAN_BC_QUEUE_LEN parameter > > via the bcqueuelen command line argument > > > > > > v1

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Vinicius Costa Gomes
Willem de Bruijn writes: >> > If I understand correctly, you are trying to achieve a single delivery >> > time. >> > The need for two separate timestamps passed along is only because the >> > kernel is unable to do the time base conversion. >> >> Yes, a correct point. >> >> > >> > Else, ETF coul

[PATCH net-next] sfc: backport XDP EV queue sharing from the out-of-tree driver

2020-12-10 Thread Ivan Babrou
Queue sharing behaviour already exists in the out-of-tree sfc driver, available under xdp_alloc_tx_resources module parameter. This avoids the following issue on machines with many cpus: Insufficient resources for 12 XDP event queues (24 other channels, max 32) Which in turn triggers EINVAL on X

Re: [PATCHv4 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2020-12-10 Thread Daniel Borkmann
On 12/8/20 1:01 PM, Hangbin Liu wrote: [...] +static int get_mac_addr(unsigned int ifindex_out, void *mac_addr) +{ + struct ifreq ifr; + char ifname[IF_NAMESIZE]; + int fd = socket(AF_INET, SOCK_DGRAM, 0); + + if (fd < 0) + return -1; + + if (!if_ind

[Patch bpf-next 3/3] tools: add a test case for bpf timeout map

2020-12-10 Thread Cong Wang
From: Cong Wang Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Dongdong Wang Signed-off-by: Cong Wang --- tools/testing/selftests/bpf/test_maps.c | 41 + 1 file changed, 41 insertions(+) diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/

[Patch bpf-next 1/3] bpf: use index instead of hash for map_locked[]

2020-12-10 Thread Cong Wang
From: Cong Wang Commit 20b6cc34ea74 ("bpf: Avoid hashtab deadlock with map_locked") introduced a percpu counter map_locked to bail out NMI case. It uses the hash of each bucket for indexing, which requires callers of htab_lock_bucket()/htab_unlock_bucket() to pass it in. But hash value is not alw

[Patch bpf-next 0/3] bpf: introduce timeout map

2020-12-10 Thread Cong Wang
From: Cong Wang This patchset introduces a new bpf hash map which has timeout. Patch 1 is a preparation, patch 2 is the implementation of timeout map, patch 3 contains a test case for timeout map. Please check each patch description for more details. --- Cong Wang (3): bpf: use index instead o

[Patch bpf-next 2/3] bpf: introduce timeout map

2020-12-10 Thread Cong Wang
From: Cong Wang This borrows the idea from conntrack and will be used for conntrack in bpf too. Each element in a timeout map has a user-specified timeout in secs, after it expires it will be automatically removed from the map. There are two cases here: 1. When the timeout map is idle, that is,

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-10 Thread Thomas Gleixner
On Thu, Dec 10 2020 at 18:20, boris ostrovsky wrote: > On 12/10/20 2:26 PM, Thomas Gleixner wrote: >> All event channel setups bind the interrupt on CPU0 or the target CPU for >> percpu interrupts and overwrite the affinity mask with the corresponding >> cpumask. That does not make sense. >> >> The

Re: [patch 24/30] xen/events: Remove unused bind_evtchn_to_irq_lateeoi()

2020-12-10 Thread Thomas Gleixner
On Thu, Dec 10 2020 at 18:19, boris ostrovsky wrote: > On 12/10/20 2:26 PM, Thomas Gleixner wrote: >> -EXPORT_SYMBOL_GPL(bind_evtchn_to_irq_lateeoi); > > include/xen/events.h also needs to be updated (and in the next patch for > xen_set_affinity_evtchn() as well). Darn, I lost that.

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Marcin Wojtas
czw., 10 gru 2020 o 21:26 Andrew Lunn napisał(a): > > > +1. As soon as the MDIO+ACPI lands, I plan to do the rework. > > Don't hold you breath. It has gone very quiet about ACPI in net > devices. I saw the results of the upcoming next revision from NXP, so I'm rather optimistic. Best regards, Ma

[PATCH iproute2-next 02/10] dcb: ets: Fix help display for "show" subcommand

2020-12-10 Thread Petr Machata
"dcb ets show dev X help" currently shows full "ets" help instead of just help for the show command. Fix it. Signed-off-by: Petr Machata --- dcb/dcb_ets.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dcb/dcb_ets.c b/dcb/dcb_ets.c index 1735885aa8ed..94c6019e8095 100644

Re: [PATCH] selftests: Skip BPF seftests by default

2020-12-10 Thread Shuah Khan
On 12/10/20 12:11 PM, Alexei Starovoitov wrote: On Thu, Dec 10, 2020 at 06:52:33PM +, Mark Brown wrote: The BPF selftests have build time dependencies on cutting edge versions of tools in the BPF ecosystem including LLVM which are more involved to satisfy than more typical requirements like

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Willem de Bruijn
> > If I understand correctly, you are trying to achieve a single delivery time. > > The need for two separate timestamps passed along is only because the > > kernel is unable to do the time base conversion. > > Yes, a correct point. > > > > > Else, ETF could program the qdisc watchdog in system ti

Re: [PATCH bpf-next v2] samples/bpf: fix possible hang in xdpsock with multiple threads

2020-12-10 Thread Daniel Borkmann
On 12/10/20 5:34 PM, Magnus Karlsson wrote: From: Magnus Karlsson Fix a possible hang in xdpsock that can occur when using multiple threads. In this case, one or more of the threads might get stuck in the while-loop in tx_only after the user has signaled the main thread to stop execution. In th

Fw: [GIT] Networking

2020-12-10 Thread David Miller
Typod this lists addr first two times, third times the cgarm I suppose. --- Begin Message --- 1) IPsec compaat fixes, from Dmitrey Safonov. 2) Fix memory leak in xfrm_user_policy(). Fix from Yu Kuai. 3) Fix polling in xsk sockets by using sk_poll_wait() instead of datagram_poll() which key

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-10 Thread boris . ostrovsky
On 12/10/20 2:26 PM, Thomas Gleixner wrote: > All event channel setups bind the interrupt on CPU0 or the target CPU for > percpu interrupts and overwrite the affinity mask with the corresponding > cpumask. That does not make sense. > > The XEN implementation of irqchip::irq_set_affinity() already

Re: [patch 24/30] xen/events: Remove unused bind_evtchn_to_irq_lateeoi()

2020-12-10 Thread boris . ostrovsky
On 12/10/20 2:26 PM, Thomas Gleixner wrote: > Signed-off-by: Thomas Gleixner > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Stefano Stabellini > Cc: xen-de...@lists.xenproject.org > --- > drivers/xen/events/events_base.c |6 -- > 1 file changed, 6 deletions(-) > > --- a/drivers/xen/

[PATCH net-next 3/9] selftests: mptcp: add the flush addrs testcase

2020-12-10 Thread Mat Martineau
From: Geliang Tang This patch added the flush addrs testcase. In do_transfer, if the number of removing addresses is less than 8, use the del addr command to remove the addresses one by one. If the number is more than 8, use the flush addrs command to remove the addresses. Acked-by: Paolo Abeni

[PATCH net-next 4/9] mptcp: use MPTCPOPT_HMAC_LEN macro

2020-12-10 Thread Mat Martineau
From: Geliang Tang Use the macro MPTCPOPT_HMAC_LEN instead of a constant in struct mptcp_options_received. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/protocol.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/protocol.h b/net/mptcp/pro

Re: [PATCH v3 1/1] xdp: avoid calling kfree twice

2020-12-10 Thread Daniel Borkmann
On 12/11/20 5:26 AM, Zhu Yanjun wrote: In the function xdp_umem_pin_pages, if npgs != umem->npgs and npgs >= 0, the function xdp_umem_unpin_pages is called. In this function, kfree is called to handle umem->pgs, and then in the function xdp_umem_pin_pages, kfree is called again to handle umem->pg

[PATCH net-next 5/9] mptcp: hold mptcp socket before calling tcp_done

2020-12-10 Thread Mat Martineau
From: Florian Westphal When processing options from tcp reset path its possible that tcp_done(ssk) drops the last reference on the mptcp socket which results in use-after-free. Reviewed-by: Matthieu Baerts Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/subflow.c |

[PATCH net-next 1/9] mptcp: attach subflow socket to parent cgroup

2020-12-10 Thread Mat Martineau
From: Nicolas Rybowski It has been observed that the kernel sockets created for the subflows (except the first one) are not in the same cgroup as their parents. That's because the additional subflows are created by kernel workers. This is a problem with eBPF programs attached to the parent's cgr

[PATCH net-next 2/9] mptcp: remove address when netlink flushes addrs

2020-12-10 Thread Mat Martineau
From: Geliang Tang When the PM netlink flushes the addresses, invoke the remove address function mptcp_nl_remove_subflow_and_signal_addr to remove the addresses and the subflows. Since this function should not be invoked under lock, move __flush_addrs out of the pernet->lock. Acked-by: Paolo Abe

[PATCH net-next v2] inet_ecn: Use csum16_add() helper for IP_ECN_set_* helpers

2020-12-10 Thread Toke Høiland-Jørgensen
Jakub pointed out that the IP_ECN_set* helpers basically open-code csum16_add(), so let's switch them over to using the helper instead. v2: - Use __be16 for check_add stack variable in IP_ECN_set_ce() (kbot) Reported-by: Jakub Kicinski Tested-by: Jonathan Morton Tested-by: Pete Heist Signed-of

[PATCH net-next 0/9] mptcp: Another set of miscellaneous MPTCP fixes

2020-12-10 Thread Mat Martineau
This is another collection of MPTCP fixes and enhancements that we have tested in the MPTCP tree: Patch 1 cleans up cgroup attachment for in-kernel subflow sockets. Patches 2 and 3 make sure that deletion of advertised addresses by an MPTCP path manager when flushing all addresses behaves similar

pull-request: bpf 2020-12-10

2020-12-10 Thread Alexei Starovoitov
Hi David, hi Jakub, The following pull-request contains BPF updates for your *net* tree. We've added 21 non-merge commits during the last 12 day(s) which contain a total of 21 files changed, 163 insertions(+), 88 deletions(-). The main changes are: 1) Fix propagation of 32-bit signed bounds fro

Re: [PATCH v4 net-next 0/2] add ppp_generic ioctl(s) to bridge channels

2020-12-10 Thread David Miller
From: Tom Parkin Date: Thu, 10 Dec 2020 17:16:45 + > On Thu, Dec 10, 2020 at 18:13:09 +0100, Guillaume Nault wrote: >> On Thu, Dec 10, 2020 at 03:50:56PM +, Tom Parkin wrote: >> > Following on from my previous RFC[1], this series adds two ioctl calls >> > to the ppp code to implement "ch

[PATCH iproute2-next 09/10] dcb: Add a subtool for the DCB buffer object

2020-12-10 Thread Petr Machata
DCBNL buffer interfaces are an extension to the 802.1q DCB interfaces and allow configuration of port headroom buffers. Add a dcb subtool to allow showing and tweaking of buffer priority mapping and buffer sizes. For example: # dcb buf show dev eni1np1 prio-buffer 0:0 1:0 2:0 3:3 4:0 5:0

[PATCH net-next 6/9] tcp: parse mptcp options contained in reset packets

2020-12-10 Thread Mat Martineau
From: Florian Westphal Because TCP-level resets only affect the subflow, there is a MPTCP option to indicate that the MPTCP-level connection should be closed immediately without a mptcp-level fin exchange. This is the 'MPTCP fast close option'. It can be carried on ack segments or TCP resets.

[PATCH iproute2-next 03/10] dcb: ets: Change the way show parameters are given in synopsis

2020-12-10 Thread Petr Machata
None, one, or many parameters can be given on the command line, but the current synopsis allows only none or one. Fix it. Signed-off-by: Petr Machata --- dcb/dcb_ets.c | 6 +++--- man/man8/dcb-ets.8 | 13 ++--- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/dcb/dcb

[PATCH iproute2-next 00/10] dcb: Support PFC, buffer, maxrate objects

2020-12-10 Thread Petr Machata
Add support to the dcb tool for the following three DCB objects: - PFC, for "Priority-based Flow Control", allows configuration of priority lossiness, and related toggles. - DCBNL buffer interfaces are an extension to the 802.1q DCB interfaces and allow configuration of port headroom buffers.

[PATCH iproute2-next 10/10] dcb: Add a subtool for the DCB maxrate object

2020-12-10 Thread Petr Machata
DCBNL maxrate interfaces are an extension to the 802.1q DCB interfaces and allow configuration of rate with which traffic in a given traffic class is sent. Add a dcb subtool to allow showing and tweaking of this per-TC maximum rate. For example: # dcb maxrate show dev eni1np1 tc-maxrate 0

[PATCH iproute2-next 04/10] man: dcb-ets: Remove an unnecessary empty line

2020-12-10 Thread Petr Machata
Signed-off-by: Petr Machata --- man/man8/dcb-ets.8 | 1 - 1 file changed, 1 deletion(-) diff --git a/man/man8/dcb-ets.8 b/man/man8/dcb-ets.8 index 1ef0948fb062..9c64b33e30ff 100644 --- a/man/man8/dcb-ets.8 +++ b/man/man8/dcb-ets.8 @@ -61,7 +61,6 @@ the DCB (Data Center Bridging) subsystem .ti -

[PATCH iproute2-next 05/10] dcb: Add dcb_set_u32(), dcb_set_u64()

2020-12-10 Thread Petr Machata
The DCB buffer object has a settable array of 32-bit quantities, and the maxrate object of 64-bit ones. Adjust dcb_parse_mapping() and related helpers to support 64-bit values in mappings, and add appropriate helpers. Signed-off-by: Petr Machata --- dcb/dcb.c | 22 ++ dcb/dcb

[PATCH net-next 8/9] mptcp: pm: simplify select_local_address()

2020-12-10 Thread Mat Martineau
From: Paolo Abeni There is no need to unconditionally acquire the join list lock, we can simply splice the join list into the subflow list and traverse only the latter. Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/pm_netlink.c | 6 ++ 1 file changed, 2 insertions(

[PATCH iproute2-next 01/10] dcb: Remove unsupported command line arguments from getopt_long()

2020-12-10 Thread Petr Machata
getopt_long() currently includes "c" and "n" in the short option string. These probably slipped in as a cut'n'paste, and are not actually accepted. Remove them. Signed-off-by: Petr Machata --- dcb/dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dcb/dcb.c b/dcb/dcb.c ind

[PATCH iproute2-next 07/10] dcb: Add -i to enable IEC mode

2020-12-10 Thread Petr Machata
Allow switching "dcb" into the ISO/IEC mode of units by passing -i. Signed-off-by: Petr Machata --- dcb/dcb.c | 10 +++--- dcb/dcb.h | 1 + man/man8/dcb.8 | 5 + 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/dcb/dcb.c b/dcb/dcb.c index 9332a8b2e3d4..4b4a5b93

[PATCH iproute2-next 06/10] dcb: Add -s to enable statistics

2020-12-10 Thread Petr Machata
Allow selective display of statistical counters by passing -s. Signed-off-by: Petr Machata --- dcb/dcb.c | 9 +++-- dcb/dcb.h | 1 + man/man8/dcb.8 | 5 + 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/dcb/dcb.c b/dcb/dcb.c index 7c0beee43686..9332a8b2e3d4 1006

[PATCH iproute2-next 08/10] dcb: Add a subtool for the DCB PFC object

2020-12-10 Thread Petr Machata
PFC, for "Priority-based Flow Control", allows configuration of priority lossiness, and related toggles. Add a dcb subtool to allow showing and tweaking of individual PFC configuration options, and querying statistics. For example: # dcb pfc show dev eni1np1 pfc-cap 8 macsec-bypass on del

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Geva, Erez
On 10/12/2020 20:11, Willem de Bruijn wrote: > On Wed, Dec 9, 2020 at 3:18 PM Geva, Erez wrote: >> >> >> On 09/12/2020 18:37, Willem de Bruijn wrote: >>> On Wed, Dec 9, 2020 at 10:25 AM Geva, Erez >>> wrote: On 09/12/2020 15:48, Willem de Bruijn wrote: > On Wed, Dec 9, 2020 a

[PATCH net-next 9/9] mptcp: let MPTCP create max size skbs

2020-12-10 Thread Mat Martineau
From: Paolo Abeni Currently the xmit path of the MPTCP protocol creates smaller- than-max-size skbs, which is suboptimal for the performances. There are a few things to improve: - when coalescing to an existing skb, must clear the PUSH flag - tcp_build_frag() expect the available space as an arg

RE: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-10 Thread David Laight
From: Xie He > Sent: 10 December 2020 10:17 > > On Thu, Dec 10, 2020 at 1:14 AM David Laight wrote: > > > > > To me, LLC1 and LLC2 are to Ethernet what UDP and TCP are to IP > > > networks. I think we can use LLC1 and LLC2 wherever UDP and TCP can be > > > used, as long as we are in the same LAN

Re: [patch 19/30] PCI: mobiveil: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Rob Herring
On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant fo

Re: [patch 18/30] PCI: xilinx-nwl: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Rob Herring
On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant fo

Re: pull-request: bpf 2020-12-10

2020-12-10 Thread David Miller
From: Alexei Starovoitov Date: Thu, 10 Dec 2020 14:25:01 -0800 > Hi David, hi Jakub, > > The following pull-request contains BPF updates for your *net* tree. > > We've added 21 non-merge commits during the last 12 day(s) which contain > a total of 21 files changed, 163 insertions(+), 88 deletio

Re: [PATCH bpf] xsk: fix race in SKB mode transmit with shared cq

2020-12-10 Thread Alexei Starovoitov
On Thu, Dec 10, 2020 at 7:36 AM Magnus Karlsson wrote: > > From: Magnus Karlsson > > Fix a race when multiple sockets are simultaneously calling sendto() > when the completion ring is shared in the SKB case. This is the case > when you share the same netdev and queue id through the > XDP_SHARED_U

[PATCH net-next 7/9] mptcp: parse and act on incoming FASTCLOSE option

2020-12-10 Thread Mat Martineau
From: Florian Westphal parse the MPTCP FASTCLOSE subtype. If provided key matches the local one, schedule the work queue to close (with tcp reset) all subflows. The MPTCP socket moves to closed state immediately. Reviewed-by: Matthieu Baerts Signed-off-by: Florian Westphal Signed-off-by: Mat

Re: [PATCH v2 0/1] net: Reduce rcu_barrier() contentions from 'unshare(CLONE_NEWNET)'

2020-12-10 Thread SeongJae Park
On Thu, 10 Dec 2020 15:09:10 +0100 Eric Dumazet wrote: > On Thu, Dec 10, 2020 at 9:09 AM SeongJae Park wrote: > > > > From: SeongJae Park > > > > On a few of our systems, I found frequent 'unshare(CLONE_NEWNET)' calls > > make the number of active slab objects including 'sock_inode_cache' type

[PATCH] nfc: s3fwrn5: let core configure the interrupt trigger

2020-12-10 Thread Krzysztof Kozlowski
If interrupt trigger is not set when requesting the interrupt, the core will take care of reading trigger type from Devicetree. There is no point to do it in the driver. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/s3fwrn5/i2c.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-)

Re: [PATCH net-next] rtnetlink: RCU-annotate both dimensions of rtnl_msg_handlers

2020-12-10 Thread David Miller
From: Jakub Kicinski Date: Wed, 9 Dec 2020 18:16:08 -0800 > We use rcu_assign_pointer to assign both the table and the entries, > but the entries are not marked as __rcu. This generates sparse > warnings. > > Signed-off-by: Jakub Kicinski > --- Applied.

Re: [PATCH wireless -next] cw1200: txrx: convert comma to semicolon

2020-12-10 Thread Joe Perches
On Thu, 2020-12-10 at 18:50 +, Kalle Valo wrote: > Zheng Yongjun wrote: > > > Replace a comma between expression statements by a semicolon. > > > > Signed-off-by: Zheng Yongjun > > Patch applied to wireless-drivers-next.git, thanks. > > c42d492c672a cw1200: txrx: convert comma to semicolo

Re: [PATCH] Revert "macb: support the two tx descriptors on at91rm9200"

2020-12-10 Thread David Miller
From: Willy Tarreau Date: Wed, 9 Dec 2020 19:47:40 +0100 > This reverts commit 0a4e9ce17ba77847e5a9f87eed3c0ba46e3f82eb. > > The code was developed and tested on an MSC313E SoC, which seems to be > half-way between the AT91RM9200 and the AT91SAM9260 in that it supports > both the 2-descriptors

Re: [PATCH net-next] net: qualcomm: rmnet: Update rmnet device MTU based on real device

2020-12-10 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Wed, 9 Dec 2020 22:51:46 -0700 > Packets sent by rmnet to the real device have variable MAP header > lengths based on the data format configured. This patch adds checks > to ensure that the real device MTU is sufficient to transmit the MAP > packet comp

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
> On Thu, 2020-12-10 at 20:28 +0100, Lorenzo Bianconi wrote: > > > On Thu, 2020-12-10 at 18:59 +0100, Lorenzo Bianconi wrote: > > > > On Dec 10, Maciej Fijalkowski wrote: > > > > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi > > > > > wrote: > > > > > > > On Thu, Dec 10, 2020 at 04:5

Re: [PATCH net-next] net: lapbether: Consider it successful if (dis)connecting when already (dis)connected

2020-12-10 Thread David Miller
From: Xie He Date: Tue, 8 Dec 2020 14:50:44 -0800 > When the upper layer instruct us to connect (or disconnect), but we have > already connected (or disconnected), consider this operation successful > rather than failed. > > This can help the upper layer to correct its record about whether we a

Re: [net-next] tcp: correctly handle increased zerocopy args struct size

2020-12-10 Thread David Miller
From: Arjun Roy Date: Thu, 10 Dec 2020 11:16:03 -0800 > From: Arjun Roy > > A prior patch increased the size of struct tcp_zerocopy_receive > but did not update do_tcp_getsockopt() handling to properly account > for this. > > This patch simply reintroduces content erroneously cut from the > re

Re: [PATCH net-next] igc: Add new device ID

2020-12-10 Thread David Miller
From: Tony Nguyen Date: Thu, 10 Dec 2020 11:08:12 -0800 > From: Sasha Neftin > > Add new device ID for the next step of the silicon and > reflect the I226_K part. > > Signed-off-by: Sasha Neftin > Tested-by: Aaron Brown > Signed-off-by: Tony Nguyen > Applied.

  1   2   3   >