Re: [PATCH net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Support a UART interface

2020-11-24 Thread Krzysztof Kozlowski
On Wed, 25 Nov 2020 at 04:08, Bongsu Jeon wrote: > > On 11/24/20, k...@kernel.org wrote: > > On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote: > >> On Mon, Nov 23, 2020 at 5:02 PM k...@kernel.org wrote: > >> > > >> > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote: > > >

[net v2] ch_ktls: lock is not freed

2020-11-24 Thread Rohit Maheshwari
Currently lock gets freed only if timeout expires, but missed a case when HW returns failure and goes for cleanup. Fixes: efca3878a5fb ("ch_ktls: Issue if connection offload fails") Signed-off-by: Rohit Maheshwari --- .../net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 4 +++- 1 file

Re: [PATCH v4] dt-bindings: misc: convert fsl,qoriq-mc from txt to YAML

2020-11-24 Thread Ioana Ciornei
On Mon, Nov 23, 2020 at 11:00:35AM +0200, Laurentiu Tudor wrote: > From: Ionut-robert Aron > > Convert fsl,qoriq-mc to YAML in order to automate the verification > process of dts files. In addition, update MAINTAINERS accordingly > and, while at it, add some missing files. > > Signed-off-by: Ion

RE: [PATCH net 1/2] devlink: Hold rtnl lock while reading netdev attributes

2020-11-24 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Wednesday, November 25, 2020 3:59 AM > > On Sun, 22 Nov 2020 08:12:56 +0200 Parav Pandit wrote: > > A netdevice of a devlink port can be moved to different net namespace > > than its parent devlink instance. > > This scenario occurs when devlink reload is not use

Re: [PATCH bpf-next v3 04/10] xsk: check need wakeup flag in sendmsg()

2020-11-24 Thread Magnus Karlsson
On Thu, Nov 19, 2020 at 9:33 AM Björn Töpel wrote: > > From: Björn Töpel > > Add a check for need wake up in sendmsg(), so that if a user calls > sendmsg() when no wakeup is needed, do not trigger a wakeup. > > To simplify the need wakeup check in the syscall, unconditionally > enable the need wa

Re: [PATCH] stmmac: pci: Add support for LS7A bridge chip

2020-11-24 Thread Zhi Li
Hi Jiaxun, It's my fault, I didn't know to send mail to the mailing list. We will discuss your suggestions and correct the errors in the code. I will send a new patch to the mailing list. Thanks. -Lizhi On 11/23/2020 06:31 PM, Jiaxun Yang wrote: Hi Lizhi, You didn't send the patch to any

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread James Bottomley
On Tue, 2020-11-24 at 13:32 -0800, Kees Cook wrote: > On Mon, Nov 23, 2020 at 08:31:30AM -0800, James Bottomley wrote: > > Really, no ... something which produces no improvement has no value > > at all ... we really shouldn't be wasting maintainer time with it > > because it has a cost to merge. I

Re: [PATCH bpf-next v3 03/10] xsk: add support for recvmsg()

2020-11-24 Thread Magnus Karlsson
On Thu, Nov 19, 2020 at 9:32 AM Björn Töpel wrote: > > From: Björn Töpel > > Add support for non-blocking recvmsg() to XDP sockets. Previously, > only sendmsg() was supported by XDP socket. Now, for symmetry and the > upcoming busy-polling support, recvmsg() is added. > > Signed-off-by: Björn Töp

[PATCH bpf v2 1/2] xsk: replace datagram_poll by sock_poll_wait

2020-11-24 Thread Xuan Zhuo
datagram_poll will judge the current socket status (EPOLLIN, EPOLLOUT) based on the traditional socket information (eg: sk_wmem_alloc), but this does not apply to xsk. So this patch uses sock_poll_wait instead of datagram_poll, and the mask is calculated by xsk_poll. Signed-off-by: Xuan Zhuo ---

[PATCH bpf v2 0/2] xsk: fix for xsk_poll writeable

2020-11-24 Thread Xuan Zhuo
Thanks for magnus very much. V2: #2 patch made some changes following magnus' opinions. Xuan Zhuo (2): xsk: replace datagram_poll by sock_poll_wait xsk: change the tx writeable condition net/xdp/xsk.c | 20 net/xdp/xsk_queue.h | 6 ++ 2 files changed, 22 i

[PATCH bpf v2 2/2] xsk: change the tx writeable condition

2020-11-24 Thread Xuan Zhuo
Modify the tx writeable condition from the queue is not full to the number of present tx queues is less than the half of the total number of queues. Because the tx queue not full is a very short time, this will cause a large number of EPOLLOUT events, and cause a large number of process wake up. S

Re: netconsole deadlock with virtnet

2020-11-24 Thread Jason Wang
On 2020/11/25 上午12:20, Jakub Kicinski wrote: On Tue, 24 Nov 2020 11:22:03 +0800 Jason Wang wrote: Perhaps you need the trylock in virtnet_poll_tx()? That could work. Best if we used normal lock if !!budget, and trylock when budget is 0. But maybe that's too hairy. If we use trylock, we proba

Re: netconsole deadlock with virtnet

2020-11-24 Thread Jason Wang
On 2020/11/24 下午10:31, Steven Rostedt wrote: On Tue, 24 Nov 2020 11:22:03 +0800 Jason Wang wrote: Btw, have a quick search, there are several other drivers that uses tx lock in the tx NAPI. tx NAPI is not the issue. The issue is that write_msg() (in netconsole.c) calls this polling logic wi

Re: [PATCH mlx5-next 11/16] net/mlx5: Add VDPA priority to NIC RX namespace

2020-11-24 Thread Eli Cohen
On Tue, Nov 24, 2020 at 03:44:13PM -0400, Jason Gunthorpe wrote: > On Tue, Nov 24, 2020 at 10:41:06AM -0800, Jakub Kicinski wrote: > > On Tue, 24 Nov 2020 14:02:10 -0400 Jason Gunthorpe wrote: > > > On Tue, Nov 24, 2020 at 09:12:19AM -0800, Jakub Kicinski wrote: > > > > On Sun, 22 Nov 2020 08:41:58

RE: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-24 Thread Parav Pandit
Hi David, > From: David Ahern > Sent: Wednesday, November 25, 2020 11:04 AM > > On 11/18/20 10:57 PM, Saeed Mahameed wrote: > > > > We are not slicing up any queues, from our HW and FW perspective SF == > > VF literally, a full blown HW slice (Function), with isolated control > > and data plane

Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs

2020-11-24 Thread Kalle Valo
Jakub Kicinski writes: > On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote: >> These are only used as input arguments to qmi_handle_init() which >> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them >> const to allow the compiler to put them in read-only memory. >> >>

Re: [PATCH net 1/2] ibmvnic: Ensure that SCRQ entry reads are correctly ordered

2020-11-24 Thread Michael Ellerman
Thomas Falcon writes: > Ensure that received Subordinate Command-Response Queue (SCRQ) > entries are properly read in order by the driver. These queues > are used in the ibmvnic device to process RX buffer and TX completion > descriptors. dma_rmb barriers have been added after checking for a > pen

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-24 Thread David Ahern
On 11/18/20 10:57 PM, Saeed Mahameed wrote: > > We are not slicing up any queues, from our HW and FW perspective SF == > VF literally, a full blown HW slice (Function), with isolated control > and data plane of its own, this is very different from VMDq and more > generic and secure. an SF device i

Re: [PATCHv6 iproute2-next 0/5] iproute2: add libbpf support

2020-11-24 Thread patchwork-bot+netdevbpf
Hello: This series was applied to iproute2/iproute2-next.git (refs/heads/main): On Mon, 23 Nov 2020 21:11:56 +0800 you wrote: > This series converts iproute2 to use libbpf for loading and attaching > BPF programs when it is available. This means that iproute2 will > correctly process BTF informat

Re: [PATCHv6 iproute2-next 0/5] iproute2: add libbpf support

2020-11-24 Thread David Ahern
On 11/23/20 6:11 AM, Hangbin Liu wrote: > This series converts iproute2 to use libbpf for loading and attaching > BPF programs when it is available. This means that iproute2 will > correctly process BTF information and support the new-style BTF-defined > maps, while keeping compatibility with the o

Re: [PATCH net v2] Documentation: netdev-FAQ: suggest how to post co-dependent series

2020-11-24 Thread David Miller
From: Jakub Kicinski Date: Tue, 24 Nov 2020 20:15:24 -0800 > Make an explicit suggestion how to post user space side of kernel > patches to avoid reposts when patchwork groups the wrong patches. > > v2: mention the cases unlike iproute2 explicitly > > Signed-off-by: Jakub Kicinski > Reviewed-b

Re: [PATCH iproute2-next 1/1] tc flower: fix parsing vlan_id and vlan_prio

2020-11-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to iproute2/iproute2-next.git (refs/heads/main): On Tue, 24 Nov 2020 14:28:10 +0200 you wrote: > When protocol is vlan then eth_type is set to the vlan eth type. > So when parsing vlan_id and vlan_prio need to check tc_proto > is vlan and not eth_type. > > Fixes: 4c

Re: [PATCH iproute2-next 1/1] tc flower: fix parsing vlan_id and vlan_prio

2020-11-24 Thread David Ahern
On 11/24/20 5:28 AM, Roi Dayan wrote: > When protocol is vlan then eth_type is set to the vlan eth type. > So when parsing vlan_id and vlan_prio need to check tc_proto > is vlan and not eth_type. > > Fixes: 4c551369e083 ("tc flower: use right ethertype in icmp/arp parsing") > Signed-off-by: Roi Da

Re: general protection fault in ieee80211_subif_start_xmit

2020-11-24 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:80145ac2 Merge tag 's390-5.10-5' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12a8ad4350 kernel config: https://syzkaller.appspot.com/x/.config?x=b81aff7

Re: [PATCH iproute2-next 0/7] Convert a number of use-cases to parse_on_off(), print_on_off()

2020-11-24 Thread David Ahern
On 11/14/20 3:53 PM, Petr Machata wrote: > Two helpers, parse_on_off() and print_on_off(), have been recently added to > lib/utils.c. Convert a number of instances of the same effective behavior > to calls to these helpers. > applied to iproute2-next. Thanks, Petr.

Re: [PATCH 127/141] staging: qlge: Fix fall-through warnings for Clang

2020-11-24 Thread Benjamin Poirier
On 2020-11-20 12:39 -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by:

Re: [PATCH net-next 2/2] net: nfc: s3fwrn5: Support a UART interface

2020-11-24 Thread Bongsu Jeon
On 11/25/20, Bongsu Jeon wrote: > On 11/24/20, k...@kernel.org wrote: >> On Tue, Nov 24, 2020 at 09:05:52PM +0900, Bongsu Jeon wrote: >>> On Mon, Nov 23, 2020 at 5:55 PM k...@kernel.org wrote: >>> > > +static enum s3fwrn5_mode s3fwrn82_uart_get_mode(void *phy_id) >>> > > +{ >>> > > + struct

Re: [PATCH net v2] Documentation: netdev-FAQ: suggest how to post co-dependent series

2020-11-24 Thread David Ahern
On 11/24/20 9:15 PM, Jakub Kicinski wrote: > Make an explicit suggestion how to post user space side of kernel > patches to avoid reposts when patchwork groups the wrong patches. > > v2: mention the cases unlike iproute2 explicitly > > Signed-off-by: Jakub Kicinski > Reviewed-by: Florian Fainell

Re: [net-next v3 0/8] seg6: add support for SRv6 End.DT4/DT6 behavior

2020-11-24 Thread David Ahern
On 11/24/20 6:58 PM, Jakub Kicinski wrote: > But it's generally not a huge issue for applying the patch. I just like > to see the build bot result, to make sure we're not adding W=1 C=1 > warnings. ah, the build bot part is new. got it.

[PATCH 08/10 net-next] net/tipc: fix socket.c kernel-doc

2020-11-24 Thread Randy Dunlap
Fix socket.c kernel-doc warnings in preparation for adding to the networking docbook. Also, for rcvbuf_limit(), use bullet notation so that the lines do not run together. ../net/tipc/socket.c:130: warning: Function parameter or member 'cong_links' not described in 'tipc_sock' ../net/tipc/socket.

[PATCH 02/10 net-next] net/tipc: fix various kernel-doc warnings

2020-11-24 Thread Randy Dunlap
f-by: Randy Dunlap Cc: Jon Maloy Cc: Ying Xue Cc: netdev@vger.kernel.org Cc: tipc-discuss...@lists.sourceforge.net Cc: "David S. Miller" Cc: Jakub Kicinski --- net/tipc/crypto.c | 17 ++++- net/tipc/discover.c |1 + net/tipc/msg.c| 10 +++--- net/t

[PATCH 05/10 net-next] net/tipc: fix name_distr.c kernel-doc

2020-11-24 Thread Randy Dunlap
Fix name_distr.c kernel-doc warnings in preparation for adding to the networking docbook. ../net/tipc/name_distr.c:55: warning: Function parameter or member 'i' not described in 'publ_to_item' ../net/tipc/name_distr.c:55: warning: Function parameter or member 'p' not described in 'publ_to_item'

[PATCH 06/10 net-next] net/tipc: fix name_table.c kernel-doc

2020-11-24 Thread Randy Dunlap
Fix name_table.c kernel-doc warnings in preparation for adding to the networking docbook. ../net/tipc/name_table.c:115: warning: Function parameter or member 'start' not described in 'service_range_foreach_match' ../net/tipc/name_table.c:115: warning: Function parameter or member 'end' not descr

[PATCH 09/10 net-next] net/tipc: fix all function Return: notation

2020-11-24 Thread Randy Dunlap
Fix Return: kernel-doc notation in all net/tipc/ source files. Also keep ReST list notation intact for output formatting. Fix a few typos in comments. Signed-off-by: Randy Dunlap Cc: Jon Maloy Cc: Ying Xue Cc: netdev@vger.kernel.org Cc: tipc-discuss...@lists.sourceforge.net Cc: "David S. Miller

[PATCH 07/10 net-next] net/tipc: fix node.c kernel-doc

2020-11-24 Thread Randy Dunlap
Fix node.c kernel-doc warnings in preparation for adding to the networking docbook. ../net/tipc/node.c:141: warning: Function parameter or member 'kref' not described in 'tipc_node' ../net/tipc/node.c:141: warning: Function parameter or member 'bc_entry' not described in 'tipc_node' ../net/tipc/

[PATCH 04/10 net-next] net/tipc: fix link.c kernel-doc

2020-11-24 Thread Randy Dunlap
Fix link.c kernel-doc warnings in preparation for adding to the networking docbook. ../net/tipc/link.c:200: warning: Function parameter or member 'session' not described in 'tipc_link' ../net/tipc/link.c:200: warning: Function parameter or member 'snd_nxt_state' not described in 'tipc_link' ../n

[PATCH 01/10 net-next] net/tipc: fix tipc header files for kernel-doc

2020-11-24 Thread Randy Dunlap
Fix tipc header files for adding to the networking docbook. Remove some uses of "/**" that were not kernel-doc notation. Fix some source formatting to eliminate Sphinx warnings. Add missing struct member and function argument kernel-doc descriptions. Documentation/networking/tipc:18: ../net/tip

[PATCH 10/10 net-next] net/tipc: add TIPC chapter to networking Documentation

2020-11-24 Thread Randy Dunlap
networking/tipc.rst | 101 +++ 2 files changed, 102 insertions(+) --- linux-next-20201124.orig/Documentation/networking/index.rst +++ linux-next-20201124/Documentation/networking/index.rst @@ -101,6 +101,7 @@ Contents: tcp-thin team timestamping + tipc tproxy

[PATCH 03/10 net-next] net/tipc: fix bearer.c for kernel-doc

2020-11-24 Thread Randy Dunlap
27; ../net/tipc/bearer.c:462: warning: Function parameter or member 'net' not described in 'tipc_l2_send_msg' ../net/tipc/bearer.c:479: warning: Function parameter or member 'net' not described in 'tipc_l2_send_msg' Signed-off-by: Randy Dunlap Cc: Jon Maloy

[PATCH 00/10 net-next] net/tipc: fix all kernel-doc and add TIPC networking chapter

2020-11-24 Thread Randy Dunlap
Fix lots of net/tipc/ kernel-doc warnings. Add many struct field and function parameter descriptions. Then add a TIPC chapter to the networking documentation book. Note: some of the struct members and function parameters are marked with "FIXME". They could use some additional descriptions if som

[PATCH net v2] Documentation: netdev-FAQ: suggest how to post co-dependent series

2020-11-24 Thread Jakub Kicinski
Make an explicit suggestion how to post user space side of kernel patches to avoid reposts when patchwork groups the wrong patches. v2: mention the cases unlike iproute2 explicitly Signed-off-by: Jakub Kicinski Reviewed-by: Florian Fainelli --- Documentation/networking/netdev-FAQ.rst | 26

[PATCH v4 net-next 0/3] net/sched: fix over mtu packet of defrag in

2020-11-24 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in act_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove

Re: [PATCH net-next 2/2] net: nfc: s3fwrn5: Support a UART interface

2020-11-24 Thread Bongsu Jeon
On 11/24/20, k...@kernel.org wrote: > On Tue, Nov 24, 2020 at 09:05:52PM +0900, Bongsu Jeon wrote: >> On Mon, Nov 23, 2020 at 5:55 PM k...@kernel.org wrote: >> > > +static enum s3fwrn5_mode s3fwrn82_uart_get_mode(void *phy_id) >> > > +{ >> > > + struct s3fwrn82_uart_phy *phy = phy_id; >> > >

[PATCH v4 net-next 2/3] net/sched: act_mirred: refactor the handle of xmit

2020-11-24 Thread wenxu
From: wenxu This one is prepare for the next patch. Signed-off-by: wenxu --- v4: no change include/net/sch_generic.h | 5 - net/sched/act_mirred.c| 21 +++-- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch_

[PATCH v4 net-next 1/3] net/sched: fix miss init the mru in qdisc_skb_cb

2020-11-24 Thread wenxu
From: wenxu The mru in the qdisc_skb_cb should be init as 0. Only defrag packets in the act_ct will set the value. Fixes: 038ebb1a713d ("net/sched: act_ct: fix miss set mru for ovs after defrag in act_ct") Signed-off-by: wenxu --- v4: no change net/core/dev.c | 2 ++ 1 file changed, 2 insert

[PATCH v4 net-next 3/3] net/sched: sch_frag: add generic packet fragment support.

2020-11-24 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in cat_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove

RE: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-11-24 Thread Rakesh Pillai
> -Original Message- > From: Doug Anderson > Sent: Tuesday, November 24, 2020 9:56 PM > To: Rakesh Pillai > Cc: Abhishek Kumar ; Kalle Valo > ; LKML ; ath10k > ; Brian Norris ; > linux-wireless ; David S. Miller > ; Jakub Kicinski ; netdev > > Subject: Re: [PATCH v2 1/1] ath10k: add o

Re: [net-next 2/3] tipc: make node number calculation reproducible

2020-11-24 Thread kernel test robot
Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/jmaloy-redhat-com/tipc-some-minor-improvements/20201125-013225 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d5a05e69a

Re: [PATCH] entry: Fix boot for !CONFIG_GENERIC_ENTRY

2020-11-24 Thread Naresh Kamboju
On Wed, 25 Nov 2020 at 03:15, Kees Cook wrote: > > On Mon, Nov 23, 2020 at 10:54:58AM -0500, Gabriel Krisman Bertazi wrote: > > Gabriel Krisman Bertazi writes: > > > > > Jann Horn writes: > > >> As part of fixing this, it might be a good idea to put "enum > > >> syscall_work_bit" behind a "#ifde

Re: [PATCH net] netdevice.h: Fix unintentional disable of ALL_FOR_ALL features on upper device

2020-11-24 Thread Herbert Xu
On Tue, Nov 24, 2020 at 11:48:35AM +0100, Eric Dumazet wrote: > > Well, the 'increment' part was suggesting the function was adding > flags, not removing them. The idea of the increment part is that we're adding a constituent device, not that we're adding features. There have always been features

Re: [EXT] Re: [PATCH v5 9/9] task_isolation: kick_all_cpus_sync: don't kick isolated cpus

2020-11-24 Thread Alex Belits
On Tue, 2020-11-24 at 00:21 +0100, Frederic Weisbecker wrote: > On Mon, Nov 23, 2020 at 10:39:34PM +, Alex Belits wrote: > > > > This is different from timers. The original design was based on the > > idea that every CPU should be able to enter kernel at any time and > > run > > kernel code w

Re: [PATCH net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Support a UART interface

2020-11-24 Thread Bongsu Jeon
On 11/24/20, k...@kernel.org wrote: > On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote: >> On Mon, Nov 23, 2020 at 5:02 PM k...@kernel.org wrote: >> > >> > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote: > > > examples: >> > >- | >> > > #include >> > > @@ -71,3

[PATCH bpf-next v8 13/34] bpf: memcg-based memory accounting for lpm_trie maps

2020-11-24 Thread Roman Gushchin
Include lpm trie and lpm trie node objects into the memcg-based memory accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/lpm_trie.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c index 00e32f2ec3e6..a7d1e5cb80da 100

[PATCH bpf-next v8 11/34] bpf: refine memcg-based memory accounting for devmap maps

2020-11-24 Thread Roman Gushchin
Include map metadata and the node size (struct bpf_dtab_netdev) into the accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/devmap.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c index 2b5ca93c17de..a4dfe544946f 100644

[PATCH bpf-next v8 01/34] mm: memcontrol: use helpers to read page's memcg data

2020-11-24 Thread Roman Gushchin
Patch series "mm: allow mapping accounted kernel pages to userspace", v6. Currently a non-slab kernel page which has been charged to a memory cgroup can't be mapped to userspace. The underlying reason is simple: PageKmemcg flag is defined as a page type (like buddy, offline, etc), so it takes a b

[PATCH bpf-next v8 30/34] bpf: eliminate rlimit-based memory accounting for xskmap maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for xskmap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- net/xdp/xskmap.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/net/xdp/xskmap.c b/net/

[PATCH bpf-next v8 03/34] mm: introduce page memcg flags

2020-11-24 Thread Roman Gushchin
The lowest bit in page->memcg_data is used to distinguish between struct memory_cgroup pointer and a pointer to a objcgs array. All checks and modifications of this bit are open-coded. Let's formalize it using page memcg flags, defined in enum page_memcg_data_flags. Additional flags might be add

[PATCH bpf-next v8 00/34] bpf: switch to memcg-based memory accounting

2020-11-24 Thread Roman Gushchin
Currently bpf is using the memlock rlimit for the memory accounting. This approach has its downsides and over time has created a significant amount of problems: 1) The limit is per-user, but because most bpf operations are performed as root, the limit has a little value. 2) It's hard to come u

[PATCH bpf-next v8 26/34] bpf: eliminate rlimit-based memory accounting for reuseport_array maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for reuseport_array maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/reuseport_array.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/ke

[PATCH bpf-next v8 19/34] bpf: eliminate rlimit-based memory accounting for bpf_struct_ops maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for bpf_struct_ops maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/bpf_struct_ops.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git

[PATCH bpf-next v8 20/34] bpf: eliminate rlimit-based memory accounting for cpumap maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for cpumap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/cpumap.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/kernel/bpf/cpumap

[PATCH bpf-next v8 23/34] bpf: eliminate rlimit-based memory accounting for hashtab maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for hashtab maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/hashtab.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/kernel/bpf/h

[PATCH bpf-next v8 07/34] bpf: memcg-based memory accounting for bpf maps

2020-11-24 Thread Roman Gushchin
This patch enables memcg-based memory accounting for memory allocated by __bpf_map_area_alloc(), which is used by many types of bpf maps for large memory allocations. Following patches in the series will refine the accounting for some of the map types. Signed-off-by: Roman Gushchin Acked-by: Son

[PATCH bpf-next v8 08/34] bpf: refine memcg-based memory accounting for arraymap maps

2020-11-24 Thread Roman Gushchin
Include percpu arrays and auxiliary data into the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/arraymap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c index c6c81eceb68f.

[PATCH bpf-next v8 28/34] bpf: eliminate rlimit-based memory accounting for sockmap and sockhash maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for sockmap and sockhash maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- net/core/sock_map.c | 33 ++--- 1 file changed, 6 insertions(+), 27 deletions(-)

[PATCH bpf-next v8 31/34] bpf: eliminate rlimit-based memory accounting for bpf local storage maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for bpf local storage maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/bpf_local_storage.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/kernel/bpf/bpf_l

[PATCH bpf-next v8 24/34] bpf: eliminate rlimit-based memory accounting for lpm_trie maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for lpm_trie maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/lpm_trie.c | 13 - 1 file changed, 13 deletions(-) diff --git a/kernel/bpf/lpm_trie.c b/kernel/b

[PATCH bpf-next v8 32/34] bpf: eliminate rlimit-based memory accounting infra for bpf maps

2020-11-24 Thread Roman Gushchin
Remove rlimit-based accounting infrastructure code, which is not used anymore. To provide a backward compatibility, use an approximation of the bpf map memory footprint as a "memlock" value, available to a user via map info. The approximation is based on the maximal number of elements and key and

[PATCH bpf-next v8 22/34] bpf: eliminate rlimit-based memory accounting for devmap maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for devmap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/devmap.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/kernel/bpf/dev

[PATCH bpf-next v8 12/34] bpf: refine memcg-based memory accounting for hashtab maps

2020-11-24 Thread Roman Gushchin
Include percpu objects and the size of map metadata into the accounting. Signed-off-by: Roman Gushchin --- kernel/bpf/hashtab.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.c index ec46266aaf1c..2b8bbdbec872 100644

[PATCH bpf-next v8 17/34] bpf: refine memcg-based memory accounting for xskmap maps

2020-11-24 Thread Roman Gushchin
Extend xskmap memory accounting to include the memory taken by the xsk_map_node structure. Signed-off-by: Roman Gushchin --- net/xdp/xskmap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/xdp/xskmap.c b/net/xdp/xskmap.c index 49da2b8ace8b..eceea51182d9 100644 --- a/n

[PATCH bpf-next v8 06/34] bpf: prepare for memcg-based memory accounting for bpf maps

2020-11-24 Thread Roman Gushchin
In the absolute majority of cases if a process is making a kernel allocation, it's memory cgroup is getting charged. Bpf maps can be updated from an interrupt context and in such case there is no process which can be charged. It makes the memory accounting of bpf maps non-trivial. Fortunately, af

[PATCH bpf-next v8 05/34] bpf: memcg-based memory accounting for bpf progs

2020-11-24 Thread Roman Gushchin
Include memory used by bpf programs into the memcg-based accounting. This includes the memory used by programs itself, auxiliary data, statistics and bpf line info. A memory cgroup containing the process which loads the program is getting charged. Signed-off-by: Roman Gushchin Acked-by: Song Liu

[PATCH bpf-next v8 09/34] bpf: refine memcg-based memory accounting for cpumap maps

2020-11-24 Thread Roman Gushchin
Include metadata and percpu data into the memcg-based memory accounting. Switch allocations made from an update path to new bpf_map_* allocation helpers to make the accounting work properly from an interrupt context. Signed-off-by: Roman Gushchin --- kernel/bpf/cpumap.c | 23 +---

[PATCH bpf-next v8 10/34] bpf: memcg-based memory accounting for cgroup storage maps

2020-11-24 Thread Roman Gushchin
Account memory used by cgroup storage maps including metadata structures. Account the percpu memory for the percpu flavor of cgroup storage. Signed-off-by: Roman Gushchin --- kernel/bpf/local_storage.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/

[PATCH bpf-next v8 27/34] bpf: eliminate rlimit-based memory accounting for bpf ringbuffer

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for bpf ringbuffer. It has been replaced with the memcg-based memory accounting. bpf_ringbuf_alloc() can't return anything except ERR_PTR(-ENOMEM) and a valid pointer, so to simplify the code make it return NULL in the first case. This allows to drop a cou

[PATCH bpf-next v8 02/34] mm: memcontrol/slab: use helpers to access slab page's memcg_data

2020-11-24 Thread Roman Gushchin
To gather all direct accesses to struct page's memcg_data field in one place, let's introduce 3 new helpers to use in the slab accounting code: struct obj_cgroup **page_objcgs(struct page *page); struct obj_cgroup **page_objcgs_check(struct page *page); bool set_page_objcgs(struct page *page

[PATCH bpf-next v8 18/34] bpf: eliminate rlimit-based memory accounting for arraymap maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for arraymap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/arraymap.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/kern

[PATCH bpf-next v8 14/34] bpf: memcg-based memory accounting for bpf ringbuffer

2020-11-24 Thread Roman Gushchin
Enable the memcg-based memory accounting for the memory used by the bpf ringbuffer. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/ringbuf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/kernel/bpf/ringbuf.c b/kernel/bpf/ringbuf.c index 31cb04a4dd

[PATCH bpf-next v8 33/34] bpf: eliminate rlimit-based memory accounting for bpf progs

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for bpf progs. It has been replaced with memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- include/linux/bpf.h | 11 --- kernel/bpf/core.c| 12 ++-- kernel/bpf/syscall.c | 69 +++

[PATCH bpf-next v8 25/34] bpf: eliminate rlimit-based memory accounting for queue_stack_maps maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for queue_stack maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/queue_stack_maps.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/k

[PATCH bpf-next v8 34/34] bpf: samples: do not touch RLIMIT_MEMLOCK

2020-11-24 Thread Roman Gushchin
Since bpf is not using rlimit memlock for the memory accounting and control, do not change the limit in sample applications. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- samples/bpf/map_perf_test_user.c| 6 -- samples/bpf/offwaketime_user.c | 6 -- samples/bpf/sockex2_u

[PATCH bpf-next v8 29/34] bpf: eliminate rlimit-based memory accounting for stackmap maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for stackmap maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/stackmap.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/kernel/bpf/s

[PATCH bpf-next v8 15/34] bpf: memcg-based memory accounting for bpf local storage maps

2020-11-24 Thread Roman Gushchin
Account memory used by bpf local storage maps: per-socket, per-inode and per-task storages. Signed-off-by: Roman Gushchin --- kernel/bpf/bpf_local_storage.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/bpf/bpf_local_storage.c b/kernel/bpf/bpf_local_stor

[PATCH bpf-next v8 21/34] bpf: eliminate rlimit-based memory accounting for cgroup storage maps

2020-11-24 Thread Roman Gushchin
Do not use rlimit-based memory accounting for cgroup storage maps. It has been replaced with the memcg-based memory accounting. Signed-off-by: Roman Gushchin Acked-by: Song Liu --- kernel/bpf/local_storage.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git

[PATCH bpf-next v8 16/34] bpf: refine memcg-based memory accounting for sockmap and sockhash maps

2020-11-24 Thread Roman Gushchin
Include internal metadata into the memcg-based memory accounting. Also include the memory allocated on updating an element. Signed-off-by: Roman Gushchin --- net/core/sock_map.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/core/sock_map.c b/net/core/sock_map.c

[PATCH bpf-next v8 04/34] mm: convert page kmemcg type to a page memcg flag

2020-11-24 Thread Roman Gushchin
PageKmemcg flag is currently defined as a page type (like buddy, offline, table and guard). Semantically it means that the page was accounted as a kernel memory by the page allocator and has to be uncharged on the release. As a side effect of defining the flag as a page type, the accounted page c

[PATCH v3 net] ptp: clockmatrix: bug fix for idtcm_strverscmp

2020-11-24 Thread min.li.xe
From: Min Li Feed kstrtou8 with NULL terminated string. Changes since v1: -Use sscanf to get rid of adhoc string parse. Changes since v2: -Check if sscanf returns 3. Signed-off-by: Min Li --- drivers/ptp/ptp_clockmatrix.c | 49 ++- 1 file changed, 16 in

RE: [PATCH v3 net] enetc: Let the hardware auto-advance the taprio base-time of 0

2020-11-24 Thread Po Liu
It makes sense to me for this patch. Thanks! > -Original Message- > From: Vladimir Oltean > Sent: 2020年11月25日 6:03 > To: Jakub Kicinski ; netdev@vger.kernel.org; Po Liu > ; Claudiu Manoil > Cc: Vinicius Costa Gomes > Subject: [PATCH v3 net] enetc: Let the hardware auto-advance the tapri

Re: WARNING in __rate_control_send_low

2020-11-24 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:80145ac2 Merge tag 's390-5.10-5' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=130e5a7950 kernel config: https://syzkaller.appspot.com/x/.config?x=b81aff7

memory leak in qrtr_tun_open

2020-11-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4d02da97 Merge tag 'net-5.10-rc5' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16f4331e50 kernel config: https://syzkaller.appspot.com/x/.config?x=c5353ac514ca5a43 das

Re: [PATCH] net/ethernet/freescale: Fix incorrect IS_ERR_VALUE macro usages

2020-11-24 Thread liwei (GF)
Hi Yang, On 2020/11/25 6:13, Li Yang wrote: > On Tue, Nov 24, 2020 at 3:44 PM Li Yang wrote: >> >> On Tue, Nov 24, 2020 at 12:24 AM Wei Li wrote: >>> >>> IS_ERR_VALUE macro should be used only with unsigned long type. >>> Especially it works incorrectly with unsigned shorter types on >>> 64bit m

Re: [net-next v3 0/8] seg6: add support for SRv6 End.DT4/DT6 behavior

2020-11-24 Thread Jakub Kicinski
On Tue, 24 Nov 2020 18:24:37 -0700 David Ahern wrote: > On 11/24/20 4:49 PM, Jakub Kicinski wrote: > > > > LGTM! Please address the nit and repost without the iproute2 patch. > > Mixing the iproute2 patch in has confused patchwork: > > > > https://patchwork.kernel.org/project/netdevbpf/list/?seri

Re: [PATCH net] Documentation: netdev-FAQ: suggest how to post co-dependent series

2020-11-24 Thread Alexei Starovoitov
On Tue, Nov 24, 2020 at 4:08 PM Jakub Kicinski wrote: > > Make an explicit suggestion how to post user space side of kernel > patches to avoid reposts when patchwork groups the wrong patches. > > Signed-off-by: Jakub Kicinski > --- > Documentation/networking/netdev-FAQ.rst | 20 +

Re: [net-next v3 0/8] seg6: add support for SRv6 End.DT4/DT6 behavior

2020-11-24 Thread David Ahern
On 11/24/20 4:49 PM, Jakub Kicinski wrote: > > LGTM! Please address the nit and repost without the iproute2 patch. > Mixing the iproute2 patch in has confused patchwork: > > https://patchwork.kernel.org/project/netdevbpf/list/?series=389667&state=* > > Note how it thinks that the iproute2 patch

Re: [net-next PATCH v5 3/4] net: dsa: mv88e6xxx: Add serdes interrupt support for MV88E6097

2020-11-24 Thread Andrew Lunn
On Tue, Nov 24, 2020 at 05:34:39PM +1300, Chris Packham wrote: > The MV88E6097 presents the serdes interrupts for ports 8 and 9 via the > Switch Global 2 registers. There is no additional layer of > enablinh/disabling the serdes interrupts like other mv88e6xxx switches. enabling > Even though mos

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-24 Thread Miguel Ojeda
On Wed, Nov 25, 2020 at 12:53 AM Finn Thain wrote: > > I'm saying that supporting the official language spec makes more sense > than attempting to support a multitude of divergent interpretations of the > spec (i.e. gcc, clang, coverity etc.) Making the kernel strictly conforming is a ship that s

Re: [PATCH net] Documentation: netdev-FAQ: suggest how to post co-dependent series

2020-11-24 Thread Florian Fainelli
On 11/24/2020 3:57 PM, Jakub Kicinski wrote: > Make an explicit suggestion how to post user space side of kernel > patches to avoid reposts when patchwork groups the wrong patches. > > Signed-off-by: Jakub Kicinski Reviewed-by: Florian Fainelli The examples are good, that makes it pretty cl

INFO: task hung in addrconf_verify_work (4)

2020-11-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4d02da97 Merge tag 'net-5.10-rc5' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1725369650 kernel config: https://syzkaller.appspot.com/x/.config?x=330f3436df12fd44 das

Re: [PATCH 0/1] pull request for net: batman-adv 2020-11-24

2020-11-24 Thread Jakub Kicinski
On Tue, 24 Nov 2020 14:44:16 +0100 Simon Wunderlich wrote: > Hi David, hi Jakub, > > here is a bugfix for batman-adv which we would like to have integrated into > net. Pulled, thanks!

  1   2   3   4   >