Re: [net,v2] net/packet: fix packet receive on L3 devices without visible hard header

2020-11-20 Thread Jason A. Donenfeld
On 11/21/20, Eyal Birger wrote: > In the patchset merged by commit b9fcf0a0d826 > ("Merge branch 'support-AF_PACKET-for-layer-3-devices'") L3 devices which > did not have header_ops were given one for the purpose of protocol parsing > on af_packet transmit path. > > That change made af_packet rece

Re: [PATCH bpf-next V7 8/8] bpf/selftests: activating bpf_check_mtu BPF-helper

2020-11-20 Thread Andrii Nakryiko
On Fri, Nov 20, 2020 at 8:21 AM Jesper Dangaard Brouer wrote: > > Adding selftest for BPF-helper bpf_check_mtu(). Making sure > it can be used from both XDP and TC. > > Signed-off-by: Jesper Dangaard Brouer > --- > tools/testing/selftests/bpf/prog_tests/check_mtu.c | 37 >

Re: [RFC PATCH] bpf: preload: Fix build error when O= is set

2020-11-20 Thread Andrii Nakryiko
On Thu, Nov 19, 2020 at 12:51 AM David Gow wrote: > > If BPF_PRELOAD is enabled, and an out-of-tree build is requested with > make O=, compilation seems to fail with: > > tools/scripts/Makefile.include:4: *** O=.kunit does not exist. Stop. > make[4]: *** [../kernel/bpf/preload/Makefile:8: kernel/

[PATCH net,v2] net/packet: fix packet receive on L3 devices without visible hard header

2020-11-20 Thread Eyal Birger
In the patchset merged by commit b9fcf0a0d826 ("Merge branch 'support-AF_PACKET-for-layer-3-devices'") L3 devices which did not have header_ops were given one for the purpose of protocol parsing on af_packet transmit path. That change made af_packet receive path regard these devices as having a vi

[net,v2] net/packet: fix packet receive on L3 devices without visible hard header

2020-11-20 Thread Eyal Birger
In the patchset merged by commit b9fcf0a0d826 ("Merge branch 'support-AF_PACKET-for-layer-3-devices'") L3 devices which did not have header_ops were given one for the purpose of protocol parsing on af_packet transmit path. That change made af_packet receive path regard these devices as having a vi

Re: [k...@kernel.org: Re: [PATCH net-next v2 0/3] net: introduce rps_default_mask]

2020-11-20 Thread Marcel Apfelbaum
Hi Daniel, On Fri, Nov 20, 2020 at 11:56 PM Daniel Borkmann wrote: > > On 11/20/20 6:39 PM, Marcel Apfelbaum wrote: > > +netdev > > [Sorry for the second email, I failed to set the text-only mode] > > On Fri, Nov 20, 2020 at 7:30 PM Marcel Apfelbaum > > wrote: > [...] > >>> -- Forwarded

INFO: task hung in sync_inodes_sb (4)

2020-11-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:03430750 Add linux-next specific files for 20201116 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=17027fdc50 kernel config: https://syzkaller.appspot.com/x/.config?x=a1c4c3f27041fdb8 dashboard

[PATCHv4 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-20 Thread George Cherian
Add health reporters for RVU NIX block. NIX Health reporter handle following HW event groups - GENERAL events - RAS events - RVU event An event counter per event is maintained in SW. Output: # ./devlink health pci/0002:01:00.0: reporter npa state healthy error 0 recover 0 reporter

[PATCHv4 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-20 Thread George Cherian
Add health reporters for RVU NPA block. NPA Health reporters handle following HW event groups - GENERAL events - ERROR events - RAS events - RVU event An event counter per event is maintained in SW. Output: # devlink health pci/0002:01:00.0: reporter npa state healthy error 0 recover

[PATCHv4 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-20 Thread George Cherian
Add devlink support to AF driver. Basic devlink support is added. Currently info_get is the only supported devlink ops. devlink ouptput looks like this # devlink dev pci/0002:01:00.0 # devlink dev info pci/0002:01:00.0: driver octeontx2-af versions: fixed: mbox version: 9 Si

[PATCHv3 net-next 0/3] Add devlink and devlink health reporters to

2020-11-20 Thread George Cherian
Add basic devlink and devlink health reporters. Devlink health reporters are added for NPA and NIX blocks. These reporters report the error count in respective blocks. Address Jakub's comment to add devlink support for error reporting. https://www.spinics.net/lists/netdev/msg670712.html Change-lo

Re: [PATCH net-next v2 0/9] ibmvnic: Performance improvements and other updates

2020-11-20 Thread Jakub Kicinski
On Wed, 18 Nov 2020 19:12:16 -0600 Thomas Falcon wrote: > The first three patches utilize a hypervisor call allowing multiple > TX and RX buffer replenishment descriptors to be sent in one operation, > which significantly reduces hypervisor call overhead. The xmit_more > and Byte Queue Limit API's

Re: [PATCH net-next 4/6] net: ipa: support retries on generic GSI commands

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 21:31:09 -0600 Alex Elder wrote: > On 11/20/20 8:49 PM, Jakub Kicinski wrote: > > On Thu, 19 Nov 2020 16:49:27 -0600 Alex Elder wrote: > >> + do > >> + ret = gsi_generic_command(gsi, channel_id, > >> +GSI_GENERIC_HALT_CHANNEL); > >

[net PATCH] tcp: Set ECT0 bit in tos/tclass for synack when BPF needs ECN

2020-11-20 Thread Alexander Duyck
From: Alexander Duyck When a BPF program is used to select between a type of TCP congestion control algorithm that uses either ECN or not there is a case where the synack for the frame was coming up without the ECT0 bit set. A bit of research found that this was due to the final socket being conf

Re: [PATCH v12 5/5] selftest: mhi: Add support to test MHI LOOPBACK channel

2020-11-20 Thread Hemant Kumar
Hi Shuah, On 11/20/20 7:26 AM, Shuah Khan wrote: On 11/16/20 3:46 PM, Hemant Kumar wrote: Loopback test opens the MHI device file node and writes a data buffer to it. MHI UCI kernel space driver copies the data and sends it to MHI uplink (Tx) LOOPBACK channel. MHI device loops back the same dat

[Patch stable] netfilter: clear skb->next in NF_HOOK_LIST()

2020-11-20 Thread Cong Wang
From: Cong Wang NF_HOOK_LIST() uses list_del() to remove skb from the linked list, however, it is not sufficient as skb->next still points to other skb. We should just call skb_list_del_init() to clear skb->next, like the rest places which using skb list. This has been fixed in upstream by commi

Re: [PATCH net-next 4/6] net: ipa: support retries on generic GSI commands

2020-11-20 Thread Alex Elder
On 11/20/20 8:49 PM, Jakub Kicinski wrote: > On Thu, 19 Nov 2020 16:49:27 -0600 Alex Elder wrote: >> +do >> +ret = gsi_generic_command(gsi, channel_id, >> + GSI_GENERIC_HALT_CHANNEL); >> +while (ret == -EAGAIN && retries--); > > This may wel

Re: [PATCH v12 5/5] selftest: mhi: Add support to test MHI LOOPBACK channel

2020-11-20 Thread Hemant Kumar
Hi Mani, On 11/19/20 10:10 PM, Manivannan Sadhasivam wrote: On Mon, Nov 16, 2020 at 02:46:22PM -0800, Hemant Kumar wrote: Loopback test opens the MHI device file node and writes a data buffer to it. MHI UCI kernel space driver copies the data and sends it to MHI uplink (Tx) LOOPBACK channel. M

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-20 Thread Jakub Kicinski
On Thu, 19 Nov 2020 22:34:46 +0200 Grygorii Strashko wrote: > The mdio_bus may have dependencies from GPIO controller and so got > deferred. Now it will print error message every time -EPROBE_DEFER is > returned which from: > __mdiobus_register() > |-devm_gpiod_get_optional() > without actually id

[PATCH net-next v2 0/2] Add an assert in napi_consume_skb()

2020-11-20 Thread Yunsheng Lin
This patch introduces a lockdep_assert_in_softirq() interface and uses it to assert the case when napi_consume_skb() is not called in the softirq context. Changelog: V2: Use lockdep instead of one-off Kconfig knob Yunsheng Lin (2): lockdep: Introduce in_softirq lockdep assert net: Use lockdep

[PATCH net-next v2 1/2] lockdep: Introduce in_softirq lockdep assert

2020-11-20 Thread Yunsheng Lin
The current semantic for napi_consume_skb() is that caller need to provide non-zero budget when calling from NAPI context, and breaking this semantic will cause hard to debug problem, because _kfree_skb_defer() need to run in atomic context in order to push the skb to the particular cpu' napi_alloc

[PATCH net-next v2 2/2] net: Use lockdep_assert_in_softirq() in napi_consume_skb()

2020-11-20 Thread Yunsheng Lin
Use napi_consume_skb() to assert the case when it is not called in a atomic softirq context. Signed-off-by: Yunsheng Lin --- net/core/skbuff.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index ffe3dcc..effa19d 100644 --- a/net/core/skbuff.c +++ b/n

Re: [PATCH net 0/4] s390/qeth: fixes 2020-11-20

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 10:09:35 +0100 Julian Wiedmann wrote: > please apply the following patch series to netdev's net tree. > > This brings several fixes for qeth's af_iucv-specific code paths. > > Also one fix by Alexandra for the recently added BR_LEARNING_SYNC > support. We want to trust the fea

Re: [PATCH net-next 0/3] net: ipa: platform-specific clock and interconnect rates

2020-11-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 19 Nov 2020 16:40:38 -0600 you wrote: > This series changes the way the IPA core clock rate and the > bandwidth parameters for interconnects are specified. Previously > these were specified with hard-wired constan

Re: [PATCH net-next 0/6] net: ipa: add a driver shutdown callback

2020-11-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 19 Nov 2020 16:49:23 -0600 you wrote: > The final patch in this series adds a driver shutdown callback for > the IPA driver. The patches leading up to that address some issues > encountered while ensuring that cal

Re: [PATCH bpf-next v7 32/34] bpf: eliminate rlimit-based memory accounting infra for bpf maps

2020-11-20 Thread Roman Gushchin
On Fri, Nov 20, 2020 at 06:52:27PM -0800, Alexei Starovoitov wrote: > On Thu, Nov 19, 2020 at 09:37:52AM -0800, Roman Gushchin wrote: > > static void bpf_map_put_uref(struct bpf_map *map) > > @@ -619,7 +562,7 @@ static void bpf_map_show_fdinfo(struct seq_file *m, > > struct file *filp) > >

Re: [PATCH v2 00/10] Broadcom b53 YAML bindings

2020-11-20 Thread Florian Fainelli
On 11/11/2020 8:50 PM, Florian Fainelli wrote: > Hi, > > This patch series fixes the various Broadcom SoCs DTS files and the > existing YAML binding for missing properties before adding a proper b53 > switch YAML binding from Kurt. > > If this all looks good, given that there are quite a few c

Re: [PATCH bpf-next v7 32/34] bpf: eliminate rlimit-based memory accounting infra for bpf maps

2020-11-20 Thread Alexei Starovoitov
On Thu, Nov 19, 2020 at 09:37:52AM -0800, Roman Gushchin wrote: > static void bpf_map_put_uref(struct bpf_map *map) > @@ -619,7 +562,7 @@ static void bpf_map_show_fdinfo(struct seq_file *m, > struct file *filp) > "value_size:\t%u\n" > "max_entries:\t%u\n" >

[PATCH bpf-next 5/7] selftests/bpf: add tp_btf CO-RE reloc test for modules

2020-11-20 Thread Andrii Nakryiko
Add another CO-RE relocation test for kernel module relocations. This time for tp_btf with direct memory reads. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/core_reloc.c | 3 +- .../bpf/progs/test_core_reloc_module.c| 32 ++- 2 files changed, 33 in

Re: [PATCH net-next 4/6] net: ipa: support retries on generic GSI commands

2020-11-20 Thread Jakub Kicinski
On Thu, 19 Nov 2020 16:49:27 -0600 Alex Elder wrote: > + do > + ret = gsi_generic_command(gsi, channel_id, > + GSI_GENERIC_HALT_CHANNEL); > + while (ret == -EAGAIN && retries--); This may well be the first time I've seen someone write a do

[PATCH bpf-next 2/7] bpf: allow to specify kernel module BTFs when attaching BPF programs

2020-11-20 Thread Andrii Nakryiko
Add ability for user-space programs to specify non-vmlinux BTF when attaching BTF-powered BPF programs: raw_tp, fentry/fexit/fmod_ret, LSM, etc. For this, add attach_btf_obj_id field which contains BTF object ID for either vmlinux or module. For backwards compatibility (and simplicity) reasons, 0 d

[PATCH bpf-next 7/7] selftests/bpf: add fentry/fexit/fmod_ret selftest for kernel module

2020-11-20 Thread Andrii Nakryiko
Add new selftest checking attachment of fentry/fexit/fmod_ret (and raw tracepoint ones for completeness) BPF programs to kernel module function. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/module_attach.c | 53 +++ .../selftests/bpf/progs/test_module_attach.c |

[PATCH bpf-next 3/7] libbpf: factor out low-level BPF program loading helper

2020-11-20 Thread Andrii Nakryiko
Refactor low-level API for BPF program loading to not rely on public API types. This allows painless extension without constant efforts to cleverly not break backwards compatibility. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/bpf.c | 100 ++-- tools/

[PATCH bpf-next 1/7] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier

2020-11-20 Thread Andrii Nakryiko
Remove a permeating assumption thoughout BPF verifier of vmlinux BTF. Instead, wherever BTF type IDs are involved, also track the instance of struct btf that goes along with the type ID. This allows to gradually add support for kernel module BTFs and using/tracking module types across BPF helper ca

[PATCH bpf-next 6/7] selftests/bpf: make BPF sidecar traceable function global

2020-11-20 Thread Andrii Nakryiko
Pahole currently isn't able to generate BTF for static functions in kernel modules, so make sure traced sidecar function is global. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/bpf_sidecar/bpf_sidecar.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools

[PATCH bpf-next 4/7] libbpf: support attachment of BPF tracing programs to kernel modules

2020-11-20 Thread Andrii Nakryiko
Teach libbpf to search for BTF types in kernel modules for tracing BPF programs. This allows attachment of raw_tp/fentry/fexit/fmod_ret/etc BPF program types to tracepoints and functions in kernel modules. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/bpf.c | 1 + tools/lib/bpf

[PATCH bpf-next 0/7] Add kernel modules support for tracing BPF program attachments

2020-11-20 Thread Andrii Nakryiko
Building on top of two previous patch sets ([0] and not yet landed [1]), this patch sets extends kernel and libbpf with support for attaching BTF-powered raw tracepoint (tp_btf) and tracing (fentry/fexit/fmod_ret/lsm) BPF programs to BPF hooks defined in kernel modules. Kernel UAPI for BPF_PROG_LO

Re: [PATCH bpf-next v2 1/7] samples: bpf: refactor hbm program with libbpf

2020-11-20 Thread Martin KaFai Lau
On Fri, Nov 20, 2020 at 06:34:05PM -0800, Martin KaFai Lau wrote: > On Thu, Nov 19, 2020 at 03:06:11PM +, Daniel T. Lee wrote: > [ ... ] > > > static int run_bpf_prog(char *prog, int cg_id) > > { > > - int map_fd; > > - int rc = 0; > > + struct hbm_queue_stats qstats = {0}; > > + cha

Re: [PATCH net-next] r8169: reduce number of workaround doorbell rings

2020-11-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 19 Nov 2020 21:57:27 +0100 you wrote: > Some chip versions have a hw bug resulting in lost door bell rings. > To work around this the doorbell is also rung whenever we still have > tx descriptors in flight after hav

Re: [PATCH net-next] r8169: use dev_err_probe in rtl_get_ether_clk

2020-11-20 Thread Jakub Kicinski
On Thu, 19 Nov 2020 22:00:11 +0100 Heiner Kallweit wrote: > Tiny improvement, let dev_err_probe() deal with EPROBE_DEFER. > > Signed-off-by: Heiner Kallweit Applied, thanks!

Re: [PATCH bpf-next v2 1/7] samples: bpf: refactor hbm program with libbpf

2020-11-20 Thread Martin KaFai Lau
On Thu, Nov 19, 2020 at 03:06:11PM +, Daniel T. Lee wrote: [ ... ] > static int run_bpf_prog(char *prog, int cg_id) > { > - int map_fd; > - int rc = 0; > + struct hbm_queue_stats qstats = {0}; > + char cg_dir[100], cg_pin_path[100]; > + struct bpf_link *link = NULL; >

Re: [net] net/packet: fix incoming receive for L3 devices without visible hard header

2020-11-20 Thread Willem de Bruijn
On Thu, Nov 19, 2020 at 10:05 PM Eyal Birger wrote: > > In the patchset merged by commit b9fcf0a0d826 > ("Merge branch 'support-AF_PACKET-for-layer-3-devices'") L3 devices which > did not have header_ops were given one for the purpose of protocol parsing > on af_packet transmit path. > > That chan

Re: [net PATCH 0/2] tcp: Address issues with ECT0 not being set in DCTCP packets

2020-11-20 Thread Jakub Kicinski
On Thu, 19 Nov 2020 13:23:43 -0800 Alexander Duyck wrote: > This patch set is meant to address issues seen with SYN/ACK packets not > containing the ECT0 bit when DCTCP is configured as the congestion control > algorithm for a TCP socket. > > A simple test using "tcpdump" and "test_progs -t bpf_tc

Re: [RFC V2 net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-20 Thread tanhuazhong
On 2020/11/20 23:25, Andrew Lunn wrote: @@ -310,6 +334,13 @@ int ethnl_set_coalesce(struct sk_buff *skb, struct genl_info *info) ret = dev->ethtool_ops->set_coalesce(dev, &coalesce); if (ret < 0) goto out_ops; + + if (ops->set_ext_coalesce) { +

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-20 Thread tanhuazhong
On 2020/11/21 5:22, Michal Kubecek wrote: On Fri, Nov 20, 2020 at 02:39:38PM +0100, Andrew Lunn wrote: On Fri, Nov 20, 2020 at 08:23:22AM +0100, Michal Kubecek wrote: On Fri, Nov 20, 2020 at 10:59:59AM +0800, tanhuazhong wrote: On 2020/11/20 6:02, Michal Kubecek wrote: We could use a simil

Re: [net-next v3 05/15] ice: create flow profile

2020-11-20 Thread Alexander Duyck
On Fri, Nov 20, 2020 at 4:42 PM Nguyen, Anthony L wrote: > > On Fri, 2020-11-13 at 15:56 -0800, Alexander Duyck wrote: > > On Fri, Nov 13, 2020 at 1:46 PM Tony Nguyen < > > anthony.l.ngu...@intel.com> wrote: > > > > > > From: Real Valiquette > > > > > > Implement the initial steps for creating an

Re: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-20 Thread Vladimir Oltean
On Thu, Nov 19, 2020 at 06:51:15PM +, tristram...@microchip.com wrote: > The initial proposal in tag_ksz.c is for the switch driver to provide > callback functions > to handle receiving and transmitting. Then each switch driver can be added to > process the tail tag in its own driver and leav

Re: [net-next v3 08/15] ice: don't always return an error for Get PHY Abilities AQ command

2020-11-20 Thread Nguyen, Anthony L
On Fri, 2020-11-13 at 17:25 -0800, Alexander Duyck wrote: > On Fri, Nov 13, 2020 at 1:49 PM Tony Nguyen < > anthony.l.ngu...@intel.com> wrote: > > > > From: Paul M Stillwell Jr > > > > There are times when the driver shouldn't return an error when the > > Get > > PHY abilities AQ command (0x0600

Re: [net-next v3 05/15] ice: create flow profile

2020-11-20 Thread Nguyen, Anthony L
On Fri, 2020-11-13 at 15:56 -0800, Alexander Duyck wrote: > On Fri, Nov 13, 2020 at 1:46 PM Tony Nguyen < > anthony.l.ngu...@intel.com> wrote: > > > > From: Real Valiquette > > > > Implement the initial steps for creating an ACL filter to support > > ntuple > > masks. Create a flow profile based

Re: [net-next v2 03/15] ice: initialize ACL table

2020-11-20 Thread Nguyen, Anthony L
On Fri, 2020-11-13 at 14:59 -0800, Alexander Duyck wrote: > On Fri, Nov 13, 2020 at 1:36 PM Tony Nguyen < > anthony.l.ngu...@intel.com> wrote: > > > > From: Real Valiquette > > > > ACL filtering can be utilized to expand support of ntuple rules by > > allowing > > mask values to be specified for

Re: [PATCH bpf-next v2 0/5] selftests/bpf: xsk selftests

2020-11-20 Thread Yonghong Song
On 11/20/20 5:00 AM, Weqaar Janjua wrote: This patch set adds AF_XDP selftests based on veth to selftests/bpf. # Topology: # - # --- # _ | Process | _ # / --- \ # /|\ #/ |

Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Ion Badulescu
On 11/20/20 6:56 PM, Jakub Kicinski wrote: On Fri, 20 Nov 2020 18:41:03 -0500 Ion Badulescu wrote: Frankly, no, I don't know of any users, and that unfortunately includes myself. I still have two cards in my stash, but they're 64-bit PCI-X, so plugging them in would likely require taking a dreme

Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 18:41:03 -0500 Ion Badulescu wrote: > Frankly, no, I don't know of any users, and that unfortunately includes > myself. I still have two cards in my stash, but they're 64-bit PCI-X, so > plugging them in would likely require taking a dremel to a 32-bit PCI > slot to make it o

Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Ion Badulescu
On 11/20/20 6:17 PM, Jakub Kicinski wrote: On Fri, 20 Nov 2020 15:50:00 +0800 xiakaixu1...@gmail.com wrote: From: Kaixu Xia The body of the if statement can be executed only when the variable vlan_count equals to 32, so the condition of the while statement can not be true and the while stateme

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-20 Thread Xie He
On Fri, Nov 20, 2020 at 3:11 PM Xie He wrote: > > Should we also handle the NETDEV_UP event here? In previous versions > of this patch series you seemed to want to establish the L2 connection > on device-up. But in this patch, you didn't handle NETDEV_UP. > > Maybe on device-up, we need to check i

Re: [PATCH net-next v3 12/12] net: dsa: microchip: ksz9477: add periodic output support

2020-11-20 Thread Vladimir Oltean
On Wed, Nov 18, 2020 at 09:30:13PM +0100, Christian Eggers wrote: > The KSZ9563 has a Trigger Output Unit (TOU) which can be used to > generate periodic signals. > > The pulse length can be altered via a device attribute. > > Tested on a Microchip KSZ9563 switch. > > Signed-off-by: Christian Egg

Re: [PATCH net-next 00/10] mptcp: More miscellaneous MPTCP fixes

2020-11-20 Thread Jakub Kicinski
On Thu, 19 Nov 2020 11:45:53 -0800 Mat Martineau wrote: > Here's another batch of fixup and enhancement patches that we have > collected in the MPTCP tree. > > Patch 1 removes an unnecessary flag and related code. > > Patch 2 fixes a bug encountered when closing fallback sockets. > > Patches 3 a

Re: [PATCH net-next 0/8] mlxsw: Add support for nexthop objects

2020-11-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 19 Nov 2020 15:08:40 +0200 you wrote: > From: Ido Schimmel > > This patch set adds support for nexthop objects in mlxsw. Nexthop > objects are treated as another front-end for programming nexthops, in > addition

Re: [PATCH net] dpaa2-eth: select XGMAC_MDIO for MDIO bus support

2020-11-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 19 Nov 2020 16:51:06 +0200 you wrote: > From: Ioana Ciornei > > Explicitly enable the FSL_XGMAC_MDIO Kconfig option in order to have > MDIO access to internal and external PHYs. > > Fixes: 719479230893 ("dpaa2-eth: ad

Re: [PATCH net-next v3 09/12] net: dsa: microchip: ksz9477: initial hardware time stamping support

2020-11-20 Thread Vladimir Oltean
On Wed, Nov 18, 2020 at 09:30:10PM +0100, Christian Eggers wrote: > Add control routines required for TX hardware time stamping. > > The KSZ9563 only supports one step time stamping > (HWTSTAMP_TX_ONESTEP_P2P), which requires linuxptp-2.0 or later. > > Currently, only P2P delay measurement is sup

Re: [PATCH bpf-next 6/6] selftests/bpf: add CO-RE relocs selftest relying on kernel module BTF

2020-11-20 Thread Martin KaFai Lau
On Thu, Nov 19, 2020 at 03:22:44PM -0800, Andrii Nakryiko wrote: > Add a self-tests validating libbpf is able to perform CO-RE relocations > against the type defined in kernel module BTF. Acked-by: Martin KaFai Lau

Re: [PATCH net-next 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-20 Thread Andrew Lunn
Hi George > > > +static void xrs700x_port_stp_state_set(struct dsa_switch *ds, int port, > > > +u8 state) > > > +{ > > > + struct xrs700x *priv = ds->priv; > > > + unsigned int val; > > > + > > > + switch (state) { > > > + case BR_STATE_DISABLED:

[PATCH net-next] net: warn if gso_type isn't set for a GSO SKB

2020-11-20 Thread Heiner Kallweit
In bug report [0] a warning in r8169 driver was reported that was caused by an invalid GSO SKB (gso_type was 0). See [1] for a discussion about this issue. Still the origin of the invalid GSO SKB isn't clear. It shouldn't be a network drivers task to check for invalid GSO SKB's. Also, even if issu

Re: [PATCH bpf-next 5/6] selftests/bpf: add bpf_sidecar kernel module for testing

2020-11-20 Thread Martin KaFai Lau
On Thu, Nov 19, 2020 at 03:22:43PM -0800, Andrii Nakryiko wrote: > Add bpf_sidecar module, which is conceptually out-of-tree module and provides > ways for selftests/bpf to test various kernel module-related functionality: > raw tracepoint, fentry/fexit/fmod_ret, etc. This module will be auto-loade

Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 15:50:00 +0800 xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The body of the if statement can be executed only when the variable > vlan_count equals to 32, so the condition of the while statement can > not be true and the while statement is dead code. Remove it. > > Rep

Re: [PATCH net-next v3 07/12] net: dsa: microchip: ksz9477: add Posix clock support for chip PTP clock

2020-11-20 Thread Vladimir Oltean
On Wed, Nov 18, 2020 at 09:30:08PM +0100, Christian Eggers wrote: > Implement routines (adjfine, adjtime, gettime and settime) for > manipulating the chip's PTP clock. > > Signed-off-by: Christian Eggers > --- Reviewed-by: Vladimir Oltean

Re: [PATCH bpf-next 4/6] libbpf: add kernel module BTF support for CO-RE relocations

2020-11-20 Thread Andrii Nakryiko
On Fri, Nov 20, 2020 at 3:06 PM Martin KaFai Lau wrote: > > On Thu, Nov 19, 2020 at 03:22:42PM -0800, Andrii Nakryiko wrote: > [ ... ] > > > +static int load_module_btfs(struct bpf_object *obj) > > +{ > > + struct bpf_btf_info info; > > + struct module_btf *mod_btf; > > + struct btf *b

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-20 Thread Xie He
Should we also handle the NETDEV_UP event here? In previous versions of this patch series you seemed to want to establish the L2 connection on device-up. But in this patch, you didn't handle NETDEV_UP. Maybe on device-up, we need to check if the carrier is up, and if it is, we do the same thing as

Re: [PATCH net-next] net: don't include ethtool.h from netdevice.h

2020-11-20 Thread Shannon Nelson
On 11/20/20 2:13 PM, Jakub Kicinski wrote: linux/netdevice.h is included in very many places, touching any of its dependecies causes large incremental builds. Drop the linux/ethtool.h include, linux/netdevice.h just needs a forward declaration of struct ethtool_ops. Fix all the places which mad

Re: [PATCH net-next 0/3] mvneta: access skb_shared_info only on last frag

2020-11-20 Thread Jesse Brandeburg
Lorenzo Bianconi wrote: > Build skb_shared_info on mvneta_rx_swbm stack and sync it to xdp_buff > skb_shared_info area only on the last fragment. > Avoid avoid unnecessary xdp_buff initialization in mvneta_rx_swbm routine. > This a preliminary series to complete xdp multi-buff in mvneta driver. >

Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 19 Nov 2020 12:09:06 +0100 you wrote: > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed > immediately. Shouldn't store a pointer to freed memory. > > Signed-off-by: Christian Eggers > Fixes:

Re: [PATCH bpf-next 4/6] libbpf: add kernel module BTF support for CO-RE relocations

2020-11-20 Thread Martin KaFai Lau
On Thu, Nov 19, 2020 at 03:22:42PM -0800, Andrii Nakryiko wrote: [ ... ] > +static int load_module_btfs(struct bpf_object *obj) > +{ > + struct bpf_btf_info info; > + struct module_btf *mod_btf; > + struct btf *btf; > + char name[64]; > + __u32 id, len; > + int err, fd; > +

Re: [PATCHv3 net-next 0/3] Add devlink and devlink health reporters to

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 11:57:58 +0530 George Cherian wrote: > Add basic devlink and devlink health reporters. > Devlink health reporters are added for NPA and NIX blocks. > These reporters report the error count in respective blocks. > > Address Jakub's comment to add devlink support for error report

[PATCH mlx5-next 03/16] net/mlx5: Check dr mask size against mlx5_match_param size

2020-11-20 Thread Saeed Mahameed
From: Muhammad Sammar This is to allow passing misc4 match param from userspace when function like ib_flow_matcher_create is called. Signed-off-by: Muhammad Sammar Reviewed-by: Alex Vesker Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/stee

[PATCH mlx5-next 04/16] net/mlx5: Add misc4 to mlx5_ifc_fte_match_param_bits

2020-11-20 Thread Saeed Mahameed
From: Muhammad Sammar Add misc4 match params to enable matching on prog_sample_fields. Signed-off-by: Muhammad Sammar Reviewed-by: Alex Vesker Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/fs_core.h | 2 +- include/linux/mlx5/device.h

[PATCH mlx5-next 02/16] net/mlx5: Add sampler destination type

2020-11-20 Thread Saeed Mahameed
From: Chris Mi The flow sampler object is a new destination type. Add a new member for the flow destination. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/diag/fs_tracepoint.c | 3 +++ drivers/net/ethernet/mellanox/ml

[PATCH mlx5-next 15/16] net/mlx5: Enable host PF HCA after eswitch is initialized

2020-11-20 Thread Saeed Mahameed
From: Parav Pandit Currently ECPF enables external host PF too early in the initialization sequence for Ethernet links when ECPF is eswitch manager. Due to this, when external host PF driver is loaded, host PF's HCA CAP has inner_ip_version supported by NIC RX flow table. This capability is late

[PATCH mlx5-next 13/16] net/mlx5: Make API mlx5_core_is_ecpf accept const pointer

2020-11-20 Thread Saeed Mahameed
From: Parav Pandit Subsequent patch implements helper API which has mlx5_core_dev as const pointer, make its caller API too const *. Signed-off-by: Parav Pandit Reviewed-by: Bodong Wang Signed-off-by: Saeed Mahameed --- include/linux/mlx5/driver.h | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH mlx5-next 08/16] net/mlx5: Update the hardware interface definition for vhca state

2020-11-20 Thread Saeed Mahameed
From: Parav Pandit Update the hardware interface definitions to query and modify vhca state, related EQE and event code. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- include/linux/mlx5/device.h | 7 +++ include/linux/mlx5/mlx5_ifc.h | 17 ++--- 2 files chan

[PATCH mlx5-next 14/16] net/mlx5: Rename peer_pf to host_pf

2020-11-20 Thread Saeed Mahameed
From: Parav Pandit To match the hardware spec, rename peer_pf to host_pf. Signed-off-by: Parav Pandit Reviewed-by: Bodong Wang Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/ecpf.c| 51 --- .../ethernet/mellanox/mlx5/core/pagealloc.c | 12 ++--- i

[PATCH mlx5-next 16/16] net/mlx5: Treat host PF vport as other (non eswitch manager) vport

2020-11-20 Thread Saeed Mahameed
From: Parav Pandit When eswitch manager is running on ECPF, host PF should be treated as non eswitch manager port, similar to other VF vports. Fail to do so, results in firmware treating PF's vport as ECPF vport for eswitch ACL tables. Non zero check to figure out if a given vport is other vport

[PATCH mlx5-next 10/16] net/mlx5: Expose other function ifc bits

2020-11-20 Thread Saeed Mahameed
From: Yishai Hadas Expose other function ifc bits to enable setting HCA caps on behalf of other function. In addition, expose vhca_resource_manager bit to control whether the other function functionality is supported by firmware. Signed-off-by: Yishai Hadas Reviewed-by: Parav Pandit Signed-of

[PATCH mlx5-next 11/16] net/mlx5: Add VDPA priority to NIC RX namespace

2020-11-20 Thread Saeed Mahameed
From: Eli Cohen Add a new namespace type to the NIC RX root namespace to allow for inserting VDPA rules before regular NIC but after bypass, thus allowing DPDK to have precedence in packet processing. Signed-off-by: Eli Cohen Reviewed-by: Mark Bloch Reviewed-by: Maor Gottlieb Signed-off-by: S

[PATCH mlx5-next 09/16] net/mlx5: Expose IP-in-IP TX and RX capability bits

2020-11-20 Thread Saeed Mahameed
From: Aya Levin Expose FW indication that it supports stateless offloads for IP over IP tunneled packets per direction. In some HW like ConnectX-4 IP-in-IP support is not symmetric, it supports steering on the inner header but it doesn't TX-Checksum and TSO. Add IP-in-IP capability per direction

[PATCH mlx5-next 07/16] net/mlx5: Update the list of the PCI supported devices

2020-11-20 Thread Saeed Mahameed
From: Meir Lichtinger Add the upcoming BlueField-3 device ID. Signed-off-by: Meir Lichtinger Reviewed-by: Eran Ben Elisha Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ne

[PATCH mlx5-next 12/16] net/mlx5: Export steering related functions

2020-11-20 Thread Saeed Mahameed
From: Eli Cohen Export mlx5_create_flow_table() mlx5_create_flow_group() mlx5_destroy_flow_group(). These symbols are required by the VDPA implementation to create rules that consume VDPA specific traffic. We do not deal with putting the prototypes in a header file since they already exist i

[PATCH mlx5-next 00/16] mlx5 next updates 2020-11-20

2020-11-20 Thread Saeed Mahameed
Hi, This series includes trivial updates to mlx5 next branch 1) HW definition for upcoming features 2) Include files and general Cleanups 3) Add the upcoming BlueField-3 device ID 4) Define flow steering priority for VDPA 5) Export missing steering API for ULPs, will be used later in VDPA drive

[PATCH mlx5-next 01/16] net/mlx5: Add sample offload hardware bits and structures

2020-11-20 Thread Saeed Mahameed
From: Chris Mi Hardware introduces flow sampler object for packet sampling. Add the offload hardware bits and structures. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo Signed-off-by: Saeed Mahameed --- include/linux/mlx5/mlx5_ifc.h | 29 + 1 file changed, 29 inse

[PATCH mlx5-next 05/16] net/mlx5: Add ts_cqe_to_dest_cqn related bits

2020-11-20 Thread Saeed Mahameed
From: Eran Ben Elisha Add a bit in HCA capabilities layout to indicate if ts_cqe_to_dest_cqn is supported. In addition, add ts_cqe_to_dest_cqn field to SQ context, for driver to set the actual CQN. Signed-off-by: Eran Ben Elisha Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- in

Re: [PATCH net-next v3 06/12] net: dsa: microchip: ksz9477: basic interrupt support

2020-11-20 Thread Vladimir Oltean
On Wed, Nov 18, 2020 at 09:30:07PM +0100, Christian Eggers wrote: > Interrupts are required for TX time stamping. Probably they could also > be used for PHY connection status. > > This patch only adds the basic infrastructure for interrupts, no > interrupts are finally enabled nor handled. > > Si

[PATCH mlx5-next 06/16] net/mlx5: Avoid exposing driver internal command helpers

2020-11-20 Thread Saeed Mahameed
From: Parav Pandit mlx5 command init and cleanup routines are internal to mlx5_core driver. Hence, avoid exporting them and move their definition to mlx5_core driver's internal file mlx5_core.h Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/co

Re: [PATCH net 10/15] ibmvnic: no reset timeout for 5 seconds after reset

2020-11-20 Thread drt
On 2020-11-20 14:40, Lijun Pan wrote: From: Dany Madden Reset timeout is going off right after adapter reset. This patch ensures that timeout is scheduled if it has been 5 seconds since the last reset. 5 seconds is the default watchdog timeout. Suggested-by: Brian King Signed-off-by: D

Re: [PATCH net-next 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-20 Thread George McCollister
On Fri, Nov 20, 2020 at 1:33 PM Andrew Lunn wrote: > > > +static const struct xrs700x_mib xrs700x_mibs[] = { > > + {XRS_RX_GOOD_OCTETS_L(0), "rx_good_octets"}, > > + {XRS_RX_BAD_OCTETS_L(0), "rx_bad_octets"}, > > + {XRS_RX_UNICAST_L(0), "rx_unicast"}, > > + {XRS_RX_BROADCAST_L(0),

Re: [PATCH net v2 3/3] ibmvnic: skip tx timeout reset while in resetting

2020-11-20 Thread drt
On 2020-11-20 14:40, Lijun Pan wrote: Sometimes it takes longer than 5 seconds (watchdog timeout) to complete failover, migration, and other resets. In stead of scheduling another timeout reset, we wait for the current one to complete. Suggested-by: Brian King Signed-off-by: Lijun Pan Review

Re: [PATCH net v2 1/3] ibmvnic: fix call_netdevice_notifiers in do_reset

2020-11-20 Thread drt
On 2020-11-20 14:40, Lijun Pan wrote: When netdev_notify_peers was substituted in commit 986103e7920c ("net/ibmvnic: Fix RTNL deadlock during device reset"), call_netdevice_notifiers(NETDEV_RESEND_IGMP, dev) was missed. Fix it now. Fixes: 986103e7920c ("net/ibmvnic: Fix RTNL deadlock during de

[PATCH net-next v2] net: don't include ethtool.h from netdevice.h

2020-11-20 Thread Jakub Kicinski
linux/netdevice.h is included in very many places, touching any of its dependecies causes large incremental builds. Drop the linux/ethtool.h include, linux/netdevice.h just needs a forward declaration of struct ethtool_ops. Fix all the places which made use of this implicit include. Acked-by: Jo

Re: [PATCH 108/141] netfilter: ipt_REJECT: Fix fall-through warnings for Clang

2020-11-20 Thread Florian Westphal
Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. Acked-by: Florian Westphal

Re: [PATCH net-next v3 05/12] net: dsa: microchip: ksz9477: move chip reset to ksz9477_switch_init()

2020-11-20 Thread Vladimir Oltean
On Wed, Nov 18, 2020 at 09:30:06PM +0100, Christian Eggers wrote: > The next patch will add basic interrupt support. Chip reset must be > performed before requesting the IRQ, so move this from ksz9477_setup() > to ksz9477_init(). > > Signed-off-by: Christian Eggers > --- Reviewed-by: Vladimir Ol

Re: [PATCH net-next] net: don't include ethtool.h from netdevice.h

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 23:28:28 +0100 Johannes Berg wrote: > On Fri, 2020-11-20 at 14:13 -0800, Jakub Kicinski wrote: > > linux/netdevice.h is included in very many places, touching any > > of its dependecies causes large incremental builds. > > > > Drop the linux/ethtool.h include, linux/netdevice.h

Re: [PATCH 015/141] netfilter: Fix fall-through warnings for Clang

2020-11-20 Thread Florian Westphal
Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of just > letting the code fall through to the next case. Acked-by: Florian Westphal Feel free to carry this in next iteration o

  1   2   3   4   5   >