Re: [PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common

2020-11-18 Thread Kalle Valo
Qinglang Miao writes: > Add the missing destroy_workqueue() before return from > cw1200_init_common in the error handling case. > > Fixes:a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN > chipsets") This should be: Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW110

Re: [PATCH 05/11] net: dsa: microchip: ksz8795: use mib_cnt where possible

2020-11-18 Thread Michael Grzeschik
Hi Andrew! On Thu, Nov 19, 2020 at 01:20:47AM +0100, Andrew Lunn wrote: On Wed, Nov 18, 2020 at 11:03:51PM +0100, Michael Grzeschik wrote: The variable mib_cnt is assigned with TOTAL_SWITCH_COUNTER_NUM. This value can also be derived from the array size of mib_names. This patch uses this calcul

Re: [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring

2020-11-18 Thread Tao Ren
On Wed, Nov 18, 2020 at 05:26:53PM -0800, Guenter Roeck wrote: > On Wed, Nov 18, 2020 at 05:01:19PM -0800, Guenter Roeck wrote: > > On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote: > > > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote: > > > > On Wed, Nov 18, 2020 at 03:09:27PM

Re: pull-request: can 2020-11-18

2020-11-18 Thread Marc Kleine-Budde
On 11/19/20 2:52 AM, Jakub Kicinski wrote: >> P.S.: Can you merge net/master into net-next/master after merging this pull >> request? > > That usually happens after Linus pulls from net, I will send a PR to him > tomorrow, and then merge net -> net-next. Hope that works for you! Yes, fine with me

WARNING: net/mptcp/protocol.c:719 mptcp_reset_timer+0x40/0x50

2020-11-18 Thread Naresh Kamboju
While running kselftest net/mptcp: mptcp_join.sh on x86_64 device running linux next 20201118 tag the following warning was noticed. # selftests: net/mptcp: mptcp_join.sh [ 1276.053194] [ cut here ] [ 1276.057857] WARNING: CPU: 2 PID: 27452 at /usr/src/kernel/net/mptcp

[PATCH] bpf: Check the return value of dev_get_by_index_rcu()

2020-11-18 Thread xiakaixu1987
From: Kaixu Xia The return value of dev_get_by_index_rcu() can be NULL, so here it is need to check the return value and return error code if it is NULL. Signed-off-by: Kaixu Xia --- net/core/filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/filter.c b/net/core/filter.c i

[PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common

2020-11-18 Thread Qinglang Miao
Add the missing destroy_workqueue() before return from cw1200_init_common in the error handling case. Fixes:a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/net/wireless/st/cw1200/main.c | 2 ++ 1 fi

Re: [PATCH net-next v3 0/6] net/x25: netdev event handling

2020-11-18 Thread Martin Schiller
On 2020-11-18 15:47, Xie He wrote: On Wed, Nov 18, 2020 at 5:59 AM Martin Schiller wrote: --- Changes to v2: o restructure complete patch-set o keep netdev event handling in layer3 (X.25) But... Won't it be better to handle L2 connections in L2 code? For example, if we are running X.25 over

Re: [PATCH 05/11] net: dsa: microchip: ksz8795: use mib_cnt where possible

2020-11-18 Thread kernel test robot
Hi Michael, I love your patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on net-next/master ipvs/master linus/master v5.10-rc4 next-20201118] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

[RFC PATCH net-next] net: dsa: mt7530: support setting ageing time

2020-11-18 Thread DENG Qingfang
MT7530 has a global address age control register, so use it to set ageing time. The applied timer is (AGE_CNT + 1) * (AGE_UNIT + 1) seconds Signed-off-by: DENG Qingfang --- drivers/net/dsa/mt7530.c | 41 drivers/net/dsa/mt7530.h | 13 + 2 fil

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread Saeed Mahameed
On Wed, 2020-11-18 at 18:23 -0800, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 18:50:57 + Parav Pandit wrote: > > At this point vdpa tool of [1] can create one or more vdpa net > > devices on this subfunction device in below sequence. > > > > $ vdpa parentdev list > > auxiliary/mlx5_core.sf.4

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread Saeed Mahameed
On Wed, 2020-11-18 at 18:14 -0800, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > > On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: > > > > It is consistent with the multi-subsystem device sharing model > > we've > > had for ages now. > > > > T

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread Saeed Mahameed
On Wed, 2020-11-18 at 21:35 -0700, David Ahern wrote: > On 11/18/20 7:14 PM, Jakub Kicinski wrote: > > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > > > On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: > > > > > > > > Just to refresh all our memory, we discussed and se

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-18 Thread Xin Long
On Thu, Nov 19, 2020 at 4:35 AM Alexander Duyck wrote: > > On Mon, Nov 16, 2020 at 1:17 AM Xin Long wrote: > > > > This patch is to let it always do CRC checksum in sctp_gso_segment() > > by removing CRC flag from the dev features in gre_gso_segment() for > > SCTP over GRE, just as it does in Com

Re: [PATCH] cxbgb4: Fix build failure when CHELSIO_TLS_DEVICE=n

2020-11-18 Thread Tom Seewald
On Tue, Nov 17, 2020 at 4:26 PM Jakub Kicinski wrote: > > On Sun, 15 Nov 2020 20:31:40 -0600 Tom Seewald wrote: > > After commit 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted bit is not enough") > > building the kernel with CHELSIO_T4=y and CHELSIO_TLS_DEVICE=n results > > in the following error: > > >

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-18 Thread Xin Long
On Thu, Nov 19, 2020 at 12:44 AM Jakub Kicinski wrote: > > On Wed, 18 Nov 2020 14:14:49 +0800 Xin Long wrote: > > On Wed, Nov 18, 2020 at 8:29 AM Jakub Kicinski wrote: > > > On Mon, 16 Nov 2020 17:15:47 +0800 Xin Long wrote: > > > > This patch is to let it always do CRC checksum in sctp_gso_segme

Re: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-18 Thread Christian Eggers
Hi Vladimir, On Thursday, 19 November 2020, 00:40:18 CET, Vladimir Oltean wrote: > On Wed, Nov 18, 2020 at 09:30:01PM +0100, Christian Eggers wrote: > > This series adds support for PTP to the KSZ956x and KSZ9477 devices. > > > > There is only little documentation for PTP available on the data sh

Re: [PATCH net-next v2 3/3] ptp: ptp_ines: use new PTP_MSGTYPE_* define(s)

2020-11-18 Thread Christian Eggers
On Wednesday, 18 November 2020, 22:03:56 CET, Jacob Keller wrote: > On 11/18/2020 8:22 AM, Christian Eggers wrote: > > Remove driver internal defines for this. > > > > Signed-off-by: Christian Eggers > > Cc: Richard Cochran > > Cc: Kurt Kanzenbach > > --- > > > > drivers/ptp/ptp_ines.c | 19 +

Re: [PATCH net-next] net: dsa: avoid potential use-after-free error

2020-11-18 Thread Christian Eggers
On Thursday, 19 November 2020, 00:33:57 CET, Vladimir Oltean wrote: > On Wed, Nov 18, 2020 at 04:43:35PM +0100, Christian Eggers wrote: > > If dsa_switch_ops::port_txtstamp() returns false, clone will be freed > > immediately. Storing the pointer in DSA_SKB_CB(skb)->clone anyway, > > supports annoy

Re: [EXT] [PATCH] aquantia: Reserve space when allocating an SKB

2020-11-18 Thread Ramsay, Lincoln
Hi Igor, > > With your solution, packets of size (AQ_CFG_RX_FRAME_MAX - AQ_SKB_PAD) up to > > size of AQ_CFG_RX_FRAME_MAX will overwrite the area of page they designated > > to. Ultimately, HW will do a memory corruption of next page. > > The code in aq_get_rxpages seems to suggest that multiple

Re: Hii

2020-11-18 Thread PRIYA RAJAGOPAL
honored Mornning

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread David Ahern
On 11/18/20 7:14 PM, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: >> On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: >> Just to refresh all our memory, we discussed and settled on the flow in [2]; RFC [1] followed this discussion.

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-18 Thread Andrew Lunn
> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > index 9ca87bc..afd8de2 100644 > --- a/include/uapi/linux/ethtool.h > +++ b/include/uapi/linux/ethtool.h > @@ -433,6 +433,7 @@ struct ethtool_modinfo { > * a TX interrupt, when the packet rate is above @pkt_rate_high. >

[RFC net-next 2/2] net: hns3: add support for dynamic interrupt moderation

2020-11-18 Thread Huazhong Tan
Add dynamic interrupt moderation support for the HNS3 driver, and add ethtool support for controlling the type of adaptive. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/Kconfig | 1 + drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 87 +- d

[RFC net-next 0/2] net: updates for -next

2020-11-18 Thread Huazhong Tan
#2 will add DIM for the HNS3 ethernet driver, then there will be two implemation of IRQ adaptive coalescing (DIM and driver custiom, so #1 adds a new netlink attribute to the ETHTOOL_MSG_COALESCE_GET/ETHTOOL_MSG_COALESCE_SET commands which controls the type of adaptive coalescing. Huazhong Tan (2)

[RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-18 Thread Huazhong Tan
Since the information whether the adaptive behavior is implemented by DIM or driver custom is useful, so add new attribute to ETHTOOL_MSG_COALESCE_GET/ETHTOOL_MSG_COALESCE_SET commands to control the type of adaptive coalescing. Suggested-by: Jakub Kicinski Signed-off-by: Huazhong Tan --- inclu

[PATCH v2 net] ptp: clockmatrix: bug fix for idtcm_strverscmp

2020-11-18 Thread min.li.xe
From: Min Li Feed kstrtou8 with NULL terminated string. Changes since v1: -Only strcpy 15 characters to leave 1 space for '\0' Signed-off-by: Min Li --- drivers/ptp/ptp_clockmatrix.c | 52 +++ 1 file changed, 38 insertions(+), 14 deletions(-) diff --gi

Re: [PATCH 06/11] net: dsa: microchip: ksz8795: use phy_port_cnt where possible

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > Since the driver can be used on more switches it needs > to use flexible port count where ever possible. > > Signed-off-by: Michael Grzeschik Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 08/11] net: dsa: microchip: ksz8795: align port_cnt usage with other microchip drivers

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > The ksz8795 driver is using port_cnt differently to the other microchip > DSA drivers. It sets it to the external physical port count, than the > whole port count (including the cpu port). This patch is aligning the > variables purpose with the o

Re: [PATCH 10/11] net: dsa: microchip: ksz8795: dynamic allocate memory for flush_dyn_mac_table

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > To get the driver working with other chips using different port counts > the dyn_mac_table should be flushed depending on the amount of physical > ports. > > Signed-off-by: Michael Grzeschik Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 09/11] net: dsa: microchip: remove usage of mib_port_count

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > The variable mib_port_cnt has the same meaning as port_cnt. > This driver removes the extra variable and is using port_cnt > everywhere instead. > > Signed-off-by: Michael Grzeschik Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 11/11] net: dsa: microchip: ksz8795: use num_vlans where possible

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > The value of the define VLAN_TABLE_ENTRIES can be derived from > num_vlans. This patch is using the variable num_vlans instead and > removes the extra define. > > Signed-off-by: Michael Grzeschik Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 07/11] net: dsa: microchip: remove superfluous num_ports asignment

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > The variable num_ports is already assigned in the init function. > This patch removes the extra assignment of the variable. > > Signed-off-by: Michael Grzeschik Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 05/11] net: dsa: microchip: ksz8795: use mib_cnt where possible

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > The variable mib_cnt is assigned with TOTAL_SWITCH_COUNTER_NUM. This > value can also be derived from the array size of mib_names. This patch > uses this calculated value instead, removes the extra define and uses > mib_cnt everywhere possible in

Re: [PATCH 04/11] net: dsa: microchip: ksz8795: use reg_mib_cnt where possible

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > The extra define SWITCH_COUNTER_NUM is a copy of the KSZ8795_COUNTER_NUM > define. This patch initializes reg_mib_cnt with KSZ8795_COUNTER_NUM, > makes use of reg_mib_cnt everywhere instead and removes the extra > define. > > Signed-off-by: Mich

Re: [PATCH 03/11] net: dsa: microchip: ksz8795: move variable assignments from detect to init

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > This patch moves all variable assignments to the init function. It > leaves the detect function for its single purpose to detect which chip > version is found. > > Signed-off-by: Michael Grzeschik Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 01/11] net: dsa: microchip: ksz8795: remove unused last_port variable

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > The variable last_port is not used anywhere, this patch removes it. > > Signed-off-by: Michael Grzeschik Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 02/11] net: dsa: microchip: ksz8795: remove superfluous port_cnt assignment

2020-11-18 Thread Florian Fainelli
On 11/18/2020 2:03 PM, Michael Grzeschik wrote: > The port_cnt assignment will be done again in the init function. > This patch removes the previous assignment in the detect function. > > Signed-off-by: Michael Grzeschik Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 18:50:57 + Parav Pandit wrote: > At this point vdpa tool of [1] can create one or more vdpa net devices on > this subfunction device in below sequence. > > $ vdpa parentdev list > auxiliary/mlx5_core.sf.4 > supported_classes > net > > $ vdpa dev add parentdev auxili

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 14:49:54 -0400 Jason Gunthorpe wrote: > On Tue, Nov 17, 2020 at 09:11:20AM -0800, Jakub Kicinski wrote: > > > > Just to refresh all our memory, we discussed and settled on the flow > > > in [2]; RFC [1] followed this discussion. > > > > > > vdpa tool of [3] can add one or more

[PATCH] mwifiex: Remove duplicated REG_PORT definition

2020-11-18 Thread Jisheng Zhang
The REG_PORT is defined twice, so remove one of them. Signed-off-by: Jisheng Zhang --- drivers/net/wireless/marvell/mwifiex/sdio.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.h b/drivers/net/wireless/marvell/mwifiex/sdio.h index dec534a6ddb1..5

Re: KASAN: use-after-free Read in ath9k_hif_usb_rx_cb (2)

2020-11-18 Thread syzbot
syzbot has bisected this issue to: commit dcd479e10a0510522a5d88b29b8f79ea3467d501 Author: Johannes Berg Date: Fri Oct 9 12:17:11 2020 + mac80211: always wind down STA state bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=100c9c1650 start commit: 0fa8ee0d Merge bran

Re: [PATCH bpf-next v2 0/3] RISC-V selftest/bpf fixes

2020-11-18 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 18 Nov 2020 08:16:37 +0100 you wrote: > This series contain some fixes for selftests/bpf when building/running > on a RISC-V host. Details can be found in each individual commit. > > > Cheers, > Björn > > [...] He

Re: [PATCH] libbpf: Fix VERSIONED_SYM_COUNT number parsing

2020-11-18 Thread Andrii Nakryiko
On Wed, Nov 18, 2020 at 1:15 PM Jiri Olsa wrote: > > We remove "other info" from "readelf -s --wide" output when > parsing GLOBAL_SYM_COUNT variable, which was added in [1]. > But we don't do that for VERSIONED_SYM_COUNT and it's failing > the check_abi target on powerpc Fedora 33. > > The extra "

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Samudrala, Sridhar
On 11/18/2020 5:17 PM, David Ahern wrote: On 11/18/20 5:41 PM, Jacob Keller wrote: On 11/18/2020 11:22 AM, Parav Pandit wrote: From: David Ahern Sent: Wednesday, November 18, 2020 11:33 PM With Connectx-4 Lx for example the netdev can have at most 63 queues leaving 96 cpu servers a b

Re: [PATCH v2 1/4] rtlwifi: rtl8188ee: avoid accessing the data mapped to streaming DMA

2020-11-18 Thread Jia-Ju Bai
Thanks for the advice. I have added the description of the changes and resent the patches. Best wishes, Jia-Ju Bai On 2020/11/19 1:20, Larry Finger wrote: On 11/17/20 7:53 PM, Jia-Ju Bai wrote: In rtl88ee_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on line 677:    dma_addr_t mappi

Re: pull-request: can 2020-11-18

2020-11-18 Thread Jakub Kicinski
On Wed, 18 Nov 2020 17:04:10 +0100 Marc Kleine-Budde wrote: > Hello Jakub, hello David, > > here's a pull request for net/master consisting of 4 patches for net/master, > > Jimmy Assarsson provides two patches for the kvaser_pciefd and kvaser_usb > drivers, where the can_bittiming_const are fixed

[PATCH v2 3/4 resend] rtlwifi: rtl8192de: avoid accessing the data mapped to streaming DMA

2020-11-18 Thread Jia-Ju Bai
In rtl92de_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on line 667: dma_addr_t mapping = dma_map_single(..., skb->data, ...); On line 669, skb->data is assigned to hdr after cast: struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data); Then hdr->frame_control is accessed

[PATCH v2 2/4 resend] rtlwifi: rtl8192ce: avoid accessing the data mapped to streaming DMA

2020-11-18 Thread Jia-Ju Bai
In rtl92ce_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on line 530: dma_addr_t mapping = dma_map_single(..., skb->data, ...); On line 533, skb->data is assigned to hdr after cast: struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data); Then hdr->frame_control is accessed

[PATCH v2 4/4 resend] rtlwifi: rtl8723ae: avoid accessing the data mapped to streaming DMA

2020-11-18 Thread Jia-Ju Bai
In rtl8723e_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on line 531: dma_addr_t mapping = dma_map_single(..., skb->data, ...); On line 534, skb->data is assigned to hdr after cast: struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data); Then hdr->frame_control is accessed

[PATCH v2 1/4 resend] rtlwifi: rtl8188ee: avoid accessing the data mapped to streaming DMA

2020-11-18 Thread Jia-Ju Bai
In rtl88ee_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on line 677: dma_addr_t mapping = dma_map_single(..., skb->data, ...); On line 680, skb->data is assigned to hdr after cast: struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data); Then hdr->frame_control is accessed

Re: [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring

2020-11-18 Thread Guenter Roeck
On Wed, Nov 18, 2020 at 05:01:19PM -0800, Guenter Roeck wrote: > On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote: > > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote: > > > On Wed, Nov 18, 2020 at 03:09:27PM -0800, rentao.b...@gmail.com wrote: > > > > From: Tao Ren > > > > > >

Re: [RFC PATCH bpf-next 0/8] Socket migration for SO_REUSEPORT.

2020-11-18 Thread Martin KaFai Lau
On Tue, Nov 17, 2020 at 06:40:15PM +0900, Kuniyuki Iwashima wrote: > The SO_REUSEPORT option allows sockets to listen on the same port and to > accept connections evenly. However, there is a defect in the current > implementation. When a SYN packet is received, the connection is tied to a > listeni

Re: [PATCH net] net/mlx4_core: Fix init_hca fields offset

2020-11-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 18 Nov 2020 10:19:22 +0200 you wrote: > From: Aya Levin > > Slave function read the following capabilities from the wrong offset: > 1. log_mc_entry_sz > 2. fs_log_entry_sz > 3. log_mc_hash_sz > > [...] Here is the su

Re: [PATCH net-next v2 1/3] nfc: s3fwrn5: Remove the max_payload

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 17:08:24 +0900 Bongsu Jeon wrote: > max_payload is unused. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Bongsu Jeon Applied all 3 to net-next, thanks!

Re: [PATCH] hv_netvsc: Validate number of allocated sub-channels

2020-11-18 Thread Jakub Kicinski
On Wed, 18 Nov 2020 16:33:10 +0100 Andrea Parri (Microsoft) wrote: > Lack of validation could lead to out-of-bound reads and information > leaks (cf. usage of nvdev->chan_table[]). Check that the number of > allocated sub-channels fits into the expected range. > > Suggested-by: Saruhan Karademir

Re: [PATCH net-next 0/9] s390/qeth: updates 2020-11-17

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 17:15:11 +0100 Julian Wiedmann wrote: > please apply the following patch series for qeth to netdev's net-next tree. > > This brings some cleanups, and a bunch of improvements for our > .get_link_ksettings() code. Applied, thanks!

Re: [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote: > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote: > > On Wed, Nov 18, 2020 at 03:09:27PM -0800, rentao.b...@gmail.com wrote: > > > From: Tao Ren > > > > > > The patch series adds hardware monitoring driver for the Maxim MAX127

Re: [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring

2020-11-18 Thread Guenter Roeck
On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote: > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote: > > On Wed, Nov 18, 2020 at 03:09:27PM -0800, rentao.b...@gmail.com wrote: > > > From: Tao Ren > > > > > > The patch series adds hardware monitoring driver for the Maxim MAX127

Re: [PATCH net-next] net: bridge: replace struct br_vlan_stats with pcpu_sw_netstats

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 21:25:42 +0100 Heiner Kallweit wrote: > Struct br_vlan_stats duplicates pcpu_sw_netstats (apart from > br_vlan_stats not defining an alignment requirement), therefore > switch to using the latter one. > > Signed-off-by: Heiner Kallweit Applied, thanks!

Re: [PATCH net-next] r8169: remove not needed check in rtl8169_start_xmit

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 21:34:09 +0100 Heiner Kallweit wrote: > In rtl_tx() the released descriptors are zero'ed by > rtl8169_unmap_tx_skb(). And in the beginning of rtl8169_start_xmit() > we check that enough descriptors are free, therefore there's no way > the DescOwn bit can be set here. > > Signed

Re: [PATCH 11/11] net: dsa: microchip: ksz8795: use num_vlans where possible

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 11:03:57PM +0100, Michael Grzeschik wrote: > The value of the define VLAN_TABLE_ENTRIES can be derived from > num_vlans. This patch is using the variable num_vlans instead and > removes the extra define. > > Signed-off-by: Michael Grzeschik Reviewed-by: Andrew Lunn

Re: [pull request][net 0/9] mlx5 fixes 2020-11-17

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 11:56:53 -0800 Saeed Mahameed wrote: > This series introduces some fixes to mlx5 driver. > Please pull and let me know if there is any problem. > > For -stable v4.14 > ('net/mlx5: Disable QoS when min_rates on all VFs are zero') > > For -stable v4.20 > ('net/mlx5: Add handli

Re: [PATCH 10/11] net: dsa: microchip: ksz8795: dynamic allocate memory for flush_dyn_mac_table

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 11:03:56PM +0100, Michael Grzeschik wrote: > To get the driver working with other chips using different port counts > the dyn_mac_table should be flushed depending on the amount of physical > ports. > > Signed-off-by: Michael Grzeschik > > --- > v1: - based on "[PATCH v4

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread David Ahern
On 11/18/20 5:41 PM, Jacob Keller wrote: > > > On 11/18/2020 11:22 AM, Parav Pandit wrote: >> >> >>> From: David Ahern >>> Sent: Wednesday, November 18, 2020 11:33 PM >>> >>> >>> With Connectx-4 Lx for example the netdev can have at most 63 queues >>> leaving 96 cpu servers a bit short - as an e

[net v2] net/tls: missing received data after fast remote close

2020-11-18 Thread Vadim Fedorenko
In case when tcp socket received FIN after some data and the parser haven't started before reading data caller will receive an empty buffer. This behavior differs from plain TCP socket and leads to special treating in user-space. The flow that triggers the race is simple. Server sends small amount

Re: [PATCH 09/11] net: dsa: microchip: remove usage of mib_port_count

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 11:03:55PM +0100, Michael Grzeschik wrote: > The variable mib_port_cnt has the same meaning as port_cnt. > This driver removes the extra variable and is using port_cnt > everywhere instead. > > Signed-off-by: Michael Grzeschik Nice to see another poorly defined variable d

[PATCH net-next v2 9/9] ibmvnic: Do not replenish RX buffers after every polling loop

2020-11-18 Thread Thomas Falcon
From: "Dwip N. Banerjee" Reduce the amount of time spent replenishing RX buffers by only doing so once available buffers has fallen under a certain threshold, in this case half of the total number of buffers, or if the polling loop exits before the packets processed is less than its budget. Sign

Re: [PATCH net 1/2] net/tls: Protect from calling tls_dev_del for TLS RX twice

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 12:33:54 -0800 Saeed Mahameed wrote: > From: Maxim Mikityanskiy > > tls_device_offload_cleanup_rx doesn't clear tls_ctx->netdev after > calling tls_dev_del if TLX TX offload is also enabled. Clearing > tls_ctx->netdev gets postponed until tls_device_gc_task. It leaves a > time

[PATCH net-next v2 7/9] ibmvnic: Correctly re-enable interrupts in NAPI polling routine

2020-11-18 Thread Thomas Falcon
From: "Dwip N. Banerjee" If the current NAPI polling loop exits without completing it's budget, only re-enable interrupts if there are no entries remaining in the queue and napi_complete_done is successful. If there are entries remaining on the queue that were missed, restart the polling loop. S

[PATCH net-next v2 8/9] ibmvnic: Use netdev_alloc_skb instead of alloc_skb to replenish RX buffers

2020-11-18 Thread Thomas Falcon
From: "Dwip N. Banerjee" Take advantage of the additional optimizations in netdev_alloc_skb when allocating socket buffers to be used for packet reception. Signed-off-by: Dwip N. Banerjee --- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH net-next v2 5/9] ibmvnic: Remove send_subcrq function

2020-11-18 Thread Thomas Falcon
It is not longer used, so remove it. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 2aace693559f..e9b0cb6dfd9d 10

[PATCH net-next v2 6/9] ibmvnic: Ensure that device queue memory is cache-line aligned

2020-11-18 Thread Thomas Falcon
From: "Dwip N. Banerjee" PCI bus slowdowns were observed on IBM VNIC devices as a result of partial cache line writes and non-cache aligned full cache line writes. Ensure that packet data buffers are cache-line aligned to avoid these slowdowns. Signed-off-by: Dwip N. Banerjee --- drivers/net/e

[PATCH net-next v2 4/9] ibmvnic: Clean up TX code and TX buffer data structure

2020-11-18 Thread Thomas Falcon
Remove unused and superfluous code and members in existing TX implementation and data structures. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 31 +++--- drivers/net/ethernet/ibm/ibmvnic.h | 8 2 files changed, 11 insertions(+), 28 delet

[PATCH net-next v2 3/9] ibmvnic: Introduce xmit_more support using batched subCRQ hcalls

2020-11-18 Thread Thomas Falcon
Include support for the xmit_more feature utilizing the H_SEND_SUB_CRQ_INDIRECT hypervisor call which allows the sending of multiple subordinate Command Response Queue descriptors in one hypervisor call via a DMA-mapped buffer. This update reduces hypervisor calls and thus hypervisor call overhead

[PATCH net-next v2 1/9] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

2020-11-18 Thread Thomas Falcon
This patch introduces the infrastructure to send batched subordinate Command Response Queue descriptors, which are used by the ibmvnic driver to send TX frame and RX buffer descriptors. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 23 +++ drivers/net/

[PATCH net-next v2 2/9] ibmvnic: Introduce batched RX buffer descriptor transmission

2020-11-18 Thread Thomas Falcon
Utilize the H_SEND_SUB_CRQ_INDIRECT hypervisor call to send multiple RX buffer descriptors to the device in one hypervisor call operation. This change will reduce the number of hypervisor calls and thus hypervisor call overhead needed to transmit RX buffer descriptors to the device. Signed-off-by:

[PATCH net-next v2 0/9] ibmvnic: Performance improvements and other updates

2020-11-18 Thread Thomas Falcon
The first three patches utilize a hypervisor call allowing multiple TX and RX buffer replenishment descriptors to be sent in one operation, which significantly reduces hypervisor call overhead. The xmit_more and Byte Queue Limit API's are leveraged to provide this support for TX descriptors. The

Re: [RFC PATCH bpf-next 7/8] bpf: Call bpf_run_sk_reuseport() for socket migration.

2020-11-18 Thread Martin KaFai Lau
On Tue, Nov 17, 2020 at 06:40:22PM +0900, Kuniyuki Iwashima wrote: > This patch makes it possible to select a new listener for socket migration > by eBPF. > > The noteworthy point is that we select a listening socket in > reuseport_detach_sock() and reuseport_select_sock(), but we do not have > st

Re: Hardware time stamping support for AF_XDP applications

2020-11-18 Thread Patel, Vedang
Hi Saeed, > On Nov 13, 2020, at 10:02 AM, Patel, Vedang wrote: > > Hi Saeed, > >> On Nov 12, 2020, at 11:31 AM, Saeed Mahameed wrote: >> >> On Tue, 2020-11-10 at 23:53 +, Patel, Vedang wrote: With BTF formatted metadata it is up to the driver to advertise whatever it can/want :)

Re: [PATCH net] ipv6: Remove dependency of ipv6_frag_thdr_truncated on ipv6 module

2020-11-18 Thread Randy Dunlap
On 11/18/20 3:44 PM, Georg Kohmann wrote: > IPV6=m > NF_DEFRAG_IPV6=y > > ld: net/ipv6/netfilter/nf_conntrack_reasm.o: in function > `nf_ct_frag6_gather': > net/ipv6/netfilter/nf_conntrack_reasm.c:462: undefined reference to > `ipv6_frag_thdr_truncated' > > Netfilter is depending on ipv6 symbol i

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Jacob Keller
On 11/18/2020 9:02 AM, Parav Pandit wrote: > >> From: David Ahern >> Sent: Wednesday, November 18, 2020 9:51 PM >> >> On 11/12/20 12:24 PM, Parav Pandit wrote: >>> Extended devlink interface for the user to add and delete port. >>> Extend devlink to connect user requests to driver to add/delet

Re: [net] net/tls: missing received data after fast remote close

2020-11-18 Thread Jakub Kicinski
On Thu, 19 Nov 2020 00:26:52 + Vadim Fedorenko wrote: > > Damn, you may be seeing some problem I'm missing again ;) Running > > __unparse can be opportunistic, if it doesn't parse anything that's > > fine. I was thinking: > > > > diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c > > index 95ab55

Re: [PATCH 0/3] atm: Replace in_interrupt usage

2020-11-18 Thread Jakub Kicinski
On Mon, 16 Nov 2020 17:21:13 +0100 Sebastian Andrzej Siewior wrote: > Folks, > > this mini series contains the removal of in_interrupt() in drivers/atm > and a tiny bugfix while staring into code. Applied, thanks.

Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.

2020-11-18 Thread Mat Martineau
On Wed, 18 Nov 2020, Paolo Abeni wrote: We must start the retransmission timer only there are pending data in the rtx queue. Otherwise we can hit a WARN_ON in mptcp_reset_timer(), as syzbot demonstrated. Reported-and-tested-by: syzbot+42aa53dafb66a07e5...@syzkaller.appspotmail.com Fixes: d9ca

Re: [PATCH net-next 03/13] devlink: Support add and delete devlink port

2020-11-18 Thread Jacob Keller
On 11/18/2020 11:22 AM, Parav Pandit wrote: > > >> From: David Ahern >> Sent: Wednesday, November 18, 2020 11:33 PM >> >> >> With Connectx-4 Lx for example the netdev can have at most 63 queues >> leaving 96 cpu servers a bit short - as an example of the limited number of >> queues that a nic

Re: [PATCH 08/11] net: dsa: microchip: ksz8795: align port_cnt usage with other microchip drivers

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 11:03:54PM +0100, Michael Grzeschik wrote: > The ksz8795 driver is using port_cnt differently to the other microchip > DSA drivers. It sets it to the external physical port count, than the > whole port count (including the cpu port). This patch is aligning the > variables pu

Re: [PATCH 07/11] net: dsa: microchip: remove superfluous num_ports asignment

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 11:03:53PM +0100, Michael Grzeschik wrote: > The variable num_ports is already assigned in the init function. > This patch removes the extra assignment of the variable. > > Signed-off-by: Michael Grzeschik > --- > drivers/net/dsa/microchip/ksz8795.c | 2 -- > drivers/net/

Re: [PATCH v4] IPv6: RTM_GETROUTE: Add RTA_ENCAP to result

2020-11-18 Thread David Ahern
On 11/18/20 4:06 PM, Oliver Herms wrote: > This patch adds an IPv6 routes encapsulation attribute > to the result of netlink RTM_GETROUTE requests > (i.e. ip route get 2001:db8::). > > Signed-off-by: Oliver Herms > --- > net/ipv6/route.c | 4 > 1 file changed, 4 insertions(+) > Reviewed-b

Re: [PATCH 06/11] net: dsa: microchip: ksz8795: use phy_port_cnt where possible

2020-11-18 Thread Andrew Lunn
> case BR_STATE_DISABLED: > data |= PORT_LEARN_DISABLE; > - if (port < SWITCH_PORT_NUM) > + if (port < dev->phy_port_cnt) > member = 0; > break; So this, unlike all the other patches so far, is not obviously correct. W

Re: [net] net/tls: missing received data after fast remote close

2020-11-18 Thread Vadim Fedorenko
On 18.11.2020 23:39, Jakub Kicinski wrote: On Wed, 18 Nov 2020 20:51:30 + Vadim Fedorenko wrote: The async nature of parser is OK for classic HTTPS server/client case because it's very good to have parsed record before actual call to recvmsg or splice_read is done. The code inside the loop i

Re: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp()

2020-11-18 Thread Vinicius Costa Gomes
Hi Richard, Richard Cochran writes: > On Tue, Nov 17, 2020 at 05:21:48PM -0800, Vinicius Costa Gomes wrote: >> Agreed that would be easiest/simplest. But what I have in hand seems to >> not like it, i.e. I have an earlier series implementing this "one shot" way >> and it's not reliable over long

Re: [PATCH net-next v2 2/7] dpaa_eth: add basic XDP support

2020-11-18 Thread Jakub Kicinski
On Mon, 16 Nov 2020 16:42:28 +0200 Camelia Groza wrote: > + if (likely(fd_format == qm_fd_contig)) { > + xdp_act = dpaa_run_xdp(priv, (struct qm_fd *)fd, vaddr, > +&xdp_meta_len); > + if (xdp_act != XDP_PASS) { > +

Re: [PATCH 05/11] net: dsa: microchip: ksz8795: use mib_cnt where possible

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 11:03:51PM +0100, Michael Grzeschik wrote: > The variable mib_cnt is assigned with TOTAL_SWITCH_COUNTER_NUM. This > value can also be derived from the array size of mib_names. This patch > uses this calculated value instead, removes the extra define and uses > mib_cnt everyw

Re: [PATCH 04/11] net: dsa: microchip: ksz8795: use reg_mib_cnt where possible

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 11:03:50PM +0100, Michael Grzeschik wrote: > The extra define SWITCH_COUNTER_NUM is a copy of the KSZ8795_COUNTER_NUM > define. This patch initializes reg_mib_cnt with KSZ8795_COUNTER_NUM, > makes use of reg_mib_cnt everywhere instead and removes the extra > define. > > Sig

Re: [EXT] [PATCH] aquantia: Reserve space when allocating an SKB

2020-11-18 Thread Ramsay, Lincoln
Hi Igor, > Here I understand your intention. You are trying to "offset" the placement of > the packet data, and the restore it back when construction SKB. Originally, I just added the skb_reserve call, but that broke everything. When I looked at what the igb driver was doing, this approach seeme

Re: [PATCH 03/11] net: dsa: microchip: ksz8795: move variable assignments from detect to init

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 11:03:49PM +0100, Michael Grzeschik wrote: > This patch moves all variable assignments to the init function. It > leaves the detect function for its single purpose to detect which chip > version is found. > > Signed-off-by: Michael Grzeschik Reviewed-by: Andrew Lunn

Re: [RFC PATCH bpf-next 6/8] bpf: Add cookie in sk_reuseport_md.

2020-11-18 Thread Martin KaFai Lau
On Tue, Nov 17, 2020 at 06:40:21PM +0900, Kuniyuki Iwashima wrote: > We will call sock_reuseport.prog for socket migration in the next commit, > so the eBPF program has to know which listener is closing in order to > select the new listener. > > Currently, we can get a unique ID for each listener

Re: [PATCH 02/11] net: dsa: microchip: ksz8795: remove superfluous port_cnt assignment

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 11:03:48PM +0100, Michael Grzeschik wrote: > The port_cnt assignment will be done again in the init function. > This patch removes the previous assignment in the detect function. > > Signed-off-by: Michael Grzeschik Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 01/11] net: dsa: microchip: ksz8795: remove unused last_port variable

2020-11-18 Thread Andrew Lunn
On Wed, Nov 18, 2020 at 11:03:47PM +0100, Michael Grzeschik wrote: > The variable last_port is not used anywhere, this patch removes it. > > Signed-off-by: Michael Grzeschik Reviewed-by: Andrew Lunn Andrew

  1   2   3   4   5   >