RE: [EXT] Re: Fwd: net: fec: rx descriptor ring out of order

2020-11-14 Thread Andy Duan
From: Kegl Rohit Sent: Sunday, November 15, 2020 1:37 AM > On Sat, Nov 14, 2020 at 2:58 AM Andy Duan wrote: > > > > From: Kegl Rohit Sent: Friday, November 13, 2020 > > 8:21 PM > > > On Fri, Nov 13, 2020 at 8:33 AM Kegl Rohit wrote: > > > > > > > > > What are the addresses of the ring entries?

[PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-14 Thread Oleksij Rempel
Add stats support for the ar9331 switch. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/qca/ar9331.c | 113 +++ 1 file changed, 113 insertions(+) diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index e24a99031b80..f6947fb0182f 100644 -

[PATCH v2 net 1/1] net: stmmac: Use rtnl_lock/unlock on netif_set_real_num_rx_queues() call

2020-11-14 Thread Wong Vee Khee
Fix an issue where dump stack is printed on suspend resume flow due to netif_set_real_num_rx_queues() is not called with rtnl_lock held(). Fixes: 686cff3d7022 ("net: stmmac: Fix incorrect location to set real_num_rx|tx_queues") Reported-by: Christophe ROULLIER Tested-by: Christophe ROULLIER Cc:

[PATCH v2 1/1] page_frag: Recover from memory pressure

2020-11-14 Thread Dongli Zhang
The ethernet driver may allocate skb (and skb->data) via napi_alloc_skb(). This ends up to page_frag_alloc() to allocate skb->data from page_frag_cache->va. During the memory pressure, page_frag_cache->va may be allocated as pfmemalloc page. As a result, the skb->pfmemalloc is always true as skb->

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-14 Thread Leon Romanovsky
On Sat, Nov 14, 2020 at 12:21:39AM +0100, Greg KH wrote: > On Fri, Nov 13, 2020 at 04:07:57PM +, Ertman, David M wrote: > > > -Original Message- > > > From: Greg KH > > > Sent: Friday, November 13, 2020 7:50 AM > > > To: Ertman, David M > > > Cc: alsa-de...@alsa-project.org; ti...@sus

Re: [PATCH] page_frag: Recover from memory pressure

2020-11-14 Thread Dongli Zhang
>From linux-next, this patch is not in akpm branch. According to discussion with Matthew offline, I will take the author of this patch as Matthew was providing review for patch and suggesting a better alternative. Therefore, it will be much more easier or me to track this patch. I will re-send t

[PATCH] bpf: don't fail kmalloc while releasing raw_tp

2020-11-14 Thread Matt Mullins
bpf_link_free is always called in process context, including from a workqueue and from __fput. Neither of these have the ability to propagate an -ENOMEM to the caller. Reported-by: syzbot+83aa762ef23b6f0d1...@syzkaller.appspotmail.com Reported-by: syzbot+d29e58bb557324e55...@syzkaller.appspotmail

Re: [PATCH bpf-next 6/9] xsk: propagate napi_id to XDP socket Rx path

2020-11-14 Thread Ilias Apalodimas
On Thu, Nov 12, 2020 at 12:40:38PM +0100, Björn Töpel wrote: > From: Björn Töpel > > Add napi_id to the xdp_rxq_info structure, and make sure the XDP > socket pick up the napi_id in the Rx path. The napi_id is used to find > the corresponding NAPI structure for socket busy polling. > > Signed-of

[net v2] net/tls: fix corrupted data in recvmsg

2020-11-14 Thread Vadim Fedorenko
If tcp socket has more data than Encrypted Handshake Message then tls_sw_recvmsg will try to decrypt next record instead of returning full control message to userspace as mentioned in comment. The next message - usually Application Data - gets corrupted because it uses zero copy for decryption that

Re: [RFC bpf-next 1/3] bpf: add module support to btf display helpers

2020-11-14 Thread Yonghong Song
On 11/14/20 8:04 AM, Alexei Starovoitov wrote: On Fri, Nov 13, 2020 at 10:59 PM Andrii Nakryiko wrote: On Fri, Nov 13, 2020 at 10:11 AM Alan Maguire wrote: bpf_snprintf_btf and bpf_seq_printf_btf use a "struct btf_ptr *" argument that specifies type information about the type to be displ

Re: [net] net/tls: fix corrupted data in recvmsg

2020-11-14 Thread Vadim Fedorenko
On 15.11.2020 03:54, Jakub Kicinski wrote: Please don't top post. On Sun, 15 Nov 2020 02:26:30 + Vadim Fedorenko wrote: No, I don't have any BPFs in test. If we have Application Data in TCP queue then tls_sw_advance_skb will change ctx->control from 0x16 to 0x17 (TLS_RECORD_TYPE_DATA) an

Re: [PATCH net-next v3] net: linux/skbuff.h: combine SKB_EXTENSIONS + KCOV handling

2020-11-14 Thread Jakub Kicinski
On Sat, 14 Nov 2020 17:10:43 -0800 Randy Dunlap wrote: > The previous Kconfig patch led to some other build errors as > reported by the 0day bot and my own overnight build testing. > > These are all in when KCOV is enabled but > SKB_EXTENSIONS is not enabled, so fix those by combining those condi

Re: devlink userspace process appears stuck (was: Re: [net-next] devlink: move request_firmware out of driver)

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 14:51:36 -0800 Jacob Keller wrote: > On 11/13/2020 2:32 PM, Jacob Keller wrote: > > > > > > On 11/13/2020 1:34 PM, Jacob Keller wrote: > >> Well, at least with ice, the experience is pretty bad. I tried out with > >> a garbage file name on one of my test systems. This was on

Re: [net] net/tls: fix corrupted data in recvmsg

2020-11-14 Thread Jakub Kicinski
Please don't top post. On Sun, 15 Nov 2020 02:26:30 + Vadim Fedorenko wrote: > No, I don't have any BPFs in test. > If we have Application Data in TCP queue then tls_sw_advance_skb > will change ctx->control from 0x16 to 0x17 (TLS_RECORD_TYPE_DATA) > and the loop will continue. Ah! Missed tha

Re: [PATCH net] net: x25: Correct locking for x25_kill_by_device and x25_kill_by_neigh

2020-11-14 Thread Xie He
On Sat, Nov 14, 2020 at 2:36 AM Xie He wrote: > > This patch adds correct locking for x25_kill_by_device and > x25_kill_by_neigh, and removes the incorrect locking in x25_connect and > x25_disconnect. I see if I do this change, I need to make sure the sock lock is not held when calling x25_remove

[RFC net-next af_unix v1 0/1] Allow delivery of SIGURG on AF_UNIX streams socket

2020-11-14 Thread rao . shoaib
From: Rao Shoaib The use of AF_UNIX sockets is on the rise. We have a case where thousands of processes connect locally to a database and issue queries that are serviced by a pool of threads. Communication is done over AF_UNIX sockets. Currently, there is no way for the submitter to signal the se

[RFC net-next af_unix v1 1/1] af_unix: Allow delivery of SIGURG on AF_UNIX streams socket

2020-11-14 Thread rao . shoaib
From: Rao Shoaib For AF_UNIX stream socket send SIGURG to the peer if the msg has MSG_OOB flag set. Signed-off-by: Rao Shoaib --- net/unix/af_unix.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 92784e5..4f01d74 100644 --

Re: [net] net/tls: fix corrupted data in recvmsg

2020-11-14 Thread Vadim Fedorenko
No, I don't have any BPFs in test. If we have Application Data in TCP queue then tls_sw_advance_skb will change ctx->control from 0x16 to 0x17 (TLS_RECORD_TYPE_DATA) and the loop will continue. The patched if will make zc = true and data will be decrypted into msg->msg_iter. After that the loop wi

Re: [PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

2020-11-14 Thread Andreas Färber
Hi Russell, On 15.11.20 02:02, Russell King - ARM Linux admin wrote: > On Sun, Nov 15, 2020 at 01:41:51AM +0100, Andreas Färber wrote: >> Commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 (net: ethernet: mvneta: >> Add 2500BaseX support for SoCs without comphy) added support for 2500BaseX. >> >> In

Re: [PATCH v4 net-next 00/13] Add ethtool ntuple filters support

2020-11-14 Thread Alexander Duyck
On Sat, Nov 14, 2020 at 11:53 AM Naveen Mamindlapalli wrote: > > This patch series adds support for ethtool ntuple filters, unicast > address filtering, VLAN offload and SR-IOV ndo handlers. All of the > above features are based on the Admin Function(AF) driver support to > install and delete the

Re: [net] net/tls: fix corrupted data in recvmsg

2020-11-14 Thread Jakub Kicinski
On Sat, 14 Nov 2020 07:09:42 +0300 Vadim Fedorenko wrote: > If tcp socket has more data than Encrypted Handshake Message then > tls_sw_recvmsg will try to decrypt next record instead of returning > full control message to userspace as mentioned in comment. The next > message - usually Application D

Re: pull-request: can 2020-11-14

2020-11-14 Thread Jakub Kicinski
On Sat, 14 Nov 2020 18:33:44 +0100 Marc Kleine-Budde wrote: > Anant Thazhemadam contributed two patches for the AF_CAN that prevent > potential > access of uninitialized member in can_rcv() and canfd_rcv(). > > The next patch is by Alejandro Concepcion Rodriguez and changes can_restart() > to use

Re: pull-request: can 2020-11-14

2020-11-14 Thread Jakub Kicinski
On Sat, 14 Nov 2020 17:35:01 -0800 Jakub Kicinski wrote: > Two invalid fixes tags here, do you want to respin or should I pull? Just realized you probably have these objects in your tree so it'd be useful if I told you which ones ;) Commit: be719591ede2 ("can: m_can: Fix freeing of can device fro

Re: [PATCH v2 bpf-next 3/4] bpf: Allow using bpf_sk_storage in FENTRY/FEXIT/RAW_TP

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 13:13:13 -0800 Martin KaFai Lau wrote: > This patch adds bpf_sk_storage_get_tracing_proto and > bpf_sk_storage_delete_tracing_proto. They will check > in runtime that the helpers can only be called when serving > softirq or running in a task context. That should enable > most

[PATCH net-next v3] net: linux/skbuff.h: combine SKB_EXTENSIONS + KCOV handling

2020-11-14 Thread Randy Dunlap
The previous Kconfig patch led to some other build errors as reported by the 0day bot and my own overnight build testing. These are all in when KCOV is enabled but SKB_EXTENSIONS is not enabled, so fix those by combining those conditions in the header file. Also, add stubs for skb_ext_add() and

Que a paz de Deus esteja com você:.

2020-11-14 Thread Mrs. Nadia Emaan
Olá meu querido Estou entrando em contato com você por este meio porque preciso do seu urgente assistência e também me ajude a realizar um projeto de caridade em seu país. Eu encontrei seu endereço de e-mail como um verdadeiro filho de Deus no passado poucos dias agora que tenho orado para saber s

Re: [PATCH v3] net: openvswitch: use core API to update/provide stats

2020-11-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 13 Nov 2020 23:53:36 +0200 you wrote: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added > function "dev_sw_netstats_tx_add()" to update net device per-cpu TX > stats. > > Use this function

Re: [PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

2020-11-14 Thread Russell King - ARM Linux admin
On Sun, Nov 15, 2020 at 01:41:51AM +0100, Andreas Färber wrote: > Commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 (net: ethernet: mvneta: > Add 2500BaseX support for SoCs without comphy) added support for 2500BaseX. > > In case a comphy is not provided, mvneta_validate()'s check > state->interfa

Re: [PATCH v3] net: xfrm: use core API for updating/providing stats

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 23:59:40 +0200 Lev Stipakov wrote: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added > function "dev_sw_netstats_tx_add()" to update net device per-cpu TX > stats. > > Use this function instead of own code. > > While on it, remove xfrmi_get_stats64() a

Re: [PATCH net-next 00/15] mlxsw: Preparations for nexthop objects support - part 1/2

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 18:05:44 +0200 Ido Schimmel wrote: > From: Ido Schimmel > > This patch set contains small and non-functional changes aimed at making > it easier to support nexthop objects in mlxsw. Follow up patches can be > found here [1]. > > Patches #1-#4 add a type field to the nexthop g

Re: [PATCH] net/nfc/nic: refined function nci_hci_resp_received

2020-11-14 Thread Jakub Kicinski
You had a typo in the subject nic -> nci. But really nfc: would be enough. On Fri, 13 Nov 2020 11:51:57 +0800 Alex Shi wrote: > We don't use the parameter result actually, so better to remove it and > skip a gcc warning for unused variable. > > Signed-off-by: Alex Shi Let's CC the nfc list. nf

Re: [PATCH net-next 1/2] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip

2020-11-14 Thread Bongsu Jeon
On Fri, Nov 13, 2020 at 4:26 PM Krzysztof Kozlowski wrote: > > On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon wrote: > > > > > > Add driver for Samsung S3FWRN82 NFC controller. > > S3FWRN82 is using NCI protocol and I2C communication interface. > > > > Signed-off-by: Bongsu Jeon > > --- > > drivers/

[PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

2020-11-14 Thread Andreas Färber
Commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 (net: ethernet: mvneta: Add 2500BaseX support for SoCs without comphy) added support for 2500BaseX. In case a comphy is not provided, mvneta_validate()'s check state->interface == PHY_INTERFACE_MODE_2500BASEX could never be true (it would've return

Re: [PATCH v2 net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 19:16:22 +0800 Wang Hai wrote: > If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), > msg should be canceled by genlmsg_cancel(). > > Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring > interface") > Reported-by: Hulk Robot > Signed-

Re: [PATCH net-next] inet: unexport udp{4|6}_lib_lookup_skb()

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 03:35:53 -0800 Eric Dumazet wrote: > From: Eric Dumazet > > These functions do not need to be exported. > > Signed-off-by: Eric Dumazet Applied, thanks!

Re: [PATCH v5 0/3] Fix inefficiences and rename nla_strlcpy

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 10:56:26 -0800 Kees Cook wrote: > Thanks! This looks good to me. > > Jakub, does this look ready to you? Yup, looks good, sorry! But it didn't get into patchwork cleanly :/ One more resend please? (assuming we're expected to take this into net-next)

Re: [PATCH net-next 0/2] tcp: avoid indirect call in __sk_stream_memory_free()

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 07:08:07 -0800 Eric Dumazet wrote: > From: Eric Dumazet > > Small improvement for CONFIG_RETPOLINE=y, when dealing with TCP sockets. Applied, thank you!

Re: [PATCH] net: stmmac: dwmac_lib: enlarge dma reset timeout

2020-11-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 13 Nov 2020 09:09:02 +0800 you wrote: > If the phy enables power saving technology, the dwmac's software reset > needs more time to complete, enlarge dma reset timeout to 20us. > > Signed-off-by: Jisheng Zhang > --

Re: [PATCH v2] IPv4: RTM_GETROUTE: Add RTA_ENCAP to result

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 09:44:38 -0700 David Ahern wrote: > On 11/13/20 1:55 AM, Oliver Herms wrote: > > This patch adds an IPv4 routes encapsulation attribute > > to the result of netlink RTM_GETROUTE requests > > (e.g. ip route get 192.0.2.1). > > > > Signed-off-by: Oliver Herms > > Reviewed-by: D

[PATCH v3 net-next 3/3] net: dsa: tag_dsa: Use a consistent comment style

2020-11-14 Thread Tobias Waldekranz
Use a consistent style of one-line/multi-line comments throughout the file. Signed-off-by: Tobias Waldekranz --- net/dsa/tag_dsa.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/net/dsa/tag_dsa.c b/net/dsa/tag_dsa.c index 04646dd71c6c..112c7c6dd

Re: [PATCH net v1] lan743x: fix issue causing intermittent kernel log warnings

2020-11-14 Thread Sven Van Asbroeck
On Sat, Nov 14, 2020 at 6:19 PM Jakub Kicinski wrote: > > The _irq() cases look a little strange, are you planning a refactor in > net-next? I'd like to, but I don't understand skbs/queues well enough (yet).

[PATCH v3 net-next 1/3] net: dsa: tag_dsa: Allow forwarding of redirected IGMP traffic

2020-11-14 Thread Tobias Waldekranz
When receiving an IGMP/MLD frame with a TO_CPU tag, the switch has not performed any forwarding of it. This means that we should not set the offload_fwd_mark on the skb, in case a software bridge wants it forwarded. This is a port of: 1ed9ec9b08ad ("dsa: Allow forwarding of redirected IGMP traffi

Re: [PATCH net-next 04/12] ibmvnic: Introduce xmit_more support using batched subCRQ hcalls

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 13:09:59 -0600 Thomas Falcon wrote: > Include support for the xmit_more feature utilizing the > H_SEND_SUB_CRQ_INDIRECT hypervisor call which allows the sending > of multiple subordinate Command Response Queue descriptors in one > hypervisor call via a DMA-mapped buffer. This up

[PATCH v3 net-next 2/3] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

2020-11-14 Thread Tobias Waldekranz
Ethertype DSA encodes exactly the same information in the DSA tag as the non-ethertype variety. So refactor out the common parts and reuse them for both protocols. This is ensures tag parsing and generation is always consistent across all mv88e6xxx chips. While we are at it, explicitly deal with

[PATCH v3 net-next 0/3] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

2020-11-14 Thread Tobias Waldekranz
The first patch ports tag_edsa.c's handling of IGMP/MLD traps to tag_dsa.c. That way, we start from two logically equivalent taggers that are then merged. The second commit does the heavy lifting of actually fusing tag_dsa.c and tag_edsa.c. The final one just follows up with some clean up of existi

Re: [PATCH net-next 01/12] ibmvnic: Ensure that subCRQ entry reads are ordered

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 13:09:56 -0600 Thomas Falcon wrote: > Ensure that received Subordinate Command-Response Queue > entries are properly read in order by the driver. > > Signed-off-by: Thomas Falcon Are you sure this is not a bug fix?

Re: [PATCH net-next 02/12] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 13:09:57 -0600 Thomas Falcon wrote: > This patch introduces the infrastructure to send batched subordinate > Command Response Queue descriptors, which are used by the ibmvnic > driver to send TX frame and RX buffer descriptors. > > Signed-off-by: Thomas Falcon > @@ -2957,6 +2

Re: [PATCH net v1] lan743x: prevent entire kernel HANG on open, for some platforms

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 15:47:41 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > On arm imx6, when opening the chip's netdev, the whole Linux > kernel intermittently hangs/freezes. > > This is caused by a bug in the driver code which tests if pcie > interrupts are working correctly, usi

Re: [PATCH net v1] lan743x: fix issue causing intermittent kernel log warnings

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 13:59:49 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > When running this chip on arm imx6, we intermittently observe > the following kernel warning in the log, especially when the > system is under high load: > The driver is calling dev_kfree_skb() from code in

Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-14 Thread Russell Strong
[PATCH 2/2] DSCP in IPv4 routing TOS handling in ipv4 routing does not use all the bits in a DSCP value. This change introduces a sysctl "route_tos_as_dscp" control that, when enabled, widens masks to used the 6 DSCP bits in routing. This commit converts macros RT_TOS -> rt_tos IPTOS_RT_MASK ->

Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-14 Thread Russell Strong
[PATCH 1/2] DSCP in IPv4 routing TOS handling in ipv4 routing does not use all the bits in a DSCP value. This change introduces a sysctl "route_tos_as_dscp" control that, when enabled, widens masks to used the 6 DSCP bits in routing. This commit adds the sysctl Signed-off-by: Russell Strong --

Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-14 Thread Russell Strong
On Fri, 13 Nov 2020 10:02:25 +0100 Guillaume Nault wrote: > On Thu, Nov 12, 2020 at 07:36:56PM -0800, Stephen Hemminger wrote: > > On Fri, 13 Nov 2020 12:06:37 +1000 > > Russell Strong wrote: > > > > > diff --git a/include/uapi/linux/in_route.h > > > b/include/uapi/linux/in_route.h index 0cc2

[PATCH iproute2-next 2/7] bridge: link: Convert to use print_on_off()

2020-11-14 Thread Petr Machata
Instead of rolling a custom on-off printer, use the one added to utils.c. Signed-off-by: Petr Machata --- bridge/link.c | 56 ++- 1 file changed, 24 insertions(+), 32 deletions(-) diff --git a/bridge/link.c b/bridge/link.c index fa6eda849b32..d88c

[PATCH iproute2-next 5/7] ip: iplink_bridge_slave: Convert to use print_on_off()

2020-11-14 Thread Petr Machata
Instead of rolling a custom on-off printer, use the one added to utils.c. Note that _print_onoff() has an extra parameter for a JSON-specific flag name. However that argument is not used, and never was. Therefore when moving over to print_on_off(), drop this argument. Signed-off-by: Petr Machata

[PATCH iproute2-next 3/7] ip: iplink: Convert to use parse_on_off()

2020-11-14 Thread Petr Machata
Invoke parse_on_off() instead of rolling a custom function. Signed-off-by: Petr Machata --- ip/iplink.c | 47 +-- 1 file changed, 17 insertions(+), 30 deletions(-) diff --git a/ip/iplink.c b/ip/iplink.c index d6b766de1fcf..f5766c39507b 100644 --- a/ip

[PATCH iproute2-next 1/7] bridge: link: Port over to parse_on_off()

2020-11-14 Thread Petr Machata
Convert bridge/link.c from a custom on_off parser to the new global one. Signed-off-by: Petr Machata --- bridge/link.c | 79 --- 1 file changed, 37 insertions(+), 42 deletions(-) diff --git a/bridge/link.c b/bridge/link.c index 3bc7af209b8b..fa6ed

[PATCH iproute2-next 4/7] ip: iplink_bridge_slave: Port over to parse_on_off()

2020-11-14 Thread Petr Machata
Invoke parse_on_off() from bridge_slave_parse_on_off() instead of hand-rolling one. Exit on failure, because the invarg that was ivoked here before would. Signed-off-by: Petr Machata --- ip/iplink_bridge_slave.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/ip/

[PATCH iproute2-next 7/7] ip: iptuntap: Convert to use print_on_off()

2020-11-14 Thread Petr Machata
Instead of rolling a custom on-off printer, use the one added to utils.c. Signed-off-by: Petr Machata --- ip/iptuntap.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/ip/iptuntap.c b/ip/iptuntap.c index 82e384998b1c..e9cc7c0f5f70 100644 --- a/ip/iptuntap.

[PATCH iproute2-next 6/7] ip: ipnetconf: Convert to use print_on_off()

2020-11-14 Thread Petr Machata
Instead of rolling a custom on-off printer, use the one added to utils.c. Signed-off-by: Petr Machata --- ip/ipnetconf.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/ip/ipnetconf.c b/ip/ipnetconf.c index 0e946ca34b4a..bb0ebe12da93 100644 ---

[PATCH iproute2-next 0/7] Convert a number of use-cases to parse_on_off(), print_on_off()

2020-11-14 Thread Petr Machata
Two helpers, parse_on_off() and print_on_off(), have been recently added to lib/utils.c. Convert a number of instances of the same effective behavior to calls to these helpers. Petr Machata (7): bridge: link: Port over to parse_on_off() bridge: link: Convert to use print_on_off() ip: iplink:

Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-14 Thread Marcelo Ricardo Leitner
On Sat, Nov 14, 2020 at 10:05:39AM -0800, Cong Wang wrote: > On Wed, Nov 11, 2020 at 9:44 PM wrote: > > diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c > > index 9c79fb9..dff3c40 100644 > > --- a/net/sched/act_ct.c > > +++ b/net/sched/act_ct.c > > @@ -1541,8 +1541,14 @@ static int __init ct_i

Re: [PATCH v3 net-next 0/8] ionic updates

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 10:22:00 -0800 Shannon Nelson wrote: > These updates are a bit of code cleaning and a minor > bit of performance tweaking. > > v3: convert ionic_lif_quiesce() to void > v2: added void cast on call to ionic_lif_quiesce() > lowered batching threshold > added patch to flat

Re: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-14 Thread Arnd Bergmann
On Sat, Nov 14, 2020 at 4:14 PM Richard Cochran wrote: > > On Fri, Nov 13, 2020 at 05:21:43PM +0100, Arnd Bergmann wrote: > > I've prototyped a patch that I think makes this more sensible > > again: https://pastebin.com/AQ5nWS9e > > I like the behavior described in the text. > > Instead of this ..

Re: [PATCH net-next v2 00/13] mptcp: improve multiple xmit streams support

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 18:45:20 +0100 Paolo Abeni wrote: > This series improves MPTCP handling of multiple concurrent > xmit streams. Umpf, looks like it no longer applies after the net->net-next merge. Please respin.

Re: [PATCH net-next v2 01/13] tcp: factor out tcp_build_frag()

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 11:38:13 +0100 Paolo Abeni wrote: > > Is there a chance someone could look into adding annotations to socket > > locking? > > Annotating lock_sock_fast()/unlock_sock_fast() as they would > unconditionally acquire/release the socket spinlock removes the warning > related to fa

Re: [PATCH net-next] lib8390: Use eth_skb_pad()

2020-11-14 Thread Florian Fainelli
On 11/12/2020 8:31 AM, Armin Wolf wrote: > Use eth_skb_pad() instead of a custom padding solution > and replace associated variables with skb->* expressions. > > Signed-off-by: Armin Wolf > --- [snip] > @@ -407,8 +404,8 @@ static netdev_tx_t __ei_start_xmit(struct sk_buff *skb, > spin_

Re: [PATCH net-next] lib8390: Use eth_skb_pad()

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 17:31:34 +0100 Armin Wolf wrote: > Use eth_skb_pad() instead of a custom padding solution > and replace associated variables with skb->* expressions. These are two separate changes, please split them out to two patches.

[PATCH v3 net-next 0/3] add support sending RFC8335 PROBE

2020-11-14 Thread Andreas Roeseler
The popular utility ping has several severe limitations such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and the probed interfaces. RFC8335 attempts to solve these limitations by creating the new utility PROBE which is a spec

[PATCH v3 net-next 1/3] net: add support for sending RFC8335 PROBE

2020-11-14 Thread Andreas Roeseler
Modifying the ping_supported function to support probe message types allows the user to send probe requests through the existing framework for sending ping requests. Signed-off-by: Andreas Roeseler --- Changes since v1: - Switch to correct base tree Changes since v2: - Switch to net-next tree

[PATCH v3 net-next 2/3] icmp: define PROBE message types

2020-11-14 Thread Andreas Roeseler
The types of ICMP Extended Echo Request and ICMP Extended Echo Reply are defined in sections 2 and 3 of RFC8335. Signed-off-by: Andreas Roeseler --- Changes since v1: - Switch to correct base tree Changes since v2: - Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553 --- include

[PATCH v3 net-next 3/3] ICMPv6: define PROBE message types

2020-11-14 Thread Andreas Roeseler
The types of ICMPV6 Extended Echo Request and ICMPV6 Extended Echo Reply are defined in sections 2 and 3 of RFC8335. Signed-off-by: Andreas Roeseler --- Changes since v1: - Switch to correct base tree Changes since v2: - Switch to net-next tree 67c70b5eb2bf7d0496fcb62d308dc3096bc11553 --- inc

[PATCH net-next] r8169: improve rtl8169_start_xmit

2020-11-14 Thread Heiner Kallweit
Improve the following in rtl8169_start_xmit: - tp->cur_tx can be accessed in parallel by rtl_tx(), therefore annotate the race by using WRITE_ONCE - avoid checking stop_queue a second time by moving the doorbell check - netif_stop_queue() uses atomic operation set_bit() that includes a full mem

Re: [PATCH net 1/1] net: stmmac: Use rtnl_lock/unlock on netif_set_real_num_rx_queues() call

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 22:49:48 +0800 Wong Vee Khee wrote: > Fix an issue where dump stack is printed on suspend resume flow due to > netif_set_real_num_rx_queues() is not called with rtnl_lock held(). > > Fixes: 686cff3d7022 ("net: stmmac: Fix incorrect location to set > real_num_rx|tx_queues") > R

Re: [PATCH] net: macb: Fix passing zero to 'PTR_ERR'

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 22:49:36 +0800 YueHaibing wrote: > Check PTR_ERR with IS_ERR to fix this. > > Fixes: cd5afa91f078 ("net: macb: Add null check for PCLK and HCLK") > Signed-off-by: YueHaibing Looks like a cleanup PTR_ERR() should return 0 for NULL AFAICS. Applied to net-next, thanks!

Re: [PATCH net-next v2] net: linux/skbuff.h: combine SKB_EXTENSIONS + KCOV handling

2020-11-14 Thread Randy Dunlap
On 11/14/20 11:54 AM, Jakub Kicinski wrote: > On Sat, 14 Nov 2020 09:46:18 -0800 Randy Dunlap wrote: >> The previous Kconfig patch led to some other build errors as >> reported by the 0day bot and my own overnight build testing. >> >> These are all in when KCOV is enabled but >> SKB_EXTENSIONS is

Re: [PATCH] netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist()

2020-11-14 Thread Jakub Kicinski
On Sat, 14 Nov 2020 18:03:56 +1100 (AEDT) James Morris wrote: > > Static checking revealed that a previous fix to > > netlbl_unlabel_staticlist() leaves a stack variable uninitialized, > > this patches fixes that. > > > > Fixes: 866358ec331f ("netlabel: fix our progress tracking in > > netlbl_unl

Re: [PATCH] ipv6: remove unused function ipv6_skb_idev()

2020-11-14 Thread Jakub Kicinski
On Fri, 13 Nov 2020 11:36:49 -0700 Nathan Chancellor wrote: > On Fri, Nov 13, 2020 at 02:50:12PM +0100, Lukas Bulwahn wrote: > > Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the > > ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since > > then, ipv6_skb_idev()

Re: [PATCH v2 net-next 1/2] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

2020-11-14 Thread Tobias Waldekranz
On Sat Nov 14, 2020 at 5:44 PM CET, Andrew Lunn wrote: > > > > + * > > > > + * A 3-bit code is used to relay why a particular frame was sent to > > > > + * the CPU. We only use this to determine if the packet was mirrored > > > > + * or trapped, i.e. whether the packet has been forwarded by hardwar

Re: [PATCHv2 net] sctp: change to hold/put transport for proto_unreach_timer

2020-11-14 Thread Jakub Kicinski
On Sat, 14 Nov 2020 10:40:23 -0300 Marcelo Ricardo Leitner wrote: > On Sat, Nov 14, 2020 at 01:22:53PM +0800, Xin Long wrote: > > A call trace was found in Hangbin's Codenomicon testing with debug kernel: > > > ... > > > > So fix it by holding/putting transport instead for proto_unreach_timer >

[PATCH v4 net-next 13/13] octeontx2-af: Delete NIX_RXVLAN_ALLOC mailbox message

2020-11-14 Thread Naveen Mamindlapalli
From: Subbaraya Sundeep Since mailbox message for installing flows is in place, remove the RXVLAN_ALLOC mbox message which is redundant. Signed-off-by: Subbaraya Sundeep Signed-off-by: Sunil Goutham Signed-off-by: Naveen Mamindlapalli --- drivers/net/ethernet/marvell/octeontx2/af/mbox.h |

[PATCH v4 net-next 08/13] octeontx2-af: Modify nix_vtag_cfg mailbox to support TX VTAG entries

2020-11-14 Thread Naveen Mamindlapalli
From: Vamsi Attunuru This patch modifies the existing nix_vtag_config mailbox message to allocate and free TX VTAG entries as requested by a NIX PF. The TX VTAG entries are global resource that shared by all PFs and each entry specifies the size of VTAG to insert and the VTAG header data to inser

[PATCH v4 net-next 02/13] octeontx2-af: Verify MCAM entry channel and PF_FUNC

2020-11-14 Thread Naveen Mamindlapalli
From: Subbaraya Sundeep This patch adds support to verify the channel number sent by mailbox requester before writing MCAM entry for Ingress packets. Similarly for Egress packets, verifying the PF_FUNC sent by the mailbox user. Signed-off-by: Subbaraya Sundeep Signed-off-by: Kiran Kumar K Sign

[PATCH v4 net-next 04/13] octeontx2-af: Add mbox messages to install and delete MCAM rules

2020-11-14 Thread Naveen Mamindlapalli
From: Subbaraya Sundeep Added new mailbox messages to install and delete MCAM rules. These mailbox messages will be used for adding/deleting ethtool n-tuple filters by NIX PF. The installed MCAM rules are stored in a list that will be traversed later to delete the MCAM entries when the interface

[PATCH v4 net-next 05/13] octeontx2-pf: Add support for ethtool ntuple filters

2020-11-14 Thread Naveen Mamindlapalli
From: Subbaraya Sundeep This patch adds support for adding and deleting ethtool ntuple filters. The filters for ether, ipv4, ipv6, tcp, udp and sctp are supported. The mask is also supported. The supported actions are drop and direct to a queue. Additionally we support FLOW_EXT field vlan_tci and

Re: [PATCH net-next v2] net: linux/skbuff.h: combine SKB_EXTENSIONS + KCOV handling

2020-11-14 Thread Jakub Kicinski
On Sat, 14 Nov 2020 09:46:18 -0800 Randy Dunlap wrote: > The previous Kconfig patch led to some other build errors as > reported by the 0day bot and my own overnight build testing. > > These are all in when KCOV is enabled but > SKB_EXTENSIONS is not enabled, so fix those by combining those condi

[PATCH v4 net-next 00/13] Add ethtool ntuple filters support

2020-11-14 Thread Naveen Mamindlapalli
This patch series adds support for ethtool ntuple filters, unicast address filtering, VLAN offload and SR-IOV ndo handlers. All of the above features are based on the Admin Function(AF) driver support to install and delete the low level MCAM entries. Each MCAM entry is programmed with the packet fi

[PATCH v4 net-next 11/13] octeontx2-af: Handle PF-VF mac address changes

2020-11-14 Thread Naveen Mamindlapalli
From: Hariprasad Kelam This patch handles the VF mac address changes as given below. 1. mac addr configrued by VF will be retained until VF module unload. 2. mac addr configred by PF for VF will be retained until power cycle. 3. mac addr confgired by PF for its VF can't be overwritten

[PATCH v4 net-next 06/13] octeontx2-pf: Add support for unicast MAC address filtering

2020-11-14 Thread Naveen Mamindlapalli
From: Hariprasad Kelam Add unicast MAC address filtering support using install flow message. Total of 8 MCAM entries are allocated for adding unicast mac filtering rules. If the MCAM allocation fails, the unicast filtering support will not be advertised. Signed-off-by: Hariprasad Kelam Signed-o

[PATCH v4 net-next 01/13] octeontx2-af: Modify default KEX profile to extract TX packet fields

2020-11-14 Thread Naveen Mamindlapalli
From: Stanislaw Kardach The current default Key Extraction(KEX) profile can only use RX packet fields while generating the MCAM search key. The profile can't be used for matching TX packet fields. This patch modifies the default KEX profile to add support for extracting TX packet fields into MCAM

[PATCH v4 net-next 09/13] octeontx2-pf: Implement ingress/egress VLAN offload

2020-11-14 Thread Naveen Mamindlapalli
From: Hariprasad Kelam This patch implements egress VLAN offload by appending NIX_SEND_EXT_S header to NIX_SEND_HDR_S. The VLAN TCI information is specified in the NIX_SEND_EXT_S. The VLAN offload in the ingress path is implemented by configuring the NIX_RX_VTAG_ACTION_S to strip and capture the

[PATCH v4 net-next 10/13] octeontx2-pf: Add support for SR-IOV management functions

2020-11-14 Thread Naveen Mamindlapalli
This patch adds support for ndo_set_vf_mac, ndo_set_vf_vlan and ndo_get_vf_config handlers. The traffic redirection based on the VF mac address or vlan id is done by installing MCAM rules. Reserved RX_VTAG_TYPE7 in each NIXLF for VF VLAN which strips the VLAN tag from ingress VLAN traffic. The NIX

[PATCH v4 net-next 12/13] octeontx2-af: Add new mbox messages to retrieve MCAM entries

2020-11-14 Thread Naveen Mamindlapalli
This patch introduces new mailbox mesages to retrieve a given MCAM entry or base flow steering rule of a VF installed by its parent PF. This helps while updating the existing MCAM rules with out re-framing the whole mailbox request again. The INSTALL FLOW mailbox consumer can read-modify-write the

[PATCH v4 net-next 03/13] octeontx2-af: Generate key field bit mask from KEX profile

2020-11-14 Thread Naveen Mamindlapalli
From: Subbaraya Sundeep Key Extraction(KEX) profile decides how the packet metadata such as layer information and selected packet data bytes at each layer are placed in MCAM search key. This patch reads the configured KEX profile parameters to find out the bit position and bit mask for each field

[PATCH v4 net-next 07/13] octeontx2-af: Add debugfs entry to dump the MCAM rules

2020-11-14 Thread Naveen Mamindlapalli
From: Subbaraya Sundeep Add debugfs support to dump the MCAM rules installed using NPC_INSTALL_FLOW mbox message. Debugfs file can display mcam entry, counter if any, flow type and counter hits. Ethtool will dump the ntuple flows related to the PF only. The debugfs file gives systemwide view of

Re: [PATCH net] vsock: forward all packets to the host when no H2G is registered

2020-11-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 12 Nov 2020 14:38:37 +0100 you wrote: > Before commit c0cfa2d8a788 ("vsock: add multi-transports support"), > if a G2H transport was loaded (e.g. virtio transport), every packets > was forwarded to the host, regardless o

Re: [PATCH net] net: phy: smsc: add missed clk_disable_unprepare in smsc_phy_probe()

2020-11-14 Thread Florian Fainelli
On 11/14/2020 11:26 AM, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 19:23:59 +0800 Zhang Changzhong wrote: >> Add the missing clk_disable_unprepare() before return from >> smsc_phy_probe() in the error handling case. >> >> Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in suppo

Re: pull-request: bpf-next 2020-11-14

2020-11-14 Thread Jakub Kicinski
On Sat, 14 Nov 2020 03:08:19 +0100 Daniel Borkmann wrote: > 1) Add BTF generation for kernel modules and extend BTF infra in kernel >e.g. support for split BTF loading and validation, from Andrii Nakryiko. > > 2) Support for pointers beyond pkt_end to recognize LLVM generated patterns >on

Re: [PATCH v2 net] net: dsa: mv88e6xxx: Avoid VTU corruption on 6097

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 12:43:35 +0100 Tobias Waldekranz wrote: > As soon as you add the second port to a VLAN, all other port > membership configuration is overwritten with zeroes. The HW interprets > this as all ports being "unmodified members" of the VLAN. > > In the simple case when all ports belo

Re: [PATCH net] net: phy: smsc: add missed clk_disable_unprepare in smsc_phy_probe()

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 19:23:59 +0800 Zhang Changzhong wrote: > Add the missing clk_disable_unprepare() before return from > smsc_phy_probe() in the error handling case. > > Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support") > Reported-by: Hulk Robot > Signed-off-by: Zhang

Re: [PATCH net-next 3/3] net: ethernet: ti: am65-cpsw: enable broadcast/multicast rate limit support

2020-11-14 Thread Vladimir Oltean
On Sat, Nov 14, 2020 at 05:56:54AM +0200, Grygorii Strashko wrote: > This patch enables support for ingress broadcast(BC)/multicast(MC) rate > limiting > in TI AM65x CPSW driver (the corresponding ALE support was added in previous > patch) by implementing HW offload for simple tc-flower policer wi

  1   2   >