We always have to update the value of ret, otherwise the
error value may be the previous one.
Signed-off-by: Wang Qing
---
drivers/net/ethernet/ti/am65-cpts.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/am65-cpts.c
b/drivers/net/ethernet/ti/am6
Actually, withing should be within.
Signed-off-by: Wang Qing
---
drivers/net/usb/cdc_ncm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index e04f588..746353c
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_nc
On Thu, Nov 05, 2020 at 11:30:35PM -0800, Martin KaFai Lau wrote:
> [ ... ]
>
> > @@ -585,12 +571,11 @@ int _ipip6_set_tunnel(struct __sk_buff *skb)
> > struct bpf_tunnel_key key = {};
> > void *data = (void *)(long)skb->data;
> > struct iphdr *iph = data;
> v4 hdr here.
Ah, right, I
On 06.11.2020 02:14, Jakub Kicinski wrote:
> On Wed, 4 Nov 2020 15:25:24 +0100 Heiner Kallweit wrote:
>> @@ -1066,7 +1054,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb,
>> struct net_device *dev)
>> return NETDEV_TX_OK;
>>
>> drop:
>> -this_cpu_inc(tun->pcpu_stats->tx_droppe
By default, off xdp is implemented by actively calling netlink on the
command line or in the program. This is very inconvenient for apps based
on xdp. For example, an app based on xdp + xsk exits abnormally, but xdp
is still working, which may cause some exceptions. And xsk cannot be
automatically
Marek Behún
> Sent: Friday, November 6, 2020 2:40 PM
[...]
> Hi Hayes,
>
> just to be clear:
> Are you against defining these functions via macros?
> If so, I can simply rewrite this so that it does not use macros...
I would like the way which let me find the source of the
function easily. I don
VRF devices use an optimized direct path on output if a default qdisc
is involved, calling Netfilter hooks directly. This path, however, does
not consider Netfilter rules completing asynchronously, such as with
NFQUEUE. The Netfilter okfn() is called for asynchronously accepted
packets, but the VRF
On Tue, Nov 03, 2020 at 12:29:08PM +0800, Hangbin Liu wrote:
> In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6,
> ip6ip6 test") we added some bpf tunnel tests. In commit 933a741e3b82
> ("selftests/bpf: bpf tunnel test.") when we moved it to the current
> folder, we forgot to re
From: Kaixu Xia
Fix following warning from coccinelle:
./tools/lib/bpf/libbpf.c:1478:43-48: WARNING: conversion to bool not needed here
Signed-off-by: Kaixu Xia
---
tools/lib/bpf/libbpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bp
On Thu, Nov 05, 2020 at 04:36:57PM -0400, Jason Gunthorpe wrote:
> On Thu, Nov 05, 2020 at 12:31:52PM -0800, Saeed Mahameed wrote:
> > On Sun, 2020-11-01 at 22:15 +0200, Leon Romanovsky wrote:
> > > From: Leon Romanovsky
> > >
> > > Move mlx5_vdpa IFC header file to the general include folder, so
On Thu, Nov 05, 2020 at 05:09:48PM -0400, Jason Gunthorpe wrote:
> On Thu, Nov 05, 2020 at 12:59:20PM -0800, Saeed Mahameed wrote:
>
> > 2. you can always load a driver without its underlying device existed.
> > for example, you can load a pci device driver/module and it will load
> > and wait for
From: Menglong Dong
The initialization for 'err' with 0 is redundant and can be removed,
as it is updated by ip_send_skb and not used before that.
Signed-off-by: Menglong Dong
---
net/ipv4/udp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
On Thu, Nov 05, 2020 at 09:51:09PM -0800, Andrii Nakryiko wrote:
> Add kernel module listener that will load/validate and unload module BTF.
> Module BTFs gets ID generated for them, which makes it possible to iterate
> them with existing BTF iteration API. They are given their respective module's
From: Menglong Dong
The initialization for 'err' with '-EINVAL' is redundant and
can be removed, as it is updated soon and not used.
Signed-off-by: Menglong Dong
---
net/ipv4/udp_diag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/udp_diag.c b/net/ipv4/udp_diag.
From: Menglong Dong
The initialization for 'err' with '-ENOSYS' is redundant and
can be removed, as it is updated soon and not used.
Signed-off-by: Menglong Dong
---
net/ipv4/udp_offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp
From: Menglong Dong
The initialization for 'err' with '-EINVAL' is redundant and
can be removed, as it is updated soon.
Signed-off-by: Menglong Dong
---
net/ipv4/devinet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 123a6d3.
On Fri, 6 Nov 2020 03:01:22 +
Hayes Wang wrote:
> Vladimir Oltean
> > Sent: Thursday, November 5, 2020 6:57 PM
> > On Thu, Nov 05, 2020 at 10:54:18AM +0100, Marek Behún wrote:
> > > I thought that static inline functions are preferred to macros, since
> > > compiler warns better if they ar
On 04/11/2020 02:31, Saeed Mahameed wrote:
> On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote:
>> From: Guvenc Gulce
>>
>> Deliver SMCD device information via netlink based
>> diagnostic interface.
>>
>> Signed-off-by: Guvenc Gulce
>> Signed-off-by: Karsten Graul
>> ---
>> include/uapi/li
Alex Dewar wrote:
> The for loop checks whether cur_section is NULL on every iteration, but
> we know it can never be NULL as there is another check towards the
> bottom of the loop body. Refactor to avoid this unnecessary check.
>
> Also, increment the variable i inline for clarity
>
> Address
On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> There are some macros unused, they causes much gcc warnings. Let's
> remove them to tame gcc.
I believe these to be essentially poor warnings.
Aren't these warnings generated only when adding W=2 to the make
command line?
Perhaps it's better
On 03/11/2020 10:18, Allen Pais wrote:
> From: Allen Pais
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-off-by: Romain
On 2020-10-06 07:45, Martin Schiller wrote:
This fixes a regression for blocking connects introduced by commit
4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25
disconnect").
The x25->neighbour is already set to "NULL" by x25_disconnect() now,
while a blocking connect is waiting in
x2
On 2020-11-05 16:06, Arnd Bergmann wrote:
...
Adding Martin Schiller and Andrew Hendry, plus the linux-x25 mailing
list to Cc. When I last looked at the wan drivers, I think I concluded
that this should still be kept around, but I do not remember why.
OTOH if it was broken for a long time, that i
To tame gcc warning on it:
net/core/xdp.c:20:0: warning: macro "REG_STATE_NEW" is not used
[-Wunused-macros]
Signed-off-by: Alex Shi
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Alexei Starovoitov
Cc: Daniel Borkmann
Cc: Jesper Dangaard Brouer
Cc: John Fastabend
Cc: netdev@vger.kernel
There are some macros unused, they causes much gcc warnings. Let's
remove them to tame gcc.
net/dsa/tag_brcm.c:51:0: warning: macro "BRCM_EG_RC_SWITCH" is not used
[-Wunused-macros]
net/dsa/tag_brcm.c:53:0: warning: macro "BRCM_EG_RC_MIRROR" is not used
[-Wunused-macros]
net/dsa/tag_brcm.c:55:0: w
There some unused macros cause gcc complain:
net/l2tp/l2tp_core.c:73:0: warning: macro "L2TP_HDRFLAG_P" is not used
[-Wunused-macros]
net/l2tp/l2tp_core.c:80:0: warning: macro "L2TP_SLFLAG_S" is not used
[-Wunused-macros]
net/l2tp/l2tp_core.c:81:0: warning: macro "L2TP_SL_SEQ_MASK" is not used
[-W
On Thu, Nov 05, 2020 at 04:57:08PM -0800, Jakub Kicinski wrote:
> On Tue, 3 Nov 2020 18:23:53 +0100 Loic Poulain wrote:
> > This function can be used by client driver to determine whether it's
> > possible to queue new elements in a channel ring.
> >
> > Signed-off-by: Loic Poulain
> > Reviewed-
On Thu, Nov 5, 2020 at 7:18 AM Kevin Sheldrake
wrote:
>
> Resent due to some failure at my end. Apologies if it arrives twice.
>
> From 63e34d4106b4dd767f9bfce951f8a35f14b52072 Mon Sep 17 00:00:00 2001
> From: Kevin Sheldrake
> Date: Thu, 5 Nov 2020 12:18:53 +
> Subject: [PATCH] Update perf
On Wed, Nov 4, 2020 at 11:11 AM Nick Desaulniers
wrote:
>
> bpftrace parses the kernel headers and uses Clang under the hood. Remove
> the version check when __BPF_TRACING__ is defined (as bpftrace does) so
> that this tool can continue to parse kernel headers, even with older
> clang sources.
>
>
On Thu, Oct 29, 2020 at 1:38 PM Andrii Nakryiko
wrote:
>
> On Thu, Oct 29, 2020 at 1:16 PM Florian Lehner wrote:
> >
> > Currently key_size of hashtab is limited to MAX_BPF_STACK.
> > As the key of hashtab can also be a value from a per cpu map it can be
> > larger than MAX_BPF_STACK.
> >
> > The
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Wed, 4 Nov 2020 12:23:32 +0100 you wrote:
> Zero-fill element values for all other cpus than current, just as
> when not using prealloc. This is the only way the bpf program can
> ensure known initial values for all cpus ('onal
From: Min Li
Use div_s64 so that the neg_adj is not needed.
Signed-off-by: Min Li
Acked-by: Richard Cochran
---
drivers/ptp/ptp_idt82p33.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c
index 223bc11..c1c9
From: Min Li
Add idt82p33_adjphase() to support PHC write phase mode.
Changes since v1:
-Fix broken build
Changes since v2:
-Fix trailing space
Changes since v3:
-Improvements suggested by Jakub
Signed-off-by: Min Li
Acked-by: Richard Cochran
---
drivers/ptp/ptp_idt82p33.c | 217 +
From: Min Li
Refactor idt82p33_xfer and use i2c_master_send for write operation.
Because some I2C controllers are only working with single-burst write
transaction.
Changes since v1:
- Fix broken build.
Signed-off-by: Min Li
Acked-by: Richard Cochran
---
drivers/ptp/ptp_idt82p33.c | 47 +
On Thu, Nov 5, 2020 at 7:48 PM Andrii Nakryiko
wrote:
>
> On Thu, Nov 5, 2020 at 7:13 PM Alexei Starovoitov
> wrote:
> >
> > On Wed, Nov 04, 2020 at 08:51:38PM -0800, Andrii Nakryiko wrote:
> > >
> > > +config DEBUG_INFO_BTF_MODULES
> > > + bool "Generate BTF for kernel modules"
> > > + d
On Thu, Nov 5, 2020 at 7:13 PM Alexei Starovoitov
wrote:
>
> On Wed, Nov 04, 2020 at 08:51:38PM -0800, Andrii Nakryiko wrote:
> >
> > +config DEBUG_INFO_BTF_MODULES
> > + bool "Generate BTF for kernel modules"
> > + def_bool y
> > + depends on DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SP
On Thu, Nov 5, 2020 at 7:19 PM Alexei Starovoitov
wrote:
>
> On Wed, Nov 04, 2020 at 08:51:37PM -0800, Andrii Nakryiko wrote:
> > @@ -215,6 +215,8 @@ struct btf {
> > struct btf *base_btf;
> > u32 start_id; /* first type ID in this BTF (0 for base BTF) */
> > u32 start_str_off; /
On Wed, Nov 04, 2020 at 08:51:37PM -0800, Andrii Nakryiko wrote:
> @@ -215,6 +215,8 @@ struct btf {
> struct btf *base_btf;
> u32 start_id; /* first type ID in this BTF (0 for base BTF) */
> u32 start_str_off; /* first string offset (0 for base BTF) */
> + char name[MODULE_NAM
On Wed, Nov 04, 2020 at 08:51:38PM -0800, Andrii Nakryiko wrote:
>
> +config DEBUG_INFO_BTF_MODULES
> + bool "Generate BTF for kernel modules"
> + def_bool y
> + depends on DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SPLIT_BTF
Does it need to be a new config ?
Can the build ran pahole if
Vladimir Oltean
> Sent: Thursday, November 5, 2020 6:57 PM
> On Thu, Nov 05, 2020 at 10:54:18AM +0100, Marek Behún wrote:
> > I thought that static inline functions are preferred to macros, since
> > compiler warns better if they are used incorrectly...
>
> Citation needed. Also, how do static in
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Thu, 5 Nov 2020 11:51:09 -0800 you wrote:
> Fix build error when BPF_SYSCALL is not set/enabled but BPF_PRELOAD is
> by making BPF_PRELOAD depend on BPF_SYSCALL.
>
> ERROR: modpost: "bpf_preload_ops" [kernel/bpf/preload/bpf_pr
From: Kaixu Xia
The '!=' expression itself is bool, no need to convert it to bool.
Fix the following coccicheck warning:
./drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1477:34-39: WARNING:
conversion to bool not needed here
Reported-by: Tosk Robot
Signed-off-by: Kaixu Xia
---
drivers/net
Hello:
This series was applied to bpf/bpf-next.git (refs/heads/master):
On Wed, 4 Nov 2020 20:33:50 -0800 you wrote:
> This patch set adds support for generating and deduplicating split BTF. This
> is an enhancement to the BTF, which allows to designate one BTF as the "base
> BTF" (e.g., vmlinux
On Thu, 5 Nov 2020 12:12:30 -0800 Saeed Mahameed wrote:
> This series makes some updates to mlx5 software steering.
> and some other misc trivial changes.
>
> v1->v2:
>- use %zu for size_t printk in patch 9.
>
> For more information please see tag log below.
>
> For the DR memory buddy alloc
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Thu, 5 Nov 2020 11:52:30 + you wrote:
> My earlier patch to reject non-zero arguments to flow dissector attach
> broke attaching via bpftool. Instead of 0 it uses -1 for target_fd.
> Fix this by passing a zero argument when
On Tue, 3 Nov 2020 18:50:38 +1000 Pavana Sharma wrote:
> The Marvell 88E6393X device is a single-chip integration of a 11-port
> Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers
> and three 10-Gigabit interfaces.
>
> This patch adds functionalities specific to mv88e6393x
From: Menglong Dong
When udp_memory_allocated is at the limit, __udp_enqueue_schedule_skb
will return a -ENOBUFS, and skb will be dropped in __udp_queue_rcv_skb
without any counters being done. It's hard to find out what happened
once this happen.
So we introduce a UDP_MIB_MEMERRORS to do this j
On Tue, 3 Nov 2020 18:49:02 +1000 Pavana Sharma wrote:
> Add 5gbase-r PHY interface mode.
>
> Signed-off-by: Pavana Sharma
Please always CC device tree maintainers and list on patches which
touch bindings. Even if there is no need for review Rob has a bot
which will catch any formatting errors.
On Tue, 3 Nov 2020 18:50:02 +1000 Pavana Sharma wrote:
> Returning 0 is no more an error case with MV88E6393 family
> which has serdes lane numbers 0, 9 or 10.
> So with this change .serdes_get_lane will return lane number
> or error (-ENODEV).
>
> Signed-off-by: Pavana Sharma
> mv88e6xxx
On Wed, 4 Nov 2020 19:22:13 -0500 min.li...@renesas.com wrote:
> From: Min Li
>
> Add idt82p33_adjphase() to support PHC write phase mode.
>
> Changes since v1:
> -Fix broken build
>
> Changes since v2:
> -Fix trailing space
>
> Signed-off-by: Min Li
>
Please drop the empty line between tag
On Wed, 4 Nov 2020 15:25:24 +0100 Heiner Kallweit wrote:
> @@ -1066,7 +1054,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb,
> struct net_device *dev)
> return NETDEV_TX_OK;
>
> drop:
> - this_cpu_inc(tun->pcpu_stats->tx_dropped);
> + dev->stats.tx_dropped++;
> skb_
On Wed, 4 Nov 2020 10:19:22 +0800 Hayes Wang wrote:
> Support ECM mode based on cdc_ether with relative mii functions,
> when CONFIG_USB_RTL8152 is not set, or the device is not supported
> by r8152 driver.
>
> Both r8152 and r8153_ecm would check the return value of
> rtl8152_get_version() in por
On Tue, 3 Nov 2020 18:23:53 +0100 Loic Poulain wrote:
> This function can be used by client driver to determine whether it's
> possible to queue new elements in a channel ring.
>
> Signed-off-by: Loic Poulain
> Reviewed-by: Manivannan Sadhasivam
Applied.
On Tue, 3 Nov 2020 18:23:54 +0100 Loic Poulain wrote:
> This patch adds a new network driver implementing MHI transport for
> network packets. Packets can be in any format, though QMAP (rmnet)
> is the usual protocol (flow control + PDN mux).
>
> It support two MHI devices, IP_HW0 which is, the p
On Thu, Nov 05, 2020 at 09:02:15AM -0700, David Ahern wrote:
> On 11/5/20 8:57 AM, Toke Høiland-Jørgensen wrote:
> > I guess we could split it further into lib/bpf_{libbpf,legacy,glue}.c
> > and have the two former ones be completely devoid of ifdefs and
> > conditionally included based on whether
On Tue, 3 Nov 2020 14:48:22 +0530 Allen Pais wrote:
> From: Allen Pais
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-o
On Tue, 3 Nov 2020 14:48:23 +0530 Allen Pais wrote:
> From: Allen Pais
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-o
On Tue, 3 Nov 2020 14:48:20 +0530 Allen Pais wrote:
> From: Allen Pais
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-o
On Thu, Nov 05, 2020 at 08:25:12AM -0700, David Ahern wrote:
> > Sorry, when trying to rename the functions. I just found another issue.
> > Even we fix the conflicts right now. What if libbpf add new functions
> > and we got another conflict in future? There are too much bpf functions
> > in bpf_l
On Sun, 1 Nov 2020 14:50:55 +0200 Ioana Ciornei wrote:
> From: Ioana Ciornei
>
> This patch set aims to actually add support for shared interrupts in
> phylib and not only for multi-PHY devices. While we are at it,
> streamline the interrupt handling in phylib.
Applied, thank you!
On Thu, 05 Nov 2020 15:52:32 -0800 Saeed Mahameed wrote:
> On Thu, 2020-11-05 at 12:42 -0800, Jakub Kicinski wrote:
> > On Thu, 05 Nov 2020 11:23:54 -0800 Saeed Mahameed wrote:
> > > If you report an error without recovering, devlink health will
> > > report a
> > > bad device state
> > >
> > >
On 11/5/20 4:57 PM, Andrea Mayer wrote:
> I spent some time figuring out what happened with this patch. It seems that
> the
> patchset was not applied by the kernel test robot in the correct order. In
> particular, patch 3 is missing from this build attempt.
>
> I applied one patch after another
We should be using the multicast sync routines for the multicast
filters. Also, let's just flatten the logic a bit and pull
the small unicast routine back into ionic_set_rx_mode().
Fixes: 1800eee16676 ("net: ionic: Replace in_interrupt() usage.")
Signed-off-by: Shannon Nelson
---
.../net/ethern
Instead of having two different ways of expressing the same
sleepability concept, using opposite logic, we can rework the
from_ndo to can_sleep for a more consistent usage.
Fixes: 1800eee16676 ("net: ionic: Replace in_interrupt() usage.")
Signed-off-by: Shannon Nelson
---
.../net/ethernet/pensan
The _ionic_lif_rx_mode() is only used once and really doesn't
need to be broken out.
Signed-off-by: Shannon Nelson
---
.../net/ethernet/pensando/ionic/ionic_lif.c | 38 ---
1 file changed, 16 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic
With a few more uses of true and false in function calls, we
need to give them some useful names so we can tell from the
calling point what we're doing.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_dev.c | 2 +-
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 16
Change the order of operations in the link_up handling to be
sure that the queues are up and ready before we announce that
the link is up.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --
We don't need to refill the rx descriptors on every napi
if only a few were handled. Waiting until we can batch up
a few together will save us a few Rx cycles.
Signed-off-by: Shannon Nelson
---
.../net/ethernet/pensando/ionic/ionic_dev.h| 4 +++-
.../net/ethernet/pensando/ionic/ionic_txrx.
These updates are a bit of code cleaning and a minor
bit of performance tweaking.
v2: added void cast on call to ionic_lif_quiesce()
lowered batching threshold
added patch to flatten calls to ionic_lif_rx_mode
added patch to change from_ndo to can_sleep
Shannon Nelson (8):
ionic: st
After the queues are stopped, expressly quiesce the lif.
This assures that even if the queues were in an odd state,
the firmware will close up everything cleanly.
Signed-off-by: Shannon Nelson
---
.../net/ethernet/pensando/ionic/ionic_lif.c | 24 +++
1 file changed, 24 insertio
Request a link check as soon as the netdev is registered rather
than waiting for the watchdog to go off in order to get the
interface operational a little more quickly.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 ++
1 file changed, 2 insertions(+)
diff
Hi all,
On Wed, 4 Nov 2020 04:00:10 +0800
kernel test robot wrote:
> Hi Andrea,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on ipvs/master]
> [also build test WARNING on linus/master v5.10-rc2 next-20201103]
> [If your patch is applied to the wrong g
On Thu, 2020-11-05 at 12:42 -0800, Jakub Kicinski wrote:
> On Thu, 05 Nov 2020 11:23:54 -0800 Saeed Mahameed wrote:
> > If you report an error without recovering, devlink health will
> > report a
> > bad device state
> >
> > $ ./devlink health
> >pci/0002:01:00.0:
> > reporter npa
> >
> -Original Message-
> From: Dan Williams
> Sent: Thursday, November 5, 2020 2:00 PM
> To: Ertman, David M
> Cc: alsa-de...@alsa-project.org; Takashi Iwai ; Mark Brown
> ; linux-rdma ; Jason
> Gunthorpe ; Doug Ledford ;
> Netdev ; David Miller ;
> Jakub Kicinski ; Greg KH ;
> Ranjani Srid
On Thu, 5 Nov 2020 14:41:12 -0800 Andrii Nakryiko wrote:
> On Thu, Nov 5, 2020 at 1:53 PM Jakub Kicinski wrote:
> > On Thu, 5 Nov 2020 13:22:12 -0800 Andrii Nakryiko wrote:
> > > Should we just drop check_verifier_log() checks?
> >
> > Drivers only print error messages when something goes wron
On Wed, 4 Nov 2020 16:48:57 +0100 Andrew Lunn wrote:
> - buf = (char*)((u32)skb->data & ~0x3);
> - len = (skb->len + 3 + ((u32)skb->data & 3)) & ~0x3;
> - cmdA = (((u32)skb->data & 0x3) << 16) |
> + offset = (unsigned long)skb->data & 3;
> + buf = skb->data - offset;
> + le
On Thu, Nov 5, 2020 at 12:40 PM Arnd Bergmann wrote:
>
> > I think this driver never worked. Looking at the original code in
> > Linux 2.1.31, it already has the problems I fixed in commit
> > 8fdcabeac398.
> >
> > I guess when people (or bots) say they "tested", they have not
> > necessarily used
On Thu, Nov 5, 2020 at 1:53 PM Jakub Kicinski wrote:
>
> On Thu, 5 Nov 2020 13:22:12 -0800 Andrii Nakryiko wrote:
> > On Thu, Nov 5, 2020 at 8:02 AM Jiri Benc wrote:
> > > On Thu, 23 Apr 2020 12:58:50 -0700, Andrii Nakryiko wrote:
> > > > To make BPF verifier verbose log more releavant and easier
On Wed, 4 Nov 2020 16:48:52 +0100 Andrew Lunn wrote:
> drivers/net/ethernet/smsc/smc91x.c:706:51: warning: variable ‘pkt_len’ set
> but not used [-Wunused-but-set-variable]
> 706 | unsigned int saved_packet, packet_no, tx_status, pkt_len;
>
> Add a new macro for getting fields out of the head
From: Xie He
> Sent: 05 November 2020 19:35
>
> On Thu, Nov 5, 2020 at 1:10 AM David Laight wrote:
> >
> > > This driver transports LAPB (X.25 link layer) frames over TTY links.
> >
> > I don't remember any requests to run LAPB over anything other
> > than synchronous links when I was writing LAP
On Thu, 5 Nov 2020 00:49:09 -0300 Marcelo Ricardo Leitner wrote:
> On Wed, Nov 04, 2020 at 02:55:32PM +0800, Xin Long wrote:
> > inet(6)_skb_parm was removed from sctp_input_cb by Commit a1dd2cf2f1ae
> > ("sctp: allow changing transport encap_port by peer packets"), as it
> > thought sctp_input_cb-
On Tue, 03 Nov 2020 16:15:33 +0100, Łukasz Stelmach wrote:
> Add bindings for AX88796C SPI Ethernet Adapter.
>
> Signed-off-by: Łukasz Stelmach
> ---
> .../bindings/net/asix,ax88796c.yaml | 73 +++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/d
Hello,
I am looking at an arm32 KernelAddressSanitizer report[1] and trying to make
sense of it.
According to the report, KASAN chokes on the second line:
rt = skb_rtable(skb);
if (rt->rt_type == RTN_MULTICAST) { /* rt shouldn't have been
dereferenced here */
The log itself do
On Thu, 5 Nov 2020 18:41:33 +0800 we...@ucloud.cn wrote:
> From: wenxu
>
> Currently kernel tc subsystem can do conntrack in act_ct. But when several
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will defrag the packets to a big one. But the last action will redire
On Tue, 3 Nov 2020 08:10:53 +0100 Kurt Kanzenbach wrote:
> this series adds a DSA driver for the Hirschmann Hellcreek TSN switch
> IP. Characteristics of that IP:
>
> * Full duplex Ethernet interface at 100/1000 Mbps on three ports
> * IEEE 802.1Q-compliant Ethernet Switch
> * IEEE 802.1Qbv Ti
On Thu, 5 Nov 2020 02:16:11 -0500 menglong8.d...@gmail.com wrote:
> From: Menglong Dong
>
> When udp_memory_allocated is at the limit, __udp_enqueue_schedule_skb
> will return a -ENOBUFS, and skb will be dropped in __udp_queue_rcv_skb
> without any counters being done. It's hard to find out what
On Thu, Nov 5, 2020 at 11:28 AM Ertman, David M
wrote:
[..]
> > > Each auxiliary_device represents a part of its parent
> > > +functionality. The generic behavior can be extended and specialized as
> > needed
> > > +by encapsulating an auxiliary_device within other domain-specific
> > structures a
On Thu, 5 Nov 2020 13:22:12 -0800 Andrii Nakryiko wrote:
> On Thu, Nov 5, 2020 at 8:02 AM Jiri Benc wrote:
> > On Thu, 23 Apr 2020 12:58:50 -0700, Andrii Nakryiko wrote:
> > > To make BPF verifier verbose log more releavant and easier to use to debug
> > > verification failures, "pop" parts of l
Similar to commit fda55eca5a33f
("net: introduce skb_transport_header_was_set()"), avoid resetting
transport offsets that were already set by GRO layer. This not only
mirrors the behavior of __netif_receive_skb_core(), but also makes
sense when it comes to UDP GSO fraglists forwarding: transport of
On Thu, Nov 5, 2020 at 8:02 AM Jiri Benc wrote:
>
> On Thu, 23 Apr 2020 12:58:50 -0700, Andrii Nakryiko wrote:
> > To make BPF verifier verbose log more releavant and easier to use to debug
> > verification failures, "pop" parts of log that were successfully verified.
> > This has effect of leavin
On Thu, Nov 05, 2020 at 12:59:20PM -0800, Saeed Mahameed wrote:
> 2. you can always load a driver without its underlying device existed.
> for example, you can load a pci device driver/module and it will load
> and wait for pci devices to pop up, the subsysetem infrastructure will
> match between
On Thu, Nov 5, 2020 at 6:05 AM Jamal Hadi Salim wrote:
>
> On 2020-11-04 10:19 p.m., David Ahern wrote:
>
> [..]
> >
> > User experience keeps getting brought up, but I also keep reading the
> > stance that BPF users can not expect a consistent experience unless they
> > are constantly chasing lat
Leon Romanovsky writes:
> On Tue, Nov 03, 2020 at 10:01:32PM +0100, Petr Machata wrote:
>>
>> Leon Romanovsky writes:
>>
>> > On Tue, Nov 03, 2020 at 12:05:20AM +0100, Petr Machata wrote:
>> >>
>> >> Leon Romanovsky writes:
>> >>
>> >> > On Sun, Nov 01, 2020 at 04:55:42PM -0700, David Ahern w
On Sun, 2020-11-01 at 22:15 +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> Create auxiliary devices under new virtual bus. This will replace
> the custom-made mlx5 ->add()/->remove() interfaces and next patches
> will fill the missing callback and remove the old interface logic.
>
> T
On Wed, Nov 4, 2020 at 7:48 PM David Ahern wrote:
>
> On 11/4/20 1:43 PM, Andrii Nakryiko wrote:
> >
> > What users writing BPF programs can expect from iproute2 in terms of
> > available BPF features is what matters. And by not enforcing a
> > specific minimal libbpf version, iproute2 version doe
> -Original Message-
> From: Leon Romanovsky
> Sent: Thursday, November 5, 2020 11:35 AM
> To: Ertman, David M
> Cc: Williams, Dan J ; alsa-de...@alsa-project.org;
> Takashi Iwai ; Mark Brown ; linux-
> rdma ; Jason Gunthorpe ;
> Doug Ledford ; Netdev ;
> David Miller ; Jakub Kicinski ;
>
On Wed, Nov 4, 2020 at 7:19 PM David Ahern wrote:
>
> On 11/4/20 3:21 AM, Daniel Borkmann wrote:
> >
> >> Then libbpf release process can incorporate proper testing of libbpf
> >> and iproute2 combination.
> >> Or iproute2 should stay as-is with obsolete bpf support.
> >>
> >> Few years from now t
On Thu, 05 Nov 2020 11:23:54 -0800 Saeed Mahameed wrote:
> If you report an error without recovering, devlink health will report a
> bad device state
>
> $ ./devlink health
>pci/0002:01:00.0:
> reporter npa
>state error error 1 recover 0
Actually, the counter in the driver is unn
On Thu, Nov 5, 2020 at 9:06 PM Xie He wrote:
>
> On Thu, Nov 5, 2020 at 7:07 AM Arnd Bergmann wrote:
> >
> > Adding Martin Schiller and Andrew Hendry, plus the linux-x25 mailing
> > list to Cc.
>
> The linux-x25 mail list has stopped working for a long time.
>
> > When I last looked at the wan dr
On 05/11/2020 at 16:48, Russell King - ARM Linux admin wrote:
On Thu, Nov 05, 2020 at 04:22:18PM +0100, Nicolas Ferre wrote:
On 05/11/2020 at 15:37, Parshuram Thombare wrote:
This patch fixes NULL pointer dereference due to NULL pcs_config
in pcs_ops.
Fixes: e4e143e26ce8 ("net: macb: add suppo
1 - 100 of 301 matches
Mail list logo
