Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

2020-10-13 Thread Michael S. Tsirkin
On Tue, Oct 13, 2020 at 04:42:59PM -0700, si-wei liu wrote: > > On 10/9/2020 7:27 PM, Jason Wang wrote: > > > > On 2020/10/3 下午1:02, Si-Wei Liu wrote: > > > Pinned pages are not properly accounted particularly when > > > mapping error occurs on IOTLB update. Clean up dangling > > > pinned pages f

[PATCH] net: mscc: ocelot: Allow using without PCI on t1040 SoC

2020-10-13 Thread Maxim Kochetkov
There is no need to select FSL_ENETC_MDIO on t1040 SoC (ppc). Signed-off-by: Maxim Kochetkov --- drivers/net/dsa/ocelot/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig index 2d23ccef7d0e..307331e7783c

[PATCH] [PATCH] [v3] wireless: Initial driver submission for pureLiFi STA devices

2020-10-13 Thread Srinivasan Raju
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices. This driver implementation has been based on the zd1211rw driver. Driver is based on 802.11 softMAC Architecture and uses native 802.11 for configuration and management The driver is compiled and tested in ARM,

[PATCH 0/1] Fix Aspeed ast2600 MAC TX hang

2020-10-13 Thread Dylan Hung
This patch fixes the TX hang issue on Aspeed AST2600. Two HW arbitration features are added onto ast2600, but these features will cause MAC TX to hang when handling scatter-gather DMA. These two problematic features can be disabled by setting MAC register 0x58 bit28 and bit27. Dylan Hung (1): n

[PATCH 1/1] net: ftgmac100: Fix Aspeed ast2600 TX hang issue

2020-10-13 Thread Dylan Hung
The new HW arbitration feature on Aspeed ast2600 will cause MAC TX to hang when handling scatter-gather DMA. Disable the problematic feature by setting MAC register 0x58 bit28 and bit27. Signed-off-by: Dylan Hung --- drivers/net/ethernet/faraday/ftgmac100.c | 5 + drivers/net/ethernet/farad

Re: [PATCH ipsec] xfrm: interface: fix the priorities for ipip and ipv6 tunnels

2020-10-13 Thread Steffen Klassert
On Tue, Oct 13, 2020 at 02:41:18PM +0200, Nicolas Dichtel wrote: > Le 13/10/2020 à 11:28, Steffen Klassert a écrit : > > On Thu, Oct 08, 2020 at 04:13:24PM +0800, Xin Long wrote: > >> As Nicolas noticed in his case, when xfrm_interface module is installed > >> the standard IP tunnels will break in

Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats

2020-10-13 Thread Leon Romanovsky
On Tue, Oct 13, 2020 at 05:39:51PM -0700, Jakub Kicinski wrote: > On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote: > > In several places the same code is used to populate rtnl_link_stats64 > > fields with data from pcpu_sw_netstats. Therefore factor out this code > > to a new function dev_

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Mike Rapoport
On Tue, Oct 13, 2020 at 08:21:13AM -0700, Randy Dunlap wrote: > On 10/13/20 8:12 AM, Mike Rapoport wrote: > > On Tue, Oct 13, 2020 at 07:43:59AM -0700, Randy Dunlap wrote: > >> On 10/13/20 1:09 AM, Mike Rapoport wrote: > >>> On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: > On Mon

[PATCH 1/1] net: dsa: seville: fix buffer size of the queue system

2020-10-13 Thread Maxim Kochetkov
The VSC9953 Seville switch has 2 megabits of buffer split into 4360 words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabytes. 2 megabytes is (2048 / 8) * 1024 = 256 * 1024. Signed-off-by: Maxim Kochetkov Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system

[PATCH bpf-next] selftests/bpf: fix compilation error in progs/profiler.inc.h

2020-10-13 Thread Song Liu
Fix the following error when compiling selftests/bpf progs/profiler.inc.h:246:5: error: redefinition of 'pids_cgrp_id' as different kind of symbol pids_cgrp_id is used in cgroup code, and included in vmlinux.h. Fix the error by renaming pids_cgrp_id as pids_cgroup_id. Fixes: 03d4d13fab3f ("self

Re: [PATCH net v2] net: fix pos incrementment in ipv6_route_seq_next

2020-10-13 Thread Vasily Averin
On 10/13/20 9:31 PM, Yonghong Song wrote: > Commit 4fc427e05158 ("ipv6_route_seq_next should increase position index") > tried to fix the issue where seq_file pos is not increased > if a NULL element is returned with seq_ops->next(). See bug > https://bugzilla.kernel.org/show_bug.cgi?id=206283 >

iwlwifi: spaces in procfs filenames ?

2020-10-13 Thread Joe Perches
commit 64fa3aff89785b5a924ce3934f6595c35b4dffee Author: Sharon Dvir Date: Wed Aug 17 15:35:09 2016 +0300 iwlwifi: pcie: give a meaningful name to interrupt request perhaps unintentionally for file: drivers/net/wireless/intel/iwlwifi/pcie/internal.h in function static inline const char *qu

Re: [PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

2020-10-13 Thread Jakub Kicinski
On Wed, 14 Oct 2020 05:06:30 +0200 Willy Tarreau wrote: > > LGTM. There's always a chance that this will make other > > designs explode, but short of someone from Cadence giving > > us a timely review we have only one way to find that out.. :) > > Not that much in fact, given that the at91ethe

Re: [PATCH 1/4] selftests: netfilter: extend nfqueue test case

2020-10-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Wed, 14 Oct 2020 01:45:56 +0200 you wrote: > From: Florian Westphal > > add a test with re-queueing: usespace doesn't pass accept verdict, > but tells to re-queue to another nf_queue instance. > > Also, make the second nf

Re: [PATCH 0/4] Netfilter fixes for net

2020-10-13 Thread Jakub Kicinski
On Wed, 14 Oct 2020 01:45:55 +0200 Pablo Neira Ayuso wrote: > Hi, > > The following patchset contains Netfilter fixes for net: > > 1) Extend nf_queue selftest to cover re-queueing, non-gso mode and >delayed queueing, from Florian Westphal. > > 2) Clear skb->tstamp in IPVS forwarding path, fr

Re: [PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

2020-10-13 Thread Willy Tarreau
On Tue, Oct 13, 2020 at 05:03:58PM -0700, Jakub Kicinski wrote: > On Sun, 11 Oct 2020 11:09:41 +0200 Willy Tarreau wrote: > > while running some tests on my Breadbee board, I noticed poor network > > Tx performance. I had a look at the driver (macb, at91ether variant) > > and noticed that at91ether

Re: [pull request][net-next 0/4] mlx5 updates 2020-10-12

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 15:41:48 -0700 Saeed Mahameed wrote: > Hi Jakub, > > This small series add xfrm IPSec TX offload support to mlx5 driver. > > Please pull and let me know if there is any problem. Pulled, thanks!

Re: [net-next v2 0/2][pull request] 40GbE Intel Wired LAN Driver Updates 2020-10-12

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 11:13:44 -0700 Tony Nguyen wrote: > This series contains updates to i40e and e1000 drivers. > > Jaroslaw adds support for changing FEC on i40e if the firmware supports it. > > Jesse fixes a kbuild-bot warning regarding ternary operator on e1000. > > v2: Return -EOPNOTSUPP in

RE: [PATCH] rtw88: fix fw_fifo_addr check

2020-10-13 Thread Andy Huang
> On Sun, Oct 11, 2020 at 08:54:38AM -0700, t...@redhat.com wrote: > > From: Tom Rix > > > > The clang build reports this warning > > > > fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' > > will always evaluate to 'true' > > if (!rtwdev->chip->fw_fifo_addr) { > > >

Re: [Patch net v3] ip_gre: set dev->hard_header_len and dev->needed_headroom properly

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 16:17:21 -0700 Cong Wang wrote: > GRE tunnel has its own header_ops, ipgre_header_ops, and sets it > conditionally. When it is set, it assumes the outer IP header is > already created before ipgre_xmit(). > > This is not true when we send packets through a raw packet socket, >

Re: [PATCH 3/3] timekeeping: remove arch_gettimeoffset

2020-10-13 Thread Thomas Gleixner
On Thu, Oct 08 2020 at 17:46, Arnd Bergmann wrote: > With Arm EBSA110 gone, nothing uses it any more, so the corresponding > code and the Kconfig option can be removed. Yay! It only took 11+ years to get rid of that. Feel free to route it through your tree. Acked-by: Thomas Gleixner

Re: [PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 10:00:11 +0200 Heiner Kallweit wrote: > In several places the same code is used to populate rtnl_link_stats64 > fields with data from pcpu_sw_netstats. Therefore factor out this code > to a new function dev_fetch_sw_netstats(). > > v2: > - constify argument netstats > - don't i

Re: [PATCH net-next V2] cxgb4/ch_ipsec: Replace the module name to ch_ipsec from chcr

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 12:22:31 +0530 Ayush Sawal wrote: > This patch changes the module name to "ch_ipsec" and prepends > "ch_ipsec" string instead of "chcr" in all debug messages and function names. > > V1->V2: > -Removed inline keyword from functions. > -Removed CH_IPSEC prefix from pr_debug. > -U

Re: [PATCH net-next v3] virtio-net: ethtool configurable RXCSUM

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 09:58:20 +0800 xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST_OFFLOA

Re: [PATCH] net/af_unix: Remove unused old_pid variable

2020-10-13 Thread Jakub Kicinski
On Sun, 11 Oct 2020 18:35:27 +0300 Or Cohen wrote: > Commit 109f6e39fa07c48f5801 ("af_unix: Allow SO_PEERCRED > to work across namespaces.") introduced the old_pid variable > in unix_listen, but it's never used. > Remove the declaration and the call to put_pid. > > Signed-off-by: Or Cohen Applie

Re: [PATCH net v2 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 22:10:31 -0700 Deepa Dinamani wrote: > > On Mon, Oct 12, 2020 at 5:36 AM Christian Eggers wrote: > > > v2: > > > - > > > - integrated proposal from Willem de Bruijn > > > - added Reviewed-by: from Willem and Deepa > > You may add my > Acked-by: Deepa Dinamani Applied

Re: [PATCH v2 bpf-next 3/4] selftests/bpf: Add profiler test

2020-10-13 Thread Song Liu
On Tue, Oct 13, 2020 at 12:57 PM Jiri Olsa wrote: > > On Thu, Oct 08, 2020 at 06:12:39PM -0700, Alexei Starovoitov wrote: > > SNIP > > > + > > +#ifdef UNROLL > > +#pragma unroll > > +#endif > > + for (int i = 0; i < MAX_CGROUPS_PATH_DEPTH; i++) { > > + filepart_length = > > +

Re: [PATCH 0/5] net: use semicolons rather than commas to separate statements

2020-10-13 Thread Jakub Kicinski
On Sun, 11 Oct 2020 12:34:53 +0200 Julia Lawall wrote: > These patches replace commas by semicolons. Commas introduce > unnecessary variability in the code structure and are hard to see. > This was done using the Coccinelle semantic patch > (http://coccinelle.lip6.fr/) shown below. Applied 3-5 to

Re: [PATCH net-next] net: mscc: ocelot: remove duplicate ocelot_port_dev_check

2020-10-13 Thread Jakub Kicinski
On Sun, 11 Oct 2020 12:20:41 +0300 Vladimir Oltean wrote: > A helper for checking whether a net_device belongs to mscc_ocelot > already existed and did not need to be rewritten. Use it. > > Fixes: 319e4dd11a20 ("net: mscc: ocelot: introduce conversion helpers between > port and netdev") > Signed-

Re: [PATCH nf v2] netfilter: conntrack: connection timeout after re-register

2020-10-13 Thread Pablo Neira Ayuso
On Fri, Oct 09, 2020 at 10:05:48PM +0200, Florian Westphal wrote: > Jozsef Kadlecsik wrote: > > > The "delay unregister" remark was wrt. the "all rules were deleted" > > > case, i.e. add a "grace period" rather than acting right away when > > > conntrack use count did hit 0. > > > > Now I underst

Re: [PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

2020-10-13 Thread Jakub Kicinski
On Sun, 11 Oct 2020 11:09:41 +0200 Willy Tarreau wrote: > while running some tests on my Breadbee board, I noticed poor network > Tx performance. I had a look at the driver (macb, at91ether variant) > and noticed that at91ether_start_xmit() immediately stops the queue > after sending a frame and wa

[PATCH 1/4] selftests: netfilter: extend nfqueue test case

2020-10-13 Thread Pablo Neira Ayuso
From: Florian Westphal add a test with re-queueing: usespace doesn't pass accept verdict, but tells to re-queue to another nf_queue instance. Also, make the second nf-queue program use non-gso mode, kernel will have to perform software segmentation. Lastly, do not queue every packet, just one p

[PATCH 4/4] netfilter: nf_log: missing vlan offload tag and proto

2020-10-13 Thread Pablo Neira Ayuso
Dump vlan tag and proto for the usual vlan offload case if the NF_LOG_MACDECODE flag is set on. Without this information the logging is misleading as there is no reference to the VLAN header. [12716.993704] test: IN=veth0 OUT= MACSRC=86:6c:92:ea:d6:73 MACDST=0e:3b:eb:86:73:76 VPROTO=8100 VID=10 M

[PATCH 3/4] netfilter: nftables: extend error reporting for chain updates

2020-10-13 Thread Pablo Neira Ayuso
The initial support for netlink extended ACK is missing the chain update path, which results in misleading error reporting in case of EEXIST. Fixes 36dd1bcc07e5 ("netfilter: nf_tables: initial support for extended ACK reporting") Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.

[PATCH 2/4] ipvs: clear skb->tstamp in forwarding path

2020-10-13 Thread Pablo Neira Ayuso
From: Julian Anastasov fq qdisc requires tstamp to be cleared in forwarding path Reported-by: Evgeny B Link: https://bugzilla.kernel.org/show_bug.cgi?id=209427 Suggested-by: Eric Dumazet Fixes: 8203e2d844d3 ("net: clear skb->tstamp in forwarding paths") Fixes: fb420d5d91c1 ("tcp/fq: move back

[PATCH 0/4] Netfilter fixes for net

2020-10-13 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter fixes for net: 1) Extend nf_queue selftest to cover re-queueing, non-gso mode and delayed queueing, from Florian Westphal. 2) Clear skb->tstamp in IPVS forwarding path, from Julian Anastasov. 3) Provide netlink extended error reporting for EEXIST

Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

2020-10-13 Thread si-wei liu
On 10/9/2020 7:27 PM, Jason Wang wrote: On 2020/10/3 下午1:02, Si-Wei Liu wrote: Pinned pages are not properly accounted particularly when mapping error occurs on IOTLB update. Clean up dangling pinned pages for the error path. As the inflight pinned pages, specifically for memory region that s

Re: net: sctp: Fix negotiation of the number of data streams - backport request

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 10:32:13 + David Laight wrote: > This commit needs backporting to 5.1 through 5.8. > Do you need me to find the patch email or is this > with the full commit id enough? I'll queue it up, thanks!

Re: [PATCH net] docs: networking: update XPS to account for netif_set_xps_queue

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 15:45:08 -0400 Willem de Bruijn wrote: > From: Willem de Bruijn > > With the introduction of netif_set_xps_queue, XPS can be enabled > by the driver at initialization. > > Update the documentation to reflect this, as otherwise users > may incorrectly believe that the feature

[ PATCH v2 0/2] ibmveth gso fix.

2020-10-13 Thread David Wilder
The ibmveth driver is a virtual Ethernet driver used on IBM pSeries systems. Gso packets can be sent between LPARS (virtual hosts) without segmentation, by flagging gso packets using one of two methods depending on the firmware version. Some gso packet were not correctly identified by the receiver.

[ PATCH v2 1/2] ibmveth: Switch order of ibmveth_helper calls.

2020-10-13 Thread David Wilder
ibmveth_rx_csum_helper() must be called after ibmveth_rx_mss_helper() as ibmveth_rx_csum_helper() may alter ip and tcp checksum values. Fixes: 66aa0678efc2 ("ibmveth: Support to enable LSO/CSO for Trunk VEA.") Signed-off-by: David Wilder Reviewed-by: Thomas Falcon Reviewed-by: Cristobal Forno R

[ PATCH v2 2/2] ibmveth: Identify ingress large send packets.

2020-10-13 Thread David Wilder
Ingress large send packets are identified by either: The IBMVETH_RXQ_LRG_PKT flag in the receive buffer or with a -1 placed in the ip header checksum. The method used depends on firmware version. Frame geometry and sufficient header validation is performed by the hypervisor eliminating the need for

Re: [PATCH bpf-next V3 0/6] bpf: New approach for BPF MTU handling

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 22:40:09 +0200 Jesper Dangaard Brouer wrote: > > FWIW I took a quick swing at testing it with the HW I have and it did > > exactly what hardware should do. The TX unit entered an error state > > and then the driver detected that and reset it a few seconds later. > > The driv

Re: [PATCH 00/14] drop double zeroing

2020-10-13 Thread Martin K. Petersen
On Sun, 20 Sep 2020 13:26:12 +0200, Julia Lawall wrote: > sg_init_table zeroes its first argument, so the allocation of that argument > doesn't have to. Applied to 5.10/scsi-queue, thanks! [02/14] scsi: target: rd: Drop double zeroing https://git.kernel.org/mkp/scsi/c/4b217e015b75 -- M

Re: [PATCH v2 22/24] ice: docs fix a devlink info that broke a table

2020-10-13 Thread Jacob Keller
On 10/13/2020 5:14 AM, Mauro Carvalho Chehab wrote: > Changeset 410d06879c01 ("ice: add the DDP Track ID to devlink info") > added description for a new devlink field, but forgot to add > one of its columns, causing it to break: > > .../Documentation/networking/devlink/ice.rst:15: WARNING

Re: [PATCH v2 bpf-next 3/4] selftests/bpf: Add profiler test

2020-10-13 Thread Jiri Olsa
On Tue, Oct 13, 2020 at 02:03:33PM -0700, Alexei Starovoitov wrote: > On Tue, Oct 13, 2020 at 12:56 PM Jiri Olsa wrote: > > > > On Thu, Oct 08, 2020 at 06:12:39PM -0700, Alexei Starovoitov wrote: > > > > SNIP > > > > > + > > > +#ifdef UNROLL > > > +#pragma unroll > > > +#endif > > > + for (int

Re: WARNING: can't access registers at asm_sysvec_reschedule_ipi

2020-10-13 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:64a632da net: fec: Fix phy_device lookup for phy_reset_aft.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=11580c8050 kernel config: https://syzkaller.appspot.com/x/.config?x=c06bcf3cc963

Re: [PATCH v2 bpf-next 3/4] selftests/bpf: Add profiler test

2020-10-13 Thread Alexei Starovoitov
On Tue, Oct 13, 2020 at 12:56 PM Jiri Olsa wrote: > > On Thu, Oct 08, 2020 at 06:12:39PM -0700, Alexei Starovoitov wrote: > > SNIP > > > + > > +#ifdef UNROLL > > +#pragma unroll > > +#endif > > + for (int i = 0; i < MAX_CGROUPS_PATH_DEPTH; i++) { > > + filepart_length = > > +

Re: [PATCH RFC PKS/PMEM 24/58] fs/freevxfs: Utilize new kmap_thread()

2020-10-13 Thread Ira Weiny
On Tue, Oct 13, 2020 at 12:25:44PM +0100, Christoph Hellwig wrote: > > - kaddr = kmap(pp); > > + kaddr = kmap_thread(pp); > > memcpy(kaddr, vip->vii_immed.vi_immed + offset, PAGE_SIZE); > > - kunmap(pp); > > + kunmap_thread(pp); > > You only Cced me on this particular patch, which mean

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Ira Weiny
On Tue, Oct 13, 2020 at 09:01:49PM +0100, Al Viro wrote: > On Tue, Oct 13, 2020 at 08:36:43PM +0100, Matthew Wilcox wrote: > > > static inline void copy_to_highpage(struct page *to, void *vfrom, unsigned > > int size) > > { > > char *vto = kmap_atomic(to); > > > > memcpy(vto, vfrom, size

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Ira Weiny
On Tue, Oct 13, 2020 at 08:36:43PM +0100, Matthew Wilcox wrote: > On Tue, Oct 13, 2020 at 11:44:29AM -0700, Dan Williams wrote: > > On Fri, Oct 9, 2020 at 12:52 PM wrote: > > > > > > From: Ira Weiny > > > > > > The kmap() calls in this FS are localized to a single thread. To avoid > > > the over

Re: [PATCH v6 68/80] nl80211: docs: add a description for s1g_cap parameter

2020-10-13 Thread Johannes Berg
On Tue, 2020-10-13 at 22:41 +0200, Mauro Carvalho Chehab wrote: > Em Tue, 13 Oct 2020 20:47:47 +0200 > Johannes Berg escreveu: > > > Thanks Mauro. > > > > > > On Tue, 2020-10-13 at 13:54 +0200, Mauro Carvalho Chehab wrote: > > > Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions

Re: [PATCH 3/3] selinux: Add SELinux GTP support

2020-10-13 Thread Harald Welte
Hi Richard and list[s], On Tue, Oct 13, 2020 at 05:38:16PM +0100, Richard Haines wrote: > There is in development a 5G version of GTP at [1]. Please note that there is no such thing as "5G version of GTP". The GTP-U (user plane) did not change between 2G, 3G, 4G or even 5G: IT is still the sam

Re: [PATCH v6 68/80] nl80211: docs: add a description for s1g_cap parameter

2020-10-13 Thread Mauro Carvalho Chehab
Em Tue, 13 Oct 2020 20:47:47 +0200 Johannes Berg escreveu: > Thanks Mauro. > > > On Tue, 2020-10-13 at 13:54 +0200, Mauro Carvalho Chehab wrote: > > Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") > > added a new parameter, but didn't add the corresponding kernel-doc > > ma

Re: [PATCH bpf-next V3 0/6] bpf: New approach for BPF MTU handling

2020-10-13 Thread Jesper Dangaard Brouer
On Sat, 10 Oct 2020 09:32:12 -0700 Jakub Kicinski wrote: > On Sat, 10 Oct 2020 12:44:02 +0200 Jesper Dangaard Brouer wrote: > > > > > We will not be sprinkling validation checks across the drivers because > > > > > some reconfiguration path may occasionally yield a bad packet, or it's > > > > > h

Re: [PATCH 07/23] wfx: add bus_sdio.c

2020-10-13 Thread Pali Rohár
Hello! On Monday 12 October 2020 12:46:32 Jerome Pouiller wrote: > +#define SDIO_VENDOR_ID_SILABS0x > +#define SDIO_DEVICE_ID_SILABS_WF200 0x1000 > +static const struct sdio_device_id wfx_sdio_ids[] = { > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) }, Plea

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-13 Thread Lukasz Stelmach
It was <2020-10-02 pią 22:36>, when Andrew Lunn wrote: >> +static u32 ax88796c_get_link(struct net_device *ndev) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> + >> +mutex_lock(&ax_local->spi_lock); >> + >> +phy_read_status(ndev->phydev); >> + >> +mutex_un

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Al Viro
On Tue, Oct 13, 2020 at 08:36:43PM +0100, Matthew Wilcox wrote: > static inline void copy_to_highpage(struct page *to, void *vfrom, unsigned > int size) > { > char *vto = kmap_atomic(to); > > memcpy(vto, vfrom, size); > kunmap_atomic(vto); > } > > in linux/highmem.h ? You mea

Re: [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-13 Thread Lukasz Stelmach
It was <2020-10-03 sob 14:59>, when Heiner Kallweit wrote: > On 02.10.2020 21:22, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The driver has been

Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client

2020-10-13 Thread Pierre-Louis Bossart
+config SND_SOC_SOF_CLIENT_SUPPORT +    bool "SOF enable clients" Tell users what "SOF" means. This option can only be reached if the user already selected the topic-level option. From there on the SOF acronym is used. Is this not enough? Yes, that's enough. I didn't see it. Sorry about

Re: [PATCH v2 bpf-next 3/4] selftests/bpf: Add profiler test

2020-10-13 Thread Jiri Olsa
On Thu, Oct 08, 2020 at 06:12:39PM -0700, Alexei Starovoitov wrote: SNIP > + > +#ifdef UNROLL > +#pragma unroll > +#endif > + for (int i = 0; i < MAX_CGROUPS_PATH_DEPTH; i++) { > + filepart_length = > + bpf_probe_read_str(payload, MAX_PATH, > BPF_CORE_READ(cgr

[PATCH net] docs: networking: update XPS to account for netif_set_xps_queue

2020-10-13 Thread Willem de Bruijn
From: Willem de Bruijn With the introduction of netif_set_xps_queue, XPS can be enabled by the driver at initialization. Update the documentation to reflect this, as otherwise users may incorrectly believe that the feature is off by default. Fixes: 537c00de1c9b ("net: Add functions netif_reset_

Re: [bpf-next PATCH v3 2/6] bpf, sockmap: On receive programs try to fast track SK_PASS ingress

2020-10-13 Thread Jakub Sitnicki
On Mon, Oct 12, 2020 at 05:33 PM CEST, John Fastabend wrote: > Jakub Sitnicki wrote: [...] >> On Fri, Oct 09, 2020 at 08:36 PM CEST, John Fastabend wrote: >> > When we receive an skb and the ingress skb verdict program returns >> > SK_PASS we currently set the ingress flag and put it on the workq

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Dan Williams
On Tue, Oct 13, 2020 at 12:37 PM Matthew Wilcox wrote: > > On Tue, Oct 13, 2020 at 11:44:29AM -0700, Dan Williams wrote: > > On Fri, Oct 9, 2020 at 12:52 PM wrote: > > > > > > From: Ira Weiny > > > > > > The kmap() calls in this FS are localized to a single thread. To avoid > > > the over head

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Matthew Wilcox
On Tue, Oct 13, 2020 at 11:44:29AM -0700, Dan Williams wrote: > On Fri, Oct 9, 2020 at 12:52 PM wrote: > > > > From: Ira Weiny > > > > The kmap() calls in this FS are localized to a single thread. To avoid > > the over head of global PKRS updates use the new kmap_thread() call. > > > > Cc: Nicol

Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client

2020-10-13 Thread Randy Dunlap
On 10/13/20 8:08 AM, Pierre-Louis Bossart wrote: > >> +config SND_SOC_SOF_CLIENT >> +    tristate >> +    select ANCILLARY_BUS >> +    help >> +  This option is not user-selectable but automagically handled by >> +  'select' statements at a higher level >> + >>>

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-13 Thread Richard Sailer
On 13/10/2020 19:18, Kleber Sacilotto de Souza wrote: > From: Thadeu Lima de Souza Cascardo > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > del_timer_sync can't be used is because this relies on keeping a reference > to struct sock. But as we keep a pointer to dccp

Re: [PATCH 2/2] Revert "dccp: don't free ccid2_hc_tx_sock struct in dccp_disconnect()"

2020-10-13 Thread Richard Sailer
On 13/10/2020 19:18, Kleber Sacilotto de Souza wrote: > rom: Thadeu Lima de Souza Cascardo > > This reverts commit 2677d20677314101293e6da0094ede7b5526d2b1. > > This fixes an issue that after disconnect, dccps_hc_tx_ccid will still be > kept, allowing the socket to be reused as a listener socket

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Nicolas Pitre
On Fri, 9 Oct 2020, ira.we...@intel.com wrote: > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Nicolas Pitre > Signed-off-by: Ira Weiny Acked-by: Nicolas Pitre > fs

Re: [PATCH v6 68/80] nl80211: docs: add a description for s1g_cap parameter

2020-10-13 Thread Johannes Berg
Thanks Mauro. On Tue, 2020-10-13 at 13:54 +0200, Mauro Carvalho Chehab wrote: > Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") > added a new parameter, but didn't add the corresponding kernel-doc > markup, as repoted when doing "make htmldocs": > > ./include/net/cfg80

Re: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()

2020-10-13 Thread Dan Williams
On Fri, Oct 9, 2020 at 12:52 PM wrote: > > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Nicolas Pitre > Signed-off-by: Ira Weiny > --- > fs/cramfs/inode.c | 10 +---

[PATCH net v2] net: fix pos incrementment in ipv6_route_seq_next

2020-10-13 Thread Yonghong Song
Commit 4fc427e05158 ("ipv6_route_seq_next should increase position index") tried to fix the issue where seq_file pos is not increased if a NULL element is returned with seq_ops->next(). See bug https://bugzilla.kernel.org/show_bug.cgi?id=206283 The commit effectively does: - increase pos for al

Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-10-13 Thread David Ahern
On 10/12/20 11:30 AM, Keller, Jacob E wrote: > Ah. Good point. This should use CLOCK_MONOTONIC instead, right? that or MONOTONIC_RAW.

Re: [PATCHv3 net-next 02/16] udp6: move the mss check after udp gso tunnel processing

2020-10-13 Thread Willem de Bruijn
On Tue, Oct 13, 2020 at 3:28 AM Xin Long wrote: > > For some protocol's gso, like SCTP, it's using GSO_BY_FRAGS for > gso_size. When using UDP to encapsulate its packet, it will > return error in udp6_ufo_fragment() as skb->len < gso_size, > and it will never go to the gso tunnel processing. > > S

[PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-13 Thread Kleber Sacilotto de Souza
From: Thadeu Lima de Souza Cascardo When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason del_timer_sync can't be used is because this relies on keeping a reference to struct sock. But as we keep a pointer to dccps_hc_tx_ccid and free that during disconnect, the timer should r

[PATCH 2/2] Revert "dccp: don't free ccid2_hc_tx_sock struct in dccp_disconnect()"

2020-10-13 Thread Kleber Sacilotto de Souza
From: Thadeu Lima de Souza Cascardo This reverts commit 2677d20677314101293e6da0094ede7b5526d2b1. This fixes an issue that after disconnect, dccps_hc_tx_ccid will still be kept, allowing the socket to be reused as a listener socket, and the cloned socket will free its dccps_hc_tx_ccid, leading t

[PATCH 0/2] net: dccp: fix structure use-after-free

2020-10-13 Thread Kleber Sacilotto de Souza
This patchset addresses the following CVE: CVE-2020-16119 - DCCP CCID structure use-after-free Hadar Manor reported that by reusing a socket with an attached dccps_hc_tx_ccid as a listener, it will be used after being released, leading to DoS and potentially code execution. The first patch moves

Re: [PATCH] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 17:31:51 +0530 Reji Thomas wrote: > Currently End.X action doesn't consider the outgoing interface > while looking up the nexthop.This breaks packet path functionality > specifically while using link local address as the End.X nexthop. > The patch fixes this by enforcing End.X a

Re: [PATCH v6 68/80] nl80211: docs: add a description for s1g_cap parameter

2020-10-13 Thread Thomas Pedersen
On 2020-10-13 04:54, Mauro Carvalho Chehab wrote: Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") added a new parameter, but didn't add the corresponding kernel-doc markup, as repoted when doing "make htmldocs": ./include/net/cfg80211.h:471: warning: Function paramet

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 18:59:28 +0300 Aleksandr Nogikh wrote: > On Mon, 12 Oct 2020 at 09:04, Dmitry Vyukov wrote: > > > > On Sat, Oct 10, 2020 at 5:14 PM Jakub Kicinski wrote: > > > > > > On Sat, 10 Oct 2020 09:54:57 +0200 Dmitry Vyukov wrote: > > > > On Sat, Oct 10, 2020 at 1:16 AM Jakub Kicin

Re: [PATCH 01/23] dt-bindings: introduce silabs,wfx.yaml

2020-10-13 Thread Rob Herring
On Mon, Oct 12, 2020 at 12:46:26PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Signed-off-by: Jérôme Pouiller > --- > .../bindings/net/wireless/silabs,wfx.yaml | 125 ++ > 1 file changed, 125 insertions(+) > create mode 100644 > Documentation/devicetree/bindi

Re: [PATCH] can: Explain PDU in CAN_ISOTP help text

2020-10-13 Thread Oliver Hartkopp
On 13.10.20 16:13, Geert Uytterhoeven wrote: The help text for the CAN_ISOTP config symbol uses the acronym "PDU". However, this acronym is not explained here, nor in Documentation/networking/can.rst. Expand the acronym to make it easier for users to decide if they need to enable the CAN_ISOTP

Re: [PATCH v2] net: Add mhi-net driver

2020-10-13 Thread Jakub Kicinski
On Mon, 12 Oct 2020 17:26:03 +0200 Loic Poulain wrote: > This patch adds a new network driver implementing MHI transport for > network packets. Packets can be in any format, though QMAP (rmnet) > is the usual protocol (flow control + PDN mux). > > It support two MHI devices, IP_HW0 which is, the p

Re: [PATCH 3/3] selinux: Add SELinux GTP support

2020-10-13 Thread Richard Haines
On Tue, 2020-10-13 at 09:55 -0400, Paul Moore wrote: > On Mon, Oct 12, 2020 at 5:40 AM Harald Welte > wrote: > > Hi Paul, > > > > On Sun, Oct 11, 2020 at 10:09:11PM -0400, Paul Moore wrote: > > > Harald, Pablo - I know you both suggested taking a slow iterative > > > approach to merging functiona

Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client

2020-10-13 Thread Pierre-Louis Bossart
+config SND_SOC_SOF_CLIENT +    tristate +    select ANCILLARY_BUS +    help +  This option is not user-selectable but automagically handled by +  'select' statements at a higher level + +config SND_SOC_SOF_CLIENT_SUPPORT +    bool "SOF enable clients" Tell users what "SOF" means.

Re: [PATCH] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-13 Thread kernel test robot
Hi Reji, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.9 next-20201013] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as doc

[RFC PATCH] IPv6: sr: seg6_strict_lookup_nexthop() can be static

2020-10-13 Thread kernel test robot
Signed-off-by: kernel test robot --- seg6_local.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c index 1a669f12d56c9d..e949d24036c2cd 100644 --- a/net/ipv6/seg6_local.c +++ b/net/ipv6/seg6_local.c @@ -219,8 +219,8 @@ int

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-13 Thread Aleksandr Nogikh
On Mon, 12 Oct 2020 at 09:04, Dmitry Vyukov wrote: > > On Sat, Oct 10, 2020 at 5:14 PM Jakub Kicinski wrote: > > > > On Sat, 10 Oct 2020 09:54:57 +0200 Dmitry Vyukov wrote: > > > On Sat, Oct 10, 2020 at 1:16 AM Jakub Kicinski wrote: [...] > > > > Could you use skb_extensions for this? > > > > >

Re: [PATCH v1] dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml

2020-10-13 Thread Rob Herring
On Fri, Oct 09, 2020 at 03:29:12PM +0200, Oleksij Rempel wrote: > In order to automate the verification of DT nodes convert > fsl-flexcan.txt to fsl,flexcan.yaml > > Signed-off-by: Oleksij Rempel > --- > .../bindings/net/can/fsl,flexcan.yaml | 137 ++ > .../bindings/net/c

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-13 Thread Jakub Kicinski
On Tue, 13 Oct 2020 14:29:29 + Danielle Ratson wrote: > > On Mon, 12 Oct 2020 15:33:45 + Danielle Ratson wrote: > > > > What's the use for this in practical terms? Isn't the lane count > > > > basically implied by the module that gets plugged in? > > > > > > The use is to enable the use

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Muchun Song
On Tue, Oct 13, 2020 at 4:09 PM Mike Rapoport wrote: > > On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: > > On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: > > > > > > On 10/12/20 10:39 AM, Muchun Song wrote: > > > > On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet > > > > wrote:

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Randy Dunlap
On 10/13/20 8:12 AM, Mike Rapoport wrote: > On Tue, Oct 13, 2020 at 07:43:59AM -0700, Randy Dunlap wrote: >> On 10/13/20 1:09 AM, Mike Rapoport wrote: >>> On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: > > On 10/1

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Mike Rapoport
On Tue, Oct 13, 2020 at 07:43:59AM -0700, Randy Dunlap wrote: > On 10/13/20 1:09 AM, Mike Rapoport wrote: > > On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: > >> On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet > >> wrote: > >>> > >>> On 10/12/20 10:39 AM, Muchun Song wrote: > On M

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-13 Thread Randy Dunlap
On 10/13/20 1:09 AM, Mike Rapoport wrote: > On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: >> On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: >>> >>> On 10/12/20 10:39 AM, Muchun Song wrote: On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet wrote: > > On Mon, Oct 12, 202

[PATCH iproute2-next 2/2] m_mpls: add mac_push action

2020-10-13 Thread Guillaume Nault
Add support for the new TCA_MPLS_ACT_MAC_PUSH action (kernel commit a45294af9e96 ("net/sched: act_mpls: Add action to push MPLS LSE before Ethernet header")). This action let TC push an MPLS header before the MAC header of a frame. Example (encapsulate all outgoing frames with label 20, then add a

[PATCH iproute2-next 1/2] m_vlan: add pop_eth and push_eth actions

2020-10-13 Thread Guillaume Nault
Add support for the new TCA_VLAN_ACT_POP_ETH and TCA_VLAN_ACT_PUSH_ETH actions (kernel commit 19fbcb36a39e ("net/sched: act_vlan: Add {POP,PUSH}_ETH actions"). These action let TC remove or add the Ethernet at the head of a frame. Drop an Ethernet header: # tc filter add dev ethX matchall action

[PATCH iproute2-next 0/2] tc: support for new MPLS L2 VPN actions

2020-10-13 Thread Guillaume Nault
This patch series adds the possibility for TC to tunnel Ethernet frames over MPLS. Patch 1 allows adding or removing the Ethernet header. Patch 2 allows pushing an MPLS LSE before the MAC header. By combining these actions, it becomes possible to encapsulate an entire Ethernet frame into MPLS, th

RE: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-13 Thread Danielle Ratson
> -Original Message- > From: Jakub Kicinski > Sent: Monday, October 12, 2020 6:58 PM > To: Danielle Ratson > Cc: Ido Schimmel ; netdev@vger.kernel.org; > da...@davemloft.net; Jiri Pirko ; and...@lunn.ch; > f.faine...@gmail.com; mkube...@suse.cz; mlxsw ; Ido > Schimmel ; johan...@sipsol

Ip Rule For GRE Tunnel‏

2020-10-13 Thread לירן אודיז
Hi, Is it possible to set IP rule for GRE tunnel? in the IP rule man there is missing information about the "tun_id" selector parameter, what is the meaning of this parameter? How can i set IP rule for the following GRE tunnel? [root@localhost /]# ip tunnel show gre0: gre/ip remote any local an

[PATCH] can: Explain PDU in CAN_ISOTP help text

2020-10-13 Thread Geert Uytterhoeven
The help text for the CAN_ISOTP config symbol uses the acronym "PDU". However, this acronym is not explained here, nor in Documentation/networking/can.rst. Expand the acronym to make it easier for users to decide if they need to enable the CAN_ISOTP option or not. Signed-off-by: Geert Uytterhoeven

  1   2   >