Re: [PATCH net] net: fix pos incrementment in ipv6_route_seq_next

2020-10-12 Thread Vasily Averin
Dear Yonghong Song, thank you for reporting the problem. As far as I understand the problem here is that pos is incremented in .start function. I do not,like an idea to avoid increment in ipv6_route_seq_next() however ipv6_route_seq_start can provide fake argument instead. --- a/net/ipv6/ip6_fi

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-12 Thread Eric Dumazet
On 10/12/20 11:53 AM, Muchun Song wrote: > We are not complaining about TCP using too much memory, but how do > we know that TCP uses a lot of memory. When I firstly face this problem, > I do not know who uses the 25GB memory and it is not shown in the > /proc/meminfo. > If we can know the amo

Re: Linux mvneta driver unable to read MAC address from HW

2020-10-12 Thread Thomas Petazzoni
Hello Ezra, On Sat, 10 Oct 2020 18:41:24 +0200 Ezra Buehler wrote: > I am running Debian buster (Linux 4.19.146) on a Synology DS214+ NAS > (Marvell ARMADA XP). Unfortunately, I end up with random MAC addresses > for the two Ethernet interfaces after boot. (Also with Debian sid, Linux > 5.4.0.)

RE: [Intel-wired-lan] [PATCH net-next] i40e: remove redundant assigment

2020-10-12 Thread Kuruvinakunnel, George
From: Intel-wired-lan On Behalf Of Marek Majtyka Sent: Tuesday, September 8, 2020 6:05 PM To: Karlsson, Magnus ; Topel, Bjorn ; intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T Cc: netdev@vger.kernel.org; Fijalkowski, Maciej ; Majtyka, MarekX ; maciejromanfijalkow...@gmain.com Subject: [I

[net] tipc: re-configure queue limit for broadcast link

2020-10-12 Thread Hoang Huu Le
The queue limit of the broadcast link is being calculated base on initial MTU. However, when MTU value changed (e.g manual changing MTU on NIC device, MTU negotiation etc.,) we do not re-calculate queue limit. This gives throughput does not reflect with the change. So fix it by calling the functio

[PATCH] tc: fq: clarify the length of orphan_mask.

2020-10-12 Thread zhang kai
From: "zhangkai...@126.com" Signed-off-by: kai zhang --- tc/q_fq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/q_fq.c b/tc/q_fq.c index 98d1bf40..b10d01e9 100644 --- a/tc/q_fq.c +++ b/tc/q_fq.c @@ -253,7 +253,7 @@ static int fq_parse_opt(struct qdisc_util *qu, int arg

Re: [RFC PATCH 10/24] vdpa: introduce config operations for associating ASID to a virtqueue group

2020-10-12 Thread Jason Wang
On 2020/10/12 下午4:17, Eli Cohen wrote: On Mon, Oct 12, 2020 at 03:45:10PM +0800, Jason Wang wrote: So in theory we can have several asid's (for different virtqueues), each one should be followed by a specific set_map call. If this is so, how do I know if I met all the conditions run my driver?

Re: [PATCH v2] vdpa/mlx5: Setup driver only if VIRTIO_CONFIG_S_DRIVER_OK

2020-10-12 Thread Jason Wang
On 2020/9/9 下午1:30, Eli Cohen wrote: On Tue, Sep 08, 2020 at 10:08:39PM -0400, Jason Wang wrote: - Original Message - set_map() is used by mlx5 vdpa to create a memory region based on the address map passed by the iotlb argument. If we get successive calls, we will destroy the curren

Re: [PATCH net v2 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-12 Thread Deepa Dinamani
> On Mon, Oct 12, 2020 at 5:36 AM Christian Eggers wrote: > > v2: > > - > > - integrated proposal from Willem de Bruijn > > - added Reviewed-by: from Willem and Deepa You may add my Acked-by: Deepa Dinamani -Deepa

vxlan_asymmetric.sh test failed every time

2020-10-12 Thread Hangbin Liu
Hi Ido, When run vxlan_asymmetric.sh on RHEL8, It failed every time. I though that it may failed because the kernel version is too old. But today I tried with latest kernel, it still failed. Would you please help check if I missed any configuration? # uname -r 5.9.0 # ip -V ip utility, iproute2-s

Re: [PATCH] ptp: ptp_clockmatrix: initialize variables

2020-10-12 Thread Tom Rix
On 10/12/20 3:01 PM, Richard Cochran wrote: > On Sun, Oct 11, 2020 at 01:09:55PM -0700, t...@redhat.com wrote: >> From: Tom Rix >> >> Clang static analysis reports this representative problem >> >> ptp_clockmatrix.c:1852:2: warning: 5th function call argument >> is an uninitialized value >>

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-12 Thread Muchun Song
On Tue, Oct 13, 2020 at 6:12 AM Cong Wang wrote: > > On Mon, Oct 12, 2020 at 2:53 AM Muchun Song wrote: > > We are not complaining about TCP using too much memory, but how do > > we know that TCP uses a lot of memory. When I firstly face this problem, > > I do not know who uses the 25GB memory an

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-12 Thread Muchun Song
On Tue, Oct 13, 2020 at 5:47 AM Cong Wang wrote: > > On Sun, Oct 11, 2020 at 9:22 PM Muchun Song wrote: > > > > On Mon, Oct 12, 2020 at 2:39 AM Cong Wang wrote: > > > > > > On Sat, Oct 10, 2020 at 3:39 AM Muchun Song > > > wrote: > > > > > > > > The amount of memory allocated to sockets buffer

Re: pull-request: bpf-next 2020-10-12

2020-10-12 Thread Jakub Kicinski
On Mon, 12 Oct 2020 13:55:22 -0700 Alexei Starovoitov wrote: > The following pull-request contains BPF updates for your *net-next* tree. > > We've added 62 non-merge commits during the last 10 day(s) which contain > a total of 73 files changed, 4339 insertions(+), 772 deletions(-). > > The main c

Re: [PATCHv3] selftests: rtnetlink: load fou module for kci_test_encap_fou() test

2020-10-12 Thread Po-Hsu Lin
On Mon, Oct 12, 2020 at 11:28 PM Jakub Kicinski wrote: > > On Mon, 12 Oct 2020 13:56:15 +0800 Po-Hsu Lin wrote: > > Is there any update on this patch? > > You received feedback. Don't remove modules after tests, something else > could be using them. Hello Jakub, I have my feedback regarding your

[PATCH 1/2] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-12 Thread Chris Packham
When a port is configured with 'managed = "in-band-status"' don't force the link up, the switch MAC will detect the link status correctly. Signed-off-by: Chris Packham --- drivers/net/dsa/mv88e6xxx/chip.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/

[PATCH 2/2] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097

2020-10-12 Thread Chris Packham
Implement serdes_power, serdes_get_lane and serdes_pcs_get_state ops for the MV88E6097 so that ports 8 & 9 can be supported as serdes ports and directly connected to other network interfaces or to SFPs without a PHY. Signed-off-by: Chris Packham --- This should be usable for all variants of the

[PATCH 0/2] net: dsa: mv88e6xxx: serdes link without phy

2020-10-12 Thread Chris Packham
This small series gets my hardware into a working state. The key points are to make sure we don't force the link and that we ask the MAC for the link status. I also have updated my dts to say `phy-mode = "1000base-x";` and `managed = "in-band-status";` Chris Packham (2): net: dsa: mv88e6xxx: Don

Re: [PATCH iproute2-next v2 2/2] tc: implement support for terse dump

2020-10-12 Thread David Ahern
On 10/9/20 9:38 AM, Vlad Buslov wrote: > > On Fri 09 Oct 2020 at 15:45, Jamal Hadi Salim wrote: >> On 2020-10-09 8:15 a.m., Vlad Buslov wrote: >>> >>> On Fri 09 Oct 2020 at 15:03, Jamal Hadi Salim wrote: >> Which test(s)? I see for example d45e mentioning terse but i dont see correspon

Re: merge window is open. bpf-next is still open.

2020-10-12 Thread Stephen Rothwell
Hi Alexei, On Mon, 12 Oct 2020 14:03:07 -0700 Alexei Starovoitov wrote: > > That is a great idea! I think that should work well for everyone. > Let's do exactly that. > Just pushed bpf-next/for-next branch. From now on I will only fetch the for-next branch. Thanks. -- Cheers, Stephen Rothwell

Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client

2020-10-12 Thread Randy Dunlap
On 10/12/20 6:55 PM, Randy Dunlap wrote: > On 10/12/20 6:31 PM, Pierre-Louis Bossart wrote: >> +config SND_SOC_SOF_CLIENT +    tristate +    select ANCILLARY_BUS +    help +  This option is not user-selectable but automagically handled by +  'select' statements

Re: [Patch net v3] ip_gre: set dev->hard_header_len and dev->needed_headroom properly

2020-10-12 Thread Xie He
On Mon, Oct 12, 2020 at 4:17 PM Cong Wang wrote: > > GRE tunnel has its own header_ops, ipgre_header_ops, and sets it > conditionally. When it is set, it assumes the outer IP header is > already created before ipgre_xmit(). > > This is not true when we send packets through a raw packet socket, > w

Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client

2020-10-12 Thread Randy Dunlap
On 10/12/20 6:31 PM, Pierre-Louis Bossart wrote: > >>> +config SND_SOC_SOF_CLIENT >>> +    tristate >>> +    select ANCILLARY_BUS >>> +    help >>> +  This option is not user-selectable but automagically handled by >>> +  'select' statements at a higher level >>> + >>> +config SND_SOC_SOF_

Re: [Patch net v3] ip_gre: set dev->hard_header_len and dev->needed_headroom properly

2020-10-12 Thread Xie He
On Mon, Oct 12, 2020 at 4:17 PM Cong Wang wrote: > > Note, there are some other suspicious use of dev->hard_header_len in > the same file, but let's leave them to a separate patch if really > needed. I looked at the file (before this patch). There are 4 occurrences of hard_header_len, but they ar

Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client

2020-10-12 Thread Pierre-Louis Bossart
+config SND_SOC_SOF_CLIENT + tristate + select ANCILLARY_BUS + help + This option is not user-selectable but automagically handled by + 'select' statements at a higher level + +config SND_SOC_SOF_CLIENT_SUPPORT + bool "SOF enable clients" Tell users wha

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-12 Thread Benjamin Poirier
On 2020-10-12 19:51 +0800, Coiby Xu wrote: > On Sat, Oct 10, 2020 at 10:22:30PM +0900, Benjamin Poirier wrote: > > On 2020-10-10 18:02 +0800, Coiby Xu wrote: > > [...] > > > > > + do { \ > > > > > + err = fill_seg_(fmsg, &dum

Re: [PATCH v2 2/6] ASoC: SOF: Introduce descriptors for SOF client

2020-10-12 Thread Randy Dunlap
On 10/5/20 11:24 AM, Dave Ertman wrote: > diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig > index 4dda4b62509f..cea7efedafef 100644 > --- a/sound/soc/sof/Kconfig > +++ b/sound/soc/sof/Kconfig > @@ -50,6 +50,24 @@ config SND_SOC_SOF_DEBUG_PROBES > Say Y if you want to enable probe

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-12 Thread Benjamin Poirier
On 2020-10-12 19:24 +0800, Coiby Xu wrote: [...] > > I think, but didn't check in depth, that in those drivers, the devlink > > device is tied to the pci device and can exist independently of the > > netdev, at least in principle. > > > You are right. Take drivers/net/ethernet/mellanox/mlxsw as an

Re: [PATCH] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API

2020-10-12 Thread kernel test robot
Hi Anant, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.9 next-20201012] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documente

[PATCH net] net: fix pos incrementment in ipv6_route_seq_next

2020-10-12 Thread Yonghong Song
Commit 4fc427e05158 ("ipv6_route_seq_next should increase position index") tried to fix the issue where seq_file pos is not increased if a NULL element is returned with seq_ops->next(). See bug https://bugzilla.kernel.org/show_bug.cgi?id=206283 The commit effectively does: - increase pos for al

Re: ethtool enhancements for configuring IET Frame preemption

2020-10-12 Thread Vinicius Costa Gomes
Hi Murali, Murali Karicheri writes: > Hi Vinicius, > > On 8/17/20 6:30 PM, Vinicius Costa Gomes wrote: >> Hi Murali, >> >> I was finally able to go back to working on this, and should have >> something for review when net-next opens. >> > Do you have anything to share here on this or still wor

[RFC net-next v2 1/2] ethtool: Add support for configuring frame preemption

2020-10-12 Thread Vinicius Costa Gomes
Frame preemption (described in IEEE 802.3br-2016) defines the concept of preemptible and express queues. It allows traffic from express queues to "interrupt" traffic from preemptible queues, which are "resumed" after the express traffic has finished transmitting. Frame preemption can only be used

[RFC net-next v2 0/2] ethtool: Add support for frame preemption

2020-10-12 Thread Vinicius Costa Gomes
Hi, Changes from v1: - The per-queue preemptible/express setting is moved to applicable qdiscs (Jakub Kicinski and others); - "min-frag-size" now follows the 802.3br specification more closely, it's expressed as X in '64(1 + X) + 4' (Joergen Andreasen) This is still an RFC because two mai

[RFC net-next v2 2/2] taprio: Add support for frame preemption offload

2020-10-12 Thread Vinicius Costa Gomes
This adds a way to configure which queues are marked as preemptible and which are marked as express. Even if this is not a "real" offload, because it can't be executed purely in software, having this information near where the mapping of queues is specified, makes it, hopefully, easier to understa

[PATCH bpf] bpf: selftest: Fix flaky tcp_hdr_options test when adding addr to lo

2020-10-12 Thread Martin KaFai Lau
The tcp_hdr_options test adds a "::eB9F" addr to the lo dev. However, this non loopback address will have a race on ipv6 dad which may lead to EADDRNOTAVAIL error from time to time. Even nodad is used in the iproute2 command, there is still a race in when the route will be added. This will then l

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-12 Thread Ira Weiny
On Mon, Oct 12, 2020 at 09:02:54PM +0100, Matthew Wilcox wrote: > On Mon, Oct 12, 2020 at 12:53:54PM -0700, Ira Weiny wrote: > > On Mon, Oct 12, 2020 at 05:44:38PM +0100, Matthew Wilcox wrote: > > > On Mon, Oct 12, 2020 at 09:28:29AM -0700, Dave Hansen wrote: > > > > kmap_atomic() is always preferr

[Patch net v3] ip_gre: set dev->hard_header_len and dev->needed_headroom properly

2020-10-12 Thread Cong Wang
GRE tunnel has its own header_ops, ipgre_header_ops, and sets it conditionally. When it is set, it assumes the outer IP header is already created before ipgre_xmit(). This is not true when we send packets through a raw packet socket, where L2 headers are supposed to be constructed by user. Packet

Re: [PATCH 0/6] Netfilter/IPVS updates for net-next

2020-10-12 Thread Jakub Kicinski
On Mon, 12 Oct 2020 03:38:13 +0200 Pablo Neira Ayuso wrote: > Hi, > > The following patchset contains Netfilter/IPVS updates for net-next: > > 1) Inspect the reply packets coming from DR/TUN and refresh connection >state and timeout, from longguang yue and Julian Anastasov. > > 2) Series to

[FINAL REMINDER] Call for Proposals: eBPF Summit 2020

2020-10-12 Thread Daniel Borkmann
This is the FINAL reminder for the call for proposals for the inaugural eBPF Summit, a virtual event, targeted at DevOps, platform architects and developers. The goal is to have a gathering of users or potential users of eBPF(/XDP) as well as developers in order to exchange ideas, use cases and

[net-next 3/4] net/mlx5e: IPsec: Add TX steering rule per IPsec state

2020-10-12 Thread Saeed Mahameed
From: Huy Nguyen Add new FTE in TX IPsec FT per IPsec state. It has the same matching criteria as the RX steering rule. The IPsec FT is created/destroyed when the first/last rule is added/deleted respectively. Signed-off-by: Huy Nguyen Reviewed-by: Boris Pismenny Reviewed-by: Tariq Toukan Si

[net-next 2/4] net/mlx5: Add NIC TX domain namespace

2020-10-12 Thread Saeed Mahameed
From: Huy Nguyen Add new namespace that represents the NIC TX domain. Signed-off-by: Huy Nguyen Signed-off-by: Raed Salem Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/fs.h | 1 + .../net/ethernet/mellanox/mlx5/core/fs_cmd.c | 3 +++ .../net/ethernet/mellanox/

[net-next 4/4] net/mlx5e: IPsec: Add Connect-X IPsec Tx data path offload

2020-10-12 Thread Saeed Mahameed
From: Raed Salem In the TX data path, spot packets with xfrm stack IPsec offload indication. Fill Software-Parser segment in TX descriptor so that the hardware may parse the ESP protocol, and perform TX checksum offload on the inner payload. Support GSO, by providing the trailer data and ICV pl

Re: merge window is open. bpf-next is still open.

2020-10-12 Thread Daniel Borkmann
On 10/12/20 11:03 PM, Alexei Starovoitov wrote: On Tue, Oct 13, 2020 at 07:50:16AM +1100, Stephen Rothwell wrote: [...] How about this: you create a for-next branch in the bpf-next tree and I fetch that instead of your master branch. What you do is always work in your master branch and wheneve

[net-next 1/4] net/mlx5: Fix uininitialized pointer read on pointer attr

2020-10-12 Thread Saeed Mahameed
From: Colin Ian King Currently the error exit path err_free kfree's attr. In the case where flow and parse_attr failed to be allocated this return path will free the uninitialized pointer attr, which is not correct. In the other case where attr fails to allocate attr does not need to be freed. S

[pull request][net-next 0/4] mlx5 updates 2020-10-12

2020-10-12 Thread Saeed Mahameed
Hi Jakub, This small series add xfrm IPSec TX offload support to mlx5 driver. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit 547848af58e3eb5a0d8b0a5e6433042f111788e2: Merge branch 'bnxt_en-Updates-for-net-next' (2020-10-12 14:42:55

RE: [ PATCH v1 2/2] ibmveth: Identify ingress large send packets.

2020-10-12 Thread dwilder
On 2020-10-11 11:31, Jakub Kicinski wrote: On Sat, 10 Oct 2020 12:51:30 -0400 Willem de Bruijn wrote: > > @@ -1385,7 +1386,17 @@ static int ibmveth_poll(struct napi_struct *napi, int budget) > > skb_put(skb, length); > > skb->protocol = eth_type_t

Re: [PATCH bpf-next] xsk: introduce padding between ring pointers

2020-10-12 Thread Daniel Borkmann
On 10/12/20 1:13 PM, Magnus Karlsson wrote: [...] Nope, that was a bad idea. After measuring, this one produces worse performance than the original suggestion with padding in between all members. Cannot explain why at the moment, but the numbers are convincing and above noise level for sure. So l

Re: [Patch net v2] ip_gre: set dev->hard_header_len and dev->needed_headroom properly

2020-10-12 Thread Cong Wang
On Sun, Oct 11, 2020 at 3:46 PM Xie He wrote: > > On Sun, Oct 11, 2020 at 12:11 PM Cong Wang wrote: > > > > @@ -626,8 +626,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb, > > > > if (dev->header_ops) { > > /* Need space for new headers */ > > - if (sk

RE: [PATCH] i40e: report correct VF link speed when link state is set to enable

2020-10-12 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org On > Behalf Of Stefan Assmann > Sent: Wednesday, September 9, 2020 1:22 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; da...@davemloft.net; Kirsher, Jeffrey T > ; Yang, Lihong ; > sassm...@kpanic.de > Subject: [PATCH] i40e: report corre

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-12 Thread Cong Wang
On Mon, Oct 12, 2020 at 2:53 AM Muchun Song wrote: > We are not complaining about TCP using too much memory, but how do > we know that TCP uses a lot of memory. When I firstly face this problem, > I do not know who uses the 25GB memory and it is not shown in the > /proc/meminfo. > If we can know

[PATCH] ath9k: revert "ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()"

2020-10-12 Thread Brooke Basile
A bug in USB/IP previously caused all syzkaller USB fuzzing instances to return false positives when testing crash reproducers. This patch reverts changes made in commit 03fb92a432ea which, due to this bug, returned false positives when tested and introduced new regressions. Fixes: 03fb92a432ea ("

Re: [PATCH] ptp: ptp_clockmatrix: initialize variables

2020-10-12 Thread Richard Cochran
On Sun, Oct 11, 2020 at 01:09:55PM -0700, t...@redhat.com wrote: > From: Tom Rix > > Clang static analysis reports this representative problem > > ptp_clockmatrix.c:1852:2: warning: 5th function call argument > is an uninitialized value > snprintf(idtcm->version, sizeof(idtcm->version)

Re: ethtool enhancements for configuring IET Frame preemption

2020-10-12 Thread Murali Karicheri
Hi Vinicius, On 8/17/20 6:30 PM, Vinicius Costa Gomes wrote: Hi Murali, I was finally able to go back to working on this, and should have something for review when net-next opens. Do you have anything to share here on this or still work in progress? Thanks Murali Cheers, Murali Karicheri

Re: [PATCH net-next v2 0/9] bnxt_en: Updates for net-next.

2020-10-12 Thread Jakub Kicinski
On Mon, 12 Oct 2020 05:10:45 -0400 Michael Chan wrote: > This series contains these main changes: > > 1. Change of default message level to enable more logging. > 2. Some cleanups related to processing async events from firmware. > 3. Allow online ethtool selftest on multi-function PFs. > 4. Retur

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-12 Thread Cong Wang
On Sun, Oct 11, 2020 at 9:22 PM Muchun Song wrote: > > On Mon, Oct 12, 2020 at 2:39 AM Cong Wang wrote: > > > > On Sat, Oct 10, 2020 at 3:39 AM Muchun Song > > wrote: > > > > > > The amount of memory allocated to sockets buffer can become significant. > > > However, we do not display the amount

Re: [PATCH net-next v6 4/7] net: dsa: hellcreek: Add support for hardware timestamping

2020-10-12 Thread Richard Cochran
On Mon, Oct 12, 2020 at 02:53:58PM +0200, Kamil Alkhouri wrote: > > By the way, how would you see the split between an unsynchronized and > > a > > synchronized PHC be implemented in the Linux kernel? If you want, you can run your PHC using the linuxptp "free_running" option. Then, you can use th

Re: [PATCH V2] net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()

2020-10-12 Thread Jakub Kicinski
On Sat, 10 Oct 2020 11:10:00 +0200 Marek Vasut wrote: > The phy_reset_after_clk_enable() is always called with ndev->phydev, > however that pointer may be NULL even though the PHY device instance > already exists and is sufficient to perform the PHY reset. > > This condition happens in fec_open(),

Re: [PATCH net-next] mlx4: handle non-napi callers to napi_poll

2020-10-12 Thread Jakub Kicinski
On Mon, 12 Oct 2020 09:40:51 +0300 Tariq Toukan wrote: > On Mon, 12 Oct 2020 at 05:47, Jakub Kicinski wrote: > > > > On Thu, 8 Oct 2020 11:45:26 -0700 Jonathan Lemon wrote: > > > From: Jonathan Lemon > > > > > > netcons calls napi_poll with a budget of 0 to transmit packets. > > > Handle this b

Re: merge window is open. bpf-next is still open.

2020-10-12 Thread Alexei Starovoitov
On Tue, Oct 13, 2020 at 07:50:16AM +1100, Stephen Rothwell wrote: > Hi Alexei, > > On Mon, 12 Oct 2020 13:15:16 -0700 Alexei Starovoitov > wrote: > > > > You mean keep pushing into bpf-next/master ? > > The only reason is linux-next. > > But coming to think about it again, let's fix linux-next p

Re: [PATCH AUTOSEL 5.8 18/24] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails

2020-10-12 Thread Petko Manolov
On 20-10-12 12:11:18, Joe Perches wrote: > On Mon, 2020-10-12 at 15:02 -0400, Sasha Levin wrote: > > From: Anant Thazhemadam > > > > [ Upstream commit f45a4248ea4cc13ed50618ff066849f9587226b2 ] > > > > When get_registers() fails in set_ethernet_addr(),the uninitialized > > value of node_id gets

Re: [PATCH v1 net-next] net: stmmac: Enable EEE HW LPI timer with auto SW/HW switching

2020-10-12 Thread Jakub Kicinski
On Fri, 9 Oct 2020 00:11:23 +0800 Voon Weifeng wrote: > From: "Vineetha G. Jaya Kumaran" > > This patch enables the HW LPI Timer which controls the automatic entry > and exit of the LPI state. > The EEE LPI timer value is configured through ethtool. The driver will > auto select the LPI HW timer

pull-request: bpf-next 2020-10-12

2020-10-12 Thread Alexei Starovoitov
Hi, The following pull-request contains BPF updates for your *net-next* tree. We've added 62 non-merge commits during the last 10 day(s) which contain a total of 73 files changed, 4339 insertions(+), 772 deletions(-). The main changes are: 1) The BPF verifier improvements to track register allo

Re: merge window is open. bpf-next is still open.

2020-10-12 Thread Stephen Rothwell
Hi Alexei, On Mon, 12 Oct 2020 13:15:16 -0700 Alexei Starovoitov wrote: > > You mean keep pushing into bpf-next/master ? > The only reason is linux-next. > But coming to think about it again, let's fix linux-next process instead. > > Stephen, > could you switch linux-next to take from bpf.git d

[PATCH v21 17/23] NET: Store LSM netlabel data in a lsmblob

2020-10-12 Thread Casey Schaufler
Netlabel uses LSM interfaces requiring an lsmblob and the internal storage is used to pass information between these interfaces, so change the internal data from a secid to a lsmblob. Update the netlabel interfaces and their callers to accommodate the change. This requires that the modules using ne

[PATCH v21 16/23] LSM: security_secid_to_secctx in netlink netfilter

2020-10-12 Thread Casey Schaufler
Change netlink netfilter interfaces to use lsmcontext pointers, and remove scaffolding. Reviewed-by: Kees Cook Reviewed-by: John Johansen Acked-by: Stephen Smalley Signed-off-by: Casey Schaufler Cc: netdev@vger.kernel.org Cc: netfilter-de...@vger.kernel.org --- net/netfilter/nfnetlink_queue.c

[PATCH v21 14/23] LSM: Use lsmcontext in security_secid_to_secctx

2020-10-12 Thread Casey Schaufler
Replace the (secctx,seclen) pointer pair with a single lsmcontext pointer to allow return of the LSM identifier along with the context and context length. This allows security_release_secctx() to know how to release the context. Callers have been modified to use or save the returned data from the n

[PATCH v21 13/23] LSM: Ensure the correct LSM context releaser

2020-10-12 Thread Casey Schaufler
Add a new lsmcontext data structure to hold all the information about a "security context", including the string, its size and which LSM allocated the string. The allocation information is necessary because LSMs have different policies regarding the lifecycle of these strings. SELinux allocates and

Re: merge window is open. bpf-next is still open.

2020-10-12 Thread Alexei Starovoitov
On Mon, Oct 12, 2020 at 11:00 AM Jakub Kicinski wrote: > > On Sun, 11 Oct 2020 17:59:16 -0700 Alexei Starovoitov wrote: > > Hi BPF developers, > > > > The merge window has just opened. > > Which would typically mean that bpf-next is closing, > > but things are going to be a little bit different th

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-12 Thread Jakub Kicinski
On Mon, 12 Oct 2020 21:10:53 +0200 Johannes Berg wrote: > Hi, > > Sorry, somehow didn't see this until now. > > > > +/* Lanes, 1, 2, 4 or 8. */ > > > +#define ETHTOOL_LANES_1 1 > > > +#define ETHTOOL_LANES_2 2 > > > +#define ETHTOOL_LANES_4 4 > >

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-12 Thread Matthew Wilcox
On Mon, Oct 12, 2020 at 12:53:54PM -0700, Ira Weiny wrote: > On Mon, Oct 12, 2020 at 05:44:38PM +0100, Matthew Wilcox wrote: > > On Mon, Oct 12, 2020 at 09:28:29AM -0700, Dave Hansen wrote: > > > kmap_atomic() is always preferred over kmap()/kmap_thread(). > > > kmap_atomic() is _much_ more lightwe

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-12 Thread Ira Weiny
On Mon, Oct 12, 2020 at 05:44:38PM +0100, Matthew Wilcox wrote: > On Mon, Oct 12, 2020 at 09:28:29AM -0700, Dave Hansen wrote: > > kmap_atomic() is always preferred over kmap()/kmap_thread(). > > kmap_atomic() is _much_ more lightweight since its TLB invalidation is > > always CPU-local and never b

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-12 Thread Johannes Berg
Hi, Sorry, somehow didn't see this until now. > > +/* Lanes, 1, 2, 4 or 8. */ > > +#define ETHTOOL_LANES_11 > > +#define ETHTOOL_LANES_22 > > +#define ETHTOOL_LANES_44 > > +#define ETHTOOL_LANES_88 > > Not an extreme

Re: [PATCH AUTOSEL 5.8 18/24] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails

2020-10-12 Thread Joe Perches
On Mon, 2020-10-12 at 15:02 -0400, Sasha Levin wrote: > From: Anant Thazhemadam > > [ Upstream commit f45a4248ea4cc13ed50618ff066849f9587226b2 ] > > When get_registers() fails in set_ethernet_addr(),the uninitialized > value of node_id gets copied over as the address. > So, check the return valu

[PATCH AUTOSEL 5.8 06/24] mt76: mt7615: reduce maximum VHT MPDU length to 7991

2020-10-12 Thread Sasha Levin
From: Felix Fietkau [ Upstream commit efb1676306f664625c0c546dd10d18d33c75e3fc ] After fixing mac80211 to allow larger A-MSDUs in some cases, there have been reports of performance regressions and packet loss with some clients. It appears that the issue occurs when the hardware is transmitting A

[PATCH AUTOSEL 5.8 07/24] drivers/net/wan/x25_asy: Correct the ndo_open and ndo_stop functions

2020-10-12 Thread Sasha Levin
From: Xie He [ Upstream commit ed46cd1d4cc4b2cf05f31fe25fc68d1a9d3589ba ] 1. Move the lapb_register/lapb_unregister calls into the ndo_open/ndo_stop functions. This makes the LAPB protocol start/stop when the network interface starts/stops. When the network interface is down, the LAPB protocol s

[PATCH AUTOSEL 5.8 11/24] net: atlantic: fix build when object tree is separate

2020-10-12 Thread Sasha Levin
From: Igor Russkikh [ Upstream commit 059432495e209279bae12db3d2b0bc8c8fe987bb ] Driver subfolder files refer parent folder includes in an absolute manner. Makefile contains a -I for this, but apparently that does not work if object tree is separated. Adding srctree to fix that. Signed-off-by

[PATCH AUTOSEL 5.8 14/24] via-rhine: Fix for the hardware having a reset failure after resume

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit d120c9a81e32c43cba8017dec873b6a414898716 ] In rhine_resume() and rhine_suspend(), the code calls netif_running() to see if the network interface is down or not. If it is down (i.e., netif_running() returning false), they will skip any housekeeping work within

[PATCH AUTOSEL 5.8 09/24] net/fsl: quieten expected MDIO access failures

2020-10-12 Thread Sasha Levin
From: Jamie Iles [ Upstream commit 1ec8e74855588cecb2620b28b877c08f45765374 ] MDIO reads can happen during PHY probing, and printing an error with dev_err can result in a large number of error messages during device probe. On a platform with a serial console this can result in excessively long

[PATCH AUTOSEL 5.8 12/24] net: usb: ax88179_178a: add MCT usb 3.0 adapter

2020-10-12 Thread Sasha Levin
From: Wilken Gottwalt [ Upstream commit c92a79829c7c169139874aa1d4bf6da32d10c38a ] Adds the driver_info and usb ids of the AX88179 based MCT U3-A9003 USB 3.0 ethernet adapter. Signed-off-by: Wilken Gottwalt Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/ax8817

[PATCH AUTOSEL 5.8 10/24] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-10-12 Thread Sasha Levin
From: Wilken Gottwalt [ Upstream commit e42d72fea91f8f2e82b65808739ca04b7a8cd7a8 ] Adds the driver_info and usb ids of the AX88179 based Toshiba USB 3.0 ethernet adapter. Signed-off-by: Wilken Gottwalt Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/ax88179_178

[PATCH AUTOSEL 5.8 15/24] via-rhine: VTunknown1 device is really VT8251 South Bridge

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit aa15190cf2cf25ec7e6c6d7373ae3ca563d48601 ] The VIA Technologies VT8251 South Bridge's integrated Rhine-II Ethernet MAC comes has a PCI revision value of 0x7c. This was verified on ASUS P5V800-VM mainboard. Signed-off-by: Kevin Brace Signed-off-by: David S.

[PATCH AUTOSEL 5.8 13/24] net: dsa: felix: fix incorrect action offsets for VCAP IS2

2020-10-12 Thread Sasha Levin
From: Vladimir Oltean [ Upstream commit 460e985ea07ec23d46af257e84e57b5409576577 ] The port mask width was larger than the actual number of ports, and therefore, all fields following this one were also shifted by the number of excess bits. But the driver doesn't use the REW_OP, SMAC_REPLACE_ENA

[PATCH AUTOSEL 5.4 01/15] net: lantiq: Add locking for TX DMA channel

2020-10-12 Thread Sasha Levin
From: Hauke Mehrtens [ Upstream commit f9317ae5523f9fb54c513ebabbb2bc887ddf ] The TX DMA channel data is accessed by the xrx200_start_xmit() and the xrx200_tx_housekeeping() function from different threads. Make sure the accesses are synchronized by acquiring the netif_tx_lock() in the xrx20

[PATCH AUTOSEL 5.4 04/15] drivers/net/wan/x25_asy: Correct the ndo_open and ndo_stop functions

2020-10-12 Thread Sasha Levin
From: Xie He [ Upstream commit ed46cd1d4cc4b2cf05f31fe25fc68d1a9d3589ba ] 1. Move the lapb_register/lapb_unregister calls into the ndo_open/ndo_stop functions. This makes the LAPB protocol start/stop when the network interface starts/stops. When the network interface is down, the LAPB protocol s

[PATCH AUTOSEL 5.4 05/15] net: mscc: ocelot: fix fields offset in SG_CONFIG_REG_3

2020-10-12 Thread Sasha Levin
From: Xiaoliang Yang [ Upstream commit 4ab810a4e04ab6c851007033d39c13e6d3f55110 ] INIT_IPS and GATE_ENABLE fields have a wrong offset in SG_CONFIG_REG_3. This register is used by stream gate control of PSFP, and it has not been used before, because PSFP is not implemented in ocelot driver. Sign

[PATCH AUTOSEL 5.4 07/15] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-10-12 Thread Sasha Levin
From: Wilken Gottwalt [ Upstream commit e42d72fea91f8f2e82b65808739ca04b7a8cd7a8 ] Adds the driver_info and usb ids of the AX88179 based Toshiba USB 3.0 ethernet adapter. Signed-off-by: Wilken Gottwalt Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/ax88179_178

[PATCH AUTOSEL 5.4 09/15] via-rhine: Fix for the hardware having a reset failure after resume

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit d120c9a81e32c43cba8017dec873b6a414898716 ] In rhine_resume() and rhine_suspend(), the code calls netif_running() to see if the network interface is down or not. If it is down (i.e., netif_running() returning false), they will skip any housekeeping work within

[PATCH AUTOSEL 5.4 10/15] via-rhine: VTunknown1 device is really VT8251 South Bridge

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit aa15190cf2cf25ec7e6c6d7373ae3ca563d48601 ] The VIA Technologies VT8251 South Bridge's integrated Rhine-II Ethernet MAC comes has a PCI revision value of 0x7c. This was verified on ASUS P5V800-VM mainboard. Signed-off-by: Kevin Brace Signed-off-by: David S.

[PATCH AUTOSEL 5.4 11/15] net: usb: pegasus: Proper error handing when setting pegasus' MAC address

2020-10-12 Thread Sasha Levin
From: Petko Manolov [ Upstream commit f30e25a9d1b25ac8d40071c4dc2679ad0fcdc55a ] v2: If reading the MAC address from eeprom fail don't throw an error, use randomly generated MAC instead. Either way the adapter will soldier on and the return type of set_ethernet_addr() can be reverted to void.

[PATCH AUTOSEL 5.4 08/15] net: usb: ax88179_178a: add MCT usb 3.0 adapter

2020-10-12 Thread Sasha Levin
From: Wilken Gottwalt [ Upstream commit c92a79829c7c169139874aa1d4bf6da32d10c38a ] Adds the driver_info and usb ids of the AX88179 based MCT U3-A9003 USB 3.0 ethernet adapter. Signed-off-by: Wilken Gottwalt Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/ax8817

[PATCH AUTOSEL 5.4 06/15] net/fsl: quieten expected MDIO access failures

2020-10-12 Thread Sasha Levin
From: Jamie Iles [ Upstream commit 1ec8e74855588cecb2620b28b877c08f45765374 ] MDIO reads can happen during PHY probing, and printing an error with dev_err can result in a large number of error messages during device probe. On a platform with a serial console this can result in excessively long

[PATCH AUTOSEL 4.14 02/11] net/fsl: quieten expected MDIO access failures

2020-10-12 Thread Sasha Levin
From: Jamie Iles [ Upstream commit 1ec8e74855588cecb2620b28b877c08f45765374 ] MDIO reads can happen during PHY probing, and printing an error with dev_err can result in a large number of error messages during device probe. On a platform with a serial console this can result in excessively long

[PATCH AUTOSEL 4.14 04/11] net: usb: ax88179_178a: add MCT usb 3.0 adapter

2020-10-12 Thread Sasha Levin
From: Wilken Gottwalt [ Upstream commit c92a79829c7c169139874aa1d4bf6da32d10c38a ] Adds the driver_info and usb ids of the AX88179 based MCT U3-A9003 USB 3.0 ethernet adapter. Signed-off-by: Wilken Gottwalt Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/ax8817

[PATCH AUTOSEL 4.19 12/12] net: usb: qmi_wwan: add Cellient MPL200 card

2020-10-12 Thread Sasha Levin
From: Wilken Gottwalt [ Upstream commit 28802e7c0c9954218d1830f7507edc9d49b03a00 ] Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gottwalt Acked-by: Bjørn Mork Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 i

[PATCH AUTOSEL 4.19 02/12] net: mscc: ocelot: fix fields offset in SG_CONFIG_REG_3

2020-10-12 Thread Sasha Levin
From: Xiaoliang Yang [ Upstream commit 4ab810a4e04ab6c851007033d39c13e6d3f55110 ] INIT_IPS and GATE_ENABLE fields have a wrong offset in SG_CONFIG_REG_3. This register is used by stream gate control of PSFP, and it has not been used before, because PSFP is not implemented in ocelot driver. Sign

[PATCH AUTOSEL 4.19 09/12] net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails

2020-10-12 Thread Sasha Levin
From: Anant Thazhemadam [ Upstream commit f45a4248ea4cc13ed50618ff066849f9587226b2 ] When get_registers() fails in set_ethernet_addr(),the uninitialized value of node_id gets copied over as the address. So, check the return value of get_registers(). If get_registers() executed successfully (i.e

[PATCH AUTOSEL 5.4 15/15] net: usb: qmi_wwan: add Cellient MPL200 card

2020-10-12 Thread Sasha Levin
From: Wilken Gottwalt [ Upstream commit 28802e7c0c9954218d1830f7507edc9d49b03a00 ] Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gottwalt Acked-by: Bjørn Mork Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 i

[PATCH AUTOSEL 4.14 11/11] net: usb: qmi_wwan: add Cellient MPL200 card

2020-10-12 Thread Sasha Levin
From: Wilken Gottwalt [ Upstream commit 28802e7c0c9954218d1830f7507edc9d49b03a00 ] Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gottwalt Acked-by: Bjørn Mork Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 i

[PATCH AUTOSEL 4.4 3/6] via-rhine: Fix for the hardware having a reset failure after resume

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit d120c9a81e32c43cba8017dec873b6a414898716 ] In rhine_resume() and rhine_suspend(), the code calls netif_running() to see if the network interface is down or not. If it is down (i.e., netif_running() returning false), they will skip any housekeeping work within

[PATCH AUTOSEL 4.14 03/11] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-10-12 Thread Sasha Levin
From: Wilken Gottwalt [ Upstream commit e42d72fea91f8f2e82b65808739ca04b7a8cd7a8 ] Adds the driver_info and usb ids of the AX88179 based Toshiba USB 3.0 ethernet adapter. Signed-off-by: Wilken Gottwalt Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/ax88179_178

  1   2   3   4   >