[PATCH] net: usb: rtl8150: don't incorrectly assign random MAC addresses

2020-10-09 Thread Anant Thazhemadam
get_registers() directly returns the return value of usb_control_msg_recv() - 0 if successful, and negative error number otherwise. However, in set_ethernet_addr(), this return value is incorrectly checked. Since this return value will never be equal to sizeof(node_id), a random MAC address wil

Re: [PATCH RFC PKS/PMEM 51/58] kernel: Utilize new kmap_thread()

2020-10-09 Thread Eric W. Biederman
ira.we...@intel.com writes: > From: Ira Weiny > > This kmap() call is localized to a single thread. To avoid the over > head of global PKRS updates use the new kmap_thread() call. Acked-by: "Eric W. Biederman" > > Cc: Eric Biederman > Signed-off-by: Ira Weiny > --- > kernel/kexec_core.c |

RE: [EXT] Re: [PATCH v6 3/3] net: dsa: ocelot: Add support for QinQ Operation

2020-10-09 Thread Hongbo Wang
Hi Vladimir, > > I asked this on the Microchip Support portal: > > -[cut here]- > > VLAN filtering only on specific TPID > > > I would like to configure a port with the following behavior: > - The VL

Re: [PATCH net 2/2] socket: don't clear SOCK_TSTAMP_NEW when SO_TIMESTAMPNS is disabled

2020-10-09 Thread Deepa Dinamani
On Fri, Oct 9, 2020 at 5:35 PM Willem de Bruijn wrote: > > On Fri, Oct 9, 2020 at 6:32 AM Christian Eggers wrote: > > > > SOCK_TSTAMP_NEW (timespec64 instead of timespec) is also used for > > hardware time stamps (configured via SO_TIMESTAMPING_NEW). > > > > User space (ptp4l) first configures ha

Re: [PATCH v5 0/2] netlink: export policy on validation failures

2020-10-09 Thread Jakub Kicinski
On Thu, 8 Oct 2020 12:45:15 +0200 Johannes Berg wrote: > Export the policy used for attribute validation when it fails, > so e.g. for an out-of-range attribute userspace immediately gets > the valid ranges back. > > v2 incorporates the suggestion from Jakub to have a function to > estimate the si

Re: [PATCH net 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-09 Thread Deepa Dinamani
On Fri, Oct 9, 2020 at 5:43 PM Willem de Bruijn wrote: > > On Fri, Oct 9, 2020 at 8:30 PM Deepa Dinamani wrote: > > > > On Fri, Oct 9, 2020 at 3:32 AM Christian Eggers wrote: > > > > > > The comparison of optname with SO_TIMESTAMPING_NEW is wrong way around, > > > so SOCK_TSTAMP_NEW will first b

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-09 Thread James Bottomley
On Fri, 2020-10-09 at 14:34 -0700, Eric Biggers wrote: > On Fri, Oct 09, 2020 at 12:49:57PM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The kmap() calls in this FS are localized to a single thread. To > > avoid the over head of global PKRS updates use the new > > kmap_thread()

Re: [Patch net] ip_gre: set dev->hard_header_len properly

2020-10-09 Thread Xie He
On Fri, Oct 9, 2020 at 6:07 PM Cong Wang wrote: > > Looking a bit deeper, I doubt the ipgre_header_ops->create is necessary, > because 1) all other tunnels devices do not have it (ip_tunnel_header_ops > only contains ->parse_protocol); 2) GRE headers are pushed in xmit > anyway, so at least SOCK_D

Re: [PATCH v3 3/3] vhost: Don't call log_access_ok() when using IOTLB

2020-10-09 Thread Jason Wang
On 2020/10/3 下午6:02, Greg Kurz wrote: When the IOTLB device is enabled, the log_guest_addr that is passed by userspace to the VHOST_SET_VRING_ADDR ioctl, and which is then written to vq->log_addr, is a GIOVA. All writes to this address are translated by log_user() to writes to an HVA, and then

Re: [PATCH RFC PKS/PMEM 57/58] nvdimm/pmem: Stray access protection for pmem->virt_addr

2020-10-09 Thread John Hubbard
On 10/9/20 12:50 PM, ira.we...@intel.com wrote: From: Ira Weiny The pmem driver uses a cached virtual address to access its memory directly. Because the nvdimm driver is well aware of the special protections it has mapped memory with, we call dev_access_[en|dis]able() around the direct pmem->v

Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

2020-10-09 Thread Jason Wang
On 2020/10/3 下午1:02, Si-Wei Liu wrote: Pinned pages are not properly accounted particularly when mapping error occurs on IOTLB update. Clean up dangling pinned pages for the error path. As the inflight pinned pages, specifically for memory region that strides across multiple chunks, would need

Re: [PATCH v3 2/3] vhost: Use vhost_get_used_size() in vhost_vring_set_addr()

2020-10-09 Thread Jason Wang
On 2020/10/3 下午6:02, Greg Kurz wrote: The open-coded computation of the used size doesn't take the event into account when the VIRTIO_RING_F_EVENT_IDX feature is present. Fix that by using vhost_get_used_size(). Signed-off-by: Greg Kurz --- drivers/vhost/vhost.c |3 +-- 1 file changed,

Re: [PATCH RFC PKS/PMEM 48/58] drivers/md: Utilize new kmap_thread()

2020-10-09 Thread Coly Li
On 2020/10/10 03:50, ira.we...@intel.com wrote: > From: Ira Weiny > > These kmap() calls are localized to a single thread. To avoid the over > head of global PKRS updates use the new kmap_thread() call. > Hi Ira, There were a number of options considered. 1) Attempt to change all the thread

Re: [PATCH v4,net-next,00/13] Add Support for Marvell OcteonTX2 Cryptographic

2020-10-09 Thread Jakub Kicinski
On Fri, 9 Oct 2020 21:04:08 +0530 Srujana Challa wrote: > This series introduces crypto(CPT) drivers(PF & VF) for Marvell OcteonTX2 > CN96XX Soc. > > OcteonTX2 SOC's resource virtualization unit (RVU) supports multiple > physical and virtual functions. Each of the PF/VF's functionality is > determ

Re: [PATCH net-next v2] virtio-net: ethtool configurable RXCSUM

2020-10-09 Thread Tonghao Zhang
On Fri, Oct 9, 2020 at 9:49 PM Willem de Bruijn wrote: > > On Thu, Oct 8, 2020 at 9:19 PM Tonghao Zhang wrote: > > > > On Wed, Sep 30, 2020 at 6:05 PM Willem de Bruijn > > wrote: > > > > > > On Wed, Sep 30, 2020 at 4:05 AM wrote: > > > > > > > > From: Tonghao Zhang > > > > > > > > Allow user c

Re: [PATCH v3 1/2] vhost-vdpa: fix vhost_vdpa_map() on error condition

2020-10-09 Thread Jason Wang
On 2020/10/3 下午1:02, Si-Wei Liu wrote: vhost_vdpa_map() should remove the iotlb entry just added if the corresponding mapping fails to set up properly. Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend") Signed-off-by: Si-Wei Liu --- drivers/vhost/vdpa.c | 3 +++ 1 file changed, 3

Re: [PATCH net-next v4 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-09 Thread Jakub Kicinski
On Fri, 9 Oct 2020 14:35:27 + Henrik Bjoernlund wrote: > +static inline struct mac_addr nla_get_mac(const struct nlattr *nla) static inlines are generally not needed in C sources and just hide unused code. Please drop the inline annotation. > +{ > + struct mac_addr mac; > + > + nla_me

Re: [PATCH] net: Add mhi-net driver

2020-10-09 Thread Jakub Kicinski
On Fri, 9 Oct 2020 22:33:31 +0200 Loic Poulain wrote: > This patch adds a new network driver implementing MHI transport for > network packets. Packets can be in any format, though QMAP (rmnet) > is the usual protocol (flow control + PDN mux). > > It support two MHI devices, IP_HW0 which is, the p

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-09 Thread Eric Biggers
On Sat, Oct 10, 2020 at 01:39:54AM +0100, Matthew Wilcox wrote: > On Fri, Oct 09, 2020 at 02:34:34PM -0700, Eric Biggers wrote: > > On Fri, Oct 09, 2020 at 12:49:57PM -0700, ira.we...@intel.com wrote: > > > The kmap() calls in this FS are localized to a single thread. To avoid > > > the over head

Re: [Patch net] tipc: fix the skb_unshare() in tipc_buf_append()

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 21:12:50 -0700 Cong Wang wrote: > skb_unshare() drops a reference count on the old skb unconditionally, > so in the failure case, we end up freeing the skb twice here. > And because the skb is allocated in fclone and cloned by caller > tipc_msg_reassemble(), the consequence is a

Re: [PATCH net-next 0/3] net/smc: updates 2020-10-07

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 22:57:40 +0200 Karsten Graul wrote: > Please apply the following patch series for smc to netdev's net-next tree. > > Patch 1 and 2 address warnings from static code checkers, and patch 3 handles > a case when all proposed ISM V2 devices fail to init and no V1 devices are > trie

Re: pull-request: can-next 2020-10-07

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 23:31:42 +0200 Marc Kleine-Budde wrote: > The first 3 patches are by me and fix several warnings found when compiling > the > kernel with W=1. > > Lukas Bulwahn's patch adjusts the MAINTAINERS file, to accommodate the > renaming > of the mcp251xfd driver. > > Vincent Mailh

Re: [Patch net] ip_gre: set dev->hard_header_len properly

2020-10-09 Thread Cong Wang
On Fri, Oct 9, 2020 at 1:38 PM Cong Wang wrote: > > Interesting point. I think needed_headroom is 0 until we call > ipgre_changelink(), but needed_headroom is already being used > in multiple places for skb_cow_head() in the same file, I guess > they should be replaced with hard_head_len because f

Re: [PATCH bpf-next v4 3/6] bpf: allow for map-in-map with dynamic inner array map entries

2020-10-09 Thread Andrii Nakryiko
On Fri, Oct 9, 2020 at 5:10 PM Daniel Borkmann wrote: > > On 10/10/20 1:01 AM, Andrii Nakryiko wrote: > > On Fri, Oct 9, 2020 at 3:40 PM Daniel Borkmann wrote: > [...] > >> *insn++ = BPF_ALU64_IMM(BPF_ADD, map_ptr, offsetof(struct > >> bpf_array, value)); > >> *insn++ = BPF_LDX

Re: [PATCH 08/17] can: add ISO 15765-2:2016 transport protocol

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 23:31:50 +0200 Marc Kleine-Budde wrote: > From: Oliver Hartkopp > > CAN Transport Protocols offer support for segmented Point-to-Point > communication between CAN nodes via two defined CAN Identifiers. > As CAN frames can only transport a small amount of data bytes > (max. 8 b

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-09 Thread Matthew Wilcox
On Fri, Oct 09, 2020 at 02:34:34PM -0700, Eric Biggers wrote: > On Fri, Oct 09, 2020 at 12:49:57PM -0700, ira.we...@intel.com wrote: > > The kmap() calls in this FS are localized to a single thread. To avoid > > the over head of global PKRS updates use the new kmap_thread() call. > > > > @@ -2410,

Re: [PATCH net 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-09 Thread Deepa Dinamani
On Fri, Oct 9, 2020 at 3:32 AM Christian Eggers wrote: > > The comparison of optname with SO_TIMESTAMPING_NEW is wrong way around, > so SOCK_TSTAMP_NEW will first be set and than reset again. Additionally > move it out of the test for SOF_TIMESTAMPING_RX_SOFTWARE as this seems > unrelated. The SO

Re: [PATCH net 2/2] socket: don't clear SOCK_TSTAMP_NEW when SO_TIMESTAMPNS is disabled

2020-10-09 Thread Willem de Bruijn
On Fri, Oct 9, 2020 at 6:32 AM Christian Eggers wrote: > > SOCK_TSTAMP_NEW (timespec64 instead of timespec) is also used for > hardware time stamps (configured via SO_TIMESTAMPING_NEW). > > User space (ptp4l) first configures hardware time stamping via > SO_TIMESTAMPING_NEW which sets SOCK_TSTAMP_

Re: [PATCH net 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-09 Thread Willem de Bruijn
On Fri, Oct 9, 2020 at 6:32 AM Christian Eggers wrote: > > The comparison of optname with SO_TIMESTAMPING_NEW is wrong way around, > so SOCK_TSTAMP_NEW will first be set and than reset again. Additionally > move it out of the test for SOF_TIMESTAMPING_RX_SOFTWARE as this seems > unrelated. > > Thi

Re: [PATCH bpf-next v4 3/6] bpf: allow for map-in-map with dynamic inner array map entries

2020-10-09 Thread Daniel Borkmann
On 10/10/20 1:01 AM, Andrii Nakryiko wrote: On Fri, Oct 9, 2020 at 3:40 PM Daniel Borkmann wrote: [...] *insn++ = BPF_ALU64_IMM(BPF_ADD, map_ptr, offsetof(struct bpf_array, value)); *insn++ = BPF_LDX_MEM(BPF_W, ret, index, 0); if (!map->bypass_spec_v1) { @@ -496,8 +

Re: [PATCH net] net/tls: remove a duplicate function prototype

2020-10-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 8 Oct 2020 22:49:00 -0700 you wrote: > Remove one of the two instances of the function prototype for > tls_validate_xmit_skb(). > > Signed-off-by: Randy Dunlap > Cc: Boris Pismenny > Cc: Aviad Yehezkel > Cc: John Fa

Re: [PATCH net] net/tls: remove a duplicate function prototype

2020-10-09 Thread Jakub Kicinski
On Thu, 8 Oct 2020 22:49:00 -0700 Randy Dunlap wrote: > Remove one of the two instances of the function prototype for > tls_validate_xmit_skb(). > > Signed-off-by: Randy Dunlap Applied, thanks.

Re: [PATCH net v3] net/tls: sendfile fails with ktls offload

2020-10-09 Thread Jakub Kicinski
On Thu, 8 Oct 2020 00:10:21 +0530 Rohit Maheshwari wrote: > At first when sendpage gets called, if there is more data, 'more' in > tls_push_data() gets set which later sets pending_open_record_frags, but > when there is no more data in file left, and last time tls_push_data() > gets called, pendin

Re: [net-next 1/3] i40e: Allow changing FEC settings on X722 if supported by FW

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 16:10:48 -0700 Tony Nguyen wrote: > + if (hw->mac.type == I40E_MAC_X722 && > + !(hw->flags & I40E_HW_FLAG_X722_FEC_REQUEST_CAPABLE)) { > + netdev_err(netdev, "Setting FEC encoding not supported by > firmware. Please update the NVM image.\n"); > +

Re: [PATCH 1/6] net: tlan: Fix typo abitrary

2020-10-09 Thread Jakub Kicinski
On Thu, 8 Oct 2020 17:47:31 +0900 Naoki Hayama wrote: > Fix comment typo. > s/abitrary/arbitrary/ > > Signed-off-by: Naoki Hayama Applied to net.

Re: [PATCH net] net:ipv6: Discard next-hop MTU less than minimum link MTU

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 14:53:02 +0200 Georg Kohmann wrote: > When a ICMPV6_PKT_TOOBIG report a next-hop MTU that is less than the IPv6 > minimum link MTU, the estimated path MTU is reduced to the minimum link > MTU. This behaviour breaks TAHI IPv6 Core Conformance Test v6LC4.1.6: > Packet Too Big Less

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 10:17:25 + Aleksandr Nogikh wrote: > From: Aleksandr Nogikh > > Remote KCOV coverage collection enables coverage-guided fuzzing of the > code that is not reachable during normal system call execution. It is > especially helpful for fuzzing networking subsystems, where it i

Re: [PATCH net v2] net: ipa: skip suspend/resume activities if not set up

2020-10-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 9 Oct 2020 15:28:48 -0500 you wrote: > When processing a system suspend request we suspend modem endpoints > if they are enabled, and call ipa_cmd_tag_process() (which issues > IPA commands) to ensure the IPA pipeline i

Re: [PATCH bpf-next v2] bpf_fib_lookup: optionally skip neighbour lookup

2020-10-09 Thread Daniel Borkmann
On 10/9/20 11:28 PM, David Ahern wrote: On 10/9/20 11:42 AM, Toke Høiland-Jørgensen wrote: David Ahern writes: On 10/9/20 3:13 AM, Toke Høiland-Jørgensen wrote: The bpf_fib_lookup() helper performs a neighbour lookup for the destination IP and returns BPF_FIB_LKUP_NO_NEIGH if this fails, with

Re: [PATCH bpf-next v4 3/6] bpf: allow for map-in-map with dynamic inner array map entries

2020-10-09 Thread Andrii Nakryiko
On Fri, Oct 9, 2020 at 3:40 PM Daniel Borkmann wrote: > > Recent work in f4d05259213f ("bpf: Add map_meta_equal map ops") and > 134fede4eecf > ("bpf: Relax max_entries check for most of the inner map types") added support > for dynamic inner max elements for most map-in-map types. Exceptions were

Re: [PATCH bpf-next V3 0/6] bpf: New approach for BPF MTU handling

2020-10-09 Thread Jakub Kicinski
On Fri, 09 Oct 2020 13:49:14 -0700 John Fastabend wrote: > Jakub Kicinski wrote: > > On Thu, 08 Oct 2020 16:08:57 +0200 Jesper Dangaard Brouer wrote: > > > V3: Drop enforcement of MTU in net-core, leave it to drivers > > > > Sorry for being late to the discussion. > > > > I absolutely disagre

[PATCH bpf-next v4 6/6] bpf, selftests: add redirect_peer selftest

2020-10-09 Thread Daniel Borkmann
Extend the test_tc_redirect test and add a small test that exercises the new redirect_peer() helper for the IPv4 and IPv6 case. Signed-off-by: Daniel Borkmann --- .../selftests/bpf/progs/test_tc_peer.c| 45 +++ .../testing/selftests/bpf/test_tc_redirect.sh | 25 +++---

[PATCH bpf-next v4 5/6] bpf, selftests: make redirect_neigh test more extensible

2020-10-09 Thread Daniel Borkmann
Rename into test_tc_redirect.sh and move setup and test code into separate functions so they can be reused for newly added tests in here. Also remove the crude hack to override ifindex inside the object file via xxd and sed and just use a simple map instead. Map given iproute2 does not support BTF

[PATCH bpf-next v4 3/6] bpf: allow for map-in-map with dynamic inner array map entries

2020-10-09 Thread Daniel Borkmann
Recent work in f4d05259213f ("bpf: Add map_meta_equal map ops") and 134fede4eecf ("bpf: Relax max_entries check for most of the inner map types") added support for dynamic inner max elements for most map-in-map types. Exceptions were maps like array or prog array where the map_gen_lookup() callback

[PATCH bpf-next v4 2/6] bpf: add redirect_peer helper

2020-10-09 Thread Daniel Borkmann
Add an efficient ingress to ingress netns switch that can be used out of tc BPF programs in order to redirect traffic from host ns ingress into a container veth device ingress without having to go via CPU backlog queue [0]. For local containers this can also be utilized and path via CPU backlog que

[PATCH bpf-next v4 0/6] Follow-up BPF helper improvements

2020-10-09 Thread Daniel Borkmann
This series addresses most of the feedback [0] that was to be followed up from the last series, that is, UAPI helper comment improvements and getting rid of the ifindex obj file hacks in the selftest by using a BPF map instead. The __sk_buff data/data_end pointer work, I'm planning to do in a later

[PATCH bpf-next v4 4/6] bpf, selftests: add test for different array inner map size

2020-10-09 Thread Daniel Borkmann
Extend the "diff_size" subtest to also include a non-inlined array map variant where dynamic inner #elems are possible. Signed-off-by: Daniel Borkmann Acked-by: Yonghong Song --- .../selftests/bpf/prog_tests/btf_map_in_map.c | 39 - .../selftests/bpf/progs/test_btf_map_in_map.c

[PATCH bpf-next v4 1/6] bpf: improve bpf_redirect_neigh helper description

2020-10-09 Thread Daniel Borkmann
Follow-up to address David's feedback that we should better describe internals of the bpf_redirect_neigh() helper. Suggested-by: David Ahern Signed-off-by: Daniel Borkmann Reviewed-by: David Ahern --- include/uapi/linux/bpf.h | 10 +++--- tools/include/uapi/linux/bpf.h | 10 +++--

Re: [PATCH RFC PKS/PMEM 09/58] drivers/gpu: Utilize new kmap_thread()

2020-10-09 Thread Daniel Vetter
On Fri, Oct 09, 2020 at 12:49:44PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > These kmap() calls in the gpu stack are localized to a single thread. > To avoid the over head of global PKRS updates use the new kmap_thread() > call. > > Cc: David Airlie > Cc: Daniel Vetter > Cc: Patr

Re: [PATCH net-next v4 10/10] bridge: cfm: Netlink Notifications.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This is the implementation of Netlink notifications out of CFM. > > Notifications are initiated whenever a state change happens in CFM. > > IFLA_BRIDGE_CFM: > Points to the CFM information. > > IFLA_BRIDGE_CFM_MEP_STATUS_INFO: >

Re: [PATCH net-next v4 09/10] bridge: cfm: Netlink GET status Interface.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This is the implementation of CFM netlink status > get information interface. > > Add new nested netlink attributes. These attributes are used by the > user space to get status information. > > GETLINK: > Request filter RTEXT_FILTE

Re: [PATCH net-next v4 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-09 Thread Nikolay Aleksandrov
On Sat, 2020-10-10 at 00:56 +0300, Nikolay Aleksandrov wrote: > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink configuration > > get information interface. > > > > Add new nested netlink attributes. These attributes are used by the > > use

Re: [PATCH net-next v4 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This is the implementation of CFM netlink configuration > get information interface. > > Add new nested netlink attributes. These attributes are used by the > user space to get configuration information. > > GETLINK: > Request filt

Re: [PATCH net-next v4 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This is the implementation of CFM netlink configuration > set information interface. > > Add new nested netlink attributes. These attributes are used by the > user space to create/delete/configure CFM instances. > > SETLINK: > IFLA

Re: [PATCH net-next v4 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This is the third commit of the implementation of the CFM protocol > according to 802.1Q section 12.14. > > Functionality is extended with CCM frame reception. > The MEP instance now contains CCM based status information. > Most importa

Re: [PATCH net-next v4 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This is the second commit of the implementation of the CFM protocol > according to 802.1Q section 12.14. > > Functionality is extended with CCM frame transmission. > > Interface is extended with these functions: > br_cfm_cc_rdi_set() >

Re: [PATCH net-next v4 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This is the first commit of the implementation of the CFM protocol > according to 802.1Q section 12.14. > > It contains MEP instance create, delete and configuration. > > Connectivity Fault Management (CFM) comprises capabilities for >

Re: [PATCH net-next v4 01/10] net: bridge: extend the process of special frames

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This patch extends the processing of frames in the bridge. Currently MRP > frames needs special processing and the current implementation doesn't > allow a nice way to process different frame types. Therefore try to > improve this by add

Re: [PATCH net-next v4 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This EtherType is used by all CFM protocal frames transmitted > according to 802.1Q section 12.14. > > Signed-off-by: Henrik Bjoernlund > Reviewed-by: Horatiu Vultur > Acked-by: Nikolay Aleksandrov > --- > include/uapi/linux/if_et

Re: [PATCH net-next v4 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This makes it possible to include or exclude the CFM > protocol according to 802.1Q section 12.14. > > Signed-off-by: Henrik Bjoernlund > Reviewed-by: Horatiu Vultur > --- > net/bridge/Kconfig | 11 +++ > net/bridge/br

Re: [PATCH net-next v4 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-10-09 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This makes it possible to include or exclude the CFM > protocol according to 802.1Q section 12.14. > > Signed-off-by: Henrik Bjoernlund > Reviewed-by: Horatiu Vultur > --- > net/bridge/Kconfig | 11 +++ > net/bridge/br

Re: [PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-09 Thread Eric Biggers
On Fri, Oct 09, 2020 at 12:49:57PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Jaegeuk Kim > Cc: Chao Yu > Signed-off-by: Ira Weiny

Re: [PATCH bpf-next v2] bpf_fib_lookup: optionally skip neighbour lookup

2020-10-09 Thread David Ahern
On 10/9/20 11:42 AM, Toke Høiland-Jørgensen wrote: > David Ahern writes: > >> On 10/9/20 3:13 AM, Toke Høiland-Jørgensen wrote: >>> The bpf_fib_lookup() helper performs a neighbour lookup for the destination >>> IP and returns BPF_FIB_LKUP_NO_NEIGH if this fails, with the expectation >>> that the

Re: [PATCH bpf-next v3 3/6] bpf: allow for map-in-map with dynamic inner array map entries

2020-10-09 Thread Daniel Borkmann
On 10/9/20 11:04 PM, Alexei Starovoitov wrote: On Fri, Oct 09, 2020 at 10:42:42PM +0200, Daniel Borkmann wrote: diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index b97bc5abb3b8..593963e40956 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h @@ -435,6 +435,11

Re: [PATCH bpf-next V3 0/6] bpf: New approach for BPF MTU handling

2020-10-09 Thread Alexei Starovoitov
On Fri, Oct 09, 2020 at 01:49:14PM -0700, John Fastabend wrote: > Jakub Kicinski wrote: > > On Thu, 08 Oct 2020 16:08:57 +0200 Jesper Dangaard Brouer wrote: > > > V3: Drop enforcement of MTU in net-core, leave it to drivers > > > > Sorry for being late to the discussion. > > > > I absolutely disa

Re: [PATCH bpf-next v3 3/6] bpf: allow for map-in-map with dynamic inner array map entries

2020-10-09 Thread Alexei Starovoitov
On Fri, Oct 09, 2020 at 10:42:42PM +0200, Daniel Borkmann wrote: > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index b97bc5abb3b8..593963e40956 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -435,6 +435,11 @@ enum { > > /* Share perf_event am

Re: [PATCH bpf-next V3 0/6] bpf: New approach for BPF MTU handling

2020-10-09 Thread John Fastabend
Jakub Kicinski wrote: > On Thu, 08 Oct 2020 16:08:57 +0200 Jesper Dangaard Brouer wrote: > > V3: Drop enforcement of MTU in net-core, leave it to drivers > > Sorry for being late to the discussion. > > I absolutely disagree. We had cases in the past where HW would lock up > if it was sent a frame

[PATCH bpf-next v3 1/6] bpf: improve bpf_redirect_neigh helper description

2020-10-09 Thread Daniel Borkmann
Follow-up to address David's feedback that we should better describe internals of the bpf_redirect_neigh() helper. Suggested-by: David Ahern Signed-off-by: Daniel Borkmann Reviewed-by: David Ahern --- include/uapi/linux/bpf.h | 10 +++--- tools/include/uapi/linux/bpf.h | 10 +++--

[PATCH bpf-next v3 3/6] bpf: allow for map-in-map with dynamic inner array map entries

2020-10-09 Thread Daniel Borkmann
Recent work in f4d05259213f ("bpf: Add map_meta_equal map ops") and 134fede4eecf ("bpf: Relax max_entries check for most of the inner map types") added support for dynamic inner max elements for most map-in-map types. Exceptions were maps like array or prog array where the map_gen_lookup() callback

[PATCH bpf-next v3 4/6] bpf, selftests: add test for different array inner map size

2020-10-09 Thread Daniel Borkmann
Extend the "diff_size" subtest to also include a non-inlined array map variant where dynamic inner #elems are possible. Signed-off-by: Daniel Borkmann Acked-by: Yonghong Song --- .../selftests/bpf/prog_tests/btf_map_in_map.c | 39 - .../selftests/bpf/progs/test_btf_map_in_map.c

[PATCH bpf-next v3 2/6] bpf: add redirect_peer helper

2020-10-09 Thread Daniel Borkmann
Add an efficient ingress to ingress netns switch that can be used out of tc BPF programs in order to redirect traffic from host ns ingress into a container veth device ingress without having to go via CPU backlog queue [0]. For local containers this can also be utilized and path via CPU backlog que

[PATCH bpf-next v3 6/6] bpf, selftests: add redirect_peer selftest

2020-10-09 Thread Daniel Borkmann
Extend the test_tc_redirect test and add a small test that exercises the new redirect_peer() helper for the IPv4 and IPv6 case. Signed-off-by: Daniel Borkmann --- .../selftests/bpf/progs/test_tc_peer.c| 45 +++ .../testing/selftests/bpf/test_tc_redirect.sh | 25 +++---

[PATCH bpf-next v3 5/6] bpf, selftests: make redirect_neigh test more extensible

2020-10-09 Thread Daniel Borkmann
Rename into test_tc_redirect.sh and move setup and test code into separate functions so they can be reused for newly added tests in here. Also remove the crude hack to override ifindex inside the object file via xxd and sed and just use a simple map instead. Map given iproute2 does not support BTF

[PATCH bpf-next v3 0/6] Follow-up BPF helper improvements

2020-10-09 Thread Daniel Borkmann
This series addresses most of the feedback [0] that was to be followed up from the last series, that is, UAPI helper comment improvements and getting rid of the ifindex obj file hacks in the selftest by using a BPF map instead. The __sk_buff data/data_end pointer work, I'm planning to do in a later

Re: [Patch net] ip_gre: set dev->hard_header_len properly

2020-10-09 Thread Cong Wang
On Fri, Oct 9, 2020 at 12:51 PM Xie He wrote: > > On Fri, Oct 9, 2020 at 12:41 PM Xie He wrote: > > > > Thanks. But there is still something that I don't understand. What is > > needed_headroom used for? If we are requesting space for t->encap_hlen > > and t->tun_hlen in hard_header_len. Do we st

[PATCH net v2] net: ipa: skip suspend/resume activities if not set up

2020-10-09 Thread Alex Elder
When processing a system suspend request we suspend modem endpoints if they are enabled, and call ipa_cmd_tag_process() (which issues IPA commands) to ensure the IPA pipeline is cleared. It is an error to attempt to issue an IPA command before setup is complete, so this is clearly a bug. But we a

[PATCH] net: Add mhi-net driver

2020-10-09 Thread Loic Poulain
This patch adds a new network driver implementing MHI transport for network packets. Packets can be in any format, though QMAP (rmnet) is the usual protocol (flow control + PDN mux). It support two MHI devices, IP_HW0 which is, the path to the IPA (IP accelerator) on qcom modem, And IP_SW0 which i

Re: [net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2020-10-07

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 10:54:39 -0700 Tony Nguyen wrote: > This series contains updates to ice driver only. > > Andy Shevchenko changes usage to %*phD format to print small buffer as hex > string. > > Bruce removes repeated words reported by checkpatch. > > Ani changes ice_info_get_dsn() to return

Re: [PATCH v2 bpf-next 0/4] bpf: Make the verifier recognize llvm register allocation patterns.

2020-10-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 8 Oct 2020 18:12:36 -0700 you wrote: > From: Alexei Starovoitov > > v1->v2: > - fixed 32-bit mov issue spotted by John. > - allowed r2=r1; r3=r2; sequence as suggested by John. > - added comments, acks, more tests.

[PATCH RFC PKS/PMEM 03/58] memremap: Add zone device access protection

2020-10-09 Thread ira . weiny
From: Ira Weiny Device managed memory exposes itself to the kernel direct map which allows stray pointers to access these device memories. Stray pointers to normal memory may result in a crash or other undesirable behavior which, while unfortunate, are usually recoverable with a reboot. Stray a

[PATCH RFC PKS/PMEM 04/58] kmap: Add stray access protection for device pages

2020-10-09 Thread ira . weiny
From: Ira Weiny Device managed pages may have additional protections. These protections need to be removed prior to valid use by kernel users. Check for special treatment of device managed pages in kmap and take action if needed. We use kmap as an interface for generic kernel code because unde

Re: [PATCH net-next] net: dsa: microchip: add ksz9563 to ksz9477 I2C driver

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 15:20:02 +0200 Andrew Lunn wrote: > On Wed, Oct 07, 2020 at 11:30:49AM +0200, Christian Eggers wrote: > > Add support for the KSZ9563 3-Port Gigabit Ethernet Switch to the > > ksz9477 driver. The KSZ9563 supports both SPI (already in) and I2C. The > > ksz9563 is already in the de

[PATCH RFC PKS/PMEM 05/58] kmap: Introduce k[un]map_thread

2020-10-09 Thread ira . weiny
From: Ira Weiny To correctly support the semantics of kmap() with Kernel protection keys (PKS), kmap() may be required to set the protections on multiple processors (globally). Enabling PKS globally can be very expensive depending on the requested operation. Furthermore, enabling a domain globa

Re: [Patch net] ip_gre: set dev->hard_header_len properly

2020-10-09 Thread Xie He
On Fri, Oct 9, 2020 at 12:41 PM Xie He wrote: > > Thanks. But there is still something that I don't understand. What is > needed_headroom used for? If we are requesting space for t->encap_hlen > and t->tun_hlen in hard_header_len. Do we still need to use > needed_headroom? It seems to me that the

[PATCH RFC PKS/PMEM 11/58] drivers/net: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in these drivers are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Jesse Brandeburg Signed-off-by: Ira Weiny --- drivers/net/ethernet/intel/igb/igb_et

[PATCH RFC PKS/PMEM 07/58] drivers/drbd: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this driver are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: Jens Axboe Signed-off-by: Ira Weiny --- drivers/block/drbd/drbd_main.c | 4 ++-- drivers/block/drbd/drbd_receiver.c | 12 ++

[PATCH RFC PKS/PMEM 08/58] drivers/firmware_loader: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this driver are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: Luis Chamberlain Signed-off-by: Ira Weiny --- drivers/base/firmware_loader/fallback.c | 4 ++-- drivers/base/firmware_loader/mai

Re: [PATCH nf v2] netfilter: conntrack: connection timeout after re-register

2020-10-09 Thread Florian Westphal
Jozsef Kadlecsik wrote: > > The "delay unregister" remark was wrt. the "all rules were deleted" > > case, i.e. add a "grace period" rather than acting right away when > > conntrack use count did hit 0. > > Now I understand it, thanks really. The hooks are removed, so conntrack > cannot "see" the

RE: [PATCH v2 bpf-next 4/4] selftests/bpf: Asm tests for the verifier regalloc tracking.

2020-10-09 Thread John Fastabend
Alexei Starovoitov wrote: > From: Alexei Starovoitov > > Add asm tests for register allocator tracking logic. > > Signed-off-by: Alexei Starovoitov > Acked-by: Andrii Nakryiko > --- > .../testing/selftests/bpf/verifier/regalloc.c | 243 ++ > 1 file changed, 243 insertions(+) >

[PATCH RFC PKS/PMEM 13/58] fs/btrfs: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this FS are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: Chris Mason Cc: Josef Bacik Cc: David Sterba Signed-off-by: Ira Weiny --- fs/btrfs/check-integrity.c | 4 ++-- fs/btrfs/compressi

[PATCH RFC PKS/PMEM 12/58] fs/afs: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this FS are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: David Howells Signed-off-by: Ira Weiny --- fs/afs/dir.c | 16 fs/afs/dir_edit.c | 16 fs/afs/

[PATCH RFC PKS/PMEM 14/58] fs/cifs: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this FS are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: Steve French Signed-off-by: Ira Weiny --- fs/cifs/cifsencrypt.c | 6 +++--- fs/cifs/file.c| 16 fs/cifs/sm

[PATCH RFC PKS/PMEM 19/58] fs/hfsplus: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this FS are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Signed-off-by: Ira Weiny --- fs/hfsplus/bitmap.c | 20 - fs/hfsplus/bnode.c | 102 ++--

[PATCH RFC PKS/PMEM 20/58] fs/jffs2: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this FS are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: David Woodhouse Cc: Richard Weinberger Signed-off-by: Ira Weiny --- fs/jffs2/file.c | 4 ++-- fs/jffs2/gc.c | 4 ++-- 2 files cha

[PATCH RFC PKS/PMEM 25/58] fs/reiserfs: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this FS are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: Jan Kara Cc: "Theodore Ts'o" Cc: Randy Dunlap Cc: Alex Shi Signed-off-by: Ira Weiny --- fs/reiserfs/journal.c | 4 ++-- 1 file ch

[PATCH RFC PKS/PMEM 24/58] fs/freevxfs: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this FS are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: Christoph Hellwig Signed-off-by: Ira Weiny --- fs/freevxfs/vxfs_immed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH RFC PKS/PMEM 21/58] fs/nfs: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this FS are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: Trond Myklebust Cc: Anna Schumaker Signed-off-by: Ira Weiny --- fs/nfs/dir.c | 20 ++-- 1 file changed, 10 insertio

[PATCH RFC PKS/PMEM 23/58] fs/fuse: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this FS are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: Miklos Szeredi Signed-off-by: Ira Weiny --- fs/fuse/readdir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH RFC PKS/PMEM 22/58] fs/f2fs: Utilize new kmap_thread()

2020-10-09 Thread ira . weiny
From: Ira Weiny The kmap() calls in this FS are localized to a single thread. To avoid the over head of global PKRS updates use the new kmap_thread() call. Cc: Jaegeuk Kim Cc: Chao Yu Signed-off-by: Ira Weiny --- fs/f2fs/f2fs.h | 8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [net v3] net: dsa: microchip: fix race condition

2020-10-09 Thread Jakub Kicinski
On Wed, 7 Oct 2020 10:55:23 +0200 Christian Eggers wrote: > Between queuing the delayed work and finishing the setup of the dsa > ports, the process may sleep in request_module() (via > phy_device_create()) and the queued work may be executed prior to the > switch net devices being registered. In k

  1   2   3   4   >