[PATCH] vdpa/mlx5: Fix dependency on MLX5_CORE

2020-10-06 Thread Eli Cohen
Remove propmt for selecting MLX5_VDPA by the user and modify MLX5_VDPA_NET to select MLX5_VDPA. Also modify MLX5_VDPA_NET to depend on mlx5_core. This fixes an issue where configuration sets 'y' for MLX5_VDPA_NET while MLX5_CORE is compiled as a module causing link errors. Reported-by: kernel tes

Re: [PATCH v2 00/29] [Set 1,2,3] Rid W=1 warnings in Wireless

2020-10-06 Thread Luca Coelho
On Tue, 2020-10-06 at 10:10 +0300, Kalle Valo wrote: > Lee Jones writes: > > > On Tue, 06 Oct 2020, Kalle Valo wrote: > > > > > Lee Jones writes: > > > > > > > On Thu, 10 Sep 2020, Lee Jones wrote: > > > > > > > > > This is a rebased/re-worked set of patches which have been > > > > > previous

[PATCH bpf-next] bpf: fix build failure for kernel/trace/bpf_trace.c with CONFIG_NET=n

2020-10-06 Thread Yonghong Song
When CONFIG_NET is not defined, I hit the following build error: kernel/trace/bpf_trace.o:(.rodata+0x110): undefined reference to `bpf_prog_test_run_raw_tp' Commit 1b4d60ec162f ("bpf: Enable BPF_PROG_TEST_RUN for raw_tracepoint") added test_run support for raw_tracepoint in /kernel/trace/bpf_

Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user space

2020-10-06 Thread Leon Romanovsky
On Tue, Oct 06, 2020 at 06:26:18AM -0700, David Miller wrote: > From: Johannes Berg > Date: Tue, 06 Oct 2020 08:43:17 +0200 > > > On Mon, 2020-10-05 at 15:07 -0700, Jakub Kicinski wrote: > >> Hi! > >> > >> This series wires up ethtool policies to ops, so they can be > >> dumped to user space for f

[PATCH net-next v2 14/16] net/mlx5: Add support for fw live patch event

2020-10-06 Thread Moshe Shemesh
Firmware live patch event notifies the driver that the firmware was just updated using live patch. In such case the driver should not reload or re-initiate entities, part to updating the firmware version and re-initiate the firmware tracer which can be updated by live patch with new strings databas

[PATCH net-next v2 16/16] devlink: Add Documentation/networking/devlink/devlink-reload.rst

2020-10-06 Thread Moshe Shemesh
Add devlink reload rst documentation file. Update index file to include it. Signed-off-by: Moshe Shemesh --- v1 -> v2: - Split first paragraph of devlink reload description to 2 sentences RFCv5 -> v1: - Rename reload_action_limit_level to reload_limit RFCv4 -> RFCv5: - Rephrase namespace change s

[PATCH net-next v2 15/16] net/mlx5: Add support for devlink reload limit no reset

2020-10-06 Thread Moshe Shemesh
Add support for devlink reload action fw_activate with reload limit no_reset which does firmware live patching, updating the firmware image without reset, no downtime and no configuration lose. The driver checks if the firmware is capable of handling the pending firmware changes as a live patch. If

Re: [PATCH bpf-next] kernel/bpf/verifier: fix build when NET is not enabled

2020-10-06 Thread Yonghong Song
On 10/6/20 7:16 PM, Randy Dunlap wrote: Fix build errors in kernel/bpf/verifier.c when CONFIG_NET is not enabled. ../kernel/bpf/verifier.c:3995:13: error: ‘btf_sock_ids’ undeclared here (not in a function); did you mean ‘bpf_sock_ops’? .btf_id = &btf_sock_ids[BTF_SOCK_TYPE_SOCK_COMMON],

Re: [PATCH iproute2-net v2] ip xfrm: support setting XFRMA_SET_MARK_MASK attribute in states

2020-10-06 Thread David Ahern
On 10/2/20 6:22 AM, Antony Antony wrote: > The XFRMA_SET_MARK_MASK attribute can be set in states (4.19+) > It is optional and the kernel default is 0x > It is the mask of XFRMA_SET_MARK(a.k.a. XFRMA_OUTPUT_MARK in 4.18) > > e.g. > ./ip/ip xfrm state add output-mark 0x6 mask 0xab proto esp

Re: [patch iproute2-next] devlink: Add health reporter test command support

2020-10-06 Thread David Ahern
On 10/1/20 12:21 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Add health reporter test command and allow user to trigger a test event. > > Signed-off-by: Jiri Pirko > --- > bash-completion/devlink | 2 +- > devlink/devlink.c | 11 +++ > man/man8/devlink-health.8 | 16 +++

Re: [iproute2-next v2] devlink: support setting the overwrite mask attribute

2020-10-06 Thread David Ahern
On 9/30/20 2:05 PM, Jacob Keller wrote: > The recently added DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK allows > userspace to indicate how a device should handle subsections of a flash > component when updating. For example, a flash component might contain > vital data such as PCIe serial number or c

[PATCH net-next v2 02/16] devlink: Add reload action option to devlink reload command

2020-10-06 Thread Moshe Shemesh
Add devlink reload action to allow the user to request a specific reload action. The action parameter is optional, if not specified then devlink driver re-init action is used (backward compatible). Note that when required to do firmware activation some drivers may need to reload the driver. On the

[PATCH net-next v2 07/16] net/mlx5: Set cap for pci sync for fw update event

2020-10-06 Thread Moshe Shemesh
Set capability to notify the firmware that this host driver is capable of handling pci sync for firmware update events. Signed-off-by: Moshe Shemesh Reviewed-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/

[PATCH net-next v2 09/16] net/mlx5: Handle sync reset now event

2020-10-06 Thread Moshe Shemesh
On sync_reset_now event the driver does reload and PCI link toggle to activate firmware upgrade reset. When the firmware sends this event it syncs the event on all PFs, so all PFs will do PCI link toggle at once. To do PCI link toggle, the driver ensures that no other device ID under the same bridg

[PATCH net-next v2 03/16] devlink: Add devlink reload limit option

2020-10-06 Thread Moshe Shemesh
Add reload limit to demand restrictions on reload actions. Reload limits supported: no_reset: No reset allowed, no down time allowed, no link flap and no configuration is lost. By default reload limit is unspecified and so no constraints on reload actions are required. Some combinations

[PATCH net-next v2 10/16] net/mlx5: Handle sync reset abort event

2020-10-06 Thread Moshe Shemesh
If firmware sends sync_reset_abort to driver the driver should clear the reset requested mode as reset is not expected any more. Signed-off-by: Moshe Shemesh Reviewed-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/fw_reset.c| 15 +++ 1 file changed, 15 insertions(+)

[PATCH net-next v2 01/16] devlink: Change devlink_reload_supported() param type

2020-10-06 Thread Moshe Shemesh
Change devlink_reload_supported() function to get devlink_ops pointer param instead of devlink pointer param. This change will be used in the next patch to check if devlink reload is supported before devlink instance is allocated. Signed-off-by: Moshe Shemesh Reviewed-by: Jakub Kicinski Reviewed

[PATCH net-next v2 04/16] devlink: Add reload stats

2020-10-06 Thread Moshe Shemesh
Add reload stats to hold the history per reload action type and limit. For example, the number of times fw_activate has been performed on this device since the driver module was added or if the firmware activation was performed with or without reset. Add devlink notification on stats update. Exp

[PATCH net-next v2 06/16] net/mlx5: Add functions to set/query MFRL register

2020-10-06 Thread Moshe Shemesh
Add functions to query and set the MFRL reset options supported by firmware. Signed-off-by: Moshe Shemesh Reviewed-by: Saeed Mahameed --- RFCv5 -> v1: - Renamed non-static functions to have module prefix --- .../net/ethernet/mellanox/mlx5/core/Makefile | 2 +- .../ethernet/mellanox/mlx5/core/

[PATCH net-next v2 05/16] devlink: Add remote reload stats

2020-10-06 Thread Moshe Shemesh
Add remote reload stats to hold the history of actions performed due devlink reload commands initiated by remote host. For example, in case firmware activation with reset finished successfully but was initiated by remote host. The function devlink_remote_reload_actions_performed() is exported to e

[PATCH net-next v2 12/16] devlink: Add enable_remote_dev_reset generic parameter

2020-10-06 Thread Moshe Shemesh
The enable_remote_dev_reset devlink param flags that the host admin allows device resets that can be initiated by other hosts. This parameter is useful for setups where a device is shared by different hosts, such as multi-host setup. Once the user set this parameter to false, the driver should NACK

[PATCH net-next v2 08/16] net/mlx5: Handle sync reset request event

2020-10-06 Thread Moshe Shemesh
Once the driver gets sync_reset_request from firmware it prepares for the coming reset and sends acknowledge. After getting this event the driver expects device reset, either it will trigger PCI reset on sync_reset_now event or such PCI reset will be triggered by another PF of the same device. So i

[PATCH net-next v2 11/16] net/mlx5: Add support for devlink reload action fw activate

2020-10-06 Thread Moshe Shemesh
Add support for devlink reload action fw_activate. To activate firmware image the mlx5 driver resets the firmware and reloads it from flash. If a new image was stored on flash it will be loaded. Once this reload command is executed the driver initiates fw sync reset flow, where the firmware synchro

[PATCH net-next v2 00/16] Add devlink reload action and limit options

2020-10-06 Thread Moshe Shemesh
Introduce new options on devlink reload API to enable the user to select the reload action required and constrains limits on these actions that he may want to ensure. Complete support for reload actions in mlx5. The following reload actions are supported: driver_reinit: driver entities re-initial

[PATCH net-next v2 13/16] net/mlx5: Add devlink param enable_remote_dev_reset support

2020-10-06 Thread Moshe Shemesh
The enable_remote_dev_reset devlink param flags that the host admin allows resets by other hosts. In case it is cleared mlx5 host PF driver will send NACK on pci sync for firmware update reset request and the command will fail. By default enable_remote_dev_reset parameter is true, so pci sync for f

Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update

2020-10-06 Thread David Ahern
On 9/30/20 4:40 PM, Jacob Keller wrote: > @@ -3124,12 +3140,19 @@ static int cmd_dev_flash_status_cb(const struct > nlmsghdr *nlh, void *data) > done = > mnl_attr_get_u64(tb[DEVLINK_ATTR_FLASH_UPDATE_STATUS_DONE]); > if (tb[DEVLINK_ATTR_FLASH_UPDATE_STATUS_TOTAL]) >

Re: [PATCH net-next 05/16] devlink: Add remote reload stats

2020-10-06 Thread Moshe Shemesh
On 10/5/2020 10:12 PM, Jacob Keller wrote: On 10/4/2020 12:09 AM, Moshe Shemesh wrote: On 10/3/2020 12:05 PM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:08PM CEST, mo...@mellanox.com wrote: Add remote reload stats to hold the history of actions performed due devlink reload commands initia

Re: [PATCH bpf-next 1/3] bpf: Propagate scalar ranges through register assignments.

2020-10-06 Thread Alexei Starovoitov
On Tue, Oct 06, 2020 at 09:42:18PM -0700, Andrii Nakryiko wrote: > > I see it differently. > > I don't like moving if (reg->id) into find_equal_scalars(). Otherwise it > > would > > have to be named something like try_find_equal_scalars(). And even with such > > "try_" prefix it's still not clean.

Re: [PATCH bpf-next 1/3] bpf: Propagate scalar ranges through register assignments.

2020-10-06 Thread Andrii Nakryiko
On Tue, Oct 6, 2020 at 9:15 PM Alexei Starovoitov wrote: > > On Tue, Oct 06, 2020 at 08:31:23PM -0700, Andrii Nakryiko wrote: > > > > > 'linked' is also wrong. The regs are exactly equal. > > > In case of pkt and other pointers two regs will have the same id > > > as well, but they will not be equ

Re: [PATCH v2] Bluetooth: Move force_bredr_smp debugfs into hci_debugfs_create_bredr

2020-10-06 Thread Claire Chang
Hi, This patch is to fix the kernel error [ 46.271811] debugfs: File 'force_bredr_smp' in directory 'hci0' already present! When powering off and on the bluetooth, the smp_register will try to create the force_bredr_smp entry again. Move the creation to hci_debugfs_create_bredr so the force_bre

Re: [PATCH bpf-next 1/3] bpf: Propagate scalar ranges through register assignments.

2020-10-06 Thread Alexei Starovoitov
On Tue, Oct 06, 2020 at 08:31:23PM -0700, Andrii Nakryiko wrote: > > > 'linked' is also wrong. The regs are exactly equal. > > In case of pkt and other pointers two regs will have the same id > > as well, but they will not be equal. Here these two scalars are equal > > otherwise doing *reg = *know

[PATCH net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-06 Thread Hangbin Liu
Based on RFC 8200, Section 4.5 Fragment Header: - If the first fragment does not include all headers through an Upper-Layer header, then that fragment should be discarded and an ICMP Parameter Problem, Code 3, message should be sent to the source of the fragment, with the Pointer

[PATCH net 0/2] IPv6: reply ICMP error with fragment doesn't contain all headers

2020-10-06 Thread Hangbin Liu
When our Engineer run latest IPv6 Core Conformance test, test v6LC.1.3.6: First Fragment Doesn’t Contain All Headers[1] failed. The test purpose is to verify that the node(Linux for example) should properly process IPv6 packets that don’t include all the headers through the Upper-Layer header. B

[PATCH net 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition

2020-10-06 Thread Hangbin Liu
Based on RFC7112, Section 6: IANA has added the following "Type 4 - Parameter Problem" message to the "Internet Control Message Protocol version 6 (ICMPv6) Parameters" registry: CODE NAME/DESCRIPTION 3 IPv6 First Fragment has incomplete IPv6 Header Chain Signed-of

[PATCH] net: wireless: nl80211: fix out-of-bounds access in nl80211_del_key()

2020-10-06 Thread Anant Thazhemadam
In nl80211_parse_key(), key.idx is first initialized as -1. If this value of key.idx remains unmodified and gets returned, and nl80211_key_allowed() also returns 0, then rdev_del_key() gets called with key.idx = -1. This causes an out-of-bounds array access. Handle this issue by checking if the

Re: [PATCH bpf-next 2/3] bpf: Track spill/fill of bounded scalars.

2020-10-06 Thread Andrii Nakryiko
On Tue, Oct 6, 2020 at 1:10 PM Alexei Starovoitov wrote: > > From: Yonghong Song > > Under register pressure the llvm may spill registers with bounds into the > stack. > The verifier has to track them through spill/fill otherwise many kinds of > bound > errors will be seen. The spill/fill of in

Re: [PATCH bpf-next 1/3] bpf: Propagate scalar ranges through register assignments.

2020-10-06 Thread Andrii Nakryiko
On Tue, Oct 6, 2020 at 7:18 PM Alexei Starovoitov wrote: > > On Tue, Oct 06, 2020 at 06:56:14PM -0700, Andrii Nakryiko wrote: > > On Tue, Oct 6, 2020 at 1:14 PM Alexei Starovoitov > > wrote: > > > > > > From: Alexei Starovoitov > > > > > > The llvm register allocator may use two different regist

Re: [PATCH v3] selftests/bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

2020-10-06 Thread patchwork-bot+bpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 6 Oct 2020 19:28:57 -0700 you wrote: > Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched > the order of check_subprogs() and resolve_pseudo_ldimm() in > the verifier. Now an empty prog expects to see the e

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-06 Thread Dan Williams
On Tue, Oct 6, 2020 at 12:21 PM Leon Romanovsky wrote: > > On Tue, Oct 06, 2020 at 05:41:00PM +, Saleem, Shiraz wrote: > > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support > > > > > > On Tue, Oct 06, 2020 at 05:09:09PM +, Parav Pandit wrote: > > > > > > > > > From: Leon Romanovsky

Re: [PATCH bpf-next 1/3] bpf: Propagate scalar ranges through register assignments.

2020-10-06 Thread Alexei Starovoitov
On Tue, Oct 06, 2020 at 06:56:14PM -0700, Andrii Nakryiko wrote: > On Tue, Oct 6, 2020 at 1:14 PM Alexei Starovoitov > wrote: > > > > From: Alexei Starovoitov > > > > The llvm register allocator may use two different registers representing the > > same virtual register. In such case the following

[PATCH bpf-next] kernel/bpf/verifier: fix build when NET is not enabled

2020-10-06 Thread Randy Dunlap
Fix build errors in kernel/bpf/verifier.c when CONFIG_NET is not enabled. ../kernel/bpf/verifier.c:3995:13: error: ‘btf_sock_ids’ undeclared here (not in a function); did you mean ‘bpf_sock_ops’? .btf_id = &btf_sock_ids[BTF_SOCK_TYPE_SOCK_COMMON], ../kernel/bpf/verifier.c:3995:26: error: ‘BTF_

linux-next: manual merge of the net-next tree with the net tree

2020-10-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/rxrpc/conn_event.c between commit: fa1d113a0f96 ("rxrpc: Fix some missing _bh annotations on locking conn->state_lock") from the net tree and commit: 245500d853e9 ("rxrpc: Rewrite the client connection manager

Re: [PATCH v2] selftests/bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

2020-10-06 Thread Alexei Starovoitov
On Tue, Oct 06, 2020 at 06:23:13PM -0700, Hao Luo wrote: > Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched > the order of check_subprogs() and resolve_pseudo_ldimm() in > the verifier. Now an empty prog expects to see the error "last > insn is not an the prog of a single invalid ldimm

Re: [PATCH bpf-next 1/3] bpf: Propagate scalar ranges through register assignments.

2020-10-06 Thread Andrii Nakryiko
On Tue, Oct 6, 2020 at 1:14 PM Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > The llvm register allocator may use two different registers representing the > same virtual register. In such case the following pattern can be observed: > 1047: (bf) r9 = r6 > 1048: (a5) if r6 < 0x1000 goto

Re: [PATCH bpf-next 3/3] selftests/bpf: Add profiler test

2020-10-06 Thread Alexei Starovoitov
On Tue, Oct 6, 2020 at 6:22 PM Jakub Kicinski wrote: > > On Tue, 6 Oct 2020 13:09:55 -0700 Alexei Starovoitov wrote: > > +static ino_t get_inode_from_kernfs(struct kernfs_node* node) > > nit: my bot suggests this may be missing an "INLINE" since it's a > static function in a header false po

Re: [PATCH bpf-next 3/3] selftests/bpf: Add profiler test

2020-10-06 Thread Jakub Kicinski
On Tue, 6 Oct 2020 13:09:55 -0700 Alexei Starovoitov wrote: > +static ino_t get_inode_from_kernfs(struct kernfs_node* node) nit: my bot suggests this may be missing an "INLINE" since it's a static function in a header > +{ > + struct kernfs_node___52* node52 = (void*)node; > + > + i

Re: [PATCH bpf-next V1 3/6] bpf: add BPF-helper for reading MTU from net_device via ifindex

2020-10-06 Thread Jakub Kicinski
On Tue, 6 Oct 2020 18:33:02 +0200 Jesper Dangaard Brouer wrote: > > +static const struct bpf_func_proto bpf_xdp_mtu_lookup_proto = { > > + .func = bpf_xdp_mtu_lookup, > > + .gpl_only = true, > > + .ret_type = RET_INTEGER, > > + .arg1_type = ARG_PTR_TO_CTX, > > +

Re: [PATCH] bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

2020-10-06 Thread Andrii Nakryiko
On Tue, Oct 6, 2020 at 5:51 PM Hao Luo wrote: > > On Tue, Oct 6, 2020 at 5:43 PM Andrii Nakryiko > wrote: > > > > On Tue, Oct 6, 2020 at 4:45 PM Hao Luo wrote: > > > > > > Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched > > > the order of check_subprogs() and resolve_pseudo_ldimm()

Re: [PATCH] bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

2020-10-06 Thread Andrii Nakryiko
On Tue, Oct 6, 2020 at 4:45 PM Hao Luo wrote: > > Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched > the order of check_subprogs() and resolve_pseudo_ldimm() in > the verifier. Now an empty prog and the prog of a single > invalid ldimm expect to see the error "last insn is not an > ex

Re: [PATCH bpf-next V1 5/6] bpf: Add MTU check for TC-BPF packets after egress hook

2020-10-06 Thread kernel test robot
Hi Jesper, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/bpf-New-approach-for-BPF-MTU-handling-and-enforcement/20201007-000903 base: https://git.kernel.org/pub/scm/linux/ker

[PATCH 2/4] selftests: netfilter: fix nft_meta.sh error reporting

2020-10-06 Thread Pablo Neira Ayuso
From: Fabian Frederick When some test directly done with check_one_counter() fails, counter variable is undefined. This patch calls ip with cname which avoids errors like: FAIL: oskuidcounter, want "packets 2", got Error: syntax error, unexpected newline, expecting string list counter inet filter

[PATCH 0/4] Netfilter fixes for net

2020-10-06 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter selftests fixes from Fabian Frederick: 1) Extend selftest nft_meta.sh to check for meta cpu. 2) Fix selftest nft_meta.sh error reporting. 3) Fix shellcheck warnings in selftest nft_meta.sh. 4) Extend selftest nft_meta.sh to check for meta time. Pl

[PATCH 3/4] selftests: netfilter: remove unused cnt and simplify command testing

2020-10-06 Thread Pablo Neira Ayuso
From: Fabian Frederick cnt was not used in nft_meta.sh This patch also fixes 2 shellcheck SC2181 warnings: "check exit code directly with e.g. 'if mycmd;', not indirectly with $?." Signed-off-by: Fabian Frederick Signed-off-by: Pablo Neira Ayuso --- tools/testing/selftests/netfilter/nft_meta.

[PATCH 4/4] selftests: netfilter: add time counter check

2020-10-06 Thread Pablo Neira Ayuso
From: Fabian Frederick Check packets are correctly placed in current year. Also do a NULL check for another one. Signed-off-by: Fabian Frederick Signed-off-by: Pablo Neira Ayuso --- tools/testing/selftests/netfilter/nft_meta.sh | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

[PATCH 1/4] selftests: netfilter: add cpu counter check

2020-10-06 Thread Pablo Neira Ayuso
From: Fabian Frederick run task on first CPU with netfilter counters reset and check cpu meta after another ping Signed-off-by: Fabian Frederick Acked-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- tools/testing/selftests/netfilter/nft_meta.sh | 14 ++ 1 file changed,

Re: [PATCH net] net: mptcp: make DACK4/DACK8 usage consistent among all subflows

2020-10-06 Thread Mat Martineau
On Tue, 6 Oct 2020, Davide Caratti wrote: using packetdrill it's possible to observe the same MPTCP DSN being acked by different subflows with DACK4 and DACK8. This is in contrast with what specified in RFC8684 §3.3.2: if an MPTCP endpoint transmits a 64-bit wide DSN, it MUST be acknowledged wit

Re: [PATCH] net/mlx5e: Fix freeing of unassigned pointer

2020-10-06 Thread Saeed Mahameed
On Sat, 2020-10-03 at 12:10 +0100, Alex Dewar wrote: > Commit ff7ea04ad579 ("net/mlx5e: Fix potential null pointer > dereference") > added some missing null checks but the error handling in > mlx5e_alloc_flow() was left broken: the variable attr is passed to > kfree > although it is never assigned

Re: [PATCH][next] net/mlx5: Fix uininitialized pointer read on pointer attr

2020-10-06 Thread Saeed Mahameed
On Tue, 2020-10-06 at 19:12 +0100, Colin King wrote: > From: Colin Ian King > > Currently the error exit path err_free kfree's attr. In the case > where > flow and parse_attr failed to be allocated this return path will free > the uninitialized pointer attr, which is not correct. In the other >

Re: [PATCH net-next] mptcp: fix infinite loop on recvmsg()/worker() race.

2020-10-06 Thread Mat Martineau
On Tue, 6 Oct 2020, Paolo Abeni wrote: If recvmsg() and the workqueue race to dequeue the data pending on some subflow, the current mapping for such subflow covers several skbs and some of them have not reached yet the received, either the worker or recvmsg() can find a subflow with the data_ava

Re: PHY reset question

2020-10-06 Thread Marek Vasut
On 10/6/20 11:11 PM, Florian Fainelli wrote: > > > On 10/6/2020 1:24 PM, Marek Vasut wrote: >> On 10/6/20 9:36 PM, Florian Fainelli wrote: >> [...] - Use compatible ("compatible = "ethernet-phy-id0022.1560") in the devicetree,     so that reading the PHYID is not needed     -

Re: [net-next PATCH v2] net: dsa: rtl8366rb: Roof MTU for switch

2020-10-06 Thread kernel test robot
Hi Linus, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Linus-Walleij/net-dsa-rtl8366rb-Roof-MTU-for-switch/20201007-033703 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9fae

Re: [PATCH] iproute2: ip addr: Fix noprefixroute and autojoin for IPv4

2020-10-06 Thread Stephen Hemminger
On Sat, 3 Oct 2020 16:10:05 +0200 Adel Belhouane wrote: > These were reported as IPv6-only and ignored: > > # ip address add 192.0.2.2/24 dev dummy5 noprefixroute > Warning: noprefixroute option can be set only for IPv6 addresses > # ip address add 224.1.1.10/24 dev dummy5 autojoi

Re: [iproute2] ipntable: add missing ndts_table_fulls ntable stat

2020-10-06 Thread Stephen Hemminger
On Fri, 2 Oct 2020 12:34:28 +0300 Eyal Birger wrote: > Used for tracking neighbour table overflows. > > Signed-off-by: Eyal Birger Looks good, wonder why it wasn't there already. Applied.

Re: [PATCH] net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()

2020-10-06 Thread Marek Vasut
On 10/6/20 11:09 PM, Florian Fainelli wrote: > > > On 10/6/2020 1:20 PM, Marek Vasut wrote: >> The phy_reset_after_clk_enable() is always called with ndev->phydev, >> however that pointer may be NULL even though the PHY device instance >> already exists and is sufficient to perform the PHY reset.

Re: [PATCH] man: fix typos

2020-10-06 Thread Stephen Hemminger
On Sun, 4 Oct 2020 11:42:59 + Samanta Navarro wrote: Looks good overall. Take the "a" off in the gso_max_segs part. Please resubmit this patch with proper Developer's Certificate of Origin (a.k.a. Signed-off-by).

Re: [EXT] Re: [PATCH v4 10/13] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-10-06 Thread Frederic Weisbecker
On Sun, Oct 04, 2020 at 03:22:09PM +, Alex Belits wrote: > > On Thu, 2020-10-01 at 16:44 +0200, Frederic Weisbecker wrote: > > > @@ -268,7 +269,8 @@ static void tick_nohz_full_kick(void) > > > */ > > > void tick_nohz_full_kick_cpu(int cpu) > > > { > > > - if (!tick_nohz_full_cpu(cpu)) > >

pull-request: can 2020-10-06

2020-10-06 Thread Marc Kleine-Budde
available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-5.9-20201006 for you to fetch changes up to 81f1f5ae8b3cbd54fdd994c9e9aacdb7b414a802: can: m_can_platform: don't call m_can_class_suspend in runtime suspend (

[PATCH] can: m_can_platform: don't call m_can_class_suspend in runtime suspend

2020-10-06 Thread Marc Kleine-Budde
From: Lucas Stach 0704c5743694 can: m_can_platform: remove unnecessary m_can_class_resume() call removed the m_can_class_resume() call in the runtime resume path to get rid of a infinite recursion, so the runtime resume now only handles the device clocks. Unfortunately it did not remove th

[PATCH v3 1/1] net/rds: suppress page allocation failure error in recv buffer refill

2020-10-06 Thread Manjunath Patil
RDS/IB tries to refill the recv buffer in softirq context using GFP_NOWAIT flag. However alloc failure is handled by queueing a work to refill the recv buffer with GFP_KERNEL flag. This means failure to allocate with GFP_NOWAIT isn't fatal. Do not print the PAF warnings if softirq context fails to

[PATCH net 2/2] net: ipa: skip suspend/resume activities if not set up

2020-10-06 Thread Alex Elder
When processing a system suspend request we suspend modem endpoints if they are enabled, and call ipa_cmd_tag_process() (which issues IPA commands) to ensure the IPA pipeline is cleared. It is an error to attempt to issue an IPA command before setup is complete, so this is clearly a bug. But we a

[PATCH net 1/2] net: ipa: only clear hardware state if setup has completed

2020-10-06 Thread Alex Elder
In the setup phase of initialization, GSI firmware gets loaded and initialized, and the AP command TX and default RX endpoints get set up. Until that happens, IPA commands must not be issued to the hardware. If the modem crashes, we stop endpoint channels and perform a number of other activities

[PATCH net 0/2] net: ipa: non-setup bug fixes

2020-10-06 Thread Alex Elder
This series fixes two bugs that occur if the IPA driver has not completed its setup phase of initialization when an event occurs. One event is the crash of the modem. If the modem crashes, ipa_modem_crashed() is called, and it performs various activities intended to put the IPA hardware into a go

Re: PHY reset question

2020-10-06 Thread Florian Fainelli
On 10/6/2020 1:24 PM, Marek Vasut wrote: On 10/6/20 9:36 PM, Florian Fainelli wrote: [...] - Use compatible ("compatible = "ethernet-phy-id0022.1560") in the devicetree,    so that reading the PHYID is not needed    - easy to solve.    Disadvantage:    - losing PHY auto-detection capabili

Re: [PATCH] net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()

2020-10-06 Thread Florian Fainelli
On 10/6/2020 1:20 PM, Marek Vasut wrote: The phy_reset_after_clk_enable() is always called with ndev->phydev, however that pointer may be NULL even though the PHY device instance already exists and is sufficient to perform the PHY reset. If the PHY still is not bound to the MAC, but there is

Re: [PATCH net-next v2 01/10] dt-bindings: net: add the dpaa2-mac DTS definition

2020-10-06 Thread Rob Herring
On Sat, Oct 03, 2020 at 12:07:28AM +0300, Ioana Ciornei wrote: > Add a documentation entry for the DTS bindings needed and supported by > the dpaa2-mac driver. > > Signed-off-by: Ioana Ciornei > --- > Changes in v2: > - new patch > > .../devicetree/bindings/net/dpaa2-mac.yaml| 55 +

RE: [PATCH] net: fec: Fix phy_device lookup for phy_reset_after_clk_enable() [Klartext]

2020-10-06 Thread Christoph Niedermaier
From: Marek Vasut Sent: Tuesday, October 6, 2020 10:20 PM > The phy_reset_after_clk_enable() is always called with ndev->phydev, > however that pointer may be NULL even though the PHY device instance > already exists and is sufficient to perform the PHY reset. > > If the PHY still is not bound t

Re: [net v2] net: dsa: microchip: fix race condition

2020-10-06 Thread Jakub Kicinski
On Tue, 6 Oct 2020 17:56:51 +0200 Christian Eggers wrote: > Fixes: 7c6ff470aa ("net: dsa: microchip: add MIB counter reading support") Fixes tag: Fixes: 7c6ff470aa ("net: dsa: microchip: add MIB counter reading support") Has these problem(s): - SHA1 should be at least 12 digits long

Re: [PATCH can-next] can: add ISO 15765-2:2016 transport protocol

2020-10-06 Thread Marc Kleine-Budde
On 9/28/20 10:04 PM, Oliver Hartkopp wrote: > CAN Transport Protocols offer support for segmented Point-to-Point > communication between CAN nodes via two defined CAN Identifiers. > As CAN frames can only transport a small amount of data bytes > (max. 8 bytes for 'classic' CAN and max. 64 bytes for

Re: PHY reset question

2020-10-06 Thread Marek Vasut
On 10/6/20 9:36 PM, Florian Fainelli wrote: [...] >> - Use compatible ("compatible = "ethernet-phy-id0022.1560") in the >> devicetree, >>    so that reading the PHYID is not needed >>    - easy to solve. >>    Disadvantage: >>    - losing PHY auto-detection capability >>    - need a new devicetree

[PATCH] net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()

2020-10-06 Thread Marek Vasut
The phy_reset_after_clk_enable() is always called with ndev->phydev, however that pointer may be NULL even though the PHY device instance already exists and is sufficient to perform the PHY reset. If the PHY still is not bound to the MAC, but there is OF PHY node and a matching PHY device instance

Re: [PATCH bpf-next V1 5/6] bpf: Add MTU check for TC-BPF packets after egress hook

2020-10-06 Thread kernel test robot
/kernel/git/bpf/bpf-next.git master config: s390-randconfig-r026-20201006 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1127662c6dc2a276839c75a42238b11a3ad00f32) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp

[PATCH RFC] net: add helper eth_set_protocol

2020-10-06 Thread Heiner Kallweit
In all cases I've seen eth_type_trans() is used as in the new helper. Biggest benefit is improved readability when replacing statements like the following: desc->skb->protocol = eth_type_trans(desc->skb, priv->dev); Coccinelle tells me that using the new helper tree-wide would touch 313 files. The

[PATCH bpf-next 0/3] bpf: Make the verifier recognize llvm register allocation patterns.

2020-10-06 Thread Alexei Starovoitov
From: Alexei Starovoitov Make two verifier improvements: - The llvm register allocator may use two different registers representing the same virtual register. Teach the verifier to recognize that. - Track bounded scalar spill/fill. The 'profiler' test in patch 3 will fail to load without patches

[PATCH bpf-next 3/3] selftests/bpf: Add profiler test

2020-10-06 Thread Alexei Starovoitov
From: Alexei Starovoitov The main purpose of the profiler test to check different llvm generation patterns to make sure the verifier can load these large programs. Note that profiler.inc.h test doesn't follow strict kernel coding style. The code was formatted in kernel style, but variable declar

[PATCH bpf-next 1/3] bpf: Propagate scalar ranges through register assignments.

2020-10-06 Thread Alexei Starovoitov
From: Alexei Starovoitov The llvm register allocator may use two different registers representing the same virtual register. In such case the following pattern can be observed: 1047: (bf) r9 = r6 1048: (a5) if r6 < 0x1000 goto pc+1 1050: ... 1051: (a5) if r9 < 0x2 goto pc+66 1052: ... 1053: (bf)

[PATCH bpf-next 2/3] bpf: Track spill/fill of bounded scalars.

2020-10-06 Thread Alexei Starovoitov
From: Yonghong Song Under register pressure the llvm may spill registers with bounds into the stack. The verifier has to track them through spill/fill otherwise many kinds of bound errors will be seen. The spill/fill of induction variables was already happening. This patch extends this logic from

Re: [PATCH ghak90 V9 11/13] audit: contid check descendancy and nesting

2020-10-06 Thread Richard Guy Briggs
On 2020-08-21 16:13, Paul Moore wrote: > On Fri, Aug 7, 2020 at 1:10 PM Richard Guy Briggs wrote: > > On 2020-07-05 11:11, Paul Moore wrote: > > > On Sat, Jun 27, 2020 at 9:23 AM Richard Guy Briggs > > > wrote: > > > > Require the target task to be a descendant of the container > > > > orchestra

Re: [PATCH net-next] net: openvswitch: Add support to lookup invalid packet in ct action.

2020-10-06 Thread Numan Siddique
On Wed, Oct 7, 2020 at 12:22 AM Florian Westphal wrote: > > Numan Siddique wrote: > > On Tue, Oct 6, 2020 at 4:46 PM Florian Westphal wrote: > > > > > > nusid...@redhat.com wrote: > > > > From: Numan Siddique > > > > > > > > For a tcp packet which is part of an existing committed connection, >

Re: [PATCH ethtool-next v2 5/6] netlink: use policy dumping to check if stats flag is supported

2020-10-06 Thread Michal Kubecek
On Tue, Oct 06, 2020 at 10:39:13PM +0300, Ido Schimmel wrote: > On Tue, Oct 06, 2020 at 08:04:24AM -0700, Jakub Kicinski wrote: > > Older kernels don't support statistics, to avoid retries > > make use of netlink policy dumps to figure out which > > flags kernel actually supports. > > Thanks for w

Re: [PATCH ethtool-next v2 5/6] netlink: use policy dumping to check if stats flag is supported

2020-10-06 Thread Ido Schimmel
On Tue, Oct 06, 2020 at 08:04:24AM -0700, Jakub Kicinski wrote: > Older kernels don't support statistics, to avoid retries > make use of netlink policy dumps to figure out which > flags kernel actually supports. Thanks for working on this, Jakub. Michal, should I try something similar for the leg

Re: PHY reset question

2020-10-06 Thread Florian Fainelli
On 10/6/2020 1:04 AM, Oleksij Rempel wrote: Hello PHY experts, Short version: what is the proper way to handle the PHY reset before identifying PHY? Long version: I stumbled over following issue: If PHY reset is registered within PHY node. Then, sometimes, we will not be able to identify it

Re: [PATCH 0/3] can: xilinx_can: Some minor changes

2020-10-06 Thread Marc Kleine-Budde
On 9/14/20 10:49 AM, Michal Simek wrote: > Hi, > > recently some small patches come to our internal tree. We started to use > coverity which found 2 issues (last two patches) which is simply to fix. > > Thanks, > Michal > > > Srinivas Neeli (3): > can: xilinx_can: Limit CANFD brp to 2 > can

[net-next PATCH v2] net: dsa: rtl8366rb: Roof MTU for switch

2020-10-06 Thread Linus Walleij
The MTU setting for this DSA switch is global so we need to keep track of the MTU set for each port, then as soon as any MTU changes, roof the MTU to the biggest common denominator and poke that into the switch MTU setting. To achieve this we need a per-chip-variant state container for the RTL8366

Re: [RESEND PATCH v2 0/2] dt-bindings: can: document R8A774E1

2020-10-06 Thread Marc Kleine-Budde
On 10/5/20 10:13 AM, Lad Prabhakar wrote: > Hi All, > > I am re-sending this patch set as this has been missed previously. > It is exactly same as [1]. > > DT maintainers have already acked the patches. > > [1] https://www.spinics.net/lists/netdev/msg679244.html > > Cheers, > Prabhakar > > Cha

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-06 Thread Leon Romanovsky
On Tue, Oct 06, 2020 at 05:41:00PM +, Saleem, Shiraz wrote: > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support > > > > On Tue, Oct 06, 2020 at 05:09:09PM +, Parav Pandit wrote: > > > > > > > From: Leon Romanovsky > > > > Sent: Tuesday, October 6, 2020 10:33 PM > > > > > > > > On Tue

Re: [PATCH 2/3] dt-bindings: can: rcar_can: Add r8a7742 support

2020-10-06 Thread Marc Kleine-Budde
On 10/6/20 9:36 AM, Lad, Prabhakar wrote: > On Tue, Aug 25, 2020 at 3:21 AM Rob Herring wrote: >> >> On Sun, 16 Aug 2020 20:07:31 +0100, Lad Prabhakar wrote: >>> Document RZ/G1H (r8a7742) SoC specific bindings. The R8A7742 CAN module >>> is identical to R-Car Gen2 family. >>> >>> No driver change

RE: [PATCH][RESEND] net: fec: Fix PHY init after phy_reset_after_clk_enable() [Klartext]

2020-10-06 Thread Christoph Niedermaier
From: Marek Vasut Sent: Tuesday, October 6, 2020 3:53 PM > The phy_reset_after_clk_enable() does a PHY reset, which means the PHY > loses its register settings. The fec_enet_mii_probe() starts the PHY > and does the necessary calls to configure the PHY via PHY framework, > and loads the correct r

Re: [PATCH bpf-next v4 1/6] bpf: Introduce pseudo_btf_id

2020-10-06 Thread Alexei Starovoitov
On Tue, Sep 29, 2020 at 4:50 PM Hao Luo wrote: > > - ret = replace_map_fd_with_map_ptr(env); > - if (ret < 0) > - goto skip_full_check; > - > if (bpf_prog_is_dev_bound(env->prog->aux)) { > ret = bpf_prog_offload_verifier_prep(env->prog); >

[net-next v3 7/9] bridge: cfm: Netlink Interface.

2020-10-06 Thread Henrik Bjoernlund
This is the implementation of CFM netlink configuration and status information interface. Add new nested netlink attributes. These attributes are used by the user space to create/delete/configure CFM instances and get status. Also they are used by the kernel to notify the user space when changes i

[net-next v3 8/9] bridge: cfm: Netlink Notifications.

2020-10-06 Thread Henrik Bjoernlund
This is the implementation of Netlink notifications out of CFM. Notifications are initiated whenever a state change happens in CFM. IFLA_BRIDGE_CFM: Points to the CFM information. IFLA_BRIDGE_CFM_MEP_STATUS_INFO: This indicate that the MEP instance status are following. IFLA_BRIDGE_CFM_C

  1   2   3   >