On Tue, 06 Oct 2020, Kalle Valo wrote:
> Lee Jones writes:
>
> > On Thu, 10 Sep 2020, Lee Jones wrote:
> >
> >> This is a rebased/re-worked set of patches which have been
> >> previously posted to the mailing list(s).
> >>
> >> This set is part of a larger effort attempting to clean-up W=1
> >>
On Mon, 2020-10-05 at 15:07 -0700, Jakub Kicinski wrote:
> Hi!
>
> This series wires up ethtool policies to ops, so they can be
> dumped to user space for feature discovery.
>
> First patch wires up GET commands, and second patch wires up SETs.
>
> The policy tables are trimmed to save space and
On Tue, Oct 06, 2020 at 02:22:15AM -0400, Michael S. Tsirkin wrote:
Acked-by: Eli Cohen
> On Fri, Oct 02, 2020 at 01:17:00PM -0700, Si-Wei Liu wrote:
> > + Eli.
> >
> > On Thu, Oct 1, 2020 at 2:02 PM Si-Wei Liu wrote:
> > >
> > > A VM with mlx5 vDPA has below warnings while being reset:
> > >
On Mon, 2020-10-05 at 15:21 -0700, Jakub Kicinski wrote:
> > > Nice, easy & useful, maybe I'll code it up tomorrow.
> >
> > OK I thought about it a bit more and looked at the code, and it's not
> > actually possible to do easily right now, because we can't actually
> > point to the bad attribut
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/sched/sch_atm.c | 9 +
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/mac802154/main.c | 8 +++-
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/xfrm/xfrm_input.c | 7 +++
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/rds/ib_cm.c | 14 ++---
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/smc/smc_cdc.c | 6 +++---
net
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/ipv4/tcp_output.c | 8 +++-
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/mac80211/ieee80211_i.h | 4 ++
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
net/dccp/timer.c | 10 +-
From: Allen Pais
Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
introduced a new tasklet initialization API. This series converts
all the net/* drivers to use the new tasklet_setup() API
The following series is based on net-next.git(8b0308fe3)
Allen Pais (8):
net: dccp: c
If recvmsg() and the workqueue race to dequeue the data
pending on some subflow, the current mapping for such
subflow covers several skbs and some of them have not
reached yet the received, either the worker or recvmsg()
can find a subflow with the data_avail flag set - since
the current mapping is
On Sun Oct 04 2020, Vladimir Oltean wrote:
> On Sun, Oct 04, 2020 at 01:29:08PM +0200, Kurt Kanzenbach wrote:
>> +/* Enabling/disabling TX and RX HW timestamping for different PTP messages
>> is
>> + * not available in the switch. Thus, this function only serves as a check
>> if
>> + * the user r
On Fri, Oct 02, 2020 at 01:17:00PM -0700, Si-Wei Liu wrote:
> + Eli.
>
> On Thu, Oct 1, 2020 at 2:02 PM Si-Wei Liu wrote:
> >
> > A VM with mlx5 vDPA has below warnings while being reset:
> >
> > vhost VQ 0 ring restore failed: -1: Resource temporarily unavailable (11)
> > vhost VQ 1 ring restore
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/usb
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/usb
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/arc
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/cai
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/usb
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/usb
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/usb
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/ppp
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/ifb
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/usb
From: Allen Pais
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
introduced a new tasklet initialization API. This series converts
the remaining drivers in net/ to use the new tasklet_setup() API
Allen Pais (10):
net: arcnet: convert tasklets to use new tasklet_setup() API
Hi Vladimir,
thanks for the review.
On Sun Oct 04 2020, Vladimir Oltean wrote:
> On Sun, Oct 04, 2020 at 01:29:06PM +0200, Kurt Kanzenbach wrote:
>> +static int hellcreek_vlan_del(struct dsa_switch *ds, int port,
>> + const struct switchdev_obj_port_vlan *vlan)
>> +{
>> +
On Mon, Oct 05, 2020 at 05:28:18PM +0300, Claudiu Manoil wrote:
> This is a methodical transition of the driver from phylib
> to phylink, following the guidelines from sfp-phylink.rst.
> The MAC register configurations based on interface mode
> were moved from the probing path to the mac_config() h
Chris Chiu writes:
> On Mon, Oct 5, 2020 at 11:01 PM Chris Chiu wrote:
>
> From: Chris Chiu
>
> The legacy_httxpowerdiff in rtl8192se is pretty much the same as
> the legacy_ht_txpowerdiff for other chips. Use the same name to
> keep the consistency.
>
> Signed-off
On Tue, Oct 06, 2020 at 04:28:09AM +0200, Willy Tarreau wrote:
> Hi Kees,
>
> On Mon, Oct 05, 2020 at 07:12:29PM -0700, Kees Cook wrote:
> > On Fri, Oct 02, 2020 at 05:16:11PM +0200, Thibaut Sautereau wrote:
> > > From: Thibaut Sautereau
> > >
> > > Commit f227e3ec3b5c ("random32: update the net
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/eth
From: Allen Pais
This series converts the remaining drivers to use new
tasklet_setup() API.
The patches are based on wireless-drivers-next.git
Allen Pais (2):
ath11k: convert tasklets to use new tasklet_setup() API
wireless: mt76: convert tasklets to use new tasklet_setup() API
drivers/
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/wir
From: Allen Pais
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier
Signed-off-by: Allen Pais
---
drivers/net/wir
Lee Jones writes:
> On Thu, 10 Sep 2020, Lee Jones wrote:
>
>> This is a rebased/re-worked set of patches which have been
>> previously posted to the mailing list(s).
>>
>> This set is part of a larger effort attempting to clean-up W=1
>> kernel builds, which are currently overwhelmingly riddled
This fixes a regression for blocking connects introduced by commit
4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect").
The x25->neighbour is already set to "NULL" by x25_disconnect() now,
while a blocking connect is waiting in
x25_wait_for_connection_establishment(). Therefore
On 05.10.2020 18:00, Florian Fainelli wrote:
>
>
> On 10/5/2020 8:54 AM, Heiner Kallweit wrote:
>> On 05.10.2020 17:41, Florian Fainelli wrote:
>>>
>>>
>>> On 10/5/2020 1:53 AM, Jisheng Zhang wrote:
On Wed, 30 Sep 2020 13:23:29 -0700 Florian Fainelli wrote:
>
> On 9/30/2020
Hi Christoph,
On Tue, 6 Oct 2020 07:13:01 +0200 Christoph Hellwig wrote:
>
> On Tue, Oct 06, 2020 at 02:58:47PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the net-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
>
> It actually doesn't need
On Tue, Oct 06, 2020 at 02:58:47PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
It actually doesn't need that or the two other internal headers.
Bjoern has a fixed, and it was supposed to be queued
Compiling samples/bpf hits an error related to fallthrough marking.
...
CC samples/bpf/hbm.o
samples/bpf/hbm.c: In function ‘main’:
samples/bpf/hbm.c:486:4: error: ‘fallthrough’ undeclared (first use in this
function)
fallthrough;
^~~
The "fallthrough" is not defi
With latest llvm trunk, bpf programs under samples/bpf
directory, if using CORE, may experience the following
errors:
LLVM ERROR: Cannot select: intrinsic %llvm.preserve.struct.access.index
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash
backtrace.
Stack dump:
0. P
Lorenzo Bianconi wrote:
> [...]
>
> >
> > In general I see no reason to populate these fields before the XDP
> > program runs. Someone needs to convince me why having frags info before
> > program runs is useful. In general headers should be preserved and first
> > frag already included in the da
On Tue, 2020-10-06 at 11:59 +0800, Chris Chiu wrote:
> From: Chris Chiu
>
> The legacy_httxpowerdiff in rtl8192se is pretty much the same as
> the legacy_ht_txpowerdiff for other chips. Use the same name to
> keep the consistency.
>
> Signed-off-by: Chris Chiu
> ---
> drivers/net/wireless/real
From: Chris Chiu
The legacy_httxpowerdiff in rtl8192se is pretty much the same as
the legacy_ht_txpowerdiff for other chips. Use the same name to
keep the consistency.
Signed-off-by: Chris Chiu
---
drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 2 +-
drivers/net/wireless/realtek/rtlwifi
Hi all,
After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
net/xdp/xsk_buff_pool.c:7:10: fatal error: linux/dma-noncoherent.h: No such
file or directory
7 | #include
| ^
Caused by commit
1c1efc2af158 (
On Mon, Oct 5, 2020 at 7:15 PM Hangbin Liu wrote:
>
> This add a test to make sure that we can still pin maps with
> reused map fd.
>
> Signed-off-by: Hangbin Liu
> ---
Acked-by: Andrii Nakryiko
[...]
On 10/5/20 12:27 PM, Andrii Nakryiko wrote:
On Fri, Oct 2, 2020 at 10:16 PM Yonghong Song wrote:
On 10/2/20 9:22 PM, Andrii Nakryiko wrote:
On Fri, Oct 2, 2020 at 7:19 PM Yonghong Song wrote:
With latest llvm trunk, bpf programs under samples/bpf
directory, if using CORE, may experien
Hi Kees,
On Mon, Oct 05, 2020 at 07:12:29PM -0700, Kees Cook wrote:
> On Fri, Oct 02, 2020 at 05:16:11PM +0200, Thibaut Sautereau wrote:
> > From: Thibaut Sautereau
> >
> > Commit f227e3ec3b5c ("random32: update the net random state on interrupt
> > and activity") broke compilation and was tempo
Say a user reuse map fd after creating a map manually and set the
pin_path, then load the object via libbpf.
In libbpf bpf_object__create_maps(), bpf_object__reuse_map() will
return 0 if there is no pinned map in map->pin_path. Then after
checking if map fd exist, we should also check if pin_path
This add a test to make sure that we can still pin maps with
reused map fd.
Signed-off-by: Hangbin Liu
---
v3: use CHECK() for bpf_object__open_file() and close map fd on error
v2: no update
---
.../selftests/bpf/prog_tests/pinning.c| 49 ++-
1 file changed, 48 insertions
Previously we forgot to close the map fd if bpf_map_update_elem()
failed during map slot init, which will leak map fd.
Let's move map slot initialization to new function init_map_slots() to
simplify the code. And close the map fd if init slot failed.
Reported-by: Andrii Nakryiko
Acked-by: Andrii
When a user reuse map fd after creating a map manually and set the
pin_path, then load the object via libbpf. bpf_object__create_maps()
will skip pinning map if map fd exist. Fix it by add moving bpf creation
to else condition and go on checking map pin_path after that.
v3:
for selftest: use CHECK
On Fri, Oct 02, 2020 at 05:16:11PM +0200, Thibaut Sautereau wrote:
> From: Thibaut Sautereau
>
> Commit f227e3ec3b5c ("random32: update the net random state on interrupt
> and activity") broke compilation and was temporarily fixed by Linus in
> 83bdc7275e62 ("random32: remove net_rand_state from
I am sending out this patch mainly to clarify the source of a problem
I am seeing.
An idle tcp connection is timing out on a 4.19 kernel after
conntrack unregister/re-register. By playing with SO_KEEPALIVE
setsockopts on the client I can make it timeout in a few seconds.
I could not find any releva
On 10/5/2020 7:48 AM, Vladimir Oltean wrote:
> Currently skb_dump has a restriction to only dump full packet for the
> first 5 socket buffers, then only headers will be printed. Remove this
> arbitrary and confusing restriction, which is only documented vaguely
> ("up to") in the comments above
On 10/5/2020 12:33 PM, Johannes Berg wrote:
> On Mon, 2020-10-05 at 12:31 -0700, Jakub Kicinski wrote:
>
>> Yea, I think we're both confused. Agreed with the above.
>>
>> Are you suggesting:
>>
>> const struct nla_policy policy[/* no size */] = {
>> [HEADER]= NLA_POLICY(...)
>>
On 10/5/2020 12:31 PM, Jakub Kicinski wrote:
> On Mon, 05 Oct 2020 21:21:36 +0200 Johannes Berg wrote:
But with the difference it seems to me that it'd be possible to get this
mixed up?
>>>
>>> Right, I prefer not to have the unnecessary NLA_REJECTS, so my thinking
>>> was - use the
On Mon, Oct 05, 2020 at 10:36:34PM +0200, Fabian Frederick wrote:
> use new helper for netstats settings
>
> Signed-off-by: Fabian Frederick
> ---
> net/xfrm/xfrm_interface.c | 9 +
> 1 file changed, 1 insertion(+), 8 deletions(-)
Acked-by: Herbert Xu
--
Email: Herbert Xu
Home Page:
On Tue, 6 Oct 2020 00:13:13 +0530 Rohit Maheshwari wrote:
> At first when sendpage gets called, if there is more data, 'more' in
> tls_push_data() gets set which later sets pending_open_record_frags, but
> when there is no more data in file left, and last time tls_push_data()
> gets called, pendin
On Mon, 5 Oct 2020, Paolo Abeni wrote:
Currently we skip calling tcp_cleanup_rbuf() when packets
are moved into the OoO queue or simply dropped. In both
cases we still increment tp->copied_seq, and we should
ask the TCP stack to check for ack.
Fixes: c76c6956566f ("mptcp: call tcp_cleanup_rbuf
On Mon, 5 Oct 2020 22:34:18 +0200 Fabian Frederick wrote:
> +static inline void dev_sw_netstats_rx_add(struct net_device *dev, unsigned
> int len)
> +{
> + struct pcpu_sw_netstats *tstats = this_cpu_ptr(dev->tstats);
> +
> + u64_stats_update_begin(&tstats->syncp);
> + tstats->rx_bytes
On 10/5/20 8:03 PM, Martin KaFai Lau wrote:
On Mon, Oct 05, 2020 at 09:58:38AM -0700, Song Liu wrote:
[...]
non-NMI pop(): use _lock(); check per cpu lists first;
if all per cpu lists are empty, check extralist;
if extralist is empty, return NULL.
non-NMI pus
Update Andrii Nakryiko's reviewer email to kernel.org account. This optimizes
email logistics on my side and makes it less likely for me to miss important
patches.
Signed-off-by: Andrii Nakryiko
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAI
[...]
>
> In general I see no reason to populate these fields before the XDP
> program runs. Someone needs to convince me why having frags info before
> program runs is useful. In general headers should be preserved and first
> frag already included in the data pointers. If users start parsing fu
On Mon, 05 Oct 2020 22:12:25 +0200 Johannes Berg wrote:
> On Mon, 2020-10-05 at 21:53 +0200, Johannes Berg wrote:
> > Hm. I like that idea.
> >
> > If we have NLMSGERR_ATTR_OFFS we could accompany that with the sub-
> > policy for that particular attribute, something like
> >
> > [NLMSGERR_ATTR_P
Perform header flags validation through the policy.
Only pause command supports ETHTOOL_FLAG_STATS. Create a separate
policy to be able to express that in policy dumps to user space.
Note that even though the core will validate the header policy,
it cannot record multiple layers of attributes and
Since ethtool uses strict attribute validation there's no need
to initialize all attributes in policy tables. 0 is NLA_UNSPEC
which is going to be rejected. Remove the NLA_REJECTs.
Similarly attributes above maxattrs are rejected, so there's
no need to always size the policy tables to ETHTOOL_A_..
We don't have good validation policy for existing unsigned int attrs
which serve as flags (for new ones we could use NLA_BITFIELD32).
With increased use of policy dumping having the validation be
expressed as part of the policy is important. Add validation
policy in form of a mask of supported/vali
Similarly to get commands wire up the policies of set commands
to get parsing by the core and policy dumps.
Signed-off-by: Jakub Kicinski
---
net/ethtool/cabletest.c | 24 ++--
net/ethtool/channels.c | 11 +++
net/ethtool/coalesce.c | 11 +++
net/ethtool/deb
There's a number of policies which check if type is a uint or sint.
Factor the checking against the list of value sizes to a helper
for easier reuse.
v2: - new patch
Signed-off-by: Jakub Kicinski
---
CC: j...@resnulli.us
CC: dsah...@gmail.com
CC: pa...@netfilter.org
---
include/net/netlink.h |
Wire up policies for get commands in struct nla_policy of the ethtool
family. Make use of genetlink code attr validation and parsing, as well
as allow dumping policies to user space.
For every ETHTOOL_MSG_*_GET:
- add 'ethnl_' prefix to policy name
- add extern declaration in net/ethtool/netlink
To get the most out of parsing by the core, and to allow dumping
full policies we need to specify which policy applies to nested
attrs. For headers it's ethnl_header_policy.
$ sed -i 's@\(ETHTOOL_A_.*HEADER\].*=\) { .type = NLA_NESTED
},@\1\n\t\tNLA_POLICY_NESTED(ethnl_header_policy),@' net/ethto
Hi!
This series wires up ethtool policies to ops, so they can be
dumped to user space for feature discovery.
First patch wires up GET commands, and second patch wires up SETs.
The policy tables are trimmed to save space and LoC.
Next - take care of linking up nested policies for the header
(whi
Thanks David for your feedback.
I will submit v3 of this patch removing the warning.
-Manjunath
On 10/3/2020 5:26 PM, David Miller wrote:
From: Manjunath Patil
Date: Fri, 2 Oct 2020 13:05:45 -0700
RDS/IB tries to refill the recv buffer in softirq context using
GFP_NOWAIT flag. However alloc
On Sat, Oct 3, 2020 at 1:55 AM Hangbin Liu wrote:
>
> This add a test to make sure that we can still pin maps with
> reused map fd.
>
> Signed-off-by: Hangbin Liu
> ---
> .../selftests/bpf/prog_tests/pinning.c| 46 ++-
> 1 file changed, 45 insertions(+), 1 deletion(-)
>
>
On Sat, Oct 3, 2020 at 1:55 AM Hangbin Liu wrote:
>
> Say a user reuse map fd after creating a map manually and set the
> pin_path, then load the object via libbpf.
>
> In libbpf bpf_object__create_maps(), bpf_object__reuse_map() will
> return 0 if there is no pinned map in map->pin_path. Then aft
Jesper Dangaard Brouer wrote:
> On Fri, 02 Oct 2020 11:06:12 -0700
> John Fastabend wrote:
>
> > Lorenzo Bianconi wrote:
> > > > Lorenzo Bianconi wrote:
> > > > > This series introduce XDP multi-buffer support. The mvneta driver is
> > > > > the first to support these new "non-linear" xdp_{buff
On Sat, Oct 3, 2020 at 1:55 AM Hangbin Liu wrote:
>
> Previously we forgot to close the map fd if bpf_map_update_elem()
> failed during map slot init, which will leak map fd.
>
> Let's move map slot initialization to new function init_map_slots() to
> simplify the code. And close the map fd if ini
> It depends a lot on what portion of the kernel gets enabled for W=1.
>
> As long as it's only drivers that are actively maintained, and they
> make up a fairly small portion of all code, it should not be a problem
> to find someone to fix useful warnings.
Well, drivers/net/ethernet is around 1.
Hi Christian,
On Mon, Oct 05, 2020 at 06:08:29PM +0200, Christian Eggers wrote:
> Between queuing the delayed work and finishing the setup of the dsa
> ports, the process may sleep in request_module() and the queued work may
> be executed prior the initialization of the DSA ports is finished. In
On Mon, Oct 05, 2020 at 06:39:39PM +0300, Igor Russkikh wrote:
> Mediadetect is another name for the EDPD (energy detect power down).
> This feature allows device to save extra power when no link is available.
>
> PHY goes into the extreme power saving mode and only periodically wakes up
> and che
use new helper for netstats settings
Signed-off-by: Fabian Frederick
---
net/xfrm/xfrm_interface.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
index eb8181987620d..8f8631eafe784 100644
--- a/net/xfrm/xfrm_inter
use new helper for netstats settings
Signed-off-by: Fabian Frederick
---
net/openvswitch/vport-internal_dev.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/net/openvswitch/vport-internal_dev.c
b/net/openvswitch/vport-internal_dev.c
index 58a7b8312c289..d8fe66eea206b
use new helper for netstats settings
Signed-off-by: Fabian Frederick
---
net/ipv4/ip_tunnel.c | 8 +---
net/ipv4/ip_vti.c| 9 +
2 files changed, 2 insertions(+), 15 deletions(-)
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index 0c1f364044715..8b04d1dcfec4e 100644
--
use new helper for netstats settings
Signed-off-by: Fabian Frederick
---
net/ipv6/ip6_vti.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c
index fac01b80a1040..5f9c4fdc120d6 100644
--- a/net/ipv6/ip6_vti.c
+++ b/net/ipv6/ip6_vti
use new helper for netstats settings
Signed-off-by: Fabian Frederick
---
drivers/net/gtp.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index c09fe18c6c52d..030a1a5afe05a 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@
use new helper for netstats settings
Signed-off-by: Fabian Frederick
---
drivers/net/bareudp.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c
index 841910f1db655..ff0bea1554f9b 100644
--- a/drivers/net/bareudp.c
+++ b
use new helper for netstats settings
Signed-off-by: Fabian Frederick
---
drivers/net/geneve.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 974a244f45ba0..d07008a818df6 100644
--- a/drivers/net/geneve.c
+++ b/dri
use new helper for netstats settings
Signed-off-by: Fabian Frederick
---
drivers/net/vxlan.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index be3bf233a809e..1a557aeba32b4 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/
some drivers/network protocols update rx bytes/packets under
u64_stats_update_begin/end sequence.
Add a specific helper like dev_lstats_add()
Signed-off-by: Fabian Frederick
---
include/linux/netdevice.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/linux/netdevice.h b
This small patchset creates netstats addition dev_sw_netstats_rx_add()
based on dev_lstats_add() and replaces some open coding
in both drivers/net and net branches.
Fabian Frederick (9):
net: netdevice.h: sw_netstats_rx_add helper
vxlan: use dev_sw_netstats_rx_add()
geneve: use dev_sw_netsta
The pull request you sent on Sun, 04 Oct 2020 22:07:55 -0700 (PDT):
> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git refs/heads/master
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/165563c05088467e7e0ba382c5bdb04b6cbf0013
Thank you!
--
Deet-doot-dot,
On Mon, 2020-10-05 at 21:53 +0200, Johannes Berg wrote:
> On Mon, 2020-10-05 at 12:40 -0700, Jakub Kicinski wrote:
>
> > > I would totally support doing that here in the general validation code,
> > > but (again) don't really think NLMSGERR_ATTR_COOKIE is an appropriate
> > > attribute for it.
> >
> On 5. Oct 2020, at 21:01, Marcelo Ricardo Leitner
> wrote:
>
> On Sat, Oct 03, 2020 at 08:24:34PM +0800, Xin Long wrote:
>> On Sat, Oct 3, 2020 at 7:23 PM Xin Long wrote:
>>>
>>> On Sat, Oct 3, 2020 at 4:12 PM Xin Long wrote:
On Sat, Oct 3, 2020 at 12:08 PM Marcelo Ricardo Leitne
On Mon, Oct 5, 2020 at 9:49 PM Andrew Lunn wrote:
>
> > Sorry, to be more specific about my concern; I like the idea of
> > exporting the W=* flags, then selectively applying them via
> > subdir-ccflags-y. I don't like the idea of supporting W=1 as defined
> > at a precise point in time via multi
On 10/5/2020 9:08 AM, Christian Eggers wrote:
Between queuing the delayed work and finishing the setup of the dsa
ports, the process may sleep in request_module() and the queued work may
be executed prior the initialization of the DSA ports is finished. In
ksz_mib_read_work(), a NULL dereferen
On Mon, 2020-10-05 at 12:40 -0700, Jakub Kicinski wrote:
> > I would totally support doing that here in the general validation code,
> > but (again) don't really think NLMSGERR_ATTR_COOKIE is an appropriate
> > attribute for it.
>
> Hm. Perhaps we can do a partial policy dump into the extack?
Hm
On Mon, 05 Oct 2020 21:46:02 +0200 Johannes Berg wrote:
> On Mon, 2020-10-05 at 12:41 -0700, Jakub Kicinski wrote:
>
> > > Now you can freely add any attributes, and, due to strict validation,
> > > anything not specified in the policy will be rejected, whether by being
> > > out of range (> maxat
> Sorry, to be more specific about my concern; I like the idea of
> exporting the W=* flags, then selectively applying them via
> subdir-ccflags-y. I don't like the idea of supporting W=1 as defined
> at a precise point in time via multiple date specific symbols. If
> someone adds something to W=
1 - 100 of 247 matches
Mail list logo
