Replace a comma between expression statements by a semicolon.
Signed-off-by: Xu Wang
---
net/ipv6/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 5e7e25e2523a..fb075d9545b9 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
This patch adds the initial support for parsing registers dumped
by the Broadcom driver. Currently, PXP and PCIe registers are
parsed.
Reviewed-by: Andy Gospodarek
Reviewed-by: Edwin Peer
Signed-off-by: Vasundhara Volam
---
Makefile.am | 2 +-
bnxt.c | 86
Any comments?
Thomas: this should be identical to the git tree I gave you for mips
testing, and you add your tested-by (and reviewd-by tags where
applicable)?
Helge: for parisc this should effectively be the same as the first
version, but I've dropped the tested-by tags due to the reshuffle,
and
Hello David,
I saw the status of my patched has been changed to "Changes requested".
Can you tell me what can I do to get the patch accepted?
Thank you in advance!
BR,
Christian
Am 17.09.20 um 14:27 schrieb Christian Langrock:
> Xfrm_dev_offload_ok() is called with the unencrypted SKB. So in
On Sunday, 20 September 2020 21:59:19 CEST Stephen Rothwell wrote:
> Hi all,
Yes, I've accidentally swapped the IDs while adding them to the various patches.
The correct ones should have been:
* 097930e85f90 ("batman-adv: bla: fix type misuse for backbone_gw hash
indexing")
Fixes: 07568d0369
Hello,
syzbot found the following issue on:
HEAD commit:c5a13b33 kmsan: clang-format core
git tree: https://github.com/google/kmsan.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=13ef204b90
kernel config: https://syzkaller.appspot.com/x/.config?x=20f149ad694ba
syzbot has found a reproducer for the following issue on:
HEAD commit:325d0eab Merge branch 'akpm' (patches from Andrew)
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16992c8190
kernel config: https://syzkaller.appspot.com/x/.config?x=b12e84189082991c
On Sat, Sep 19, 2020 at 02:24:10PM +, David Laight wrote:
> I thought about that change while writing my import_iovec() => iovec_import()
> patch - and thought that the io_uring code would (as usual) cause grief.
>
> Christoph - did you see those patches?
No.
On Sun, Sep 20, 2020 at 12:14:49PM -0700, Andy Lutomirski wrote:
> I wonder if this is really quite cast in stone. We could also have
> FMODE_SHITTY_COMPAT and set that when a file like this is *opened* in
> compat mode. Then that particular struct file would be read and
> written using the compa
After commit 37ab4fa7844a ("net: unix: allow bind to fail on mutex lock"),
the assignment to err is redundant. So remove it.
Signed-off-by: Jing Xiangfeng
---
net/unix/af_unix.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 92784e51ee7d..eb82bdc
> You're going to have to update every single SWITCHDEV_PORT_ADD_OBJ
> handler and subsequent helpers to check the validate the protocol value.
>
> You also are going to have to make sure that every instantiated
> switchdev_obj_port_vlan object initializes the vlan protocol field properly.
>
> Ba
On Mon, Sep 21, 2020 at 12:23:18AM +, Vladimir Oltean wrote:
> On Mon, Sep 21, 2020 at 02:45:39AM +0300, Vladimir Oltean wrote:
> > This looks like a simple enough solution, but am I right that old
> > kernels, which ignore this new DEVLINK_ATTR_PORT_INDEX netlink
> > attribute, will consequent
On Sun, Sep 20, 2020 at 11:33:41PM +, Vladimir Oltean wrote:
> On Sat, Sep 19, 2020 at 04:43:28PM +0200, Andrew Lunn wrote:
> >
> > DSA only instantiates devlink ports for switch ports which are used.
> > For this hardware, only 4 user ports and the CPU port have devlink
> > ports, which explai
On Sun, Sep 20, 2020 at 11:23:29PM +, Vladimir Oltean wrote:
> On Sat, Sep 19, 2020 at 04:43:30PM +0200, Andrew Lunn wrote:
> > Allow DSA drivers to make use of devlink port regions, via simple
> > wrappers.
> >
> > Signed-off-by: Andrew Lunn
> > ---
> > include/net/dsa.h | 5 +
> > ne
From: Julia Lawall
Date: Sun, 20 Sep 2020 13:26:19 +0200
> sg_init_table zeroes its first argument, so the allocation of that argument
> doesn't have to.
>
> the semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> expression x,n,flags;
> @@
>
> x
From: Julia Lawall
Date: Sun, 20 Sep 2020 13:26:15 +0200
> sg_init_table zeroes its first argument, so the allocation of that argument
> doesn't have to.
>
> the semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> expression x,n,flags;
> @@
>
> x
When napi_consume_skb() is called in the tx desc cleaning process,
it is usually in the softirq context(BH disabled, or are processing
softirqs), but it may also be in the task context, such as in the
netpoll or loopback selftest process.
Currently napi_consume_skb() uses non-zero budget to indica
From: 劉偉權
Date: Mon, 21 Sep 2020 01:55:23 +
> Hi Andrew,
> Thanks...understood...
This is a top-post. Andrew said to not top-post, and you said
you understand this.
If you understand it, please stop top-posting.
Thank you.
From: Michael Chan
Date: Sun, 20 Sep 2020 21:08:53 -0400
> A series of small driver fixes covering VPD length logic,
> ethtool_get_regs on VF, hwmon temperature error handling,
> mutex locking for EEE and pause ethtool settings, and
> parameters for statistics related firmware calls.
Series appl
From: Vladimir Oltean
Date: Mon, 21 Sep 2020 03:10:22 +0300
> This series attempts to make DSA VLANs work in the presence of a master
> interface that is:
> - filtering, so it drops VLANs that aren't explicitly added to its
> filter list
> - offloading, so the old assumptions in the tagging cod
Hi Andrew,
Thanks...understood...
B.R.
Willy
Original Message-
From: Andrew Lunn
Sent: Friday, September 18, 2020 10:01 PM
To: 劉偉權
Cc: hkallwe...@gmail.com; da...@davemloft.net; li...@armlinux.org.uk;
k...@kernel.org; Ryan Kao ; netdev@vger.kernel.org;
linux-ker...@vger.kernel.org
Sub
Enable ALDPS(Advanced Link Down Power Saving) to save power when
link down.
Signed-off-by: Jisheng Zhang
---
Since v1:
- add what does ALDPS mean.
- replace magic number 0x18 with RTL8211F_PHYCR1 macro.
drivers/net/phy/realtek.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/dri
All changes related to bp->link_info require the protection of the
link_lock mutex. It's not sufficient to rely just on RTNL.
Fixes: 163e9ef63641 ("bnxt_en: Fix race when modifying pause settings.")
Reviewed-by: Edwin Peer
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt
A series of small driver fixes covering VPD length logic,
ethtool_get_regs on VF, hwmon temperature error handling,
mutex locking for EEE and pause ethtool settings, and
parameters for statistics related firmware calls.
Please queue patches 1, 2, and 3 for -stable. Thanks.
Edwin Peer (1):
bnxt
The wrong flag value caused the firmware call to return actual port
counters instead of the counter masks. This messed up the counter
overflow logic and caused erratic extended port counters to be
displayed under ethtool -S.
Fixes: 531d1d269c1d ("bnxt_en: Retrieve hardware masks for port counters
From: Edwin Peer
Returning "unknown" as a temperature value violates the hwmon interface
rules. Appropriate error codes should be returned via device_attribute
show instead. These will ultimately be propagated to the user via the
file system interface.
In addition to the corrected error handling
From: Vasundhara Volam
Using strlcpy() to copy from VPD is not correct because VPD strings
are not necessarily NULL terminated. Use memcpy() to copy the VPD
length up to the destination buffer size - 1. The destination is
zeroed memory so it will always be NULL terminated.
Fixes: a0d0fd70fed5
From: Vasundhara Volam
Debug firmware commands are not supported on VFs to read registers.
This patch avoids logging unnecessary access_denied error on VFs
when user calls ETHTOOL_GREGS.
By returning error in get_regs_len() method on the VF, the get_regs()
method will not be called.
Fixes: b5d6
Fix it to set the required fid input parameter. The firmware call
fails without this patch.
Fixes: d752d0536c97 ("bnxt_en: Retrieve hardware counter masks from firmware if
available.")
Reviewed-by: Edwin Peer
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
1 f
On Mon, Sep 21, 2020 at 02:45:39AM +0300, Vladimir Oltean wrote:
> This looks like a simple enough solution, but am I right that old
> kernels, which ignore this new DEVLINK_ATTR_PORT_INDEX netlink
> attribute, will consequently interpret any devlink command for a port as
> being for a global regio
DSA tries to prevent having a VLAN added by a bridge and by an 802.1Q
upper at the same time. It does that by checking the VID in
.ndo_vlan_rx_add_vid(), since that's something that the 8021q module
calls, via vlan_vid_add(). When a VLAN matches in both subsystems, this
check returns -EBUSY.
Howev
When the bridge has VLAN awareness disabled there isn't any duplication
of functionality, since the bridge does not process VLAN. Don't deny
adding 8021q uppers to DSA switch ports in that case. The switch is
supposed to simply pass traffic leaving the VLAN tag as-is, and the
stack will happily str
This is checking for the following order of operations, and makes sure
to deny that configuration:
ip link add link swp2 name swp2.100 type vlan id 100
ip link add br0 type bridge vlan_filtering 1
ip link set swp2 master br0
bridge vlan add dev swp2 vid 100
Instead of using vlan_for_each(), which
Check whether there is any hwaccel VLAN tag on RX, and if there is,
treat it as the tag_8021q header.
Signed-off-by: Vladimir Oltean
Reviewed-by: Florian Fainelli
---
Changes in v2:
None.
net/dsa/tag_sja1105.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff -
The current logic beats me a little bit. The comment that "bridge skips
-EOPNOTSUPP, so skip the prepare phase" was introduced in commit
fb2dabad69f0 ("net: dsa: support VLAN filtering switchdev attr").
I'm not sure:
(a) ok, the bridge skips -EOPNOTSUPP, but, so what, where are we
returning -E
We'll be adding a new check in the PRECHANGEUPPER notifier, where we'll
need to check some VLAN uppers. It is hard to do that when there is
already a function named dsa_slave_upper_vlan_check. So rename this one.
Not to mention that this function probably shouldn't have started with
"dsa_slave_" i
This series attempts to make DSA VLANs work in the presence of a master
interface that is:
- filtering, so it drops VLANs that aren't explicitly added to its
filter list
- offloading, so the old assumptions in the tagging code about there
being a VLAN tag in the skb are not necessarily true any
The whole purpose of tag_8021q is to send VLAN-tagged traffic to the
CPU, from which the driver can decode the source port and switch id.
Currently this only works if the VLAN filtering on the master is
disabled. Change that by explicitly adding code to tag_8021q.c to add
the VLANs corresponding t
There doesn't seem to be any strong technical reason for doing it this
way, but we'll be adding more checks for invalid upper device
configurations, and it will be easier to have them all grouped under
PRECHANGEUPPER.
Tested that it still works:
ip link set br0 type bridge vlan_filtering 1
ip link
Most DSA switch tags shift the EtherType to the right, causing the
master to not parse the VLAN as VLAN.
However, not all switches do that (example: tail tags, tag_8021q etc),
and if the DSA master has "rx-vlan-filter: on" in ethtool -k, then we
have a problem.
Therefore, we could populate the VLA
Hello,
syzbot found the following issue on:
HEAD commit:5fa35f24 Add linux-next specific files for 20200916
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=141e870190
kernel config: https://syzkaller.appspot.com/x/.config?x=619bde85d9eaaed5
dashboard
On Sat, Sep 19, 2020 at 04:43:32PM +0200, Andrew Lunn wrote:
> Add a devlink region to return the per port registers.
>
> Signed-off-by: Andrew Lunn
> ---
> drivers/net/dsa/mv88e6xxx/chip.c| 8
> drivers/net/dsa/mv88e6xxx/devlink.c | 61 +
> drivers/net/dsa/
On Sat, Sep 19, 2020 at 04:43:31PM +0200, Andrew Lunn wrote:
> Hide away from DSA drivers how devlink works.
>
> Signed-off-by: Andrew Lunn
> ---
> include/net/dsa.h | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/include/net/dsa.h b/include/net/dsa.h
> index 01da896b29
On Sat, Sep 19, 2020 at 04:43:29PM +0200, Andrew Lunn wrote:
> Allow regions to be registered to a devlink port. The same netlink API
> is used, but the port index is provided to indicate when a region is a
> port region as opposed to a device region.
>
> Signed-off-by: Andrew Lunn
> ---
> inclu
On 9/20/2020 4:33 PM, Vladimir Oltean wrote:
On Sat, Sep 19, 2020 at 04:43:28PM +0200, Andrew Lunn wrote:
DSA only instantiates devlink ports for switch ports which are used.
For this hardware, only 4 user ports and the CPU port have devlink
ports, which explains the discontinuous port regio
On Sat, Sep 19, 2020 at 04:43:28PM +0200, Andrew Lunn wrote:
>
> DSA only instantiates devlink ports for switch ports which are used.
> For this hardware, only 4 user ports and the CPU port have devlink
> ports, which explains the discontinuous port regions.
This is not so much a choice, as it is
On Sat, Sep 19, 2020 at 04:43:30PM +0200, Andrew Lunn wrote:
> Allow DSA drivers to make use of devlink port regions, via simple
> wrappers.
>
> Signed-off-by: Andrew Lunn
> ---
> include/net/dsa.h | 5 +
> net/core/devlink.c | 3 +--
> net/dsa/dsa.c | 14 ++
> 3 files ch
On Sun, Sep 20, 2020 at 08:22:59PM +0100, Matthew Wilcox wrote:
> On Sun, Sep 20, 2020 at 08:10:31PM +0100, Al Viro wrote:
> > IMO it's much saner to mark those and refuse to touch them from io_uring...
>
> Simpler solution is to remove io_uring from the 32-bit syscall list.
> If you're a 32-bit p
On 9/20/2020 10:17 AM, Andrew Lunn wrote:
Add kerneldoc for the core PHY data structures, a few inline functions
and exported functions which are not already documented.
Signed-off-by: Andrew Lunn
Looks good for the most part, if you can capitalize Phy, phy or any
variant in the process t
From: Liu Jian
Date: Sat, 19 Sep 2020 18:59:45 +0800
> Suppress a bunch of warnings of the form:
>
> drivers/net/ethernet/renesas/sh_eth.c:100:13: warning: initialized field
> overwritten [-Woverride-init]
>
> This is because after the sh_eth_offset_xxx array is initialized to
> SH_ETH_OFFSET
From: Zhang Changzhong
Date: Sat, 19 Sep 2020 10:26:51 +0800
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/marvell/mvneta.c:754:6: warning:
> variable 'dummy' set but not used [-Wunused-but-set-variable]
> 754 | u32 dummy;
> | ^
>
> This variable
From: Yunsheng Lin
Date: Sat, 19 Sep 2020 10:24:47 +0800
> When budget is non-zero, skb_unref() has already handled the
> NULL checking.
>
> When budget is zero, the dev_consume_skb_any() has handled NULL
> checking in __dev_kfree_skb_irq(), or dev_kfree_skb() which also
> ultimately call skb_un
From: Henry Ptasinski
Date: Sat, 19 Sep 2020 00:12:11 +
> When calculating ancestor_size with IPv6 enabled, simply using
> sizeof(struct ipv6_pinfo) doesn't account for extra bytes needed for
> alignment in the struct sctp6_sock. On x86, there aren't any extra
> bytes, but on ARM the ipv6_pin
From: Lorenzo Bianconi
Date: Sat, 19 Sep 2020 02:03:26 +0200
> Avoid copying skb_shared_info frags array in mvneta_swbm_build_skb() since
> __build_skb_around() does not overwrite it
>
> Signed-off-by: Lorenzo Bianconi
Applied, thank you.
From: Arnd Bergmann
> Sent: 20 September 2020 21:49
>
> On Sun, Sep 20, 2020 at 9:28 PM Andy Lutomirski wrote:
> > On Sun, Sep 20, 2020 at 12:23 PM Matthew Wilcox wrote:
> > >
> > > On Sun, Sep 20, 2020 at 08:10:31PM +0100, Al Viro wrote:
> > > > IMO it's much saner to mark those and refuse to t
From: Colin King
Date: Fri, 18 Sep 2020 22:51:26 +0100
> From: Colin Ian King
>
> A continue statement is indented incorrectly, add in the missing
> tab.
>
> Signed-off-by: Colin Ian King
Applied.
On 9/20/2020 10:17 AM, Andrew Lunn wrote:
Document the main structures, a few inline helpers and exported
functions which are not already documented.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
From: Linus Walleij
Date: Sat, 19 Sep 2020 00:29:54 +0200
> We go to lengths to determine whether the PVID should be set
> for this port or not, and then fail to take it into account.
> Fix this oversight.
>
> Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> Signed-off-by:
On 9/20/2020 10:16 AM, Andrew Lunn wrote:
Fix the Sphinx warning:
./include/linux/netdevice.h:2162: warning: Function parameter or member
'proto_down_reason' not described in 'net_device'
by adding the needed documentation.
Cc: Roopa Prabhu
Signed-off-by: Andrew Lunn
Reviewed-by: Floria
On 9/20/2020 10:17 AM, Andrew Lunn wrote:
Add missing parameter documentation, or fixup wrong parameter names.
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 9/20/2020 1:37 PM, Linus Walleij wrote:
There is an off-by-one error in rtl8366rb_is_vlan_valid()
making VLANs 0..4094 valid while it should be 1..4095.
Fix it.
Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
Signed-off-by: Linus Walleij
Reviewed-by: Florian Fainel
On Sun, Sep 20, 2020 at 9:28 PM Andy Lutomirski wrote:
> On Sun, Sep 20, 2020 at 12:23 PM Matthew Wilcox wrote:
> >
> > On Sun, Sep 20, 2020 at 08:10:31PM +0100, Al Viro wrote:
> > > IMO it's much saner to mark those and refuse to touch them from
> > > io_uring...
> >
> > Simpler solution is to
There is an off-by-one error in rtl8366rb_is_vlan_valid()
making VLANs 0..4094 valid while it should be 1..4095.
Fix it.
Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
Signed-off-by: Linus Walleij
---
drivers/net/dsa/rtl8366rb.c | 2 +-
1 file changed, 1 insertion(+), 1 de
Hello,
syzbot found the following issue on:
HEAD commit:5fa35f24 Add linux-next specific files for 20200916
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1122e2d990
kernel config: https://syzkaller.appspot.com/x/.config?x=6bdb7e39caf48f53
dashboard
Hi all,
In commit
2369e8270469 ("batman-adv: mcast: fix duplicate mcast packets from BLA
backbone to mesh")
Fixes tag
Fixes: 279e89b2281a ("batman-adv: add broadcast duplicate check")
has these problem(s):
- Subject does not match target commit subject
Did you mean:
Fixes: 279e89b228
Hi all,
Commit
097930e85f90 ("batman-adv: bla: fix type misuse for backbone_gw hash
indexing")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
pgpIpyBLeEkQS.pgp
Description: OpenPGP digital signature
On Sun, Sep 20, 2020 at 12:23 PM Matthew Wilcox wrote:
>
> On Sun, Sep 20, 2020 at 08:10:31PM +0100, Al Viro wrote:
> > IMO it's much saner to mark those and refuse to touch them from io_uring...
>
> Simpler solution is to remove io_uring from the 32-bit syscall list.
> If you're a 32-bit process,
On Sun, Sep 20, 2020 at 08:10:31PM +0100, Al Viro wrote:
> IMO it's much saner to mark those and refuse to touch them from io_uring...
Simpler solution is to remove io_uring from the 32-bit syscall list.
If you're a 32-bit process, you don't get to use io_uring. Would
any real users actually care
On Sun, Sep 20, 2020 at 11:07 AM Al Viro wrote:
>
> On Sun, Sep 20, 2020 at 04:15:10PM +0100, Matthew Wilcox wrote:
> > On Fri, Sep 18, 2020 at 02:45:25PM +0200, Christoph Hellwig wrote:
> > > Add a flag to force processing a syscall as a compat syscall. This is
> > > required so that in_compat_s
On Sun, Sep 20, 2020 at 08:01:59PM +0100, Matthew Wilcox wrote:
> On Sun, Sep 20, 2020 at 07:07:42PM +0100, Al Viro wrote:
> > 2) a few drivers are really fucked in head. They use different
> > *DATA* layouts for reads/writes, depending upon the calling process.
> > IOW, if you fork/exec a 32b
On Sun, Sep 20, 2020 at 11:47 AM Greg Kroah-Hartman
wrote:
>
> On Sat, Sep 19, 2020 at 04:22:35PM -0300, Jason Gunthorpe wrote:
> > On Sat, Sep 19, 2020 at 07:27:30PM +0200, Greg Kroah-Hartman wrote:
> > > > It's probably heresy, but why do I need to integrate into the RDMA
> > > > subsystem ?
>
On Sun, Sep 20, 2020 at 07:07:42PM +0100, Al Viro wrote:
> 2) a few drivers are really fucked in head. They use different
> *DATA* layouts for reads/writes, depending upon the calling process.
> IOW, if you fork/exec a 32bit binary and your stdin is one of those,
> reads from stdin in parent
On Sun, Sep 20, 2020 at 07:07:42PM +0100, Al Viro wrote:
> /proc/bus/input/devices (fucked bitmap-to-text representation)
To illustrate the, er, beauty of that stuff:
; cat32 /proc/bus/input/devices >/tmp/a
; cat /proc/bus/input/devices >/tmp/b
; diff -u /tmp/a /tmp/b|grep '^[-+]'
--- /tmp/a
On Sun, Sep 20, 2020 at 09:59:36AM -0700, Andy Lutomirski wrote:
> As one example, look at __sys_setsockopt(). It's called for the
> native and compat versions, and it contains an in_compat_syscall()
> check. (This particularly check looks dubious to me, but that's
> another story.) If this wer
On Sun, Sep 20, 2020 at 04:15:10PM +0100, Matthew Wilcox wrote:
> On Fri, Sep 18, 2020 at 02:45:25PM +0200, Christoph Hellwig wrote:
> > Add a flag to force processing a syscall as a compat syscall. This is
> > required so that in_compat_syscall() works for I/O submitted by io_uring
> > helper thr
On 9/20/20 10:16 AM, Andrew Lunn wrote:
> The first two patches just fixed warnings seen while trying to work on
> PHY documentation.
>
> The following patches then first fix existing warnings in the
> kerneldoc for the PHY subsystem, and then extend the kernel
> documentation for the major struct
Add missing parameter documentation, or fixup wrong parameter names.
Signed-off-by: Andrew Lunn
---
include/linux/mdio.h | 3 ++-
include/linux/phy.h | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/mdio.h b/include/linux/mdio.h
index 3a88b699b758..dbd69b3d1
Add kerneldoc for the core PHY data structures, a few inline functions
and exported functions which are not already documented.
Signed-off-by: Andrew Lunn
---
Documentation/networking/kapi.rst | 9 +
drivers/net/phy/phy-core.c| 30 +++
drivers/net/phy/phy.c | 69 -
in
The first two patches just fixed warnings seen while trying to work on
PHY documentation.
The following patches then first fix existing warnings in the
kerneldoc for the PHY subsystem, and then extend the kernel
documentation for the major structures and functions in the PHY
subsystem.
Andrew Lun
Document the main structures, a few inline helpers and exported
functions which are not already documented.
Signed-off-by: Andrew Lunn
---
Documentation/networking/kapi.rst | 15 ++
drivers/net/phy/mdio_bus.c| 37 +
drivers/net/phy/mdio_device.c | 21
include
Fix the Sphinx warning:
Function parameter or member 'xdp_state' not described in 'net_device'
by documenting xdp_state.
Cc: Andrii Nakryiko
Signed-off-by: Andrew Lunn
---
include/linux/netdevice.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/netdevice.h b/include/linux
Fix the Sphinx warning:
./include/linux/netdevice.h:2162: warning: Function parameter or member
'proto_down_reason' not described in 'net_device'
by adding the needed documentation.
Cc: Roopa Prabhu
Signed-off-by: Andrew Lunn
---
include/linux/netdevice.h | 1 +
1 file changed, 1 insertion(+)
On Sat, Sep 19, 2020 at 7:57 PM Al Viro wrote:
>
> On Sat, Sep 19, 2020 at 05:14:41PM -0700, Andy Lutomirski wrote:
>
> > > 2) have you counted the syscalls that do and do not need that?
> >
> > No.
>
> Might be illuminating...
>
> > > 3) how many of those realistically *can* be unified with their
On Wed, Sep 16, 2020 at 02:00:54PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 16, 2020 at 11:47:58AM +0300, Oded Gabbay wrote:
> > On Wed, Sep 16, 2020 at 11:21 AM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Wed, Sep 16, 2020 at 11:02:39AM +0300, Oded Gabbay wrote:
> > > > On Wed, Sep 16, 202
On Sun, Sep 20, 2020 at 5:15 PM Matthew Wilcox wrote:
>
> On Fri, Sep 18, 2020 at 02:45:25PM +0200, Christoph Hellwig wrote:
> > Add a flag to force processing a syscall as a compat syscall. This is
> > required so that in_compat_syscall() works for I/O submitted by io_uring
> > helper threads on
I really like that as it’s self-documenting and anyone debugging it can see
what is actually being used at a glance.
> On Sep 20, 2020, at 09:15, Matthew Wilcox wrote:
>
> On Fri, Sep 18, 2020 at 02:45:25PM +0200, Christoph Hellwig wrote:
>> Add a flag to force processing a syscall as a compat
Thanks, Julia!
> On Sep 20, 2020, at 7:26 AM, Julia Lawall wrote:
>
> sg_init_table zeroes its first argument, so the allocation of that argument
> doesn't have to.
>
> the semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> expression x,n,flags;
Sat, Sep 19, 2020 at 01:20:34AM CEST, tlfal...@linux.ibm.com wrote:
>
>On 9/18/20 2:20 AM, Jiri Pirko wrote:
>> Thu, Sep 17, 2020 at 10:31:10PM CEST, tlfal...@linux.ibm.com wrote:
>> > On 9/10/20 2:00 AM, Jiri Pirko wrote:
>> > > Tue, Sep 08, 2020 at 08:27:13PM CEST, tlfal...@linux.ibm.com wrote:
>
On Fri, Sep 18, 2020 at 02:45:25PM +0200, Christoph Hellwig wrote:
> Add a flag to force processing a syscall as a compat syscall. This is
> required so that in_compat_syscall() works for I/O submitted by io_uring
> helper threads on behalf of compat syscalls.
Al doesn't like this much, but my su
Hello,
syzbot found the following issue on:
HEAD commit:0f9ad4e7 Merge branch 's390-qeth-next'
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=15fc675590
kernel config: https://syzkaller.appspot.com/x/.config?x=d29a102d22f784ea
dashboard link: https://s
On Sun, Sep 20, 2020 at 03:55:47PM +0200, Arnd Bergmann wrote:
> On Sun, Sep 20, 2020 at 12:09 AM Al Viro wrote:
> > On Fri, Sep 18, 2020 at 05:16:15PM +0200, Christoph Hellwig wrote:
> > > On Fri, Sep 18, 2020 at 02:58:22PM +0100, Al Viro wrote:
> > > > Said that, why not provide a variant that w
n those 141 lines when it is time to add a new flag
to W=1?
How often are new W=1 flags added? My patch exported
KBUILD_CFLAGS_WARN1. How about instead we export
KBUILD_CFLAGS_WARN1_20200920. A subsystem can then sign up to being
W=1 clean as for the 20200920 definition of W=1.
If you want to add
I'm Mrs.Frau Kiran, an indian, philanthropist and art collector. I bring to you
a Beneficial CharityProposal to assist me with. If interested!, respond back. I
will be more detailed on proposal in my next email to you.
Best Regards Mrs.Frau Kiran
On Sun, Sep 20, 2020 at 04:16:53PM +0200, Robert Marko wrote:
> While up-streaming the IPQ4019 driver it was thought that the controller had
> no Clause 45 support,
> but it actually does and its activated by writing a bit to the mode register.
>
> So lets add it as newer SoC-s use the same contr
On Sun, Sep 20, 2020 at 2:19 AM Andrew Lunn wrote:
>
> > +
> > +/* 0 = Clause 22, 1 = Clause 45 */
> > +#define MDIO_MODE_BITBIT(8)
>
> How about calling this MDIO_MODE_C45
Good idea, will rename it.
>
> > + /* Enter Clause 45 mode */
> > +
This patch series adds support for Clause 45 to the driver.
While at it also change some defines to upper case to match rest of the driver.
Changes since v1:
* Drop clock patches, these need further investigation and
no user for non default configuration has been found
Robert Marko (2):
net: m
While up-streaming the IPQ4019 driver it was thought that the controller had no
Clause 45 support,
but it actually does and its activated by writing a bit to the mode register.
So lets add it as newer SoC-s use the same controller and Clause 45 compliant
PHY-s.
Signed-off-by: Robert Marko
Cc:
In the commit adding the IPQ4019 MDIO driver, defines for timeout and sleep
partially used lower case.
Lets change it to upper case in line with the rest of driver defines.
Signed-off-by: Robert Marko
Cc: Luka Perkov
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
drivers/net/phy/
On Sun, Sep 20, 2020 at 12:09 AM Al Viro wrote:
> On Fri, Sep 18, 2020 at 05:16:15PM +0200, Christoph Hellwig wrote:
> > On Fri, Sep 18, 2020 at 02:58:22PM +0100, Al Viro wrote:
> > > Said that, why not provide a variant that would take an explicit
> > > "is it compat" argument and use it there?
On Fri, Sep 18, 2020 at 10:51:26PM +0100, Colin King wrote:
> From: Colin Ian King
>
> A continue statement is indented incorrectly, add in the missing
> tab.
>
> Signed-off-by: Colin Ian King
> ---
> lib/test_rhashtable.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Herb
1 - 100 of 117 matches
Mail list logo
