On Mon, Sep 14, 2020 at 03:45:00PM +0200, Jiri Pirko wrote:
> Mon, Sep 14, 2020 at 08:07:51AM CEST, mo...@mellanox.com wrote:
> >Expose devlink reload actions stats to the user through devlink dev
> >get command.
> >
> >Examples:
> >$ devlink dev show
> >pci/:82:00.0:
> > reload_action_stats:
On Mon, Sep 14, 2020 at 04:26:17PM +0100, Matthew Wilcox wrote:
> On Mon, Sep 14, 2020 at 04:44:16PM +0200, Christoph Hellwig wrote:
> > I'm still a little unsure about the API naming, as alloc_pages sort of
> > implies a struct page return value, but we return a kernel virtual
> > address.
>
> Er
On Mon, Sep 14, 2020 at 06:34:02PM +0300, Sergei Shtylyov wrote:
> On 9/14/20 5:44 PM, Christoph Hellwig wrote:
>
> > DMA_ATTR_NON_CONSISTENT is a no-op except on PARISC and some mips
> > configs, so don't set it in this ARM specific driver.
>
>Hm, PARICS and ARM capitalized but mips in lower
On Mon, Sep 14, 2020 at 04:13:58PM +0100, Matthew Wilcox wrote:
> On Mon, Sep 14, 2020 at 04:44:27PM +0200, Christoph Hellwig wrote:
> > drivers/net/ethernet/i825xx/lasi_82596.c | 25 ++---
> > drivers/net/ethernet/i825xx/lib82596.c | 114 ++-
> > drivers/net/ethernet/i825xx
On 9/4/20 3:10 PM, Wang Hai wrote:
> KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced.
> So better to remove it.
>
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
> ---
> drivers/net/can/kvaser_pciefd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net
On 9/4/20 3:12 PM, Wang Hai wrote:
> CANFD_CLK_SEL_DIV_MASK and CANFD_OPTIONS_SET are
> never used after they were introduced. Remove them.
>
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
> ---
> drivers/net/can/peak_canfd/peak_pciefd_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>
On Mon, Sep 14, 2020 at 08:20:18AM -0700, James Bottomley wrote:
> If you're going to change the macros from taking a device to taking a
> hostdata structure then the descriptive argument name needs to change
> ... it can't be dev anymore. I'm happy with it simply becoming 'h' if
> hostdata is too
On 9/8/20 4:59 PM, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_ED
Tue, Sep 15, 2020 at 12:06:19AM CEST, michael.c...@broadcom.com wrote:
>On Mon, Sep 14, 2020 at 2:31 PM Jakub Kicinski wrote:
>>
>> On Mon, 14 Sep 2020 13:28:29 +0200 Jiri Pirko wrote:
>> > >> Instead, why don't you block in reload_up() until the reset is complete?
>> > >
>> > >Though user initiat
Hello sir,
> > I hope the patch will get merged soon.
>
> No need to "hope"; you could split up Matthew's patch yourself, and test and
> send the resulting patches. From the above thread, it looks like the
> networking
> developers want one patch to fix the improper use of GFP_ATOMIC (which is
On Mon, Sep 14, 2020 at 12:43:04PM -0700, Martin KaFai Lau wrote:
> For other ARG_PTR_TO_SOCK_COMMON helpers, they are not available to
> the tracing prog type. Hence, they are fine to accept PTR_TO_BTF_ID
> as ARG_PTR_TO_SOCK_COMMON since the only way for non tracing prog to
> get a PTR_TO_BTF_ID
On Tue, Sep 15, 2020 at 10:43:31AM +0530, Anmol Karn wrote:
> On Mon, Sep 14, 2020 at 08:26:55PM +0100, Matthew Wilcox wrote:
> > On Tue, Sep 15, 2020 at 12:17:55AM +0530, Anmol Karn wrote:
> > > On Mon, Sep 14, 2020 at 12:08:03PM +0100, Matthew Wilcox wrote:
> > > > On Mon, Sep 14, 2020 at 12:47:2
On Mon, Sep 14, 2020 at 6:43 PM Andrii Nakryiko wrote:
>
> Move almost 200 tests from test_btf into test_progs framework to be exercised
> regularly. Pretty-printing tests were left alone and renamed into
> test_btf_pprint because they are very slow and were not even executed by
> default with tes
On 9/14/20 2:28 PM, Song Liu wrote:
On Mon, Sep 14, 2020 at 11:47 AM Yonghong Song wrote:
Currently, we use bucket_lock when traversing bpf_sk_storage_map
elements. Since bpf_iter programs cannot use bpf_sk_storage_get()
and bpf_sk_storage_delete() helpers which may also grab bucket lock,
w
On Mon, 2020-09-14 at 23:01 +0200, Armin Wolf wrote:
> Fix various checkpatch warnings.
>
> Remove version printing so modules including lib8390 do not
> have to provide a global version string for successful
> compilation.
This 8390 code is for a _really_ old driver.
It doesn't seem likely these
On Mon, Sep 14, 2020 at 08:26:55PM +0100, Matthew Wilcox wrote:
> On Tue, Sep 15, 2020 at 12:17:55AM +0530, Anmol Karn wrote:
> > On Mon, Sep 14, 2020 at 12:08:03PM +0100, Matthew Wilcox wrote:
> > > On Mon, Sep 14, 2020 at 12:47:24PM +0530, Anmol Karn wrote:
> > > > idr_get_next() gives WARN_ON_ON
On Mon, 2020-09-14 at 20:06 +0800, Huazhong Tan wrote:
> From: Yunsheng Lin
>
> Use napi_consume_skb() to batch consuming skb when cleaning
> tx desc in NAPI polling.
>
> Signed-off-by: Yunsheng Lin
> Signed-off-by: Huazhong Tan
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c| 27
On Mon, 2020-09-14 at 23:01 +0200, Armin Wolf wrote:
> Replace pr_cont() with SMP-safe construct.
>
> Signed-off-by: Armin Wolf
> ---
> drivers/net/ethernet/8390/lib8390.c | 31 +++--
> 1 file changed, 12 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/net/ethern
Saeed,
ommit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
introduced a new tasklet initialization API. This series converts
all the net/* drivers to use the new tasklet_setup() API
^^^
this is not all drivers ..
Right, my bad, I should not have said net/*.
see below
On Tue, 2020-09-15 at 09:42 +0530, Allen Pais wrote:
> > > ommit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
> > > introduced a new tasklet initialization API. This series converts
> > > all the net/* drivers to use the new tasklet_setup() API
^^^
this is not all drivers ..
On Fri, Sep 11, 2020 at 08:59:27PM +0200, Maciej Fijalkowski wrote:
> On Thu, Sep 03, 2020 at 12:51:14PM -0700, Alexei Starovoitov wrote:
> > On Wed, Sep 02, 2020 at 10:08:15PM +0200, Maciej Fijalkowski wrote:
> > > diff --git a/tools/testing/selftests/bpf/progs/tailcall6.c
> > > b/tools/testing/s
Replace an instance of kmemdup() with the devres counted version
instead.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/dec/tulip/de2104x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
b/drivers/net/ethernet/dec/tulip
Replace pci_enable_device() with its devres counterpart
pcim_enable_device().
Signed-off-by: Moritz Fischer
---
Note: Please check my logic on this, it would seem to me
calling pci_disable_device() on devices enabled with
pcim_enable_device() *should* be fine.
Changes from v1:
- Fixed missing r
This series is the first bunch of minor cleanups for the de2104x driver
to make it look and behave more like a modern driver.
These changes replace some of the non-devres versions with devres
versions of functions to simplify the error paths.
Next up after this will be the ioremap part.
Changes
Replace devm_alloc_etherdev() with its devres version.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
b/drivers/net/ethernet/dec/tulip/de2104x.c
index
On Mon, 2020-09-14 at 18:44 -0700, Jesse Brandeburg wrote:
> After applying the patches below, the drivers/net/ethernet
> directory can be built as modules with W=1 with no warnings (so
> far on x64_64 arch only!).
> As Jakub pointed out, there is much more work to do to clean up
> C=1, but that wi
ommit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
introduced a new tasklet initialization API. This series converts
all the net/* drivers to use the new tasklet_setup() API
This series is based on v5.9-rc5
Allen Pais (12):
net: mvpp2: Prepare to use the new tasklet API
From: Allen Pais
ommit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
introduced a new tasklet initialization API. This series converts
all the net/* drivers to use the new tasklet_setup() API
This series is based on v5.9-rc5
I don't understand how this works, you're not passin
On Mon, 2020-09-14 at 18:44 -0700, Jesse Brandeburg wrote:
> While fixing the W=1 builds, this warning came up because the
> developers used a very tricky way to get structures initialized
> to a non-zero value, but this causes GCC to warn about an
> override. In this case the override was intentio
Kfir reported that pmtu exceptions are not created properly for
deployments where multipath routes use the same device.
After some digging I see 2 compounding problems:
1. ip_route_output_key_hash_rcu is updating the flowi4_oif *after*
the route lookup. This is the second use case where this ha
Fix parameter description of tipc_link_bc_create()
Reported-by: Hulk Robot
Fixes: 16ad3f4022bb ("tipc: introduce variable window congestion control")
Signed-off-by: Lu Wei
---
net/tipc/link.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/tipc/link.c b/net/tipc/link.c
On Fri, Sep 11, 2020 at 6:16 AM Jiri Olsa wrote:
>
> On Thu, Sep 10, 2020 at 05:46:21PM -0700, Alexei Starovoitov wrote:
> > On Thu, Sep 10, 2020 at 5:22 AM Jiri Olsa wrote:
> > >
> > > Some kernels builds might inline vfs_getattr call within
> > > fstat syscall code path, so fentry/vfs_getattr t
On Mon, Sep 14, 2020 at 3:50 PM Song Liu wrote:
>
> On Mon, Sep 14, 2020 at 3:47 PM Andrii Nakryiko
> wrote:
> >
> > On Mon, Sep 14, 2020 at 3:32 PM Yonghong Song wrote:
> > >
> > > When syncing latest libbpf repo to bcc, ubuntu 16.04 (4.4.0 LTS kernel)
> > > failed compilation for xsk.c:
> > >
On Mon, Sep 14, 2020 at 6:31 PM Alexei Starovoitov
wrote:
>
> On Wed, Sep 9, 2020 at 7:51 PM Andrii Nakryiko wrote:
> >
> > Move almost 200 tests from test_btf into test_progs framework to be
> > exercised
> > regularly. Pretty-printing tests were left alone in test_btf because they
> > are
> >
On Mon, Sep 14, 2020 at 3:20 PM Andrii Nakryiko
wrote:
>
> On Mon, Sep 14, 2020 at 11:31 AM Yonghong Song wrote:
> >
> > When building bpf selftests like
> > make -C tools/testing/selftests/bpf -j20
> > I hit the following errors:
> > ...
> > GEN
> > /net-next/tools/testing/selftests/
On Mon, Sep 14, 2020 at 5:51 PM Andrii Nakryiko wrote:
>
> Make path to bench_ringbufs.c just a text, not a special link.
>
> Reported-by: Mauro Carvalho Chehab
> Fixes: 97abb2b39682 ("docs/bpf: Add BPF ring buffer design notes")
> Signed-off-by: Andrii Nakryiko
Applied. Thanks
While fixing the W=1 builds, this warning came up because the
developers used a very tricky way to get structures initialized
to a non-zero value, but this causes GCC to warn about an
override. In this case the override was intentional, so just
disable the warning for this code with a macro that re
As part of the W=1 compliation series, these lines all created
warnings about unused variables that were assigned a value. Most
of them are from register reads, but some are just picking up
a return value from a function and never doing anything with it.
The register reads should be OK, because th
On Mon, Sep 14, 2020 at 2:13 PM Song Liu wrote:
>
> On Mon, Sep 14, 2020 at 7:52 AM Magnus Karlsson
> wrote:
> >
> > From: Magnus Karlsson
> >
> > Fix a potential refcount warning that a zero value is increased to one
> > in xp_dma_map, by initializing the refcount to one to start with,
> > inst
This takes care of all of the trivial W=1 fixes in the Intel
Ethernet drivers, which allows developers and maintainers to
build more of the networking tree with more complete warning
checks.
Almost all of the changes were trivial comment updates on
function headers, with one debug message added to
Remove variables that were storing a return value from a register
read or other read, where the return value wasn't used. Those
conversions to remove the lvalue of the assignment should be safe
because the readl memory mapped reads are marked volatile and
should not be optimized out without an lval
As part of the W=1 series for ethernet, these drivers were discovered to
be using kdoc style comments but were not actually doing kdoc. The kernel
uses kdoc style when documenting code, not doxygen or other styles.
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/amazon/ena/ena_com.c
The W=1 builds showed a few files exporting functions
(non-static) that were not prototyped. What actually happened is
that there were prototypes, but the include file was forgotten in
the implementation file.
Add the include file and remove the warnings.
Signed-off-by: Jesse Brandeburg
---
dri
A couple of drivers had a "generic documentation" section that
would trigger a "can't understand" message from W=1 compiles.
Fix by using correct DOC: tags.
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/arc/emac_arc.c | 2 +-
drivers/net/ethernet/cadence/macb_pci.c | 2 +-
2 file
After applying the patches below, the drivers/net/ethernet
directory can be built as modules with W=1 with no warnings (so
far on x64_64 arch only!).
As Jakub pointed out, there is much more work to do to clean up
C=1, but that will be another series of changes.
This series removes 1,283 warnings
The flash string handling code triggered a W=1 warning and upon
investigation it seems everything can be handled in a simpler
way with a single initialization and one strlcat. The buffer is filled
with NULL after the end of the string by the initializer, and the
strlcat checks total length, and ma
kernel-doc script as used by W=1, is confused by the macro
usage inside the header describing the efx_ptp_data struct.
drivers/net/ethernet/sfc/ptp.c:345: warning: Function parameter or member
'MC_CMD_PTP_IN_TRANSMIT_LENMAX' not described in 'efx_ptp_data'
After some discussion on the list, brea
Move almost 200 tests from test_btf into test_progs framework to be exercised
regularly. Pretty-printing tests were left alone and renamed into
test_btf_pprint because they are very slow and were not even executed by
default with test_btf.
All the test_btf tests that were moved are modeled as prop
On 2020/9/15 5:45, Jakub Kicinski wrote:
> On Mon, 14 Sep 2020 20:06:56 +0800 Huazhong Tan wrote:
>> From: Yunsheng Lin
>>
>> writel() can be used to order I/O vs memory by default when
>> writing portable drivers. Use writel() to replace wmb() +
>> writel_relaxed(), and writel() is dma_wmb() + wr
On Thu, Sep 10, 2020 at 1:31 AM Magnus Karlsson
wrote:
>
> This small series improves/fixes three things in the xdpsock sample
> application. Details can be found in the individual commit messages,
> but a brief summary follows:
>
> Patch 1: fix one packet sending in xdpsock
> Patch 2: fix possibl
On Thu, Sep 10, 2020 at 12:56 AM Björn Töpel wrote:
>
> From: Björn Töpel
>
> For AF_XDP sockets, there was a discrepancy between the number of of
> pinned pages and the size of the umem region.
>
> The size of the umem region is used to validate the AF_XDP descriptor
> addresses. The logic that
Use the dim library to manage dynamic interrupt
moderation in ionic.
v2: untangled declarations in ionic_dim_work()
Signed-off-by: Shannon Nelson
Acked-by: Jakub Kicinski
---
.../ethernet/pensando/ionic/ionic_debugfs.c | 2 +
.../net/ethernet/pensando/ionic/ionic_dev.h | 1 +
.../etherne
On Mon, Sep 14, 2020 at 03:47:38PM -0700, Jakub Kicinski wrote:
> On Mon, 14 Sep 2020 16:21:22 -0400 Joel Fernandes wrote:
> > On Tue, Sep 08, 2020 at 05:27:51PM -0700, Jakub Kicinski wrote:
> > > On Tue, 08 Sep 2020 21:15:56 +0300 niko...@cumulusnetworks.com wrote:
> > > > Ah, you want to solve
On Wed, Sep 9, 2020 at 7:51 PM Andrii Nakryiko wrote:
>
> Move almost 200 tests from test_btf into test_progs framework to be exercised
> regularly. Pretty-printing tests were left alone in test_btf because they are
> very slow and were not even executed by default with test_btf. Also, they seem
>
This patch set is to add support for user to get or set Tx/Rx channel
via ethtool. There are two patches that fixes bug introduced on upstream
in order to have the feature work.
Tested on Intel Tigerlake Platform.
Aashish Verma (1):
net: stmmac: Fix incorrect location to set real_num_rx|tx_queu
From: Aashish Verma
netif_set_real_num_tx_queues() & netif_set_real_num_rx_queues() should be
used to inform network stack about the real Tx & Rx queue (active) number
in both stmmac_open() and stmmac_resume(), therefore, we move the code
from stmmac_dvr_probe() to stmmac_hw_setup().
Fixes: c02b
On 9/14/20 5:53 PM, Keller, Jacob E wrote:
-Original Message-
From: Shannon Nelson
Sent: Monday, September 14, 2020 4:47 PM
To: Jakub Kicinski ; Keller, Jacob E
Cc: netdev@vger.kernel.org; da...@davemloft.net
Subject: Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update
On
On Mon, 14 Sep 2020 13:01:20 +0530 Allen Pais wrote:
> From: Allen Pais
>
> The future tasklet API will no longer allow to pass an arbitrary
> "unsigned long" data parameter. The tasklet data structure will need to
> be embedded into a data structure that will be retrieved from the tasklet
> hand
linux/kernel.h is included more than once, Remove the one that isn't
necessary.
Signed-off-by: Tian Tao
---
drivers/vhost/vdpa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 3fab94f..95e2b83 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/v
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Jakub Kicinski
> Sent: Monday, September 14, 2020 4:36 PM
> To: Keller, Jacob E
> Cc: Shannon Nelson ; netdev@vger.kernel.org;
> da...@davemloft.net
> Subject: Re: [PATCH v3 net-next 2/2] ionic: add devlink firmwa
Make path to bench_ringbufs.c just a text, not a special link.
Reported-by: Mauro Carvalho Chehab
Fixes: 97abb2b39682 ("docs/bpf: Add BPF ring buffer design notes")
Signed-off-by: Andrii Nakryiko
---
Documentation/bpf/ringbuf.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Update supporters for IBM Power SRIOV Virtual NIC Device Driver.
Thomas Falcon is moving on to other works. Dany Madden, Lijun Pan
and Sukadev Bhattiprolu are the current supporters.
Signed-off-by: Dany Madden
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
On Mon, Sep 14, 2020 at 11:37 AM Stanislav Fomichev wrote:
>
> From: YiFei Zhu
>
> This is a simple test to check that loading and dumping metadata
> in btftool works, whether or not metadata contents are used by the
> program.
>
> A C test is also added to make sure the skeleton code can read th
On Mon, 14 Sep 2020 17:20:11 -0700 Paul E. McKenney wrote:
> > Seems like quite a few places depend on the macro disappearing its
> > argument. I was concerned that it's going to be had to pick out whether
> > !LOCKDEP builds should return true or false from LOCKDEP helpers, but
> > perhaps relying
On 9/14/20 5:47 PM, Anchal Agarwal wrote:
> On Sun, Sep 13, 2020 at 11:43:30AM -0400, boris.ostrov...@oracle.com wrote:
>> CAUTION: This email originated from outside of the organization. Do not
>> click links or open attachments unless you can confirm the sender and know
>> the content is safe
On Mon, Sep 14, 2020 at 03:47:38PM -0700, Jakub Kicinski wrote:
> On Mon, 14 Sep 2020 16:21:22 -0400 Joel Fernandes wrote:
> > On Tue, Sep 08, 2020 at 05:27:51PM -0700, Jakub Kicinski wrote:
> > > On Tue, 08 Sep 2020 21:15:56 +0300 niko...@cumulusnetworks.com wrote:
> > > > Ah, you want to solve
On Mon, Sep 14, 2020 at 5:13 PM Jakub Kicinski wrote:
>
> These stats are already reported in ethtool -S.
> Michael confirms they are equivalent to standard stats.
>
> v2: - fix sparse warning about endian by using the macro
> - use u64 for pointer type
>
> Signed-off-by: Jakub Kicinski
> Rev
Check if the pause stats are reported by HW by checking the bitmap.
Calculation is based on the order of strings in main_strings from
ethtool -S. Hopefully the semantics of these stats match the standard..
Signed-off-by: Jakub Kicinski
Reviewed-by: Saeed Mahameed
---
.../net/ethernet/mellanox/m
Make sure the empty nest is reported even without stats.
Make sure reporting only selected stats works fine.
Signed-off-by: Jakub Kicinski
Reviewed-by: Saeed Mahameed
---
.../drivers/net/netdevsim/ethtool-pause.sh| 108 ++
1 file changed, 108 insertions(+)
create mode 10075
Tell people that there now is an interface for querying pause frames.
A little bit of restructuring is needed given this is a first source
of such statistics.
Signed-off-by: Jakub Kicinski
Reviewed-by: Saeed Mahameed
---
Documentation/networking/statistics.rst | 57 ++---
1
Add minimal ethtool interface for testing ethtool pause stats.
v2: add missing static on nsim_ethtool_ops
Signed-off-by: Jakub Kicinski
Reviewed-by: Saeed Mahameed
---
drivers/net/netdevsim/Makefile| 2 +-
drivers/net/netdevsim/ethtool.c | 64 +++
drivers/net
Report standard pause frame stats. They are already aggregated
in struct ixgbe_hw_stats.
The combination of the registers is suggested as equivalent to
PAUSEMACCtrlFramesTransmitted / PAUSEMACCtrlFramesReceived
by the Intel 82576EB datasheet, I could not find any information
in the HW actually sup
These stats are already reported in ethtool -S.
Michael confirms they are equivalent to standard stats.
v2: - fix sparse warning about endian by using the macro
- use u64 for pointer type
Signed-off-by: Jakub Kicinski
Reviewed-by: Saeed Mahameed
---
.../net/ethernet/broadcom/bnxt/bnxt_etht
Plumb through all the indirection and copy some code from
ethtool -S. The names of the group indicate that these are
the stats we are after (and Saeed confirms it).
v3:
- fix build in mlx5_rep
v2:
- drop the ethool helper and call stats directly
- don't pass 0 as initialized to in buffer
- use
Currently drivers have to report their pause frames statistics
via ethtool -S, and there is a wide variety of names used for
these statistics.
Add the two statistics defined in IEEE 802.3x to the standard
API. Create a new ethtool request header flag for including
statistics in the response to GET
Hi!
This is the first (small) series which exposes some stats via
the corresponding ethtool interface. Here (thanks to the
excitability of netlink) we expose pause frame stats via
the same interfaces as ethtool -a / -A.
In particular the following stats from the standard:
- 30.3.4.2 aPAUSEMACCtr
Hi Marvin,
On Wed, Aug 05, 2020 at 05:45:51AM +, Gaube, Marvin (THSE-TL1) wrote:
> Hello,
> I'm using the upstream driver Vladimir mentioned, as of 5.4.51.
>
> Best regards
> Marvin Gaube
Could you try net-next again, now that David has merged this patch?
https://git.kernel.org/pub/scm/linux
From: Soheil Hassas Yeganeh
Date: Mon, 14 Sep 2020 17:52:10 -0400
> From: Soheil Hassas Yeganeh
>
> For EPOLLET, applications must call sendmsg until they get EAGAIN.
> Otherwise, there is no guarantee that EPOLLOUT is sent if there was
> a failure upon memory allocation.
>
> As a result on hi
From: Soheil Hassas Yeganeh
Date: Mon, 14 Sep 2020 17:52:09 -0400
> From: Soheil Hassas Yeganeh
>
> If there was any event available on the TCP socket, tcp_poll()
> will be called to retrieve all the events. In tcp_poll(), we call
> sk_stream_is_writeable() which returns true as long as we are
From: Shannon Nelson
Date: Sun, 13 Sep 2020 12:16:54 -0700
> Clean and rebuild the debugfs info for the queues being swapped.
>
> Fixes: a34e25ab977c ("ionic: change the descriptor ring length without full
> reset")
> Signed-off-by: Shannon Nelson
Applied.
From: Xin Long
Date: Sun, 13 Sep 2020 19:43:03 +0800
> In fl_set_erspan_opt(), all bits of erspan md was set 1, as this
> function is also used to set opt MASK. However, when setting for
> md->u.index for opt VALUE, the rest bits of the union md->u will
> be left 1. It would cause to fail the mat
From: Xin Long
Date: Sun, 13 Sep 2020 19:51:49 +0800
> This patch is to do some mask when setting vxlan option in net_sched
> and lwtunnel, so that only available bits can be set on vxlan md gbp.
>
> This would help when users don't know exactly vxlan's gbp bits, and
> avoid some mismatch becaus
On 9/14/20 4:36 PM, Jakub Kicinski wrote:
On Mon, 14 Sep 2020 16:15:28 -0700 Jacob Keller wrote:
On 9/10/2020 10:56 AM, Jakub Kicinski wrote:
IOW drop the component parameter from the normal helper, cause almost
nobody uses that. The add a more full featured __ version, which would
take the arg
From: Xin Long
Date: Sun, 13 Sep 2020 19:37:31 +0800
> In tipc_buf_append() it may change skb's frag_list, and it causes
> problems when this skb is cloned. skb_unclone() doesn't really
> make this skb's flag_list available to change.
>
> Shuang Li has reported an use-after-free issue because of
On Mon, Sep 14, 2020 at 11:37 AM Stanislav Fomichev wrote:
>
> From: YiFei Zhu
>
> Dump metadata in the 'bpftool prog' list if it's present.
> For some formatting some BTF code is put directly in the
> metadata dumping. Sanity checks on the map and the kind of the btf_type
> to make sure we are a
From: Peilin Ye
Date: Sun, 13 Sep 2020 04:06:05 -0400
> tipc_group_add_to_tree() returns silently if `key` matches `nkey` of an
> existing node, causing tipc_group_create_member() to leak memory. Let
> tipc_group_add_to_tree() return an error in such a case, so that
> tipc_group_create_member() c
On Mon, 14 Sep 2020 16:15:28 -0700 Jacob Keller wrote:
> On 9/10/2020 10:56 AM, Jakub Kicinski wrote:
> > IOW drop the component parameter from the normal helper, cause almost
> > nobody uses that. The add a more full featured __ version, which would
> > take the arg struct, the struct would includ
From: Vladimir Oltean
Date: Sat, 12 Sep 2020 02:26:07 +0300
> A DSA master interface has upper network devices, each representing an
> Ethernet switch port attached to it. Demultiplexing the source ports and
> setting skb->dev accordingly is done through the catch-all ETH_P_XDSA
> packet_type han
From: Landen Chao
Date: Fri, 11 Sep 2020 21:48:50 +0800
> This patch series adds support for MT7531.
>
> MT7531 is the next generation of MT7530 which could be found on Mediatek
> router platforms such as MT7622 or MT7629.
>
> It is also a 7-ports switch with 5 giga embedded phys, 2 cpu ports,
On Mon, Sep 14, 2020 at 11:37 AM Stanislav Fomichev wrote:
>
> From: YiFei Zhu
>
> The patch adds a simple wrapper bpf_prog_bind_map around the syscall.
> When the libbpf tries to load a program, it will probe the kernel for
> the support of this syscall and unconditionally bind .rodata section
>
Li RongQing wrote:
> when changes the rx/tx ring to 4096, kzalloc may fail due to
> a temporary shortage on slab entries.
>
> so using kvmalloc to allocate this memory as there is no need
> that this memory area is physical continuously.
>
> and using __GFP_RETRY_MAYFAIL to allocate from kmalloc
Li RongQing wrote:
> when changes the rx/tx ring to 4096, rx/tx_bi needs an order
> 5 pages, and allocation maybe fail due to memory fragmentation
> so switch to kvzalloc
Hi Li,
Thanks for your patches, but I think you're solving a problem that isn't
a problem (besides that the warning is being p
On Mon, Sep 14, 2020 at 11:37 AM Stanislav Fomichev wrote:
>
> From: YiFei Zhu
>
> The patch adds a simple wrapper bpf_prog_bind_map around the syscall.
> When the libbpf tries to load a program, it will probe the kernel for
> the support of this syscall and unconditionally bind .rodata section
>
On 9/10/2020 10:56 AM, Jakub Kicinski wrote:
> On Wed, 9 Sep 2020 18:34:57 -0700 Shannon Nelson wrote:
>> On 9/9/20 12:22 PM, Jakub Kicinski wrote:
>>> On Wed, 9 Sep 2020 10:58:19 -0700 Shannon Nelson wrote:
I'm suggesting that this implementation using the existing devlink
logg
On Mon, Sep 14, 2020 at 12:06:37PM -0500, Dan Murphy wrote:
> Hello
>
> I am adding the 100base Fx support for the ethtool. There are a few PHYs that
> support the Fiber connection and the ethtool should be able to properly
> display
> that the PHY supports the 100base-FX Full and Half Duplex mo
On 9/10/2020 10:56 AM, Jakub Kicinski wrote:
> IOW drop the component parameter from the normal helper, cause almost
> nobody uses that. The add a more full featured __ version, which would
> take the arg struct, the struct would include the timeout value.
>
I would point out that the ice drive
On Mon, Sep 14, 2020 at 9:08 AM Toke Høiland-Jørgensen wrote:
>
> Andrii Nakryiko writes:
>
> > On Fri, Sep 11, 2020 at 3:01 AM Toke Høiland-Jørgensen
> > wrote:
> >>
> >> From: Toke Høiland-Jørgensen
> >>
> >> This enables support for attaching freplace programs to multiple attach
> >> points
On 9/14/20 10:54 PM, Jakub Kicinski wrote:
> On Sat, 12 Sep 2020 21:36:29 +0200 Hauke Mehrtens wrote:
>> The napi_schedule() call will only schedule the NAPI if it is not
>> already running. To make sure that we do not deactivate interrupts
>> without scheduling NAPI only deactivate the interrupts
On Mon, 14 Sep 2020 15:02:18 -0700 Shannon Nelson wrote:
> On 9/10/20 10:56 AM, Jakub Kicinski wrote:
> > On Wed, 9 Sep 2020 18:34:57 -0700 Shannon Nelson wrote:
> >> On 9/9/20 12:22 PM, Jakub Kicinski wrote:
> >>> On Wed, 9 Sep 2020 10:58:19 -0700 Shannon Nelson wrote:
> I'm suggesting
On Mon, Sep 14, 2020 at 3:47 PM Andrii Nakryiko
wrote:
>
> On Mon, Sep 14, 2020 at 3:32 PM Yonghong Song wrote:
> >
> > When syncing latest libbpf repo to bcc, ubuntu 16.04 (4.4.0 LTS kernel)
> > failed compilation for xsk.c:
> > In file included from
> > /tmp/debuild.0jkauG/bcc/src/cc/libbpf/
1 - 100 of 402 matches
Mail list logo