On Sun, Sep 13, 2020 at 10:32 PM Martin Schiller wrote:
>
> Acked-by: Martin Schiller
Thank you, Martin!
On Sun, Sep 13, 2020 at 10:26 PM Krzysztof Hałasa wrote:
>
> Xie He writes:
>
> > The HDLC device is not actually prepending any header when it is used
> > with this driver. When the PVC device has prepended its header and
> > handed over the skb to the HDLC device, the HDLC device just hands it
When building bpf selftests like
make -C tools/testing/selftests/bpf -j20
I hit the following errors:
...
GEN
/net-next/tools/testing/selftests/bpf/tools/build/bpftool/Documentation/bpftool-gen.8
:75: (WARNING/2) Block quote ends without a blank line; unexpected
unindent.
:71: (WAR
Set capability to notify the firmware that this host driver is capable
of handling pci sync for firmware update events.
Signed-off-by: Moshe Shemesh
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/m
Firmware live patch event notifies the driver that the firmware was just
updated using live patch. In such case the driver should not reload or
re-initiate entities, part to updating the firmware version and
re-initiate the firmware tracer which can be updated by live patch with
new strings databas
Add functions to query and set the MFRL reset options supported by
firmware.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
.../ethernet/mellanox/mlx5/core/fw_reset.c| 46 +++
.../ethernet/mellanox/mlx5/core/fw_reset.h| 13 ++
Once the driver gets sync_reset_request from firmware it prepares for the
coming reset and sends acknowledge.
After getting this event the driver expects device reset, either it will
trigger PCI reset on sync_reset_now event or such PCI reset will be
triggered by another PF of the same device. So i
Add devlink reload action to allow the user to request a specific reload
action. The action parameter is optional, if not specified then devlink
driver re-init action is used (backward compatible).
Note that when required to do firmware activation some drivers may need
to reload the driver. On the
Add support for devlink reload action fw_activate. To activate firmware
image the mlx5 driver resets the firmware and reloads it from flash. If
a new image was stored on flash it will be loaded. Once this reload
command is executed the driver initiates fw sync reset flow, where the
firmware synchro
Introduce new options on devlink reload API to enable the user to select
the reload action required and contrains limits on these actions that he
may want to ensure. Complete support for reload actions in mlx5.
The following reload actions are supported:
driver_reinit: driver entities re-initiali
The enable_remote_dev_reset devlink param flags that the host admin
allows device resets that can be initiated by other hosts. This
parameter is useful for setups where a device is shared by different
hosts, such as multi-host setup. Once the user set this parameter to
false, the driver should NACK
If firmware sends sync_reset_abort to driver the driver should clear the
reset requested mode as reset is not expected any more.
Signed-off-by: Moshe Shemesh
---
.../net/ethernet/mellanox/mlx5/core/fw_reset.c| 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/net/eth
Add devlink reload rst documentation file.
Update index file to include it.
Signed-off-by: Moshe Shemesh
---
v3 -> v4:
- Remove reload action fw_activate_no_reset
- Add reload actions limit levels and document the no_reset limit level
constrains
v2 -> v3:
- Devlink reload returns the actions do
The enable_remote_dev_reset devlink param flags that the host admin
allows resets by other hosts. In case it is cleared mlx5 host PF driver
will send NACK on pci sync for firmware update reset request and the
command will fail.
By default enable_remote_dev_reset parameter is true, so pci sync for
f
Add support for devlink reload action fw_activate with limit level
no_reset which does firmware live patching, updating the firmware image
without reset, no downtime and no configuration lose. The driver checks
if the firmware is capable of handling the pending firmware changes as a
live patch. If
Add reload action limit level to demand restrictions on actions.
Reload action limit levels supported:
none (default): No constrains on actions. Driver implementation may
include reset or downtime as needed to perform the
actions.
no_reset: No reset allowed, no down
Expose devlink reload actions stats to the user through devlink dev
get command.
Examples:
$ devlink dev show
pci/:82:00.0:
reload_action_stats:
driver_reinit 2
fw_activate 1
driver_reinit_no_reset 0
fw_activate_no_reset 0
pci/:82:00.1:
reload_action_stats:
driver_r
Add reload action stats to hold the history per reload action type and
limit level.
For example, the number of times fw_activate has been performed on this
device since the driver module was added or if the firmware activation
was performed with or without reset.
Add devlink notification on stats u
On sync_reset_now event the driver does reload and PCI link toggle to
activate firmware upgrade reset. When the firmware sends this event it
syncs the event on all PFs, so all PFs will do PCI link toggle at once.
To do PCI link toggle, the driver ensures that no other device ID under
the same bridg
On 12/09/20 5:56 am, Ian Rogers wrote:
> If events in a group explicitly set a frequency or period with leader
> sampling, don't disable the samples on those events.
>
> Prior to 5.8:
> perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S'
> would clear the attributes then appl
On 2020-09-12 04:18, Xie He wrote:
x25_type_trans only needs to be called before we call netif_rx to pass
the skb to upper layers.
It does not need to be called before lapb_data_received. The LAPB
module
does not need the fields that are set by calling it.
In the other two X.25 drivers - lapb
On Sat, 2020-09-12 at 00:00 +0200, Rikard Falkeborn wrote:
> These are never modified, so constify them to allow the compiler to
> place them in read-only memory. This moves about 25kB to read-only
> memory as seen by the output of the size command.
Nice.
Did you find this by tool or inspection?
Xie He writes:
> The HDLC device is not actually prepending any header when it is used
> with this driver. When the PVC device has prepended its header and
> handed over the skb to the HDLC device, the HDLC device just hands it
> over to the hardware driver for transmission without prepending any
On September 13, 2020 4:35:44 PM t...@redhat.com wrote:
From: Tom Rix
clang static analysis flags this problem
sdio.c:3265:13: warning: Branch condition evaluates to
a garbage value
} else if (pending) {
^~~
brcmf_sdio_dcmd_resp_wait() only sets pending to true.
On Mon, Sep 14, 2020 at 4:37 AM Andrew Lunn wrote:
>
> > +static int gaudi_nic_get_module_eeprom(struct net_device *netdev,
> > + struct ethtool_eeprom *ee, u8 *data)
> > +{
> > + struct gaudi_nic_device **ptr = netdev_priv(netdev);
> > + struct gaudi_ni
On Mon, Sep 14, 2020 at 4:39 AM Florian Fainelli wrote:
>
>
>
> On 9/12/2020 7:41 AM, Oded Gabbay wrote:
> > From: Omer Shpigelman
> >
> > The driver supports ethtool callbacks and provides statistics using the
> > device's profiling infrastructure (coresight).
>
> Is there any relationship near
I can assure you that when I said "I think", I meant it in an assertive manner,
and not an assumptive one, but I can understand how that could easily get lost
in translation.
I wouldn't have sent in the patch if I had caught the build warning, and once
again, my apologies for not fixing it sooner
On Sun, Sep 13, 2020 at 07:35:22AM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> clang static analysis flags this problem
> sdio.c:3265:13: warning: Branch condition evaluates to
> a garbage value
> } else if (pending) {
>^~~
>
> brcmf_sdio_dcmd_resp_wait()
Hello Bjorn,
Sincere apologies! I forgot to include the "PCI" prefix in the subject.
Would you like me to send the patch again?
Krzysztof
All the flags defined in the enum pci_dev_flags are used to determine
whether a particular feature of an underlying PCI device should be used
or not - features are also often disabled via a device-specific quirk.
These flags are tightly coupled with a PCI device and primarily used in
simple binary
Convert cpu_to_le16(le16_to_cpu(E1) + E2) to use le16_add_cpu().
Signed-off-by: Liu Shixin
---
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
b/drivers/net/wireless/mediatek/
Convert cpu_to_le32(le32_to_cpu(E1) + E2) to use le32_add_cpu().
Signed-off-by: Liu Shixin
---
drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c
b/drivers/net/can/usb/peak_usb/pcan_usb_pro.
On Sun, Sep 13, 2020 at 05:10:01PM -0700, Moritz Fischer wrote:
> Replace pci_enable_device() with its devres counterpart
> pcim_enable_device().
>
> Signed-off-by: Moritz Fischer
> ---
> drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>
On Sat, Sep 12, 2020 at 12:11:20AM +0100, Edward Cree wrote:
> On 11/09/2020 23:26, Jakub Kicinski wrote:
> > "Toolchain" sounds a little grand in this context, the script that
> > parses kdoc does basic regexps to convert the standard kernel macros:
> > ...
> > IDK if we can expect it to understan
- Original Message -
> Fix the warning: [-Werror=-Wframe-larger-than=]
>
> drivers/vhost/vhost.c: In function log_used:
> drivers/vhost/vhost.c:1906:1:
> warning: the frame size of 1040 bytes is larger than 1024 bytes
>
> Signed-off-by: Li Wang
> ---
> drivers/vhost/vhost.c | 14
On Fri, Sep 11, 2020 at 09:19:14PM +0300, Vadym Kochan wrote:
> Hi,
>
> I'd like to discuss a concept of introduction additional entity into SFP
> subsystem called SFP controller. But lets start with the issue.
>
> Issue
> =
>
> There are boards with SFP ports whose GPIO pins are not connect
On Tue, Sep 8, 2020 at 8:33 PM Chris Chiu wrote:
>
> Hi Sean, Ryder,
> We have an ASUS laptop X532EQ with the wifi module AZWAVE-CB434NF
> which fails to bring up the wifi interface on kernel 5.9.0-rc1. The
> dmesg shows the firmware load error.
>
> [ 25.630850] mt7615e :2d:00.0: Message
On 2020/9/11 4:19, Cong Wang wrote:
> On Thu, Sep 3, 2020 at 8:21 PM Kehuan Feng wrote:
>> I also tried Cong's patch (shown below on my tree) and it could avoid
>> the issue (stressing for 30 minutus for three times and not jitter
>> observed).
>
> Thanks for verifying it!
>
>>
>> --- ./include/
> DSA used to override the "ethtool -S" callback of the host port, and
> append its own CPU port counters to that.
That was always a hack. It was bound to break sooner or later.
Ido planned to add statistics to devlink. I hope we can make use of
that to replace the CPU port statistics, and also a
> static int pause_prepare_data(const struct ethnl_req_info *req_base,
> @@ -34,10 +36,17 @@ static int pause_prepare_data(const struct ethnl_req_info
> *req_base,
>
> if (!dev->ethtool_ops->get_pauseparam)
> return -EOPNOTSUPP;
> +
> ret = ethnl_ops_begin(dev);
>
On 9/12/2020 7:41 AM, Oded Gabbay wrote:
From: Omer Shpigelman
The driver supports ethtool callbacks and provides statistics using the
device's profiling infrastructure (coresight).
Is there any relationship near or far with ARM's CoreSight:
https://developer.arm.com/ip-products/system-ip
> +static int gaudi_nic_get_module_eeprom(struct net_device *netdev,
> + struct ethtool_eeprom *ee, u8 *data)
> +{
> + struct gaudi_nic_device **ptr = netdev_priv(netdev);
> + struct gaudi_nic_device *gaudi_nic = *ptr;
> + struct hl_device *hdev = gau
> +static struct gaudi_nic_ethtool_stats gaudi_nic_mac_stats_rx[] = {
> + {"Rx MAC counters", 0},
> + {" etherStatsOctets", 0x0},
> + {" OctetsReceivedOK", 0x4},
> + {" aAlignmentErrors", 0x8},
> + {" aPAUSEMACCtrlFramesReceived", 0xC},
> + {" aFrameTooLongErrors", 0x10
Replace devm_alloc_etherdev() with its devres version.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
b/drivers/net/ethernet/dec/tulip/de2104x.c
index
Replace an instance of kmemdup() with the devres counted version
instead.
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/dec/tulip/de2104x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
b/drivers/net/ethernet/dec/tulip
Replace pci_enable_device() with its devres counterpart
pcim_enable_device().
Signed-off-by: Moritz Fischer
---
drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c
b/drivers/net/ethernet/dec
This series is the first bunch of minor cleanups for the de2104x driver
to make it look and behave more like a modern driver.
These changes replace some of the non-devres versions with devres
versions of functions to simplify the error paths.
Next up after this will be the ioremap part.
Moritz F
From: Christophe JAILLET
Date: Sun, 13 Sep 2020 14:55:46 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
From: Christophe JAILLET
Date: Sun, 13 Sep 2020 14:38:34 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
From: Christophe JAILLET
Date: Sun, 13 Sep 2020 14:44:53 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
From: Christophe JAILLET
Date: Sun, 13 Sep 2020 14:30:42 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
From: Anant Thazhemadam
Date: Sun, 13 Sep 2020 16:33:13 +0530
> diff --git a/net/socket.c b/net/socket.c
> index 0c0144604f81..1e6f9b54982c 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -2398,6 +2398,7 @@ static int ___sys_sendmsg(struct socket *sock, struct
> user_msghdr __user *msg,
>
From: Tariq Toukan
Date: Sun, 13 Sep 2020 13:12:05 +0300
>
>
> On 9/13/2020 4:22 AM, David Miller wrote:
>> From: Luo Jiaxing
>> Date: Sat, 12 Sep 2020 16:08:15 +0800
>>
>>> We found a set but not used variable 'ring_cons' in mlx4_en_xmit(), it
>>> will
>>> cause a warning when build the kern
From: Shay Agroskin
Date: Sun, 13 Sep 2020 11:16:34 +0300
> ENA logs are adjusted to display the full ENA representation to
> distinct each ENA device in case of multiple interfaces.
> Using dev_err/warn/info function family for logging provides uniform
> printing with clear distinction of the dr
Use the dim library to manage dynamic interrupt
moderation in ionic.
Signed-off-by: Shannon Nelson
---
.../ethernet/pensando/ionic/ionic_debugfs.c | 2 +
.../net/ethernet/pensando/ionic/ionic_dev.h | 1 +
.../ethernet/pensando/ionic/ionic_ethtool.c | 71 ---
.../net/ether
From: Anant Thazhemadam
Date: Sun, 13 Sep 2020 11:50:52 +0530
> My apologies. I think I ended up overlooking the build warning.
You "think" you overlooked the build warning? You don't actually
know?
If you aren't willing to even make sure the build is clean after your
changes, why should we be
From: Russell King
Date: Sun, 13 Sep 2020 08:05:52 +0100
> Richard Cochran points out that SKBTX_IN_PROGRESS should be set when
> the skbuff is queued for timestamping. Add this.
>
> Signed-off-by: Russell King
Applied.
From: Christophe JAILLET
Date: Sun, 13 Sep 2020 09:01:07 +0200
> 'w89c840_open()' is incorrectly reported in a debug message. Use __func__
> instead.
>
> While at it, fix some style issue in the same function.
>
> Signed-off-by: Christophe JAILLET
Applied.
From: Christophe JAILLET
Date: Sun, 13 Sep 2020 08:57:11 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
From: Christophe JAILLET
Date: Sun, 13 Sep 2020 08:14:17 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
From: Christophe JAILLET
Date: Sun, 13 Sep 2020 07:46:28 +0200
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
> W
Hi,
just after updating one of our clusters to 5.4.55 and reconnecting to another
stack
of switches, the box panicked.. here's what i digged out from pstore:
<6>[ 1056.250637] bond0: (slave eth3): Enslaving as a backup interface with an
up link
<4>[ 1057.559331] [ cut here ]
Clean and rebuild the debugfs info for the queues being swapped.
Fixes: a34e25ab977c ("ionic: change the descriptor ring length without full
reset")
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 15 +++
1 file changed, 15 insertions(+)
diff --g
syzbot has bisected this issue to:
commit 58956317c8de52009d1a38a721474c24aef74fe7
Author: David Ahern
Date: Fri Dec 7 20:24:57 2018 +
neighbor: Improve garbage collection
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=146ba85390
start commit: 746f534a tools/libbpf
From: David Ahern
flowi4_multipath_hash was added by the commit referenced below for
tunnels. Unfortunately, the patch did not initialize the new field
for several fast path lookups that do not initialize the entire flow
struct to 0. Fix those locations. Currently, flowi4_multipath_hash
is random
On 8/21/20 6:30 PM, Anchal Agarwal wrote:
> Save/restore xen_sched_clock_offset in syscore suspend/resume during PM
> hibernation. Commit '867cefb4cb1012: ("xen: Fix x86 sched_clock() interface
> for xen")' fixes xen guest time handling during migration. A similar issue
> is seen during PM hibern
On 8/21/20 6:27 PM, Anchal Agarwal wrote:
> From: Munehisa Kamata
>
> Add Xen PVHVM specific system core callbacks for PM
> hibernation support. The callbacks suspend and resume
> Xen primitives like shared_info, pvclock and grant table.
> These syscore_ops are specifically for domU hibernation.
On 8/21/20 6:25 PM, Anchal Agarwal wrote:
> From: Munehisa Kamata
>
> Guest hibernation is different from xen suspend/resume/live migration.
> Xen save/restore does not use pm_ops as is needed by guest hibernation.
> Hibernation in guest follows ACPI path and is guest inititated , the
> hibern
On Sat, Sep 12, 2020 at 07:37:23PM +, Michael Kelley wrote:
> From: Boqun Feng Sent: Thursday, September 10, 2020
> 7:35 AM
>
> >
> > When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at
> > least 2 * PAGE_SIZE: one page for the header and at least one page of
> > the dat
swap_u32() duplicate native swap(), so replace swap_u32() with swap().
Signed-off-by: Ivan Safonov
---
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
b/drivers/net/w
On Sun, Sep 13, 2020 at 02:44:53PM +0200, Christophe JAILLET wrote:
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
>
On 8/21/20 6:26 PM, Anchal Agarwal wrote:
> From: Munehisa Kamata
>
> Since commit b3e96c0c7562 ("xen: use freeze/restore/thaw PM events for
> suspend/resume/chkpt"), xenbus uses PMSG_FREEZE, PMSG_THAW and
> PMSG_RESTORE events for Xen suspend. However, they're actually assigned
> to xenbus_dev
From: Petr Machata
The SBIB register configures the size of an internal buffer that the
Spectrum ASICs use when mirroring traffic on egress. This size should be
taken into account when validating that the port headroom buffers are not
larger than the chip can handle. Up until now this was not don
From: Petr Machata
The maximum port speed depends on link modes supported by the port, and for
Ethernet ports is constant. The maximum speed will be handy when setting
SBIB, the internal buffer used for traffic mirroring. Therefore, keep it in
struct mlxsw_sp_port for easy access.
Signed-off-by:
From: Petr Machata
The maximum port MTU depends on port type. On Spectrum, mlxsw configures
all ports as Ethernet ports, and the maximum MTU therefore never changes.
Besides checking MTU configuration, maximum MTU will also be handy when
setting SBIB, the internal buffer used for traffic mirrorin
From: Ido Schimmel
Petr says:
Internal buffer is a part of port headroom used for packets that are
mirrored due to triggers that the Spectrum ASIC considers "egress". Besides
ACL mirroring on port egresss this includes also packets mirrored due to
ECN marking.
This patchset changes the way the
From: Petr Machata
The SBIB register configures the size of an internal buffer that the
Spectrum ASICs use when mirroring traffic on egress. This size should be
taken into account when validating that the port headroom buffers are not
larger than the chip can handle. Up until now this was not don
From: Petr Machata
In order to allow reusing the logic, extract from
mlxsw_sp_port_get_link_ksettings() the code to obtain Ethernet protocol
attributes, mlxsw_sp_port_ptys_query().
Signed-off-by: Petr Machata
Signed-off-by: Ido Schimmel
---
.../mellanox/mlxsw/spectrum_ethtool.c | 38 +
On 8/21/20 6:25 PM, Anchal Agarwal wrote:
> From: Munehisa Kamata
>
> Guest hibernation is different from xen suspend/resume/live migration.
> Xen save/restore does not use pm_ops as is needed by guest hibernation.
> Hibernation in guest follows ACPI path and is guest inititated , the
> hibe
From: Tom Rix
clang static analysis flags this problem
sdio.c:3265:13: warning: Branch condition evaluates to
a garbage value
} else if (pending) {
^~~
brcmf_sdio_dcmd_resp_wait() only sets pending to true.
So pending needs to be initialized to false.
Fixes: 5b4
On Sun, Sep 13, 2020 at 08:05:52AM +0100, Russell King wrote:
> Richard Cochran points out that SKBTX_IN_PROGRESS should be set when
> the skbuff is queued for timestamping. Add this.
>
> Signed-off-by: Russell King
Acked-by: Richard Cochran
On 9/12/20 9:25 PM, Bjorn Andersson wrote:
> On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote:
>
>> We take a single IPA clock reference to keep the clock running until
>> we get a system suspend operation, and maintain a flag indicating
>> whether that reference has been taken. When a suspend requ
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'tulip_init_one()' GFP_KERNEL can be used
because it
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'de_alloc_rings()' GFP_KERNEL can be used
because it
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'dmfe_init_one()' GFP_KERNEL can be used
because it
The wrappers in include/linux/pci-dma-compat.h should go away.
The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.
When memory is allocated in 'uli526x_init_one()' GFP_KERNEL can be used
because
This patch is to do some mask when setting vxlan option in net_sched
and lwtunnel, so that only available bits can be set on vxlan md gbp.
This would help when users don't know exactly vxlan's gbp bits, and
avoid some mismatch because of some unavailable bits set by users.
Xin Long (2):
net: sc
As we can see from vxlan_build/parse_gbp_hdr(), when processing metadata
on vxlan rx/tx path, only dont_learn/policy_applied/policy_id fields can
be set to or parse from the packet for vxlan gbp option.
So we'd better do the mask when set it in act_tunnel_key and cls_flower.
Otherwise, when users
As we can see from vxlan_build/parse_gbp_hdr(), when processing metadata
on vxlan rx/tx path, only dont_learn/policy_applied/policy_id fields can
be set to or parse from the packet for vxlan gbp option.
So do the mask when set it in lwtunnel, as it does in act_tunnel_key and
cls_flower.
Signed-of
In fl_set_erspan_opt(), all bits of erspan md was set 1, as this
function is also used to set opt MASK. However, when setting for
md->u.index for opt VALUE, the rest bits of the union md->u will
be left 1. It would cause to fail the match of the whole md when
version is 1 and only index is set.
Th
In tipc_buf_append() it may change skb's frag_list, and it causes
problems when this skb is cloned. skb_unclone() doesn't really
make this skb's flag_list available to change.
Shuang Li has reported an use-after-free issue because of this
when creating quite a few macvlan dev over the same dev, wh
The crash report indicated that there was a local variable;
iovstack.i@__sys_sendmmsg created at:
___sys_sendmsg net/socket.c:2388 [inline]
__sys_sendmmsg+0x6db/0xc90 net/socket.c:2480
that was left uninitialized.
Initializing this stack to 0s prevents this bug from happening.
Since the me
Shay Agroskin writes:
The placement policy is printed in the process of queue creation
in
ena_up(). No need to print it in ena_probe().
Signed-off-by: Arthur Kiyanovski
Signed-off-by: Shay Agroskin
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 ++
1 file changed, 2 insert
Le 13/09/2020 à 08:55, Leon Romanovsky a écrit :
On Sun, Sep 13, 2020 at 08:14:17AM +0200, Christophe JAILLET wrote:
> [...]
@@ -504,9 +510,8 @@ static int alloc_list(struct net_device *dev)
sizeof(struct netdev_desc));
/* Rubicon
On 9/13/2020 4:22 AM, David Miller wrote:
From: Luo Jiaxing
Date: Sat, 12 Sep 2020 16:08:15 +0800
We found a set but not used variable 'ring_cons' in mlx4_en_xmit(), it will
cause a warning when build the kernel. And after checking the commit record
of this function, we found that it was in
On Fri, Sep 11, 2020 at 03:13:43PM -0700, Jakub Kicinski wrote:
> On Fri, 11 Sep 2020 14:12:50 -0700 Alexander Duyck wrote:
> > On Fri, Sep 11, 2020 at 12:53 PM Jakub Kicinski wrote:
> > > @@ -3546,6 +3556,7 @@ static const struct ethtool_ops ixgbe_ethtool_ops =
> > > {
> > > .set_eeprom
On Sun, Sep 13, 2020 at 1:11 AM Willem de Bruijn
wrote:
>
> I am concerned about adding a WARN_ON_ONCE that we already expect to
> fire on some platforms.
>
> Probably better to add the documentation without the warning.
>
> I know I suggested the check before, sorry for the churn, but I hadn't
>
The PCI vendor IDs in the documentation inaccurately describe the ENA
devices. For example, the 1d0f:ec20 can have LLQ support. The driver
loads in LLQ mode by default, and a message is printed to the kernel
ring if the mode isn't supported by the device, so the device table
isn't needed.
Also, LL
After running Sparse checker on the driver using
make C=1 M=drivers/net/ethernet/amazon/ena
the only error that is thrown is:
sparse: sparse: Using plain integer as NULL pointer
about the line
struct ena_calc_queue_size_ctx calc_queue_ctx = { 0 };
This patch fixes this warning, thus m
The formal name changes to "ENA_ADMIN_RSS_INDIRECTION_TABLE_CONFIG".
Indirection is the ability to reference "something" using "something else"
instead of the value itself.
Indirection table, as the name implies, is the ability to reference
CPU/Queue value using hash-to-CPU table instead of CPU/Que
1 - 100 of 115 matches
Mail list logo
