Re: [PATCH] net/packet: fix overflow in tpacket_rcv

2020-09-04 Thread Salvatore Bonaccorso
Hi, On Fri, Sep 04, 2020 at 04:36:48PM +0200, gre...@linuxfoundation.org wrote: > On Fri, Sep 04, 2020 at 02:22:46PM +, Nuernberger, Stefan wrote: > > On Fri, 2020-09-04 at 16:16 +0200, Greg Kroah-Hartman wrote: > > > On Fri, Sep 04, 2020 at 03:30:52PM +0200, Stefan Nuernberger wrote: > > > >

[PATCH] tipc: fix shutdown() of connection oriented socket

2020-09-04 Thread Tetsuo Handa
I confirmed that the problem fixed by commit 2a63866c8b51a3f7 ("tipc: fix shutdown() of connectionless socket") also applies to stream socket. -- #include #include #include int main(int argc, char *argv[]) { int fds[2] = { -1, -1 }; socketpair(PF_TIPC, SOCK_STREAM /* or

[PATCH net-next 1/2] udp: add a GSO type for UDPv6

2020-09-04 Thread Huazhong Tan
In some cases, for UDP GSO, UDPv4 and UDPv6 need to be handled separately, for example, checksum offload, so add new GSO type SKB_GSO_UDPV6_L4 for UDPv6, and the old SKB_GSO_UDP_L4 stands for UDPv4. Signed-off-by: Huazhong Tan --- drivers/net/bonding/bond_main.c | 4 +++-

[PATCH net-next 2/2] net: disable UDP GSO features when CSUM is disable

2020-09-04 Thread Huazhong Tan
When CSUM is not available, UDP GSO should be disable as well. Signed-off-by: Huazhong Tan --- net/core/dev.c | 12 1 file changed, 12 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index d42c9ea..0c78306 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -9402,6 +9402

[PATCH net-next 0/2] net: two updates related to UDP GSO

2020-09-04 Thread Huazhong Tan
There are two updates relates to UDP GSO. #1 adds a new GSO type for UDPv6 #2 adds check for UDP GSO when csum is disable in netdev_fix_features(). Changes since RFC V2: - modifies the timing of setting UDP GSO type when doing UDP GRO in #1. Changes since RFC V1: - updates NETIF_F_GSO_LAST sugges

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-04 Thread Lukas Wunner
On Fri, Sep 04, 2020 at 11:14:37PM +0200, Daniel Borkmann wrote: > On 9/4/20 6:21 PM, Lukas Wunner wrote: > > nft and tc are orthogonal, i.e. filtering/mangling versus queueing. > > However tc has gained the ability to filter packets as well, hence > > there's some overlap in functionality. Natura

Re: [Patch net] act_ife: load meta modules before tcf_idr_check_alloc()

2020-09-04 Thread Jakub Kicinski
On Thu, 3 Sep 2020 19:10:11 -0700 Cong Wang wrote: > The following deadlock scenario is triggered by syzbot: > > Thread A: Thread B: > tcf_idr_check_alloc() > ... > populate_metalist() > rtnl_unlock() > rtnl_lock() >

Re: [PATCH] atm: eni: fix the missed pci_disable_device() for eni_init_one()

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 10:51:03 +0800 Jing Xiangfeng wrote: > eni_init_one() misses to call pci_disable_device() in an error path. > Jump to err_disable to fix it. > > Signed-off-by: Jing Xiangfeng Please make sure you add appropriate fixes tags, here: Fixes: ede58ef28e10 ("atm: remove deprecated u

[net-next] tipc: fix a deadlock when flushing scheduled work

2020-09-04 Thread Hoang Huu Le
In the commit fdeba99b1e58 ("tipc: fix use-after-free in tipc_bcast_get_mode"), we're trying to make sure the tipc_net_finalize_work work item finished if it enqueued. But calling flush_scheduled_work() is not just affecting above work item but either any scheduled work. This has turned out to be o

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 18:57:27 -0700 Xie He wrote: > On Fri, Sep 4, 2020 at 6:28 PM Xie He wrote: > > > > The HDLC device is not actually prepending any header when it is used > > with this driver. When the PVC device has prepended its header and > > handed over the skb to the HDLC device, the HDLC d

linux-next: manual merge of the akpm-current tree with the net-next tree

2020-09-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the akpm-current tree got a conflict in: mm/filemap.c between commit: 76cd61739fd1 ("mm/error_inject: Fix allow_error_inject function signatures.") from the net-next tree and commit: 2cb138387ead ("mm/filemap: fix storing to a THP shadow entry") from

[PATCH net] ibmvnic: add missing parenthesis in do_reset()

2020-09-04 Thread Jakub Kicinski
Indentation and logic clearly show that this code is missing parenthesis. Fixes: 9f1345737790 ("ibmvnic fix NULL tx_pools and rx_tools issue at do_reset") Signed-off-by: Jakub Kicinski --- CC: m...@linux.vnet.ibm.com CC: d...@linux.ibm.com CC: tlfal...@linux.ibm.com CC: jal...@linux.ibm.com I ra

RE: [Intel-wired-lan] [PATCH net-next v2 3/3] i40e, xsk: move buffer allocation out of the Rx processing loop

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Björn Töpel > Sent: Tuesday, August 25, 2020 4:36 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; b...@vger.kernel.org; Topel, Bjorn > ; Karlsson, Magnus ; > k...@kernel.org > Subject: [Intel-wired-lan] [PATCH net-next v2 3/3] i40e, xs

RE: [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: use 16B HW descriptors instead of 32B

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Björn Töpel > Sent: Tuesday, August 25, 2020 4:36 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; b...@vger.kernel.org; Topel, Bjorn > ; Karlsson, Magnus ; > k...@kernel.org > Subject: [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: us

Re: [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV

2020-09-04 Thread wanghai (M)
在 2020/9/4 21:26, Willem de Bruijn 写道: On Fri, Sep 4, 2020 at 3:09 PM Wang Hai wrote: BPDU_TYPE_TCN is never used after it was introduced. So better to remove it. This comment does not cover the patch contents. Otherwise the patch looks good to me. Thanks for your review, I will revise this

RE: [Intel-wired-lan] [PATCH net-next v2 1/3] i40e, xsk: remove HW descriptor prefetch in AF_XDP path

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Björn Töpel > Sent: Tuesday, August 25, 2020 4:36 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; b...@vger.kernel.org; Topel, Bjorn > ; Karlsson, Magnus ; > k...@kernel.org > Subject: [Intel-wired-lan] [PATCH net-next v2 1/3] i40e, xs

RE: [RFC v2 11/11] scsi: storvsc: Support PAGE_SIZE larger than 4K

2020-09-04 Thread Michael Kelley
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM > > Hyper-V always use 4k page size (HV_HYP_PAGE_SIZE), so when > communicating with Hyper-V, a guest should always use HV_HYP_PAGE_SIZE > as the unit for page related data. For storvsc, the data is > vmbus_packet_mpb_array. And since in s

[PATCH net] hv_netvsc: Fix hibernation for mlx5 VF driver

2020-09-04 Thread Dexuan Cui
mlx5_suspend()/resume() keep the network interface, so during hibernation netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence netvsc_resume() should call netvsc_vf_changed() to switch the data path back to the VF after hibernation. Similarly, netvsc_suspend() should not call n

RE: [PATCH] ice: Fix memleak in ice_set_ringparam

2020-09-04 Thread Brown, Aaron F
> From: Dinghao Liu > Sent: Wednesday, August 26, 2020 7:34 PM > To: dinghao@zju.edu.cn; k...@umn.edu > Cc: Kirsher, Jeffrey T ; David S. Miller > ; Jakub Kicinski ; Alexei > Starovoitov ; Daniel Borkmann ; > Jesper Dangaard Brouer ; John Fastabend > ; intel-wired-...@lists.osuosl.org; > netde

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-04 Thread Xie He
On Fri, Sep 4, 2020 at 6:28 PM Xie He wrote: > > The HDLC device is not actually prepending any header when it is used > with this driver. When the PVC device has prepended its header and > handed over the skb to the HDLC device, the HDLC device just hands it > over to the hardware driver for tran

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-04 Thread Xie He
Thank you for your email, Jakub! On Fri, Sep 4, 2020 at 3:14 PM Jakub Kicinski wrote: > > Since this is a tunnel protocol on top of HDLC interfaces, and > hdlc_setup_dev() sets dev->hard_header_len = 16; should we actually > set the needed_headroom to 10 + 16 = 26? I'm not clear on where/if > hdl

RE: [RFC v2 07/11] hv_netvsc: Use HV_HYP_PAGE_SIZE for Hyper-V communication

2020-09-04 Thread Michael Kelley
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM > > When communicating with Hyper-V, HV_HYP_PAGE_SIZE should be used since > that's the page size used by Hyper-V and Hyper-V expects all > page-related data using the unit of HY_HYP_PAGE_SIZE, for example, the > "pfn" in hv_page_buffer is

RE: [RFC v2 03/11] Drivers: hv: vmbus: Introduce types of GPADL

2020-09-04 Thread Michael Kelley
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM > > This patch introduces two types of GPADL: HV_GPADL_{BUFFER, RING}. The > types of GPADL are purely the concept in the guest, IOW the hypervisor > treat them as the same. > > The reason of introducing the types of GPADL is to support g

Re: [PATCH net-next 9/9] net: ethernet: ti: ale: add support for multi port k3 cpsw versions

2020-09-04 Thread Jakub Kicinski
On Sat, 5 Sep 2020 02:09:24 +0300 Grygorii Strashko wrote: > The TI J721E (CPSW9g) ALE version is similar, in general, to Sitara AM3/4/5 > CPSW ALE, but has more extended functions and different ALE VLAN entry > format. > > This patch adds support for for multi port TI J721E (CPSW9g) ALE variant.

Re: [PATCH bpf-next 1/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Alexei Starovoitov
On Fri, Sep 4, 2020 at 5:08 PM Andrii Nakryiko wrote: > > On Fri, Sep 4, 2020 at 4:20 PM Yonghong Song wrote: > > > > > > > > On 9/4/20 1:30 PM, Andrii Nakryiko wrote: > > > On Fri, Sep 4, 2020 at 12:49 PM Yonghong Song wrote: > > >> > > >> Commit 41c48f3a98231 ("bpf: Support access > > >> to bp

Re: [PATCH net-next 8/9] net: ethernet: ti: ale: switch to use tables for vlan entry description

2020-09-04 Thread Jakub Kicinski
On Sat, 5 Sep 2020 02:09:23 +0300 Grygorii Strashko wrote: > The ALE VLAN entries are too much differ between different TI CPSW ALE > versions. So, handling them using flags, defines and get/set functions > became over-complicated. > > This patch introduces tables to describe the ALE VLAN entries

Re: [PATCH bpf-next 1/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 4:20 PM Yonghong Song wrote: > > > > On 9/4/20 1:30 PM, Andrii Nakryiko wrote: > > On Fri, Sep 4, 2020 at 12:49 PM Yonghong Song wrote: > >> > >> Commit 41c48f3a98231 ("bpf: Support access > >> to bpf map fields") added support to access map fields > >> with CORE support. F

Re: PROBLEM: QinQ not working with qlcnic drivers

2020-09-04 Thread Jakub Kicinski
CC: qlcnic maintainers On Fri, 4 Sep 2020 11:25:27 +0200 MyNet SysAdmin wrote: > *[1.] One line summary of the problem:* > > QinQ not working with qlcnicdrivers > > *[2.] Full description of the problem/report:* > > QinQ networking operations don’t happenproperly: a QinQ message can be > recei

RE: [RFC v2 02/11] Drivers: hv: vmbus: Move __vmbus_open()

2020-09-04 Thread Michael Kelley
From: Boqun Feng Sent: Tuesday, September 1, 2020 8:01 PM > > Pure function movement, no functional changes. The move is made, because > in a later change, __vmbus_open() will rely on some static functions > afterwards, so we sperate the move and the modification of s/sperate/separate/ > __vmbu

Re: [PATCH bpf-next 0/6] xsk: exit NAPI loop when AF_XDP Rx ring is full

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 16:32:56 +0200 Björn Töpel wrote: > On 2020-09-04 16:27, Jesper Dangaard Brouer wrote: > > On Fri, 4 Sep 2020 15:53:25 +0200 > > Björn Töpel wrote: > > > >> On my machine the "one core scenario Rx drop" performance went from > >> ~65Kpps to 21Mpps. In other words, from "not

RE: [PATCH][v3] i40e: optimise prefetch page refcount

2020-09-04 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org > On Behalf Of Li RongQing > Sent: Tuesday, August 18, 2020 12:08 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [PATCH][v3] i40e: optimise prefetch page refcount > > refcount of rx_buffer page will be added here originally, so pr

Re: [PATCH bpf-next] bpf: don't check against device MTU in __bpf_skb_max_len

2020-09-04 Thread Jakub Kicinski
On Fri, 04 Sep 2020 11:30:28 +0200 Jesper Dangaard Brouer wrote: > @@ -3211,8 +3211,7 @@ static int bpf_skb_net_shrink(struct sk_buff *skb, u32 > off, u32 len_diff, > > static u32 __bpf_skb_max_len(const struct sk_buff *skb) > { > - return skb->dev ? skb->dev->mtu + skb->dev->hard_header_l

RE: [Intel-wired-lan] [PATCH][v2] i40e: optimise prefetch page refcount

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of Li > RongQing > Sent: Friday, July 31, 2020 3:38 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; > k...@kernel.org; Bowers, AndrewX ; > Nguyen, Anthony L > Subject: [Intel-wired-lan] [PATCH][v2] i40e: optimise prefetch page refcount > > ref

Re: [PATCH bpf-next 1/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Yonghong Song
On 9/4/20 1:30 PM, Andrii Nakryiko wrote: On Fri, Sep 4, 2020 at 12:49 PM Yonghong Song wrote: Commit 41c48f3a98231 ("bpf: Support access to bpf map fields") added support to access map fields with CORE support. For example, struct bpf_map { __u32 max_entr

Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-04 Thread Baptiste Covolato
Hi Michael, On Thu, Sep 3, 2020 at 11:29 AM Michael Chan wrote: > If tg3_reset_task() fails, the device state is left in an inconsistent > state with IFF_RUNNING still set but NAPI state not enabled. A > subsequent operation, such as ifdown or AER error can cause it to > soft lock up when it tri

Re: [PATCH bpf-next v3 3/8] libbpf: Add BPF_PROG_BIND_MAP syscall and use it on .metadata section

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 6:29 PM Alexei Starovoitov wrote: > > On Wed, Sep 02, 2020 at 07:31:33PM -0700, Andrii Nakryiko wrote: > > On Fri, Aug 28, 2020 at 12:37 PM Stanislav Fomichev wrote: > > > > > > From: YiFei Zhu > > > > > > The patch adds a simple wrapper bpf_prog_bind_map around the syscal

[PATCH net-next 9/9] net: ethernet: ti: ale: add support for multi port k3 cpsw versions

2020-09-04 Thread Grygorii Strashko
The TI J721E (CPSW9g) ALE version is similar, in general, to Sitara AM3/4/5 CPSW ALE, but has more extended functions and different ALE VLAN entry format. This patch adds support for for multi port TI J721E (CPSW9g) ALE variant. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_

[PATCH net-next 8/9] net: ethernet: ti: ale: switch to use tables for vlan entry description

2020-09-04 Thread Grygorii Strashko
The ALE VLAN entries are too much differ between different TI CPSW ALE versions. So, handling them using flags, defines and get/set functions became over-complicated. This patch introduces tables to describe the ALE VLAN entries fields, which are different between TI CPSW ALE versions, and new get

[PATCH net-next 6/9] net: ethernet: ti: ale: make usage of ale dev_id mandatory

2020-09-04 Thread Grygorii Strashko
Hence all existing driver updated to use ALE dev_id the usage of ale dev_id can be made mandatory and cpsw_ale_create() can be updated to use "features" property from ALE static configuration. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ale.c | 28 +-

[PATCH net-next 7/9] net: ethernet: ti: am65-cpsw: enable hw auto ageing

2020-09-04 Thread Grygorii Strashko
The AM65x ALE supports HW auto-ageing which can be enabled by programming ageing interval in ALE_AGING_TIMER register. For this CPSW fck_clk frequency has to be know by ALE. This patch extends cpsw_ale_params with bus_freq field and enables ALE HW auto ageing for AM65x CPSW2G ALE version. Signed-

[PATCH net-next 4/9] net: netcp: ethss: use dev_id for ale configuration

2020-09-04 Thread Grygorii Strashko
The previous patch has introduced possibility to select CPSW ALE by using ALE dev_id identifier. Switch TI Keystone 2 NETCP driver to use dev_id and perform clean up by removing "ale_entries" configuration code. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/netcp_ethss.c | 18

[PATCH net-next 5/9] net: ethernet: ti: am65-cpsw: use dev_id for ale configuration

2020-09-04 Thread Grygorii Strashko
The previous patch has introduced possibility to select CPSW ALE by using ALE dev_id identifier. Switch TI TI AM65x/J721E CPSW NUSS driver to use dev_id. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --

[PATCH net-next 3/9] net: ethernet: ti: cpsw: use dev_id for ale configuration

2020-09-04 Thread Grygorii Strashko
The previous patch has introduced possibility to select CPSW ALE by using ALE dev_id identifier. Switch TI cpsw driver to use dev_id="cpsw" and perform clean up by removing "ale_entries" configuration code. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 6 -- driv

[PATCH net-next 1/9] net: ethernet: ti: ale: add cpsw_ale_get_num_entries api

2020-09-04 Thread Grygorii Strashko
Add cpsw_ale_get_num_entries() API to return number of ALE table entries and update existing drivers to use it. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 10 ++ drivers/net/ethernet/ti/cpsw_ale.c | 5 + drivers/net/ethernet/ti/cpsw_a

[PATCH net-next 2/9] net: ethernet: ti: ale: add static configuration

2020-09-04 Thread Grygorii Strashko
As existing, as newly introduced CPSW ALE versions have differences in supported features and ALE table formats. Especially it's actual for the recent AM65x/J721E/J7200 and future AM64x SoCs, which supports features like: auto-aging, classifiers, Link aggregation, additional HW filtering, etc. The

[PATCH net-next 0/9] net: ethernet: ti: ale: add static configuration

2020-09-04 Thread Grygorii Strashko
Hi All, As existing, as newly introduced CPSW ALE versions have differences in supported features and ALE table formats. Especially it's actual for the recent AM65x/J721E/J7200 and future AM64x SoCs, which supports more features like: auto-aging, classifiers, Link aggregation, additional HW filte

Re: [PATCH v2 net-next 0/2] ionic: add devlink dev flash support

2020-09-04 Thread Shannon Nelson
On 9/4/20 3:47 PM, Jakub Kicinski wrote: On Fri, 4 Sep 2020 11:20:11 -0700 Shannon Nelson wrote: It's probably related to this discussion: https://lore.kernel.org/linux-sparse/ecdd10cb-0022-8f8a-ec36-9d51b3ae8...@pensando.io/ I thought we'd worked out our struct alignment issues, but I'll see i

Re: [PATCH v2 net-next 0/2] ionic: add devlink dev flash support

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 11:20:11 -0700 Shannon Nelson wrote: > It's probably related to this discussion: > https://lore.kernel.org/linux-sparse/ecdd10cb-0022-8f8a-ec36-9d51b3ae8...@pensando.io/ > > I thought we'd worked out our struct alignment issues, but I'll see if I > can carve out some time to ta

Re: [PATCH RFC 0/7] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 09:15:20 + Henrik Bjoernlund wrote: > Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. > > Connectivity Fault Management (CFM) comprises capabilities for > detecting, verifying, and isolating connectivity failures in > Virtual Bridged Networks. These

[PATCH v2 00/17] RDMA: Improve use of umem in DMA drivers

2020-09-04 Thread Jason Gunthorpe
Most RDMA drivers rely on a linear table of DMA addresses organized in some device specific page size. For a while now the core code has had the rdma_for_each_block() SG iterator to help break a umem into DMA blocks for use in the device lists. Improve on this by adding rdma_umem_for_each_dma_blo

[PATCH v2 16/17] RDMA/qedr: Remove fbo and zbva from the MR

2020-09-04 Thread Jason Gunthorpe
zbva is always false, so fbo is never read. A 'zero-based-virtual-address' is simply IOVA == 0, and the driver already supports this. Signed-off-by: Jason Gunthorpe --- drivers/infiniband/hw/qedr/verbs.c | 4 drivers/net/ethernet/qlogic/qed/qed_rdma.c | 12 ++-- include/li

Re: Exposing device ACL setting through devlink

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 10:31:41 +0200 Jiri Pirko wrote: > Thu, Sep 03, 2020 at 07:59:45PM CEST, tlfal...@linux.ibm.com wrote: > >Hello, I am trying to expose MAC/VLAN ACL and pvid settings for IBM > >VNIC devices to administrators through devlink (originally through > >sysfs files, but that was rejecte

Re: [PATCH bpf-next 1/2] samples: bpf: Replace bpf_program__title() with bpf_program__section_name()

2020-09-04 Thread Daniel Borkmann
On 9/4/20 8:34 AM, Daniel T. Lee wrote: From commit 521095842027 ("libbpf: Deprecate notion of BPF program "title" in favor of "section name""), the term title has been replaced with section name in libbpf. Since the bpf_program__title() has been deprecated, this commit switches this function t

Re: [PATCH net-next v2 1/2] of: Export of_remove_property() to modules

2020-09-04 Thread Rob Herring
On Fri, Sep 4, 2020 at 3:37 PM Florian Fainelli wrote: > > We will need to remove some OF properties in drivers/net/dsa/bcm_sf2.c > with a subsequent commit. Export of_remove_property() to modules so we > can keep bcm_sf2 modular and provide an empty stub for when CONFIG_OF is > disabled to mainta

Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices

2020-09-04 Thread Jakub Kicinski
On Wed, 2 Sep 2020 17:06:58 -0700 Xie He wrote: > PVC devices are virtual devices in this driver stacked on top of the > actual HDLC device. They are the devices normal users would use. > PVC devices have two types: normal PVC devices and Ethernet-emulating > PVC devices. > > When transmitting da

Re: [PATCH bpf-next 1/2] tools: bpftool: dump outer maps content

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 9:14 AM Quentin Monnet wrote: > > Although user space can lookup and dump the content of an outer map > (hash-of-maps or array-of-maps), bpftool does not allow to do so. > > It seems that the only reason for that is historical. Lookups for outer > maps was added in commit 14

Re: [PATCH bpf-next 2/2] tools: bpftool: add "inner_map" to "bpftool map create" outer maps

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 9:16 AM Quentin Monnet wrote: > > There is no support for creating maps of types array-of-map or > hash-of-map in bpftool. This is because the kernel needs an inner_map_fd > to collect metadata on the inner maps to be supported by the new map, > but bpftool does not provide

Re: [PATCH bpf-next 3/3] tools: bpftool: automate generation for "SEE ALSO" sections in man pages

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 1:58 PM Quentin Monnet wrote: > > The "SEE ALSO" sections of bpftool's manual pages refer to bpf(2), > bpf-helpers(7), then all existing bpftool man pages (save the current > one). > > This leads to nearly-identical lists being duplicated in all manual > pages. Ideally, when

RE: [PATCH][next] i40e: switch kvzalloc to allocate rx/tx_bi buffer

2020-09-04 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org > On Behalf Of Li RongQing > Sent: Friday, August 21, 2020 2:02 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [PATCH][next] i40e: switch kvzalloc to allocate rx/tx_bi buffer > > when changes the rx/tx ring to 4096, rx/tx_bi needs

Re: [PATCH bpf-next 2/3] tools: bpftool: include common options from separate file

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 1:57 PM Quentin Monnet wrote: > > Nearly all man pages for bpftool have the same common set of option > flags (--help, --version, --json, --pretty, --debug). The description is > duplicated across all the pages, which is more difficult to maintain if > the description of an

Re: [PATCH bpf-next 1/3] tools: bpftool: print optional built-in features along with version

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 1:57 PM Quentin Monnet wrote: > > Bpftool has a number of features that can be included or left aside > during compilation. This includes: > > - Support for libbfd, providing the disassembler for JIT-compiled > programs. > - Support for BPF skeletons, used for profiling pr

Re: [PATCH bpf-next 0/3] bpf: format fixes for BPF helpers and bpftool documentation

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 9:15 AM Quentin Monnet wrote: > > This series contains minor fixes (or harmonisation edits) for the > bpftool-link documentation (first patch) and BPF helpers documentation > (last two patches), so that all related man pages can build without errors. > > Quentin Monnet (3):

[PATCH net-next v2 1/2] of: Export of_remove_property() to modules

2020-09-04 Thread Florian Fainelli
We will need to remove some OF properties in drivers/net/dsa/bcm_sf2.c with a subsequent commit. Export of_remove_property() to modules so we can keep bcm_sf2 modular and provide an empty stub for when CONFIG_OF is disabled to maintain the ability to compile test. Signed-off-by: Florian Fainelli

[PATCH net-next v2 0/2] net: dsa: bcm_sf2: Ensure MDIO diversion is used

2020-09-04 Thread Florian Fainelli
Changes in v2: - export of_update_property() to permit building bcm_sf2 as a module - provided a better explanation of the problem being solved after explaining it to Andrew during the v1 review Florian Fainelli (2): of: Export of_remove_property() to modules net: dsa: bcm_sf2: Ensure that

[PATCH net-next v2 2/2] net: dsa: bcm_sf2: Ensure that MDIO diversion is used

2020-09-04 Thread Florian Fainelli
Registering our slave MDIO bus outside of the OF infrastructure is necessary in order to avoid creating double references of the same Device Tree nodes, however it is not sufficient to guarantee that the MDIO bus diversion is used because of_phy_connect() will still resolve to a valid PHY phandle a

Re: [PATCH v20 06/23] LSM: Use lsmblob in security_secctx_to_secid

2020-09-04 Thread Paul Moore
On Wed, Aug 26, 2020 at 11:08 AM Casey Schaufler wrote: > Change security_secctx_to_secid() to fill in a lsmblob instead > of a u32 secid. Multiple LSMs may be able to interpret the > string, and this allows for setting whichever secid is > appropriate. Change security_secmark_relabel_packet() to

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-04 Thread Daniel Borkmann
On 9/4/20 6:21 PM, Lukas Wunner wrote: On Wed, Sep 02, 2020 at 10:00:32PM -0700, John Fastabend wrote: Lukas Wunner wrote: [...] Do you have plans to address the performance degradation? Otherwise if I was building some new components its unclear why we would choose the slower option over the

[PATCH bpf-next 2/3] tools: bpftool: include common options from separate file

2020-09-04 Thread Quentin Monnet
Nearly all man pages for bpftool have the same common set of option flags (--help, --version, --json, --pretty, --debug). The description is duplicated across all the pages, which is more difficult to maintain if the description of an option changes. It may also be confusing to sort out what option

[PATCH bpf-next 1/3] tools: bpftool: print optional built-in features along with version

2020-09-04 Thread Quentin Monnet
Bpftool has a number of features that can be included or left aside during compilation. This includes: - Support for libbfd, providing the disassembler for JIT-compiled programs. - Support for BPF skeletons, used for profiling programs or iterating on the PIDs of processes associated with BPF

[PATCH bpf-next 3/3] tools: bpftool: automate generation for "SEE ALSO" sections in man pages

2020-09-04 Thread Quentin Monnet
The "SEE ALSO" sections of bpftool's manual pages refer to bpf(2), bpf-helpers(7), then all existing bpftool man pages (save the current one). This leads to nearly-identical lists being duplicated in all manual pages. Ideally, when a new page is created, all lists should be updated accordingly, bu

[PATCH bpf-next 0/3] tools: bpftool: print built-in features, automate some of the documentation

2020-09-04 Thread Quentin Monnet
There are two changes for bpftool in this series. The first one is a modification to the "version" command, to have it print the status (compiled or not) of some of the optional features for bpftool. This is to help determine if a bpftool binary is able to, for example, disassemble JIT-compiled pr

Re: [EXT] Re: [net-next PATCH 0/2] Introduce mbox tracepoints for Octeontx2

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 12:29:04 + Sunil Kovvuri Goutham wrote: > > >No, there are 3 drivers registering to 3 PCI device IDs and there can > > >be many instances of the same devices. So there can be 10's of instances > > >of > > AF, PF and VFs. > > > > So you can still have per-pci device devlin

Re: [PATCH bpf-next 1/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Andrii Nakryiko
On Fri, Sep 4, 2020 at 12:49 PM Yonghong Song wrote: > > Commit 41c48f3a98231 ("bpf: Support access > to bpf map fields") added support to access map fields > with CORE support. For example, > > struct bpf_map { > __u32 max_entries; > } __attribute__((pr

RE: [PATCH] igb: read PBA number from flash

2020-09-04 Thread Brown, Aaron F
> From: Gal Hammer > Sent: Saturday, August 29, 2020 10:45 PM > To: linux-ker...@vger.kernel.org > Cc: Kirsher, Jeffrey T ; David S . Miller > ; Jakub Kicinski ; intel-wired- > l...@lists.osuosl.org; netdev@vger.kernel.org; Marcel Apfelbaum > ; Gal Hammer > Subject: [PATCH] igb: read PBA number f

Re: [PATCH bpf-next v2 6/6] bpf/selftests: Test for bpf_per_cpu_ptr() and bpf_this_cpu_ptr()

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:35 PM Hao Luo wrote: > > Test bpf_per_cpu_ptr() and bpf_this_cpu_ptr(). Test two paths in the > kernel. If the base pointer points to a struct, the returned reg is > of type PTR_TO_BTF_ID. Direct pointer dereference can be applied on > the returned variable. If the base po

Re: [PATCH bpf-next v2 5/6] bpf: Introduce bpf_this_cpu_ptr()

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:35 PM Hao Luo wrote: > > Add bpf_this_cpu_ptr() to help access percpu var on this cpu. This > helper always returns a valid pointer, therefore no need to check > returned value for NULL. Also note that all programs run with > preemption disabled, which means that the retur

[PATCH net-next] mlx4: make sure to always set the port type

2020-09-04 Thread Jakub Kicinski
Even tho mlx4_core registers the devlink ports, it's mlx4_en and mlx4_ib which set their type. In situations where one of the two is not built yet the machine has ports of given type we see the devlink warning from devlink_port_type_warn() trigger. Having ports of a type not supported by the kerne

Re: [PATCH bpf-next v2 4/6] bpf: Introduce bpf_per_cpu_ptr()

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:35 PM Hao Luo wrote: > > Add bpf_per_cpu_ptr() to help bpf programs access percpu vars. > bpf_per_cpu_ptr() has the same semantic as per_cpu_ptr() in the kernel > except that it may return NULL. This happens when the cpu parameter is > out of range. So the caller must chec

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 11:04:50 +0200 Jiri Pirko wrote: > Thu, Sep 03, 2020 at 09:47:19PM CEST, k...@kernel.org wrote: > >On Thu, 3 Sep 2020 07:57:29 +0200 Jiri Pirko wrote: > >> Wed, Sep 02, 2020 at 05:30:25PM CEST, k...@kernel.org wrote: > >> >On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote:

[PATCH bpf-next 2/2] selftests/bpf: add test for map_ptr arithmetic

2020-09-04 Thread Yonghong Song
change selftest map_ptr_kern.c which will fail without previous verifier change. Also added to verifier test for both "map_ptr += scalar" and "scalar += map_ptr" arithmetic. Signed-off-by: Yonghong Song --- .../selftests/bpf/progs/map_ptr_kern.c| 4 +-- .../testing/selftests/bpf/verifie

[PATCH bpf-next 0/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Yonghong Song
With CORE, it is possible that the compiler may produce code like r1 = 0 // relocation instruction map_ptr += r1 ... Currently verifier does not allow map_ptr arithmetic, even for adding with 0. This patch set relaxed the condition so the above code can be accepted. Patch #1 is the kernel im

[PATCH bpf-next 1/2] bpf: permit map_ptr arithmetic with opcode add and offset 0

2020-09-04 Thread Yonghong Song
Commit 41c48f3a98231 ("bpf: Support access to bpf map fields") added support to access map fields with CORE support. For example, struct bpf_map { __u32 max_entries; } __attribute__((preserve_access_index)); struct bpf_array {

Re: [PATCH bpf-next v2 3/6] bpf/selftests: ksyms_btf to test typed ksyms

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:35 PM Hao Luo wrote: > > Selftests for typed ksyms. Tests two types of ksyms: one is a struct, > the other is a plain int. This tests two paths in the kernel. Struct > ksyms will be converted into PTR_TO_BTF_ID by the verifier while int > typed ksyms will be converted into

Re: [PATCH net-next v7 5/6] net: marvell: prestera: Add Switchdev driver implementation

2020-09-04 Thread Andy Shevchenko
On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote: > > The following features are supported: > > - VLAN-aware bridge offloading > - VLAN-unaware bridge offloading > - FDB offloading (learning, ageing) > - Switchport configuration > > Currently there are some limitations like: > >

Re: [PATCH net-next v7 4/6] net: marvell: prestera: Add ethtool interface support

2020-09-04 Thread Andy Shevchenko
On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote: > > The ethtool API provides support for the configuration of the following > features: speed and duplex, auto-negotiation, MDI-x, forward error > correction, port media type. The API also provides information about the > port status, hardware and

Re: [PATCH bpf-next v2 2/6] bpf/libbpf: BTF support for typed ksyms

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:34 PM Hao Luo wrote: > > If a ksym is defined with a type, libbpf will try to find the ksym's btf > information from kernel btf. If a valid btf entry for the ksym is found, > libbpf can pass in the found btf id to the verifier, which validates the > ksym's type and value.

Re: [PATCHv2] selftests: rtnetlink: load fou module for kci_test_encap_fou()

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 17:10:39 +0800 Po-Hsu Lin wrote: > Hello David, > > do you need more information for this V2 patch? Something strange happened here, did you perhaps edit the patch manually and resend the same email? I think the Message-ID header may had been the same on v1 and v2 of your patc

Re: [PATCH net-next v7 2/6] net: marvell: prestera: Add PCI interface support

2020-09-04 Thread Andy Shevchenko
On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote: > > Add PCI interface driver for Prestera Switch ASICs family devices, which > provides: > > - Firmware loading mechanism > - Requests & events handling to/from the firmware > - Access to the firmware on the bus level > > The firmware

Re: [PATCH] net: fec: Fix PHY init after phy_reset_after_clk_enable()

2020-09-04 Thread Marek Vasut
On 9/4/20 9:02 PM, Richard Leitner wrote: > On Fri, Sep 04, 2020 at 05:26:14PM +0200, Marek Vasut wrote: >> On 9/4/20 4:02 PM, Andrew Lunn wrote: >>> On Fri, Sep 04, 2020 at 12:45:44AM +0200, Marek Vasut wrote: On 9/4/20 12:08 AM, Andrew Lunn wrote: >>> b4 am 20200903043947.3272453-1-f.fai

Re: [PATCH net-next v7 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-09-04 Thread Andy Shevchenko
On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote: > > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely > wireless SMB deployment. > > The current implementation supports only boards designed for the Marvell > S

Re: [PATCH] net: fec: Fix PHY init after phy_reset_after_clk_enable()

2020-09-04 Thread Richard Leitner
On Fri, Sep 04, 2020 at 05:26:14PM +0200, Marek Vasut wrote: > On 9/4/20 4:02 PM, Andrew Lunn wrote: > > On Fri, Sep 04, 2020 at 12:45:44AM +0200, Marek Vasut wrote: > >> On 9/4/20 12:08 AM, Andrew Lunn wrote: > > b4 am 20200903043947.3272453-1-f.faine...@gmail.com > > That might be a

Re: [PATCH bpf-next v2 1/6] bpf: Introduce pseudo_btf_id

2020-09-04 Thread Andrii Nakryiko
On Thu, Sep 3, 2020 at 3:34 PM Hao Luo wrote: > > Pseudo_btf_id is a type of ld_imm insn that associates a btf_id to a > ksym so that further dereferences on the ksym can use the BTF info > to validate accesses. Internally, when seeing a pseudo_btf_id ld insn, > the verifier reads the btf_id store

Re: [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events

2020-09-04 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 04, 2020 at 03:50:13PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Sep 04, 2020 at 03:48:03PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Sep 04, 2020 at 09:22:10AM -0700, Ian Rogers escreveu: > > > On Fri, Sep 4, 2020 at 9:03 AM Jiri Olsa wrote: > > > > On Thu, Sep 0

Re: [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events

2020-09-04 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 04, 2020 at 03:48:03PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Sep 04, 2020 at 09:22:10AM -0700, Ian Rogers escreveu: > > On Fri, Sep 4, 2020 at 9:03 AM Jiri Olsa wrote: > > > On Thu, Sep 03, 2020 at 10:41:14PM -0700, Ian Rogers wrote: > > > > On Wed, Jul 29, 2020 at 4:24 P

INFO: rcu detected stall in corrupted (4)

2020-09-04 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0f091e43 netlabel: remove unused param from audit_log_form.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14551a7190 kernel config: https://syzkaller.appspot.com/x/.config?x=61025c6fd3261bb1 das

Re: [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events

2020-09-04 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 04, 2020 at 09:22:10AM -0700, Ian Rogers escreveu: > On Fri, Sep 4, 2020 at 9:03 AM Jiri Olsa wrote: > > On Thu, Sep 03, 2020 at 10:41:14PM -0700, Ian Rogers wrote: > > > On Wed, Jul 29, 2020 at 4:24 PM Ian Rogers wrote: > > > > On Tue, Jul 28, 2020 at 9:10 AM Jiri Olsa wrote: > > >

Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-09-04 Thread Andrew Lunn
On Fri, Sep 04, 2020 at 04:36:29PM +, Sunil Kovvuri Goutham wrote: > > > > -Original Message- > > From: Herbert Xu > > Sent: Friday, September 4, 2020 7:48 PM > > To: Srujana Challa > > Cc: da...@davemloft.net; netdev@vger.kernel.org; linux- > > cry...@vger.kernel.org; Suheil Chandr

Re: [PATCH v2 net-next 0/2] ionic: add devlink dev flash support

2020-09-04 Thread Shannon Nelson
On 9/4/20 8:01 AM, Jakub Kicinski wrote: On Thu, 3 Sep 2020 17:05:32 -0700 Shannon Nelson wrote: Add support for using devlink's dev flash facility to update the firmware on an ionic device. This is a simple model of pushing the firmware file to the NIC, asking the NIC to unpack and install th

RE: [Intel-wired-lan] [PATCH v2] i40e: fix return of uninitialized aq_ret in i40e_set_vsi_promisc

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Stefan Assmann > Sent: Thursday, August 13, 2020 4:27 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; sassm...@kpanic.de; k...@kernel.org; > da...@davemloft.net > Subject: [Intel-wired-lan] [PATCH v2] i40e: fix return of uninitialized

RE: [Intel-wired-lan] [PATCH] i40e: always propagate error value in i40e_set_vsi_promisc()

2020-09-04 Thread Brown, Aaron F
> From: Intel-wired-lan On Behalf Of > Stefan Assmann > Sent: Thursday, August 20, 2020 4:53 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Loktionov, Aleksandr > ; sassm...@kpanic.de; > da...@davemloft.net > Subject: [Intel-wired-lan] [PATCH] i40e: always propagate error

  1   2   3   >