Re: pull-request: bpf 2020-08-15

2020-08-14 Thread David Miller
From: Daniel Borkmann Date: Sat, 15 Aug 2020 02:05:44 +0200 > The following pull-request contains BPF updates for your *net* tree. > > We've added 23 non-merge commits during the last 4 day(s) which contain > a total of 32 files changed, 421 insertions(+), 141 deletions(-). > > The main changes

pull-request: bpf 2020-08-15

2020-08-14 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. We've added 23 non-merge commits during the last 4 day(s) which contain a total of 32 files changed, 421 insertions(+), 141 deletions(-). The main changes are: 1) Fix sock_ops ctx access splat due to register overrid

Re: [PATCH net,stable 1/1] net: fec: correct the error path for regulator disable in probe

2020-08-14 Thread David Miller
From: fugang.d...@nxp.com Date: Thu, 13 Aug 2020 15:13:14 +0800 > From: Fugang Duan > > Correct the error path for regulator disable. > > Fixes: 9269e5560b26 ("net: fec: add phy-reset-gpios PROBE_DEFER check") > Signed-off-by: Fugang Duan Applied and queued up for -stable, thanks.

Re: [PATCH] docs: networking: bonding.rst resources section cleanup

2020-08-14 Thread David Miller
From: Nivedita Singhvi Date: Thu, 13 Aug 2020 10:40:05 +0530 > Removed obsolete resources from bonding.rst doc: >- bonding-de...@lists.sourceforge.net hasn't been used since 2008 >- admin interface is 404 >- Donald Becker's domain/content no longer online > > Signed-off-by: Nivedita

Re: [PATCH] selftests: rtnetlink: load fou module for kci_test_encap_fou()

2020-08-14 Thread David Miller
From: Po-Hsu Lin Date: Thu, 13 Aug 2020 12:44:22 +0800 > diff --git a/tools/testing/selftests/net/config > b/tools/testing/selftests/net/config > index 3b42c06b..96d2763 100644 > --- a/tools/testing/selftests/net/config > +++ b/tools/testing/selftests/net/config > @@ -31,3 +31,4 @@ CONFIG_NET_SC

Re: [net v2 0/3][pull request] Intel Wired LAN Driver Updates 2020-08-14

2020-08-14 Thread David Miller
From: Tony Nguyen Date: Fri, 14 Aug 2020 15:17:42 -0700 > This series contains updates to i40e and igc drivers. > > Vinicius fixes an issue with PTP spinlock being accessed before > initialization. > > Przemyslaw fixes an issue with trusted VFs seeing additional traffic. > > Grzegorz adds a wa

BUG: corrupted list in bt_accept_unlink

2020-08-14 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a1d21081 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11c7789190 kernel config: https://syzkaller.appspot.com/x/.config?x=9c89856ae5fc8b6 dash

Re: BUG: unable to handle kernel paging request in free_block (5)

2020-08-14 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 1378817486d6860f6a927f573491afe65287abf1 Author: Eric Dumazet Date: Thu May 21 18:29:58 2020 + tipc: block BH before using dst_cache bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1537694a90 start commit: e6986

[PATCH] bluetooth: Set ext scan response only when it exists

2020-08-14 Thread Abhishek Pandit-Subedi
Only set extended scan response only when it exists. Otherwise, clear the scan response data. Per the core spec v5.2, Vol 4, Part E, 7.8.55 If the advertising set is non-scannable and the Host uses this command other than to discard existing data, the Controller shall return the error code Invali

[net v2 1/3] igc: Fix PTP initialization

2020-08-14 Thread Tony Nguyen
From: Vinicius Costa Gomes Right now, igc_ptp_reset() is called from igc_reset(), which is called from igc_probe() before igc_ptp_init() has a chance to run. It is detected as an attempt to use an spinlock without registering its key first. See log below. To avoid this problem, simplify the init

[net v2 3/3] i40e: Fix crash during removing i40e driver

2020-08-14 Thread Tony Nguyen
From: Grzegorz Szczurek Fix the reason of crashing system by add waiting time to finish reset recovery process before starting remove driver procedure. Now VSI is releasing if VSI is not in reset recovery mode. Without this fix it was possible to start remove driver if other processing command ne

[net v2 0/3][pull request] Intel Wired LAN Driver Updates 2020-08-14

2020-08-14 Thread Tony Nguyen
This series contains updates to i40e and igc drivers. Vinicius fixes an issue with PTP spinlock being accessed before initialization. Przemyslaw fixes an issue with trusted VFs seeing additional traffic. Grzegorz adds a wait for pending resets on driver removal to prevent null pointer dereferenc

[net v2 2/3] i40e: Set RX_ONLY mode for unicast promiscuous on VLAN

2020-08-14 Thread Tony Nguyen
From: Przemyslaw Patynowski Trusted VF with unicast promiscuous mode set, could listen to TX traffic of other VFs. Set unicast promiscuous mode to RX traffic, if VSI has port VLAN configured. Rename misleading I40E_AQC_SET_VSI_PROMISC_TX bit to I40E_AQC_SET_VSI_PROMISC_RX_ONLY. Aligned unicast pr

Re: [net 2/3] i40e: Set RX_ONLY mode for unicast promiscuous on VLAN

2020-08-14 Thread Nguyen, Anthony L
On Fri, 2020-08-14 at 14:19 -0700, Jakub Kicinski wrote: > On Fri, 14 Aug 2020 13:36:42 -0700 Tony Nguyen wrote: > > + * @hw: pointer to the hw struct > > + * @maj: api major value > > + * @min: api minor value > > +static bool i40e_is_aq_api_ver_ge(struct i40e_adminq_info *aq, u16 > > maj, > > +

Re: [PATCH net v4] net: xdp: account for layer 3 packets in generic skb handler

2020-08-14 Thread David Miller
From: "Jason A. Donenfeld" Date: Fri, 14 Aug 2020 23:04:56 +0200 > What? No. It comes up repeatedly because people want to reuse their > XDP processing logic with layer 3 devices. XDP is a layer 2 packet processing technology. It assumes an L2 ethernet and/or VLAN header is going to be there.

Re: [net 3/3] i40e: Fix crash during removing i40e driver

2020-08-14 Thread Jakub Kicinski
On Fri, 14 Aug 2020 13:36:43 -0700 Tony Nguyen wrote: > Fixes: 4b8164467b85 ("Add common function for finding VSI by type") Fixes tag: Fixes: 4b8164467b85 ("Add common function for finding VSI by type") Has these problem(s): - Subject does not match target commit subject Just use

Re: [net 2/3] i40e: Set RX_ONLY mode for unicast promiscuous on VLAN

2020-08-14 Thread Jakub Kicinski
On Fri, 14 Aug 2020 13:36:42 -0700 Tony Nguyen wrote: > + * @hw: pointer to the hw struct > + * @maj: api major value > + * @min: api minor value > +static bool i40e_is_aq_api_ver_ge(struct i40e_adminq_info *aq, u16 maj, > + u16 min) hw vs aq. Please build test the p

Re: [PATCH net v4] net: xdp: account for layer 3 packets in generic skb handler

2020-08-14 Thread David Miller
From: Jakub Kicinski Date: Fri, 14 Aug 2020 08:31:53 -0700 > I'm sure it comes up repeatedly because we don't return any errors, > so people waste time investigating why it doesn't work. +1

Re: [PATCH net] mptcp: sendmsg: reset iter on error

2020-08-14 Thread David Miller
From: Florian Westphal Date: Fri, 14 Aug 2020 15:56:34 +0200 > Once we've copied data from the iterator we need to revert in case we > end up not sending any data. > > This bug doesn't trigger with normal 'poll' based tests, because > we only feed a small chunk of data to kernel after poll indic

Re: [PATCH net] sfc: check hash is valid before using it

2020-08-14 Thread David Miller
From: Edward Cree Date: Fri, 14 Aug 2020 13:26:22 +0100 > On EF100, the RX hash field in the packet prefix may not be valid (e.g. > if the header parse failed), and this is indicated by a one-bit flag > elsewhere in the packet prefix. Only call skb_set_hash() if the > RSS_HASH_VALID bit is se

Re: [PATCH net v4] net: xdp: account for layer 3 packets in generic skb handler

2020-08-14 Thread Jason A. Donenfeld
On 8/14/20, Jakub Kicinski wrote: > On Fri, 14 Aug 2020 08:56:48 +0200 Jason A. Donenfeld wrote: >> On Thu, Aug 13, 2020 at 11:01 PM Jakub Kicinski wrote: >> > > I had originally dropped this patch, but the issue kept coming up in >> > > user reports, so here's a v4 of it. Testing of it is still

Re: pull-request: can 2020-08-14

2020-08-14 Thread David Miller
From: Marc Kleine-Budde Date: Fri, 14 Aug 2020 13:04:22 +0200 > this is a pull request of 6 patches for net/master. All patches fix problems > in > the j1939 CAN networking stack. > > The first patch is by Eric Dumazet fixes a kernel-infoleak in > j1939_sk_sock2sockaddr_can(). > > The remainin

Re: [PATCH net v5] net: xdp: account for layer 3 packets in generic skb handler

2020-08-14 Thread Jason A. Donenfeld
On 8/14/20, David Miller wrote: > From: "Jason A. Donenfeld" > Date: Fri, 14 Aug 2020 09:30:48 +0200 > >> @@ -4676,6 +4688,7 @@ static u32 netif_receive_generic_xdp(struct sk_buff >> *skb, >> (orig_bcast != is_multicast_ether_addr_64bits(eth->h_dest))) { >> __skb_push(skb, E

Re: [PATCH net v5] net: xdp: account for layer 3 packets in generic skb handler

2020-08-14 Thread David Miller
From: "Jason A. Donenfeld" Date: Fri, 14 Aug 2020 09:30:48 +0200 > @@ -4676,6 +4688,7 @@ static u32 netif_receive_generic_xdp(struct sk_buff > *skb, > (orig_bcast != is_multicast_ether_addr_64bits(eth->h_dest))) { > __skb_push(skb, ETH_HLEN); > skb->protocol

Re: [PATCH] net: qrtr: fix usage of idr in port assignment to socket

2020-08-14 Thread David Miller
From: Necip Fazil Yildiran Date: Fri, 14 Aug 2020 10:10:00 + > diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c > index b4c0db0b7d31..52d0707df776 100644 > --- a/net/qrtr/qrtr.c > +++ b/net/qrtr/qrtr.c > @@ -693,22 +693,24 @@ static void qrtr_port_remove(struct qrtr_sock *ipc) > static int qrt

Re: [PATCH net 0/5] refactoring of ibmvnic code

2020-08-14 Thread David Miller
From: Lijun Pan Date: Fri, 14 Aug 2020 02:59:16 -0500 > This patch series refactor reset_init and init functions, > improve the debugging messages, and make some other cosmetic changes > to make the code easier to read and debug. Cosmetic changes and cleanups are not appropriate at this time as

[net 1/3] igc: Fix PTP initialization

2020-08-14 Thread Tony Nguyen
From: Vinicius Costa Gomes Right now, igc_ptp_reset() is called from igc_reset(), which is called from igc_probe() before igc_ptp_init() has a chance to run. It is detected as an attempt to use an spinlock without registering its key first. See log below. To avoid this problem, simplify the init

[net 0/3][pull request] Intel Wired LAN Driver Updates 2020-08-14

2020-08-14 Thread Tony Nguyen
This series contains updates to i40e and igc drivers. Vinicius fixes an issue with PTP spinlock being accessed before initialization. Przemyslaw fixes an issue with trusted VFs seeing additional traffic. Grzegorz adds a wait for pending resets on driver removal to prevent null pointer dereferenc

[net 2/3] i40e: Set RX_ONLY mode for unicast promiscuous on VLAN

2020-08-14 Thread Tony Nguyen
From: Przemyslaw Patynowski Trusted VF with unicast promiscuous mode set, could listen to TX traffic of other VFs. Set unicast promiscuous mode to RX traffic, if VSI has port VLAN configured. Rename misleading I40E_AQC_SET_VSI_PROMISC_TX bit to I40E_AQC_SET_VSI_PROMISC_RX_ONLY. Aligned unicast pr

[net 3/3] i40e: Fix crash during removing i40e driver

2020-08-14 Thread Tony Nguyen
From: Grzegorz Szczurek Fix the reason of crashing system by add waiting time to finish reset recovery process before starting remove driver procedure. Now VSI is releasing if VSI is not in reset recovery mode. Without this fix it was possible to start remove driver if other processing command ne

Re: [PATCH v1 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-08-14 Thread Luiz Augusto von Dentz
Hi Joseph, On Thu, Aug 13, 2020 at 1:42 AM Joseph Hwang wrote: > > It is desirable to define the HCI packet payload sizes of > USB alternate settings so that they can be exposed to user > space. > > Reviewed-by: Alain Michaud > Reviewed-by: Abhishek Pandit-Subedi > Signed-off-by: Joseph Hwang

Re: [PATCH v1 2/2] Bluetooth: sco: expose WBS packet length in socket option

2020-08-14 Thread Luiz Augusto von Dentz
Hi Joseph, On Thu, Aug 13, 2020 at 1:42 AM Joseph Hwang wrote: > > It is desirable to expose the wideband speech packet length via > a socket option to the user space so that the user space can set > the value correctly in configuring the sco connection. > > Reviewed-by: Alain Michaud > Reviewed

Re: [PATCH net] mptcp: sendmsg: reset iter on error

2020-08-14 Thread Mat Martineau
On Fri, 14 Aug 2020, Florian Westphal wrote: Once we've copied data from the iterator we need to revert in case we end up not sending any data. This bug doesn't trigger with normal 'poll' based tests, because we only feed a small chunk of data to kernel after poll indicated POLLOUT. With block

[PATCH 2/2 nf] selftests: netfilter: exit on invalid parameters

2020-08-14 Thread Fabian Frederick
exit script with comments when parameters are wrong during address addition. No need for a message when trying to change MTU with lower values: output is self-explanatory Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_flowtable.sh | 13 + 1 file changed, 13

[PATCH 1/2 nf] selftests: netfilter: fix header example

2020-08-14 Thread Fabian Frederick
nft_flowtable.sh is made for bash not sh. Also give values which not return "RTNETLINK answers: Invalid argument" Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_flowtable.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net

Re: KASAN: use-after-free Read in refcount_inc_not_zero_checked (2)

2020-08-14 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 987053a30016a7d9ab3e4ad973e7c51aeb1f1ef6 Author: Arvind Sankar Date: Thu Apr 30 18:28:40 2020 + efi/x86: Move command-line initrd loading to efi_main bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11680f6a90 star

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-14 Thread Christian Lamparter
On 2020-08-14 18:40, Lee Jones wrote: On Fri, 14 Aug 2020, Christian Lamparter wrote: On 2020-08-14 13:39, Lee Jones wrote: 'ar9170_qmap' is used in some source files which include carl9170.h, but not all of them. Mark it as __maybe_unused to show that this is not only okay, it's expected. F

Re: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements

2020-08-14 Thread Kalle Valo
Lee Jones writes: > On Fri, 14 Aug 2020, Kalle Valo wrote: > >> Lee Jones writes: >> >> > Fixes the following W=1 kernel build warning(s): >> > >> > drivers/net/wireless/broadcom/b43/main.c: In function >> > ‘b43_dummy_transmission’: >> > drivers/net/wireless/broadcom/b43/main.c:785:3: warni

Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

2020-08-14 Thread Andrii Nakryiko
On Fri, Aug 14, 2020 at 2:58 AM Miaohe Lin wrote: > > Convert the uses of fallthrough comments to fallthrough macro. > > Signed-off-by: Miaohe Lin > --- > kernel/bpf/cgroup.c | 2 +- > kernel/bpf/cpumap.c | 2 +- > kernel/bpf/syscall.c | 2 +- > kernel/bpf/verifier.c | 6 +++--- > 4 files c

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-08-14 Thread Jason Gunthorpe
On Sat, Aug 08, 2020 at 03:57:33PM -0700, Jack Leadford wrote: > Hello! > > Thanks to Jason for getting this conversation back on track. > > Yes: in general, {} or a partial initializer /will/ zero padding bits. > > However, there is a bug in some versions of GCC where {} will /not/ zero > paddi

Re: [RFC PATCH bpf-next 2/4] bpf: make BTF show support generic, apply to seq files/bpf_trace_printk

2020-08-14 Thread Alexei Starovoitov
On Fri, Aug 14, 2020 at 02:06:37PM +0100, Alan Maguire wrote: > On Wed, 12 Aug 2020, Alexei Starovoitov wrote: > > > On Thu, Aug 06, 2020 at 03:42:23PM +0100, Alan Maguire wrote: > > > > > > The bpf_trace_printk tracepoint is augmented with a "trace_id" > > > field; it is used to allow tracepoint

Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

2020-08-14 Thread Yonghong Song
On 8/14/20 2:16 AM, Miaohe Lin wrote: Convert the uses of fallthrough comments to fallthrough macro. Signed-off-by: Miaohe Lin This is not a bug fix but rather an enhancement so not sure whether this should push to bpf tree or wait until bpf-next. It may be worthwhile to mention Commit 29

Re: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements

2020-08-14 Thread Lee Jones
On Fri, 14 Aug 2020, Kalle Valo wrote: > Lee Jones writes: > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/wireless/broadcom/b43/main.c: In function > > ‘b43_dummy_transmission’: > > drivers/net/wireless/broadcom/b43/main.c:785:3: warning: suggest braces > > around

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-14 Thread Lee Jones
On Fri, 14 Aug 2020, Christian Lamparter wrote: > On 2020-08-14 13:39, Lee Jones wrote: > > 'ar9170_qmap' is used in some source files which include carl9170.h, > > but not all of them. Mark it as __maybe_unused to show that this is > > not only okay, it's expected. > > > > Fixes the following W

Re: [PATCH] ath10k: fix the status check and wrong return

2020-08-14 Thread Tom Psyborg
On 14/08/2020, Tang Bin wrote: > In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't > return NULL. Thus use IS_ERR() and PTR_ERR() to validate > the returned value instead of IS_ERR_OR_NULL(). > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin > --- > drivers/net/wireless/a

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-14 Thread Lee Jones
On Fri, 14 Aug 2020, Kalle Valo wrote: > Lee Jones writes: > > > - Ensure spaces appear after {for, if, while, etc} > > - Ensure spaces to not appear after '(' > > - Ensure spaces to not appear before ')' > > - Ensure spaces appear between ')' and '{' > > - Ensure spaces appear after ',' >

Re: [PATCH 26/30] net: wireless: broadcom: b43: phy_common: Demote non-conformant kerneldoc header

2020-08-14 Thread Lee Jones
On Fri, 14 Aug 2020, Artur Dubrovsky wrote: > remove me from mailing list I guess you have to remove yourself: http://lists.infradead.org/mailman/listinfo/b43-dev > пт, 14 авг. 2020 г. в 14:43, Lee Jones : > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/wireless/bro

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-14 Thread Luca Ceresoli
Hi, On 14/08/20 16:51, Rob Herring wrote: > On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli wrote: >> >> Hi Rob, >> >> On 12/08/20 22:36, Rob Herring wrote: >>> Clean-up incorrect indentation, extra spaces, long lines, and missing >>> EOF newline in schema files. Most of the clean-ups are for list

Re: [PATCH][for v4.4 only] udp: drop corrupt packets earlier to avoid data corruption

2020-08-14 Thread Sasha Levin
On Wed, Aug 12, 2020 at 05:09:37PM -0700, Eric Dumazet wrote: On Wed, Aug 12, 2020 at 5:06 PM Sasha Levin wrote: On Fri, Aug 07, 2020 at 06:03:00PM +, Dexuan Cui wrote: >> From: Dexuan Cui >> Sent: Monday, July 27, 2020 6:55 PM >> To: gre...@linuxfoundation.org; eduma...@google.com; >> st

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-14 Thread Sedat Dilek
On Fri, Aug 14, 2020 at 6:05 PM Willy Tarreau wrote: > > On Fri, Aug 14, 2020 at 05:32:32PM +0200, Sedat Dilek wrote: > > commit 94c7eb54c4b8e81618ec79f414fe1ca5767f9720 > > "random32: add a tracepoint for prandom_u32()" > > > > ...I gave Willy's patches a try and used the Linux Test Project (LTP)

RE: sctp: num_ostreams and max_instreams negotiation

2020-08-14 Thread David Laight
> > > At some point the negotiation of the number of SCTP streams > > > seems to have got broken. > > > I've definitely tested it in the past (probably 10 years ago!) > > > but on a 5.8.0 kernel getsockopt(SCTP_INFO) seems to be > > > returning the 'num_ostreams' set by setsockopt(SCTP_INIT) > > >

Re: [PATCH bpf] selftest/bpf: make bpftool if it is not already built

2020-08-14 Thread Yonghong Song
On 8/14/20 1:57 AM, Balamuruhan S wrote: test_bpftool error out if bpftool is not available in bpftool dir linux/tools/bpf/bpftool, build and clean it as part of test bootstrap and teardown. Error log: - test_feature_dev_json (test_bpftool.TestBpftool) ... ERROR test_feature_kernel (t

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-14 Thread Willy Tarreau
On Fri, Aug 14, 2020 at 05:32:32PM +0200, Sedat Dilek wrote: > commit 94c7eb54c4b8e81618ec79f414fe1ca5767f9720 > "random32: add a tracepoint for prandom_u32()" > > ...I gave Willy's patches a try and used the Linux Test Project (LTP) > for testing. Just FWIW today I could run several relevant tes

[RFC 3/3] staging: qlge: clean up code that dump info to dmesg

2020-08-14 Thread Coiby Xu
The related code are not necessary because, - Device status and general registers can be obtained by ethtool. - Coredump can be done via devlink health reporter. - Structure related to the hardware (struct ql_adapter) can be obtained by crash or drgn. Signed-off-by: Coiby Xu --- drivers/stagin

[RFC 2/3] staging: qlge: coredump via devlink health reporter

2020-08-14 Thread Coiby Xu
$ devlink health dump show DEVICE reporter coredump -p -j { "Core Registers": { "segment": 1, "values": [ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

[RFC 1/3] Initialize devlink health dump framework for the dlge driver

2020-08-14 Thread Coiby Xu
Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu --- drivers/staging/qlge/Makefile | 2 +- drivers/staging/qlge/qlge.h| 9 +++ drivers/staging/qlge/qlge_health.c | 43 ++

[RFC 0/3] staging: qlge: Re-writing the debugging features

2020-08-14 Thread Coiby Xu
This patch set aims to avoid dumping registers, data structures and coredump to dmesg and also to reduce the code size of the qlge driver. As pointed out by Benjamin [1], > At 2000 lines, qlge_dbg.c alone is larger than some entire ethernet > drivers. Most of what it does is dump kernel data stru

Re: [PATCH] net: correct zerocopy refcnt with newly allocated UDP or RAW uarg

2020-08-14 Thread Willem de Bruijn
On Fri, Aug 14, 2020 at 10:17 AM linmiaohe wrote: > > Willem de Bruijn wrote: > >On Thu, Aug 13, 2020 at 1:59 PM Miaohe Lin wrote: > >> > >> The var extra_uref is introduced to pass the initial reference taken > >> in sock_zerocopy_alloc to the first generated skb. But now we may fail > >> to pa

Re: [DRAFT PATCH] random32: make prandom_u32() output unpredictable

2020-08-14 Thread Sedat Dilek
On Thu, Aug 13, 2020 at 10:06 AM Willy Tarreau wrote: > > On Thu, Aug 13, 2020 at 09:53:11AM +0200, Sedat Dilek wrote: > > On Wed, Aug 12, 2020 at 5:21 AM Willy Tarreau wrote: > > > > > > On Tue, Aug 11, 2020 at 12:51:43PM +0200, Sedat Dilek wrote: > > > > Can you share this "rebased to mainline"

Re: [PATCH net v4] net: xdp: account for layer 3 packets in generic skb handler

2020-08-14 Thread Jakub Kicinski
On Fri, 14 Aug 2020 08:56:48 +0200 Jason A. Donenfeld wrote: > On Thu, Aug 13, 2020 at 11:01 PM Jakub Kicinski wrote: > > > I had originally dropped this patch, but the issue kept coming up in > > > user reports, so here's a v4 of it. Testing of it is still rather slim, > > > but hopefully that wi

Re: [PATCH] iproute2: ip maddress: Check multiaddr length

2020-08-14 Thread Stephen Hemminger
On Fri, 14 Aug 2020 10:46:26 +0200 Sascha Hauer wrote: > ip maddress add|del takes a MAC address as argument, so insist on > getting a length of ETH_ALEN bytes. This makes sure the passed argument > is actually a MAC address and especially not an IPv4 address which > was previously accepted and s

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-14 Thread Kalle Valo
Lee Jones writes: > - Ensure spaces appear after {for, if, while, etc} > - Ensure spaces to not appear after '(' > - Ensure spaces to not appear before ')' > - Ensure spaces appear between ')' and '{' > - Ensure spaces appear after ',' > - Ensure spaces do not appear before ',' > - Ensure

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-14 Thread Christian Lamparter
On 2020-08-14 13:39, Lee Jones wrote: 'ar9170_qmap' is used in some source files which include carl9170.h, but not all of them. Mark it as __maybe_unused to show that this is not only okay, it's expected. Fixes the following W=1 kernel build warning(s) Is this W=1 really a "must" requirement?

Re: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements

2020-08-14 Thread Kalle Valo
Lee Jones writes: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/broadcom/b43/main.c: In function > ‘b43_dummy_transmission’: > drivers/net/wireless/broadcom/b43/main.c:785:3: warning: suggest braces > around empty body in an ‘if’ statement [-Wempty-body] > drive

KMSAN: uninit-value in __skb_checksum_complete (5)

2020-08-14 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:ce8056d1 wip: changed copy_from_user where instrumented git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=149f894a90 kernel config: https://syzkaller.appspot.com/x/.

Re: [PATCH for v5.9] ath5k: Replace HTTP links with HTTPS ones

2020-08-14 Thread Kalle Valo
"Alexander A. Klimov" wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b`: > For

Re: [PATCH 7/7] ath: drop unnecessary list_empty

2020-08-14 Thread Kalle Valo
Julia Lawall wrote: > list_for_each_entry{_safe} is able to handle an empty list. > The only effect of avoiding the loop is not initializing the > index variable. > Drop list_empty tests in cases where these variables are not > used. > > Note that list_for_each_entry{_safe} is defined in terms o

Re: WARNING: locking bug in try_to_grab_pending

2020-08-14 Thread Eric Dumazet
On 8/14/20 6:17 AM, syzbot wrote: > syzbot suspects this issue was fixed by commit: > > commit 1378817486d6860f6a927f573491afe65287abf1 > Author: Eric Dumazet > Date: Thu May 21 18:29:58 2020 + > > tipc: block BH before using dst_cache > > bisection log: https://syzkaller.appspot.

Re: [PATCH][next] ath9k: Use fallthrough pseudo-keyword

2020-08-14 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. > > [1] > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > Signed-off-by:

Re: [PATCH net 0/3] ethtool-netlink bug fixes

2020-08-14 Thread Florian Fainelli
On 8/14/2020 6:16 AM, Maxim Mikityanskiy wrote: This series contains a few bug fixes for ethtool-netlink. These bugs are specific for the netlink interface, and the legacy ioctl interface is not affected. These patches aim to have the same behavior in ethtool-netlink as in the legacy ethtool.

[PATCH] ath10k: fix the status check and wrong return

2020-08-14 Thread Tang Bin
In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't return NULL. Thus use IS_ERR() and PTR_ERR() to validate the returned value instead of IS_ERR_OR_NULL(). Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- drivers/net/wireless/ath/ath10k/ahb.c | 12 ++-- 1 file chang

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-14 Thread Rob Herring
On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli wrote: > > Hi Rob, > > On 12/08/20 22:36, Rob Herring wrote: > > Clean-up incorrect indentation, extra spaces, long lines, and missing > > EOF newline in schema files. Most of the clean-ups are for list > > indentation which should always be 2 spaces m

Re: [PATCH][next] wil6210: Avoid the use of one-element array

2020-08-14 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > One-element arrays are being deprecated[1]. Replace the one-element > array with a simple value type 'u8 reserved'[2], once this is just > a placeholder for alignment. > > [1] https://github.com/KSPP/linux/issues/79 > [2] https://github.com/KSPP/linux/issues/86 >

Re: [PATCH] ath9k: Fix typo in function name

2020-08-14 Thread Kalle Valo
Pavel Machek wrote: > Typo "destoy" made me wonder if correct patch is wrong; fix it. No > functional change. > > Signed-off-by: Pavel Machek (CIP) > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 743adae9da12 ath9k: Fix typo in function name -- https://patc

Re: [PATCH for v5.9] ath9k: Replace HTTP links with HTTPS ones

2020-08-14 Thread Kalle Valo
"Alexander A. Klimov" wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b`: > For

[PATCH] clk: clk-hi3670: Add CLK_IGNORE_UNUSED flag

2020-08-14 Thread Mauro Carvalho Chehab
There are several clocks that are required for Kirin 970 to work. Without them, the system hangs. However, most of the clocks defined at clk-hi3670 aren't specified on its device tree, nor at Hikey 970 one. A few of them are defined at the Linaro's official tree for Hikey 970, but, even there, dis

How are you today, I am sending this mail to you regarding my project plan in your country which i would like to discuss with you, can you please get back to me for further details. Regards, Mr. Insan

2020-08-14 Thread Insang Lee

Re: [PATCH 1/3] selftests: Add VRF icmp error route lookup test

2020-08-14 Thread Michael Jeanson
- On 13 Aug, 2020, at 19:13, David Ahern dsah...@gmail.com wrote: ... >> +ipv6_ping() >> +{ >> +log_section "IPv6: VRF ICMP error route lookup ping" >> + >> +setup >> + >> +# verify connectivity >> +if ! check_connectivity6; then >> +echo "Error: Basic connectivity

[PATCH net] mptcp: sendmsg: reset iter on error

2020-08-14 Thread Florian Westphal
Once we've copied data from the iterator we need to revert in case we end up not sending any data. This bug doesn't trigger with normal 'poll' based tests, because we only feed a small chunk of data to kernel after poll indicated POLLOUT. With blocking IO and large writes this triggers. Receiver

Re: [PATCH] net: add missing skb_uarg refcount increment in pskb_carve_inside_header()

2020-08-14 Thread Willem de Bruijn
On Fri, Aug 14, 2020 at 9:20 AM linmiaohe wrote: > > Willem de Bruijn wrote: > >On Thu, Aug 13, 2020 at 2:16 PM Miaohe Lin wrote: > >> > >> If the skb is zcopied, we should increase the skb_uarg refcount before > >> we involve skb_release_data(). See pskb_expand_head() as a reference. > > > >Did

RE: sctp: num_ostreams and max_instreams negotiation

2020-08-14 Thread David Laight
> > At some point the negotiation of the number of SCTP streams > > seems to have got broken. > > I've definitely tested it in the past (probably 10 years ago!) > > but on a 5.8.0 kernel getsockopt(SCTP_INFO) seems to be > > returning the 'num_ostreams' set by setsockopt(SCTP_INIT) > > rather than

Re: [net-next v4 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-08-14 Thread Andrew Lunn
> > > Currently > > > > > > compatible = "marvell,prestera" > > > > > > is used as default, so may be > > > > > > you mean to support few matching including particular silicon too, like ? > > > > > > > > > compatible = "marvell,prestera" > > > compatible = "marvell,prestera-ac3x"

[PATCH ethtool 2/2] netlink: Print and return an error when features weren't changed

2020-08-14 Thread Maxim Mikityanskiy
The legacy ethtool prints an error message and returns 1 if no features were changed as requested. Port this behavior to ethtool-netlink. req_mask is compared to wanted_mask to detect if any feature was changed. If these masks are equal, it means that the kernel hasn't changed anything, and all bit

Re: WARNING: locking bug in try_to_grab_pending

2020-08-14 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 1378817486d6860f6a927f573491afe65287abf1 Author: Eric Dumazet Date: Thu May 21 18:29:58 2020 + tipc: block BH before using dst_cache bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=175599f690 start commit: 6663c

[PATCH ethtool 0/2] ethtool-netlink compatibility fixes

2020-08-14 Thread Maxim Mikityanskiy
This series contains fixes for ethtool-netlink to make the behavior similar to the legacy ethtool and avoid regressions caused by differences in behavior between the old and the new tool. Please also see the sibling series for the kernel. Maxim Mikityanskiy (2): netlink: Fix the condition for d

[PATCH ethtool 1/2] netlink: Fix the condition for displaying actual changes

2020-08-14 Thread Maxim Mikityanskiy
This comment in the code: /* result is not exactly as requested, show differences */ implies that the "Actual changes" output should be displayed only if the result is not as requested, which matches the legacy ethtool behavior. However, in fact, ethtool-netlink displays "actual changes" even

[PATCH net 3/3] ethtool: Don't omit the netlink reply if no features were changed

2020-08-14 Thread Maxim Mikityanskiy
The legacy ethtool userspace tool shows an error when no features could be changed. It's useful to have a netlink reply to be able to show this error when __netdev_update_features wasn't called, for example: 1. ethtool -k eth0 large-receive-offload: off 2. ethtool -K eth0 rx-fcs on 3. ethtool -

[PATCH net 1/3] ethtool: Fix preserving of wanted feature bits in netlink interface

2020-08-14 Thread Maxim Mikityanskiy
Currently, ethtool-netlink calculates new wanted bits as: (req_wanted & req_mask) | (old_active & ~req_mask) It completely discards the old wanted bits, so they are forgotten with the next ethtool command. Sample steps to reproduce: 1. ethtool -k eth0 tx-tcp-segmentation: on # TSO is on from t

[PATCH net 2/3] ethtool: Account for hw_features in netlink interface

2020-08-14 Thread Maxim Mikityanskiy
ethtool-netlink ignores dev->hw_features and may confuse the drivers by asking them to enable features not in the hw_features bitmask. For example: 1. ethtool -k eth0 tls-hw-tx-offload: off [fixed] 2. ethtool -K eth0 tls-hw-tx-offload on tls-hw-tx-offload: on 3. ethtool -k eth0 tls-hw-tx-

[PATCH net 0/3] ethtool-netlink bug fixes

2020-08-14 Thread Maxim Mikityanskiy
This series contains a few bug fixes for ethtool-netlink. These bugs are specific for the netlink interface, and the legacy ioctl interface is not affected. These patches aim to have the same behavior in ethtool-netlink as in the legacy ethtool. Please also see the sibling series for the userspace

Re: [RFC PATCH bpf-next 2/4] bpf: make BTF show support generic, apply to seq files/bpf_trace_printk

2020-08-14 Thread Alan Maguire
On Wed, 12 Aug 2020, Alexei Starovoitov wrote: > On Thu, Aug 06, 2020 at 03:42:23PM +0100, Alan Maguire wrote: > > > > The bpf_trace_printk tracepoint is augmented with a "trace_id" > > field; it is used to allow tracepoint filtering as typed display > > information can easily be interspersed wit

RE: num_ostreams and max_instreams negotiation

2020-08-14 Thread David Laight
> At some point the negotiation of the number of SCTP streams > seems to have got broken. > I've definitely tested it in the past (probably 10 years ago!) > but on a 5.8.0 kernel getsockopt(SCTP_INFO) seems to be > returning the 'num_ostreams' set by setsockopt(SCTP_INIT) > rather than the smaller

Re: [net-next v4 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-08-14 Thread Vadym Kochan
On Fri, Aug 14, 2020 at 01:05:36PM +0100, Jonathan McDowell wrote: > On Fri, Aug 14, 2020 at 11:20:54AM +0300, Vadym Kochan wrote: > > On Thu, Aug 13, 2020 at 09:03:22AM +0100, Jonathan McDowell wrote: > > > On Mon, Jul 27, 2020 at 03:22:37PM +0300, Vadym Kochan wrote: > > > > Marvell Prestera 98DX

[PATCH net] sfc: check hash is valid before using it

2020-08-14 Thread Edward Cree
On EF100, the RX hash field in the packet prefix may not be valid (e.g. if the header parse failed), and this is indicated by a one-bit flag elsewhere in the packet prefix. Only call skb_set_hash() if the RSS_HASH_VALID bit is set. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10

[RFC][PATCH] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc

2020-08-14 Thread Denys Zagorui
SIOCADDMULTI API allows adding multicast/unicast mac addresses but doesn't deferentiate them so if someone tries to add secondary unicast mac addr it will be added to multicast netdev list which is confusing. There is at least one user that allows adding secondary unicast through this API. (2f41f33

Re: [net-next v4 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-08-14 Thread Jonathan McDowell
On Fri, Aug 14, 2020 at 11:20:54AM +0300, Vadym Kochan wrote: > On Thu, Aug 13, 2020 at 09:03:22AM +0100, Jonathan McDowell wrote: > > On Mon, Jul 27, 2020 at 03:22:37PM +0300, Vadym Kochan wrote: > > > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 > > > ports of 10GbE uplinks

[PATCH 02/30] net: bonding: bond_main: Document 'proto' and rename 'new_active' parameters

2020-08-14 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/bonding/bond_main.c:329: warning: Function parameter or member 'proto' not described in 'bond_vlan_rx_add_vid' drivers/net/bonding/bond_main.c:362: warning: Function parameter or member 'proto' not described in 'bond_vlan_rx_kill_vid

[PATCH 01/30] net: bonding: bond_3ad: Fix a bunch of kerneldoc parameter issues

2020-08-14 Thread Lee Jones
Renames and missing descriptions. Fixes the following W=1 kernel build warning(s): drivers/net/bonding/bond_3ad.c:140: warning: Function parameter or member 'port' not described in '__get_first_agg' drivers/net/bonding/bond_3ad.c:140: warning: Excess function parameter 'bond' description in '

[PATCH 05/30] net: wireless: atmel: atmel: Demote non-kerneldoc header to standard comment block

2020-08-14 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/atmel/atmel.c:4232: warning: Cannot understand This file is part of net.russotto.AtmelMACFW, hereto referred to Cc: Simon Kelley Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.kernel.o

[PATCH 06/30] net: ethernet: 8390: axnet_cs: Document unused parameter 'txqueue'

2020-08-14 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/8390/axnet_cs.c:907: warning: Function parameter or member 'txqueue' not described in 'axnet_tx_timeout' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Martin Habets Cc: Shannon Nelson Cc: "Michael S. Tsirkin" Cc: William

  1   2   >