Re: [PATCH net v2] net/sched: act_ct: fix miss set mru for ovs after defrag in act_ct

On Thu, Jul 30, 2020 at 7:45 PM wrote: > > From: wenxu > > When openvswitch conntrack offload with act_ct action. Fragment packets > defrag in the ingress tc act_ct action and miss the next chain. Then the > packet pass to the openvswitch datapath without the mru. The over > mtu packet will be dr

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

On Fri, Jul 31, 2020 at 07:19:24PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 31, 2020 at 11:36:04AM -0300, Jason Gunthorpe wrote: > > On Fri, Jul 31, 2020 at 04:21:48PM +0200, Greg Kroah-Hartman wrote: > > > > > > The spec was updated in C11 to require zero'ing padding when doing > > > > parti

Re: [PATCH v2 0/3]

On 7/31/2020 10:10 PM, Rakesh Pillai wrote: > > >> -Original Message- >> From: Florian Fainelli >> Sent: Saturday, August 1, 2020 12:17 AM >> To: Rakesh Pillai ; ath...@lists.infradead.org >> Cc: linux-wirel...@vger.kernel.org; linux-ker...@vger.kernel.org; >> kv...@codeaurora.org; da

RE: [PATCH v2 1/3] ath10k: Add history for tracking certain events

> -Original Message- > From: Ben Greear > Sent: Saturday, August 1, 2020 12:08 AM > To: Rakesh Pillai ; ath...@lists.infradead.org > Cc: linux-wirel...@vger.kernel.org; linux-ker...@vger.kernel.org; > kv...@codeaurora.org; da...@davemloft.net; k...@kernel.org; > netdev@vger.kernel.org >

RE: [PATCH v2 0/3]

> -Original Message- > From: Florian Fainelli > Sent: Saturday, August 1, 2020 12:17 AM > To: Rakesh Pillai ; ath...@lists.infradead.org > Cc: linux-wirel...@vger.kernel.org; linux-ker...@vger.kernel.org; > kv...@codeaurora.org; da...@davemloft.net; k...@kernel.org; > netdev@vger.kernel

Re: [PATCH] net: Phy: Add PHY lookup support on MDIO bus in case of ACPI probe

On 7/31/2020 9:53 PM, Vikas Singh wrote: > Hi Andrew, >   > As i have already mentioned that this patch is based on > https://www.spinics.net/lists/netdev/msg662173.html, > > > When MDIO bus gets registered itself along with devices on it ,

Re: [PATCH net-next] fib: fix another fib_rules_ops indirect call wrapper problem

On 7/31/20 8:01 PM, Brian Vazquez wrote: > It turns out that on commit 41d707b7332f ("fib: fix fib_rules_ops > indirect calls wrappers") I forgot to include the case when > CONFIG_IP_MULTIPLE_TABLES is not set. > > Fixes: 41d707b7332f ("fib: fix fib_rules_ops indirect calls wrappers") > Reported-b

Re: [RFC PATCH] bpftool btf: Add prefix option to dump C

On Fri, Jul 31, 2020 at 6:47 PM Ian Rogers wrote: > > On Tue, Jul 21, 2020 at 11:58 PM Andrii Nakryiko > wrote: > > > > On Tue, Jul 21, 2020 at 10:44 PM Ian Rogers wrote: > > > > > > When bpftool dumps types and enum members into a header file for > > > inclusion the names match those in the ori

[PATCH net-next v3 2/2] hinic: add check for mailbox msg from VF

PF should check whether the cmd from VF is supported and its content is right before passing it to hw. Signed-off-by: Luo bin --- V1~V2: fix W=1 C=1 warnings .../net/ethernet/huawei/hinic/hinic_hw_cmdq.h | 8 + .../net/ethernet/huawei/hinic/hinic_hw_mbox.c | 173 +- .../net/et

[PATCH net-next v3 1/2] hinic: add generating mailbox random index support

add support to generate mailbox random id of VF to ensure that mailbox messages PF received are from the correct VF. Signed-off-by: Luo bin --- V2~V3 fix review opinions pointed out by Jakub .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 13 ++ .../net/ethernet/huawei/hinic/hinic_hw_mbox.c |

[PATCH net-next v3 0/2] hinic: mailbox channel enhancement

add support to generate mailbox random id for VF to ensure that the mailbox message from VF is valid and PF should check whether the cmd from VF is supported before passing it to hw. Luo bin (2): hinic: add generating mailbox random index support hinic: add check for mailbox msg from VF .../

Re: [PATCH v2] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

On Fri, Jul 31, 2020 at 4:41 PM Xie He wrote: > > Thank you for your thorough review comment! > > On Fri, Jul 31, 2020 at 7:13 AM Willem de Bruijn > wrote: > > > > Thanks for fixing a kernel panic. The existing line was added recently > > in commit 9dc829a135fb ("drivers/net/wan/lapbether: Fixed

Re: [PATCH net-next v2 1/2] hinic: add generating mailbox random index support

On 2020/8/1 3:52, Jakub Kicinski wrote: > On Fri, 31 Jul 2020 09:56:41 +0800 Luo bin wrote: >> add support to generate mailbox random id of VF to ensure that >> mailbox messages PF received are from the correct VF. >> >> Signed-off-by: Luo bin > >> diff --git a/drivers/net/ethernet/huawei/hinic/h

Re: [PATCH v2 net-next 0/9] mptcp: add syncookie support

On 7/31/20 4:56 PM, David Miller wrote: > From: Florian Westphal > Date: Thu, 30 Jul 2020 21:25:49 +0200 > >> Changes in v2: > ... >> When syn-cookies are used the SYN?ACK never contains a MPTCP option, >> because the code path that creates a request socket based on a valid >> cookie ACK lack

Re: pull-request: mac80211-next 2020-07-31

From: Johannes Berg Date: Fri, 31 Jul 2020 18:54:02 +0200 > Here's a set of patches for -next, in case we get a release > on Sunday :-) If not I may have some more next week, but no > point waiting now with this. > > Please pull and let me know if there's any problem. Pulled, thanks Johannes.

Re: [PATCH net-next v2] rtnetlink: add support for protodown reason

From: Roopa Prabhu Date: Fri, 31 Jul 2020 17:34:01 -0700 > From: Roopa Prabhu > > netdev protodown is a mechanism that allows protocols to > hold an interface down. It was initially introduced in > the kernel to hold links down by a multihoming protocol. > There was also an attempt to introduce

Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

> > > > +static int mlxbf_gige_mdio_read(struct mii_bus *bus, int phy_add, > > > > +int > > > > > > > +phy_reg) { > > > > > > > + struct mlxbf_gige *priv = bus->priv; > > > > > > > + u32 cmd; > > > > > > > + u32 ret; > > > > > > > + > > > > > > > + /* If the lock is

Re: [PATCH v6 bpf-next 0/6] bpf: tailcalls in BPF subprograms

On 7/31/20 2:03 AM, Maciej Fijalkowski wrote: v5->v6: - propagate only those poke descriptors that individual subprogram is actually using (Daniel) - drop the cumbersome check if poke desc got filled in map_poke_run() - move poke->ip renaming in bpf_jit_add_poke_descriptor() from patch 4 to

Re: linux-next: Tree for Jul 31 (net/decnet/ & FIB_RULES)

On 7/31/20 5:35 PM, Stephen Rothwell wrote: > Hi Randy, > > On Fri, 31 Jul 2020 08:53:09 -0700 Randy Dunlap wrote: >> >> on i386: >> >> ld: net/core/fib_rules.o: in function `fib_rules_lookup': >> fib_rules.c:(.text+0x16b8): undefined reference to `fib4_rule_match' >> ld: fib_rules.c:(.text+0x16b

Re: linux-next: Tree for Jul 31 (net/decnet/ & FIB_RULES)

Hi Randy, On Fri, 31 Jul 2020 08:53:09 -0700 Randy Dunlap wrote: > > on i386: > > ld: net/core/fib_rules.o: in function `fib_rules_lookup': > fib_rules.c:(.text+0x16b8): undefined reference to `fib4_rule_match' > ld: fib_rules.c:(.text+0x16bf): undefined reference to `fib4_rule_match' > ld: fib_

[PATCH net-next v2] rtnetlink: add support for protodown reason

From: Roopa Prabhu netdev protodown is a mechanism that allows protocols to hold an interface down. It was initially introduced in the kernel to hold links down by a multihoming protocol. There was also an attempt to introduce protodown reason at the time but was rejected. protodown and protodown

Re: [PATCH][next] net/sched: cls_u32: Use struct_size() helper

On 7/31/20 18:50, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Thu, 30 Jul 2020 11:03:14 -0500 > >> Make use of the struct_size() helper, in multiple places, instead >> of an open-coded version in order to avoid any potential type >> mistakes and protect against potential integer

[net-next v2 1/5] devlink: convert flash_update to use params structure

A future change is going to introduce a new parameter for specifying how devices should handle overwrite behavior when updating the flash. This will introduce a new argument specifying a bitmask of component subsections to allow overwriting behavior. Prepare for this by converting flash_update to

[iproute2-next v2 5/5] devlink: support setting the overwrite mask

Add support for specifying the overwrite sections to allow in the flash update command. This is done by adding a new "overwrite" option which can take either "settings" or "identifiers" passing the overwrite mode multiple times will combine the fields using bitwise-OR. Signed-off-by: Jacob Keller

[net-next v2 3/5] ice: add support for flash update overwrite mask

The ice driver has the ability to inform firmware of what sections of flash to preserve when performing an update. Expose this support via the recently added overwrite_mask support. Based on which sections are specified, determine the equivalent preservation level and inform firmware. Reject combi

[net-next v2 0/5] devlink flash update overwrite mask

This series introduces support for a new attribute to the flash update command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. This attribute is a u32 value that represents a bitmask of which subsections of flash to request/allow overwriting when performing a flash update. The intent is to support the

[iproute2-next v2 4/5] Update devlink header for overwrite mask attribute

Signed-off-by: Jacob Keller --- include/uapi/linux/devlink.h | 24 1 file changed, 24 insertions(+) diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index b7f23faae901..3d006ad2fdaf 100644 --- a/include/uapi/linux/devlink.h +++ b/include/uapi/linu

[net-next v2 2/5] devlink: introduce flash update overwrite mask

Sections of device flash may contain settings or device identifying information. When performing a flash update, it is generally expected that these settings and identifiers are not overwritten. Sometimes it is useful to be able to overwrite these fields when performing a flash update. To support

Re: pull-request: bpf 2020-07-31

From: Daniel Borkmann Date: Fri, 31 Jul 2020 15:51:45 +0200 > The following pull-request contains BPF updates for your *net* tree. > > We've added 5 non-merge commits during the last 21 day(s) which contain > a total of 5 files changed, 126 insertions(+), 18 deletions(-). > > The main changes a

Re: [PATCH net-next] tun: add missing rcu annotation in tun_set_ebpf()

From: Jason Wang Date: Fri, 31 Jul 2020 00:17:20 -0400 > We expecte prog_p to be protected by rcu, so adding the rcu annotation > to fix the following sparse warning: > > drivers/net/tun.c:3003:36: warning: incorrect type in argument 2 (different > address spaces) > drivers/net/tun.c:3003:36:

Re: INFO: trying to register non-static key in skb_queue_purge

syzbot has bisected this issue to: commit 65b27995a4ab8fc51b4adc6b4dcdca20f7a595bb Author: Heiner Kallweit Date: Mon Aug 12 21:52:19 2019 + net: phy: let phy_speed_down/up support speeds >1Gbps bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1327ef5090 start commit:

Re: pull request (net): ipsec 2020-07-31

From: Steffen Klassert Date: Fri, 31 Jul 2020 09:17:54 +0200 > 1) Fix policy matching with mark and mask on userspace interfaces. >From Xin Long. > > 2) Several fixes for the new ESP in TCP encapsulation. >From Sabrina Dubroca. > > 3) Fix crash when the hold queue is used. The assumptio

Re: [pull request][net 0/4] Mellanox, mlx5 fixes 2020-07-30

From: Saeed Mahameed Date: Thu, 30 Jul 2020 18:57:48 -0700 > This small patchset introduces some fixes to mlx5 driver. > > Please pull and let me know if there is any problem. Pulled. > For -stable v4.18: > ('net/mlx5e: fix bpf_prog reference count leaks in mlx5e_alloc_rq') > > For -stable v

Re: [Intel-wired-lan] [PATCH v1] ice: devlink: use %*phD to print small buffer

On Fri, 2020-07-31 at 16:49 -0700, David Miller wrote: > From: Andy Shevchenko > Date: Thu, 30 Jul 2020 19:04:51 +0300 > > > Use %*phD format to print small buffer as hex string. > > > > Signed-off-by: Andy Shevchenko > > I am assuming the Intel folks will integrate this into their tree. Yes,

Re: [PATCH net-next] tcp: add earliest departure time to SCM_TIMESTAMPING_OPT_STATS

From: Yousuk Seung Date: Thu, 30 Jul 2020 15:44:40 -0700 > This change adds TCP_NLA_EDT to SCM_TIMESTAMPING_OPT_STATS that reports > the earliest departure time(EDT) of the timestamped skb. By tracking EDT > values of the skb from different timestamps, we can observe when and how > much the value

Re: [net-next 00/12][pull request] 1GbE Intel Wired LAN Driver Updates 2020-07-30

From: Tony Nguyen Date: Thu, 30 Jul 2020 13:37:08 -0700 > This series contains updates to e100, e1000, e1000e, igb, igbvf, ixgbe, > ixgbevf, iavf, and driver documentation. > > Vaibhav Gupta converts legacy .suspend() and .resume() to generic PM > callbacks for e100, igbvf, ixgbe, ixgbevf, and i

Re: [PATCH v2 net-next 0/9] mptcp: add syncookie support

From: Florian Westphal Date: Thu, 30 Jul 2020 21:25:49 +0200 > Changes in v2: ... > When syn-cookies are used the SYN?ACK never contains a MPTCP option, > because the code path that creates a request socket based on a valid > cookie ACK lacks the needed changes to construct MPTCP request sockets

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

From: Peilin Ye Date: Thu, 30 Jul 2020 15:20:26 -0400 > rds_notify_queue_get() is potentially copying uninitialized kernel stack > memory to userspace since the compiler may leave a 4-byte hole at the end > of `cmsg`. > > In 2016 we tried to fix this issue by doing `= { 0 };` on `cmsg`, which >

Re: [net 0/2][pull request] Intel Wired LAN Driver Updates 2020-07-30

From: Tony Nguyen Date: Thu, 30 Jul 2020 10:09:36 -0700 > This series contains updates to the e1000e and igb drivers. > > Aaron Ma allows PHY initialization to continue if ULP disable failed for > e1000e. > > Francesco Ruggeri fixes race conditions in igb reset that could cause panics. ... >

Re: [PATCH][next] net/sched: cls_u32: Use struct_size() helper

From: "Gustavo A. R. Silva" Date: Thu, 30 Jul 2020 11:03:14 -0500 > Make use of the struct_size() helper, in multiple places, instead > of an open-coded version in order to avoid any potential type > mistakes and protect against potential integer overflows. > > Also, remove unnecessary object id

Re: [PATCH v1] ice: devlink: use %*phD to print small buffer

From: Andy Shevchenko Date: Thu, 30 Jul 2020 19:04:51 +0300 > Use %*phD format to print small buffer as hex string. > > Signed-off-by: Andy Shevchenko I am assuming the Intel folks will integrate this into their tree.

Re: [PATCH v1] qede: Use %pM format specifier for MAC addresses

From: Andy Shevchenko Date: Thu, 30 Jul 2020 19:00:57 +0300 > Convert to %pM instead of using custom code. > > Signed-off-by: Andy Shevchenko Applied to net-next

Re: [PATCH v1] qed: Use %pM format specifier for MAC addresses

From: Andy Shevchenko Date: Thu, 30 Jul 2020 18:59:20 +0300 > Convert to %pM instead of using custom code. > > Signed-off-by: Andy Shevchenko Applied to net-next, thanks.

Re: [PATCH v1] hsr: Use %pM format specifier for MAC addresses

From: Andy Shevchenko Date: Thu, 30 Jul 2020 18:09:04 +0300 > Convert to %pM instead of using custom code. > > Signed-off-by: Andy Shevchenko Applied to net-next, thanks.

Re: [PATCH net-next 0/4] s390/qeth: updates 2020-07-30

From: Julian Wiedmann Date: Thu, 30 Jul 2020 17:01:17 +0200 > please apply the following patch series for qeth to netdev's net-next tree. > > This primarily brings some modernization to the RX path, laying the > groundwork for smarter RX refill policies. > Some of the patches are tagged as fixes

Re: [PATCH] net: Pass NULL to skb_network_protocol() when we don't care about vlan depth

From: linmiaohe Date: Thu, 30 Jul 2020 19:02:36 +0800 > From: Miaohe Lin > > When we don't care about vlan depth, we could pass NULL instead of the > address of a unused local variable to skb_network_protocol() as a param. > > Signed-off-by: Miaohe Lin Applied to net-next, thanks.

Re: [PATCH net] net/sched: The error lable position is corrected in ct_init_module

From: Liu Jian Date: Thu, 30 Jul 2020 16:14:28 +0800 > From: liujian > > Exchange the positions of the err_tbl_init and err_register labels in > ct_init_module function. > > Fixes: c34b961a2492 ("net/sched: act_ct: Create nf flow table per zone") > Signed-off-by: liujian Applied, thank you.

RE: [PATCH v2 bpf-next 5/5] tools/bpftool: add documentation and bash-completion for `link detach`

Andrii Nakryiko wrote: > Add info on link detach sub-command to man page. Add detach to bash-completion > as well. > > Acked-by: Song Liu > Signed-off-by: Andrii Nakryiko > --- Acked-by: John Fastabend

RE: [PATCH v2 bpf-next 4/5] tools/bpftool: add `link detach` subcommand

Andrii Nakryiko wrote: > Add ability to force-detach BPF link. Also add missing error message, if > specified link ID is wrong. > > Acked-by: Song Liu > Signed-off-by: Andrii Nakryiko > --- Acked-by: John Fastabend

RE: [PATCH v2 bpf-next 3/5] selftests/bpf: add link detach tests for cgroup, netns, and xdp bpf_links

Andrii Nakryiko wrote: > Add bpf_link__detach() testing to selftests for cgroup, netns, and xdp > bpf_links. > > Acked-by: Song Liu > Signed-off-by: Andrii Nakryiko > --- Acked-by: John Fastabend

RE: [PATCH v2 bpf-next 2/5] libbpf: add bpf_link detach APIs

Andrii Nakryiko wrote: > Add low-level bpf_link_detach() API. Also add higher-level bpf_link__detach() > one. > > Acked-by: Song Liu > Signed-off-by: Andrii Nakryiko > --- I like it nice and straightforward. Acked-by: John Fastabend

RE: [PATCH v2 bpf-next 1/5] bpf: add support for forced LINK_DETACH command

Andrii Nakryiko wrote: > Add LINK_DETACH command to force-detach bpf_link without destroying it. It has > the same behavior as auto-detaching of bpf_link due to cgroup dying for > bpf_cgroup_link or net_device being destroyed for bpf_xdp_link. In such case, > bpf_link is still a valid kernel object

Re: [PATCH bpf-next v3 01/29] bpf: memcg-based memory accounting for bpf progs

On Thu, Jul 30, 2020 at 2:28 PM Roman Gushchin wrote: > > Include memory used by bpf programs into the memcg-based accounting. > This includes the memory used by programs itself, auxiliary data > and statistics. > > Signed-off-by: Roman Gushchin Acked-by: Song Liu

Re: [PATCH bpf-next v3 27/29] bpf: eliminate rlimit-based memory accounting infra for bpf maps

On Thu, Jul 30, 2020 at 2:27 PM Roman Gushchin wrote: > > Remove rlimit-based accounting infrastructure code, which is not used > anymore. > > Signed-off-by: Roman Gushchin The code is good, so Acked-by: Song Liu However, I am still nervous as we deprecate memlock. > --- > include/linux/bpf

Re: [bpf PATCH v2 1/5] bpf: sock_ops ctx access may stomp registers in corner case

Daniel Borkmann wrote: > On 7/29/20 6:22 PM, John Fastabend wrote: > > I had a sockmap program that after doing some refactoring started spewing > > this splat at me: > > > > [18610.807284] BUG: unable to handle kernel NULL pointer dereference at > > 0001 > > [...] > > [18610.807359]

Re: [PATCH] [net/ethtool] ethnl_set_linkmodes: remove redundant null check

On Fri, Jul 31, 2020 at 12:58:44AM -0400, Gaurav Singh wrote: > info cannot be NULL here since its being accessed earlier > in the function: nlmsg_parse(info->nlhdr...). Remove this > redundant NULL check. This is what the static checker tells you but it could still mean the other place is missing

Re: [PATCH v2 net-next 9/9] selftests: mptcp: add test cases for mptcp join tests with syn cookies

On Thu, 30 Jul 2020, Florian Westphal wrote: Also add test cases with MP_JOIN when tcp_syncookies sysctl is 2 (i.e., syncookies are always-on). While at it, also print the test number and add the test number to the pcap files that can be generated optionally. This makes it easier to match the

Re: [PATCH v2 net-next 8/9] selftests: mptcp: make 2nd net namespace use tcp syn cookies unconditionally

On Thu, 30 Jul 2020, Florian Westphal wrote: check we can establish connections also when syn cookies are in use. Check that MPTcpExtMPCapableSYNRX and MPTcpExtMPCapableACKRX increase for each MPTCP test. Check TcpExtSyncookiesSent and TcpExtSyncookiesRecv increase in netns2. Signed-off-by: F

Re: [PATCH v2 net-next 7/9] mptcp: enable JOIN requests even if cookies are in use

On Thu, 30 Jul 2020, Florian Westphal wrote: JOIN requests do not work in syncookie mode -- for HMAC validation, the peers nonce and the mptcp token (to obtain the desired connection socket the join is for) are required, but this information is only present in the initial syn. So either we need

Re: [PATCH v2 net-next 4/9] mptcp: rename and export mptcp_subflow_request_sock_ops

On Thu, 30 Jul 2020, Florian Westphal wrote: syncookie code path needs to create an mptcp request sock. Prepare for this and add mptcp prefix plus needed export of ops struct. Signed-off-by: Florian Westphal --- include/net/mptcp.h | 1 + net/mptcp/subflow.c | 11 ++- 2 files changed,

Re: [PATCH v2 net-next 5/9] mptcp: subflow: add mptcp_subflow_init_cookie_req helper

On Thu, 30 Jul 2020, Florian Westphal wrote: Will be used to initialize the mptcp request socket when a MP_CAPABLE request was handled in syncookie mode, i.e. when a TCP ACK containing a MP_CAPABLE option is a valid syncookie value. Normally (non-cookie case), MPTCP will generate a unique 32 bi

Re: [PATCH v2 net-next 3/9] mptcp: subflow: split subflow_init_req

On Thu, 30 Jul 2020, Florian Westphal wrote: When syncookie support is added, we will need to add a variant of subflow_init_req() helper. It will do almost same thing except that it will not compute/add a token to the mptcp token tree. To avoid excess copy&paste, this commit splits away part o

Re: [PATCH v2 net-next 2/9] mptcp: token: move retry to caller

On Thu, 30 Jul 2020, Florian Westphal wrote: Once syncookie support is added, no state will be stored anymore when the syn/ack is generated in syncookie mode. When the ACK comes back, the generated key will be taken from the TCP ACK, the token is re-generated and inserted into the token tree.

Re: Bug: ip utility fails to show routes with large # of multipath next-hops

Thanks Ido and David for your confirmation and insight. -- Ashutosh On Wed, Jul 29, 2020 at 8:17 AM David Ahern wrote: > > On 7/29/20 5:43 AM, Ido Schimmel wrote: > > On Tue, Jul 28, 2020 at 05:52:44PM -0700, Ashutosh Grewal wrote: > >> Hello David and all, > >> > >> I hope this is the correct w

Re: [PATCH net] net: gre: recompute gre csum for sctp over gre tunnels

On Fri, Jul 31, 2020 at 08:12:05PM +0200, Lorenzo Bianconi wrote: > The GRE tunnel can be used to transport traffic that does not rely on a > Internet checksum (e.g. SCTP). The issue can be triggered creating a GRE > or GRETAP tunnel and transmitting SCTP traffic ontop of it where CRC > offload has

RE: [PATCH bpf-next] selftests/bpf: fix spurious test failures in core_retro selftest

Andrii Nakryiko wrote: > core_retro selftest uses BPF program that's triggered on sys_enter > system-wide, but has no protection from some unrelated process doing syscall > while selftest is running. This leads to occasional test failures with > unexpected PIDs being returned. Fix that by filtering

RE: [RFC PATCH bpf-next 0/3] Add a new bpf helper for FDB lookup

Yoshiki Komachi wrote: > This series adds a new bpf helper for doing FDB lookup in the kernel > tables from XDP programs. This helps users to accelerate Linux bridge > with XDP. > > In the past, XDP generally required users to reimplement their own > networking functionalities with specific manner

RE: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

> -Original Message- > From: Andrew Lunn > Sent: Friday, July 31, 2020 3:55 PM > To: Asmaa Mnebhi > Cc: David Thompson ; > netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Jiri > Pirko > Subject: Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet > driver > > On

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

On Friday, July 07/31/20, 2020 at 11:00:08 -0700, Jakub Kicinski wrote: > On Fri, 31 Jul 2020 16:39:04 +0530 Ganji Aravind wrote: > > On Thursday, July 07/30/20, 2020 at 16:23:35 -0700, Jakub Kicinski wrote: > > > On Thu, 30 Jul 2020 20:41:38 +0530 Ganji Aravind wrote: > > > > Update set_flash to

Re: [PATCH net] net: gre: recompute gre csum for sctp over gre tunnels

> The GRE tunnel can be used to transport traffic that does not rely on a > Internet checksum (e.g. SCTP). The issue can be triggered creating a GRE > or GRETAP tunnel and transmitting SCTP traffic ontop of it where CRC > offload has been disabled. In order to fix the issue we need to > recompute t

Re: [PATCH v2] seg6_iptunnel: Refactor seg6_lwt_headroom out of uapi header

From: Ioana-Ruxandra Stancioi Date: Fri, 31 Jul 2020 07:40:32 + > --- a/net/ipv6/seg6_iptunnel.c > +++ b/net/ipv6/seg6_iptunnel.c > @@ -27,6 +27,23 @@ > #include > #endif > > +static inline size_t seg6_lwt_headroom(struct seg6_iptunnel_encap *tuninfo) > +{ Please remove the inline tag w

Re: [RFC PATCH bpf-next 2/3] bpf: Add helper to do forwarding lookups in kernel FDB table

On 7/31/20 6:44 AM, Yoshiki Komachi wrote: This patch adds a new bpf helper to access FDB in the kernel tables from XDP programs. The helper enables us to find the destination port of master bridge in XDP layer with high speed. If an entry in the tables is successfully found, egress device index

[PATCH net-next] cxgb4: fix extracting IP addresses in TC-FLOWER rules

commit c8729cac2a11 ("cxgb4: add ethtool n-tuple filter insertion") has removed checking control key for determining IP address types for TC-FLOWER rules, which causes all the rules being inserted to hardware to become IPv6 rule type always. So, add back the check to select the correct IP address t

[PATCH net-next] cxgb4: fix check for running offline ethtool selftest

The flag indicating the selftest to run is a bitmask. So, fix the check. Also, the selftests will fail if adapter initialization has not been completed yet. So, add appropriate check and bail sooner. Fixes: 7235ffae3d2c ("cxgb4: add loopback ethtool self-test") Signed-off-by: Rahul Lakkireddy ---

Re: [net-next v4 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

Hi Andy, On Fri, Jul 31, 2020 at 07:02:47PM +0300, Andy Shevchenko wrote: > On Fri, Jul 31, 2020 at 6:22 PM Vadym Kochan wrote: > > On Mon, Jul 27, 2020 at 03:59:13PM +0300, Andy Shevchenko wrote: > > > On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan > > > wrote: > > ... > > > > > Signed-off-by:

[PATCH bpf-next] selftests/bpf: fix spurious test failures in core_retro selftest

core_retro selftest uses BPF program that's triggered on sys_enter system-wide, but has no protection from some unrelated process doing syscall while selftest is running. This leads to occasional test failures with unexpected PIDs being returned. Fix that by filtering out all processes that are not

Re: [PATCH v2] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

Thank you for your thorough review comment! On Fri, Jul 31, 2020 at 7:13 AM Willem de Bruijn wrote: > > Thanks for fixing a kernel panic. The existing line was added recently > in commit 9dc829a135fb ("drivers/net/wan/lapbether: Fixed the value of > hard_header_len"). I assume a kernel with that

Re: [net-next 0/4] devlink flash update overwrite mask

On 7/30/2020 5:39 PM, Jakub Kicinski wrote: > LGTM, > > minor suggestions: > - could you add opt-in support flags to struct devlink_ops, a'la >ethtool_ops->supported_coalesce_params so that you don't have to >modify all drivers to reject unsupported things? Sure that makes sense. >

Re: [PATCH v2 0/3]

On Fri, 31 Jul 2020 23:57:19 +0530 Rakesh Pillai wrote: > The history recording will be compiled only if > ATH10K_DEBUG is enabled, and also enabled via > the module parameter. Once the history recording > is enabled via module parameter, it can be enabled > or disabled runtime via debugfs. Have y

Re: [PATCH v2 net-next 08/11] sfc_ef100: statistics gathering

On Fri, 31 Jul 2020 14:00:24 +0100 Edward Cree wrote: > + core_stats->rx_packets = stats[EF100_STAT_port_rx_packets]; > + core_stats->tx_packets = stats[EF100_STAT_port_tx_packets]; > + core_stats->rx_bytes = stats[EF100_STAT_port_rx_bytes]; > + core_stats->tx_bytes = stats[EF100_ST

Re: KASAN: slab-out-of-bounds Read in qrtr_endpoint_post (2)

syzbot has bisected this issue to: commit e42671084361302141a09284fde9bbc14fdd16bf Author: Manivannan Sadhasivam Date: Thu May 7 12:53:06 2020 + net: qrtr: Do not depend on ARCH_QCOM bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12a8076c90 start commit: 83bdc727 r

Re: [PATCH v2 net-next 03/11] sfc_ef100: read Design Parameters at probe time

On Fri, 31 Jul 2020 13:58:35 +0100 Edward Cree wrote: > + default: > + /* Host interface says "Drivers should ignore design parameters > + * that they do not recognise." > + */ > + netif_info(efx, probe, efx->net_dev, > +

[PATCH v3 net-next 0/3] ionic txrx updates

These are a few patches to do some cleanup in the packet handling and give us more flexibility in tuning performance by allowing us to put Tx handling on separate interrupts when it makes sense for particular traffic loads. v3: simplified queue count change logging, removed unnecessary check f

[PATCH v3 net-next 2/3] ionic: tx separate servicing

We give the tx clean path its own budget and service routine in order to give a little more leeway to be more aggressive, and in preparation for coming changes. We've found this gives us a little better performance in some packet processing scenarios without hurting other scenarios. Signed-off-by

[PATCH v3 net-next 3/3] ionic: separate interrupt for Tx and Rx

Add the capability to split the Tx queues onto their own interrupts with their own napi contexts. This gives the opportunity for more direct control of Tx interrupt handling, such as CPU affinity and interrupt coalescing, useful for some traffic loads. v2: use ethtool -L, not a vendor specific pr

[PATCH v3 net-next 1/3] ionic: use fewer firmware doorbells on rx fill

We really don't need to hit the Rx queue doorbell so many times, we can wait to the end and cause a little less thrash. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/

Re: [PATCH net v2 5/5] fsl/fman: fix eth hash table allocation

On Fri, 31 Jul 2020 13:49:22 +0300 Florinel Iordache wrote: > Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") > > Signed-off-by: Florinel Iordache Please repost without the empty lines between these tags.

Re: [PATCH v4 net-next 04/10] qed: implement devlink info request

On Fri, 31 Jul 2020 08:53:55 +0300 Igor Russkikh wrote: > Here we return existing fw & mfw versions, we also fetch device's > serial number. > > The base device specific structure (qed_dev_info) was not directly > available to the base driver before. > Thus, here we create and store a private copy

Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

On Fri, Jul 31, 2020 at 06:54:04PM +, Asmaa Mnebhi wrote: Hi Asmaa Please don't send HTML obfusticated emails to mailing lists. > > +static int mlxbf_gige_mdio_read(struct mii_bus *bus, int phy_add, int > > > +phy_reg) { > > > + struct mlxbf_gige *priv = bus->priv; > > > +

Re: [PATCH net-next v2 1/2] hinic: add generating mailbox random index support

On Fri, 31 Jul 2020 09:56:41 +0800 Luo bin wrote: > add support to generate mailbox random id of VF to ensure that > mailbox messages PF received are from the correct VF. > > Signed-off-by: Luo bin > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c > b/drivers/net/ethernet/huawei/

Re: [PATCH v2 net-next 04/11] sfc_ef100: TX path for EF100 NICs

On Fri, 31 Jul 2020 13:59:04 +0100 Edward Cree wrote: > +static inline efx_oword_t *ef100_tx_desc(struct efx_tx_queue *tx_queue, > + unsigned int index) Does this static inline make any difference? You know the general policy... > +{ > + if (likely(tx_que

RE: [PATCH v2 net-next] mscc: Add LCPLL Reset to VSC8574 Family of phy drivers

Thanks David and Florian, see below. > On 7/30/20 4:36 PM, David Miller wrote: > > From: Bryan Whitehead > > Date: Mon, 27 Jul 2020 13:18:28 -0400 > > > >> @@ -929,6 +929,77 @@ static bool vsc8574_is_serdes_init(struct > >> phy_device *phydev) } > >> > >> /* bus->mdio_lock should be locked when

Re: [PATCH v2 0/3]

On 7/31/20 11:27 AM, Rakesh Pillai wrote: > The history recording will be compiled only if > ATH10K_DEBUG is enabled, and also enabled via > the module parameter. Once the history recording > is enabled via module parameter, it can be enabled > or disabled runtime via debugfs. Why not use trace pr

Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

> +static int mlxbf_gige_mdio_read(struct mii_bus *bus, int phy_add, int > phy_reg) > +{ > + struct mlxbf_gige *priv = bus->priv; > + u32 cmd; > + u32 ret; Here and in write, please check if it is a C45 transaction request and return -EOPNOTSUPP. Andrew

Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

> +config MLXBF_GIGE > + tristate "Mellanox Technologies BlueField Gigabit Ethernet support" > + depends on (ARM64 || COMPILE_TEST) && ACPI && INET > + select PHYLIB > + help > + The second generation BlueField SoC from Mellanox Technologies > + supports an out-of-band G

Re: [PATCH v2 1/3] ath10k: Add history for tracking certain events

On 7/31/20 11:27 AM, Rakesh Pillai wrote: Add history for tracking the below events - register read - register write - IRQ trigger - NAPI poll - CE service - WMI cmd - WMI event - WMI tx completion This will help in debugging any crash or any improper behaviour. Tested-on: WCN3990 hw1.0 SNOC WL

Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

On Wed, Jul 29, 2020 at 02:29:15PM -0400, David Thompson wrote: Hi David > +static void mlxbf_gige_get_pauseparam(struct net_device *netdev, > + struct ethtool_pauseparam *pause) > +{ > + pause->autoneg = AUTONEG_ENABLE; > + pause->rx_pause = 1; > + p

Re: [PATCH v2] ravb: Fixed the problem that rmmod can not be done

On 7/30/20 1:01 PM, Yuusuke Ashizuka wrote: CCing DaveM (as you should have done from the start)... > ravb is a module driver, but I cannot rmmod it after insmod it. > ravb does mdio_init() at the time of probe, and module->refcnt is incremented > by alloc_mdio_bitbang() called after that. > T

[PATCH v2 3/3] ath10k: Add debugfs support to enable event history

Add the support to enable/disable the recording of debug events history. The enable/disable of the history from debugfs will not make any affect if its not enabled via module parameter. Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 Signed-off-by: Rakesh Pillai --- drivers/net/

[PATCH v2 bpf-next 5/5] tools/bpftool: add documentation and bash-completion for `link detach`

Add info on link detach sub-command to man page. Add detach to bash-completion as well. Acked-by: Song Liu Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/Documentation/bpftool-link.rst | 8 tools/bpf/bpftool/bash-completion/bpftool| 4 ++-- 2 files changed, 10 insertions(

  1   2   3   >