RE: [PATCH net-next] net: Enabled MPLS support for devices of type ARPHRD_NONE.

2020-07-26 Thread Varghese, Martin (Nokia - IN/Bangalore)
>> From: Martin Varghese >> >> This change enables forwarding of MPLS packets from bareudp tunnel >> device which is of type ARPHRD_NONE. >> >> Signed-off-by: Martin Varghese > This restriction looks just like a massive guessing game. > What is needed by MPLS by a device specifically, and ca

Re: WARNING in xfrm_policy_insert

2020-07-26 Thread Xin Long
On Mon, Jul 27, 2020 at 4:11 AM syzbot wrote: > > syzbot suspects this issue was fixed by commit: > > commit ed17b8d377eaf6b4a01d46942b4c647378a79bdd > Author: Xin Long > Date: Mon May 25 05:53:37 2020 + > > xfrm: fix a warning in xfrm_policy_insert_list > > bisection log: https://syzk

Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing

2020-07-26 Thread Luciano Coelho
On Sun, 2020-07-26 at 21:11 +0300, Kalle Valo wrote: > Wolfram Sang writes: > > > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote: > > > Missing this firmware is not fatal, my wifi card still works. Even more, > > > I couldn't find any documentation what it is or where to get it. So,

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-07-26 Thread Pkshih
On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote: > Make these statements a little simpler. > > Signed-off-by: Joe Perches > --- >  drivers/net/wireless/realtek/rtlwifi/base.c   | 14 +-- >  .../rtlwifi/btcoexist/halbtc8192e2ant.c   | 23 ++- >  .../rtlwifi/btcoexist

Re: [RFC PATCH v2 03/21] mm: Allow DMA mapping of pages which are not online

2020-07-26 Thread Christoph Hellwig
On Sun, Jul 26, 2020 at 10:28:28PM -0700, Jonathan Lemon wrote: > Change the system RAM check from 'valid' to 'online', so dummy > pages which refer to external DMA resources can be mapped. NAK. This looks completely bogus. Maybe you do have a good reason somewhere (although I doubt it), but th

Re: [PATCH] rtlwifi: core: use eth_broadcast_addr() to assign broadcast

2020-07-26 Thread Pkshih
On Mon, 2020-07-27 at 02:16 +, Xu Wang wrote: > This patch is to use eth_broadcast_addr() to assign broadcast address > insetad of memcpy(). > > Signed-off-by: Xu Wang > --- >  drivers/net/wireless/realtek/rtlwifi/core.c | 3 +-- >  1 file changed, 1 insertion(+), 2 deletions(-) > > diff --gi

Re: linux-next: build failure after merge of the bluetooth tree

2020-07-26 Thread Christoph Hellwig
The fixup looks good to me, thanks.

Re: [PATCH] [net/ipv6] ip6_output: Add ipv6_pinfo null check

2020-07-26 Thread kernel test robot
Hi Gaurav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on sparc-next/master] [also build test WARNING on ipvs/master linus/master v5.8-rc7 next-20200724] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we sugge

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-26 Thread B K Karthik
On Mon, Jul 27, 2020 at 1:37 AM Cong Wang wrote: > > On Sat, Jul 25, 2020 at 11:12 PM B K Karthik wrote: > > > > On Sun, Jul 26, 2020 at 11:05 AM Cong Wang wrote: > > > > > > On Sat, Jul 25, 2020 at 8:09 PM B K Karthik > > > wrote: > > > > @@ -103,10 +103,10 @@ static int __xfrm6_tunnel_spi_ch

Question Print Formatting iproute2

2020-07-26 Thread Briana Oursler
I have a patch I've written to address a format specifier change that breaks some tests in tc-testing, but I wanted to ask about the change and for some guidance with respect to how formatters are approached in iproute2. On a recent run of tdc tests I ran ./tdc.py -c qdisc and found: 1..91 not o

RE: [PATCH v13 2/9] arm/arm64: KVM: Advertise KVM UID to guests via SMCCC

2020-07-26 Thread Jianyong Wu
Hi Will, > -Original Message- > From: Jianyong Wu > Sent: Friday, June 19, 2020 9:01 PM > To: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; > t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com; > m...@kernel.org; richardcoch...@gmail.com; Mark Ru

linux-next: build failure after merge of the bluetooth tree

2020-07-26 Thread Stephen Rothwell
Hi all, After merging the bluetooth tree, today's linux-next build (arm multi_v7_defconfig) failed like this: net/bluetooth/sco.c: In function 'sco_sock_setsockopt': net/bluetooth/sco.c:862:3: error: cannot convert to a pointer type 862 | if (get_user(opt, (u32 __user *)optval)) { | ^

[PATCH] [net/ipv6] ip6_output: Add ipv6_pinfo null check

2020-07-26 Thread Gaurav Singh
ipv6_pinfo is initlialized by inet6_sk() which returns NULL. Hence it can cause segmentation fault. Fix this by adding a NULL check. Signed-off-by: Gaurav Singh --- net/ipv6/ip6_output.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_output.c b/net/ipv6/

[PATCH net-next 04/10] bnxt_en: Refactor statistics code and structures.

2020-07-26 Thread Michael Chan
The driver manages multiple statistics structures of different sizes. They are all allocated, freed, and handled practically the same. Define a new bnxt_stats_mem structure and common allocation and free functions for all staistics memory blocks. Reviewed-by: Vasundhara Volam Signed-off-by: Mich

[PATCH net-next 08/10] bnxt_en: Accumulate all counters.

2020-07-26 Thread Michael Chan
Now that we have the infrastructure in place, add the new function bnxt_accumulate_all_stats() to periodically accumulate and check for counter rollover of all ring stats and port stats. A chip bug was also discovered that could cause some ring counters to become 0 during DMA. Workaround by ignor

[PATCH net-next 07/10] bnxt_en: Retrieve hardware masks for port counters.

2020-07-26 Thread Michael Chan
If supported by newer firmware, make the firmware call to query all the port counter masks. If not supported, assume 40-bit port counter masks. Reviewed-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 75 --- 1 file c

[PATCH net-next 06/10] bnxt_en: Retrieve hardware counter masks from firmware if available.

2020-07-26 Thread Michael Chan
Newer firmware has a new call HWRM_FUNC_QSTATS_EXT to retrieve the masks of all ring counters. Make this call when supported to initialize the hardware masks of all ring counters. If the call is not available, assume 48-bit ring counter masks on P5 chips. Reviewed-by: Vasundhara Volam Signed-of

[PATCH net-next 09/10] bnxt_en: Switch over to use the 64-bit software accumulated counters.

2020-07-26 Thread Michael Chan
Now we can report all the full 64-bit CPU endian software accumulated counters instead of the hw counters, some of which may be less than 64-bit wide. Define the necessary macros to access the software counters. Reviewed-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet

[PATCH net-next 10/10] bnxt_en: Add support for 'ethtool -d'

2020-07-26 Thread Michael Chan
From: Vasundhara Volam Add support to dump PXP registers and PCIe statistics. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 32 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 +++ drivers/net/ethernet/

[PATCH net-next 00/10] bnxt_en update.

2020-07-26 Thread Michael Chan
This patchset removes the PCIe histogram and other debug register data from ethtool -S. The removed data are not counters and they have very large and constantly fluctuating values that are not suitable for the ethtool -S decimal counter display. The rest of the patches implement counter rollover

[PATCH net-next 05/10] bnxt_en: Allocate additional memory for all statistics blocks.

2020-07-26 Thread Michael Chan
Some of these DMAed hardware counters are not full 64-bit counters and so we need to accumulate them as they overflow. Allocate copies of these DMA statistics memory blocks with the same size for accumulation. The hardware counter widths are also counter specific so we allocate memory for masks t

[PATCH net-next 03/10] bnxt_en: Use macros to define port statistics size and offset.

2020-07-26 Thread Michael Chan
The port statistics structures have hard coded padding and offset. Define macros to make this look cleaner. Reviewed-by: Pavan Chebbi Reviewed-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 drivers/net/ethernet/broadcom/bnxt/bnxt.h

[PATCH net-next 02/10] bnxt_en: Update firmware interface to 1.10.1.54.

2020-07-26 Thread Michael Chan
Main changes are 200G support and fixing the definitions of discard and error counters to match the hardware definitions. Because the HWRM_PORT_PHY_QCFG message size has now exceeded the max. encapsulated response message size of 96 bytes from the PF to the VF, we now need to cap this message to 9

[PATCH net-next 01/10] bnxt_en: Remove PCIe non-counters from ethtool statistics

2020-07-26 Thread Michael Chan
From: Vasundhara Volam Remove PCIe non-counters display from ethtool statistics, as they are not simple counters but register dump. The next few patches will add logic to detect counter roll-over and it won't work with these PCIe non-counters. There will be a follow up patch to get PCIe informa

RE: [EXT] Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Andy Duan
From: Chris Healy Sent: Monday, July 27, 2020 11:01 AM > It appears quite a few boards were affected by this micrel PHY driver change: > > 2ccb0161a0e9eb06f538557d38987e436fc39b8d > 80bf72598663496d08b3c0231377db6a99d7fd68 > 2de00450c0126ec8838f72157577578e85cae5d8 > 820f8a870f6575acda1bf7f1a03c7

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Chris Healy
It appears quite a few boards were affected by this micrel PHY driver change: 2ccb0161a0e9eb06f538557d38987e436fc39b8d 80bf72598663496d08b3c0231377db6a99d7fd68 2de00450c0126ec8838f72157577578e85cae5d8 820f8a870f6575acda1bf7f1a03c701c43ed5d79 I just updated the phy-mode with my board from rgmii to

RE: [EXT] Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Andy Duan
From: Chris Healy Sent: Monday, July 27, 2020 10:40 AM > Actually, I was a little quick to say it went from broken to working. > > With net-next, I'm getting CRC errors on 100% of inbound packets. > With bcf3440c6dd78bfe5836ec0990fe36d7b4bb7d20 reverted, I drop down to a > 1% error rate. > > Thi

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Chris Healy
Actually, I was a little quick to say it went from broken to working. With net-next, I'm getting CRC errors on 100% of inbound packets. With bcf3440c6dd78bfe5836ec0990fe36d7b4bb7d20 reverted, I drop down to a 1% error rate. This very much feels like a KSZ9031 RGMII timing issue to me... On Sun,

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Laurent Pinchart
Hi Chris, On Sun, Jul 26, 2020 at 07:35:51PM -0700, Chris Healy wrote: > Hi Laurent, > > I have the exact same copper PHY. I just reverted a patch specific to > this PHY and went from broken to working. Give this a try: > > git revert bcf3440c6dd78bfe5836ec0990fe36d7b4bb7d20 Reverting this on

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Laurent Pinchart
Hi Chris, On Sun, Jul 26, 2020 at 07:13:20PM -0700, Chris Healy wrote: > On Sun, Jul 26, 2020 at 7:06 PM Laurent Pinchart wrote: > > On Mon, Jul 27, 2020 at 04:24:02AM +0300, Laurent Pinchart wrote: > >> On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > >>> This reverts commit 29ae6bd

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Chris Healy
Hi Laurent, I have the exact same copper PHY. I just reverted a patch specific to this PHY and went from broken to working. Give this a try: git revert bcf3440c6dd78bfe5836ec0990fe36d7b4bb7d20 Regards, Chris On Sun, Jul 26, 2020 at 7:33 PM Laurent Pinchart wrote: > > Hi Andrew, > > On Mon,

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Laurent Pinchart
Hi Andrew, On Mon, Jul 27, 2020 at 04:14:32AM +0200, Andrew Lunn wrote: > On Mon, Jul 27, 2020 at 05:06:31AM +0300, Laurent Pinchart wrote: > > On Mon, Jul 27, 2020 at 04:24:02AM +0300, Laurent Pinchart wrote: > > > On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > > > > This reverts

[PATCH] mwifiex: 11n_rxreorder: Remove unnecessary cast in kfree()

2020-07-26 Thread Xu Wang
Remove unnecassary casts in the argument to kfree. Signed-off-by: Xu Wang --- drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c b/drivers/net/wireless/marvell/mwifiex/11n_

RE: [EXT] Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Andy Duan
From: Chris Healy Sent: Monday, July 27, 2020 10:13 AM > On Sun, Jul 26, 2020 at 7:06 PM Laurent Pinchart > wrote: > > > > On Mon, Jul 27, 2020 at 04:24:02AM +0300, Laurent Pinchart wrote: > > > On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > > > > This reverts commit 29ae6bd1b0d8a

[PATCH] rtlwifi: core: use eth_broadcast_addr() to assign broadcast

2020-07-26 Thread Xu Wang
This patch is to use eth_broadcast_addr() to assign broadcast address insetad of memcpy(). Signed-off-by: Xu Wang --- drivers/net/wireless/realtek/rtlwifi/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wirel

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Andrew Lunn
On Mon, Jul 27, 2020 at 05:06:31AM +0300, Laurent Pinchart wrote: > On Mon, Jul 27, 2020 at 04:24:02AM +0300, Laurent Pinchart wrote: > > On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > > > This reverts commit 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef. > > > > > > The commit breaks e

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Chris Healy
On Sun, Jul 26, 2020 at 7:06 PM Laurent Pinchart wrote: > > On Mon, Jul 27, 2020 at 04:24:02AM +0300, Laurent Pinchart wrote: > > On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > > > This reverts commit 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef. > > > > > > The commit breaks ethernet

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Laurent Pinchart
On Mon, Jul 27, 2020 at 04:24:02AM +0300, Laurent Pinchart wrote: > On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > > This reverts commit 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef. > > > > The commit breaks ethernet function on i.MX6SX, i.MX7D, i.MX8MM, > > i.MX8MQ, and i.MX8QXP plat

[PATCH] netfilter: ip6tables: Remove redundant null checks

2020-07-26 Thread Gaurav Singh
netfilter: ip6tables: Remove redundant null checks Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_ah.c | 3 +-- net/ipv6/netfilter/ip6t_frag.c | 3 +-- net/ipv6/netfilter/ip6t_hbh.c | 3 +-- net/ipv6/netfilter/ip6t_rt.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) dif

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Andrew Lunn
On Mon, Jul 27, 2020 at 04:23:54AM +0300, Laurent Pinchart wrote: > Hi Fugang, > > On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > > This reverts commit 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef. > > > > The commit breaks ethernet function on i.MX6SX, i.MX7D, i.MX8MM, > > i.MX8MQ, a

Re: [RESENT PATCH net--stat 1/1] net: ethernet: fec: Revert "net: ethernet: fec: Replace interrupt driven MDIO with polled IO"

2020-07-26 Thread Laurent Pinchart
Hi Fugang, On Mon, Apr 27, 2020 at 10:08:04PM +0800, Fugang Duan wrote: > This reverts commit 29ae6bd1b0d8a57d7c00ab12cbb949fc41986eef. > > The commit breaks ethernet function on i.MX6SX, i.MX7D, i.MX8MM, > i.MX8MQ, and i.MX8QXP platforms. Boot yocto system by NFS mounting > rootfs will be failed

Re: [PATCH RFC net-next] net: phy: add Marvell PHY PTP support

2020-07-26 Thread Russell King - ARM Linux admin
On Tue, Jul 14, 2020 at 05:26:28PM +0100, Russell King wrote: > The driver takes inspiration from the Marvell 88E6xxx DSA and DP83640 > drivers. The hardware is very similar to the implementation found in > the 88E6xxx DSA driver, but the access methods are very different, > although it may be pos

[net-next PATCH 1/2 v2] net: dsa: rtl8366: Fix VLAN semantics

2020-07-26 Thread Linus Walleij
The RTL8366 would not handle adding new members (ports) to a VLAN: the code assumed that ->port_vlan_add() was only called once for a single port. When intializing the switch with .configure_vlan_while_not_filtering set to true, the function is called numerous times for adding all ports to VLAN1, w

[net-next PATCH 2/2 v2] net: dsa: rtl8366: Fix VLAN set-up

2020-07-26 Thread Linus Walleij
Alter the rtl8366_vlan_add() to call rtl8366_set_vlan() inside the loop that goes over all VIDs since we now properly support calling that function more than once. Augment the loop to postincrement as this is more intuitive. The loop moved past the last VID but called rtl8366_set_vlan() with the p

[net-next PATCH 0/2 v2] RTL8366 VLAN callback fixes

2020-07-26 Thread Linus Walleij
While we are pondering how to make the core set up the VLANs the right way, let's merge the uncontroversial fixes. Linus Walleij (2): net: dsa: rtl8366: Fix VLAN semantics net: dsa: rtl8366: Fix VLAN set-up drivers/net/dsa/rtl8366.c | 35 --- 1 file changed, 2

Re: [net-next v3 2/6] net: marvell: prestera: Add PCI interface support

2020-07-26 Thread Vadym Kochan
Hi Andy, On Sun, Jul 26, 2020 at 01:32:19PM +0300, Andy Shevchenko wrote: > On Sat, Jul 25, 2020 at 6:10 PM Vadym Kochan wrote: > > > > Add PCI interface driver for Prestera Switch ASICs family devices, which > > provides: > > > > - Firmware loading mechanism > > - Requests & events handl

Re: KMSAN: uninit-value in strstr

2020-07-26 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:93f54a72 instrumented.h: fix KMSAN support git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=15692a7490 kernel config: https://syzkaller.appspot.com/x/.

Re: IPv6: proxy_ndp to a network range

2020-07-26 Thread Pali Rohár
Hello, I would like to brisk up this thread again! On Monday 09 May 2016 16:51:10 Alexander Aring wrote: > Hi, > > On Mon, May 09, 2016 at 01:46:13AM -0700, H. Peter Anvin wrote: > > On May 9, 2016 1:39:08 AM PDT, Alexander Aring wrote: > > >Hi, > > > > > >On Mon, May 09, 2016 at 01:06:51AM -070

Re: phc2sys - does it work?

2020-07-26 Thread Russell King - ARM Linux admin
On Sun, Jul 26, 2020 at 11:05:51AM -0700, Richard Cochran wrote: > On Sun, Jul 26, 2020 at 12:01:05PM +0100, Russell King - ARM Linux admin > wrote: > > Another solution would be to avoid running NTP on any machine intending > > to be the source of PTP time on a network, but that then brings up th

Re: WARNING in xfrm_policy_insert

2020-07-26 Thread syzbot
syzbot suspects this issue was fixed by commit: commit ed17b8d377eaf6b4a01d46942b4c647378a79bdd Author: Xin Long Date: Mon May 25 05:53:37 2020 + xfrm: fix a warning in xfrm_policy_insert_list bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1774b9df10 start commit:

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-26 Thread Cong Wang
On Sat, Jul 25, 2020 at 11:12 PM B K Karthik wrote: > > On Sun, Jul 26, 2020 at 11:05 AM Cong Wang wrote: > > > > On Sat, Jul 25, 2020 at 8:09 PM B K Karthik wrote: > > > @@ -103,10 +103,10 @@ static int __xfrm6_tunnel_spi_check(struct net > > > *net, u32 spi) > > > { > > > struct xfrm

Re: phc2sys - does it work?

2020-07-26 Thread Vladimir Oltean
On Sun, Jul 26, 2020 at 12:01:05PM +0100, Russell King - ARM Linux admin wrote: > > Another solution would be to avoid running NTP on any machine intending > to be the source of PTP time on a network, but that then brings up the > problem that you can't synchronise the PTP time source to a referen

Re: [PATCH] net: dev: Add API to check net_dev readiness

2020-07-26 Thread Andrew Lunn
On Sun, Jul 26, 2020 at 10:37:54PM +0300, Ilia Lin wrote: > From: Ilia Lin > > Add an API that returns true, if the net_dev_init was already called, > and the driver was initialized. > > Some early drivers, that are initialized during the subsys_initcall > may try accessing the net_dev or NAPI A

[PATCH] net: dev: Add API to check net_dev readiness

2020-07-26 Thread Ilia Lin
From: Ilia Lin Add an API that returns true, if the net_dev_init was already called, and the driver was initialized. Some early drivers, that are initialized during the subsys_initcall may try accessing the net_dev or NAPI APIs before the net_dev_init, and will encounter a kernel bug. This API p

Re: question about using UDP GSO in Linux kernel 4.19

2020-07-26 Thread Willem de Bruijn
On Sun, Jul 26, 2020 at 2:18 PM Han wrote: > > On Sun, Jul 26, 2020 at 6:42 AM Willem de Bruijn > wrote: > > > > On Sat, Jul 25, 2020 at 7:08 PM Han wrote: > > > > > > My apologies if this is not the right place to ask this question. > > > > > > I'm trying to use UDP GSO to improve the throughpu

[PATCH net-next 2/2] net/smc: unique reason code for exceeded max dmb count

2020-07-26 Thread Karsten Graul
When the maximum dmb buffer limit for an ism device is reached no more dmb buffers can be registered. When this happens the reason code is set to SMC_CLC_DECL_MEM indicating out-of-memory. This is the same reason code that is used when no memory could be allocated for the new dmb buffer. This is co

[PATCH net-next 0/2] net/smc: show unique rsn code for exceeded max dmb count

2020-07-26 Thread Karsten Graul
Resolve some confusion at the user side when the reason code shows out-of-memory but actually there is enough memory left. Karsten Graul (2): s390/ism: indicate correct error reason in ism_alloc_dmb() net/smc: unique reason code for exceeded max dmb count drivers/s390/net/ism_drv.c | 2 +-

[PATCH net-next 1/2] s390/ism: indicate correct error reason in ism_alloc_dmb()

2020-07-26 Thread Karsten Graul
When the ism driver allocates a new dmb in ism_alloc_dmb() it must first check for and reserve a slot in the sba bitmap. When find_next_zero_bit() finds no free slot then the return code is -ENOMEM. This code conflicts with the error when the alloc() fails later in the code. As a result of that the

Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing

2020-07-26 Thread Wolfram Sang
On Sun, Jul 26, 2020 at 09:11:25PM +0300, Kalle Valo wrote: > Wolfram Sang writes: > > > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote: > >> Missing this firmware is not fatal, my wifi card still works. Even more, > >> I couldn't find any documentation what it is or where to get it

Re: [RFC] net: add support for threaded NAPI polling

2020-07-26 Thread Felix Fietkau
On 2020-07-26 19:58, Eric Dumazet wrote: > > > On 7/26/20 10:19 AM, Felix Fietkau wrote: >> On 2020-07-26 18:49, Eric Dumazet wrote: >>> On 7/26/20 9:31 AM, Felix Fietkau wrote: For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI poll function does not pe

Re: question about using UDP GSO in Linux kernel 4.19

2020-07-26 Thread Han
On Sun, Jul 26, 2020 at 6:42 AM Willem de Bruijn wrote: > > On Sat, Jul 25, 2020 at 7:08 PM Han wrote: > > > > My apologies if this is not the right place to ask this question. > > > > I'm trying to use UDP GSO to improve the throughput. My testing shows > > that UDP GSO works with the local serv

Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing

2020-07-26 Thread Kalle Valo
Wolfram Sang writes: > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote: >> Missing this firmware is not fatal, my wifi card still works. Even more, >> I couldn't find any documentation what it is or where to get it. So, I >> don't think the users should be notified if it is missing.

Re: phc2sys - does it work?

2020-07-26 Thread Richard Cochran
On Sun, Jul 26, 2020 at 12:01:05PM +0100, Russell King - ARM Linux admin wrote: > Another solution would be to avoid running NTP on any machine intending > to be the source of PTP time on a network, but that then brings up the > problem that you can't synchronise the PTP time source to a reference

Re: [RFC] net: add support for threaded NAPI polling

2020-07-26 Thread Eric Dumazet
On 7/26/20 10:19 AM, Felix Fietkau wrote: > On 2020-07-26 18:49, Eric Dumazet wrote: >> On 7/26/20 9:31 AM, Felix Fietkau wrote: >>> For some drivers (especially 802.11 drivers), doing a lot of work in the >>> NAPI >>> poll function does not perform well. Since NAPI poll is bound to the CPU it

Re: [RFC] net: add support for threaded NAPI polling

2020-07-26 Thread Felix Fietkau
On 2020-07-26 18:49, Eric Dumazet wrote: > On 7/26/20 9:31 AM, Felix Fietkau wrote: >> For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI >> poll function does not perform well. Since NAPI poll is bound to the CPU it >> was scheduled from, we can easily end up with a few

Re: [PATCH net-next 1/3] udp_tunnel: allow to turn off path mtu discovery on encap sockets

2020-07-26 Thread Stefano Brivio
On Sun, 19 Jul 2020 21:19:44 -0600 David Ahern wrote: > On 7/19/20 3:49 PM, Stefano Brivio wrote: > >> > >> With this test case, the lookup fails: > >> > >> [ 144.689378] vxlan: vxlan_xmit_one: dev vxlan_a 10.0.1.1/57864 -> > >> 10.0.0.0/4789 len 5010 gw 10.0.1.2 > >> [ 144.692755] vxlan: skb_t

Re: [RFC iproute2] ip: bridge: use -human to convert time-related values to seconds

2020-07-26 Thread Vladimir Oltean
On Sun, Jul 26, 2020 at 07:34:06PM +0300, Nikolay Aleksandrov wrote: > On 26/07/2020 19:21, Vladimir Oltean wrote: > > Hi Nikolay, > > > > On Sun, Jul 26, 2020 at 01:43:23PM +0300, Nikolay Aleksandrov wrote: > >> We have been printing and expecting the time-related bridge options > >> scaled by US

Re: [RFC] net: add support for threaded NAPI polling

2020-07-26 Thread Eric Dumazet
On 7/26/20 9:31 AM, Felix Fietkau wrote: > For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI > poll function does not perform well. Since NAPI poll is bound to the CPU it > was scheduled from, we can easily end up with a few very busy CPUs spending > most of their tim

Re: [RFC iproute2] ip: bridge: use -human to convert time-related values to seconds

2020-07-26 Thread Nikolay Aleksandrov
On 26/07/2020 19:21, Vladimir Oltean wrote: > Hi Nikolay, > > On Sun, Jul 26, 2020 at 01:43:23PM +0300, Nikolay Aleksandrov wrote: >> We have been printing and expecting the time-related bridge options >> scaled by USER_HZ which is confusing to users and hasn't been documented >> anywhere. Unfortu

[RFC] net: add support for threaded NAPI polling

2020-07-26 Thread Felix Fietkau
For some drivers (especially 802.11 drivers), doing a lot of work in the NAPI poll function does not perform well. Since NAPI poll is bound to the CPU it was scheduled from, we can easily end up with a few very busy CPUs spending most of their time in softirq/ksoftirqd and some idle ones. Introduc

RE: [RFC 1/7] mac80211: Add check for napi handle before WARN_ON

2020-07-26 Thread Rakesh Pillai
> -Original Message- > From: Rakesh Pillai > Sent: Friday, July 24, 2020 11:51 AM > To: 'Johannes Berg' ; > 'ath...@lists.infradead.org' > Cc: 'linux-wirel...@vger.kernel.org' ; > 'linux-ker...@vger.kernel.org' ; > 'kv...@codeaurora.org' ; 'da...@davemloft.net' > ; 'k...@kernel.org' ;

Re: [RFC iproute2] ip: bridge: use -human to convert time-related values to seconds

2020-07-26 Thread Vladimir Oltean
Hi Nikolay, On Sun, Jul 26, 2020 at 01:43:23PM +0300, Nikolay Aleksandrov wrote: > We have been printing and expecting the time-related bridge options > scaled by USER_HZ which is confusing to users and hasn't been documented > anywhere. Unfortunately that has been the case for years and people wh

Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing

2020-07-26 Thread Wolfram Sang
On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote: > Missing this firmware is not fatal, my wifi card still works. Even more, > I couldn't find any documentation what it is or where to get it. So, I > don't think the users should be notified if it is missing. If you browse > the net, you

[PATCH net-next v2] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-26 Thread Jonathan McDowell
This adds full 802.1q VLAN support to the qca8k, allowing the use of vlan_filtering and more complicated bridging setups than allowed by basic port VLAN support. Tested with a number of untagged ports with separate VLANs and then a trunk port with all the VLANs tagged on it. v2: - Return sensible

Re: question about using UDP GSO in Linux kernel 4.19

2020-07-26 Thread Willem de Bruijn
On Sat, Jul 25, 2020 at 7:08 PM Han wrote: > > My apologies if this is not the right place to ask this question. > > I'm trying to use UDP GSO to improve the throughput. My testing shows > that UDP GSO works with the local server (i.e. loopback interface) but > fails with a remote server (in WLAN,

Re: [PATCH 11/20] dt-bindings: i2c: renesas,i2c: Document r8a774e1 support

2020-07-26 Thread Wolfram Sang
On Wed, Jul 15, 2020 at 12:09:01PM +0100, Lad Prabhakar wrote: > Document i2c controller for RZ/G2H (R8A774E1) SoC, which is compatible > with R-Car Gen3 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Applied to for-next, thanks! signature.asc Descript

Re: [PATCH 12/20] dt-bindings: i2c: renesas,iic: Document r8a774e1 support

2020-07-26 Thread Wolfram Sang
On Wed, Jul 15, 2020 at 12:09:02PM +0100, Lad Prabhakar wrote: > Document IIC controller for RZ/G2H (R8A774E1) SoC, which is compatible > with R-Car Gen3 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Applied to for-next, thanks! signature.asc Descript

Re: fentry/fexit attach to EXT type XDP program does not work

2020-07-26 Thread Jiri Olsa
On Tue, Jun 09, 2020 at 10:52:34AM +0200, Eelco Chaudron wrote: SNIP > > >libbpf: failed to load object 'test_xdp_bpf2bpf' > > >libbpf: failed to load BPF skeleton 'test_xdp_bpf2bpf': -4007 > > >test_xdp_fentry_ext:FAIL:__load ftrace skeleton failed > > >#91 xdp_fentry_ext:FAIL >

[PATCH bpf-next] udp, bpf: Ignore connections in reuseport group after BPF sk lookup

2020-07-26 Thread Jakub Sitnicki
When BPF sk lookup invokes reuseport handling for the selected socket, it should ignore the fact that reuseport group can contain connected UDP sockets. With BPF sk lookup this is not relevant as we are not scoring sockets to find the best match, which might be a connected UDP socket. Fix it by un

[PATCH 4/7] net/mlx5: drop unnecessary list_empty

2020-07-26 Thread Julia Lawall
list_for_each_entry is able to handle an empty list. The only effect of avoiding the loop is not initializing the index variable. Drop list_empty tests in cases where these variables are not used. Note that list_for_each_entry is defined in terms of list_first_entry, which indicates that it should

[PATCH 2/7] sfc: drop unnecessary list_empty

2020-07-26 Thread Julia Lawall
list_for_each_safe is able to handle an empty list. The only effect of avoiding the loop is not initializing the index variable. Drop list_empty tests in cases where these variables are not used. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) @@ expression

[PATCH 7/7] ath: drop unnecessary list_empty

2020-07-26 Thread Julia Lawall
list_for_each_entry{_safe} is able to handle an empty list. The only effect of avoiding the loop is not initializing the index variable. Drop list_empty tests in cases where these variables are not used. Note that list_for_each_entry{_safe} is defined in terms of list_first_entry, which indicates

[PATCH 0/7] drop unnecessary list_empty

2020-07-26 Thread Julia Lawall
The various list iterators are able to handle an empty list. The only effect of avoiding the loop is not initializing some index variables. Drop list_empty tests in cases where these variables are not used. The semantic patch that makes these changes is as follows: (http://coccinelle.lip6.fr/) @

[RFC PATCH iproute2-next 0/3] Global per-type support for QP counters

2020-07-26 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This is complimentary part of kernel series [1] that extends netlink interface to allow automatic binding of QP counters based on their type, in very similar manner to already existing per-PID ability. Thanks [1] https://lore.kernel.org/lkml/20200702082933.424537-1-l.

[RFC PATCH iproute2-next 2/3] rdma: Add "PID" criteria support for statistic counter auto mode

2020-07-26 Thread Leon Romanovsky
From: Mark Zhang With this new criteria, QPs have different PIDs will be bound to different counters in auto mode. This can be used in combination with other criteria like "type". Examples: $ rdma statistic qp set link mlx5_2/1 auto pid on $ rdma statistic qp set link mlx5_2/1 auto type,pid on $

[RFC PATCH iproute2-next 1/3] rdma: update uapi headers

2020-07-26 Thread Leon Romanovsky
From: Mark Zhang Update rdma_netlink.h file upto kernel commit 7c97f3aded10 ("RDMA/counter: Add PID category support in auto mode") Signed-off-by: Mark Zhang Reviewed-by: Ido Kalir Signed-off-by: Leon Romanovsky --- rdma/include/uapi/rdma/rdma_netlink.h | 2 +- 1 file changed, 1 insertion(+)

[RFC PATCH iproute2-next 3/3] rdma: Document the new "pid" criteria for auto mode

2020-07-26 Thread Leon Romanovsky
From: Mark Zhang Document the new supported criteria of auto mode. Examples: $ rdma statistic qp set link mlx5_2/1 auto pid on $ rdma statistic qp set link mlx5_2/1 auto pid,type on Signed-off-by: Mark Zhang Reviewed-by: Ido Kalir Signed-off-by: Leon Romanovsky --- man/man8/rdma-statistic.8

RE: [RFC 0/7] Add support to process rx packets in thread

2020-07-26 Thread David Laight
From: Sebastian Gottschall > Sent: 25 July 2020 16:42 > >> i agree. i just can say that i tested this patch recently due this > >> discussion here. and it can be changed by sysfs. but it doesnt work for > >> wifi drivers which are mainly using dummy netdev devices. for this i > >> made a small pat

[PATCH] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

2020-07-26 Thread Xie He
In net/packet/af_packet.c, the function packet_snd first reserves a headroom of length (dev->hard_header_len + dev->needed_headroom). Then if the socket is a SOCK_DGRAM socket, it calls dev_hard_header, which calls dev->header_ops->create, to create the link layer header. If the socket is a SOCK_RA

Re: phc2sys - does it work?

2020-07-26 Thread Russell King - ARM Linux admin
On Sat, Jul 25, 2020 at 04:29:16PM +0300, Vladimir Oltean wrote: > Just a sanity check: do you have this patch? > https://github.com/richardcochran/linuxptp/commit/e0580929f451e685d92cd10d80b76f39e9b09a97 I did not, as I was running Debian stable's 1.9.2 version, whereas current git head for linux

[RFC iproute2] ip: bridge: use -human to convert time-related values to seconds

2020-07-26 Thread Nikolay Aleksandrov
We have been printing and expecting the time-related bridge options scaled by USER_HZ which is confusing to users and hasn't been documented anywhere. Unfortunately that has been the case for years and people who use ip-link are scaling the values themselves by now. In order to help anyone who want

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-26 Thread kernel test robot
when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/B-K-Karthik/net-ipv6-fix-use-after-free-Read-in-__xfrm6_tunnel_spi_lookup/20200726-111019 base: https://git.kernel.org/pub

Re: [net-next v3 2/6] net: marvell: prestera: Add PCI interface support

2020-07-26 Thread Andy Shevchenko
On Sat, Jul 25, 2020 at 6:10 PM Vadym Kochan wrote: > > Add PCI interface driver for Prestera Switch ASICs family devices, which > provides: > > - Firmware loading mechanism > - Requests & events handling to/from the firmware > - Access to the firmware on the bus level > > The firmware

Re: [PATCH] net: ipv6: fix slab-out-of-bounda Read in xfrm6_tunnel_alloc_spi

2020-07-26 Thread kernel test robot
/scm/linux/kernel/git/klassert/ipsec.git master config: x86_64-randconfig-r032-20200726 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 8bf4c1f4fb257774f66c8cda07adc6c5e8668326) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com

Re: KASAN: use-after-free Read in __smsc95xx_mdio_read

2020-07-26 Thread Greg KH
On Sun, Jul 26, 2020 at 02:57:05AM -0700, syzbot wrote: > syzbot suspects this issue was fixed by commit: > > commit 7e23ab72e73bc601b4cf2983382691d9f165c8d1 > Author: Ding Xiang > Date: Mon Mar 30 07:56:26 2020 + > > pinctrl: nomadik:remove unneeded variable > > bisection log: https

Re: KASAN: use-after-free Read in __smsc95xx_mdio_read

2020-07-26 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 7e23ab72e73bc601b4cf2983382691d9f165c8d1 Author: Ding Xiang Date: Mon Mar 30 07:56:26 2020 + pinctrl: nomadik:remove unneeded variable bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=13cfe3a090 start commit: 7ae

Re: [net-next v3 2/6] net: marvell: prestera: Add PCI interface support

2020-07-26 Thread Jiri Pirko
Sat, Jul 25, 2020 at 05:06:47PM CEST, vadym.koc...@plvision.eu wrote: >Add PCI interface driver for Prestera Switch ASICs family devices, which >provides: > >- Firmware loading mechanism >- Requests & events handling to/from the firmware >- Access to the firmware on the bus level > >The

Re: [net-next v3 4/6] net: marvell: prestera: Add ethtool interface support

2020-07-26 Thread Jiri Pirko
Sat, Jul 25, 2020 at 05:06:49PM CEST, vadym.koc...@plvision.eu wrote: >The ethtool API provides support for the configuration of the following >features: speed and duplex, auto-negotiation, MDI-x, forward error >correction, port media type. The API also provides information about the >port status,

Re: [net-next v3 3/6] net: marvell: prestera: Add basic devlink support

2020-07-26 Thread Jiri Pirko
Sat, Jul 25, 2020 at 05:06:48PM CEST, vadym.koc...@plvision.eu wrote: >Add very basic support for devlink interface: > >- driver name >- fw version >- devlink ports > >Signed-off-by: Vadym Kochan Reviewed-by: Jiri Pirko

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-26 Thread Felix Fietkau
On 2020-07-26 10:32, Hillf Danton wrote: > > On Sun, 26 Jul 2020 10:10:15 +0200 Felix Fietkau wrote: >> On 2020-07-26 03:22, Hillf Danton wrote: >> > >> > Feel free to do that. Is it likely for me to select a Cc? >> > >> Shall I use Signed-off-by: Hillf Danton ? > > s/Signed-off-by/Cc/ > >> Wh

  1   2   >