Re: mmotm 2020-07-20-19-06 uploaded (net/ipv6/ip6_vti.o)

2020-07-20 Thread Stephen Rothwell
Hi all, On Tue, 21 Jul 2020 16:54:24 +1000 Stephen Rothwell wrote: > > On Mon, 20 Jul 2020 23:09:34 -0700 Randy Dunlap wrote: > > > > on i386: > > > > ld: net/ipv6/ip6_vti.o: in function `vti6_rcv_tunnel': > > ip6_vti.c:(.text+0x2d11): undefined reference to `xfrm6_tunnel_spi_lookup' > > Ca

Re: mmotm 2020-07-20-19-06 uploaded (net/ipv6/ip6_vti.o)

2020-07-20 Thread Stephen Rothwell
Hi all, On Mon, 20 Jul 2020 23:09:34 -0700 Randy Dunlap wrote: > > on i386: > > ld: net/ipv6/ip6_vti.o: in function `vti6_rcv_tunnel': > ip6_vti.c:(.text+0x2d11): undefined reference to `xfrm6_tunnel_spi_lookup' Caused by commit 08622869ed3f ("ip6_vti: support IP6IP6 tunnel processing with .

Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones

2020-07-20 Thread Alexander A. Klimov
Am 21.07.20 um 08:05 schrieb Leon Romanovsky: On Mon, Jul 20, 2020 at 11:34:00PM +0200, Alexander A. Klimov wrote: Am 20.07.20 um 18:48 schrieb Leon Romanovsky: On Mon, Jul 20, 2020 at 08:36:35AM -0600, Jonathan Corbet wrote: On Mon, 20 Jul 2020 17:07:16 +0300 Leon Romanovsky wrote: Do

[PATCH v3] net: ethernet: ravb: exit if re-initialization fails in tx timeout

2020-07-20 Thread Yoshihiro Shimoda
According to the report of [1], this driver is possible to cause the following error in ravb_tx_timeout_work(). ravb e680.ethernet ethernet: failed to switch device to config mode This error means that the hardware could not change the state from "Operation" to "Configuration" while some tx a

[PATCH net 2/2] udp: Improve load balancing for SO_REUSEPORT.

2020-07-20 Thread Kuniyuki Iwashima
Currently, SO_REUSEPORT does not work well if connected sockets are in a UDP reuseport group. Then reuseport_has_conns() returns true and the result of reuseport_select_sock() is discarded. Also, unconnected sockets have the same score, hence only does the first unconnected socket in udp_hslot alw

Re: [PATCH] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

2020-07-20 Thread Xiongfeng Wang
Hi, On 2020/7/21 8:44, David Miller wrote: > From: Xiongfeng Wang > Date: Mon, 20 Jul 2020 19:17:49 +0800 > >> -return sprintf(buf, "%lu", trans_timeout); >> +return sprintf(buf, "%lu\n", trans_timeout); > > Better to replace it with 'fmt_ulong'. Thanks for your advice. I will change i

[PATCH net 1/2] udp: Copy has_conns in reuseport_grow().

2020-07-20 Thread Kuniyuki Iwashima
If an unconnected socket in a UDP reuseport group connect()s, has_conns is set to 1. Then, when a packet is received, udp[46]_lib_lookup2() scans all sockets in udp_hslot looking for the connected socket with the highest score. However, when the number of sockets bound to the port exceeds max_sock

[PATCH net 0/2] udp: Fix reuseport selection with connected sockets.

2020-07-20 Thread Kuniyuki Iwashima
From: kuniyu This patch set addresses two issues which happen when both connected and unconnected sockets are in the same UDP reuseport group. Kuniyuki Iwashima (2): udp: Copy has_conns in reuseport_grow(). udp: Improve load balancing for SO_REUSEPORT. net/core/sock_reuseport.c | 1 + net

Re: mmotm 2020-07-20-19-06 uploaded (net/ipv6/ip6_vti.o)

2020-07-20 Thread Steffen Klassert
On Mon, Jul 20, 2020 at 11:09:34PM -0700, Randy Dunlap wrote: > On 7/20/20 7:07 PM, Andrew Morton wrote: > > The mm-of-the-moment snapshot 2020-07-20-19-06 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > > >

Re: [PATCH ipsec-next] ip6_vti: use IS_REACHABLE to avoid some compile errors

2020-07-20 Thread Steffen Klassert
On Fri, Jul 17, 2020 at 03:03:14PM +0800, Xin Long wrote: > Naresh reported some compile errors: > > arm build failed due this error on linux-next 20200713 and 20200713 > net/ipv6/ip6_vti.o: In function `vti6_rcv_tunnel': > ip6_vti.c:(.text+0x1d20): undefined reference to `xfrm6_tunnel_spi_

Re: [PATCH ipsec-next] xfrm: interface: use IS_REACHABLE to avoid some compile errors

2020-07-20 Thread Steffen Klassert
On Fri, Jul 17, 2020 at 03:02:30PM +0800, Xin Long wrote: > kernel test robot reported some compile errors: > > ia64-linux-ld: net/xfrm/xfrm_interface.o: in function `xfrmi4_fini': > net/xfrm/xfrm_interface.c:900: undefined reference to > `xfrm4_tunnel_deregister' > ia64-linux-ld: net/xfrm/

Re: [PATCH ipsec 0/3] xfrm: a few fixes for espintcp

2020-07-20 Thread Steffen Klassert
On Thu, Jul 16, 2020 at 10:09:00AM +0200, Sabrina Dubroca wrote: > Andrew Cagney reported some issues when trying to use async operations > on the encapsulation socket. Patches 1 and 2 take care of these bugs. > > In addition, I missed a spot when adding IPv6 support and converting > to the common

Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones

2020-07-20 Thread Leon Romanovsky
On Mon, Jul 20, 2020 at 11:34:00PM +0200, Alexander A. Klimov wrote: > > > Am 20.07.20 um 18:48 schrieb Leon Romanovsky: > > On Mon, Jul 20, 2020 at 08:36:35AM -0600, Jonathan Corbet wrote: > > > On Mon, 20 Jul 2020 17:07:16 +0300 > > > Leon Romanovsky wrote: > > > > > > > > Do *you* want to revie

RE: [EXT] Re: [PATCH 1/2] net: dsa: Add flag for 802.1AD when adding VLAN for dsa switch and port

2020-07-20 Thread Hongbo Wang
Thanks for your suggestion! I will change the code. thanks. -Original Message- From: Florian Fainelli Sent: 2020年7月21日 12:57 To: Hongbo Wang ; Xiaoliang Yang ; allan.niel...@microchip.com; Po Liu ; Claudiu Manoil ; Alexandru Marginean ; Vladimir Oltean ; Leo Li ; Mingkai Hu ; and...@

Re: [PATCH 02/24] bpfilter: fix up a sparse annotation

2020-07-20 Thread Al Viro
On Tue, Jul 21, 2020 at 07:23:26AM +0200, Christoph Hellwig wrote: > On Tue, Jul 21, 2020 at 04:40:16AM +0200, Luc Van Oostenryck wrote: > > > req.pid = current->pid; > > > req.cmd = optname; > > > - req.addr = (long __force __user)optval; > > > + req.addr = (__force long)optval; > > > > For c

Re: [PATCH 02/24] bpfilter: fix up a sparse annotation

2020-07-20 Thread Christoph Hellwig
On Tue, Jul 21, 2020 at 04:40:16AM +0200, Luc Van Oostenryck wrote: > > req.pid = current->pid; > > req.cmd = optname; > > - req.addr = (long __force __user)optval; > > + req.addr = (__force long)optval; > > For casts to integers, even '__force' is not needed (since integers > can't be

[PATCH bpf-next v4 08/14] xsk: enable sharing of dma mappings

2020-07-20 Thread Magnus Karlsson
Enable the sharing of dma mappings by moving them out from the buffer pool. Instead we put each dma mapped umem region in a list in the umem structure. If dma has already been mapped for this umem and device, it is not mapped again and the existing dma mappings are reused. Signed-off-by: Magnus Ka

[PATCH bpf-next v4 09/14] xsk: rearrange internal structs for better performance

2020-07-20 Thread Magnus Karlsson
Rearrange the xdp_sock, xdp_umem and xsk_buff_pool structures so that they get smaller and align better to the cache lines. In the previous commits of this patch set, these structs have been reordered with the focus on functionality and simplicity, not performance. This patch improves throughput pe

[PATCH bpf-next v4 10/14] xsk: add shared umem support between queue ids

2020-07-20 Thread Magnus Karlsson
Add support to share a umem between queue ids on the same device. This mode can be invoked with the XDP_SHARED_UMEM bind flag. Previously, sharing was only supported within the same queue id and device, and you shared one set of fill and completion rings. However, note that when sharing a umem betw

[PATCH bpf-next v4 12/14] libbpf: support shared umems between queues and devices

2020-07-20 Thread Magnus Karlsson
Add support for shared umems between hardware queues and devices to the AF_XDP part of libbpf. This so that zero-copy can be achieved in applications that want to send and receive packets between HW queues on one device or between different devices/netdevs. In order to create sockets that share a

[PATCH bpf-next v4 11/14] xsk: add shared umem support between devices

2020-07-20 Thread Magnus Karlsson
Add support to share a umem between different devices. This mode can be invoked with the XDP_SHARED_UMEM bind flag. Previously, sharing was only supported within the same device. Note that when sharing a umem between devices, just as in the case of sharing a umem between queue ids, you need to crea

[PATCH bpf-next v4 14/14] xsk: documentation for XDP_SHARED_UMEM between queues and netdevs

2020-07-20 Thread Magnus Karlsson
Add documentation for the XDP_SHARED_UMEM feature when a UMEM is shared between different queues and/or netdevs. Signed-off-by: Magnus Karlsson --- Documentation/networking/af_xdp.rst | 68 +++-- 1 file changed, 58 insertions(+), 10 deletions(-) diff --git a/Docu

[PATCH bpf-next v4 13/14] samples/bpf: add new sample xsk_fwd.c

2020-07-20 Thread Magnus Karlsson
From: Cristian Dumitrescu This sample code illustrates the packet forwarding between multiple AF_XDP sockets in multi-threading environment. All the threads and sockets are sharing a common buffer pool, with each socket having its own private buffer cache. The sockets are created with the xsk_soc

[PATCH bpf-next v4 05/14] xsk: move queue_id, dev and need_wakeup to buffer pool

2020-07-20 Thread Magnus Karlsson
Move queue_id, dev, and need_wakeup from the umem to the buffer pool. This so that we in a later commit can share the umem between multiple HW queues. There is one buffer pool per dev and queue id, so these variables should belong to the buffer pool, not the umem. Need_wakeup is also something that

[PATCH bpf-next v4 07/14] xsk: move addrs from buffer pool to umem

2020-07-20 Thread Magnus Karlsson
Replicate the addrs pointer in the buffer pool to the umem. This mapping will be the same for all buffer pools sharing the same umem. In the buffer pool we leave the addrs pointer for performance reasons. Signed-off-by: Magnus Karlsson --- include/net/xdp_sock.h | 1 + net/xdp/xdp_umem.c

[PATCH bpf-next v4 00/14] xsk: support shared umems between devices and queues

2020-07-20 Thread Magnus Karlsson
This patch set adds support to share a umem between AF_XDP sockets bound to different queue ids on the same device or even between devices. It has already been possible to do this by registering the umem multiple times, but this wastes a lot of memory. Just imagine having 10 threads each having 10

[PATCH bpf-next v4 04/14] xsk: move fill and completion rings to buffer pool

2020-07-20 Thread Magnus Karlsson
Move the fill and completion rings from the umem to the buffer pool. This so that we in a later commit can share the umem between multiple HW queue ids. In this case, we need one fill and completion ring per queue id. As the buffer pool is per queue id and napi id this is a natural place for it and

[PATCH bpf-next v4 06/14] xsk: move xsk_tx_list and its lock to buffer pool

2020-07-20 Thread Magnus Karlsson
Move the xsk_tx_list and the xsk_tx_list_lock from the umem to the buffer pool. This so that we in a later commit can share the umem between multiple HW queues. There is one xsk_tx_list per device and queue id, so it should be located in the buffer pool. Signed-off-by: Magnus Karlsson --- includ

[PATCH bpf-next v4 02/14] xsk: i40e: ice: ixgbe: mlx5: rename xsk zero-copy driver interfaces

2020-07-20 Thread Magnus Karlsson
Rename the AF_XDP zero-copy driver interface functions to better reflect what they do after the replacement of umems with buffer pools in the previous commit. Mostly it is about replacing the umem name from the function names with xsk_buff and also have them take the a buffer pool pointer instead o

[PATCH bpf-next v4 03/14] xsk: create and free buffer pool independently from umem

2020-07-20 Thread Magnus Karlsson
Create and free the buffer pool independently from the umem. Move these operations that are performed on the buffer pool from the umem create and destroy functions to new create and destroy functions just for the buffer pool. This so that in later commits we can instantiate multiple buffer pools pe

[PATCH bpf-next v4 01/14] xsk: i40e: ice: ixgbe: mlx5: pass buffer pool to driver instead of umem

2020-07-20 Thread Magnus Karlsson
Replace the explicit umem reference passed to the driver in AF_XDP zero-copy mode with the buffer pool instead. This in preparation for extending the functionality of the zero-copy mode so that umems can be shared between queues on the same netdev and also between netdevs. In this commit, only an u

[PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread Chi Song
An imbalanced TX indirection table causes netvsc to have low performance. This table is created and managed during runtime. To help better diagnose performance issues caused by imbalanced tables, add device attributes to show the content of TX indirection tables. Signed-off-by: Chi Song --- v4: u

Re: [PATCH 1/2] net: dsa: Add flag for 802.1AD when adding VLAN for dsa switch and port

2020-07-20 Thread Florian Fainelli
On 7/20/2020 3:41 AM, hongbo.w...@nxp.com wrote: > From: "hongbo.wang" > > the following command can be supported: > ip link add link swp1 name swp1.100 type vlan protocol 802.1ad id 100 You should probably include the switch driver that is going to be benefiting from doing these changes in t

Re: [PATCH v5 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread Stephen Hemminger
On Tue, 21 Jul 2020 03:50:00 + Chi Song wrote: > +static void netvsc_attrs_init(void) > +{ > + char buffer[4]; > + int i; > + > + for (i = 0; i < VRSS_SEND_TAB_SIZE; i++) { > + sprintf(buffer, "%02u", i); > + dev_attr_netvsc_dev_attrs[i].attr.name = > +

KASAN: use-after-free Read in sock_def_write_space (2)

2020-07-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5714ee50 copy_xstate_to_kernel: Fix typo which caused GDB .. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13059e7f10 kernel config: https://syzkaller.appspot.com/x/.config?x=f87a5e4232fdb267 das

general protection fault in __xfrm6_tunnel_spi_check

2020-07-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4c43049f Add linux-next specific files for 20200716 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=16f786d710 kernel config: https://syzkaller.appspot.com/x/.config?x=2c76d72659687242 dashboard

Re: [PATCH net] netdevsim: fix unbalaced locking in nsim_create()

2020-07-20 Thread Taehee Yoo
On Tue, 21 Jul 2020 at 02:57, Jakub Kicinski wrote: > Hi Jakub, Thank you for your review! > On Sat, 18 Jul 2020 06:49:21 + Taehee Yoo wrote: > > In the nsim_create(), rtnl_lock() is called before nsim_bpf_init(). > > If nsim_bpf_init() is failed, rtnl_unlock() should be called, > > but it i

KASAN: slab-out-of-bounds Read in xfrm6_tunnel_alloc_spi

2020-07-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4c43049f Add linux-next specific files for 20200716 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=10e7e9d710 kernel config: https://syzkaller.appspot.com/x/.config?x=2c76d72659687242 dashboard

[PATCH v5 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread Chi Song
An imbalanced TX indirection table causes netvsc to have low performance. This table is created and managed during runtime. To help better diagnose performance issues caused by imbalanced tables, add device attributes to show the content of TX indirection tables. Signed-off-by: Chi Song --- v4: u

Re: [PATCH bpf-next v2 3/6] bpf: support attaching freplace programs to multiple attach points

2020-07-20 Thread Andrii Nakryiko
On Mon, Jul 20, 2020 at 4:35 PM Alexei Starovoitov wrote: > > On Sun, Jul 19, 2020 at 10:02:48PM -0700, Andrii Nakryiko wrote: > > On Thu, Jul 16, 2020 at 7:06 PM Alexei Starovoitov > > wrote: > > > > > > On Thu, Jul 16, 2020 at 12:50:05PM +0200, Toke Høiland-Jørgensen wrote: > > > > Alexei Staro

[PATCH] Fix memory overwriting issue when copy an address to user space

2020-07-20 Thread lebon zhou
On Mon, Jul 20, 2020 at 11:12 PM David Laight wrote: > > From: lebon zhou > > Sent: 20 July 2020 05:35 > > To: da...@davemloft.net; k...@kernel.org > > Cc: linux-ker...@vger.kernel.org; netdev@vger.kernel.org > > Subject: [PATCH] Fix memory overwriting issue when copy an address to user > > space

Re: [PATCH v4 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread David Miller
From: Chi Song Date: Tue, 21 Jul 2020 02:37:42 + > +static ssize_t tx_indirection_show(struct device *dev, > +struct device_attribute *dev_attr, char *buf) > +{ > + struct net_device *ndev = to_net_dev(dev); > + struct net_device_context *ndc = netdev_p

Re: [tipc-discussion] [net v1 1/1] tipc: allow to build NACK message in link timeout function

2020-07-20 Thread David Miller
From: Tung Nguyen Date: Tue, 21 Jul 2020 08:57:05 +0700 > Commit 02288248b051 ("tipc: eliminate gap indicator from ACK messages") > eliminated sending of the 'gap' indicator in regular ACK messages and > only allowed to build NACK message with enabled probe/probe_reply. > However, necessary corre

RE: [EXT] Re: [PATCH 1/2] net: dsa: Add flag for 802.1AD when adding VLAN for dsa switch and port

2020-07-20 Thread Hongbo Wang
Hi Nikolay, Thanks for your comments. The original intention is that I want to run a command to set single port into QinQ mode, the related commands are: ip link set br0 type bridge vlan_protocol 802.1ad // this command will set all ports under the bridge br0 ip link add link swp1 name swp1.1

[PATCH net] openvswitch: fix drop over mtu packet after defrag in act_ct

2020-07-20 Thread wenxu
From: wenxu When openvswitch conntrack offload with act_ct action. Fragment packets defrag in the ingress tc act_ct action and miss the next chain. Then the packet pass to the openvswitch datapath without the mru. The defrag over mtu packet will be dropped in output of openvswitch for over mtu.

Re: [PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy

2020-07-20 Thread Sekhar Nori
Hi Santosh, On 7/15/20 2:24 PM, Grygorii Strashko wrote: > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the > KSZ9031 PHY") the networking is broken on keystone-k2g-evm board. > > The above board have phy-mode = "rgmii-id" and it is worked before because > KSZ9031 PHY st

Re: BPF logging infrastructure. Was: [PATCH bpf-next 4/6] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

2020-07-20 Thread Andrii Nakryiko
On Mon, Jul 20, 2020 at 3:31 PM Alexei Starovoitov wrote: > > On Fri, Jul 17, 2020 at 08:54:45PM -0700, Andrii Nakryiko wrote: > > > > > Only libbpf can do it. Kernel is helpless here. > > > Say we change the kernel errno for all unsuported prog types and maps > > > it would return ENOTSUPP or som

Re: Misaligned IPv6 addresses is SCTP socket options.

2020-07-20 Thread Marcelo Ricardo Leitner
On Mon, Jul 20, 2020 at 03:50:16PM +, David Laight wrote: > Several of the structures in linux/uapi/linux/sctp.h are > marked __attribute__((packed, aligned(4))). I don't think we can change that by now. It's bad, yes, but it's exposed and, well, for a long time (since 2005). > > I believe t

Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version

2020-07-20 Thread Jason Wang
On 2020/7/20 下午7:16, Eugenio Pérez wrote: On Mon, Jul 20, 2020 at 11:27 AM Michael S. Tsirkin wrote: On Thu, Jul 16, 2020 at 07:16:27PM +0200, Eugenio Perez Martin wrote: On Fri, Jul 10, 2020 at 7:58 AM Michael S. Tsirkin wrote: On Fri, Jul 10, 2020 at 07:39:26AM +0200, Eugenio Perez Marti

Re: [PATCH 18/20] dt-bindings: can: rcar_can: Document r8a774e1 support

2020-07-20 Thread Rob Herring
On Wed, 15 Jul 2020 12:09:08 +0100, Lad Prabhakar wrote: > Document SoC specific bindings for RZ/G2H (R8A774E1) SoC. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > --- > Documentation/devicetree/bindings/net/can/rcar_can.txt | 1 + > 1 file changed, 1 insertion(+)

[PATCH bpf-next v1 2/3] bpf, riscv: Add encodings for compressed instructions

2020-07-20 Thread Luke Nelson
This patch adds functions for encoding and emitting compressed riscv (RVC) instructions to the BPF JIT. Some regular riscv instructions can be compressed into an RVC instruction if the instruction fields meet some requirements. For example, "add rd, rs1, rs2" can be compressed into "c.add rd, rs2"

[PATCH bpf-next v1 0/3] bpf, riscv: Add compressed instructions to rv64 JIT

2020-07-20 Thread Luke Nelson
This patch series enables using compressed riscv (RVC) instructions in the rv64 BPF JIT. RVC is a standard riscv extension that adds a set of compressed, 2-byte instructions that can replace some regular 4-byte instructions for improved code density. This series first modifies the JIT to support

Re: [PATCH 19/20] dt-bindings: can: rcar_canfd: Document r8a774e1 support

2020-07-20 Thread Rob Herring
On Wed, 15 Jul 2020 12:09:09 +0100, Lad Prabhakar wrote: > Document the support for rcar_canfd on R8A774E1 SoC devices. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > --- > Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 1 + > 1 file changed, 1 insertio

[PATCH bpf-next v1 3/3] bpf, riscv: Use compressed instructions in the rv64 JIT

2020-07-20 Thread Luke Nelson
This patch uses the RVC support and encodings from bpf_jit.h to optimize the rv64 jit. The optimizations work by replacing emit(rv_X(...)) with a call to a helper function emit_X, which will emit a compressed version of the instruction when possible, and when RVC is enabled. The JIT continues to

[PATCH bpf-next v1 1/3] bpf, riscv: Modify JIT ctx to support compressed instructions

2020-07-20 Thread Luke Nelson
This patch makes the necessary changes to struct rv_jit_context and to bpf_int_jit_compile to support compressed riscv (RVC) instructions in the BPF JIT. It changes the JIT image to be u16 instead of u32, since RVC instructions are 2 bytes as opposed to 4. It also changes ctx->offset and ctx->nin

Re: [PATCH V2 3/6] vDPA: implement IRQ offloading helpers in vDPA core

2020-07-20 Thread Jason Wang
On 2020/7/21 上午10:02, Zhu, Lingshan wrote: On 7/20/2020 5:40 PM, Jason Wang wrote: On 2020/7/20 下午5:07, Zhu, Lingshan wrote: +} + +static void vdpa_unsetup_irq(struct vdpa_device *vdev, int qid) +{ +    struct vdpa_driver *drv = drv_to_vdpa(vdev->dev.driver); + +    if (drv->unsetup_vq_ir

Re: [PATCH 14/20] dt-bindings: spi: renesas,sh-msiof: Add r8a774e1 support

2020-07-20 Thread Rob Herring
On Wed, 15 Jul 2020 12:09:04 +0100, Lad Prabhakar wrote: > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > --- > Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by

Re: [PATCH 16/20] dt-bindings: watchdog: renesas,wdt: Document r8a774e1 support

2020-07-20 Thread Rob Herring
On Wed, 15 Jul 2020 12:09:06 +0100, Lad Prabhakar wrote: > RZ/G2H (a.k.a. R8A774E1) watchdog implementation is compatible > with R-Car Gen3, therefore add the relevant documentation. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml | 1 + > 1 f

Re: [PATCH 14/20] dt-bindings: spi: renesas,sh-msiof: Add r8a774e1 support

2020-07-20 Thread Rob Herring
On Fri, Jul 17, 2020 at 01:22:09PM +0100, Mark Brown wrote: > On Fri, Jul 17, 2020 at 01:15:13PM +0100, Lad, Prabhakar wrote: > > On Fri, Jul 17, 2020 at 12:59 PM Mark Brown wrote: > > > > On Wed, Jul 15, 2020 at 12:09:04PM +0100, Lad Prabhakar wrote: > > > > Document RZ/G2H (R8A774E1) SoC bindin

[PATCH bpf-next v4] bpftool: use only nftw for file tree parsing

2020-07-20 Thread Tony Ambardar
The bpftool sources include code to walk file trees, but use multiple frameworks to do so: nftw and fts. While nftw conforms to POSIX/SUSv3 and is widely available, fts is not conformant and less common, especially on non-glibc systems. The inconsistent framework usage hampers maintenance and porta

Re: [PATCH 11/20] dt-bindings: i2c: renesas,i2c: Document r8a774e1 support

2020-07-20 Thread Rob Herring
On Wed, 15 Jul 2020 12:09:01 +0100, Lad Prabhakar wrote: > Document i2c controller for RZ/G2H (R8A774E1) SoC, which is compatible > with R-Car Gen3 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > --- > Documentation/devicetree/bindings/i2c/renesas,i2c.tx

Re: [PATCH 12/20] dt-bindings: i2c: renesas,iic: Document r8a774e1 support

2020-07-20 Thread Rob Herring
On Wed, 15 Jul 2020 12:09:02 +0100, Lad Prabhakar wrote: > Document IIC controller for RZ/G2H (R8A774E1) SoC, which is compatible > with R-Car Gen3 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > --- > Documentation/devicetree/bindings/i2c/renesas,iic.tx

Re: [PATCH 02/20] dt-bindings: thermal: rcar-gen3-thermal: Add r8a774e1 support

2020-07-20 Thread Rob Herring
On Wed, 15 Jul 2020 12:08:52 +0100, Lad Prabhakar wrote: > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring

[PATCH v2 2/2] octeontx2-af: add nix error af interrupt handlers

2020-07-20 Thread rakeshs . lkm
From: Jerin Jacob Added debug messages for NIX_AF_RVU_INT, NIX_AF_ERR_INT and NIX_AF_RAS error AF interrupts. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Rakesh Babu Signed-off-by: Subbaraya Sundeep --- .../net/ethernet/marvell/octeontx2/af/rvu.c | 5 +

Re: [PATCH 05/20] dt-bindings: timer: renesas,cmt: Document r8a774e1 CMT support

2020-07-20 Thread Rob Herring
On Wed, 15 Jul 2020 12:08:55 +0100, Lad Prabhakar wrote: > Document SoC specific bindings for RZ/G2H (r8a774e1) SoC. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/timer/renesas,cmt.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring

[PATCH v2 1/2] octeontx2-af: add npa error af interrupt handlers

2020-07-20 Thread rakeshs . lkm
From: Jerin Jacob Added debug messages for NPA NPA_AF_RVU_INT, NPA_AF_GEN_INT, NPA_AF_ERR_INT and NPA_AF_RAS error AF interrupts Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Rakesh Babu Signed-off-by: Subbaraya Sundeep --- .../net/ethernet/marvell/octeontx2

[PATCH v2 0/2] Interrupt handler support for NPA and NIX in Octeontx2.

2020-07-20 Thread rakeshs . lkm
From: Rakesh Babu Changes from v1. 1. Assigned void pointers to another type of pointers without type casting. 2. Removed Switch and If cases in interrupt handlers and printed the hexa value of the interrupt Jerin Jacob (2): octeontx2-af: add npa error af interrupt handlers octeontx2-af: add

Re: [PATCH 02/24] bpfilter: fix up a sparse annotation

2020-07-20 Thread Luc Van Oostenryck
On Mon, Jul 20, 2020 at 02:47:15PM +0200, Christoph Hellwig wrote: > The __user doesn't make sense when casting to an integer type. > > Signed-off-by: Christoph Hellwig > --- > net/bpfilter/bpfilter_kern.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bpfilter/bpf

Re: [RFC PATCH bpf-next 2/2] selftests/bpf: Test __ksym externs with BTF

2020-07-20 Thread Andrii Nakryiko
On Mon, Jul 20, 2020 at 1:28 PM Hao Luo wrote: > > > > > This should ideally look like a real global variable extern: > > > > extern const struct rq runqueues __ksym; > > > > > > But that's the case for non-per-cpu variables. You didn't seem to > > address per-CPU variables in this patch set. How

[PATCH v4 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread Chi Song
An imbalanced TX indirection table causes netvsc to have low performance. This table is created and managed during runtime. To help better diagnose performance issues caused by imbalanced tables, add device attributes to show the content of TX indirection tables. Signed-off-by: Chi Song --- v4: u

linux-next: manual merge of the bpf-next tree with the net-next tree

2020-07-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got a conflict in: include/net/xdp.h between commit: 2f0bc54ba9a8 ("xdp: introduce xdp_get_shared_info_from_{buff, frame} utility routines") from the net-next tree and commits: 9216477449f3 ("bpf: cpumap: Add the possibility to atta

Re: [PATCH bpf-next v3] bpftool: use only nftw for file tree parsing

2020-07-20 Thread Tony Ambardar
On Mon, 20 Jul 2020 at 01:13, Quentin Monnet wrote: > > On 17/07/2020 23:55, Tony Ambardar wrote: > > The bpftool sources include code to walk file trees, but use multiple > > frameworks to do so: nftw and fts. While nftw conforms to POSIX/SUSv3 and > > is widely available, fts is not conformant a

linux-next: manual merge of the bpf-next tree with the net-next tree

2020-07-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got a conflict in: include/linux/filter.h between commit: 4d295e546115 ("net: simplify cBPF setsockopt compat handling") from the net-next tree and commits: e9ddbb7707ff ("bpf: Introduce SK_LOOKUP program type with a dedicated attach

Re: [PATCH 8/9] dt-bindings: net: renesas,ravb: Add support for r8a774e1 SoC

2020-07-20 Thread Rob Herring
On Mon, 13 Jul 2020 22:35:19 +0100, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 + > 1 file cha

Re: [PATCH 6/9] dt-bindings: gpio: renesas,rcar-gpio: Add r8a774e1 support

2020-07-20 Thread Rob Herring
On Mon, 13 Jul 2020 22:35:17 +0100, Lad Prabhakar wrote: > Document Renesas RZ/G2H (R8A774E1) GPIO blocks compatibility within the > relevant dt-bindings. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml | 1 + > 1 file changed, 1 insertion(+

Re: [PATCH 1/9] dt-bindings: iommu: renesas,ipmmu-vmsa: Add r8a774e1 support

2020-07-20 Thread Rob Herring
On Mon, Jul 13, 2020 at 10:35:12PM +0100, Lad Prabhakar wrote: > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring

Re: [PATCH 3/9] arm64: dts: renesas: r8a774e1: Add IPMMU device nodes

2020-07-20 Thread Rob Herring
On Mon, Jul 13, 2020 at 10:35:14PM +0100, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Add RZ/G2H (R8A774E1) IPMMU nodes. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar > --- > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 121 ++ >

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-20 Thread Rob Herring
On Fri, Jul 17, 2020 at 08:26:02PM +0100, Matthew Hagan wrote: > > > On 16/07/2020 23:32, Andrew Lunn wrote: > > On Thu, Jul 16, 2020 at 03:09:25PM -0700, Jakub Kicinski wrote: > >> On Mon, 13 Jul 2020 21:50:26 +0100 Matthew Hagan wrote: > >>> Add names and decriptions of additional PORT0_PAD_CTR

答复: [Intel-wired-lan] [PATCH 1/2] xdp: i40e: ixgbe: ixgbevf: not flip rx buffer for copy mode xdp

2020-07-20 Thread Li,Rongqing
> -邮件原件- > 发件人: Magnus Karlsson [mailto:magnus.karls...@gmail.com] > 发送时间: 2020年7月20日 15:21 > 收件人: Li,Rongqing > 抄送: Network Development ; intel-wired-lan > ; Karlsson, Magnus > ; Björn Töpel > 主题: Re: [Intel-wired-lan] [PATCH 1/2] xdp: i40e: ixgbe: ixgbevf: not flip rx > buffer for cop

[tipc-discussion] [net v1 1/1] tipc: allow to build NACK message in link timeout function

2020-07-20 Thread Tung Nguyen
Commit 02288248b051 ("tipc: eliminate gap indicator from ACK messages") eliminated sending of the 'gap' indicator in regular ACK messages and only allowed to build NACK message with enabled probe/probe_reply. However, necessary correction for building NACK message was missed in tipc_link_timeout()

linux-next: manual merge of the net-next tree with the net tree

2020-07-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/aquantia/atlantic/aq_hw.h between commit: 23e500e88723 ("net: atlantic: disable PTP on AQC111, AQC112") from the net tree and commit: 1e41b3fee795 ("net: atlantic: add support for 64-bit reads/

[RFC 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages

2020-07-20 Thread Boqun Feng
When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at least 2 * PAGE_SIZE: one page for the header and at least one page of the data part (because of the alignment requirement for double mapping). So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when using vmbus_ope

[RFC 03/11] Drivers: hv: vmbus: Introduce types of GPADL

2020-07-20 Thread Boqun Feng
This patch introduces two types of GPADL: HV_GPADL_{BUFFER, RING}. The types of GPADL are purely the concept in the guest, IOW the hypervisor treat them as the same. The reason of introducing the types of GPADL is to support guests whose page size is not 4k (the page size of Hyper-V hypervisor). I

[RFC 04/11] Drivers: hv: Use HV_HYP_PAGE in hv_synic_enable_regs()

2020-07-20 Thread Boqun Feng
Both the base_*_gpa should use the guest page number in Hyper-V page, so use HV_HYP_PAGE instead of PAGE. Signed-off-by: Boqun Feng --- drivers/hv/hv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index 41b2ee06cc2f..e4f50dcdc46c 10064

[RFC 06/11] hv: hyperv.h: Introduce some hvpfn helper functions

2020-07-20 Thread Boqun Feng
When a guest communicate with the hypervisor, it must use HV_HYP_PAGE to calculate PFN, so introduce a few hvpfn helper functions as the counterpart of the page helper functions. This is the preparation for supporting guest whose PAGE_SIZE is not 4k. Signed-off-by: Boqun Feng --- include/linux/h

[RFC 02/11] Drivers: hv: vmbus: Move __vmbus_open()

2020-07-20 Thread Boqun Feng
Pure function movement, no functional changes. The move is made, because in a later change, __vmbus_open() will rely on some static functions afterwards, so we sperate the move and the modification of __vmbus_open() in two patches to make it easy to review. Signed-off-by: Boqun Feng --- drivers/

[RFC 01/11] Drivers: hv: vmbus: Always use HV_HYP_PAGE_SIZE for gpadl

2020-07-20 Thread Boqun Feng
Since the hypervisor always uses 4K as its page size, the size of PFNs used for gpadl should be HV_HYP_PAGE_SIZE rather than PAGE_SIZE, so adjust this accordingly as the preparation for supporting 16K/64K page size guests. Signed-off-by: Boqun Feng --- drivers/hv/channel.c | 13 + 1

[RFC 05/11] Drivers: hv: vmbus: Move virt_to_hvpfn() to hyperv header

2020-07-20 Thread Boqun Feng
There will be more places other than vmbus where we need to calculate the Hyper-V page PFN from a virtual address, so move virt_to_hvpfn() to hyperv generic header. Signed-off-by: Boqun Feng --- drivers/hv/channel.c | 13 - include/linux/hyperv.h | 15 +++ 2 files chang

[RFC 09/11] HID: hyperv: Make ringbuffer at least take two pages

2020-07-20 Thread Boqun Feng
When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at least 2 * PAGE_SIZE: one page for the header and at least one page of the data part (because of the alignment requirement for double mapping). So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when using vmbus_ope

[RFC 10/11] Driver: hv: util: Make ringbuffer at least take two pages

2020-07-20 Thread Boqun Feng
When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at least 2 * PAGE_SIZE: one page for the header and at least one page of the data part (because of the alignment requirement for double mapping). So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when using vmbus_ope

[RFC 07/11] hv_netvsc: Use HV_HYP_PAGE_SIZE for Hyper-V communication

2020-07-20 Thread Boqun Feng
When communicating with Hyper-V, HV_HYP_PAGE_SIZE should be used since that's the page size used by Hyper-V and Hyper-V expects all page-related data using the unit of HY_HYP_PAGE_SIZE, for example, the "pfn" in hv_page_buffer is actually the HV_HYP_PAGE (i.e. the Hyper-V page) number. In order to

[RFC 00/11] Hyper-V: Support PAGE_SIZE larger than 4K

2020-07-20 Thread Boqun Feng
This patchset add the necessary changes to support guests whose page size is larger than 4K. Hyper-V always uses 4K as the page size and expects the same page size when communicating with guests. That is, all the "pfn"s in the hypervisor-guest communication protocol are the page numbers in the uni

[RFC 11/11] scsi: storvsc: Support PAGE_SIZE larger than 4K

2020-07-20 Thread Boqun Feng
Hyper-V always use 4k page size (HV_HYP_PAGE_SIZE), so when communicating with Hyper-V, a guest should always use HV_HYP_PAGE_SIZE as the unit for page related data. For storvsc, the data is vmbus_packet_mpb_array. And since in scsi_cmnd, sglist of pages (in unit of PAGE_SIZE) is used, we need conv

RE: [PATCH/RFC v2] net: ethernet: ravb: exit if hardware is in-progress in tx timeout

2020-07-20 Thread Yoshihiro Shimoda
Hello! Thank you for your review! > From: Sergei Shtylyov, Sent: Tuesday, July 21, 2020 2:15 AM > > Hello! > > On 7/20/20 2:58 PM, Yoshihiro Shimoda wrote: > > > According to the report of [1], this driver is possible to cause > > the following error in ravb_tx_timeout_work(). > > > > ravb e68

Re: [PATCH] net: ag71xx: add missed clk_disable_unprepare in error path of probe

2020-07-20 Thread David Miller
From: Huang Guobin Date: Sun, 19 Jul 2020 21:46:14 -0400 > The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when > of_reset_control_get_exclusive() failed. Add the missed call to fix it. > > Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") > Reported-by: Hulk Robot > Sign

Re: [PATCH v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-20 Thread David Miller
From: Bixuan Cui Date: Mon, 20 Jul 2020 09:58:39 +0800 > Fix the warning: [-Werror=-Wframe-larger-than=] > > drivers/net/ethernet/neterion/vxge/vxge-main.c: > In function'VXGE_COMPLETE_VPATH_TX.isra.37': > drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: > warning: the frame size of 1056 by

Re: [PATCH net v3] net/sched: act_ct: fix restore the qdisc_skb_cb after defrag

2020-07-20 Thread David Miller
From: we...@ucloud.cn Date: Sun, 19 Jul 2020 20:30:37 +0800 > From: wenxu > > The fragment packets do defrag in tcf_ct_handle_fragments > will clear the skb->cb which make the qdisc_skb_cb clear > too. So the qdsic_skb_cb should be store before defrag and > restore after that. > It also update t

Re: [PATCH net-next] net: dsa: use the ETH_MIN_MTU and ETH_DATA_LEN default values

2020-07-20 Thread David Miller
From: Vladimir Oltean Date: Sat, 18 Jul 2020 21:04:18 +0300 > Now that DSA supports MTU configuration, undo the effects of commit > 8b1efc0f83f1 ("net: remove MTU limits on a few ether_setup callers") and > let DSA interfaces use the default min_mtu and max_mtu specified by > ether_setup(). This

Re: [PATCH v2] net: dsa: qca8k: implement the port MTU callbacks

2020-07-20 Thread David Miller
From: Jonathan McDowell Date: Sat, 18 Jul 2020 17:32:14 +0100 > This switch has a single max frame size configuration register, so we > track the requested MTU for each port and apply the largest. > > v2: > - Address review feedback from Vladimir Oltean > > Signed-off-by: Jonathan McDowell Ap

Re: [PATCH -next] net: hsr: remove redundant null check

2020-07-20 Thread David Miller
From: Wang Hai Date: Sat, 18 Jul 2020 20:53:38 +0800 > Because kfree_skb already checked NULL skb parameter, > so the additional checks are unnecessary, just remove them. > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Applied.

  1   2   3   4   5   >