Re: [RFC PATCH v1 1/2] Bluetooth: queue ACL packets if no handle is found

2020-06-29 Thread Marcel Holtmann
Hi Archie, >>> There is a possibility that an ACL packet is received before we >>> receive the HCI connect event for the corresponding handle. If this >>> happens, we discard the ACL packet. >>> >>> Rather than just ignoring them, this patch provides a queue for >>> incoming ACL packet without a

[PATCH v2] net: qrtr: free flow in __qrtr_node_release

2020-06-29 Thread Carl Huang
The flow is allocated in qrtr_tx_wait, but not freed when qrtr node is released. (*slot) becomes NULL after radix_tree_iter_delete is called in __qrtr_node_release. The fix is to save (*slot) to a vairable and then free it. This memory leak is catched when kmemleak is enabled in kernel, the report

Re: [PATCH v1] Bluetooth: Fix kernel oops triggered by hci_adv_monitors_clear()

2020-06-29 Thread Marcel Holtmann
Hi Miao-chen, > This fixes the kernel oops by removing unnecessary background scan > update from hci_adv_monitors_clear() which shouldn't invoke any work > queue. > > The following test was performed. > - Run "rmmod btusb" and verify that no kernel oops is triggered. > > Signed-off-by: Miao-chen

Re: [RFC PATCH v1 2/2] Bluetooth: queue L2CAP conn req if encryption is needed

2020-06-29 Thread Marcel Holtmann
Hi Luiz, > It is possible to receive an L2CAP conn req for an encrypted > connection, before actually receiving the HCI change encryption > event. If this happened, the received L2CAP packet will be ignored. >>> >>> How is this possible? Or you are referring to a race between the ACL

Re: [PATCH net] net: ethernet: fec: prevent tx starvation under high rx load

2020-06-29 Thread Tobias Waldekranz
On Mon Jun 29, 2020 at 3:07 PM CEST, David Miller wrote: > From: Tobias Waldekranz > Date: Mon, 29 Jun 2020 21:16:01 +0200 > > > In the ISR, we poll the event register for the queues in need of > > service and then enter polled mode. After this point, the event > > register will never be read agai

Re: [PATCH 04/16] net: bpfilter: use 'userprogs' syntax to build bpfilter_umh

2020-06-29 Thread Masahiro Yamada
Hi Michal, Alexei, On Mon, Jun 8, 2020 at 8:56 PM Michal Kubecek wrote: > > On Thu, Apr 23, 2020 at 04:39:17PM +0900, Masahiro Yamada wrote: > > The user mode helper should be compiled for the same architecture as > > the kernel. > > > > This Makefile reuses the 'hostprogs' syntax by overriding H

[PATCH net] hinic: fix passing non negative value to ERR_PTR

2020-06-29 Thread Luo bin
get_dev_cap and set_resources_state functions may return a positive value because of hardware failure, and the positive return value can not be passed to ERR_PTR directly. Fixes: 7dd29ee12865 ("net-next/hinic: add sriov feature support") Signed-off-by: Luo bin --- drivers/net/ethernet/huawei/hin

Re: [PATCH] Remove handhelds.org links and email addresses

2020-06-29 Thread Alexander A. Klimov
Am 29.06.20 um 23:10 schrieb Wolfram Sang: Hi Alexander, thanks for trying to fix this, yet I have some doubts. On Mon, Jun 29, 2020 at 10:31:21PM +0200, Alexander A. Klimov wrote: Rationale: https://lore.kernel.org/linux-doc/20200626110706.7b5d4...@lwn.net/ I think we need some text here

[PATCH v5 bpf-next 0/4] bpf: introduce bpf_get_task_stack()

2020-06-29 Thread Song Liu
This set introduces a new helper bpf_get_task_stack(). The primary use case is to dump all /proc/*/stack to seq_file via bpf_iter__task. A few different approaches have been explored and compared: 1. A simple wrapper around stack_trace_save_tsk(), as v1 [1]. This approach introduces new s

RE: [EXT] [PATCH net] net: ethernet: fec: prevent tx starvation under high rx load

2020-06-29 Thread Andy Duan
From: Tobias Waldekranz Sent: Tuesday, June 30, 2020 3:16 AM > In the ISR, we poll the event register for the queues in need of service and > then enter polled mode. After this point, the event register will never be > read > again until we exit polled mode. > > In a scenario where a UDP flow i

RE: [EXT] Re: [PATCH net-next] net: ethernet: fec: prevent tx starvation under high rx load

2020-06-29 Thread Andy Duan
From: Tobias Waldekranz Sent: Tuesday, June 30, 2020 12:29 AM > On Sun Jun 28, 2020 at 8:23 AM CEST, Andy Duan wrote: > > I never seem bandwidth test cause netdev watchdog trip. > > Can you describe the reproduce steps on the commit, then we can > > reproduce it on my local. Thanks. > > My setup

Re: [PATCH v3] IPv4: Tunnel: Fix effective path mtu calculation

2020-06-29 Thread Jakub Kicinski
On Fri, 26 Jun 2020 00:44:35 +0200 Oliver Herms wrote: > The calculation of the effective tunnel mtu, that is used to create > mtu exceptions if necessary, is currently not done correctly. This > leads to unnecessary entries in the IPv6 route cache for any > packet send through the tunnel. > > The

[PATCH v2 bpf] bpf: enforce BPF ringbuf size to be the power of 2

2020-06-29 Thread Andrii Nakryiko
BPF ringbuf assumes the size to be a multiple of page size and the power of 2 value. The latter is important to avoid division while calculating position inside the ring buffer and using (N-1) mask instead. This patch fixes omission to enforce power-of-2 size rule. Fixes: 457f44363a88 ("bpf: Imple

[PATCH ipsec] xfrm: state: match with both mark and mask on user interfaces

2020-06-29 Thread Xin Long
Similar to commit 4f47e8ab6ab79 ("xfrm: policy: match with both mark and mask on user interfaces"), this patch is to match both mark and mask for state on these user interfaces: xfrm_state_lookup_byaddr_user xfrm_state_lookup_user xfrm_state_update xfrm_state_find xfrm_state_add __

Re: [PATCH v4 bpf-next 2/4] bpf: introduce helper bpf_get_task_stack()

2020-06-29 Thread Song Liu
> On Jun 29, 2020, at 9:18 PM, Alexei Starovoitov > wrote: > > On Sun, Jun 28, 2020 at 10:58 PM Song Liu wrote: >> >> Introduce helper bpf_get_task_stack(), which dumps stack trace of given >> task. This is different to bpf_get_stack(), which gets stack track of >> current task. One potenti

Re: [PATCH bpf-next 1/2] bpf, x86: Factor common x86 JIT code

2020-06-29 Thread kernel test robot
Hi Tobias, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Tobias-Klauser/bpf-x86-Factor-common-x86-JIT-code/20200630-045932 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git ma

[PATCH v2 bpf-next 0/2] Make bpf_endian.h compatible with vmlinux.h

2020-06-29 Thread Andrii Nakryiko
Change libbpf's bpf_endian.h header to be compatible when used with system headers and when using just vmlinux.h. This is a frequent request for users writing BPF CO-RE applications. Do this by re-implementing byte swap compile-time macros. Also add simple tests validating correct results both for

[PATCH v2 bpf-next 2/2] selftests/bpf: add byte swapping selftest

2020-06-29 Thread Andrii Nakryiko
Add simple selftest validating byte swap built-ins and compile-time macros. Signed-off-by: Andrii Nakryiko --- .../testing/selftests/bpf/prog_tests/endian.c | 53 +++ .../testing/selftests/bpf/progs/test_endian.c | 37 + 2 files changed, 90 insertions(+) create mode

[PATCH v2 bpf-next 1/2] libbpf: make bpf_endian co-exist with vmlinux.h

2020-06-29 Thread Andrii Nakryiko
Make bpf_endian.h compatible with vmlinux.h. It is a frequent request from users wanting to use bpf_endian.h in their BPF applications using CO-RE and vmlinux.h. To achieve that, re-implement byte swap macros and drop all the header includes. This way it can be used both with linux header includes

Re: [PATCH net-next v3 0/9] net: phy: add Lynx PCS MDIO module

2020-06-29 Thread Michael Walle
Hi all, Am 2020-06-22 11:34, schrieb Vladimir Oltean: On Mon, 22 Jun 2020 at 12:29, Russell King - ARM Linux admin wrote: On Mon, Jun 22, 2020 at 01:54:42AM +0300, Ioana Ciornei wrote: > Add support for the Lynx PCS as a separate module in drivers/net/phy/. > The advantage of this structure i

Re: [PATCH net-next 1/2] mlxsw: core: Add ethtool support for QSFP-DD transceivers

2020-06-29 Thread Ido Schimmel
On Tue, Jun 30, 2020 at 02:21:59AM +0200, Andrew Lunn wrote: > I've no practice experience with modules other than plain old SFPs, > 1G. And those have all sorts of errors, even basic things like the CRC > are systematically incorrect because they are not recalculated after > adding the serial numb

Re: [PATCH 2/2] can: flexcan: add support for ISO CAN-FD

2020-06-29 Thread Michael Walle
[+ Oliver] Hi Joakim, Am 2020-06-30 04:42, schrieb Joakim Zhang: -Original Message- From: Michael Walle Sent: 2020年6月30日 2:18 To: linux-...@vger.kernel.org; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Wolfgang Grandegger ; Marc Kleine-Budde ; David S . Miller ; Jakub Kicin

[PATCH v3 12/20] xfrm: policy: Use sequence counters with associated lock

2020-06-29 Thread Ahmed S. Darwish
A sequence counter write side critical section must be protected by some form of locking to serialize writers. If the serialization primitive is not disabling preemption implicitly, preemption has to be explicitly disabled before entering the sequence counter write side critical section. A plain s

[PATCH v3 11/20] netfilter: nft_set_rbtree: Use sequence counter with associated rwlock

2020-06-29 Thread Ahmed S. Darwish
A sequence counter write side critical section must be protected by some form of locking to serialize writers. A plain seqcount_t does not contain the information of which lock must be held when entering a write side critical section. Use the new seqcount_rwlock_t data type, which allows to associ

[PATCH v3 10/20] netfilter: conntrack: Use sequence counter with associated spinlock

2020-06-29 Thread Ahmed S. Darwish
A sequence counter write side critical section must be protected by some form of locking to serialize writers. A plain seqcount_t does not contain the information of which lock must be held when entering a write side critical section. Use the new seqcount_spinlock_t data type, which allows to asso

[PATCH v3 00/20] seqlock: Extend seqcount API with associated locks

2020-06-29 Thread Ahmed S. Darwish
Hi, This is v3 of the seqlock patch series: [PATCH v1 00/25] seqlock: Extend seqcount API with associated locks https://lore.kernel.org/lkml/20200519214547.352050-1-a.darw...@linutronix.de [PATCH v2 00/18] https://lore.kernel.org/lkml/20200608005729.1874024-1-a.darw...@linutronix.de

Re: [PATCH] vhost: Fix documentation

2020-06-29 Thread Jason Wang
On 2020/6/30 下午1:29, Eli Cohen wrote: Fix documentation to match actual function prototypes "end" used instead of "last". Fix that. Signed-off-by: Eli Cohen --- Acked-by: Jason Wang Thanks drivers/vhost/iotlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] vhost: Fix documentation

2020-06-29 Thread Eli Cohen
Fix documentation to match actual function prototypes "end" used instead of "last". Fix that. Signed-off-by: Eli Cohen --- drivers/vhost/iotlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/iotlb.c b/drivers/vhost/iotlb.c index 1f0ca6e44410..0d4213a54a88

RE: [PATCH/RFC] net: ethernet: ravb: Try to wake subqueue instead of stop on timeout

2020-06-29 Thread Yoshihiro Shimoda
Hello! > From: Sergei Shtylyov, Sent: Monday, June 29, 2020 5:40 PM > > Hello! > > On 29.06.2020 8:24, Yoshihiro Shimoda wrote: > > > From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM > > > > According to the report of [1], this driver is possible to cause > > the fol

Re: [PATCH v5 bpf-next 0/5] bpf: Introduce minimal support for sleepable progs

2020-06-29 Thread Andrii Nakryiko
On Mon, Jun 29, 2020 at 9:34 PM Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > v4->v5: > - addressed Andrii's feedback. > > v3->v4: > - fixed synchronize_rcu_tasks_trace() usage and accelerated with > synchronize_rcu_mult(). > - removed redundant synchronize_rcu(). Otherwise it won't

Re: [PATCH bpf] bpf: enforce BPF ringbuf size to be the power of 2

2020-06-29 Thread Andrii Nakryiko
On Mon, Jun 29, 2020 at 9:47 PM Alexei Starovoitov wrote: > > On Mon, Jun 29, 2020 at 3:19 PM Andrii Nakryiko wrote: > > > > BPF ringbuf assumes the size to be a multiple of page size and the power of > > 2 value. The latter is important to avoid division while calculating > > position > > insid

Re: [PATCH v7 08/11] thermal: Explicitly enable non-changing thermal zone devices

2020-06-29 Thread Amit Kucheria
On Mon, Jun 29, 2020 at 5:59 PM Andrzej Pietrasiewicz wrote: > > Some thermal zone devices never change their state, so they should be > always enabled. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Amit Kucheria > --- > drivers/net/ethernet/chelsio/cxgb4/cxgb4_thermal.c | 8 +++

Re: [PATCH net] xsk: remove cheap_dma optimization

2020-06-29 Thread Christoph Hellwig
On Mon, Jun 29, 2020 at 05:18:38PM +0200, Daniel Borkmann wrote: > On 6/29/20 5:10 PM, Björn Töpel wrote: >> On 2020-06-29 15:52, Daniel Borkmann wrote: >>> >>> Ok, fair enough, please work with DMA folks to get this properly integrated >>> and >>> restored then. Applied, thanks! >> >> Daniel, you

Re: [PATCH bpf-next 2/2] selftests/bpf: allow substituting custom vmlinux.h for selftests build

2020-06-29 Thread Yonghong Song
On 6/29/20 5:47 PM, Andrii Nakryiko wrote: Similarly to bpftool Makefile, allow to specify custom location of vmlinux.h to be used during the build. This allows simpler testing setups with checked-in pre-generated vmlinux.h. Signed-off-by: Andrii Nakryiko Acked-by: Yonghong Song

Re: [PATCH] igb: reinit_locked() should be called with rtnl_lock

2020-06-29 Thread Francesco Ruggeri
> Would you mind adding a fixes tag here? Probably: > > Fixes: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver") That seems to be the commit that introduced the driver in 2.6.25. I am not familiar with the history of the driver to tell if this was a day 1 problem or if it became an i

Re: [PATCH bpf] bpf: enforce BPF ringbuf size to be the power of 2

2020-06-29 Thread Alexei Starovoitov
On Mon, Jun 29, 2020 at 3:19 PM Andrii Nakryiko wrote: > > BPF ringbuf assumes the size to be a multiple of page size and the power of > 2 value. The latter is important to avoid division while calculating position > inside the ring buffer and using (N-1) mask instead. This patch fixes omission >

[PATCH net-next] net: dsa: Improve subordinate PHY error message

2020-06-29 Thread Florian Fainelli
It is not very informative to know the DSA master device when a subordinate network device fails to get its PHY setup. Provide the device name and capitalize PHY while we are it. Signed-off-by: Florian Fainelli --- net/dsa/slave.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

Re: [PATCH v2 4/4] staging: qlge: replace pr_err with netdev_err

2020-06-29 Thread Benjamin Poirier
On 2020-06-30 01:43 +0800, Coiby Xu wrote: > On Mon, Jun 29, 2020 at 02:30:04PM +0900, Benjamin Poirier wrote: > > On 2020-06-27 22:58 +0800, Coiby Xu wrote: > > [...] > > > void ql_dump_qdev(struct ql_adapter *qdev) > > > { > > > @@ -1611,99 +1618,100 @@ void ql_dump_qdev(struct ql_adapter *qdev

[PATCH v5 bpf-next 4/5] libbpf: support sleepable progs

2020-06-29 Thread Alexei Starovoitov
From: Alexei Starovoitov Pass request to load program as sleepable via ".s" suffix in the section name. If it happens in the future that all map types and helpers are allowed with BPF_F_SLEEPABLE flag "fmod_ret/" and "lsm/" can be aliased to "fmod_ret.s/" and "lsm.s/" to make all lsm and fmod_ret

[PATCH v5 bpf-next 2/5] bpf: Introduce sleepable BPF programs

2020-06-29 Thread Alexei Starovoitov
From: Alexei Starovoitov Introduce sleepable BPF programs that can request such property for themselves via BPF_F_SLEEPABLE flag at program load time. In such case they will be able to use helpers like bpf_copy_from_user() that might sleep. At present only fentry/fexit/fmod_ret and lsm programs c

[PATCH v5 bpf-next 3/5] bpf: Add bpf_copy_from_user() helper.

2020-06-29 Thread Alexei Starovoitov
From: Alexei Starovoitov Sleepable BPF programs can now use copy_from_user() to access user memory. Signed-off-by: Alexei Starovoitov Acked-by: Andrii Nakryiko --- include/linux/bpf.h| 1 + include/uapi/linux/bpf.h | 11 ++- kernel/bpf/helpers.c | 22 +

[PATCH v5 bpf-next 5/5] selftests/bpf: Add sleepable tests

2020-06-29 Thread Alexei Starovoitov
From: Alexei Starovoitov Modify few tests to sanity test sleepable bpf functionality. Running 'bench trig-fentry-sleep' vs 'bench trig-fentry' and 'perf report': sleepable with SRCU: 3.86% bench [k] __srcu_read_unlock 3.22% bench [k] __srcu_read_lock 0.92% bench [k] bpf_p

[PATCH v5 bpf-next 1/5] bpf: Remove redundant synchronize_rcu.

2020-06-29 Thread Alexei Starovoitov
From: Alexei Starovoitov bpf_free_used_maps() or close(map_fd) will trigger map_free callback. bpf_free_used_maps() is called after bpf prog is no longer executing: bpf_prog_put->call_rcu->bpf_prog_free->bpf_free_used_maps. Hence there is no need to call synchronize_rcu() to protect map elements.

[PATCH v5 bpf-next 0/5] bpf: Introduce minimal support for sleepable progs

2020-06-29 Thread Alexei Starovoitov
From: Alexei Starovoitov v4->v5: - addressed Andrii's feedback. v3->v4: - fixed synchronize_rcu_tasks_trace() usage and accelerated with synchronize_rcu_mult(). - removed redundant synchronize_rcu(). Otherwise it won't be clear why synchronize_rcu_tasks_trace() is not needed in free_map callb

Re: [PATCH v4 bpf-next 2/4] bpf: introduce helper bpf_get_task_stack()

2020-06-29 Thread Alexei Starovoitov
On Sun, Jun 28, 2020 at 10:58 PM Song Liu wrote: > > Introduce helper bpf_get_task_stack(), which dumps stack trace of given > task. This is different to bpf_get_stack(), which gets stack track of > current task. One potential use case of bpf_get_task_stack() is to call > it from bpf_iter__task an

Re: KASAN: use-after-free Read in nl8NUM_dump_wpan_phy (2)

2020-06-29 Thread Cong Wang
#syz fix: genetlink: get rid of family->attrbuf

Re: KASAN: vmalloc-out-of-bounds Read in tipc_nl_publ_dump

2020-06-29 Thread Cong Wang
#syz fix: genetlink: get rid of family->attrbuf

Re: KASAN: use-after-free Read in tipc_nl_node_dump_monitor_peer (2)

2020-06-29 Thread Cong Wang
#syz fix: genetlink: get rid of family->attrbuf

Re: KASAN: vmalloc-out-of-bounds Read in netdev_name_node_lookup_rcu

2020-06-29 Thread Cong Wang
#syz fix: genetlink: get rid of family->attrbuf

Re: KASAN: vmalloc-out-of-bounds Read in __nla_validate_parse

2020-06-29 Thread Cong Wang
#syz fix: genetlink: get rid of family->attrbuf

Re: KASAN: vmalloc-out-of-bounds Read in __cfg8NUM_wpan_dev_from_attrs

2020-06-29 Thread Cong Wang
#syz fix: genetlink: get rid of family->attrbuf

Re: KASAN: use-after-free Read in devlink_get_from_attrs

2020-06-29 Thread Cong Wang
#syz fix: genetlink: get rid of family->attrbuf

Re: KASAN: use-after-free Read in tipc_nl_publ_dump (2)

2020-06-29 Thread Cong Wang
#syz fix: genetlink: get rid of family->attrbuf

Re: KASAN: use-after-free Read in dev_get_by_name

2020-06-29 Thread Cong Wang
#syz fix: genetlink: get rid of family->attrbuf

Re: KASAN: use-after-free Read in netdev_name_node_lookup_rcu

2020-06-29 Thread Cong Wang
#syz fix: genetlink: get rid of family->attrbuf

Re: [PATCH bpf-next] libbpf: make bpf_endian co-exist with vmlinux.h

2020-06-29 Thread Andrii Nakryiko
On Mon, Jun 29, 2020 at 8:09 PM Alexei Starovoitov wrote: > > On Mon, Jun 29, 2020 at 07:05:38PM -0700, Andrii Nakryiko wrote: > > Copy over few #defines from UAPI swab.h header to make all the rest of > > bpf_endian.h work and not rely on any extra headers. This way it can be used > > both with l

Re: [PATCH v4 bpf-next 5/5] selftests/bpf: Add sleepable tests

2020-06-29 Thread Andrii Nakryiko
On Mon, Jun 29, 2020 at 8:06 PM Alexei Starovoitov wrote: > > On Mon, Jun 29, 2020 at 06:25:38PM -0700, Andrii Nakryiko wrote: > > > > > + > > > +SEC("fentry.s/__x64_sys_setdomainname") > > > +int BPF_PROG(test_sys_setdomainname, struct pt_regs *regs) > > > +{ > > > + int buf = 0; > > > +

Re: [PATCH] of: of_mdio: count number of regitered phys

2020-06-29 Thread Florian Fainelli
On 6/29/2020 5:45 PM, Andrew Lunn wrote: > On Mon, Jun 29, 2020 at 10:26:36AM +0300, Claudiu Beznea wrote: >> In case of_mdiobus_register_phy()/of_mdiobus_register_device() >> returns -ENODEV for all PHYs in device tree or for all scanned >> PHYs there is a chance that of_mdiobus_register() to >

Re: KASAN: use-after-free Read in netdev_name_node_lookup_rcu

2020-06-29 Thread Cong Wang
On Mon, Jun 29, 2020 at 6:17 PM Jason A. Donenfeld wrote: > > Hey Cong, Hi, Jason > > I'm wondering if the below error is related to what you've been > looking at yesterday. AFAICT, there's a simple UaF on the attrbuf > passed to the start method. I recall recently you were working on the > lock

Re: [PATCH v4 bpf-next 1/5] bpf: Remove redundant synchronize_rcu.

2020-06-29 Thread Andrii Nakryiko
On Mon, Jun 29, 2020 at 7:56 PM Alexei Starovoitov wrote: > > On Mon, Jun 29, 2020 at 06:08:48PM -0700, Andrii Nakryiko wrote: > > On Mon, Jun 29, 2020 at 5:58 PM Andrii Nakryiko > > wrote: > > > > > > On Mon, Jun 29, 2020 at 5:35 PM Alexei Starovoitov > > > wrote: > > > > > > > > From: Alexei S

Re: [PATCH net-next 0/8] Add PAL support to smsc95xx

2020-06-29 Thread Florian Fainelli
On 6/29/2020 6:33 PM, Andrew Lunn wrote: > On Mon, Jun 29, 2020 at 07:55:24PM +, andre.ed...@microchip.com wrote: >> To allow to probe external phy drivers, this patchset adds use of >> Phy Abstraction Layer to smsc95xx driver. > > This is version 2 correct? Please put v2 in the Subject lin

[PATCH v1] Bluetooth: Fix kernel oops triggered by hci_adv_monitors_clear()

2020-06-29 Thread Miao-chen Chou
This fixes the kernel oops by removing unnecessary background scan update from hci_adv_monitors_clear() which shouldn't invoke any work queue. The following test was performed. - Run "rmmod btusb" and verify that no kernel oops is triggered. Signed-off-by: Miao-chen Chou Reviewed-by: Abhishek Pa

Re: [PATCH bpf-next 1/2] tools/bpftool: allow substituting custom vmlinux.h for the build

2020-06-29 Thread Yonghong Song
On 6/29/20 5:47 PM, Andrii Nakryiko wrote: In some build contexts (e.g., Travis CI build for outdated kernel), vmlinux.h, generated from available kernel, doesn't contain all the types necessary for BPF program compilation. For such set up, the most maintainable way to deal with this problem i

Re: [PATCH net-next 0/3] cls_flower: Offload unmasked key

2020-06-29 Thread Satish
Hi David, Thank you so much for providing your review comments. We decided to withdraw this patch for the time being. We'll resubmit this patch addressing all your comments with the driver code in future". On Sat, Jun 20, 2020 at 1:42 AM David Miller wrote: > > > You are giving no context on wh

Re: [PATCH bpf] bpf: enforce BPF ringbuf size to be the power of 2

2020-06-29 Thread Yonghong Song
On 6/29/20 3:17 PM, Andrii Nakryiko wrote: BPF ringbuf assumes the size to be a multiple of page size and the power of 2 value. The latter is important to avoid division while calculating position inside the ring buffer and using (N-1) mask instead. This patch fixes omission to enforce power-o

Re: [PATCH bpf-next] libbpf: make bpf_endian co-exist with vmlinux.h

2020-06-29 Thread Alexei Starovoitov
On Mon, Jun 29, 2020 at 07:05:38PM -0700, Andrii Nakryiko wrote: > Copy over few #defines from UAPI swab.h header to make all the rest of > bpf_endian.h work and not rely on any extra headers. This way it can be used > both with linux header includes, as well with a vmlinux.h. This has been > a fre

Re: [PATCH v4 bpf-next 5/5] selftests/bpf: Add sleepable tests

2020-06-29 Thread Alexei Starovoitov
On Mon, Jun 29, 2020 at 06:25:38PM -0700, Andrii Nakryiko wrote: > > > + > > +SEC("fentry.s/__x64_sys_setdomainname") > > +int BPF_PROG(test_sys_setdomainname, struct pt_regs *regs) > > +{ > > + int buf = 0; > > + long ret; > > + > > + ret = bpf_copy_from_user(&buf, sizeof(buf),

Re: [PATCH v4 bpf-next 2/5] bpf: Introduce sleepable BPF programs

2020-06-29 Thread Alexei Starovoitov
On Mon, Jun 29, 2020 at 06:15:41PM -0700, Andrii Nakryiko wrote: > > > > +/* when rcu_read_lock_trace is held it means that some sleepable bpf > > program is > > + * running. Those programs can use bpf arrays and preallocated hash maps. > > These > > + * map types are waiting on programs to compl

Re: [PATCH v4 bpf-next 1/5] bpf: Remove redundant synchronize_rcu.

2020-06-29 Thread Alexei Starovoitov
On Mon, Jun 29, 2020 at 06:08:48PM -0700, Andrii Nakryiko wrote: > On Mon, Jun 29, 2020 at 5:58 PM Andrii Nakryiko > wrote: > > > > On Mon, Jun 29, 2020 at 5:35 PM Alexei Starovoitov > > wrote: > > > > > > From: Alexei Starovoitov > > > > > > bpf_free_used_maps() or close(map_fd) will trigger ma

[PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct

2020-06-29 Thread wenxu
From: wenxu The fragment packets do defrag in act_ct module. The reassembled packet over the mtu in the act_mirred. This big packet should be fragmented to send out. Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct") Signed-off-by: wenxu --- This patch is based on http://patchwork.ozlabs.or

RE: [PATCH 2/2] can: flexcan: add support for ISO CAN-FD

2020-06-29 Thread Joakim Zhang
> -Original Message- > From: Michael Walle > Sent: 2020年6月30日 2:18 > To: linux-...@vger.kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org > Cc: Wolfgang Grandegger ; Marc Kleine-Budde > ; David S . Miller ; Jakub > Kicinski ; Joakim Zhang ; > dl-linux-imx ; Michael Walle

[PATCH net-next] hinic: remove unused but set variable

2020-06-29 Thread Luo bin
remove unused but set variable to avoid auto build test WARNING Signed-off-by: Luo bin Reported-by: kernel test robot --- .../net/ethernet/huawei/hinic/hinic_ethtool.c | 18 -- .../net/ethernet/huawei/hinic/hinic_sriov.c| 2 -- 2 files changed, 20 deletions(-) diff --git

RE: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

2020-06-29 Thread Joakim Zhang
> -Original Message- > From: Michael Walle > Sent: 2020年6月30日 0:23 > To: Marc Kleine-Budde > Cc: Joakim Zhang ; linux-...@vger.kernel.org; > dl-linux-imx ; netdev@vger.kernel.org > Subject: Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature > > Hi Marc, > > > I've cleaned

Re: [PATCH net-next] icmp: support rfc 4884

2020-06-29 Thread Willem de Bruijn
On Mon, Jun 29, 2020 at 8:37 PM Tom Herbert wrote: > > On Mon, Jun 29, 2020 at 4:07 PM Eric Dumazet wrote: > > > > > > > > On 6/29/20 2:30 PM, Willem de Bruijn wrote: > > > On Mon, Jun 29, 2020 at 5:15 PM Eric Dumazet > > > wrote: > > >> > > >> > > >> > > >> On 6/29/20 9:57 AM, Willem de Bruijn

Re: linux-next: build failures after merge of the vfs tree

2020-06-29 Thread Herbert Xu
On Tue, Jun 30, 2020 at 11:58:57AM +1000, Stephen Rothwell wrote: > > > > OK, here's a patch for both of these together: > > > > > > diff --git a/arch/s390/lib/test_unwind.c b/arch/s390/lib/test_unwind.c > > > index 32b7a30b2485..eb382ceaa116 100644 > > > --- a/arch/s390/lib/test_unwind.c > > > ++

[PATCH bpf-next] libbpf: make bpf_endian co-exist with vmlinux.h

2020-06-29 Thread Andrii Nakryiko
Copy over few #defines from UAPI swab.h header to make all the rest of bpf_endian.h work and not rely on any extra headers. This way it can be used both with linux header includes, as well with a vmlinux.h. This has been a frequent complaint from users, that need this header. Signed-off-by: Andrii

Re: linux-next: build failures after merge of the vfs tree

2020-06-29 Thread Stephen Rothwell
Hi all, On Thu, 18 Jun 2020 10:08:51 +1000 Stephen Rothwell wrote: > > On Wed, 17 Jun 2020 17:38:45 +1000 Herbert Xu > wrote: > > > > On Wed, Jun 17, 2020 at 05:31:02PM +1000, Stephen Rothwell wrote: > > > > > > > > > > Presumably another include needed: > > > > > > > > > > arch/s390/lib/t

Re: [PATCH v4 bpf-next 00/14] bpf: Add d_path helper

2020-06-29 Thread Andrii Nakryiko
On Thu, Jun 25, 2020 at 4:47 PM Jiri Olsa wrote: > > hi, > adding d_path helper to return full path for 'path' object. > > In a preparation for that, this patchset also adds support for BTF ID > whitelists, because d_path can't be called from any probe due to its > locks usage. The whitelists allo

Re: [PATCH v4 bpf-next 07/14] bpf: Allow nested BTF object to be refferenced by BTF object + offset

2020-06-29 Thread Andrii Nakryiko
On Thu, Jun 25, 2020 at 4:49 PM Jiri Olsa wrote: > > Adding btf_struct_address function that takes 2 BTF objects > and offset as arguments and checks whether object A is nested > in object B on given offset. > > This function will be used when checking the helper function > PTR_TO_BTF_ID arguments

Re: [PATCH v4 bpf-next 14/14] selftests/bpf: Add test for resolve_btfids

2020-06-29 Thread Andrii Nakryiko
On Thu, Jun 25, 2020 at 4:48 PM Jiri Olsa wrote: > > Adding test to resolve_btfids tool, that: > - creates binary with BTF IDs list and set > - process the binary with resolve_btfids tool > - verifies that correct BTF ID values are in place > > Signed-off-by: Jiri Olsa > --- > tools/testin

kernel BUG at net/l2tp/l2tp_core.c:LINE!

2020-06-29 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15db7bb510 kernel config: https://syzkaller.appspot.com/x/.config?x=be4578b3f1083656 das

Re: [PATCH net-next 0/8] Add PAL support to smsc95xx

2020-06-29 Thread Andrew Lunn
On Mon, Jun 29, 2020 at 07:55:24PM +, andre.ed...@microchip.com wrote: > To allow to probe external phy drivers, this patchset adds use of > Phy Abstraction Layer to smsc95xx driver. This is version 2 correct? Please put v2 in the Subject line. Also, list here, what has changed since v1.

Re: [PATCH v4 bpf-next 12/14] selftests/bpf: Add verifier test for d_path helper

2020-06-29 Thread Andrii Nakryiko
On Thu, Jun 25, 2020 at 4:48 PM Jiri Olsa wrote: > > Adding verifier test for attaching tracing program and > calling d_path helper from within and testing that it's > allowed for dentry_open function and denied for 'd_path' > function with appropriate error. > > Signed-off-by: Jiri Olsa > --- A

[net-next v2 01/13] igc: Add initial EEE support

2020-06-29 Thread Jeff Kirsher
From: Sasha Neftin IEEE802.3az-2010 Energy Efficient Ethernet has been approved as standard (September 2010) and the driver can enable and disable it via ethtool. Disable the feature by default on parts which support it. Add enable/disable eee options. tx-lpi, tx-timer and advertise not supported

[net-next v2 09/13] igc: Add LPI counters

2020-06-29 Thread Jeff Kirsher
From: Sasha Neftin Add EEE TX LPI and EEE RX LPI counters. A EEE TX LPI event occurs when the transmitter enters EEE (IEEE 802.3az) LPI state. A EEE RX LPI event occurs when the receiver detect link partner entry into EEE(IEEE 802.3az) LPI state. Signed-off-by: Sasha Neftin Tested-by: Aaron Bro

[net-next v2 03/13] igc: Clean up Rx timestamping logic

2020-06-29 Thread Jeff Kirsher
From: Andre Guedes Differently from I210, I225 doesn't report Rx timestamps via the TS bit Rx descriptor + RXSTMPL/RXSTMPH registers mechanism. Rx timestamps are reported in the packet buffer only, which is implemented by igc_ptp_rx_ pktstamp(). So this patch removes igc_ptp_rx_rgtstamp() and all

[net-next v2 06/13] igc: Remove UDP filter setup in PTP code

2020-06-29 Thread Jeff Kirsher
From: Andre Guedes As implemented in igc_ethtool_get_ts_info(), igc only supports HWTSTAMP_ FILTER_ALL so any HWTSTAMP_FILTER_* option the user may set falls back to HWTSTAMP_FILTER_ALL. HWTSTAMP_FILTER_ALL is implemented via Rx Time Sync Control (TSYNCRXCTL) configuration which timestamps all i

[net-next v2 11/13] igc: Refactor the igc_power_down_link()

2020-06-29 Thread Jeff Kirsher
From: Sasha Neftin Currently the implementation of igc_power_down_link() method was just calling igc_power_down_phy_copper_base() method. We can just call igc_power_down_phy_copper_base() method directly. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- driv

[net-next v2 07/13] igc: Refactor igc_ptp_set_timestamp_mode()

2020-06-29 Thread Jeff Kirsher
From: Andre Guedes Current igc_ptp_set_timestamp_mode() logic is a bit tangled since it handles many different hardware configurations in one single place, making it harder to follow. This patch untangles that code by breaking it into helper functions. Quick note about the hw->mac.type check whi

[net-next v2 05/13] igc: Check __IGC_PTP_TX_IN_PROGRESS instead of ptp_tx_skb

2020-06-29 Thread Jeff Kirsher
From: Andre Guedes The __IGC_PTP_TX_IN_PROGRESS flag indicates we have a pending Tx timestamp. In some places, instead of checking that flag, we check adapter->ptp_tx_skb. This patch fixes those places to use the flag. Quick note about igc_ptp_tx_hwtstamp() change: when that function is called,

[net-next v2 13/13] igc: Remove checking media type during MAC initialization

2020-06-29 Thread Jeff Kirsher
From: Sasha Neftin i225 device support only copper mode. There is no point to check media type in the igc_config_fc_after_link_up() method. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_mac.c | 8 +++- 1 file changed

[net-next v2 04/13] igc: Remove duplicate code in Tx timestamp handling

2020-06-29 Thread Jeff Kirsher
From: Andre Guedes The functions igc_ptp_tx_hang() and igc_ptp_tx_work() have duplicate code which handles Tx timestamp timeouts. This patch does a trivial refactoring by moving that code to its own function and reusing it. Signed-off-by: Andre Guedes Tested-by: Aaron Brown Signed-off-by: Jeff

[net-next v2 02/13] igc: Add initial LTR support

2020-06-29 Thread Jeff Kirsher
From: Sasha Neftin The LTR message on the PCIe inform the requested latency on which the PCIe must become active to the downstream PCIe port of the system. This patch provide recommended LTR parameters by i225 specification. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jef

[net-next v2 12/13] igc: Remove unneeded check for copper media type

2020-06-29 Thread Jeff Kirsher
From: Sasha Neftin PHY of the i225 device support only copper mode. There is no point to check media type in the igc_power_up_link() method. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_main.c | 3 +-- 1 file changed, 1

[net-next v2 10/13] igc: Remove TCP segmentation TX fail counter

2020-06-29 Thread Jeff Kirsher
From: Sasha Neftin TCP segmentation TX context fail counter is not applicable for i225 devices. This patch comes to clean up this counter. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_mac.c | 1 - drivers/net/ethernet/i

[net-next v2 08/13] igc: Fix Rx timestamp disabling

2020-06-29 Thread Jeff Kirsher
From: Andre Guedes When Rx timestamping is enabled, we set the timestamp bit in SRRCTL register for each queue, but we don't clear it when disabling. This patch fixes igc_ptp_disable_rx_timestamp() accordingly. Also, this patch gets rid of igc_ptp_enable_tstamp_rxqueue() and igc_ptp_enable_tstam

[net-next v2 00/13][pull request] 1GbE Intel Wired LAN Driver Updates 2020-06-29

2020-06-29 Thread Jeff Kirsher
This series contains updates to only the igc driver. Sasha added Energy Efficient Ethernet (EEE) support and Latency Tolerance Reporting (LTR) support for the igc driver. Added Low Power Idle (LPI) counters and cleaned up unused TCP segmentation counters. Removed igc_power_down_link() and call igc

Re: [PATCH net-next 5/8] smsc95xx: use PAL framework read/write functions

2020-06-29 Thread Andrew Lunn
On Mon, Jun 29, 2020 at 01:12:37PM +, andre.ed...@microchip.com wrote: > Use functions phy_read and phy_write instead of smsc95xx_mdio_read and > smsc95xx_mdio_write respectively. > > Signed-off-by: Andre Edich > --- > drivers/net/usb/smsc95xx.c | 33 + > 1 fi

Re: [PATCH v4 bpf-next 5/5] selftests/bpf: Add sleepable tests

2020-06-29 Thread Andrii Nakryiko
On Mon, Jun 29, 2020 at 5:35 PM Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > Modify few tests to sanity test sleepable bpf functionality. > > Running 'bench trig-fentry-sleep' vs 'bench trig-fentry' and 'perf report': > sleepable with SRCU: >3.86% bench [k] __srcu_read_unlo

Re: [PATCH net-next 3/8] smsc95xx: add PAL support to use external PHY drivers

2020-06-29 Thread Andrew Lunn
> +static int smsc95xx_start_phy(struct usbnet *dev) > +{ > + struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev- > >data[0]); > + struct net_device *net = dev->net; > + int ret; > + > + ret = smsc95xx_reset(dev); > + if (ret < 0) > + return ret; > + > +

  1   2   3   4   5   >