Re: [PATCHv2 net] tc-testing: update geneve options match in tunnel_key unit tests

2020-06-18 Thread Simon Horman
On Fri, Jun 19, 2020 at 11:24:45AM +0800, Hangbin Liu wrote: > Since iproute2 commit f72c3ad00f3b ("tc: m_tunnel_key: add options > support for vxlan"), the geneve opt output use key word "geneve_opts" > instead of "geneve_opt". To make compatibility for both old and new > iproute2, let's accept bo

Re: [PATCH iproute2] tc: m_tunnel_key: fix geneve opt output

2020-06-18 Thread Simon Horman
On Fri, Jun 19, 2020 at 10:25:24AM +0800, Hangbin Liu wrote: > On Thu, Jun 18, 2020 at 12:51:08PM +0200, Simon Horman wrote: > > On Thu, Jun 18, 2020 at 06:44:20PM +0800, Hangbin Liu wrote: > > > Commit f72c3ad00f3b changed the geneve option output from "geneve_opt" > > > to "geneve_opts", which ma

Re: [PATCH v5 2/3] dt-bindings: net: mscc-vsc8531: add optional clock properties

2020-06-18 Thread Heiko Stuebner
Am Freitag, 19. Juni 2020, 07:01:58 CEST schrieb Florian Fainelli: > > On 6/18/2020 5:11 AM, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > Some mscc ethernet phys have a configurable clock output, so describe the > > generic properties to access them in devicetrees. > > > > Signed-off-

Re: [Patch net] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-06-18 Thread Zefan Li
On 2020/6/19 5:09, Cong Wang wrote: > On Thu, Jun 18, 2020 at 12:36 PM Roman Gushchin wrote: >> >> On Thu, Jun 18, 2020 at 12:19:13PM -0700, Cong Wang wrote: >>> On Wed, Jun 17, 2020 at 6:44 PM Zefan Li wrote: Cc: Roman Gushchin Thanks for fixing this. On 2020/6/17

[net 0/4][pull request] Intel Wired LAN Driver Updates 2020-06-18

2020-06-18 Thread Jeff Kirsher
This series contains fixes to ixgbe, i40e and ice driver. Ciara fixes up the ixgbe, i40e and ice drivers to protect access when allocating and freeing the rings. In addition, made use of READ_ONCE when reading the rings prior to accessing the statistics pointer. Björn fixes a crash where the rec

[net 4/4] i40e: fix crash when Rx descriptor count is changed

2020-06-18 Thread Jeff Kirsher
From: Björn Töpel When the AF_XDP buffer allocator was introduced, the Rx SW ring "rx_bi" allocation was moved from i40e_setup_rx_descriptors() function, and was instead done in the i40e_configure_rx_ring() function. This broke the ethtool set_ringparam() hook for changing the Rx descriptor coun

[net 2/4] i40e: protect ring accesses with READ- and WRITE_ONCE

2020-06-18 Thread Jeff Kirsher
From: Ciara Loftus READ_ONCE should be used when reading rings prior to accessing the statistics pointer. Introduce this as well as the corresponding WRITE_ONCE usage when allocating and freeing the rings, to ensure protected access. Signed-off-by: Ciara Loftus Tested-by: Andrew Bowers Signed-

[net 1/4] ixgbe: protect ring accesses with READ- and WRITE_ONCE

2020-06-18 Thread Jeff Kirsher
From: Ciara Loftus READ_ONCE should be used when reading rings prior to accessing the statistics pointer. Introduce this as well as the corresponding WRITE_ONCE usage when allocating and freeing the rings, to ensure protected access. Signed-off-by: Ciara Loftus Tested-by: Andrew Bowers Signed-

[net 3/4] ice: protect ring accesses with WRITE_ONCE

2020-06-18 Thread Jeff Kirsher
From: Ciara Loftus The READ_ONCE macro is used when reading rings prior to accessing the statistics pointer. The corresponding WRITE_ONCE usage when allocating and freeing the rings to ensure protected access was not in place. Introduce this. Signed-off-by: Ciara Loftus Tested-by: Andrew Bowers

[v2,net-next] net: qos offload add flow status with dropped count

2020-06-18 Thread Po Liu
From: Po Liu This patch adds a drop frames counter to tc flower offloading. Reporting h/w dropped frames is necessary for some actions. Some actions like police action and the coming introduced stream gate action would produce dropped frames which is necessary for user. Status update shows how ma

bpf test error: KASAN: use-after-free Write in afs_wake_up_async_call

2020-06-18 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:ef7232da ionic: export features for vlans to use git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=173214d110 kernel config: https://syzkaller.appspot.com/x/.config?x=b8ad29058cb749bc dashboard link: http

RE: [PATCH/RFC] net: ethernet: ravb: Try to wake subqueue instead of stop on timeout

2020-06-18 Thread Yoshihiro Shimoda
Hello! > From: Sergei Shtylyov, Sent: Monday, June 15, 2020 5:13 PM > > Hello! > > On 15.06.2020 8:58, Yoshihiro Shimoda wrote: > > >> From: Yoshihiro Shimoda, Sent: Tuesday, May 26, 2020 6:47 PM > >> > >> According to the report of [1], this driver is possible to cause > >> the following error

Re: [PATCH] bpf: Allow small structs to be type of function argument

2020-06-18 Thread Yonghong Song
On 6/18/20 7:04 PM, Alexei Starovoitov wrote: On Thu, Jun 18, 2020 at 5:26 PM John Fastabend wrote: foo(int a, __int128 b) would put a in r0 and b in r2 and r3 leaving a hole in r1. But that was some old reference manual and might no longer be the case This should not happen if clang

Re: [PATCH net-next v8 4/5] net: dp83869: Add RGMII internal delay configuration

2020-06-18 Thread kernel test robot
cb8e59cc87201af93dfbb6c3dccc8fcad72a09c2 config: s390-randconfig-r014-20200618 (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 487ca07fcc75d52755c9fe2ee05bcb3b6c44) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp

Re: [PATCH v5 2/3] dt-bindings: net: mscc-vsc8531: add optional clock properties

2020-06-18 Thread Florian Fainelli
On 6/18/2020 5:11 AM, Heiko Stuebner wrote: > From: Heiko Stuebner > > Some mscc ethernet phys have a configurable clock output, so describe the > generic properties to access them in devicetrees. > > Signed-off-by: Heiko Stuebner > --- > Documentation/devicetree/bindings/net/mscc-phy-vsc85

[PATCH net 1/2] of: of_mdio: Correct loop scanning logic

2020-06-18 Thread Florian Fainelli
Commit 209c65b61d94 ("drivers/of/of_mdio.c:fix of_mdiobus_register()") introduced a break of the loop on the premise that a successful registration should exit the loop. The premise is correct but not to code, because rc && rc != -ENODEV is just a special error condition, that means we would exit t

[PATCH net 2/2] net: phy: Check harder for errors in get_phy_id()

2020-06-18 Thread Florian Fainelli
Commit 02a6efcab675 ("net: phy: allow scanning busses with missing phys") added a special condition to return -ENODEV in case -ENODEV or -EIO was returned from the first read of the MII_PHYSID1 register. In case the MDIO bus data line pull-up is not strong enough, the MDIO bus controller will not

[PATCH net 0/2] net: phy: MDIO bus scanning fixes

2020-06-18 Thread Florian Fainelli
Hi all, This patch series fixes two problems with the current MDIO bus scanning logic which was identified while moving from 4.9 to 5.4 on devices that do rely on scanning the MDIO bus at runtime because they use pluggable cards. Florian Fainelli (2): of: of_mdio: Correct loop scanning logic

Re: [PATCH 11/11] selftests/bpf: Add test for d_path helper

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:07 AM Jiri Olsa wrote: > > Adding test for d_path helper which is pretty much > copied from Wenbo Zhang's test for bpf_get_fd_path, > which never made it in. > > I've failed so far to compile the test with > kernel header, so for now adding 'struct file' with f_path > me

Re: [PATCH net] net: increment xmit_recursion level in dev_direct_xmit()

2020-06-18 Thread Eric Dumazet
On 6/18/20 8:48 PM, David Miller wrote: > From: Eric Dumazet > Date: Wed, 17 Jun 2020 22:23:25 -0700 > >> Back in commit f60e5990d9c1 ("ipv6: protect skb->sk accesses >> from recursive dereference inside the stack") Hannes added code >> so that IPv6 stack would not trust skb->sk for typical ca

Re: [PATCH 10/11] selftests/bpf: Add verifier test for d_path helper

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > > Adding verifier test for attaching tracing program and > calling d_path helper from within and testing that it's > allowed for dentry_open function and denied for 'd_path' > function with appropriate error. > > Signed-off-by: Jiri Olsa > --- >

Re: [PATCH 09/11] bpf: Add d_path helper

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:07 AM Jiri Olsa wrote: > > Adding d_path helper function that returns full path > for give 'struct path' object, which needs to be the > kernel BTF 'path' object. > > The helper calls directly d_path function. > > Updating also bpf.h tools uapi header and adding > 'path'

Re: [PATCH 08/11] bpf: Add BTF whitelist support

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > > Adding support to define 'whitelist' of BTF IDs, which is > also sorted. > > Following defines sorted list of BTF IDs that is accessible > within kernel code as btf_whitelist_d_path and its count is > in btf_whitelist_d_path_cnt variable. > >

Re: [PATCH 06/11] bpf: Do not pass enum bpf_access_type to btf_struct_access

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > > There's no need for it. > > Signed-off-by: Jiri Olsa > --- It matches bpf_verifier_ops->btf_struct_access, though, which, I think, actually allows write access for some special cases. So I think we should keep it. > include/linux/bpf.h | 1

Re: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-18 Thread Andrii Nakryiko
On Thu, Jun 18, 2020 at 7:08 PM Alexei Starovoitov wrote: > > On Thu, Jun 18, 2020 at 5:47 PM Arnaldo Carvalho de Melo > wrote: > > > > > > > > On June 18, 2020 9:40:32 PM GMT-03:00, Andrii Nakryiko > > wrote: > > >On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > > >> > > >> The btfid tool w

Re: [PATCH net-next v2 0/5] cxgb4: add support to read/write flash

2020-06-18 Thread David Miller
From: Vishal Kulkarni Date: Thu, 18 Jun 2020 11:35:51 +0530 > This series of patches adds support to read/write different binary images > of serial flash present in Chelsio terminator. > > V2 changes: > Patch 1: No change > Patch 2: No change > Patch 3: Fix 4 compilation warnings reported by C=1

Re: [PATCH net] net: increment xmit_recursion level in dev_direct_xmit()

2020-06-18 Thread David Miller
From: Eric Dumazet Date: Wed, 17 Jun 2020 22:23:25 -0700 > Back in commit f60e5990d9c1 ("ipv6: protect skb->sk accesses > from recursive dereference inside the stack") Hannes added code > so that IPv6 stack would not trust skb->sk for typical cases > where packet goes through 'standard' xmit path

Re: [PATCH v2 net-next 0/6] net: tso: expand to UDP support

2020-06-18 Thread David Miller
From: Eric Dumazet Date: Wed, 17 Jun 2020 20:53:20 -0700 > With QUIC getting more attention these days, it is worth > implementing UDP direct segmentation, the same we did for TCP. > > Drivers will need to advertize NETIF_F_GSO_UDP_L4 so that > GSO stack does not do the (more expensive) segmenta

Re: [PATCH net] net: dsa: bcm_sf2: Fix node reference count

2020-06-18 Thread David Miller
From: Florian Fainelli Date: Wed, 17 Jun 2020 20:42:44 -0700 > of_find_node_by_name() will do an of_node_put() on the "from" argument. > With CONFIG_OF_DYNAMIC enabled which checks for device_node reference > counts, we would be getting a warning like this: ... > Fix this by adding a of_node_get

Re: [PATCH 0/5] net: hns3: a bundle of minor cleanup and fixes

2020-06-18 Thread David Miller
From: Barry Song Date: Thu, 18 Jun 2020 13:02:06 +1200 > some minor changes to either improve the readability or make the code align > with linux APIs better. Series applied, thanks.

Re: [PATCH][next] mISDN: hfcsusb: Use struct_size() helper

2020-06-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 17 Jun 2020 18:15:57 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by:

Re: [PATCH net-next 0/8] r8169: smaller improvements again

2020-06-18 Thread David Miller
From: Heiner Kallweit Date: Wed, 17 Jun 2020 22:50:11 +0200 > Series includes a number of different smaller improvements. Series applied, thanks Heiner.

Re: [PATCH] lan743x: allow mac address to come from dt

2020-06-18 Thread David Miller
From: Tim Harvey Date: Wed, 17 Jun 2020 15:59:10 -0700 > If a valid mac address is present in dt, use that before using > CSR's or a random mac address. > > Signed-off-by: Tim Harvey Applied to net-next, thanks.

Re: [PATCH resend net] net: ethtool: add missing NETIF_F_GSO_FRAGLIST feature string

2020-06-18 Thread David Miller
From: Alexander Lobakin Date: Wed, 17 Jun 2020 20:42:47 + > Commit 3b33583265ed ("net: Add fraglist GRO/GSO feature flags") missed > an entry for NETIF_F_GSO_FRAGLIST in netdev_features_strings array. As > a result, fraglist GSO feature is not shown in 'ethtool -k' output and > can't be toggl

Re: [PATCH][next] enetc: Use struct_size() helper in kzalloc()

2020-06-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 17 Jun 2020 13:53:17 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by:

Re: [PATCH v2] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-06-18 Thread David Miller
From: David Christensen Date: Wed, 17 Jun 2020 11:51:17 -0700 > The driver function tg3_io_error_detected() calls napi_disable twice, > without an intervening napi_enable, when the number of EEH errors exceeds > eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock. > > Add c

[PATCH net-next 0/9] devlink: Support get,set mac address of a port function

2020-06-18 Thread Parav Pandit
Currently, ip link set dev vfhas below few limitations. 1. Command is limited to set VF parameters only. It cannot set the default MAC address for the PCI PF. 2. It can be set only on system where PCI SR-IOV capability exists. In smartnic based system, eswitch of a NIC resides on a different

[PATCH net-next 5/9] net/mlx5: E-switch, Introduce and use eswitch support check helper

2020-06-18 Thread Parav Pandit
Introduce an helper routine to get esw from a devlink device and use it at eswitch callbacks and in subsequent patch. Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan --- .../net/ethernet/mellanox/mlx5/core/eswitch.c | 23 +++ .../net/ethernet/mellanox/mlx5/core/eswitch.h | 1 + .../mell

[PATCH net-next 2/9] net/devlink: Support querying hardware address of port function

2020-06-18 Thread Parav Pandit
PCI PF and VF devlink port can manage the function represented by a devlink port. Enable users to query port function's hardware address. Example of a PCI VF port which supports a port function: $ devlink port show pci/:06:00.0/2 pci/:06:00.0/2: type eth netdev enp6s0pf0vf1 flavour pcivf

[PATCH net-next 1/9] net/devlink: Prepare devlink port functions to fill extack

2020-06-18 Thread Parav Pandit
Prepare devlink port related functions to optionally fill up the extack information which will be used in subsequent patch by port function attribute(s). Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- net/core/devlink.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)

[PATCH net-next 7/9] net/mlx5: E-switch, Support querying port function mac address

2020-06-18 Thread Parav Pandit
Support querying mac address of the eswitch devlink port function. Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan Acked-by: Jiri Pirko --- .../net/ethernet/mellanox/mlx5/core/devlink.c | 1 + .../net/ethernet/mellanox/mlx5/core/eswitch.c | 43 +++ .../net/ethernet/mellanox

[PATCH net-next 6/9] net/mlx5: Move helper to eswitch layer

2020-06-18 Thread Parav Pandit
To use port number to port index conversion at eswitch level, move it to eswitch header. Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 8 +--- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 7 +++ 2 files changed, 8 inser

[PATCH net-next 8/9] net/mlx5: Split mac address setting function for using state_lock

2020-06-18 Thread Parav Pandit
Refactor mac address setting function to let caller hold the necessary state_lock mutex, so that subsequent patch and use this helper routine. Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan --- .../net/ethernet/mellanox/mlx5/core/eswitch.c | 38 --- 1 file changed, 24 insert

[PATCH net-next 4/9] net/mlx5: Constify mac address pointer

2020-06-18 Thread Parav Pandit
Since none of the functions need to modify the input mac address, constify them. Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/v

[PATCH net-next 9/9] net/mlx5: E-switch, Supporting setting devlink port function mac address

2020-06-18 Thread Parav Pandit
Enable user to set mac address of the PCI PF and VF port function. Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan Acked-by: Jiri Pirko --- .../net/ethernet/mellanox/mlx5/core/devlink.c | 1 + .../net/ethernet/mellanox/mlx5/core/eswitch.c | 36 +++ .../net/ethernet/mellanox

[PATCH net-next 3/9] net/devlink: Support setting hardware address of port function

2020-06-18 Thread Parav Pandit
PCI PF and VF devlink port can manage the function represented by a devlink port. Allow users to set port function's hardware address. Example of a PCI VF port which supports a port function: $ devlink port show pci/:06:00.0/2 pci/:06:00.0/2: type eth netdev enp6s0pf0vf1 flavour pcivf pfn

Re: [PATCH net-next v8 5/5] net: phy: DP83822: Add setting the fixed internal delay

2020-06-18 Thread kernel test robot
Hi Dan, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Dan-Murphy/RGMII-Internal-delay-common-property/20200619-051238 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cb8e

Re: [PATCH net v3] bareudp: Fixed multiproto mode configuration

2020-06-18 Thread David Miller
From: Martin Varghese Date: Wed, 17 Jun 2020 22:30:23 +0530 > From: Martin > > Code to handle multiproto configuration is missing. > > Fixes: 4b5f67232d95 ("net: Special handling for IP & MPLS") > Signed-off-by: Martin Applied and queued up for v5.7 -stable, thanks.

Re: [PATCH net-next] net: napi: remove useless stack trace

2020-06-18 Thread David Miller
From: Eric Dumazet Date: Wed, 17 Jun 2020 09:40:51 -0700 > Whenever a buggy NAPI driver returns more than its budget, > we emit a stack trace that is of no use, since it does not > tell which driver is buggy. > > Instead, emit a message giving the function name, and a > descriptive message. > >

Re: [PATCH net 0/2] s390/qeth: fixes 2020-06-17

2020-06-18 Thread David Miller
From: Julian Wiedmann Date: Wed, 17 Jun 2020 16:54:51 +0200 > please apply the following patch series for qeth to netdev's net tree. > > The first patch fixes a regression in the error handling for a specific > cmd type. I have some follow-ups queued up for net-next to clean this > up properly..

Re: [PATCH net 0/2] mptcp: cope with syncookie on MP_JOINs

2020-06-18 Thread David Miller
From: Paolo Abeni Date: Wed, 17 Jun 2020 12:08:55 +0200 > Currently syncookies on MP_JOIN connections are not handled correctly: the > connections fallback to TCP and are kept alive instead of resetting them at > fallback time. > > The first patch propagates the required information up to syn_re

Re: [PATCH v2 01/02] net: phy: marvell: Add Marvell 88E1340 support

2020-06-18 Thread David Miller
These patches have been corrupted by your email client, try to apply what ended up in the mailing list and you will see, from "git am": Applying: net: phy: marvell: Add Marvell 88E1340 support error: corrupt patch at line 40

[PATCHv2 net] tc-testing: update geneve options match in tunnel_key unit tests

2020-06-18 Thread Hangbin Liu
Since iproute2 commit f72c3ad00f3b ("tc: m_tunnel_key: add options support for vxlan"), the geneve opt output use key word "geneve_opts" instead of "geneve_opt". To make compatibility for both old and new iproute2, let's accept both "geneve_opt" and "geneve_opts". Suggested-by: Davide Caratti Sig

Re: [PATCH net 0/3] Fix VLAN checks for SJA1105 DSA tc-flower filters

2020-06-18 Thread David Miller
From: Vladimir Oltean Date: Wed, 17 Jun 2020 02:58:40 +0300 > From: Vladimir Oltean > > This fixes a ridiculous situation where the driver, in VLAN-unaware > mode, would refuse accepting any tc filter: > > tc filter replace dev sw1p3 ingress flower skip_sw \ > dst_mac 42:be:24:9b:76:20 \

Re: [PATCH][next] net: stmmac: selftests: Use struct_size() helper in kzalloc()

2020-06-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 16 Jun 2020 18:03:28 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by:

Re: [PATCH net v3 0/2] two fixes for 'act_gate' control plane

2020-06-18 Thread David Miller
From: Davide Caratti Date: Tue, 16 Jun 2020 22:25:19 +0200 > - patch 1/2 attempts to fix the error path of tcf_gate_init() when users > try to configure 'act_gate' rules with wrong parameters > - patch 2/2 is a follow-up of a recent fix for NULL dereference in > the error path of tcf_gate_ini

Re: [PATCH net v3] ip_tunnel: fix use-after-free in ip_tunnel_lookup()

2020-06-18 Thread David Miller
From: Taehee Yoo Date: Tue, 16 Jun 2020 16:51:51 + > In the datapath, the ip_tunnel_lookup() is used and it internally uses > fallback tunnel device pointer, which is fb_tunnel_dev. > This pointer variable should be set to NULL when a fb interface is deleted. > But there is no routine to set

Re: [PATCH net v2] ip6_gre: fix use-after-free in ip6gre_tunnel_lookup()

2020-06-18 Thread David Miller
From: Taehee Yoo Date: Tue, 16 Jun 2020 16:04:00 + > In the datapath, the ip6gre_tunnel_lookup() is used and it internally uses > fallback tunnel device pointer, which is fb_tunnel_dev. > This pointer variable should be set to NULL when a fb interface is deleted. > But there is no routine to

Re: [PATCH net v2] net: core: reduce recursion limit value

2020-06-18 Thread David Miller
From: Taehee Yoo Date: Tue, 16 Jun 2020 15:52:05 + > In the current code, ->ndo_start_xmit() can be executed recursively only > 10 times because of stack memory. > But, in the case of the vxlan, 10 recursion limit value results in > a stack overflow. > In the current code, the nested interfac

Re: [PATCH v2 net 0/2] Reapply DSA fix for dpaa-eth with proper Fixes: tag

2020-06-18 Thread David Miller
From: Vladimir Oltean Date: Tue, 16 Jun 2020 18:19:08 +0300 > From: Vladimir Oltean > > Joakim notified me that this fix breaks stable trees. > It turns out that my assessment about who-broke-who was wrong. > The real Fixes: tag should have been: > > Fixes: 060ad66f9795 ("dpaa_eth: change DMA

Re: [PATCH net] net: fix memleak in register_netdevice()

2020-06-18 Thread David Miller
From: Yang Yingliang Date: Tue, 16 Jun 2020 09:39:21 + > I got a memleak report when doing some fuzz test: ... > If call_netdevice_notifiers() failed, then rollback_registered() > calls netdev_unregister_kobject() which holds the kobject. The > reference cannot be put because the netdev won'

Re: [PATCH 2/2] net: ethernet: mvneta: Add 2500BaseX support for SoCs without comphy

2020-06-18 Thread David Miller
From: Sascha Hauer Date: Tue, 16 Jun 2020 10:31:40 +0200 > The older SoCs like Armada XP support a 2500BaseX mode in the datasheets > referred to as DR-SGMII (Double rated SGMII) or HS-SGMII (High Speed > SGMII). This is an upclocked 1000BaseX mode, thus > PHY_INTERFACE_MODE_2500BASEX is the appr

Re: [PATCH 1/2] net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy

2020-06-18 Thread David Miller
From: Sascha Hauer Date: Tue, 16 Jun 2020 10:31:39 +0200 > The MVNETA_SERDES_CFG register is only available on older SoCs like the > Armada XP. On newer SoCs like the Armada 38x the fields are moved to > comphy. This patch moves the writes to this register next to the comphy > initialization, so

Re: [PATCH net] net: dsa: bcm_sf2: Fix node reference count

2020-06-18 Thread David Miller
From: Andrew Lunn Date: Thu, 18 Jun 2020 14:56:40 +0200 > That if_find_node_by_name() does a put is not very intuitive. > Maybe document that as well in the kerneldocs? > > Reviewed-by: Andrew Lunn I've been complaining about the non-intuitiveness of the various OF interfaces for a long time.

Re: [PATCH net-next v8 2/5] net: phy: Add a helper to return the index for of the internal delay

2020-06-18 Thread kernel test robot
Hi Dan, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Dan-Murphy/RGMII-Internal-delay-common-property/20200619-051238 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cb8e59cc87

Re: [PATCH iproute2] tc: m_tunnel_key: fix geneve opt output

2020-06-18 Thread Hangbin Liu
On Thu, Jun 18, 2020 at 01:25:46PM +0200, Davide Caratti wrote: > On Thu, 2020-06-18 at 18:44 +0800, Hangbin Liu wrote: > > Commit f72c3ad00f3b changed the geneve option output from "geneve_opt" > > to "geneve_opts", which may break the program compatibility. Reset > > it back to geneve_opt. > > >

Re: [PATCH iproute2] tc: m_tunnel_key: fix geneve opt output

2020-06-18 Thread Hangbin Liu
On Thu, Jun 18, 2020 at 12:51:08PM +0200, Simon Horman wrote: > On Thu, Jun 18, 2020 at 06:44:20PM +0800, Hangbin Liu wrote: > > Commit f72c3ad00f3b changed the geneve option output from "geneve_opt" > > to "geneve_opts", which may break the program compatibility. Reset > > it back to geneve_opt. >

Re: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-18 Thread Alexei Starovoitov
On Thu, Jun 18, 2020 at 5:47 PM Arnaldo Carvalho de Melo wrote: > > > > On June 18, 2020 9:40:32 PM GMT-03:00, Andrii Nakryiko > wrote: > >On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > >> > >> The btfid tool will be used during the vmlinux linking, > >> so it's necessary it's ready for it.

Re: [PATCH] bpf: Allow small structs to be type of function argument

2020-06-18 Thread Alexei Starovoitov
On Thu, Jun 18, 2020 at 5:26 PM John Fastabend wrote: > > foo(int a, __int128 b) > > would put a in r0 and b in r2 and r3 leaving a hole in r1. But that > was some old reference manual and might no longer be the case > in reality. Perhaps just spreading hearsay, but the point is we > should say

Re: RATE not being printed on tc -s class show dev XXXX

2020-06-18 Thread Cong Wang
On Tue, Jun 16, 2020 at 7:06 AM Roberto J. Blandino Cisneros wrote: > I am seing "rate 0bit". > > But installing from debian package iproute2 i got nothing so i decide to > compile iproute2 using version 5.7.0 > > But my output is the same as below: You either need to enable /sys/module/sch_htb/p

Re: [PATCH 05/11] bpf: Remove btf_id helpers resolving

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > > Now when we moved the helpers btf_id into .BTF_ids section, > we can remove the code that resolve those IDs in runtime. > > Signed-off-by: Jiri Olsa > --- Nice! :) BTW, have you looked at bpf_ctx_convert stuff? Would we be able to replace it

Re: [PATCH 03/11] bpf: Add btf_ids object

2020-06-18 Thread Andrii Nakryiko
On Thu, Jun 18, 2020 at 5:56 PM Andrii Nakryiko wrote: > > On Tue, Jun 16, 2020 at 3:05 AM Jiri Olsa wrote: > > > > Adding support to generate .BTF_ids section that would > > hold various BTF IDs list for verifier. > > > > Adding macros help to define lists of BTF IDs placed in > > .BTF_ids secti

Re: [PATCH 03/11] bpf: Add btf_ids object

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:05 AM Jiri Olsa wrote: > > Adding support to generate .BTF_ids section that would > hold various BTF IDs list for verifier. > > Adding macros help to define lists of BTF IDs placed in > .BTF_ids section. They are initially filled with zeros > (during compilation) and reso

Re: [PATCH 03/11] bpf: Add btf_ids object

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:05 AM Jiri Olsa wrote: > > Adding support to generate .BTF_ids section that would > hold various BTF IDs list for verifier. > > Adding macros help to define lists of BTF IDs placed in > .BTF_ids section. They are initially filled with zeros > (during compilation) and reso

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread kernel test robot
Hi Heiko, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on sparc-next/master net-next/master net/master linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-18 Thread Arnaldo Carvalho de Melo
On June 18, 2020 9:40:32 PM GMT-03:00, Andrii Nakryiko wrote: >On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: >> >> The btfid tool will be used during the vmlinux linking, >> so it's necessary it's ready for it. >> > >Seeing troubles John runs into, I wonder if it maybe would be better >to

RE: [net-next 13/15] iecm: Add ethtool

2020-06-18 Thread Michael, Alice
> -Original Message- > From: Jakub Kicinski > Sent: Thursday, June 18, 2020 4:50 PM > To: Kirsher, Jeffrey T > Cc: da...@davemloft.net; Michael, Alice ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Brady, Alan ; Burra, Phani R ; > Hay, Joshua A ; Chittim, Madhu > ;

Re: [PATCH 02/11] bpf: Compile btfid tool at kernel compilation start

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > > The btfid tool will be used during the vmlinux linking, > so it's necessary it's ready for it. > Seeing troubles John runs into, I wonder if it maybe would be better to add it to pahole instead? It's already a dependency for anything BTF-relate

Re: [PATCH bpf-next 1/2] bpf: switch most helper return values from 32-bit int to 64-bit long

2020-06-18 Thread John Fastabend
John Fastabend wrote: > Andrii Nakryiko wrote: > > On Thu, Jun 18, 2020 at 11:58 AM John Fastabend > > wrote: [...] > > That would be great. Self-tests do work, but having more testing with > > real-world application would certainly help as well. > > Thanks for all the follow up. > > I ran the

Re: [PATCH 01/11] bpf: Add btfid tool to resolve BTF IDs in ELF object

2020-06-18 Thread Andrii Nakryiko
On Tue, Jun 16, 2020 at 3:06 AM Jiri Olsa wrote: > > The btfid tool scans Elf object for .BTF_ids section and > resolves its symbols with BTF IDs. naming is hard and subjective, I know. But given this actively modifies ELF file it probably should indicate this in the name. So something like patch

RE: [net-next 13/15] iecm: Add ethtool

2020-06-18 Thread Brady, Alan
> -Original Message- > From: Michal Kubecek > Sent: Thursday, June 18, 2020 2:17 PM > To: netdev@vger.kernel.org > Cc: Kirsher, Jeffrey T ; da...@davemloft.net; > Michael, Alice ; nhor...@redhat.com; > sassm...@redhat.com; Brady, Alan ; Burra, Phani R > ; Hay, Joshua A ; Chittim, > Madhu ;

Re: [PATCH] bpf: Allow small structs to be type of function argument

2020-06-18 Thread John Fastabend
Andrii Nakryiko wrote: > On Thu, Jun 18, 2020 at 3:50 PM John Fastabend > wrote: > > > > Jiri Olsa wrote: > > > On Wed, Jun 17, 2020 at 04:20:54PM -0700, John Fastabend wrote: > > > > Jiri Olsa wrote: > > > > > This way we can have trampoline on function > > > > > that has arguments with types li

Re: af_decnet.c: missing semi-colon and/or indentation?

2020-06-18 Thread Randy Dunlap
On 6/18/20 4:35 PM, Eric Dumazet wrote: > > > On 6/18/20 4:19 PM, Randy Dunlap wrote: >> >> Please see lines 1250-1251. >> >> >> case TIOCINQ: >> lock_sock(sk); >> skb = skb_peek(&scp->other_receive_queue); >> if (skb) { >> amount =

Re: [PATCH bpf 2/2] selftests/bpf: add variable-length data concatenation pattern test

2020-06-18 Thread Andrii Nakryiko
On Thu, Jun 18, 2020 at 4:48 PM John Fastabend wrote: > > Andrii Nakryiko wrote: > > On Thu, Jun 18, 2020 at 12:09 PM John Fastabend > > wrote: > > > > > > Andrii Nakryiko wrote: > > > > Add selftest that validates variable-length data reading and > > > > concatentation > > > > with one big shar

Re: [PATCH] bpf: Allow small structs to be type of function argument

2020-06-18 Thread Andrii Nakryiko
On Thu, Jun 18, 2020 at 3:50 PM John Fastabend wrote: > > Jiri Olsa wrote: > > On Wed, Jun 17, 2020 at 04:20:54PM -0700, John Fastabend wrote: > > > Jiri Olsa wrote: > > > > This way we can have trampoline on function > > > > that has arguments with types like: > > > > > > > > kuid_t uid > > > >

Re: [net-next 13/15] iecm: Add ethtool

2020-06-18 Thread Jakub Kicinski
On Wed, 17 Jun 2020 22:13:42 -0700 Jeff Kirsher wrote: > +static const struct ethtool_ops iecm_ethtool_ops = { > + .get_drvinfo= iecm_get_drvinfo, > + .get_msglevel = iecm_get_msglevel, > + .set_msglevel = iecm_set_msglevel, > + .get_coalesce

Re: [PATCH bpf 2/2] selftests/bpf: add variable-length data concatenation pattern test

2020-06-18 Thread John Fastabend
Andrii Nakryiko wrote: > On Thu, Jun 18, 2020 at 12:09 PM John Fastabend > wrote: > > > > Andrii Nakryiko wrote: > > > Add selftest that validates variable-length data reading and > > > concatentation > > > with one big shared data array. This is a common pattern in production > > > use for > >

Re: [net-next PATCH] net: Avoid overwriting valid skb->napi_id

2020-06-18 Thread Nambiar, Amritha
On 6/18/2020 3:29 PM, Eric Dumazet wrote: On Thu, Jun 18, 2020 at 2:21 PM Amritha Nambiar wrote: This will be useful to allow busy poll for tunneled traffic. In case of busy poll for sessions over tunnels, the underlying physical device's queues need to be polled. Tunnels schedule NAPI either

Re: [PATCH net-next 1/3] net/sched: Introduce action hash

2020-06-18 Thread Daniel Borkmann
On 6/19/20 12:15 AM, Ariel Levkovich wrote: Allow setting a hash value to a packet for a future match. The action will determine the packet's hash result according to the selected hash type. The first option is to select a basic asymmetric l4 hash calculation on the packet headers which will ei

Re: [PATCH net-next v8 2/5] net: phy: Add a helper to return the index for of the internal delay

2020-06-18 Thread Dan Murphy
Hello On 6/18/20 6:29 PM, kernel test robot wrote: Hi Dan, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Dan-Murphy/RGMII-Internal-delay-common-property/20200619-051238 base: https://git.kernel.org/p

Re: af_decnet.c: missing semi-colon and/or indentation?

2020-06-18 Thread Eric Dumazet
On 6/18/20 4:19 PM, Randy Dunlap wrote: > > Please see lines 1250-1251. > > > case TIOCINQ: > lock_sock(sk); > skb = skb_peek(&scp->other_receive_queue); > if (skb) { > amount = skb->len; > } else { >

Re: [PATCH 2/5] net: hns3: pointer type of buffer should be void

2020-06-18 Thread Jakub Kicinski
On Thu, 18 Jun 2020 13:02:08 +1200 Barry Song wrote: > Move the type of buffer address from unsigned char to void > > Signed-off-by: Barry Song > --- > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- > drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 2 +- > 2 files changed, 2 insertion

Re: [PATCH bpf-next 1/2] bpf: switch most helper return values from 32-bit int to 64-bit long

2020-06-18 Thread John Fastabend
Andrii Nakryiko wrote: > On Thu, Jun 18, 2020 at 11:58 AM John Fastabend > wrote: > > > > Andrii Nakryiko wrote: > > > On Wed, Jun 17, 2020 at 11:49 PM John Fastabend > > > wrote: > > > > > > > > Andrii Nakryiko wrote: > > > > > Switch most of BPF helper definitions from returning int to long. >

Re: [PATCH net-next v8 2/5] net: phy: Add a helper to return the index for of the internal delay

2020-06-18 Thread kernel test robot
Hi Dan, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Dan-Murphy/RGMII-Internal-delay-common-property/20200619-051238 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cb8e59cc87

af_decnet.c: missing semi-colon and/or indentation?

2020-06-18 Thread Randy Dunlap
Please see lines 1250-1251. case TIOCINQ: lock_sock(sk); skb = skb_peek(&scp->other_receive_queue); if (skb) { amount = skb->len; } else { skb_queue_walk(&sk->sk_receive_queue

RE: [net-next 02/15] iecm: Add framework set of header files

2020-06-18 Thread Michael, Alice
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Joe Perches > Sent: Wednesday, June 17, 2020 10:33 PM > To: Kirsher, Jeffrey T ; da...@davemloft.net > Cc: Michael, Alice ; netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com; Brady, Alan > ; Burra,

RE: [PATCH net-next 4/5] net: phy: add Lynx PCS MDIO module

2020-06-18 Thread Ioana Ciornei
> Subject: Re: [PATCH net-next 4/5] net: phy: add Lynx PCS MDIO module > > > Are there really instances where the ethernet driver has to manage > > multiple different types of PCSs? I am not sure this type of snippet > > of code is really going to occur. > > Hi Ioana > > The Marvell mv88e6390 fa

Re: [Patch net] net: change addr_list_lock back to static key

2020-06-18 Thread Vladimir Oltean
On Fri, 19 Jun 2020 at 01:46, Andrew Lunn wrote: > > > > Hi Vladimir > > > > > > So you are suggesting this? > > > > > > > > + ret = netdev_upper_dev_link(master, slave_dev, NULL); > > > > > > Andrew > > > > Yes, basically this: > > > > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > > in

Re: general protection fault in __bfs (2)

2020-06-18 Thread syzbot
syzbot suspects this bug was fixed by commit: commit 46ca11177ed593f39d534f8d2c74ec5344e90c11 Author: Amit Cohen Date: Thu May 21 12:11:45 2020 + selftests: mlxsw: qos_mc_aware: Specify arping timeout as an integer bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1315b0591

Re: [PATCH v1 3/3] net/fsl: enable extended scanning in xgmac_mdio

2020-06-18 Thread Florian Fainelli
On 6/17/2020 10:15 AM, Calvin Johnson wrote: > From: Jeremy Linton > > Since we know the xgmac hardware always has a c45 > complaint bus, lets try scanning for c22 capable > phys first. If we fail to find any, then it with > fall back to c45 automatically. s/complaint/compliant/ s/lets/let's/

  1   2   3   4   >