Re: [RFC PATCH net-next 07/10] mlxsw: spectrum_ethtool: Add link extended state

2020-06-08 Thread Amit Cohen
On 07-Jun-20 21:25, Florian Fainelli wrote: > > > On 6/7/2020 7:59 AM, Amit Cohen wrote: >> Implement .get_down_ext_state() as part of ethtool_ops. >> Query link down reason from PDDR register and convert it to ethtool >> ext_state. >> >> In case that more information than common ext_state is pro

Re: [PATCH AUTOSEL 5.7 264/274] vxlan: Avoid infinite loop when suppressing NS messages with invalid options

2020-06-08 Thread Ido Schimmel
On Mon, Jun 08, 2020 at 07:05:57PM -0400, Sasha Levin wrote: > From: Ido Schimmel > > [ Upstream commit 8066e6b449e050675df48e7c4b16c29f00507ff0 ] Hi, In the same patch set I also included a similar fix for the bridge module: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co

Re: [PATCH] bpf: alloc_record_per_cpu Add null check after malloc

2020-06-08 Thread Jesper Dangaard Brouer
On Sat, 6 Jun 2020 19:59:48 -0400 gaurav singh wrote: > Hi, > > The memset call is made right after malloc call. To fix this, add the null > check right after malloc and then do memset. > > Please find the patch below. The fix in your patch seem correct (although there are more places), but th

Re: [PATCH 3/9] net: wireless: ath: fix wiki website url

2020-06-08 Thread Kalle Valo
Flavio Suligoi wrote: > In some ath files, the wiki url is still the old > "wireless.kernel.org" instead of the new > "wireless.wiki.kernel.org" > > Signed-off-by: Flavio Suligoi > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 1141215c745b ath: fix wiki websi

Re: [PATCH] ath10k: Acquire tx_lock in tx error paths

2020-06-08 Thread Kalle Valo
Evan Green wrote: > ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock > is held. Acquire the lock in a couple of error paths when calling that > function to ensure this condition is met. > > Fixes: 6421969f248fd ("ath10k: refactor tx pending management") > Fixes: e62ee5c381c

Re: [PATCH] vhost/test: fix up after API change

2020-06-08 Thread Jason Wang
On 2020/6/9 下午1:53, Jason Wang wrote: On 2020/6/8 下午8:42, Michael S. Tsirkin wrote: Pass a flag to request kernel thread use. Fixes: 01fcb1cbc88e ("vhost: allow device that does not depend on vhost worker") Signed-off-by: Michael S. Tsirkin ---   drivers/vhost/test.c | 2 +-   1 file chang

Re: [PATCH 5/6] vdpa: introduce virtio pci driver

2020-06-08 Thread Jason Wang
On 2020/6/8 下午9:29, Michael S. Tsirkin wrote: On Mon, Jun 08, 2020 at 06:07:36PM +0800, Jason Wang wrote: On 2020/6/8 下午5:54, Michael S. Tsirkin wrote: On Mon, Jun 08, 2020 at 05:46:52PM +0800, Jason Wang wrote: On 2020/6/8 下午5:45, Michael S. Tsirkin wrote: On Mon, Jun 08, 2020 at 05:43:58P

Re: [PATCH] vhost/test: fix up after API change

2020-06-08 Thread Jason Wang
On 2020/6/8 下午8:42, Michael S. Tsirkin wrote: Pass a flag to request kernel thread use. Fixes: 01fcb1cbc88e ("vhost: allow device that does not depend on vhost worker") Signed-off-by: Michael S. Tsirkin --- drivers/vhost/test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH v2 1/2] net: sched: export __netdev_watchdog_up()

2020-06-08 Thread Valentin Longchamp
Since the quiesce/activate rework, __netdev_watchdog_up() is directly called in the ucc_geth driver. Unfortunately, this function is not available for modules and thus ucc_geth cannot be built as a module anymore. Fix it by exporting __netdev_watchdog_up(). Since the commit introducing the regres

[PATCH v2 2/2] net: sched: make the watchdog functions more coherent

2020-06-08 Thread Valentin Longchamp
Remove dev_watchdog_up() that directly called __netdev_watchdog_up() and rename dev_watchdog_down() to __netdev_watchdog_down() for symmetry. Signed-off-by: Valentin Longchamp --- net/sched/sch_generic.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/net/sched/sc

[PATCH iproute2 net-next 2/2] bridge: support for nexthop id in fdb entries

2020-06-08 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to assign a nexthop group id to an fdb entry. $bridge fdb add 02:02:00:00:00:13 dev vx10 nhid 102 self Signed-off-by: Roopa Prabhu --- bridge/fdb.c | 22 +++--- man/man8/bridge.8 | 13 ++--- 2 files changed, 29 insertions

[PATCH iproute2 net-next 0/2] support for fdb nexthop groups

2020-06-08 Thread Roopa Prabhu
From: Roopa Prabhu This series adds iproute2 support for recently added kernel fdb nexthop groups example: /* create fdb nexthop group */ $ip nexthop add id 12 via 172.16.1.2 fdb $ip nexthop add id 13 via 172.16.1.3 fdb $ip nexthop add id 102 group 12/13 fdb /* assign nexthop group to fdb en

[PATCH iproute2 net-next 1/2] ipnexthop: support for fdb nexthops

2020-06-08 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support to add and delete ecmp nexthops of type fdb. Such nexthops can be linked to vxlan fdb entries. $ip nexthop add id 12 via 172.16.1.2 fdb $ip nexthop add id 13 via 172.16.1.3 fdb $ip nexthop add id 102 group 12/13 fdb $bridge fdb add 02:02:00:00:00:13 de

[PATCH net 1/1] ionic: wait on queue start until after IFF_UP

2020-06-08 Thread Shannon Nelson
The netif_running() test looks at __LINK_STATE_START which gets set before ndo_open() is called, there is a window of time between that and when the queues are actually ready to be run. If ionic_check_link_status() notices that the link is up very soon after netif_running() becomes true, it might

Re: [PATCHv4 bpf-next 0/2] xdp: add dev map multicast support

2020-06-08 Thread Hangbin Liu
On Mon, Jun 08, 2020 at 05:32:54PM +0200, Toke Høiland-Jørgensen wrote: > Hangbin Liu writes: > > > On Thu, Jun 04, 2020 at 06:02:54PM +0200, Toke Høiland-Jørgensen wrote: > >> Hangbin Liu writes: > >> > >> > On Thu, Jun 04, 2020 at 02:37:23PM +0200, Toke Høiland-Jørgensen > >> > wrote:

[PATCH v2 net] nexthop: Fix fdb labeling for groups

2020-06-08 Thread David Ahern
fdb nexthops are marked with a flag. For standalone nexthops, a flag was added to the nh_info struct. For groups that flag was added to struct nexthop when it should have been added to the group information. Fix by removing the flag from the nexthop struct and adding a flag to nh_group that mirrors

Re: [PATCH net] nexthops: Fix fdb labeling for groups

2020-06-08 Thread David Ahern
On 6/8/20 6:21 PM, David Ahern wrote: > fdb nexthops are marked with a flag. For standalone nexthops, a flag was > added to the nh_info struct. For groups that flag was added to struct > nexthop when it should have been added to the group information. Fix > by removing the flag from the nexthop str

Re: [PATCH net 0/2] rxrpc: Fix hang due to missing notification

2020-06-08 Thread David Miller
From: David Howells Date: Mon, 08 Jun 2020 19:49:47 +0100 > Here's a fix for AF_RXRPC. Occasionally calls hang because there are > circumstances in which rxrpc generate a notification when a call is > completed - primarily because initial packet transmission failed and the > call was killed off

Re: [PATCH net] selftests/net: in timestamping, strncpy needs to preserve null byte

2020-06-08 Thread David Miller
From: Tanner Love Date: Mon, 8 Jun 2020 15:37:15 -0400 > From: tannerlove > > If user passed an interface option longer than 15 characters, then > device.ifr_name and hwtstamp.ifr_name became non-null-terminated > strings. The compiler warned about this: > > timestamping.c:353:2: warning: ‘st

Re: [PATCH net v2] mptcp: bugfix for RM_ADDR option parsing

2020-06-08 Thread David Miller
From: Geliang Tang Date: Mon, 8 Jun 2020 18:47:54 +0800 > In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the > "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet: > > +---+---+---+ > |Subtype|(resvd)| Address ID | > +---+---

Re: [patch 1/1] net-zerocopy: use vm_insert_pages() for tcp rcv zerocopy

2020-06-08 Thread David Miller
From: a...@linux-foundation.org Date: Sun, 07 Jun 2020 18:54:41 -0700 > From: Arjun Roy > Subject: net-zerocopy: use vm_insert_pages() for tcp rcv zerocopy > > Use vm_insert_pages() for tcp receive zerocopy. Spin lock cycles (as > reported by perf) drop from a couple of percentage points to a f

Re: [PATCH 1/1] cxgb4: fix cxgb4_uld_in_use() not used error

2020-06-08 Thread David Miller
From: Heinrich Schuchardt Date: Mon, 8 Jun 2020 02:58:23 +0200 > When building without CONFIG_CHELSIO_TLS_DEVICE a build error occurs: > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:666:13: error: > ‘cxgb4_uld_in_use’ defined but not used [-Werror=unused-function] > 666 | static bool cxgb

Re: [PATCH net-next 1/4] xfrm: bail early on slave pass over skb

2020-06-08 Thread David Miller
net-next is closed, thank you

Re: [PATCH net] net/tls(TLS_SW): Add selftest for 'chunked' sendfile test

2020-06-08 Thread David Miller
From: Pooja Trivedi Date: Fri, 5 Jun 2020 16:01:18 + > This selftest tests for cases where sendfile's 'count' > parameter is provided with a size greater than the intended > file size. > > Motivation: When sendfile is provided with 'count' parameter > value that is greater than the size of

Re: [PATCH bpf 0/3] bpf: avoid using/returning file descriptor value zero

2020-06-08 Thread Alexei Starovoitov
On Mon, Jun 08, 2020 at 06:51:12PM +0200, Jesper Dangaard Brouer wrote: > Make it easier to handle UAPI/kABI extensions by avoid BPF using/returning > file descriptor value zero. Use this in recent devmap extension to keep > older applications compatible with newer kernels. > > For special type ma

[PATCH AUTOSEL 5.7 003/274] ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb

2020-06-08 Thread Sasha Levin
From: Qiujun Huang [ Upstream commit 19d6c375d671ce9949a864fb9a03e19f5487b4d3 ] Add barrier to accessing the stack array skb_pool. The case reported by syzbot: https://lore.kernel.org/linux-usb/3d7c1505a2168...@google.com BUG: KASAN: stack-out-of-bounds in ath9k_hif_usb_rx_stream dr

[PATCH AUTOSEL 5.7 004/274] ath9k: Fix use-after-free Write in ath9k_htc_rx_msg

2020-06-08 Thread Sasha Levin
From: Qiujun Huang [ Upstream commit e4ff08a4d727146bb6717a39a8d399d834654345 ] Write out of slab bounds. We should check epid. The case reported by syzbot: https://lore.kernel.org/linux-usb/6ac55b05a1c05...@google.com BUG: KASAN: use-after-free in htc_process_conn_rsp drivers/net/w

[PATCH AUTOSEL 5.7 005/274] ath9k: Fix use-after-free Read in htc_connect_service

2020-06-08 Thread Sasha Levin
From: Qiujun Huang [ Upstream commit ced21a4c726bdc60b1680c050a284b08803bc64c ] The skb is consumed by htc_send_epid, so it needn't release again. The case reported by syzbot: https://lore.kernel.org/linux-usb/590f6b05a1c05...@google.com usb 1-1: ath9k_htc: Firmware ath9k_htc/htc_9

[PATCH AUTOSEL 5.7 010/274] igc: Fix default MAC address filter override

2020-06-08 Thread Sasha Levin
From: Andre Guedes [ Upstream commit ac9156b27564a089ec52f526bfcb59f61c34e7c6 ] This patch fixes a bug when the user adds the first MAC address filter via ethtool NFC mechanism. When the first MAC address filter is added, it overwrites the default MAC address filter configured at RAL[0] and RAH

[PATCH AUTOSEL 5.7 021/274] net: ethernet: ti: fix return value check in k3_cppi_desc_pool_create_name()

2020-06-08 Thread Sasha Levin
From: Wei Yongjun [ Upstream commit 2ac757e4152e3322a04a6dfb3d1fa010d3521abf ] In case of error, the function gen_pool_create() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 93a76530316a ("net: ethernet: ti: introduce a

[PATCH AUTOSEL 5.7 023/274] selftests/bpf: Copy runqslower to OUTPUT directory

2020-06-08 Thread Sasha Levin
From: Veronika Kabatova [ Upstream commit b26d1e2b60284dc9f66ffad9ccd5c5da1100bb4b ] $(OUTPUT)/runqslower makefile target doesn't actually create runqslower binary in the $(OUTPUT) directory. As lib.mk expects all TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in the OUTPU

[PATCH AUTOSEL 5.7 028/274] net: atlantic: make hw_get_regs optional

2020-06-08 Thread Sasha Levin
From: Mark Starovoytov [ Upstream commit d0f23741c202c685447050713907f3be39a985ee ] This patch fixes potential crash in case if hw_get_regs is NULL. Signed-off-by: Mark Starovoytov Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c

[PATCH AUTOSEL 5.7 035/274] rtw88: fix an issue about leak system resources

2020-06-08 Thread Sasha Levin
From: Dejin Zheng [ Upstream commit 191f6b08bfef24e1a9641eaac96ed030a7be4599 ] the related system resources were not released when pci_iomap() return error in the rtw_pci_io_mapping() function. add pci_release_regions() to fix it. Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver") Cc

[PATCH AUTOSEL 5.7 031/274] ath10k: remove the max_sched_scan_reqs value

2020-06-08 Thread Sasha Levin
From: Wen Gong [ Upstream commit d431f8939c1419854dfe89dd345387f5397c6edd ] The struct cfg80211_wowlan of NET_DETECT WoWLAN feature share the same struct cfg80211_sched_scan_request together with scheduled scan request feature, and max_sched_scan_reqs of wiphy is only used for sched scan, and at

[PATCH AUTOSEL 5.7 029/274] net: ena: fix error returning in ena_com_get_hash_function()

2020-06-08 Thread Sasha Levin
From: Arthur Kiyanovski [ Upstream commit e9a1de378dd46375f9abfd8de1e6f59ee114a793 ] In case the "func" parameter is NULL we now return "-EINVAL". This shouldn't happen in general, but when it does happen, this is the proper way to handle it. We also check func for NULL in the beginning of the

[PATCH AUTOSEL 5.7 044/274] mt76: mt7615: fix aid configuration in mt7615_mcu_wtbl_generic_tlv

2020-06-08 Thread Sasha Levin
From: Lorenzo Bianconi [ Upstream commit fdf433121f82766ff508a6f06665d2aca3e258d5 ] If the vif is running in station mode the aid will be passed by mac80211 using bss_conf.aid. Fix aid configuration in mt7615_mcu_wtbl_generic_tlv Fixes: 04b8e65922f6 ("mt76: add mac80211 driver for MT7615 PCIe-b

[PATCH AUTOSEL 5.7 048/274] ixgbe: Fix XDP redirect on archs with PAGE_SIZE above 4K

2020-06-08 Thread Sasha Levin
From: Jesper Dangaard Brouer [ Upstream commit 88eb0ee17b2ece64fcf6689a4557a5c2e7a89c4b ] The ixgbe driver have another memory model when compiled on archs with PAGE_SIZE above 4096 bytes. In this mode it doesn't split the page in two halves, but instead increment rx_buffer->page_offset by trues

[PATCH AUTOSEL 5.7 054/274] Bluetooth: Add SCO fallback for invalid LMP parameters error

2020-06-08 Thread Sasha Levin
From: Hsin-Yu Chao [ Upstream commit 56b5453a86203a44726f523b4133c1feca49ce7c ] Bluetooth PTS test case HFP/AG/ACC/BI-12-I accepts SCO connection with invalid parameter at the first SCO request expecting AG to attempt another SCO request with the use of "safe settings" for given codec, base on s

[PATCH AUTOSEL 5.7 058/274] ath11k: Fix some resource leaks in error path in 'ath11k_thermal_register()'

2020-06-08 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit 25ca180ad380a0c7286442a922e7fbcc6a9f6083 ] If 'thermal_cooling_device_register()' fails, we must undo what has been allocated so far. So we must go to 'err_thermal_destroy' instead of returning directly In case of error in 'ath11k_thermal_register()',

[PATCH AUTOSEL 5.7 071/274] batman-adv: Revert "disable ethtool link speed detection when auto negotiation off"

2020-06-08 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit 9ad346c90509ebd983f60da7d082f261ad329507 ] The commit 8c46fcd78308 ("batman-adv: disable ethtool link speed detection when auto negotiation off") disabled the usage of ethtool's link_ksetting when auto negotation was enabled due to invalid values when used

[PATCH AUTOSEL 5.7 075/274] ice: Change number of XDP TxQ to 0 when destroying rings

2020-06-08 Thread Sasha Levin
From: Marta Plantykow [ Upstream commit c8f135c6ee7851ad72bd4d877216950fcbd45fb6 ] When XDP Tx rings are destroyed the number of XDP Tx queues is not changing. This patch is changing this number to 0. Signed-off-by: Marta Plantykow Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher Signed-

[PATCH AUTOSEL 5.7 073/274] ice: Fix memory leak

2020-06-08 Thread Sasha Levin
From: Surabhi Boob [ Upstream commit 1aaef2bc4e0a5ce9e4dd86359e6a0bf52c6aa64f ] Handle memory leak on filter management initialization failure. Signed-off-by: Surabhi Boob Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- driver

[PATCH AUTOSEL 5.7 081/274] ice: fix PCI device serial number to be lowercase values

2020-06-08 Thread Sasha Levin
From: Paul M Stillwell Jr [ Upstream commit 1a9c561aa35534a03c0aa51c7fb1485731202a7c ] Commit ceb2f00707f9 ("ice: Use pci_get_dsn()") changed the code to use a new function to get the Device Serial Number. It also changed the case of the filename for loading a package on a specific NIC from lowe

[PATCH AUTOSEL 5.7 089/274] ath11k: fix error message to correctly report the command that failed

2020-06-08 Thread Sasha Levin
From: Colin Ian King [ Upstream commit 9a8074e3bcd7956ec6b4f7c26360af1b0b0abe38 ] Currently the error message refers to the command WMI_TWT_DIeABLE_CMDID which looks like a cut-n-paste mangled typo. Fix the message to match the command WMI_BSS_COLOR_CHANGE_ENABLE_CMDID that failed. Fixes: 5a032

[PATCH AUTOSEL 5.7 084/274] tun: correct header offsets in napi frags mode

2020-06-08 Thread Sasha Levin
From: Willem de Bruijn [ Upstream commit 96aa1b22bd6bb9fccf62f6261f390ed6f3e7967f ] Tun in IFF_NAPI_FRAGS mode calls napi_gro_frags. Unlike netif_rx and netif_gro_receive, this expects skb->data to point to the mac layer. But skb_probe_transport_header, __skb_get_hash_symmetric, and xdp_do_gene

[PATCH AUTOSEL 5.7 083/274] net: vmxnet3: fix possible buffer overflow caused by bad DMA value in vmxnet3_get_rss()

2020-06-08 Thread Sasha Levin
From: Jia-Ju Bai [ Upstream commit 3e1c6846b9e108740ef8a37be80314053f5dd52a ] The value adapter->rss_conf is stored in DMA memory, and it is assigned to rssConf, so rssConf->indTableSize can be modified at anytime by malicious hardware. Because rssConf->indTableSize is assigned to n, buffer over

[PATCH AUTOSEL 5.7 091/274] ath11k: Avoid mgmt tx count underflow

2020-06-08 Thread Sasha Levin
From: Sriram R [ Upstream commit 800113ff4b1d277c2b66ffc04d4d38f202a0d187 ] The mgmt tx count reference is incremented/decremented on every mgmt tx and on tx completion event from firmware. In case of an unexpected mgmt tx completion event from firmware, the counter would underflow. Avoid this b

[PATCH AUTOSEL 5.7 094/274] ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb

2020-06-08 Thread Sasha Levin
From: Qiujun Huang [ Upstream commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 ] In ath9k_hif_usb_rx_cb interface number is assumed to be 0. usb_ifnum_to_if(urb->dev, 0) But it isn't always true. The case reported by syzbot: https://lore.kernel.org/linux-usb/666c9c05a1c05...@google.c

[PATCH AUTOSEL 5.7 093/274] ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx

2020-06-08 Thread Sasha Levin
From: Qiujun Huang [ Upstream commit abeaa85054ff8cfe8b99aafc5c70ea067e5d0908 ] Free wmi later after cmd urb has been killed, as urb cb will access wmi. the case reported by syzbot: https://lore.kernel.org/linux-usb/0002fc05a1d61...@google.com BUG: KASAN: use-after-free in ath9k_wmi

[PATCH AUTOSEL 5.7 092/274] ath10k: fix kernel null pointer dereference

2020-06-08 Thread Sasha Levin
From: Venkateswara Naralasetty [ Upstream commit acb31476adc9ff271140cdd4d3c707ff0c97f5a4 ] Currently sta airtime is updated without any lock in case of host based airtime calculation. Which may result in accessing the invalid sta pointer in case of continuous station connect/disconnect. This p

[PATCH AUTOSEL 5.7 103/274] net: mscc: ocelot: deal with problematic MAC_ETYPE VCAP IS2 rules

2020-06-08 Thread Sasha Levin
From: Vladimir Oltean [ Upstream commit 89f9ffd3eb670bad1260bc579f5e13b8f2d5b3e0 ] By default, the VCAP IS2 will produce a single match for each frame, on the most specific classification. Example: a ping packet (ICMP over IPv4 over Ethernet) sent from an IP address of 10.0.0.1 and a MAC addres

[PATCH AUTOSEL 5.7 099/274] brcmfmac: fix wrong location to get firmware feature

2020-06-08 Thread Sasha Levin
From: Jaehoon Chung [ Upstream commit c57673852062428cdeabdd6501ac8b8e4c302067 ] sup_wpa feature is getting after setting feature_disable flag. If firmware is supported sup_wpa feature, it's always enabled regardless of feature_disable flag. Fixes: b8a64f0e96c2 ("brcmfmac: support 4-way handsh

[PATCH AUTOSEL 5.7 113/274] ath10k: add flush tx packets for SDIO chip

2020-06-08 Thread Sasha Levin
From: Wen Gong [ Upstream commit dd7fc5545bbafdbd6c1efdc996b61883b285bdc5 ] When station connected to AP, and run TX traffic such as TCP/UDP, and system enter suspend state, then mac80211 call ath10k_flush with set drop flag, recently it only send wmi peer flush to firmware and firmware will flu

[PATCH AUTOSEL 5.7 122/274] net/mlx4_core: Add missing iounmap() in error path

2020-06-08 Thread Sasha Levin
From: Zou Wei [ Upstream commit c90af587a9eee697e2d89683113707cada70116a ] This fixes the following coccicheck warning: drivers/net/ethernet/mellanox/mlx4/crdump.c:200:2-8: ERROR: missing iounmap; ioremap on line 190 and execution via conditional on line 198 Fixes: 7ef19d3b1d5e ("devlink: repo

[PATCH AUTOSEL 5.7 120/274] dpaa2-eth: fix return codes used in ndo_setup_tc

2020-06-08 Thread Sasha Levin
From: Jesper Dangaard Brouer [ Upstream commit b89c1e6bdc73f5775e118eb2ab778e75b262b30c ] Drivers ndo_setup_tc call should return -EOPNOTSUPP, when it cannot support the qdisc type. Other return values will result in failing the qdisc setup. This lead to qdisc noop getting assigned, which will

[PATCH AUTOSEL 5.7 125/274] ath11k: use GFP_ATOMIC under spin lock

2020-06-08 Thread Sasha Levin
From: Wei Yongjun [ Upstream commit 69c93f9674c97dc439cdc0527811f8ad104c2e35 ] A spin lock is taken here so we should use GFP_ATOMIC. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Signed-off-by: Wei Yongjun Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/

[PATCH AUTOSEL 5.7 126/274] Bluetooth: Adding driver and quirk defs for multi-role LE

2020-06-08 Thread Sasha Levin
From: Alain Michaud [ Upstream commit 220915857e29795ae5ba4222806268b4a99c19c1 ] This change adds the relevant driver and quirk to allow drivers to report the le_states as being trustworthy. This has historically been disabled as controllers did not reliably support this. In particular, this wi

[PATCH AUTOSEL 5.7 124/274] netfilter: nft_nat: return EOPNOTSUPP if type or flags are not supported

2020-06-08 Thread Sasha Levin
From: Pablo Neira Ayuso [ Upstream commit 0d7c83463fdf7841350f37960a7abadd3e650b41 ] Instead of EINVAL which should be used for malformed netlink messages. Fixes: eb31628e37a0 ("netfilter: nf_tables: Add support for IPv6 NAT") Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- n

[PATCH AUTOSEL 5.7 128/274] libbpf: Refactor map creation logic and fix cleanup leak

2020-06-08 Thread Sasha Levin
From: Andrii Nakryiko [ Upstream commit 2d39d7c56f115148b05d1d8c6b8698a5730c8b53 ] Factor out map creation and destruction logic to simplify code and especially error handling. Also fix map FD leak in case of partially successful map creation during bpf_object load operation. Fixes: 57a00f41644

[PATCH AUTOSEL 5.7 135/274] selftests/bpf: Add runqslower binary to .gitignore

2020-06-08 Thread Sasha Levin
From: Andrii Nakryiko [ Upstream commit e4e8f4d047fdcf7ac7d944e266e85d8041f16cd6 ] With recent changes, runqslower is being copied into selftests/bpf root directory. So add it into .gitignore. Fixes: b26d1e2b6028 ("selftests/bpf: Copy runqslower to OUTPUT directory") Signed-off-by: Andrii Nakry

[PATCH AUTOSEL 5.7 131/274] selftests/bpf: Fix memory leak in extract_build_id()

2020-06-08 Thread Sasha Levin
From: Andrii Nakryiko [ Upstream commit 9f56bb531a809ecaa7f0ddca61d2cf3adc1cb81a ] getline() allocates string, which has to be freed. Fixes: 81f77fd0deeb ("bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID") Signed-off-by: Andrii Nakryiko Signed-off-by: Alexei Starovoitov Cc: Song Liu

[PATCH AUTOSEL 5.7 133/274] libbpf: Fix huge memory leak in libbpf_find_vmlinux_btf_id()

2020-06-08 Thread Sasha Levin
From: Andrii Nakryiko [ Upstream commit 3521ffa2ee9a48c3236c93f54ae11c074490ebce ] BTF object wasn't freed. Fixes: a6ed02cac690 ("libbpf: Load btf_vmlinux only once per object.") Signed-off-by: Andrii Nakryiko Signed-off-by: Alexei Starovoitov Cc: KP Singh Link: https://lore.kernel.org/bpf/2

[PATCH AUTOSEL 5.7 132/274] selftests/bpf: Fix invalid memory reads in core_relo selftest

2020-06-08 Thread Sasha Levin
From: Andrii Nakryiko [ Upstream commit 13c908495e5d51718a6da84ae925fa2aac056380 ] Another one found by AddressSanitizer. input_len is bigger than actually initialized data size. Fixes: c7566a69695c ("selftests/bpf: Add field existence CO-RE relocs tests") Signed-off-by: Andrii Nakryiko Signed

[PATCH AUTOSEL 5.7 130/274] selftests/bpf: Fix memory leak in test selector

2020-06-08 Thread Sasha Levin
From: Andrii Nakryiko [ Upstream commit f25d5416d64c796aa639136eb0b076c8bd579b54 ] Free test selector substrings, which were strdup()'ed. Fixes: b65053cd94f4 ("selftests/bpf: Add whitelist/blacklist of test names to test_progs") Signed-off-by: Andrii Nakryiko Signed-off-by: Alexei Starovoitov

[PATCH AUTOSEL 5.7 129/274] selftests/bpf: Ensure test flavors use correct skeletons

2020-06-08 Thread Sasha Levin
From: Andrii Nakryiko [ Upstream commit 76148faa161e7cfb2d7719f35b37d7db4f3f8596 ] Ensure that test runner flavors include their own skeletons from / directory. Previously, skeletons generated for no-flavor test_progs were used. Apart from fixing correctness, this also makes it possible to compi

[PATCH AUTOSEL 5.7 134/274] selftests/bpf: Fix bpf_link leak in ns_current_pid_tgid selftest

2020-06-08 Thread Sasha Levin
From: Andrii Nakryiko [ Upstream commit 8d30e80a049ad699264e4a12911e349f93c7279a ] If condition is inverted, but it's also just not necessary. Fixes: 1c1052e0140a ("tools/testing/selftests/bpf: Add self-tests for new helper bpf_get_ns_current_pid_tgid.") Signed-off-by: Andrii Nakryiko Signed-

[PATCH AUTOSEL 5.7 140/274] net: bcmgenet: Fix WoL with password after deep sleep

2020-06-08 Thread Sasha Levin
From: Doug Berger [ Upstream commit 6f7689057a0f10a6c967b9f2759d7a3dc948b930 ] Broadcom STB chips support a deep sleep mode where all register contents are lost. Because we were stashing the MagicPacket password into some of these registers a suspend into that deep sleep then a resumption would

[PATCH AUTOSEL 5.7 151/274] ice: Fix error return code in ice_add_prof()

2020-06-08 Thread Sasha Levin
From: Wei Yongjun [ Upstream commit f8d530ac29fe9248f5e58ca5bcf4c368f8393ccf ] Fix to return a error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 31ad4e4ee1e4 ("ice: Allocate flow profile") Signed-off-by: Wei Yongjun Signed-off-by: David S. Miller

[PATCH AUTOSEL 5.7 150/274] octeontx2-pf: Fix error return code in otx2_probe()

2020-06-08 Thread Sasha Levin
From: Wei Yongjun [ Upstream commit 654cad8b6a17dcb00077070b27bc65873951a568 ] Fix to return negative error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Fixes: 5a6d7c9daef3 ("octeontx2-pf: Mailbox communication with AF") Signed-off-by: Wei Yongjun

[PATCH AUTOSEL 5.7 146/274] stmmac: intel: Fix clock handling on error and remove paths

2020-06-08 Thread Sasha Levin
From: Andy Shevchenko [ Upstream commit 09f012e64e4b8126ed6f02d0a85a57c3a0465cf9 ] clk_prepare_enable() might fail, we have to check its returned value. Besides that we have to call clk_disable_unprepare() on the error and remove paths. Do above in the dwmac-intel driver. While at it, remove le

[PATCH AUTOSEL 5.7 139/274] net: bcmgenet: set Rx mode before starting netif

2020-06-08 Thread Sasha Levin
From: Doug Berger [ Upstream commit 72f96347628e73dbb61b307f18dd19293cc6792a ] This commit explicitly calls the bcmgenet_set_rx_mode() function when the network interface is started. This function is normally called by ndo_set_rx_mode when the flags are changed, but apparently not when the drive

[PATCH AUTOSEL 5.7 154/274] drivers: net: davinci_mdio: fix potential NULL dereference in davinci_mdio_probe()

2020-06-08 Thread Sasha Levin
From: Wei Yongjun [ Upstream commit e00edb4efbbc07425441a3be2aa87abaf5800d96 ] platform_get_resource() may fail and return NULL, so we should better check it's return value to avoid a NULL pointer dereference since devm_ioremap() does not check input parameters for null. This is detected by Coc

[PATCH AUTOSEL 5.7 156/274] ath10k: fix possible memory leak in ath10k_bmi_lz_data_large()

2020-06-08 Thread Sasha Levin
From: Wei Yongjun [ Upstream commit 2326aa011967f0afbcba7fe1a005d01f8b12900b ] 'cmd' is malloced in ath10k_bmi_lz_data_large() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: d58f466a5dee ("ath10k: add large size for BMI download dat

[PATCH AUTOSEL 5.7 152/274] net: lpc-enet: fix error return code in lpc_mii_init()

2020-06-08 Thread Sasha Levin
From: Wei Yongjun [ Upstream commit 88ec7cb22ddde725ed4ce15991f0bd9dd817fd85 ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: b7370112f519 ("lpc32xx: Added ethernet driver") Signed-off-by: Wei Yongjun Acked-by: Vladimir

[PATCH AUTOSEL 5.7 157/274] ath11k: fix error return code in ath11k_dp_alloc()

2020-06-08 Thread Sasha Levin
From: Wei Yongjun [ Upstream commit f76f750aeea47fd98b6502eb6d37f84ca33662bf ] Fix to return negative error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Fixes: d0998eb84ed3 ("ath11k: optimise ath11k_dp_tx_completion_handler") Signed-off-by: Wei Yon

[PATCH AUTOSEL 5.7 164/274] libertas_tf: avoid a null dereference in pointer priv

2020-06-08 Thread Sasha Levin
From: Colin Ian King [ Upstream commit 049ceac308b0d57c4f06b9fb957cdf95d315cf0b ] Currently there is a check if priv is null when calling lbtf_remove_card but not in a previous call to if_usb_reset_dev that can also dereference priv. Fix this by also only calling lbtf_remove_card if priv is nul

[PATCH AUTOSEL 5.7 163/274] ath9k_htc: Silence undersized packet warnings

2020-06-08 Thread Sasha Levin
From: Masashi Honma [ Upstream commit 450edd2805982d14ed79733a82927d2857b27cac ] Some devices like TP-Link TL-WN722N produces this kind of messages frequently. kernel: ath: phy0: Short RX data len, dropping (dlen: 4) This warning is useful for developers to recognize that the device (Wi-Fi don

[PATCH AUTOSEL 5.7 160/274] net: allwinner: Fix use correct return type for ndo_start_xmit()

2020-06-08 Thread Sasha Levin
From: Yunjian Wang [ Upstream commit 09f6c44aaae0f1bdb8b983d7762676d5018c53bc ] The method ndo_start_xmit() returns a value of type netdev_tx_t. Fix the ndo function to use the correct type. And emac_start_xmit() can leak one skb if 'channel' == 3. Signed-off-by: Yunjian Wang Signed-off-by: Da

[PATCH AUTOSEL 5.7 168/274] dsa: sja1105: dynamically allocate stats structure

2020-06-08 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit ae1804de93f6f1626906567ae7deec8e0111259d ] The addition of sja1105_port_status_ether structure into the statistics causes the frame size to go over the warning limit: drivers/net/dsa/sja1105/sja1105_ethtool.c:421:6: error: stack frame size of 1104 bytes in

[PATCH AUTOSEL 5.7 187/274] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-06-08 Thread Sasha Levin
From: Bhupesh Sharma [ Upstream commit 73e030977f7884dbe1be0018bab517e8d02760f8 ] Normally kdump kernel(s) run under severe memory constraint with the basic idea being to save the crashdump vmcore reliably when the primary kernel panics/hangs. Currently the qed* ethernet driver ends up consumin

[PATCH AUTOSEL 5.7 186/274] wcn36xx: Fix error handling path in 'wcn36xx_probe()'

2020-06-08 Thread Sasha Levin
From: Christophe JAILLET [ Upstream commit a86308fc534edeceaf64670c691e17485436a4f4 ] In case of error, 'qcom_wcnss_open_channel()' must be undone by a call to 'rpmsg_destroy_ept()', as already done in the remove function. Fixes: 5052de8deff5 ("soc: qcom: smd: Transition client drivers from smd

[PATCH AUTOSEL 5.7 184/274] ath10k: Skip handling del_server during driver exit

2020-06-08 Thread Sasha Levin
From: Rakesh Pillai [ Upstream commit 7c6d67b136ceb0aebc7a3153b300e925ed915daf ] The qmi infrastructure sends the client a del_server event when the client releases its qmi handle. This is not the msg indicating the actual qmi server exiting. In such cases the del_server msg should not be proces

[PATCH AUTOSEL 5.7 191/274] mt76: mt7615: do not always reset the dfs state setting the channel

2020-06-08 Thread Sasha Levin
From: Lorenzo Bianconi [ Upstream commit fdb786cce0ef3615dcbb30d8baf06a1d4cb7a344 ] mac80211/hostapd runs mt7615_set_channel with the same channel parameters sending multiple rdd commands overwriting the previous ones. This behaviour is causing tpt issues on dfs channels. Fix the issue checking

[PATCH AUTOSEL 5.7 185/274] ath10k: Remove msdu from idr when management pkt send fails

2020-06-08 Thread Sasha Levin
From: Rakesh Pillai [ Upstream commit c730c477176ad4af86d9aae4d360a7ad840b073a ] Currently when the sending of any management pkt via wmi command fails, the packet is being unmapped freed in the error handling. But the idr entry added, which is used to track these packet is not getting removed.

[PATCH AUTOSEL 5.7 194/274] mt76: mt7615: fix mt7615_firmware_own for mt7663e

2020-06-08 Thread Sasha Levin
From: Lorenzo Bianconi [ Upstream commit becdf0d5d7a46f5ed1f12405ffae4b04764fe27c ] Check the firmware-own configuration has been applied polling MT_CONN_HIF_ON_LPCTL register Fixes: f40ac0f3d3c0 ("mt76: mt7615: introduce mt7663e support") Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix F

[PATCH AUTOSEL 5.7 192/274] mt76: mt7622: fix DMA unmap length

2020-06-08 Thread Sasha Levin
From: Lorenzo Bianconi [ Upstream commit c0f8055b3986f9c9f990268b578173259769ba1c ] Fix DMA unmap length estimation in mt7615_txp_skb_unmap_hw for mt7622 chipset Fixes: 6aa4ed7927f1 ("mt76: mt7615: implement DMA support for MT7622") Signed-off-by: Lorenzo Bianconi Signed-off-by: Sasha Levin -

[PATCH AUTOSEL 5.7 193/274] mt76: mt7663: fix DMA unmap length

2020-06-08 Thread Sasha Levin
From: Lorenzo Bianconi [ Upstream commit 89829c9e65ab680f7e5a1658cb74bc6316ab036e ] Fix DMA unmap length for mt7663e devices in mt7615_txp_skb_unmap_hw Fixes: f40ac0f3d3c0 ("mt76: mt7615: introduce mt7663e support") Co-developed-by: Sean Wang Signed-off-by: Sean Wang Co-developed-by: Soul Hua

[PATCH AUTOSEL 5.7 190/274] mt76: mt7663: fix mt7615_mac_cca_stats_reset routine

2020-06-08 Thread Sasha Levin
From: Lorenzo Bianconi [ Upstream commit 886a862d3677ac0d3b57d19ffcf5b2d48b9c5267 ] Fix PHYMUX_5 register definition for mt7663 in mt7615_mac_cca_stats_reset routine Fixes: f40ac0f3d3c0 ("mt76: mt7615: introduce mt7663e support") Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix Fietkau Si

[PATCH AUTOSEL 5.7 196/274] mt76: avoid rx reorder buffer overflow

2020-06-08 Thread Sasha Levin
From: Ryder Lee [ Upstream commit 7c4f744d6703757be959f521a7a441bf34745d99 ] Enlarge slot to support 11ax 256 BA (256 MPDUs in an AMPDU) Signed-off-by: Chih-Min Chen Signed-off-by: Ryder Lee Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/agg-

[PATCH AUTOSEL 5.7 209/274] net: ipa: do not clear interrupt in gsi_channel_start()

2020-06-08 Thread Sasha Levin
From: Alex Elder [ Upstream commit 195ef57f870070cb02f2f3b99a63d69e8e8f798e ] In gsi_channel_start() there is harmless-looking comment "Clear the channel's event ring interrupt in case it's pending". The intent was to avoid getting spurious interrupts when first bringing up a channel. However

[PATCH AUTOSEL 5.7 207/274] net/mlx5e: IPoIB, Drop multicast packets that this interface sent

2020-06-08 Thread Sasha Levin
From: Erez Shitrit [ Upstream commit 8b46d424a743ddfef8056d5167f13ee7ebd1dcad ] After enabled loopback packets for IPoIB, we need to drop these packets that this HCA has replicated and came back to the same interface that sent them. Fixes: 4c6c615e3f30 ("net/mlx5e: IPoIB, Add PKEY child interfa

[PATCH AUTOSEL 5.7 198/274] brcmfmac: fix WPA/WPA2-PSK 4-way handshake offload and SAE offload failures

2020-06-08 Thread Sasha Levin
From: Chung-Hsien Hsu [ Upstream commit b2fe11f0777311a764e47e2f9437809b4673b7b1 ] An incorrect value of use_fwsup is set for 4-way handshake offload for WPA//WPA2-PSK, caused by commit 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload"). It results in missing bit BRCMF_VIF_STA

[PATCH AUTOSEL 5.7 201/274] net: dsa: mt7530: set CPU port to fallback mode

2020-06-08 Thread Sasha Levin
From: DENG Qingfang [ Upstream commit 38152ea37d8bdaffa22603e0a5b5b86cfa8714c9 ] Currently, setting a bridge's self PVID to other value and deleting the default VID 1 renders untagged ports of that VLAN unable to talk to the CPU port: bridge vlan add dev br0 vid 2 pvid untagged self

[PATCH AUTOSEL 5.7 208/274] selftests/bpf: Fix test_align verifier log patterns

2020-06-08 Thread Sasha Levin
From: Stanislav Fomichev [ Upstream commit 5366d2269139ba8eb6a906d73a0819947e3e4e0a ] Commit 294f2fc6da27 ("bpf: Verifer, adjust_scalar_min_max_vals to always call update_reg_bounds()") changed the way verifier logs some of its state, adjust the test_align accordingly. Where possible, I tried to

[PATCH ethtool 2/2] man: add man page for ETHTOOL_GTUNABLE and ETHTOOL_STUNABLE

2020-06-08 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan --- ethtool.8.in | 12 1 file changed, 12 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 4c5b6c5..da0564e 100644 --- a/ethtool.8.in +++ b/ethtool.8.in @@ -390,6 +390,18 @@ ethtool \- query or control network driver and hardware

[PATCH AUTOSEL 5.7 210/274] rtlwifi: Fix a double free in _rtl_usb_tx_urb_setup()

2020-06-08 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit beb12813bc75d4a23de43b85ad1c7cb28d27631e ] Seven years ago we tried to fix a leak but actually introduced a double free instead. It was an understandable mistake because the code was a bit confusing and the free was done in the wrong place. The "skb" point

[PATCH ethtool 1/2] ethtool: add support for get/set ethtool_tunable

2020-06-08 Thread Govindarajulu Varadarajan
Add support for ETHTOOL_GTUNABLE and ETHTOOL_STUNABLE options. Tested rx-copybreak on enic driver. Tested ETHTOOL_TUNNABLE_STRING options with test/debug changes in kernel. Signed-off-by: Govindarajulu Varadarajan --- ethtool.c | 227 ++ 1 fil

[PATCH AUTOSEL 5.7 217/274] ice: cleanup vf_id signedness

2020-06-08 Thread Sasha Levin
From: Jesse Brandeburg [ Upstream commit 53bb66983f34d4ff0af179fe228e2c55e1e45921 ] The vf_id variable is dealt with in the code in inconsistent ways of sign usage, preventing compilation with -Werror=sign-compare. Fix this problem in the code by always treating vf_id as unsigned, since there ar

[PATCH AUTOSEL 5.7 218/274] ice: Fix resource leak on early exit from function

2020-06-08 Thread Sasha Levin
From: Eric Joyner [ Upstream commit 857a4f0e9f4956fffc0cedcaa2ba187a2e987153 ] Memory allocated in the ice_add_prof_id_vsig() function wasn't being properly freed if an error occurred inside the for-loop in the function. In particular, 'p' wasn't being freed if an error occurred before it was a

[PATCH AUTOSEL 5.7 227/274] ice: Fix Tx timeout when link is toggled on a VF's interface

2020-06-08 Thread Sasha Levin
From: Brett Creeley [ Upstream commit 4dc926d3a59e73b8c4adf51b261f1a1bbd48a989 ] Currently if the iavf is loaded and a VF link transitions from up to down to up again a Tx timeout will be triggered. This happens because Tx/Rx queue interrupts are only enabled when receiving the VIRTCHNL_OP_CONFI

  1   2   3   4   5   >