KMSAN: uninit-value in slhc_compress (2)

2020-06-05 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:f0d5ec90 kmsan: apply __no_sanitize_memory to dotraplinkag.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=12a3dcca10 kernel config: https://syzkaller.appspot.co

Re: [PATCH v2] cxgb4: Fix 'defined but not used' warning for cxgb4_uld_in_use()

2020-06-05 Thread Tom Seewald
> This doesn't apply to the net GIT tree. Apologies, this fix is for net-next. Let me know if I should resend. Thanks

Re: [PATCH net] net/tls(TLS_SW): Add selftest for 'chunked' sendfile test

2020-06-05 Thread Jakub Kicinski
On Fri, 5 Jun 2020 16:01:18 + Pooja Trivedi wrote: > This selftest tests for cases where sendfile's 'count' > parameter is provided with a size greater than the intended > file size. > > Motivation: When sendfile is provided with 'count' parameter > value that is greater than the size of the

Re: [PATCH v4 bpf-next 0/5] bpf: Add support for XDP programs in DEVMAP entries

2020-06-05 Thread David Ahern
On 6/1/20 4:28 PM, David Ahern wrote: >> >> and that selftest is imo too primitive. > > I focused the selftests on API changes introduced by this set - new > attach type, valid accesses to egress_ifindex and not allowing devmap > programs with xdp generic. > >> It's only loading progs and not exe

Hang on wireless removal..

2020-06-05 Thread Linus Torvalds
So I think there's something wrong with wireless networking, and (likely) in particular turning off wireless. And I think the problem came in this merge window, because now my machine hangs on shutdown. My new desktop is otherwise working fine, but it has some unnecessary wireless capability on th

[ipsec:master 2/2] arch/c6x/include/asm/unaligned.h:43:17: sparse: sparse: cast truncates bits from constant value (5c0 becomes c0)

2020-06-05 Thread kernel test robot
onfig-s031-20200605 (attached as .config) compiler: c6x-elf-gcc (GCC) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-246-g41f651b4-dirty git checkout a4902d914e508f3691fa7ef885a76d2b7e735805 # save the attached .config to linux build tree ma

[PATCH] virtio_net: Unregister and re-register xdp_rxq across freeze/restore

2020-06-05 Thread Sean Christopherson
Unregister each queue's xdp_rxq during freeze, and re-register the new instance during restore. All queues are released during free and recreated during restore, i.e. the pre-freeze xdp_rxq will be lost. The bug is detected by WARNs in xdp_rxq_info_unreg() and xdp_rxq_info_unreg_mem_model() that

Re: [PATCH 03/12] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume

2020-06-05 Thread Boris Ostrovsky
On 6/4/20 7:03 PM, Anchal Agarwal wrote: > On Sat, May 30, 2020 at 07:02:01PM -0400, Boris Ostrovsky wrote: >> CAUTION: This email originated from outside of the organization. Do not >> click links or open attachments unless you can confirm the sender and know >> the content is safe. >> >> >> >>

[RFC PATCH net] splice: Do not set SPLICE_F_MORE flag if end of file is reached

2020-06-05 Thread Pooja Trivedi
SPLICE_F_MORE should only get set if read_len < len and pos does not indicate file end. This is because the passed-in len can be greater than file size and read_len < len could indicate that end of file has been reached and there is no more pending data. -- This issue was found during kTLS te

Re: [PATCH 04/12] x86/xen: add system core suspend and resume callbacks

2020-06-05 Thread Boris Ostrovsky
On 6/3/20 6:40 PM, Agarwal, Anchal wrote: > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > On 5/19/20 7:26 PM, Anchal Agarwal wrote: > > From: Munehisa

Re: [PATCH net] net: dp83869: Reset return variable if PHY strap is read

2020-06-05 Thread Florian Fainelli
On 6/5/2020 1:51 PM, Dan Murphy wrote: > When the PHY's strap register is read to determine if lane swapping is > needed the phy_read_mmd returns the value back into the ret variable. > > If the call to read the strap fails the failed value is returned. If > the call to read the strap is succe

[PATCH net] net: dp83869: Reset return variable if PHY strap is read

2020-06-05 Thread Dan Murphy
When the PHY's strap register is read to determine if lane swapping is needed the phy_read_mmd returns the value back into the ret variable. If the call to read the strap fails the failed value is returned. If the call to read the strap is successful then ret is possibly set to a non-zero positiv

[PATCH v3] Bluetooth: Allow suspend even when preparation has failed

2020-06-05 Thread Abhishek Pandit-Subedi
It is preferable to allow suspend even when Bluetooth has problems preparing for sleep. When Bluetooth fails to finish preparing for suspend, log the error and allow the suspend notifier to continue instead. To also make it clearer why suspend failed, change bt_dev_dbg to bt_dev_err when handling

Re: [PATCH v2] Bluetooth: Allow suspend even when preparation has failed

2020-06-05 Thread Jakub Kicinski
On Thu, 4 Jun 2020 21:28:50 -0700 Abhishek Pandit-Subedi wrote: > It is preferable to allow suspend even when Bluetooth has problems > preparing for sleep. When Bluetooth fails to finish preparing for > suspend, log the error and allow the suspend notifier to continue > instead. > > To also make

Re: [PATCH] cxgb4: Use kfree() instead kvfree() where appropriate

2020-06-05 Thread David Miller
From: Denis Efremov Date: Fri, 5 Jun 2020 22:11:44 +0300 > Use kfree(buf) in blocked_fl_read() because the memory is allocated with > kzalloc(). Use kfree(t) in blocked_fl_write() because the memory is > allocated with kcalloc(). > > Signed-off-by: Denis Efremov Applied.

Re: [PATCH] net: qed: fixes crash while running driver in kdump kernel

2020-06-05 Thread David Miller
From: Alok Prasad Date: Fri, 5 Jun 2020 16:30:34 + > This fixes a crash introduced by recent is_kdump_kernel() check. > The source of the crash is that kdump kernel can be loaded on a > system with already created VFs. But for such VFs, it will follow > a logic path of PF and eventually crash

Re: [PATCH net] vsock/vmci: make vmci_vsock_transport_cb() static

2020-06-05 Thread David Miller
From: Stefano Garzarella Date: Fri, 5 Jun 2020 17:12:41 +0200 > Fix the following gcc-9.3 warning when building with 'make W=1': > net/vmw_vsock/vmci_transport.c:2058:6: warning: no previous prototype > for ‘vmci_vsock_transport_cb’ [-Wmissing-prototypes] > 2058 | void vmci_vsoc

Re: [PATCH] net: ethtool: Fix comment mentioning typo in IS_ENABLED()

2020-06-05 Thread David Miller
From: Kees Cook Date: Fri, 5 Jun 2020 07:21:22 -0700 > This has no code changes, but it's a typo noticed in other clean-ups, > so we might as well fix it. IS_ENABLED() takes full names, and should > have the "CONFIG_" prefix. > > Reported-by: Joe Perches > Link: > https://lore.kernel.org/lkml/

Re: [PATCH net] net: phy: mscc: fix Serdes configuration in vsc8584_config_init

2020-06-05 Thread David Miller
From: Antoine Tenart Date: Fri, 5 Jun 2020 16:00:09 +0200 > When converting the MSCC PHY driver to shared PHY packages, the Serdes > configuration in vsc8584_config_init was modified to use 'base_addr' > instead of 'base' as the port number. But 'base_addr' isn't equal to > 'addr' for all PHYs i

Re: [PATCH net 0/4] Fixes for OF_MDIO flag

2020-06-05 Thread David Miller
From: Dan Murphy Date: Fri, 5 Jun 2020 09:01:03 -0500 > There are some residual drivers that check the CONFIG_OF_MDIO flag using the > if defs. Using this check does not work when the OF_MDIO is configured as a > module. Using the IS_ENABLED macro checks if the flag is declared as built-in > or a

Re: [PATCH net] net: ethernet: mvneta: fix MVNETA_SKB_HEADROOM alignment

2020-06-05 Thread David Miller
From: Alexander Lobakin Date: Fri, 5 Jun 2020 15:53:24 +0300 > Commit ca23cb0bc50f ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero") > added headroom alignment check against 8. > Hovewer (if we imagine that NET_SKB_PAD or XDP_PACKET_HEADROOM is not > aligned to cacheline size), it actually

Re: [PATCH net] ethtool: linkinfo: remove an unnecessary NULL check

2020-06-05 Thread David Miller
From: Dan Carpenter Date: Fri, 5 Jun 2020 14:04:13 +0300 > This code generates a Smatch warning: > > net/ethtool/linkinfo.c:143 ethnl_set_linkinfo() > warn: variable dereferenced before check 'info' (see line 119) > > Fortunately, the "info" pointer is never NULL so the check can be > r

Re: [PATCH v2] cxgb4: Fix 'defined but not used' warning for cxgb4_uld_in_use()

2020-06-05 Thread David Miller
From: Tom Seewald Date: Thu, 4 Jun 2020 20:36:32 -0500 > The only user of cxgb4_uld_in_use() is cxgb4_set_ktls_feature() which is > only available when CONFIG_CHELSIO_TLS_DEVICE=y. To avoid this compiler > warning when CONFIG_CHELSIO_TLS_DEVICE=n, place cxgb4_uld_in_use() behind > the same ifdef

Re: [PATCH] net/mlx5: Use kfree(ft->g) in arfs_create_groups()

2020-06-05 Thread Eric Dumazet
On 6/5/20 12:22 PM, Denis Efremov wrote: > Use kfree() instead of kvfree() on ft->g in arfs_create_groups() because > the memory is allocated with kcalloc(). > > Signed-off-by: Denis Efremov > --- > drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: TCP_DEFER_ACCEPT wakes up without data

2020-06-05 Thread Julian Anastasov
Hello, On Thu, 4 Jun 2020, Christoph Paasch wrote: > On Wed, Jun 11, 2014 at 11:05 PM Julian Anastasov wrote: > > > > > > > The behavior that we want is for the receipt of the duplicate bare > > > ACK to not result in waking up user space. The socket still hasn't > > > received any da

[PATCH] net/mlx5: Use kfree(ft->g) in arfs_create_groups()

2020-06-05 Thread Denis Efremov
Use kfree() instead of kvfree() on ft->g in arfs_create_groups() because the memory is allocated with kcalloc(). Signed-off-by: Denis Efremov --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/ml

[PATCH] cxgb4: Use kfree() instead kvfree() where appropriate

2020-06-05 Thread Denis Efremov
Use kfree(buf) in blocked_fl_read() because the memory is allocated with kzalloc(). Use kfree(t) in blocked_fl_write() because the memory is allocated with kcalloc(). Signed-off-by: Denis Efremov --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+),

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-05 Thread Andrew Lunn
On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonathan McDowell wrote: > The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X > mode depending on what it's connected to (e.g. CPU vs external PHY or > SFP). At present the driver does no configuration of this port even if > it is sele

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-05 Thread Marek Behun
On Fri, 5 Jun 2020 19:10:58 +0100 Jonathan McDowell wrote: > The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X > mode depending on what it's connected to (e.g. CPU vs external PHY or > SFP). At present the driver does no configuration of this port even if > it is selected.

[PATCH 1/2] dt-bindings: net: dsa: qca8k: document SGMII properties

2020-06-05 Thread Jonathan McDowell
This patch documents the qca8k's SGMII related properties that allow configuration of the SGMII port. Signed-off-by: Jonathan McDowell --- Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.t

[PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-05 Thread Jonathan McDowell
The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X mode depending on what it's connected to (e.g. CPU vs external PHY or SFP). At present the driver does no configuration of this port even if it is selected. Add support for making sure the SGMII is enabled if it's in use, and

[PATCH 0/2] net: dsa: qca8k: Add SGMII configuration options

2020-06-05 Thread Jonathan McDowell
This pair of patches adds some SGMII device tree configuration options for the QCA8K switch driver, and the associated documentation. At present the driver does no configuration of the SGMII port, even if it is selected. These changes allow configuration of how it is connected up (i.e. connected t

Re: Use of RCU in qrtr

2020-06-05 Thread Matthew Wilcox
[I meant to cc netdev on this originally. Added now, preserving entire message below for context] On Fri, Jun 05, 2020 at 05:12:05AM -0700, Matthew Wilcox wrote: > While doing the XArray conversion, I came across your commit > f16a4b26f31f95dddb12cf3c2390906a735203ae > > synchronize_rcu() is k

Re: [PATCH net v2] esp: select CRYPTO_SEQIV when useful

2020-06-05 Thread Eric Biggers
On Fri, Jun 05, 2020 at 10:39:31AM -0700, Eric Biggers wrote: > From: Eric Biggers > > CRYPTO_CTR no longer selects CRYPTO_SEQIV, which breaks IPsec for users > who need any of the algorithms that use seqiv. These users now would > need to explicitly enable CRYPTO_SEQIV. > > There doesn't seem

[PATCH net v2] esp: select CRYPTO_SEQIV when useful

2020-06-05 Thread Eric Biggers
From: Eric Biggers CRYPTO_CTR no longer selects CRYPTO_SEQIV, which breaks IPsec for users who need any of the algorithms that use seqiv. These users now would need to explicitly enable CRYPTO_SEQIV. There doesn't seem to be a clear rule on what algorithms the IPsec options (INET_ESP and INET6_

Re: [PATCH net-next 7/8] net: phy: Add Synopsys DesignWare XPCS MDIO module

2020-06-05 Thread Russell King - ARM Linux admin
Hi Jose, I just tripped over a bug while grepping for something else and reading a bit of this driver: On Mon, Mar 09, 2020 at 09:36:26AM +0100, Jose Abreu wrote: > +static int xpcs_read_lpa(struct mdio_xpcs_args *xpcs, > + struct phylink_link_state *state) > +{ > + int r

Re: [PATCH bpf-next V1] bpf: devmap dynamic map-value area based on BTF

2020-06-05 Thread Alexei Starovoitov
On Fri, Jun 5, 2020 at 4:01 AM Toke Høiland-Jørgensen wrote: > > Jesper Dangaard Brouer writes: > > > On Thu, 4 Jun 2020 10:33:41 -0700 > > Alexei Starovoitov wrote: > > > >> On Thu, Jun 04, 2020 at 10:40:06AM -0600, David Ahern wrote: > >> > On 6/4/20 9:48 AM, Jesper Dangaard Brouer wrote: > >>

Re: [PATCH bpf-next V1] bpf: devmap dynamic map-value area based on BTF

2020-06-05 Thread Alexei Starovoitov
On Fri, Jun 5, 2020 at 1:23 AM Jesper Dangaard Brouer wrote: > > Great. If we can remove this requirement of -1 init (and let zero mean > feature isn't used), then I'm all for exposing expose in uapi/bpf.h. Not having it in bpf.h doesn't magically make it invisible. It's uapi because user space C

Re: [PATCH] wlcore: mesh: handle failure case of pm_runtime_get_sync

2020-06-05 Thread Tony Lindgren
* Navid Emamdoost [200605 03:28]: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. Looks like we have a similar patch already in Linux next, care to check? Regards, Tony

Re: TCP_DEFER_ACCEPT wakes up without data

2020-06-05 Thread Eric Dumazet
On 6/5/20 7:57 AM, Christoph Paasch wrote: > On Thu, Jun 4, 2020 at 6:28 PM Eric Dumazet wrote: >> >> >> >> On 6/4/20 4:18 PM, Christoph Paasch wrote: >>> +Eric & Leif >>> >>> Hello, >>> >>> >>> (digging out an old thread ... ;-) ) >>> >> >> Is there a tldr; ? > > Sure! TCP_DEFER_ACCEPT delays

Re: [PATCH] qrtr: Convert qrtr_ports from IDR to XArray

2020-06-05 Thread Eric Dumazet
On 6/5/20 5:00 AM, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > The XArray interface is easier for this driver to use. Also fixes a > bug reported by the improper use of GFP_ATOMIC. > This does not look stable candidate. If you try to add a Fixes: tag, you might discover tha

Re: [PATCH] qrtr: Convert qrtr_ports from IDR to XArray

2020-06-05 Thread Eric Biggers
On Fri, Jun 05, 2020 at 05:00:37AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > The XArray interface is easier for this driver to use. Also fixes a > bug reported by the improper use of GFP_ATOMIC. > > Signed-off-by: Matthew Wilcox (Oracle) This fixes https://lkml.kernel

Re: [PATCH net] net: phy: mscc: fix Serdes configuration in vsc8584_config_init

2020-06-05 Thread Florian Fainelli
On 6/5/2020 7:00 AM, Antoine Tenart wrote: > When converting the MSCC PHY driver to shared PHY packages, the Serdes > configuration in vsc8584_config_init was modified to use 'base_addr' > instead of 'base' as the port number. But 'base_addr' isn't equal to > 'addr' for all PHYs inside the packa

Re: [PATCH net 3/4] net: marvell: Fix OF_MDIO config check

2020-06-05 Thread Florian Fainelli
On 6/5/2020 7:01 AM, Dan Murphy wrote: > When CONFIG_OF_MDIO is set to be a module the code block is not > compiled. Use the IS_ENABLED macro that checks for both built in as > well as module. > > Fixes: cf41a51db8985 ("of/phylib: Use device tree properties to initialize > Marvell PHYs.") > Si

Re: [PATCH net 4/4] net: mscc: Fix OF_MDIO config check

2020-06-05 Thread Florian Fainelli
On 6/5/2020 7:01 AM, Dan Murphy wrote: > When CONFIG_OF_MDIO is set to be a module the code block is not > compiled. Use the IS_ENABLED macro that checks for both built in as > well as module. > > Fixes: 4f58e6dceb0e4 ("net: phy: Cleanup the Edge-Rate feature in Microsemi > PHYs.") > Signed-of

[PATCH] net: qed: fixes crash while running driver in kdump kernel

2020-06-05 Thread Alok Prasad
This fixes a crash introduced by recent is_kdump_kernel() check. The source of the crash is that kdump kernel can be loaded on a system with already created VFs. But for such VFs, it will follow a logic path of PF and eventually crash. Thus, we are partially reverting back previous changes and ins

Re: [PATCH net 2/4] net: dp83867: Fix OF_MDIO config check

2020-06-05 Thread Florian Fainelli
On 6/5/2020 7:01 AM, Dan Murphy wrote: > When CONFIG_OF_MDIO is set to be a module the code block is not > compiled. Use the IS_ENABLED macro that checks for both built in as > well as module. > > Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy") > Signed-off-by: Dan Murphy Revie

Re: [PATCH net 1/4] net: dp83869: Fix OF_MDIO config check

2020-06-05 Thread Florian Fainelli
On 6/5/2020 7:01 AM, Dan Murphy wrote: > When CONFIG_OF_MDIO is set to be a module the code block is not > compiled. Use the IS_ENABLED macro that checks for both built in as > well as module. > > Fixes: 01db923e83779 ("net: phy: dp83869: Add TI dp83869 phy") > Signed-off-by: Dan Murphy Revie

Re: BUG: using smp_processor_id() in preemptible code in radix_tree_node_alloc

2020-06-05 Thread Eric Biggers
On Fri, Jun 05, 2020 at 04:29:22AM -0700, Matthew Wilcox wrote: > On Thu, Jun 04, 2020 at 08:55:55PM -0700, Eric Biggers wrote: > > Possibly a bug in lib/radix-tree.c? this_cpu_ptr() in > > radix_tree_node_alloc() > > can be reached without a prior preempt_disable(). Or is the caller of > > idr_

[PATCH net] net/tls(TLS_SW): Add selftest for 'chunked' sendfile test

2020-06-05 Thread Pooja Trivedi
This selftest tests for cases where sendfile's 'count' parameter is provided with a size greater than the intended file size. Motivation: When sendfile is provided with 'count' parameter value that is greater than the size of the file, kTLS example fails to send the file correctly. Last chunk of t

[PATCH 5/9] net: wireless: broadcom: fix wiki website url

2020-06-05 Thread Flavio Suligoi
In some b43 files, the wiki url is still the old "wireless.kernel.org" instead of the new "wireless.wiki.kernel.org" Signed-off-by: Flavio Suligoi --- drivers/net/wireless/broadcom/b43/main.c | 2 +- drivers/net/wireless/broadcom/b43legacy/main.c | 4 ++-- 2 files changed, 3 insertions(+),

[PATCH 3/9] net: wireless: ath: fix wiki website url

2020-06-05 Thread Flavio Suligoi
In some ath files, the wiki url is still the old "wireless.kernel.org" instead of the new "wireless.wiki.kernel.org" Signed-off-by: Flavio Suligoi --- drivers/net/wireless/ath/Kconfig | 4 ++-- drivers/net/wireless/ath/ath9k/Kconfig| 5 +++-- drivers/net/wireless/ath/ath9k/hw.c

[PATCH 9/9] net: fix wiki website url mac80211 and wireless files

2020-06-05 Thread Flavio Suligoi
In the files: - net/mac80211/rx.c - net/wireless/Kconfig the wiki url is still the old "wireless.kernel.org" instead of the new "wireless.wiki.kernel.org" Signed-off-by: Flavio Suligoi --- net/mac80211/rx.c| 2 +- net/wireless/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-

[PATCH 8/9] include: fix wiki website url in netlink interface header

2020-06-05 Thread Flavio Suligoi
The wiki url is still the old "wireless.kernel.org" instead of the new "wireless.wiki.kernel.org" Signed-off-by: Flavio Suligoi --- include/uapi/linux/nl80211.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h index d

[PATCH 2/9] net: wireless: fix wiki website url in main Kconfig

2020-06-05 Thread Flavio Suligoi
The wiki url is still the old "wireless.kernel.org" instead of the new "wireless.wiki.kernel.org" Signed-off-by: Flavio Suligoi --- drivers/net/wireless/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig index 1

[PATCH 0/9] net: wireless: fix wireless wiki website url

2020-06-05 Thread Flavio Suligoi
In some files, related to the net wireless sub-system, the wireless wiki URL is still the old "wireless.kernel.org" instead of the new "wireless.wiki.kernel.org" Flavio Suligoi (9): doc: networking: wireless: fix wiki website url net: wireless: fix wiki website url in main Kconfig net: wire

[PATCH 4/9] net: wireless: atmel: fix wiki website url

2020-06-05 Thread Flavio Suligoi
In at76c50x-usb.c the wiki url is still the old "wireless.kernel.org" instead of the new "wireless.wiki.kernel.org" Signed-off-by: Flavio Suligoi --- drivers/net/wireless/atmel/at76c50x-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/atmel/at76c50x-

[PATCH 6/9] net: wireless: intel: fix wiki website url

2020-06-05 Thread Flavio Suligoi
In some Intel files, the wiki url is still the old "wireless.kernel.org" instead of the new "wireless.wiki.kernel.org" Signed-off-by: Flavio Suligoi --- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +- drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +- 2 files changed, 2 insertions(+),

[PATCH 7/9] net: wireless: intersil: fix wiki website url

2020-06-05 Thread Flavio Suligoi
In some Intesil files, the wiki url is still the old "wireless.kernel.org" instead of the new "wireless.wiki.kernel.org" Signed-off-by: Flavio Suligoi --- drivers/net/wireless/intersil/Kconfig | 2 +- drivers/net/wireless/intersil/p54/Kconfig | 6 +++--- drivers/net

[PATCH 1/9] doc: networking: wireless: fix wiki website url

2020-06-05 Thread Flavio Suligoi
In the files: - regulatory.rst - mac80211-injection.rst the wiki url is still the old "wireless.kernel.org" instead of the new "wireless.wiki.kernel.org" Signed-off-by: Flavio Suligoi --- Documentation/networking/mac80211-injection.rst | 2 +- Documentation/networking/regulatory.rst |

[PATCH net] vsock/vmci: make vmci_vsock_transport_cb() static

2020-06-05 Thread Stefano Garzarella
Fix the following gcc-9.3 warning when building with 'make W=1': net/vmw_vsock/vmci_transport.c:2058:6: warning: no previous prototype for ‘vmci_vsock_transport_cb’ [-Wmissing-prototypes] 2058 | void vmci_vsock_transport_cb(bool is_host) | ^~~ Fi

Re: TCP_DEFER_ACCEPT wakes up without data

2020-06-05 Thread Christoph Paasch
On Thu, Jun 4, 2020 at 6:28 PM Eric Dumazet wrote: > > > > On 6/4/20 4:18 PM, Christoph Paasch wrote: > > +Eric & Leif > > > > Hello, > > > > > > (digging out an old thread ... ;-) ) > > > > Is there a tldr; ? Sure! TCP_DEFER_ACCEPT delays the creation of the socket until data has been sent by th

Re: [PATCH bpf-next 5/8] bpf: Add link-based BPF program attachment to network namespace

2020-06-05 Thread Jakub Sitnicki
On Fri, Jun 05, 2020 at 01:38 AM CEST, Nick Desaulniers wrote: > On Wed, May 27, 2020 at 8:19 PM kbuild test robot wrote: >> >> Hi Jakub, >> >> I love your patch! Perhaps something to improve: >> >> [auto build test WARNING on bpf-next/master] >> [also build test WARNING on net-next/master next-20

[PATCH] net: ethtool: Fix comment mentioning typo in IS_ENABLED()

2020-06-05 Thread Kees Cook
This has no code changes, but it's a typo noticed in other clean-ups, so we might as well fix it. IS_ENABLED() takes full names, and should have the "CONFIG_" prefix. Reported-by: Joe Perches Link: https://lore.kernel.org/lkml/b08611018fdb6d88757c6008a5c02fa0e07b32fb.ca...@perches.com Signed-off

[PATCH net] net: phy: mscc: fix Serdes configuration in vsc8584_config_init

2020-06-05 Thread Antoine Tenart
When converting the MSCC PHY driver to shared PHY packages, the Serdes configuration in vsc8584_config_init was modified to use 'base_addr' instead of 'base' as the port number. But 'base_addr' isn't equal to 'addr' for all PHYs inside the package, which leads to the Serdes still being enabled on t

[PATCH net 0/4] Fixes for OF_MDIO flag

2020-06-05 Thread Dan Murphy
Hello There are some residual drivers that check the CONFIG_OF_MDIO flag using the if defs. Using this check does not work when the OF_MDIO is configured as a module. Using the IS_ENABLED macro checks if the flag is declared as built-in or as a module. Dan Dan Murphy (4): net: dp83869: Fix OF_

[PATCH net 1/4] net: dp83869: Fix OF_MDIO config check

2020-06-05 Thread Dan Murphy
When CONFIG_OF_MDIO is set to be a module the code block is not compiled. Use the IS_ENABLED macro that checks for both built in as well as module. Fixes: 01db923e83779 ("net: phy: dp83869: Add TI dp83869 phy") Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 2 +- 1 file changed, 1 ins

[PATCH net 2/4] net: dp83867: Fix OF_MDIO config check

2020-06-05 Thread Dan Murphy
When CONFIG_OF_MDIO is set to be a module the code block is not compiled. Use the IS_ENABLED macro that checks for both built in as well as module. Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy") Signed-off-by: Dan Murphy --- drivers/net/phy/dp83867.c | 2 +- 1 file changed, 1 ins

[PATCH net 3/4] net: marvell: Fix OF_MDIO config check

2020-06-05 Thread Dan Murphy
When CONFIG_OF_MDIO is set to be a module the code block is not compiled. Use the IS_ENABLED macro that checks for both built in as well as module. Fixes: cf41a51db8985 ("of/phylib: Use device tree properties to initialize Marvell PHYs.") Signed-off-by: Dan Murphy --- drivers/net/phy/marvell.c

[PATCH net 4/4] net: mscc: Fix OF_MDIO config check

2020-06-05 Thread Dan Murphy
When CONFIG_OF_MDIO is set to be a module the code block is not compiled. Use the IS_ENABLED macro that checks for both built in as well as module. Fixes: 4f58e6dceb0e4 ("net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.") Signed-off-by: Dan Murphy --- drivers/net/phy/mscc/mscc.h

[PATCH net] net: ethernet: mvneta: fix MVNETA_SKB_HEADROOM alignment

2020-06-05 Thread Alexander Lobakin
Commit ca23cb0bc50f ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero") added headroom alignment check against 8. Hovewer (if we imagine that NET_SKB_PAD or XDP_PACKET_HEADROOM is not aligned to cacheline size), it actually aligns headroom down, while skb/xdp_buff headroom should be *at least*

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-05 Thread Victor Julien
On 04-06-2020 15:48, Willem de Bruijn wrote: > On Thu, Jun 4, 2020 at 5:47 AM Victor Julien wrote: >> >> On 02-06-2020 22:18, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 4:05 PM Victor Julien wrote: On 02-06-2020 21:38, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 3:22 PM

Re: [PATCH net] ethtool: linkinfo: remove an unnecessary NULL check

2020-06-05 Thread Michal Kubecek
On Fri, Jun 05, 2020 at 02:04:13PM +0300, Dan Carpenter wrote: > This code generates a Smatch warning: > > net/ethtool/linkinfo.c:143 ethnl_set_linkinfo() > warn: variable dereferenced before check 'info' (see line 119) > > Fortunately, the "info" pointer is never NULL so the check can be

[PATCH AUTOSEL 5.6 13/17] net/mlx5: Fix crash upon suspend/resume

2020-06-05 Thread Sasha Levin
From: Mark Bloch [ Upstream commit 8fc3e29be9248048f449793502c15af329f35c6e ] Currently a Linux system with the mlx5 NIC always crashes upon hibernation - suspend/resume. Add basic callbacks so the NIC could be suspended and resumed. Fixes: 9603b61de1ee ("mlx5: Move pci device handling from ml

[PATCH AUTOSEL 5.6 14/17] net/mlx5e: replace EINVAL in mlx5e_flower_parse_meta()

2020-06-05 Thread Sasha Levin
From: Pablo Neira Ayuso [ Upstream commit a683012a8e77675a1947cc8f11f97cdc1d5bb769 ] The drivers reports EINVAL to userspace through netlink on invalid meta match. This is confusing since EINVAL is usually reserved for malformed netlink messages. Replace it by more meaningful codes. Fixes: 6d65

[PATCH AUTOSEL 5.6 09/17] nfp: flower: fix used time of merge flow statistics

2020-06-05 Thread Sasha Levin
From: Heinrich Kuhn [ Upstream commit 5b186cd60f033110960a3db424ffbd6de4cee528 ] Prior to this change the correct value for the used counter is calculated but not stored nor, therefore, propagated to user-space. In use-cases such as OVS use-case at least this results in active flows being remove

[PATCH AUTOSEL 5.6 07/17] net: usb: qmi_wwan: add Telit LE910C1-EUX composition

2020-06-05 Thread Sasha Levin
From: Daniele Palmas [ Upstream commit 591612aa578cd7148b7b9d74869ef40118978389 ] Add support for Telit LE910C1-EUX composition 0x1031: tty, tty, tty, rmnet Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/qmi_

[PATCH AUTOSEL 5.6 05/17] net: stmmac: enable timestamp snapshot for required PTP packets in dwmac v5.10a

2020-06-05 Thread Sasha Levin
From: Fugang Duan [ Upstream commit f2fb6b6275eba9d312957ca44c487bd780da6169 ] For rx filter 'HWTSTAMP_FILTER_PTP_V2_EVENT', it should be PTP v2/802.AS1, any layer, any kind of event packet, but HW only take timestamp snapshot for below PTP message: sync, Pdelay_req, Pdelay_resp. Then it causes

[PATCH AUTOSEL 5.6 15/17] NFC: st21nfca: add missed kfree_skb() in an error path

2020-06-05 Thread Sasha Levin
From: Chuhong Yuan [ Upstream commit 3decabdc714ca56c944f4669b4cdec5c2c1cea23 ] st21nfca_tm_send_atr_res() misses to call kfree_skb() in an error path. Add the missed function call to fix it. Fixes: 1892bf844ea0 ("NFC: st21nfca: Adding P2P support to st21nfca in Initiator & Target mode") Signe

[PATCH AUTOSEL 5.6 10/17] net: dsa: felix: send VLANs on CPU port as egress-tagged

2020-06-05 Thread Sasha Levin
From: Vladimir Oltean [ Upstream commit 183be6f967fe37c3154bfac39e913c3bafe89d1b ] As explained in other commits before (b9cd75e66895 and 87b0f983f66f), ocelot switches have a single egress-untagged VLAN per port, and the driver would deny adding a second one while an egress-untagged VLAN alread

[PATCH AUTOSEL 5.6 17/17] l2tp: do not use inet_hash()/inet_unhash()

2020-06-05 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 02c71b144c811bcdd865e0a1226d0407d11357e8 ] syzbot recently found a way to crash the kernel [1] Issue here is that inet_hash() & inet_unhash() are currently only meant to be used by TCP & DCCP, since only these protocols provide the needed hashinfo pointer.

[PATCH AUTOSEL 5.6 16/17] drivers/net/ibmvnic: Update VNIC protocol version reporting

2020-06-05 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit 784688993ebac34dffe44a9f2fabbe126ebfd4db ] VNIC protocol version is reported in big-endian format, but it is not byteswapped before logging. Fix that, and remove version comparison as only one protocol version exists at this time. Signed-off-by: Thomas Falc

[PATCH AUTOSEL 5.4 04/14] net: stmmac: enable timestamp snapshot for required PTP packets in dwmac v5.10a

2020-06-05 Thread Sasha Levin
From: Fugang Duan [ Upstream commit f2fb6b6275eba9d312957ca44c487bd780da6169 ] For rx filter 'HWTSTAMP_FILTER_PTP_V2_EVENT', it should be PTP v2/802.AS1, any layer, any kind of event packet, but HW only take timestamp snapshot for below PTP message: sync, Pdelay_req, Pdelay_resp. Then it causes

[PATCH AUTOSEL 5.4 06/14] net: usb: qmi_wwan: add Telit LE910C1-EUX composition

2020-06-05 Thread Sasha Levin
From: Daniele Palmas [ Upstream commit 591612aa578cd7148b7b9d74869ef40118978389 ] Add support for Telit LE910C1-EUX composition 0x1031: tty, tty, tty, rmnet Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/qmi_

[PATCH AUTOSEL 5.4 12/14] NFC: st21nfca: add missed kfree_skb() in an error path

2020-06-05 Thread Sasha Levin
From: Chuhong Yuan [ Upstream commit 3decabdc714ca56c944f4669b4cdec5c2c1cea23 ] st21nfca_tm_send_atr_res() misses to call kfree_skb() in an error path. Add the missed function call to fix it. Fixes: 1892bf844ea0 ("NFC: st21nfca: Adding P2P support to st21nfca in Initiator & Target mode") Signe

[PATCH AUTOSEL 5.4 11/14] net/mlx5: Fix crash upon suspend/resume

2020-06-05 Thread Sasha Levin
From: Mark Bloch [ Upstream commit 8fc3e29be9248048f449793502c15af329f35c6e ] Currently a Linux system with the mlx5 NIC always crashes upon hibernation - suspend/resume. Add basic callbacks so the NIC could be suspended and resumed. Fixes: 9603b61de1ee ("mlx5: Move pci device handling from ml

[PATCH AUTOSEL 5.4 14/14] l2tp: do not use inet_hash()/inet_unhash()

2020-06-05 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 02c71b144c811bcdd865e0a1226d0407d11357e8 ] syzbot recently found a way to crash the kernel [1] Issue here is that inet_hash() & inet_unhash() are currently only meant to be used by TCP & DCCP, since only these protocols provide the needed hashinfo pointer.

[PATCH AUTOSEL 5.4 08/14] nfp: flower: fix used time of merge flow statistics

2020-06-05 Thread Sasha Levin
From: Heinrich Kuhn [ Upstream commit 5b186cd60f033110960a3db424ffbd6de4cee528 ] Prior to this change the correct value for the used counter is calculated but not stored nor, therefore, propagated to user-space. In use-cases such as OVS use-case at least this results in active flows being remove

[PATCH AUTOSEL 5.4 13/14] drivers/net/ibmvnic: Update VNIC protocol version reporting

2020-06-05 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit 784688993ebac34dffe44a9f2fabbe126ebfd4db ] VNIC protocol version is reported in big-endian format, but it is not byteswapped before logging. Fix that, and remove version comparison as only one protocol version exists at this time. Signed-off-by: Thomas Falc

[PATCH AUTOSEL 4.19 7/9] NFC: st21nfca: add missed kfree_skb() in an error path

2020-06-05 Thread Sasha Levin
From: Chuhong Yuan [ Upstream commit 3decabdc714ca56c944f4669b4cdec5c2c1cea23 ] st21nfca_tm_send_atr_res() misses to call kfree_skb() in an error path. Add the missed function call to fix it. Fixes: 1892bf844ea0 ("NFC: st21nfca: Adding P2P support to st21nfca in Initiator & Target mode") Signe

[PATCH AUTOSEL 4.19 8/9] drivers/net/ibmvnic: Update VNIC protocol version reporting

2020-06-05 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit 784688993ebac34dffe44a9f2fabbe126ebfd4db ] VNIC protocol version is reported in big-endian format, but it is not byteswapped before logging. Fix that, and remove version comparison as only one protocol version exists at this time. Signed-off-by: Thomas Falc

[PATCH AUTOSEL 4.19 9/9] l2tp: do not use inet_hash()/inet_unhash()

2020-06-05 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 02c71b144c811bcdd865e0a1226d0407d11357e8 ] syzbot recently found a way to crash the kernel [1] Issue here is that inet_hash() & inet_unhash() are currently only meant to be used by TCP & DCCP, since only these protocols provide the needed hashinfo pointer.

[PATCH AUTOSEL 4.14 8/8] l2tp: do not use inet_hash()/inet_unhash()

2020-06-05 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 02c71b144c811bcdd865e0a1226d0407d11357e8 ] syzbot recently found a way to crash the kernel [1] Issue here is that inet_hash() & inet_unhash() are currently only meant to be used by TCP & DCCP, since only these protocols provide the needed hashinfo pointer.

[PATCH AUTOSEL 4.9 5/6] drivers/net/ibmvnic: Update VNIC protocol version reporting

2020-06-05 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit 784688993ebac34dffe44a9f2fabbe126ebfd4db ] VNIC protocol version is reported in big-endian format, but it is not byteswapped before logging. Fix that, and remove version comparison as only one protocol version exists at this time. Signed-off-by: Thomas Falc

[PATCH AUTOSEL 4.14 4/8] net: usb: qmi_wwan: add Telit LE910C1-EUX composition

2020-06-05 Thread Sasha Levin
From: Daniele Palmas [ Upstream commit 591612aa578cd7148b7b9d74869ef40118978389 ] Add support for Telit LE910C1-EUX composition 0x1031: tty, tty, tty, rmnet Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/qmi_

[PATCH AUTOSEL 4.9 4/6] NFC: st21nfca: add missed kfree_skb() in an error path

2020-06-05 Thread Sasha Levin
From: Chuhong Yuan [ Upstream commit 3decabdc714ca56c944f4669b4cdec5c2c1cea23 ] st21nfca_tm_send_atr_res() misses to call kfree_skb() in an error path. Add the missed function call to fix it. Fixes: 1892bf844ea0 ("NFC: st21nfca: Adding P2P support to st21nfca in Initiator & Target mode") Signe

[PATCH AUTOSEL 4.14 6/8] NFC: st21nfca: add missed kfree_skb() in an error path

2020-06-05 Thread Sasha Levin
From: Chuhong Yuan [ Upstream commit 3decabdc714ca56c944f4669b4cdec5c2c1cea23 ] st21nfca_tm_send_atr_res() misses to call kfree_skb() in an error path. Add the missed function call to fix it. Fixes: 1892bf844ea0 ("NFC: st21nfca: Adding P2P support to st21nfca in Initiator & Target mode") Signe

[PATCH AUTOSEL 4.9 3/6] net: usb: qmi_wwan: add Telit LE910C1-EUX composition

2020-06-05 Thread Sasha Levin
From: Daniele Palmas [ Upstream commit 591612aa578cd7148b7b9d74869ef40118978389 ] Add support for Telit LE910C1-EUX composition 0x1031: tty, tty, tty, rmnet Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/qmi_

[PATCH AUTOSEL 4.9 6/6] l2tp: do not use inet_hash()/inet_unhash()

2020-06-05 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 02c71b144c811bcdd865e0a1226d0407d11357e8 ] syzbot recently found a way to crash the kernel [1] Issue here is that inet_hash() & inet_unhash() are currently only meant to be used by TCP & DCCP, since only these protocols provide the needed hashinfo pointer.

[PATCH AUTOSEL 4.14 7/8] drivers/net/ibmvnic: Update VNIC protocol version reporting

2020-06-05 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit 784688993ebac34dffe44a9f2fabbe126ebfd4db ] VNIC protocol version is reported in big-endian format, but it is not byteswapped before logging. Fix that, and remove version comparison as only one protocol version exists at this time. Signed-off-by: Thomas Falc

  1   2   >