[PATCH net-next] qed: Add EDPM mode type for user-fw compatibility

2020-05-25 Thread Michal Kalderon
From: Yuval Basson In older FW versions the completion flag was treated as the ack flag in edpm messages. Expose the FW option of setting which mode the QP is in by adding a flag to the qedr <-> qed API. Flag is added for backward compatibility with libqedr. This flag will be set by qedr after d

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-25 Thread Vasundhara Volam
On Tue, May 26, 2020 at 10:17 AM Jiri Pirko wrote: > > Tue, May 26, 2020 at 06:28:59AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Mon, May 25, 2020 at 10:56 PM Jiri Pirko wrote: > >> > >> Sun, May 24, 2020 at 08:29:56AM CEST, vasundhara-v.vo...@broadcom.com > >> wrote: > >> >On Sun, May

Re: [PATCH 8/8] net/iucv: Use the new device_to_pm() helper to access struct dev_pm_ops

2020-05-25 Thread Greg Kroah-Hartman
On Mon, May 25, 2020 at 06:26:08PM +, Krzysztof Wilczyński wrote: > Use the new device_to_pm() helper to access Power Management callbacs > (struct dev_pm_ops) for a particular device (struct device_driver). > > No functional change intended. > > Signed-off-by: Krzysztof Wilczyński > --- >

[PATCH v3 bpf-next 4/5] bpf: add BPF ringbuf and perf buffer benchmarks

2020-05-25 Thread Andrii Nakryiko
Extend bench framework with ability to have benchmark-provided child argument parser for custom benchmark-specific parameters. This makes bench generic code modular and independent from any specific benchmark. Also implement a set of benchmarks for new BPF ring buffer and existing perf buffer. 4 b

[PATCH v3 bpf-next 2/5] libbpf: add BPF ring buffer support

2020-05-25 Thread Andrii Nakryiko
Declaring and instantiating BPF ring buffer doesn't require any changes to libbpf, as it's just another type of maps. So using existing BTF-defined maps syntax with __uint(type, BPF_MAP_TYPE_RINGBUF) and __uint(max_elements, ) is all that's necessary to create and use BPF ring buffer. This patch a

[PATCH v3 bpf-next 5/5] docs/bpf: add BPF ring buffer design notes

2020-05-25 Thread Andrii Nakryiko
Add commit description from patch #1 as a stand-alone documentation under Documentation/bpf, as it might be more convenient format, in long term perspective. Suggested-by: Stanislav Fomichev Signed-off-by: Andrii Nakryiko --- Documentation/bpf/ringbuf.rst | 209 +

Re: [PATCH 1/8] driver core: Add helper for accessing Power Management callbacs

2020-05-25 Thread Greg Kroah-Hartman
On Mon, May 25, 2020 at 06:26:01PM +, Krzysztof Wilczyński wrote: > Add driver_to_pm() helper allowing for accessing the Power Management > callbacs for a particular device. Access to the callbacs (struct > dev_pm_ops) is normally done through using the pm pointer that is > embedded within the

[PATCH v3 bpf-next 0/5] BPF ring buffer

2020-05-25 Thread Andrii Nakryiko
Implement a new BPF ring buffer, as presented at BPF virtual conference ([0]). It presents an alternative to perf buffer, following its semantics closely, but allowing sharing same instance of ring buffer across multiple CPUs efficiently. Most patches have extensive commentary explaining various a

[PATCH v3 bpf-next 3/5] selftests/bpf: add BPF ringbuf selftests

2020-05-25 Thread Andrii Nakryiko
Both singleton BPF ringbuf and BPF ringbuf with map-in-map use cases are tested. Also reserve+submit/discards and output variants of API are validated. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/ringbuf.c| 211 ++ .../selftests/bpf/prog_tests/ringbuf_

Re: clean up and streamline probe_kernel_* and friends v4

2020-05-25 Thread Christoph Hellwig
On Mon, May 25, 2020 at 03:19:12PM -0700, Andrew Morton wrote: > hm. Applying linux-next to this series generates a lot of rejects against > powerpc: > > -rw-rw-r-- 1 akpm akpm 493 May 25 15:06 arch/powerpc/kernel/kgdb.c.rej > -rw-rw-r-- 1 akpm akpm 6461 May 25 15:06 > arch/powerpc/kernel/trace

Re: [PATCH rdma-next v2 7/7] RDMA/cma: Provide ECE reject reason

2020-05-25 Thread Leon Romanovsky
On Mon, May 25, 2020 at 03:36:47PM -0300, Jason Gunthorpe wrote: > On Mon, May 25, 2020 at 09:22:42PM +0300, Leon Romanovsky wrote: > > On Mon, May 25, 2020 at 03:14:17PM -0300, Jason Gunthorpe wrote: > > > On Mon, Apr 13, 2020 at 05:15:38PM +0300, Leon Romanovsky wrote: > > > > @@ -4223,7 +4223,7

With regard to processing overlapping fragment packet

2020-05-25 Thread 강유건
Hello Actually, I'm not sure if it's right to send mail here. I'm testing ipv6ready Self Test 5.0.4 using linux-4.19.118 kernel. ( https://www.ipv6ready.org.cn/home/views/default/resource/logo/phase2-core/index.htm ) Test failed in 82. Part B: Reverse Order Fragments ( Link-Local ) in Section 1

Re: linux-next: manual merge of the net-next tree with the bpf tree

2020-05-25 Thread Björn Töpel
On 2020-05-26 05:12, Stephen Rothwell wrote: I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want

[PATCH] vdpa: bypass waking up vhost_woker for vdpa vq kick

2020-05-25 Thread Zhu Lingshan
Standard vhost devices rely on waking up a vhost_worker to kick a virtquque. However vdpa devices have hardware backends, so it does not need this waking up routin. In this commit, vdpa device will kick a virtqueue directly, reduce the performance overhead caused by waking up a vhost_woker. Signed

Re: [PATCH bpf-next] libbpf: add API to consume the perf ring buffer content

2020-05-25 Thread Andrii Nakryiko
On Mon, May 25, 2020 at 2:01 PM Eelco Chaudron wrote: > > This new API, perf_buffer__consume, can be used as follows: I wonder, was it inspired by yet-to-be committed ring_buffer__consume() or it's just a coincidence? > - When you have a perf ring where wakeup_events is higher than 1, > and yo

Re: [PATCH] net/ethernet/freescale: rework quiesce/activate for ucc_geth

2020-05-25 Thread Valentin Longchamp
Le 23.05.2020 à 00:50, David Miller a écrit : From: Valentin Longchamp Date: Wed, 20 May 2020 17:53:50 +0200 ugeth_quiesce/activate are used to halt the controller when there is a link change that requires to reconfigure the mac. The previous implementation called netif_device_detach(). This

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-25 Thread Jiri Pirko
Tue, May 26, 2020 at 06:28:59AM CEST, vasundhara-v.vo...@broadcom.com wrote: >On Mon, May 25, 2020 at 10:56 PM Jiri Pirko wrote: >> >> Sun, May 24, 2020 at 08:29:56AM CEST, vasundhara-v.vo...@broadcom.com wrote: >> >On Sun, May 24, 2020 at 10:23 AM Jiri Pirko wrote: >> >> >> >> Sat, May 23, 2020

Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-25 Thread Vasundhara Volam
On Mon, May 25, 2020 at 10:56 PM Jiri Pirko wrote: > > Sun, May 24, 2020 at 08:29:56AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >On Sun, May 24, 2020 at 10:23 AM Jiri Pirko wrote: > >> > >> Sat, May 23, 2020 at 08:08:22AM CEST, vasundhara-v.vo...@broadcom.com > >> wrote: > >> >Add a new "a

Re: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device wakeup is disabled

2020-05-25 Thread Chen Yu
Hi Sasha, On Tue, May 26, 2020 at 12:23:55AM +, Sasha Levin wrote: > Hi > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag > fixing commit: bc7f75fa9788 ("[E1000E]: New pci-express e1000 driver > (currently for ICH9 devices only)"). > > Th

linux-next: manual merge of the net-next tree with the bpf tree

2020-05-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/xdp/xdp_umem.c between commit: b16a87d0aef7 ("xsk: Add overflow check for u64 division, stored into u32") from the bpf tree and commit: 2b43470add8c ("xsk: Introduce AF_XDP buffer allocation API") from the net

Re: [PATCH v2 bpf-next 2/7] tools/memory-model: add BPF ringbuf MPSC litmus tests

2020-05-25 Thread Paul E. McKenney
On Mon, May 25, 2020 at 04:33:15PM -0700, Andrii Nakryiko wrote: > On Fri, May 22, 2020 at 11:51 AM Andrii Nakryiko > wrote: > > > > On Thu, May 21, 2020 at 5:34 PM Paul E. McKenney wrote: > > > > > > On Sun, May 17, 2020 at 12:57:22PM -0700, Andrii Nakryiko wrote: > > > > Add 4 litmus tests for

Re: [PATCH net-next] tcp: allow traceroute -Mtcp for unpriv users

2020-05-25 Thread Eric Dumazet
On 5/25/20 5:54 PM, David Miller wrote: > From: Eric Dumazet > Date: Sun, 24 May 2020 11:00:02 -0700 > >> Unpriv users can use traceroute over plain UDP sockets, but not TCP ones. >> >> $ traceroute -Mtcp 8.8.8.8 >> You do not have enough privileges to use this traceroute method. >> >> $ trace

Re: [PATCH 0/5] Netfilter fixes for net

2020-05-25 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 25 May 2020 23:54:15 +0200 > The following patchset contains Netfilter fixes for net: > > 1) Set VLAN tag in tcp reset/icmp unreachable packets to reject >connections in the bridge family, from Michael Braun. > > 2) Incorrect subcounter flag update in ipse

RE: [EXT] Re: [PATCH net 1/2] net: ethernet: dwmac: add Ethernet glue logic for NXP imx8 chip

2020-05-25 Thread Andy Duan
From: David Miller Sent: Tuesday, May 26, 2020 9:13 AM > From: Fugang Duan > Date: Mon, 25 May 2020 18:29:13 +0800 > > > +static int imx_dwmac_init(struct platform_device *pdev, void *priv) { > > + struct imx_priv_data *dwmac = priv; > > + struct plat_stmmacenet_data *plat_dat = dwmac->p

Re: [PATCH net-next 0/4] r8169: sync hw config for few chip versions with r8168 vendor driver

2020-05-25 Thread David Miller
From: Heiner Kallweit Date: Mon, 25 May 2020 19:48:16 +0200 > Sync hw config for few chip versions with r8168 vendor driver. Series applied, thanks.

Re: pull-request: mac80211 2020-05-25

2020-05-25 Thread David Miller
From: Johannes Berg Date: Mon, 25 May 2020 16:15:46 +0200 > We have a couple more fixes, all of them seem sort of older issues > that surfaced now. > > Please pull and let me know if there's any problem. Pulled, thanks Johannes.

Re: pull-request: wireless-drivers-next-2020-05-25

2020-05-25 Thread David Miller
From: Kalle Valo Date: Mon, 25 May 2020 11:48:28 + (UTC) > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. Pulled, thanks Kalle.

Re: [PATCH net 1/2] net: ethernet: dwmac: add Ethernet glue logic for NXP imx8 chip

2020-05-25 Thread David Miller
From: Fugang Duan Date: Mon, 25 May 2020 18:29:13 +0800 > +static int imx_dwmac_init(struct platform_device *pdev, void *priv) > +{ > + struct imx_priv_data *dwmac = priv; > + struct plat_stmmacenet_data *plat_dat = dwmac->plat_dat; > + int ret; > + Please code these sequences as:

Re: [PATCH] bridge: mrp: Fix out-of-bounds read in br_mrp_parse

2020-05-25 Thread David Miller
From: Horatiu Vultur Date: Mon, 25 May 2020 09:55:41 + > The issue was reported by syzbot. When the function br_mrp_parse was > called with a valid net_bridge_port, the net_bridge was an invalid > pointer. Therefore the check br->stp_enabled could pass/fail > depending where it was pointing i

Re: [PATCH] qlcnic: fix missing release in qlcnic_83xx_interrupt_test.

2020-05-25 Thread David Miller
From: wu000...@umn.edu Date: Mon, 25 May 2020 03:24:39 -0500 > From: Qiushi Wu > > In function qlcnic_83xx_interrupt_test(), function > qlcnic_83xx_diag_alloc_res() is not handled by function > qlcnic_83xx_diag_free_res() after a call of the function > qlcnic_alloc_mbx_args() failed. Fix this is

Re: [PATCH] drivers: ipa: print dev_err info accurately

2020-05-25 Thread David Miller
From: Wang Wenhu Date: Sun, 24 May 2020 23:29:51 -0700 > Print certain name string instead of hard-coded "memory" for dev_err > output, which would be more accurate and helpful for debugging. > > Signed-off-by: Wang Wenhu Applied to net-next, thanks.

Re: [PATCH net-next] net: Avoid spurious rx_dropped increases with tap and rx_handler

2020-05-25 Thread David Miller
From: Benjamin Poirier Date: Mon, 25 May 2020 14:01:37 +0900 > Consider an skb which doesn't match a ptype_base/ptype_specific handler. If > this skb is delivered to a ptype_all handler, it does not count as a drop. > However, if the skb is also processed by an rx_handler which returns > RX_HANDL

Re: [PATCH] dpaa_eth: fix usage as DSA master, try 3

2020-05-25 Thread David Miller
From: Vladimir Oltean Date: Mon, 25 May 2020 00:22:51 +0300 > From: Vladimir Oltean > > The dpaa-eth driver probes on compatible string for the MAC node, and > the fman/mac.c driver allocates a dpaa-ethernet platform device that > triggers the probing of the dpaa-eth net device driver. > > All

Re: [PATCH net-next V2] Let the ADJ_OFFSET interface respect the ADJ_NANO flag for PHC devices.

2020-05-25 Thread David Miller
From: Richard Cochran Date: Sun, 24 May 2020 11:27:10 -0700 > In commit 184ecc9eb260d5a3bcdddc5bebd18f285ac004e9 ("ptp: Add adjphase > function to support phase offset control.") the PTP Hardware Clock > interface expanded to support the ADJ_OFFSET offset mode. However, > the implementation did

Re: [PATCH net-next] tcp: allow traceroute -Mtcp for unpriv users

2020-05-25 Thread David Miller
From: Eric Dumazet Date: Sun, 24 May 2020 11:00:02 -0700 > Unpriv users can use traceroute over plain UDP sockets, but not TCP ones. > > $ traceroute -Mtcp 8.8.8.8 > You do not have enough privileges to use this traceroute method. > > $ traceroute -n -Mudp 8.8.8.8 > traceroute to 8.8.8.8 (8.8.8

Re: [PATCH net-next] ipv4: potential underflow in compat_ip_setsockopt()

2020-05-25 Thread David Miller
From: Dan Carpenter Date: Sat, 23 May 2020 20:46:48 +0300 > The value of "n" is capped at 0x1ff but it checked for negative > values. I don't think this causes a problem but I'm not certain and > it's harmless to prevent it. > > Fixes: 2e04172875c9 ("ipv4: do compat setsockopt for MCAST_MSF

Re: [PATCH net-next] bnx2x: allow bnx2x_bsc_read() to schedule

2020-05-25 Thread David Miller
From: Eric Dumazet Date: Sat, 23 May 2020 12:46:49 -0700 > bnx2x_warpcore_read_sfp_module_eeprom() can call bnx2x_bsc_read() > three times before giving up. > > This causes latency blips of at least 31 ms (58 ms being reported > by our teams) > > Convert the long lasting loops of udelay() to us

Re: [PATCH net-next v2 0/2] flow_dissector, cls_flower: Add support for multiple MPLS Label Stack Entries

2020-05-25 Thread David Miller
From: David Miller Date: Mon, 25 May 2020 17:38:18 -0700 (PDT) > Series applied, thanks. Reverted, this doesn't even build with the one of the most popular drivers in the tree, mlx5. drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_mplsoudp.c: In function ‘parse_tunnel’: drivers/net/ethernet/

Re: [PATCH] drivers: ipa: print dev_err info accurately

2020-05-25 Thread Alex Elder
On 5/25/20 1:29 AM, Wang Wenhu wrote: Print certain name string instead of hard-coded "memory" for dev_err output, which would be more accurate and helpful for debugging. Signed-off-by: Wang Wenhu Cc: Alex Elder Good idea. Reviewed-by: Alex Elder --- drivers/net/ipa/ipa_clock.c | 4 ++-

Re: [PATCH 1/1] MVNETA_SKB_HEADROOM set last 3 bits to zero

2020-05-25 Thread David Miller
From: Sven Auhagen Date: Sat, 23 May 2020 12:14:08 +0200 > For XDP the MVNETA_SKB_HEADROOM is used as an offset for > the received data. > The MVNETA manual states that the last 3 bits assumed to be 0. > > This is currently the case but lets make it explicit in the definition > to prevent futur

Re: [PATCH net-next,v2] net/tls: fix race condition causing kernel panic

2020-05-25 Thread David Miller
From: Vinay Kumar Yadav Date: Sat, 23 May 2020 01:40:31 +0530 > tls_sw_recvmsg() and tls_decrypt_done() can be run concurrently. > // tls_sw_recvmsg() > if (atomic_read(&ctx->decrypt_pending)) > crypto_wait_req(-EINPROGRESS, &ctx->async_wait); > else > rein

Re: [PATCH net-next v2 0/2] flow_dissector, cls_flower: Add support for multiple MPLS Label Stack Entries

2020-05-25 Thread David Miller
From: Guillaume Nault Date: Thu, 21 May 2020 19:47:08 +0200 > Currently, the flow dissector and the Flower classifier can only handle > the first entry of an MPLS label stack. This patch series generalises > the code to allow parsing and matching the Label Stack Entries that > follow. > > Patch

Re: [PATCH 1/2] e1000e: Do not wake up the system via WOL if device wakeup is disabled

2020-05-25 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a "Fixes:" tag fixing commit: bc7f75fa9788 ("[E1000E]: New pci-express e1000 driver (currently for ICH9 devices only)"). The bot has tested the following trees: v5.6.14, v5.4.42, v4.19.124, v4.14.181, v4.9.224,

Re: [net-next 11/17] ice: Fix resource leak on early exit from function

2020-05-25 Thread Sasha Levin
Hi [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v5.6.14, v5.4.42, v4.19.124, v4.14.181, v4.9.224, v4.4.224. v5.6.14: Build OK! v5.4

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Russell King - ARM Linux admin
On Mon, May 25, 2020 at 06:42:50PM -0500, Jeremy Linton wrote: > Hi, > > On 5/25/20 6:33 PM, Russell King - ARM Linux admin wrote: > > On Mon, May 25, 2020 at 06:22:19PM -0500, Jeremy Linton wrote: > > > On 5/25/20 6:09 PM, Russell King - ARM Linux admin wrote: > > > > On Mon, May 25, 2020 at 05:2

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Andrew Lunn
On Mon, May 25, 2020 at 06:46:10PM -0500, Jeremy Linton wrote: > Hi, > > > On 5/25/20 6:12 PM, Andrew Lunn wrote: > > > arch/powerpc/boot/dts/fsl/t4240rdb.dts: compatible = > > > "ethernet-phy-id13e5.1002"; > > > arch/powerpc/boot/dts/fsl/t4240rdb.dts: compatible = > > > "ethernet-phy-id13e5.10

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Jeremy Linton
Hi, On 5/25/20 6:12 PM, Andrew Lunn wrote: arch/powerpc/boot/dts/fsl/t4240rdb.dts: compatible = "ethernet-phy-id13e5.1002"; arch/powerpc/boot/dts/fsl/t4240rdb.dts: compatible = "ethernet-phy-id13e5.1002"; arch/powerpc/boot/dts/fsl/t4240rdb.dts: compatible = "ethernet-phy-id13e5.1002"; arch/powe

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Andrew Lunn
> Right, which is what I sort of expected. Because its falling back to a > device list of 0x, which means probe every single MMD. > > Combined with the lack of filtering means that your getting a bunch of MMD > IDs that potentially are invalid, along with any that happen to be valid. > Its

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Jeremy Linton
Hi, On 5/25/20 6:33 PM, Russell King - ARM Linux admin wrote: On Mon, May 25, 2020 at 06:22:19PM -0500, Jeremy Linton wrote: On 5/25/20 6:09 PM, Russell King - ARM Linux admin wrote: On Mon, May 25, 2020 at 05:22:07PM -0500, Jeremy Linton wrote: On 5/25/20 5:01 PM, Russell King - ARM Linux ad

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Russell King - ARM Linux admin
On Mon, May 25, 2020 at 06:22:19PM -0500, Jeremy Linton wrote: > On 5/25/20 6:09 PM, Russell King - ARM Linux admin wrote: > > On Mon, May 25, 2020 at 05:22:07PM -0500, Jeremy Linton wrote: > > > On 5/25/20 5:01 PM, Russell King - ARM Linux admin wrote: > > > > On Mon, May 25, 2020 at 04:51:16PM -0

Re: [PATCH v2 bpf-next 2/7] tools/memory-model: add BPF ringbuf MPSC litmus tests

2020-05-25 Thread Andrii Nakryiko
On Fri, May 22, 2020 at 11:51 AM Andrii Nakryiko wrote: > > On Thu, May 21, 2020 at 5:34 PM Paul E. McKenney wrote: > > > > On Sun, May 17, 2020 at 12:57:22PM -0700, Andrii Nakryiko wrote: > > > Add 4 litmus tests for BPF ringbuf implementation, divided into two > > > different > > > use cases.

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Russell King - ARM Linux admin
On Mon, May 25, 2020 at 06:16:18PM -0500, Jeremy Linton wrote: > Hi, > > On 5/25/20 5:01 PM, Russell King - ARM Linux admin wrote: > > On Mon, May 25, 2020 at 04:51:16PM -0500, Jeremy Linton wrote: > > > So, my goals here have been to first, not break anything, and then do a > > > slightly better

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Jeremy Linton
On 5/25/20 6:09 PM, Russell King - ARM Linux admin wrote: On Mon, May 25, 2020 at 05:22:07PM -0500, Jeremy Linton wrote: On 5/25/20 5:01 PM, Russell King - ARM Linux admin wrote: On Mon, May 25, 2020 at 04:51:16PM -0500, Jeremy Linton wrote: Hi, On 5/25/20 5:06 AM, Russell King - ARM Linux ad

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Jeremy Linton
Hi, On 5/25/20 5:01 PM, Russell King - ARM Linux admin wrote: On Mon, May 25, 2020 at 04:51:16PM -0500, Jeremy Linton wrote: Hi, On 5/25/20 5:06 AM, Russell King - ARM Linux admin wrote: On Sun, May 24, 2020 at 10:34:13PM -0500, Jeremy Linton wrote: Hi, On 5/23/20 1:37 PM, Russell King - AR

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Andrew Lunn
> arch/powerpc/boot/dts/fsl/t4240rdb.dts: compatible = > "ethernet-phy-id13e5.1002"; > arch/powerpc/boot/dts/fsl/t4240rdb.dts: compatible = > "ethernet-phy-id13e5.1002"; > arch/powerpc/boot/dts/fsl/t4240rdb.dts: compatible = > "ethernet-phy-id13e5.1002"; > arch/powerpc/boot/dts/fsl/t4240rdb.dts:

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Russell King - ARM Linux admin
On Mon, May 25, 2020 at 05:22:07PM -0500, Jeremy Linton wrote: > On 5/25/20 5:01 PM, Russell King - ARM Linux admin wrote: > > On Mon, May 25, 2020 at 04:51:16PM -0500, Jeremy Linton wrote: > > > Hi, > > > > > > On 5/25/20 5:06 AM, Russell King - ARM Linux admin wrote: > > > > On Sun, May 24, 2020

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Russell King - ARM Linux admin
On Mon, May 25, 2020 at 05:17:27PM -0500, Jeremy Linton wrote: > Hi, > > On 5/25/20 5:06 PM, Andrew Lunn wrote: > > > Yes, we know even for the NXP reference hardware, one of the phy's doesn't > > > probe out correctly because it doesn't respond to the ieee defined > > > registers. I think at this

[PATCH net-next 08/14] mlxsw: switchx2: Move SwitchX-2 trap groups out of main enum

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel The number of Spectrum trap groups is not infinite, but two identifiers are occupied by SwitchX-2 specific trap groups. Free these identifiers by moving them out of the main enum. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/re

[PATCH net-next 14/14] mlxsw: spectrum_router: Allow programming link-local prefix routes

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel The device has a trap for IPv6 packets that need be routed and have a unicast link-local destination IP (i.e., fe80::/10). This allows mlxsw to ignore link-local routes, as the packets will be trapped to the CPU in any case. However, since link-local routes are not programmed,

[PATCH net-next 06/14] mlxsw: spectrum: Use same trap group for local routes and link-local destination

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel Packets with an IPv6 link-local destination (i.e., fe80::/10) should not be forwarded and are therefore trapped to the CPU for local delivery. Since these packets are trapped for the same logical reason as packets hitting local routes, associate both traps with the same group.

[PATCH net-next 11/14] mlxsw: spectrum: Share one group for all locally delivered packets

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel Routed IP packets with the Router Alert option need to be trapped to the CPU as they might need to be locally delivered to raw sockets with the IP_ROUTER_ALERT / IPV6_ROUTER_ALERT socket option. Move them to the same group with other packets that might need to be trapped follo

[PATCH net-next 04/14] mlxsw: spectrum: Use same trap group for various IPv6 packets

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel Group these various IPv6 packets (e.g., router solicitations, router advertisement) together and subject them to the same policer. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 6 +++--- 1 file changed, 3 insertions

[PATCH net-next 05/14] mlxsw: spectrum: Use separate trap group for FID miss

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel When a packet enters the device it is classified to a filtering identifier (FID) based on the ingress port and VLAN. The FID miss trap is used to trap packets for which a FID could not be found. In mlxsw this trap should only be triggered when a port is enslaved to an OVS brid

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Andrew Lunn
> I know for sure we find phys that previously weren't found. That is in itself somewhat dangerous. Those using primitive configuration systems are probably going to use phy_find_first(), rather than an address on the bus. I always recommend against that, because if another PHY suddenly pops up o

[PATCH net-next 03/14] mlxsw: spectrum: Rename IPv6 ND trap group

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel The IPv6 Neighbour Discovery (ND) group will be used for various IPv6 packets, not all of which fall under the definition of ND, so rename it to "IPV6" which is more appropriate. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg

[PATCH net-next 01/14] mlxsw: spectrum: Use dedicated trap group for ACL trap

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel Packets that are trapped via tc's trap action are currently subject to the same policer as packets hitting local routes. The latter are critical to the correct functioning of the control plane, while the former are mainly used for traffic inspection. Split the ACL trap to a se

[PATCH net-next 00/14] mlxsw: Various trap changes - part 2

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel This patch set contains another set of small changes in mlxsw trap configuration. It is the last set before exposing control traps (e.g., IGMP query, ARP request) via devlink-trap. Tested with existing devlink-trap selftests. Please see individual patches for a detailed change

[PATCH net-next 07/14] mlxsw: spectrum: Reduce priority of locally delivered packets

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel To align with recent recommended values. Will be configurable by future patches. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c| 2 +- tools/testing/selftests/drivers/net/mlxsw/sharedbuffer.sh | 2 +- 2 fil

[PATCH net-next 09/14] mlxsw: spectrum_trap: Do not hard code "thin" policer identifier

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel As explained in commit e612523041ab ("mlxsw: spectrum_trap: Introduce dummy group with thin policer"), the purpose of the "thin" policer is to pass as less packets as possible to the CPU. The identifier of this policer is currently set according to the maximum number of used t

[PATCH net-next 02/14] mlxsw: spectrum: Use same switch case for identical groups

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel Trap groups that use the same policer settings can share the same switch case. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/sp

[PATCH net-next 10/14] mlxsw: reg: Move all trap groups under the same enum

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel After the previous patch the split is no longer necessary and all the trap groups can be moved under the same enum. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 10 +++--- 1 file changed, 3 insertions(+), 7 deletion

[PATCH net-next 13/14] mlxsw: spectrum: Add packet traps for BFD packets

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel Bidirectional Forwarding Detection (BFD) provides "low-overhead, short-duration detection of failures in the path between adjacent forwarding engines" (RFC 5880). This is accomplished by exchanging BFD packets between the two forwarding engines. Up until now these packets were

[PATCH net-next 12/14] mlxsw: spectrum: Treat IPv6 link-local SIP as an exception

2020-05-25 Thread Ido Schimmel
From: Ido Schimmel IPv6 packets that need to be forwarded and have a link-local source IP are dropped by the kernel and an ICMPv6 "Destination unreachable" is sent to the sending host. As such, change the trap group of such packets so that they do not interfere with IPv6 management packets. In t

[PATCH] bpf: Fix spelling in comment

2020-05-25 Thread Chris Packham
Change 'handeled' to 'handled'. Signed-off-by: Chris Packham --- kernel/bpf/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c index 916f5132a984..1ff8e73e9b12 100644 --- a/kernel/bpf/core.c +++ b/kernel/bpf/core.c @@ -1543,7 +1543,7

Re: [bpf-next PATCH v5 2/5] bpf: extend bpf_base_func_proto helpers with probe_* and *current_task*

2020-05-25 Thread John Fastabend
Daniel Borkmann wrote: > On 5/24/20 6:50 PM, John Fastabend wrote: > > Often it is useful when applying policy to know something about the > > task. If the administrator has CAP_SYS_ADMIN rights then they can > > use kprobe + networking hook and link the two programs together to > > accomplish this

Re: [PATCH] net: sctp: Fix spelling in Kconfig help

2020-05-25 Thread Marcelo Ricardo Leitner
On Tue, May 26, 2020 at 10:55:59AM +1200, Chris Packham wrote: > Change 'handeled' to 'handled' in the Kconfig help for SCTP. > > Signed-off-by: Chris Packham Acked-by: Marcelo Ricardo Leitner

Re: [bpf-next PATCH v5 1/5] bpf, sk_msg: add some generic helpers that may be useful from sk_msg

2020-05-25 Thread John Fastabend
Daniel Borkmann wrote: > On 5/24/20 6:50 PM, John Fastabend wrote: > > Add these generic helpers that may be useful to use from sk_msg programs. > > The helpers do not depend on ctx so we can simply add them here, > > > > BPF_FUNC_perf_event_output > > BPF_FUNC_get_current_uid_gid > > BPF_FU

[PATCH] net: sctp: Fix spelling in Kconfig help

2020-05-25 Thread Chris Packham
Change 'handeled' to 'handled' in the Kconfig help for SCTP. Signed-off-by: Chris Packham --- net/sctp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/Kconfig b/net/sctp/Kconfig index 6e2eb1dd64ed..68934438ee19 100644 --- a/net/sctp/Kconfig +++ b/net/sctp/Kco

Re: [RFC 08/11] net: phy: Allow mdio buses to auto-probe c45 devices

2020-05-25 Thread Russell King - ARM Linux admin
On Mon, May 25, 2020 at 05:09:56PM -0500, Jeremy Linton wrote: > Hi, > > On 5/25/20 3:25 AM, Russell King - ARM Linux admin wrote: > > On Sun, May 24, 2020 at 11:28:52PM -0500, Jeremy Linton wrote: > > > Hi, > > > > > > On 5/24/20 9:44 AM, Andrew Lunn wrote: > > > > > +++ b/include/linux/phy.h >

Re: [PATCH bpf] xsk: add overflow check for u64 division, stored into u32

2020-05-25 Thread Jonathan Lemon
On Mon, May 25, 2020 at 10:03:59AM +0200, Björn Töpel wrote: > From: Björn Töpel > > The npgs member of struct xdp_umem is an u32 entity, and stores the > number of pages the UMEM consumes. The calculation of npgs > > npgs = size / PAGE_SIZE > > can overflow. > > To avoid overflow scenarios,

Re: [PATCH] MAINTAINERS: adjust entry in XDP SOCKETS to actual file name

2020-05-25 Thread Daniel Borkmann
- Björn, please pick this minor non-urgent patch. applies to next-20200525 on top of the commits mentioned above Thanks Lukas! Daniel/Alexei, this should go to the bpf-next tree. Yep, applied, thanks!

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Jeremy Linton
On 5/25/20 5:01 PM, Russell King - ARM Linux admin wrote: On Mon, May 25, 2020 at 04:51:16PM -0500, Jeremy Linton wrote: Hi, On 5/25/20 5:06 AM, Russell King - ARM Linux admin wrote: On Sun, May 24, 2020 at 10:34:13PM -0500, Jeremy Linton wrote: Hi, On 5/23/20 1:37 PM, Russell King - ARM Lin

Re: [PATCH bpf-next] bpf: Fix returned error sign when link doesn't support updates

2020-05-25 Thread Daniel Borkmann
On 5/25/20 2:29 PM, Jakub Sitnicki wrote: System calls encode returned errors as negative values. Fix a typo that breaks this convention for bpf(LINK_UPDATE) when bpf_link doesn't support update operation. Fixes: f9d041271cf4 ("bpf: Refactor bpf_link update handling") Signed-off-by: Jakub Sitnic

Re: [PATCH bpf-next v2] tools: bpftool: make capability check account for new BPF caps

2020-05-25 Thread Daniel Borkmann
On 5/23/20 3:02 AM, Quentin Monnet wrote: Following the introduction of CAP_BPF, and the switch from CAP_SYS_ADMIN to other capabilities for various BPF features, update the capability checks (and potentially, drops) in bpftool for feature probes. Because bpftool and/or the system might not know

Re: [PATCH bpf-next] tools: bpftool: clean subcommand help messages

2020-05-25 Thread Daniel Borkmann
On 5/23/20 3:07 AM, Quentin Monnet wrote: This is a clean-up for the formatting of the do_help functions for bpftool's subcommands. The following fixes are included: - Do not use argv[-2] for "iter" help message, as the help is shown by default if no "iter" action is selected, resulting in me

Re: [PATCH bpf] xsk: add overflow check for u64 division, stored into u32

2020-05-25 Thread Daniel Borkmann
On 5/25/20 10:03 AM, Björn Töpel wrote: From: Björn Töpel The npgs member of struct xdp_umem is an u32 entity, and stores the number of pages the UMEM consumes. The calculation of npgs npgs = size / PAGE_SIZE can overflow. To avoid overflow scenarios, the division is now first stored in a

Re: clean up and streamline probe_kernel_* and friends v4

2020-05-25 Thread Andrew Morton
On Thu, 21 May 2020 17:22:38 +0200 Christoph Hellwig wrote: > this series start cleaning up the safe kernel and user memory probing > helpers in mm/maccess.c, and then allows architectures to implement > the kernel probing without overriding the address space limit and > temporarily allowing acce

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Jeremy Linton
Hi, On 5/25/20 5:06 PM, Andrew Lunn wrote: Yes, we know even for the NXP reference hardware, one of the phy's doesn't probe out correctly because it doesn't respond to the ieee defined registers. I think at this point, there really isn't anything we can do about that unless we involve the (ACPI)

Re: [RFC 08/11] net: phy: Allow mdio buses to auto-probe c45 devices

2020-05-25 Thread Jeremy Linton
Hi, On 5/25/20 3:25 AM, Russell King - ARM Linux admin wrote: On Sun, May 24, 2020 at 11:28:52PM -0500, Jeremy Linton wrote: Hi, On 5/24/20 9:44 AM, Andrew Lunn wrote: +++ b/include/linux/phy.h @@ -275,6 +275,11 @@ struct mii_bus { int reset_delay_us; /* RESET GPIO descriptor

Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct

2020-05-25 Thread Daniel Lezcano
On 25/05/2020 21:35, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > W dniu 23.05.2020 o 23:24, Daniel Lezcano pisze: >> Hi Andrzej, >> >> On 17/04/2020 18:20, Andrzej Pietrasiewicz wrote: >>> Thermal zone devices' mode is stored in individual drivers. This patch >>> changes it so that mode is store

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Andrew Lunn
> Yes, we know even for the NXP reference hardware, one of the phy's doesn't > probe out correctly because it doesn't respond to the ieee defined > registers. I think at this point, there really isn't anything we can do > about that unless we involve the (ACPI) firmware in currently nonstandard > b

Re: [RFC 04/11] net: phy: Handle c22 regs presence better

2020-05-25 Thread Russell King - ARM Linux admin
On Mon, May 25, 2020 at 04:51:16PM -0500, Jeremy Linton wrote: > Hi, > > On 5/25/20 5:06 AM, Russell King - ARM Linux admin wrote: > > On Sun, May 24, 2020 at 10:34:13PM -0500, Jeremy Linton wrote: > > > Hi, > > > > > > On 5/23/20 1:37 PM, Russell King - ARM Linux admin wrote: > > > > On Fri, May

Re: [RFC 01/11] net: phy: Don't report success if devices weren't found

2020-05-25 Thread Jeremy Linton
Hi, On 5/25/20 4:07 PM, Russell King - ARM Linux admin wrote: On Mon, May 25, 2020 at 04:02:13PM -0500, Jeremy Linton wrote: So, I think you're going to have to add a work-around to ignore bit 0, which brings up the question whether this is worth it or not. It does ignore bit 0, it gets turne

[PATCH 1/5] netfilter: nft_reject_bridge: enable reject with bridge vlan

2020-05-25 Thread Pablo Neira Ayuso
From: Michael Braun Currently, using the bridge reject target with tagged packets results in untagged packets being sent back. Fix this by mirroring the vlan id as well. Fixes: 85f5b3086a04 ("netfilter: bridge: add reject support") Signed-off-by: Michael Braun Signed-off-by: Pablo Neira Ayuso

[PATCH 4/5] netfilter: conntrack: make conntrack userspace helpers work again

2020-05-25 Thread Pablo Neira Ayuso
Florian Westphal says: "Problem is that after the helper hook was merged back into the confirm one, the queueing itself occurs from the confirm hook, i.e. we queue from the last netfilter callback in the hook-list. Therefore, on return, the packet bypasses the confirm action and the connection is

[PATCH 2/5] netfilter: ipset: Fix subcounter update skip

2020-05-25 Thread Pablo Neira Ayuso
From: Phil Sutter If IPSET_FLAG_SKIP_SUBCOUNTER_UPDATE is set, user requested to not update counters in sub sets. Therefore IPSET_FLAG_SKIP_COUNTER_UPDATE must be set, not unset. Fixes: 6e01781d1c80e ("netfilter: ipset: set match: add support to match the counters") Signed-off-by: Phil Sutter

[PATCH 3/5] netfilter: nf_conntrack_pptp: prevent buffer overflows in debug code

2020-05-25 Thread Pablo Neira Ayuso
Dan Carpenter says: "Smatch complains that the value for "cmd" comes from the network and can't be trusted." Add pptp_msg_name() helper function that checks for the array boundary. Fixes: f09943fefe6b ("[NETFILTER]: nf_conntrack/nf_nat: add PPTP helper port") Reported-by: Dan Carpenter Signed-of

[PATCH 5/5] netfilter: nfnetlink_cthelper: unbreak userspace helper support

2020-05-25 Thread Pablo Neira Ayuso
Restore helper data size initialization and fix memcopy of the helper data size. Fixes: 157eb5dc ("netfilter: nfnetlink_cthelper: reject too large userspace allocation requests") Reviewed-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetlink_cthelper.c | 3 ++-

[PATCH 0/5] Netfilter fixes for net

2020-05-25 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter fixes for net: 1) Set VLAN tag in tcp reset/icmp unreachable packets to reject connections in the bridge family, from Michael Braun. 2) Incorrect subcounter flag update in ipset, from Phil Sutter. 3) Possible buffer overflow in the pptp conntrack

Re: [bpf-next PATCH v5 2/5] bpf: extend bpf_base_func_proto helpers with probe_* and *current_task*

2020-05-25 Thread Daniel Borkmann
On 5/24/20 6:50 PM, John Fastabend wrote: Often it is useful when applying policy to know something about the task. If the administrator has CAP_SYS_ADMIN rights then they can use kprobe + networking hook and link the two programs together to accomplish this. However, this is a bit clunky and als

  1   2   3   >