[net-next 02/16] ice: Initialize Flow Director resources

2020-05-22 Thread Jeff Kirsher
From: Henry Tieman Flow Director allows for redirection based on ntuple rules. Rules are programmed using the ethtool set-ntuple interface. Supported actions are redirect to queue and drop. Setup the initial framework to process Flow Director filters. Create and allocate resources to manage and

[net-next 05/16] ice: Support IPv6 Flow Director filters

2020-05-22 Thread Jeff Kirsher
From: Henry Tieman Extend supported filters to allow for IPv6 filters. Supported fields are: src-ip, dst-ip, src-port, and dst-port Supported flow-types are: tcp6, udp6, sctp6, ip6 Example usage: ethtool -N eth0 flow-type tcp6 src-port 12 dst-port 13 \ src-ip fce0::1:34 dst-ip fce0::1:35 actio

[net-next 03/16] ice: Support displaying ntuple rules

2020-05-22 Thread Jeff Kirsher
From: Henry Tieman Add functionality for ethtool --show-ntuple, allowing for filters to be displayed when set functionality is added. Add statistics related to Flow Director matches and status. Signed-off-by: Henry Tieman Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff

[net-next 08/16] ice: Implement aRFS

2020-05-22 Thread Jeff Kirsher
From: Brett Creeley Enable accelerated Receive Flow Steering (aRFS). It is used to steer Rx flows to a specific queue. This functionality is triggered by the network stack through ndo_rx_flow_steer and requires Flow Director (ntuple on) to function. The fltr_info is used to add/remove/update flo

[net-next 09/16] ice: Call ice_aq_set_mac_cfg

2020-05-22 Thread Jeff Kirsher
From: Anirudh Venkataramanan As per the specification, the driver needs to call set_mac_cfg (opcode 0x0603) to be able to exercise jumbo frames. Call the function during initialization and the post reset rebuild flow. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Tony Nguyen Tested-by:

[net-next 06/16] ice: Enable flex-bytes support

2020-05-22 Thread Jeff Kirsher
From: Henry Tieman Flex-bytes allows for packet matching based on an offset and value. This is supported via the ethtool user-def option. It is specified by providing an offset followed by a 2 byte match value. Offset is measured from the start of the MAC address. The following restrictions app

[net-next 13/16] ice: check for compatibility between DDP package and firmware

2020-05-22 Thread Jeff Kirsher
From: Victor Raj Require the Dynamic Device Personalization (DDP) file to have the same major version number and the same or older minor number than the firmware version major and minor, respectively. Check the OS and NVM package versions before downloading the package. If the OS package version

[net-next 15/16] ice: fix usage of incorrect variable

2020-05-22 Thread Jeff Kirsher
From: Jesse Brandeburg The driver was using rq_last_status where it should have been using sq_last_status. Fix the string to be using the correct error reporting variable. Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/

[net-next 07/16] ice: Restore filters following reset

2020-05-22 Thread Jeff Kirsher
From: Henry Tieman Following a reset, Flow Director filters are cleared from the hardware. Rebuild the filters using the software structures containing the filter rules. Signed-off-by: Henry Tieman Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/n

[net-next 01/16] virtchnl: Add missing explicit padding to structures

2020-05-22 Thread Jeff Kirsher
From: Geert Uytterhoeven On e.g. m68k, the alignment of 32-bit values is only 2 bytes, leading to the following: ./include/linux/avf/virtchnl.h:147:36: warning: division by zero [-Wdiv-by-zero] { virtchnl_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }

[net-next 12/16] ice: Check if unicast MAC exists before setting VF MAC

2020-05-22 Thread Jeff Kirsher
From: Brett Creeley Currently if a unicast MAC is set via ndo_set_vf_mac, the PF driver will set the VF's dflt_lan_addr.addr once some basic checks have passed. The VF is then reset. During reset the PF driver will attempt to program the VF's MAC from the dflt_lan_addr.addr field. This fails when

[net-next 14/16] ice: Fix bad register reads

2020-05-22 Thread Jeff Kirsher
From: Anirudh Venkataramanan The "ethtool -d" handler reads registers in the ice_regs_dump_list array and returns read values back to the userspace. The register offsets PFINT0_ITR* are not valid as per the specification and reading these causes a "unable to handle kernel paging request" bug in

[net-next 11/16] ice: Fix Tx timeout when link is toggled on a VF's interface

2020-05-22 Thread Jeff Kirsher
From: Brett Creeley Currently if the iavf is loaded and a VF link transitions from up to down to up again a Tx timeout will be triggered. This happens because Tx/Rx queue interrupts are only enabled when receiving the VIRTCHNL_OP_CONFIG_MAP_IRQ message, which happens on reset or initial iavf driv

[net-next 10/16] ice: print Rx MDD auto reset message before VF reset

2020-05-22 Thread Jeff Kirsher
From: Paul Greenwalt Rx MDD auto reset message was not being logged because logging occurred after the VF reset and the VF MDD data was reinitialized. Log the Rx MDD auto reset message before triggering the VF reset. Signed-off-by: Paul Greenwalt Tested-by: Andrew Bowers Signed-off-by: Jeff K

[net-next 16/16] ice: cleanup unsigned loops

2020-05-22 Thread Jeff Kirsher
From: Jesse Brandeburg Fix loop variables that are comparing or assigning signed against unsigned values, mostly by declaring loop counters as unsigned. Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_dcb_nl.c |

[net-next 00/16][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-22

2020-05-22 Thread Jeff Kirsher
This series contains updates to virtchnl and the ice driver. Geert Uytterhoeven fixes a data structure alignment issue in the virtchnl structures. Henry adds Flow Director support which allows for the redirection on ntuple rules over six patches. Initially Henry adds the initial infrastructure f

Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client

2020-05-22 Thread Greg KH
On Fri, May 22, 2020 at 09:29:57AM -0500, Pierre-Louis Bossart wrote: > This is not an hypothetical case, we've had this recurring problem when a > PCI device creates an audio card represented as a platform device. When the > card registration fails, typically due to configuration issues, the PCI >

[PATCH v2 net-next 0/4] bnxt_en: Add new "allow_fw_live_reset" generic devlink parameter

2020-05-22 Thread Vasundhara Volam
This patchset adds support for a "allow_fw_live_reset" generic devlink parameter and use it in bnxt_en driver. Firmware live reset allows users to reset the firmware in real time. For example, after firmware upgrade, this feature can immediately reset to run the new firmware without reloading the

[PATCH v2 net-next 3/4] bnxt_en: Use allow_fw_live_reset generic devlink parameter

2020-05-22 Thread Vasundhara Volam
allow_fw_live_reset parameter supports both permanent and runtime configuration modes. Permanent configuration mode allows user to enable the firmware live reset device capability in NVRAM configuration. Runtime configuration mode allows the user to prevent firmware live reset by setting it to fal

[PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.

2020-05-22 Thread Vasundhara Volam
Add a new "allow_fw_live_reset" generic device bool parameter. When parameter is set, user is allowed to reset the firmware in real time. This parameter is employed to communicate user consent or dissent for the live reset to happen. A separate command triggers the actual live reset. Cc: Jiri Pir

[PATCH v2 net-next 4/4] bnxt_en: Check if fw_live_reset is allowed before doing ETHTOOL_RESET

2020-05-22 Thread Vasundhara Volam
If device does not allow fw_live_reset, issue FW_RESET command without graceful flag, which requires a driver reload to reset the firmware. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan Reviewed-by: Edwin Peer --- v2: Rephrase the subject and elaborate commit message --- drivers/

[PATCH v2 net-next 2/4] bnxt_en: Update firmware spec. to 1.10.1.40.

2020-05-22 Thread Vasundhara Volam
Major changes are to add additional flags to configure hot firmware reset. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan Reviewed-by: Edwin Peer --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 64 --- 1 file changed, 37 insertions(+), 27 deletions(-)

[PATCHv3 bpf-next 0/2] xdp: add dev map multicast support

2020-05-22 Thread Hangbin Liu
Hi all, This patchset is for xdp multicast support, which has been discussed before[0]. The goal is to be able to implement an OVS-like data plane in XDP, i.e., a software switch that can forward XDP frames to multiple ports. To achieve this, an application needs to specify a group of interfaces

[PATCHv3 bpf-next 1/2] xdp: add a new helper for dev map multicast support

2020-05-22 Thread Hangbin Liu
This patch is for xdp multicast support. In this implementation we add a new helper to accept two maps: forward map and exclude map. We will redirect the packet to all the interfaces in *forward map*, but exclude the interfaces that in *exclude map*. To achive this I add a new ex_map for struct bp

[PATCHv3 bpf-next 2/2] sample/bpf: add xdp_redirect_map_multicast test

2020-05-22 Thread Hangbin Liu
This is a sample for xdp multicast. In the sample we have 3 forward groups and 1 exclude group. It will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. For more testing details, please see the test description in xdp_redirect_

[PATCH] mt76: mt7915: Use proper enum type in __mt7915_mcu_msg_send

2020-05-22 Thread Nathan Chancellor
Clang warns: drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:232:9: warning: implicit conversion from enumeration type 'enum mt76_txq_id' to different enumeration type 'enum mt7915_txq_id' [-Wenum-conversion] txq = MT_TXQ_FWDL; ~ ^~~ drivers/net/wireless

[net-next 08/17] igc: Fix NFC rules leak when driver is unloaded

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes If we have RFC rules in adapter->nfc_rule_list when the IGC driver is unloaded, all rules are leaked. This patch fixes the issue by introducing the helper igc_flush_nfc_rules() and calling it in igc_remove(). It also updates igc_set_features() so is reuses the new helper instea

[net-next 01/17] igc: Refactor igc_ethtool_add_nfc_rule()

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes Current implementation of igc_ethtool_add_nfc_rule() is quite long and a bit convoluted so this patch does a code refactoring to improve the code. Code related to NFC rule object initialization is refactored out to the local helper function igc_ethtool_init_nfc_rule(). Likewis

[net-next 03/17] igc: Fix locking issue when retrieving NFC rules

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes Access to NFC rules stored in adapter->nfc_rule_list is protect by adapter->nfc_rule_lock. The functions igc_ethtool_get_nfc_rule() and igc_ethtool_get_nfc_rules() are missing to hold the lock while accessing rule objects. Signed-off-by: Andre Guedes Tested-by: Aaron Brown S

[net-next 09/17] igc: Fix NFC rule validation

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes If we try to overwrite an existing rule with the same filter but different action, we get EEXIST error as shown below. $ ethtool -N eth0 flow-type ether dst action 1 loc 10 $ ethtool -N eth0 flow-type ether dst action 2 loc 10 rmgr: Cannot insert RX class rule: File exists

[net-next 06/17] igc: Fix NFC rules restoration

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes When network interface is brought up, the driver re-enables the NFC rules previously configured. However, this is done in reverse order the rules were added and hardware filters are configured differently. For example, consider the following rules: $ ethtool -N eth0 flow-type

[net-next 02/17] igc: Fix 'sw_idx' type in struct igc_nfc_rule

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes The 'sw_idx' field from 'struct igc_nfc_rule' is u16 type but it is assigned an u32 value in igc_ethtool_init_nfc_rule(). This patch changes 'sw_idx' type to u32 so they match. Also, it makes more sense to call this field 'location' since it holds the NFC rule location. Signed

[net-next 15/17] e1000e: Warn if disabling ULP failed

2020-05-22 Thread Jeff Kirsher
From: Kai-Heng Feng The hardware may stop working if driver failed to disable ULP mode. Take the return value of e1000_disable_ulp_lpt_lp() into account, and pass up the error if it fails. Signed-off-by: Kai-Heng Feng Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethern

[net-next 13/17] igc: Remove unused descriptor's flags

2020-05-22 Thread Jeff Kirsher
From: Sasha Neftin Enable Tidv register, Report Packet Sent, Report Status and Ethernet CRC flags not in use. This patch comes to clean up these flags. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_defines.h | 4 1

[net-next 04/17] igc: Fix NFC rule overwrite cases

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes When the 'loc' argument is passed in ethtool, the input rule overwrites any rule present in that location. In this situation we must disable the old rule otherwise it is left enabled in hardware. This patch fixes the issue by always calling igc_disable_nfc_rule() when deleting

[net-next 07/17] igc: Refactor igc_ethtool_update_nfc_rule()

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes Current implementation of igc_ethtool_update_nfc_rule() is a bit convoluted since it handles too many things: rule lookup, deletion and addition. This patch breaks it into three functions so we simplify the code and improve code reuse. Code related to rule lookup is refactored

[net-next 00/17][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-22

2020-05-22 Thread Jeff Kirsher
This series contains updates to e1000e, igc and igb. Many of the patches in this series are fixes, but many of the igc fixes are based on the recent filter rule handling Andre has been working, which will not backport to earlier/stable kernels. The remaining fixes for e1000e and igb have CC'd sta

[net-next 16/17] e1000e: Disable TSO for buffer overrun workaround

2020-05-22 Thread Jeff Kirsher
From: Kai-Heng Feng Commit b10effb92e27 ("e1000e: fix buffer overrun while the I219 is processing DMA transactions") imposes roughly 30% performance penalty. The commit log states that "Disabling TSO eliminates performance loss for TCP traffic without a noticeable impact on CPU performance", so

[net-next 05/17] igc: Fix NFC rules with multicast addresses

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes Multicast MAC addresses are valid address for NFC rules but igc_add_mac_filter() is currently rejecting them. In fact, the I225 controller doesn't impose any constraint on the address value so this patch gets rid of the address validation check in MAC filter APIs. Signed-off-b

[net-next 14/17] igb: Report speed and duplex as unknown when device is runtime suspended

2020-05-22 Thread Jeff Kirsher
From: Kai-Heng Feng igb device gets runtime suspended when there's no link partner. We can't get correct speed under that state: $ cat /sys/class/net/enp3s0/speed 1000 In addition to that, an error can also be spotted in dmesg: [ 385.991957] igb :03:00.0 enp3s0: PCIe link lost Since device

[net-next 12/17] igc: Remove igc_nfc_rule_exit()

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes During igc_down(), we call igc_nfc_rule_exit() which traverse the NFC rule list disabling filters one by one. Later on in igc_down() flow we issue an hardware reset which also clear all filters. Since we already reset the hardware, we don't actually need to disable each filter

[net-next 11/17] igc: Change adapter->nfc_rule_lock to mutex

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes This patch changes adapter->nfc_rule_lock type from spin_lock to mutex so we avoid unnecessary busy waiting on lock contention. A closer look at the execution context of NFC rule API users shows that all of them run in process context. The API users are: ethtool ops, igc_confi

[net-next 10/17] igc: Change return type from igc_disable_nfc_rule()

2020-05-22 Thread Jeff Kirsher
From: Andre Guedes None of igc_disable_nfc_rule() callers actually check its returning value. A closer look at why this function would fail shows that the only situation is when we try to delete an Ethertype or MAC filter that doesn't exist. That situation is very unlikely so we can change igc_d

[net-next 17/17] e1000e: disable s0ix entry and exit flows for ME systems

2020-05-22 Thread Jeff Kirsher
From: Vitaly Lifshits Since ME systems do not support SLP_S0 in S0ix state, and S0ix entry and exit flows may cause errors on them it is best to avoid using e1000e_s0ix_entry_flow and e1000e_s0ix_exit_flow functions. This was done by creating a struct of all devices that comes with ME and by che

Re: [PATCH iproute2 v3 0/2] bpf: memory access fixes

2020-05-22 Thread Daniel Borkmann
On 5/18/20 3:00 PM, Jamal Hadi Salim wrote: ping? Note: these are trivial bug fixes. Looking at c0325b06382c ("bpf: replace snprintf with asprintf when dealing with long buffers"), I wonder whether it's best to just revert and redo cleanly from scratch.. How much testing has been performed o

Re: pull-request: bpf-next 2020-05-23

2020-05-22 Thread David Miller
From: Daniel Borkmann Date: Sat, 23 May 2020 02:26:08 +0200 > The following pull-request contains BPF updates for your *net-next* tree. Pulled, thanks Daniel.

[PATCH bpf-next] tools: bpftool: clean subcommand help messages

2020-05-22 Thread Quentin Monnet
This is a clean-up for the formatting of the do_help functions for bpftool's subcommands. The following fixes are included: - Do not use argv[-2] for "iter" help message, as the help is shown by default if no "iter" action is selected, resulting in messages looking like "./bpftool bpftool pin.

Re: KASAN: slab-out-of-bounds Read in ath9k_hif_usb_rx_cb

2020-05-22 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:806d8acc USB: dummy-hcd: use configurable endpoint naming .. git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=113b269a10 kernel config: https://syz

[PATCH bpf-next v2] tools: bpftool: make capability check account for new BPF caps

2020-05-22 Thread Quentin Monnet
Following the introduction of CAP_BPF, and the switch from CAP_SYS_ADMIN to other capabilities for various BPF features, update the capability checks (and potentially, drops) in bpftool for feature probes. Because bpftool and/or the system might not know of CAP_BPF yet, some caution is necessary:

Re: [PATCH v2 bpf-next 1/3] bpf: Consolidate inner-map-compatible properties into bpf_types.h

2020-05-22 Thread Martin KaFai Lau
On Sat, May 23, 2020 at 12:22:48AM +0200, Daniel Borkmann wrote: > On 5/22/20 4:23 AM, Martin KaFai Lau wrote: > [...] > > }; > > +/* Cannot be used as an inner map */ > > +#define BPF_MAP_NO_INNER_MAP (1 << 0) > > + > > struct bpf_map { > > /* The first two cachelines with read-mostly memb

Re: [PATCH net-next 1/5] net: hns3: add support for VF to query ring and vector mapping

2020-05-22 Thread tanhuazhong
On 2020/5/23 1:39, Jakub Kicinski wrote: On Fri, 22 May 2020 10:49:42 +0800 Huazhong Tan wrote: From: Guangbin Huang This patch adds support for VF to query the mapping of ring and vector. Signed-off-by: Guangbin Huang Signed-off-by: Huazhong Tan Hi, Jakub. Could you explain a lit

[net 06/13] net/mlx5e: Fix inner tirs handling

2020-05-22 Thread Saeed Mahameed
From: Roi Dayan In the cited commit inner_tirs argument was added to create and destroy inner tirs, and no indication was added to mlx5e_modify_tirs_hash() function. In order to have a consistent handling, use inner_indir_tir[0].tirn in tirs destroy/modify function as an indication to whether inn

[net 07/13] net/mlx5: Fix memory leak in mlx5_events_init

2020-05-22 Thread Saeed Mahameed
From: Moshe Shemesh Fix memory leak in mlx5_events_init(), in case create_single_thread_workqueue() fails, events struct should be freed. Fixes: 5d3c537f9070 ("net/mlx5: Handle event of power detection in the PCIE slot") Signed-off-by: Moshe Shemesh Reviewed-by: Tariq Toukan Signed-off-by: Sa

[net 04/13] net/mlx5e: Fix allowed tc redirect merged eswitch offload cases

2020-05-22 Thread Saeed Mahameed
From: Maor Dickman After changing the parent_id to be the same for both NICs of same The cited commit wrongly allow offload of tc redirect flows from VF to uplink and vice versa when devcies are on different eswitch, these cases aren't supported by HW. Disallow the above offloads when devcies ar

[net 12/13] net/mlx5e: CT: Correctly get flow rule

2020-05-22 Thread Saeed Mahameed
From: Roi Dayan The correct way is to us the flow_cls_offload_flow_rule() wrapper instead of f->rule directly. Fixes: 4c3844d9e97e ("net/mlx5e: CT: Introduce connection tracking") Signed-off-by: Roi Dayan Reviewed-by: Oz Shlomo Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/

[net 11/13] net/mlx5e: Update netdev txq on completions during closure

2020-05-22 Thread Saeed Mahameed
From: Moshe Shemesh On sq closure when we free its descriptors, we should also update netdev txq on completions which would not arrive. Otherwise if we reopen sqs and attach them back, for example on fw fatal recovery flow, we may get tx timeout. Fixes: 29429f3300a3 ("net/mlx5e: Timeout if SQ do

[net 10/13] net/mlx5: Annotate mutex destroy for root ns

2020-05-22 Thread Saeed Mahameed
From: Roi Dayan Invoke mutex_destroy() to catch any errors. Fixes: 2cc43b494a6c ("net/mlx5_core: Managing root flow table") Signed-off-by: Roi Dayan Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 6 ++ 1 file changed, 6 inser

[net 09/13] net/mlx5: Don't maintain a case of del_sw_func being null

2020-05-22 Thread Saeed Mahameed
From: Roi Dayan Add del_sw_func cb for root ns. Now there is no need to maintain a case of del_sw_func being null when freeing the node. Fixes: 2cc43b494a6c ("net/mlx5_core: Managing root flow table") Signed-off-by: Roi Dayan Reviewed-by: Mark Bloch Reviewed-by: Paul Blakey Signed-off-by: Sae

[net 13/13] net/mlx5: Fix error flow in case of function_setup failure

2020-05-22 Thread Saeed Mahameed
From: Shay Drory Currently, if an error occurred during mlx5_function_setup(), we keep dev->state as DEVICE_STATE_UP. Fixing it by adding a goto label. Fixes: e161105e58da ("net/mlx5: Function setup/teardown procedures") Signed-off-by: Shay Drory Reviewed-by: Moshe Shemesh Signed-off-by: Saeed

[net 08/13] net/mlx5: Fix cleaning unmanaged flow tables

2020-05-22 Thread Saeed Mahameed
From: Roi Dayan Unmanaged flow tables doesn't have a parent and tree_put_node() assume there is always a parent if cleaning is needed. fix that. Fixes: 5281a0c90919 ("net/mlx5: fs_core: Introduce unmanaged flow tables") Signed-off-by: Roi Dayan Reviewed-by: Mark Bloch Reviewed-by: Paul Blakey

[net 03/13] net/mlx5: Avoid processing commands before cmdif is ready

2020-05-22 Thread Saeed Mahameed
From: Eran Ben Elisha When driver is reloading during recovery flow, it can't get new commands till command interface is up again. Otherwise we may get to null pointer trying to access non initialized command structures. Add cmdif state to avoid processing commands while cmdif is not ready. Fix

[net 05/13] net/mlx5e: kTLS, Destroy key object after destroying the TIS

2020-05-22 Thread Saeed Mahameed
From: Tariq Toukan The TLS TIS object contains the dek/key ID. By destroying the key first, the TIS would contain an invalid non-existing key ID. Reverse the destroy order, this also acheives the desired assymetry between the destroy and the create flows. Fixes: d2ead1f360e8 ("net/mlx5e: Add kTL

[net 02/13] net/mlx5: Fix a race when moving command interface to events mode

2020-05-22 Thread Saeed Mahameed
From: Eran Ben Elisha After driver creates (via FW command) an EQ for commands, the driver will be informed on new commands completion by EQE. However, due to a race in driver's internal command mode metadata update, some new commands will still be miss-handled by driver as if we are in polling m

[net 01/13] net/mlx5: Add command entry handling completion

2020-05-22 Thread Saeed Mahameed
From: Moshe Shemesh When FW response to commands is very slow and all command entries in use are waiting for completion we can have a race where commands can get timeout before they get out of the queue and handled. Timeout completion on uninitialized command will cause releasing command's buffer

[pull request][net 00/13] mlx5 fixes 2020-05-22

2020-05-22 Thread Saeed Mahameed
Hi Dave, This series introduces some fixes to mlx5 driver. Please pull and let me know if there is any problem. For -stable v4.13 ('net/mlx5: Add command entry handling completion') For -stable v5.2 ('net/mlx5: Fix error flow in case of function_setup failure') ('net/mlx5: Fix memory l

Re: [PATCH] xfrm: Fix double ESP trailer insertion in IPsec crypto offload

2020-05-22 Thread Saeed Mahameed
On Thu, 2020-05-21 at 16:49 -0500, Huy Nguyen wrote: > During IPsec performance testing, we see bad ICMP checksum. The issue > is that > the error packet that has duplicated ESP trailer. For example, this > below ping reply skb is > collected at mlx5e_xmit. This ping reply skb length is 154 because

Re: [PATCH net] tipc: block BH before using dst_cache

2020-05-22 Thread Tetsuo Handa
On Fri, May 22, 2020 at 2:30 AM Eric Dumazet wrote: > dst_cache_get() documents it must be used with BH disabled. Since the report was complaining about preemption at this_cpu_ptr(), and "#syz test" request with my preemption-disable patch no longer complained, I didn't realize that it is docum

pull-request: bpf-next 2020-05-23

2020-05-22 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. We've added 50 non-merge commits during the last 8 day(s) which contain a total of 109 files changed, 2776 insertions(+), 2887 deletions(-). The main changes are: 1) Add a new AF_XDP buffer allocation API to the

Re: [pull request][net-next 00/10] mlx5 updates 2020-05-22

2020-05-22 Thread Saeed Mahameed
On Fri, 2020-05-22 at 16:51 -0700, Saeed Mahameed wrote: > Hi Dave/Jakub > > This series adds misc updates to mlx5 driver. > For more information please see tag log below. > > Please pull and let me know if there is any problem. > I forgot to mention that there is a slight touch out side mlx5 i

[net-next 02/10] net/mlx5e: Extract TC-specific code from en_rep.c to rep/tc.c

2020-05-22 Thread Saeed Mahameed
From: Vlad Buslov As a preparation for introducing new kconfig option that controls compilation of all TC offloads code in mlx5, extract TC-specific code from en_rep.c to standalone file. This allows easily compiling out the code by only including new source in make file when corresponding kconfi

[net-next 10/10] net/mlx5e: Support pedit on mpls over UDP decap

2020-05-22 Thread Saeed Mahameed
From: Eli Cohen Allow to modify ethernet headers while decapsulating mpls over UDP packets. This is implemented using the same reformat object used for decapsulation. Signed-off-by: Eli Cohen Reviewed-by: Roi Dayan Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- .../net/ethernet/

[net-next 09/10] net/mlx5e: Add support for hw decapsulation of MPLS over UDP

2020-05-22 Thread Saeed Mahameed
From: Eli Cohen MPLS over UDP is supported in hardware by using a packet reformat object with reformat type equal L3_TUNNEL_TO_L2 which both decapsulates the outer L3, L4 and MPLS headers, and allows for setting the L2 headers of the resulting decapsulated packet. For the hardware to operate corr

[net-next 03/10] net/mlx5e: Extract neigh-specific code from en_rep.c to rep/neigh.c

2020-05-22 Thread Saeed Mahameed
From: Vlad Buslov As a preparation for introducing new kconfig option that controls compilation of all TC offloads code in mlx5, extract neigh-specific code from en_rep.c to standalone file. This allows easily compiling out the code by only including new source in make file when corresponding kco

[net-next 04/10] net/mlx5e: Move TC-specific code from en_main.c to en_tc.c

2020-05-22 Thread Saeed Mahameed
From: Vlad Buslov As a preparation for introducing new kconfig option that controls compilation of all TC offloads code in mlx5, extract TC-specific code from en_main.c to en_tc.c. This allows easily compiling out the code by only including new source in make file when corresponding kconfig is en

[net-next 05/10] net/mlx5e: Introduce kconfig var for TC support

2020-05-22 Thread Saeed Mahameed
From: Vlad Buslov In order to improve code maintainability and readability, introduce new CONFIG_MLX5_CLS_ACT kconfig variable to control compilation of TC hardware offloads implementation. This allows distinguishing between features that require TC support (MPLSoUDP, etc.) and features that just

[net-next 08/10] net/mlx5e: Allow to match on mpls parameters

2020-05-22 Thread Saeed Mahameed
From: Eli Cohen Support matching on MPLS over UDP parameters using misc2 section of match parameters. Signed-off-by: Eli Cohen Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en/tc_tun_mplsoudp.c | 49 +++ .../net/ethernet/mellanox/mlx5/core/

[net-next 07/10] net/mlx5e: Add support for hw encapsulation of MPLS over UDP

2020-05-22 Thread Saeed Mahameed
From: Eli Cohen MPLS over UDP is supported by adding a rule on a representor net device which does tunnel_key set, push mpls and forward to a baredup device. At the hardware level we use a packet_reformat_context object to do the encapsulation of the packet. The resulting packet looks as follows

[net-next 06/10] net: Add netif_is_bareudp() API to identify bareudp devices

2020-05-22 Thread Saeed Mahameed
From: Eli Cohen Add netif_is_bareudp() so the device can be identified as a bareudp one. Signed-off-by: Eli Cohen Reviewed-by: Roi Dayan Reviewed-by: Eli Britstein Reviewed-by: Paul Blakey Signed-off-by: Saeed Mahameed --- include/net/bareudp.h | 7 +++ 1 file changed, 7 insertions(+)

[net-next 01/10] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-22 Thread Saeed Mahameed
From: Tang Bin Use IS_ERR() and PTR_ERR() instead of PTR_ERR_OR_ZERO() to simplify code, avoid redundant judgements. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 5 ++

[pull request][net-next 00/10] mlx5 updates 2020-05-22

2020-05-22 Thread Saeed Mahameed
Hi Dave/Jakub This series adds misc updates to mlx5 driver. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit 593532668f635d19d207510e0fbb5c2250f56b6f: Revert "net: mvneta: speed down the

Re: [EXT] Re: [PATCH net 3/4] ARM: dts: imx6: update fec gpr property to match new format

2020-05-22 Thread Andrew Lunn
> Yes, I don't think anyone is saying otherwise. Correct. > > The problem is just that there are already .dtsi files for i.MX chips > having multiple ethernet interfaces > in the mainline kernel (at least imx6ui.dtsi, imx6sx.dts, imx7d.dtsi) Vybrid is one i use a lot with two FECs. > but that

Re: [RFC 1/2] devlink: add simple fw crash helpers

2020-05-22 Thread Luis Chamberlain
On Fri, May 22, 2020 at 04:23:55PM -0700, Steve deRosier wrote: > Specifically, I don't think we should set a taint flag when a driver > easily handles a routine firmware crash and is confident that things > have come up just fine again. In other words, triggering the taint in > every driver module

Re: [PATCH net 0/2] rxrpc: Fix a warning and a leak [ver #2]

2020-05-22 Thread David Miller
From: David Howells Date: Sat, 23 May 2020 00:42:32 +0100 > > Here are a couple of fixes for AF_RXRPC: > > (1) Fix an uninitialised variable warning. > > (2) Fix a leak of the ticket on error in rxkad. > > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git

[PATCH net 2/2] rxrpc: Fix a memory leak in rxkad_verify_response() [ver #2]

2020-05-22 Thread David Howells
From: Qiushi Wu A ticket was not released after a call of the function "rxkad_decrypt_ticket" failed. Thus replace the jump target "temporary_error_free_resp" by "temporary_error_free_ticket". Fixes: 8c2f826dc3631 ("rxrpc: Don't put crypto buffers on the stack") Signed-off-by: Qiushi Wu Signed-

[PATCH net 1/2] rxrpc: Fix a warning [ver #2]

2020-05-22 Thread David Howells
Fix a warning due to an uninitialised variable. le included from ../fs/afs/fs_probe.c:11: ../fs/afs/fs_probe.c: In function 'afs_fileserver_probe_result': ../fs/afs/internal.h:1453:2: warning: 'rtt_us' may be used uninitialized in this function [-Wmaybe-uninitialized] 1453 | printk("[%-6.6s] "F

[PATCH net 0/2] rxrpc: Fix a warning and a leak [ver #2]

2020-05-22 Thread David Howells
Here are a couple of fixes for AF_RXRPC: (1) Fix an uninitialised variable warning. (2) Fix a leak of the ticket on error in rxkad. The patches are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20200523-v2 and can also be found

Re: [PATCH bpf 0/2] selftests/bpf: add missing CONFIG values to test config

2020-05-22 Thread Daniel Borkmann
On 5/22/20 1:36 PM, Alan Maguire wrote: Selftests "config" file is intended to represent the config required to run the tests; a few values are missing for the BPF selftests and these can result in test failures due to missing helpers etc. Add the missing values as they will help document the con

Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-22 Thread Andrew Lunn
On Fri, May 22, 2020 at 05:06:34PM +0200, Matthias Brugger wrote: > > > On 22/05/2020 14:06, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > This adds the driver for the MediaTek STAR Ethernet MAC currently used > > on the MT8* SoC family. For now we only support full-duplex. >

Re: [PATCH] selftests/bpf: add general instructions for test execution

2020-05-22 Thread Daniel Borkmann
On 5/22/20 1:24 PM, Alan Maguire wrote: Getting a clean BPF selftests run involves ensuring latest trunk LLVM/clang are used, pahole is recent (>=1.16) and config matches the specified config file as closely as possible. Add to bpf_devel_QA.rst and point tools/testing/selftests/bpf/README.rst to

Re: [bpf-next PATCH v2] bpf: Add rx_queue_mapping to bpf_sock

2020-05-22 Thread Daniel Borkmann
On 5/22/20 8:28 PM, Amritha Nambiar wrote: Add "rx_queue_mapping" to bpf_sock. This gives read access for the existing field (sk_rx_queue_mapping) of struct sock from bpf_sock. Semantics for the bpf_sock rx_queue_mapping access are similar to sk_rx_queue_get(), i.e the value NO_QUEUE_MAPPING is n

Re: [PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard

2020-05-22 Thread David Miller
From: David Howells Date: Sat, 23 May 2020 00:26:46 +0100 > David Miller wrote: > >> Pulled, thanks David. > > Thanks. I'll rebase my two extra patches I've just sent you a pull request > for when you've updated the branch. Please respin and fix the Subject line of patch #2 to have a correct

Re: [PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard

2020-05-22 Thread David Howells
David Miller wrote: > Pulled, thanks David. Thanks. I'll rebase my two extra patches I've just sent you a pull request for when you've updated the branch. David

Re: [PATCH net 0/3] rxrpc: Fix retransmission timeout and ACK discard [ver #2]

2020-05-22 Thread David Howells
David Howells wrote: > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-fixes-20200520 Oops. That's the wrong tag. It should be rxrpc-fixes-20200521. David

Re: [RFC 1/2] devlink: add simple fw crash helpers

2020-05-22 Thread Steve deRosier
On Fri, May 22, 2020 at 2:51 PM Luis Chamberlain wrote: > > On Fri, May 22, 2020 at 10:46:07PM +0200, Johannes Berg wrote: > > FWIW, I still completely disagree on that taint. You (Luis) obviously > > have been running into a bug in that driver, I doubt the firmware > > actually managed to wedge t

[PATCH net 0/2] rxrpc: Fix a warning and a leak

2020-05-22 Thread David Howells
Here are a couple of fixes for AF_RXRPC: (1) Fix an uninitialised variable warning. (2) Fix a leak of the ticket on error in rxkad. The patches are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20200523 and can also be found on

[PATCH net 1/2] rxrpc: Fix a warning

2020-05-22 Thread David Howells
Fix a warning due to an uninitialised variable. le included from ../fs/afs/fs_probe.c:11: ../fs/afs/fs_probe.c: In function 'afs_fileserver_probe_result': ../fs/afs/internal.h:1453:2: warning: 'rtt_us' may be used uninitialized in this function [-Wmaybe-uninitialized] 1453 | printk("[%-6.6s] "F

[PATCH net 2/2] A ticket was not released after a call of the function

2020-05-22 Thread David Howells
From: Qiushi Wu "rxkad_decrypt_ticket" failed. Thus replace the jump target "temporary_error_free_resp" by "temporary_error_free_ticket". Fixes: 8c2f826dc3631 ("rxrpc: Don't put crypto buffers on the stack") Signed-off-by: Qiushi Wu Signed-off-by: David Howells cc: Markus Elfring --- net/rx

Re: [PATCH] net: sun: fix missing release regions in cas_init_one().

2020-05-22 Thread David Miller
From: wu000...@umn.edu Date: Fri, 22 May 2020 16:50:27 -0500 > From: Qiushi Wu > > In cas_init_one(), "pdev" is requested by "pci_request_regions", but it > was not released after a call of the function “pci_write_config_byte” > failed. Thus replace the jump target “err_write_cacheline” by > "

Re: [PATCH v2 0/3] bridge: mrp: Add br_mrp_unique_ifindex function

2020-05-22 Thread David Miller
From: Horatiu Vultur Date: Thu, 21 May 2020 23:19:04 + > This patch series adds small fixes to MRP implementation. > The following are fixed in this patch series: > - now is not allow to add the same port to multiple MRP rings > - remove unused variable > - restore the port state according to

Re: [PATCH net] net: mscc: ocelot: fix address ageing time (again)

2020-05-22 Thread David Miller
From: Vladimir Oltean Date: Fri, 22 May 2020 00:31:23 +0300 > From: Vladimir Oltean > > ocelot_set_ageing_time has 2 callers: > - felix_set_ageing_time: from drivers/net/dsa/ocelot/felix.c > - ocelot_port_attr_ageing_set: from drivers/net/ethernet/mscc/ocelot.c > > The issue described in the

  1   2   3   4   >