Re: [PATCH net v2] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed

2020-05-07 Thread Marek Szyprowski
Hi Florian, On 07.05.2020 17:54, Florian Fainelli wrote: > On 5/7/2020 3:03 AM, Marek Szyprowski wrote: >> On 07.05.2020 11:46, Marek Szyprowski wrote: >>> On 25.02.2020 14:11, Nicolas Saenz Julienne wrote: Outdated Raspberry Pi 4 firmware might configure the external PHY as rgmii althou

[PATCH net] r8169: re-establish support for RTL8401 chip version

2020-05-07 Thread Heiner Kallweit
r8169 never had native support for the RTL8401, however it reportedly worked with the fallback to RTL8101e [0]. Therefore let's add this as an explicit assignment. [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956868 Fixes: b4cc2dcc9c7c ("r8169: remove default chip versions") Reported-by:

Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks

2020-05-07 Thread Johan Hovold
On Fri, May 08, 2020 at 03:35:02AM +0530, Naresh Kamboju wrote: > On Thu, 7 May 2020 at 16:43, Greg Kroah-Hartman > wrote: > > > > > > > > > > > Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link > > > > PHYs") needs to be backported as well for these. > > > > > > > > Original seri

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-07 Thread Heiner Kallweit
On 08.05.2020 00:56, Jakub Kicinski wrote: > On Thu, 7 May 2020 19:03:44 +0200 Bartosz Golaszewski wrote: >>> To implement Edwin's suggestion? Makes sense, but I'm no expert, let's >>> also CC Heiner since he was asking about it last time. >> >> Yes, because taking the last bit of priv_flags from

Re: [PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-07 Thread Kevin Hao
On Fri, May 08, 2020 at 10:18:27AM +0530, Sunil Kovvuri wrote: > On Fri, May 8, 2020 at 9:43 AM Kevin Hao wrote: > > > > In the current codes, the octeontx2 uses its own method to allocate > > the pool buffers, but there are some issues in this implementation. > > 1. We have to run the otx2_get_pa

linux-next 20200506 - build failure with net/bpfilter/bpfilter_umh

2020-05-07 Thread Valdis Klētnieks
My kernel build came to a screeching halt with: CHECK net/bpfilter/bpfilter_kern.c CC [M] net/bpfilter/bpfilter_kern.o CC [U] net/bpfilter/main.o LD [U] net/bpfilter/bpfilter_umh /usr/bin/ld: cannot find -lc collect2: error: ld returned 1 exit status make[2]: *** [scripts/Makefile.use

Re: [PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-07 Thread Sunil Kovvuri
On Fri, May 8, 2020 at 9:43 AM Kevin Hao wrote: > > In the current codes, the octeontx2 uses its own method to allocate > the pool buffers, but there are some issues in this implementation. > 1. We have to run the otx2_get_page() for each allocation cycle and >this is pretty error prone. As I

[PATCH] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-07 Thread Kevin Hao
In the current codes, the octeontx2 uses its own method to allocate the pool buffers, but there are some issues in this implementation. 1. We have to run the otx2_get_page() for each allocation cycle and this is pretty error prone. As I can see there is no invocation of the otx2_get_page() in

Re: [PATCH v3 net-next 4/4] net: dsa: sja1105: implement cross-chip bridging operations

2020-05-07 Thread Florian Fainelli
On 5/3/2020 3:12 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > sja1105 uses dsa_8021q for DSA tagging, a format which is VLAN at heart > and which is compatible with cascading. A complete description of this > tagging format is in net/dsa/tag_8021q.c, but a quick summary is that > eac

[PATCH net-next] ieee802154: 6lowpan: remove unnecessary comparison

2020-05-07 Thread Yang Yingliang
The type of dispatch is u8 which is always '<=' 0xff, so the dispatch <= 0xff is always true, we can remove this comparison. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- net/ieee802154/6lowpan/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/6

linux-next: manual merge of the net-next tree with the rdma tree

2020-05-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/bonding/bond_main.c between commits: ed7d4f023b1a ("bonding: Rename slave_arr to usable_slaves") c071d91d2a89 ("bonding: Add helper function to get the xmit slave based on hash") 29d5bbccb3a1 ("bonding

Re: [PATCH v3 net-next 2/4] net: dsa: permit cross-chip bridging between all trees in the system

2020-05-07 Thread Florian Fainelli
On 5/3/2020 3:12 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > One way of utilizing DSA is by cascading switches which do not all have > compatible taggers. Consider the following real-life topology: > > +---+ >

Re: [PATCH v3 net-next 3/4] net: dsa: introduce a dsa_switch_find function

2020-05-07 Thread Florian Fainelli
On 5/3/2020 3:12 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Somewhat similar to dsa_tree_find, dsa_switch_find returns a dsa_switch > structure pointer by searching for its tree index and switch index (the > parameters from dsa,member). To be used, for example, by drivers who > imp

Re: [PATCH v3 net-next 1/4] net: bridge: allow enslaving some DSA master network devices

2020-05-07 Thread Florian Fainelli
On 5/3/2020 3:12 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Commit 8db0a2ee2c63 ("net: bridge: reject DSA-enabled master netdevices > as bridge members") added a special check in br_if.c in order to check > for a DSA master network device with a tagging protocol configured. This >

[PATCH net-next] octeontx2-vf: Fix error return code in otx2vf_probe()

2020-05-07 Thread Wei Yongjun
Fix to return negative error code -ENOMEM from the alloc failed error handling case instead of 0, as done elsewhere in this function. Fixes: 3184fb5ba96e ("octeontx2-vf: Virtual function driver support") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/net/ethernet/marvell/octeont

[PATCH net-next] net: ethernet: ti: fix error return code in am65_cpsw_nuss_probe()

2020-05-07 Thread Wei Yongjun
Fix to return negative error code -ENOMEM from the cpsw_ale_create() error handling case instead of 0, as done elsewhere in this function. Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- driver

Re: [PATCH net-next v2 21/33] virtio_net: add XDP frame size in two code paths

2020-05-07 Thread Jason Wang
On 2020/5/7 上午4:34, Michael S. Tsirkin wrote: On Thu, Apr 30, 2020 at 01:22:08PM +0200, Jesper Dangaard Brouer wrote: The virtio_net driver is running inside the guest-OS. There are two XDP receive code-paths in virtio_net, namely receive_small() and receive_mergeable(). The receive_big() func

[PATCH net v1] hinic: fix a bug of ndo_stop

2020-05-07 Thread Luo bin
if some function in ndo_stop interface returns failure because of hardware fault, must go on excuting rest steps rather than return failure directly, otherwise will cause memory leak Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_hw_mgmt.c | 28 ++- .../net/ethern

[PATCH net-next v1] hinic: add three net_device_ops of vf

2020-05-07 Thread Luo bin
adds ndo_set_vf_rate/ndo_set_vf_spoofchk/ndo_set_vf_link_state to configure netdev of virtual function Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 31 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 35 ++- .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 21 +

Re: [PATCH net-next 1/2] virtio-net: don't reserve space for vnet header for XDP

2020-05-07 Thread Jason Wang
On 2020/5/6 下午5:46, Michael S. Tsirkin wrote: There are a lot of unanswered questions on how this will be implemented. Thus, I cannot layout how we are going to leverage this info yet, but your patch are killing this info, which IHMO is going in the wrong direction. I can copy vnet header ahea

Re: [PATCH] net: atarilance: Replace zero-length array with flexible-array

2020-05-07 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 7 May 2020 14:01:33 -0500 > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in

Re: [PATCH net-next 1/2] virtio-net: don't reserve space for vnet header for XDP

2020-05-07 Thread Jason Wang
On 2020/5/6 下午5:54, Michael S. Tsirkin wrote: On Wed, May 06, 2020 at 04:19:40PM +0800, Jason Wang wrote: On 2020/5/6 下午3:53, Michael S. Tsirkin wrote: On Wed, May 06, 2020 at 02:16:32PM +0800, Jason Wang wrote: We tried to reserve space for vnet header before xdp.data_hard_start. But this i

Re: [PATCH] ipv6: Replace zero-length array with flexible-array

2020-05-07 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 7 May 2020 14:02:16 -0500 > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in

Re: [PATCH] team: Replace zero-length array with flexible-array

2020-05-07 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 7 May 2020 14:25:07 -0500 > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in

Re: [PATCH net-next 2/2] virtio-net: fix the XDP truesize calculation for mergeable buffers

2020-05-07 Thread Jason Wang
On 2020/5/6 下午8:08, Michael S. Tsirkin wrote: On Wed, May 06, 2020 at 04:21:15PM +0800, Jason Wang wrote: On 2020/5/6 下午3:37, Michael S. Tsirkin wrote: On Wed, May 06, 2020 at 02:16:33PM +0800, Jason Wang wrote: We should not exclude headroom and tailroom when XDP is set. So this patch fixes

Re: [PATCH net 0/2] net: ipa: fix cleanup after modem crash

2020-05-07 Thread David Miller
From: Alex Elder Date: Thu, 7 May 2020 14:14:02 -0500 > The first patch in this series fixes a bug where the size of a data > transfer request was never set, meaning it was 0. The consequence > of this was that such a transfer request would never complete if > attempted, and led to a hung task

[PATCH 2/2] sunrpc: add missing newline when printing parameter 'auth_hashtable_size' by sysfs

2020-05-07 Thread Xiongfeng Wang
When I cat parameter '/sys/module/sunrpc/parameters/auth_hashtable_size', it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/auth_hashtable_size 16[root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- net/sunrpc/auth.c | 2

[PATCH 0/2] sunrpc: add missing newline when printing module parameters by sysfs

2020-05-07 Thread Xiongfeng Wang
When I cat parameters below ''/sys/module/sunrpc/parameters/', I found the following two parameter need a new line. [root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/pool_mode global[root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/auth_hashtable_size 16[root@hulk-202 ~]# Xiongfeng Wang (2

[PATCH 1/2] sunrpc: add missing newline when printing parameter 'pool_mode' by sysfs

2020-05-07 Thread Xiongfeng Wang
When I cat parameter '/sys/module/sunrpc/parameters/pool_mode', it displays as follows. It is better to add a newline for easy reading. [root@hulk-202 ~]# cat /sys/module/sunrpc/parameters/pool_mode global[root@hulk-202 ~]# Signed-off-by: Xiongfeng Wang --- net/sunrpc/svc.c | 10 +- 1 f

[PATCH -next] brcmfmac: make non-global functions static

2020-05-07 Thread Chen Zhou
Fix sparse warning: drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2206:5: warning: symbol 'brcmf_p2p_get_conn_idx' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Chen Zhou --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +- 1 file

Re: [PATCH net] hinic: fix a bug of ndo_stop

2020-05-07 Thread luobin (L)
All right,will fix. On 2020/5/8 9:00, David Miller wrote: From: Luo bin Date: Thu, 7 May 2020 04:32:22 + + ulong timeo; Please fully spell out "unsigned long" for this type. The same problem exists in your net-next patch submission as well. Thank you. .

Re: [Patch net v3] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-07 Thread David Miller
From: Cong Wang Date: Thu, 7 May 2020 12:19:03 -0700 > syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event > between bonding master and slave. I managed to find a reproducer > for this: > > ip li set bond0 up > ifenslave bond0 eth0 > brctl addbr br0 > ethtool -K eth0 lro off

[PATCH v2] net: tcp: fixes commit 98aaa913b4ed ("tcp: Extend SOF_TIMESTAMPING_RX_SOFTWARE to TCP recvmsg")

2020-05-07 Thread Kelly Littlepage
The stated intent of the original commit is to is to "return the timestamp corresponding to the highest sequence number data returned." The current implementation returns the timestamp for the last byte of the last fully read skb, which is not necessarily the last byte in the recv buffer. This patc

Re: [PATCH net-next] net: relax SO_TXTIME CAP_NET_ADMIN check

2020-05-07 Thread David Miller
From: Eric Dumazet Date: Thu, 7 May 2020 10:05:39 -0700 > Now sch_fq has horizon feature, we want to allow QUIC/UDP applications > to use EDT model so that pacing can be offloaded to the kernel (sch_fq) > or the NIC. > > Signed-off-by: Eric Dumazet > Cc: Willem de Bruijn Applied, thanks Eric

Re: [PATCH net] mptcp: set correct vfs info for subflows

2020-05-07 Thread David Miller
From: Paolo Abeni Date: Thu, 7 May 2020 18:53:24 +0200 > When a subflow is created via mptcp_subflow_create_socket(), > a new 'struct socket' is allocated, with a new i_ino value. > > When inspecting TCP sockets via the procfs and or the diag > interface, the above ones are not related to the p

Re: [PATCH net-next 0/5] bonding: report transmit status to callers

2020-05-07 Thread David Miller
From: Eric Dumazet Date: Thu, 7 May 2020 09:32:17 -0700 > First patches cleanup netpoll, and make sure it provides tx status to its > users. > > Last patch changes bonding to not pretend packets were sent without error. > > By providing more accurate status, TCP stack can avoid adding more >

Re: [PATCH] net: microchip: encx24j600: add missed kthread_stop

2020-05-07 Thread David Miller
From: Chuhong Yuan Date: Thu, 7 May 2020 23:13:20 +0800 > This driver calls kthread_run() in probe, but forgets to call > kthread_stop() in probe failure and remove. > Add the missed kthread_stop() to fix it. > > Signed-off-by: Chuhong Yuan Applied, thanks.

Re: [PATCH][next] net: phy: fix less than zero comparison with unsigned variable val

2020-05-07 Thread David Miller
From: Colin King Date: Thu, 7 May 2020 15:34:30 +0100 > From: Colin Ian King > > The unsigned variable val is being checked for an error by checking > if it is less than zero. This can never occur because val is unsigned. > Fix this by making val a plain int. > > Addresses-Coverity: ("Unsigne

Re: [PATCH net-next] net/smc: remove set but not used variables 'del_llc, del_llc_resp'

2020-05-07 Thread David Miller
From: Karsten Graul Date: Thu, 7 May 2020 16:24:06 +0200 > From: YueHaibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > net/smc/smc_llc.c: In function 'smc_llc_cli_conf_link': > net/smc/smc_llc.c:753:31: warning: > variable 'del_llc' set but not used [-Wunused-but-set-variable] >

Re: [PATCH net] hinic: fix a bug of ndo_stop

2020-05-07 Thread David Miller
From: Luo bin Date: Thu, 7 May 2020 04:32:22 + > + ulong timeo; Please fully spell out "unsigned long" for this type. The same problem exists in your net-next patch submission as well. Thank you.

Re: [PATCH] tcp: tcp_mark_head_lost is only valid for sack-tcp

2020-05-07 Thread David Miller
From: zhang kai Date: Thu, 7 May 2020 11:08:30 +0800 > so tcp_is_sack/reno checks are removed from tcp_mark_head_lost. > > Signed-off-by: zhang kai Applied to net-next, thanks.

Re: [PATCH net-next] net: remove newlines in NL_SET_ERR_MSG_MOD

2020-05-07 Thread David Miller
From: Jacob Keller Date: Wed, 6 May 2020 17:58:27 -0700 > The NL_SET_ERR_MSG_MOD macro is used to report a string describing an > error message to userspace via the netlink extended ACK structure. It > should not have a trailing newline. > > Add a cocci script which catches cases where the newl

Re: [PATCH net-next 0/3] net: ethernet: ti: am65x-cpts: follow up dt bindings update

2020-05-07 Thread David Miller
From: Grygorii Strashko Date: Wed, 6 May 2020 21:13:58 +0300 > This series is follow update for TI A65x/J721E Common platform time sync > (CPTS) > driver [1] to implement DT bindings review comments from > Rob Herring [2]. > - "reg" and "compatible" properties are made required for CPTS DT n

Re: [PATCH net/master] net: ethernet: ti: cpts: Fix linker issue when TI_CPTS is defined

2020-05-07 Thread Dan Murphy
All On 5/7/20 4:47 PM, Dan Murphy wrote: Fix build issue when CONFIG_TI_CPTS is defined in the defconfig but CONFIG_TI_CPTS_MOD is not set. I see this already has a pending patch to fix this so unless this solution is better I will drop the patch https://lore.kernel.org/patchwork/patch/1235

Re: [PATCH net-next 0/2] hsr: hsr code refactoring

2020-05-07 Thread David Miller
From: Taehee Yoo Date: Wed, 6 May 2020 15:46:34 + > There are some unnecessary routine in the hsr module. > This patch removes these routines. > > The first patch removes incorrect comment. > The second patch removes unnecessary WARN_ONCE() macro. Series applied, thanks.

Re: [PATCH net-next] enetc: Fix use after free in stream_filter_unref()

2020-05-07 Thread David Miller
From: Dan Carpenter Date: Tue, 5 May 2020 23:47:21 +0300 > This code frees "sfi" and then dereferences it on the next line. > > Fixes: 888ae5a3952b ("net: enetc: add tc flower psfp offload driver") > Signed-off-by: Dan Carpenter This was fixed in another patch by using the local variable 'inde

Re: [PATCH net] soc: fsl: dpio: properly compute the consumer index

2020-05-07 Thread David Miller
From: Ioana Ciornei Date: Tue, 5 May 2020 23:14:29 +0300 > Mask the consumer index before using it. Without this, we would be > writing frame descriptors beyond the ring size supported by the QBMAN > block. > > Fixes: 3b2abda7d28c ("soc: fsl: dpio: Replace QMAN array mode with ring mode > enqu

Re: [PATCH] Revert "ipv6: add mtu lock check in __ip6_rt_update_pmtu"

2020-05-07 Thread Maciej Żenczykowski
> I've thought about this some more and decided to apply this and > queue it up for -stable, thank you. Thank you!

Re: [PATCH v3 net-next 0/6] tc-gate offload for SJA1105 DSA switch

2020-05-07 Thread David Miller
From: Vladimir Oltean Date: Tue, 5 May 2020 22:20:51 +0300 > From: Vladimir Oltean > > Expose the TTEthernet hardware features of the switch using standard > tc-flower actions: trap, drop, redirect and gate. > > v1 was submitted at: > https://patchwork.ozlabs.org/project/netdev/cover/20200503

Re: [PATCH] Revert "ipv6: add mtu lock check in __ip6_rt_update_pmtu"

2020-05-07 Thread David Miller
From: Maciej Żenczykowski Date: Tue, 5 May 2020 11:57:23 -0700 > From: Maciej Żenczykowski > > This reverts commit 19bda36c4299ce3d7e5bce10bebe01764a655a6d: > > | ipv6: add mtu lock check in __ip6_rt_update_pmtu > | > | Prior to this patch, ipv6 didn't do mtu lock check in ip6_update_pmtu. >

Re: [PATCH] net: bareudp: avoid uninitialized variable warning

2020-05-07 Thread David Miller
From: Arnd Bergmann Date: Tue, 5 May 2020 19:22:14 +0200 > clang points out that building without IPv6 would lead to returning > an uninitialized variable if a packet with family!=AF_INET is > passed into bareudp_udp_encap_recv(): > > drivers/net/bareudp.c:139:6: error: variable 'err' is used u

Re: linux-next boot error: WARNING: suspicious RCU usage in ip6mr_get_table

2020-05-07 Thread Stephen Rothwell
, May 7, 2020 at 11:26 AM syzbot > > > wrote: > > >> > > >> ===== > > >> WARNING: suspicious RCU usage > > >> 5.7.0-rc4-next-20200507-syzkaller #0 Not tainted > > >> - > > >> security/integ

Re: [RFC PATCH net] net: flow_offload: simplify hw stats check handling

2020-05-07 Thread Jakub Kicinski
On Thu, 7 May 2020 18:46:43 +0200 Pablo Neira Ayuso wrote: > On Thu, May 07, 2020 at 04:49:15PM +0100, Edward Cree wrote: > > On 07/05/2020 16:32, Pablo Neira Ayuso wrote: > > > On Thu, May 07, 2020 at 03:59:09PM +0100, Edward Cree wrote: > > >> Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits,

Re: XDP bpf_tail_call_redirect(): yea or nay?

2020-05-07 Thread Alexei Starovoitov
On Thu, May 7, 2020 at 11:09 AM John Fastabend wrote: > > I think it would work but I it would be even nicer if clang, verifier > and jit caught the tail call pattern and did it automatically. I've been advocating for proper tail calls for some time :) All it needs is indirect jump instruction in

Re: linux-next boot error: WARNING: suspicious RCU usage in ip6mr_get_table

2020-05-07 Thread Madhuparna Bhowmik
owing crash on: > >> > >> HEAD commit:6b43f715 Add linux-next specific files for 20200507 > >> git tree: linux-next > >> console output: https://syzkaller.appspot.com/x/log.txt?x=16f6437010 > >> kernel config: https://syzkal

Re: [PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-07 Thread Jakub Kicinski
On Thu, 7 May 2020 19:03:44 +0200 Bartosz Golaszewski wrote: >> To implement Edwin's suggestion? Makes sense, but I'm no expert, let's >> also CC Heiner since he was asking about it last time. > > Yes, because taking the last bit of priv_flags from net_device seems > to be more controversial but

Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-07 Thread Jakub Kicinski
On Wed, May 06, 2020 at 12:23:29PM -0700, Jakub Kicinski wrote: > Please trim your replies. > > Off-topic. > > Is there any simple way to trim replies semi-automatically in VIM? > > Right now, I'm doing it manually, but maybe there is some better > way to do it. I'm also doing it manually :(

Re: [PATCH v3 net-next 0/4] Cross-chip bridging for disjoint DSA trees

2020-05-07 Thread Florian Fainelli
On 5/7/2020 3:15 PM, David Miller wrote: > From: Vladimir Oltean > Date: Thu, 7 May 2020 19:07:32 +0300 > >> What does it mean that this series is "deferred" in patchwork? > > I need it to be reviewed, nobody reviewed it for days so I just toss > it in the deferred state. > > I don't feel co

Re: XDP bpf_tail_call_redirect(): yea or nay?

2020-05-07 Thread Toke Høiland-Jørgensen
John Fastabend writes: > Toke Høiland-Jørgensen wrote: >> Björn Töpel writes: >> >> > On Thu, 7 May 2020 at 15:44, Toke Høiland-Jørgensen >> > wrote: >> >> >> >> Björn Töpel writes: >> >> >> >> > Before I start hacking on this, I might as well check with the XDP >> >> > folks if this conside

[PATCH] umh: fix memory leak on execve failure

2020-05-07 Thread Vincent Minet
If a UMH process created by fork_usermode_blob() fails to execute, a pair of struct file allocated by umh_pipe_setup() will leak. Under normal conditions, the caller (like bpfilter) needs to manage the lifetime of the UMH and its two pipes. But when fork_usermode_blob() fails, the caller doesn't r

Re: [PATCH v3 net-next 0/4] Cross-chip bridging for disjoint DSA trees

2020-05-07 Thread David Miller
From: Vladimir Oltean Date: Thu, 7 May 2020 19:07:32 +0300 > What does it mean that this series is "deferred" in patchwork? I need it to be reviewed, nobody reviewed it for days so I just toss it in the deferred state. I don't feel comfortable applying this without Andrew/Florian's review, but

Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks

2020-05-07 Thread Naresh Kamboju
On Thu, 7 May 2020 at 16:43, Greg Kroah-Hartman wrote: > > > > > > > Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link > > > PHYs") needs to be backported as well for these. > > > > > > Original series can be found here: > > > > > > > > > https://lkml.kernel.org/r/1480357509-

[PATCH net/master] net: ethernet: ti: cpts: Fix linker issue when TI_CPTS is defined

2020-05-07 Thread Dan Murphy
Fix build issue when CONFIG_TI_CPTS is defined in the defconfig but CONFIG_TI_CPTS_MOD is not set. arm-none-linux-gnueabihf-ld: drivers/net/ethernet/ti/cpsw.o: in function `cpsw_ndo_stop': drivers/net/ethernet/ti/cpsw.c:886: undefined reference to `cpts_unregister' arm-none-linux-gnueabihf-ld: dr

Re: [RFC PATCH bpf-next 1/3] arm64: insn: Fix two bugs in encoding 32-bit logical immediates

2020-05-07 Thread Luke Nelson
Hi everyone, Thanks for the comments! Responses below: > It's a bit grotty spreading the checks out now. How about we tweak things > slightly along the lines of: > > > diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c > index 4a9e773a177f..60ec788eaf33 100644 > --- a/arch/arm64/ker

Re: [RFC PATCH 0/7] Share events between metrics

2020-05-07 Thread Andi Kleen
> > - without this change events within a metric may get scheduled > > together, after they may appear as part of a larger group and be > > multiplexed at different times, lowering accuracy - however, less > > multiplexing may compensate for this. > > I agree the heuristic in this patch set

Re: [PATCH] net: tcp: fix rx timestamp behavior for tcp_recvmsg

2020-05-07 Thread Willem de Bruijn
On Tue, May 5, 2020 at 4:23 PM Willem de Bruijn wrote: > > On Mon, May 4, 2020 at 12:30 PM Kelly Littlepage wrote: > > > > Timestamping cmsgs are not returned when the user buffer supplied to > > recvmsg is too small to copy at least one skbuff in entirety. > > In general a tcp reader should not

Re: [PATCH v2] net: ethernet: ti: Remove TI_CPTS_MOD workaround

2020-05-07 Thread Arnd Bergmann
On Wed, May 6, 2020 at 10:57 PM Grygorii Strashko wrote: > On 06/05/2020 09:51, Clay McClure wrote: > > On Tue, May 05, 2020 at 10:41:26AM +0300, Grygorii Strashko wrote: > > > > Ok. After some thinking and hence you commit b6d49cab44b5 ("net: Make > PTP-specific drivers depend on PTP_1588_CLOCK

Re: [PATCH AUTOSEL 5.4 26/35] SUNRPC: defer slow parts of rpc_free_client() to a workqueue.

2020-05-07 Thread NeilBrown
On Thu, May 07 2020, Sasha Levin wrote: > From: NeilBrown > > [ Upstream commit 7c4310ff56422ea43418305d22bbc5fe19150ec4 ] This one is buggy - it introduces a use-after-free. Best delay it for now. NeilBrown > > The rpciod workqueue is on the write-out path for freeing dirty memory, > so it i

Re: [PATCH v3] net: bpf: permit redirect from ingress L3 to egress L2 devices at near max mtu

2020-05-07 Thread Daniel Borkmann
On 5/7/20 6:46 PM, Maciej Żenczykowski wrote: (a) not clear why the max is SKB_MAX_ALLOC in the first place (this is PAGE_SIZE << 2, ie. 16K on x86), while lo mtu is 64k Agreed, tbh, it's not clear to me either atm. :) The SKB_MAX_ALLOC constant itself should be replaced with something more ap

Re: [PATCH v2] ath10k: Replace zero-length array with flexible-array

2020-05-07 Thread Rajkumar Manoharan
On 2020-05-06 21:11, Gustavo A. R. Silva wrote: [...] static inline struct htt_stats_conf_item *htt_stats_conf_next_item( @@ -1674,7 +1674,7 @@ struct htt_tx_fetch_ind { __le16 num_resp_ids; __le16 num_records; struct htt_tx_fetch_record records[0]; - __le32 resp_id

Re: [PATCH bpf-next 02/17] bpf: Introduce SK_LOOKUP program type with a dedicated attach point

2020-05-07 Thread Martin KaFai Lau
On Wed, May 06, 2020 at 03:53:35PM +0200, Jakub Sitnicki wrote: > On Wed, May 06, 2020 at 03:16 PM CEST, Lorenz Bauer wrote: > > On Wed, 6 May 2020 at 13:55, Jakub Sitnicki wrote: > > [...] > > >> @@ -4012,4 +4051,18 @@ struct bpf_pidns_info { > >> __u32 pid; > >> __u32 tgid; > >

RE: [Intel-wired-lan] [PATCH net-next] i40e: Make i40e_shutdown_adminq() return void

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of Jason Yan Sent: Tuesday, May 5, 2020 11:19 PM To: Kirsher, Jeffrey T ; da...@davemloft.net; Azarewicz, Piotr ; intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Jason Yan Subject: [Intel-wire

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: Use true, false for bool variable in __ixgbe_enable_sriov()

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of Jason Yan Sent: Tuesday, May 5, 2020 12:44 AM To: Kirsher, Jeffrey T ; da...@davemloft.net; a...@kernel.org; dan...@iogearbox.net; k...@kernel.org; h...@kernel.org; john.fastab...@gmail.com; intel-wired-...@lists.osuosl.org; netdev@

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: Remove conversion to bool in ixgbe_device_supports_autoneg_fc()

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of Jason Yan Sent: Tuesday, May 5, 2020 12:42 AM To: Kirsher, Jeffrey T ; da...@davemloft.net; intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux-ker...@vger.kernel.org Cc: Jason Yan Subject: [Intel-wired-lan] [PATCH net-n

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: Remove unused inline function ixgbe_irq_disable_queues

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of YueHaibing Sent: Tuesday, May 5, 2020 1:36 AM To: Kirsher, Jeffrey T ; da...@davemloft.net Cc: netdev@vger.kernel.org; YueHaibing ; intel-wired-...@lists.osuosl.org; linux-ker...@vger.kernel.org Subject: [Intel-wired-lan] [PATCH net-n

RE: [Intel-wired-lan] [PATCH net-next] ixgbe: fix signed-integer-overflow warning

2020-05-07 Thread Bowers, AndrewX
-Original Message- From: Intel-wired-lan On Behalf Of Xie XiuQi Sent: Monday, May 4, 2020 7:45 PM To: Kirsher, Jeffrey T ; da...@davemloft.net Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux-ker...@vger.kernel.org Subject: [Intel-wired-lan] [PATCH net-next] ixgbe: fix

Re: [PATCH bpf-next v4 4/4] bpf: allow any port in bpf_bind helper

2020-05-07 Thread Andrey Ignatov
Stanislav Fomichev [Thu, 2020-05-07 12:12 -0700]: > We want to have a tighter control on what ports we bind to in > the BPF_CGROUP_INET{4,6}_CONNECT hooks even if it means > connect() becomes slightly more expensive. The expensive part > comes from the fact that we now need to call inet_csk_get_po

Re: [PATCH -next] cxgb4: remove duplicate headers

2020-05-07 Thread David Miller
From: Chen Zhou Date: Thu, 7 May 2020 21:26:39 +0800 > Remove duplicate headers which are included twice. > > Signed-off-by: Chen Zhou Applied.

Re: [PATCH -next] net: ipa: remove duplicate headers

2020-05-07 Thread David Miller
From: Chen Zhou Date: Thu, 7 May 2020 21:39:45 +0800 > Remove duplicate headers which are included twice. > > Signed-off-by: Chen Zhou The net-next tree already has this fixed.

Re: pull-request: wireless-drivers-next-2020-05-07

2020-05-07 Thread David Miller
From: Kalle Valo Date: Thu, 07 May 2020 16:21:06 +0300 > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. Pulled, thanks Kalle.

Re: [RFC PATCH bpf-next 3/3] bpf, arm64: Optimize ADD,SUB,JMP BPF_K using arm64 add/sub immediates

2020-05-07 Thread Daniel Borkmann
On 5/7/20 3:05 AM, Luke Nelson wrote: The current code for BPF_{ADD,SUB} BPF_K loads the BPF immediate to a temporary register before performing the addition/subtraction. Similarly, BPF_JMP BPF_K cases load the immediate to a temporary register before comparison. This patch introduces optimizati

Re: [PATCH v2 0/2] Add QRTR MHI client driver

2020-05-07 Thread David Miller
From: Manivannan Sadhasivam Date: Thu, 7 May 2020 18:23:04 +0530 > Here is the series adding MHI client driver support to Qualcomm IPC router > protocol. MHI is a newly added bus to kernel which is used to communicate to > external modems over a physical interface like PCI-E. This driver is used

Re: [RFC PATCH bpf-next 2/3] bpf, arm64: Optimize AND,OR,XOR,JSET BPF_K using arm64 logical immediates

2020-05-07 Thread Daniel Borkmann
On 5/7/20 3:05 AM, Luke Nelson wrote: The current code for BPF_{AND,OR,XOR,JSET} BPF_K loads the immediate to a temporary register before use. This patch changes the code to avoid using a temporary register when the BPF immediate is encodable using an arm64 logical immediate instruction. If the

Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code

2020-05-07 Thread David Miller
From: Tang Bin Date: Thu, 7 May 2020 19:50:10 +0800 > Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO() > to simplify code, avoid redundant judgements. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Saeed, please pick this up. Thank you.

Re: [PATCH] net: hisilicon: Make CONFIG_HNS invisible

2020-05-07 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 7 May 2020 13:45:11 +0200 > The HNS config symbol enables the framework support for the Hisilicon > Network Subsystem. It is already selected by all of its users, so there > is no reason to make it visible. > > Signed-off-by: Geert Uytterhoeven Applied, th

Re: [PATCH] via-rhine: Add platform dependencies

2020-05-07 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 7 May 2020 13:42:05 +0200 > The VIA Rhine Ethernet interface is only present on PCI devices or > VIA/WonderMedia VT8500/WM85xx SoCs. Add platform dependencies to the > VIA_RHINE config symbol, to avoid asking the user about it when > configuring a kernel with

Re: [net-next] net:enetc: bug fix for qos sfi operate space after freed

2020-05-07 Thread David Miller
From: Po Liu Date: Thu, 7 May 2020 18:57:38 +0800 > 'Dan Carpenter' reported: > This code frees "sfi" and then dereferences it on the next line: >> kfree(sfi); >> clear_bit(sfi->index, epsfp.psfp_sfi_bitmap); > > This "sfi->index" should be "index". > > Reported

Re: [PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_ethtool_add_mac_rule()

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:08:57 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1396:5-8: Unneeded > variable: "err". Return "0" on line 1411 > > Signed-off-by: Jason Yan Applied.

Re: [PATCH net-next] net: tulip: de4x5: make PCI_signature() return void

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:08:47 +0800 > This function always return 0 now, we can make it return void to > simplify the code. This fixes the following coccicheck warning: > > drivers/net/ethernet/dec/tulip/de4x5.c:3908:11-17: Unneeded variable: > "status". Return "0" on line 3912

Re: [PATCH net-next] net: atheros: remove dead code in atl1c_resume()

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:08:36 +0800 > This code has been marked dead for nearly 10 years. Remove it. > > Signed-off-by: Jason Yan Applied.

Re: [PATCH net-next] net: encx24j600: make encx24j600_hw_init() return void

2020-05-07 Thread David Miller
From: Jason Yan Date: Thu, 7 May 2020 19:09:05 +0800 > This function always return 0 now, we can make it return void to > simplify the code. This fixes the following coccicheck warning: > > drivers/net/ethernet/microchip/encx24j600.c:609:5-8: Unneeded variable: > "ret". Return "0" on line 653 >

Re: [PATCH] usb: hso: correct debug message

2020-05-07 Thread David Miller
From: Oliver Neukum Date: Thu, 7 May 2020 11:49:49 +0200 > If you do not find the OUT endpoint, you should say so, > rather than copy the error message for the IN endpoint. > Presumably a copy and paste error. > > Signed-off-by: Oliver Neukum Applied, thank you.

Re: [PATCH net-next] net: phy: Make iproc_mdio_resume static

2020-05-07 Thread David Miller
From: Zheng Zengkai Date: Thu, 7 May 2020 16:03:26 +0800 > Fix sparse warnings: > > drivers/net/phy/mdio-bcm-iproc.c:182:5: warning: > symbol 'iproc_mdio_resume' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Zheng Zengkai Applied.

Re: [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id()

2020-05-07 Thread Jeremy Linton
Hi, On 5/7/20 12:27 PM, Andy Shevchenko wrote: On Thu, May 7, 2020 at 4:26 PM Jeremy Linton wrote: On 5/5/20 8:29 AM, Calvin Johnson wrote: + if (sscanf(cp, "ethernet-phy-id%4x.%4x", +&upper, &lower) == 2) { + *phy_id = ((upper & 0xFFF

Re: [Patch net v3] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-07 Thread Nikolay Aleksandrov
On 07/05/2020 22:19, Cong Wang wrote: > syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event > between bonding master and slave. I managed to find a reproducer > for this: > > ip li set bond0 up > ifenslave bond0 eth0 > brctl addbr br0 > ethtool -K eth0 lro off > brctl addif br

Re: [PATCH net-next 7/7] net: atlantic: unify get_mac_permanent

2020-05-07 Thread Jakub Kicinski
On Thu, 7 May 2020 11:15:10 +0300 Igor Russkikh wrote: > From: Mark Starovoytov > > MAC generation in case if MAC is not populated is the same for both A1 and > A2. > This patch moves MAC generation into a separate function, which is called > from both places to reduce the amount of copy/paste.

Re: [EXT] Re: [PATCH v1 net-next 4/6] net: mscc: ocelot: VCAP IS1 support

2020-05-07 Thread Allan W. Nielsen
On 07.05.2020 11:23, Xiaoliang Yang wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Hi Allan, Hi Vladimir, On 06.05.2020 13:53, Vladimir Oltean wrote: [snip] >At the moment, the driver does not support more than 1 action. We might >need to

[PATCH] team: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By ma

[Patch net v3] net: fix a potential recursive NETDEV_FEAT_CHANGE

2020-05-07 Thread Cong Wang
syzbot managed to trigger a recursive NETDEV_FEAT_CHANGE event between bonding master and slave. I managed to find a reproducer for this: ip li set bond0 up ifenslave bond0 eth0 brctl addbr br0 ethtool -K eth0 lro off brctl addif br0 bond0 ip li set br0 up When a NETDEV_FEAT_CHANGE ev

[PATCH net 0/2] net: ipa: fix cleanup after modem crash

2020-05-07 Thread Alex Elder
The first patch in this series fixes a bug where the size of a data transfer request was never set, meaning it was 0. The consequence of this was that such a transfer request would never complete if attempted, and led to a hung task timeout. This data transfer is required for cleaning up IPA hard

  1   2   3   >