On Thu, Oct 17, 2019 at 11:03 PM Rudolf Spring wrote:
>
> Can you reproduce the error in the lab ? Same behaviour with Kernel 5.3.6.
>
Yes. We are trying to reproduce in our local lab. We will update once
we have reproduction.
>
> eth0: flags=4163 mtu 9000
> ether a8:20:66:28:e6:95 txqu
On Thu, Oct 17, 2019 at 9:28 AM Stanislav Fomichev wrote:
> Tried to do the following:
>
> 1. Add: static volatile const char __annotate_source1[] = __FILE__;
>to test_rdonly_maps.c and I think it got optimized away :-/
>At least I don't see it in the 'bpftool btf dump' output.
>
> 2. Add:
Thu, Oct 17, 2019 at 09:20:55PM CEST, and...@lunn.ch wrote:
>Some of the marvell switches have bits controlling the hash algorithm
s/marvell/Marvell/
>the ATU uses for MAC addresses. In some industrial settings, where all
>the devices are from the same manufacture, and hence use the same OUI,
>t
Only raw_tracepoint program type can have bpf_attr.attach_btf_id >= 0.
Make sure to reject other program types that accidentally set it to non-zero.
Fixes: ccfe29eb29c2 ("bpf: Add attach_btf_id attribute to program load")
Reported-by: Andrii Nakryiko
Signed-off-by: Alexei Starovoitov
---
kernel
Thu, Oct 17, 2019 at 09:20:54PM CEST, and...@lunn.ch wrote:
>Add plumbing to allow DSA drivers to register parameters with devlink.
>
>To keep with the abstraction, the DSA drivers pass the ds structure to
>these helpers, and the DSA core then translates that to the devlink
>structure associated to
BPF prog for XDP parses the packet and extracts the flow key. Then find
an entry from flow tables.
Only "accept" and "drop" actions are implemented at this point.
Signed-off-by: Toshiaki Makita
---
net/xdp_flow/xdp_flow_kern_bpf.c | 297 ++-
1 file changed, 29
On Fri, Oct 18, 2019 at 6:38 AM Pravin Shelar wrote:
>
> On Wed, Oct 16, 2019 at 5:50 AM wrote:
> >
> > From: Tonghao Zhang
> >
> > When we destroy the flow tables which may contain the flow_mask,
> > so release the flow mask struct.
> >
> > Signed-off-by: Tonghao Zhang
> > Tested-by: Greg Rose
As UMH runs under RTNL, it cannot attach XDP from userspace. Thus the
kernel, xdp_flow module, installs the XDP program.
Signed-off-by: Toshiaki Makita
---
net/xdp_flow/xdp_flow_kern_mod.c | 109 ---
1 file changed, 103 insertions(+), 6 deletions(-)
diff --gi
This logic will be used when xdp_flow kmod requests flow
insertion/deleteion.
On insertion, find a free entry and populate it, then update next index
pointer of its previous entry. On deletion, set the next index pointer
of the prev entry to the next index of the entry to be deleted.
Signed-off-b
Add maps for flow tables in bpf. TC flower has hash tables for each flow
mask ordered by priority. To do the same thing, prepare a
hashmap-in-arraymap. As bpf does not provide ordered list, we emulate it
by an array. Each array entry has one-byte next index field to implement
a list. Also prepare a
XDP progs are likely to read/write xdp->data.
This improves the performance of xdp_flow.
Signed-off-by: Toshiaki Makita
---
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
b/drivers/net/ethernet/intel/i4
As struct flow_rule has descrete storages for flow_dissector and
key/mask containers, we need to serialize them in some way to pass them
to UMH.
Convert flow_rule into flow key form used in xdp_flow bpf prog and
pass it.
Signed-off-by: Toshiaki Makita
---
net/xdp_flow/xdp_flow_kern_mod.c | 331
Add a devmap for XDP_REDIRECT and use it for redirect action.
Signed-off-by: Toshiaki Makita
---
net/xdp_flow/umh_bpf.h | 1 +
net/xdp_flow/xdp_flow_kern_bpf.c | 14 +++-
net/xdp_flow/xdp_flow_kern_mod.c | 14
net/xdp_flow/xdp_flow_umh.c | 164
The usage would be like this:
$ ethtool -K eth0 flow-offload-xdp on
$ tc qdisc add dev eth0 clsact
$ tc filter add dev eth0 ingress protocol ip flower ...
Then the filters offloaded to XDP are marked as "in_hw".
xdp_flow is using the indirect block mechanism to handle the newly added
feature.
On Sun, Sep 01, 2019 at 11:06:05AM +0300, Kalle Valo wrote:
> Guenter Roeck writes:
>
> > Hi,
> >
> > On Sat, Aug 03, 2019 at 08:31:01PM -0400, Hui Peng wrote:
> >> The `ar_usb` field of `ath10k_usb_pipe_usb_pipe` objects
> >> are initialized to point to the containing `ath10k_usb` object
> >> ac
This is a PoC for an idea to offload flow, i.e. TC flower and nftables,
to XDP.
* Motivation
The purpose is to speed up flow based network features like TC flower and
nftables by making use of XDP.
I chose flow feature because my current interest is in OVS. OVS uses TC
flower to offload flow tab
memcmp() is generally slow. Compare keys in long if possible.
This improves xdp_flow performance.
Signed-off-by: Toshiaki Makita
---
kernel/bpf/hashtab.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.c
i
Factor out the logic in bpf_prog_get_fd_by_id() and add
bpf_prog_get_by_id()/bpf_prog_get_type_dev_by_id().
Also export bpf_prog_get_type_dev_by_id(), which will be used by the
following commit to get bpf prog from its id.
Signed-off-by: Toshiaki Makita
---
include/linux/bpf.h | 8
ke
Add flow offload driver, xdp_flow_core.c, and skeleton of UMH handling
mechanism. The driver is not called from anywhere yet.
xdp_flow_setup_block() in xdp_flow_core.c is meant to be called when
a net device is bound to a flow block, e.g. ingress qdisc is added.
It loads xdp_flow kernel module and
Factor out the check and change logic from dev_change_xdp_fd(),
and export them for the following commit.
Signed-off-by: Toshiaki Makita
---
include/linux/netdevice.h | 4 ++
net/core/dev.c| 111 +-
2 files changed, 95 insertions(+), 20 d
This is another example action.
Signed-off-by: Toshiaki Makita
---
net/xdp_flow/xdp_flow_kern_bpf.c | 23 +--
net/xdp_flow/xdp_flow_kern_mod.c | 5 +
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/net/xdp_flow/xdp_flow_kern_bpf.c b/net/xdp_flow/xdp_flow_
Hi all,
Today's linux-next merge of the tip tree got a conflict in:
samples/bpf/Makefile
between commit:
1d97c6c2511f ("samples/bpf: Base target programs rules on Makefile.target")
from the net-next tree and commit:
fce9501aec6b ("samples/bpf: fix build by setting HAVE_ATTR_TEST to zero
The program is meant to be loaded when a device is bound to an ingress
flow block and should be attached to XDP on the device.
Typically it should be loaded when TC ingress or clsact qdisc is added
or a nftables offloaded chain is added.
The program is prebuilt and embedded in the UMH, instead of
Check if TC flow offloading to XDP works.
Signed-off-by: Toshiaki Makita
---
tools/testing/selftests/bpf/Makefile | 1 +
tools/testing/selftests/bpf/test_xdp_flow.sh | 106 +++
2 files changed, 107 insertions(+)
create mode 100755 tools/testing/selftests/bpf/te
Greetings
My name is Barrister Hans Erich.
I have a client who is interested to invest in your country, she is a well
known politician in her country and deserve a lucrative investment partnership
with you outside her country without any delay Please can you manage such
investment please Kin
Dear Sir / Madam
Since ever we left your country back to Canada , we have gotten Government
approval and we have been busying planning for the less privilege Children
projects.
We are planning to release first batch of the funds $2,990,000.00 within 14
days for building an estate for motherl
On Thu, 17 Oct 2019 16:48:25 -0700, Jakub Kicinski wrote:
> > The only patch that we have been able to make consistently work
> > without crashing and also without compromising performance, is the
> > previously submitted one where later thread bails out of
> > tls_tx_records. And as mentioned, it
From: Wei Wang
Date: Wed, 16 Oct 2019 12:03:15 -0700
> Jesse and Ido reported the following race condition:
> - Received packet A is forwarded and cached dst entry is
> taken from the nexthop ('nhc->nhc_rth_input'). Calls skb_dst_set()
>
> - Given Jesse has busy routers ("ingesting full BGP ro
From: Stefano Brivio
Date: Wed, 16 Oct 2019 20:52:09 +0200
> ...instead of -EINVAL. An issue was found with older kernel versions
> while unplugging a NFS client with pending RPCs, and the wrong error
> code here prevented it from recovering once link is back up with a
> configured address.
>
>
From: Edward Cree
Date: Wed, 16 Oct 2019 16:26:50 +0100
> Hi, did this get missed or was my request improper in some way?
> Our testing has been hitting this issue on distro kernels (Fedora, Debian,
> Ubuntu), we'd like the fix to get everywhere it's needed and AIUI -stable
> is the proper rout
On Wed, 9 Oct 2019 16:57:39 +, Pooja Trivedi wrote:
> On Fri, Sep 27, 2019 at 05:37:53PM -0700, Jakub Kicinski wrote:
> > On Tue, 24 Sep 2019 12:48:26 -0400, Pooja Trivedi wrote:
> > > On Mon, Sep 23, 2019 at 8:28 PM Jakub Kicinski wrote:
> > > > On Sat, 21 Sep 2019 23:19:20 -0400, Pooja Tr
From: Marek Vasut
Date: Wed, 16 Oct 2019 15:35:07 +0200
> The KSZ8795 PHY ID is in fact used by KSZ8794/KSZ8795/KSZ8765 switches.
> Update the PHY ID and name to reflect that, as this family of switches
> is commonly refered to as KSZ87xx
>
> Signed-off-by: Marek Vasut
Applied.
From: Marek Vasut
Date: Wed, 16 Oct 2019 15:35:06 +0200
> The KSZ8051 PHY and the KSZ8794/KSZ8795/KSZ8765 switch share exactly the
> same PHY ID. Since KSZ8051 is higher in the ksphy_driver[] list of PHYs
> in the micrel PHY driver, it is used even with the KSZ87xx switch. This
> is wrong, since
Greetings
My name is Barrister Hans Erich.
I have a client who is interested to invest in your country, she is a well
known politician in her country and deserve a lucrative investment partnership
with you outside her country without any delay Please can you manage such
investment please Kin
Greetings
My name is Barrister Hans Erich.
I have a client who is interested to invest in your country, she is a well
known politician in her country and deserve a lucrative investment partnership
with you outside her country without any delay Please can you manage such
investment please Kin
On Wed, Oct 16, 2019 at 5:50 AM wrote:
>
> From: Tonghao Zhang
>
> When we destroy the flow tables which may contain the flow_mask,
> so release the flow mask struct.
>
> Signed-off-by: Tonghao Zhang
> Tested-by: Greg Rose
> ---
> net/openvswitch/flow_table.c | 14 +-
> 1 file chan
Vinicius,
On 10/17/2019 05:02 PM, Murali Karicheri wrote:
On 10/17/2019 03:32 PM, Vinicius Costa Gomes wrote:
Murali Karicheri writes:
root@am57xx-evm:~# tc qdisc replace dev eth0 parent root handle 100
taprio \
> num_tc 4 \
> map 2 3 1 0 2 2 2 2 2 2 2 2 2 2 2 2 \
> queue
My Dear Friend
With due respect to your person and much sincerity of purpose, I make
this contact with you as I believe that you can be of great assistance
to me. My name, Mr.Samuel Anu, from Burkina Faso, West Africa. I work
in Bank here as telex manager, Please Can you use ATM Visa card to
with
On 10/17/2019 03:32 PM, Vinicius Costa Gomes wrote:
Murali Karicheri writes:
root@am57xx-evm:~# tc qdisc replace dev eth0 parent root handle 100 taprio \
> num_tc 4 \
> map 2 3 1 0 2 2 2 2 2 2 2 2 2 2 2 2 \
> queues 1@0 1@0 1@0 1@0 \
> base-time 1564535762845777831 \
On Thu, Oct 17, 2019 at 9:20 AM Martin Varghese
wrote:
>
> On Tue, Oct 08, 2019 at 12:28:23PM -0400, Willem de Bruijn wrote:
> > On Tue, Oct 8, 2019 at 5:51 AM Martin Varghese
> > wrote:
> > >
> > > From: Martin
> > >
> > > The Bareudp tunnel module provides a generic L3 encapsulation
> > > tunn
On 10/17, Andrii Nakryiko wrote:
> On Thu, Oct 17, 2019 at 9:07 AM Stanislav Fomichev wrote:
> >
> > On 10/16, Andrii Nakryiko wrote:
> > > On Wed, Oct 16, 2019 at 9:32 AM Stanislav Fomichev
> > > wrote:
> > > >
> > > > On 10/15, Andrii Nakryiko wrote:
> > > > > Define test runner generation met
Am Donnerstag, den 17.10.2019, 14:20 -0400 schrieb David Miller:
> From: David Miller
> Date: Thu, 17 Oct 2019 14:19:55 -0400 (EDT)
>
> > From: Oliver Neukum
> > Date: Thu, 17 Oct 2019 11:53:38 +0200
> >
> > > The serial state information must not be embedded into another
> > > data structure,
On 10/17/2019 12:22 PM, David Miller wrote:
From: xiangxia.m@gmail.com
Date: Tue, 15 Oct 2019 18:30:30 +0800
This series patch optimize openvswitch for performance or simplify
codes.
...
Pravin and company, please review!
Hi Dave,
I've tested the patches and provided my 'Tested-by'
On Thu, 17 Oct 2019 21:20:55 +0200, Andrew Lunn wrote:
> Some of the marvell switches have bits controlling the hash algorithm
> the ATU uses for MAC addresses. In some industrial settings, where all
> the devices are from the same manufacture, and hence use the same OUI,
> the default hashing algo
From: Heiner Kallweit
Date: Thu, 17 Oct 2019 21:26:35 +0200
> To be on the safe side, let me check with Realtek directly.
That's a great idea, let us know what you find out.
From: Marek Vasut
Date: Wed, 16 Oct 2019 15:33:23 +0200
> The KSZ87xx driver calls mutex_init() on mutexes already inited in
> ksz_common.c ksz_switch_register(). Do not do it twice, drop the
> reinitialization.
>
> Signed-off-by: Marek Vasut
Applied.
From: Marek Vasut
Date: Wed, 16 Oct 2019 15:33:24 +0200
> The KSZ driver uses one regmap per register width (8/16/32), each with
> it's own lock, but accessing the same set of registers. In theory, it
> is possible to create a race condition between these regmaps, although
> the underlying bus (S
From: Sebastian Andrzej Siewior
Date: Wed, 16 Oct 2019 10:28:33 +0200
> From: Marc Kleine-Budde
>
> With threaded interrupts enabled, the interrupt thread runs as SCHED_RR
> with priority 50. If a user application with a higher priority preempts
> the interrupt thread and tries to shutdown the
Murali Karicheri writes:
>
> root@am57xx-evm:~# tc qdisc replace dev eth0 parent root handle 100 taprio \
> > num_tc 4 \
> > map 2 3 1 0 2 2 2 2 2 2 2 2 2 2 2 2 \
> > queues 1@0 1@0 1@0 1@0 \
> > base-time 1564535762845777831 \
> > sched-entry S 0xC 1500 \
> > sch
As soon as the netdev is registers, the kernel can start using the
interface. If the driver connects the MAC to the PHY after the netdev
is registered, there is a race condition where the interface can be
opened without having the PHY connected.
Change the order to close this race condition.
Fixe
On Thu, Oct 17, 2019 at 11:44 AM Jakub Kicinski
wrote:
>
> On Thu, 17 Oct 2019 11:10:06 -0700, Cong Wang wrote:
> > On Wed, Oct 16, 2019 at 4:22 PM Jakub Kicinski wrote:
> > > On Wed, 16 Oct 2019 15:42:28 -0700, Cong Wang wrote:
> > > > > @@ -612,7 +613,7 @@ static int netem_enqueue(struct sk_buff
From: Ioana Ciornei
Date: Wed, 16 Oct 2019 10:36:21 +0300
> This patch set adds a couple of fixes around updating configuration on MAC
> change. Depending on when MC connects the DPNI to a MAC, both the MAC
> address and TX FQIDs should be updated everytime there is a change in
> configuration.
On 17.10.2019 21:11, David Miller wrote:
> From: Heiner Kallweit
> Date: Thu, 17 Oct 2019 20:59:43 +0200
>
>> It's unclear where these entries came from and also the r8101
>> vendor driver doesn't mention any such chip type. So let's
>> remove these entries.
>>
>> Signed-off-by: Heiner Kallweit
From: xiangxia.m@gmail.com
Date: Tue, 15 Oct 2019 18:30:30 +0800
> This series patch optimize openvswitch for performance or simplify
> codes.
...
Pravin and company, please review!
On Thu, 17 Oct 2019 17:31:22 +0530, Sheetal Tigadoli wrote:
> From: Vasundhara Volam
>
> Driver supports 2 types of core dumps.
>
> 1. Live dump - Firmware dump when system is up and running.
> 2. Crash dump - Dump which is collected during firmware crash
> that can be retrieved
Some of the marvell switches have bits controlling the hash algorithm
the ATU uses for MAC addresses. In some industrial settings, where all
the devices are from the same manufacture, and hence use the same OUI,
the default hashing algorithm is not optimal. Allow the other
algorithms to be selected
The Marvell switches allow the hash algorithm for MAC addresses in the
address translation unit to be configured. Add support to the DSA core
to allow DSA drivers to make use of devlink parameters, and allow the
ATU hash to be get/set via such a parameter.
v2:
Pass a pointer for where the hash sh
Add plumbing to allow DSA drivers to register parameters with devlink.
To keep with the abstraction, the DSA drivers pass the ds structure to
these helpers, and the DSA core then translates that to the devlink
structure associated to the device.
Signed-off-by: Andrew Lunn
---
include/net/dsa.h
On Thu, Oct 17, 2019 at 1:09 AM Jakub Sitnicki wrote:
>
> On Thu, Oct 17, 2019 at 08:52 AM CEST, Andrii Nakryiko wrote:
> > On Wed, Oct 16, 2019 at 9:28 PM Alexei Starovoitov
> > wrote:
> >>
> >> On Wed, Oct 16, 2019 at 4:49 AM Andrii Nakryiko wrote:
> >> >
> >> > This patch set extensively reva
On Wed, Oct 16, 2019 at 9:07 AM Toke Høiland-Jørgensen wrote:
>
> It seems I forgot to add handling of devmap_hash type maps to the device
> unregister hook for devmaps. This omission causes devices to not be
> properly released, which causes hangs.
>
> Fix this by adding the missing handler.
>
>
On Thu, Oct 17, 2019 at 11:18 AM Martin Lau wrote:
>
> On Thu, Oct 17, 2019 at 10:37:52AM +0200, Jakub Sitnicki wrote:
> > flow_dissector_reattach test changes the netns we run in but does not
> > restore it to the one we started in when finished. This interferes with
> > tests that run after it.
From: Heiner Kallweit
Date: Thu, 17 Oct 2019 20:59:43 +0200
> It's unclear where these entries came from and also the r8101
> vendor driver doesn't mention any such chip type. So let's
> remove these entries.
>
> Signed-off-by: Heiner Kallweit
Hmmm... does it really hurt anything to keep them
From: Oliver Neukum
Date: Thu, 17 Oct 2019 15:25:47 +0200
> The serial state information must not be embedded into another
> data structure, as this interferes with cache handling for DMA
> on architectures without cache coherence..
> That would result in data corruption on some architectures
> A
From: Lorenzo Bianconi
Date: Thu, 17 Oct 2019 14:28:32 +0200
> Increment netdev rx counters even for XDP_DROP verdict. Report even
> tx bytes for xdp buffers (TYPE_NETSEC_XDP_TX or TYPE_NETSEC_XDP_NDO).
> Moreover account pending buffer length in netsec_xdp_queue_one as it is
> done for skb count
On Thu, Oct 17, 2019 at 12:52:32PM +0200, Toke Høiland-Jørgensen wrote:
> It seems I forgot to add handling of devmap_hash type maps to the device
> unregister hook for devmaps. This omission causes devices to not be
> properly released, which causes hangs.
>
> Fix this by adding the missing handl
It's unclear where these entries came from and also the r8101
vendor driver doesn't mention any such chip type. So let's
remove these entries.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/r8169_main.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --g
On Thu, 17 Oct 2019 12:57:02 +0200, Toke Høiland-Jørgensen wrote:
> Tetsuo pointed out that without an explicit cast, the cost calculation for
> devmap_hash type maps could overflow on 32-bit builds. This adds the
> missing cast.
>
> Fixes: 6f9d451ab1a3 ("xdp: Add devmap_hash map type for looking
On Thu, 17 Oct 2019 11:10:06 -0700, Cong Wang wrote:
> On Wed, Oct 16, 2019 at 4:22 PM Jakub Kicinski wrote:
> > On Wed, 16 Oct 2019 15:42:28 -0700, Cong Wang wrote:
> > > > @@ -612,7 +613,7 @@ static int netem_enqueue(struct sk_buff *skb,
> > > > struct Qdisc *sch,
> > > >
> So you conclude as it is not leak too? Then what are you trying to
> fix?
I conclude there is no easily *visible* leak.
At least not at first glance - not with single threaded code.
> I am becoming more confused after this. :-/
I think adding kmemleak_not_leak() is hiding the fact that there
a
On Thu, Oct 17, 2019 at 07:52:32PM +0200, Stefan Wahren wrote:
> Hi Daniel,
>
> Am 17.10.19 um 19:41 schrieb Daniel Wagner:
> > Hi Stefan,
> >
> > On Thu, Oct 17, 2019 at 07:05:32PM +0200, Stefan Wahren wrote:
> >> Am 17.10.19 um 08:52 schrieb Daniel Wagner:
> >>> On Wed, Oct 16, 2019 at 05:51:07P
From: Maciej Żenczykowski
This fixes:
external/ethtool/de2104x.c:115:43: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
de21040_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
external/ethtool/de2104x.c:421:43: error: unused parameter 'info'
[-Werror,-Wunu
From: Maciej Żenczykowski
This fixes:
external/ethtool/igb.c:92:39: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
igb_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: If2e175d1b1bd3976d760dc359b52c304e8334f92
---
From: Maciej Żenczykowski
This fixes:
external/ethtool/fec.c:197:43: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int fec_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I5d53deb593d72dcfde95b62f1651dd8f5d6aa3b
From: Maciej Żenczykowski
This fixes:
external/ethtool/tse.c:28:50: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int altera_tse_dump_regs(struct ethtool_drvinfo *info,
Signed-off-by: Maciej Żenczykowski
Change-Id: I555f0e3c55bba999aeb64f1e1435744590ea389d
---
tse.c | 2 +-
From: Maciej Żenczykowski
This fixes:
external/ethtool/e100.c:40:40: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
e100_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: Idc6e3bb3fb837555425ddd6cc903e8763a4c71e1
-
From: Maciej Żenczykowski
This fixes:
external/ethtool/ethtool.c:1271:70: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
static int dump_eeprom(int geeprom_dump_raw, struct ethtool_drvinfo *info,
Signed-off-by: Maciej Żenczykowski
Change-Id: I57c65a8d21c6864d4c09f37bb3d408348e
From: Maciej Żenczykowski
This fixes:
external/ethtool/natsemi.c:967:45: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
natsemi_dump_eeprom(struct ethtool_drvinfo *info, struct ethtool_eeprom *ee)
Signed-off-by: Maciej Żenczykowski
Change-Id: I40d66f887d18ac6e69e1f365767a19f58
From: Maciej Żenczykowski
This fixes:
external/ethtool/sfc.c:3894:39: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
sfc_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: Ia255a280742332c44b66bf8f5bb678abc7e3467b
-
From: Maciej Żenczykowski
This fixes:
external/ethtool/vioc.c:14:44: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int vioc_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I2b25a5c4d23af281616847ceb75ca8c70dfb44
From: Maciej Żenczykowski
This fixes:
external/ethtool/ixgb.c:42:40: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
ixgb_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I674e03805dc9a4633d0299d9f4e88bd4ddb61359
-
From: Maciej Żenczykowski
This fixes:
external/ethtool/e1000.c:368:41: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
e1000_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: Ib0bf9e87137f256adf6e93f90d7f9426ab376a5
From: Maciej Żenczykowski
This fixes:
external/ethtool/vmxnet3.c:6:43: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
vmxnet3_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I5494339c8d17e72424651e7056605cd61aa6d
From: Maciej Żenczykowski
This fixes:
external/ethtool/e1000.c:258:38: error: unused parameter 'revision_id'
[-Werror,-Wunused-parameter]
e1000_get_mac_type(u16 device_id, u8 revision_id)
Signed-off-by: Maciej Żenczykowski
Change-Id: I2469ef61996fd273cc3a2a6a7af0ae889c81b02b
---
e1000.c |
From: Maciej Żenczykowski
This fixes:
external/ethtool/marvell.c:262:44: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int skge_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
external/ethtool/marvell.c:382:44: error: unused parameter 'info'
[-Werror,-Wun
From: Maciej Żenczykowski
This fixes:
external/ethtool/smsc911x.c:5:48: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int smsc911x_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs
*regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I419e8e365481020241303033fcdfaf
From: Maciej Żenczykowski
This fixes:
external/ethtool/at76c50x-usb.c:16:48: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
at76c50x_usb_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs
*regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I4ca9edb1b155c63f14268aebf
From: Maciej Żenczykowski
This fixes:
external/ethtool/ibm_emac.c:317:48: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int ibm_emac_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs
*regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I18f305612e48ae76031ae327acf1
From: Maciej Żenczykowski
This fixes:
external/ethtool/amd8111e.c:155:48: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int amd8111e_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs
*regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I885d775f4b56f75b8f5bfa2abefb
From: Maciej Żenczykowski
This fixes:
external/ethtool/et131x.c:5:46: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int et131x_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I4e90a489bdd3a0a04817149b1b6a86e7ef9
From: Maciej Żenczykowski
This fixes:
external/ethtool/fjes.c:5:44: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int fjes_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: Id5409c70e26f4e131a8557a9c8f0a0c921dfefd
From: Maciej Żenczykowski
This fixes:
external/ethtool/lan78xx.c:5:47: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int lan78xx_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: Ibc67c27248ca623e9ca8534d43c888af3
From: Maciej Żenczykowski
This fixes:
external/ethtool/natsemi.c:326:43: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
natsemi_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: Ib45adc15c39be9886fdc77ee488aba6b677
From: Maciej Żenczykowski
This fixes:
external/ethtool/ethtool.c:473:43: error: unused parameter 'ctx'
[-Werror,-Wunused-parameter]
static int do_version(struct cmd_context *ctx)
external/ethtool/ethtool.c:5392:43: error: unused parameter 'ctx'
[-Werror,-Wunused-parameter]
static int s
From: Maciej Żenczykowski
This fixes:
external/ethtool/stmmac.c:21:49: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int st_mac100_dump_regs(struct ethtool_drvinfo *info,
external/ethtool/stmmac.c:54:47: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int st_g
From: Maciej Żenczykowski
This fixes:
external/ethtool/dsa.c:677:43: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int dsa_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I7da1206aab480823b6aee2aa013db3e2912c829
From: Maciej Żenczykowski
This fixes:
external/ethtool/ixgbevf.c:6:43: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
ixgbevf_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I6f3233ceb46bc6b96eca673578fa2a6281ea8
From: Maciej Żenczykowski
This fixes:
external/ethtool/ixgbe.c:171:41: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
ixgbe_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I745f6b9582bc176eafdce9e292a4bf2a951c0c6
From: Maciej Żenczykowski
This fixes:
external/ethtool/marvell.c:127:22: error: arithmetic on a pointer to void is
a GNU extension [-Werror,-Wpointer-arith]
dump_timer("LED", p + 0x20);
(and remove some spare whitespace while we're at it)
Signed-off-by: Maciej Żenczykowski
Change-Id: Ia49
From: Maciej Żenczykowski
This fixes:
external/ethtool/fec_8xx.c:50:47: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
int fec_8xx_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: Iefd61cf2b89804fab8ca6c8451967066
From: Maciej Żenczykowski
This fixes:
external/ethtool/realtek.c:244:43: error: unused parameter 'info'
[-Werror,-Wunused-parameter]
realtek_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
Signed-off-by: Maciej Żenczykowski
Change-Id: I62fa7dbb66d5ae545272b41538198787dbb
1 - 100 of 176 matches
Mail list logo
