Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-10 Thread Andrew Lunn
On Sun, Aug 11, 2019 at 05:18:57AM +0200, Marek Behún wrote: > Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in > genphy_read_status") broke fixed link DSA port registration in > dsa_port_fixed_link_register_of: the genphy_read_status does not do what > it is supposed to and the followi

Re: [PATCH net-next 1/1] net: dsa: fix fixed-link port registration

2019-08-10 Thread Marek Behun
On Sat, 10 Aug 2019 20:00:01 -0700 (PDT) David Miller wrote: > From: Marek Behun > Date: Sun, 11 Aug 2019 04:02:47 +0200 > > > Which means I should have added the Fixes tag /o\ > > Which means you need to repost this patch with it added. Sent as v2

[PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-10 Thread Marek Behún
Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in genphy_read_status") broke fixed link DSA port registration in dsa_port_fixed_link_register_of: the genphy_read_status does not do what it is supposed to and the following adjust_link is given wrong parameters. This causes a regression o

Re: [PATCH net-next 1/1] net: dsa: fix fixed-link port registration

2019-08-10 Thread David Miller
From: Marek Behun Date: Sun, 11 Aug 2019 04:02:47 +0200 > Which means I should have added the Fixes tag /o\ Which means you need to repost this patch with it added.

[net-next:master 57/138] arch/mips/include/asm/octeon/cvmx-ipd.h:330:27: error: storage size of 'pip_sft_rst' isn't known

2019-08-10 Thread kbuild test robot
Hi Matthew, FYI, the error/warning still remains. tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next.git master head: 2cc2743d8feec87b0bc0c9c1106136852d97f566 commit: 171a9bae68c72f2d1260c3825203760856e6793b [57/138] staging/octeon: Allow test build on !MIPS conf

Re: [PATCH net-next 1/1] net: dsa: fix fixed-link port registration

2019-08-10 Thread Marek Behun
Which means I should have added the Fixes tag /o\ On Sun, 11 Aug 2019 03:47:42 +0200 Marek Behun wrote: > This should probably go into stable as well, after review. > > Marek

Re: [PATCH net-next 1/1] net: dsa: fix fixed-link port registration

2019-08-10 Thread Marek Behun
This should probably go into stable as well, after review. Marek On Sun, 11 Aug 2019 03:46:50 +0200 Marek Behún wrote: > Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in > genphy_read_status") broke fixed link DSA port registration in > dsa_port_fixed_link_register_of: the genphy_re

[PATCH net-next 1/1] net: dsa: fix fixed-link port registration

2019-08-10 Thread Marek Behún
Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in genphy_read_status") broke fixed link DSA port registration in dsa_port_fixed_link_register_of: the genphy_read_status does not do what it is supposed to and the following adjust_link is given wrong parameters. This causes a regression o

Re: [PATCH v3 00/17] Networking driver debugfs cleanups

2019-08-10 Thread David Miller
From: Greg Kroah-Hartman Date: Sat, 10 Aug 2019 12:17:15 +0200 > There is no need to test the result of any debugfs call anymore. The > debugfs core warns the user if something fails, and the return value of > a debugfs call can always be fed back into another debugfs call with no > problems. >

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-10 Thread Roopa Prabhu
On Sat, Aug 10, 2019 at 8:50 AM Michal Kubecek wrote: > > On Sat, Aug 10, 2019 at 06:46:57AM -0700, Roopa Prabhu wrote: > > On Fri, Aug 9, 2019 at 8:46 AM Michal Kubecek wrote: > > > > > > On Fri, Aug 09, 2019 at 08:40:25AM -0700, Roopa Prabhu wrote: > > > > to that point, I am also not sure why

Re: [PATCH net-next v5 6/6] net: mscc: PTP Hardware Clock (PHC) support

2019-08-10 Thread Andrew Lunn
Hi Antoine > @@ -596,11 +606,53 @@ static int ocelot_port_xmit(struct sk_buff *skb, struct > net_device *dev) > > dev->stats.tx_packets++; > dev->stats.tx_bytes += skb->len; > - dev_kfree_skb_any(skb); > + > + if (ocelot->ptp && shinfo->tx_flags & SKBTX_HW_TSTAMP && > +

Re: [PATCH net-next v5 5/6] net: mscc: remove the frame_info cpuq member

2019-08-10 Thread Andrew Lunn
On Wed, Aug 07, 2019 at 11:22:13AM +0200, Antoine Tenart wrote: > In struct frame_info, the cpuq member is never used. This cosmetic patch > removes it from the structure, and from the parsing of the frame header > as it's only set but never used. > > Signed-off-by: Antoine Tenart Reviewed-by: A

Re: [PATCH net-next v5 3/6] net: mscc: describe the PTP register range

2019-08-10 Thread Andrew Lunn
On Wed, Aug 07, 2019 at 11:22:11AM +0200, Antoine Tenart wrote: > This patch adds support for using the PTP register range, and adds a > description of its registers. This bank is used when configuring PTP. > > Signed-off-by: Antoine Tenart Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v5 2/6] Documentation/bindings: net: ocelot: document the PTP ready IRQ

2019-08-10 Thread Andrew Lunn
On Wed, Aug 07, 2019 at 11:22:10AM +0200, Antoine Tenart wrote: > One additional interrupt needs to be described within the Ocelot device > tree node: the PTP ready one. This patch documents the binding needed to > do so. > > Signed-off-by: Antoine Tenart Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next v5 1/6] Documentation/bindings: net: ocelot: document the PTP bank

2019-08-10 Thread Andrew Lunn
On Wed, Aug 07, 2019 at 11:22:09AM +0200, Antoine Tenart wrote: > One additional register range needs to be described within the Ocelot > device tree node: the PTP. This patch documents the binding needed to do > so. > > Signed-off-by: Antoine Tenart Reviewed-by: Andrew Lunn Andrew

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-10 Thread Michal Kubecek
On Sat, Aug 10, 2019 at 06:46:57AM -0700, Roopa Prabhu wrote: > On Fri, Aug 9, 2019 at 8:46 AM Michal Kubecek wrote: > > > > On Fri, Aug 09, 2019 at 08:40:25AM -0700, Roopa Prabhu wrote: > > > to that point, I am also not sure why we have a new API For multiple > > > names. I mean why support more

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-10 Thread Roopa Prabhu
On Fri, Aug 9, 2019 at 8:46 AM Michal Kubecek wrote: > > On Fri, Aug 09, 2019 at 08:40:25AM -0700, Roopa Prabhu wrote: > > to that point, I am also not sure why we have a new API For multiple > > names. I mean why support more than two names (existing old name and > > a new name to remove the len

[PATCH] caif: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Richard Fontana Cc: Steve Winslow Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/n

[PATCH] xen-netback: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Wei Liu Cc: Paul Durrant Cc: xen-de...@lists.xenproject.org Cc: netdev@vger.kernel.org Signed-off-by: Greg Kro

[PATCH v3 05/17] bnxt: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. This cleans up a lot of unneeded code and logic around the debugfs files, making all of this much simpler and easier

[PATCH v3 08/17] nfp: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: "David S. Miller" Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Jesper Dangaard Brouer Cc: John Fastabend

[PATCH v3 09/17] stmmac: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Because we don't care about the individual files, we can remove the stored dentry for the files, as they are not nee

[PATCH v3 06/17] cxgb4: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. If a debugfs call fails, it will properly warn in the syslog, there's no need for all individual drivers to also pri

[PATCH v3 07/17] hns3: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Yisen Zhuang Cc: Salil Mehta Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroah-Hartm

[PATCH v3 04/17] xgbe: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. This cleans up a lot of unneeded code and logic around the debugfs files, making all of this much simpler and easier

[PATCH v3 03/17] mlx5: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. This cleans up a lot of unneeded code and logic around the debugfs files, making all of this much simpler and easier

[PATCH v3 16/17] ixgbe: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jeff Kirsher Cc: "David S. Miller" Cc: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-

[PATCH v3 02/17] bonding: no need to print a message if debugfs_create_dir() fails

2019-08-10 Thread Greg Kroah-Hartman
The debugfs core now will print a message if this function fails, so don't duplicate that logic. Also, no need to change the code logic if the call fails either, as no debugfs calls should interrupt normal kernel code for any reason. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc

[PATCH v3 17/17] ieee802154: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Alexander Aring Cc: "David S. Miller" Cc: Harry Morris Cc: linux-w...@vger.kernel.org Cc: netdev@vger.kernel.

[PATCH v3 11/17] qca: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: "David S. Miller" Cc: Stefan Wahren Cc: Michael Heimpold Cc: Yangtao Li Cc: netdev@vger.kernel.org Signed-of

[PATCH v3 00/17] Networking driver debugfs cleanups

2019-08-10 Thread Greg Kroah-Hartman
There is no need to test the result of any debugfs call anymore. The debugfs core warns the user if something fails, and the return value of a debugfs call can always be fed back into another debugfs call with no problems. Also, debugfs is for debugging, so if there are problems with debugfs (i.e

[PATCH v3 01/17] wimax: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. This cleans up a lot of unneeded code and logic around the debugfs wimax files, making all of this much simpler and

[PATCH v3 10/17] dpaa2: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Because we don't care about the individual files, we can remove the stored dentry for the files, as they are not nee

[PATCH v3 14/17] fm10k: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jeff Kirsher Cc: "David S. Miller" Cc: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-

[PATCH v3 13/17] mvpp2: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: "David S. Miller" Cc: Maxime Chevallier Cc: Nick Desaulniers Cc: Nathan Huckleberry Cc: netdev@vger.kernel.o

[PATCH v3 12/17] skge: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Mirko Lindner Cc: Stephen Hemminger Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Greg Kroa

[PATCH v3 15/17] i40e: no need to check return value of debugfs_create functions

2019-08-10 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jeff Kirsher Cc: "David S. Miller" Cc: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org Signed-off-

Re: [PATCH v2 00/17] Networking driver debugfs cleanups

2019-08-10 Thread Greg KH
On Fri, Aug 09, 2019 at 11:20:54AM -0700, David Miller wrote: > From: Greg Kroah-Hartman > Date: Fri, 9 Aug 2019 14:30:51 +0200 > > > v2: fix up build warnings, it's as if I never even built these. Ugh, so > > sorry for wasting people's time with the v1 series. I need to stop > > relyi

ok

2019-08-10 Thread AHM AHM
Greetings, It was nice to have your contact and I hope this mail doesn't come to you as a surprise or be treated as spam because i consider this info highly classified and pertinent. I am Mr. Ahmed Zama, A Senior staff in one of Bank here in Burkina Faso. I am contacting you with regards to this p