Re: [PATCH iproute2-next] rdma: Add driver QP type string

2019-08-05 Thread Leon Romanovsky
On Tue, Aug 06, 2019 at 09:41:37AM +0300, Gal Pressman wrote: > On 05/08/2019 22:08, David Ahern wrote: > > On 8/4/19 2:07 AM, Gal Pressman wrote: > >> RDMA resource tracker now tracks driver QPs as well, add driver QP type > >> string to qp_types_to_str function. > > > > "now" means which kernel r

Re: [PATCH iproute2-next] rdma: Add driver QP type string

2019-08-05 Thread Gal Pressman
On 05/08/2019 22:08, David Ahern wrote: > On 8/4/19 2:07 AM, Gal Pressman wrote: >> RDMA resource tracker now tracks driver QPs as well, add driver QP type >> string to qp_types_to_str function. > > "now" means which kernel release? Leon: should this be in master or -next? Now means the patch is

RE: hv_netvsc: WARNING: suspicious RCU usage?

2019-08-05 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of Dexuan Cui > Sent: Monday, August 5, 2019 4:56 PM > The warning is caused by the rcu_dereference_rtnl() : > > 1239 static void netvsc_get_stats64(struct net_device *net, > 1240struct rtnl_link_stats64 *t) >

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-05 Thread Michal Kubecek
On Mon, Aug 05, 2019 at 10:52:16AM -0400, Vivien Didelot wrote: > Hi Michal! > > On Mon, 5 Aug 2019 10:04:48 +0200, Michal Kubecek wrote: > > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > > > Usually kernel drivers set the regs->len value to the same length as > > > info->regd

Re: [PATCH v2 bpf-next 0/2] selftests/bpf: more loop tests

2019-08-05 Thread Yonghong Song
On 8/5/19 7:17 PM, Alexei Starovoitov wrote: > Add two bounded loop tests. > > v1-v2: addressed feedback from Yonghong. > > Alexei Starovoitov (2): >selftests/bpf: add loop test 4 >selftests/bpf: add loop test 5 Looks good to me. Ack for the whole series. Acked-by: Yonghong Song > >

Re: [net-next v2 0/8][pull request] 40GbE Intel Wired LAN Driver Updates 2019-08-05

2019-08-05 Thread Jakub Kicinski
On Mon, 5 Aug 2019 11:54:51 -0700, Jeff Kirsher wrote: > This series contains updates to i40e driver only. > > Dmitrii adds missing statistic counters for VEB and VEB TC's. > > Slawomir adds support for logging the "Disable Firmware LLDP" flag > option and its current status. > > Jake fixes an

Re: [PATCH net-next v6 0/6] flow_offload: add indr-block in nf_table_offload

2019-08-05 Thread Jakub Kicinski
On Sun, 4 Aug 2019 21:23:55 +0800, we...@ucloud.cn wrote: > From: wenxu > > This series patch make nftables offload support the vlan and > tunnel device offload through indr-block architecture. > > The first four patches mv tc indr block to flow offload and > rename to flow-indr-block. > Becaus

Re: [net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2019-08-04

2019-08-05 Thread Jakub Kicinski
On Sun, 4 Aug 2019 04:59:18 -0700, Jeff Kirsher wrote: > This series contains more updates to fm10k from Jake Keller. > > Jake removes the unnecessary initialization of some variables to help > resolve static code checker warnings. Explicitly return success during > resume, since the value of 'e

[PATCH v2 bpf-next 0/2] selftests/bpf: more loop tests

2019-08-05 Thread Alexei Starovoitov
Add two bounded loop tests. v1-v2: addressed feedback from Yonghong. Alexei Starovoitov (2): selftests/bpf: add loop test 4 selftests/bpf: add loop test 5 .../bpf/prog_tests/bpf_verif_scale.c | 2 ++ tools/testing/selftests/bpf/progs/loop4.c | 18 +++ tools/testing/sel

[PATCH v2 bpf-next 1/2] selftests/bpf: add loop test 4

2019-08-05 Thread Alexei Starovoitov
Add a test that returns a 'random' number between [0, 2^20) If state pruning is not working correctly for loop body the number of processed insns will be 2^20 * num_of_insns_in_loop_body and the program will be rejected. Signed-off-by: Alexei Starovoitov Acked-by: Andrii Nakryiko --- .../selfte

[PATCH v2 bpf-next 2/2] selftests/bpf: add loop test 5

2019-08-05 Thread Alexei Starovoitov
Add a test with multiple exit conditions. It's not an infinite loop only when the verifier can properly track all math on variable 'i' through all possible ways of executing this loop. barrier()s are needed to disable llvm optimization that combines multiple branches into fewer branches. Signed-o

Re: [PATCH v2] tools: bpftool: fix reading from /proc/config.gz

2019-08-05 Thread Jakub Kicinski
On Tue, 6 Aug 2019 02:07:02 +0100, Peter Wu wrote: > /proc/config has never existed as far as I can see, but /proc/config.gz > is present on Arch Linux. Execute an external gunzip program to avoid > linking to zlib and rework the option scanning code since a pipe is not > seekable. This also fixes

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-05 Thread Alexei Starovoitov
On Mon, Aug 05, 2019 at 02:25:35PM -0700, Andy Lutomirski wrote: > It tries to make the kernel respect the access modes for fds. Without > this patch, there seem to be some holes: nothing looked at program fds > and, unless I missed something, you could take a readonly fd for a > program, pin the

[PATCH v2] tools: bpftool: fix reading from /proc/config.gz

2019-08-05 Thread Peter Wu
/proc/config has never existed as far as I can see, but /proc/config.gz is present on Arch Linux. Execute an external gunzip program to avoid linking to zlib and rework the option scanning code since a pipe is not seekable. This also fixes a file handle leak on some error paths. Fixes: 4567b983f78

Re: [PATCH 1/1] bpf: introduce new helper udp_flow_src_port

2019-08-05 Thread Jakub Kicinski
On Sat, 3 Aug 2019 23:52:16 -0700, Y Song wrote: > > include/uapi/linux/bpf.h | 21 +++-- > > net/core/filter.c | 20 > > tools/include/uapi/linux/bpf.h| 21 +++-- > > tools/testing/selftests/bpf/bpf_helpers.h |

hv_netvsc: WARNING: suspicious RCU usage?

2019-08-05 Thread Dexuan Cui
Hi, After the VM boots up, I always get the below call-trace when I run "nload" for the first time: [ 113.910911] WARNING: suspicious RCU usage [ 113.913244] 5.2.0+ #19 Not tainted [ 113.915216] - [ 113.917521] drivers/net/hyperv/netvsc_drv.c:1243 suspicious rcu_d

Re: [PATCH] tools: bpftool: fix reading from /proc/config.gz

2019-08-05 Thread Peter Wu
Hi all, Thank you for your quick feedback, I will address them in the next revision. On Mon, Aug 05, 2019 at 11:41:09AM +0100, Quentin Monnet wrote: > As far as I understood (from examining Cilium [0]), /proc/config _is_ > used by some distributions, such as CoreOS. This is why we look at that >

[PATCH v2 net-next] selftests: Add l2tp tests

2019-08-05 Thread David Ahern
From: David Ahern Add IPv4 and IPv6 l2tp tests. Current set is over IP and with IPsec. v2 - add l2tp.sh to TEST_PROGS in Makefile Signed-off-by: David Ahern --- tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/net/l2tp.sh | 382 +++ 2 fil

[PATCH net 1/2] docs: admin-guide: remove references to IPX and token-ring

2019-08-05 Thread Stephen Hemminger
Both IPX and TR have not been supported for a while now. Remove them from the /proc/sys/net documentation. Signed-off-by: Stephen Hemminger --- Documentation/admin-guide/sysctl/net.rst | 29 +--- 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/Documentation/admi

[PATCH net 2/2] net: docs: replace IPX in tuntap documentation

2019-08-05 Thread Stephen Hemminger
IPX is no longer supported, but the example in the documentation might useful. Replace it with IPv6. Signed-off-by: Stephen Hemminger --- Documentation/networking/tuntap.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/tuntap.txt b/Documentati

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-05 Thread Andy Lutomirski
> On Aug 5, 2019, at 2:25 PM, Andy Lutomirski wrote: > > On Mon, Aug 5, 2019 at 12:21 PM Alexei Starovoitov > wrote: > >> What we need is to drop privileges sooner in daemons like systemd. > > This is doable right now: systemd could fork off a subprocess and > delegate its cgroup operatio

Re: pull-request: can 2019-08-02

2019-08-05 Thread David Miller
From: Marc Kleine-Budde Date: Fri, 2 Aug 2019 14:00:34 +0200 > this is a pull request of 4 patches for net/master. > > The first two patches are by Wang Xiayang, they force that the string buffer > during a dev_info() is properly NULL terminated. > > The last two patches are by Tomas Bortoli a

Re: [PATCH net-next v2] openvswitch: Print error when ovs_execute_actions() fails

2019-08-05 Thread Yifeng Sun
Thanks Pravin! Best, Yifeng On Mon, Aug 5, 2019 at 1:49 PM Pravin Shelar wrote: > > On Sun, Aug 4, 2019 at 7:56 PM Yifeng Sun wrote: > > > > Currently in function ovs_dp_process_packet(), return values of > > ovs_execute_actions() are silently discarded. This patch prints out > > an debug messa

Re: [PATCH bpf-next 1/2] selftests/bpf: add loop test 4

2019-08-05 Thread Andrii Nakryiko
On Mon, Aug 5, 2019 at 1:53 PM Alexei Starovoitov wrote: > > On 8/5/19 1:04 PM, Yonghong Song wrote: > > > > > > On 8/5/19 12:45 PM, Andrii Nakryiko wrote: > >> On Sat, Aug 3, 2019 at 8:19 PM Alexei Starovoitov wrote: > >>> > >>> Add a test that returns a 'random' number between [0, 2^20) > >>> I

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-05 Thread Andy Lutomirski
On Mon, Aug 5, 2019 at 12:21 PM Alexei Starovoitov wrote: > > On Mon, Aug 05, 2019 at 10:23:10AM -0700, Andy Lutomirski wrote: > > > > I refreshed the branch again. I had a giant hole in my previous idea > > that we could deprivilege program loading: some BPF functions need > > privilege. Now I

Re: [PATCH net 1/2] net/tls: partially revert fix transition through disconnect with close

2019-08-05 Thread John Fastabend
David Miller wrote: > From: Jakub Kicinski > Date: Thu, 1 Aug 2019 14:36:01 -0700 > > > Looks like we were slightly overzealous with the shutdown() > > cleanup. Even though the sock->sk_state can reach CLOSED again, > > socket->state will not got back to SS_UNCONNECTED once > > connections is ES

Re: [PATCH net-next] selftests: Add l2tp tests

2019-08-05 Thread David Ahern
On 8/5/19 2:20 PM, David Miller wrote: > From: David Ahern > Date: Thu, 1 Aug 2019 16:54:21 -0700 > >> From: David Ahern >> >> Add IPv4 and IPv6 l2tp tests. Current set is over IP and with >> IPsec. >> >> Signed-off-by: David Ahern >> --- >> The ipsec tests expose a netdev refcount leak that I

Re: [PATCH bpf-next 1/2] selftests/bpf: add loop test 4

2019-08-05 Thread Alexei Starovoitov
On 8/5/19 1:04 PM, Yonghong Song wrote: > > > On 8/5/19 12:45 PM, Andrii Nakryiko wrote: >> On Sat, Aug 3, 2019 at 8:19 PM Alexei Starovoitov wrote: >>> >>> Add a test that returns a 'random' number between [0, 2^20) >>> If state pruning is not working correctly for loop body the number of >>> p

Re: [PATCH net-next v2] openvswitch: Print error when ovs_execute_actions() fails

2019-08-05 Thread Pravin Shelar
On Sun, Aug 4, 2019 at 7:56 PM Yifeng Sun wrote: > > Currently in function ovs_dp_process_packet(), return values of > ovs_execute_actions() are silently discarded. This patch prints out > an debug message when error happens so as to provide helpful hints > for debugging. > --- > v1->v2: Fixed acc

[PATCH net-next] net: use "nb" for notifier blocks

2019-08-05 Thread Alexey Dobriyan
Use more pleasant looking struct notifier_block *nb, instead of "this". Signed-off-by: Alexey Dobriyan --- drivers/net/bonding/bond_main.c |2 +- drivers/net/ethernet/broadcom/cnic.c |2 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

[PATCH net-next] net: delete "register" keyword

2019-08-05 Thread Alexey Dobriyan
Delete long obsoleted "register" keyword. Signed-off-by: Alexey Dobriyan --- drivers/net/ethernet/apple/bmac.c |4 ++-- drivers/net/slip/slhc.c | 30 +++--- net/netfilter/ipvs/ip_vs_ctl.c|4 ++-- net/netfilter/ipvs/ip_vs_lblcr.c |4 ++-- 4 fi

Re: [patch 1/1] drivers/net/ethernet/marvell/mvmdio.c: Fix non OF case

2019-08-05 Thread David Miller
From: Arnaud Patard (Rtp) Date: Fri, 02 Aug 2019 10:32:40 +0200 > Orion5.x systems are still using machine files and not device-tree. > Commit 96cb4342382290c9 ("net: mvmdio: allow up to three clocks to be > specified for orion-mdio") has replaced devm_clk_get() with of_clk_get(), > leading to a

Re: [PATCH net] net/smc: avoid fallback in case of non-blocking connect

2019-08-05 Thread David Miller
From: Karsten Graul Date: Fri, 2 Aug 2019 10:47:50 +0200 > From: Ursula Braun > > FASTOPEN is not possible with SMC. sendmsg() with msg_flag MSG_FASTOPEN > triggers a fallback to TCP if the socket is in state SMC_INIT. > But if a nonblocking connect is already started, fallback to TCP > is no

Re: [PATCH net] net/smc: do not schedule tx_work in SMC_CLOSED state

2019-08-05 Thread David Miller
From: Karsten Graul Date: Fri, 2 Aug 2019 10:16:38 +0200 > From: Ursula Braun > > The setsockopts options TCP_NODELAY and TCP_CORK may schedule the > tx worker. Make sure the socket is not yet moved into SMC_CLOSED > state (for instance by a shutdown SHUT_RDWR call). > > Reported-by: syzbot+9

Re: [PATCH net-next] cnic: Explicitly initialize all reference counts to 0.

2019-08-05 Thread David Miller
From: Michael Chan Date: Fri, 2 Aug 2019 02:17:51 -0400 > The driver is relying on zero'ed allocated memory and does not > explicitly call atomic_set() to initialize the ref counts to 0. Add > these atomic_set() calls so that it will be more straight forward > to convert atomic ref counts to re

Re: [PATCH net-next] selftests: Add l2tp tests

2019-08-05 Thread David Miller
From: David Ahern Date: Thu, 1 Aug 2019 16:54:21 -0700 > From: David Ahern > > Add IPv4 and IPv6 l2tp tests. Current set is over IP and with > IPsec. > > Signed-off-by: David Ahern > --- > The ipsec tests expose a netdev refcount leak that I have not had > time to track down, but the tests t

Re: [PATCH net] gve: Fix case where desc_cnt and data_cnt can get out of sync

2019-08-05 Thread David Miller
From: Catherine Sullivan Date: Thu, 1 Aug 2019 16:07:31 -0700 > desc_cnt and data_cnt should always be equal. In the case of a dropped > packet desc_cnt was still getting updated (correctly), data_cnt > was not. To eliminate this bug and prevent it from recurring this > patch combines them into

Re: [PATCH net-next] ipv6: have a single rcu unlock point in __ip6_rt_update_pmtu

2019-08-05 Thread David Miller
From: David Ahern Date: Thu, 1 Aug 2019 15:18:08 -0700 > From: David Ahern > > Simplify the unlock path in __ip6_rt_update_pmtu by using a > single point where rcu_read_unlock is called. > > Signed-off-by: David Ahern Applied.

Re: [PATCH net] ipv6: Fix unbalanced rcu locking in rt6_update_exception_stamp_rt

2019-08-05 Thread David Miller
From: David Ahern Date: Thu, 1 Aug 2019 14:36:35 -0700 > From: David Ahern > > The nexthop path in rt6_update_exception_stamp_rt needs to call > rcu_read_unlock if it fails to find a fib6_nh match rather than > just returning. > > Fixes: e659ba31d806 ("ipv6: Handle all fib6_nh in a nexthop in

Re: [PATCH net 2/2] selftests/tls: add a litmus test for the socket reuse through shutdown

2019-08-05 Thread David Miller
From: Jakub Kicinski Date: Thu, 1 Aug 2019 14:36:02 -0700 > Make sure that shutdown never works, and at the same time document how > I tested to came to the conclusion that currently reuse is not possible. > > Signed-off-by: Jakub Kicinski Applied.

Re: [PATCH net 1/2] net/tls: partially revert fix transition through disconnect with close

2019-08-05 Thread David Miller
From: Jakub Kicinski Date: Thu, 1 Aug 2019 14:36:01 -0700 > Looks like we were slightly overzealous with the shutdown() > cleanup. Even though the sock->sk_state can reach CLOSED again, > socket->state will not got back to SS_UNCONNECTED once > connections is ESTABLISHED. Meaning we will see EIS

Re: [PATCH bpf-next 1/2] selftests/bpf: add loop test 4

2019-08-05 Thread Yonghong Song
On 8/5/19 12:45 PM, Andrii Nakryiko wrote: > On Sat, Aug 3, 2019 at 8:19 PM Alexei Starovoitov wrote: >> >> Add a test that returns a 'random' number between [0, 2^20) >> If state pruning is not working correctly for loop body the number of >> processed insns will be 2^20 * num_of_insns_in_loop_

[net] ixgbe: fix possible deadlock in ixgbe_service_task()

2019-08-05 Thread Jeff Kirsher
From: Taehee Yoo ixgbe_service_task() calls unregister_netdev() under rtnl_lock(). But unregister_netdev() internally calls rtnl_lock(). So deadlock would occur. Fixes: 59dd45d550c5 ("ixgbe: firmware recovery mode") Signed-off-by: Taehee Yoo Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

Re: [PATCH bpf-next 1/2] selftests/bpf: add loop test 4

2019-08-05 Thread Andrii Nakryiko
On Sat, Aug 3, 2019 at 8:19 PM Alexei Starovoitov wrote: > > Add a test that returns a 'random' number between [0, 2^20) > If state pruning is not working correctly for loop body the number of > processed insns will be 2^20 * num_of_insns_in_loop_body and the program > will be rejected. > > Signed

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-05 Thread Alexei Starovoitov
On Mon, Aug 05, 2019 at 10:23:10AM -0700, Andy Lutomirski wrote: > > I refreshed the branch again. I had a giant hole in my previous idea > that we could deprivilege program loading: some BPF functions need > privilege. Now I have a changelog comment to that effect and a patch > that sketches ou

Re: [PATCH iproute2-next] rdma: Add driver QP type string

2019-08-05 Thread David Ahern
On 8/4/19 2:07 AM, Gal Pressman wrote: > RDMA resource tracker now tracks driver QPs as well, add driver QP type > string to qp_types_to_str function. "now" means which kernel release? Leon: should this be in master or -next? > > Signed-off-by: Gal Pressman > --- > rdma/res.c | 6 -- > 1 f

Re: [PATCH] tools: bpftool: fix reading from /proc/config.gz

2019-08-05 Thread Jakub Kicinski
On Mon, 5 Aug 2019 08:29:36 -0700, Stanislav Fomichev wrote: > On 08/05, Peter Wu wrote: > > /proc/config has never existed as far as I can see, but /proc/config.gz > > is present on Arch Linux. Execute an external gunzip program to avoid > > linking to zlib and rework the option scanning code sinc

Re: [PATCH net 0/2] flow_offload hardware priority fixes

2019-08-05 Thread Jakub Kicinski
On Sat, 3 Aug 2019 09:08:54 +0200, Pablo Neira Ayuso wrote: > The idea is that every subsystem (ethtool, tc, nf) sets up/binds its > own flow_block object. And each flow_block object has its own priority > range space. So whatever priority the user specifies only applies to > the specific subsystem

[net-next v2 4/8] i40e: fix code comments

2019-08-05 Thread Jeff Kirsher
Found a code comment that needed TLC to correct their formatting. Signed-off-by: Jeff Kirsher Tested-by: Andrew Bowers --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b

[net-next v2 2/8] i40e: Log disable-fw-lldp flag change by ethtool

2019-08-05 Thread Jeff Kirsher
From: Slawomir Laba Add logging for disable-fw-lldp flag by ethtool. Added check for I40E_FLAG_DISABLE_FW_LLDP and logging state in dmesg. Without this commit there was no clear statement in dmesg about FW LLDP state in dmesg. Signed-off-by: Slawomir Laba Tested-by: Andrew Bowers Signed-off-by

[net-next v2 1/8] i40e: fix incorrect ethtool statistics veb and veb.tc_

2019-08-05 Thread Jeff Kirsher
From: Dmitrii Golovanov This patch fixes missing call of i40e_update_veb_stats() in function i40e_get_ethtool_stats() to update stats data of VEB and VEB TC counters before they are written into ethtool buffer. Before the patch ethtool counters may fell behind interface counters. Signed-off-by:

[net-next v2 0/8][pull request] 40GbE Intel Wired LAN Driver Updates 2019-08-05

2019-08-05 Thread Jeff Kirsher
This series contains updates to i40e driver only. Dmitrii adds missing statistic counters for VEB and VEB TC's. Slawomir adds support for logging the "Disable Firmware LLDP" flag option and its current status. Jake fixes an issue where VF's being notified of their link status before their queues

[net-next v2 5/8] i40e: Update visual effect for advertised FEC mode.

2019-08-05 Thread Jeff Kirsher
From: Czeslaw Zagorski Updates visual effect for advertised mode after setting desired mode. The mode appears in advertised FEC mode correctly, when ethtool interface command is called. Without this commit advertised FEC is displayed regardless of the settings as "None BaseR RS". Signed-off-by:

[net-next v2 3/8] i40e: don't report link up for a VF who hasn't enabled queues

2019-08-05 Thread Jeff Kirsher
From: Jacob Keller Commit d3d657a90850 ("i40e: update VFs of link state after GET_VF_RESOURCES") modified the PF driver to notify a VF of its link status immediately after it requests resources. This was intended to fix reporting on VF drivers, so that they would properly report link status. Ho

[net-next v2 6/8] i40e: Log info when PF is entering and leaving Allmulti mode.

2019-08-05 Thread Jeff Kirsher
From: Czeslaw Zagorski Add log when PF is entering and leaving allmulti mode. The change of PF state is visible in dmesg now. Without this commit, entering and leaving allmulti mode is not logged in dmesg. Signed-off-by: Czeslaw Zagorski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --

[net-next v2 7/8] i40e: verify string count matches even on early return

2019-08-05 Thread Jeff Kirsher
From: Jacob Keller Similar to i40e_get_ethtool_stats, add a goto to verify that the data pointer for the strings lines up with the expected stats count. This helps ensure that bugs are not introduced when adding stats. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Ki

[net-next v2 8/8] i40e: Remove unicast log when VF is leaving multicast mode.

2019-08-05 Thread Jeff Kirsher
From: Czeslaw Zagorski This patch removes unicast log when VF is leaving multicast mode. Added check of vf->vf_states & I40E_VF_STATE_MC_PROMISC/I40E_VF_STATE_UC_PROMISC. Without this commit, leaving multicast mode logs "unset unicast" in dmsg. Signed-off-by: Czeslaw Zagorski Tested-by: Andrew

Re: [patch iproute2] devlink: finish queue.h to list.h transition

2019-08-05 Thread Stephen Hemminger
On Mon, 5 Aug 2019 11:56:56 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Loose the "q" from the names and name the structure fields in the same > way rest of the code does. Also, fix list_add arg order which leads > to segfault. > > Fixes: 33267017faf1 ("iproute2: devlink: port from sys/que

Re: [PATCH mlx5-next v1 1/3] IB/mlx5: Query ODP capabilities for DC

2019-08-05 Thread Saeed Mahameed
On Sun, 2019-08-04 at 13:00 +0300, Leon Romanovsky wrote: > From: Michael Guralnik > > Set current capabilities of ODP for DC to max capabilities and cache > them in mlx5_ib. > > Signed-off-by: Michael Guralnik > Reviewed-by: Moni Shoua > Signed-off-by: Leon Romanovsky > --- > drivers/infini

Re: [PATCH 1/2] net: mvpp2: implement RXAUI support

2019-08-05 Thread David Miller
From: Matt Pelland Date: Thu, 1 Aug 2019 16:45:22 -0400 > +static void mvpp22_gop_init_rxaui(struct mvpp2_port *port) > +{ > + struct mvpp2 *priv = port->priv; > + void __iomem *xpcs = priv->iface_base + MVPP22_XPCS_BASE(port->gop_id); > + u32 val; Reverse christmas tree please.

Re: [net v1 PATCH 0/4] net: fix regressions for generic-XDP

2019-08-05 Thread David Miller
From: Jesper Dangaard Brouer Date: Thu, 01 Aug 2019 20:00:11 +0200 > Thanks to Brandon Cazander, who wrote a very detailed bug report that > even used perf probe's on xdp-newbies mailing list, we discovered that > generic-XDP contains some regressions when using bpf_xdp_adjust_head(). > > First

Re: [PATCH] net: sched: use temporary variable for actions indexes

2019-08-05 Thread David Miller
From: dmitro...@mellanox.com Date: Thu, 1 Aug 2019 13:02:51 + > From: Dmytro Linkin > > Currently init call of all actions (except ipt) init their 'parm' > structure as a direct pointer to nla data in skb. This leads to race > condition when some of the filter actions were initialized succe

Re: [pull request][net-next 00/12] Mellanox, mlx5 updates 2019-08-01

2019-08-05 Thread David Miller
From: Saeed Mahameed Date: Thu, 1 Aug 2019 19:56:50 + > This series provides misc updates to mlx5 driver. > For more information please see tag log below. > > Please pull and let me know if there is any problem. > > Please note that the series starts with a merge of mlx5-next branch, > to r

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-05 Thread Andy Lutomirski
On Mon, Aug 5, 2019 at 12:37 AM Song Liu wrote: > > Hi Andy, > > > > > # mount -t bpf bpf /sys/fs/bpf > > # cd /sys/fs/bpf > > # mkdir luto > > # chown luto: luto > > # setpriv --euid=1000 --ruid=1000 bash > > $ pwd > > /sys/fs/bpf > > bash-5.0$ ls -l > > total 0 > > drwxr-xr-x 2 luto luto 0 Aug

Re: [PATCH bpf-next 2/2] selftests/bpf: add loop test 5

2019-08-05 Thread Alexei Starovoitov
On Sun, Aug 04, 2019 at 05:45:23AM +, Yonghong Song wrote: > > > On 8/2/19 4:33 PM, Alexei Starovoitov wrote: > > Add a test with multiple exit conditions. > > It's not an infinite loop only when the verifier can properly track > > all math on variable 'i' through all possible ways of executi

Re: [PATCH bpf-next 1/2] selftests/bpf: add loop test 4

2019-08-05 Thread Alexei Starovoitov
On Sun, Aug 04, 2019 at 05:29:42AM +, Yonghong Song wrote: > > > On 8/2/19 4:33 PM, Alexei Starovoitov wrote: > > Add a test that returns a 'random' number between [0, 2^20) > > If state pruning is not working correctly for loop body the number of > > processed insns will be 2^20 * num_of_ins

[PATCH bpf-next v3 0/3] selftests/bpf: switch test_progs back to stdio

2019-08-05 Thread Stanislav Fomichev
I was looking into converting test_sockops* to test_progs framework and that requires using cgroup_helpers.c which rely on stdio/stderr. Let's use open_memstream to override stdout into buffer during subtests instead of custom test_{v,}printf wrappers. That lets us continue to use stdio in the subt

[PATCH bpf-next v3 3/3] selftests/bpf: test_progs: drop extra trailing tab

2019-08-05 Thread Stanislav Fomichev
Small (un)related cleanup. Cc: Andrii Nakryiko Acked-by: Andrii Nakryiko Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_progs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/te

[PATCH] xen/netback: Reset nr_frags before freeing skb

2019-08-05 Thread Ross Lagerwall
At this point nr_frags has been incremented but the frag does not yet have a page assigned so freeing the skb results in a crash. Reset nr_frags before freeing the skb to prevent this. Signed-off-by: Ross Lagerwall --- drivers/net/xen-netback/netback.c | 2 ++ 1 file changed, 2 insertions(+) di

[PATCH bpf-next v3 1/3] selftests/bpf: test_progs: switch to open_memstream

2019-08-05 Thread Stanislav Fomichev
Use open_memstream to override stdout during test execution. The copy of the original stdout is held in env.stdout and used to print subtest info and dump failed log. test_{v,}printf are now simple wrappers around stdout and will be removed in the next patch. v3: * don't do strlen over log_buf, l

[PATCH bpf-next v3 2/3] selftests/bpf: test_progs: test__printf -> printf

2019-08-05 Thread Stanislav Fomichev
Now that test__printf is a simple wraper around printf, let's drop it (and test__vprintf as well). Cc: Andrii Nakryiko Acked-by: Andrii Nakryiko Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/bpf_verif_scale.c | 4 ++-- .../testing/selftests/bpf/prog_tests/l4lb_all.c |

Re: [PATCH] tools: bpftool: fix reading from /proc/config.gz

2019-08-05 Thread Stanislav Fomichev
On 08/05, Peter Wu wrote: > /proc/config has never existed as far as I can see, but /proc/config.gz > is present on Arch Linux. Execute an external gunzip program to avoid > linking to zlib and rework the option scanning code since a pipe is not > seekable. This also fixes a file handle leak on som

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-05 Thread Jiri Pirko
Mon, Aug 05, 2019 at 04:51:22PM CEST, dsah...@gmail.com wrote: >On 8/5/19 8:49 AM, Jiri Pirko wrote: >>> Your commit 5fc494225c1eb81309cc4c91f183cd30e4edb674 changed that from a >>> per-namepace accounting to all namespaces managed by a single devlink >>> instance in init_net - which is completely

Re: [PATCH bpf-next 1/3] selftests/bpf: test_progs: switch to open_memstream

2019-08-05 Thread Stanislav Fomichev
On 08/02, Andrii Nakryiko wrote: > On Fri, Aug 2, 2019 at 1:14 PM Stanislav Fomichev wrote: > > > > On 08/02, Andrii Nakryiko wrote: > > > On 8/2/19 10:17 AM, Stanislav Fomichev wrote: > > > > Use open_memstream to override stdout during test execution. > > > > The copy of the original stdout is h

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-05 Thread Vivien Didelot
Hi Michal! On Mon, 5 Aug 2019 10:04:48 +0200, Michal Kubecek wrote: > On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > > Usually kernel drivers set the regs->len value to the same length as > > info->regdump_len, which was used for the allocation. In case where > > regs->len is s

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-05 Thread David Ahern
On 8/5/19 8:49 AM, Jiri Pirko wrote: >> Your commit 5fc494225c1eb81309cc4c91f183cd30e4edb674 changed that from a >> per-namepace accounting to all namespaces managed by a single devlink >> instance in init_net - which is completely wrong. > No. Not "all namespaces". Only the one where the devlink i

Re: [PATCH 06/16] net: phy: adin: support PHY mode converters

2019-08-05 Thread Andrew Lunn
On Mon, Aug 05, 2019 at 07:54:43PM +0300, Alexandru Ardelean wrote: > Sometimes, the connection between a MAC and PHY is done via a > mode/interface converter. An example is a GMII-to-RGMII converter, which > would mean that the MAC operates in GMII mode while the PHY operates in > RGMII. In this c

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-05 Thread Jiri Pirko
Mon, Aug 05, 2019 at 04:10:39PM CEST, dsah...@gmail.com wrote: >On 8/4/19 11:54 PM, Jiri Pirko wrote: >> There was implicit devlink instance creation per-namespace. No relation >> any actual device. It was wrong and misuse of devlink. >> >> Now you have 1 devlink instance per 1 device as it should

RE: [PATCH net-next v3 2/2] qed: Add driver API for flashing the config attributes.

2019-08-05 Thread Ariel Elior
> From: Sudarsana Reddy Kalluru > Sent: Tuesday, July 30, 2019 6:36 AM > To: David Miller > > > -Original Message- > > From: David Miller > > Sent: Monday, July 29, 2019 11:34 PM > > To: Sudarsana Reddy Kalluru > > Cc: netdev@vger.kernel.org; Michal Kalderon ; > > Ariel Elior > > Subje

Re: [patch net-next v2 1/3] net: devlink: allow to change namespaces

2019-08-05 Thread David Ahern
On 8/4/19 11:54 PM, Jiri Pirko wrote: > There was implicit devlink instance creation per-namespace. No relation > any actual device. It was wrong and misuse of devlink. > > Now you have 1 devlink instance per 1 device as it should be. Also, you > have fib resource control for this device, also as

Re: [drop_monitor] 98ffbd6cd2: will-it-scale.per_thread_ops -17.5% regression

2019-08-05 Thread Ido Schimmel
On Mon, Jul 29, 2019 at 05:52:13PM +0800, kernel test robot wrote: > Greeting, > > FYI, we noticed a -17.5% regression of will-it-scale.per_thread_ops due to > commit: > > > commit: 98ffbd6cd2b25fc6cbb0695e03b4fd43b5e116e6 ("[RFC PATCH net-next 10/12] > drop_monitor: Add packet alert mode") >

Re: [PATCH net 1/2] net: sched: police: allow accessing police->params with rtnl

2019-08-05 Thread Pieter Jansen van Vuuren
On 2019/08/03 14:36, Vlad Buslov wrote: > Recently implemented support for police action in flow_offload infra leads > to following rcu usage warning: > > [ 1925.881092] = > [ 1925.881094] WARNING: suspicious RCU usage > [ 1925.881098] 5.3.0-rc1+ #574 Not tainted > [ 19

Re: [PATCH net 2/2] net: sched: sample: allow accessing psample_group with rtnl

2019-08-05 Thread Pieter Jansen van Vuuren
On 2019/08/03 14:36, Vlad Buslov wrote: > Recently implemented support for sample action in flow_offload infra leads > to following rcu usage warning: > > [ 1938.234856] = > [ 1938.234858] WARNING: suspicious RCU usage > [ 1938.234863] 5.3.0-rc1+ #574 Not tainted > [ 19

Re: [PATCH] tools: bpftool: fix reading from /proc/config.gz

2019-08-05 Thread Quentin Monnet
Hi Peter, Thanks for looking into this (and for the fixes)! Some comments below. 2019-08-05 01:15 UTC+0100 ~ Peter Wu > /proc/config has never existed as far as I can see, but /proc/config.gz As far as I understood (from examining Cilium [0]), /proc/config _is_ used by some distributions, such

enquiry.

2019-08-05 Thread purchase department
Dear Sir We are interested to Purchase your product, i got your contact information from two of our customers. Please contact us with the following below:- - Your minimum order quantity. - Your FOB Prices and FOB Port. - Your estimated delivery time. Please fine attached company details and

[patch iproute2] devlink: finish queue.h to list.h transition

2019-08-05 Thread Jiri Pirko
From: Jiri Pirko Loose the "q" from the names and name the structure fields in the same way rest of the code does. Also, fix list_add arg order which leads to segfault. Fixes: 33267017faf1 ("iproute2: devlink: port from sys/queue.h to list.h") Signed-off-by: Jiri Pirko --- devlink/devlink.c |

Re: [PATCH net-next 1/3,v2] net: sched: use major priority number as hardware priority

2019-08-05 Thread Jiri Pirko
Fri, Aug 02, 2019 at 03:28:44PM CEST, pa...@netfilter.org wrote: >tc transparently maps the software priority number to hardware. Update >it to pass the major priority which is what most drivers expect. Update >drivers too so they do not need to lshift the priority field of the >flow_cls_common_off

Re: [PATCH ethtool] ethtool: dump nested registers

2019-08-05 Thread Michal Kubecek
On Fri, Aug 02, 2019 at 03:34:54PM -0400, Vivien Didelot wrote: > Usually kernel drivers set the regs->len value to the same length as > info->regdump_len, which was used for the allocation. In case where > regs->len is smaller than the allocated info->regdump_len length, > we may assume that the d

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-05 Thread Song Liu
Hi Andy, > On Aug 4, 2019, at 10:47 PM, Andy Lutomirski wrote: > > On Sun, Aug 4, 2019 at 5:08 PM Andy Lutomirski wrote: >> >> On Sun, Aug 4, 2019 at 3:16 PM Andy Lutomirski wrote: >>> >>> On Fri, Aug 2, 2019 at 12:22 AM Song Liu wrote: Hi Andy, > I actually agree CAP_