Re: [PATCH bpf-next 02/10] libbpf: implement BPF CO-RE offset relocation algorithm

2019-07-26 Thread Andrii Nakryiko
On Thu, Jul 25, 2019 at 4:18 PM Alexei Starovoitov wrote: > > On Wed, Jul 24, 2019 at 12:27:34PM -0700, Andrii Nakryiko wrote: > > This patch implements the core logic for BPF CO-RE offsets relocations. > > All the details are described in code comments. > > > > Signed-off-by: Andrii Nakryiko > >

Re: [PATCH bpf-next 02/10] libbpf: implement BPF CO-RE offset relocation algorithm

2019-07-26 Thread Andrii Nakryiko
On Thu, Jul 25, 2019 at 12:32 PM Song Liu wrote: > > > > > On Jul 24, 2019, at 12:27 PM, Andrii Nakryiko wrote: > > > > This patch implements the core logic for BPF CO-RE offsets relocations. > > All the details are described in code comments. > > Some description in the change log is still usefu

Re: [PATCH bpf-next 01/10] libbpf: add .BTF.ext offset relocation section loading

2019-07-26 Thread Andrii Nakryiko
On Wed, Jul 24, 2019 at 10:20 PM Song Liu wrote: > > > > > On Jul 24, 2019, at 5:37 PM, Andrii Nakryiko > > wrote: > > > > On Wed, Jul 24, 2019 at 5:00 PM Song Liu wrote: > >> > >> > >> > >>> On Jul 24, 2019, at 12:27 PM, Andrii Nakryiko wrote: > >>> > >>> Add support for BPF CO-RE offset relo

Zdravstvujte! Vas interesuyut klientskie bazy dannyh?

2019-07-26 Thread netdev
Zdravstvujte! Vas interesuyut klientskie bazy dannyh?

Re: [PATCH bpf-next v5 0/6] xdp: Add devmap_hash map type

2019-07-26 Thread Alexei Starovoitov
On Fri, Jul 26, 2019 at 9:06 AM Toke Høiland-Jørgensen wrote: > > This series adds a new map type, devmap_hash, that works like the existing > devmap type, but using a hash-based indexing scheme. This is useful for the > use > case where a devmap is indexed by ifindex (for instance for use with t

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-26 Thread Alexei Starovoitov
On Fri, Jul 26, 2019 at 2:19 PM Sedat Dilek wrote: > > On Fri, Jul 26, 2019 at 11:10 PM Yonghong Song wrote: > > > > > > > > On 7/26/19 2:02 PM, Sedat Dilek wrote: > > > On Fri, Jul 26, 2019 at 10:38 PM Sedat Dilek > > > wrote: > > >> > > >> Hi Yonghong Song, > > >> > > >> On Fri, Jul 26, 2019

[PATCH] tcp: add new tcp_mtu_probe_floor sysctl

2019-07-26 Thread Josh Hunt
The current implementation of TCP MTU probing can considerably underestimate the MTU on lossy connections allowing the MSS to get down to 48. We have found that in almost all of these cases on our networks these paths can handle much larger MTUs meaning the connections are being artificially limite

Re: [PATCH v2] net: dsa: qca8k: enable port flow control

2019-07-26 Thread xiaofeis
On 2019-07-26 21:29, Andrew Lunn wrote: I didn't compile it on this tree, same code is just compiled and tested on kernel v4.14. For kernel development work, v4.14 is dead. It died 12th November 2017. It gets backports of bug fixes, but kernel developers otherwise don't touch it. We are work

Re: [PATCH net-next v3 1/3] flow_offload: move tc indirect block to flow offload

2019-07-26 Thread Jakub Kicinski
On Fri, 26 Jul 2019 21:34:05 +0800, we...@ucloud.cn wrote: > From: wenxu > > move tc indirect block to flow_offload and rename > it to flow indirect block.The nf_tables can use the > indr block architecture. > > Signed-off-by: wenxu > diff --git a/include/net/flow_offload.h b/include/net/flow_

Re: [PATCH net-next v3 2/3] flow_offload: support get tcf block immediately

2019-07-26 Thread Jakub Kicinski
On Fri, 26 Jul 2019 21:34:06 +0800, we...@ucloud.cn wrote: > From: wenxu > > Because the new flow-indr-block can't get the tcf_block > directly. > It provide a callback to find the tcf block immediately > when the device register and contain a ingress block. > > Signed-off-by: wenxu Please CC

Re: [PATCH] iplink: document 'change' option to ip link

2019-07-26 Thread Matteo Croce
On Sat, Jul 27, 2019 at 12:00 AM Stephen Hemminger wrote: > > Add the command alias "change" to man page. > Don't show it on usage, since it is not commonly used. > > Reported-off-by: Matteo Croce > Signed-off-by: Stephen Hemminger > --- > man/man8/ip-link.8.in | 5 + > 1 file changed, 5 in

Re: [PATCH bpf-next 6/9] selftests/bpf: abstract away test log output

2019-07-26 Thread Alexei Starovoitov
On Fri, Jul 26, 2019 at 03:26:52PM -0700, Stanislav Fomichev wrote: > On 07/26, Andrii Nakryiko wrote: > > On Fri, Jul 26, 2019 at 2:31 PM Stanislav Fomichev wrote: > > > > > > On 07/26, Andrii Nakryiko wrote: > > > > This patch changes how test output is printed out. By default, if test > > > > h

Re: [PATCH bpf-next 4/9] libbpf: add libbpf_swap_print to get previous print func

2019-07-26 Thread Alexei Starovoitov
On Fri, Jul 26, 2019 at 02:47:28PM -0700, Andrii Nakryiko wrote: > On Fri, Jul 26, 2019 at 2:28 PM Stanislav Fomichev wrote: > > > > On 07/26, Andrii Nakryiko wrote: > > > libbpf_swap_print allows to restore previously set print function. > > > This is useful when running many independent test wit

Re: [PATCH bpf] libbpf: fix erroneous multi-closing of BTF FD

2019-07-26 Thread Alexei Starovoitov
On Fri, Jul 26, 2019 at 2:25 PM Andrii Nakryiko wrote: > > Libbpf stores associated BTF FD per each instance of bpf_program. When > program is unloaded, that FD is closed. This is wrong, because leads to > a race and possibly closing of unrelated files, if application > simultaneously opens new fi

Re: [PATCH v2 bpf] libbpf: fix missing __WORDSIZE definition

2019-07-26 Thread Arnaldo Carvalho de Melo
On July 26, 2019 8:01:10 PM GMT-03:00, Andrii Nakryiko wrote: >On Fri, Jul 26, 2019 at 1:49 PM Arnaldo Carvalho de Melo > wrote: >> >> Em Thu, Jul 18, 2019 at 10:30:21AM -0700, Andrii Nakryiko escreveu: >> > hashmap.h depends on __WORDSIZE being defined. It is defined by >> > glibc/musl in differ

Re: [PATCH bpf-next 2/6] bpf: add BPF_MAP_DUMP command to dump more than one entry per call

2019-07-26 Thread Jakub Kicinski
On Fri, 26 Jul 2019 16:36:19 -0700, Brian Vazquez wrote: > > In bcc, we have many instances like this: > > getting all (key value) pairs, do some analysis and output, > > delete all keys > > > > The implementation typically like > > /* to get all (key, value) pairs */ > > while(bpf_

Re: [PATCH bpf-next 2/6] bpf: add BPF_MAP_DUMP command to dump more than one entry per call

2019-07-26 Thread Brian Vazquez
On Thu, Jul 25, 2019 at 11:10 PM Yonghong Song wrote: > > > > On 7/25/19 6:47 PM, Alexei Starovoitov wrote: > > On Thu, Jul 25, 2019 at 6:24 PM Brian Vazquez > > wrote: > >> > >> On Thu, Jul 25, 2019 at 4:54 PM Alexei Starovoitov > >> wrote: > >>> > >>> On Thu, Jul 25, 2019 at 04:25:53PM -0700,

Re: [PATCH bpf-next 06/10] selftests/bpf: add CO-RE relocs array tests

2019-07-26 Thread Andrii Nakryiko
On Thu, Jul 25, 2019 at 4:26 PM Alexei Starovoitov wrote: > > On Wed, Jul 24, 2019 at 12:27:38PM -0700, Andrii Nakryiko wrote: > > Add tests for various array handling/relocation scenarios. > > > > Signed-off-by: Andrii Nakryiko > ... > > + > > +#define CORE_READ(dst, src) \ > > + bpf_probe_r

Re: [PATCH v2 bpf] libbpf: fix missing __WORDSIZE definition

2019-07-26 Thread Andrii Nakryiko
On Fri, Jul 26, 2019 at 1:49 PM Arnaldo Carvalho de Melo wrote: > > Em Thu, Jul 18, 2019 at 10:30:21AM -0700, Andrii Nakryiko escreveu: > > hashmap.h depends on __WORDSIZE being defined. It is defined by > > glibc/musl in different headers. It's an explicit goal for musl to be > > "non-detectable"

Re: [PATCH net-next v2] mlx4/en_netdev: allow offloading VXLAN over VLAN

2019-07-26 Thread Saeed Mahameed
On Fri, 2019-07-26 at 20:18 +0200, Davide Caratti wrote: > ConnectX-3 Pro can offload transmission of VLAN packets with VXLAN > inside: > enable tunnel offloads in dev->vlan_features, like it's done with > other > NIC drivers (e.g. be2net and ixgbe). > > It's no more necessary to change dev->hw_en

Re: [PATCH bpf-next 6/9] selftests/bpf: abstract away test log output

2019-07-26 Thread Stanislav Fomichev
On 07/26, Andrii Nakryiko wrote: > On Fri, Jul 26, 2019 at 2:31 PM Stanislav Fomichev wrote: > > > > On 07/26, Andrii Nakryiko wrote: > > > This patch changes how test output is printed out. By default, if test > > > had no errors, the only output will be a single line with test number, > > > name

[PATCH] gigaset: stop maintaining seperately

2019-07-26 Thread Paul Bolle
The Dutch consumer grade ISDN network will be shut down on September 1, 2019. This means I'll be converted to some sort of VOIP shortly. At that point it would be unwise to try to maintain the gigaset driver, even for odd fixes as I do. So I'll stop maintaining it as a seperate driver and bump supp

Re: [PATCH] iplink_can: fix format output of clock with flag -details

2019-07-26 Thread Stephen Hemminger
On Fri, 26 Jul 2019 15:06:09 +0200 Antonio Borneo wrote: > The command > ip -details link show can0 > prints in the last line the value of the clock frequency attached > to the name of the following value "numtxqueues", e.g. > clock 4950numtxqueues 1 numrxqueues 1 gso_max_size >

Re: [PATCH bpf-next 3/9] selftests/bpf: add test selectors by number and name to test_progs

2019-07-26 Thread Stanislav Fomichev
On 07/26, Andrii Nakryiko wrote: > On Fri, Jul 26, 2019 at 2:25 PM Stanislav Fomichev wrote: > > > > On 07/26, Andrii Nakryiko wrote: > > > Add ability to specify either test number or test name substring to > > > narrow down a set of test to run. > > > > > > Usage: > > > sudo ./test_progs -n 1 >

Re: [PATCH v2] iproute2: devlink: port from sys/queue.h to list.h

2019-07-26 Thread Stephen Hemminger
On Fri, 26 Jul 2019 22:01:05 +0100 Sergei Trofimovich wrote: > sys/queue.h does not exist on linux-musl targets and fails build as: > > devlink.c:28:10: fatal error: sys/queue.h: No such file or directory >28 | #include > | ^ > > The change ports to l

Re: [PATCH bpf-next 1/9] selftests/bpf: prevent headers to be compiled as C code

2019-07-26 Thread Stanislav Fomichev
On 07/26, Andrii Nakryiko wrote: > On Fri, Jul 26, 2019 at 2:21 PM Stanislav Fomichev wrote: > > > > On 07/26, Andrii Nakryiko wrote: > > > Apprently listing header as a normal dependency for a binary output > > > makes it go through compilation as if it was C code. This currently > > > works with

[PATCH] iplink: document 'change' option to ip link

2019-07-26 Thread Stephen Hemminger
Add the command alias "change" to man page. Don't show it on usage, since it is not commonly used. Reported-off-by: Matteo Croce Signed-off-by: Stephen Hemminger --- man/man8/ip-link.8.in | 5 + 1 file changed, 5 insertions(+) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in inde

Re: [PATCH bpf-next 6/9] selftests/bpf: abstract away test log output

2019-07-26 Thread Andrii Nakryiko
On Fri, Jul 26, 2019 at 2:31 PM Stanislav Fomichev wrote: > > On 07/26, Andrii Nakryiko wrote: > > This patch changes how test output is printed out. By default, if test > > had no errors, the only output will be a single line with test number, > > name, and verdict at the end, e.g.: > > > > #31

Re: [PATCH bpf-next 4/9] libbpf: add libbpf_swap_print to get previous print func

2019-07-26 Thread Andrii Nakryiko
On Fri, Jul 26, 2019 at 2:28 PM Stanislav Fomichev wrote: > > On 07/26, Andrii Nakryiko wrote: > > libbpf_swap_print allows to restore previously set print function. > > This is useful when running many independent test with one default print > > function, but overriding log verbosity for particul

Re: [PATCH bpf-next 3/9] selftests/bpf: add test selectors by number and name to test_progs

2019-07-26 Thread Andrii Nakryiko
On Fri, Jul 26, 2019 at 2:25 PM Stanislav Fomichev wrote: > > On 07/26, Andrii Nakryiko wrote: > > Add ability to specify either test number or test name substring to > > narrow down a set of test to run. > > > > Usage: > > sudo ./test_progs -n 1 > > sudo ./test_progs -t attach_probe > > > > Signe

Re: [PATCH bpf-next 1/9] selftests/bpf: prevent headers to be compiled as C code

2019-07-26 Thread Andrii Nakryiko
On Fri, Jul 26, 2019 at 2:21 PM Stanislav Fomichev wrote: > > On 07/26, Andrii Nakryiko wrote: > > Apprently listing header as a normal dependency for a binary output > > makes it go through compilation as if it was C code. This currently > > works without a problem, but in subsequent commits caus

Re: [net 7/9] net/mlx5e: kTLS, Call WARN_ONCE on netdev mismatch

2019-07-26 Thread Saeed Mahameed
On Thu, 2019-07-25 at 13:49 -0700, Jakub Kicinski wrote: > On Thu, 25 Jul 2019 20:36:48 +, Saeed Mahameed wrote: > > From: Tariq Toukan > > > > A netdev mismatch in the processed TLS SKB should not occur, > > and indicates a kernel bug. > > Add WARN_ONCE to spot such cases. > > > > Fixes: d2

Re: [PATCH] sis900: add support for ethtool's EEPROM dump

2019-07-26 Thread Saeed Mahameed
On Thu, 2019-07-25 at 21:48 +0200, Sergej Benilov wrote: > Implement ethtool's EEPROM dump command (ethtool -e|--eeprom-dump). > > Thx to Andrew Lunn for comments. > > Signed-off-by: Sergej Benilov > --- > drivers/net/ethernet/sis/sis900.c | 68 > +++ > 1 file change

Re: [patch iproute2 2/2] tc: batch: fix line/line_next processing in batch

2019-07-26 Thread Stephen Hemminger
On Tue, 23 Jul 2019 13:25:38 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > When getcmdline fails, there is no valid string in line_next. > So change the flow and don't process it. Alongside with that, > free the previous line buffer and prevent memory leak. > > Fixes: 485d0c6001c4 ("tc: Add b

Re: [pull request][net 0/9] Mellanox, mlx5 fixes 2019-07-25

2019-07-26 Thread David Miller
From: Saeed Mahameed Date: Thu, 25 Jul 2019 20:36:32 + > This series introduces some fixes to mlx5 driver. > > 1) Ariel is addressing an issue with enacp flow counter race condition > 2) Aya fixes ethtool speed handling > 3) Edward fixes modify_cq hw bits alignment > 4) Maor fixes RDMA_RX c

Re: [PATCH bpf-next 6/9] selftests/bpf: abstract away test log output

2019-07-26 Thread Stanislav Fomichev
On 07/26, Andrii Nakryiko wrote: > This patch changes how test output is printed out. By default, if test > had no errors, the only output will be a single line with test number, > name, and verdict at the end, e.g.: > > #31 xdp:OK > > If test had any errors, all log output captured during test

Re: phylink: flow control on fixed-link not working.

2019-07-26 Thread Russell King - ARM Linux admin
On Fri, Jul 19, 2019 at 07:52:26PM +, René van Dorst wrote: > Hi Russel, > > If I use this patch below: > > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c > index 5d0af041b8f9..a6aebaa14338 100644 > --- a/drivers/net/phy/phylink.c > +++ b/drivers/net/phy/phylink.c > @@ -21

Re: [PATCH bpf-next 4/9] libbpf: add libbpf_swap_print to get previous print func

2019-07-26 Thread Stanislav Fomichev
On 07/26, Andrii Nakryiko wrote: > libbpf_swap_print allows to restore previously set print function. > This is useful when running many independent test with one default print > function, but overriding log verbosity for particular subset of tests. Can we change the return type of libbpf_set_print

Re: [PATCH] sis900: add support for ethtool's EEPROM dump

2019-07-26 Thread David Miller
From: Sergej Benilov Date: Thu, 25 Jul 2019 21:48:06 +0200 > Implement ethtool's EEPROM dump command (ethtool -e|--eeprom-dump). > > Thx to Andrew Lunn for comments. > > Signed-off-by: Sergej Benilov Applied to net-next.

Re: [PATCH bpf-next 3/9] selftests/bpf: add test selectors by number and name to test_progs

2019-07-26 Thread Stanislav Fomichev
On 07/26, Andrii Nakryiko wrote: > Add ability to specify either test number or test name substring to > narrow down a set of test to run. > > Usage: > sudo ./test_progs -n 1 > sudo ./test_progs -t attach_probe > > Signed-off-by: Andrii Nakryiko > --- > tools/testing/selftests/bpf/test_progs.c

[PATCH bpf] libbpf: fix erroneous multi-closing of BTF FD

2019-07-26 Thread Andrii Nakryiko
Libbpf stores associated BTF FD per each instance of bpf_program. When program is unloaded, that FD is closed. This is wrong, because leads to a race and possibly closing of unrelated files, if application simultaneously opens new files while bpf_programs are unloaded. It's also unnecessary, becau

Re: [PATCH v3 11/14] NFC: nxp-nci: Remove unused macro pr_fmt()

2019-07-26 Thread David Miller
From: Andy Shevchenko Date: Thu, 25 Jul 2019 22:35:08 +0300 > The macro had never been used. > > Signed-off-by: Andy Shevchenko > Tested-by: Sedat Dilek ... > @@ -12,8 +12,6 @@ > * Copyright (C) 2012 Intel Corporation. All rights reserved. > */ > > -#define pr_fmt(fmt) KBUILD_MODNAME "

Re: [PATCH bpf-next 1/9] selftests/bpf: prevent headers to be compiled as C code

2019-07-26 Thread Stanislav Fomichev
On 07/26, Andrii Nakryiko wrote: > Apprently listing header as a normal dependency for a binary output > makes it go through compilation as if it was C code. This currently > works without a problem, but in subsequent commits causes problems for > differently generated test.h for test_progs. Markin

Re: [PATCH net] net: qualcomm: rmnet: Fix incorrect UL checksum offload logic

2019-07-26 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Thu, 25 Jul 2019 12:07:12 -0600 > The udp_ip4_ind bit is set only for IPv4 UDP non-fragmented packets > so that the hardware can flip the checksum to 0x if the computed > checksum is 0 per RFC768. > > However, this bit had to be set for IPv6 UDP non

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-26 Thread Sedat Dilek
On Fri, Jul 26, 2019 at 11:10 PM Yonghong Song wrote: > > > > On 7/26/19 2:02 PM, Sedat Dilek wrote: > > On Fri, Jul 26, 2019 at 10:38 PM Sedat Dilek wrote: > >> > >> Hi Yonghong Song, > >> > >> On Fri, Jul 26, 2019 at 5:45 PM Yonghong Song wrote: > >>> > >>> > >>> > >>> On 7/26/19 1:26 AM, Seda

Re: [PATCH net] ocelot: Cancel delayed work before wq destruction

2019-07-26 Thread David Miller
From: Claudiu Manoil Date: Thu, 25 Jul 2019 16:33:18 +0300 > Make sure the delayed work for stats update is not pending before > wq destruction. > This fixes the module unload path. > The issue is there since day 1. > > Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") > > Si

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-26 Thread Yonghong Song
On 7/26/19 2:02 PM, Sedat Dilek wrote: > On Fri, Jul 26, 2019 at 10:38 PM Sedat Dilek wrote: >> >> Hi Yonghong Song, >> >> On Fri, Jul 26, 2019 at 5:45 PM Yonghong Song wrote: >>> >>> >>> >>> On 7/26/19 1:26 AM, Sedat Dilek wrote: Hi, I have opened a new issue in the ClangBuiltLi

Re: [PATCH] Build fixes for skb_frag_size conversion

2019-07-26 Thread David Miller
From: Arnd Bergmann Date: Thu, 25 Jul 2019 13:08:18 +0200 > On Wed, Jul 24, 2019 at 1:37 PM Matthew Wilcox wrote: >> >> From: "Matthew Wilcox (Oracle)" >> >> I missed a few places. One is in some ifdeffed code which will probably >> never be re-enabled; the others are in drivers which can't cu

Re: [PATCH net-next 2/2] mlx4/en_netdev: call notifiers when hw_enc_features change

2019-07-26 Thread Saeed Mahameed
On Fri, 2019-07-26 at 12:39 +0200, Davide Caratti wrote: > On Thu, 2019-07-25 at 21:27 +, Saeed Mahameed wrote: > > On Thu, 2019-07-25 at 14:25 +0200, Davide Caratti wrote: > > > On Wed, 2019-07-24 at 20:47 +, Saeed Mahameed wrote: > > > > On Wed, 2019-07-24 at 16:02 +0200, Davide Caratti w

Re: [PATCH net-next 3/3] net: dsa: mt7530: Add support for port 5

2019-07-26 Thread David Miller
From: René van Dorst Date: Wed, 24 Jul 2019 21:25:49 +0200 > @@ -1167,6 +1236,10 @@ mt7530_setup(struct dsa_switch *ds) > u32 id, val; > struct device_node *dn; > struct mt7530_dummy_poll p; > + phy_interface_t interface; > + struct device_node *mac_np; > + struct de

Re: [PATCH] qed: RDMA - Fix the hw_ver returned in device attributes

2019-07-26 Thread David Miller
From: Michal Kalderon Date: Thu, 25 Jul 2019 13:59:55 +0300 > The hw_ver field was initialized to zero. Return the chip revision. > This is relevant for rdma driver. > > Signed-off-by: Michal Kalderon Applied.

Re: [PATCH] net: tipc: Fix a possible null-pointer dereference in tipc_publ_purge()

2019-07-26 Thread David Miller
From: Jia-Ju Bai Date: Thu, 25 Jul 2019 17:20:21 +0800 > @@ -223,7 +223,8 @@ static void tipc_publ_purge(struct net *net, struct > publication *publ, u32 addr) > publ->key); > } > > - kfree_rcu(p, rcu); > + if (p) > + kfree_rcu(p, rcu); Please fi

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-26 Thread Yonghong Song
On 7/26/19 1:38 PM, Sedat Dilek wrote: > Hi Yonghong Song, > > On Fri, Jul 26, 2019 at 5:45 PM Yonghong Song wrote: >> >> >> >> On 7/26/19 1:26 AM, Sedat Dilek wrote: >>> Hi, >>> >>> I have opened a new issue in the ClangBuiltLinux issue tracker. >> >> Glad to know clang 9 has asm goto support

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-26 Thread Sedat Dilek
On Fri, Jul 26, 2019 at 10:38 PM Sedat Dilek wrote: > > Hi Yonghong Song, > > On Fri, Jul 26, 2019 at 5:45 PM Yonghong Song wrote: > > > > > > > > On 7/26/19 1:26 AM, Sedat Dilek wrote: > > > Hi, > > > > > > I have opened a new issue in the ClangBuiltLinux issue tracker. > > > > Glad to know clan

Re: [PATCH net-next 1/3] net: ethernet: mediatek: Add basic PHYLINK support

2019-07-26 Thread David Miller
From: René van Dorst Date: Wed, 24 Jul 2019 21:23:40 +0200 > @@ -186,165 +187,219 @@ static void mtk_gmac0_rgmii_adjust(struct mtk_eth > *eth, int speed) > mtk_w32(eth, val, TRGMII_TCK_CTRL); > } > > -static void mtk_phy_link_adjust(struct net_device *dev) > +static void mtk_mac_config(

[PATCH v2] iproute2: devlink: port from sys/queue.h to list.h

2019-07-26 Thread Sergei Trofimovich
sys/queue.h does not exist on linux-musl targets and fails build as: devlink.c:28:10: fatal error: sys/queue.h: No such file or directory 28 | #include | ^ The change ports to list.h API and drops dependency of 'sys/queue.h'. The API maps one-to-one. Bu

Re: [PATCH net-next v4 6/6] net: mscc: PTP Hardware Clock (PHC) support

2019-07-26 Thread Saeed Mahameed
On Thu, 2019-07-25 at 16:27 +0200, Antoine Tenart wrote: > This patch adds support for PTP Hardware Clock (PHC) to the Ocelot > switch for both PTP 1-step and 2-step modes. > > Signed-off-by: Antoine Tenart > --- > drivers/net/ethernet/mscc/ocelot.c | 394 > ++- > drive

Re: [PATCH v2 bpf] libbpf: fix missing __WORDSIZE definition

2019-07-26 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 18, 2019 at 10:30:21AM -0700, Andrii Nakryiko escreveu: > hashmap.h depends on __WORDSIZE being defined. It is defined by > glibc/musl in different headers. It's an explicit goal for musl to be > "non-detectable" at compilation time, so instead include glibc header if > glibc is explici

Re: next-20190723: bpf/seccomp - systemd/journald issue?

2019-07-26 Thread Sedat Dilek
Hi Yonghong Song, On Fri, Jul 26, 2019 at 5:45 PM Yonghong Song wrote: > > > > On 7/26/19 1:26 AM, Sedat Dilek wrote: > > Hi, > > > > I have opened a new issue in the ClangBuiltLinux issue tracker. > > Glad to know clang 9 has asm goto support and now It can compile > kernel again. > Yupp. > >

[PATCH bpf-next 1/9] selftests/bpf: prevent headers to be compiled as C code

2019-07-26 Thread Andrii Nakryiko
Apprently listing header as a normal dependency for a binary output makes it go through compilation as if it was C code. This currently works without a problem, but in subsequent commits causes problems for differently generated test.h for test_progs. Marking those headers as order-only dependency

[PATCH bpf-next 2/9] selftests/bpf: revamp test_progs to allow more control

2019-07-26 Thread Andrii Nakryiko
Refactor test_progs to allow better control on what's being run. Also use argp to do argument parsing, so that it's easier to keep adding more options. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/Makefile | 8 +-- tools/testing/selftests/bpf/test_progs.c | 84

[PATCH bpf-next 9/9] selftests/bpf: convert send_signal.c to use subtests

2019-07-26 Thread Andrii Nakryiko
Convert send_signal set of tests to be exposed as three sub-tests. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/prog_tests/send_signal.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/send_signal.c b/tools/te

[PATCH bpf-next 0/9] Revamp test_progs as a test running framework

2019-07-26 Thread Andrii Nakryiko
This patch set makes a number of changes to test_progs selftest, which is a collection of many other tests (and sometimes sub-tests as well), to provide better testing experience and allow to start convering many individual test programs under selftests/bpf into a single and convenient test runner.

[PATCH bpf-next 4/9] libbpf: add libbpf_swap_print to get previous print func

2019-07-26 Thread Andrii Nakryiko
libbpf_swap_print allows to restore previously set print function. This is useful when running many independent test with one default print function, but overriding log verbosity for particular subset of tests. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 8 tools/lib/b

[PATCH bpf-next 3/9] selftests/bpf: add test selectors by number and name to test_progs

2019-07-26 Thread Andrii Nakryiko
Add ability to specify either test number or test name substring to narrow down a set of test to run. Usage: sudo ./test_progs -n 1 sudo ./test_progs -t attach_probe Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/test_progs.c | 43 +--- 1 file changed, 39 ins

[PATCH bpf-next 7/9] selftests/bpf: add sub-tests support for test_progs

2019-07-26 Thread Andrii Nakryiko
Allow tests to have their own set of sub-tests. Also add ability to do test/subtest selection using `-t /` and `-n /`, as an extension of existing -t/-n selector options. For the format: it's a comma-separated list of either individual test numbers (1-based), or range of test numbers. E.g., all of

[PATCH bpf-next 5/9] selftest/bpf: centralize libbpf logging management for test_progs

2019-07-26 Thread Andrii Nakryiko
Make test_progs test runner own libbpf logging. Also introduce two levels of verbosity: -v and -vv. First one will be used in subsequent patches to enable test log output always. Second one increases verbosity level of libbpf logging further to include debug output as well. Signed-off-by: Andrii N

[PATCH bpf-next 8/9] selftests/bpf: convert bpf_verif_scale.c to sub-tests API

2019-07-26 Thread Andrii Nakryiko
Expose each BPF verifier scale test as individual sub-test to allow independent results output and test selection. Test run results now look like this: $ sudo ./test_progs -t verif/ #3/1 loop3.o:OK #3/2 test_verif_scale1.o:OK #3/3 test_verif_scale2.o:OK #3/4 test_verif_scale3.o:OK #3/

[PATCH bpf-next 6/9] selftests/bpf: abstract away test log output

2019-07-26 Thread Andrii Nakryiko
This patch changes how test output is printed out. By default, if test had no errors, the only output will be a single line with test number, name, and verdict at the end, e.g.: #31 xdp:OK If test had any errors, all log output captured during test execution will be output after test completes.

[PATCH net-next 4/4] r8169: enable HW csum and TSO

2019-07-26 Thread Heiner Kallweit
Enable HW csum and TSO per default except on known buggy chip versions. Realtek confirmed that RTL8168evl has a HW issue with TSO. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/dr

[PATCH net-next 3/4] r8169: remove r8169_csum_workaround

2019-07-26 Thread Heiner Kallweit
The loop in r8169_csum_workaround is called only if in msdn_giant_send_check a copy of the skb header needs to be made and we don't have enough memory. Let's simply drop the packet in that case so that we can remove r8169_csum_workaround. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/r

[PATCH net-next 1/4] r8169: set GSO size and segment limits

2019-07-26 Thread Heiner Kallweit
Set GSO max size and max segment number as in the vendor driver. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realte

[PATCH net-next 2/4] r8169: implement callback ndo_features_check

2019-07-26 Thread Heiner Kallweit
Implement callback ndo_features_check and move all feature checks there. This will allow us to get rid of r8169_csum_workaround() completely in a subsequent step. Like in the vendor driver disable HW csum for short packets on RTL8168b. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/real

[PATCH net-next 0/4] r8169: improve HW csum and TSO handling

2019-07-26 Thread Heiner Kallweit
This series: - delegates more tasks from the driver to the core - enables HW csum and TSO per default - copies quirks for buggy chip versions from vendor driver Heiner Kallweit (4): r8169: set GSO size and segment limits r8169: implement callback ndo_features_check r8169: remove r8169_csum_w

Re: [patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-26 Thread Stephen Hemminger
On Tue, 23 Jul 2019 13:25:37 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > One cannot depend on *argv being null in case of no arg is left on the > command line. For example in batch mode, this is not always true. Check > argc instead to prevent crash. > > Reported-by: Alex Kushnarov > Fixes

[PATCH net-next] ipv6: remove printk

2019-07-26 Thread Jonathan Lemon
ipv6_find_hdr() prints a non-rate limited error message when it cannot find an ipv6 header at a specific offset. This could be used as a DoS, so just remove it. Signed-off-by: Jonathan Lemon --- net/ipv6/exthdrs_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ip

Re: Driver support for Realtek RTL8125 2.5GB Ethernet

2019-07-26 Thread Heiner Kallweit
On 24.07.2019 22:02, Heiner Kallweit wrote: > On 24.07.2019 10:19, Jian-Hong Pan wrote: >> Hi all, >> >> We have got a consumer desktop equipped with Realtek RTL8125 2.5GB >> Ethernet [1] recently. But, there is no related driver in mainline >> kernel yet. So, we can only use the vendor driver [2

[PATCH net-next] r8169: align setting PME with vendor driver

2019-07-26 Thread Heiner Kallweit
Align setting PME with the vendor driver. PMEnable is writable on RTL8169 only, on later chip versions it's read-only. PME_SIGNAL is used on chip versions from RTL8168evl with the exception of the RTL8168f family. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 8 +

Re: [PATCH iproute2] iplink: document the 'link change' subcommand

2019-07-26 Thread Matteo Croce
On July 26, 2019 8:25:14 PM GMT+02:00, Stephen Hemminger wrote: > On Wed, 24 Jul 2019 21:12:18 +0200 > Matteo Croce wrote: > > > ip link can set parameters both via the 'set' and 'change' keyword. > > In fact, 'change' is an alias for 'set'. > > Document this in the help and manpage. > > > > F

Re: [patch iproute2 1/2] tc: action: fix crash caused by incorrect *argv check

2019-07-26 Thread Stephen Hemminger
On Tue, 23 Jul 2019 21:36:00 +0200 Jiri Pirko wrote: > Tue, Jul 23, 2019 at 07:54:01PM CEST, step...@networkplumber.org wrote: > >On Tue, 23 Jul 2019 13:25:37 +0200 > >Jiri Pirko wrote: > > > >> From: Jiri Pirko > >> > >> One cannot depend on *argv being null in case of no arg is left on the

Re: [PATCH iproute2] iplink: document the 'link change' subcommand

2019-07-26 Thread Stephen Hemminger
On Wed, 24 Jul 2019 21:12:18 +0200 Matteo Croce wrote: > ip link can set parameters both via the 'set' and 'change' keyword. > In fact, 'change' is an alias for 'set'. > Document this in the help and manpage. > > Fixes: 1d93483985f0 ("iplink: use netlink for link configuration") > Signed-off-by:

Re: [PATCH] iproute2: devlink: use sys/queue.h from libbsd as a fallback

2019-07-26 Thread Stephen Hemminger
On Wed, 24 Jul 2019 09:18:38 +0100 Sergei Trofimovich wrote: > On sys/queue.h does not exist linux-musl targets and > fails build as: > > devlink.c:28:10: fatal error: sys/queue.h: No such file or directory >28 | #include > | ^ > > The change pulls in

[PATCH net-next v2] mlx4/en_netdev: allow offloading VXLAN over VLAN

2019-07-26 Thread Davide Caratti
ConnectX-3 Pro can offload transmission of VLAN packets with VXLAN inside: enable tunnel offloads in dev->vlan_features, like it's done with other NIC drivers (e.g. be2net and ixgbe). It's no more necessary to change dev->hw_enc_features when VXLAN are added or removed, since .ndo_features_check()

[PATCH 2/2] staging/octeon: Allow test build on !MIPS

2019-07-26 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" Add compile test support by moving all includes of files under asm/octeon into octeon-ethernet.h, and if we're not on MIPS, stub out all the calls into the octeon support code in octeon-stubs.h Signed-off-by: Matthew Wilcox (Oracle) --- drivers/staging/octeon/Kc

[PATCH 1/2] octeon: Fix typo

2019-07-26 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" Compile fix from skb_frag_t conversion. Signed-off-by: Matthew Wilcox (Oracle) --- drivers/staging/octeon/ethernet-tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx

[PATCH 0/2] Fix Octeon to build on !MIPS

2019-07-26 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" I typo'd the conversion to skb_frag_t in the Octeon driver, but didn't notice because you can only build it on MIPS, and the buildbots seem overloaded right now. So I've constructed some stubs which let me build it on x86. I'm sure somebody could do a better job

Attn Dear Atm Card beneficiary. GOOD NEWS,Shipment number: 4Z69536197319960 Content Packages: ATM Visa Card, amount of $18.5Million

2019-07-26 Thread DR, MOHAMMED BUHARI, PRESIDENT OF NIGERIA
Attn Dear Atm Card beneficiary. GOOD NEWS, This is to inform you that i have paid the delivery fees for your ATM Master Card I paid it because our bank director stated that before, they So contact Dr. William Roberts, Director DHL Courier Company Benin to receive your delivery ATM Visa Card amount

Please Let My Situation Touch Your Heart.

2019-07-26 Thread Mrs Monica
-- -- Hello My Dear Calvary Greetings in the name of the ALMIGHTY I am Mrs Monica Gabriele from Switzerland I am married to Late Mr.Gabriele Joseph who is a wealthy business man here in Burkina Faso we were married for many years without a child before he died after a brief illness. Before h

[PATCH V3 3/3] net: dsa: ksz: Add Microchip KSZ8795 DSA driver

2019-07-26 Thread Marek Vasut
From: Tristram Ha Add Microchip KSZ8795 DSA driver. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: David S. Miller Cc: Florian Fainelli Cc: Tristram Ha Cc: Vivien Didelot Cc: Woojung Huh --- V2: - Use reverse xmas tree for variable declaration - Use BIT() m

[PATCH V3 2/3] net: dsa: ksz: Add KSZ8795 tag code

2019-07-26 Thread Marek Vasut
From: Tristram Ha Add DSA tag code for Microchip KSZ8795 switch. The switch is simpler and the tag is only 1 byte, instead of 2 as is the case with KSZ9477. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: David S. Miller Cc: Florian Fainelli Cc: Tristram Ha Cc: Vi

[PATCH V3 1/3] dt-bindings: net: dsa: ksz: document Microchip KSZ87xx family switches

2019-07-26 Thread Marek Vasut
Document Microchip KSZ87xx family switches. These include KSZ8765 - 5 port switch KSZ8794 - 4 port switch KSZ8795 - 5 port switch Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: David S. Miller Cc: Florian Fainelli Cc: Rob Herring Cc: Tristram Ha Cc: Vivien Didelot Cc: Woojung Huh Cc: devic

[PATCH V3 0/3] net: dsa: ksz: Add Microchip KSZ87xx support

2019-07-26 Thread Marek Vasut
This series adds support for Microchip KSZ87xx switches, which are slightly simpler compared to KSZ9xxx . Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: David S. Miller Cc: Florian Fainelli Cc: Tristram Ha Cc: Vivien Didelot Cc: Woojung Huh Marek Vasut (1): dt-bindings: net: dsa: ksz: do

Re: [PATCH net-next 3/3] dt-bindings: net: ethernet: Update mt7622 docs and dts to reflect the new phylink API

2019-07-26 Thread Russell King - ARM Linux admin
On Fri, Jul 26, 2019 at 03:16:22PM +, René van Dorst wrote: > Quoting Andrew Lunn : > > On Fri, Jul 26, 2019 at 07:19:56AM +, René van Dorst wrote: > > > Quoting Andrew Lunn : > > > > > > >>+ gmac0: mac@0 { > > > >>+ compatible = "mediatek,eth-mac"; > > > >>+

[PATCH bpf-next v5 5/6] tools/libbpf_probes: Add new devmap_hash type

2019-07-26 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This adds the definition for BPF_MAP_TYPE_DEVMAP_HASH to libbpf_probes.c in tools/lib/bpf. Signed-off-by: Toke Høiland-Jørgensen Acked-by: Yonghong Song --- tools/lib/bpf/libbpf_probes.c |1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/bpf/libbpf_p

[PATCH bpf-next v5 4/6] tools/include/uapi: Add devmap_hash BPF map type

2019-07-26 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This adds the devmap_hash BPF map type to the uapi headers in tools/. Signed-off-by: Toke Høiland-Jørgensen Acked-by: Yonghong Song --- tools/include/uapi/linux/bpf.h |1 + 1 file changed, 1 insertion(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/inc

[PATCH bpf-next v5 3/6] xdp: Add devmap_hash map type for looking up devices by hashed index

2019-07-26 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen A common pattern when using xdp_redirect_map() is to create a device map where the lookup key is simply ifindex. Because device maps are arrays, this leaves holes in the map, and the map has to be sized to fit the largest ifindex, regardless of how many devices actual

[PATCH bpf-next v5 6/6] tools: Add definitions for devmap_hash map type

2019-07-26 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This adds selftest and bpftool updates for the devmap_hash map type. Signed-off-by: Toke Høiland-Jørgensen --- tools/bpf/bpftool/Documentation/bpftool-map.rst |2 +- tools/bpf/bpftool/bash-completion/bpftool |4 ++-- tools/bpf/bpftool/map.c

[PATCH bpf-next v5 2/6] xdp: Refactor devmap allocation code for reuse

2019-07-26 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The subsequent patch to add a new devmap sub-type can re-use much of the initialisation and allocation code, so refactor it into separate functions. Signed-off-by: Toke Høiland-Jørgensen Acked-by: Yonghong Song --- kernel/bpf/devmap.c | 136 ++

[PATCH bpf-next v5 0/6] xdp: Add devmap_hash map type

2019-07-26 Thread Toke Høiland-Jørgensen
This series adds a new map type, devmap_hash, that works like the existing devmap type, but using a hash-based indexing scheme. This is useful for the use case where a devmap is indexed by ifindex (for instance for use with the routing table lookup helper). For this use case, the regular devmap nee

[PATCH bpf-next v5 1/6] include/bpf.h: Remove map_insert_ctx() stubs

2019-07-26 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen When we changed the device and CPU maps to use linked lists instead of bitmaps, we also removed the need for the map_insert_ctx() helpers to keep track of the bitmaps inside each map. However, it seems I forgot to remove the function definitions stubs, so remove those

  1   2   >