On Mon, Jul 22, 2019 at 09:43:15PM +0200, Toke Høiland-Jørgensen wrote:
> Is there a mechanism for the user to filter the packets before they are
> sent to userspace? A bpf filter would be the obvious choice I guess...
Hi Toke,
Yes, it's on my TODO list to write an eBPF program that only lets
"un
On Tue, Jul 23, 2019 at 2:20 AM Petar Penkov wrote:
>
> From: Petar Penkov
>
> This patch series introduces a BPF helper function that allows generating SYN
> cookies from BPF. Currently, this helper is enabled at both the TC hook and
> the
> XDP hook.
Please provide performance numbers ?
We
The hardware has been declared EOL by the vendor more than 5 years ago.
What's more relevant to the Linux kernel is that the quality of this driver
is not on par with many other mainline drivers.
Cc: Manish Chopra
Message-id: <20190617074858.32467-1-bpoir...@suse.com>
Signed-off-by: Benjamin Poir
act_ife at least requires TCA_IFE_PARMS, so we have to bail out
when there is no attribute passed in.
Reported-by: syzbot+fbb5b288c9cb6a2ee...@syzkaller.appspotmail.com
Fixes: ef6980b6becb ("introduce IFE action")
Cc: Jamal Hadi Salim
Cc: Jiri Pirko
Signed-off-by: Cong Wang
---
net/sched/act_i
Convert trace_output sample to libbpf's perf_buffer API.
Signed-off-by: Andrii Nakryiko
---
samples/bpf/trace_output_user.c | 43 +++--
1 file changed, 14 insertions(+), 29 deletions(-)
diff --git a/samples/bpf/trace_output_user.c b/samples/bpf/trace_output_user.c
in
libbpf's perf_buffer API supersedes trace_helper.h's helpers.
Remove those helpers after all existing users were already moved to
perf_buffer API.
Signed-off-by: Andrii Nakryiko
---
tools/testing/selftests/bpf/trace_helpers.c | 125
tools/testing/selftests/bpf/trace_helpers.
Switch test_tcpnotify test to use libbpf's perf_buffer API instead of
re-implementing portion of it.
Signed-off-by: Andrii Nakryiko
---
.../selftests/bpf/test_tcpnotify_user.c | 90 ---
1 file changed, 36 insertions(+), 54 deletions(-)
diff --git a/tools/testing/selftests/
Convert test_get_stack_raw_tp test to new perf_buffer API.
Signed-off-by: Andrii Nakryiko
---
.../bpf/prog_tests/get_stack_raw_tp.c | 78 ++-
.../bpf/progs/test_get_stack_rawtp.c | 2 +-
2 files changed, 44 insertions(+), 36 deletions(-)
diff --git a/tools/test
Convert xdp_sample_pkts_user to libbpf's perf_buffer API.
Signed-off-by: Andrii Nakryiko
---
samples/bpf/xdp_sample_pkts_user.c | 61 +-
1 file changed, 17 insertions(+), 44 deletions(-)
diff --git a/samples/bpf/xdp_sample_pkts_user.c
b/samples/bpf/xdp_sample_pkts_u
There were few more tests and samples that were using custom perf buffer setup
code from trace_helpers.h. This patch set gets rid of all the usages of those
and removes helpers themselves. Libbpf provides nicer, but equally powerful
set of APIs to work with perf ring buffers, so let's have all the
When BPF program defines uninitialized global variable, it's put into
a special COMMON section. Libbpf will reject such programs, but will
provide very unhelpful message with garbage-looking section index.
This patch detects special section cases and gives more explicit error
message.
Signed-off-
On 2019/7/23 11:08, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)"
>
> In preparation for unifying the skb_frag and bio_vec, use the fine
> accessors which already exist and use skb_frag_t instead of
> struct skb_frag_struct.
>
> Signed-off-by: Matthew Wilcox (Oracle)
> ---
> include/
From: Matthew Wilcox
Date: Mon, 22 Jul 2019 20:08:24 -0700
> From: "Matthew Wilcox (Oracle)"
>
> The skb_frag_t and bio_vec are fundamentally the same (page, offset,
> length) tuple. This patch series unifies the two, leaving the
> skb_frag_t typedef in place. This has the immediate advantage
Removed cacheline_aligned attribute to ring structs. This actually
causes holes in the ag71xx struc as well as lower performance.
Rearranged struct members to fall within respective cachelines. The RX
ring struct now does not share a cacheline with the TX ring. The NAPI
atruct now takes up its
sock_efree() releases the sock refcnt, if we don't hold this refcnt
when setting skb->destructor to it, the refcnt would not be balanced.
This leads to several bug reports from syzbot.
I have checked other users of sock_efree(), all of them hold the
sock refcnt.
Fixes: c8c8218ec5af ("netrom: fix
From: "Matthew Wilcox (Oracle)"
One step closer to turning the skb_frag_t into a bio_vec.
Signed-off-by: Matthew Wilcox (Oracle)
---
include/linux/skbuff.h | 12 +---
net/core/skbuff.c | 2 +-
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/include/linux/skbuff.h b
From: "Matthew Wilcox (Oracle)"
To increase commonality between block and net, we are going to replace
the skb_frag_t with the bio_vec. This patch increases the size of
skb_frag_t on 32-bit machines from 8 bytes to 12 bytes. The size is
unchanged on 64-bit machines.
Signed-off-by: Matthew Wilc
From: "Matthew Wilcox (Oracle)"
Improved compatibility with bvec
Signed-off-by: Matthew Wilcox (Oracle)
---
include/linux/skbuff.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 8076e2ba8349..e849e411d1f3 100
The original issue,
https://lore.kernel.org/netdev/1562959401-19815-1-git-send-email-...@lca.pw/
The debugging so far seems point to that the compilers get confused by the
module sections. During module_param(), it stores “__param_rx_frag_size"
as a “struct kernel_param” into the __param section.
From: "Matthew Wilcox (Oracle)"
In preparation for unifying the skb_frag and bio_vec, use the fine
accessors which already exist and use skb_frag_t instead of
struct skb_frag_struct.
Signed-off-by: Matthew Wilcox (Oracle)
---
drivers/crypto/chelsio/chtls/chtls_io.c | 6 +++--
drivers/hs
From: "Matthew Wilcox (Oracle)"
There are a lot of users of frag->page_offset, so use a union
to avoid converting those users today.
Signed-off-by: Matthew Wilcox (Oracle)
---
include/linux/bvec.h | 5 -
include/linux/skbuff.h | 9 ++---
2 files changed, 6 insertions(+), 8 deletions(
From: "Matthew Wilcox (Oracle)"
In preparation for unifying the skb_frag and bio_vec, use the fine
accessors which already exist and use skb_frag_t instead of
struct skb_frag_struct.
Signed-off-by: Matthew Wilcox (Oracle)
---
include/linux/skbuff.h | 2 +-
net/core/skbuff.c | 24
From: "Matthew Wilcox (Oracle)"
Match the layout of bio_vec.
Signed-off-by: Matthew Wilcox (Oracle)
---
include/linux/skbuff.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 7910935410e6..b9dc8b4f24b1 100644
--- a/inclu
From: "Matthew Wilcox (Oracle)"
The skb_frag_t and bio_vec are fundamentally the same (page, offset,
length) tuple. This patch series unifies the two, leaving the
skb_frag_t typedef in place. This has the immediate advantage that
we already have iov_iter support for bvecs and don't need to add
From: Matthew Wilcox
Date: Mon, 22 Jul 2019 13:39:59 -0700
> No further feedback received, and the patches still apply cleanly to
> Linus' head. Do you want the patch series resent, or does your workflow
> let you just pick these patches up now?
Please resend for net-next inclusion, thanks.
From: Petar Penkov
This helper function allows BPF programs to try to generate SYN
cookies, given a reference to a listener socket. The function works
from XDP and with an skb context since bpf_skc_lookup_tcp can lookup a
socket in both cases.
Signed-off-by: Petar Penkov
Suggested-by: Eric Duma
From: Petar Penkov
Sync updated documentation for bpf_redirect_map.
Sync the bpf_tcp_gen_syncookie helper function definition with the one
in tools/uapi.
Signed-off-by: Petar Penkov
---
tools/include/uapi/linux/bpf.h | 37 +++---
1 file changed, 34 insertions(+), 3
From: Petar Penkov
This patch allows generation of a SYN cookie before an SKB has been
allocated, as is the case at XDP.
Signed-off-by: Petar Penkov
---
include/net/tcp.h| 11 +++
net/ipv4/tcp_input.c | 76
net/ipv4/tcp_ipv4.c | 8 +
n
From: Petar Penkov
This allows us to call this function before an SKB has been
allocated.
Signed-off-by: Petar Penkov
---
net/ipv4/tcp_input.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index c21e8a22fb3b..8892df6de1d
From: Petar Penkov
This patch series introduces a BPF helper function that allows generating SYN
cookies from BPF. Currently, this helper is enabled at both the TC hook and the
XDP hook.
The first two patches in the series add/modify several TCP helper functions to
allow for SKB-less operation,
From: Petar Penkov
Expose bpf_tcp_gen_syncookie to selftests.
Signed-off-by: Petar Penkov
---
tools/testing/selftests/bpf/bpf_helpers.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/bpf/bpf_helpers.h
b/tools/testing/selftests/bpf/bpf_helpers.h
index 5a3d92c8be
From: Petar Penkov
Modify the existing bpf_tcp_check_syncookie test to also generate a
SYN cookie, pass the packet to the kernel, and verify that the two
cookies are the same (and both valid). Since cloned SKBs are skipped
during generic XDP, this test does not issue a SYN cookie when run in
XDP
On 7/22/19 1:11 PM, Patel, Vedang wrote:
>
>
>> On Jul 22, 2019, at 11:21 AM, David Ahern wrote:
>>
>> On 7/19/19 3:40 PM, Vedang Patel wrote:
>>> In iproute2 txtime-assist series, it was pointed out that print_bool()
>>> should be used to print binary values. This is to make it JSON friendly.
>
Merge window is closed, therefore new round begins.
Thanks everyone,
Daniel
Hi Antoine,
On Fri, Jul 05, 2019 at 09:52:07PM +0200, Antoine Tenart wrote:
> This patch adds one register range within the mscc,vsc7514-switch node,
> to describe the PTP registers.
>
> Signed-off-by: Antoine Tenart
Presuming this should go through net-next along with the rest of the
series:
Add in the basic ethtool callbacks for device information
and control.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/Makefile | 2 +-
.../net/ethernet/pensando/ionic/ionic_dev.h | 3 +
.../ethernet/pensando/ionic/ionic_ethtool.c | 495 ++
.../ethe
Interrupt coalescing, tunable copybreak value, and
tx timeout.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic.h | 2 +-
.../ethernet/pensando/ionic/ionic_ethtool.c | 105 ++
.../net/ethernet/pensando/ionic/ionic_lif.c | 13 ++-
.../net/ethern
Add both the Tx and Rx queue setup and handling. The related
stats display comes later. Instead of using the generic napi
routines used by the slow-path commands, the Tx and Rx paths
are simplified and inlined in one file in order to get better
compiler optimizations.
Signed-off-by: Shannon Nels
Add AdminQ specific message requests and completion handling.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic.h | 7 ++
.../net/ethernet/pensando/ionic/ionic_main.c | 106 ++
2 files changed, 113 insertions(+)
diff --git a/drivers/net/ethernet/pe
Add the Rx filtering and rx_mode NDO callbacks. Also add
the deferred work thread handling needed to manage the filter
requests otuside of the netif_addr_lock spinlock.
Signed-off-by: Shannon Nelson
---
.../net/ethernet/pensando/ionic/ionic_lif.c | 389 +-
.../net/ethernet/pen
Set up the initial NDO structure and callbacks for netdev
to use, and register the netdev. This will allow us to do
a few basic operations on the device, but no traffic yet.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic.h | 1 +
.../ethernet/pensando/ionic/ioni
Add code to handle the link status event, and wire up the
basic netdev hardware stats.
Signed-off-by: Shannon Nelson
---
.../net/ethernet/pensando/ionic/ionic_lif.c | 116 ++
.../net/ethernet/pensando/ionic/ionic_lif.h | 1 +
2 files changed, 117 insertions(+)
diff --git a
The AdminQ is fine for sending messages and requests to the NIC,
but we also need to have events published from the NIC to the
driver. The NotifyQ handles this for us, using the same interrupt
as AdminQ.
Signed-off-by: Shannon Nelson
---
.../ethernet/pensando/ionic/ionic_debugfs.c | 16 ++
.
The ionic device has a small set of PCI registers, including a
device control and data space, and a large set of message
commands.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/Makefile |2 +-
drivers/net/ethernet/pensando/ionic/ionic.h | 20 +
.../net/ethernet/p
The port management commands apply to the physical port
associated with the PCI device, which might be shared among
several logical interfaces.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic.h | 4 +
.../ethernet/pensando/ionic/ionic_bus_pci.c | 16 +++
.../ne
Add a devlink interface for access to information that isn't
normally available through ethtool or the iplink interface.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/Makefile | 2 +-
drivers/net/ethernet/pensando/ionic/ionic.h | 3 +
.../ethernet/pensando/ionic/ioni
The LIF is the Logical Interface, which represents the external
connections. The NIC can multiplex many LIFs to a single port,
but in most setups, LIF0 is the primary control for the port.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/Makefile | 3 +-
drivers/net/ethe
Most of the NIC configuration happens through the AdminQ message
queue. NAPI is used for basic interrupt handling and message
queue management. These routines are set up to be shared among
different types of queues when used in slow-path handling.
Signed-off-by: Shannon Nelson
---
drivers/net/
Set up the infrastructure for managing Rx filters. We can't ask the
hardware for what filters it has, so we keep a local list of filters
that we've pushed into the HW.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/Makefile | 4 +-
.../net/ethernet/pensando/ionic/ionic
Add in the detailed statistics for ethtool -S that the driver
keeps as it processes packets. Display of the additional
debug statistics can be enabled through the ethtool priv-flags
feature.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/Makefile | 3 +-
.../ethernet/p
Add code to manipulate through ethtool the RSS configuration
used by the NIC.
Signed-off-by: Shannon Nelson
---
.../ethernet/pensando/ionic/ionic_ethtool.c | 73
.../net/ethernet/pensando/ionic/ionic_lif.c | 87 +++
.../net/ethernet/pensando/ionic/ionic_lif.h
When the netdev gets a new name from userland, pass that name
down to the NIC for internal tracking.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic.h | 2 +
.../net/ethernet/pensando/ionic/ionic_lif.c | 65 +++
2 files changed, 67 insertions(+)
The ionic interrupt model is based on interrupt control blocks
accessed through the PCI BAR. Doorbell registers are used by
the driver to signal to the NIC that requests are waiting on
the message queues. Interrupts are used by the NIC to signal
to the driver that answers are waiting on the compl
This patch adds a basic driver framework for the Pensando IONIC
network device. There is no functionality right now other than
the ability to load and unload.
Signed-off-by: Shannon Nelson
---
.../networking/device_drivers/index.rst | 1 +
.../device_drivers/pensando/ionic.rst |
This is a patch series that adds the ionic driver, supporting the Pensando
ethernet device.
In this initial patchset we implement basic transmit and receive. Later
patchsets will add more advanced features.
Our thanks to Andrew Lunn, Michal Kubecek, Jacub Kicinski, Jiri Pirko, and
the ever prese
On Sun, Jul 21, 2019 at 7:44 AM Vlad Buslov wrote:
>
> In function int tc_new_tfilter() q pointer can be NULL when adding filter
> on a shared block. With recent change that resets TCQ_F_CAN_BYPASS after
> filter creation, following NULL pointer dereference happens in case parent
> block is shared
Hi Andy, Lorenz, and all,
> On Jul 2, 2019, at 2:32 PM, Andy Lutomirski wrote:
>
> On Tue, Jul 2, 2019 at 2:04 PM Kees Cook wrote:
>>
>> On Mon, Jul 01, 2019 at 06:59:13PM -0700, Andy Lutomirski wrote:
>>> I think I'm understanding your motivation. You're not trying to make
>>> bpf() generic
On Fri, Jul 12, 2019 at 11:27:07AM -0700, David Miller wrote:
> From: Matthew Wilcox
> Date: Fri, 12 Jul 2019 06:43:38 -0700
>
> > From: "Matthew Wilcox (Oracle)"
> >
> > The skb_frag_t and bio_vec are fundamentally the same (page, offset,
> > length) tuple. This patch series unifies the two,
On 2019-07-21, at 20:26:08 +0200, Pablo Neira Ayuso wrote:
> On Sun, Jul 21, 2019 at 12:31:05PM +0100, Jeremy Sowden wrote:
> > net/netfilter/nf_tables_offload.h includes net/netfilter/nf_tables.h
> > which is itself on the blacklist.
> >
> > Reported-by: Jakub Kicinski
> > Signed-off-by: Jeremy S
> On Jul 22, 2019, at 11:21 AM, David Ahern wrote:
>
> On 7/19/19 3:40 PM, Vedang Patel wrote:
>> In iproute2 txtime-assist series, it was pointed out that print_bool()
>> should be used to print binary values. This is to make it JSON friendly.
>>
>> So, make the corresponding changes in ETF.
This patch improves few aspects of rtl_rx, no functional change intended.
1. inline rtl8169_try_rx_copy
2. make pkt_size unsigned
3. use constant ETH_FCS_LEN instead of value 4
4. We just created the skb, so we don't need the checks in skb_put.
Also we don't need the return value of skb_put.
Ido Schimmel writes:
> From: Ido Schimmel
>
> So far drop monitor supported only one mode of operation in which a
> summary of recent packet drops is periodically sent to user space as a
> netlink event. The event only includes the drop location (program
> counter) and number of drops in the las
From: Loganaden Velvindron
Date: Mon, 22 Jul 2019 23:25:49 +0400
> ping davem
I really don't want to send it to -stable, sorry...
On Wed, Jul 17, 2019 at 5:45 PM Dave Taht wrote:
>
> On Mon, Jul 15, 2019 at 11:01 AM Loganaden Velvindron
> wrote:
> >
> > On Fri, Jul 5, 2019 at 6:15 PM Loganaden Velvindron
> > wrote:
> > >
> > > Hi folks,
> > >
> > > I read the guidelines for LTS/stable.
> > > https://www.kernel.org/doc/htm
From: Maciej Żenczykowski
Date: Thu, 18 Jul 2019 23:30:03 -0700
> From: Maciej Żenczykowski
>
> This is trivial since we already have support for the entirely
> identical (from the kernel's point of view) RDNSS and DNSSL that
> also contain opaque data that needs to be passed down to userspace.
From: Thomas Falcon
Date: Tue, 16 Jul 2019 17:25:10 -0500
> The following scenario was encountered during testing of logical
> partition mobility on pseries partitions with bonded ibmvnic
> adapters in LACP mode.
>
> 1. Driver receives a signal that the device has been
>swapped, and it needs
Flood me...
From: Ido Schimmel
Users should be able to query the current configuration of drop monitor
before they start using it. Add a command to query the existing
configuration which currently consists of alert mode and packet
truncation length.
Signed-off-by: Ido Schimmel
---
include/uapi/linux/net_d
From: Ido Schimmel
So far drop monitor supported only one alert mode in which a summary of
locations in which packets were recently dropped was sent to user space.
This alert mode is sufficient in order to understand that packets were
dropped, but lacks information to perform a more detailed ana
From: Ido Schimmel
When sending dropped packets to user space it is not always necessary to
copy the entire packet as usually only the headers are of interest.
Allow user to specify the truncation length and add the original length
of the packet as additional metadata to the netlink message.
By
From: Ido Schimmel
Currently, the configure command does not do anything but return an
error. Subsequent patches will enable the command to change various
configuration options such as alert mode and packet truncation.
Similar to other netlink-based configuration channels, make sure only
users w
From: Ido Schimmel
So far drop monitor supported only one mode of operation in which a
summary of recent packet drops is periodically sent to user space as a
netlink event. The event only includes the drop location (program
counter) and number of drops in the last interval.
While this mode of op
From: Ido Schimmel
The timer and work item are currently initialized once during module
init, but subsequent patches will need to associate different functions
with the work item, based on the configured alert mode.
Allow subsequent patches to make that change by initializing and
de-initializing
From: Ido Schimmel
Remove multiple blank lines which are visually annoying and useless.
This suppresses the "Please don't use multiple blank lines" checkpatch
messages.
Signed-off-by: Ido Schimmel
---
net/core/drop_monitor.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/drop_m
From: Ido Schimmel
The error code 'ENOTSUPP' is reserved for use with NFS. Use 'EOPNOTSUPP'
instead.
Signed-off-by: Ido Schimmel
---
net/core/drop_monitor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/drop_monitor.c b/net/core/drop_monitor.c
index 4ea4347f5
From: Ido Schimmel
While 'per_cpu_dm_data' is a per-CPU variable, its 'skb' and
'send_timer' fields can be accessed concurrently by the CPU sending the
netlink notification to user space from the workqueue and the CPU
tracing kfree_skb(). This spinlock is meant to protect against that.
Document
From: Ido Schimmel
Subsequent patches will need to enable / disable tracing based on the
configured alerting mode.
Reduce the nesting level and prepare for the introduction of this
functionality by splitting the tracing enable / disable operations into
two different functions.
Signed-off-by: Id
From: Ido Schimmel
The 'trace_state_mutex' does not only protect the global 'trace_state'
variable, but also the global 'hw_stats_list'.
Subsequent patches are going add more operations from user space to
drop_monitor and these all need to be mutually exclusive.
Rename 'trace_state_mutex' to th
From: Ido Schimmel
Add various extack messages to make drop_monitor more user friendly.
Signed-off-by: Ido Schimmel
---
net/core/drop_monitor.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/net/core/drop_monitor.c b/net/core/drop_monitor.c
index 9080e62245b9..1
From: Ido Schimmel
Each operation from user space should be protected by the global drop
monitor mutex. Use the pre_doit / post_doit hooks to take / release the
lock instead of doing it explicitly in each function.
Signed-off-by: Ido Schimmel
---
net/core/drop_monitor.c | 24 +-
On 7/19/19 3:40 PM, Vedang Patel wrote:
> In iproute2 txtime-assist series, it was pointed out that print_bool()
> should be used to print binary values. This is to make it JSON friendly.
>
> So, make the corresponding changes in ETF.
>
> Fixes: 8ccd49383cdc ("etf: Add skip_sock_check")
> Reporte
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/mst/vhost.git
linux-next
head: 25da3c2b43902852820e3231349085682e1a
commit: 4cfd64ce2ad979cbd9a97e1500533d2f5f1355b8 [4/5] rcu: add count of
outstanding callbacks
config: i386-allnoconfig (attached as .config)
compiler: gcc-7
In this function factored out from sctp_sendmsg_new_asoc() and
__sctp_connect(), it adds a peer with the other addr into the
asoc after this asoc is created with the 1st addr.
Signed-off-by: Xin Long
---
net/sctp/socket.c | 76 +++
1 file chang
In this function factored out from sctp_sendmsg_new_asoc() and
__sctp_connect(), it creates the asoc and adds a peer with the
1st addr.
Signed-off-by: Xin Long
---
net/sctp/socket.c | 160 ++
1 file changed, 76 insertions(+), 84 deletions(-)
d
__sctp_connect is doing quit similar things as sctp_sendmsg_new_asoc.
To factor out common functions, this patch is to clean up their code
to make them look more similar:
1. create the asoc and add a peer with the 1st addr.
2. add peers with the other addrs into this asoc one by one.
Signed-o
Now __sctp_connect() is called by __sctp_setsockopt_connectx() and
sctp_inet_connect(), the latter has done addr_size check with size
of sa_family_t.
In the next patch to clean up __sctp_connect(), we will remove
addr_size check with size of sa_family_t from __sctp_connect()
for the 1st address.
This patchset is to factor out some common code for
sctp_sendmsg_new_asoc() and __sctp_connect() into 2
new functioins.
Xin Long (4):
sctp: check addr_size with sa_family_t size in
__sctp_setsockopt_connectx
sctp: clean up __sctp_connect
sctp: factor out sctp_connect_new_asoc
sctp: fac
Hi ,
I had working DSA with 4.9.184 kernel, with BCM53125, rev 4 hardware .
It had 2 bridges with
br08000.00 no lan1
lan2
lan3
Daniel Borkmann wrote:
> On 7/19/19 7:37 PM, Jakub Kicinski wrote:
> > On Fri, 19 Jul 2019 10:29:13 -0700, Jakub Kicinski wrote:
> >> John says:
> >>
> >> Resolve a series of splats discovered by syzbot and an unhash
> >> TLS issue noted by Eric Dumazet.
> >
> > Sorry for the delay, this code is q
Jakub Kicinski wrote:
> On Fri, 19 Jul 2019 10:29:13 -0700, Jakub Kicinski wrote:
> > John says:
> >
> > Resolve a series of splats discovered by syzbot and an unhash
> > TLS issue noted by Eric Dumazet.
>
> Sorry for the delay, this code is quite tricky. According to my testing
> TLS SW and HW s
On 7/19/19 11:06 AM, Ilya Leoshkevich wrote:
> "sendmsg6: rewrite IP & port (C)" fails on s390, because the code in
> sendmsg_v6_prog() assumes that (ctx->user_ip6[0] & 0x) refers to
> leading IPv6 address digits, which is not the case on big-endian
> machines.
>
> Since checking bitwise opera
On 7/19/19 4:34 PM, Arnaldo Carvalho de Melo wrote:
> Hi Daniel,
>
> Please consider pulling or applying from the patches, if someone
> has any issues, please holler,
>
> - Arnaldo
>
> Arnaldo Carvalho de Melo (2):
> libbpf: Fix endianness macro usage for some compilers
> libbpf: Avoid
On 7/19/19 7:37 PM, Jakub Kicinski wrote:
> On Fri, 19 Jul 2019 10:29:13 -0700, Jakub Kicinski wrote:
>> John says:
>>
>> Resolve a series of splats discovered by syzbot and an unhash
>> TLS issue noted by Eric Dumazet.
>
> Sorry for the delay, this code is quite tricky. According to my testing
>
From: Toke Høiland-Jørgensen
This adds the definition for BPF_MAP_TYPE_DEVMAP_HASH to libbpf_probes.c in
tools/lib/bpf.
Signed-off-by: Toke Høiland-Jørgensen
Acked-by: Yonghong Song
---
tools/lib/bpf/libbpf_probes.c |1 +
1 file changed, 1 insertion(+)
diff --git a/tools/lib/bpf/libbpf_p
From: Toke Høiland-Jørgensen
The subsequent patch to add a new devmap sub-type can re-use much of the
initialisation and allocation code, so refactor it into separate functions.
Signed-off-by: Toke Høiland-Jørgensen
Acked-by: Yonghong Song
---
kernel/bpf/devmap.c | 136 ++
From: Toke Høiland-Jørgensen
This adds selftest and bpftool updates for the devmap_hash map type.
Signed-off-by: Toke Høiland-Jørgensen
---
tools/bpf/bpftool/Documentation/bpftool-map.rst |2 +-
tools/bpf/bpftool/bash-completion/bpftool |4 ++--
tools/bpf/bpftool/map.c
From: Toke Høiland-Jørgensen
This adds the devmap_hash BPF map type to the uapi headers in tools/.
Signed-off-by: Toke Høiland-Jørgensen
Acked-by: Yonghong Song
---
tools/include/uapi/linux/bpf.h |1 +
1 file changed, 1 insertion(+)
diff --git a/tools/include/uapi/linux/bpf.h b/tools/inc
From: Toke Høiland-Jørgensen
A common pattern when using xdp_redirect_map() is to create a device map
where the lookup key is simply ifindex. Because device maps are arrays,
this leaves holes in the map, and the map has to be sized to fit the
largest ifindex, regardless of how many devices actual
From: Toke Høiland-Jørgensen
When we changed the device and CPU maps to use linked lists instead of
bitmaps, we also removed the need for the map_insert_ctx() helpers to keep
track of the bitmaps inside each map. However, it seems I forgot to remove
the function definitions stubs, so remove those
This series adds a new map type, devmap_hash, that works like the existing
devmap type, but using a hash-based indexing scheme. This is useful for the use
case where a devmap is indexed by ifindex (for instance for use with the routing
table lookup helper). For this use case, the regular devmap nee
1 - 100 of 101 matches
Mail list logo
