From: Maciej Żenczykowski
This is trivial since we already have support for the entirely
identical (from the kernel's point of view) RDNSS and DNSSL that
also contain opaque data that needs to be passed down to userspace.
As specified in RFC7710, Captive Portal option contains a URL.
8-bit ident
Hi Stefan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on next-20190718]
[cannot apply to v5.2]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
On 2019/07/18 10:23, Florian Fainelli wrote:
> On 7/17/19 6:42 PM, Benjamin Poirier wrote:
> > As pointed out by Firo Yang, a netdev tx timeout may trigger just before an
> > ethtool set_channels operation is started. be_tx_timeout(), which dumps
> > some queue structures, is not written to run con
On Thu, 18 Jul 2019 12:55:39 -0700
Vedang Patel wrote:
> - print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s",
> + print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ",
> (qopt->flags & TC_ETF_DEADLINE_MODE_ON) ? "on"
> : "off");
> + pri
On 17.07.19 14:15, Daniel Golle wrote:
On Wed, Jul 17, 2019 at 01:02:43PM +0200, Stefan Roese wrote:
This patch adds support for the MediaTek MT7628/88 SoCs to the common
MediaTek ethernet driver. Some minor changes are needed for this and
a bigger change, as the MT7628 does not support QDMA (on
From: Arnd Bergmann
[ Upstream commit 752c2ea2d8e7c23b0f64e2e7d4337f3604d44c9f ]
The cudbg_collect_mem_region() and cudbg_read_fw_mem() both use several
hundred kilobytes of kernel stack space. One gets inlined into the other,
which causes the stack usage to be combined beyond the warning limit
On 19-07-19, 10:53, xiaofeis wrote:
> Set phy device advertising to enable MAC flow control.
How about:
to Pause for enabling MAC flow control
>
> Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae
Please remove this
> Signed-off-by: Xiaofei Shen
> ---
> drivers/net/dsa/qca8k.c | 4 +++-
>
Hi David,
Before commit 18a8021a7be3 ("net/ipv4: Plumb support for filtering route
dumps"), when we dump a non-exist table, ip cmd exits silently.
# ip -4 route list table 1
# echo $?
0
After commit 18a8021a7be3 ("net/ipv4: Plumb support for filtering route
dumps"). When we dump a non-exist tabl
From: Wei Yongjun
Date: Fri, 19 Jul 2019 01:21:57 +
> Fix to return error code -ENOMEM from the dmam_alloc_coherent() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> Signed-off-by: Wei Yongjun
> Reviewed-
From: Wei Yongjun
Date: Fri, 19 Jul 2019 01:22:06 +
> In case of error, the function of_get_mac_address() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> Sig
From: Eric Dumazet
Date: Thu, 18 Jul 2019 19:28:14 -0700
> Neal reported incorrect use of ns_capable() from bpf hook.
>
> bpf_setsockopt(...TCP_CONGESTION...)
> -> tcp_set_congestion_control()
>-> ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN)
> -> ns_capable_common()
> -> curre
Set phy device advertising to enable MAC flow control.
Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae
Signed-off-by: Xiaofei Shen
---
drivers/net/dsa/qca8k.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index d93be
On 7/18/19, 7:28 PM, "Eric Dumazet" wrote:
Neal reported incorrect use of ns_capable() from bpf hook.
bpf_setsockopt(...TCP_CONGESTION...)
-> tcp_set_congestion_control()
-> ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN)
-> ns_capable_common()
-> curre
On Thu, Jul 18, 2019 at 10:28 PM Eric Dumazet wrote:
>
> Neal reported incorrect use of ns_capable() from bpf hook.
>
> bpf_setsockopt(...TCP_CONGESTION...)
> -> tcp_set_congestion_control()
>-> ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN)
> -> ns_capable_common()
> -> current_c
On Thu, Jul 18, 2019 at 05:12:07PM -0700, Shannon Nelson wrote:
> On 7/17/19 8:28 PM, Andrew Lunn wrote:
> >On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote:
> >>On 7/8/19 7:14 PM, Andrew Lunn wrote:
> +static int ionic_set_pauseparam(struct net_device *netdev,
> +
Neal reported incorrect use of ns_capable() from bpf hook.
bpf_setsockopt(...TCP_CONGESTION...)
-> tcp_set_congestion_control()
-> ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN)
-> ns_capable_common()
-> current_cred()
-> rcu_dereference_protected(current->cred, 1)
Accessing
Em Thu, Jul 18, 2019 at 02:16:29PM -0700, Andrii Nakryiko escreveu:
> On Thu, Jul 18, 2019 at 12:14 PM Arnaldo Carvalho de Melo
> wrote:
> >
> > Em Thu, Jul 18, 2019 at 03:56:19PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > I'll stop and replace my patch with yours to see if it survives all th
In case of error, the function of_get_mac_address() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Signed-off-by: Wei Yongjun
Reviewed-by: Oleksij Rempel
---
v1 -> v2: fi
Fix to return error code -ENOMEM from the dmam_alloc_coherent() error
handling case instead of 0, as done elsewhere in this function.
Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Signed-off-by: Wei Yongjun
Reviewed-by: Oleksij Rempel
---
v1 -> v2: fix subsystem prefix
---
drivers/ne
On 7/17/19 8:28 PM, Andrew Lunn wrote:
On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote:
On 7/8/19 7:14 PM, Andrew Lunn wrote:
+static int ionic_set_pauseparam(struct net_device *netdev,
+ struct ethtool_pauseparam *pause)
+{
+ struct lif *lif =
From: Stefan Roese
Date: Wed, 17 Jul 2019 13:02:43 +0200
> This patch adds support for the MediaTek MT7628/88 SoCs to the common
> MediaTek ethernet driver. Some minor changes are needed for this and
> a bigger change, as the MT7628 does not support QDMA (only PDMA).
>
> Signed-off-by: Stefan Ro
From: Michael Chan
Date: Wed, 17 Jul 2019 03:07:23 -0400
> Unlike legacy chips, 57500 chips don't need additional VNIC resources
> for aRFS/ntuple. Fix the code accordingly so that we don't reserve
> and allocate additional VNICs on 57500 chips. Without this patch,
> the driver is failing to in
From: Wei Yongjun
Date: Wed, 17 Jul 2019 06:29:56 +
> Add the missing unlock before return from function sk_buff()
> in the error handling case.
>
> Fixes: f3097be21bf1 ("net: dsa: sja1105: Add a state machine for RX
> timestamping")
> Signed-off-by: Wei Yongjun
Applied.
From: Brian King
Date: Mon, 15 Jul 2019 16:41:50 -0500
> This patch fixes an issue seen on Power systems with bnx2x which results
> in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb
> pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons
> load in bnx2x_tx_int. Addi
Please resubmit these two ag71xx patches, you use a different subsystem
prefix in the Subject lines, so you should make them consistent.
Using just "ag71xx: " is perfectly fine.
Thank you.
On 7/18/19 1:55 PM, Vedang Patel wrote:
> ETF Qdisc currently checks for a socket with SO_TXTIME socket option. If
> either is not present, the packet is dropped. In the future commits, we
> want other Qdiscs to add packet with launchtime to the ETF Qdisc. Also,
> there are some packets (e.g. ICMP
On 7/11/19 2:14 AM, Paul Blakey wrote:
> Hi,
>
> This patch series add connection tracking capabilities in tc.
> It does so via a new tc action, called act_ct, and new tc flower classifier
> matching.
> Act ct and relevant flower matches, are still under review in net-next
> mailing list.
>
..
On Thu, Jul 18, 2019 at 12:14 PM Arnaldo Carvalho de Melo
wrote:
>
> Em Thu, Jul 18, 2019 at 03:56:19PM -0300, Arnaldo Carvalho de Melo escreveu:
> > I'll stop and replace my patch with yours to see if it survives all the
> > test builds...
>
> So, Alpine:3.4, the first image for this distro I did
From: Alexei Starovoitov
Date: Thu, 18 Jul 2019 14:00:25 -0700
> The following pull-request contains BPF updates for your *net* tree.
...
Pulled, thanks Alexei.
Hi David,
The following pull-request contains BPF updates for your *net* tree.
The main changes are:
1) verifier precision propagation fix, from Andrii.
2) BTF size fix for typedefs, from Andrii.
3) a bunch of big endian fixes, from Ilya.
4) wide load from bpf_sock_addr fixes, from Stanislav.
On Wed, Jul 17, 2019 at 5:29 AM Ilya Leoshkevich wrote:
>
> test_xdp_noinline fails on s390 due to a handful of endianness issues.
> Use ntohs for parsing eth_proto.
> Replace bswaps with ntohs/htons.
>
> Signed-off-by: Ilya Leoshkevich
> Acked-by: Vasily Gorbik
Applied. Thanks
On Thu, Jul 18, 2019 at 2:14 AM Ilya Leoshkevich wrote:
>
> This test looks up a 32-bit map element and then loads it using a 64-bit
> load. This does not work on s390, which is a big-endian machine.
>
> Since the point of this test doesn't seem to be loading a smaller value
> using a larger load,
On Thu, Jul 18, 2019 at 05:01:03PM +0200, Ilya Leoshkevich wrote:
> The very first check in test_pkt_md_access is failing on s390, which
> happens because loading a part of a struct __sk_buff field produces
> an incorrect result.
>
> The preprocessed code of the check is:
>
> {
> __u8 tmp =
From: David Miller
Date: Thu, 18 Jul 2019 12:39:39 -0700 (PDT)
> Series applied, thank you.
Actually, I had to revert, this breaks the build:
In file included from ./include/net/netfilter/nf_tables_offload.h:4,
from :
./include/net/flow_offload.h: In function ‘flow_block_cb_add
This adds support for setting the txtime_delay parameter which is useful
for the txtime offload mode of taprio.
Signed-off-by: Vedang Patel
---
tc/q_taprio.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/tc/q_taprio.c b/tc/q_taprio.c
index 1db2aba6e
Add documentation for the latest options, flags and txtime-delay, to the
taprio manpage.
This also adds an example to run tc in txtime offload mode.
Signed-off-by: Vedang Patel
---
man/man8/tc-taprio.8 | 40
1 file changed, 40 insertions(+)
diff --git a
From: Vinicius Costa Gomes
This allows a new parameter, flags, to be passed to taprio. Currently, it
only supports enabling the txtime-assist mode. But, we plan to add
different modes for taprio (e.g. hardware offloading) and this parameter
will be useful in enabling those modes.
Signed-off-by:
Document the newly added option (skip_sock_check) on the etf man-page.
Signed-off-by: Vedang Patel
---
man/man8/tc-etf.8 | 10 ++
1 file changed, 10 insertions(+)
diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
index 30a12de7d2c7..4cb3b9e02d6e 100644
--- a/man/man8/tc-etf.8
+++ b/man
ETF Qdisc currently checks for a socket with SO_TXTIME socket option. If
either is not present, the packet is dropped. In the future commits, we
want other Qdiscs to add packet with launchtime to the ETF Qdisc. Also,
there are some packets (e.g. ICMP packets) which may not have a socket
associated
> On Jul 18, 2019, at 10:36 AM, David Ahern wrote:
>
> On 7/16/19 1:53 PM, Vedang Patel wrote:
>> Document the newly added option (skip-skb-check) on the etf man-page.
>>
>> Signed-off-by: Vedang Patel
>> ---
>> man/man8/tc-etf.8 | 10 ++
>> 1 file changed, 10 insertions(+)
>>
>> dif
> On Jul 18, 2019, at 10:32 AM, David Ahern wrote:
>
> On 7/16/19 1:53 PM, Vedang Patel wrote:
>> The type for txtime-delay parameter will change from s32 to u32. So,
>> make the corresponding change in the ABI file as well.
>>
>> Signed-off-by: Vedang Patel
>> ---
>> include/uapi/linux/pkt_
From: Pablo Neira Ayuso
Date: Thu, 18 Jul 2019 19:59:27 +0200
> The following patchset contains fixes for the flow_offload infrastructure:
>
> 1) Fix possible build breakage before patch 3/4. Both the flow_offload
>infrastructure and OVS define the flow_stats structure. Patch 3/4 in
>thi
Em Thu, Jul 18, 2019 at 03:56:19PM -0300, Arnaldo Carvalho de Melo escreveu:
> I'll stop and replace my patch with yours to see if it survives all the
> test builds...
So, Alpine:3.4, the first image for this distro I did when I started
these builds, survives the 6 builds with gcc and clang with y
From: Jakub Kicinski
Date: Thu, 18 Jul 2019 10:08:47 -0700
> Yes, certainly. It's documentation and renaming a stat before it makes
> it into an official release.
Agreed.
From: Ilias Apalodimas
Date: Thu, 18 Jul 2019 17:38:30 +0300
> Add myself to maintainers since i provided the XDP and page_pool
> implementation
>
> Signed-off-by: Ilias Apalodimas
Applied.
From: David Ahern
Date: Thu, 18 Jul 2019 08:21:01 -0600
> On 7/17/19 2:39 PM, Ido Schimmel wrote:
>> From: Ido Schimmel
>>
>> When a route needs to be appended to an existing multipath route,
>> fib6_add_rt2node() first appends it to the siblings list and increments
>> the number of sibling rou
From: Chuhong Yuan
Date: Thu, 18 Jul 2019 15:45:42 +0800
> Use vzalloc and vzalloc_node instead of using vmalloc and
> vmalloc_node and then zeroing the allocated memory by
> memset 0.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan
Applied.
Em Thu, Jul 18, 2019 at 11:04:04AM -0700, Andrii Nakryiko escreveu:
> On Thu, Jul 18, 2019 at 10:55 AM Arnaldo Carvalho de Melo
> wrote:
> >
> > Em Thu, Jul 18, 2019 at 10:25:13AM -0700, Andrii Nakryiko escreveu:
> > > hashmap.h depends on __WORDSIZE being defined. It is defined by
> > > glibc/mus
On Thu, 18 Jul 2019 16:20:41 +0200, Ilya Leoshkevich wrote:
> Hi Lorenz,
>
> I've been using the following patch for quite some time now.
> Please let me know if it works for you.
>
> Best regards,
> Ilya
>
> ---
>
> When OUTPUT is set, bpftool and libbpf put their objects into the same
> direc
On 7/18/19 5:12 AM, Manish Chopra wrote:
>> -Original Message-
>> From: Brian King
>> Sent: Tuesday, July 16, 2019 3:12 AM
>> To: GR-everest-linux-l2
>> Cc: Sudarsana Reddy Kalluru ; Ariel Elior
>> ; netdev@vger.kernel.org; Brian King
>>
>> Subject: [EXT] [PATCH] bnx2x: Prevent load reor
On Thu, Jul 18, 2019 at 10:55 AM Arnaldo Carvalho de Melo
wrote:
>
> Em Thu, Jul 18, 2019 at 10:25:13AM -0700, Andrii Nakryiko escreveu:
> > hashmap.h depends on __WORDSIZE being defined. It is defined by
> > glibc/musl in different headers. It's an explicit goal for musl to be
> > "non-detectable
Rename this type definition and adapt users.
Signed-off-by: Pablo Neira Ayuso
Acked-by: Jiri Pirko
---
v4: no changes.
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +-
drivers/net/ethernet/mscc/ocelot_tc.c | 2 +-
include/net/flow_offload.h | 16 ++-
This object stores the flow block callbacks that are attached to this
block. Update flow_block_cb_lookup() to take this new object.
This patch restores the block sharing feature.
Fixes: da3eeb904ff4 ("net: flow_offload: add list handling functions")
Signed-off-by: Pablo Neira Ayuso
---
v3: add f
No need to annotate the netns on the flow block callback object,
flow_block_cb_is_busy() already checks for used blocks.
Fixes: d63db30c8537 ("net: flow_offload: add flow_block_cb_alloc() and
flow_block_cb_free()")
Signed-off-by: Pablo Neira Ayuso
Acked-by: Jiri Pirko
---
v4: no changes.
driv
Hi,
The following patchset contains fixes for the flow_offload infrastructure:
1) Fix possible build breakage before patch 3/4. Both the flow_offload
infrastructure and OVS define the flow_stats structure. Patch 3/4 in
this batch indirectly pulls in the flow_stats definition from
include
There is a flow_stats structure defined in include/net/flow_offload.h
and a follow up patch adds #include to
net/sch_generic.h.
This breaks compilation since OVS codebase includes net/sock.h which
pulls in linux/filter.h which includes net/sch_generic.h.
In file included from ./include/net/sch_g
Em Thu, Jul 18, 2019 at 10:25:13AM -0700, Andrii Nakryiko escreveu:
> hashmap.h depends on __WORDSIZE being defined. It is defined by
> glibc/musl in different headers. It's an explicit goal for musl to be
> "non-detectable" at compilation time, so instead include glibc header if
> glibc is explici
On 7/18/19 10:28 AM, Andrew Lunn wrote:
On Thu, Jul 18, 2019 at 10:05:23AM -0700, Shannon Nelson wrote:
On 7/17/19 8:21 PM, Andrew Lunn wrote:
On Tue, Jul 09, 2019 at 03:42:39PM -0700, Shannon Nelson wrote:
On 7/8/19 7:27 PM, Andrew Lunn wrote:
+static int ionic_get_module_eeprom(struct net_d
On 7/16/19 1:53 PM, Vedang Patel wrote:
> Document the newly added option (skip-skb-check) on the etf man-page.
>
> Signed-off-by: Vedang Patel
> ---
> man/man8/tc-etf.8 | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
> index 30a12de7d2
On Thu, Jul 18, 2019 at 10:30 AM Andrii Nakryiko wrote:
>
> hashmap.h depends on __WORDSIZE being defined. It is defined by
> glibc/musl in different headers. It's an explicit goal for musl to be
> "non-detectable" at compilation time, so instead include glibc header if
> glibc is explicitly detec
On 7/16/19 1:53 PM, Vedang Patel wrote:
> The type for txtime-delay parameter will change from s32 to u32. So,
> make the corresponding change in the ABI file as well.
>
> Signed-off-by: Vedang Patel
> ---
> include/uapi/linux/pkt_sched.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
hashmap.h depends on __WORDSIZE being defined. It is defined by
glibc/musl in different headers. It's an explicit goal for musl to be
"non-detectable" at compilation time, so instead include glibc header if
glibc is explicitly detected and fall back to musl header otherwise.
Fixes: e3b924224028 ("
On Thu, Jul 18, 2019 at 10:05:23AM -0700, Shannon Nelson wrote:
> On 7/17/19 8:21 PM, Andrew Lunn wrote:
> >On Tue, Jul 09, 2019 at 03:42:39PM -0700, Shannon Nelson wrote:
> >>On 7/8/19 7:27 PM, Andrew Lunn wrote:
> +static int ionic_get_module_eeprom(struct net_device *netdev,
> +
On Thu, Jul 18, 2019 at 10:25 AM Andrii Nakryiko wrote:
>
> hashmap.h depends on __WORDSIZE being defined. It is defined by
> glibc/musl in different headers. It's an explicit goal for musl to be
> "non-detectable" at compilation time, so instead include glibc header if
> glibc is explicitly detec
hashmap.h depends on __WORDSIZE being defined. It is defined by
glibc/musl in different headers. It's an explicit goal for musl to be
"non-detectable" at compilation time, so instead include glibc header if
glibc is explicitly detected and fall back to musl header otherwise.
Fixes: e3b924224028 ("
On 7/16/19 11:29 PM, Wei Yongjun wrote:
> Add the missing unlock before return from function sk_buff()
> in the error handling case.
>
> Fixes: f3097be21bf1 ("net: dsa: sja1105: Add a state machine for RX
> timestamping")
> Signed-off-by: Wei Yongjun
Reviewed-by: Florian Fainelli
--
Florian
On 7/17/19 6:42 PM, Benjamin Poirier wrote:
> As pointed out by Firo Yang, a netdev tx timeout may trigger just before an
> ethtool set_channels operation is started. be_tx_timeout(), which dumps
> some queue structures, is not written to run concurrently with
> be_update_queues(), which frees/allo
On 7/12/19 11:02 AM, Andrea Claudi wrote:
> print_tunnel() functions in ip6tunnel.c and iptunnel.c contains
> the same code to print out GRE key and flags
>
> This commit factorize the code in a helper function in tunnel.c
>
> Signed-off-by: Andrea Claudi
> ---
> ip/ip6tunnel.c | 22 ++-
On 7/17/19 8:31 PM, Andrew Lunn wrote:
On Fri, Jul 12, 2019 at 10:32:38PM -0700, Shannon Nelson wrote:
On 7/8/19 7:30 PM, Andrew Lunn wrote:
+static int ionic_nway_reset(struct net_device *netdev)
+{
+ struct lif *lif = netdev_priv(netdev);
+ int err = 0;
+
+ if (netif_running
On Thu, 18 Jul 2019 07:40:22 +, Tariq Toukan wrote:
> On 7/17/2019 8:41 PM, Jakub Kicinski wrote:
> > On Sun, 7 Jul 2019 06:44:27 +, Tariq Toukan wrote:
> >> On 7/6/2019 2:29 AM, David Miller wrote:
> >>> From: Tariq Toukan
> >>> Date: Fri, 5 Jul 2019 18:30:10 +0300
> >>>
>
On 7/17/19 8:21 PM, Andrew Lunn wrote:
On Tue, Jul 09, 2019 at 03:42:39PM -0700, Shannon Nelson wrote:
On 7/8/19 7:27 PM, Andrew Lunn wrote:
+static int ionic_get_module_eeprom(struct net_device *netdev,
+ struct ethtool_eeprom *ee,
+
On 7/18/19 10:52 AM, Marcelo Ricardo Leitner wrote:
> On Thu, Jul 18, 2019 at 03:00:34PM +, Paul Blakey wrote:
>> Hey guys,
>>
>> any more comments?
>
> From my side, just the man page on tc-ct(8) that is missing.
> Everything else seems to be in place.
>
> Thanks,
> Marcelo
>
Paul: If ther
On Thu, Jul 18, 2019 at 03:00:34PM +, Paul Blakey wrote:
> Hey guys,
>
> any more comments?
>From my side, just the man page on tc-ct(8) that is missing.
Everything else seems to be in place.
Thanks,
Marcelo
On Thu, Jul 18, 2019 at 1:49 PM Lucas Stach wrote:
>
> Am Donnerstag, den 18.07.2019, 10:34 -0400 schrieb Sven Van Asbroeck:
> > Allowing the fec to reset its PHY via the phy-reset-gpios
> > devicetree property is deprecated. To improve developer
> > awareness, generate a warning whenever the depr
On Wed, 17 Jul 2019 06:29:56 +, Wei Yongjun wrote:
> Add the missing unlock before return from function sk_buff()
> in the error handling case.
>
> Fixes: f3097be21bf1 ("net: dsa: sja1105: Add a state machine for RX
> timestamping")
> Signed-off-by: Wei Yongjun
Reviewed-by: Vivien Didelot
On Thu, 18 Jul 2019 at 16:52, Jassi Brar wrote:
>
> On Thu, 18 Jul 2019 at 09:38, Ilias Apalodimas
> wrote:
> >
> > Add myself to maintainers since i provided the XDP and page_pool
> > implementation
> >
> Yes, please.
>
> Acked-by: Jassi Brar
>
Acked-by: Ard Biesheuvel
On Thu, Jul 18, 2019 at 8:01 AM Ilya Leoshkevich wrote:
>
> The very first check in test_pkt_md_access is failing on s390, which
> happens because loading a part of a struct __sk_buff field produces
> an incorrect result.
>
> The preprocessed code of the check is:
>
> {
> __u8 tmp = *((vol
The very first check in test_pkt_md_access is failing on s390, which
happens because loading a part of a struct __sk_buff field produces
an incorrect result.
The preprocessed code of the check is:
{
__u8 tmp = *((volatile __u8 *)&skb->len +
((sizeof(skb->len) - sizeof(__u8
Hey guys,
any more comments?
thanks,
Paul.
On Thu, 18 Jul 2019 at 09:38, Ilias Apalodimas
wrote:
>
> Add myself to maintainers since i provided the XDP and page_pool
> implementation
>
Yes, please.
Acked-by: Jassi Brar
> Signed-off-by: Ilias Apalodimas
Add myself to maintainers since i provided the XDP and page_pool
implementation
Signed-off-by: Ilias Apalodimas
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 211ea3a199bd..64f659d8346c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14789,6 +1
Hi Lorenz,
I've been using the following patch for quite some time now.
Please let me know if it works for you.
Best regards,
Ilya
---
When OUTPUT is set, bpftool and libbpf put their objects into the same
directory, and since some of them have the same names, the collision
happens.
Fix by inv
On 7/17/19 2:39 PM, Ido Schimmel wrote:
> From: Ido Schimmel
>
> When a route needs to be appended to an existing multipath route,
> fib6_add_rt2node() first appends it to the siblings list and increments
> the number of sibling routes on each sibling.
>
> Later, the function notifies the route
Quoting from
https://bugzilla.kernel.org/show_bug.cgi?id=204155
1. Configure an PPPoE interface (e.g., ppp0) with an IPv6 address and
a prefixlen of 64; e.g., 2001:0DB8::1/64.
2. Configure a Netfilter ip6table rule to drop IN to OUT forwarding of traffic
across the PPP interface: ip6ta
> -Original Message-
> From: Brian King
> Sent: Tuesday, July 16, 2019 3:12 AM
> To: GR-everest-linux-l2
> Cc: Sudarsana Reddy Kalluru ; Ariel Elior
> ; netdev@vger.kernel.org; Brian King
>
> Subject: [EXT] [PATCH] bnx2x: Prevent load reordering in tx completion
> processing
>
> Externa
This test looks up a 32-bit map element and then loads it using a 64-bit
load. This does not work on s390, which is a big-endian machine.
Since the point of this test doesn't seem to be loading a smaller value
using a larger load, simply use a 32-bit load.
Signed-off-by: Ilya Leoshkevich
---
to
On 7/18/19 9:49 AM, Jacob Wen wrote:
> Hi,
>
> inet_gro_receive verifies IP csum but a NIC already did so and set
> CHECKSUM_UNNECESSARY.
>
>
> https://github.com/torvalds/linux/blob/v5.2/net/ipv4/af_inet.c#L1432-L1433
>
> if (unlikely(ip_fast_csum((u8 *)iph, 5)))
>
> goto out_unlo
Hi,
inet_gro_receive verifies IP csum but a NIC already did so and set
CHECKSUM_UNNECESSARY.
https://github.com/torvalds/linux/blob/v5.2/net/ipv4/af_inet.c#L1432-L1433
if (unlikely(ip_fast_csum((u8 *)iph, 5)))
goto out_unlock;
Is this a bug?
On 17.07.19 13:52, Wei Yongjun wrote:
Fix to return error code -ENOMEM from the dmam_alloc_coherent() error
handling case instead of 0, as done elsewhere in this function.
Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Signed-off-by: Wei Yongjun
Reviewed-by: Oleksij Rempel
---
On 7/17/2019 8:41 PM, Jakub Kicinski wrote:
> On Sun, 7 Jul 2019 06:44:27 +, Tariq Toukan wrote:
>> On 7/6/2019 2:29 AM, David Miller wrote:
>>> From: Tariq Toukan
>>> Date: Fri, 5 Jul 2019 18:30:10 +0300
>>>
This series from Eran and me, adds TLS TX HW offload support to
the
On 17.07.19 13:52, Wei Yongjun wrote:
In case of error, the function of_get_mac_address() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Signed-off-by: Wei Yongjun
On Mon, Jul 15, 2019 at 12:00:19PM +0200, Nicolas Dichtel wrote:
>
> Here is a bunch of bugs fixes. Some have been seen by code review and some
> when
> playing with x-netns.
> The details are in each patch.
>
> v1 -> v2:
> - add patch #3 and #4
Series applied, thanks Nicolas!
92 matches
Mail list logo
