Re: [PATCH v3 bpf-next 05/12] libbpf: add resizable non-thread safe internal hashmap

2019-07-17 Thread Andrii Nakryiko
On Wed, Jul 17, 2019 at 5:24 PM Arnaldo Carvalho de Melo wrote: > > Em Fri, May 24, 2019 at 11:59:00AM -0700, Andrii Nakryiko escreveu: > > There is a need for fast point lookups inside libbpf for multiple use > > cases (e.g., name resolution for BTF-to-C conversion, by-name lookups in > > BTF for

Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-17 Thread Andrew Lunn
On Fri, Jul 12, 2019 at 10:32:38PM -0700, Shannon Nelson wrote: > On 7/8/19 7:30 PM, Andrew Lunn wrote: > >>+static int ionic_nway_reset(struct net_device *netdev) > >>+{ > >>+ struct lif *lif = netdev_priv(netdev); > >>+ int err = 0; > >>+ > >>+ if (netif_running(netdev)) > >>+ err

Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-17 Thread Andrew Lunn
On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote: > On 7/8/19 7:14 PM, Andrew Lunn wrote: > >>+static int ionic_set_pauseparam(struct net_device *netdev, > >>+ struct ethtool_pauseparam *pause) > >>+{ > >>+ struct lif *lif = netdev_priv(netdev); > >>+ str

Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-17 Thread Andrew Lunn
On Tue, Jul 09, 2019 at 03:42:39PM -0700, Shannon Nelson wrote: > On 7/8/19 7:27 PM, Andrew Lunn wrote: > >>+static int ionic_get_module_eeprom(struct net_device *netdev, > >>+ struct ethtool_eeprom *ee, > >>+ u8 *data) > >>+{ > >>+ struct

[PATCH net] be2net: Synchronize be_update_queues with dev_watchdog

2019-07-17 Thread Benjamin Poirier
As pointed out by Firo Yang, a netdev tx timeout may trigger just before an ethtool set_channels operation is started. be_tx_timeout(), which dumps some queue structures, is not written to run concurrently with be_update_queues(), which frees/allocates those queues structures. Add some synchronizat

Re: [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio

2019-07-17 Thread Andrew Lunn
On Tue, Jul 09, 2019 at 04:03:28PM -0600, Rob Herring wrote: > On Mon, Jul 8, 2019 at 8:41 PM Andrew Lunn wrote: > > > > > > Optional properties: > > > > - interrupts: interrupt line number for the SMI error/done interrupt > > > > -- clocks: phandle for up to three required clocks for the MDIO i

[PATCH iproute2] json: fix backslash escape typo in jsonw_puts

2019-07-17 Thread Ivan Delalande
Fixes: fcc16c22 ("provide common json output formatter") Signed-off-by: Ivan Delalande --- lib/json_writer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/json_writer.c b/lib/json_writer.c index 5004c181..88c5eb88 100644 --- a/lib/json_writer.c +++ b/lib/json_writer.c @@

Re: [PATCH v3 bpf-next 05/12] libbpf: add resizable non-thread safe internal hashmap

2019-07-17 Thread Arnaldo Carvalho de Melo
Em Fri, May 24, 2019 at 11:59:00AM -0700, Andrii Nakryiko escreveu: > There is a need for fast point lookups inside libbpf for multiple use > cases (e.g., name resolution for BTF-to-C conversion, by-name lookups in > BTF for upcoming BPF CO-RE relocation support, etc). This patch > implements simpl

Re: phylink: flow control on fixed-link not working.

2019-07-17 Thread René van Dorst
Quoting Russell King - ARM Linux admin : On Wed, Jul 17, 2019 at 09:31:11PM +, René van Dorst wrote: Hi, I am trying to enable flow control/pause on PHYLINK and fixed-link. My setup SOC mac (mt7621) <-> RGMII <-> SWITCH mac (mt7530). It seems that in fixed-link mode all the flow control/

Re: [PATCH] qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/

2019-07-17 Thread Benjamin Poirier
On 2019/07/17 12:02, David Miller wrote: > From: Benjamin Poirier > Date: Tue, 16 Jul 2019 11:34:59 +0900 > > > The hardware has been declared EOL by the vendor more than 5 years ago. > > What's more relevant to the Linux kernel is that the quality of this driver > > is not on par with many other

Re: [PATCH net] ipv6: rt6_check should return NULL if 'from' is NULL

2019-07-17 Thread David Miller
From: David Ahern Date: Wed, 17 Jul 2019 15:08:43 -0700 > From: David Ahern > > Paul reported that l2tp sessions were broken after the commit referenced > in the Fixes tag. Prior to this commit rt6_check returned NULL if the > rt6_info 'from' was NULL - ie., the dst_entry was disconnected from

Re: [net 1/1] tipc: initialize 'validated' field of received packets

2019-07-17 Thread David Miller
From: Jon Maloy Date: Wed, 17 Jul 2019 23:43:44 +0200 > The tipc_msg_validate() function leaves a boolean flag 'validated' in > the validated buffer's control block, to avoid performing this action > more than once. However, at reception of new packets, the position of > this field may already ha

Re: [PATCH bpf] bpf: fix narrower loads on s390

2019-07-17 Thread Y Song
On Wed, Jul 17, 2019 at 1:52 PM Ilya Leoshkevich wrote: > > > Am 17.07.2019 um 18:25 schrieb Y Song : > > > > On Wed, Jul 17, 2019 at 3:36 AM Ilya Leoshkevich wrote: > >> > >> > >> Here is a better one: len=0x11223344 and we would like to do > >> ((u8 *)&len)[3]. > >> > >> len is represented as `

Re: [Patch net v3 0/2] ipv4: relax source validation check for loopback packets

2019-07-17 Thread David Miller
From: Cong Wang Date: Wed, 17 Jul 2019 14:41:57 -0700 > This patchset fixes a corner case when loopback packets get dropped > by rp_filter when we route them from veth to lo. Patch 1 is the fix > and patch 2 provides a simplified test case for this scenario. Series applied, thanks Cong.

Re: [PATCH net 0/2] mlxsw: Two fixes

2019-07-17 Thread David Miller
From: Ido Schimmel Date: Wed, 17 Jul 2019 23:29:06 +0300 > From: Ido Schimmel > > This patchset contains two fixes for mlxsw. > > Patch #1 from Petr fixes an issue in which DSCP rewrite can occur even > if the egress port was switched to Trust L2 mode where priority mapping > is based on PCP.

Re: [PATCHv2] net: ag71xx: Add missing header

2019-07-17 Thread David Miller
From: Rosen Penev Date: Wed, 17 Jul 2019 12:46:45 -0700 > ag71xx uses devm_ioremap_nocache. This fixes usage of an implicit function > > Fixes: d51b6ce441d356369387d20bc1de5f2edb0ab71e > > Signed-off-by: Rosen Penev Applied.

Re: [PATCH net,v3 1/4] net: openvswitch: rename flow_stats to sw_flow_stats

2019-07-17 Thread David Miller
What is this series doing? Where is your "0/4" cover letter which would tell us this? Also: > OVS compilation breaks here after this patchset since flow_stats > structure is already defined in include/net/flow_offload.h. This patch > is new in this batch. You need to explain in more detail an

[PATCH net] ipv6: rt6_check should return NULL if 'from' is NULL

2019-07-17 Thread David Ahern
From: David Ahern Paul reported that l2tp sessions were broken after the commit referenced in the Fixes tag. Prior to this commit rt6_check returned NULL if the rt6_info 'from' was NULL - ie., the dst_entry was disconnected from a FIB entry. Restore that behavior. Fixes: 93531c674315 ("net/ipv6:

Re: [Patch net v3 1/2] fib: relax source validation check for loopback packets

2019-07-17 Thread David Ahern
On 7/17/19 3:41 PM, Cong Wang wrote: > In a rare case where we redirect local packets from veth to lo, > these packets fail to pass the source validation when rp_filter > is turned on, as the tracing shows: > > <...>-311708 [040] ..s1 7951180.957825: fib_table_lookup: table 254 oif 0 > iif 1 sr

Re: [Patch net v3 2/2] selftests: add a test case for rp_filter

2019-07-17 Thread David Ahern
On 7/17/19 3:41 PM, Cong Wang wrote: > Add a test case to simulate the loopback packet case fixed > in the previous patch. > > This test gets passed after the fix: > > IPv4 rp_filter tests > TEST: rp_filter passes local packets[ OK ] > TEST: rp_filter passe

Re: phylink: flow control on fixed-link not working.

2019-07-17 Thread Russell King - ARM Linux admin
On Wed, Jul 17, 2019 at 09:31:11PM +, René van Dorst wrote: > Hi, > > I am trying to enable flow control/pause on PHYLINK and fixed-link. > > My setup SOC mac (mt7621) <-> RGMII <-> SWITCH mac (mt7530). > > It seems that in fixed-link mode all the flow control/pause bits are cleared > in > p

[net 1/1] tipc: initialize 'validated' field of received packets

2019-07-17 Thread Jon Maloy
The tipc_msg_validate() function leaves a boolean flag 'validated' in the validated buffer's control block, to avoid performing this action more than once. However, at reception of new packets, the position of this field may already have been set by lower layer protocols, so that the packet is erro

[Patch net v3 1/2] fib: relax source validation check for loopback packets

2019-07-17 Thread Cong Wang
In a rare case where we redirect local packets from veth to lo, these packets fail to pass the source validation when rp_filter is turned on, as the tracing shows: <...>-311708 [040] ..s1 7951180.957825: fib_table_lookup: table 254 oif 0 iif 1 src 10.53.180.130 dst 10.53.180.130 tos 0 scope 0 f

[Patch net v3 0/2] ipv4: relax source validation check for loopback packets

2019-07-17 Thread Cong Wang
This patchset fixes a corner case when loopback packets get dropped by rp_filter when we route them from veth to lo. Patch 1 is the fix and patch 2 provides a simplified test case for this scenario. Cong Wang (2): fib: relax source validation check for loopback packets selftests: add a test ca

[Patch net v3 2/2] selftests: add a test case for rp_filter

2019-07-17 Thread Cong Wang
Add a test case to simulate the loopback packet case fixed in the previous patch. This test gets passed after the fix: IPv4 rp_filter tests TEST: rp_filter passes local packets[ OK ] TEST: rp_filter passes loopback packets [ OK ]

phylink: flow control on fixed-link not working.

2019-07-17 Thread René van Dorst
Hi, I am trying to enable flow control/pause on PHYLINK and fixed-link. My setup SOC mac (mt7621) <-> RGMII <-> SWITCH mac (mt7530). It seems that in fixed-link mode all the flow control/pause bits are cleared in phylink_parse_fixedlink(). If I read phylink_parse_fixedlink() [0] correctly, I

Re: [PATCH bpf] bpf: fix narrower loads on s390

2019-07-17 Thread Ilya Leoshkevich
> Am 17.07.2019 um 18:25 schrieb Y Song : > > On Wed, Jul 17, 2019 at 3:36 AM Ilya Leoshkevich wrote: >> >> >> Here is a better one: len=0x11223344 and we would like to do >> ((u8 *)&len)[3]. >> >> len is represented as `11 22 33 44` in memory, so the desired result is >> 0x44. It can be obtai

[PATCH net] ipv6: Unlink sibling route in case of failure

2019-07-17 Thread Ido Schimmel
From: Ido Schimmel When a route needs to be appended to an existing multipath route, fib6_add_rt2node() first appends it to the siblings list and increments the number of sibling routes on each sibling. Later, the function notifies the route via call_fib6_entry_notifiers(). In case the notificat

Re: [Patch net v2] net_sched: unset TCQ_F_CAN_BYPASS when adding filters

2019-07-17 Thread David Miller
From: Eric Dumazet Date: Wed, 17 Jul 2019 21:19:51 +0200 > On Wed, Jul 17, 2019 at 9:04 PM David Miller wrote: >> >> From: Cong Wang >> Date: Tue, 16 Jul 2019 13:57:30 -0700 >> >> > For qdisc's that support TC filters and set TCQ_F_CAN_BYPASS, >> > notably fq_codel, it makes no sense to let pac

[PATCH net 2/2] mlxsw: spectrum: Do not process learned records with a dummy FID

2019-07-17 Thread Ido Schimmel
From: Ido Schimmel The switch periodically sends notifications about learned FDB entries. Among other things, the notification includes the FID (Filtering Identifier) and the port on which the MAC was learned. In case the driver does not have the FID defined on the relevant port, the following e

[PATCH net 0/2] mlxsw: Two fixes

2019-07-17 Thread Ido Schimmel
From: Ido Schimmel This patchset contains two fixes for mlxsw. Patch #1 from Petr fixes an issue in which DSCP rewrite can occur even if the egress port was switched to Trust L2 mode where priority mapping is based on PCP. Patch #2 fixes a problem where packets can be learned on a non-existing

[PATCH net 1/2] mlxsw: spectrum_dcb: Configure DSCP map as the last rule is removed

2019-07-17 Thread Ido Schimmel
From: Petr Machata Spectrum systems use DSCP rewrite map to update DSCP field in egressing packets to correspond to priority that the packet has. Whether rewriting will take place is determined at the point when the packet ingresses the switch: if the port is in Trust L3 mode, packet priority is

[PATCHv2] net: ag71xx: Add missing header

2019-07-17 Thread Rosen Penev
ag71xx uses devm_ioremap_nocache. This fixes usage of an implicit function Fixes: d51b6ce441d356369387d20bc1de5f2edb0ab71e Signed-off-by: Rosen Penev --- v2: Target net instead of net-next drivers/net/ethernet/atheros/ag71xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/eth

[PATCH net,v3 2/4] net: flow_offload: remove netns parameter from flow_block_cb_alloc()

2019-07-17 Thread Pablo Neira Ayuso
No need to annotate the netns on the flow block callback object, flow_block_cb_is_busy() already checks for used blocks. Fixes: d63db30c8537 ("net: flow_offload: add flow_block_cb_alloc() and flow_block_cb_free()") Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko --- v3: no changes. driv

[PATCH net,v3 1/4] net: openvswitch: rename flow_stats to sw_flow_stats

2019-07-17 Thread Pablo Neira Ayuso
There is a flow_stats structure defined in include/net/flow_offload.h which is placed in the networking core. I think that definition takes precedence on OVS, so rename flow_stats in OVS to sw_flow_stats. Signed-off-by: Pablo Neira Ayuso --- OVS compilation breaks here after this patchset since f

[PATCH net,v3 3/4] net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t

2019-07-17 Thread Pablo Neira Ayuso
Rename this type definition and adapt users. Signed-off-by: Pablo Neira Ayuso Acked-by: Jiri Pirko --- v3: no changes. tc_setup_cb_t is now misleading, so better fix this semantic inconsistency in the net tree as Jiri suggests. drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- driver

[PATCH net,v3 4/4] net: flow_offload: add flow_block structure and use it

2019-07-17 Thread Pablo Neira Ayuso
This object stores the flow block callbacks that are attached to this block. Update flow_block_cb_lookup() to take this new object. This patch restores the block sharing feature. Fixes: da3eeb904ff4 ("net: flow_offload: add list handling functions") Signed-off-by: Pablo Neira Ayuso --- v3: add f

Re: [Patch net v2] net_sched: unset TCQ_F_CAN_BYPASS when adding filters

2019-07-17 Thread Eric Dumazet
On Wed, Jul 17, 2019 at 9:04 PM David Miller wrote: > > From: Cong Wang > Date: Tue, 16 Jul 2019 13:57:30 -0700 > > > For qdisc's that support TC filters and set TCQ_F_CAN_BYPASS, > > notably fq_codel, it makes no sense to let packets bypass the TC > > filters we setup in any scenario, otherwise

Re: [PATCH net v3 0/7] net/rds: RDMA fixes

2019-07-17 Thread David Miller
From: Gerd Rausch Date: Tue, 16 Jul 2019 15:28:43 -0700 > A number of net/rds fixes necessary to make "rds_rdma.ko" > pass some basic Oracle internal tests. Series applied.

Re: [Patch net v2] net_sched: unset TCQ_F_CAN_BYPASS when adding filters

2019-07-17 Thread David Miller
From: Cong Wang Date: Tue, 16 Jul 2019 13:57:30 -0700 > For qdisc's that support TC filters and set TCQ_F_CAN_BYPASS, > notably fq_codel, it makes no sense to let packets bypass the TC > filters we setup in any scenario, otherwise our packets steering > policy could not be enforced. ... Eric I

Re: [PATCH 2/2] net: apply proc_net_mkdir() harder

2019-07-17 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 16 Jul 2019 20:52:20 +0200 > On Sat, Jul 06, 2019 at 07:55:21PM +0300, Alexey Dobriyan wrote: >> From: "Hallsmark, Per" >> >> proc_net_mkdir() should be used to create stuff under /proc/net, >> so that dentry revalidation kicks in. >> >> See >> >> commi

Re: [PATCH] qlge: Move drivers/net/ethernet/qlogic/qlge/ to drivers/staging/qlge/

2019-07-17 Thread David Miller
From: Benjamin Poirier Date: Tue, 16 Jul 2019 11:34:59 +0900 > The hardware has been declared EOL by the vendor more than 5 years ago. > What's more relevant to the Linux kernel is that the quality of this driver > is not on par with many other mainline drivers. > > Cc: Manish Chopra > Message-

Re: [PATCH] net: sctp: fix warning "NULL check before some freeing functions is not needed"

2019-07-17 Thread David Miller
From: Hariprasad Kelam Date: Tue, 16 Jul 2019 07:50:02 +0530 > This patch removes NULL checks before calling kfree. > > fixes below issues reported by coccicheck > net/sctp/sm_make_chunk.c:2586:3-8: WARNING: NULL check before some > freeing functions is not needed. > net/sctp/sm_make_chunk.c:265

Re: [PATCH] bnx2x: Prevent load reordering in tx completion processing

2019-07-17 Thread David Miller
From: Brian King Date: Mon, 15 Jul 2019 16:41:50 -0500 > This patch fixes an issue seen on Power systems with bnx2x which results > in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb > pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons > load in bnx2x_tx_int. Addi

Re: [PATCH net] caif-hsi: fix possible deadlock in cfhsi_exit_module()

2019-07-17 Thread David Miller
From: Taehee Yoo Date: Mon, 15 Jul 2019 14:10:17 +0900 > cfhsi_exit_module() calls unregister_netdev() under rtnl_lock(). > but unregister_netdev() internally calls rtnl_lock(). > So deadlock would occur. > > Fixes: c41254006377 ("caif-hsi: Add rtnl support") > Signed-off-by: Taehee Yoo Applie

Re: [PATCH] net: dsa: sja1105: Fix missing unlock on error in sk_buff()

2019-07-17 Thread Vladimir Oltean
On Wed, 17 Jul 2019 at 09:24, Wei Yongjun wrote: > > Add the missing unlock before return from function sk_buff() > in the error handling case. > > Fixes: f3097be21bf1 ("net: dsa: sja1105: Add a state machine for RX > timestamping") > Signed-off-by: Wei Yongjun > --- Reviewed-by: Vladimir Oltea

Re: [PATCH net-next 00/12] mlx5 TLS TX HW offload support

2019-07-17 Thread Jakub Kicinski
On Sun, 7 Jul 2019 06:44:27 +, Tariq Toukan wrote: > On 7/6/2019 2:29 AM, David Miller wrote: > > From: Tariq Toukan > > Date: Fri, 5 Jul 2019 18:30:10 +0300 > > > >> This series from Eran and me, adds TLS TX HW offload support to > >> the mlx5 driver. > > > > Series applied, please dea

[PATCH net-next v2 2/2] tc-testing: updated skbedit action tests with batch create/delete

2019-07-17 Thread Roman Mashak
Update TDC tests with cases varifying ability of TC to install or delete batches of skbedit actions. Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/actions/skbedit.json | 47 ++ 1 file changed, 47 insertions(+) diff --git a/tools/testing/selftests/tc-testing/t

[PATCH net-next v2 0/2] Fix batched event generation for skbedit action

2019-07-17 Thread Roman Mashak
When adding or deleting a batch of entries, the kernel sends up to TCA_ACT_MAX_PRIO (defined to 32 in kernel) entries in an event to user space. However it does not consider that the action sizes may vary and require different skb sizes. For example, consider the following script adding 32 entries

[PATCH net-next v2 1/2] net sched: update skbedit action for batched events operations

2019-07-17 Thread Roman Mashak
Add get_fill_size() routine used to calculate the action size when building a batch of events. Fixes: ca9b0e27e ("pkt_action: add new action skbedit") Signed-off-by: Roman Mashak --- net/sched/act_skbedit.c | 12 1 file changed, 12 insertions(+) diff --git a/net/sched/act_skbedit.c

Re: [PATCH net-next v1] fix: taprio: Change type of txtime-delay parameter to u32

2019-07-17 Thread Patel, Vedang
> On Jul 16, 2019, at 2:19 PM, David Miller wrote: > > From: Vedang Patel > Date: Tue, 16 Jul 2019 12:52:18 -0700 > >> During the review of the iproute2 patches for txtime-assist mode, it was >> pointed out that it does not make sense for the txtime-delay parameter to >> be negative. So, cha

Re: Confirm receipt of this mail

2019-07-17 Thread Margaret Ko Leung
Greetings, I am Mrs.Margaret Ko May-Yee Leung Deputy Chairman, Managing Director and Executive Director of Chong Hing Bank Limited. I write briefly to seek your collaboration in a multi-million transaction with good return for us on participation. Reply for details. Regards, Margaret Ko Leung

Re: [PATCH bpf] bpf: fix narrower loads on s390

2019-07-17 Thread Y Song
On Wed, Jul 17, 2019 at 3:36 AM Ilya Leoshkevich wrote: > > > Am 17.07.2019 um 11:21 schrieb Ilya Leoshkevich : > > > >> Am 17.07.2019 um 07:11 schrieb Y Song : > >> > >> [sorry, resend again as previous one has come text messed out due to > >> networking issues] > >> > >> On Tue, Jul 16, 2019 at

Re: IPv6 L2TP issues related to 93531c67

2019-07-17 Thread Paul Donohue
On Wed, Jul 17, 2019 at 05:11:21AM -0600, David Ahern wrote: > This fixes the test script (whitespace damaged but simple enough to > manually patch). See if it fixes the problem with your more complex > setup. If so I will send a formal patch. Yes! I applied this on top of f632a8170a6b667ee4e3f552

[PATCH iproute2-rc v1 5/7] rdma: Add stat manual mode support

2019-07-17 Thread Leon Romanovsky
From: Mark Zhang In manual mode a QP can be manually bound to a counter. If the counter id(cntn) is not specified that kernel will allocate one. After a successful bind, the cntn can be seen through "rdma statistic qp show". And in unbind if lqpn is not specified then all QPs on this counter will

[PATCH iproute2-rc v1 7/7] rdma: Document counter statistic

2019-07-17 Thread Leon Romanovsky
From: Mark Zhang Add document of accessing the QP counter, including bind/unbind a QP to a counter manually or automatically, and dump counter statistics. Signed-off-by: Mark Zhang Signed-off-by: Leon Romanovsky --- man/man8/rdma-dev.8 | 1 + man/man8/rdma-link.8 | 1 + man/man

[PATCH iproute2-rc v1 1/7] rdma: Add "stat qp show" support

2019-07-17 Thread Leon Romanovsky
From: Mark Zhang This patch presents link, id, task name, lqpn, as well as all sub counters of a QP counter. A QP counter is a dynamically allocated statistic counter that is bound with one or more QPs. It has several sub-counters, each is used for a different purpose. Examples: $ rdma stat qp s

[PATCH iproute2-rc v1 4/7] rdma: Make get_port_from_argv() returns valid port in strict port mode

2019-07-17 Thread Leon Romanovsky
From: Mark Zhang When strict_port is set, make get_port_from_argv() returns failure if no valid port is specified. Signed-off-by: Mark Zhang Signed-off-by: Leon Romanovsky --- rdma/utils.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/rdma/utils.c b/rdma/utils.c i

[PATCH iproute2-rc v1 6/7] rdma: Add default counter show support

2019-07-17 Thread Leon Romanovsky
From: Mark Zhang Show default counter statistics, which are same through the sysfs interface: /sys/class/infiniband//ports//hw_counters/ Example: $ rdma stat show link mlx5_2/1 link mlx5_2/1 rx_write_requests 8 rx_read_requests 4 rx_atomic_requests 0 out_of_buffer 0 out_of_sequence 0 duplicate_r

[PATCH iproute2-rc v1 3/7] rdma: Add rdma statistic counter per-port auto mode support

2019-07-17 Thread Leon Romanovsky
From: Mark Zhang With per-QP statistic counter support, a user is allowed to monitor specific QPs categories, which are bound to/unbound from counters dynamically allocated/deallocated. In per-port "auto" mode, QPs are bound to counters automatically according to common criteria. For example a p

[PATCH iproute2-rc v1 2/7] rdma: Add get per-port counter mode support

2019-07-17 Thread Leon Romanovsky
From: Mark Zhang Add an interface to show which mode is active. Two modes are supported: - "auto": In this mode all QPs belong to one category are bind automatically to a single counter set. Currently only "qp type" is supported; - "manual": In this mode QPs are bound to a counter manually. Ex

[PATCH iproute2-rc v1 0/7] Statistics counter support

2019-07-17 Thread Leon Romanovsky
From: Leon Romanovsky Changelog v0->v1: * Fixed typo in manual page (Gal) * Rebased on top of d035cc1b "ip tunnel: warn when changing IPv6 tunnel without tunnel name" * Dropped update header file because it was already merged. -

Re: [PATCH iproute2-rc 2/8] rdma: Add "stat qp show" support

2019-07-17 Thread Leon Romanovsky
On Tue, Jul 16, 2019 at 12:01:28PM -0700, Stephen Hemminger wrote: > On Wed, 10 Jul 2019 10:24:49 +0300 > Leon Romanovsky wrote: > > > From: Mark Zhang > > > > This patch presents link, id, task name, lqpn, as well as all sub > > counters of a QP counter. > > A QP counter is a dynamically allocat

Re: Request for backport of 96125bf9985a75db00496dd2bc9249b777d2b19b

2019-07-17 Thread Dave Taht
On Mon, Jul 15, 2019 at 11:01 AM Loganaden Velvindron wrote: > > On Fri, Jul 5, 2019 at 6:15 PM Loganaden Velvindron > wrote: > > > > Hi folks, > > > > I read the guidelines for LTS/stable. > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > > > > Although this is n

If interested

2019-07-17 Thread Tk Allen
My name is Mr. Allen, I have a Business Proposal of Four million five hundred thousand united states dollars for you to handle with me from my bank. I will need you to assist me in executing this Business .

Re: [PATCH] net: ethernet: mediatek: Add MT7628/88 SoC support

2019-07-17 Thread René van Dorst
Quoting Stefan Roese : Hi Stefan, So comments below. This patch adds support for the MediaTek MT7628/88 SoCs to the common MediaTek ethernet driver. Some minor changes are needed for this and a bigger change, as the MT7628 does not support QDMA (only PDMA). Signed-off-by: Stefan Roese Cc: Re

Re: [PATCH] net: ethernet: mediatek: Add MT7628/88 SoC support

2019-07-17 Thread Daniel Golle
On Wed, Jul 17, 2019 at 01:02:43PM +0200, Stefan Roese wrote: > This patch adds support for the MediaTek MT7628/88 SoCs to the common > MediaTek ethernet driver. Some minor changes are needed for this and > a bigger change, as the MT7628 does not support QDMA (only PDMA). The Ethernet core found i

[PATCH bpf] selftests/bpf: fix test_xdp_noinline on s390

2019-07-17 Thread Ilya Leoshkevich
test_xdp_noinline fails on s390 due to a handful of endianness issues. Use ntohs for parsing eth_proto. Replace bswaps with ntohs/htons. Signed-off-by: Ilya Leoshkevich Acked-by: Vasily Gorbik --- .../selftests/bpf/progs/test_xdp_noinline.c | 17 + 1 file changed, 9 insertio

[PATCH] net: ethernet: fix error return code in ag71xx_probe()

2019-07-17 Thread Wei Yongjun
Fix to return error code -ENOMEM from the dmam_alloc_coherent() error handling case instead of 0, as done elsewhere in this function. Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/atheros/ag71xx.c | 4 +++- 1 file changed, 3 insertio

[PATCH] net: ag71xx: fix return value check in ag71xx_probe()

2019-07-17 Thread Wei Yongjun
In case of error, the function of_get_mac_address() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/atheros/ag71xx.c |

Re: IPv6 L2TP issues related to 93531c67

2019-07-17 Thread David Ahern
On 7/16/19 7:56 AM, Paul Donohue wrote: > > Unfortunately, I have a fairly complicated setup, so it took me a while to > figure out which pieces were relevant ... But I think I've finally got it. > The missing piece was IPsec. > > After establishing an IPsec tunnel to carry the L2TP traffic, t

[PATCH] net: ethernet: mediatek: Add MT7628/88 SoC support

2019-07-17 Thread Stefan Roese
This patch adds support for the MediaTek MT7628/88 SoCs to the common MediaTek ethernet driver. Some minor changes are needed for this and a bigger change, as the MT7628 does not support QDMA (only PDMA). Signed-off-by: Stefan Roese Cc: René van Dorst Cc: Sean Wang Cc: Felix Fietkau Cc: John C

Re: [PATCH net] be2net: Signal that the device cannot transmit during reconfiguration

2019-07-17 Thread Firo Yang
Crystal clear. Many thanks. // Firo

Re: [PATCH bpf] bpf: fix narrower loads on s390

2019-07-17 Thread Ilya Leoshkevich
> Am 17.07.2019 um 11:21 schrieb Ilya Leoshkevich : > >> Am 17.07.2019 um 07:11 schrieb Y Song : >> >> [sorry, resend again as previous one has come text messed out due to >> networking issues] >> >> On Tue, Jul 16, 2019 at 10:08 PM Y Song wrote: >>> >>> On Tue, Jul 16, 2019 at 4:59 AM Ilya Le

Re: [PATCH net] be2net: Signal that the device cannot transmit during reconfiguration

2019-07-17 Thread Benjamin Poirier
On 2019/07/17 17:56, Firo Yang wrote: > I don't think this change could fix this problem because if SMP, > dev_watchdog() could run on a different CPU. hmm, SMP is clearly part of the picture here. The change I proposed revolves around the synchronization offered by dev->tx_global_lock: we have

Re: [PATCH bpf] bpf: fix narrower loads on s390

2019-07-17 Thread Ilya Leoshkevich
> Am 17.07.2019 um 07:11 schrieb Y Song : > > [sorry, resend again as previous one has come text messed out due to > networking issues] > > On Tue, Jul 16, 2019 at 10:08 PM Y Song wrote: >> >> On Tue, Jul 16, 2019 at 4:59 AM Ilya Leoshkevich wrote: >>> >>> test_pkt_md_access is failing on s39

Re: [PATCH net] be2net: Signal that the device cannot transmit during reconfiguration

2019-07-17 Thread Firo Yang
I don't think this change could fix this problem because if SMP, dev_watchdog() could run on a different CPU. Thanks, Firo

Re: [PATCH bpf] selftests/bpf: make directory prerequisites order-only

2019-07-17 Thread Ilya Leoshkevich
> Am 16.07.2019 um 19:49 schrieb Alexei Starovoitov > : > > On Mon, Jul 15, 2019 at 3:22 PM Daniel Borkmann wrote: >> >> On 7/12/19 3:56 PM, Ilya Leoshkevich wrote: >>> When directories are used as prerequisites in Makefiles, they can cause >>> a lot of unnecessary rebuilds, because a directory

Re: OOM triggered by SCTP

2019-07-17 Thread Marek Majkowski
Malc, thanks taking a look. I'm able to trigger the problem on non-SMP virtme with 4GiB ram, but I'm not able to trigger it on my SMP host with 16GiB. The slab info from dmesg (on 4GiB run): Unreclaimable slab info: SCTPv6 31068KB 31068KB sctp_chunk 24321KB 2

Re: [PATCH] net/mlx5: Replace kfree with kvfree

2019-07-17 Thread Eric Dumazet
On 7/17/19 10:03 AM, Chuhong Yuan wrote: > Variable allocated by kvmalloc should not be freed by kfree. > Because it may be allocated by vmalloc. > So replace kfree with kvfree here. > > Signed-off-by: Chuhong Yuan > --- Please add corresponding Fixes: tag, thanks ! > drivers/net/ethernet/m

Re: [PATCH net] be2net: Signal that the device cannot transmit during reconfiguration

2019-07-17 Thread Benjamin Poirier
On 2019/07/17 13:23, Firo Yang wrote: > I think there is a problem if dev_watchdog() is triggered before > netif_carrier_off(). dev_watchdog() might call ->ndo_tx_timeout(), i.e. > be_tx_timeout(), if txq timeout happens. Thus be_tx_timeout() could still be > able to access the memory which is

[PATCH net] bnxt_en: Fix VNIC accounting when enabling aRFS on 57500 chips.

2019-07-17 Thread Michael Chan
Unlike legacy chips, 57500 chips don't need additional VNIC resources for aRFS/ntuple. Fix the code accordingly so that we don't reserve and allocate additional VNICs on 57500 chips. Without this patch, the driver is failing to initialize when it tries to allocate extra VNICs. Fixes: ac33906c67e