Re: [Patch net] fib: relax source validation check for loopback packets

2019-07-13 Thread Cong Wang
On Sat, Jul 13, 2019 at 11:30 PM Cong Wang wrote: > It's complicated, Mesos network isolation uses this case: > https://cgit.twitter.biz/mesos/tree/src/slave/containerizer/mesos/isolators/network/port_mapping.cpp Oops, please use the open source link instead: https://github.com/apache/mesos/blob/

Re: [Patch net] fib: relax source validation check for loopback packets

2019-07-13 Thread Cong Wang
On Sat, Jul 13, 2019 at 3:42 PM David Ahern wrote: > > On 7/12/19 2:17 PM, Cong Wang wrote: > > diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c > > index 317339cd7f03..8662a44a28f9 100644 > > --- a/net/ipv4/fib_frontend.c > > +++ b/net/ipv4/fib_frontend.c > > @@ -388,6 +388,12 @@ st

Re: [PATCH net-next 1/1] Allow 0.0.0.0/8 as a valid address range

2019-07-13 Thread Paul Marks
On Wed, Jun 26, 2019 at 1:20 PM David Miller wrote: > > From: Dave Taht > Date: Sat, 22 Jun 2019 10:07:34 -0700 > > > The longstanding prohibition against using 0.0.0.0/8 dates back > > to two issues with the early internet. > > > > There was an interoperability problem with BSD 4.2 in 1984, fixe

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-13 Thread David Miller
From: Ido Schimmel Date: Thu, 11 Jul 2019 15:39:09 +0300 > Before I start working on v2, I would like to get your feedback on the > high level plan. Also adding Neil who is the maintainer of drop_monitor > (and counterpart DropWatch tool [1]). > > IIUC, the problem you point out is that users ne

Re: [net-next] bonding: add documentation for peer_notif_delay

2019-07-13 Thread David Miller
From: Vincent Bernat Date: Sat, 13 Jul 2019 16:35:27 +0200 > Ability to tweak the interval between peer notifications has been > added in 07a4ddec3ce9 ("bonding: add an option to specify a delay > between peer notifications") but the documentation was not updated. > > Signed-off-by: Vincent Bern

Re: [PATCH net] r8169: fix issue with confused RX unit after PHY power-down on RTL8411b

2019-07-13 Thread David Miller
From: Heiner Kallweit Date: Sat, 13 Jul 2019 13:45:47 +0200 > On RTL8411b the RX unit gets confused if the PHY is powered-down. > This was reported in [0] and confirmed by Realtek. Realtek provided > a sequence to fix the RX unit after PHY wakeup. > > The issue itself seems to have been there lo

Re: [PATCH 2/2] net-next: ag71xx: Rearrange ag711xx struct to remove holes

2019-07-13 Thread David Miller
From: Rosen Penev Date: Fri, 12 Jul 2019 19:09:21 -0700 > Removed cacheline_aligned attribute to ring structs. This actually > causes holes in the ag71xx struc as well as lower performance. > > Rearranged struct members to fall within respective cachelines. The RX > ring struct now does not

Re: [PATCH 1/2] net-next: ag71xx: Add missing header

2019-07-13 Thread David Miller
From: Rosen Penev Date: Fri, 12 Jul 2019 19:09:20 -0700 > ag71xx uses devm_ioremap_nocache. This fixes usage of an implicit function > > Signed-off-by: Rosen Penev This is a bug fix and should target 'net'.

Re: [PATCH net-next 1/2] net sched: update skbedit action for batched events operations

2019-07-13 Thread David Miller
From: Roman Mashak Date: Fri, 12 Jul 2019 18:21:59 -0400 > Add get_fill_size() routine used to calculate the action size > when building a batch of events. > > Signed-off-by: Roman Mashak Please add an appropriate Fixes: tag, and also when you respin this provide the required "[PATCH 0/N] " he

Re: [Patch net] net_sched: unset TCQ_F_CAN_BYPASS when adding filters

2019-07-13 Thread Cong Wang
On Sat, Jul 13, 2019 at 5:54 AM Eric Dumazet wrote: > > > > On 7/12/19 10:17 PM, Cong Wang wrote: > > For qdisc's that support TC filters and set TCQ_F_CAN_BYPASS, > > notably fq_codel, it makes no sense to let packets bypass the TC > > filters we setup in any scenario, otherwise our packets steer

Re: [Patch net] fib: relax source validation check for loopback packets

2019-07-13 Thread David Ahern
On 7/13/19 4:42 PM, David Ahern wrote: > On 7/12/19 2:17 PM, Cong Wang wrote: >> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c >> index 317339cd7f03..8662a44a28f9 100644 >> --- a/net/ipv4/fib_frontend.c >> +++ b/net/ipv4/fib_frontend.c >> @@ -388,6 +388,12 @@ static int __fib_valid

Re: [Patch net] fib: relax source validation check for loopback packets

2019-07-13 Thread David Ahern
On 7/12/19 2:17 PM, Cong Wang wrote: > diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c > index 317339cd7f03..8662a44a28f9 100644 > --- a/net/ipv4/fib_frontend.c > +++ b/net/ipv4/fib_frontend.c > @@ -388,6 +388,12 @@ static int __fib_validate_source(struct sk_buff *skb, > __be32 src,

Re: [PATCH] Fix dumping vlan rules

2019-07-13 Thread Florian Westphal
michael-...@fami-braun.de wrote: > From: "M. Braun" > > Given the following bridge rules: > 1. ip protocol icmp accept > 2. ether type vlan vlan type ip ip protocol icmp accept > > The are currently both dumped by "nft list ruleset" as > 1. ip protocol icmp accept > 2. ip protocol icmp accept

Re: [PATCH] Fix dumping vlan rules

2019-07-13 Thread Laura Garcia
CC'ing netfilter. On Sat, Jul 13, 2019 at 11:10 PM wrote: > > From: "M. Braun" > > Given the following bridge rules: > 1. ip protocol icmp accept > 2. ether type vlan vlan type ip ip protocol icmp accept > > The are currently both dumped by "nft list ruleset" as > 1. ip protocol icmp accept > 2.

[PATCH] Fix dumping vlan rules

2019-07-13 Thread michael-dev
From: "M. Braun" Given the following bridge rules: 1. ip protocol icmp accept 2. ether type vlan vlan type ip ip protocol icmp accept The are currently both dumped by "nft list ruleset" as 1. ip protocol icmp accept 2. ip protocol icmp accept Though, the netlink code actually is different brid

Re: [PATCH net] net: neigh: fix multiple neigh timer scheduling

2019-07-13 Thread Lorenzo Bianconi
> > From: David Miller > Date: Fri, 12 Jul 2019 15:40:47 -0700 (PDT) > > > From: Lorenzo Bianconi > > Date: Fri, 12 Jul 2019 19:22:51 +0200 > > > >> Neigh timer can be scheduled multiple times from userspace adding > >> multiple neigh entries and forcing the neigh timer scheduling passing > >> NT

[net-next] bonding: add documentation for peer_notif_delay

2019-07-13 Thread Vincent Bernat
Ability to tweak the interval between peer notifications has been added in 07a4ddec3ce9 ("bonding: add an option to specify a delay between peer notifications") but the documentation was not updated. Signed-off-by: Vincent Bernat --- Documentation/networking/bonding.txt | 16 +--- 1

Re: [Patch net] net_sched: unset TCQ_F_CAN_BYPASS when adding filters

2019-07-13 Thread Eric Dumazet
On 7/12/19 10:17 PM, Cong Wang wrote: > For qdisc's that support TC filters and set TCQ_F_CAN_BYPASS, > notably fq_codel, it makes no sense to let packets bypass the TC > filters we setup in any scenario, otherwise our packets steering > policy could not be enforced. > > This can be easily repr

Re: [RFC PATCH net-next 3/6] net: dsa: Pass tc-taprio offload to drivers

2019-07-13 Thread Vladimir Oltean
Hi Ilias, On Mon, 8 Jul 2019 at 14:23, Ilias Apalodimas wrote: > > Hi Vladimir, > > > tc-taprio is a qdisc based on the enhancements for scheduled traffic > > specified in IEEE 802.1Qbv (later merged in 802.1Q). This qdisc has > > a software implementation and an optional offload through which >

[PATCH net] r8169: fix issue with confused RX unit after PHY power-down on RTL8411b

2019-07-13 Thread Heiner Kallweit
On RTL8411b the RX unit gets confused if the PHY is powered-down. This was reported in [0] and confirmed by Realtek. Realtek provided a sequence to fix the RX unit after PHY wakeup. The issue itself seems to have been there longer, the Fixes tag refers to where the fix applies properly. [0] https

[PATCH net] r8169: fix issue with confused RX unit after PHY power-down on RTL8411b

2019-07-13 Thread Heiner Kallweit
On RTL8411b the RX unit gets confused if the PHY is powered-down. This was reported in [0] and confirmed by Realtek. Realtek provided a sequence to fix the RX unit after PHY wakeup. The issue itself seems to have been there longer, the Fixes tag refers to where the fix applies properly. [0] https

[PATCH iproute2] tc: util: constrain percentage in 0-100 interval

2019-07-13 Thread Andrea Claudi
parse_percent() currently allows to specify negative percentages or value above 100%. However this does not seems to make sense, as the function is used for probabilities or bandiwidth rates. Moreover, using negative values leads to erroneous results (using Bernoulli loss model as example): $ ip

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-13 Thread Toke Høiland-Jørgensen
>Neil Horman writes: > On Fri, Jul 12, 2019 at 02:33:29PM +0200, Toke Høiland-Jørgensen wrote: >> Neil Horman writes: >> >> > On Fri, Jul 12, 2019 at 11:27:55AM +0200, Toke Høiland-Jørgensen wrote: >> >> Neil Horman writes: >> >> >> >> > On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel