Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-12 Thread Shannon Nelson
On 7/8/19 7:30 PM, Andrew Lunn wrote: +static int ionic_nway_reset(struct net_device *netdev) +{ + struct lif *lif = netdev_priv(netdev); + int err = 0; + + if (netif_running(netdev)) + err = ionic_reset_queues(lif); What does ionic_reset_queues() do? It sounds no

Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support

2019-07-12 Thread Shannon Nelson
On 7/8/19 7:14 PM, Andrew Lunn wrote: +static int ionic_set_pauseparam(struct net_device *netdev, + struct ethtool_pauseparam *pause) +{ + struct lif *lif = netdev_priv(netdev); + struct ionic *ionic = lif->ionic; + struct ionic_dev *idev = &lif->io

Re: [PATCH v3 bpf 1/3] bpf: fix BTF verifier size resolution logic

2019-07-12 Thread Martin Lau
On Fri, Jul 12, 2019 at 10:25:55AM -0700, Andrii Nakryiko wrote: > BTF verifier has a size resolution bug which in some circumstances leads to > invalid size resolution for, e.g., TYPEDEF modifier. This happens if we have > [1] PTR -> [2] TYPEDEF -> [3] ARRAY, in which case due to being in pointer

[PATCH 1/2] net-next: ag71xx: Add missing header

2019-07-12 Thread Rosen Penev
ag71xx uses devm_ioremap_nocache. This fixes usage of an implicit function Signed-off-by: Rosen Penev --- drivers/net/ethernet/atheros/ag71xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index 72a57c6cd254..8

[PATCH 2/2] net-next: ag71xx: Rearrange ag711xx struct to remove holes

2019-07-12 Thread Rosen Penev
Removed cacheline_aligned attribute to ring structs. This actually causes holes in the ag71xx struc as well as lower performance. Rearranged struct members to fall within respective cachelines. The RX ring struct now does not share a cacheline with the TX ring. The NAPI atruct now takes up its

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Neil Horman
On Fri, Jul 12, 2019 at 02:33:29PM +0200, Toke Høiland-Jørgensen wrote: > Neil Horman writes: > > > On Fri, Jul 12, 2019 at 11:27:55AM +0200, Toke Høiland-Jørgensen wrote: > >> Neil Horman writes: > >> > >> > On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel wrote: > >> >> On Sun, Jul 07,

Re: [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

2019-07-12 Thread Gregory Rose
On 7/12/2019 3:18 PM, David Miller wrote: From: Taehee Yoo Date: Sat, 6 Jul 2019 01:08:09 +0900 When a vport is deleted, the maximum headroom size would be changed. If the vport which has the largest headroom is deleted, the new max_headroom would be set. But, if the new headroom size is e

Re: [PATCH net] net: neigh: fix multiple neigh timer scheduling

2019-07-12 Thread David Miller
From: David Miller Date: Fri, 12 Jul 2019 15:40:47 -0700 (PDT) > From: Lorenzo Bianconi > Date: Fri, 12 Jul 2019 19:22:51 +0200 > >> Neigh timer can be scheduled multiple times from userspace adding >> multiple neigh entries and forcing the neigh timer scheduling passing >> NTF_USE in the netli

Re: [PATCH net] net: neigh: fix multiple neigh timer scheduling

2019-07-12 Thread David Miller
From: Lorenzo Bianconi Date: Fri, 12 Jul 2019 19:22:51 +0200 > Neigh timer can be scheduled multiple times from userspace adding > multiple neigh entries and forcing the neigh timer scheduling passing > NTF_USE in the netlink requests. > This will result in a refcount leak and in the following du

Re: [PATCH] net: dsa: qca8k: replace legacy gpio include

2019-07-12 Thread David Miller
From: Christian Lamparter Date: Fri, 12 Jul 2019 17:33:36 +0200 > This patch replaces the legacy bulk gpio.h include > with the proper gpio/consumer.h variant. This was > caught by the kbuild test robot that was running > into an error because of this. > > For more information why linux/gpio.h i

Re: [PATCH net-next 0/2] Fix bugs in NFP flower match offload

2019-07-12 Thread David Miller
From: John Hurley Date: Wed, 10 Jul 2019 19:30:28 +0100 > This patchset contains bug fixes for corner cases in the match fields of > flower offloads. The patches ensure that flows that should not be > supported are not (incorrectly) offloaded. These include rules that match > on layer 3 and/or 4

Re: [PATCH net-next 1/1] tc-tests: updated skbedit tests

2019-07-12 Thread David Miller
From: Roman Mashak Date: Thu, 11 Jul 2019 12:29:00 -0400 > - Added mask upper bound test case > - Added mask validation test case > - Added mask replacement case > > Signed-off-by: Roman Mashak New tests I'll allow still now, applied, thanks.

Re: [PATCH net-next] net/mlx5e: Provide cb_list pointer when setting up tc block on rep

2019-07-12 Thread David Miller
From: Vlad Buslov Date: Wed, 10 Jul 2019 21:25:54 +0300 > Recent refactoring of tc block offloads infrastructure introduced new > flow_block_cb_setup_simple() method intended to be used as unified way for > all drivers to register offload callbacks. However, commit that actually > extended all us

Re: [PATCH net-next] net: sched: Fix NULL-pointer dereference in tc_indr_block_ing_cmd()

2019-07-12 Thread David Miller
From: Vlad Buslov Date: Wed, 10 Jul 2019 20:12:29 +0300 > After recent refactoring of block offlads infrastructure, indr_dev->block > pointer is dereferenced before it is verified to be non-NULL. Example stack > trace where this behavior leads to NULL-pointer dereference error when > creating vxl

[PATCH net-next 2/2] tc-testing: updated skbedit action tests with batch create/delete

2019-07-12 Thread Roman Mashak
Signed-off-by: Roman Mashak --- .../tc-testing/tc-tests/actions/skbedit.json | 47 ++ 1 file changed, 47 insertions(+) diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/skbedit.json b/tools/testing/selftests/tc-testing/tc-tests/actions/skbedit.json index

[PATCH net-next 1/2] net sched: update skbedit action for batched events operations

2019-07-12 Thread Roman Mashak
Add get_fill_size() routine used to calculate the action size when building a batch of events. Signed-off-by: Roman Mashak --- net/sched/act_skbedit.c | 12 1 file changed, 12 insertions(+) diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c index 215a06705cef..dc3c653ec

Re: [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

2019-07-12 Thread David Miller
From: Taehee Yoo Date: Sat, 6 Jul 2019 01:08:09 +0900 > When a vport is deleted, the maximum headroom size would be changed. > If the vport which has the largest headroom is deleted, > the new max_headroom would be set. > But, if the new headroom size is equal to the old headroom size, > updatin

[Patch net] net_sched: unset TCQ_F_CAN_BYPASS when adding filters

2019-07-12 Thread Cong Wang
For qdisc's that support TC filters and set TCQ_F_CAN_BYPASS, notably fq_codel, it makes no sense to let packets bypass the TC filters we setup in any scenario, otherwise our packets steering policy could not be enforced. This can be easily reproduced with the following script: ip li add dev dum

[Patch net] fib: relax source validation check for loopback packets

2019-07-12 Thread Cong Wang
In a rare case where we redirect local packets from veth to lo, these packets fail to pass the source validation when rp_filter is turned on, as the tracing shows: <...>-311708 [040] ..s1 7951180.957825: fib_table_lookup: table 254 oif 0 iif 1 src 10.53.180.130 dst 10.53.180.130 tos 0 scope 0 f

Re: [PATCH bpf] selftests/bpf: put test_stub.o into $(OUTPUT)

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 7:00 AM Ilya Leoshkevich wrote: > > Add a rule to put test_stub.o in $(OUTPUT) and change the references to > it accordingly. This prevents test_stub.o from being created in the > source directory. > > Signed-off-by: Ilya Leoshkevich > --- Makes sense. Acked-by: Andrii N

Re: [PATCH bpf] selftests/bpf: fix test_send_signal_nmi on s390

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 12:55 PM Y Song wrote: > > On Fri, Jul 12, 2019 at 11:24 AM Andrii Nakryiko > wrote: > > > > On Fri, Jul 12, 2019 at 10:46 AM Ilya Leoshkevich > > wrote: > > > > > > Many s390 setups (most notably, KVM guests) do not have access to > > > hardware performance events. > >

Re: [PATCH bpf] selftests/bpf: make directory prerequisites order-only

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 6:57 AM Ilya Leoshkevich wrote: > > When directories are used as prerequisites in Makefiles, they can cause > a lot of unnecessary rebuilds, because a directory is considered changed > whenever a file in this directory is added, removed or modified. > > If the only thing a

Re: [PATCH bpf] selftests/bpf: fix attach_probe on s390

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 6:42 AM Ilya Leoshkevich wrote: > > attach_probe test fails, because it cannot install a kprobe on a > non-existent sys_nanosleep symbol. > > Use the correct symbol name for the nanosleep syscall on 64-bit s390. > Don't bother adding one for 31-bit mode, since tests are com

Re: [PATCH bpf] selftests/bpf: fix test_send_signal_nmi on s390

2019-07-12 Thread Y Song
On Fri, Jul 12, 2019 at 11:24 AM Andrii Nakryiko wrote: > > On Fri, Jul 12, 2019 at 10:46 AM Ilya Leoshkevich wrote: > > > > Many s390 setups (most notably, KVM guests) do not have access to > > hardware performance events. > > > > Therefore, use the software event instead. > > > > Signed-off-by:

Re: [oss-drivers] Re: [RFC bpf-next 2/8] bpf: extend list based insn patching infra to verification layer

2019-07-12 Thread Andrii Nakryiko
On Thu, Jul 11, 2019 at 5:20 AM Jiong Wang wrote: > > > Jiong Wang writes: > > > Andrii Nakryiko writes: > > > >> On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang wrote: > >>> > >>> Verification layer also needs to handle auxiliar info as well as adjusting > >>> subprog start. > >>> > >>> At this layer,

Re: [RFC bpf-next 1/8] bpf: introducing list based insn patching infra to core layer

2019-07-12 Thread Andrii Nakryiko
On Thu, Jul 11, 2019 at 4:53 AM Jiong Wang wrote: > > > Andrii Nakryiko writes: > > > On Thu, Jul 4, 2019 at 2:32 PM Jiong Wang wrote: > >> > >> This patch introduces list based bpf insn patching infra to bpf core layer > >> which is lower than verification layer. > >> > >> This layer has bpf ins

Re: [RFC bpf-next 0/8] bpf: accelerate insn patching speed

2019-07-12 Thread Andrii Nakryiko
On Thu, Jul 11, 2019 at 4:22 AM Jiong Wang wrote: > > > Andrii Nakryiko writes: > > > On Thu, Jul 4, 2019 at 2:31 PM Jiong Wang wrote: > >> > >> This is an RFC based on latest bpf-next about acclerating insn patching > >> speed, it is now near the shape of final PATCH set, and we could see the >

Re: [PATCH v3 bpf 0/3] fix BTF verification size resolution

2019-07-12 Thread Yonghong Song
On 7/12/19 10:25 AM, Andrii Nakryiko wrote: > BTF size resolution logic isn't always resolving type size correctly, leading > to erroneous map creation failures due to value size mismatch. > > This patch set: > 1. fixes the issue (patch #1); > 2. adds tests for trickier cases (patch #2); > 3. an

Re: [RFC PATCH net-next 0/3] net: batched receive in GRO path

2019-07-12 Thread David Miller
From: Eric Dumazet Date: Fri, 12 Jul 2019 18:48:29 +0200 > I should have mentioned that we have a patch that I forgot to > upstream adding the PSH flag to all TSO packets, meaning the > receiver can automatically learn the boundary of a GRO packet and > not have to wait for the napi->poll() end (

Re: [PATCH v3 0/7] Convert skb_frag_t to bio_vec

2019-07-12 Thread David Miller
From: Matthew Wilcox Date: Fri, 12 Jul 2019 06:43:38 -0700 > From: "Matthew Wilcox (Oracle)" > > The skb_frag_t and bio_vec are fundamentally the same (page, offset, > length) tuple. This patch series unifies the two, leaving the > skb_frag_t typedef in place. This has the immediate advantage

Re: [PATCH bpf] selftests/bpf: fix test_send_signal_nmi on s390

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 10:46 AM Ilya Leoshkevich wrote: > > Many s390 setups (most notably, KVM guests) do not have access to > hardware performance events. > > Therefore, use the software event instead. > > Signed-off-by: Ilya Leoshkevich > Acked-by: Vasily Gorbik > --- > tools/testing/selfte

[PATCH bpf] selftests/bpf: fix test_send_signal_nmi on s390

2019-07-12 Thread Ilya Leoshkevich
Many s390 setups (most notably, KVM guests) do not have access to hardware performance events. Therefore, use the software event instead. Signed-off-by: Ilya Leoshkevich Acked-by: Vasily Gorbik --- tools/testing/selftests/bpf/prog_tests/send_signal.c | 9 + 1 file changed, 9 insertions

[PATCH v2 bpf-next] selftests/bpf: remove logic duplication in test_verifier.c

2019-07-12 Thread Andrii Nakryiko
test_verifier tests can specify single- and multi-runs tests. Internally logic of handling them is duplicated. Get rid of it by making single run retval/data specification to be a first run spec. Cc: Krzesimir Nowak Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/test_verifier.c

Re: [net-next 0/2] tipc: link changeover issues

2019-07-12 Thread David Miller
net-next is closed right now, resubmit this when the tree opens back up.

Re: [PATCH v4 bpf-next 1/4] selftests/bpf: compile progs with -D__TARGET_ARCH_$(SRCARCH)

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 2:00 AM Ilya Leoshkevich wrote: > > > Am 12.07.2019 um 02:53 schrieb Andrii Nakryiko : > > > > On Thu, Jul 11, 2019 at 7:32 AM Ilya Leoshkevich wrote: > >> > >> This opens up the possibility of accessing registers in an > >> arch-independent way. > >> > >> Signed-off-by: I

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-12 Thread Matthias Kaehlcke
Hi Florian, On Wed, Jul 10, 2019 at 09:28:39AM -0700, Florian Fainelli wrote: > On 7/10/19 8:55 AM, Rob Herring wrote: > > On Wed, Jul 3, 2019 at 5:23 PM Matthias Kaehlcke wrote: > >> > >> Hi Florian, > >> > >> On Wed, Jul 03, 2019 at 02:37:47PM -0700, Florian Fainelli wrote: > >>> On 7/3/19 12:3

[PATCH v3 bpf 3/3] selftests/bpf: use typedef'ed arrays as map values

2019-07-12 Thread Andrii Nakryiko
Convert few tests that couldn't use typedef'ed arrays due to kernel bug. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/progs/test_get_stack_rawtp.c | 3 ++- tools/testing/selftests/bpf/progs/test_stacktrace_build_id.c | 3 +-- tools/testing/selftests/bpf/progs/test_stacktrac

[PATCH v3 bpf 1/3] bpf: fix BTF verifier size resolution logic

2019-07-12 Thread Andrii Nakryiko
BTF verifier has a size resolution bug which in some circumstances leads to invalid size resolution for, e.g., TYPEDEF modifier. This happens if we have [1] PTR -> [2] TYPEDEF -> [3] ARRAY, in which case due to being in pointer context ARRAY size won't be resolved (because for pointer it doesn't m

[PATCH v3 bpf 0/3] fix BTF verification size resolution

2019-07-12 Thread Andrii Nakryiko
BTF size resolution logic isn't always resolving type size correctly, leading to erroneous map creation failures due to value size mismatch. This patch set: 1. fixes the issue (patch #1); 2. adds tests for trickier cases (patch #2); 3. and converts few test cases utilizing BTF-defined maps, that p

[PATCH v3 bpf 2/3] selftests/bpf: add trickier size resolution tests

2019-07-12 Thread Andrii Nakryiko
Add more BTF tests, validating that size resolution logic is correct in few trickier cases. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/test_btf.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/tools/testing/selftests/bpf/test_btf.c b/tools/te

[PATCH net] net: neigh: fix multiple neigh timer scheduling

2019-07-12 Thread Lorenzo Bianconi
Neigh timer can be scheduled multiple times from userspace adding multiple neigh entries and forcing the neigh timer scheduling passing NTF_USE in the netlink requests. This will result in a refcount leak and in the following dump stack: [ 32.465295] NEIGH: BUG, double timer add, state is 8 [

Re: [PATCH v2 bpf-next 1/3] bpf: fix BTF verifier size resolution logic

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 8:47 AM Yonghong Song wrote: > > > > On 7/12/19 8:36 AM, Andrii Nakryiko wrote: > > On Thu, Jul 11, 2019 at 10:59 PM Yonghong Song wrote: > >> > >> > >> > >> On 7/10/19 11:53 PM, Andrii Nakryiko wrote: > >>> BTF verifier has a size resolution bug which in some circumstance

Re: [PATCH net] net: fix use-after-free in __netif_receive_skb_core

2019-07-12 Thread Jonathan Lemon
On 12 Jul 2019, at 8:29, Edward Cree wrote: On 10/07/2019 23:47, Sabrina Dubroca wrote: 2019-07-10, 16:07:43 +0100, Edward Cree wrote: On 10/07/2019 14:52, Sabrina Dubroca wrote: -static int __netif_receive_skb_core(struct sk_buff *skb, bool pfmemalloc, +static int __netif_receive_skb_core

[PATCH iproute2-next] tunnel: factorize printout of GRE key and flags

2019-07-12 Thread Andrea Claudi
print_tunnel() functions in ip6tunnel.c and iptunnel.c contains the same code to print out GRE key and flags This commit factorize the code in a helper function in tunnel.c Signed-off-by: Andrea Claudi --- ip/ip6tunnel.c | 22 ++ ip/iptunnel.c | 19 ++- ip/t

Re: [RFC PATCH net-next 0/3] net: batched receive in GRO path

2019-07-12 Thread Eric Dumazet
On 7/12/19 5:59 PM, Edward Cree wrote: > On 10/07/2019 18:39, Eric Dumazet wrote: >> Holding a small packet in the list up to the point we call busy_poll_stop() >> will basically make busypoll non working anymore. >> >> napi_complete_done() has special behavior when busy polling is active. > Yep

Re: [PATCH] net: dsa: qca8k: replace legacy gpio include

2019-07-12 Thread Florian Fainelli
On 7/12/19 8:33 AM, Christian Lamparter wrote: > This patch replaces the legacy bulk gpio.h include > with the proper gpio/consumer.h variant. This was > caught by the kbuild test robot that was running > into an error because of this. > > For more information why linux/gpio.h is bad can be found

Re: [PATCH] net: dsa: qca8k: replace legacy gpio include

2019-07-12 Thread Vivien Didelot
On Fri, 12 Jul 2019 17:33:36 +0200, Christian Lamparter wrote: > This patch replaces the legacy bulk gpio.h include > with the proper gpio/consumer.h variant. This was > caught by the kbuild test robot that was running > into an error because of this. > > For more information why linux/gpio.h is

Re: [ovs-dev] [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

2019-07-12 Thread Gregory Rose
On 7/5/2019 9:08 AM, Taehee Yoo wrote: When a vport is deleted, the maximum headroom size would be changed. If the vport which has the largest headroom is deleted, the new max_headroom would be set. But, if the new headroom size is equal to the old headroom size, updating routine is unnecessary

Re: [RFC PATCH net-next 0/3] net: batched receive in GRO path

2019-07-12 Thread Edward Cree
On 10/07/2019 18:39, Eric Dumazet wrote: > Holding a small packet in the list up to the point we call busy_poll_stop() > will basically make busypoll non working anymore. > > napi_complete_done() has special behavior when busy polling is active. Yep, I get it now, sorry for being dumb :) Essentiall

Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 05:42 PM, Andrii Nakryiko wrote: > On Fri, Jul 12, 2019 at 5:59 AM Daniel Borkmann wrote: >> On 07/12/2019 08:03 AM, Yonghong Song wrote: >>> On 7/10/19 11:53 PM, Andrii Nakryiko wrote: BTF size resolution logic isn't always resolving type size correctly, leading to e

Re: [PATCH v2 bpf-next 1/3] bpf: fix BTF verifier size resolution logic

2019-07-12 Thread Yonghong Song
On 7/12/19 8:36 AM, Andrii Nakryiko wrote: > On Thu, Jul 11, 2019 at 10:59 PM Yonghong Song wrote: >> >> >> >> On 7/10/19 11:53 PM, Andrii Nakryiko wrote: >>> BTF verifier has a size resolution bug which in some circumstances leads to >>> invalid size resolution for, e.g., TYPEDEF modifier. Thi

Re: [PATCH bpf-next] selftests/bpf: remove logic duplication in test_verifier.c

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 6:57 AM Daniel Borkmann wrote: > > On 07/12/2019 09:53 AM, Krzesimir Nowak wrote: > > On Thu, Jul 11, 2019 at 4:43 PM Andrii Nakryiko > > wrote: > >> > >> On Thu, Jul 11, 2019 at 5:13 AM Krzesimir Nowak > >> wrote: > >>> > >>> On Thu, Jul 11, 2019 at 3:08 AM Andrii Nakry

Re: [PATCH bpf-next] net: Don't uninstall an XDP program when none is installed

2019-07-12 Thread Daniel Borkmann
On 07/10/2019 01:16 PM, Maxim Mikityanskiy wrote: > On 2019-06-12 19:14, Maxim Mikityanskiy wrote: >> dev_change_xdp_fd doesn't perform any checks in case it uninstalls an >> XDP program. It means that the driver's ndo_bpf can be called with >> XDP_SETUP_PROG asking to set it to NULL even if it's a

Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 5:59 AM Daniel Borkmann wrote: > > On 07/12/2019 08:03 AM, Yonghong Song wrote: > > On 7/10/19 11:53 PM, Andrii Nakryiko wrote: > >> BTF size resolution logic isn't always resolving type size correctly, > >> leading > >> to erroneous map creation failures due to value size

Re: [PATCH v2 bpf-next 1/3] bpf: fix BTF verifier size resolution logic

2019-07-12 Thread Andrii Nakryiko
On Thu, Jul 11, 2019 at 10:59 PM Yonghong Song wrote: > > > > On 7/10/19 11:53 PM, Andrii Nakryiko wrote: > > BTF verifier has a size resolution bug which in some circumstances leads to > > invalid size resolution for, e.g., TYPEDEF modifier. This happens if we > > have > > [1] PTR -> [2] TYPEDE

[PATCH] net: dsa: qca8k: replace legacy gpio include

2019-07-12 Thread Christian Lamparter
This patch replaces the legacy bulk gpio.h include with the proper gpio/consumer.h variant. This was caught by the kbuild test robot that was running into an error because of this. For more information why linux/gpio.h is bad can be found in: commit 56a46b6144e7 ("gpio: Clarify that is legacy")

Re: [PATCH net] net: fix use-after-free in __netif_receive_skb_core

2019-07-12 Thread Edward Cree
On 10/07/2019 23:47, Sabrina Dubroca wrote: > 2019-07-10, 16:07:43 +0100, Edward Cree wrote: >> On 10/07/2019 14:52, Sabrina Dubroca wrote: >>> -static int __netif_receive_skb_core(struct sk_buff *skb, bool pfmemalloc, >>> +static int __netif_receive_skb_core(struct sk_buff **pskb, bool pfmemalloc,

[PATCH bpf] selftests/bpf: put test_stub.o into $(OUTPUT)

2019-07-12 Thread Ilya Leoshkevich
Add a rule to put test_stub.o in $(OUTPUT) and change the references to it accordingly. This prevents test_stub.o from being created in the source directory. Signed-off-by: Ilya Leoshkevich --- tools/testing/selftests/bpf/Makefile | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) dif

Loan of any kind without collateral

2019-07-12 Thread info
We Raymond Bryan Investment Firm is giving out loan on at 3% interest rate.. Contact our finacial accountant Now for loan of any kind without collateral: giovannipietrob...@gmail.com Contact Number: +1 909 283 3102 --- This email has been checked for viruses by AVG. https://www.avg.com

Re: [PATCH bpf-next] selftests/bpf: remove logic duplication in test_verifier.c

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 09:53 AM, Krzesimir Nowak wrote: > On Thu, Jul 11, 2019 at 4:43 PM Andrii Nakryiko > wrote: >> >> On Thu, Jul 11, 2019 at 5:13 AM Krzesimir Nowak wrote: >>> >>> On Thu, Jul 11, 2019 at 3:08 AM Andrii Nakryiko wrote: test_verifier tests can specify single- and multi-runs t

[PATCH bpf] selftests/bpf: make directory prerequisites order-only

2019-07-12 Thread Ilya Leoshkevich
When directories are used as prerequisites in Makefiles, they can cause a lot of unnecessary rebuilds, because a directory is considered changed whenever a file in this directory is added, removed or modified. If the only thing a target is interested in is the existence of the directory it depends

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Ido Schimmel
On Thu, Jul 11, 2019 at 07:53:54PM -0400, Neil Horman wrote: > A few things here: > IIRC we don't announce individual hardware drops, drivers record them in > internal structures, and they are retrieved on demand via ethtool calls, so > you > will either need to include some polling (probably not

[PATCH v3 2/7] net: Use skb accessors in network core

2019-07-12 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" In preparation for unifying the skb_frag and bio_vec, use the fine accessors which already exist and use skb_frag_t instead of struct skb_frag_struct. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/skbuff.h | 2 +- net/core/skbuff.c | 24

[PATCH v3 0/7] Convert skb_frag_t to bio_vec

2019-07-12 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" The skb_frag_t and bio_vec are fundamentally the same (page, offset, length) tuple. This patch series unifies the two, leaving the skb_frag_t typedef in place. This has the immediate advantage that we already have iov_iter support for bvecs and don't need to add

[PATCH v3 1/7] net: Use skb accessors in network drivers

2019-07-12 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" In preparation for unifying the skb_frag and bio_vec, use the fine accessors which already exist and use skb_frag_t instead of struct skb_frag_struct. Signed-off-by: Matthew Wilcox (Oracle) --- drivers/crypto/chelsio/chtls/chtls_io.c | 6 +++-- drivers/hs

Re: [PATCH v4 bpf-next 0/4] selftests/bpf: fix compiling loop{1,2,3}.c on s390

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 10:55 AM, Ilya Leoshkevich wrote: >> Am 11.07.2019 um 22:35 schrieb Stanislav Fomichev : >> >> On 07/11, Ilya Leoshkevich wrote: >>> Use PT_REGS_RC(ctx) instead of ctx->rax, which is not present on s390. >>> >>> This patch series consists of three preparatory commits, which make it >>

[PATCH v3 6/7] net: Rename skb_frag_t size to bv_len

2019-07-12 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" Improved compatibility with bvec Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/skbuff.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 8076e2ba8349..e849e411d1f3 100

[PATCH v3 5/7] net: Rename skb_frag page to bv_page

2019-07-12 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" One step closer to turning the skb_frag_t into a bio_vec. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/skbuff.h | 12 +--- net/core/skbuff.c | 2 +- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/include/linux/skbuff.h b

[PATCH v3 3/7] net: Increase the size of skb_frag_t

2019-07-12 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" To increase commonality between block and net, we are going to replace the skb_frag_t with the bio_vec. This patch increases the size of skb_frag_t on 32-bit machines from 8 bytes to 12 bytes. The size is unchanged on 64-bit machines. Signed-off-by: Matthew Wilc

[PATCH v3 7/7] net: Convert skb_frag_t to bio_vec

2019-07-12 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" There are a lot of users of frag->page_offset, so use a union to avoid converting those users today. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/bvec.h | 5 - include/linux/skbuff.h | 9 ++--- 2 files changed, 6 insertions(+), 8 deletions(

[PATCH v3 4/7] net: Reorder the contents of skb_frag_t

2019-07-12 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" Match the layout of bio_vec. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 7910935410e6..b9dc8b4f24b1 100644 --- a/inclu

Re: [PATCH v3 bpf] selftests/bpf: do not ignore clang failures

2019-07-12 Thread Daniel Borkmann
On 07/11/2019 11:12 AM, Ilya Leoshkevich wrote: > When compiling an eBPF prog fails, make still returns 0, because > failing clang command's output is piped to llc and therefore its > exit status is ignored. > > When clang fails, pipe the string "clang failed" to llc. This will make > llc fail wit

[PATCH bpf] selftests/bpf: fix attach_probe on s390

2019-07-12 Thread Ilya Leoshkevich
attach_probe test fails, because it cannot install a kprobe on a non-existent sys_nanosleep symbol. Use the correct symbol name for the nanosleep syscall on 64-bit s390. Don't bother adding one for 31-bit mode, since tests are compiled only in 64-bit mode. Fixes: 1e8611bbdfc9 ("selftests/bpf: add

Re: [PATCH] tools: bpftool: add raw_tracepoint_writable prog type to header

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 03:35 AM, Daniel T. Lee wrote: > From commit 9df1c28bb752 ("bpf: add writable context for raw tracepoints"), > a new type of BPF_PROG, RAW_TRACEPOINT_WRITABLE has been added. > > Since this BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE is not listed at > bpftool's header, it causes a segfaul

Re: [PATCH v2 bpf] selftests/bpf: fix bpf_target_sparc check

2019-07-12 Thread Daniel Borkmann
On 07/10/2019 01:56 PM, Ilya Leoshkevich wrote: > bpf_helpers.h fails to compile on sparc: the code should be checking > for defined(bpf_target_sparc), but checks simply for bpf_target_sparc. > > Also change #ifdef bpf_target_powerpc to #if defined() for consistency. > > Signed-off-by: Ilya Leosh

Re: [PATCH bpf-next] libbpf: fix ptr to u64 conversion warning on 32-bit platforms

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 02:56 PM, Matt Hart wrote: > On Tue, 9 Jul 2019 at 05:30, Yonghong Song wrote: >> On 7/8/19 9:00 PM, Andrii Nakryiko wrote: >>> On 32-bit platforms compiler complains about conversion: >>> >>> libbpf.c: In function ‘perf_event_open_probe’: >>> libbpf.c:4112:17: error: cast from point

Re: [PATCH bpf-next] bpf: fix precision bit propagation for BPF_ST instructions

2019-07-12 Thread Daniel Borkmann
On 07/09/2019 05:32 AM, Andrii Nakryiko wrote: > When backtracking instructions to propagate precision bit for registers > and stack slots, one class of instructions (BPF_ST) weren't handled > causing extra stack slots to be propagated into parent state. Parent > state might not have that much stac

.r.sallm Salif,__.,,

2019-07-12 Thread Mr.sallm S_a_l_i_f.,
Good Day I am Mr.sallm Salif,, a regional managing director (CORIS BANK INTERNATIONAL) Ouagadougou Burkina Faso, in my department we have US$9,500. million united state dollars, to transfer into your account as a dormant fund.If you are interested to use this fund to help the orphans around th

Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 08:03 AM, Yonghong Song wrote: > On 7/10/19 11:53 PM, Andrii Nakryiko wrote: >> BTF size resolution logic isn't always resolving type size correctly, leading >> to erroneous map creation failures due to value size mismatch. >> >> This patch set: >> 1. fixes the issue (patch #1); >> 2.

Re: [PATCH bpf-next] libbpf: fix ptr to u64 conversion warning on 32-bit platforms

2019-07-12 Thread Matt Hart
On Tue, 9 Jul 2019 at 05:30, Yonghong Song wrote: > > > > On 7/8/19 9:00 PM, Andrii Nakryiko wrote: > > On 32-bit platforms compiler complains about conversion: > > > > libbpf.c: In function ‘perf_event_open_probe’: > > libbpf.c:4112:17: error: cast from pointer to integer of different > > size [-

Re: bonded active-backup ethernet-wifi drops packets

2019-07-12 Thread Brian J. Murrell
On Fri, 2019-07-05 at 17:46 -0700, Jay Vosburgh wrote: > > I did set this up and test it, but haven't had time to analyze > in depth. > > What I saw was that ping (IPv4) flood worked fine, bonded or > not, over a span of several hours. Interesting. In contrast to my experience. > H

Re: [PATCH bpf-next v9 0/2] bpf: Allow bpf_skb_event_output for more prog types

2019-07-12 Thread Daniel Borkmann
On 07/10/2019 09:10 PM, Allan Zhang wrote: > Sure, thanks. will do as suggested. Yep, bpf-next is currently closed due to merge window, please resubmit once it reopens. Thanks, Daniel

Re: [PATCH v6 bpf-next 0/3] bpf: add bpf_descendant_of helper

2019-07-12 Thread Daniel Borkmann
On 07/10/2019 08:00 PM, Javier Honduvilla Coto wrote: > Hi all, > > This patch adds the bpf_descendant_of helper which accepts a PID and > returns 1 if the PID of the process currently being executed is a > descendant of it or if it's itself. Returns 0 otherwise. The passed > PID should be the one

Re: [PATCH] MAINTAINERS: update BPF JIT S390 maintainers

2019-07-12 Thread Daniel Borkmann
On 07/11/2019 08:33 PM, David Miller wrote: > From: Vasily Gorbik > Date: Wed, 10 Jul 2019 13:34:54 +0200 > >> Dave, Alexei, Daniel, >> would you take it via one of your trees? Or should I take it via s390? > > I think it can go via the bpf tree. Yep, just applied to bpf, thanks!

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Toke Høiland-Jørgensen
Neil Horman writes: > On Fri, Jul 12, 2019 at 11:27:55AM +0200, Toke Høiland-Jørgensen wrote: >> Neil Horman writes: >> >> > On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel wrote: >> >> On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: >> >> > From: Ido Schimmel >> >> > Date

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Neil Horman
On Fri, Jul 12, 2019 at 11:27:55AM +0200, Toke Høiland-Jørgensen wrote: > Neil Horman writes: > > > On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel wrote: > >> On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: > >> > From: Ido Schimmel > >> > Date: Sun, 7 Jul 2019 10:58:17 +0

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Neil Horman
On Thu, Jul 11, 2019 at 08:40:34PM -0700, Florian Fainelli wrote: > > > On 7/11/2019 4:53 PM, Neil Horman wrote: > >> I would like to emphasize that the configuration of whether these > >> dropped packets are even sent to the CPU from the device still needs to > >> reside in devlink given this is

Re: [RFC] virtio-net: share receive_*() and add_recvbuf_*() with virtio-vsock

2019-07-12 Thread Jason Wang
On 2019/7/12 下午6:00, Stefano Garzarella wrote: On Thu, Jul 11, 2019 at 03:52:21PM -0400, Michael S. Tsirkin wrote: On Thu, Jul 11, 2019 at 01:41:34PM +0200, Stefano Garzarella wrote: On Thu, Jul 11, 2019 at 03:37:00PM +0800, Jason Wang wrote: On 2019/7/10 下午11:37, Stefano Garzarella wrote:

Re: [RFC] virtio-net: share receive_*() and add_recvbuf_*() with virtio-vsock

2019-07-12 Thread Stefano Garzarella
On Thu, Jul 11, 2019 at 03:52:21PM -0400, Michael S. Tsirkin wrote: > On Thu, Jul 11, 2019 at 01:41:34PM +0200, Stefano Garzarella wrote: > > On Thu, Jul 11, 2019 at 03:37:00PM +0800, Jason Wang wrote: > > > > > > On 2019/7/10 下午11:37, Stefano Garzarella wrote: > > > > Hi, > > > > as Jason suggest

Re: [PATCH] User mode linux bump maximum MTU tuntap interface [RESAND]

2019-07-12 Thread Anton Ivanov
On 02/07/2019 15:40, Richard Weinberger wrote: CC'ing um folks. On Tue, Jul 2, 2019 at 3:01 PM Алексей wrote: Hello, the parameter ETH_MAX_PACKET limited to 1500 bytes is the not support jumbo frames. This patch change ETH_MAX_PACKET the 65535 bytes to jumbo frame support with user mode lin

Re: [PATCH] User mode linux bump maximum MTU tuntap interface [RESAND]

2019-07-12 Thread Anton Ivanov
On 12/07/2019 10:22, Anton Ivanov wrote: On 02/07/2019 15:40, Richard Weinberger wrote: CC'ing um folks. On Tue, Jul 2, 2019 at 3:01 PM Алексей wrote: Hello, the parameter  ETH_MAX_PACKET limited to 1500 bytes is the not support jumbo frames. This patch change ETH_MAX_PACKET the 65535 bytes

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-12 Thread Toke Høiland-Jørgensen
Neil Horman writes: > On Thu, Jul 11, 2019 at 03:39:09PM +0300, Ido Schimmel wrote: >> On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote: >> > From: Ido Schimmel >> > Date: Sun, 7 Jul 2019 10:58:17 +0300 >> > >> > > Users have several ways to debug the kernel and understand why a pa

Re: [PATCH v4 bpf-next 1/4] selftests/bpf: compile progs with -D__TARGET_ARCH_$(SRCARCH)

2019-07-12 Thread Ilya Leoshkevich
> Am 12.07.2019 um 02:53 schrieb Andrii Nakryiko : > > On Thu, Jul 11, 2019 at 7:32 AM Ilya Leoshkevich wrote: >> >> This opens up the possibility of accessing registers in an >> arch-independent way. >> >> Signed-off-by: Ilya Leoshkevich >> --- >> tools/testing/selftests/bpf/Makefile | 4 +++-

Re: [PATCH v4 bpf-next 0/4] selftests/bpf: fix compiling loop{1,2,3}.c on s390

2019-07-12 Thread Ilya Leoshkevich
> Am 11.07.2019 um 22:35 schrieb Stanislav Fomichev : > > On 07/11, Ilya Leoshkevich wrote: >> Use PT_REGS_RC(ctx) instead of ctx->rax, which is not present on s390. >> >> This patch series consists of three preparatory commits, which make it >> possible to use PT_REGS_RC in BPF selftests, follow

[PATCH 2/8] can: flexcan: use struct canfd_frame for CAN classic frame

2019-07-12 Thread Joakim Zhang
This patch prepares for CAN FD mode, using struct canfd_frame can both for classic format frame and fd format frame. Signed-off-by: Joakim Zhang --- drivers/net/can/flexcan.c| 34 +- drivers/net/can/rx-offload.c | 4 ++-- 2 files changed, 19 insertions(+), 19

[PATCH 4/8] can: flexcan: add CANFD BRS support

2019-07-12 Thread Joakim Zhang
This patch intends to add CAN FD BitRate Switch(BRS) support in driver. Signed-off-by: Joakim Zhang --- drivers/net/can/flexcan.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index 23e9407e33ff..4956ef64944a 100

[PATCH 3/8] can: flexcan: add CAN FD mode support

2019-07-12 Thread Joakim Zhang
This patch intends to add CAN FD mode support in driver, it means that payload size can extend up to 64 bytes. Bit timing always set in CBT register other than CTRL1 register when CANFD supports BRS, it will extend the range of all CAN bit timing variables (PRESDIV, PROPSEG, PSEG1, PSEG2 and RJW),

[PATCH 5/8] can: flexcan: add ISO CAN FD feature support

2019-07-12 Thread Joakim Zhang
ISO CAN FD is introduced to increase the failture detection capability than non-ISO CAN FD. The non-ISO CAN FD is still supported by FlexCAN so that it can be used mainly during an intermediate phase, for evaluation and development purposes. Therefore, it is strongly recommended to configure FlexC

[PATCH 0/8] can: flexcan: add CAN FD support for NXP Flexcan

2019-07-12 Thread Joakim Zhang
Hi Marc, This patch set intends to add support for NXP Flexcan CAN FD, it has been validated on three NXP platform(i.MX8QM/QXP, S32V234, LX2160AR1). After discussed with another two Fexcan owner, we sorted out this version. I hope you can pick up the patch set as it can fully meet requirement of

[PATCH 6/8] can: flexcan: add Transceiver Delay Compensation suopport

2019-07-12 Thread Joakim Zhang
The CAN FD protocol allows the transmission and reception of data at a higher bit rate than the nominal rate used in the arbitration phase when the message's BRS bit is set. The TDC mechanism is effective only during the data phase of FD frames having BRS bit set. It has no effect either on non-FD

  1   2   >