Hi Florian,
Thanks a lot for your reply.
Could you please elaborate more on how generic tracker tracks ESP connection?
Brs,
Bao
On Wed, 26 Jun 2019 at 18:13, Florian Westphal wrote:
>
> Naruto Nguyen wrote:
> > In linux/latest/source/net/netfilter/ folder, I only see we have
> > nf_conntrack_
Tue, Jul 09, 2019 at 09:13:53PM CEST, snel...@pensando.io wrote:
>On 7/8/19 11:56 PM, Jiri Pirko wrote:
>> Tue, Jul 09, 2019 at 12:58:00AM CEST, snel...@pensando.io wrote:
>> > On 7/8/19 1:03 PM, Jiri Pirko wrote:
>> > > Mon, Jul 08, 2019 at 09:58:09PM CEST, snel...@pensando.io wrote:
>> > > > On 7
Tue, Jul 09, 2019 at 09:03:36PM CEST, da...@davemloft.net wrote:
>From: Jakub Kicinski
>Date: Tue, 9 Jul 2019 11:20:58 -0700
>
>> On Tue, 9 Jul 2019 08:17:11 +0200, Jiri Pirko wrote:
>>> >But I'll leave it to Jiri and Dave to decide if its worth a respin :)
>>> >Functionally I think this is okay.
Switching from ->priv_destructor to dellink() has an unexpected
consequence: existing RCU readers, that is, hsr_port_get_hsr()
callers, may still be able to read the port list.
Instead of checking the return value of each hsr_port_get_hsr(),
we can just move it to ->ndo_uninit() which is called af
From: Gerd Rausch
Prior to
commit d021fabf525ff ("rds: rdma: add consumer reject")
function "rds_rdma_cm_event_handler_cmn" would always honor a rejected
connection attempt by issuing a "rds_conn_drop".
The commit mentioned above added a "break", eliminating
the "fallthrough" case and made the
From: Gerd Rausch
The proper "tos" value needs to be returned
to user-space (sockopt RDS_INFO_CONNECTIONS).
Fixes: 3eb450367d08 ("rds: add type of service(tos) infrastructure")
Signed-off-by: Gerd Rausch
Reviewed-by: Zhu Yanjun
Signed-off-by: Santosh Shilimkar
---
net/rds/connection.c | 1 +
Connections with legitimate tos values can get into usual connection
race. It can result in consumer reject. We don't want tos value or
protocol version to be demoted for such connections otherwise
piers would end up different tos values which can results in
no connection. Example a peer initiated
RDS composite message(rdma + control) user notification needs to be
triggered once the full message is delivered and such a fix was
added as part of commit 941f8d55f6d61 ("RDS: RDMA: Fix the composite
message user notification"). But rds_send_remove_from_sock is missing
data part notify check and h
Few rds fixes which makes rds rdma transport reliably working on mainline
First two fixes are applicable to v4.11+ stable versions and last
three patches applies to only v5.1 stable and current mainline.
Patchset is re-based against 'net' and also available on below tree
The following changes si
From: Gerd Rausch
This reverts commit 56012459310a1dbcc55c2dbf5500a9f7571402cb.
RDS kept spinning inside function "rds_ib_post_reg_frmr", waiting for
"i_fastreg_wrs" to become incremented:
while (atomic_dec_return(&ibmr->ic->i_fastreg_wrs) <= 0) {
atomic_inc(&ibmr->ic->
On Tue, Jul 09, 2019 at 08:54:58PM +, Saeed Mahameed wrote:
> On Thu, 2019-07-04 at 21:21 +0300, Leon Romanovsky wrote:
> > On Thu, Jul 04, 2019 at 01:21:04PM -0400, Saeed Mahameed wrote:
> > > On Thu, Jul 4, 2019 at 1:15 PM Leon Romanovsky
> > > wrote:
> > > > On Thu, Jul 04, 2019 at 01:06:58
On Tue, Jul 09, 2019 at 03:56:13PM -0500, Henry Orosco wrote:
> On Mon, Jul 08, 2019 at 02:13:39PM +, Jason Gunthorpe wrote:
> > On Sat, Jul 06, 2019 at 04:15:20PM +, Saleem, Shiraz wrote:
> > > > Subject: Re: [rdma 14/16] RDMA/irdma: Add ABI definitions
> > > >
> > > > On Fri, Jul 05, 2019
Return value was changes to 'int' from void but this return statement
was not updated, or it slipped in via a merge.
Fixes: b5d9a834f4fd ("net/tls: don't clear TX resync flag on error")
Signed-off-by: David S. Miller
---
Applied to net-next.
drivers/net/ethernet/mellanox/mlx5/core/en_accel/t
Jakub Kicinski wrote:
> On Mon, 08 Jul 2019 19:14:05 +, John Fastabend wrote:
> > @@ -287,6 +313,27 @@ static void tls_sk_proto_cleanup(struct sock *sk,
> > #endif
> > }
> >
> > +static void tls_sk_proto_unhash(struct sock *sk)
> > +{
> > + struct inet_connection_sock *icsk = inet_csk(sk)
Jakub Kicinski wrote:
> On Mon, 08 Jul 2019 19:15:18 +, John Fastabend wrote:
> > @@ -352,15 +354,18 @@ static void tls_sk_proto_close(struct sock *sk, long
> > timeout)
> > if (ctx->tx_conf == TLS_BASE && ctx->rx_conf == TLS_BASE)
> > goto skip_tx_cleanup;
> >
> > - sk->sk
Jakub Kicinski wrote:
> On Tue, 9 Jul 2019 17:04:59 -0700, Jakub Kicinski wrote:
> > On Tue, 09 Jul 2019 08:40:14 -0700, John Fastabend wrote:
> > > Jakub Kicinski wrote:
> > > > Looks like strparser is not done'd for offload?
> > >
> > > Right so if rx_conf != TLS_SW then the hardware needs
On Mon, 08 Jul 2019 19:14:05 +, John Fastabend wrote:
> @@ -287,6 +313,27 @@ static void tls_sk_proto_cleanup(struct sock *sk,
> #endif
> }
>
> +static void tls_sk_proto_unhash(struct sock *sk)
> +{
> + struct inet_connection_sock *icsk = inet_csk(sk);
> + long timeo = sock_sndtimeo
On Mon, 08 Jul 2019 19:15:18 +, John Fastabend wrote:
> @@ -352,15 +354,18 @@ static void tls_sk_proto_close(struct sock *sk, long
> timeout)
> if (ctx->tx_conf == TLS_BASE && ctx->rx_conf == TLS_BASE)
> goto skip_tx_cleanup;
>
> - sk->sk_prot = ctx->sk_proto;
>
On Mon, 08 Jul 2019 19:15:18 +, John Fastabend wrote:
> @@ -836,22 +841,39 @@ static int tls_init(struct sock *sk)
There is a goto out above this which has to be turned into return 0;
if out now releases the lock.
> if (sk->sk_state != TCP_ESTABLISHED)
> return -ENOTSUPP;
On 2019/7/10 上午4:03, Daniel Borkmann wrote:
On 07/09/2019 05:04 AM, Jason Wang wrote:
On 2019/7/9 上午6:38, Daniel Borkmann wrote:
On 07/02/2019 04:11 PM, Yuya Kusakabe wrote:
On 7/2/19 5:33 PM, Jason Wang wrote:
On 2019/7/2 下午4:16, Yuya Kusakabe wrote:
This adds XDP meta data support to bot
On Tue, 9 Jul 2019 17:04:59 -0700, Jakub Kicinski wrote:
> On Tue, 09 Jul 2019 08:40:14 -0700, John Fastabend wrote:
> > Jakub Kicinski wrote:
> > > Looks like strparser is not done'd for offload?
> >
> > Right so if rx_conf != TLS_SW then the hardware needs to do
> > the strparser functiona
On 2019/06/27 14:18, Manish Chopra wrote:
> > -Original Message-
> > From: Benjamin Poirier
> > Sent: Monday, June 17, 2019 1:19 PM
> > To: Manish Chopra ; GR-Linux-NIC-Dev > nic-...@marvell.com>; netdev@vger.kernel.org
> > Subject: [EXT] [PATCH net-next 16/16] qlge: Refill empty buffer q
On Mon, 8 Jul 2019 12:06:17 -0400
Roman Mashak wrote:
> Add 32-bit missing mask attribute in iproute2/tc, which has been long
> supported by the kernel side.
>
> v2: print value in hex with print_hex() as suggested by Stephen Hemminger.
>
> Signed-off-by: Roman Mashak
Both patches applied
On Mon, 8 Jul 2019 11:36:42 +0200
Andrea Claudi wrote:
> Setting metrics for routes currently lead to non-parsable
> json output. For example:
>
> $ ip link add type dummy
> $ ip route add 192.168.2.0 dev dummy0 metric 100 mtu 1000 rto_min 3
> $ ip -j route | jq
> parse error: ':' not as part o
On Tue, 09 Jul 2019 08:40:14 -0700, John Fastabend wrote:
> Jakub Kicinski wrote:
> > Looks like strparser is not done'd for offload?
>
> Right so if rx_conf != TLS_SW then the hardware needs to do
> the strparser functionality.
Can I just take a stab at fixing the HW part?
Can I rebase this o
On Tue, Jul 9, 2019 at 11:38 PM Stephen Hemminger
wrote:
>
> On Tue, 9 Jul 2019 22:40:40 +0200
> Matteo Croce wrote:
>
> > iproute has an utility function which checks if a string is a prefix for
> > another one, to allow use of abbreviated commands, e.g. 'addr' or 'a'
> > instead of 'address'.
On 7/8/19 7:27 PM, Andrew Lunn wrote:
+static int ionic_get_module_eeprom(struct net_device *netdev,
+ struct ethtool_eeprom *ee,
+ u8 *data)
+{
+ struct lif *lif = netdev_priv(netdev);
+ struct ionic_dev *idev = &lif->
On Tue, 9 Jul 2019 15:38:44 +0300, Ido Schimmel wrote:
> On Mon, Jul 08, 2019 at 03:51:58PM -0700, Jakub Kicinski wrote:
> > On Mon, 8 Jul 2019 16:19:08 +0300, Ido Schimmel wrote:
> > > On Sun, Jul 07, 2019 at 12:45:41PM -0700, David Miller wrote:
> > > > From: Ido Schimmel
> > > > Date: Sun,
On 7/8/19 10:15 PM, Michal Kubecek wrote:
Also, there is no need to zero initialize ks->link_modes.advertising
above if it's going to be rewritten here anyway.
Michal
Got it.
Thanks,
sln
On 7/9/19 11:26 AM, Parav Pandit wrote:
> Show devlink port number whenever kernel reports that attribute.
>
> An example output for a physical port.
> $ devlink port show
> pci/:06:00.1/65535: type eth netdev eth1_p1 flavour physical port 1
>
> Acked-by: Jiri Pirko
> Signed-off-by: Parav Pa
On 7/8/19 10:25 PM, Michal Kubecek wrote:
On Mon, Jul 08, 2019 at 12:25:26PM -0700, Shannon Nelson wrote:
Add in the basic ethtool callbacks for device information
and control.
+
+ if (fec_type != idev->port_info->config.fec_type) {
+ mutex_lock(&ionic->dev_cmd_lock);
+
On Tue, Jul 9, 2019 at 6:16 AM Andrea Claudi wrote:
>
> Tunnel change fails if a tunnel name is not specified while using
> 'ip -6 tunnel change'. However, no warning message is printed and
> no error code is returned.
>
> $ ip -6 tunnel add ip6tnl1 mode ip6gre local fd::1 remote fd::2 tos inherit
On Tue, Jul 9, 2019 at 7:13 AM wrote:
>
> From: Josua Mayer
>
> Armada 8040 needs four clocks to be enabled for MDIO accesses to work.
> Update the binding to allow the extra clock to be specified.
>
> Cc: sta...@vger.kernel.org
> Fixes: 6d6a331f44a1 ("dt-bindings: allow up to three clocks for or
On Mon, Jul 8, 2019 at 8:41 PM Andrew Lunn wrote:
>
> > > Optional properties:
> > > - interrupts: interrupt line number for the SMI error/done interrupt
> > > -- clocks: phandle for up to three required clocks for the MDIO instance
> > > +- clocks: phandle for up to four required clocks for the
From: Vivien Didelot
Date: Mon, 8 Jul 2019 23:31:13 -0400
> This patch adds support for enabling or disabling the flooding of
> unknown multicast traffic on the CPU ports, depending on the value
> of the switchdev SWITCHDEV_ATTR_ID_BRIDGE_MROUTER attribute.
>
> The current behavior is kept unch
From: David Ahern
Date: Tue, 9 Jul 2019 14:45:17 -0700
> From: David Ahern
>
> Commit 9903c8dc7342 changed TC_ETF defines to use _BITUL instead of BIT
> but did not add the dependecy on linux/const.h. As a consequence,
> importing the uapi headers into iproute2 causes builds to fail. Add
> the
From: Ilias Apalodimas
Date: Wed, 10 Jul 2019 00:14:48 +0300
> While freeing tx buffers the memory has to be unmapped if the packet was
> an skb or was used for .ndo_xdp_xmit using the same arguments. Get rid
> of the unneeded extra 'else if' statement
>
> Signed-off-by: Ilias Apalodimas
Appli
From: Ilias Apalodimas
Date: Wed, 10 Jul 2019 00:14:49 +0300
> On commit ba2b232108d3 ("net: netsec: add XDP support") a static
> declaration for netsec_set_tx_de() was added to make the diff easier
> to read. Now that the patch is merged let's move the functions around
> and get rid of that
>
From: David Ahern
Commit 9903c8dc7342 changed TC_ETF defines to use _BITUL instead of BIT
but did not add the dependecy on linux/const.h. As a consequence,
importing the uapi headers into iproute2 causes builds to fail. Add
the dependency.
Fixes: 9903c8dc7342 ("etf: Don't use BIT() in UAPI heade
Ok that's enough, gotta close the door... :-)
Please bug fixes only at this point, thank you.
From: Pablo Neira Ayuso
Date: Tue, 9 Jul 2019 22:55:38 +0200
> This patchset adds support for Netfilter hardware offloads.
Series applied with v5 of patch #12.
Please follow-up to any other feedback as necessary, thank you.
On Tue, Jul 9, 2019 at 1:27 PM Edward Cree wrote:
>
> On 05/07/2019 22:15, Daniel Borkmann wrote:
> > On 07/05/2019 05:50 PM, Andrii Nakryiko wrote:
> >> This patch set implements an update to how BTF-defined maps are specified.
> >> The
> >> change is in how integer attributes, e.g., type, max_e
On Tue, 9 Jul 2019 22:40:40 +0200
Matteo Croce wrote:
> iproute has an utility function which checks if a string is a prefix for
> another one, to allow use of abbreviated commands, e.g. 'addr' or 'a'
> instead of 'address'.
>
> This routine unfortunately considers an empty string as prefix
> o
Many tc modules were printing error messages to stdout.
This is problematic if using JSON or other output formats.
Change all these places to use fprintf(stderr, ...) instead.
Also, remove unnecessary initialization and places
where else is used after error return.
Signed-off-by: Stephen Hemminge
On commit ba2b232108d3 ("net: netsec: add XDP support") a static
declaration for netsec_set_tx_de() was added to make the diff easier
to read. Now that the patch is merged let's move the functions around
and get rid of that
Signed-off-by: Ilias Apalodimas
---
drivers/net/ethernet/socionext/nets
While freeing tx buffers the memory has to be unmapped if the packet was
an skb or was used for .ndo_xdp_xmit using the same arguments. Get rid
of the unneeded extra 'else if' statement
Signed-off-by: Ilias Apalodimas
---
drivers/net/ethernet/socionext/netsec.c | 8
1 file changed, 4 in
From: Lucas Bates
Date: Mon, 8 Jul 2019 21:34:25 -0400
> This series supersedes the previous submission that included a patch for test
> case verification using JSON output. It adds a new tdc plugin, scapyPlugin,
> as
> a way to send traffic to test tc filters and actions.
>
> The first patch
On Tue, 9 Jul 2019 14:36:34 -0600
David Ahern wrote:
> On 7/9/19 11:00 AM, Stephen Hemminger wrote:
> > On Tue, 9 Jul 2019 16:59:31 +0100
> > John Hurley wrote:
> >
> >>if (!tb[TCA_MPLS_PARMS]) {
> >> + print_string(PRINT_FP, NULL, "%s", "[NULL mpls parameters]");
> >
> > Thi
This patch adds hardware offload support for nftables through the
existing netdev_ops->ndo_setup_tc() interface, the TC_SETUP_CLSFLOWER
classifier and the flow rule API. This hardware offload support is
available for the NFPROTO_NETDEV family and the ingress hook.
Each nftables expression has a ne
And any other existing fields in this structure that refer to tc.
Specifically:
* tc_cls_flower_offload_flow_rule() to flow_cls_offload_flow_rule().
* TC_CLSFLOWER_* to FLOW_CLS_*.
* tc_cls_common_offload to tc_cls_common_offload.
Signed-off-by: Pablo Neira Ayuso
---
v4: new patch, rename tc def
This patch adds hardware offload support for nftables through the
existing netdev_ops->ndo_setup_tc() interface, the TC_SETUP_CLSFLOWER
classifier and the flow rule API. This hardware offload support is
available for the NFPROTO_NETDEV family and the ingress hook.
Each nftables expression has a ne
This patch adds a function to check if flow block callback is already in
use. Call this new function from flow_block_cb_setup_simple() and from
drivers.
Signed-off-by: Pablo Neira Ayuso
---
v4: no changes.
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c| 4
drivers/net/ethernet/mell
Unused, now replaced by flow block API.
Signed-off-by: Pablo Neira Ayuso
---
v4: no changes.
include/net/pkt_cls.h | 69
net/sched/cls_api.c | 98 ---
2 files changed, 167 deletions(-)
diff --git a/include/n
Add a new helper function to allocate flow_block_cb objects.
Signed-off-by: Pablo Neira Ayuso
---
v4: no changes.
include/net/flow_offload.h | 14 ++
net/core/flow_offload.c| 28
2 files changed, 42 insertions(+)
diff --git a/include/net/flow_offloa
Rename from TCF_BLOCK_BINDER_TYPE_* to FLOW_BLOCK_BINDER_TYPE_* and
remove temporary tcf_block_binder_type alias.
Signed-off-by: Pablo Neira Ayuso
---
v4: no changes.
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c| 2 +-
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 ++--
driv
Rename from TC_BLOCK_{UN}BIND to FLOW_BLOCK_{UN}BIND and remove
temporary tc_block_command alias.
Signed-off-by: Pablo Neira Ayuso
---
v4: no changes.
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 4 ++--
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 ++--
drivers/net/ethernet
This patch updates flow_block_cb_setup_simple() to use the flow block API.
Several drivers are also adjusted to use it.
This patch introduces the per-driver list of flow blocks to account for
blocks that are already in use.
Remove tc_block_offload alias.
Signed-off-by: Pablo Neira Ayuso
---
v4:
On Mon, Jul 08, 2019 at 02:13:39PM +, Jason Gunthorpe wrote:
> On Sat, Jul 06, 2019 at 04:15:20PM +, Saleem, Shiraz wrote:
> > > Subject: Re: [rdma 14/16] RDMA/irdma: Add ABI definitions
> > >
> > > On Fri, Jul 05, 2019 at 04:42:19PM +, Saleem, Shiraz wrote:
> > > > > Subject: Re: [rdm
Most drivers do the same thing to set up the flow block callbacks, this
patch adds a helper function to do this.
This preparation patch reduces the number of changes to adapt the
existing drivers to use the flow block callback API.
This new helper function takes a flow block list per-driver, whic
This patch completes the flow block API to introduce:
* flow_block_cb_priv() to access callback private data.
* flow_block_cb_incref() to bump reference counter on this flow block.
* flow_block_cb_decref() to decrement the reference counter.
These functions are taken from the existing tcf_block_c
Hi,
This patchset adds support for Netfilter hardware offloads.
This patchset reuses the existing block infrastructure, the
netdev_ops->ndo_setup_tc() interface, TC_SETUP_CLSFLOWER classifier and
the flow rule API.
Patch #1 adds flow_block_cb_setup_simple(), most drivers do the same thing
This patch adds the list handling functions for the flow block API:
* flow_block_cb_lookup() allows drivers to look up for existing flow blocks.
* flow_block_cb_add() adds a flow block to the per driver list to be registered
by the core.
* flow_block_cb_remove() to remove a flow block from the l
This patch adds tcf_block_setup() which uses the flow block API.
This infrastructure takes the flow block callbacks coming from the
driver and register/unregister to/from the cls_api core.
Signed-off-by: Pablo Neira Ayuso
---
v4: Remove driver_list handling from the core - Jiri Pirko.
net/sche
On Thu, 2019-07-04 at 21:21 +0300, Leon Romanovsky wrote:
> On Thu, Jul 04, 2019 at 01:21:04PM -0400, Saeed Mahameed wrote:
> > On Thu, Jul 4, 2019 at 1:15 PM Leon Romanovsky
> > wrote:
> > > On Thu, Jul 04, 2019 at 01:06:58PM -0400, Saeed Mahameed wrote:
> > > > On Wed, Jul 3, 2019 at 5:27 AM wr
iproute has an utility function which checks if a string is a prefix for
another one, to allow use of abbreviated commands, e.g. 'addr' or 'a'
instead of 'address'.
This routine unfortunately considers an empty string as prefix
of any pattern, leading to undefined behaviour when an empty
argument
On 7/9/19 9:59 AM, John Hurley wrote:
> +static void explain(void)
> +{
> + fprintf(stderr,
> + "Usage: mpls pop [ protocol MPLS_PROTO ]\n"
> + " mpls push [ protocol MPLS_PROTO ] [ label MPLS_LABEL ]
> [ tc MPLS_TC ] [ ttl MPLS_TTL ] [ bos MPLS_BOS ] [CONTROL]\
On 7/9/19 11:00 AM, Stephen Hemminger wrote:
> On Tue, 9 Jul 2019 16:59:31 +0100
> John Hurley wrote:
>
>> if (!tb[TCA_MPLS_PARMS]) {
>> +print_string(PRINT_FP, NULL, "%s", "[NULL mpls parameters]");
>
> This is an error message please just use fprintf(stderr instead
>
skbedi
On 05/07/2019 22:15, Daniel Borkmann wrote:
> On 07/05/2019 05:50 PM, Andrii Nakryiko wrote:
>> This patch set implements an update to how BTF-defined maps are specified.
>> The
>> change is in how integer attributes, e.g., type, max_entries, map_flags, are
>> specified: now they are captured as p
From: jo...@solid-run.com
Date: Tue, 9 Jul 2019 15:00:57 +0200
> From: Josua Mayer
>
> With a modular kernel as configured by Debian a hang was observed with
> the Armada 8040 SoC in the Clearfog GT and Macchiatobin boards.
>
> The 8040 SoC actually requires four clocks to be enabled for the m
On 07/09/2019 05:04 AM, Jason Wang wrote:
> On 2019/7/9 上午6:38, Daniel Borkmann wrote:
>> On 07/02/2019 04:11 PM, Yuya Kusakabe wrote:
>>> On 7/2/19 5:33 PM, Jason Wang wrote:
On 2019/7/2 下午4:16, Yuya Kusakabe wrote:
> This adds XDP meta data support to both receive_small() and
> recei
From: Ilias Apalodimas
Date: Tue, 9 Jul 2019 15:35:53 +0300
> The current driver starts using page_pool buffers before calling
> xdp_rxq_info_reg_mem_model(). Start using the buffers after the
> registration succeeded, so we won't have to call
> page_pool_request_shutdown() in case of failure
>
From: Denis Kirjanov
Date: Tue, 9 Jul 2019 13:42:51 +0200
> @@ -962,7 +962,8 @@ static void vhost_del_umem_range(struct vhost_umem *umem,
>
> while ((node = vhost_umem_interval_tree_iter_first(&umem->umem_tree,
> start, end)))
> -
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Parav Pandit
> Sent: Tuesday, July 2, 2019 12:00 AM
> To: netdev@vger.kernel.org
> Cc: Saeed Mahameed ;
> jakub.kicin...@netronome.com; Jiri Pirko ; Parav Pandit
>
> Subject: [RESEND PATCH iproute2 net-next] devli
Same rationale as for sfc, except that this wasn't performance-tested.
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/falcon/rx.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/sfc/falcon/rx.c
b/drivers/net/ethernet/sfc/falcon/rx.c
index fd
When GRO decides not to coalesce a packet, in napi_frags_finish(), instead
of passing it to the stack immediately, place it on a list in the napi
struct. Then, at flush time (napi_complete_done() or napi_poll()), call
netif_receive_skb_list_internal() on the list. We'd like to do that in
napi
We already scored points when handling the RX event, no-one else does this,
and looking at the history it appears this was originally meant to only
score on merges, not on GRO_NORMAL. Moreover, it gets in the way of
changing GRO to not immediately pass GRO_NORMAL skbs to the stack.
Performance
This series listifies part of GRO processing, in a manner which allows those
packets which are not GROed (i.e. for which dev_gro_receive returns
GRO_NORMAL) to be passed on to the listified regular receive path.
dev_gro_receive() itself is not listified, nor the per-protocol GRO
callback, since
Hi Dave,
> -Original Message-
> From: David Miller
> Sent: Wednesday, July 10, 2019 12:34 AM
> To: jakub.kicin...@netronome.com
> Cc: j...@resnulli.us; Parav Pandit ;
> netdev@vger.kernel.org; Jiri Pirko ; Saeed Mahameed
>
> Subject: Re: [PATCH net-next v6 0/5] devlink: Introduce PCI PF,
From: Michael Chan
Date: Tue, 9 Jul 2019 03:50:07 -0400
> Add page_pool_destroy() in bnxt_free_rx_rings() during normal RX ring
> cleanup, as Ilias has informed us that the following commit has been
> merged:
>
> 1da4bbeffe41 ("net: core: page_pool: add user refcnt and reintroduce
> page_pool_
From: Paul Blakey
Date: Tue, 9 Jul 2019 10:30:47 +0300
> This patch series add connection tracking capabilities in tc sw datapath.
> It does so via a new tc action, called act_ct, and new tc flower classifier
> matching
> on conntrack state, mark and label.
...
Ok, I applied this, but two thi
On 7/8/19 11:56 PM, Jiri Pirko wrote:
Tue, Jul 09, 2019 at 12:58:00AM CEST, snel...@pensando.io wrote:
On 7/8/19 1:03 PM, Jiri Pirko wrote:
Mon, Jul 08, 2019 at 09:58:09PM CEST, snel...@pensando.io wrote:
On 7/8/19 12:34 PM, Jiri Pirko wrote:
Mon, Jul 08, 2019 at 09:25:32PM CEST, snel...@pens
On 7/8/19 6:26 PM, Jakub Kicinski wrote:
On Mon, 8 Jul 2019 12:25:32 -0700, Shannon Nelson wrote:
Add a devlink interface for access to information that isn't
normally available through ethtool or the iplink interface.
Example:
$ ./devlink -j -p dev info pci/:b6:00.0
{
From: Jakub Kicinski
Date: Tue, 9 Jul 2019 11:20:58 -0700
> On Tue, 9 Jul 2019 08:17:11 +0200, Jiri Pirko wrote:
>> >But I'll leave it to Jiri and Dave to decide if its worth a respin :)
>> >Functionally I think this is okay.
>>
>> I'm happy with the set as it is right now.
>
> To be clear, I
On Tue, Jul 09, 2019 at 12:31:54PM -0400, Andy Gospodarek wrote:
> On Tue, Jul 09, 2019 at 06:20:57PM +0300, Ilias Apalodimas wrote:
> > Hi,
> >
> > > > Add page_pool_destroy() in bnxt_free_rx_rings() during normal RX ring
> > > > cleanup, as Ilias has informed us that the following commit has bee
On Tue, 9 Jul 2019 08:17:11 +0200, Jiri Pirko wrote:
> >But I'll leave it to Jiri and Dave to decide if its worth a respin :)
> >Functionally I think this is okay.
>
> I'm happy with the set as it is right now.
To be clear, I am happy enough as well. Hence the review tag.
> Anyway, if you want
(let's hope that the gmail web interface doesn't mangle this too much)
On Mon, Jul 8, 2019 at 10:16 AM kbuild test robot wrote:
>
> tree:
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/davem/net-next.git
> master
> head: 61a582be1a668a0c1407a46f779965bfeff88784
> commit: a653f2f
Software event output is only enabled by a few prog types right now (TC,
LWT out, XDP, sockops). Many other skb based prog types need
bpf_skb_event_output to produce software event.
More prog types are enabled to access bpf_skb_event_output in this
patch.
v8 changes:
No actual change, just cc to
From: allanzhang
Software event output is only enabled by a few prog types.
This test is to ensure that all supported types are enabled for
bpf_perf_event_output successfully.
Signed-off-by: Allan Zhang
---
tools/testing/selftests/bpf/test_verifier.c | 12 ++-
.../selftests/bpf/verifier/even
From: allanzhang
Software event output is only enabled by a few prog types right now (TC,
LWT out, XDP, sockops). Many other skb based prog types need
bpf_skb_event_output to produce software event.
Added socket_filter, cg_skb, sk_skb prog types to generate sw event.
Test bpf code is generated
On Tue, Jul 9, 2019 at 8:22 AM Ilya Leoshkevich wrote:
>
> bpf_helpers.h fails to compile on sparc: the code should be checking
> for defined(bpf_target_sparc), but checks simply for bpf_target_sparc.
>
> Signed-off-by: Ilya Leoshkevich
> ---
> tools/testing/selftests/bpf/bpf_helpers.h | 2 +-
>
On Sat, Jul 06, 2019 at 12:00:44AM +0200, Daniel Borkmann wrote:
> On 07/05/2019 07:26 PM, Quentin Monnet wrote:
> > 2019-07-05 10:24 UTC-0700 ~ Jakub Kicinski
> >> On Fri, 5 Jul 2019 14:10:31 +0200, Jiri Olsa wrote:
> >>> Michael reported crash with by bpf program in json mode on powerpc:
> >>>
>
On Tue, Jul 9, 2019 at 8:18 AM Ilya Leoshkevich wrote:
>
> Use PT_REGS_RC(ctx) instead of ctx->rax, which is not present on s390.
>
> This patch series consists of three preparatory commits, which make it
> possible to use PT_REGS_RC in BPF selftests, followed by the actual fix.
>
> Since the last
On Tue, Jul 9, 2019 at 8:19 AM Ilya Leoshkevich wrote:
>
> Right now, on certain architectures, these macros are usable only with
> kernel headers. This patch makes it possible to use them with userspace
> headers and, as a consequence, not only in BPF samples, but also in BPF
> selftests.
>
> On
On Tue, 9 Jul 2019 11:14:00 -0600
David Ahern wrote:
> On 7/9/19 7:16 AM, Andrea Claudi wrote:
> > This reverts commit ba126dcad20e6d0e472586541d78bdd1ac4f1123.
> > It breaks tunnel creation when using 'dev' parameter:
> >
> > $ ip link add type dummy
> > $ ip -6 tunnel add ip6tnl1 mode ip6ip6 r
On Tue, Jul 9, 2019 at 6:16 AM Andrea Claudi wrote:
>
> This reverts commit ba126dcad20e6d0e472586541d78bdd1ac4f1123.
> It breaks tunnel creation when using 'dev' parameter:
>
> $ ip link add type dummy
> $ ip -6 tunnel add ip6tnl1 mode ip6ip6 remote 2001:db8::100::2 local
> 2001:db8::100
Show devlink port number whenever kernel reports that attribute.
An example output for a physical port.
$ devlink port show
pci/:06:00.1/65535: type eth netdev eth1_p1 flavour physical port 1
Acked-by: Jiri Pirko
Signed-off-by: Parav Pandit
---
Changelog:
v0->v1:
- Declare and assign port_
> -Original Message-
> From: David Ahern
> Sent: Tuesday, July 9, 2019 10:41 PM
> To: Parav Pandit ; netdev@vger.kernel.org
> Cc: step...@networkplumber.org; Jiri Pirko ;
> dsah...@kernel.org
> Subject: Re: [PATCH net-next iproute2] devlink: Show devlink port number
>
> On 7/9/19 10:33
On 7/9/19 7:16 AM, Andrea Claudi wrote:
> This reverts commit ba126dcad20e6d0e472586541d78bdd1ac4f1123.
> It breaks tunnel creation when using 'dev' parameter:
>
> $ ip link add type dummy
> $ ip -6 tunnel add ip6tnl1 mode ip6ip6 remote 2001:db8::100::2 local
> 2001:db8::100::1 hoplimit 1
On 7/9/19 10:33 AM, Parav Pandit wrote:
> @@ -2806,6 +2806,11 @@ static void pr_out_port(struct dl *dl, struct nlattr
> **tb)
>
> pr_out_str(dl, "flavour", port_flavour_name(port_flavour));
> }
> + if (tb[DEVLINK_ATTR_PORT_NUMBER]) {
> + uint32_t port_number =
On Tue, 9 Jul 2019 16:59:31 +0100
John Hurley wrote:
> if (!tb[TCA_MPLS_PARMS]) {
> + print_string(PRINT_FP, NULL, "%s", "[NULL mpls parameters]");
This is an error message please just use fprintf(stderr instead
1 - 100 of 180 matches
Mail list logo