Re: [PATCH iproute2-next 1/9] libnetlink: Set NLA_F_NESTED in rta_nest

2019-05-30 Thread Michal Kubecek
On Thu, May 30, 2019 at 11:50:59AM -0600, David Ahern wrote: > On 5/30/19 11:43 AM, Stephen Hemminger wrote: > > > > I assume older kernels ignore the attribute? > > > > Also, how is this opt-in for running iproute2-next on old kernels? > > from what I can see older kernel added the flag when ge

[PATCH net-next] cxgb4: Set initial IRQ affinity hints

2019-05-30 Thread Nirranjan Kirubaharan
Spread initial IRQ affinity hints across the device node CPUs, for nic queue and uld queue IRQs, to load balance and avoid all interrupts on CPU0. Signed-off-by: Nirranjan Kirubaharan --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 7 +++- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |

[PATCH V5 net-next 3/6] net: Add a layer for non-PHY MII time stamping drivers.

2019-05-30 Thread Richard Cochran
While PHY time stamping drivers can simply attach their interface directly to the PHY instance, stand alone drivers require support in order to manage their services. Non-PHY MII time stamping drivers have a control interface over another bus like I2C, SPI, UART, or via a memory mapped peripheral.

[PATCH V5 net-next 2/6] net: Introduce a new MII time stamping interface.

2019-05-30 Thread Richard Cochran
Currently the stack supports time stamping in PHY devices. However, there are newer, non-PHY devices that can snoop an MII bus and provide time stamps. In order to support such devices, this patch introduces a new interface to be used by both PHY and non-PHY devices. In addition, the one and onl

[PATCH V5 net-next 4/6] dt-bindings: ptp: Introduce MII time stamping devices.

2019-05-30 Thread Richard Cochran
This patch add a new binding that allows non-PHY MII time stamping devices to find their buses. The new documentation covers both the generic binding and one upcoming user. Signed-off-by: Richard Cochran Reviewed-by: Andrew Lunn --- Documentation/devicetree/bindings/ptp/ptp-ines.txt | 35 +

[PATCH V5 net-next 6/6] ptp: Add a driver for InES time stamping IP core.

2019-05-30 Thread Richard Cochran
The InES at the ZHAW offers a PTP time stamping IP core. The FPGA logic recognizes and time stamps PTP frames on the MII bus. This patch adds a driver for the core along with a device tree binding to allow hooking the driver to MII buses. Signed-off-by: Richard Cochran --- drivers/ptp/Kconfig

[PATCH V5 net-next 1/6] net: Introduce peer to peer one step PTP time stamping.

2019-05-30 Thread Richard Cochran
The 1588 standard defines one step operation for both Sync and PDelay_Resp messages. Up until now, hardware with P2P one step has been rare, and kernel support was lacking. This patch adds support of the mode in anticipation of new hardware developments. Signed-off-by: Richard Cochran --- driv

[PATCH V5 net-next 0/6] Peer to Peer One-Step time stamping

2019-05-30 Thread Richard Cochran
This series adds support for PTP (IEEE 1588) P2P one-step time stamping along with a driver for a hardware device that supports this. If the hardware supports p2p one-step, it subtracts the ingress time stamp value from the Pdelay_Request correction field. The user space software stack then simpl

[PATCH V5 net-next 5/6] net: mdio: of: Register discovered MII time stampers.

2019-05-30 Thread Richard Cochran
When parsing a PHY node, register its time stamper, if any, and attach the instance to the PHY device. Signed-off-by: Richard Cochran --- drivers/net/phy/phy_device.c | 3 +++ drivers/of/of_mdio.c | 30 +- 2 files changed, 32 insertions(+), 1 deletion(-) dif

Re: [PATCH V4 net-next 0/6] Peer to Peer One-Step time stamping

2019-05-30 Thread Richard Cochran
On Thu, May 30, 2019 at 12:58:33PM -0700, David Miller wrote: > I had to revert, this doesn't build. Sorry I missed macvlan, and thanks for the 'uninitialized' warning. It was a real latent bug. I wonder why my linaro 7.4 gcc didn't flag that... Anyhow, I rebased v5 of my series to latest net-ne

[PATCH iproute2-next v1 4/4] rdma: Add man page for rdma dev set netns command

2019-05-30 Thread Parav Pandit
Add man page to describe additional set netns command for rdma device. Reviewed-by: Leon Romanovsky Signed-off-by: Parav Pandit --- man/man8/rdma-dev.8 | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/man/man8/rdma-dev.8 b/man/man8/rdma-dev.8 index 069f471

[PATCH iproute2-next v1 3/4] rdma: Add an option to set net namespace of rdma device

2019-05-30 Thread Parav Pandit
Enrich rdmatool with an option to set network namespace of RDMA device. After successful execution of it, rdma device will be accessible only in assigned network namespace. rdma tool command examples and output. First set netns mode to exclusive. $ rdma system set netns exclusive Now create net

[PATCH iproute2-next v1 2/4] rdma: Add man pages for rdma system commands

2019-05-30 Thread Parav Pandit
Reviewed-by: Leon Romanovsky Signed-off-by: Parav Pandit --- man/man8/rdma-system.8 | 82 ++ man/man8/rdma.8| 7 +++- 2 files changed, 88 insertions(+), 1 deletion(-) create mode 100644 man/man8/rdma-system.8 diff --git a/man/man8/rdma-system.8

[PATCH iproute2-next v1 1/4] rdma: Add an option to query,set net namespace sharing sys parameter

2019-05-30 Thread Parav Pandit
Enrich rdmatool with an option to query rdma subsystem parameter whether rdma devices are shared among multiple network namespaces or exclusive to single network namespace. rdma tool command examples and output. $ rdma system show netns shared $ rdma system set netns exclusive $ rdma system sho

[PATCH iproute2-next v1 0/4] Enrich rdma tool for net namespace commands

2019-05-30 Thread Parav Pandit
RDMA subsystem can be running in either of the modes. (a) Sharing RDMA devices among multiple net namespaces or (b) Exclusive mode where RDMA device is bound to single net namespace This patch series adds (1) query command to query rdma subsystem sharing mode (2) set command to change rdma subsys

RE: [PATCH iproute2-next 1/4] rdma: Add an option to query,set net namespace sharing sys parameter

2019-05-30 Thread Parav Pandit
Hi David, > -Original Message- > From: David Ahern > Sent: Wednesday, May 29, 2019 9:43 PM > To: Parav Pandit > Cc: netdev@vger.kernel.org; linux-r...@vger.kernel.org; > step...@networkplumber.org; Leon Romanovsky > Subject: Re: [PATCH iproute2-next 1/4] rdma: Add an option to query,set

Re: [PATCH net 1/3] net/tls: avoid NULL-deref on resync during device removal

2019-05-30 Thread Jakub Kicinski
On Tue, 21 May 2019 19:02:00 -0700, Jakub Kicinski wrote: > When netdev with active kTLS sockets in unregistered > notifier callback walks the offloaded sockets and > cleans up offload state. RX data may still be processed, > however, and if resync was requested prior to device > removal we would

Re: [PATCH bpf-next v5 3/6] bpf: Add IPv6 Segment Routing helpers

2019-05-30 Thread Tom Herbert
On Sat, May 12, 2018 at 8:26 AM Mathieu Xhonneux wrote: > > The BPF seg6local hook should be powerful enough to enable users to > implement most of the use-cases one could think of. After some thinking, > we figured out that the following actions should be possible on a SRv6 > packet, requiring 3

Re: [PATCH net-next 1/6] seg6: Fix TLV definitions

2019-05-30 Thread Tom Herbert
On Thu, May 30, 2019 at 3:18 PM David Miller wrote: > > From: Tom Herbert > Date: Thu, 30 May 2019 14:50:16 -0700 > > > TLV constants are defined for PAD1, PADN, and HMAC (the three defined in > > draft-ietf-6man-segment-routing-header-19). The other TLV are unused and > > not correct so they are

Re: [PATCH net v2] net: correct zerocopy refcnt with udp MSG_MORE

2019-05-30 Thread David Miller
From: Willem de Bruijn Date: Thu, 30 May 2019 18:01:21 -0400 > From: Willem de Bruijn > > TCP zerocopy takes a uarg reference for every skb, plus one for the > tcp_sendmsg_locked datapath temporarily, to avoid reaching refcnt zero > as it builds, sends and frees skbs inside its inner loop. > >

Re: kTLS broken somewhere between 4.18 and 5.0

2019-05-30 Thread Andre Tomt
On 07.05.2019 16:45, John Fastabend wrote: Andre Tomt wrote: On 14.04.2019 22:40, John Fastabend wrote: On 4/13/19 6:56 PM, Andre Tomt wrote: On 13.04.2019 17:34, Steinar H. Gunderson wrote: Hi, I've been using kTLS for a while, with my video reflector Cubemap (https://git.sesse.net/?p=cubem

Re: EoGRE sends undersized frames without padding

2019-05-30 Thread Steinar H. Gunderson
On Thu, May 30, 2019 at 10:35:08AM +0200, Steinar H. Gunderson wrote: > After looking at the GRE packets in Wireshark, it turns out the Ethernet > packets within the EoGRE packet is undersized (under 60 bytes), and Linux > doesn't pad them. I haven't found anything in RFC 7637 that says anything >

[PATCH net] vrf: Increment Icmp6InMsgs on the original netdev

2019-05-30 Thread Stephen Suryaputra
Get the ingress interface and increment ICMP counters based on that instead of skb->dev when the the dev is a VRF device. This is a follow up on the following message: https://www.spinics.net/lists/netdev/msg560268.html Signed-off-by: Stephen Suryaputra --- net/ipv6/icmp.c | 17 ++

Re: [PATCH net-next 1/6] seg6: Fix TLV definitions

2019-05-30 Thread David Miller
From: Tom Herbert Date: Thu, 30 May 2019 14:50:16 -0700 > TLV constants are defined for PAD1, PADN, and HMAC (the three defined in > draft-ietf-6man-segment-routing-header-19). The other TLV are unused and > not correct so they are removed. Removing macros will break userland compilation, you ca

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-05-30

2019-05-30 Thread David Miller
From: Jeff Kirsher Date: Thu, 30 May 2019 11:50:30 -0700 > This series contains updates to ice driver only. Pulled, thanks Jeff.

Re: [PATCH net-next v2 0/3] net: phy: improve handling of more complex C45 PHY's

2019-05-30 Thread David Miller
From: Heiner Kallweit Date: Thu, 30 May 2019 15:08:09 +0200 > This series tries to address few problematic aspects raised by > Russell. Concrete example is the Marvell 88x3310, the changes > should be helpful for other complex C45 PHY's too. > > v2: > - added patch enabling interrupts also if ph

Re: [PATCH bpf v4] libbpf: Return btf_fd for load_sk_storage_btf

2019-05-30 Thread Song Liu
On Wed, May 29, 2019 at 11:30 AM Michal Rostecki wrote: > > Before this change, function load_sk_storage_btf expected that > libbpf__probe_raw_btf was returning a BTF descriptor, but in fact it was > returning an information about whether the probe was successful (0 or > 1). load_sk_storage_btf wa

Re: [PATCH net-next] qed: Fix static checker warning

2019-05-30 Thread David Miller
From: Michal Kalderon Date: Thu, 30 May 2019 15:20:40 +0300 > In some cases abs_ppfid could be printed without being initialized. > > Fixes: 79284adeb99e ("qed: Add llh ppfid interface and 100g support for > offload protocols") > Reported-by: Dan Carpenter > Signed-off-by: Michal Kalderon Ap

[PATCH net v2] net: correct zerocopy refcnt with udp MSG_MORE

2019-05-30 Thread Willem de Bruijn
From: Willem de Bruijn TCP zerocopy takes a uarg reference for every skb, plus one for the tcp_sendmsg_locked datapath temporarily, to avoid reaching refcnt zero as it builds, sends and frees skbs inside its inner loop. UDP and RAW zerocopy do not send inside the inner loop so do not need the ex

Re: [PATCH net-next 0/7] net: add rcu annotations for ifa_list

2019-05-30 Thread David Miller
From: Florian Westphal Date: Wed, 29 May 2019 13:43:25 +0200 > Eric Dumazet reported follwing problem: > > It looks that unless RTNL is held, accessing ifa_list needs proper RCU > protection. indev->ifa_list can be changed under us by another cpu > (which owns RTNL) [..] > > A proper r

Re: [PATCH net-next,v3 0/9] connection tracking support for bridge

2019-05-30 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 29 May 2019 13:25:30 +0200 > This patchset adds native connection tracking support for the bridge. Series applied.

Re: [PATCH] net: ethernet: ti: cpsw_ethtool: fix ethtool ring param set

2019-05-30 Thread David Miller
From: Ivan Khoronzhuk Date: Thu, 30 May 2019 00:47:53 +0300 > Fixes: 37e2d99b59c4765112533a1d38174fea58d28a51 ("ethtool: Ensure new > ring parameters are within bounds during SRINGPARAM") > > Signed-off-by: Ivan Khoronzhuk Please do not chop up Fixes: tags into multiple lines. Please do not p

Re: [PATCH net] net-gro: fix use-after-free read in napi_gro_frags()

2019-05-30 Thread David Miller
From: Eric Dumazet Date: Wed, 29 May 2019 15:36:10 -0700 > If a network driver provides to napi_gro_frags() an > skb with a page fragment of exactly 14 bytes, the call > to gro_pull_from_frag0() will 'consume' the fragment > by calling skb_frag_unref(skb, 0), and the page might > be freed and reu

Re: [PATCH net-next 0/2] r8169: decouple firmware handling code from actual driver code

2019-05-30 Thread David Miller
From: Heiner Kallweit Date: Wed, 29 May 2019 21:13:05 +0200 > These two patches are a step towards eventually factoring out firmware > handling code to a separate source file. Series applied.

Re: [PATCH net-next] r8169: enable WoL speed down on more chip versions

2019-05-30 Thread David Miller
From: Heiner Kallweit Date: Wed, 29 May 2019 20:52:03 +0200 > Call the pll power down function also for chip versions 02..06 and > 13..15. The MAC can't be powered down on these chip versions, but at > least they benefit from the speed-down power-saving if WoL is enabled. > > Signed-off-by: Hein

[PATCH net-next 6/6] seg6: Add support to rearrange SRH for AH ICV calculation

2019-05-30 Thread Tom Herbert
Mutable fields related to segment routing are: destination address, segments left, and modifiable TLVs (those whose high order bit is set). Add support to rearrange a segment routing (type 4) routing header to handle these mutability requirements. This is described in draft-herbert-ipv6-srh-ah-00.

[PATCH net-next 3/6] seg6: Remove HMAC flag and implement seg6_find_hmac_tlv

2019-05-30 Thread Tom Herbert
The HMAC flag is no longer defined in the SRH specification. Remove it and any uses of it. This includes removal of sr_has_hmac. We replace this function with seg6_find_hmac_tlv. That function parses (via __seg6_parse_srh) a TLV list and returns the pointer to an HMAC TLV if one exists. The parsin

Re: [net-next]hinic: add LRO support

2019-05-30 Thread David Miller
All of these module params are a non-starter.

Re: [PATCH net-next] vrf: local route leaking

2019-05-30 Thread David Ahern
On 5/30/19 2:52 PM, George Wilkie wrote: > This doesn't work for me (again, not using namespaces). > For traffic coming in on vrf-b to a destination on 10.200.2.0, > I see ARPs going out for the destination on xvrf2/in on xvrf1, > but nothing replies to it. Is rp_filter set?

[PATCH net-next 1/6] seg6: Fix TLV definitions

2019-05-30 Thread Tom Herbert
The definitions of TLVs in uapi/linux/seg6.h are incorrect and incomplete. Fix this. TLV constants are defined for PAD1, PADN, and HMAC (the three defined in draft-ietf-6man-segment-routing-header-19). The other TLV are unused and not correct so they are removed. Signed-off-by: Tom Herbert ---

[PATCH net-next 5/6] ah6: Be explicit about which routing types are processed.

2019-05-30 Thread Tom Herbert
The current code assumes that all routing headers can be processed as type 0 when rearranging the routing header for AH verification. Change this to be explicit. Type 0 and type 2 are supported and are processed the same way with regards to AH. Also check if rearranging routing header fails. Updat

Re: [PATCH net] net: don't clear sock->sk early to avoid trouble in strparser

2019-05-30 Thread David Miller
From: Jakub Kicinski Date: Wed, 29 May 2019 16:33:23 -0700 > af_inet sets sock->sk to NULL which trips strparser over: ... > To avoid this issue set sock->sk after sk_prot->close. > My grepping and testing did not discover any code which > would depend on the current behaviour. > > Fixes: c4623

[PATCH net-next 4/6] ah6: Create function __zero_out_mutable_opts

2019-05-30 Thread Tom Herbert
This is an adaptation of zero_out_mutable_opts that takes three additional arguments: offset of the TLVs, a mask to locate the mutable bit in the TLV type, and the type value for single byte padding. zero_out_mutable_opts calls the new function and sets the arguments appropriate to Hop-by-Hop and

[PATCH net-next 0/6] seg6: Segment routing fixes

2019-05-30 Thread Tom Herbert
A few bug fixes, code clean up, and minor enhancements to segment routing. Changes include: - Fix SRH TLV definitions - Implement a TLV parsing loop - Eliminate the HMAC flag - Support to rearrange segment routing header for AH ICV calculation Tom Herbert (6): seg6: Fix TLV definiti

[PATCH net-next 2/6] seg6: Implement a TLV parsing loop

2019-05-30 Thread Tom Herbert
Implement a TLV parsing loop for segment routing. The code is uniform with other instances of TLV parsing loops in the stack (e.g. parsing of Hop-by-Hop and Destination Options). seg_validate_srh calls this function. Note, this fixes a bug in the original parsing code that PAD1 was not supported.

Re: [PATCH net] net: correct zerocopy refcnt with udp MSG_MORE

2019-05-30 Thread David Miller
From: Willem de Bruijn Date: Wed, 29 May 2019 15:33:57 -0400 > Fixes: 52900d22288ed ("udp: elide zerocopy operation in hot path") This is not a valid commit ID.

Re: [PATCH v2 net 0/2] Fixes for DSA tagging using 802.1Q

2019-05-30 Thread David Miller
From: Vladimir Oltean Date: Thu, 30 May 2019 00:42:29 +0300 > During the prototyping for the "Decoupling PHYLINK from struct > net_device" patchset, the CPU port of the sja1105 driver was moved to a > different spot. This uncovered an issue in the tag_8021q DSA code, > which used to work by mist

Re: [PATCH net] net: correct zerocopy refcnt with udp MSG_MORE

2019-05-30 Thread Willem de Bruijn
On Thu, May 30, 2019 at 5:44 PM David Miller wrote: > > From: Willem de Bruijn > Date: Wed, 29 May 2019 15:33:57 -0400 > > > Fixes: 52900d22288ed ("udp: elide zerocopy operation in hot path") > > This is not a valid commit ID. Typo in the last character, sorry. Should be 52900d22288e7 ("udp: e

Re: [PATCH net-next] vrf: local route leaking

2019-05-30 Thread George Wilkie
On Wed, May 29, 2019 at 09:29:22PM -0600, David Ahern wrote: > you are correct that use of loopback here for default VRF does not work > -- the lookup code gets confused because it is a forward path (as > opposed to MPLS which is a local input). I found a couple of solutions > that work for default

Re: [PATCH v2 bpf-next] bpf: doc: update answer for 32-bit subregister question

2019-05-30 Thread Song Liu
On Thu, May 30, 2019 at 1:23 PM Jiong Wang wrote: > > There has been quite a few progress around the two steps mentioned in the > answer to the following question: > > Q: BPF 32-bit subregister requirements > > This patch updates the answer to reflect what has been done. > > v2: > - Add missing

Re: [PATCH net-next v2 0/6] add TFO backup key

2019-05-30 Thread David Miller
From: Jason Baron Date: Wed, 29 May 2019 12:33:55 -0400 > Christoph, Igor, and I have worked on an API that facilitates TFO key > rotation. This is a follow up to the series that Christoph previously > posted, with an API that meets both of our use-cases. Here's a > link to the previous work: >

Re: [PATCH net-next v1 3/7] taprio: Add the skeleton to enable hardware offloading

2019-05-30 Thread Jakub Kicinski
On Thu, 30 May 2019 00:21:39 +, Patel, Vedang wrote: > > On May 29, 2019, at 2:06 PM, Jakub Kicinski > > wrote: > > On Wed, 29 May 2019 20:05:16 +, Patel, Vedang wrote: > >> [Sending the email again since the last one was rejected by netdev because > >> it was html.] > >> > >>> On M

[PATCH v2 bpf-next] bpf: doc: update answer for 32-bit subregister question

2019-05-30 Thread Jiong Wang
There has been quite a few progress around the two steps mentioned in the answer to the following question: Q: BPF 32-bit subregister requirements This patch updates the answer to reflect what has been done. v2: - Add missing full stop. (Song Liu) - Minor tweak on one sentence. (Song Liu) v

Re: [PATCH bpf-next] bpf: doc: update answer for 32-bit subregister question

2019-05-30 Thread Jiong Wang
Song Liu writes: > On Thu, May 30, 2019 at 12:46 AM Jiong Wang wrote: >> >> There has been quite a few progress around the two steps mentioned in the >> answer to the following question: >> >> Q: BPF 32-bit subregister requirements >> >> This patch updates the answer to reflect what has been

Re: [PATCH iproute2-next 7/9] Add support for nexthop objects

2019-05-30 Thread Roopa Prabhu
On Wed, May 29, 2019 at 9:04 PM David Ahern wrote: > > From: David Ahern > > Add nexthop subcommand to ip. Implement basic commands for creating, > deleting and dumping nexthop objects. Syntax follows 'nexthop' syntax > from existing 'ip route' command. > > Signed-off-by: David Ahern If you are

Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

2019-05-30 Thread Alexei Starovoitov
On Thu, May 30, 2019 at 11:52 AM David Ahern wrote: > > On 5/30/19 12:27 PM, Alexei Starovoitov wrote: > > On Thu, May 30, 2019 at 11:01 AM David Miller wrote: > >> > >> From: Alexei Starovoitov > >> Date: Thu, 30 May 2019 08:18:10 -0700 > >> > >>> On Thu, May 30, 2019 at 8:16 AM David Ahern wr

Re: [PATCH iproute2-next 8/9] ip route: Add option to use nexthop objects

2019-05-30 Thread Roopa Prabhu
On Wed, May 29, 2019 at 9:04 PM David Ahern wrote: > > From: David Ahern > > Add nhid option for routes to use nexthop objects by id. > > Signed-off-by: David Ahern > --- man page needs an update ? :) > ip/iproute.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > >

Re: [RFC PATCH iproute2-next 1/1] tc: add support for act ctinfo

2019-05-30 Thread Stephen Hemminger
On Thu, 30 May 2019 16:43:20 + Kevin 'ldir' Darbyshire-Bryant wrote: Please don't use HTML encoded mail. I.e not exchange. > + > + if (argc) { > + if (matches(*argv, "dscp") == 0) { > + NEXT_ARG(); > + char *slash; > +

Re: [PATCH iproute2-next 5/9] libnetlink: Add helper to create nexthop dump request

2019-05-30 Thread David Ahern
On 5/30/19 1:56 PM, Roopa Prabhu wrote: >> diff --git a/lib/libnetlink.c b/lib/libnetlink.c >> index eb85bbdf01ee..c1cdda3b8d4e 100644 >> --- a/lib/libnetlink.c >> +++ b/lib/libnetlink.c >> @@ -25,6 +25,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "libnetlink.h" >>

Re: [PATCH V4 net-next 0/6] Peer to Peer One-Step time stamping

2019-05-30 Thread David Miller
From: David Miller Date: Thu, 30 May 2019 11:55:07 -0700 (PDT) > Series applied, thanks Richard. I had to revert, this doesn't build. drivers/ptp/ptp_ines.c: In function ‘ines_txtstamp’: drivers/ptp/ptp_ines.c:674:3: warning: ‘old_skb’ may be used uninitialized in this function [-Wmaybe-uninit

Re: [PATCH iproute2-next 5/9] libnetlink: Add helper to create nexthop dump request

2019-05-30 Thread Roopa Prabhu
On Wed, May 29, 2019 at 9:04 PM David Ahern wrote: > > From: David Ahern > > Add rtnl_nexthopdump_req to initiate a dump request of nexthop objects. > > Signed-off-by: David Ahern > --- > include/libnetlink.h | 4 > lib/libnetlink.c | 27 +++ > 2 files changed,

Re: [PATCH net-next v2 1/3] net: phy: enable interrupts when PHY is attached already

2019-05-30 Thread Andrew Lunn
On Thu, May 30, 2019 at 03:09:15PM +0200, Heiner Kallweit wrote: > This patch is a step towards allowing PHY drivers to handle more > interrupt sources than just link change. E.g. several PHY's have > built-in temperature monitoring and can raise an interrupt if a > temperature threshold is exceede

Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra properties retrieval via get_priv_flags

2019-05-30 Thread David Miller
From: Date: Wed, 29 May 2019 12:49:55 +0300 > @@ -560,6 +564,14 @@ struct ena_admin_set_feature_mtu_desc { > u32 mtu; > }; > > +struct ena_admin_get_extra_properties_strings_desc { > + u32 count; > +}; > + > +struct ena_admin_get_extra_properties_flags_desc { > + u32 flags; > +};

Re: [PATCH V1 net-next 01/11] net: ena: add handling of llq max tx burst size

2019-05-30 Thread David Miller
From: Date: Wed, 29 May 2019 12:49:54 +0300 > static inline int ena_com_write_sq_doorbell(struct ena_com_io_sq *io_sq) > { > u16 tail = io_sq->tail; > + u16 max_entries_in_tx_burst = io_sq->llq_info.max_entries_in_tx_burst; Reverse christmas tree please.

Re: [PATCH net-next 0/8] mlxsw: Hardware monitoring enhancements

2019-05-30 Thread David Miller
From: Ido Schimmel Date: Wed, 29 May 2019 11:47:14 +0300 > From: Ido Schimmel > > This patchset from Vadim provides various hardware monitoring related > improvements for mlxsw. > > Patch #1 allows querying firmware version from the switch driver when > the underlying bus is I2C. This is usefu

Re: [PATCH] net/mlx5e: Allow matching only enc_key_id/enc_dst_port for decapsulation action

2019-05-30 Thread Saeed Mahameed
On Fri, 2019-05-24 at 18:54 +0800, Tonghao Zhang wrote: > On Sun, May 12, 2019 at 5:08 PM Roi Dayan wrote: > > > > > > On 06/05/2019 21:28, xiangxia.m@gmail.com wrote: > > > From: Tonghao Zhang > > > > > > In some case, we don't care the enc_src_ip and enc_dst_ip, and > > > if we don't mat

Re: [PATCH net 0/2] mlxsw: Two small fixes

2019-05-30 Thread David Miller
From: Ido Schimmel Date: Wed, 29 May 2019 10:59:43 +0300 > From: Ido Schimmel > > Patch #1 from Jiri fixes an issue specific to Spectrum-2 where the > insertion of two identical flower filters with different priorities > would trigger a warning. > > Patch #2 from Amit prevents the driver from

Re: [PATCH net-next v3 1/1] net/udp_gso: Allow TX timestamp with UDP GSO

2019-05-30 Thread Willem de Bruijn
> > Asked elsewhere, but best answered here: given that xmit_more delays > > delivery to the NIC until the last segment in a train, is the first > > segment in your opinion still the best to attach the timestamp request > > to? > > > > To reiterate, we do not want to need a follow-up patch to disab

[PATCH net-next] selftests: Add test cases for nexthop objects

2019-05-30 Thread David Ahern
From: David Ahern Add functional test cases for nexthop objects. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib_nexthops.sh | 1026 +++ 1 file changed, 1026 insertions(+) create mode 100755 tools/testing/selftests/net/fib_nexthops.sh diff --git a/tools

Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

2019-05-30 Thread David Ahern
On 5/30/19 12:57 PM, David Miller wrote: > From: David Ahern > Date: Thu, 30 May 2019 12:52:43 -0600 > >> The nexthop code paths are not live yet. More changes are needed before >> that can happen. I have been sending the patches in small, reviewable >> increments to be kind to reviewers than a s

Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

2019-05-30 Thread David Miller
From: David Ahern Date: Thu, 30 May 2019 12:52:43 -0600 > The nexthop code paths are not live yet. More changes are needed before > that can happen. I have been sending the patches in small, reviewable > increments to be kind to reviewers than a single 27 patch set with > everything (the remainin

[PATCH v2 bpf-next 2/2] libbpf: remove qidconf and better support external bpf programs.

2019-05-30 Thread Jonathan Lemon
Use the recent change to XSKMAP bpf_map_lookup_elem() to test if there is a xsk present in the map instead of duplicating the work with qidconf. Fix things so callers using XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD bypass any internal bpf maps, so xsk_socket__{create|delete} works properly. Signed-off-

[PATCH v2 bpf-next 1/2] bpf: Allow bpf_map_lookup_elem() on an xskmap

2019-05-30 Thread Jonathan Lemon
Currently, the AF_XDP code uses a separate map in order to determine if an xsk is bound to a queue. Instead of doing this, have bpf_map_lookup_elem() return the queue_id, as a way of indicating that there is a valid entry at the map index. Rearrange some xdp_sock members to eliminate structure ho

Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

2019-05-30 Thread David Miller
From: Alexei Starovoitov Date: Thu, 30 May 2019 11:27:23 -0700 > On Thu, May 30, 2019 at 11:01 AM David Miller wrote: >> >> From: Alexei Starovoitov >> Date: Thu, 30 May 2019 08:18:10 -0700 >> >> > On Thu, May 30, 2019 at 8:16 AM David Ahern wrote: >> >> >> >> On 5/30/19 9:06 AM, Alexei Starov

Re: [PATCH V4 net-next 0/6] Peer to Peer One-Step time stamping

2019-05-30 Thread David Miller
From: Richard Cochran Date: Tue, 28 May 2019 22:58:01 -0700 > This series adds support for PTP (IEEE 1588) P2P one-step time > stamping along with a driver for a hardware device that supports this. > > If the hardware supports p2p one-step, it subtracts the ingress time > stamp value from the Pd

Re: [PATCH net] r8169: fix MAC address being lost in PCI D3

2019-05-30 Thread David Miller
From: Heiner Kallweit Date: Wed, 29 May 2019 07:44:01 +0200 > (At least) RTL8168e forgets its MAC address in PCI D3. To fix this set > the MAC address when resuming. For resuming from runtime-suspend we > had this in place already, for resuming from S3/S5 it was missing. > > The commit reference

Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

2019-05-30 Thread David Ahern
On 5/30/19 12:27 PM, Alexei Starovoitov wrote: > On Thu, May 30, 2019 at 11:01 AM David Miller wrote: >> >> From: Alexei Starovoitov >> Date: Thu, 30 May 2019 08:18:10 -0700 >> >>> On Thu, May 30, 2019 at 8:16 AM David Ahern wrote: On 5/30/19 9:06 AM, Alexei Starovoitov wrote: > Hu

Re: [PATCH] inet: frags: Remove unnecessary smp_store_release/READ_ONCE

2019-05-30 Thread David Miller
From: Herbert Xu Date: Wed, 29 May 2019 13:40:26 +0800 > The smp_store_release call in fqdir_exit cannot protect the setting > of fqdir->dead as claimed because its memory barrier is only > guaranteed to be one-way and the barrier precedes the setting of > fqdir->dead. > > IOW it doesn't provide

[net-next 04/15] ice: Add support for Forward Error Correction (FEC)

2019-05-30 Thread Jeff Kirsher
From: Paul Greenwalt This patch adds driver support for Forward Error Correction (FEC) and ethtool handlers to set/get FEC params. Signed-off-by: Paul Greenwalt Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/ice/ice_admi

[net-next 14/15] ice: Recognize higher speeds

2019-05-30 Thread Jeff Kirsher
From: Anirudh Venkataramanan In ice_print_link_msg, add cases for 50GB and 100GB speeds. This results in the right speed being reported on load, instead of "Unknownbps". When VF link if forced (in ice_set_pfe_link_forced), report max speed 100GB. Signed-off-by: Anirudh Venkataramanan Tested-by

[net-next 09/15] ice: Use continue instead of an else block

2019-05-30 Thread Jeff Kirsher
From: Anirudh Venkataramanan For style consistency, use continue instead of an else block in ice_pf_dcb_recfg. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 8 +--- 1 file changed, 5 insertion

[net-next 12/15] ice: Update function header

2019-05-30 Thread Jeff Kirsher
From: Anirudh Venkataramanan Add some details to the function header for ice_deinit_hw. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_common.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/n

[net-next 02/15] ice: Introduce ice_init_mac_fltr and move ice_napi_del

2019-05-30 Thread Jeff Kirsher
From: Tony Nguyen Consolidate adding unicast and broadcast MAC filters in a single new function ice_init_mac_fltr. Move ice_napi_del to ice_lib.c Signed-off-by: Tony Nguyen Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/i

[net-next 03/15] ice: Add support for virtchnl_vector_map.[rxq|txq]_map

2019-05-30 Thread Jeff Kirsher
From: Anirudh Venkataramanan Add support for virtchnl_vector_map.[rxq|txq]_map to use bitmap to associate indicated queues with the specified vector. This support is needed since the Windows AVF driver calls VIRTCHNL_OP_CONFIG_IRQ_MAP for each vector and used the bitmap to indicate the associated

[net-next 11/15] ice: Move define for ICE_AQC_DRIVER_UNLOADING

2019-05-30 Thread Jeff Kirsher
From: Anirudh Venkataramanan The define describing the bits for the struct field should be below the field itself. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 2 +- 1 file changed, 1 insertio

[net-next 15/15] ice: Trivial cosmetic changes

2019-05-30 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch mostly capitalizes abbreviations in code comments. Fixed some typos and removed some unnecessary newlines as well. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/ice/ice_adminq_cmd.

[net-next 05/15] ice: Use right type for ice_cfg_vsi_lan return

2019-05-30 Thread Jeff Kirsher
From: Akeem G Abodunrin ice_cfg_vsi_lan returns a value of type enum ice_status. So use a local of the same type to capture the return value. Signed-off-by: Akeem G Abodunrin Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/

[net-next 13/15] ice: Use a different ICE_DBG bit for firmware log messages

2019-05-30 Thread Jeff Kirsher
From: Jacob Keller Replace the use of the ICE_DBG_AQ_MSG bit when dumping firmware logging messages with a separate distinct type ICE_DBG_FW_LOG. This is useful so that developers may enable ICE_DBG_FW_LOG and get firmware logging messages, without also dumping AdminQ messages at the same time.

[net-next 08/15] ice: Change minimum descriptor count value for Tx/Rx rings

2019-05-30 Thread Jeff Kirsher
From: Preethi Banala Change minimum number of descriptor count from 32 to 64. This is to have a feature parity with previous Intel NIC drivers. Signed-off-by: Preethi Banala Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/i

[net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-05-30

2019-05-30 Thread Jeff Kirsher
This series contains updates to ice driver only. Brett continues his work with interrupt handling by fixing an issue where were writing to the incorrect register to disable all VF interrupts. Tony consolidates the unicast and multicast MAC filters into a single new function. Anirudh adds support

[net-next 07/15] ice: Add switch rules to handle LLDP packets

2019-05-30 Thread Jeff Kirsher
From: Dave Ertman Add call to configure dropping egress LLDP packets in ice_vsi_setup and remove the rule in ice_vsi_release. Add calls to add/remove rule to route LLDP packets to default VSI when FW LLDP engine is disabled/enabled and remove rule if applied during ice_vsi_release. In the funct

[net-next 06/15] ice: Cleanup ice_update_link_info

2019-05-30 Thread Jeff Kirsher
From: Bruce Allan Do not allocate memory for the Get PHY Abilities command data buffer when it is not necessary, change one local variable to another to reduce the number of de-references, reduce the scope of some local variables, and reorder the code and change exit points to get rid of an unnec

[net-next 10/15] ice: Align to updated AQ command formats

2019-05-30 Thread Jeff Kirsher
From: Anirudh Venkataramanan The current specification has updates to the command formats for manage MAC opcodes (opcodes 0x0107 and 0x0108) and get PHY caps (opcode 0x0600). Update the code to reflect this. Signed-off-by: Anirudh Venkataramanan Tested-by: Andrew Bowers Signed-off-by: Jeff Kir

[net-next 01/15] ice: Use GLINT_DYN_CTL to disable VF's interrupts

2019-05-30 Thread Jeff Kirsher
From: Brett Creeley Currently in ice_free_vf_res() we are writing to the VFINT_DYN_CTLN register in the PF's function space to disable all VF's interrupts. This is incorrect because this register is only for use in the VF's function space. This becomes obvious when seeing that the valid indices u

Re: [pull request][net 0/6] Mellanox, mlx5 fixes 2019-05-28

2019-05-30 Thread David Miller
From: Saeed Mahameed Date: Wed, 29 May 2019 02:07:57 + > This series introduces some fixes to mlx5 driver. > > Please pull and let me know if there is any problem. Pulled. > For -stable v4.13: > ('net/mlx5: Allocate root ns memory using kzalloc to match kfree') > > For -stable v4.16: > ('

Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

2019-05-30 Thread Alexei Starovoitov
On Thu, May 30, 2019 at 11:01 AM David Miller wrote: > > From: Alexei Starovoitov > Date: Thu, 30 May 2019 08:18:10 -0700 > > > On Thu, May 30, 2019 at 8:16 AM David Ahern wrote: > >> > >> On 5/30/19 9:06 AM, Alexei Starovoitov wrote: > >> > Huge number of core changes and zero tests. > >> > >>

Re: [PATCH bpf-next] bpf: doc: update answer for 32-bit subregister question

2019-05-30 Thread Song Liu
On Thu, May 30, 2019 at 12:46 AM Jiong Wang wrote: > > There has been quite a few progress around the two steps mentioned in the > answer to the following question: > > Q: BPF 32-bit subregister requirements > > This patch updates the answer to reflect what has been done. > > v1: > - Integrated

Re: [PATCH PATCH v4 0/2] XDP generic fixes

2019-05-30 Thread David Miller
From: Stephen Hemminger Date: Tue, 28 May 2019 11:47:29 -0700 > This set of patches came about while investigating XDP > generic on Azure. The split brain nature of the accelerated > networking exposed issues with the stack device model. Series applied.

Re: [PATCH net-next v2] udp: Avoid post-GRO UDP checksum recalculation

2019-05-30 Thread David Miller
From: Sean Tranchetti Date: Tue, 28 May 2019 12:22:54 -0600 > Currently, when resegmenting an unexpected UDP GRO packet, the full UDP > checksum will be calculated for every new SKB created by skb_segment() > because the netdev features passed in by udp_rcv_segment() lack any > information about

Re: [PATCH net v2 1/3] net/sched: act_csum: pull all VLAN headers before checksumming

2019-05-30 Thread Stephen Hemminger
On Thu, 30 May 2019 20:03:41 +0200 Davide Caratti wrote: > > +static inline int tc_skb_pull_vlans(struct sk_buff *skb, > + unsigned int *hdr_count, > + __be16 *proto) > +{ > + if (skb_vlan_tag_present(skb)) > + *pro

  1   2   >