Re: [RFC bpf-next 7/7] samples/bpf: add busy-poll support to xdpsock sample

2019-05-26 Thread Magnus Karlsson
On Fri, May 24, 2019 at 4:59 AM Ye Xiaolong wrote: > > Hi, Magnus > > On 05/02, Magnus Karlsson wrote: > >This patch adds busy-poll support to the xdpsock sample > >application. It is enabled by the "-b" or the "--busy-poll" command > >line options. > > > >Signed-off-by: Magnus Karlsson > >--- >

netdev_alloc_skb is failing for 16k length

2019-05-26 Thread Arun Kumar Neelakantam
Hi team, we are using "skb = netdev_alloc_skb(NULL, len);" which is getting failed sometimes for len = 16k. I suspect mostly system memory got fragmented and hence atomic memory allocation for 16k is failing, can you please suggest best way to handle this failure case. Thanks Arun N

Re: [PATCH v2 1/4] net: phy: dp83867: fix speed 10 in sgmii mode

2019-05-26 Thread Heiner Kallweit
On 27.05.2019 08:16, Max Uvarov wrote: > For support 10Mps sped in SGMII mode DP83867_10M_SGMII_RATE_ADAPT bit > of DP83867_10M_SGMII_CFG register has to be cleared by software. > That does not affect speeds 100 and 1000 so can be done on init. > > Signed-off-by: Max Uvarov > Cc: Heiner Kallweit

Re: [PATCH v2 2/4] net: phy: dp83867: increase SGMII autoneg timer duration

2019-05-26 Thread Heiner Kallweit
On 27.05.2019 08:16, Max Uvarov wrote: > After reset SGMII Autoneg timer is set to 2us (bits 6 and 5 are 01). > That us not enough to finalize autonegatiation on some devices. > Increase this timer duration to maximum supported 16ms. > > Signed-off-by: Max Uvarov > Cc: Heiner Kallweit > --- > d

[PATCH v2 0/4] net: phy: dp83867: add some fixes

2019-05-26 Thread Max Uvarov
v2: fix minor comments by Heiner Kallweit and Florian Fainelli. Max Uvarov (4): net: phy: dp83867: fix speed 10 in sgmii mode net: phy: dp83867: increase SGMII autoneg timer duration net: phy: dp83867: do not call config_init twice net: phy: dp83867: Set up RGMII TX delay drivers/net/p

[PATCH v2 3/4] net: phy: dp83867: do not call config_init twice

2019-05-26 Thread Max Uvarov
Phy state machine calls _config_init just after reset. Signed-off-by: Max Uvarov --- drivers/net/phy/dp83867.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 5fafcc091525..a1c0b2128de2 100644 --- a/drivers/net/phy/d

[PATCH v2 1/4] net: phy: dp83867: fix speed 10 in sgmii mode

2019-05-26 Thread Max Uvarov
For support 10Mps sped in SGMII mode DP83867_10M_SGMII_RATE_ADAPT bit of DP83867_10M_SGMII_CFG register has to be cleared by software. That does not affect speeds 100 and 1000 so can be done on init. Signed-off-by: Max Uvarov Cc: Heiner Kallweit --- drivers/net/phy/dp83867.c | 20 ++

[PATCH v2 4/4] net: phy: dp83867: Set up RGMII TX delay

2019-05-26 Thread Max Uvarov
PHY_INTERFACE_MODE_RGMII_RXID is less then TXID so code to set tx delay is never called. Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy") Signed-off-by: Max Uvarov Cc: Florian Fainelli --- drivers/net/phy/dp83867.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --g

[PATCH v2 2/4] net: phy: dp83867: increase SGMII autoneg timer duration

2019-05-26 Thread Max Uvarov
After reset SGMII Autoneg timer is set to 2us (bits 6 and 5 are 01). That us not enough to finalize autonegatiation on some devices. Increase this timer duration to maximum supported 16ms. Signed-off-by: Max Uvarov Cc: Heiner Kallweit --- drivers/net/phy/dp83867.c | 10 ++ 1 file change

Re: [PATCH bpf-next 3/3] veth: Support bulk XDP_TX

2019-05-26 Thread Toshiaki Makita
On 2019/05/24 18:53, Jesper Dangaard Brouer wrote: > On Thu, 23 May 2019 22:51:34 +0900 > Toshiaki Makita wrote: > >> On 19/05/23 (木) 22:29:27, Jesper Dangaard Brouer wrote: >>> On Thu, 23 May 2019 20:35:50 +0900 >>> Toshiaki Makita wrote: >>> On 2019/05/23 20:25, Toke Høiland-Jørgensen

Re: [PATCH net-next] r8169: remove support for RTL_GIGA_MAC_VER_01

2019-05-26 Thread David Miller
From: Heiner Kallweit Date: Sat, 25 May 2019 21:14:39 +0200 > RTL_GIGA_MAC_VER_01 is RTL8169, the ancestor of the chip family. > It didn't have an internal PHY and I've never seen it in the wild. > What isn't there doesn't need to be maintained, so let's remove > support for it. > > Signed-off-b

Re: [PATCH net-next] r8169: improve RTL8168d PHY initialization

2019-05-26 Thread David Miller
From: Heiner Kallweit Date: Sat, 25 May 2019 20:57:42 +0200 > Certain parts of the PHY initialization are the same for sub versions > 1 and 2 of RTL8168d. So let's factor this out to simplify the code. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next 0/3] r8169: small improvements

2019-05-26 Thread David Miller
From: Heiner Kallweit Date: Sat, 25 May 2019 20:42:30 +0200 > Series with small improvements. Series applied, thanks.

Re: [PATCH net 1/4] net: aquantia: tx clean budget logic error

2019-05-26 Thread David Miller
From: Igor Russkikh Date: Sat, 25 May 2019 09:57:59 + > In case no other traffic happening on the ring, full tx cleanup > may not be completed. That may cause socket buffer to overflow > and tx traffic to stuck until next activity on the ring happens. > > This is due to logic error in budget

Re: [PATCH net-next] selftest: Fixes for icmp_redirect test

2019-05-26 Thread David Miller
From: David Ahern Date: Fri, 24 May 2019 16:37:07 -0700 > From: David Ahern > > I was really surprised that the IPv6 mtu exception followed by redirect > test was passing as nothing about the code suggests it should. The problem > is actually with the logic in the test script. > > Fix the test

Re: [PATCH net-next] net: phy: bcm87xx: improve bcm87xx_config_init and feature detection

2019-05-26 Thread David Miller
From: Heiner Kallweit Date: Fri, 24 May 2019 22:24:19 +0200 > PHY drivers don't have to and shouldn't fiddle with phylib internals. > Most of the code in bcm87xx_config_init() can be removed because > phylib takes care. > > In addition I replaced usage of PHY_10GBIT_FEC_FEATURES with an > implem

Re: [PATCH net 0/4] net/tls: two fixes for rx_list pre-handling

2019-05-26 Thread David Miller
From: Jakub Kicinski Date: Fri, 24 May 2019 10:34:29 -0700 > tls_sw_recvmsg() had been modified to cater better to async decrypt. > Partially read records now live on the rx_list. Data is copied from > this list before the old do {} while loop, and the not included > correctly in deciding whether

Re: [PATCH v3 2/2] net: core: support XDP generic on stacked devices.

2019-05-26 Thread David Miller
From: Stephen Hemminger Date: Thu, 23 May 2019 10:54:29 -0700 > @@ -4858,6 +4841,17 @@ static int __netif_receive_skb_core(struct sk_buff > *skb, bool pfmemalloc, > > __this_cpu_inc(softnet_data.processed); > > + if (static_branch_unlikely(&generic_xdp_needed_key)) { > +

[PATCH] enetc: fix le32/le16 degrading to integer warnings

2019-05-26 Thread Y.b. Lu
Fix blow sparse warning introduced by a previous patch. - restricted __le32 degrades to integer - restricted __le16 degrades to integer Fixes: d39823121911 ("enetc: add hardware timestamping support") Signed-off-by: Yangbo Lu --- drivers/net/ethernet/freescale/enetc/enetc.c | 16 +---

[PATCH net-next] team: add ethtool get_link_ksettings

2019-05-26 Thread Hangbin Liu
Like bond, add ethtool get_link_ksettings to show the total speed. Signed-off-by: Hangbin Liu --- drivers/net/team/team.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 2106045b3e16..5e892ee4c006 100644 --- a

RE: [EXT] Re: [PATCH net,stable 1/1] net: fec: add defer probe for of_get_mac_address

2019-05-26 Thread Andy Duan
From: David Miller Sent: Saturday, May 25, 2019 4:12 AM > From: Andy Duan > Date: Thu, 23 May 2019 01:55:23 + > > > @@ -3146,7 +3150,10 @@ static int fec_enet_init(struct net_device *ndev) > > memset(cbd_base, 0, bd_size); > > > > /* Get the Ethernet address */ > > - fec_get_

Re: [PATCH net] net: dsa: mv88e6xxx: Set correct interface mode for CPU/DSA ports

2019-05-26 Thread Greg Ungerer
Hi Andrew, Thanks for the quick response. On 24/5/19 11:44 pm, Andrew Lunn wrote: On Fri, May 24, 2019 at 11:25:03AM +1000, Greg Ungerer wrote: Hi Andrew, I have a problem with a Marvell 6390 switch that I have bisected back to commit 7cbbee050c95, "[PATCH] net: dsa: mv88e6xxx: Set correct i

Re: [PATCH net-next 00/11] inet: frags: avoid possible races at netns dismantle

2019-05-26 Thread David Miller
From: Eric Dumazet Date: Fri, 24 May 2019 09:03:29 -0700 > This patch series fixes a race happening on netns dismantle with > frag queues. While rhashtable_free_and_destroy() is running, > concurrent timers might run inet_frag_kill() and attempt > rhashtable_remove_fast() calls. This is not allow

[PATCH net-next 2/4] ipv6: Update references from RFC2460 to RFC8200

2019-05-26 Thread Tom Herbert
IPv6 is now a full Internet standard in RFC8200! Update references in the code to reflect that. Signed-off-by: Tom Herbert --- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 2 +- drivers/net/usb/smsc95xx.c | 2 +- net/ipv6/exthdrs.c

[PATCH net-next 3/4] ipv6: Reference RFC8504 for limits in padding and EH

2019-05-26 Thread Tom Herbert
RFC8504 specifies requirements for applying limits to Hop-by-Hop and Destination Options extension headers and options (including padding). Reference this RFC appropriately. Signed-off-by: Tom Herbert --- include/net/ipv6.h | 9 + net/ipv6/exthdrs.c | 3 ++- 2 files changed, 7 insertions

[PATCH net-next 0/4] ipv6: Update RFC references and implement ICMP errors for limits

2019-05-26 Thread Tom Herbert
This patch set contains: - Resolve comment for ipv6_skip_exthdr that the function is non conformant with RFC2460. I requested and received an on the interpretation of the requirements on 6man list. - Update references, in comments, of RFC2460 to be RFC8200. RFC8200 (aka IPv6) is now a full I

[PATCH net-next 4/4] ipv6: Send ICMP errors for exceeding extension header limits

2019-05-26 Thread Tom Herbert
Define constants and add support to send ICMPv6 Parameter Problem errors as defined in draft-ietf-6man-icmp-limits-02. ICMPV6_TOOBIG_OPTION is sent if a packet exceeding the padding limit is received (more than seven consecutive bytes of padding), ICMPV6_TOOMANY_OPTIONS is sent if a packet is rece

Re: Having TIPC compiled in causes strange networking failures

2019-05-26 Thread Cong Wang
On Sat, May 25, 2019 at 5:27 PM wrote: > > Hi! I build my own kernel, and I set TIPC as enabled long ago thinking > it was something many applications depend on. After I upgraded to 5.1.5, > I noticed lots of errors in my systemd log and that Firefox couldnt > start any of its subprocesses: > > NE

[PATCH net-next 1/4] ipv6: Resolve comment that EH processing order is being violated

2019-05-26 Thread Tom Herbert
ipv6_skip_exthdr is preambled with a comment indicating that the function necessarily violates the extension header processing order requirements of RFC2460 in order to fulfill requirements of ICMPv6 processing. This patch revises the comment to indicate that the function is conformant with RFC8200

[net-next:master 120/123] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:5755:1: warning: no return statement in function returning non-void

2019-05-26 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: ddf6ddb057f22445837df4d01bd966995d4426f7 commit: d93ed94fbeaf3bf5ed16b57574dbb48ab7f7e41a [120/123] net: hns3: add aRFS support for PF config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux

Re: [PATCH net 0/3] dpaa2-eth: Fix smatch warnings

2019-05-26 Thread David Miller
From: Ioana Radulescu Date: Fri, 24 May 2019 18:15:14 +0300 > Fix a couple of warnings reported by smatch. Series applied.

Re: IP-Aliasing for IPv6? (actually "labels")

2019-05-26 Thread M. Buecher
On 2019-05-20 22:53, Michal Kubecek wrote: On Mon, May 20, 2019 at 10:23:03PM +0200, M. Buecher wrote: Used feature is the label option of `ip`, which works for IPv4, but not with IPv6. The only reason for having these labels is to allow old tools like ifconfig to partially work even if th

bpf program loader doesn't honor CAP_NET_ADMIN

2019-05-26 Thread Andreas Steinmetz
Quite simple "program": start as root configure rlimit_memlock drop root but keep CAP_NET_ADMIN and CAP_NET_RAW create network interface configure network interface create CLSACT qdisc for interface reconfigure eBPF program for interface call bpf(BPF_PROGLOAD, ...) with program type BPF_PROG_TYPE_

Fw: [Bug 203703] New: 5.1 regression makes r8169 Ethernet connection inoperable if fq_codel qdisc is used

2019-05-26 Thread Stephen Hemminger
Begin forwarded message: Date: Sat, 25 May 2019 04:55:19 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 203703] New: 5.1 regression makes r8169 Ethernet connection inoperable if fq_codel qdisc is used https://bugzilla.kernel.org/show_bug.cgi?id=2

Re: [RFC net-next 1/1] net: sched: protect against loops in TC filter hooks

2019-05-26 Thread Jamal Hadi Salim
On 2019-05-24 2:32 p.m., Daniel Borkmann wrote: On 05/24/2019 06:05 PM, John Hurley wrote: TC hooks allow the application of filters and actions to packets at both ingress and egress of the network stack. It is possible, with poor configuration, that this can produce loops whereby an ingress hoo

[PATCH] [PATCH bpf] style fix in while(!feof()) loop

2019-05-26 Thread Chang-Hsien Tsai
use fgets() as the while loop condition. Signed-off-by: Chang-Hsien Tsai --- tools/bpf/bpftool/xlated_dumper.c | 4 +--- tools/testing/selftests/bpf/trace_helpers.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/bpf/bpftool/xlated_dumper.c b/tools/bpf/b