[PATCH net-next v2 0/3] mlxsw: Add support for devlink info command

2019-04-07 Thread Ido Schimmel
Shalom says: Expose the following ASIC information via devlink info command: - Driver name - Hardware revision - Firmware PSID - Running firmware version Standard output example: $ devlink dev info pci/:03:00.0 pci/:03:00.0: versions: fixed: hw.revision A

Hello Beautiful

2019-04-07 Thread Jack
Hi Dear, my name is Jack and i am seeking for a relationship in which i will feel loved after a series of failed relationships. I am hoping that you would be interested and we could possibly get to know each other more if you do not mind. I am open to answering questions from you as i think my

Re: [RFC net-next 2/2] net: sched: fq_pie: Flow Queue PIE AQM

2019-04-07 Thread Dave Taht
On Mon, Apr 8, 2019 at 7:37 AM Dave Taht wrote: > > On Mon, Apr 8, 2019 at 7:31 AM Gautam Ramakrishnan > wrote: > > > > I was trying to refactor the code and I ran into some issues. > > 1. I moved some of the parameters such as flows_cnt into a new struct > > called fq_pie_params, instead of kee

Re: [RFC net-next 2/2] net: sched: fq_pie: Flow Queue PIE AQM

2019-04-07 Thread Dave Taht
On Mon, Apr 8, 2019 at 7:31 AM Gautam Ramakrishnan wrote: > > I was trying to refactor the code and I ran into some issues. > 1. I moved some of the parameters such as flows_cnt into a new struct > called fq_pie_params, instead of keeping them in fq_pie_sched_data. > Should I move those parameters

Re: [RFC net-next 2/2] net: sched: fq_pie: Flow Queue PIE AQM

2019-04-07 Thread Gautam Ramakrishnan
I was trying to refactor the code and I ran into some issues. 1. I moved some of the parameters such as flows_cnt into a new struct called fq_pie_params, instead of keeping them in fq_pie_sched_data. Should I move those parameters back into fq_pie_sched_data? 2. fq_codel maintains the backlog varia

PROGRAMME DE RECRUTEMENT ACF CANADA 2019

2019-04-07 Thread ACTION CONTRE LA FAIM INTERNATIONAL
ACTION AGAINST HUNGER CANADA(ACF-États-Unis-CANADA) pour le développement international Siège Social: 304 Rue Saint Antoine E, Montréal, QC H2Y 1A3, Canada ÉMAIL: actioncontrelaf...@post.com PROGRAMME DE RECRUTEMENT ACF CANADA 2019 *** Action

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-07 Thread Richard Cochran
On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all Famous last words! > supported PHY's, at least for the ones with basic features sets

Re: [PATCH net-next] net: sched: flower: insert filter to ht before offloading it to hw

2019-04-07 Thread David Miller
From: Vlad Buslov Date: Fri, 5 Apr 2019 20:56:26 +0300 > John reports: > > Recent refactoring of fl_change aims to use the classifier spinlock to > avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer() > function was moved to before the lock is taken. This can create problems > f

Re: [PATCH 1/4] rhashtable: use cmpxchg() in nested_table_alloc()

2019-04-07 Thread Herbert Xu
On Tue, Apr 02, 2019 at 10:07:45AM +1100, NeilBrown wrote: > nested_table_alloc() relies on the fact that there is > at most one spinlock allocated for every slot in the top > level nested table, so it is not possible for two threads > to try to allocate the same table at the same time. > > This a

Re: [PATCH net] selftests: add a tc matchall test case

2019-04-07 Thread David Miller
From: Nicolas Dichtel Date: Fri, 5 Apr 2019 14:20:24 +0200 > This is a follow up of the commit 0db6f8befc32 ("net/sched: fix ->get > helper of the matchall cls"). > > To test it: > $ cd tools/testing/selftests/tc-testing > $ ln -s ../plugin-lib/nsPlugin.py plugins/20-nsPlugin.py > $ ./tdc.py -n

[PATCH] ethtool: Add bash-completion script

2019-04-07 Thread Kevin Locke
To aid users constructing a valid ethtool invocation, create a [bash-completion] script to provide [programmable completion] of ethtool arguments. It supports all current command options. The script is placed in shell-completion/bash and installed to completionsdir from pkg-config for bash-comple

Re: [PATCH net-next] net: phy: replace genphy_10g_driver with genphy_c45_driver

2019-04-07 Thread Andrew Lunn
On Sun, Apr 07, 2019 at 01:55:01PM +0200, Heiner Kallweit wrote: > Recently a number of generic functions for Clause 45 PHY's has been > added. So let's replace the old very limited genphy_10g_driver with a > genphy_c45_driver. This driver isn't limited to 10G, however it's worth > to be noted that

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-07 Thread Andrew Lunn
On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FE

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-07 Thread richard . purdie
Hi, I've been chasing down why a python test from the python3 testsuite started failing and it seems to point to this kernel change in the networking stack. In kernels beyond commit 4f693b55c3d2d2239b8a0094b518a1e533cf75d5 the test hangs about 90% of the time (I've reproduced with 5.1-rc3, 5.0.7,

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-07 Thread Heiner Kallweit
On 07.04.2019 22:31, Florian Fainelli wrote: > > > On 4/7/2019 2:57 AM, Heiner Kallweit wrote: >> Recently genphy_read_abilities() has been added that dynamically detects >> clause 22 PHY abilities. I *think* this detection should work with all >> supported PHY's, at least for the ones with basic

Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-07 Thread Florian Fainelli
On 4/7/2019 2:57 AM, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FEATURES and PHY_GBI

Re: [PATCH bpf-next v4 01/16] bpf: implement lookup-free direct value access for maps

2019-04-07 Thread Daniel Borkmann
On 04/07/2019 04:57 AM, Alexei Starovoitov wrote: [...] > I don't get this shadow vs normal .data idea. > The more we talk the more I'm convinced that this is not a good api. > Say in the future we indeed have these shadow + normal .data > then just use the same insn->imm field to refer to shadow p

Re: [PATCH net-next] qmi_wwan: Add quirk for Quectel dynamic config

2019-04-07 Thread Kristian Evensen
Hi, On Sun, Apr 7, 2019 at 5:27 PM Bjørn Mork wrote: > I guess this has to go to (at least some of) the stable trees > eventually, but assume you directed it to net-next for more thorough > testing first? Yes, that was my thought exactly. Since this is more an improvement than a fix, I sent it t

Re: [PATCH net] netdevice: Fix promiscuity and allmulti negative overflow

2019-04-07 Thread Stephen Hemminger
On Thu, 4 Apr 2019 20:45:18 +0800 Hangbin Liu wrote: > Similarly to dad9b335c694 ("netdevice: Fix promiscuity and allmulti > overflow"), we should not decrease promiscuity if it is already 0. This should never happen. If it is a kernel bug and should be reported like refcnt_t overflow.

Re: [PATCH net-next] qmi_wwan: Add quirk for Quectel dynamic config

2019-04-07 Thread Bjørn Mork
Kristian Evensen writes: > Most, if not all, Quectel devices use dynamic interface numbers, and > users are able to change the USB configuration at will. Matching on for > example interface number is therefore not possible. > > Instead, the QMI device can be identified by looking at the interface

[PATCH net-next] qmi_wwan: Add quirk for Quectel dynamic config

2019-04-07 Thread Kristian Evensen
Most, if not all, Quectel devices use dynamic interface numbers, and users are able to change the USB configuration at will. Matching on for example interface number is therefore not possible. Instead, the QMI device can be identified by looking at the interface class, subclass and protocol (all 0

Re: NAT performance regression caused by vlan GRO support

2019-04-07 Thread Rafał Miłecki
Now I have some questions regarding possible optimizations. Note I'm too familiar with the net subsystem so maybe I got wrong ideas. On 07.04.2019 13:53, Rafał Miłecki wrote: On 04.04.2019 14:57, Rafał Miłecki wrote: Long story short, starting with the commit 66e5133f19e9 ("vlan: Add GRO suppor

[PATCH net-next] net: phy: replace genphy_10g_driver with genphy_c45_driver

2019-04-07 Thread Heiner Kallweit
Recently a number of generic functions for Clause 45 PHY's has been added. So let's replace the old very limited genphy_10g_driver with a genphy_c45_driver. This driver isn't limited to 10G, however it's worth to be noted that Clause 45 doesn't cover 1000Base-T. For using 1000Base-T with a Clause 4

Re: NAT performance regression caused by vlan GRO support

2019-04-07 Thread Rafał Miłecki
On 04.04.2019 14:57, Rafał Miłecki wrote: Long story short, starting with the commit 66e5133f19e9 ("vlan: Add GRO support for non hardware accelerated vlan") - which first hit kernel 4.2 - NAT performance of my router dropped by 30% - 40%. I'll try to provide some summary for this issue. I'll f

[PATCH net-next] net: phy: remove unnecessary callback settings in C45 drivers

2019-04-07 Thread Heiner Kallweit
genphy_c45_aneg_done() is used by phylib as fallback for c45 PHY's if callback aneg_done isn't defined. So we don't have to set this explicitly. Same for genphy_c45_pma_read_abilities(). Signed-off-by: Heiner Kallweit --- drivers/net/phy/aquantia_main.c | 14 -- drivers/net/phy/marve

[PATCH net-next] net: phy: switch drivers to use dynamic feature detection

2019-04-07 Thread Heiner Kallweit
Recently genphy_read_abilities() has been added that dynamically detects clause 22 PHY abilities. I *think* this detection should work with all supported PHY's, at least for the ones with basic features sets, i.e. PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these features expl

[PATCH rdma-next v1 10/17] RDMA/nldev: Allow counter auto mode configration through RDMA netlink

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Provide an option to enable/disable per-port counter auto mode through RDMA netlink. Limit it to users with ADMIN capability only. Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 78 +++

[PATCH rdma-next v1 17/17] RDMA/nldev: Allow get default counter statistics through RDMA netlink

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang This patch adds the ability to return the hwstats of per-port default counters (which can also be queried through sysfs nodes). Signed-off-by: Mark Zhang Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 101 +++- 1 file changed,

[PATCH rdma-next v1 16/17] RDMA/nldev: Allow get counter mode through RDMA netlink

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Provide an option to get current counter mode through RDMA netlink. Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/counters.c | 13 + drivers/infiniband/core/nldev.c| 78 +- 2

[PATCH rdma-next v1 15/17] RDMA/nldev: Allow counter manual mode configration through RDMA netlink

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Provide an option to allow users to manually bind a qp with a counter through RDMA netlink. Limit it to users with ADMIN capability only. Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 111 +++

[PATCH rdma-next v1 12/17] IB/mlx5: Add counter_alloc_stats() and counter_update_stats() support

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Add support for ib callback counter_alloc_stats() and counter_update_stats(). Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a

[PATCH rdma-next v1 13/17] RDMA/core: Get sum value of all counters when perform a sysfs stat read

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Since a QP can only be bound to one counter, then if it is bound to a separate counter, for backward compatibility purpose, the statistic value must be: * stat of default counter + stat of all running allocated counters + stat of all deallocated counters (history stats) Signed-o

[PATCH mlx5-next v1 01/17] net/mlx5: Add rts2rts_qp_counters_set_id field in hca cap

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Add rts2rts_qp_counters_set_id field in hca cap so that RTS2RTS qp modification can be used to change the counter of a QP. Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- include/linux/mlx5/mlx5_ifc.h | 4 +++- 1 file changed, 3 inserti

[PATCH rdma-next v1 06/17] RDMA/counter: Add "auto" configuration mode support

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang In auto mode all QPs belong to one category are bind automatically to a single counter set. Currently only "qp type" is supported. In this mode the qp counter is set in RST2INIT modification, and when a qp is destroyed the counter is unbound. Signed-off-by: Mark Zhang Reviewed

[PATCH rdma-next v1 09/17] IB/mlx5: Support statistic q counter configuration

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Add support for ib callbacks counter_bind_qp() and counter_unbind_qp(). Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 55 +++ 1 file changed, 55 insertions(+) diff --git

[PATCH rdma-next v1 05/17] RDMA/counter: Add set/clear per-port auto mode support

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Add an API to support set/clear per-port auto mode. Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/Makefile | 2 +- drivers/infiniband/core/counters.c | 77 ++ drivers/infiniband/c

[PATCH rdma-next v1 11/17] RDMA/netlink: Implement counter dumpit calback

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang This patch adds the ability to return all available counters together with their properties and hwstats. Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/counters.c | 28 + drivers/infiniband/core/device.c

[PATCH rdma-next v1 14/17] RDMA/counter: Allow manual mode configuration support

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang In manual mode a QP is bound to a counter manually. If counter is not specified then a new one will be allocated. Manually mode is enabled when user binds a QP, and disabled when the last manually bound QP is unbound. When auto-mode is turned off and there are counters left, manu

[PATCH mlx5-next v1 07/17] IB/mlx5: Support set qp counter

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Support bind a qp with counter. If counter is null then bind the qp to the default counter. Different QP state has different operation: - RESET: Set the counter field so that it will take effective during RST2INIT change; - RTS: Issue an RTS2RTS change to update the QP counter;

[PATCH rdma-next v1 00/17] Statistics counter support

2019-04-07 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v0 -> v1: * Changed wording of counter comment * Removed unneeded assignments * Added extra patch to present global counters * I didn't change QP type from int to be enum ib_qp_type, because it caused to cyclic dependency between ib_verbs.h and rdma_co

[PATCH rdma-next v1 02/17] RDMA/restrack: Introduce statistic counter

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Introduce statistic counter as a new resource. It allows a user to monitor specific objects (e.g., QPs) by binding to a counter. In some cases a user counter resource is created with task other then "current", because its creation is done as part of rdmatool call. Signed-off-by

[PATCH rdma-next v1 04/17] RDMA/restrack: Make is_visible_in_pid_ns() as an API

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Remove is_visible_in_pid_ns() from nldev.c and make it as a restrack API, so that it can be taken advantage by other parts like counter. Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c| 15 ++-

[PATCH rdma-next v1 03/17] RDMA/restrack: Add an API to attach a task to a resource

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Add rdma_restrack_attach_task() which is able to attach a task other then "current" to a resource. Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/restrack.c | 14 ++ drivers/infiniband/core/restrack.

[PATCH rdma-next v1 08/17] IB/mlx5: Add counter set id as a parameter for mlx5_ib_query_q_counters()

2019-04-07 Thread Leon Romanovsky
From: Mark Zhang Add counter set id as a parameter so that this API can be used for querying any q counter. Signed-off-by: Mark Zhang Reviewed-by: Majd Dibbiny Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-