syzbot reports:
BUG: using __this_cpu_read() in preemptible code:
caller is dev_recursion_level include/linux/netdevice.h:3052 [inline]
__this_cpu_preempt_check+0x246/0x270 lib/smp_processor_id.c:47
dev_recursion_level include/linux/netdevice.h:3052 [inline]
ip6_skb_dst_mtu include/net/ip6_route
Hi Dan,
On Wed, 2019-04-03 at 08:34 +0300, Dan Carpenter wrote:
> NEXTHDR_MAX is 255. What happens here is that we take a u8 value
> "hdr->nexthdr" from the network and then look it up in
> lowpan_nexthdr_nhcs[]. The problem is that if hdr->nexthdr is 0xff
> then
> we read one element beyond the
On 02.04.2019 23:57, Bjorn Helgaas wrote:
> [+cc Rajat]
>
> On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote:
>> On 02.04.2019 22:16, Florian Fainelli wrote:
>>> On 4/2/19 12:55 PM, Heiner Kallweit wrote:
There are numerous reports about different problems caused by ASPM
i
NEXTHDR_MAX is 255. What happens here is that we take a u8 value
"hdr->nexthdr" from the network and then look it up in
lowpan_nexthdr_nhcs[]. The problem is that if hdr->nexthdr is 0xff then
we read one element beyond the end of the array so the array needs to
be one element larger.
Fixes: 92aa
On Tue, Apr 02, 2019 at 02:11:53PM -0700, David Ahern wrote:
> From: David Ahern
>
> Second set of three with the end goal of enabling IPv6 gateways with IPv4
> routes.
I am still not completely convinced on the new "*nhc" in patch 2 without
seeing a patch showing why nh_sel is not enough.
Howev
This is to inform you that Turkey Financier here in Turkey offers loan to
anyone who might be in need of a loan for any financial concern. Should you be
interested in applying for a business or personal loan, you are required to
send an enquiry to us for further proceedings. We offer loan servic
Rename extension header files that are specific to IPv6.
net/ipv6/exthdrs.c -> net/ipv6/exthdrs6.c
net/ipv6/exthdrs_offload.c -> net/ipv6/exthdrs6_offload.c
net/ipv6/exthdrs_options.c -> net/ipv6/exthdrs6_options.c
---
net/ipv6/Makefile | 6 +-
net/ipv6/exthdrs.c | 830 --
Extension headers are the mechanism of extensibility for the IPv6
protocol, however to date they have only seen limited deployment.
The reasons for that are because intermediate devices don't handle
them well, and there haven't really be any useful extension headers
defined. In particular, Destinat
Move generic functions in exthdrs.c to exthdrs_core.c so that exthdrs.c
only contains functions that are specific to IPv6 processing, and
exthdrs_core.c contains functions that are generic.
---
net/ipv6/exthdrs.c | 138
net/ipv6/exthdrs_core.c
Create exthdrs_options.c to hold code related to specific Hop-by-Hop
and Destination extension header options. Move related functions in
exthdrs.c to the new file.
---
include/net/ipv6.h | 15
net/ipv6/Makefile | 2 +-
net/ipv6/exthdrs.c | 204 -
Since commit bc7d811ace4a ("netfilter: nf_ct_h323: Convert
CHECK_BOUND macro to function"), NAT traversal for H.323
doesn't work, failing to parse H323-UserInformation.
nf_h323_error_boundary() compares contents of the bitstring,
not the addresses, preventing valid H.323 packets from being
conntrac
On Fri, 22 Mar 2019 08:56:40 -0700, Eric Dumazet wrote:
> Often times, recvmsg() system calls and BH handling for a particular
> TCP socket are done on different cpus.
>
> This means the incoming skb had to be allocated on a cpu,
> but freed on another.
>
> This incurs a high spinlock contention
The thunderx driver forbids to load an eBPF program if the MTU is higher
than 1500 bytes, but this can be circumvented by first loading the eBPF,
and then raising the MTU.
XDP assumes that SKBs are linear and fit in a single page, this can lead
to undefined behaviours.
Fix this by limiting the MTU
From: Tariq Toukan
Soften the memory barrier call of mb() by a sufficient wmb() in the
consumer index update of the event queues.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
From: Tonghao Zhang
If we try to offload decapsulation actions to VFs hw, we get the log [1].
It's not friendly, because the kind of net device is null, and we don't
know what '0' means.
[1] "mlx5_core :05:01.2 vf_0: decapsulation offload is not supported for
net device (0)"
Signed-off-by
From: Eli Britstein
Upon redirection to an uplink VLAN device, emulate vlan push actions
according to the VLAN properties of the VLAN device and redirect to
the uplink.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/e
From: Tariq Toukan
Expose a new helper that wraps the logic for setting the
netdevice's MTU boundaries.
Use it for the different components (Eth, rep, IPoIB).
Set the netdevice min MTU to ETH_MIN_MTU, and the max according
to both the FW capability and the kernel definition.
Signed-off-by: Tari
From: Eli Britstein
If we have a match for the same value of a rewrite field, there is no
point for the rewrite. In order to save rewrite actions, and avoid
entirely rewrite actions (if all rewrites are the same), ignore such
rewrite fields.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
From: Tonghao Zhang
This patch deletes unnecessary setting of the esw_attr->parse_attr
to parse_attr in parse_tc_fdb_actions() because it is already done
by the mlx5e_flow_esw_attr_init() function.
Signed-off-by: Tonghao Zhang
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/
From: Tariq Toukan
The LRO WQE size is a constant, obsolete the parameter field
that holds it.
Signed-off-by: Tariq Toukan
Reviewed-by: Maxim Mikityanskiy
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 -
drivers/net/ethernet/mellanox/mlx5/core/en_mai
From: Eli Britstein
Changing the prio field of the VLAN is not supported. With
commit 37410902874c ("net/mlx5e: Support VLAN modify action") zero
value indicated "no-change". Allow the vid rewrite if the prio match
is the same as the prio set value.
Fixes: 37410902874c ("net/mlx5e: Support VLAN
From: Eli Britstein
Rewrite of the packet in the VLAN offset may corrupt the packet if it's
not VLAN tagged. Deny the rewrite in this case.
Fixes: 37410902874c ("net/mlx5e: Support VLAN modify action")
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
driv
From: Eli Britstein
Offload TC rule on a VLAN device by matching the VLAN properties
of the VLAN device and emulating vlan pop actions.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/en_rep.c | 3 +-
.../net/etherne
From: Tonghao Zhang
* Now the encapsulation is not supported for mlx5 VFs. When we try to
offload that action, the -EINVAL is returned, but not -EOPNOTSUPP.
This patch changes the returned value and ignore to confuse user.
The command is shown as below [1].
* When max modify header action is zer
From: Tonghao Zhang
This patch is a little improvement. Simplify the parse_tc_fdb_actions().
Signed-off-by: Tonghao Zhang
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
From: Aya Levin
Handle event of power state change in the PCIE slot. When the event
occurs, check if query power state and PCI power fields is supported. If
so, read these fields from MPEIN (management PCIE info) register and
issue a corresponding message.
Signed-off-by: Aya Levin
Signed-off-by
From: Eli Britstein
The headers criteria and value pointers may be either of the inner
packet, if a tunnel exists, or of the outer. Simplify the code by using
helper functions to retrieve them.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
.../net/ethe
From: Max Gurtovoy
Delete mutex_init call of a lock that's initialized in inner function.
Fixes: eca8cc389535 ("net/mlx5: E-Switch, Refactor offloads flow steering
init/cleanup")
Signed-off-by: Max Gurtovoy
Reviewed-by: Roi Dayan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellan
Hi Dave,
This series adds misc updates to mlx5 driver.
For more information please see tag log below.
Please pull and let me know if there is any problem.
Please note that the series starts with a merge of mlx5-next branch,
to resolve and avoid dependency with rdma tree.
Note: when merged with
On 04/02/2019 06:49 PM, andrii.nakry...@gmail.com wrote:
> From: Andrii Nakryiko
>
> This patch adds new config option to trigger generation of BTF type
> information from DWARF debuginfo for vmlinux and kernel modules through
> pahole, which in turn relies on libbpf for btf_dedup() algorithm.
>
Recent changes to TC flower remove the requirement for rtnl lock when
accessing and modifying filters. Refcounts now ensure access and deletion
do not happen concurrently. However, the reoffload function which cycles
through all filters and replays them to registered hw drivers is not
protected.
U
Way back in 3c9c36bcedd426f2be2826da43e5163de61735f7 the
ndo_fcoe_get_wwn pointer was switched from depending on CONFIG_FCOE to
CONFIG_LIBFCOE in order to allow building FCoE support into the bnx2x
driver and used by bnx2fc without including the generic software fcoe
module.
But, FCoE is generally
[+cc Rajat]
On Tue, Apr 02, 2019 at 10:41:20PM +0200, Heiner Kallweit wrote:
> On 02.04.2019 22:16, Florian Fainelli wrote:
> > On 4/2/19 12:55 PM, Heiner Kallweit wrote:
> >> There are numerous reports about different problems caused by ASPM
> >> incompatibilities between certain network chip ver
On 02.04.2019 23:08, Rajat Jain wrote:
> On Tue, Apr 2, 2019 at 1:41 PM Heiner Kallweit wrote:
>>
>> On 02.04.2019 22:16, Florian Fainelli wrote:
>>> On 4/2/19 12:55 PM, Heiner Kallweit wrote:
There are numerous reports about different problems caused by ASPM
incompatibilities between ce
On 04/02/2019 07:08 PM, Stanislav Fomichev wrote:
> This series contains small fixes to make bpf selftests compile cleanly
> with clangs. All of them are not real problems, but it's nice to have
> an option to use clang for the tests themselves.
>
> Stanislav Fomichev (4):
> selftests: bpf: test
From: David Ahern
Similar to ipv6, move addition of nexthop attributes to dump
message into helpers that are called for both single path and
multipath routes. Align the new helpers to the IPv6 variant
which most notably means computing the flags argument based on
settings in nh_flags.
The RTA_FL
From: David Ahern
Update fib_table_lookup tracepoint to take a fib_nh_common struct and
dump the v6 gateway address if the nexthop uses it.
Over the years saddr has not proven useful and the output of the
tracepoint produces very long lines. Since saddr is not part of
fib_nh_common, drop it. If
From: David Ahern
Export fib_nexthop_info and fib_add_nexthop for use by IPv6 code.
Remove rt6_nexthop_info and rt6_add_nexthop in favor of the IPv4
versions. Update fib_nexthop_info for IPv6 linkdown check and
RTA_GATEWAY for AF_INET6.
Signed-off-by: David Ahern
Acked-by: Martin KaFai Lau
---
From: David Ahern
Most of the ipv4 code only needs data from fib_nh_common. Add
fib_nh_common selection to fib_result and update users to use it.
Right now, fib_nh_common in fib_result will point to a fib_nh struct
that is embedded within a fib_info:
fib_info --> fib_nh
From: David Ahern
With the exception of the nexthop weight, the nexthop attributes used by
fib_nexthop_info and fib_add_nexthop come from the fib_nh_common struct.
Update both to use it and change fib_nexthop_info to check the family
as needed.
nexthop weight comes from the common struct for exi
From: David Ahern
Second set of three with the end goal of enabling IPv6 gateways with IPv4
routes.
This set moves:
- the ipv4 tracepoint to take a fib_nh_common and updates it to handle
a v6 gateway.
- consolidates route notifications to use the same fill functions
for both ipv4 and ipv6
v
On Tue, Apr 2, 2019 at 1:41 PM Heiner Kallweit wrote:
>
> On 02.04.2019 22:16, Florian Fainelli wrote:
> > On 4/2/19 12:55 PM, Heiner Kallweit wrote:
> >> There are numerous reports about different problems caused by ASPM
> >> incompatibilities between certain network chip versions and board
> >>
On 2019/04/03 5:23, David Miller wrote:
> From: Tetsuo Handa
> Date: Mon, 1 Apr 2019 23:19:22 +0900
>
>> syzbot is reporting uninitialized value at rds_connect [1] and
>> rds_bind [2]. This is because syzbot is passing ulen == 0 whereas
>> these functions expects that it is safe to access sockad
On 04/02, Petar Penkov wrote:
> On Mon, Apr 1, 2019 at 1:57 PM Stanislav Fomichev wrote:
> >
> > Short doc on what BPF flow dissector should expect in the input
> > __sk_buff and flow_keys.
> >
> > Signed-off-by: Stanislav Fomichev
> > ---
> > .../networking/bpf_flow_dissector.txt | 115
On Mon, Apr 1, 2019 at 1:57 PM Stanislav Fomichev wrote:
>
> Short doc on what BPF flow dissector should expect in the input
> __sk_buff and flow_keys.
>
> Signed-off-by: Stanislav Fomichev
> ---
> .../networking/bpf_flow_dissector.txt | 115 ++
> 1 file changed, 115 inse
On Tue, Apr 2, 2019 at 1:18 PM Willem de Bruijn
wrote:
>
> On Mon, Apr 1, 2019 at 4:57 PM Stanislav Fomichev wrote:
> >
> > This patch series fixes the existing BPF flow dissector API to
> > support calling BPF progs from the eth_get_headlen context (the support
> > itself will be added in bpf-ne
On 02.04.2019 22:16, Florian Fainelli wrote:
> On 4/2/19 12:55 PM, Heiner Kallweit wrote:
>> There are numerous reports about different problems caused by ASPM
>> incompatibilities between certain network chip versions and board
>> chipsets. On the other hand on (especially mobile) systems where AS
On Tue, Apr 02, 2019 at 08:43:30PM +0200, Heiner Kallweit wrote:
> The original patch didn't consider the case that autoneg process
> finishes successfully but both link partners have no mode in common.
> In this case there's no link, nevertheless we may be interested in
> what the link partner adv
From: Jeff Kirsher
Date: Mon, 1 Apr 2019 11:44:05 -0700
> This series contains two fixes for XDP in the i40e driver.
>
> Björn provides both fixes, first moving a function out of the header and
> into the main.c file. Second fixes a regression introduced in an
> earlier patch that removed umem
From: Michael Zhivich
Date: Mon, 1 Apr 2019 13:14:28 -0400
> When building C++ userspace code that includes ethtool.h
> with "-Werror -Wall", g++ complains about signed-unsigned comparison in
> ethtool_validate_speed() due to definition of SPEED_UNKNOWN as -1.
>
> Change definition of SPEED_UNKN
From: Tetsuo Handa
Date: Mon, 1 Apr 2019 23:19:22 +0900
> syzbot is reporting uninitialized value at rds_connect [1] and
> rds_bind [2]. This is because syzbot is passing ulen == 0 whereas
> these functions expects that it is safe to access sockaddr->family field
> in order to determine minimal
Proper support of indirect stack access with variable offset in
unprivileged mode (!root) requires corresponding support in Spectre
masking for stack ALU in retrieve_ptr_limit().
There are no use-case for variable offset in unprivileged mode though so
make verifier reject such accesses for simplic
From: Vlad Buslov
Date: Mon, 1 Apr 2019 14:16:59 +0300
> Action tunnel_key doesn't have a metadata/tunnel for release(decap) action.
> Drivers do not dereference entry->tunnel pointer for that action type, so
> this behavior doesn't result in a crash at the moment. However, this needs
> to be co
check_stack_access() that prints verbose log is used in
adjust_ptr_min_max_vals() that prints its own verbose log and now they
stick together, e.g.:
variable stack access var_off=(0xfff0; 0x4) off=-16
size=1R2 stack pointer arithmetic goes out of range, prohibited for
!root
Add
Test that verifier rejects indirect stack access with variable offset in
unprivileged mode and accepts same code in privileged mode.
Since pointer arithmetics is prohibited in unprivileged mode verifier
should reject the program even before it gets to helper call that uses
variable offset, at the
Test that verifier rejects indirect access to uninitialized stack with
variable offset.
Example of output:
# ./test_verifier
...
#859/p indirect variable-offset stack access, uninitialized OK
Signed-off-by: Andrey Ignatov
---
.../testing/selftests/bpf/verifier/var_off.c | 27
It's hard to guarantee that whole memory is marked as initialized on
helper return if uninitialized stack is accessed with variable offset
since specific bounds are unknown to verifier. This may cause
uninitialized stack leaking.
Reject such an access in check_stack_boundary to prevent possible
le
This patch set is a follow-up for discussion [1].
It fixes variable offset stack access handling for raw and unprivileged
mode, rejecting both of them.
Patch 1 handles raw (uninitialized) mode.
Patch 2 adds test for raw mode.
Patch 3 handles unprivileged mode.
Patch 4 adds test for unprivileged m
From: Sheena Mira-ato
Date: Mon, 1 Apr 2019 13:04:42 +1300
> The device type for ip6 tunnels is set to
> ARPHRD_TUNNEL6. However, the ip4ip6_err function
> is expecting the device type of the tunnel to be
> ARPHRD_TUNNEL. Since the device types do not
> match, the function exits and the ICMP er
On Mon, Apr 1, 2019 at 4:57 PM Stanislav Fomichev wrote:
>
> This patch series fixes the existing BPF flow dissector API to
> support calling BPF progs from the eth_get_headlen context (the support
> itself will be added in bpf-next tree).
>
> The summary of the changes:
> * fix VLAN handling in
On 4/2/19 12:55 PM, Heiner Kallweit wrote:
> There are numerous reports about different problems caused by ASPM
> incompatibilities between certain network chip versions and board
> chipsets. On the other hand on (especially mobile) systems where ASPM
> works properly it can significantly contribut
From: Heiner Kallweit
Date: Sun, 31 Mar 2019 19:51:45 +0200
> This series improves genphy_c45_read_lpa:
> - Use clause 45 standard register / bit to detect link partner autoneg
> capability.
> - Consider that lpa register values may be invalid if "autoneg complete"
> bit isn't set.
Series ap
On 02/04/2019 18:35, Mike Manning wrote:
> In vlan bridge binding mode, the link state is no longer transferred
> from the lower device. Instead it is set by the bridge module according
> to the state of bridge ports that are members of the vlan.
>
> Signed-off-by: Mike Manning
> ---
> net/8021q
On 02/04/2019 22:20, Nikolay Aleksandrov wrote:
> On 02/04/2019 18:35, Mike Manning wrote:
>> In the case of vlan filtering on bridges, the bridge may also have the
>> corresponding vlan devices as upper devices. Currently the link state
>> of vlan devices is transferred from the lower device. So t
On 02/04/2019 18:35, Mike Manning wrote:
> If vlan bridge binding is enabled, then the link state of a vlan device
> that is an upper device of the bridge should track the state of bridge
> ports that are members of that vlan. So if a bridge port becomes or
> stops being a member of a vlan, then up
From: Heiner Kallweit
Date: Wed, 27 Mar 2019 21:57:10 +0100
> Similar to genphy_c45_pma_read_abilities() add a function to dynamically
> detect the abilities of a Clause 22 PHY. This is mainly copied from
> genphy_config_init(). Main benefit is that PHY drivers no longer have
> to specify whether
Schöner Tag,
Mein Name ist Herr Jucai Li, Chief Executive Officer der Bank of China
Ich suche einen Geschäftspartner, der mit mir in einem Joint Venture
zusammenarbeiten wird.
Kontaktieren Sie mich in meiner privaten E-Mail für weitere Details.
E-Mail (jucailil...@gmail.com)
Ich warte darauf, v
There are numerous reports about different problems caused by ASPM
incompatibilities between certain network chip versions and board
chipsets. On the other hand on (especially mobile) systems where ASPM
works properly it can significantly contribute to power-saving and
increased battery runtime.
On
I found one issue with dsa and the last patch. Will send v4.
On Fri, 2019-03-29 at 15:37 -0700, Saeed Mahameed wrote:
> Hi,
>
> This series includes some misc shared code updates for mlx5-next
> branch.
>
> From Maxim, Remove un-used macros and spinlock from mlx5 code.
>
> From Aya, Expose Management PCIE info register layout and add rate
> limit
> print
On Sat, 2019-03-30 at 08:08 +, Leon Romanovsky wrote:
> On Fri, Mar 29, 2019 at 03:37:58PM -0700, Saeed Mahameed wrote:
> > From: Huy Nguyen
> >
> > Detach mlx5_core mdev messages from pci device mdev->pdev messages
> > and
> > provide a better report/debug of different mlx5 device types.
> >
On 02/04/2019 18:35, Mike Manning wrote:
> In the case of vlan filtering on bridges, the bridge may also have the
> corresponding vlan devices as upper devices. A vlan bridge binding mode
> is added to allow the link state of the vlan device to track only the
> state of the subset of bridge ports t
On 02/04/2019 18:35, Mike Manning wrote:
> In the case of vlan filtering on bridges, the bridge may also have the
> corresponding vlan devices as upper devices. Currently the link state
> of vlan devices is transferred from the lower device. So this is up if
> the bridge is in admin up state and th
In vlan bridge binding mode, the link state is no longer transferred
from the lower device. Instead it is set by the bridge module according
to the state of bridge ports that are members of the vlan.
Signed-off-by: Mike Manning
---
net/8021q/vlan.c | 18 ++
net/8021q/vlan_dev
The original patch didn't consider the case that autoneg process
finishes successfully but both link partners have no mode in common.
In this case there's no link, nevertheless we may be interested in
what the link partner advertised.
Like phydev->link we set phydev->autoneg_complete in
genphy_upd
From: Ben Greear
I found this useful while debugging an issue setting igb to
fixed rates.
Signed-off-by: Ben Greear
---
drivers/net/ethernet/intel/igb/igb_main.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/d
On Tue, Apr 02, 2019 at 04:13:58PM +0200, Daniel Borkmann wrote:
> On 04/02/2019 04:08 AM, Alexei Starovoitov wrote:
> > On 4/1/19 9:35 AM, Daniel Borkmann wrote:
> >> On 04/01/2019 04:17 PM, Daniel Borkmann wrote:
> >>> On 03/30/2019 01:16 AM, Alexei Starovoitov wrote:
> Add 3 basic tests tha
On 4/2/19 1:15 AM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Pass the switch ID down the to devlink through devlink_port_attrs_set()
> so it can be used by devlink_compat_switch_id_get(). Leave
> ndo_get_port_parent_id implementation only for legacy.
>
> Signed-off-by: Jiri Pirko
Reviewed-by: F
If vlan bridge binding is enabled, then the link state of a vlan device
that is an upper device of the bridge should track the state of bridge
ports that are members of that vlan. So if a bridge port becomes or
stops being a member of a vlan, then update the link state of the
vlan device if necessa
From: Dan Carpenter
Date: Tue, 2 Apr 2019 09:53:14 +0300
> We free "ct_info->ct" and then use it on the next line when we pass it
> to nf_ct_destroy_timeout(). This patch swaps the order to avoid the use
> after free.
>
> Fixes: 06bd2bdf19d2 ("openvswitch: Add timeout support to ct action")
> S
In the case of vlan filtering on bridges, the bridge may also have the
corresponding vlan devices as upper devices. A vlan bridge binding mode
is added to allow the link state of the vlan device to track only the
state of the subset of bridge ports that are also members of the vlan,
rather than tha
From: Martin Lau
Date: Tue, 2 Apr 2019 17:06:08 +
> Please update the commit message accordingly to avoid future confusion in
> case others may want to re-add it.
+1
From:
Date: Tue, 2 Apr 2019 09:49:50 -0700
> From: Andrii Nakryiko
>
> This patch adds new config option to trigger generation of BTF type
> information from DWARF debuginfo for vmlinux and kernel modules through
> pahole, which in turn relies on libbpf for btf_dedup() algorithm.
>
> The inten
On 31.03.2019 17:05, Heiner Kallweit wrote:
> On 31.03.2019 16:58, Andrew Lunn wrote:
>>> - In auto-neg case, skip populating lp_advertising if we
>>> don't have a link. This avoids quite some unnecessary
>>> MDIO reads in case of phylib polling mode.
>>
>> Hi Heiner
>>
>> Could it be that we d
On Tue, Apr 02, 2019 at 04:37:19PM +0200, Daniel Borkmann wrote:
> On 04/02/2019 01:58 PM, Paul Chaignon wrote:
> > Three checks for verifier bugs were introduced in commit f4d7e40 ("bpf:
> > introduce function calls (verification)"). The bugs were reported as
> > incorrect programs instead of ker
Gautam Ramakrishnan writes:
> Hello, thanks for the feedback
>
> On Tue, Apr 2, 2019 at 4:19 PM Toke Høiland-Jørgensen wrote:
>>
>> Some suggestions below to make fq_pie and fq_codel more similar (ref. my
>> previous email).
>>
>> Also, a few unrelated nits.
>>
>> > From: Mohit P. Tahiliani
>>
Marc Kleine-Budde writes:
> On 3/27/19 6:14 PM, Cong Wang wrote:
>> On Wed, Mar 27, 2019 at 9:56 AM Marc Kleine-Budde
>> wrote:
>>>
>>> There is networking hardware that isn't based on Ethernet for layers 1 and
>>> 2.
>>>
>>> For example CAN.
>>>
>>> CAN is a multi-master serial bus standard f
On 4/2/19 11:10 AM, Martin Lau wrote:
>> @@ -182,11 +183,10 @@ struct fib_result_nl {
>> int err;
>> };
>>
>> -#ifdef CONFIG_IP_ROUTE_MULTIPATH
>> -#define FIB_RES_NH(res) ((res).fi->fib_nh[(res).nh_sel])
> If nh_sel is still needed, I am likely missing something to
On Mon, Apr 01, 2019 at 08:02:34PM -0700, David Ahern wrote:
> From: David Ahern
>
> Export fib_nexthop_info and fib_add_nexthop for use by IPv6 code.
> Remove rt6_nexthop_info and rt6_add_nexthop in favor of the IPv4
> versions. Update fib_nexthop_info for IPv6 linkdown check and
> RTA_GATEWAY f
On Mon, Apr 01, 2019 at 08:02:33PM -0700, David Ahern wrote:
> From: David Ahern
>
> With the exception of the nexthop weight, the nexthop attributes used by
> fib_nexthop_info and fib_add_nexthop come from the fib_nh_common struct.
> Update both to use it and change fib_nexthop_info to check the
On Mon, Apr 01, 2019 at 08:02:32PM -0700, David Ahern wrote:
> From: David Ahern
>
> Similar to ipv6, move addition of nexthop attributes to dump
> message into helpers that are called for both single path and
> multipath routes. Align the new helpers to the IPv6 variant
> which most notably mean
On Tue, 2 Apr 2019 11:14:59 +0300, Leon Romanovsky wrote:
> On Mon, Apr 01, 2019 at 11:32:21AM -0700, Jakub Kicinski wrote:
> > On Mon, 1 Apr 2019 09:28:16 +0300, Leon Romanovsky wrote:
> > > On Sun, Mar 31, 2019 at 02:06:33PM -0700, Jakub Kicinski wrote:
> > > > On Sun, 31 Mar 2019 19:44:42 +0
On Mon, Apr 01, 2019 at 08:02:31PM -0700, David Ahern wrote:
> From: David Ahern
>
> Most of the ipv4 code only needs data from fib_nh_common. Add
> fib_nh_common selection to fib_result and update users to use it.
>
> Right now, fib_nh_common in fib_result will point to a nexthop within
> a fib
This makes sure we don't put headers as input files when doing
compilation, because clang complains about the following:
clang-9: error: cannot specify -o when generating multiple output files
../lib.mk:152: recipe for target
'xxx/tools/testing/selftests/bpf/test_verifier' failed
make: *** [xxx/t
flow_dissector_load.c:55:19: warning: format string is not a string literal
(potentially insecure)
[-Wformat-security]
error(1, errno, command);
^~~
flow_dissector_load.c:55:19: note: treat the string as an argument to avoid this
Use standard C99 %zu for sizeof, not GCC's custom %Zu:
bpf_obj_id.c:76:48: warning: invalid conversion specifier 'Z'
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/bpf/prog_tests/bpf_obj_id.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing
verifier/ctx_skb.c:708:11: warning: initializer overrides prior initialization
of this subobject [-Winitializer-overrides]
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
^~
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/bpf/v
This series contains small fixes to make bpf selftests compile cleanly
with clangs. All of them are not real problems, but it's nice to have
an option to use clang for the tests themselves.
Stanislav Fomichev (4):
selftests: bpf: tests.h should depend on .c files, not the output
selftests: bpf
On Tue, Apr 02, 2019 at 10:03:34AM -0600, David Ahern wrote:
> On 4/2/19 10:01 AM, Martin Lau wrote:
> > On Mon, Apr 01, 2019 at 08:02:30PM -0700, David Ahern wrote:
> >> From: David Ahern
> >>
> >> Update fib_table_lookup tracepoint to take a fib_nh_common struct and
> >> dump the v6 gateway addr
On Mon, Apr 1, 2019 at 11:53 PM Dan Carpenter wrote:
>
> We free "ct_info->ct" and then use it on the next line when we pass it
> to nf_ct_destroy_timeout(). This patch swaps the order to avoid the use
> after free.
>
> Fixes: 06bd2bdf19d2 ("openvswitch: Add timeout support to ct action")
> Signe
1 - 100 of 137 matches
Mail list logo
