Re: [PATCH v2 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-03-31 Thread Leon Romanovsky
On Tue, Mar 26, 2019 at 02:18:29PM -0500, Steve Wise wrote: > Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma > device to a netdev interface. > > EG: > > rdma link add rxe_eth0 type rxe netdev eth0 > rdma link delete rxe_eth0 > > Signed-off-by: Steve Wise > --- > rdma/li

Re: [PATCH v2 iproute2-next 3/4] rdma: add 'link add/delete' commands

2019-03-31 Thread Leon Romanovsky
On Tue, Mar 26, 2019 at 02:18:29PM -0500, Steve Wise wrote: > Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma > device to a netdev interface. > > EG: > > rdma link add rxe_eth0 type rxe netdev eth0 > rdma link delete rxe_eth0 > > Signed-off-by: Steve Wise > --- > rdma/li

Re: [PATCH v2 iproute2-next 1/4] Add .mailmap file

2019-03-31 Thread Leon Romanovsky
On Tue, Mar 26, 2019 at 02:18:27PM -0500, Steve Wise wrote: > .mailmap allows tracking multiple email addresses to the proper user name. > > Signed-off-by: Steve Wise > --- > .mailmap | 8 > 1 file changed, 8 insertions(+) > create mode 100644 .mailmap > Thanks, Reviewed-by: Leon Roman

Re: [PATCH v2 iproute2-next 2/4] rdma: add helper rd_sendrecv_msg()

2019-03-31 Thread Leon Romanovsky
On Tue, Mar 26, 2019 at 02:18:28PM -0500, Steve Wise wrote: > This function sends the constructed netlink message and then > receives the response. > > Change rd_recv_msg() to display any error messages. > > Change 'rdma dev set' to use rd_sendrecv_msg(). > > Signed-off-by: Steve Wise > --- > rdm

Re: [PATCH rdma-next 0/8] User space steering

2019-03-31 Thread Leon Romanovsky
On Sun, Mar 31, 2019 at 02:06:33PM -0700, Jakub Kicinski wrote: > On Sun, 31 Mar 2019 19:44:42 +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > From Ariel, > > > > This series of patches adds user space managed steering infrastructure > > to the mlx5_ib driver. > > > > User space ma

samples: bpf: spintest_kern.c sample broken due to missing symbol?

2019-03-31 Thread Daniel T. Lee
spintest sample isn't running currently since there is no such symbol called 'spin_lock'. At "spintest_kern.c", it has 'kprobe/spin_lock' and 'kprobe/spin_unlock' and some others kernel symbols like below. SEC("kprobe/spin_unlock")PROG(p1) SEC("kprobe/spin_lock")PROG(p2) SEC("kprobe/mutex_spin_on

Re: [PATCH v2 iproute2-next 2/4] rdma: add helper rd_sendrecv_msg()

2019-03-31 Thread David Ahern
On 3/26/19 1:18 PM, Steve Wise wrote: > This function sends the constructed netlink message and then > receives the response. > > Change rd_recv_msg() to display any error messages. > > Change 'rdma dev set' to use rd_sendrecv_msg(). > > Signed-off-by: Steve Wise > --- > rdma/dev.c | 2 +- >

Re: [PATCH net,v2] vrf: check accept_source_route on the original netdevice

2019-03-31 Thread David Ahern
On 3/31/19 2:57 PM, David Miller wrote: > From: Stephen Suryaputra > Date: Wed, 27 Mar 2019 15:58:48 -0400 > >> Configuration check to accept source route IP options should be made on >> the incoming netdevice when the skb->dev is an l3mdev master. The route >> lookup for the source route next ho

[PATCH] ip6_tunnel: Match to ARPHRD_TUNNEL6 for dev type

2019-03-31 Thread Sheena Mira-ato
The device type for ip6 tunnels is set to ARPHRD_TUNNEL6. However, the ip4ip6_err function is expecting the device type of the tunnel to be ARPHRD_TUNNEL. Since the device types do not match, the function exits and the ICMP error packet is not sent to the originating host. Note that the device typ

Re: [PATCH net,v2] vrf: check accept_source_route on the original netdevice

2019-03-31 Thread David Ahern
On 3/27/19 1:58 PM, Stephen Suryaputra wrote: > Configuration check to accept source route IP options should be made on > the incoming netdevice when the skb->dev is an l3mdev master. The route > lookup for the source route next hop also needs the incoming netdev. > > Signed-off-by: Stephen Suryap

Re: [PATCH rdma-next 0/8] User space steering

2019-03-31 Thread Jakub Kicinski
On Sun, 31 Mar 2019 19:44:42 +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > From Ariel, > > This series of patches adds user space managed steering infrastructure > to the mlx5_ib driver. > > User space managed steering requires the means to access a dedicated > memory space that is

Re: [PATCH net-next 0/2] sctp: fully support memory accounting

2019-03-31 Thread David Miller
From: Marcelo Ricardo Leitner Date: Sun, 31 Mar 2019 17:10:48 -0300 > On Sun, Mar 31, 2019 at 04:53:45PM +0800, Xin Long wrote: >> sctp memory accounting is added in this patchset by using >> these kernel APIs on send side: > > Please give me till tomorrow to review this one. No problem.

Re: [PATCH net,v2] vrf: check accept_source_route on the original netdevice

2019-03-31 Thread David Miller
From: Stephen Suryaputra Date: Wed, 27 Mar 2019 15:58:48 -0400 > Configuration check to accept source route IP options should be made on > the incoming netdevice when the skb->dev is an l3mdev master. The route > lookup for the source route next hop also needs the incoming netdev. > > Signed-off

Re: [patch net-next 00/12] net: expose switch ID via devlink

2019-03-31 Thread Jakub Kicinski
On Sun, 31 Mar 2019 10:50:17 +0200, Jiri Pirko wrote: > I understand that from the functionality point of view, you are correct. > But for the visibility and better understanding about what's the > topology, I think it would be fine to expose this. Anyway, I'll remove > the patch to expose the devl

Re: [PATCH net-next 0/2] sctp: fully support memory accounting

2019-03-31 Thread Marcelo Ricardo Leitner
On Sun, Mar 31, 2019 at 04:53:45PM +0800, Xin Long wrote: > sctp memory accounting is added in this patchset by using > these kernel APIs on send side: Please give me till tomorrow to review this one. Thanks, Marcelo

Re: [PATCH net-next 0/2] sctp: fully support memory accounting

2019-03-31 Thread Matteo Croce
On Sun, Mar 31, 2019 at 10:53 AM Xin Long wrote: > > sctp memory accounting is added in this patchset by using > these kernel APIs on send side: > > - sk_mem_charge() > - sk_mem_uncharge() > - sk_wmem_schedule() > - sk_under_memory_pressure() > - sk_mem_reclaim() > > and these on receive

Re: [PATCH net-next] r8169: disable tx interrupt coalescing on RTL8168

2019-03-31 Thread Heiner Kallweit
On 31.03.2019 20:23, David Miller wrote: > From: Heiner Kallweit > Date: Sun, 31 Mar 2019 20:16:51 +0200 > >> Can we defer applying this patch until net has been merged? > Thanks > Yes, but please mention such dependencies next time. > OK

Re: [PATCH net-next] r8169: disable tx interrupt coalescing on RTL8168

2019-03-31 Thread David Miller
From: Heiner Kallweit Date: Sun, 31 Mar 2019 20:16:51 +0200 > Can we defer applying this patch until net has been merged? Yes, but please mention such dependencies next time.

Re: [PATCH net-next] r8169: disable tx interrupt coalescing on RTL8168

2019-03-31 Thread Heiner Kallweit
On 31.03.2019 20:13, David Miller wrote: > From: Heiner Kallweit > Date: Sun, 31 Mar 2019 15:43:59 +0200 > >> @@ -5456,12 +5448,6 @@ static void rtl_hw_start_8168(struct rtl8169_private >> *tp) >> { >> RTL_W8(tp, MaxTxPacketSize, TxPacketMax); >> >> -tp->cp_cmd &= ~INTT_MASK; >> -

Re: [PATCH net-next] r8169: disable tx interrupt coalescing on RTL8168

2019-03-31 Thread David Miller
From: Heiner Kallweit Date: Sun, 31 Mar 2019 15:43:59 +0200 > @@ -5456,12 +5448,6 @@ static void rtl_hw_start_8168(struct rtl8169_private > *tp) > { > RTL_W8(tp, MaxTxPacketSize, TxPacketMax); > > - tp->cp_cmd &= ~INTT_MASK; > - tp->cp_cmd |= PktCntrDisable | INTT_1; > - RTL

Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

2019-03-31 Thread David Miller
From: Heiner Kallweit Date: Sun, 31 Mar 2019 15:18:48 +0200 > Use netif_receive_skb_list() instead of napi_gro_receive() to benefit > from batched skb processing. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next 0/2] sctp: fully support memory accounting

2019-03-31 Thread David Miller
From: Xin Long Date: Sun, 31 Mar 2019 16:56:40 +0800 > Simple tests are as attached. Are these integratable into selftests somehow?

Re: [PATCH net-next 0/4] mlxsw: spectrum_acl: Get rid of failed_rollback mechanism

2019-03-31 Thread David Miller
From: Ido Schimmel Date: Sun, 31 Mar 2019 06:49:37 + > Jiri says: > > Currently if vregion rehash fails, it rolls back to the original ERP > set. However, in case of unlikely rollback fail, the vregion is in a > zombie state and never gets rehashed again. With the recent changes, it > is pos

[PATCH net-next 2/2] net: phy: deal properly with autoneg incomplete in genphy_c45_read_lpa

2019-03-31 Thread Heiner Kallweit
The link partner advertisement registers are not guaranteed to contain valid values if autoneg is incomplete. Therefore, if MDIO_AN_STAT1_COMPLETE isn't set, let's clear all link partner capability bits. This also avoids unnecessary register reads if link is down and phylib is in polling mode. Sig

[PATCH net-next 1/2] net: phy: use c45 standard to detect link partner autoneg capability

2019-03-31 Thread Heiner Kallweit
Currently mii_lpa_mod_linkmode_lpa_t() checks bit LPA_LPACK to detect whether link partner supports autoneg. This doesn't work correctly at least on Aquantia AQCS109 when it negotiates 1000Base-T2 mode. The "link partner is autoneg-capable" bit as defined by clause 45 is set however. Better let's s

[PATCH net-next 0/2] net: phy: improve genphy_c45_read_lpa

2019-03-31 Thread Heiner Kallweit
This series improves genphy_c45_read_lpa: - Use clause 45 standard register / bit to detect link partner autoneg capability. - Consider that lpa register values may be invalid if "autoneg complete" bit isn't set. Heiner Kallweit (2): net: phy: use c45 standard to detect link partner autoneg

[RFC net-next 2/2] net: sched: fq_pie: Flow Queue PIE AQM

2019-03-31 Thread Gautam Ramakrishnan
From: Mohit P. Tahiliani FQ-PIE incorporates fair/flow queuing in which every queue is managed by an instance of PIE queueing discipline. The algorithm provides good control over the queueing delay while at the same time, ensures fairness across various flows sharing the same link. Principles:

[RFC net-next 1/2] net: sched: pie: refactor PIE

2019-03-31 Thread Gautam Ramakrishnan
From: Mohit P. Tahiliani This patch refactors the code for the PIE qdisc. It breaks sch_pie.c down into 'sch_pie.c' and 'pie.h'. This enables the addition of qdiscs such as FQ-PIE that make use of the components of PIE. Signed-off-by: Mohit P. Tahiliani Signed-off-by: Sachin D. Patil Signed-of

[RFC net-next 0/2] net: sched: add Flow Queue PIE AQM

2019-03-31 Thread Gautam Ramakrishnan
Flow Queue PIE packet scheduler This patch series implements the Flow Queue Proportional Integral Controller (FQ-PIE) active queue management algorithm. It is an enhancement over the PIE algorithm. It integrates the PIE aqm with a deficit round robin scheme. It is implemented over RFC 8033 aligne

[PATCH mlx5-next 6/8] net/mlx5: Expose TIR ICM address in command outbox

2019-03-31 Thread Leon Romanovsky
From: Ariel Levkovich Adding the TIR ICM address to the create_tir command outbox through which the device reports the ICM address of the newly created TIR. The TIR address can be used for direct attachment to a steering rule in SW managed steering mode. Signed-off-by: Ariel Levkovich Reviewed

[PATCH rdma-next 8/8] IB/mlx5: Expose TIR ICM address to user space

2019-03-31 Thread Leon Romanovsky
From: Ariel Levkovich This patch exposes the TIR ICM address of raw packet and RSS QPs to user space. In order to pass the new field, the patch extends the mlx5 specific QP creation response structure and fills it with the icm address returned by the FW command, if available. Signed-off-by: Ari

[PATCH mlx5-next 1/8] net/mlx5: Expose SW ICM related device memory capabilities

2019-03-31 Thread Leon Romanovsky
From: Ariel Levkovich Add SW ICM related fields to the device memory capabilities structure and sw ownership capability in flow table properties. The currently supported SW ICM types are steering and header modify and the changes exposes the device memory capabilities for each of these two types

[PATCH rdma-next 3/8] IB/mlx5: Warn on allocated MEMIC buffers during cleanup

2019-03-31 Thread Leon Romanovsky
From: Ariel Levkovich Adding a warning on allocated MEMIC buffers that weren't freed prior to driver tear down. Signed-off-by: Ariel Levkovich Reviewed-by: Eli Cohen Reviewed-by: Mark Bloch Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 2 ++ 1 file changed, 2 insert

[PATCH rdma-next 4/8] IB/mlx5: Add steering SW ICM device memory type

2019-03-31 Thread Leon Romanovsky
From: Ariel Levkovich This patch adds support for allocating, deallocating and registering a new device memory type, STEERING_SW_ICM. This memory can be allocated and used by a privileged user for direct rule insertion and management of the device's steering tables. The type is provided by the u

[PATCH rdma-next 2/8] IB/mlx5: Support device memory type attribute

2019-03-31 Thread Leon Romanovsky
From: Ariel Levkovich This patch intoruduces a new mlx5_ib driver attribute to the DM allocation method - the DM type. In order to allow addition of new types in downstream patches this patch also refactors the allocation, deallocation and registration handlers to consider the requested type and

[PATCH mlx5-next 7/8] net/mlx5: Introduce new TIR creation core API

2019-03-31 Thread Leon Romanovsky
From: Ariel Levkovich Introducing new TIR creation core API which allows caller to receive back from the call the full command outbox. This comes as a preparation for the next patch that will retrieve the TIR ICM address from the command outbox. Signed-off-by: Ariel Levkovich Reviewed-by: Eli

[PATCH rdma-next 5/8] IB/mlx5: Device resource control for privileged DEVX user

2019-03-31 Thread Leon Romanovsky
From: Ariel Levkovich For DEVX users who have SYS_RAWIO capability, we set the internal device resources capability when creating the UCTX. This will allow the device to restrict the allocation of internal device resources such as SW ICM memory to privileged DEVX users only. Signed-off-by: Ariel

[PATCH rdma-next 0/8] User space steering

2019-03-31 Thread Leon Romanovsky
From: Leon Romanovsky >From Ariel, This series of patches adds user space managed steering infrastructure to the mlx5_ib driver. User space managed steering requires the means to access a dedicated memory space that is used by the device to store the packet steering and header modification tabl

[PATCH v2 net-next] net: phy: aquantia: add SGMII statistics

2019-03-31 Thread Heiner Kallweit
The AQR107 family has SGMII statistics counters. Let's expose them to ethtool. To interpret the counters correctly one has to be aware that rx on SGMII side is tx on ethernet side. The counters are populated by the chip in 100Mbps/1Gbps mode only. v2: - add constant AQR107_SGMII_STAT_SZ - add str

Re: [PATCH net-next] net: phy: improve genphy_read_status

2019-03-31 Thread Andrew Lunn
On Sun, Mar 31, 2019 at 04:59:13PM +0200, Heiner Kallweit wrote: > On 31.03.2019 16:52, Andrew Lunn wrote: > >> - if (AUTONEG_ENABLE == phydev->autoneg) { > >> + if (phydev->autoneg == AUTONEG_ENABLE && phydev->link) { > > > > Hi Heiner > > > > I don't necessary agree with placing the constant

Re: [PATCH net-next] net: phy: improve genphy_read_status

2019-03-31 Thread Heiner Kallweit
On 31.03.2019 16:58, Andrew Lunn wrote: >> - In auto-neg case, skip populating lp_advertising if we >> don't have a link. This avoids quite some unnecessary >> MDIO reads in case of phylib polling mode. > > Hi Heiner > > Could it be that we don't have a link because what the partner is > adve

Re: [PATCH net-next] net: phy: aquantia: add SGMII statistics

2019-03-31 Thread Heiner Kallweit
On 31.03.2019 16:45, Andrew Lunn wrote: >> +static u64 aqr107_get_stat(struct phy_device *phydev, int index) >> +{ >> +const struct aqr107_hw_stat *stat = aqr107_hw_stats + index; >> +int len_l = min(stat->size, 16); >> +int len_h = stat->size - len_l; >> +u64 ret; >> +int val;

Re: [PATCH net-next] net: phy: improve genphy_read_status

2019-03-31 Thread Heiner Kallweit
On 31.03.2019 16:52, Andrew Lunn wrote: >> -if (AUTONEG_ENABLE == phydev->autoneg) { >> +if (phydev->autoneg == AUTONEG_ENABLE && phydev->link) { > > Hi Heiner > > I don't necessary agree with placing the constant first in the > comparison, but it is best practice not to change it when ma

Re: [PATCH net-next] net: phy: improve genphy_read_status

2019-03-31 Thread Andrew Lunn
> - In auto-neg case, skip populating lp_advertising if we > don't have a link. This avoids quite some unnecessary > MDIO reads in case of phylib polling mode. Hi Heiner Could it be that we don't have a link because what the partner is advertising does not intersect with what we are advertisi

Re: [PATCH net-next] net: phy: improve genphy_read_status

2019-03-31 Thread Andrew Lunn
> - if (AUTONEG_ENABLE == phydev->autoneg) { > + if (phydev->autoneg == AUTONEG_ENABLE && phydev->link) { Hi Heiner I don't necessary agree with placing the constant first in the comparison, but it is best practice not to change it when making additions. It makes it a little bit harder to

Re: [PATCH net-next] net: phy: aquantia: add SGMII statistics

2019-03-31 Thread Andrew Lunn
> +static u64 aqr107_get_stat(struct phy_device *phydev, int index) > +{ > + const struct aqr107_hw_stat *stat = aqr107_hw_stats + index; > + int len_l = min(stat->size, 16); > + int len_h = stat->size - len_l; > + u64 ret; > + int val; > + > + val = phy_read_mmd(phydev, MDI

[PATCH net-next] r8169: disable tx interrupt coalescing on RTL8168

2019-03-31 Thread Heiner Kallweit
In contrast to switching rx irq coalescing off what fixed an issue, switching tx irq coalescing off is merely a latency optimization, therefore net-next. As part of this change: - Remove INTT_0 .. INTT_3 constants, they aren't used. - Remove comment in rtl_hw_start_8169(), we now have a detailed

[PATCH net-next] r8169: use netif_receive_skb_list batching

2019-03-31 Thread Heiner Kallweit
Use netif_receive_skb_list() instead of napi_gro_receive() to benefit from batched skb processing. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/e

How are you beautiful

2019-03-31 Thread Wesley
I guess you are having a lovely weekend.My name is Wesley,I know this may seem inappropriate so i ask for your forgiveness.I hope this email meet you in good health condition.I`m Sorry for intruding upon your privacy. I`m from the State .I am very cheerful, kind and positive man, and I am curre

[PATCH net-next] net: phy: aquantia: add SGMII statistics

2019-03-31 Thread Heiner Kallweit
The AQR107 family has SGMII statistics counters. Let's expose them to ethtool. To interpret the counters correctly one has to be aware that rx on SGMII side is tx on ethernet side. The counters are populated by the chip in 100Mbps/1Gbps mode only. Signed-off-by: Heiner Kallweit --- drivers/net/p

[PATCHv2 net-next] net: use rcu_dereference_protected to fetch sk_dst_cache in sk_destruct

2019-03-31 Thread Xin Long
As Eric noticed, in .sk_destruct, sk->sk_dst_cache update is prevented, and no barrier is needed for this. So change to use rcu_dereference_protected() instead of rcu_dereference_check() to fetch sk_dst_cache in there. v1->v2: - no change, repost after net-next is open. Reported-by: Eric Dumaze

[PATCH net] sctp: initialize _pad of sockaddr_in before copying to user memory

2019-03-31 Thread Xin Long
Syzbot report a kernel-infoleak: BUG: KMSAN: kernel-infoleak in _copy_to_user+0x16b/0x1f0 lib/usercopy.c:32 Call Trace: _copy_to_user+0x16b/0x1f0 lib/usercopy.c:32 copy_to_user include/linux/uaccess.h:174 [inline] sctp_getsockopt_peer_addrs net/sctp/socket.c:5911 [inline] sctp_

Re: [PATCH net-next 0/2] sctp: fully support memory accounting

2019-03-31 Thread Xin Long
Simple tests are as attached. On Sun, Mar 31, 2019 at 4:53 PM Xin Long wrote: > > sctp memory accounting is added in this patchset by using > these kernel APIs on send side: > > - sk_mem_charge() > - sk_mem_uncharge() > - sk_wmem_schedule() > - sk_under_memory_pressure() > - sk_mem_recl

[PATCH net-next 2/2] sctp: implement memory accounting on rx path

2019-03-31 Thread Xin Long
sk_forward_alloc's updating is also done on rx path, but to be consistent we change to use sk_mem_charge() in sctp_skb_set_owner_r(). In sctp_eat_data(), it's not enough to check sctp_memory_pressure only, which doesn't work for mem_cgroup_sockets_enabled, so we change to use sk_under_memory_press

[PATCH net-next 1/2] sctp: implement memory accounting on tx path

2019-03-31 Thread Xin Long
Now when sending packets, sk_mem_charge() and sk_mem_uncharge() have been used to set sk_forward_alloc. We just need to call sk_wmem_schedule() to check if the allocated should be raised, and call sk_mem_reclaim() to check if the allocated should be reduced when it's under memory pressure. If sk_w

[PATCH net-next 0/2] sctp: fully support memory accounting

2019-03-31 Thread Xin Long
sctp memory accounting is added in this patchset by using these kernel APIs on send side: - sk_mem_charge() - sk_mem_uncharge() - sk_wmem_schedule() - sk_under_memory_pressure() - sk_mem_reclaim() and these on receive side: - sk_mem_charge() - sk_mem_uncharge() - sk_rmem_schedule

Re: [patch net-next 00/12] net: expose switch ID via devlink

2019-03-31 Thread Jiri Pirko
Sat, Mar 30, 2019 at 08:49:23PM CET, jakub.kicin...@netronome.com wrote: >On Sat, 30 Mar 2019 08:35:27 +0100, Jiri Pirko wrote: >>> Is switchib doing forwarding? Not long ago Parav was convincing us >>> that switchdev mode for IB is pretty much meaningless. Even though >>> there are apparently re