Tue, Mar 12, 2019 at 09:56:28PM CET, jakub.kicin...@netronome.com wrote:
>On Tue, 12 Mar 2019 15:02:39 +0100, Jiri Pirko wrote:
>> Tue, Mar 12, 2019 at 03:10:54AM CET, wrote:
>> >On Mon, 11 Mar 2019 09:52:04 +0100, Jiri Pirko wrote:
>> >> Fri, Mar 08, 2019 at 08:09:43PM CET, wrote:
>> >> >If th
Hi Paul, Jake,
On Wed, Mar 13, 2019 at 3:08 AM Keller, Jacob E
wrote:
>
>
>
> > -Original Message-
> > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
> > Behalf Of Paul Thomas
> > Sent: Tuesday, March 12, 2019 1:05 PM
> > To: netdev@vger.kernel.org
> > Subject:
On Mon, Mar 11, 2019 at 3:16 AM Zhike Wang wrote:
>
> It is confusing to directly use return value of netlink_send()/
> netlink_unicast() as the return value of *notify*, as it may be not
> error at all.
>
> Example: in tc_del_tfilter(), after calling tfilter_del_notify(), it will
> goto errout if
Hi Paul, Jake,
On Wed, Mar 13, 2019 at 5:01 AM Paul Thomas wrote:
>
> On Tue, Mar 12, 2019 at 7:07 PM Keller, Jacob E
> wrote:
> >
> >
> >
> > > -Original Message-
> > > From: Paul Thomas [mailto:pthomas8...@gmail.com]
> > > Sent: Tuesday, March 12, 2019 3:05 PM
> > > To: Keller, Jacob E
On Fri, 2019-02-22 at 13:23 -0700, Jason Gunthorpe wrote:
> On Fri, Feb 22, 2019 at 08:13:58PM +, Ertman, David M wrote:
> > > From: Jason Gunthorpe [mailto:j...@ziepe.ca]
> > > Sent: Thursday, February 21, 2019 11:35 AM
> > > To: Saleem, Shiraz
> > > Cc: dledf...@redhat.com; da...@davemloft.n
Schönen Tag,
Sie benötigen einen echten Kredit online Ihre Rechnungen zu sichern?
Startet ein neues Unternehmen? Sie benötigen einen persönlichen Kredit
oder Business-Darlehen? Wir bieten ein Darlehen von € 10.000 bis €
500,000.000.00 mit 2% Zinsen pro Jahr und auch mit einem
erschwinglichen Rückz
On Tue, 12 Mar 2019 21:42:29 +0200
niko...@cumulusnetworks.com wrote:
> On 12 March 2019 21:33:48 EET, Stephen Hemminger
> wrote:
> >On Tue, 12 Mar 2019 18:41:27 +0200
> >Nikolay Aleksandrov wrote:
> >
> >I like it.
> >
> >> + print_u64(PRINT_ANY, "rx_v1", "RX: v1 %llu ",
> >
On Tue, Mar 12, 2019 at 7:07 PM Keller, Jacob E
wrote:
>
>
>
> > -Original Message-
> > From: Paul Thomas [mailto:pthomas8...@gmail.com]
> > Sent: Tuesday, March 12, 2019 3:05 PM
> > To: Keller, Jacob E
> > Cc: netdev@vger.kernel.org
> > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in m
On Tue, Mar 12, 2019 at 06:50:59PM +0100, Daniel Mack wrote:
> On 12/3/2019 1:27 PM, Heiko Stuebner wrote:
> > Hi Andrew, Heiner,
> >
> > Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn:
> >> On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote:
> >>> From: Heiner Kallweit
> >>>
Hey. wollte mich mal wieder bei dir melden.
https://macfuncriper1988.blogspot.ro/
> -Original Message-
> From: Paul Thomas [mailto:pthomas8...@gmail.com]
> Sent: Tuesday, March 12, 2019 3:05 PM
> To: Keller, Jacob E
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver
>
> Hi Jake, thanks for all the help and for looking at this
Hi Jake, thanks for all the help and for looking at this!
>
> You have two conditionals inside, and I misread where you were doing the
> checking of the SKBTX_HW_TSTAMP flag.
>
> I would do the following :
>
> if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HWTSTAMP) &&
> gem_ptp_do_txstamp(qu
From: Tariq Toukan
Date: Tue, 12 Mar 2019 17:05:46 +0200
> This patchset by Jack contains misc fixes to the mlx4 Core driver.
>
> Patch 1 fixes a use-after-free situation by marking (nullifying) the pointer,
> please queue for -stable >= v4.0.
> Patch 2 adds a missing lock acquire and release
From: Ido Schimmel
Date: Tue, 12 Mar 2019 08:40:40 +
> Patch #1 fixes the recently introduced QSFP thermal zones to correctly
> work with split ports, where several ports are mapped to the same
> module.
>
> Patch #2 initializes the base MAC in the minimal driver. The driver is
> using the b
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
> Behalf Of Keller, Jacob E
> Sent: Tuesday, March 12, 2019 2:35 PM
> To: Paul Thomas ; netdev@vger.kernel.org
> Subject: RE: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver
>
> > -Origi
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
> Behalf Of Paul Thomas
> Sent: Tuesday, March 12, 2019 1:05 PM
> To: netdev@vger.kernel.org
> Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver
>
> On Tue, Mar 12, 2019 at 3:51
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
> Behalf Of Paul Thomas
> Sent: Tuesday, March 12, 2019 12:51 PM
> To: netdev@vger.kernel.org
> Cc: Paul Thomas
> Subject: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver
>
> Make sure SKBT
After upgrading to 4.19.24, we are no longer experiencing these
general protection faults,
which is great, I looked through the commit log between the two
versions, but nothing
jumped out to me as a possible fix for this issue. If someone happens
to know which commit
fixed this issue, I would love
On 03/12/2019 09:52 PM, Daniel Borkmann wrote:
> On 03/12/2019 09:02 PM, Andrii Nakryiko wrote:
>> On Tue, Mar 12, 2019 at 12:44 PM Magnus Karlsson
>> wrote:
>>>
>>> On Tue, Mar 12, 2019 at 8:27 PM Andrii Nakryiko
>>> wrote:
On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson
wrote:
>
On 03/12/2019 06:21 AM, Yonghong Song wrote:
> The test_progs subtests, test_spin_lock() and test_map_lock(),
> requires BTF present to run successfully.
> Currently, when BTF failed to load, test_progs will segfault,
> $ ./test_progs
> ...
> 12: (bf) r1 = r8
> 13: (85) call bpf_spin_lock#9
On Tue, 12 Mar 2019 15:02:39 +0100, Jiri Pirko wrote:
> Tue, Mar 12, 2019 at 03:10:54AM CET, wrote:
> >On Mon, 11 Mar 2019 09:52:04 +0100, Jiri Pirko wrote:
> >> Fri, Mar 08, 2019 at 08:09:43PM CET, wrote:
> >> >If the switchport is in the hypervisor then only the hypervisor can
> >> >control s
On 03/12/2019 09:02 PM, Andrii Nakryiko wrote:
> On Tue, Mar 12, 2019 at 12:44 PM Magnus Karlsson
> wrote:
>>
>> On Tue, Mar 12, 2019 at 8:27 PM Andrii Nakryiko
>> wrote:
>>>
>>> On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson
>>> wrote:
In xsk_socket__create(), the libbpf_flags field
On Tue, Mar 12, 2019 at 3:51 PM Paul Thomas wrote:
>
> Make sure SKBTX_HW_TSTAMP (i.e. SOF_TIMESTAMPING_TX_HARDWARE) has been
> enabled for this skb
> This is a concept for discussion, more testing is needed.
> It does fix the issue where normal socks that aren't expecting a timestamp
> will not
On Tue, Mar 12, 2019 at 12:44 PM Magnus Karlsson
wrote:
>
> On Tue, Mar 12, 2019 at 8:27 PM Andrii Nakryiko
> wrote:
> >
> > On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson
> > wrote:
> > >
> > > In xsk_socket__create(), the libbpf_flags field was not checked for
> > > setting currently unused/u
Make sure SKBTX_HW_TSTAMP (i.e. SOF_TIMESTAMPING_TX_HARDWARE) has been enabled
for this skb
This is a concept for discussion, more testing is needed.
It does fix the issue where normal socks that aren't expecting a timestamp will
not wake
up on select.
---
drivers/net/ethernet/cadence/macb_main.
On Tue, Mar 12, 2019 at 8:27 PM Andrii Nakryiko
wrote:
>
> On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson
> wrote:
> >
> > In xsk_socket__create(), the libbpf_flags field was not checked for
> > setting currently unused/unknown flags. This patch fixes that by returning
> > -EINVAL if the user ha
On 12 March 2019 21:33:48 EET, Stephen Hemminger
wrote:
>On Tue, 12 Mar 2019 18:41:27 +0200
>Nikolay Aleksandrov wrote:
>
>I like it.
>
>> +print_u64(PRINT_ANY, "rx_v1", "RX: v1 %llu ",
>> + mstats->igmp_v1reports[BR_MCAST_DIR_RX]);
>> +
On Tue, 12 Mar 2019 18:41:27 +0200
Nikolay Aleksandrov wrote:
I like it.
> + print_u64(PRINT_ANY, "rx_v1", "RX: v1 %llu ",
> + mstats->igmp_v1reports[BR_MCAST_DIR_RX]);
> + print_u64(PRINT_ANY, "rx_v2", "v2 %llu ",
> +
On Tue, Mar 12, 2019 at 2:00 AM Magnus Karlsson
wrote:
>
> In xsk_socket__create(), the libbpf_flags field was not checked for
> setting currently unused/unknown flags. This patch fixes that by returning
> -EINVAL if the user has set any flag that is not in use at this point
> in time.
>
> Fixes:
On Wed, Mar 06, 2019 at 07:21:42PM +0200, Leon Romanovsky wrote:
> From: Yishai Hadas
>
> To prevent a hardware memory leak when a DEVX DCT object is destroyed
> without calling DRAIN DCT before, (e.g. under cleanup flow), need to
> manage its creation and destruction via mlx5 core.
>
> In that
On Wed, Mar 06, 2019 at 07:20:50PM +0200, Leon Romanovsky wrote:
> From: Yishai Hadas
>
> In case the DCT creation command has succeeded a DRAIN must be issued
> before calling DESTROY.
>
> In addition, the original code used the wrong parameter for the DESTROY
> command, 'in' instead of 'din',
On 12/3/2019 1:27 PM, Heiko Stuebner wrote:
> Hi Andrew, Heiner,
>
> Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn:
>> On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote:
>>> From: Heiner Kallweit
>>> Date: Sun, 3 Mar 2019 19:58:57 +0100
>>>
Currently the Phy driver's l
On 3/3/19 10:58 AM, Heiner Kallweit wrote:
> Currently the Phy driver's link_change_notify callback is called
> whenever the state machine is run (every second if polling), no matter
> whether the state changed or not. This isn't needed and may confuse
> users considering the name of the callback.
There is a patchwork instance behind bcm-kernel-feedback-list that is
helpful to track submissions, add this list for the Broadcom GENET and
SYSTEMPORT drivers.
Signed-off-by: Florian Fainelli
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3
This patch adds an example in using the new helper
bpf_get_listener_sock().
Signed-off-by: Martin KaFai Lau
---
tools/testing/selftests/bpf/bpf_helpers.h | 2 +
.../bpf/progs/test_sock_fields_kern.c | 88 +---
.../testing/selftests/bpf/test_sock_fields.c | 134 +++
Lorenz Bauer [thanks!] reported that a ptr returned by bpf_tcp_sock(sk)
can still be accessed after bpf_sk_release(sk).
Both bpf_tcp_sock() and bpf_sk_fullsock() have the same issue.
This patch addresses them together.
A simple reproducer looks like this:
sk = bpf_sk_lookup_tcp();
This set addresses issue about accessing invalid
ptr returned from bpf_tcp_sock() and bpf_sk_fullsock()
after bpf_sk_release().
v4:
- Tried the one "id" approach. It does not work well and the reason is in
the Patch 1 commit message.
- Rename refcount_id to ref_obj_id.
- With ref_obj_id, resett
Add a new helper "struct bpf_sock *bpf_get_listener_sock(struct bpf_sock *sk)"
which returns a bpf_sock in TCP_LISTEN state. It will trace back to
the listener sk from a request_sock if possible. It returns NULL
for all other cases.
No reference is taken because the helper ensures the sk is
in S
This patch sync the uapi bpf.h to tools/.
Signed-off-by: Martin KaFai Lau
---
tools/include/uapi/linux/bpf.h | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 3c38ac9a92a7..983b25cb608d 100644
---
Adding verifier tests to ensure the ptr returned from bpf_tcp_sock() and
bpf_sk_fullsock() cannot be accessed after bpf_sk_release() is called.
A few of the tests are derived from a reproducer test by Lorenz Bauer.
Signed-off-by: Martin KaFai Lau
---
.../selftests/bpf/verifier/ref_tracking.c
On Mon, Mar 11, 2019 at 11:03:10PM -0700, Brendan Gregg wrote:
> On Mon, Mar 11, 2019 at 8:24 PM Kris Van Hees
> wrote:
> >
> > On Mon, Mar 11, 2019 at 06:29:55PM -0700, Brendan Gregg wrote:
> > > On Mon, Mar 11, 2019 at 7:21 AM Kris Van Hees
> > > wrote:
> > > >
> > > > On Thu, Mar 07, 2019 at
Add bond and bond_slave xstats support with optional json output.
Example:
- Plain text:
$ ip link xstats type bond 802.3ad
bond0
LACPDU Rx 2017
LACPDU Tx 2038
LACPDU Unknown type Rx 0
LACPDU Illegal Rx 0
Hi,
This set adds json output support to the xstats API (patch 01) and then
adds json support to the bridge xstats output (patch 02) and adds xstats
output support (both plain text and json) for the bonding (patch 03).
It doesn't change the bridge's plain text output, but it fixes an
inconsistency
Add json support for bridge's xstats output.
The plain text output format should remain the same.
Note that this patch pulls the interface out of the attribute
loop, this was an oversight when the set was upstreamed. This does not
change the output format, but fixes it when new xstats attributes sh
This adds only initial object support if json argument is specified.
Later patches convert the current xstats users to json.
Signed-off-by: Nikolay Aleksandrov
---
ip/iplink_xstats.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ip/iplink_xstats.c b/ip/iplink_xstats.c
index 908d9228369f
On Tue, Mar 12, 2019 at 10:58:39PM +0800, Jason Yan wrote:
>
>
> On 2019/3/12 19:52, Greg KH wrote:
> > On Mon, Mar 11, 2019 at 05:18:33PM +0800, Jason Yan wrote:
> > > Hi, Daniel & Greg
> > >
> > > This patch (979d63d50c0c bpf: prevent out of bounds speculation on pointer
> > > arithmetic) was
Hi Dave,
This patchset by Jack contains misc fixes to the mlx4 Core driver.
Patch 1 fixes a use-after-free situation by marking (nullifying) the pointer,
please queue for -stable >= v4.0.
Patch 2 adds a missing lock acquire and release in SRIOV command interface,
please queue for -stable >= v
From: Jack Morgenstein
As part of unloading a device, the driver switches from
FW command event mode to FW command polling mode.
Part of switching over to polling mode is freeing the command context array
memory (unfortunately, currently, without NULLing the command context array
pointer).
The
From: Jack Morgenstein
In procedures mlx4_cmd_use_events() and mlx4_cmd_use_polling(), we need to
guarantee that there are no FW commands in progress on the comm channel
(for VFs) or wrapped FW commands (on the PF) when SRIOV is active.
We do this by also taking the slave_cmd_mutex when SRIOV is
From: Jack Morgenstein
Calculation of qp mtt size (in function mlx4_RST2INIT_wrapper)
ultimately depends on function roundup_pow_of_two.
If the amount of memory required by the QP is less than one page,
roundup_pow_of_two is called with argument zero. In this case, the
roundup_pow_of_two result
On 2019/3/12 19:52, Greg KH wrote:
On Mon, Mar 11, 2019 at 05:18:33PM +0800, Jason Yan wrote:
Hi, Daniel & Greg
This patch (979d63d50c0c bpf: prevent out of bounds speculation on pointer
arithmetic) was assigned a CVE (CVE-2019-7308) with a high score:
CVSS v3.0 Severity and Metrics:
Base S
Tue, Mar 12, 2019 at 03:10:54AM CET, jakub.kicin...@netronome.com wrote:
>On Mon, 11 Mar 2019 09:52:04 +0100, Jiri Pirko wrote:
>> Fri, Mar 08, 2019 at 08:09:43PM CET, jakub.kicin...@netronome.com wrote:
>> >If the switchport is in the hypervisor then only the hypervisor can
>> >control switching/f
Back in 2013 Hannes took care of most of such leaks in commit
bceaa90240b6 ("inet: prevent leakage of uninitialized memory to user in recv
syscalls")
But the bug in l2tp_ip6_recvmsg() has not been fixed.
syzbot report :
BUG: KMSAN: kernel-infoleak in _copy_to_user+0x16b/0x1f0 lib/usercopy.c:32
Hi Andrew, Heiner,
Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn:
> On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote:
> > From: Heiner Kallweit
> > Date: Sun, 3 Mar 2019 19:58:57 +0100
> >
> > > Currently the Phy driver's link_change_notify callback is called
> > > whenev
On Mon, Mar 11, 2019 at 05:18:33PM +0800, Jason Yan wrote:
> Hi, Daniel & Greg
>
> This patch (979d63d50c0c bpf: prevent out of bounds speculation on pointer
> arithmetic) was assigned a CVE (CVE-2019-7308) with a high score:
>
> CVSS v3.0 Severity and Metrics:
> Base Score: 9.8 CRITICAL
>
> And
Printing each devices PCI vendor and device ID has the advantage of
easily revealing what hardware we're dealing with exactly. It's no
longer necessary to match the PCI bus information to the lspci output.
Helps with bug reports where no lspci output is available.
Output before
i40e :08:00.0:
On Sat, Mar 9, 2019 at 1:22 AM Eric Dumazet wrote:
>
>
>
> On 03/08/2019 09:17 AM, Eric Dumazet wrote:
> >
> >
> > On 03/07/2019 11:25 PM, Xin Long wrote:
> >> sk_setup_caps() is called to set sk->sk_dst_cache in pptp_connect,
> >> so we have to dst_release(sk->sk_dst_cache) in pptp_sock_destruct,
On Sat, Mar 9, 2019 at 1:17 AM Eric Dumazet wrote:
>
>
>
> On 03/07/2019 11:25 PM, Xin Long wrote:
> > sk_setup_caps() is called to set sk->sk_dst_cache in pptp_connect,
> > so we have to dst_release(sk->sk_dst_cache) in pptp_sock_destruct,
> > otherwise, the dst refcnt will leak.
> >
> > It can b
In xsk_socket__create(), the libbpf_flags field was not checked for
setting currently unused/unknown flags. This patch fixes that by returning
-EINVAL if the user has set any flag that is not in use at this point
in time.
Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets")
Reviewe
Patch #1 fixes the recently introduced QSFP thermal zones to correctly
work with split ports, where several ports are mapped to the same
module.
Patch #2 initializes the base MAC in the minimal driver. The driver is
using the base MAC as its parent ID and without initializing it, it is
reported as
From: Vadim Pasternak
Verify during thermal initialization if QSFP module's entry is already
configured in order to prevent duplication.
Such scenario could happen in case two switch drivers (PCI and I2C
based) coexist and if after boot, splitting configuration is applied
for some ports and then
From: Jiri Pirko
Currently base_mac is not initialized which causes wrong reporting of
zeroed parent_id to userspace. Fix this by initializing base_mac
properly.
Fixes: c100e47caa8e ("mlxsw: minimal: Add ethtool support")
Signed-off-by: Jiri Pirko
Signed-off-by: Ido Schimmel
---
drivers/net/e
A previous fix ("tls: Fix write space handling") assumed that
user space application gets informed about the socket send buffer
availability when tls_push_sg() gets called. Inside tls_push_sg(), in
case do_tcp_sendpages() returns 0, the function returns without calling
ctx->sk_write_space. Further,
On 3/11/19 7:11 PM, Florian Fainelli wrote:
>> I continued bisecting and found a bad commit in the riotboard's phy
>> driver. I'll send a separate mail for this.
>>
>> | cd28d1d6e52e net: phy: at803x: Disable phy delay for RGMII mode
>
> If your problem is with this driver, keep in mind that the a
Hi Vakul,
On 3/12/2019 9:09 AM, Vakul Garg wrote:
> A previous fix ("tls: Fix write space handling") assumed that
> user space application gets informed about the socket send buffer
> availability when tls_push_sg() gets called. Inside tls_push_sg(), in
> case do_tcp_sendpages() returns 0, the fun
A previous fix ("tls: Fix write space handling") assumed that
user space application gets informed about the socket send buffer
availability when tls_push_sg() gets called. Inside tls_push_sg(), in
case do_tcp_sendpages() returns 0, the function returns without calling
ctx->sk_write_space. Further,
66 matches
Mail list logo
